From nobody Fri Sep 25 18:25:25 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10ECF58596B; Wed, 9 Sep 2026 16:42:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972126; cv=none; b=bgOhZ+IZFAqqssZSE/zbQ64znPqbKR/3D8BvHulmlp193wsk/KdYpjcKvccaulezDCW+usnYXHHN1eBWlj61SuaYK9plB7ENBlsW3VwSRQWYiw+I2PjoerdU3FAg6ZjmyPLVakSTJ4E1jCbEiIgP9KC2veA9/Zkh7GpjX+2X27A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972126; c=relaxed/simple; bh=Q6pDdgD77tRCU1gfJ0wVe+fYxWUkzGcUP5Av9NeMePE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OUCd8qNNGwCanvJAxzu0XLo1i+/lh9TyUgBu0FVPOR17gmEBxAHnRPVQ80hcqsPc4cK45L/6v2iFijziVYS7eg+hFI6hMLeF4fgorCjg7crjsfhInjmEzXNd2QHCnu+m+uzaRxEIv0D+ik8Lpq04ozLTsJj2+OvhkrC2QEbk04A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P9XxZjSA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P9XxZjSA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4D111F00893; Wed, 9 Sep 2026 16:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788972124; bh=FMw2HWQZ9hsyHLkoSdNcliDW51DS08OBnzT9klJKoh4=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=P9XxZjSAG7BO5GXu5sDY05MoKWqQwhylKChrrcysigqS/FwRisiRX/pVyr+icPk0J 7CJ77bLLiep/LK+yAPpV4JxlKhBZ9zlqXcoRPGqKnldEEyYHglyJnFnlEJau1liEoa qLe/SB6+Rg4lOHNDwoKMF83aZpRtU1vxD0aNSiIZuOGFjmBynCfFVwL9CqWOpaR8lj lL1jyzwcbT9BCZEksH+hLf77ZJJvDgQbD8c7b/t0tmLHWmNmVGVw6aM5FN2vVaTH4y yaBvW207NqjFjivMOEFurLOsJ55Zpd9WFCuivAecQgCkn/z/Mk7xbm2H89Q4SOOaL6 reZBgwdUZYdSQ== From: Konrad Dybcio Date: Wed, 09 Sep 2026 18:41:54 +0200 Subject: [PATCH 1/6] interconnect: qcom: Move bcm_div() to common code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260909-topic-icc_rpm_smd_qol-v1-1-6dc5b5e97626@oss.qualcomm.com> References: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> In-Reply-To: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> To: Georgi Djakov , Evan Green , Yassine Oudjana , Dmitry Baryshkov , Adam Skladowski Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788972117; l=3145; i=konrad.dybcio@oss.qualcomm.com; s=20230215; h=from:subject:message-id; bh=giFz0SPGWx5zhxrTw7l9Ho39cbePiTp1WQDdxwBTl3U=; b=JZfoPQxkrnMmL3h92ZJ11e16g7PQDiNYiq+KnVwG7j4ddIsO/BzwqdtXac97SZDzyolI3ZuJm wqrBifQY9bhDzEuSJpxXd9J8cWCtha7zcO2MAC27JclV1yx5L9UW7YO X-Developer-Key: i=konrad.dybcio@oss.qualcomm.com; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= From: Konrad Dybcio This helper is useful for both SMD_RPM and RPMH code, extract it. Assisted-by: LLM Signed-off-by: Konrad Dybcio Reviewed-by: Abel Vesa Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/bcm-voter.c | 21 +++++---------------- drivers/interconnect/qcom/icc-common.h | 9 +++++++++ 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/interconnect/qcom/bcm-voter.c b/drivers/interconnect/q= com/bcm-voter.c index a2d437a05a11..cdb0c5ee5cbc 100644 --- a/drivers/interconnect/qcom/bcm-voter.c +++ b/drivers/interconnect/qcom/bcm-voter.c @@ -3,7 +3,6 @@ * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved. */ =20 -#include #include #include #include @@ -14,6 +13,7 @@ #include =20 #include "bcm-voter.h" +#include "icc-common.h" #include "icc-rpmh.h" =20 static LIST_HEAD(bcm_voters); @@ -47,17 +47,6 @@ static int cmp_vcd(void *priv, const struct list_head *a= , const struct list_head return bcm_a->aux_data.vcd - bcm_b->aux_data.vcd; } =20 -static u64 bcm_div(u64 num, u32 base) -{ - /* Ensure that small votes aren't lost. */ - if (num && num < base) - return 1; - - do_div(num, base); - - return num; -} - /* BCMs with enable_mask use one-hot-encoding for on/off signaling */ static void bcm_aggregate_mask(struct qcom_icc_bcm *bcm) { @@ -99,20 +88,20 @@ static void bcm_aggregate(struct qcom_icc_bcm *bcm) for (bucket =3D 0; bucket < QCOM_ICC_NUM_BUCKETS; bucket++) { for (i =3D 0; i < bcm->num_nodes; i++) { node =3D bcm->nodes[i]; - temp =3D bcm_div(node->sum_avg[bucket] * bcm->aux_data.width, + temp =3D qcom_bw_div(node->sum_avg[bucket] * bcm->aux_data.width, node->buswidth * node->channels); agg_avg[bucket] =3D max(agg_avg[bucket], temp); =20 - temp =3D bcm_div(node->max_peak[bucket] * bcm->aux_data.width, + temp =3D qcom_bw_div(node->max_peak[bucket] * bcm->aux_data.width, node->buswidth); agg_peak[bucket] =3D max(agg_peak[bucket], temp); } =20 temp =3D agg_avg[bucket] * bcm->vote_scale; - bcm->vote_x[bucket] =3D bcm_div(temp, bcm->aux_data.unit); + bcm->vote_x[bucket] =3D qcom_bw_div(temp, bcm->aux_data.unit); =20 temp =3D agg_peak[bucket] * bcm->vote_scale; - bcm->vote_y[bucket] =3D bcm_div(temp, bcm->aux_data.unit); + bcm->vote_y[bucket] =3D qcom_bw_div(temp, bcm->aux_data.unit); } =20 if (bcm->keepalive && bcm->vote_x[QCOM_ICC_BUCKET_AMC] =3D=3D 0 && diff --git a/drivers/interconnect/qcom/icc-common.h b/drivers/interconnect/= qcom/icc-common.h index 21c39b163948..af4b5a6f30b7 100644 --- a/drivers/interconnect/qcom/icc-common.h +++ b/drivers/interconnect/qcom/icc-common.h @@ -7,6 +7,15 @@ #define __DRIVERS_INTERCONNECT_QCOM_ICC_COMMON_H__ =20 #include +#include + +static inline u64 qcom_bw_div(u64 num, u32 base) +{ + if (num && num < base) + return 1; + + return div_u64(num, base); +} =20 struct icc_node_data *qcom_icc_xlate_extended(const struct of_phandle_args= *spec, void *data); --=20 2.55.0 From nobody Fri Sep 25 18:25:25 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6624758599E; Wed, 9 Sep 2026 16:42:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972129; cv=none; b=Q9kHB+bOt2+XIS0o8YYfeg0qr1KxNhJwIhoaXPLJ7YkfsbrAdHomSTNtdNfI7P/t82g15HU1Eh7vZlcLLf7wBU5lcyctC4N3QTEwNON1T++8Hzbwrcx7v8NK4Mrd2c6wG2WEn/NJGguHxfQ1OebJSHQTxQ4DbKtxTpX46A9iqH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972129; c=relaxed/simple; bh=Saw9oQjpmCOPBdHQ24rWkzLed+yX8U8tzZwDqBe85/M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bu786EEiYGXyjttPb96SoxPfzzAkwUB6ZKwmV5BfOjQpuDHYWhMO8+Xb+qb8nH84KU94IZV9TP2IaVcOS12diTpZG3/QZxpoz1WZkFd+QDcHCkN0IOlCKNKmPkpIhkUw4TO9WJLSNpS8hcZca+kIDDfjpvpk0aw6RV9eWFuBhMQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fvIcVr0T; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fvIcVr0T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CED21F000FF; Wed, 9 Sep 2026 16:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788972127; bh=zMBvILJQ3rVZJDsl6gHMlJGk+imyYQUzgOFzEqMBpR8=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=fvIcVr0TGDx9TGuQlhENHAl+KExVig5fIpBzR5lLDvT5G21ByOmwy4GhZY2UB0KXi YfWsZ/VgoVMsFx5SA1IrVzHG5tELNtEDFyY2GwKI0GQfA6o5AI8Up1aju7/3Rzgrca P4nwcUVkKd1q26Pz+2r/QOrgi+FO+3/Q33OlxCIEn1o37CUlIT29Yd9T7Yjp3g+Hv5 VT/V7trcMAqFHkzhWuXbMDB90kdHbzrqsK0tPDJYa6PmwtSNPlDyVUdxfQ/sB14pX8 Ji7HvvdccwAuvpolRMmaK/IDs3OoY2+9lnTTSbDJRg7fw52iNbxGF2SlfXACY3qBs5 u+VVNt//2u82A== From: Konrad Dybcio Date: Wed, 09 Sep 2026 18:41:55 +0200 Subject: [PATCH 2/6] interconnect: qcom: icc-rpm: Don't skip small votes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260909-topic-icc_rpm_smd_qol-v1-2-6dc5b5e97626@oss.qualcomm.com> References: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> In-Reply-To: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> To: Georgi Djakov , Evan Green , Yassine Oudjana , Dmitry Baryshkov , Adam Skladowski Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788972117; l=1589; i=konrad.dybcio@oss.qualcomm.com; s=20230215; h=from:subject:message-id; bh=+u2BZarVZ/NIuhBagHU5zciFixnbmdImgYtKugL0Uwg=; b=L3xRCMSYg/Z5tqs88ZtXF+Uf5b09FH6481QkQ8SUPpBK8qiYHytZ6xWl8WQIOb5hr+hl6ABT9 HjbfV8v0ZHRAC3CRmxzd+Qr1qMoNirtp1TYATLwhT5IA61zKrAdM/gP X-Developer-Key: i=konrad.dybcio@oss.qualcomm.com; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= From: Konrad Dybcio Small votes (such as 1 or 100) can end up being rounded down to 0 midway through the calculations. Use qcom_bw_div() when dividing to prevent that. Assisted-by: LLM Fixes: 30c8fa3ec61a ("interconnect: qcom: Add MSM8916 interconnect provider= driver") Signed-off-by: Konrad Dybcio Reviewed-by: Abel Vesa Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/icc-rpm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qco= m/icc-rpm.c index ca4c8a944755..f571f002ccbd 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -298,25 +298,25 @@ static u64 qcom_icc_calc_rate(struct qcom_icc_provide= r *qp, struct qcom_icc_node u64 agg_avg_rate, agg_peak_rate, agg_rate; =20 if (qn->channels) - agg_avg_rate =3D div_u64(qn->sum_avg[ctx], qn->channels); + agg_avg_rate =3D qcom_bw_div(qn->sum_avg[ctx], qn->channels); else agg_avg_rate =3D qn->sum_avg[ctx]; =20 if (qn->ab_coeff) { agg_avg_rate =3D agg_avg_rate * qn->ab_coeff; - agg_avg_rate =3D div_u64(agg_avg_rate, 100); + agg_avg_rate =3D qcom_bw_div(agg_avg_rate, 100); } =20 if (qn->ib_coeff) { agg_peak_rate =3D qn->max_peak[ctx] * 100; - agg_peak_rate =3D div_u64(agg_peak_rate, qn->ib_coeff); + agg_peak_rate =3D qcom_bw_div(agg_peak_rate, qn->ib_coeff); } else { agg_peak_rate =3D qn->max_peak[ctx]; } =20 agg_rate =3D max_t(u64, agg_avg_rate, agg_peak_rate); =20 - return div_u64(agg_rate, qn->buswidth); + return qcom_bw_div(agg_rate, qn->buswidth); } =20 /** --=20 2.55.0 From nobody Fri Sep 25 18:25:25 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEC4D5867DB; Wed, 9 Sep 2026 16:42:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972132; cv=none; b=IaOWY2OXZAEwig6xoke3zAorkzZOga6aywGIB627LmmrP8j84PoSHpOJ63AYmnhd81P+R+0K8+BJQmH81FhdX5EvKwUFTHIFBsxGVJ4e8CrnCf8FR7usl0NeqkSv+KZ1xajc456C7Dd9q1vX6yNkdP4oh3mAPh0YAeDbI3vPvj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972132; c=relaxed/simple; bh=ykZnuLH4pAqPrbYh9fFWACOZE8tDWlV4LwIVPGYI+PU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hes2ZAShu4JeEGKinmBY0dsrSVfiMs+hpvNAPpqol0oaZ77GCtpa8Gb2c+SOKu3vvrHQi9bYuoWGMensKGkcUi1EUkZuOzIST4DloHJ2yBSX2KLEzsf5ZTWEqQjKqPE4P78F4RVI/qKAdw388MTKppx/KVF7unFVs7p8ssxk+2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hFKi8GtO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hFKi8GtO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B1651F00893; Wed, 9 Sep 2026 16:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788972131; bh=y8PoVu8aSaRIRZxFbqhcwKB7XCs+xPUwp92Rj5i/PSs=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=hFKi8GtORl7/9IIRUQZNuuDejhNEdmpZdqCvj//1vF1Q4N0OIUQgLfa4hUc0TjAq9 RjlnkyMf2TO8b7EMIE1jYujaZXE8yCtoTbUAixh+bQuXStEb3zbZUqb+SPc31HFKwM 9ZoxMezImWVKMhqss8bhdXmSzIfoW0cvd0y5p0RP89v3dJ2DIHQ1rbL+jyleSwG9Z8 h60mT6Fp/QKCf8R6RxDlajkXdXMT2jqwrPRtUAs5WStw7QAkNb11sQIM8tC+Ymfu// 1+mcUmmiUXdONslqdAFHV06oa4rwjGqvEoBuFVzaERZ5L/O/UfE+OQGyPsMv2BTGYB 71OQfub/PwqTg== From: Konrad Dybcio Date: Wed, 09 Sep 2026 18:41:56 +0200 Subject: [PATCH 3/6] interconnect: qcom: icc-rpm: Handle icc_link_create() failures Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260909-topic-icc_rpm_smd_qol-v1-3-6dc5b5e97626@oss.qualcomm.com> References: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> In-Reply-To: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> To: Georgi Djakov , Evan Green , Yassine Oudjana , Dmitry Baryshkov , Adam Skladowski Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788972117; l=1186; i=konrad.dybcio@oss.qualcomm.com; s=20230215; h=from:subject:message-id; bh=4OietwpgRaB7dskRwb1aHQydl/vmwBVTXw0RtqdsnJo=; b=XF29T/95lJH5Jf0v1GctPJs9Stbn/UbL5lMyCbHooc1o2RXXd/f3QPVYaykSoQYd8g/4h105w efBZIQu6RFmBG7jQvV8jJ4CJ8bnbnuqpzsl3qbUVYSXvxJTR1nMeJ/7 X-Developer-Key: i=konrad.dybcio@oss.qualcomm.com; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= From: Konrad Dybcio icc_link_create() can return errors. Don't ignore them. Assisted-by: LLM Fixes: 30c8fa3ec61a ("interconnect: qcom: Add MSM8916 interconnect provider= driver") Signed-off-by: Konrad Dybcio Reviewed-by: Abel Vesa Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/icc-rpm.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qco= m/icc-rpm.c index f571f002ccbd..5d8a41aede8b 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -583,8 +583,15 @@ int qnoc_probe(struct platform_device *pdev) node->data =3D qnodes[i]; icc_node_add(node, provider); =20 - for (j =3D 0; j < qnodes[i]->num_links; j++) - icc_link_create(node, qnodes[i]->links[j]); + for (j =3D 0; j < qnodes[i]->num_links; j++) { + ret =3D icc_link_create(node, qnodes[i]->links[j]); + if (ret) { + icc_nodes_remove(provider); + clk_bulk_disable_unprepare(qp->num_intf_clks, + qp->intf_clks); + goto err_disable_unprepare_clk; + } + } =20 /* Set QoS registers (we only need to do it once, generally) */ if (qnodes[i]->qos.ap_owned && --=20 2.55.0 From nobody Fri Sep 25 18:25:25 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74FE4584976; Wed, 9 Sep 2026 16:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972136; cv=none; b=Gr95q149cxzEkVkAkQh/lar4wMT6DBqMiq5k3VgJNFuXOpoUqOHaxQGA/2IzonntTqnwdKoXet0pdI8iIJ1yWCjvjtL9LP6n/c8OK0vBY6TqRvhj3rFJM7Z2z+I5cI4StNdguRocU3WHSGjoC1qfNsysNlC80I/J535YVE1/Mj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972136; c=relaxed/simple; bh=/0zV8N7lQohFEH4TlzqI2MqZumggig0DqWnbPCuoOgo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jf8S7nnoSPLHAeKL9Go48xL/t7EDD/ebeaGfq9EXXoWzV8ZfGJNqp4M0bcXkQIYW0bAB/p7N0O43I0uZ11BjOSbBChw1CXpB0dLe47wpZ3DS7ytjM56pTnMAR07c6m+cKGTC8pv7e7qm88gmiH7WwFe475qRxGtQPDafPSg90Lo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FTR2jEAN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FTR2jEAN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2CCE1F000FF; Wed, 9 Sep 2026 16:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788972135; bh=X9Pd/JkpLhUpbD72eUNsvv3WYWheEMYgKw1lsSWodok=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=FTR2jEANivVddM6pKhnITyWhdU+KEWz2qpEkmTIuFobQyLOIs87D7M/3bURTT98C1 ayPBDbSe3Y8CqjiwwRWnAOqcIcopMmPs+71PYkm9JSDUG4Tg4wAf3+nk1d/M578fqN uX5sTL0iv3YL9aYqi8G5+CC7aTuxw0VJ+n9E1xFP1YCw3rEFGiTvxybZcxZlIsQ0op 9kMgzr4RuO0bzc2lcjMGciDDL5Gl1fNK49hQN1exucjhNY2/kJUesXLbVtlVIImIZk 71pJx0AUbLU6Hq5/xdP9rND6zS94q/d/JbaX6wZy8+UK6em3GhzO7s3r0xjc4H+PxC /RfFh6R5BAlug== From: Konrad Dybcio Date: Wed, 09 Sep 2026 18:41:57 +0200 Subject: [PATCH 4/6] interconnect: qcom: icc-rpm: Program SMD RPM auxiliary QoS ports Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260909-topic-icc_rpm_smd_qol-v1-4-6dc5b5e97626@oss.qualcomm.com> References: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> In-Reply-To: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> To: Georgi Djakov , Evan Green , Yassine Oudjana , Dmitry Baryshkov , Adam Skladowski Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788972117; l=5986; i=konrad.dybcio@oss.qualcomm.com; s=20230215; h=from:subject:message-id; bh=PJtITCcTYAwrwu9dCo2vAeW7z8YzVv9vbyU6MwKXoqI=; b=qL2bBMdMTJj7GCyB8UgtqfK8v8n9cU0BPJur0DYn3/3arJt2SxpyWq/ICENui+eD6YNY1Z9Ux RdbNdXplZwbCyeJG4vRATQ6IGMvFB0Lx2M9FfYE0QhbS/2c54STE+9S X-Developer-Key: i=konrad.dybcio@oss.qualcomm.com; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= From: Konrad Dybcio Some SMD RPM interconnect nodes own two QoS ports. Currently, the code only takes care of one, leaving some endpoints partially unconfigured. Keep qos_port as the primary port and describe the optional second port with aux_qos_port. Assisted-by: LLM Signed-off-by: Konrad Dybcio Reviewed-by: Abel Vesa Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/icc-rpm.c | 82 ++++++++++++++++++++++++++++++++-= ---- drivers/interconnect/qcom/icc-rpm.h | 2 + 2 files changed, 73 insertions(+), 11 deletions(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qco= m/icc-rpm.c index 5d8a41aede8b..12387de98318 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -58,15 +58,32 @@ static int qcom_icc_set_qnoc_qos(struct icc_node *src) struct qcom_icc_qos *qos =3D &qn->qos; int rc; =20 + rc =3D regmap_update_bits(qp->regmap, + qp->qos_offset + QNOC_QOS_MCTL_LOWn_ADDR(qos->qos_port), + QNOC_QOS_MCTL_DFLT_PRIO_MASK, + qos->areq_prio << QNOC_QOS_MCTL_DFLT_PRIO_SHIFT); + if (rc) + return rc; + rc =3D regmap_update_bits(qp->regmap, qp->qos_offset + QNOC_QOS_MCTL_LOWn_ADDR(qos->qos_port), - QNOC_QOS_MCTL_DFLT_PRIO_MASK, - qos->areq_prio << QNOC_QOS_MCTL_DFLT_PRIO_SHIFT); + QNOC_QOS_MCTL_URGFWD_EN_MASK, + !!qos->urg_fwd_en << QNOC_QOS_MCTL_URGFWD_EN_SHIFT); + if (rc) + return rc; + + if (!qos->aux_qos_port) + return 0; + + rc =3D regmap_update_bits(qp->regmap, + qp->qos_offset + QNOC_QOS_MCTL_LOWn_ADDR(qos->aux_qos_port), + QNOC_QOS_MCTL_DFLT_PRIO_MASK, + qos->areq_prio << QNOC_QOS_MCTL_DFLT_PRIO_SHIFT); if (rc) return rc; =20 return regmap_update_bits(qp->regmap, - qp->qos_offset + QNOC_QOS_MCTL_LOWn_ADDR(qos->qos_port), + qp->qos_offset + QNOC_QOS_MCTL_LOWn_ADDR(qos->aux_qos_port), QNOC_QOS_MCTL_URGFWD_EN_MASK, !!qos->urg_fwd_en << QNOC_QOS_MCTL_URGFWD_EN_SHIFT); } @@ -75,8 +92,9 @@ static int qcom_icc_bimc_set_qos_health(struct qcom_icc_p= rovider *qp, struct qcom_icc_qos *qos, int regnum) { - u32 val; u32 mask; + u32 val; + int ret; =20 val =3D qos->prio_level; mask =3D M_BKE_HEALTH_CFG_PRIOLVL_MASK; @@ -90,8 +108,17 @@ static int qcom_icc_bimc_set_qos_health(struct qcom_icc= _provider *qp, mask |=3D M_BKE_HEALTH_CFG_LIMITCMDS_MASK; } =20 + ret =3D regmap_update_bits(qp->regmap, + qp->qos_offset + M_BKE_HEALTH_CFG_ADDR(regnum, qos->qos_port), + mask, val); + if (ret) + return ret; + + if (!qos->aux_qos_port) + return 0; + return regmap_update_bits(qp->regmap, - qp->qos_offset + M_BKE_HEALTH_CFG_ADDR(regnum, qos->qos_port), + qp->qos_offset + M_BKE_HEALTH_CFG_ADDR(regnum, qos->aux_qos_port), mask, val); } =20 @@ -102,7 +129,7 @@ static int qcom_icc_set_bimc_qos(struct icc_node *src) struct icc_provider *provider; u32 mode =3D NOC_QOS_MODE_BYPASS; u32 val =3D 0; - int i, rc =3D 0; + int i, rc; =20 qn =3D src->data; provider =3D src->provider; @@ -116,8 +143,7 @@ static int qcom_icc_set_bimc_qos(struct icc_node *src) */ if (mode !=3D NOC_QOS_MODE_BYPASS) { for (i =3D 3; i >=3D 0; i--) { - rc =3D qcom_icc_bimc_set_qos_health(qp, - &qn->qos, i); + rc =3D qcom_icc_bimc_set_qos_health(qp, &qn->qos, i); if (rc) return rc; } @@ -126,8 +152,17 @@ static int qcom_icc_set_bimc_qos(struct icc_node *src) val =3D 1; } =20 + rc =3D regmap_update_bits(qp->regmap, + qp->qos_offset + M_BKE_EN_ADDR(qn->qos.qos_port), + M_BKE_EN_EN_BMASK, val); + if (rc) + return rc; + + if (!qn->qos.aux_qos_port) + return 0; + return regmap_update_bits(qp->regmap, - qp->qos_offset + M_BKE_EN_ADDR(qn->qos.qos_port), + qp->qos_offset + M_BKE_EN_ADDR(qn->qos.aux_qos_port), M_BKE_EN_EN_BMASK, val); } =20 @@ -145,9 +180,25 @@ static int qcom_icc_noc_set_qos_priority(struct qcom_i= cc_provider *qp, if (rc) return rc; =20 - return regmap_update_bits(qp->regmap, + rc =3D regmap_update_bits(qp->regmap, qp->qos_offset + NOC_QOS_PRIORITYn_ADDR(qos->qos_port), NOC_QOS_PRIORITY_P0_MASK, qos->prio_level); + if (rc) + return rc; + + if (!qos->aux_qos_port) + return 0; + + val =3D qos->areq_prio << NOC_QOS_PRIORITY_P1_SHIFT; + rc =3D regmap_update_bits(qp->regmap, + qp->qos_offset + NOC_QOS_PRIORITYn_ADDR(qos->aux_qos_port), + NOC_QOS_PRIORITY_P1_MASK, val); + if (rc) + return rc; + + return regmap_update_bits(qp->regmap, + qp->qos_offset + NOC_QOS_PRIORITYn_ADDR(qos->aux_qos_port), + NOC_QOS_PRIORITY_P0_MASK, qos->prio_level); } =20 static int qcom_icc_set_noc_qos(struct icc_node *src) @@ -182,9 +233,18 @@ static int qcom_icc_set_noc_qos(struct icc_node *src) /* How did we get here? */ } =20 - return regmap_update_bits(qp->regmap, + rc =3D regmap_update_bits(qp->regmap, qp->qos_offset + NOC_QOS_MODEn_ADDR(qn->qos.qos_port), NOC_QOS_MODEn_MASK, mode); + if (rc) + return rc; + + if (!qn->qos.aux_qos_port) + return 0; + + return regmap_update_bits(qp->regmap, + qp->qos_offset + NOC_QOS_MODEn_ADDR(qn->qos.aux_qos_port), + NOC_QOS_MODEn_MASK, mode); } =20 static int qcom_icc_qos_set(struct icc_node *node) diff --git a/drivers/interconnect/qcom/icc-rpm.h b/drivers/interconnect/qco= m/icc-rpm.h index cdd5f444b152..e36c378a80a3 100644 --- a/drivers/interconnect/qcom/icc-rpm.h +++ b/drivers/interconnect/qcom/icc-rpm.h @@ -77,6 +77,7 @@ struct qcom_icc_provider { * @ap_owned: indicates if the node is owned by the AP or by the RPM * @qos_mode: default qos mode for this node * @qos_port: qos port number for finding qos registers of this node + * @aux_qos_port: optional QoS port in addition to @qos_port. Zero means "= none". * @urg_fwd_en: enable urgent forwarding */ struct qcom_icc_qos { @@ -86,6 +87,7 @@ struct qcom_icc_qos { bool ap_owned; int qos_mode; int qos_port; + u16 aux_qos_port; bool urg_fwd_en; }; =20 --=20 2.55.0 From nobody Fri Sep 25 18:25:25 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0A68585968; Wed, 9 Sep 2026 16:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972140; cv=none; b=qLrRDrqjIl/pEHRB1sYkY+eipqnLkst5JrAMjOVelRuV/TUY0OuG9I36yqHqX7sAtX3+Xu5FzM/HAsyBjjYhxFmX9CMD3VG5j1sEPaOeVvOmsh5d7NLVK25iQQQHvxU8MTV/ytRFPHdcIWxCg4c6srEo9ocGfBmsGk5T9aN7qLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972140; c=relaxed/simple; bh=colMcQhGsvUQisGiDdEb/913gMwPxUjx5UfOhyIWaf8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SGm4t54UsW0pkREi4/Jo4P0H7otZYVUwSqststpBCXAZYNfRhwoigdZLMtuGKOhVDh/ocOw0KC4s7tD8/RO5wlZCNAgReZLGLksLkmXBLn0Bi5j1A2SjIYB3wf573ZITelgNnhWTLsn1JrGT4W5pszUSNGCXcyGUEbjLLC/nQME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Yve1qiA7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Yve1qiA7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A331D1F00893; Wed, 9 Sep 2026 16:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788972138; bh=c1NSwFJOt9Rq2u8EI/PLslmEct20Up/KRVRlPxjXiKk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Yve1qiA7LG5Ihw/gOqT4z2ciYs92iX0yOA6SryZD4DU/+TMbynqCZB1GU4jy7K5tB n+30at+j3gG6niot2nZMXDnAGqhR9ru1r0ZE4CU6C8w1g5IJxj6Nst+Cvc5EIb8RbD xy/Oqg3y5rxlPeASfidiBKvI55q6tbx9GWoSCJj0anSKe7qsKcL69sAy5TnFJc3ATS 9bH5MVZ0U7t4UWf8U+JBV9OQEn9eh0JWzJQQRdKThKI5qm06THmXN1LTPxv4NcT4/Q wIToUZC7z/Egv9FYBF5pD/PEJesaPoiMW/jkeRH10D8nZolKe98lb7sVgnCeGQ4y28 GULnWBJ/bQc8A== From: Konrad Dybcio Date: Wed, 09 Sep 2026 18:41:58 +0200 Subject: [PATCH 5/6] interconnect: qcom: msm8996: Configure auxiliary Venus QoS port Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260909-topic-icc_rpm_smd_qol-v1-5-6dc5b5e97626@oss.qualcomm.com> References: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> In-Reply-To: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> To: Georgi Djakov , Evan Green , Yassine Oudjana , Dmitry Baryshkov , Adam Skladowski Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788972117; l=804; i=konrad.dybcio@oss.qualcomm.com; s=20230215; h=from:subject:message-id; bh=Guepwd0CuDGgMGInIQXUtcEqVLXI53hk28wMJtQhEmg=; b=oE23CWNECwenZQkhuE1thx8PUG1xcD8ukKLTg08xNr3d03QEoY0QwBeNuf3H/+DOcoBN0cCL5 2T2J2fA5LI6BiCKxndVOKHT38G19ftovBzXEmKXlzIyfqnauHnSNS+w X-Developer-Key: i=konrad.dybcio@oss.qualcomm.com; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= From: Konrad Dybcio Enable the secondary QoS port used by the MSM8996 Venus node. Assisted-by: LLM Fixes: 7add937f5222 ("interconnect: qcom: Add MSM8996 interconnect provider= driver") Signed-off-by: Konrad Dybcio Reviewed-by: Abel Vesa Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/msm8996.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/interconnect/qcom/msm8996.c b/drivers/interconnect/qco= m/msm8996.c index 882f9d2b6d4e..7fc808cc5975 100644 --- a/drivers/interconnect/qcom/msm8996.c +++ b/drivers/interconnect/qcom/msm8996.c @@ -501,6 +501,7 @@ static struct qcom_icc_node mas_venus =3D { .qos.areq_prio =3D 0, .qos.prio_level =3D 0, .qos.qos_port =3D 3, + .qos.aux_qos_port =3D 4, .num_links =3D ARRAY_SIZE(mas_mnoc_bimc_common_links), .links =3D mas_mnoc_bimc_common_links }; --=20 2.55.0 From nobody Fri Sep 25 18:25:25 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B17F58B6D5; Wed, 9 Sep 2026 16:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972143; cv=none; b=jnIAw0i641Xa5gPEJoTcM2kDZKOYfvGL/ZE2FvBlB74B4gRy0JpTZQpFl9y3XJjZTBZ/jdxoWEvugMuzaPeNJccW+CQuk0XTJv3P0y1yE4FBrURvlXF2Jn/FG1YBdm9G5f6lBS+zZMIvaRf9LuT5W5ndFbkQ23kBz0gbp9drQ2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788972143; c=relaxed/simple; bh=wYQCFXqH48ZLFdhzjjRSCUFa3Q0kbFjcEF+eC1LeN2c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EDGUJj9yR+Wp2Z8/MzMj26w7kwIyDv7Bir1F0+Ea63E8pmRxK9fzvN4hSAy1GhCcB1mjINMZE94XC/fj6bp3wCx4TLYj8SohIF9J/ndnZIjqgCRhCSB/toYCoEtKhRBZ5+xFf4YCQDUw02LB97RSHA44Bj8Q3CXFi7cW/Yid0ek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nje1edKf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nje1edKf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D78B1F000FF; Wed, 9 Sep 2026 16:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788972142; bh=ConfJibyxipxTH9JVW04JGxe7tLVOw+GS9d3RJCp3z0=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Nje1edKfQrxAnX8meZD1tIM8SYtYREz33T/hgww+bcnjJysSDKA0qdDgXj+dNAwla YuLx6ht2XIZ8pqTQc2DHx/pWPFOBwySHfhdPzj5WF/fGXHGnzwFKFb5jSUmiKRvOY/ 0zKEsMxHIR3H5uMmpw5sz4xjCzgU2GJPyRudkUKmHx3uFbrpJNu8XDpfi20+kYHcx6 SAO7BJ3khWcEmk0dlmMDzGRqEC+Am0b3W8swbJpPecgrVW+Nf+DrkLU9WQ01/7hKfw f+nVDCQuNVjHuzYslSZz4SHd2NGT+GDCTMRl8wq6++vC5haHSphqFCxprgRh4KK8PD b5s7tW53uk4fA== From: Konrad Dybcio Date: Wed, 09 Sep 2026 18:41:59 +0200 Subject: [PATCH 6/6] interconnect: qcom: msm8976: Configure auxiliary GPU QoS port Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260909-topic-icc_rpm_smd_qol-v1-6-6dc5b5e97626@oss.qualcomm.com> References: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> In-Reply-To: <20260909-topic-icc_rpm_smd_qol-v1-0-6dc5b5e97626@oss.qualcomm.com> To: Georgi Djakov , Evan Green , Yassine Oudjana , Dmitry Baryshkov , Adam Skladowski Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788972117; l=879; i=konrad.dybcio@oss.qualcomm.com; s=20230215; h=from:subject:message-id; bh=JkfBWEaftj2Y4hKi9rFBS8295BraOyAd/v0v8sIgbws=; b=1nlIlWTvlYZrhspew3MvBoAmy1Xd6lpJHvhSfpHKtZ7nBrTt5q51XeJeKEzsTHsIEBmZSxJYw VkG18S5QDhZAh2y+aDUiWljU+Z9e6ZfmLPMCm716iYGydKN+Hk7m5cw X-Developer-Key: i=konrad.dybcio@oss.qualcomm.com; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= From: Konrad Dybcio Enable the secondary QoS port used by the MSM8976 GPU node. Assisted-by: LLM Fixes: 6e3ea1f36b10 ("interconnect: qcom: Add MSM8976 interconnect provider= driver") Signed-off-by: Konrad Dybcio Reviewed-by: Abel Vesa Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/msm8976.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/interconnect/qcom/msm8976.c b/drivers/interconnect/qco= m/msm8976.c index c219dcfd43b6..11100264ef69 100644 --- a/drivers/interconnect/qcom/msm8976.c +++ b/drivers/interconnect/qcom/msm8976.c @@ -454,7 +454,8 @@ static struct qcom_icc_node mas_oxili =3D { .qos.qos_mode =3D NOC_QOS_MODE_BYPASS, .qos.areq_prio =3D 0, .qos.prio_level =3D 0, - .qos.qos_port =3D 16, /* [16, 17] */ + .qos.qos_port =3D 16, + .qos.aux_qos_port =3D 17, .num_links =3D ARRAY_SIZE(mas_oxili_links), .links =3D mas_oxili_links, }; --=20 2.55.0