From nobody Fri Sep 25 20:47:25 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F34EE57D236 for ; Tue, 8 Sep 2026 17:24:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888292; cv=none; b=V7jU8eInr+/Y2AADgZgJrpRi/agnHzQhYwVaeXWlznZ16c6ZJKzuoIpNqtJhW253nCl/MJqSJH4x0r5XbUC1xgDBBhGR32T1joq2cIUlR/BuTd/DywaqVqGMbO+zNSmenESFJ/WnJ7ZPgAHGO3pJ7qZ4yQiqjePIkgUASFJkwxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888292; c=relaxed/simple; bh=bgK+DZod7mmJgogZgW1zioKzetKNGqoKIW9z56Vpb+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RyGa7UcgHP8M/wCfGGe+hhd6GhI/H9J7+qqYk/V/iH8J/uSMOQZbnv+yFhxXb3IdPmuqp6y0Xztlzx+V1V91IRhM8nzcprxNnPsOdirVbyYgtNvBr9z/EDHcgHgCQdr1OCWg+w//jWvgjzU33d6/bnebrQySoqQMNwybG/lAN/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DS0AYKoM; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DS0AYKoM" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc1cebad4afso144224a12.0 for ; Tue, 08 Sep 2026 10:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788888290; x=1789493090; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H2F/5Rn1z2wIFmLqiH74YcGVKvaBMa7CAe2jvYLlnR4=; b=DS0AYKoM/XtIzmvoogEW2zPP8mMC3wPBLkyPVMi+EpTzxEmkY07j/GxQqBkJH3Wrhf 461MUClpHWrUrOEzHuxY8VloGRupqkIxwhXEbAYIPk6aAaJZhsdN2zC4fvT9b1+xn2N8 N7+8HHVfBzSWXzokmylQUzsUQoK/gXx68STjdMqHefquti4KNAlq8qq8pZUyMGegMA1z JKZ5kscvnHSX1ErGw/EeXapdgTTCjkRYsXLgvG/iI+OHUEnG8QWNEE8wMiKLcfgfWaJh 9ny+Km/KW0Ahfl64+8+3isN6y//jGg+OQZ2Vk+AEF2eUuwrFP+ZLBifHEfGHlXKuNhCV bI9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788888290; x=1789493090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H2F/5Rn1z2wIFmLqiH74YcGVKvaBMa7CAe2jvYLlnR4=; b=jYQ+9U5aM1ulQiyouEeD53DrDejSt6hoxmTexO+2Jk0mDIeWBvBJrMQ8+4eWhU/LLD irChr+nw/E3+s63TdMTPLElTcVU9+ZPLyt2oRA5UAQADooguEhhOMU0OJMeXn8+IiamW HXIU5mD26YI0rmPtkKncf0Ha+ZhqBfivEzLCjFpEX1rS95Yn2sjN8qia+5tbSWz3Mu0K BLR/nIu1Ak1oKi0ukY6GF0trhKuypayvwFLubRYHYx6Tc5L79uayXPp0Gg+GfohoOVTO pMewhXQB1WD3IWhKFUfgdmchofGhC+vgWcajh8ueEf0nPLgaxK7oMB6e1Nwd9U9XvzFb mmWQ== X-Forwarded-Encrypted: i=1; AKwUvBw7/L8n9wVa+M+5lbtxfQiOX914+vvaOgTiXLFt95f9XedU31OlT7VOKYubceOED732EVK4t/9fS3J7rrA=@vger.kernel.org X-Gm-Message-State: AFuF++k4w6lytgz8BkJGtu0YrOXcup1EPUEU7UQWCbktncRSwmP79If9 b42s9LzR5By2SeFq342nzYztYRMa4/z4YMEO3h22u36Qqzc6t0+7xm0f X-Gm-Gg: AYBFou2mkhZXzQxCoAASOI6TTV6jfqQbdkw4FwAlo3YoWG+T59fgjt/M8IwuR1DxfLp OVaKXb1K5eZUnCT2mhq0pPYp9VONXqTa8R0kdvXVQj4ya4KAXSg12uLyEM7J/RSgENxRGSiu11Y +4WTAVOn562i/PU2puAUsP6DEYULrlih+Jd0vdFbjMvVMvGQGnTj6VL+WWWYRwVsEMlMxppm4Je mX7LDAMsP4GRSs3RigztRhdB+4IxagzoREnQC+5H/PYfApvrToDnIjpHk37A2UMljJhgDYcm2L/ 3gI/D5f6vDMVgHsWyFBrSYgE+N/QeK7Ig3AD83FJLykd6Fzg5Qb1L6MIbgLlnHnxSGZgWwfffZ6 JSF9gGvMpRDcASBxXktYs82ww2K80QrBjTE4HjCRhRBEb6St5v6Bc429wC3WL4Ggu937OkFwqbL NDYCNe1IUwY9ofZBa8KyBjydpazGxA1XalHtKHncV7Q5S8yTBdMeBQvzDIzhRDx+Pd00X8pw== X-Received: by 2002:a17:90b:4d84:b0:398:e73e:5a0c with SMTP id 98e67ed59e1d1-39bac138257mr1168410a91.1.1788888290224; Tue, 08 Sep 2026 10:24:50 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:43ae:bf76:d99a:e5ff]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33688cfc714sm19297176eec.20.2026.09.08.10.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 10:24:49 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v4 1/6] iio: adc: bcm_iproc_adc: sort headers alphabetically Date: Tue, 8 Sep 2026 22:53:54 +0530 Message-ID: <20260908172359.30003-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260908172359.30003-1-mdshahid03@gmail.com> References: <20260908172359.30003-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Sort the Linux kernel headers alphabetically to improve consistency and make the include list easier to maintain. Signed-off-by: Mohammad Shahid Reviewed-by: Andy Shevchenko Reviewed-by: Marcelo Schmitt --- drivers/iio/adc/bcm_iproc_adc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index ab66b97d2f04..e46e3761993a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -3,14 +3,14 @@ * Copyright 2016 Broadcom */ =20 -#include -#include #include -#include -#include #include #include +#include +#include +#include #include +#include =20 #include =20 --=20 2.43.0 From nobody Fri Sep 25 20:47:25 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9617F5921E5 for ; Tue, 8 Sep 2026 17:25:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888303; cv=none; b=gWOmcyxIlrqwUTLiu42HCoHSNlyqbqRBHVjonMIrzndZxvn4liBwMbI1aAlqHz875427N1jIbv742q2mRtuJ2vDTPcnFP9UfWDSRlPZXcD609HZEk1CxgLfVAHfyyzWZEg7gh9SbUjfiVu5UyUTXOssNvil4Dg5wOyhVUoc847E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888303; c=relaxed/simple; bh=HGcGydyDeZTeqtOr6+V26MAEuex+3SFEV+2bHwgn6gU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OCwzZ62Kz4zB3xihD82r6SBS7QYO8D4BTjpY3Nc9JldEg6YPaGaT6tZG3WX2MVvTOh3s8EwJJicOws0a8+dkXzTJbBeZz0CVrIqpEQTYCtj19/XwPzc1YmYZkp2N5GHSkmMEU49+NvhIqjhAjSUnw9UsQJbH6h8gmLmL1COtnno= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lHKDcZTY; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lHKDcZTY" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccafb752so170943a91.0 for ; Tue, 08 Sep 2026 10:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788888300; x=1789493100; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O8FraEq/yUb0r8EupXB8EQKm5xu56D8kJQlL77fVqVg=; b=lHKDcZTY75XgjqwrBA7iYcT6wCkkjfOsiVvsrHGjG59qAKE8vuh7DGwhxh8/YcUhYU 6C9xwfdFUpM1Evwgy164d5QWO06/srMEgN4pp8eI0bSam7+FYjh+wolP/iE2Dzk3Bsd3 iVmh3vWK6FjNcYqAcjtL7iLxPtOwAQMB/19M5xe3ZhMcsou3/SEqKhmSAFZPBqtrsbgV OmpYzOykbi1Bu8ubjsIKNrVnTHDng6CJ7Bmj4yuHm2YPMTzhPvduk1gdVmFrn8E0uRCg FJQUMcCCxjK7q/BPer3Y2dmPAKmah9r+QnIz+2dSJaNTg7PhkKvL1yUIvP8bNYPYS9P8 SrzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788888300; x=1789493100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=O8FraEq/yUb0r8EupXB8EQKm5xu56D8kJQlL77fVqVg=; b=pqeTYT5SVqdoPrQfoQL/NMD/iHErqsy7E84L61Z/mPMCv/4htTw2/A5LUtso00CnC3 22h5VnDtxbc0CoZFixsew3GZsAdwZDnb1f6pyIU2n7srBYkP4TsSnyqcuYSSThPTp9bf bORU7HpY6XcDuo3kX+kyKNoe0rB+2C/uV4xHctY1zSPoBV5WApVKO54PKrEcLKS7lK+V kBkcWp2ZxYWmOjw+9LO5MLRzO6afRM+QVmaWxlv+fcGwKCRMoN4GE4yCYwrIQY6cHgMy qWFRazdaFCf1EuJSrii2Kz0i4a1PthveS6aDWOw6wtlTlrsvg5umeQakDhGEiWjdGqe0 Yh9A== X-Forwarded-Encrypted: i=1; AKwUvByUmO2YCuZLPRXu+R5OT43rk8qPnRieGv2cAkoNNgN3PHC8+hW0DJNlqHkCE0NjrgFjkijlTeG2uPiGRFw=@vger.kernel.org X-Gm-Message-State: AFuF++kWaUdsrmatSMck4KRlbYgyafanv4evuC/VL9cjVXBtz8qapKKL NtEnzJ+VE2rsbXGLWIQad2gMNwCS48fvaa/xt7fZT1Vkl/ekkDg+3wPi X-Gm-Gg: AYBFou189BHY6LofNyRsk/2asL2pQ22X5JA9HhedoPHNcwCEexuwjtTd3DHlnQbkGHl 7GYKIKvpmJOdruJJ08iCqNoUm4X1RDo/Cwmd6dFyOZFSUTGRkCjYsFbH8I2g5btOJzrryEaLk8l kvW86iy8KIreEtuif7MzR/ZNKpkEOMk7pEb60Qq+N+7hSh2hf/NbhrkqIbSiAOSLQciEr/3yyQp oZkftSKY0oIZlq1zOSIcdi4IPNwBcedZpCtqcG/VRofuusNlma7Qu96nSEMizHy49O/Vhk4J8LS kwAQFlMXcKAM4Fm1oYc+AZR1FzSLZbsXrK8Z1aA2Hd514nyFzAOZc1U9whQqFnmR0PZ/QNDfJf6 DGoCoT9StSsbFjwWPZgWpnqXsklaPSorgltQyAm39Pp75cLxCbfpyZJLSfDe7vBRHE++D5muCEB 3uYlSB0hACVfMO9UE3EaZNGd+vC8m+A+qzn07svqhpgqXecJLGeL1MB3Y3D/w= X-Received: by 2002:a17:90b:270b:b0:398:c9be:cca8 with SMTP id 98e67ed59e1d1-39bac13b38dmr1363341a91.2.1788888299767; Tue, 08 Sep 2026 10:24:59 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:43ae:bf76:d99a:e5ff]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33688cfc714sm19297176eec.20.2026.09.08.10.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 10:24:59 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v4 2/6] iio: adc: bcm_iproc_adc: fix include dependencies Date: Tue, 8 Sep 2026 22:53:55 +0530 Message-ID: <20260908172359.30003-3-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260908172359.30003-1-mdshahid03@gmail.com> References: <20260908172359.30003-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Add the headers required directly by the driver for the APIs and types it uses. Remove the unused linux/io.h header now that register access is handled through regmap APIs. Signed-off-by: Mohammad Shahid Reviewed-by: Andy Shevchenko Reviewed-by: Marcelo Schmitt --- drivers/iio/adc/bcm_iproc_adc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index e46e3761993a..21bd51da9cd6 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -3,14 +3,18 @@ * Copyright 2016 Broadcom */ =20 +#include +#include #include +#include #include #include -#include #include #include +#include #include #include +#include =20 #include =20 --=20 2.43.0 From nobody Fri Sep 25 20:47:25 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02C0B4A43F0 for ; Tue, 8 Sep 2026 17:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888318; cv=none; b=Er8c7nbdIDkO9YWIOo6qWrbUH5jgetL+FE5gax5+nTG4umPVoHsyaqS+DiF00oEyGIbDrjF93uo4ovdYrLeTQbF2aFGPaXGdNA3BYc++WAv7GkT8nhpPHHbuHEGha397nmTknxEe7zsUNrkWivhL574HpuV4aJb7Z9cAxMme3j0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888318; c=relaxed/simple; bh=hQ+d7J8gtjsDGLvfNnMIrer8Ha9unpnDP+fsEJIUaq4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tIClchH1NRvz9J+TmEk32fW4L6VrtIIgjJqKklP+C4sfWrL99qHhPh+hAclPdv+8nlEzsYJPSyqaQLFPm3oOjFru99kYt9ibpPO7GeZMaoEDj3IIpfI7WRE8xK9ZzCtqhXurFSkgfvArK5HqPszZgIVr12jtbjBSavLibM2JXlE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QCYPs1jJ; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QCYPs1jJ" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-38ec1402b05so4674207a91.2 for ; Tue, 08 Sep 2026 10:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788888316; x=1789493116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZQcP2F4emeVQ9JpkX9Int2YPn5v7ZeGN+IRcU4vsCsU=; b=QCYPs1jJnFjY0Ynl6+AswNy4xIy3oO8H9x4ipufxkLf+W9QxwttC0oscO3eltpSI+h Ltgh+ZsOyPoL0YIFiJg261H/opm0HVv6t7IOFq/od6kFcwtLSa62SFeo4nw7R85qMeWi d9cQ0vh2h2cLv5hIdQRgqvO00zPztQfAJ6EkM9DustcY2hYM5nUIjAbCH/7eWLeLajIl qAxo+wPfN5epdIpaLgNjzFs0dWxRF4q0j76kBtBANctz/5Hc+QghLOc+40Af7gZVVmoj KA4ilDuxDFBRymrngPuWFQa/LRUV52U0pkY54QRGZpUE/b6k7yjr0Jab6x42PsRY2N70 645A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788888316; x=1789493116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZQcP2F4emeVQ9JpkX9Int2YPn5v7ZeGN+IRcU4vsCsU=; b=WKgv7THuUjKv39jYYr4lRCTdrhJO5bNMKhMgnHrdxdKzAGuFrwmdEyyU9AiR3kUyxq IG4RtcNh5by9uiifQLf0GiTJndxEcmMxqaZ5w1t7qs7h9n/to3t8I5rCoGm6m3hrHZyN R/ZYDXkYb4lTs6kTcXjaw++ve6tT3NmzlPO7P1iBiF0sIHfDQ/DrjmiaZZcKbd5o4WU5 N3KFrcQAUiWnWByc/FuM5+EZXdCy3kLPrmI0UKTH/bLhsWaDbx3S8afiobX6YX+L1M7Y 3oYmpt6f6M7PRAlPmzUs+Ii1V9BveF6oEDyYCkUtqJV0PheF8qSkN4q5xQosLyiRZWP/ 5Zdw== X-Forwarded-Encrypted: i=1; AKwUvBy3lfwD5AReUN5McQCztH3XZmlLgXP8xOE59QsffWPLomtexKroHu77c5ocGksnHeauKVT0x87X4Pqp9xM=@vger.kernel.org X-Gm-Message-State: AFuF++nwo2trjCIWiZRFg1xqdwpL9JihZHqP0+zs0OWfkuHnwm7jZQ+q nqkQlLzAp+WMD1DjzcDs0gZdoM2SjQ/6uvz+xV9KqVGy83mMXjQWQCuU X-Gm-Gg: AYBFou3RoMMhG2WmEHhs8j1pCARS1okTgg32IstGmjDrmPC78BC5NniJPRpagC+BfEi Phza1DP/7xT+skLtn2rF/mLJWr+K33VAO+6XcHHJhKdiXtwI+6YZ/WicUxT51tV/Oh2AaSEFEjt qNR1XbHGbt3yfSTlW0UK7ev7PVjqTYNU/K8RK3LZslswPM0JXy6uHssgHHs2kTNXDlpVMx5C76t Y/OJ7ZYvIzrQ1wwep80LJHvdBuDRDYy/Z7yK4hmjoOS0PCKnaLYdgioPqQ3smlGIrN7YDRELVKH waQe00QcQCfOQicfeVY0O0hyCnDzohktdK1Nodnwil3atarbQEXlx08EB54QGSG4ltIoPhMIrwH Ozw1NAPsBrh0mnezk/MH5ZSzUBf1uJlN91pszXgXCpM1aPjAzk7pBpFGQANTFzVeXpq5Mzh9ZmV GDVeVEM/429ccxflrlm9oc4LKyM+3d2lo9Vm5rNki3b6FdAiQz4VN3S7aPMSA= X-Received: by 2002:a17:90b:3a81:b0:398:c292:ac80 with SMTP id 98e67ed59e1d1-39b2612eaa4mr42334724a91.10.1788888316179; Tue, 08 Sep 2026 10:25:16 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:43ae:bf76:d99a:e5ff]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33688cfc714sm19297176eec.20.2026.09.08.10.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 10:25:15 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v4 3/6] iio: adc: bcm_iproc_adc: use devm-managed clock Date: Tue, 8 Sep 2026 22:53:56 +0530 Message-ID: <20260908172359.30003-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260908172359.30003-1-mdshahid03@gmail.com> References: <20260908172359.30003-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Convert the ADC clock to use devm-managed APIs to simplify resource cleanup. Signed-off-by: Mohammad Shahid Reviewed-by: Andy Shevchenko Reviewed-by: Marcelo Schmitt --- drivers/iio/adc/bcm_iproc_adc.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 21bd51da9cd6..d6f82f8ddee1 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -110,7 +110,6 @@ do { \ =20 struct iproc_adc_priv { struct regmap *regmap; - struct clk *adc_clk; struct mutex mutex; int irqno; int chan_val; @@ -511,6 +510,7 @@ static int iproc_adc_probe(struct platform_device *pdev) struct iproc_adc_priv *adc_priv; struct iio_dev *indio_dev =3D NULL; struct device *dev =3D &pdev->dev; + struct clk *adc_clk; int ret; =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*adc_priv)); @@ -530,10 +530,9 @@ static int iproc_adc_probe(struct platform_device *pde= v) return dev_err_probe(dev, PTR_ERR(adc_priv->regmap), "failed to get handle for tsc syscon\n"); =20 - adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) - return dev_err_probe(dev, PTR_ERR(adc_priv->adc_clk), - "failed getting clock tsc_clk\n"); + adc_clk =3D devm_clk_get_enabled(dev, "tsc_clk"); + if (IS_ERR(adc_clk)) + return dev_err_probe(dev, PTR_ERR(adc_clk), "failed to enable clock\n"); =20 adc_priv->irqno =3D platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -551,13 +550,9 @@ static int iproc_adc_probe(struct platform_device *pde= v) if (ret) return ret; =20 - ret =3D clk_prepare_enable(adc_priv->adc_clk); - if (ret) - return dev_err_probe(dev, ret, "failed to enable clock\n"); - ret =3D iproc_adc_enable(indio_dev); if (ret) - goto err_adc_enable; + return ret; =20 indio_dev->name =3D "iproc-static-adc"; indio_dev->info =3D &iproc_adc_iio_info; @@ -575,8 +570,6 @@ static int iproc_adc_probe(struct platform_device *pdev) =20 err_clk: iproc_adc_disable(indio_dev); -err_adc_enable: - clk_disable_unprepare(adc_priv->adc_clk); =20 return ret; } @@ -584,11 +577,9 @@ static int iproc_adc_probe(struct platform_device *pde= v) static void iproc_adc_remove(struct platform_device *pdev) { struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); - struct iproc_adc_priv *adc_priv =3D iio_priv(indio_dev); =20 iio_device_unregister(indio_dev); iproc_adc_disable(indio_dev); - clk_disable_unprepare(adc_priv->adc_clk); } =20 static const struct of_device_id iproc_adc_of_match[] =3D { --=20 2.43.0 From nobody Fri Sep 25 20:47:25 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9D4F4CB8D2 for ; Tue, 8 Sep 2026 17:25:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888328; cv=none; b=TY1LRuhpG8iTsV8iMV99htM6bOr6wmYFKiLe5GmwI0MOlgzCb/MvChnE/N+CcKF1U9EzS+YOwcMtafHndF2KFqOcLuE+fIt4kVhG6XvghBsAgYx2KoXdOa4gDmVllhoE1fs1yUsk8fpH0NOjSx/mPOVnRWOkv0kwRUSGI8hjvcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888328; c=relaxed/simple; bh=iSm6gUUkWSpkXgJjmPimBp+kKrGEEM4tZY4iWPBzihA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VV4TmEGCA940XsPFL4FgFv0hBDXKrJO6ByQCSh/2KG5mLgemi9PxR+zq3T+w62X2giAJY938Jit9rRQ16seNeGZKlrmpWBnNIhbIWF4F4+0CHVkEcHScXpv+pSMRTGLeF4A+jZ69O8z44FExBp2E1ukj3xuMd79brNC+7hvn5Kc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rcw43/vu; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rcw43/vu" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-cc1c8d4a959so3288456a12.3 for ; Tue, 08 Sep 2026 10:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788888326; x=1789493126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Zs21gAo4QkiJe7skjL4wk3AEQvdIKI9ChNhU3Egus/E=; b=Rcw43/vu1YmIaY5oX0YN3GoRK1JiKCJFZRLhoi8pZB7AHYsniJpDy1eTIG7W2WNoaJ RkuGlv9jAunXkDubDJCNLLcc+SCzniu604EWp7OIMhZeNY/0hYT4reBdkK4kk30UoxJ2 BKwjaE1b30t9Rsc8CnnNel2jAb2a0Ptr4vGCrg6a2gQi0Nl7whUrSz3JTCj5HSfra7ez YdWL46YlgwaEmXBCDWPtJ8lRcJAwbL3qxRxABsPWg1gYHzx1KqVME6ssQZv+Zayhouj3 AUUb+up7RbUjQZMajo7RiHtQAkleL89VSwnQDsjQb1POnYyR+lPlXnjzGLZJ23JWb6AO vrkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788888326; x=1789493126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Zs21gAo4QkiJe7skjL4wk3AEQvdIKI9ChNhU3Egus/E=; b=mQwuq87+x5wQUd5K6j4soOd6WDSr6LmRxaDWxuY2usKf5zhWF1MQEQLm7S/RPhkj+c r4xcBvnDRrDmEPGf4tenIaeFnBbWOQzJsLUHFpTIcBEH7XChvG9SsSoLtUx/QnwhfRgL wTC2qbXZWAF2mcAuxNELwUbJiLiqqpPyGU9+/nwmn/GJ/dkvU2qN4yPMhxoHtRKa29FY GPyNPOL4W+IT5Bvwuiub5s6e7t7n+CJZVZE0sw7gkWM2iX0ndXSaFATVk6TVwJgTWr5c f9yqXkuLetyQI+N9fAEsn9qS6xNmDoWmTYIN7mwKbXRAZpFTs9j0Gx2HNHA4xP5yRJZQ Hllg== X-Forwarded-Encrypted: i=1; AKwUvBxIGelyAi8Klknr06nV6E/hw6oeCiOYE7NWbHZv052lzh5B5aUP/0mTb1u5jyRRmhvI10Ms4ewTVY9KadU=@vger.kernel.org X-Gm-Message-State: AFuF++lZHPVQc/tSmGFqkC7LG6pw98qNAqfW24GiR+fdCphnR0Ps18UY s2qDF+2u3TdgRw2OnbGfStBO+88hf/0pWIoPI/GoMRmzZ8DzU+gEgXQJpcSee2fHlkw= X-Gm-Gg: AYBFou38zJT++eM/L5hWQINu+zv4hU293PcVzfNkUO8QZ8dyRK1qkMK3sDHgf401DP6 ewyN74AlESFscG6GejrGeAVHAW1ysr9DrHomgKCzp4U+mAX4kN+oBOP+KpGQ9NGlV0VsAe3Ovje qDOmaK/RXznpbnDQmFrTFLiMGRMdfAOhVa/a3+HwkhM2kDYJu0P+GAzDOhNBo/jrSP5XkA+Znny Vcsj/imeMqNfge/gWkPHboTvZeLSjPhdM2tp19BoNGSjnQhdeHIMZizKfytsPPVbPKWzvtb1lPR lzMILmE08Zdrk9ugLi5tXKL1fYw1wZo3su4MD/27L0lAOky+hnNNI2Dlt206hvUIsNlivVGKyqC FttlcHIawXXG7kwuXh2JXkyBJhLkj3IfxvKG5yfrPdtnfM1mktIoPmsn3uEwiQ4LnCkSSbskf9k cc+P/ZaSk636PPJEfZhgn9rLJK7mSA+dsmJ4PCV+bXzVvtk9lMwAq/2uOuYBc= X-Received: by 2002:a05:6a21:2291:b0:3d0:88f5:f812 with SMTP id adf61e73a8af0-3da39d147e0mr44672625637.10.1788888325834; Tue, 08 Sep 2026 10:25:25 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:43ae:bf76:d99a:e5ff]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33688cfc714sm19297176eec.20.2026.09.08.10.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 10:25:25 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v4 4/6] iio: adc: bcm_iproc_adc: use devm-managed ADC cleanup Date: Tue, 8 Sep 2026 22:53:57 +0530 Message-ID: <20260908172359.30003-5-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260908172359.30003-1-mdshahid03@gmail.com> References: <20260908172359.30003-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use devm_add_action_or_reset() to disable the ADC automatically when the device is detached or probe fails. This removes the manual ADC cleanup from the remove and error paths and ties the ADC cleanup to the device lifetime. Signed-off-by: Mohammad Shahid Reviewed-by: Andy Shevchenko Reviewed-by: Marcelo Schmitt --- drivers/iio/adc/bcm_iproc_adc.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index d6f82f8ddee1..ff271c7fb2de 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -451,6 +451,11 @@ static void iproc_adc_disable(struct iio_dev *indio_de= v) } } =20 +static void iproc_adc_disable_action(void *indio_dev) +{ + iproc_adc_disable(indio_dev); +} + static int iproc_adc_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, @@ -554,6 +559,10 @@ static int iproc_adc_probe(struct platform_device *pde= v) if (ret) return ret; =20 + ret =3D devm_add_action_or_reset(dev, iproc_adc_disable_action, indio_dev= ); + if (ret) + return ret; + indio_dev->name =3D "iproc-static-adc"; indio_dev->info =3D &iproc_adc_iio_info; indio_dev->modes =3D INDIO_DIRECT_MODE; @@ -561,17 +570,10 @@ static int iproc_adc_probe(struct platform_device *pd= ev) indio_dev->num_channels =3D ARRAY_SIZE(iproc_adc_iio_channels); =20 ret =3D iio_device_register(indio_dev); - if (ret) { - dev_err(&pdev->dev, "iio_device_register failed:err %d\n", ret); - goto err_clk; - } + if (ret) + return dev_err_probe(dev, ret, "iio_device_register failed\n"); =20 return 0; - -err_clk: - iproc_adc_disable(indio_dev); - - return ret; } =20 static void iproc_adc_remove(struct platform_device *pdev) @@ -579,7 +581,6 @@ static void iproc_adc_remove(struct platform_device *pd= ev) struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); =20 iio_device_unregister(indio_dev); - iproc_adc_disable(indio_dev); } =20 static const struct of_device_id iproc_adc_of_match[] =3D { --=20 2.43.0 From nobody Fri Sep 25 20:47:25 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 284EF59480C for ; Tue, 8 Sep 2026 17:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888339; cv=none; b=m6aczhz8Dnm0SRayeNQlYFkAxSoblKCNJCT0BbSaZsdf7TYfbwBb/p12GOarFMurz3pyIeK0wEFEMRsGz1qT7Ma9vLMFApZoXizocTSlpgMBXBhQN0KN2DPwHjHx8HSjcqeLy3DT+RxClFQPImePjMErD8FXDkXdo5i7hBmnv1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888339; c=relaxed/simple; bh=lnMZlFsr2b7pcckby/9HTomjPCDw0OgChLIiwio7RjI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=flVpYnfTvksUysZPx3LVGVVkviwT4g3xTwXVgV0YqKOajoU+80ATq1Rn66jsZI5YU3jBcxH09lMHE7Ky2H1qqWKWp7MHR4hmNFskuYuq2YMsW6TeYQKBDMwwzdGIwJf3ZNsOPmr5yhWfnyxNpAu5cuY1ODXBhffWTr+YEInMkEA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZYw8rqYt; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZYw8rqYt" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccafb752so171625a91.0 for ; Tue, 08 Sep 2026 10:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788888337; x=1789493137; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eN6yqcpqAjYfvv8rc/zTcsykokPXr/AOywGzcoVI8dE=; b=ZYw8rqYtssNc0O0RM34kCCD2vqEhJk275t1Dnd2yI7JSmKdEHdn2+UM8gatQT0xCkj KzaVqiiEU/2Zl6YVy0/2moa6cpU8vdmVdROKxV/B3RGcAQFuc7OX+JvaMih5ThpY4wSj 6ilEOm9w3ZvhHZZ7ash9ebwE+sH0dwkxoE76FUZuOKE/Cg2yVqJfZD4KeCPuK7xkW35z eFpbOMwDHElN8YGZQNzDydnMb9WRXlSpmvJImjbTir9dLtrSiY7XABr65mrjtXPMXyPH dOPigJewzD/VTp90LZU0SRk9eQyrYQqM4LkadGT4YI4zmIf7htBbM0IJSlhBxvlMCMAm NxgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788888337; x=1789493137; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=eN6yqcpqAjYfvv8rc/zTcsykokPXr/AOywGzcoVI8dE=; b=HEtb/y4hCPIvI2/OJl6WCGu9Le8P2FExD9LjL2IzSSWx39EvEMUD2wHy/etykMa60j CUg6aaxi7zYyTTa+v1RiQh6M/60//yksHKYrhOs59+g867l8OrO+bEtPepbpDhqZfLIy ZKwwZGINF0feqqE+KFmS+PWl5PgWKhqaVIjoIegbwxfuUav6LEiqPq7sm/OGGgpPwE2w C+9rrJ+tvyPamVaIPZm9rRKJrInG2GnpZfcGLsi0tcqsNjoaiGLIn3XiacUJXMg8x8PS MCyBFIs6zU+hBAY97deNyOJWcQt669SztFxW6D28eWtemU384ZK7AUfrmk4lYZM+64w8 J9Tg== X-Forwarded-Encrypted: i=1; AKwUvBx9dZOJ2SJU/QAmT1RSfXwdCeGjZOXyrrn7fkHGvvhAyet2VUxZHL6ljzzzUI7lem9BF/eJviVPgOXEYAI=@vger.kernel.org X-Gm-Message-State: AFuF++nHmpsnz70N7E1nHc6VeuJs+2wMP5uZjk1lXsBM/L6fXXUlksaG zTLm8aCglkb4QU+9ltGwUGDCYRy41jFA0qPMSTjMV4jCwtp86IRigasZ X-Gm-Gg: AYBFou2QbJqDoxAKM4VDUDZS0RrBbbh/8g1tRoP22XCUKWTvUmJ53uZGiCp2salNPUf p6WOJrpkHJwDGYVPNR5oOehv97RfajicGl+9gHkAMq1BaDRtA6HTIpJLbCFn0jyQR0g3mBQg/xT K6a3odQ4uVpdw6KSr7H+U05DB7pVPcCmg81aEXi2O3amBm6VjTFnBrR2GpmOnCaBNTTgi4hCF+z 7E1sXo/VVfDiBfMzGujEc9XTvxeCpGf2wFlSoJkf6FG/Ckiff8DKdFsve1aK1fSl2u2/e93pd2C kuDyW2rgUW9P177J5w+vJKmfiV7S5E+2RDkqgilplo8DC0YiA31jALbdtOEPr49PWyMA7eD99ha 376+fKl7ZTcOQrqMHbk3zF1nalQbKXiWFZVhpsWg/VuQX0UGM5LJ02gtzoWdQ4LRUQiuQ5+wVCT yIesrR3Y90MyRHvu0bNc4yZ0svg8zQaK/rJJvRx2knLZYIwTc7OawFmZt15d0= X-Received: by 2002:a17:90b:2787:b0:38e:9eb2:9d43 with SMTP id 98e67ed59e1d1-39bac34331amr1274961a91.16.1788888337459; Tue, 08 Sep 2026 10:25:37 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:43ae:bf76:d99a:e5ff]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33688cfc714sm19297176eec.20.2026.09.08.10.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 10:25:37 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v4 5/6] iio: adc: bcm_iproc_adc: use devm-managed mutex initialization Date: Tue, 8 Sep 2026 22:53:58 +0530 Message-ID: <20260908172359.30003-6-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260908172359.30003-1-mdshahid03@gmail.com> References: <20260908172359.30003-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use devm_mutex_init() to tie the mutex lifetime to the device and improve debugging when CONFIG_DEBUG_MUTEXES is enabled. Signed-off-by: Mohammad Shahid Reviewed-by: Andy Shevchenko Reviewed-by: Marcelo Schmitt --- drivers/iio/adc/bcm_iproc_adc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index ff271c7fb2de..9881a3104c26 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -525,7 +525,9 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv =3D iio_priv(indio_dev); platform_set_drvdata(pdev, indio_dev); =20 - mutex_init(&adc_priv->mutex); + ret =3D devm_mutex_init(dev, &adc_priv->mutex); + if (ret) + return ret; =20 init_completion(&adc_priv->completion); =20 --=20 2.43.0 From nobody Fri Sep 25 20:47:25 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C5F25908A8 for ; Tue, 8 Sep 2026 17:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888350; cv=none; b=VWN3xHSzpdj0ZNt8gVCdbkxQK15S36R+Ki7IX1oeC73Dhwp/JBgjqyd9rCm/vNkarmVOf89k6/JhfrulKP4kcIHZSTjIBkx/nLZxIUsXG5jqynqNnEoeoMflNffjb6Iv/sq6vbTcPTzjYcly6KL4C7S8jA2M3vSXOnx/W6xQ9EE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788888350; c=relaxed/simple; bh=wvUTcCBQZzKDbM9i8CICMan82jk+je7iizDWRvrhU0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FVPaGr5P0iu/rOozoIJmEky+vBGcfjjd1cRt9OGFGVqDXkSjnhYkmniNDWG4jDidLyoaRwrtf7qMhQFwYgyg8GDwkQwrI78OFOQ2BVVkdAkJSyPHl3y+Q4Nba7Mvs40Gg/DnpKDNMUpFJtDzms+lx0oaMQDKgQok2mQzIwxybLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p11BosEJ; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p11BosEJ" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-84830c774a0so4735477b3a.1 for ; Tue, 08 Sep 2026 10:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788888349; x=1789493149; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fYdCGwR2PPQ+VhuIDyakmIiYQ5Y15ZgMmXSqFF9HOCc=; b=p11BosEJFD1WFsDES+xPhAEn1LU3fMdO3JLMHZt2a+Hd+PZaBAnxQ2VMBl/lA81Rv7 HTu6h6qNb3mjHOqVqPghdQ0FxgnLXSeTvBzg1IF+6eCSDbaSFATJCzjNBDxaom/MHMwA a86gnkNbUwlcaAx8/Z5KGv0qCa7F+Sdm5ZvIlwHS6B5gZC/jLImC3EyHH1jLBFSt2KtV UowaDMVl6KngwpXj4j1pSF6sugHac8mnWv2FTtQizvRqF6SItOeZTq4sggeHssd9xUUh ie82KAo4SK7dKGBZu3tufh4lxesW2aR/XKTftLLisCK370GpgPxjiJ1L7NQIaelbeA4a 0cGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788888349; x=1789493149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fYdCGwR2PPQ+VhuIDyakmIiYQ5Y15ZgMmXSqFF9HOCc=; b=ielrRN1NxUV/Q1BGask7xOQkeQy1yRndneY55wPyG2hn/xCDve/Q++28J6HRIjJ6DV mr3uQe9QTRXhz2zDWMu1BHP95OAw2aQxEGtrp+s9TIucUj+wJpND+k7tgAGhJorscPxp YomiF79lkyYE0O8T1WjAFP5Co+RwlAH61JYjbcVtiUMV4Jp8/BEU8uXfktv/gm55SNwK NdHVn+EPuxXg+VcK9A1Aip9T7+ejwRU2XY0n0QjTuXvC1fIudP/tak+Q08KpK/ijXoKV XMbHU2z7rVb1lDR8dkoNMdDkxPskjIDeyjZalei1UVf49S3TY2x/8f4rcSyY0AP5PoRd 5XuQ== X-Forwarded-Encrypted: i=1; AKwUvBzmOifBYoYcOp5btHgsJB/08EqYDxQIvGGzsebqXZplHKAJoPWLcUGsuoARyaPLcV5Qdwmw1oPcsCLqcYs=@vger.kernel.org X-Gm-Message-State: AFuF++mJldAZM8XjPnv9xL3oXcuyPAdx/uvY7QUbnRCPQ5np5LLCb/hD iVHFGutnepwbmBDdOgtD+uISfIMhJ8xIQ+l0N9YNT4RJgPovWNIoH1PB X-Gm-Gg: AYBFou2YFMpw3Z2v31zc0InYlo8o9ZeIFfwYqxIBSFwaKG3XODST6H2HMwIB9ge6WWK 4f0ZLiAX2Ud4xA2DDC2kRuXK8ZovzyLRmA3p3jE4G0hky0JHQr2mlh7JYIpGt5STELhMpSySc+Z DQQ2uYReXL8H6cVkd3CIRTuCQaydYxNdUHYuuolDwJVK4dNxMy6ngqF09jsyttZtD1JKuso14Ga 1hi/jXMvnwGt8co3sD4O7UX5tbblhM3ZRz00JrF1S7bybi0jorJ6YaFgyxFLdIZEjafM5FCXfnf t7aIz8ndZQKiRIj0IgajiCLLnlUY0QmdZ13HKm89nxK/McILBy6CQ+4TP2BHcEZEvHlCJMlsBA+ GJ5XcTrw2dDR9mIzGbQiCvE4oEQTnq7Gd5+oRnr1xk9Bx29aEwDXEcidopJ+sF9HORzQ2B6Hqv4 wqIClPrG944jXT8YtIp1AHKlVNrpF+Ja1xALMK3pGx3RPruq6v3+Fj6fHaS88= X-Received: by 2002:a05:6a20:bea6:b0:3bf:7e2a:e874 with SMTP id adf61e73a8af0-3da39b5c429mr46679411637.1.1788888348747; Tue, 08 Sep 2026 10:25:48 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:43ae:bf76:d99a:e5ff]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33688cfc714sm19297176eec.20.2026.09.08.10.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 10:25:48 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v4 6/6] iio: adc: bcm_iproc_adc: use devm-managed IIO device registration Date: Tue, 8 Sep 2026 22:53:59 +0530 Message-ID: <20260908172359.30003-7-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260908172359.30003-1-mdshahid03@gmail.com> References: <20260908172359.30003-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use devm_iio_device_register() to automatically unregister the IIO device when the device is detached. This removes the manual iio_device_unregister() call and makes the iproc_adc_remove() callback unnecessary. Signed-off-by: Mohammad Shahid Reviewed-by: Andy Shevchenko Reviewed-by: Marcelo Schmitt --- drivers/iio/adc/bcm_iproc_adc.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 9881a3104c26..ca81e0edd24d 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -523,7 +523,6 @@ static int iproc_adc_probe(struct platform_device *pdev) return -ENOMEM; =20 adc_priv =3D iio_priv(indio_dev); - platform_set_drvdata(pdev, indio_dev); =20 ret =3D devm_mutex_init(dev, &adc_priv->mutex); if (ret) @@ -571,18 +570,7 @@ static int iproc_adc_probe(struct platform_device *pde= v) indio_dev->channels =3D iproc_adc_iio_channels; indio_dev->num_channels =3D ARRAY_SIZE(iproc_adc_iio_channels); =20 - ret =3D iio_device_register(indio_dev); - if (ret) - return dev_err_probe(dev, ret, "iio_device_register failed\n"); - - return 0; -} - -static void iproc_adc_remove(struct platform_device *pdev) -{ - struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); - - iio_device_unregister(indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct of_device_id iproc_adc_of_match[] =3D { @@ -593,7 +581,6 @@ MODULE_DEVICE_TABLE(of, iproc_adc_of_match); =20 static struct platform_driver iproc_adc_driver =3D { .probe =3D iproc_adc_probe, - .remove =3D iproc_adc_remove, .driver =3D { .name =3D "iproc-static-adc", .of_match_table =3D iproc_adc_of_match, --=20 2.43.0