From nobody Fri Sep 25 20:47:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B726550DBE; Tue, 8 Sep 2026 15:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882184; cv=fail; b=GVc67Xhg7BvQKDFUfT6JVamKhdL4lD+ZPj/dZcihxPfGiv7D0BJgdmrNaupr2L/ennhPSu2H2GTAQiYf/jcxhVqdAVy6nUZ/eJpXB/QhEmTGoFzE/A5MKUYxZQPzG+PsC6NGL/sj/5Cw7OyhtPXgJh57Pr+NYt1kyVLyAl/isRo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882184; c=relaxed/simple; bh=uTIWTSTNrzdW3ZDoyKyYEiuNBtsYxb9rLWm1k7/Xxgg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LnE5pGokUQYxymzx6wlxFokcSd6p5peAfJCG2yFJwGRy3GVkv3Irc5UaxrYgHniKpuQ9X7DOcDEnjb8m/HaFa73lGrDu3XPdLsZt7xOJGrK82mzqLcpL+mD5jrI3qjJD5VBMNf1wKn3g4s1FmrNw7/NXSio7hrEeFtFA5CzGGuw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=XrWJudpd; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=kh8TO2kL; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="XrWJudpd"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="kh8TO2kL" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 688EkN57173179; Tue, 8 Sep 2026 10:42:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=0zQflQX0fDaSlqZZtd4N/a73J+VEAQJY8T0SCdlZv uY=; b=XrWJudpdYC/X75EU/UBXwRgne4w5EA6t13nQvkR0jWxVnYEzleJzMumrl fADprezuCs1Fm2ww7sW7Q7MVw+wfSNfWvC9NO1uQl7iAVhLPc+MFdG1w7qmHwdEu DVbg2z1S5cbF9RsXRC1Wwd7GOXopZ34iguwoV5IXTatVYtCdLZVWhwl24JrGSguG K2RYWXUZVRICuRf4JXqTRt/v5b3wrmx7rtaL5FIDTctQcDAWGtoCgwDLzyXL4nDa AMI2xz9HHQ2xrSc+9l87tn75lP0rd2mbNoBucvUtIRShH+8BTkEJRa7yF4kyJWwd SV3RwGXH5rC0DEVrziXMtulHdF+fw== Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11011045.outbound.protection.outlook.com [40.107.208.45]) by m0384305.ppops.net (PPS) with ESMTPS id 4gjkdmryj7-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 08 Sep 2026 10:42:39 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BhWdlgtec1oCacENwpPzJm/nrsBG6pcK0i3M7GYjAMLUjQOxqtDV9pcn6d7m3F6L0YW0Nl+muBGB6lyH4ClYoARWt8xD/S+GPGWRYmEhJsPmrmWHLvYdy19uFvIgrP32160vORc+jdIiMcP399K4Ym8k2dMY4KkciTHMfp6NCgufZu7TSRJbl8GS0qR6Chma4kQyDlYUufSqW+mrPg/fCRDpqEgpSfir7QOH1wuYhlZXsYORj9SW22fnlry2TmheoEkVMjxovklBAO06BoU/Vm3b1Uh4h5VnSH2Q3aKuKIPWQ+OTQdAuZbk4KfabXhYiZunmZEVOPkrBv7TLFiUM0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0zQflQX0fDaSlqZZtd4N/a73J+VEAQJY8T0SCdlZvuY=; b=QOQGXwbg5PZEmuG1vA9i7VmuIs4LzzkXkQD7sRN606bEHVjLO5IidOgdjxkmShoiiVW3MVEy8QrSEeIeKrBy2FpK+fr9Dtl2HFf9fAP6Ru/NGaXBrdGP4XH5xzQM/EMTDio9PGCO5rwgVQku0hyX+M/kGGFojB/QKYFHWQdz25S067D2DPPrF62OS4bI0O7FSsbyaKBzeEszYWxYAjOmDxTgKrpnDJHfBQ4FZYbnrNNLoNuXyj2gh1aFTGFr+Y6bOm7gK4VM9wljh7k7F6a1rbYoBPm7v7fWleFjFuylRbpLuBwB1GGB6Duu316j/PPfm2CvJIyqXfN2d7wZDDLa0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0zQflQX0fDaSlqZZtd4N/a73J+VEAQJY8T0SCdlZvuY=; b=kh8TO2kLcbnClNcU8YIbI+mxmzxOKRJRkvw2hfJJPEGsmJTlNT56Cnx6s0j4/jb70dKXfVRSnuWygP6ZkaORgWAG/peOgk+UCNuQkmaxIN0uIt47pj5oLGfMMIxD64vwM1aV6s0XiVgohYsmBIghjDsXGZMj/g20hU+vK8asUE4= Received: from CH2PR19CA0028.namprd19.prod.outlook.com (2603:10b6:610:4d::38) by DSVPR10MB998078.namprd10.prod.outlook.com (2603:10b6:8:41d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Tue, 8 Sep 2026 15:42:36 +0000 Received: from CH2PEPF00000148.namprd02.prod.outlook.com (2603:10b6:610:4d:cafe::3a) by CH2PR19CA0028.outlook.office365.com (2603:10b6:610:4d::38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Tue, 8 Sep 2026 15:42:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CH2PEPF00000148.mail.protection.outlook.com (10.167.244.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Tue, 8 Sep 2026 15:42:35 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:25 -0500 Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:24 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 8 Sep 2026 10:42:24 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.33.213]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 688FgNWb3725209; Tue, 8 Sep 2026 10:42:24 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH v2 1/8] i2c: omap: Drop bit shift for I2C register addresses Date: Tue, 8 Sep 2026 10:42:16 -0500 Message-ID: <20260908154223.116074-2-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260908154223.116074-1-afd@ti.com> References: <20260908154223.116074-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000148:EE_|DSVPR10MB998078:EE_ X-MS-Office365-Filtering-Correlation-Id: 77b85913-900d-4246-0620-08df0dbfce47 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|82310400026|36860700016|376014|10067099003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: R8XxHRNPMvfqXs8jH7Z022lpPly3W3tvHeBXftUAc83P3sc3XXVDV9bLaP9dD6etrAj8lP5pV9vwNfM4wn0GMmbhVk3cm3hFeEUVRMgiUvlVp5CGGvRcap7HNmnHtUZRJXi4OJ4oVbz8O86ft0kPhw3rLpRAWt9s7KyoQDngx2/nLtG5vFjytwnawkfFj0D1pRI9GXN6zIYAwxI4QorEhlpqvryLZysS4S4A0KuVesVhIyl48bqEQTWPHnt9oH0Fz43VoLvOW592DQgqT66zXRln0ImqWcHObVFtSLbJIREs5QXjGms29i7YW/s8bG6ECNfS+JedOopMjDhP2+g+1ht7gISBVtorH1RmTECo/FnuMK0SmPtXEXC/tHd8yho8KtjW+tMIfEO0TuHUeoWVgIsFDCPYoAYKgU/sTO3yw5CE4jfTxSpqEH/9PdUTTjb7w3Ogbz5Bb1e5kCBBRbW3SfewF8h0f+wEXZQe+hI/IQMgwIZbOMNVaMNp+SzoO+2nzIGmvHlJ+Hrgt0MzzWcff0MwtIpaB22Mb6Qs2A0MxFctfgiKM1bKqDd8RHxCSrl2DpVRRR8RW7Np1y5wWWh6HDgDbjxrDoqRI713YxjzxJLdbFq20Kkl8TjZjGGIoGXtI5dSniUTmOrZ5DITW+u+dB1Mjc8Ld0IxJmx52yAT1NdxPKa/o+yU/UZtVFSIlBULgFdx68Gz1NOSrK6krZESng== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(82310400026)(36860700016)(376014)(10067099003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sLFYH6tC+R0z4AwWUDmmZo1sYtetS/QWT/rb40Ta9dP7ucmpKjHntQeuBIBCIneD+ZlTLNE1JfYPu32KgZeZy+lSiyrKt6wc2jM9viMxg58zFbHECqjJAtjrwU21gu/c5TsE4421D1PzIbWGsKBGx96q0twSLvLYUo8Een4qGhFGU5uR1ZvsFwzOITxVeev9TGBNyN8i4PO1PIhVJHYVPPiert17SrtJaBdHxIytOIgZQyDtKYyLfCuNUI+4UBYu5VJYmi7TNnLUHTUrfhGcJYUZDgL6ad9OxZe30r1+y4o72xTVEDQ7Lz/tKOIN7APZMPHnuJbVjOWCSR3a6GxdyQBfCgy7nEYkFEWBXDckF87wISpFSUYRl1jBlbKFU/xldstrK+sqNzX9xCXPedqsgughishpVyZsHCYprD6pbRDCxLiJPVq72O1G9ygUOuct X-Exchange-RoutingPolicyChecked: ZxBQh0Ge8xFnpHrIC8JCUIZSUoBZP8R+h3pae3zVkZ1OpNSvxRV92sqoMc0jWFH7DQTPXdLz9/NBbWyjwwKbaZrUiZtzfy9qB7bMY/iLt7BQ8gguQ01jpg75Y7eDnE4KB1uEEO6TdSSsUNNYSbo4PFcMs4oARRUaa807ZitSjTBIUESHVX7wILN2jubuwc2ovC5Dx8c4FlkDjoG09rlwkZo8YExLDB57fZmYooL617ruPJ3pGpM/XwIQHMal1jiRpU4T2g97hCLnhWwpS+AbfUfsAzViwG3naB7CZByQfULZ3JwxGIpb4QeMSEQYKEjrobxTE6j7zFD+NrlsOxU1Ew== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 15:42:35.9575 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77b85913-900d-4246-0620-08df0dbfce47 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000148.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR10MB998078 X-Proofpoint-ORIG-GUID: Dv-6RvVj8i02343KpVAAsvnmwzTnGGHH X-Authority-Analysis: v=2.4 cv=KpZ9H2WN c=1 sm=1 tr=0 ts=6aa02cf0 cx=c_pps a=s6FLI2cSFE2dV00WXjZlDQ==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=50gAi1W1AAAA:8 a=miE_aGblqCwIs2vhnBUA:9 a=bIAsa0K8HJLRn3BBPJ--:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX1WGhCh+qR2bJ fA8X4QvKVQ9eiADjmwh/6zVuOk5HOb7MvEIKEYZ0m93CORAs1DsUjkrv7DU3/+2wDGxDmIZ7xjz a5isSucPyWPBB6o+vk9t9rtfK3bx30M= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfXz6FKF93wqUCP dZOAIXLlV6QiP/Bak2Mzy8AeXLcjWbRChCN1QgIFBX/MFiREh6pBnUNyYDbZD8OHFWXUx3r3Jt8 8uxdtPEKHezsZWx2vMKnGYFDeB7w3XRcRiIC9pH9jhsOjTAJ1qWv2BCF1isv20MT9RSUUVNqNnk ib+8OkjyoH9hwRcIlrF54ZbSHpSfcri3wtoneOJGRo8BaoTZLAMhG6pl82E5VtakJ2N+eX+Gxj+ MFWm39c9A2rptXkThoPZULRSY1uBnI4ra0JoEB+CTcrB+RZcxh+Kew7zk7UdXrZe/kyjD3O8eE2 OSwtntF70GS+NnXPVrxJJz6R21NrnxrTZcQhTH0FxWgmG2KcrcQBSWIHVEZem8xuAK+g/N7nZzQ 9Gk/xCRk7LZaJI0MGLkEKF7LKxtHw0JQxiNX1ol/aZpCKFKykM2gt0TnfhZ+PUuvAQybfZ0tE2K kpcborNqNSOGuWEMQEg== X-Proofpoint-GUID: Dv-6RvVj8i02343KpVAAsvnmwzTnGGHH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080169 Content-Type: text/plain; charset="utf-8" The OMAP7xx devices used a register address shift of 1, but this device has long since been removed from the kernel. So now no remaining board device uses a shift other than 2, and no DT supported platform ever did. We can drop this flag and use the pre-shifted register addresses. This simplifies the register access. Signed-off-by: Andrew Davis Reviewed-by: Andreas Kemnade Acked-by: Kevin Hilman --- arch/arm/mach-omap1/i2c.c | 4 --- drivers/i2c/busses/i2c-omap.c | 50 +++++++++++--------------- include/linux/platform_data/i2c-omap.h | 5 --- 3 files changed, 21 insertions(+), 38 deletions(-) diff --git a/arch/arm/mach-omap1/i2c.c b/arch/arm/mach-omap1/i2c.c index 94d3e7883e027..bc7828a858941 100644 --- a/arch/arm/mach-omap1/i2c.c +++ b/arch/arm/mach-omap1/i2c.c @@ -61,10 +61,6 @@ int __init omap_i2c_add_bus(struct omap_i2c_bus_platform= _data *pdata, OMAP_I2C_FLAG_16BIT_DATA_REG | OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK; =20 - /* how the cpu bus is wired up differs for 7xx only */ - - pdata->flags |=3D OMAP_I2C_FLAG_BUS_SHIFT_2; - pdev->dev.platform_data =3D pdata; =20 return platform_device_register(pdev); diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index f02d294db42a6..72f979eec7311 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -180,7 +180,6 @@ struct omap_i2c_dev { struct device *dev; void __iomem *base; /* virtual */ int irq; - int reg_shift; /* bit shift for I2C register addresses */ struct completion cmd_complete; struct resource *ioarea; u32 latency; /* maximum mpu wkup latency */ @@ -217,23 +216,23 @@ struct omap_i2c_dev { =20 static const u8 reg_map_ip_v1[] =3D { [OMAP_I2C_REV_REG] =3D 0x00, - [OMAP_I2C_IE_REG] =3D 0x01, - [OMAP_I2C_STAT_REG] =3D 0x02, - [OMAP_I2C_IV_REG] =3D 0x03, - [OMAP_I2C_WE_REG] =3D 0x03, - [OMAP_I2C_SYSS_REG] =3D 0x04, - [OMAP_I2C_BUF_REG] =3D 0x05, - [OMAP_I2C_CNT_REG] =3D 0x06, - [OMAP_I2C_DATA_REG] =3D 0x07, - [OMAP_I2C_SYSC_REG] =3D 0x08, - [OMAP_I2C_CON_REG] =3D 0x09, - [OMAP_I2C_OA_REG] =3D 0x0a, - [OMAP_I2C_SA_REG] =3D 0x0b, - [OMAP_I2C_PSC_REG] =3D 0x0c, - [OMAP_I2C_SCLL_REG] =3D 0x0d, - [OMAP_I2C_SCLH_REG] =3D 0x0e, - [OMAP_I2C_SYSTEST_REG] =3D 0x0f, - [OMAP_I2C_BUFSTAT_REG] =3D 0x10, + [OMAP_I2C_IE_REG] =3D 0x04, + [OMAP_I2C_STAT_REG] =3D 0x0c, + [OMAP_I2C_IV_REG] =3D 0x0c, + [OMAP_I2C_WE_REG] =3D 0x0c, + [OMAP_I2C_SYSS_REG] =3D 0x10, + [OMAP_I2C_BUF_REG] =3D 0x14, + [OMAP_I2C_CNT_REG] =3D 0x18, + [OMAP_I2C_DATA_REG] =3D 0x1c, + [OMAP_I2C_SYSC_REG] =3D 0x20, + [OMAP_I2C_CON_REG] =3D 0x24, + [OMAP_I2C_OA_REG] =3D 0x28, + [OMAP_I2C_SA_REG] =3D 0x2c, + [OMAP_I2C_PSC_REG] =3D 0x30, + [OMAP_I2C_SCLL_REG] =3D 0x34, + [OMAP_I2C_SCLH_REG] =3D 0x38, + [OMAP_I2C_SYSTEST_REG] =3D 0x3c, + [OMAP_I2C_BUFSTAT_REG] =3D 0x40, }; =20 static const u8 reg_map_ip_v2[] =3D { @@ -267,14 +266,12 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap); static inline void omap_i2c_write_reg(struct omap_i2c_dev *omap, int reg, u16 val) { - writew_relaxed(val, omap->base + - (omap->regs[reg] << omap->reg_shift)); + writew_relaxed(val, omap->base + omap->regs[reg]); } =20 static inline u16 omap_i2c_read_reg(struct omap_i2c_dev *omap, int reg) { - return readw_relaxed(omap->base + - (omap->regs[reg] << omap->reg_shift)); + return readw_relaxed(omap->base + omap->regs[reg]); } =20 static void __omap_i2c_init(struct omap_i2c_dev *omap) @@ -1214,19 +1211,16 @@ static struct omap_i2c_bus_platform_data omap2420_p= data =3D { .rev =3D OMAP_I2C_IP_VERSION_1, .flags =3D OMAP_I2C_FLAG_NO_FIFO | OMAP_I2C_FLAG_SIMPLE_CLOCK | - OMAP_I2C_FLAG_16BIT_DATA_REG | - OMAP_I2C_FLAG_BUS_SHIFT_2, + OMAP_I2C_FLAG_16BIT_DATA_REG, }; =20 static struct omap_i2c_bus_platform_data omap2430_pdata =3D { .rev =3D OMAP_I2C_IP_VERSION_1, - .flags =3D OMAP_I2C_FLAG_BUS_SHIFT_2 | - OMAP_I2C_FLAG_FORCE_19200_INT_CLK, + .flags =3D OMAP_I2C_FLAG_FORCE_19200_INT_CLK, }; =20 static struct omap_i2c_bus_platform_data omap3_pdata =3D { .rev =3D OMAP_I2C_IP_VERSION_1, - .flags =3D OMAP_I2C_FLAG_BUS_SHIFT_2, }; =20 static struct omap_i2c_bus_platform_data omap4_pdata =3D { @@ -1384,8 +1378,6 @@ omap_i2c_probe(struct platform_device *pdev) platform_set_drvdata(pdev, omap); init_completion(&omap->cmd_complete); =20 - omap->reg_shift =3D (omap->flags >> OMAP_I2C_FLAG_BUS_SHIFT__SHIFT) & 3; - pm_runtime_enable(omap->dev); pm_runtime_set_autosuspend_delay(omap->dev, OMAP_I2C_PM_TIMEOUT); pm_runtime_use_autosuspend(omap->dev); diff --git a/include/linux/platform_data/i2c-omap.h b/include/linux/platfor= m_data/i2c-omap.h index 3444265ee8ee7..fe6753cd17bf5 100644 --- a/include/linux/platform_data/i2c-omap.h +++ b/include/linux/platform_data/i2c-omap.h @@ -23,11 +23,6 @@ #define OMAP_I2C_FLAG_16BIT_DATA_REG BIT(2) #define OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK BIT(5) #define OMAP_I2C_FLAG_FORCE_19200_INT_CLK BIT(6) -/* how the CPU address bus must be translated for I2C unit access */ -#define OMAP_I2C_FLAG_BUS_SHIFT_NONE 0 -#define OMAP_I2C_FLAG_BUS_SHIFT_1 BIT(7) -#define OMAP_I2C_FLAG_BUS_SHIFT_2 BIT(8) -#define OMAP_I2C_FLAG_BUS_SHIFT__SHIFT 7 =20 struct omap_i2c_bus_platform_data { u32 clkrate; --=20 2.39.2 From nobody Fri Sep 25 20:47:00 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B450565108; Tue, 8 Sep 2026 15:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882240; cv=fail; b=S0nqpg05otvRuogTXvL0Ac6ougfkjuRqAqRStmIUdODLmcRS+WcV623l0TUsaGoc+/RmKmel1SpZ90H9txKpm/SdRe1Mw+lWQU4w0Orr4gb/ix2Ot7mGJvOjVyDFu2gaQfIDmODZzZp21FMl0fMVLFoyTs6IcJkauOmS4Sn9ASA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882240; c=relaxed/simple; bh=EL5ceNUk6yokUkG2f9NSDJIsi36IwdqmxO9GP0JXNsU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RsRzwCeEjmZHLJJfRpPEbQ0cetHGAeGEaL1BsPuymPgnZPoaPg5lXNO6buFBvo1VLj/Pt8pUT0VQ6HwFlo7YNSAYoVW+1/SPxdhSH1aAM7nHKcFHwzmH0kyhbzBK2XCdYyelgJaIKh6cV7TTczNTdE8DbpRn0avK6HdFnHebe+s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=VprLOEMM; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=cxcdom4P; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="VprLOEMM"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="cxcdom4P" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688Elooq1845540; Tue, 8 Sep 2026 10:43:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=+mtFK3uMBh+95DlhbAWd1LHsJX/Cb+oUhkeRK6PqU iw=; b=VprLOEMMHgkNUcKm7bpe27/AvEeVASDl9Q0oF7FNCy4WV7ADFpn/j0GsY hRgXaHd10idBvUJrLSCouU28NfZiopHoOZtmHi9y149RTwG1qJ1bHN1DGwMliClU cK1NdUWRzpO6u/NTO9Zw0+bUvVYlT1+jnHzGCJUSp7E/1+XgkvP8NKo8QOY2xycV fj56YPgJO6xlhZecHwMCLNN0y12zp9vG3Nzpf2PAzyDtBqNAxRWzH7v8KZgLOGzf BZx+Hg2iX4io8B3Rvd3yax4bHLUJ/uYSayldzINS8Nk5q/ZUJmRQFM+ZP1DKsPAQ d1vOAvVm3/O/9bwK+rY1LWEGtbibw== Received: from ph7pr06cu001.outbound.protection.outlook.com (mail-westus3azon11010062.outbound.protection.outlook.com [52.101.201.62]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gj940mybs-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 08 Sep 2026 10:43:44 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AGSrA2aCoot0Ik6IjYjyoWUGbGvAjH1HHuchtJVCvAUdXMo8HWTb7mnVZxmMCBoAZ4+KNlNZ81vCzquHdOihD+U3mfPMxcQgC7LX7yorpTPWJCi/N09wNCgH8jgrFW4RLfkMAsRstJv8bhI+6MsYKEiA1QH8ShopcCVer/V6FDxxZLx+LpSrcbCSTY78VzRmEl219lFnLVYXSbUuHT7CoUbl56vQfnP2k5nlZVgRKLYbpaqzC/WgTyO3awrR07qBBBthoPDkqdNp60JnXCnGTdVE6WeDpwdIV8dP396yNhGRJBkgZtA4UISJJ9DNcfmF1AHiwhvTXlYDa/mwfZBOOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+mtFK3uMBh+95DlhbAWd1LHsJX/Cb+oUhkeRK6PqUiw=; b=ICbOplfqhuu7A2KCyhTvB95Bxpw4jwQrslAkCVDWmhH4vmLnx03p8LtIuPDIkQXGt+ce6qZMsIh2KcpBj6qWwaSPY691gRWX22DRK6m4tB8zar3PjRaxgOleeZukDANeSqLcfW42LRad1dTBQ+i7AZ9Jk+WLaBwhECen0eFjdEbGLS/+/L/32HSlCXVHBLrgS6Dlq02ZFqWIOKcCPXPFH4oOKZn5NO1O4b5vioTEcZh5H78FXdabXMsliRQTZ3rCaGPgi/P5G/qyYnw4poXtRu2zSWial8I0ixC9WlR3DaND0fArmz4vTpK9i+miEJ4uj3XLbd4R6heDcBDZkNB0zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+mtFK3uMBh+95DlhbAWd1LHsJX/Cb+oUhkeRK6PqUiw=; b=cxcdom4PqbcL/A2kq6lozUUXQgA0E4u8ftZKqfnkOnuW2TJZ5ZiWvRCvllrYMs7Aof+JgtKVE4qffMH8Edf2wM8vszSGvi4KKqat4kYEx56lD+DCflL4rXQzNa6eTyzw74FIvO+VlPfa9l6wBOxyhHyEtk5jbaws6M+ckIiY2FA= Received: from SN7PR04CA0163.namprd04.prod.outlook.com (2603:10b6:806:125::18) by MW4PR10MB5864.namprd10.prod.outlook.com (2603:10b6:303:18f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Tue, 8 Sep 2026 15:42:38 +0000 Received: from SA2PEPF00003F64.namprd04.prod.outlook.com (2603:10b6:806:125:cafe::35) by SN7PR04CA0163.outlook.office365.com (2603:10b6:806:125::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Tue, 8 Sep 2026 15:42:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SA2PEPF00003F64.mail.protection.outlook.com (10.167.248.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Tue, 8 Sep 2026 15:42:37 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:25 -0500 Received: from DLEE212.ent.ti.com (157.170.170.114) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:25 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE212.ent.ti.com (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 8 Sep 2026 10:42:25 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.33.213]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 688FgNWc3725209; Tue, 8 Sep 2026 10:42:24 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH v2 2/8] i2c: omap: Remove unused is_rdr and is_xdr variables Date: Tue, 8 Sep 2026 10:42:17 -0500 Message-ID: <20260908154223.116074-3-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260908154223.116074-1-afd@ti.com> References: <20260908154223.116074-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F64:EE_|MW4PR10MB5864:EE_ X-MS-Office365-Filtering-Correlation-Id: 02f64f9c-ac2e-4dc0-fc1c-08df0dbfcf4f X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|36860700016|82310400026|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: RI7H2THDQVTKCjZC9+ccSPBcqMcEpXGNeNvAlUfEfnmgsRvEzC8NnftpBF1YO/ahVjI/mbPrE07jrxVIxtpz8SGGMSUxaTDQYHjkKLCgOHxtULLa19E46musa8C73XIAhH90EnU8bs/X3nFORmOsm1cH2Pk4GR17GdCI7kuZ4+Ygn0PH8TXmR7cqrEG9HkNkkZrX4Aokm6qfe7bwsu2zMvvCYkpmlZuy/VD/Rl6MsKqLDR3vjO+N/28mJKwtfn0FtGWnWHOPORuGteatjIK16+8oO27UsL8CDSJ1C9WkGOlHRQENYu1Pf8Qb+SW8cScAtf0XewWGwpJM5ltidPIODhT7DT5ksFTxSivjoEklax1JdLlrl5OxFXnqApXLGWcjbAsPaB34Ji2blK3jeZOxThy3QkhKLlvFGFbU4qpTTc7A+SeULuW/p2X+Yyi+8pUoXDkW6/8wl8aBWR7CC52S7gkUb8+Gu+WAiw1/N6IbfCQMVzbUWsAv8TShWzxAneO5RQBLz5QbzsBx5y+xLW+2YF97kgyrjAFVVAqeXJxZ66zCbevzJf1hXjy0j5hB//2HXBjPD4whM8kyixTGG9ZWeWAjWIPrYpbsfDz2x2vErFE/rcGaKFcoJ6mPIvXvMw3iMFbVS1+XBwksOd3ZmdQyz9CgbbPxb3ynKSA9trfTTx/2b/Cr1dfalnCZOhKDy74g1CoK0Ewt0PGOGIbm1OiwSw== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(36860700016)(82310400026)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ODkialvv8c6ErOXpCIl4quwrsLKSzCfw52thVo7tGG+NmzZZ/FMaY0idCerIHJWnX60gliFiNgSDRvR6Yoh+g442I1OlGvQqhMYNXKrq3NqffTObbkVxKtT+gjk9MOJCSvlcwM4ivtj8+ISAejr3flQYazVjwwXpPb2uUTt5nNcoRWNH/NbrQvoQeLL6PQBP3dMJTA6mNBTdqYyvlxx5I0hQNzNmo9B2SV7NveHibSNu75XW7PhOWK6hTk4ygA75f5kkFqHPCFL+P71WAB4cVIJ5gyIBLc9af/9b6jOyg74i1k3LIW70r04wbziqi+SHAenbXJog0IA7Dt10onFAxVNzVRdb6uDPp7KcFzlbEWioloNk2ioyViwU6kSduUQAuPYg2sQc47tW2uHs2U/eypbWgBvLM75OIzRphAMtBtfs4PZZ2JVcSW49ZF3i6u6o X-Exchange-RoutingPolicyChecked: r+2H+Hnz+fHtL0aXW0aHB8U8mq7MYrxqwwkI452aMbJ1U6QEtn8yDH951RfejGJl27euwOqxI1M6R/D4QhKJTNln3Cejkc7azM3npnXE4quJaoGD1pqg3F4uxFNToEB9dOAwZ3+z+2+Kgxd3tESfNLD/06XshdiIHFsL/tnmP4561+Z5DH1lIvTtlSZaiQdh36653j+NAho6xlr+TNNwurb+Eik4lSt+2z2UBri0Jp7EN7sbg1Sfl4isiD9E4nsrUKDZ9Mex75HkzR23pOyaEyY+WbDeA+sBgAXwDAp6mPPFoRd448NFMqJjJAJ2UZGGne9c0yv+Ecs3NwZ6JfFwYQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 15:42:37.7234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02f64f9c-ac2e-4dc0-fc1c-08df0dbfcf4f X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F64.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5864 X-Proofpoint-ORIG-GUID: ts_RIpyo0eK8uDm7ewzoqxiDfZXVJu7H X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX20cQfjGRUMI1 wGzXxX39Ik/CLk/EXGoprknc+HFJ6jzznFX0aiV+Z/PyqMamCCIeea9yNR7s4OMa1+FofDsetrn Y/kAGFjs3q+p9NL6EiD+SaGBuKcat3cCgodhTqHadlqq4h/ChYOJlaXdl53iaMGbJpJ6P8eXNWQ o433PwjUSVwwdyi/d44C7VcYeb4gTy5U8w3cbRYju8aAvxpQeSQ5PX3IYGv9WrIL9/BW6EmUFie KjQUNQ6+r9BKhvCxti+LkevrjjCQaivzVb+1zFdk+S1EbLYlQ3iYoa+0zZdBQUPoDhq67F5a7qH e1WcbFTM8nod0128GZkwRY8xD2KK2MJ3JUAXPECBqJ44APBYTthnuhcCEBnzlLRqJ3GCBAgzChB /+m0HKxPaIqCXEDmdzoOJjzkktg51hKRirPBq/4avM3K7TwZXzrpVMy1ptM+VobiGNfutt+24jI /svArhl9qw3emp8AF5A== X-Authority-Analysis: v=2.4 cv=UrNT8ewB c=1 sm=1 tr=0 ts=6aa02d30 cx=c_pps a=V+mzYH1ZSfwt9Wwm8MCB5w==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=50gAi1W1AAAA:8 a=eUdvuMK_en-A6lLaKTEA:9 a=bIAsa0K8HJLRn3BBPJ--:22 X-Proofpoint-GUID: ts_RIpyo0eK8uDm7ewzoqxiDfZXVJu7H X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfXzaBuRxAfivPC ynNGnXVVC94n0Z97x8KeAPlXwSk78iUdJCWsMx4ewmsKSf2Ce4isKBpQ4wBruIrJ0tK0s32wJ2l NCNY9ayyydhsuOpCr2HGbi2QG8HQxWc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080169 Content-Type: text/plain; charset="utf-8" These are passed into omap_i2c_{receive,transmit}_data() but are never used, remove them. Signed-off-by: Andrew Davis Reviewed-by: Andreas Kemnade --- drivers/i2c/busses/i2c-omap.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 72f979eec7311..68b0a043f1e51 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -993,8 +993,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *omap) return 0; } =20 -static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes, - bool is_rdr) +static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes) { u16 w; =20 @@ -1014,8 +1013,7 @@ static void omap_i2c_receive_data(struct omap_i2c_dev= *omap, u8 num_bytes, } } =20 -static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes, - bool is_xdr) +static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes) { u16 w; =20 @@ -1119,7 +1117,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap) OMAP_I2C_BUFSTAT_REG) >> 8) & 0x3F; } =20 - omap_i2c_receive_data(omap, num_bytes, true); + omap_i2c_receive_data(omap, num_bytes); omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RDR); continue; } @@ -1130,7 +1128,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap) if (omap->threshold) num_bytes =3D omap->threshold; =20 - omap_i2c_receive_data(omap, num_bytes, false); + omap_i2c_receive_data(omap, num_bytes); omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RRDY); continue; } @@ -1142,7 +1140,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap) if (omap->fifo_size) num_bytes =3D omap->buf_len; =20 - ret =3D omap_i2c_transmit_data(omap, num_bytes, true); + ret =3D omap_i2c_transmit_data(omap, num_bytes); if (ret < 0) break; =20 @@ -1157,7 +1155,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap) if (omap->threshold) num_bytes =3D omap->threshold; =20 - ret =3D omap_i2c_transmit_data(omap, num_bytes, false); + ret =3D omap_i2c_transmit_data(omap, num_bytes); if (ret < 0) break; =20 --=20 2.39.2 From nobody Fri Sep 25 20:47:00 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DB69566C48; Tue, 8 Sep 2026 15:43:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882189; cv=fail; b=LrXX29Jy+UpPdZeEV2WKyIdMVKQ+dkzs9xL13GuFhmJC2EKuW+vEJVhzFywl1wdfWNQ8Fj0OWyYSb4eOlplCAKbfm+FwPZNV/Rz/ksKBdi5CNhYKu9VVPbTtCjErAjjNq36MpRTi4IKMuxh2nodbPukuTKOBlqYNT0xJ3+DWarE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882189; c=relaxed/simple; bh=D3vWuoujBubp5bT9ZHDQeih/pkyy+vORMKoxxQ99wHU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PtQ2YX8kmNQ8qyL8UDYmwanowZFw3IXBG/Ensjx1dh5+T4anxu9s2wo+qVRDlCWNzRkOrtWwNbdWQX17gbYaL+MmQJ9Twyze0ZRauDDlS0j7+FL7uoe5yXb3RRRzNCL4K926MSohxFIvJWzC9qij484RRVLdXflHHuwsOXfzb2s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=N2u9rj/P; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=uqu/46kk; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="N2u9rj/P"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="uqu/46kk" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688Eloog1845540; Tue, 8 Sep 2026 10:42:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=wBYMysOBsG3Mpnztt/jp8rqcUrVbJ5vmIz1uOCkQQ 8k=; b=N2u9rj/PifGFGUYmXVFTljJu6adAil8yrmS6IEan89DOLTq6ZM6hyvK6U LOUOFmTtFaN3AGDw8R2hxkFzBUN/2jSl6wMUOnFom7BjSswGb1c2O3DwYY1xMd88 6ohIJo83ZjxTOIcS553ZKKyhn/vRf5m9v4F6VDDJyFG4FbZpVcljCKBSjWCuJzlm bxJO8FUew3H0dxYnvgn/RK5TytyapqwDhWcLIMHKPIU4lTAPGyEfa7SabHmZE3vj 6pQwguLsDZVCesGut2ZnzPzI5ThpHwc4NDCfTDUyhD3BPd77nJQB/CJpYnDRPHOV 3l8DUCTiMb6SV4DAoZwRAKaMeVYzQ== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012045.outbound.protection.outlook.com [52.101.43.45]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gj940mxxt-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 08 Sep 2026 10:42:44 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jtnWYmYz922LT7edljOJ5yah5GGyH5QxYdyWOBv4nN93YdxHAPfYMNiSf7eGOYD7EoRbOrkKCAsXCQnzxKO+PSVOLd1SGdjOGrZTMUc35E1J+NKN3X/ie7mvx9vV0NO0VgJSCp9MOz0SwJatU7Y2YJtAvQ46wQDPQlmYL9KcYb2qxO5wOCMdTCyHguJgyYjkmg3nbwH3UeYQpEaWjp6uBIMf4NYoTOGJZ1e6ATnqyjbrAubmyt2v/GiNKhRuMK3bfxaQ2d6g+I9sOm0D5Hdt1RAsAHWS/92GMrkw8BjkngugdAQfQ8D+h5o/lv5Kg0O/41IPjaXh08irF8nXg0ekKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wBYMysOBsG3Mpnztt/jp8rqcUrVbJ5vmIz1uOCkQQ8k=; b=WVO/fIs//FZeDUnh8tlsqhFDQUN7hcnFfU7ywjRAqpZYu4cSgshxetrlXNMdgkSYmJTHE0mEXGiOk4FuhxjNfcpWDF+WRGP7c7QE+1j5QjfQ4kHPjMXfnM98TaKbksKkF7oxjkh3SKvBy2LVR8KQ3TSpad2jVXQKqMYcZkPboMn1c3ipa/S4/rUUWs09ab5IRdbUcUvSb6QIjvprYvhveDcYm+tHSzkYGXgHxgcDz48PdudwzFLKnGnzYMmoODkL8QtYcfM2o/ENlyN48EFDI/SCh8VZD4Xu1XShLwnlWk7PO/xiZuq7c1QzXduRyixbKqCNdg9Vq0Wur/LMFya6TA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBYMysOBsG3Mpnztt/jp8rqcUrVbJ5vmIz1uOCkQQ8k=; b=uqu/46kkfuMs7SQ7ejdc5sdeNFoM8BKgYYsSmHQC95yJnfUdQ+meaXxj6Yd+cD66840cY+I+ziNmVZEqxzW5W4qRAzdvCBY0eUGuryZ5YfLeraWLdcPA/q2mDMauWRb8jmAn+eYQypXwWWfdIxbwpGaE5OKQl86aGRBogZRco0M= Received: from CH2PR19CA0006.namprd19.prod.outlook.com (2603:10b6:610:4d::16) by PH3PPF730141699.namprd10.prod.outlook.com (2603:10b6:518:1::7ab) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Tue, 8 Sep 2026 15:42:36 +0000 Received: from CH2PEPF00000148.namprd02.prod.outlook.com (2603:10b6:610:4d:cafe::6c) by CH2PR19CA0006.outlook.office365.com (2603:10b6:610:4d::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Tue, 8 Sep 2026 15:42:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CH2PEPF00000148.mail.protection.outlook.com (10.167.244.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Tue, 8 Sep 2026 15:42:36 +0000 Received: from DLEE213.ent.ti.com (157.170.170.116) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:25 -0500 Received: from DLEE202.ent.ti.com (157.170.170.77) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:25 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 8 Sep 2026 10:42:25 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.33.213]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 688FgNWd3725209; Tue, 8 Sep 2026 10:42:25 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH v2 3/8] i2c: omap: Use devm_pm_runtime_enable() helper Date: Tue, 8 Sep 2026 10:42:18 -0500 Message-ID: <20260908154223.116074-4-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260908154223.116074-1-afd@ti.com> References: <20260908154223.116074-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000148:EE_|PH3PPF730141699:EE_ X-MS-Office365-Filtering-Correlation-Id: c0f9262c-3238-46b8-a3fe-08df0dbfce8a X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|376014|23010399003|1800799024|18002099003|22082099003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: Wmpky1vZOF6VL8mUuZnCgbvmeVXBWKg4JEfQl4UftdDFgjvs7QqXsqUC4He27+y0cHUqvb5yE4y+XCo/ZZ5HVSzt3ikgw/7UZ59baXeTTNGMYc1EYARyr5usYb1/IoF4tF3i5p2Dyoi9lldPlTZo1CFRzUhGTe0sVD0zhid4E01NZ+W1K1I8mpKNrAQzMWcu73HVXnOCNN2pK3zZKf0OaZGuwTio+j7uRUv88OKLNli0iPq0ZI3yMkOy4ofPPvJt5I0hv5fXf81VX09uPvHba9xdQJSv7N8UEHRW5wLIAmh2+oIH9CadSsR/qxCUt2Xo5DNlH8Zq0Ry28PEIOU6OU7USowV6TyXwH612JQGFifVhIFfpxikCW2Zqs6gh0FQuq3UNwG/Qsj5HuP1xLG08wjz3PKRr9QcARcWcM5ZppUpf/1VHQOFOOgz7h/1S3e1vWDyGf2l17sW7a6JwGy2wcgkz7QCmAtVucPxYh3ZV5u6N8Cu+2gCbbAxmK7q8Q8pg9FGyNaJPZvE5+y2LIDecTExW2Qq4UkmZorHp5nYGDv/9CukcdbHN7N93gPi38dFFVyNt0rJBrPaiyhL9tvNFvbkloOViyMEYJuU6jKb0luMnjXpCBkNmD9uVIoEBqphriow8uSOu/MqwPhdVeVfn6hZ8BOxQH2IPzJ9WumfKf4GHCZuFrRbJlM6pMFBcAiCvZ8S6zO/XLJzYgpMpFpxmKA== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(376014)(23010399003)(1800799024)(18002099003)(22082099003)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: weLJvrmpIfv4qTvT4gZJZfx28g3zsiAvc9p2FiI/4zP1RCsyMoCo5ciaNPQsx7viEaTsBGHCJPjgzIIwMmwxbi7yRxYOo7k06V62B28i5lS9XebMEbjoBH9Dchy+r3k5PO4JcFM2dF2aPnlRxU48qf5CgYeschii+KyPofDLP2d1J9UNuN1BE6TBfN8waYvrL0EFJeUnjR8+fw8YIZBHT1UcWuV/PfCGUtPJYwLzQPapxmx8LTONshmXAiiajZFtLGG3RHuj6BiTOMVkAbB6oYKAi2N02gNgNAQ5+PSArqzZD85MekcqEkJCWUzMdXB5dDekpKH9HrYrtomv/2MzkCWvVwCzNQi55/vobmb0U4dSwKQ5sjJ1JvEnA3WjilbHS19OtbR/Wq4DU1IgX8+hPDZQkdLbcncTYi0wAH/ngGuIxBhQ1lgQwlaVcaKtpy33 X-Exchange-RoutingPolicyChecked: q6rFHJGTL49E5r6/MoGOVJHCIOlY727aXRaaUlW1rnOnmp//OOTHlTbyEi+PkBGQBuoTEu/Ch8SpA8dRE4ZH5OlIJaCsjRwIym9vxYq+llZqRKlwxLYWwVOb5HWer7IQzMYbA5tapSVBCYjBqku3xELSbCKoieQLzPbNfgyePmXFUQJc26PQNl2cqmQ6qQFNs+L2OHWmAgRc+KKbAf0EVdUF+J17WFowr1crbwuR/P2eegvFKfPfVx0jAQfCJO0LUtPimgLbQ8uWEEqXMK32gH1GX3hucrbN/cDUlTaJ0Zw+oXlR/xkHHR0kCkTofmRXVjyZo9uIY+4IY2Kmjm/Siw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 15:42:36.4054 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0f9262c-3238-46b8-a3fe-08df0dbfce8a X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000148.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH3PPF730141699 X-Proofpoint-ORIG-GUID: t7OdWvQ-libYUJ_1xnGMceNksPIAJQ4C X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX0S8FX+mSHpsa 81t6cyDwALi5vkEJudSsqjaA0K6Ficzh8XZ9z95Wpn37SLngylNaQEJCw5qGwZWfhmubTqHixMS 7HTrvP2TpIWOKzdvbajSmtj6YpdkqJH8zHu36azfoboWbuPfcwGwLdTULHkJ4yEA15eOPm3sOVE tpSvLzCiJweyalq03MBGL/Y+WTOnYRkBaiheKPastAANGyijgbg4WhmmrAXV7QJcAw4CT2rzBEh 858vowUTxozZw1Hq9n2dEQPibfYc7HkdJu8KUI4Svys1ZDjdcn2S8pSiAgo78Z/wXxom0Yr5NIn 6iGWFL1vFtt6v+CHQJE48rPb64s2qdsXYdjiNJ39dlwCwLzpk7Nri7P43yTVVbQ57Mw+MYQ/+4R OMcOJmzMvMgGOQmhtciTiJpqwxfNaURQzOoViCqZ6f+UVzbknQ85ixcCGND0OdQrvVlm5W20E6b eu6vCXMvg07XnFX16lA== X-Authority-Analysis: v=2.4 cv=UrNT8ewB c=1 sm=1 tr=0 ts=6aa02cf4 cx=c_pps a=xqIz4pcv3YTcvFGvps39jg==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=c0zHu0wbgw2R5NnQJfYA:9 X-Proofpoint-GUID: t7OdWvQ-libYUJ_1xnGMceNksPIAJQ4C X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX6F5J/SA6MNxU VQrgMTzagR3iV6SY9i8qsHnln3oODcsqd4nmDxaoNUkoaKbsnVlMg5iIkzLXkZHHhubFZNtqArX xdBIy1VcqaypbPG6tO6Ft0m9j8u+KFU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080169 Content-Type: text/plain; charset="utf-8" Use device life-cycle managed runtime enable function to simplify probe and exit paths. It will call pm_runtime_dont_use_autosuspend() for us. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 68b0a043f1e51..e03519d939755 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1376,13 +1376,13 @@ omap_i2c_probe(struct platform_device *pdev) platform_set_drvdata(pdev, omap); init_completion(&omap->cmd_complete); =20 - pm_runtime_enable(omap->dev); + devm_pm_runtime_enable(omap->dev); pm_runtime_set_autosuspend_delay(omap->dev, OMAP_I2C_PM_TIMEOUT); pm_runtime_use_autosuspend(omap->dev); =20 r =3D pm_runtime_resume_and_get(omap->dev); if (r < 0) - goto err_disable_pm; + return r; =20 /* * Read the Rev hi bit-[15:14] ie scheme this is 1 indicates ver2. @@ -1496,9 +1496,6 @@ omap_i2c_probe(struct platform_device *pdev) omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0); err_put_pm: pm_runtime_put_sync(omap->dev); -err_disable_pm: - pm_runtime_dont_use_autosuspend(omap->dev); - pm_runtime_disable(&pdev->dev); =20 return r; } @@ -1519,9 +1516,7 @@ static void omap_i2c_remove(struct platform_device *p= dev) else omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0); =20 - pm_runtime_dont_use_autosuspend(&pdev->dev); pm_runtime_put_sync(&pdev->dev); - pm_runtime_disable(&pdev->dev); } =20 static int omap_i2c_runtime_suspend(struct device *dev) --=20 2.39.2 From nobody Fri Sep 25 20:47:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15809563FC1; Tue, 8 Sep 2026 15:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882202; cv=fail; b=juFFKWjjAmZt2w3tMfII5XD5pUR61HDaeQnmcJe+JyllavkVts6DWInSBKmnNNOzNafw6JHIxsZjmqDxx/mOWnb6lsT244loFmwm+/dgsly1J3t6fMS3E8coVr5I9+yzIgN71gxJu056PnL+WUTWyrQ5RYcRghJi44hs2+s4Sgk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882202; c=relaxed/simple; bh=zRdXX2S7cfFWaed8buWY1oJSQQ+1NNUG+ZARWvgYeJQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rtHahEMkOtH98dV66fCaP6bjp7ut3axIc7xKnMkZv2EgJF3ScKY60JRbHzXR/OhhnTvK2X9rd5PymOpezkv2V3+xrV0lR5u/yjlB7myrARmyjCuq/e82Xh1gPP3EK9AM+lfzYvhSeYMu+V8NbWlDHqIuw14FYePvKLUyS7+FZZk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=j1yiVcBf; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=iwGbschn; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="j1yiVcBf"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="iwGbschn" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 688Ejwf62032955; Tue, 8 Sep 2026 10:43:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=K7POOkoENI7pBO6nO+goDRRn5n4Glh+Ta45eXMG4r N4=; b=j1yiVcBfqzce6x8Jmv8vUHg10P2ruFPTrC3lbz+FwAVQ2+LMMeQ67bpcx N/kTfS74sN3Tds3jlnkG8XqLDmP3rEJQiOtnbiqFcSekG9CcqLLWCcXsmjXypZZ+ e6aXs0qXprnnPU9BsTPh1jhHPPIF1w3vVZX3MQ0OQhGuQafjIv4fovQykemR8i4v CYN9NfD+5j2CrEG4Qbq9Gv8jtiaQqzxygeO8IJcfrkj5HMRM9PQ6Z4FiP839SygD gwswq2Oz4YopoSFoYHJnkki7vZXqAfeyWPByfUYwfxe+n3XPBr/FJKUFY3mfVAHs VhV05SdNXZkmoz9Gww2POBDMZrhOQ== Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11011014.outbound.protection.outlook.com [40.93.194.14]) by m0380145.ppops.net (PPS) with ESMTPS id 4gjffmtbg6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 08 Sep 2026 10:43:09 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UQmlgm7fq18x+HU+PzslJ3/OUFmOpA23pQ9zDv/xxT7vHHBPEQd1gf3dP1/NgayWIolAUOdPzCAuLkmJHqsYhAM6Wz+UkWvagJC6YTSVHdfAQvB29iqsTNb4Qvx7eWfJrvdpiHgkO0dc6V0/10wk4mpK9CSQB9bPOLEFHoxnVcS+bdIOjzQaV3cmbIstcbaO6PlxXlkeODGSvTksRVgGzE+ldcIspXeh5uUb1fWewtwP4quN0CKEIbxLbXnmqrLLHWKSuEwc5GTwMDaU2/L3Dlg911Wo5Nb/6zjUyDaP4vVYGLefMmN4x66x9HGPB3t4zNvHr1S4hROjQEXTrpIWUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K7POOkoENI7pBO6nO+goDRRn5n4Glh+Ta45eXMG4rN4=; b=ntFLmo1kvP/iW5ilfRaie/vBx+VH09P6ynJYNU3w9Qur3KWwMLiioe8kJMv5JAbq9jYd8850ec+bJ1zedA3KOl0rmiJMuQCT9dVKcJztUpnIS3NBq+N2l6ETQL9gllKB/NtkAs0YKqUnmMRfsypXTqi+rZlZAClhg8dbyML8gp5DFVTZP4Re0aknYtRrldAfNDXx2XoTOZ8vUUP59zxbB597diLHowo/R9sHNqNtHYmGhehU5OMe/ewtxfwctrLFCM4/hr8jsjbWfHO+M07sr/jpQ8FM6NhVsygmU4wzO6iIOmD0xptU10ZEQoYsv4wM7d/NfDjeAcABm/2/vACXvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K7POOkoENI7pBO6nO+goDRRn5n4Glh+Ta45eXMG4rN4=; b=iwGbschnYQjOm0ZClzN8LQycSezdRN1RTEN9bqo2lFWBIu3Ehz+anoOcEskpbpRQ0QmVirue4uCvdOqMx96LGNEYgtlbv8cUve3cOmOPy8Tp9sLGPxEr/o2otkVII5Ne3kMQXq3QIPelj4I40QWyB5lkeQJg3RkwrIyw/NYwP+s= Received: from CH0P221CA0038.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:11d::24) by BY5PR10MB4225.namprd10.prod.outlook.com (2603:10b6:a03:20f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Tue, 8 Sep 2026 15:43:06 +0000 Received: from DS3PEPF0000C37C.namprd04.prod.outlook.com (2603:10b6:610:11d:cafe::6f) by CH0P221CA0038.outlook.office365.com (2603:10b6:610:11d::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Tue, 8 Sep 2026 15:43:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by DS3PEPF0000C37C.mail.protection.outlook.com (10.167.23.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Tue, 8 Sep 2026 15:43:05 +0000 Received: from DFLE208.ent.ti.com (10.64.6.66) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:26 -0500 Received: from DFLE208.ent.ti.com (10.64.6.66) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:26 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 8 Sep 2026 10:42:26 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.33.213]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 688FgNWe3725209; Tue, 8 Sep 2026 10:42:25 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH v2 4/8] i2c: omap: Combine event flags register definitions Date: Tue, 8 Sep 2026 10:42:19 -0500 Message-ID: <20260908154223.116074-5-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260908154223.116074-1-afd@ti.com> References: <20260908154223.116074-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37C:EE_|BY5PR10MB4225:EE_ X-MS-Office365-Filtering-Correlation-Id: 3707c6d9-3f4d-4d6c-e4b5-08df0dbfdfc9 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|23010399003|6133799003|3023799007|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: CpRoDRSTZQXFKBrIxV+8dc/SLKgqZste5wTpWdxyFzw4MdK6pfxDUAC3CG+rm3UCtLygw56ND2AxxaO3YnUW0nriFMbPe8hGgsitlwjdMJkvX+KS0L6+v/rJs1goW9/onqp46VEG34j3yRM3+vvYLSmM6xsIFyS++s+WoKpyYjRlqA9THkZt075P7t5da/U+1MJb2ZdsYoJ65nUuAxGA0H2R/6NiEFvyk/RpGe/9YGG7t8SUXZC9WzE0v8b5nKvFTUtUoSicaqodOBypJfEuCwL3kcuvp8JmXMjaHCsPWNrXIJKt0wryGsbAnpYQqHEfkjqMQMWnOLIc42NfVQj/gzBUk+lO2ZBBhQh1BGte4rSTa5lAFEcLUAuQZddGJ3CKA836+TJXLp12twHSmX2VY8PLvseN2keJmZDqA0R4qOhGqSoLmCURfS1kY62e5eNeVHesPG0dtEhhgniBJoV+221Jh0fe1rqet0/rKnoelDhNh4vqt8iDov4h/LBrj/yhQ0/jQfh9TNUa7DU5B9PJ4s/WSU1X27DodX4Iq7I3c9tbckzfO+CkF7Y3vQESRIOVwkEoGKXOnxZQYVEqUtOAXysXgyDy8WfhaD+ePRCveL3DTa/9mTLndR3h1iq6ZdzanH1RE8QPEVbN1zInh5Ycln/KamxokvSsg/3dROtsym3gDVZvWQgNrOzTx8bHvqfEIiLY84fVCMJywHQ8RZg23A== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(23010399003)(6133799003)(3023799007)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ku1jF7m5bbJir8rQY6KYXVwxLWAR3RLGhTod9RAg+3ByliU/OXdyR8sSEr3F8I/inCDg3NlhGggo32V7Rmh1G9B2/T5MPYv9+yFjZv8DcvBfjhmC9ixWaizClD35mNdAzKySgY0LPiu0TAIz501sSlIMoqOJ8D03M4SR6eG25uiCIRN3tCbt3rbINGl+DOa5DLt0hNbPBkREEdTPQ3yZyEpCR9YVSEJzyEX8eGmbhgMX4g9QiYnQIKR/itZuzBrUk/7SvWFHTbiNXVsSAJhlOYqbxA7jQSYsUBz2NBPzC3kWNv/8XY/Ni9PW3vPQ/Q9gAYGbHtb+uYX7ouebp14lqO1j7f2UpfF7FMT9r498PaS/Q3VmJCta/GNzaQW3Mn9P64WGXuLtMTE8r3fYg1DKzcDin9QRmcT3aYXyzhOGos/YZZ58sOfHgXWdFeHkwbKk X-Exchange-RoutingPolicyChecked: aMz7rczu9ES9nb5hx4mxp8vw9eJsvzrSTPX5ntYQNG7dYMvwrCrbgOPYM5HtFzjCijxsPPsEM/H3OfR0bNLpMwUdT26ur8QQgp/SVZoLq39dcFSjAI4SAPX1bISOmDaLPjJ67k9JSe3axopZkR46oec9e9U956OawAVX/SpNYpZ6PvLxgBCkS0tub1sUjv01zPUYwkfdUzvzpmu0h4qtEdPP5D4kaEmS8+x1hKFwwY0SxEtaXKJtf6f3vy4fqMQ5VR6M+iHWSGJBnp9jLBRrVjzNiRVo35LJlBCve1iumPthzk13zyRsWwsltuyknDDiC6Q4I+rwNzTOK+H/7c3h1Q== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 15:43:05.3361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3707c6d9-3f4d-4d6c-e4b5-08df0dbfdfc9 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4225 X-Authority-Analysis: v=2.4 cv=FewHAp+6 c=1 sm=1 tr=0 ts=6aa02d0d cx=c_pps a=u5a0R1DJIqwdmu/eAz29vw==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=-VTgE4bae0sfXoRtrj0A:9 X-Proofpoint-ORIG-GUID: 3zT3d2WV8oVOskw_KvtoQylD8GBeXtRi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX0e7tyJ+gEeiP TX5cHRCV4itVCTVNuUs8MDAUzei3/4PKO87Y/AuNR7jY5Rno5j9lxOWCa6W0CtvYlYwpBqVZQea MRPfQDGKgPslNSYopWSlntdZMWUUoWowU20wcD8YHf3Y8G04HiLKpgScZLuOom2s7GmCcAVZfdR Rrjz7JJ90GDB48OYIEfDnbmbGlOG7ZE0snrLhlV5/lMCbPLS3HqUJyCIFuzN41SXSL32sf9y+1h CevaVInWS5ePRaUFZxtgr4e6h0lpE+VvJttuoVudnjZGBR8nRGR9vrmj88jcomhE0uJ4zm9+8MV RJVXT3bvaU0aWugS7vk/9p9maA1wy7XPRqtfDCQinExJnjO4ynNmeLo04u3+efDQs+fTN5RG95k 0dm/aqC6h4jqOY4fvm7D82pdGmjBGP3IoZcku5WXd36ouTjU4bbAPGr/+vXn4tq3SWMk08MnvpW AP6S0qYR41srIpBfNGg== X-Proofpoint-GUID: 3zT3d2WV8oVOskw_KvtoQylD8GBeXtRi X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX8jFxBw5LjLp1 DzoN6LjjdJCggclVZ/EPpIaEYmpuExbyWBzX6wlS9cegn+wf3sdDe/R2nfU+NL6/UxyjoroBQX+ 9Nc8gKKNe4PPuPIre1i8HjkDGz3488s= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 impostorscore=0 clxscore=1015 phishscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080169 Content-Type: text/plain; charset="utf-8" The position of the status, interrupt enable, and wakeup enable bits for each event are the same in each of their respective registers. We only need one set of offset definitions that can be shared. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 58 ++++++++++++++--------------------- 1 file changed, 23 insertions(+), 35 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index e03519d939755..cc65dc90770d1 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -78,16 +78,7 @@ enum { OMAP_I2C_IP_V2_IRQENABLE_CLR, }; =20 -/* I2C Interrupt Enable Register (OMAP_I2C_IE): */ -#define OMAP_I2C_IE_XDR (1 << 14) /* TX Buffer drain int enable */ -#define OMAP_I2C_IE_RDR (1 << 13) /* RX Buffer drain int enable */ -#define OMAP_I2C_IE_XRDY (1 << 4) /* TX data ready int enable */ -#define OMAP_I2C_IE_RRDY (1 << 3) /* RX data ready int enable */ -#define OMAP_I2C_IE_ARDY (1 << 2) /* Access ready int enable */ -#define OMAP_I2C_IE_NACK (1 << 1) /* No ack interrupt enable */ -#define OMAP_I2C_IE_AL (1 << 0) /* Arbitration lost int ena */ - -/* I2C Status Register (OMAP_I2C_STAT): */ +/* I2C Status bits (OMAP_I2C_IE, OMAP_I2C_STAT, OMAP_I2C_WE) */ #define OMAP_I2C_STAT_XDR (1 << 14) /* TX Buffer draining */ #define OMAP_I2C_STAT_RDR (1 << 13) /* RX Buffer draining */ #define OMAP_I2C_STAT_BB (1 << 12) /* Bus busy */ @@ -95,29 +86,13 @@ enum { #define OMAP_I2C_STAT_XUDF (1 << 10) /* Transmit underflow */ #define OMAP_I2C_STAT_AAS (1 << 9) /* Address as slave */ #define OMAP_I2C_STAT_BF (1 << 8) /* Bus Free */ +#define OMAP_I2C_STAT_STC (1 << 6) /* Start condition */ +#define OMAP_I2C_STAT_GC (1 << 5) /* General call */ #define OMAP_I2C_STAT_XRDY (1 << 4) /* Transmit data ready */ #define OMAP_I2C_STAT_RRDY (1 << 3) /* Receive data ready */ #define OMAP_I2C_STAT_ARDY (1 << 2) /* Register access ready */ -#define OMAP_I2C_STAT_NACK (1 << 1) /* No ack interrupt enable */ -#define OMAP_I2C_STAT_AL (1 << 0) /* Arbitration lost int ena */ - -/* I2C WE wakeup enable register */ -#define OMAP_I2C_WE_XDR_WE (1 << 14) /* TX drain wakup */ -#define OMAP_I2C_WE_RDR_WE (1 << 13) /* RX drain wakeup */ -#define OMAP_I2C_WE_AAS_WE (1 << 9) /* Address as slave wakeup*/ -#define OMAP_I2C_WE_BF_WE (1 << 8) /* Bus free wakeup */ -#define OMAP_I2C_WE_STC_WE (1 << 6) /* Start condition wakeup */ -#define OMAP_I2C_WE_GC_WE (1 << 5) /* General call wakeup */ -#define OMAP_I2C_WE_DRDY_WE (1 << 3) /* TX/RX data ready wakeup */ -#define OMAP_I2C_WE_ARDY_WE (1 << 2) /* Reg access ready wakeup */ -#define OMAP_I2C_WE_NACK_WE (1 << 1) /* No acknowledgment wakeup */ -#define OMAP_I2C_WE_AL_WE (1 << 0) /* Arbitration lost wakeup */ - -#define OMAP_I2C_WE_ALL (OMAP_I2C_WE_XDR_WE | OMAP_I2C_WE_RDR_WE | \ - OMAP_I2C_WE_AAS_WE | OMAP_I2C_WE_BF_WE | \ - OMAP_I2C_WE_STC_WE | OMAP_I2C_WE_GC_WE | \ - OMAP_I2C_WE_DRDY_WE | OMAP_I2C_WE_ARDY_WE | \ - OMAP_I2C_WE_NACK_WE | OMAP_I2C_WE_AL_WE) +#define OMAP_I2C_STAT_NACK (1 << 1) /* No ack */ +#define OMAP_I2C_STAT_AL (1 << 0) /* Arbitration lost */ =20 /* I2C Buffer Configuration Register (OMAP_I2C_BUF): */ #define OMAP_I2C_BUF_RDMA_EN (1 << 15) /* RX DMA channel enable */ @@ -360,7 +335,16 @@ static int omap_i2c_init(struct omap_i2c_dev *omap) * WFI instruction. * REVISIT: Some wkup sources might not be needed. */ - omap->westate =3D OMAP_I2C_WE_ALL; + omap->westate =3D (OMAP_I2C_STAT_XDR | + OMAP_I2C_STAT_RDR | + OMAP_I2C_STAT_AAS | + OMAP_I2C_STAT_BF | + OMAP_I2C_STAT_STC | + OMAP_I2C_STAT_GC | + OMAP_I2C_STAT_RRDY | + OMAP_I2C_STAT_ARDY | + OMAP_I2C_STAT_NACK | + OMAP_I2C_STAT_AL); } =20 if (omap->flags & OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK) { @@ -459,10 +443,14 @@ static int omap_i2c_init(struct omap_i2c_dev *omap) sclh =3D fclk_rate / (omap->speed * 2) - 7 + psc; } =20 - omap->iestate =3D (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY | - OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK | - OMAP_I2C_IE_AL) | ((omap->fifo_size) ? - (OMAP_I2C_IE_RDR | OMAP_I2C_IE_XDR) : 0); + omap->iestate =3D (OMAP_I2C_STAT_XRDY | + OMAP_I2C_STAT_RRDY | + OMAP_I2C_STAT_ARDY | + OMAP_I2C_STAT_NACK | + OMAP_I2C_STAT_AL); + + if (omap->fifo_size) + omap->iestate |=3D (OMAP_I2C_STAT_RDR | OMAP_I2C_STAT_XDR); =20 omap->pscstate =3D psc; omap->scllstate =3D scll; --=20 2.39.2 From nobody Fri Sep 25 20:47:00 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BC7C49365C; Tue, 8 Sep 2026 15:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882193; cv=fail; b=mdxWTT1seZp3bD/iqt65ENua3XfhE/NXw4bXAT5RXS0vztEHOPHg444vDvm1Lv6xNix4c6z4ysLm27gUzcd1uojULYaxgT5qJh51pF6I9WJpPIjyuBCaohueEBb1VuGIEHghChTe37XYA0SFiYx06trwtC8hMRszmNSzUhFcvEY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882193; c=relaxed/simple; bh=ZrCc1gcWNacZb+POfeYK99JH79xugcmevydTqlbdg4U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Py7qgrWP/VlIMD8kCyXIr/dicAINusHHbvb+WVUQm0dsy07rZq90dCzHWfhRkoIvTfLisTf9aYyHnVZnYv992skfqbmq9FPHyH1gyGc/DMXGpCN9cEj5calyZ3//PUbpj9u0x/KKdpJMpt/Re6aL2N4v/33G9UI+nrZxQAb3RPw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=RRh1cgr2; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=KEEvhHGX; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="RRh1cgr2"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KEEvhHGX" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688ElUBf1845098; Tue, 8 Sep 2026 10:42:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=vPwoOeeVYXkOm95zJLw/3AUi6/evQS2lJN6KFGBIc HA=; b=RRh1cgr2fNzhH+C5j4f+gr8F3ADV+H9+UpUhboxH3BUkLd7xKXPvoJVtd jjukV1RuT8CnQs/mFdJMn43eMpXo5sqlbPuVWLSu42rj34fWDeFfzQv44SaidqrI NRQNPYHMfzkMbAxNip0zW0Nu8o5/gWxYBDrH7j8BNI6L4ARkPuzjfIpteVmm7AGA 8Og+1VNsIwOj7VDcytLbopV4/HShFCIg/0fz7U5W2k17zA0XqLAwn51J7XE6liJm z7ptqXwvHkS1jVE5e1k7HrFrByNkk7MEYxAYKgRk8t7AxyA/wft1DXZs3xd9O0+N wnYMMIL3xYBWs+vNqjan0D4GuH4Uw== Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11010067.outbound.protection.outlook.com [52.101.193.67]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gj940mxyu-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 08 Sep 2026 10:42:47 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u3Ro90SBUYDV+oSrEpN8zta/vPCwlH+u69JqcpOo2wfPGKKIReki+tW81ly6juNNn1JbEjyLtZeYAePZb0+raluHLk1giX+ZA2Onvw68/YLyCrra4yci0mbfAYeJUPWyELPnLPdh5dtbdbXzXU+VV3GZvFAmagkPgTM0BdXYkDq+SOx2ZlXhEFSgMuInpueEaLU3ucUoTSB7zh9D7Ko/4VkwMmvAclG8RHekncVDXfuv2dDHRlHiDMt6Ag2N5x2xUTPrqn/ltr2fnLmbIoPGSXFFeytS8RTLaZGKOjuhOS9gTr9g2+FnRPdNg7uRrFduy+9OJLWfs/B04g3X6ILGGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vPwoOeeVYXkOm95zJLw/3AUi6/evQS2lJN6KFGBIcHA=; b=y1BhafDU948wKb34BUxHAWpKSC54tOzGuSlA1kW7TtRGn1YK9san0gkq3Fz1n2EHZDxDGq4Qmw7I7p3i12kZTf35rbbGatxULRgZy7Pmz0gPVUaJf7MRY3UFFVuEo42SWJhp4vUsZ7GRwEynonqC7oOtcqi7hkwa8O8jIcwKmpMJgFrjligTzXqCxhxSzcyANHw0AXVoQY0lnJQHe5bdajupBeDmLBZAfV9i9u6Yg1RPQiFRf1mIUjm+ljnKAnp0MlUGBVFBYN019uBnrYllWpddsbWT/5sK4YHuBKf5txKZz7z7pxSSMf2xC4DUgGKtSDe/Nf0dkMWT+JT14xf6AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vPwoOeeVYXkOm95zJLw/3AUi6/evQS2lJN6KFGBIcHA=; b=KEEvhHGXOpD1vNE9LBGiA9jcmx6lIk6WNzni7HomN9VrHuqzND3bwPi8AnRGfWYLbo+0TP6OCtu6L5Ju57xukdtIDYq17kMEkNM4JjNvD4tQh9cCbqFnp7G6ff/3LYVuDebfG4VGvWtqDNN3TUb6g1gtn/fAviM/CCGzSSaBb9I= Received: from BY1P220CA0049.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:59e::15) by DM4PR10MB6717.namprd10.prod.outlook.com (2603:10b6:8:113::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Tue, 8 Sep 2026 15:42:39 +0000 Received: from SA2PEPF00003F62.namprd04.prod.outlook.com (2603:10b6:a03:59e:cafe::7a) by BY1P220CA0049.outlook.office365.com (2603:10b6:a03:59e::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Tue, 8 Sep 2026 15:42:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SA2PEPF00003F62.mail.protection.outlook.com (10.167.248.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Tue, 8 Sep 2026 15:42:39 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:26 -0500 Received: from DLEE202.ent.ti.com (157.170.170.77) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:26 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 8 Sep 2026 10:42:26 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.33.213]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 688FgNWf3725209; Tue, 8 Sep 2026 10:42:26 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH v2 5/8] i2c: omap: Use bool for flag values Date: Tue, 8 Sep 2026 10:42:20 -0500 Message-ID: <20260908154223.116074-6-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260908154223.116074-1-afd@ti.com> References: <20260908154223.116074-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F62:EE_|DM4PR10MB6717:EE_ X-MS-Office365-Filtering-Correlation-Id: f0d65466-454f-4d62-4c35-08df0dbfd06a X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|1800799024|82310400026|23010399003|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: AU1SWpr9OyrXCYMU/tSMwfJmlh+2/tZOf6R0ocVOedglgyg+fcATPXKwSGtcYXAvNDPLxri47Dvysw4CpVeJKAMUDyMytwuJzSKM8cmPclK2IUdzPPET+HmGVcNERsxs8vO7y4W8LLUR584fR4MrEBAIx7Engh8d9X+lIiqQGpmcEeBKXlInry9DHw4FcL5z9Sg4fZGzBOo6AESOIEULH2/jMLyOe+MCZbjn0QeUNB6NTrqibmPDyM5WqSz4Kl8XN0NN67y76Ai5p/XwLf3hD39lKUmT1v2KQzJH2Fz6lBRR8LwWxiaroIB3ESyU08MOfqHeigZrxbLvPJdhW2s0AgDMisbfO3QPFEuuNyNCU4qBZ5TL4HQ6IUu4Fp1Jts8S1do4OZnDpeTDGBVzVqMKZQX5Md0x17+MAC8q6WABzuQEwyTFla2ZBHUtoA9dNlj3MONdi4qihs+6au2SG/fqkmkWDMpmI3oCJdew/EjQ7y/2OPf2UhnJWut9tojql3NunQuV+o9vfPACb0Thaq7Dkmxy4GWFLzUN6qTcQ8QpX/svP7v7E9ArDytk1M+54ib4IanYxHP9Hoa9q8FVfcViXX75ng19G8MgsGyMriD6GW0btfjEJINID4e2DPfcCGNIvA626Q4l+3+hzTdZbI+eRa0udCO8lmVpdUYd2Ayj5LSGKAKorETHOQiddhu8ycg4TpQYY36+W9L46IJUENVvRw== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(1800799024)(82310400026)(23010399003)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Pt/xYmLS55CRWfvnlACWDL0QeN9ATpVRU9gffReNGFAujMydaXumM7BES9B+z9J7Cek75xmLU7czfS4LYOBcDexOCJeujl6mweVupBo0CTxvlQJfqjaFn5pMQC/b1Sx6qiPBUqa6D2atw6e7jxFk28/JEDZgl2cvTogG+8ipHUPQJ3D8S/SQdrRYB3xHwBVyIu6r9a+wo+nfgQlaR7NR8Lt+he0jgjwkYU8V4YjMasDLPg4+kB0wZb2QXkmZMDvi6T0xSL/R4UVNzULXyaVvWacQ/kIFdq+napeCFng+Zkow6EBK2+PanAP6oh4MYgZX8bd6perAooO1j1lR1i2ItUfsUzQSBL9GD5SxzBnfCTR7EOukwUH0y7nsQDXTtfBgZhDIaTcCahAtjRETJF0rqEibkHScV2pG6nl0l2zN9E0zAKnvrTxtXCHtUVcjgLhh X-Exchange-RoutingPolicyChecked: M+PNRWciA6d5i/8A5TvreAbnni/zQpH77r+5uSjtoZ9QC3Nck57TQKhylLHsEDFh9CgviM276v3HmrOuWLD2HPgTyO3Ui4c0BsgjEinvxS1hREVVMKqZtblbNi/0o+KRXXpwGHXMmAJS9wPIKENniAcQh+4uBibVQML0xLGRqxHivGLz4O9bz9s1Q5XA/7UZ62jPUV20IWoeqlOkq3inelmpMaJTEjgNdO409eyHeprbXxImpA2COEsu7Plan1xT1/puNP8JIztvXiM/CoP4omOM8EiOw3lxkVAXSkDOJJFiwSi2T6ro679ya8GKlf+4efvXDYZ0BxHN9IgSpRD7Yg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 15:42:39.5762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0d65466-454f-4d62-4c35-08df0dbfd06a X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F62.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6717 X-Proofpoint-ORIG-GUID: utOXRxPsb7T6KvFOpjsUMWxxJXVbvOE7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX4uAB4/7rCFkv LJyjI3uxzZdp+5I1quyS9EQCXnY5o0wqdR128JX8NUQpzE/OZZBPzGaDokSIfo+NCchC5BDY6ew kzUWl+KxFXEEx6wEoT4//QxN/j1aHUmKZyNcnxC2WEYLtY+7adgWT1Dp6vf5RMG0FcxRsIAHvaU jxVg8arOfXJdesLIRQQAS4r6WrDc0EQ2KbAsd3WITvG414ckdgLcfNUrJZwpTGGVcVYVN8AUTFX cT9yzmpKVKG+BS5wZF8miDCYstmgP0ZTevhdCTg+GTrxcxYgYVNukKTKX8UVVSIXFB00NpEOqpA KhN1qfeOJkii8bEY+A5EX2CiOgM3/bIHwoLKh+kQxzVhAeaX1OGo2hdPh6lh8GByEkXq3IGwQKZ Z2wSxvTCCb5ji4hmdg0dZvIgpAc20xqWXXubXFm6XbydidQeO4I+E7/w04dGwozOdxWT9yiypm/ /uVT8uxdIAUMVh7p3lQ== X-Authority-Analysis: v=2.4 cv=UrNT8ewB c=1 sm=1 tr=0 ts=6aa02cf8 cx=c_pps a=4Gx/Bq66bxzCWlClXrtOjA==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=vVWVvIjhg91t4kWa_skA:9 X-Proofpoint-GUID: utOXRxPsb7T6KvFOpjsUMWxxJXVbvOE7 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfXzCjcXOv6KdCc hy6Ozpv/e4RvBEFAlWVjXdhm7t3/d1obRm/jegmWm5GixIR2YT1JHW2v6BsZFeBQvHjFmrCV+Ix Z+1y+IRuxom5ItgIn2CwphAoiRJJCnM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080169 Content-Type: text/plain; charset="utf-8" C bit fields are weird, use bool for single bit flags. The compiler will set these to an aligned size in the structs in either case. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index cc65dc90770d1..dc75780f76c96 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -174,11 +174,11 @@ struct omap_i2c_dev { * if set, should be trsh+1 */ u32 rev; - unsigned b_hw:1; /* bad h/w fixes */ - unsigned bb_valid:1; /* true when BB-bit reflects + bool b_hw; /* bad h/w fixes */ + bool bb_valid; /* true when BB-bit reflects * the I2C bus state */ - unsigned receiver:1; /* true when we're in receiver mode */ + bool receiver; /* true when we're in receiver mode */ u16 iestate; /* Saved interrupt register */ u16 pscstate; u16 scllstate; @@ -313,7 +313,7 @@ static int omap_i2c_reset(struct omap_i2c_dev *omap) =20 if (omap->rev > OMAP_I2C_REV_ON_3430_3530) { /* Schedule I2C-bus monitoring on the next transfer */ - omap->bb_valid =3D 0; + omap->bb_valid =3D false; } } =20 @@ -458,7 +458,7 @@ static int omap_i2c_init(struct omap_i2c_dev *omap) =20 if (omap->rev <=3D OMAP_I2C_REV_ON_3430_3530) { /* Not implemented */ - omap->bb_valid =3D 1; + omap->bb_valid =3D true; } =20 __omap_i2c_init(omap); @@ -531,7 +531,7 @@ static int omap_i2c_wait_for_bb_valid(struct omap_i2c_d= ev *omap) { unsigned long bus_free_timeout =3D 0; unsigned long timeout; - int bus_free =3D 0; + bool bus_free =3D false; u16 stat, systest; =20 if (omap->bb_valid) @@ -558,7 +558,7 @@ static int omap_i2c_wait_for_bb_valid(struct omap_i2c_d= ev *omap) if (!bus_free) { bus_free_timeout =3D jiffies + OMAP_I2C_BUS_FREE_TIMEOUT; - bus_free =3D 1; + bus_free =3D true; } =20 /* @@ -569,7 +569,7 @@ static int omap_i2c_wait_for_bb_valid(struct omap_i2c_d= ev *omap) if (time_after(jiffies, bus_free_timeout)) break; } else { - bus_free =3D 0; + bus_free =3D false; } =20 if (time_after(jiffies, timeout)) { @@ -585,7 +585,7 @@ static int omap_i2c_wait_for_bb_valid(struct omap_i2c_d= ev *omap) msleep(1); } =20 - omap->bb_valid =3D 1; + omap->bb_valid =3D true; return 0; } =20 @@ -620,7 +620,7 @@ static void omap_i2c_resize_fifo(struct omap_i2c_dev *o= map, u8 size, bool is_rx) omap_i2c_write_reg(omap, OMAP_I2C_BUF_REG, buf); =20 if (omap->rev < OMAP_I2C_REV_ON_3630) - omap->b_hw =3D 1; /* Enable hardware fixes */ + omap->b_hw =3D true; /* Enable hardware fixes */ =20 /* calculate wakeup latency constraint for MPU */ if (omap->set_mpu_wkup_lat !=3D NULL) @@ -644,7 +644,7 @@ static void omap_i2c_wait(struct omap_i2c_dev *omap) * Low level master read/write transaction. */ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, - struct i2c_msg *msg, int stop, bool polling) + struct i2c_msg *msg, bool stop, bool polling) { struct omap_i2c_dev *omap =3D i2c_get_adapdata(adap); unsigned long time_left; @@ -684,7 +684,7 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, w |=3D OMAP_I2C_CON_OPMODE_HS; =20 if (msg->flags & I2C_M_STOP) - stop =3D 1; + stop =3D true; if (msg->flags & I2C_M_TEN) w |=3D OMAP_I2C_CON_XA; if (!(msg->flags & I2C_M_RD)) @@ -1423,7 +1423,7 @@ omap_i2c_probe(struct platform_device *pdev) omap->fifo_size =3D (omap->fifo_size / 2); =20 if (omap->rev < OMAP_I2C_REV_ON_3630) - omap->b_hw =3D 1; /* Enable hardware fixes */ + omap->b_hw =3D true; /* Enable hardware fixes */ =20 /* calculate wakeup latency constraint for MPU */ if (omap->set_mpu_wkup_lat !=3D NULL) --=20 2.39.2 From nobody Fri Sep 25 20:47:00 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DC87566C4B; Tue, 8 Sep 2026 15:43:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882189; cv=fail; b=KqiyxT5mU5oagmOW6YbNz6EJSITeASBqMwm8v75xeLwAmXiXcEZruI9saQ6J81NaRTZ37BFGasIAk5FojpFvBwKCSuTwRBIpP7uTqPvE1bJJ2Qaz8CYpFfLwrkk1/4s4L2ZMZMbqw+2Ti70u7pYizuNrloEEKlnHTqAAyTOZWZg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882189; c=relaxed/simple; bh=p2e0L6BJd3eYaXNKxlq07c/fzPpFlLTGlrZWwVdbo1w=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CwbY9IxSgTBrvTShevZzVjcmu482ARr41mHv8vHUs1TQZ9c/Q1/Wlwt8Ci/mUb/lqp/tlGE4+44esJJ+gCEI2U/eIyZADChii/b+MngmXFokCzEOtiPpXwM5HEm6R2P5RWI/bzTWLk9X3gVtBBJl2VlZ+sYH667wwzN5mD4psOA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=GfgJMAJx; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=HKSJ3QWI; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="GfgJMAJx"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="HKSJ3QWI" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688ElZLZ1845196; Tue, 8 Sep 2026 10:42:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=3VEJ9S51As+8i4RFTYMsWN+iJA9+Vwrcx8aSerRNm 30=; b=GfgJMAJxQdD01ovEsB6A1JPgQGpmcrCBKHxAEwUctTYZ9Ko4S5P9r/hDc zLJ/+wudJkIsPoJ1BJq/ShVMuW5ZEbeO+WJFfnuS0FSKlBj8HpWQVFLlbx1bxwQI 8edfcYpZxnuma8XIUxbE4+gE5ERhw9RNBKRfAP9bC9lk7Jn6YOWL7coy7y5ApCJ3 f2QAPzebVbMnsfO/o0oFxmHGz1JrBSAVRfMieL8tXUg8npTasu3e8HyhbR/Gn0DE WQIJX0SX02undEiSnaXI+ocODnsjuooZ1RJMODgnEUOBVaXJT6WEHkLRCT0bFkMd LCn9fJU5KF1AOU3Vuh5UyrnHjCPUQ== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11013034.outbound.protection.outlook.com [40.107.201.34]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gj940mxx7-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 08 Sep 2026 10:42:41 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AiLL/A6RhqRRLK9fynYaZRi6z+ekX3rxAkQV8hFJWucTvEEMVmTgt+Rvo3TUGYXAwLqWOol2yebMqJaIdTFAz5PRSWOQfhRGahCOg/FOWEZaKy5G8iZ/qb9KsbIkj2ASux/0zFYxsHkdohLLQj21sPwxm4/aRYrHUXPLMFPWJg85NEDD0ho34RLr4NCJnqn4H8nWBHW+VZySJtZ1LIBMfZZo2vtclzihBDW/vrRO7kTyvX4VlpHwR5gPTyuoh3eAbYKT38Z+kR1jZsgCv3ow7pgA1t8hDilQpusd0CMSbHrcdgyXXgMvLURCYVDVFcG7shpYtnmSceWCjQeNumWKDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3VEJ9S51As+8i4RFTYMsWN+iJA9+Vwrcx8aSerRNm30=; b=xz++nbdT6rlCmjKj4f1WfapByvGtB+Gy7nWf9bFkG6xhtQKpzFK8MR7S4lUpdFsnaHw1pTVk/LGzevQ+WrygJj70IkeZtc529Ya+SkkFASidLt5WIBLYBqh2UaB22lg2C9poxSdJK7bw8R0vIQ4NlPipoIgQJ7I/jTC3yj0Ow5ab+Xd5GhMH7pda3PFH5tvLZ0NPs6bo5KnrsgiSuqWjjkHGGBexBBKndV8OKi9WYE7xdG2YDguy7P4Sa64r3LFpHzqT/sgywUl1oisc0Mf54RGhCO8KSYPpxSFc3GsI8Z2mGCUJISYAm4S8ua4Q90Ue3sou2WOHdalPtDNS7xuuJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3VEJ9S51As+8i4RFTYMsWN+iJA9+Vwrcx8aSerRNm30=; b=HKSJ3QWIjx2+Mmy2jLFXaja9CVghF58QuzsYB4XP4AmcmH64mIKtnT3V+H/GK6hpB93a5VA35SQRd0PhM9kaILzulL4bqSNRxeNj1IDocjrVbI8JjADQGILgD9Vrx4BumIa/jTZBb1qfdQ7ZRgB0xXipuqjt/VQe6C1s/UoanFw= Received: from CH2PR19CA0015.namprd19.prod.outlook.com (2603:10b6:610:4d::25) by PH8PR10MB998088.namprd10.prod.outlook.com (2603:10b6:510:40c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Tue, 8 Sep 2026 15:42:38 +0000 Received: from CH2PEPF00000148.namprd02.prod.outlook.com (2603:10b6:610:4d:cafe::50) by CH2PR19CA0015.outlook.office365.com (2603:10b6:610:4d::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Tue, 8 Sep 2026 15:42:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CH2PEPF00000148.mail.protection.outlook.com (10.167.244.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Tue, 8 Sep 2026 15:42:37 +0000 Received: from DLEE211.ent.ti.com (157.170.170.113) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:27 -0500 Received: from DLEE212.ent.ti.com (157.170.170.114) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:27 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE212.ent.ti.com (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 8 Sep 2026 10:42:27 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.33.213]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 688FgNWg3725209; Tue, 8 Sep 2026 10:42:26 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH v2 6/8] i2c: omap: Make reset bit name match register name Date: Tue, 8 Sep 2026 10:42:21 -0500 Message-ID: <20260908154223.116074-7-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260908154223.116074-1-afd@ti.com> References: <20260908154223.116074-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000148:EE_|PH8PR10MB998088:EE_ X-MS-Office365-Filtering-Correlation-Id: 78a14810-6ba6-4f51-a60a-08df0dbfcf3d X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|376014|23010399003|1800799024|18002099003|22082099003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: WgDnT8vnH+kiapnMt4BAp/SZ0KNUBRNi1YuPxLeNpxs1fzufljsL1rkFK0UB37yAN7V6PxZKP/1YcuQrANbOEx3tpBB9roH9rnHbbL9ZuLG5q/sPEkA6Z6AkPjADuzzGQBhIb2zgE6aLv5+9/FDFzCKzzWIRVPFwrqJOthD1ZjkcP0lD7T/d6tM/ereDbjpyBuOongoJubfDzCr342VysChAn1uuKbchBUWJJW6hrH8bP+3DpikX2SSmeLg8/ijpMb9s6nbRL2m6ydiXGZNPBIIlJ5ovs5I15zaXzLbn2Mjtw+7xhuiWZVoRNEk2u1KsgV24c+ua+45fHOIhJzOrggIX5Y/0kw9aUsWy9FPniLuyh0JZpyfBfRynPjARVfl6HxdyOtcQrmyMU0ChJ5S+xPSdVD/ZDQN4I8pKBzNoXU0CEy4EUkCMGvqABAhIlrgj+sTl1ju05Y2ZVXIVui2ETXnNq2CJRz94niJr7oeB/WJEQXzpgYjqUJpjEHJJCslxTPF5RoD4NDQRNlimv+qFAfP3hXCmjeMWQ/1EMCrUWfSB2SAwn+5uuotDYb+CNu/iYgTmrcwoRAOw2ZcwYKydyWkCAUWntivOHJ1VRBI0ArD3VESZuS2+be2QlkDV1WtSdx03+S0Z/dafOWz0qd++jjc8P8i2CliKKTRqPOnxMWwi8OebKLflE5z7EPxfSK94h27FYh0xcZ4yq8Thlg/9LA== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(376014)(23010399003)(1800799024)(18002099003)(22082099003)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: yi9GH4iBhnuhT4NqMcCuHs0vB5TPwjbAziWd8saWA/lXm5n2PjXRvJ66wdC7RNpDcwUt2l+XF7o2e1kPy33aRF6FcSrreP5ok6wtuxIY6fUP9zm3JvNEyLYRibWDb5UFDLfi7imhHYToMBSmTTUvO0D7foH4m5//vq9zh7REIEjDKQemqWiv3l18o+EDBQbJw6KdF2NnsqUX2D81Q7Or9+wyZyUGimuSqbaWxXHV0vbULQUbXV8iFgtsk0qYs4xEfc/e3ujeuMyKp/DnQB8yXi6A9oeFYOBmEA80txesS5JwnFs/vdvo7aWJ7WWefDgVhV9/ymeEkfbwrVF9tBwTN7jW91CCB078SIq/Dyf0QOSdl5hGdVyLmhhTMPko27CgwGxSnc+79j5uuD1/Zje8qLnek97oTH1+i4HCbZteghxBQWThbTjktHCfbjzjLZqT X-Exchange-RoutingPolicyChecked: S2YGP2h/Ylw0vF+GtLS2YT5im7weMou6hYbESFZ/aJ+vmQlnEQYBUkS/M+KZjp7GY9qyPgYd03FZmtF4xgaYHVjHUmuDnJ29rTDBgL0byMsbSEnW12uEiraUFhepHN54HKhtYi4wa1TIO1ZkJggPh9PsIjf2wknKKK+GVUtSElND39M1XyPdapxL+3pnkdFTfZjS79q7M2M/PnAEtJFWQ8N0wT/m4whZWxUBD5GyobTUHrartzJOyxYGOVE2EUjOAo02i/2x13uWGeL8qq29s2uxNCl3dJ8O3rvgXHUr/BvC8hu2uSqLBFv6nLelWqki3JL+UH10rGRrgx547Yj2YQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 15:42:37.6315 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78a14810-6ba6-4f51-a60a-08df0dbfcf3d X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000148.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB998088 X-Proofpoint-ORIG-GUID: VeGDNFaGV7IMuHEuLauA4E-EyMM0-TCg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX8/5XiQHZUbnI NfGEjUm/cyJWCWCuhbFs7jliIf7pDInr+nSBSKATl5Eiemlj26RChdre9tjH4WosH0DyEdkW4tc L3HjhCvyERR2LwuWxgvtJspBFVlHxH6/YrORPuH9qzEDJZehHWVQTtlDLJL9DVghW9AaCWTbL4M thuwWZN/oIKa9ucMt3i0dHXsdK3xDZ57O/MIFW7gz6PINTyjHkqPVuxvFhF1FmrlAB3EmGgwawR /97iDx8U35FTJdxozz8VCJulStDMJF7+XD1dDw+e0izmERCR3Fnk2wbe/dyxi4qlUuP5YnmgtdP SzZDKmbW3kHPbpW0xWQFGNJltCoVobhc6DFYntuIEhtUJufdkd6PzihO1B6L6wCHtkipBf4VFEo HbkR3+6pAXYYdIXDOTNRht22o53tO/WzuAt2m9oKNQi+dyRcxnNFwLB77ZXfwGOw7jF/laNczw8 3rcJTlk0JHA3j3RJ6jQ== X-Authority-Analysis: v=2.4 cv=UrNT8ewB c=1 sm=1 tr=0 ts=6aa02cf2 cx=c_pps a=8SlpipC/tMUw4p3hnqM13g==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=jiVZLek5lCiKkj7Mo_QA:9 X-Proofpoint-GUID: VeGDNFaGV7IMuHEuLauA4E-EyMM0-TCg X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfXyl7d2jmh2C5K zqnl3rAluHv8rDNsCdEORsgpGntWIHA6QOF7A5R0PiU9eCbOS2xirqCCZW67uC20zk219+MRrMu PiGbuH4paxDH5mIK8bfUukewjVAUPZQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080169 Content-Type: text/plain; charset="utf-8" The bit definitions usually match the register name definition to make matching bits to registers more clear. Do this for the bits inside OMAP_I2C_SYSS_REG and OMAP_I2C_SYSC_REG registers. Remove unused bits. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index dc75780f76c96..a50cf195c28cf 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -133,17 +133,10 @@ enum { #define OMAP_I2C_SYSTEST_SDA_O (1 << 0) /* SDA line drive out */ =20 /* OCP_SYSSTATUS bit definitions */ -#define SYSS_RESETDONE_MASK (1 << 0) +#define OMAP_I2C_SYSS_RESETDONE (1 << 0) =20 /* OCP_SYSCONFIG bit definitions */ -#define SYSC_CLOCKACTIVITY_MASK (0x3 << 8) -#define SYSC_SIDLEMODE_MASK (0x3 << 3) -#define SYSC_ENAWAKEUP_MASK (1 << 2) -#define SYSC_SOFTRESET_MASK (1 << 1) -#define SYSC_AUTOIDLE_MASK (1 << 0) - -#define SYSC_IDLEMODE_SMART 0x2 -#define SYSC_CLOCKACTIVITY_FCLK 0x2 +#define OMAP_I2C_SYSC_SOFTRESET (1 << 1) =20 /* Errata definitions */ #define I2C_OMAP_ERRATA_I207 (1 << 0) @@ -293,13 +286,13 @@ static int omap_i2c_reset(struct omap_i2c_dev *omap) omap_i2c_read_reg(omap, OMAP_I2C_CON_REG) & ~(OMAP_I2C_CON_EN)); =20 - omap_i2c_write_reg(omap, OMAP_I2C_SYSC_REG, SYSC_SOFTRESET_MASK); + omap_i2c_write_reg(omap, OMAP_I2C_SYSC_REG, OMAP_I2C_SYSC_SOFTRESET); /* For some reason we need to set the EN bit before the * reset done bit gets set. */ timeout =3D jiffies + OMAP_I2C_TIMEOUT; omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN); while (!(omap_i2c_read_reg(omap, OMAP_I2C_SYSS_REG) & - SYSS_RESETDONE_MASK)) { + OMAP_I2C_SYSS_RESETDONE)) { if (time_after(jiffies, timeout)) { dev_warn(omap->dev, "timeout waiting " "for controller reset\n"); --=20 2.39.2 From nobody Fri Sep 25 20:47:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B378053447E; Tue, 8 Sep 2026 15:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882177; cv=fail; b=Ahs9TJJdXrqfaZJ0ASOnk4FT6VDuSl4fmohvd3ef1pAmSvJp5h38zctlOKw2thVPk5n2hjisXsypa6KEk/YPqUjU0vlNL7awmIxZOqEoi+zS3P64qVlWwQ/klU+AUAF7IuDFYPHvL8lyKgqXzSfDoDt3hdO6MfpcXUL6L5Jhhyc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882177; c=relaxed/simple; bh=Vbn+XLMaFzBjz/uvtk95yaSvYtDRv5PeHaLFfCPIbjw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uKgKMAXSpUe9lmhx8U02DhVPLqm6AVy68IXcO1JJ07rt+DGnox6oiqjx/D5/Xmd4YdTLquA0/vtP1UE9/n73ZB3BtEHSy77XLKWAlxzx5cyMZM1T00NGIerp0ctaST9HzGZmYj8C1i7wNyo3cFOfEdmDe3aZQmQ9KlWAGfRbmqk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=NydjUmG1; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=UiP63I7E; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="NydjUmG1"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="UiP63I7E" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 688EjrMb2032901; Tue, 8 Sep 2026 10:42:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=6JwITzJS1HiqrdKiUyafv46BdgOOqAsiTlQP/jiss aY=; b=NydjUmG1PCdAJzDMgWrJ9WIqJRIF9IP10T/6Rc8Q2BF6v6TYd20SimAEp pqRVcQ43vOV3Dfa3lvXI8ltxnNTr7uEkRGcmXZ62m15SPCmTKapNMH99CAyhzXLB 3jc0xWQ73G8fcycU4ctOc+KuViBeiLrvjWivsdiGIXouh8Obw6jnKUI62Zh5Nu+6 +bRKPsLv0naF9OyKThw4VthHXmPvZlRc8fUWg6bc/ArOgMPU8usOCesEYlCJRnvQ 6q/WS5gqoqAm1AerLhfqAVejW94KeMmIyHekOwkh3A5v0qP9aUhUyuwWlM49G8Fq e2Ec8uzwqHCTsKZQIDBnGToqkrSUA== Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11010045.outbound.protection.outlook.com [40.93.198.45]) by m0380145.ppops.net (PPS) with ESMTPS id 4gjffmtbdq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 08 Sep 2026 10:42:43 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vZOM4TX58qLnm39A1uq+L4qQoDPvxbf80dhMSw29HKX7AY12Vm0ZNq4N2j56r5KrYzI/6bLxfM9MwWe6Q7VAVcDCiFtjybq99kmBzuUXqvsjXJVoVTBE6x8A/OkWu0on77GbTzDTw8TPux9CQv29YD634HqasR3ALc+mgD+EhDWgMY2nZvB/bR75WGH2wKGWg7j8KpNq92SX3pSYvKut6pBmjyfM0LcTr1WJHvoG+BHMIUMWNiEvrfVcx2PD2l21n/W1gZAxtuk/8RqVHwzq+19QR5adpD2iElzsxwSNs8Cfvqp8qqPnKMDipDlfiGF+nT7bVDMSc1ZmwDgA7HSkPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6JwITzJS1HiqrdKiUyafv46BdgOOqAsiTlQP/jissaY=; b=BW9smUtv3HNvSZ3gmkePPbLgsUTLW7mjxMGP2hA3FL8Pm2pop5BbK7ftJgPXoR6PfI4bkv2EZa4QtMkln7FL1agWqRBWvj8QQFu3nhsU3TBSGUbD07hzX7+tVqCZP3CMvsujxcLpRIp/eszQZJMh0QYIyMhsG2armSWHklmQ81HNtpMK1g86SJrNxEuN/MtC0WRbNJRwGmoOkFm9tFOEypGu7jDMss7HJk5uOvI8NF/QTukf750+u29u1Ic/zjkBQ/tyZT4pu++ZWqDfIOGS1LZwNMRZKCZK+u2X5PRd7nZQ7xEDcb+piypRrxnqgEjKYndWrJDc9TzstW8WgMkz7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6JwITzJS1HiqrdKiUyafv46BdgOOqAsiTlQP/jissaY=; b=UiP63I7E9palrhugd8gOY+CtUA3QDz/OF1y94FZiIs/Guo1iWew6YcYdGgjKqoF1SJnomCkuVrFvcP/K4dXjdm/5jPYUcqrfiE/ZBh4O3W6FuSocOlXZXLjcoQoUQtntL3tw2wNZGDtiwqZxdSAY0WoiUE0+MZM+sqDuxyRoKT4= Received: from CH0PR04CA0069.namprd04.prod.outlook.com (2603:10b6:610:74::14) by IA4PR10MB8658.namprd10.prod.outlook.com (2603:10b6:208:562::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.6; Tue, 8 Sep 2026 15:42:37 +0000 Received: from CH2PEPF0000014A.namprd02.prod.outlook.com (2603:10b6:610:74:cafe::27) by CH0PR04CA0069.outlook.office365.com (2603:10b6:610:74::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.6 via Frontend Transport; Tue, 8 Sep 2026 15:42:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CH2PEPF0000014A.mail.protection.outlook.com (10.167.244.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Tue, 8 Sep 2026 15:42:37 +0000 Received: from DLEE206.ent.ti.com (157.170.170.90) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:27 -0500 Received: from DLEE214.ent.ti.com (157.170.170.117) by DLEE206.ent.ti.com (157.170.170.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:27 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE214.ent.ti.com (157.170.170.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 8 Sep 2026 10:42:27 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.33.213]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 688FgNWh3725209; Tue, 8 Sep 2026 10:42:27 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH v2 7/8] i2c: omap: Switch to using BIT and GENMASK Date: Tue, 8 Sep 2026 10:42:22 -0500 Message-ID: <20260908154223.116074-8-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260908154223.116074-1-afd@ti.com> References: <20260908154223.116074-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000014A:EE_|IA4PR10MB8658:EE_ X-MS-Office365-Filtering-Correlation-Id: 7362eca2-9498-4f98-7684-08df0dbfcf5e X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|82310400026|1800799024|376014|10067099003|6133799003|3023799007|22082099003|18002099003|10086099003|56012099006; X-Microsoft-Antispam-Message-Info: rHztN18NRBSaOcizK+ZZsVvW5ZUqgTNwftP62Bzh7IrxkKUisXykUmrB3Ggu1+plE4NhAUrDICVhA3eHIZ23Pal6hMH9D+MtR4nfuH/z0RJsm5zlIRpupmrgl3fhnNq45YHzK9vDo/KSdV6KmYS/3NlTy0ZemjtOwrAzIH/qvh77+jk7kSRPS4bCudCrUxqoptY+aO9Du5JUQBs2q26Gk2QSL2XZgAzqe6Vur3NGBfTQCXJMXNAtYtCs8AlzpgGfIBTzWTyviheKqe1uNFhIypjvlsSIl508+fIQDmk2n7OG0VkCBaxeCaz5ktuOR5kJDbi7IkIObwnXHE3G0jvDphVS4bUXloLECRHS3gGf67borb4gfaIWVqBNfxJ/5VmndHmOKK0TG/lDyvwiazYMeQF4nkKbvvDvpuvwfwFl9bEWo90hVjjhEpJmjyrSgiOSwLWeafROVHoZaU2nvWqSonx08QH236eaLKMia8oj77Z2Lnw1efL68sS4fuWn/xE+k8Xe934w+l5dq0UwA1gOdzSGmYDrO3vpRABsP7vtoEMSvaF6LLqgvoUX9aIBreykx7D1LCNIgMPU7G04P7HSvqcUWEAZrYIfb/pia0jBo+Axrjvlj/fcULIbFZF5sh+q454bgCXYKJC9Pfww60a+h7kae8NhfRYRiqKyoBxYz5YBtWLam1fGe2/vTorvievPZXmcjDftCc2eshCR1CyX/w== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(82310400026)(1800799024)(376014)(10067099003)(6133799003)(3023799007)(22082099003)(18002099003)(10086099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kLOPGVP3JvQaNw7dStbZnKwD5Qf1YAP+AmdCn8t5kQAGHO5HaiLwQWmCScXB6V4aGLh8mR6PMtGeqgBc4Z9YwRWdYD5/1iDHH+wzH6LPZcl9ujddAplWkCBpSYZpshXnsuLkzUsATpqlhJzRgbsxhQzdDTxbw5LWLFoRGj6PzMY0Mjq7qGzMXJfR4Jvc4BIW1fy9bVItIsWBnBuOpIMgzgDb4c2ChPZ7XCezjyX0X1SvfvBPfYk5LzDSoyyKTh0qCsfgRpFBS8LsYtToV/blEba5WxH9d13GeKUV8FUz9X0Yc05Y5AXX++ANXyuLTTsj+lpgfHmk9lJR+OpTR3W4r2tiziOJ0bljoFnJBj1Qynwl0qrQehyz/ri4OEU6aFeOMhg0d1PuTopyPm1k2qgkxY89nlqNT+6AelXHMSXOlIo/xFPAOrAitkn0qftN2HJc X-Exchange-RoutingPolicyChecked: JEgLWUltK3QDoliZG7n+XLxEQIZOx16S5kTcRJJLr4QYcKgey1qjxA0vnTK4NreY0sLDoksqxJGWXgHVCMmMfIGebXxPMM4pvOwZhUbv/oCvaveYIbJtIRlBBNRz2U4PKppdomy/T5WI7OkUdW146/EisDbyQH7QZ9a1jPJiZHTCDmnzXIozyCxlXM2sQIcfwNoxDH18xI4tM7csS2L12j6WAcUnvO/MHzZDvGHALMTkArpbON3sL5p1bqic/u8OXrjnSgLIt0jx9wrf5O3hk56SEg19sWzCsjESij/oTdFFFxscMg23iYQlxZXUpmlsZ5GIx9BDW1J2jb/qAerImg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 15:42:37.8171 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7362eca2-9498-4f98-7684-08df0dbfcf5e X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000014A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR10MB8658 X-Authority-Analysis: v=2.4 cv=FewHAp+6 c=1 sm=1 tr=0 ts=6aa02cf3 cx=c_pps a=zLftBE+EtYxwi/BgDV84wA==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=nc86A_OknvlbK2ZPRX4A:9 X-Proofpoint-ORIG-GUID: d8WDDo4hof3LFI6oMVBb9BwR-8xKLP0r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX7DynwT/P1rnu MMV7sZKo+1BEphDEXAmCU1S09m5xesXK4yNxTOYfEfGmDv2Rzol1j5eDF1jofSmK1qi1duL06UH 97nw6+wuoAi/xpoOmTICifWVnrd31FlF1uhe4Eq0XK6oyIzgazm01hZkWpEGAH7hZfFJOCnLEIf KFXU7nbr7gtJ+d2fGjQ2xJkm41iKCCNl6KSt94X1oZVTfcaUrZQe9mfmyabSpxjG7I6dSwXUkwh xl9w14XLzHQU01hNdzeBxrjl6YEO1WEdf1A/Iqk9gnqEMlvEDYCQDgRsjZgQs+D4V2mXs3CGpOZ hLtGT5Z9IN8eIiPQmy2IDkwEFq9AclkQqohe6LqkaqfyfLOYtY9EaVQ4x97u3awY/D2mkakRNzR CodtSVcBCGACemCjTutIQsYX3CpjBCd9/l32B+YvWA/YnW4I5ZRnqcMozI2yaUDGbRte+dxGZie jkVyv61cK1gjxYIVCIw== X-Proofpoint-GUID: d8WDDo4hof3LFI6oMVBb9BwR-8xKLP0r X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX8a2JC8JiEzRz zMUD5uoqYpIo7rQWo7cDNXSPhCDLYWl7dVoYh7rEJQ9M7JjJhrQlf8V4n5VyRdl2zXpadD6jwLm 7m6SN8w34jH7reEVP7/CPw5b7UbJy+g= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 impostorscore=0 clxscore=1015 phishscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080169 Content-Type: text/plain; charset="utf-8" We have helpers for setting bit values and masks. Use them. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 82 +++++++++++++++++------------------ 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index a50cf195c28cf..41464f92da046 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -79,64 +79,64 @@ enum { }; =20 /* I2C Status bits (OMAP_I2C_IE, OMAP_I2C_STAT, OMAP_I2C_WE) */ -#define OMAP_I2C_STAT_XDR (1 << 14) /* TX Buffer draining */ -#define OMAP_I2C_STAT_RDR (1 << 13) /* RX Buffer draining */ -#define OMAP_I2C_STAT_BB (1 << 12) /* Bus busy */ -#define OMAP_I2C_STAT_ROVR (1 << 11) /* Receive overrun */ -#define OMAP_I2C_STAT_XUDF (1 << 10) /* Transmit underflow */ -#define OMAP_I2C_STAT_AAS (1 << 9) /* Address as slave */ -#define OMAP_I2C_STAT_BF (1 << 8) /* Bus Free */ -#define OMAP_I2C_STAT_STC (1 << 6) /* Start condition */ -#define OMAP_I2C_STAT_GC (1 << 5) /* General call */ -#define OMAP_I2C_STAT_XRDY (1 << 4) /* Transmit data ready */ -#define OMAP_I2C_STAT_RRDY (1 << 3) /* Receive data ready */ -#define OMAP_I2C_STAT_ARDY (1 << 2) /* Register access ready */ -#define OMAP_I2C_STAT_NACK (1 << 1) /* No ack */ -#define OMAP_I2C_STAT_AL (1 << 0) /* Arbitration lost */ +#define OMAP_I2C_STAT_XDR BIT(14) /* TX Buffer draining */ +#define OMAP_I2C_STAT_RDR BIT(13) /* RX Buffer draining */ +#define OMAP_I2C_STAT_BB BIT(12) /* Bus busy */ +#define OMAP_I2C_STAT_ROVR BIT(11) /* Receive overrun */ +#define OMAP_I2C_STAT_XUDF BIT(10) /* Transmit underflow */ +#define OMAP_I2C_STAT_AAS BIT(9) /* Address as slave */ +#define OMAP_I2C_STAT_BF BIT(8) /* Bus Free */ +#define OMAP_I2C_STAT_STC BIT(6) /* Start condition */ +#define OMAP_I2C_STAT_GC BIT(5) /* General call */ +#define OMAP_I2C_STAT_XRDY BIT(4) /* Transmit data ready */ +#define OMAP_I2C_STAT_RRDY BIT(3) /* Receive data ready */ +#define OMAP_I2C_STAT_ARDY BIT(2) /* Register access ready */ +#define OMAP_I2C_STAT_NACK BIT(1) /* No ack */ +#define OMAP_I2C_STAT_AL BIT(0) /* Arbitration lost */ =20 /* I2C Buffer Configuration Register (OMAP_I2C_BUF): */ -#define OMAP_I2C_BUF_RDMA_EN (1 << 15) /* RX DMA channel enable */ -#define OMAP_I2C_BUF_RXFIF_CLR (1 << 14) /* RX FIFO Clear */ -#define OMAP_I2C_BUF_XDMA_EN (1 << 7) /* TX DMA channel enable */ -#define OMAP_I2C_BUF_TXFIF_CLR (1 << 6) /* TX FIFO Clear */ +#define OMAP_I2C_BUF_RDMA_EN BIT(15) /* RX DMA channel enable */ +#define OMAP_I2C_BUF_RXFIF_CLR BIT(14) /* RX FIFO Clear */ +#define OMAP_I2C_BUF_XDMA_EN BIT(7) /* TX DMA channel enable */ +#define OMAP_I2C_BUF_TXFIF_CLR BIT(6) /* TX FIFO Clear */ =20 /* I2C Configuration Register (OMAP_I2C_CON): */ -#define OMAP_I2C_CON_EN (1 << 15) /* I2C module enable */ -#define OMAP_I2C_CON_BE (1 << 14) /* Big endian mode */ -#define OMAP_I2C_CON_OPMODE_HS (1 << 12) /* High Speed support */ -#define OMAP_I2C_CON_STB (1 << 11) /* Start byte mode (master) */ -#define OMAP_I2C_CON_MST (1 << 10) /* Master/slave mode */ -#define OMAP_I2C_CON_TRX (1 << 9) /* TX/RX mode (master only) */ -#define OMAP_I2C_CON_XA (1 << 8) /* Expand address */ -#define OMAP_I2C_CON_RM (1 << 2) /* Repeat mode (master only) */ -#define OMAP_I2C_CON_STP (1 << 1) /* Stop cond (master only) */ -#define OMAP_I2C_CON_STT (1 << 0) /* Start condition (master) */ +#define OMAP_I2C_CON_EN BIT(15) /* I2C module enable */ +#define OMAP_I2C_CON_BE BIT(14) /* Big endian mode */ +#define OMAP_I2C_CON_OPMODE_HS BIT(12) /* High Speed support */ +#define OMAP_I2C_CON_STB BIT(11) /* Start byte mode (master) */ +#define OMAP_I2C_CON_MST BIT(10) /* Master/slave mode */ +#define OMAP_I2C_CON_TRX BIT(9) /* TX/RX mode (master only) */ +#define OMAP_I2C_CON_XA BIT(8) /* Expand address */ +#define OMAP_I2C_CON_RM BIT(2) /* Repeat mode (master only) */ +#define OMAP_I2C_CON_STP BIT(1) /* Stop cond (master only) */ +#define OMAP_I2C_CON_STT BIT(0) /* Start condition (master) */ =20 /* I2C SCL time value when Master */ #define OMAP_I2C_SCLL_HSSCLL 8 #define OMAP_I2C_SCLH_HSSCLH 8 =20 /* I2C System Test Register (OMAP_I2C_SYSTEST): */ -#define OMAP_I2C_SYSTEST_ST_EN (1 << 15) /* System test enable */ -#define OMAP_I2C_SYSTEST_FREE (1 << 14) /* Free running mode */ -#define OMAP_I2C_SYSTEST_TMODE_MASK (3 << 12) /* Test mode select */ +#define OMAP_I2C_SYSTEST_ST_EN BIT(15) /* System test enable */ +#define OMAP_I2C_SYSTEST_FREE BIT(14) /* Free running mode */ +#define OMAP_I2C_SYSTEST_TMODE_MASK GENMASK(13, 12) /* Test mode select */ #define OMAP_I2C_SYSTEST_TMODE_SHIFT (12) /* Test mode select */ /* Functional mode */ -#define OMAP_I2C_SYSTEST_SCL_I_FUNC (1 << 8) /* SCL line input value */ -#define OMAP_I2C_SYSTEST_SCL_O_FUNC (1 << 7) /* SCL line output value */ -#define OMAP_I2C_SYSTEST_SDA_I_FUNC (1 << 6) /* SDA line input value */ -#define OMAP_I2C_SYSTEST_SDA_O_FUNC (1 << 5) /* SDA line output value */ +#define OMAP_I2C_SYSTEST_SCL_I_FUNC BIT(8) /* SCL line input value */ +#define OMAP_I2C_SYSTEST_SCL_O_FUNC BIT(7) /* SCL line output value */ +#define OMAP_I2C_SYSTEST_SDA_I_FUNC BIT(6) /* SDA line input value */ +#define OMAP_I2C_SYSTEST_SDA_O_FUNC BIT(5) /* SDA line output value */ /* SDA/SCL IO mode */ -#define OMAP_I2C_SYSTEST_SCL_I (1 << 3) /* SCL line sense in */ -#define OMAP_I2C_SYSTEST_SCL_O (1 << 2) /* SCL line drive out */ -#define OMAP_I2C_SYSTEST_SDA_I (1 << 1) /* SDA line sense in */ -#define OMAP_I2C_SYSTEST_SDA_O (1 << 0) /* SDA line drive out */ +#define OMAP_I2C_SYSTEST_SCL_I BIT(3) /* SCL line sense in */ +#define OMAP_I2C_SYSTEST_SCL_O BIT(2) /* SCL line drive out */ +#define OMAP_I2C_SYSTEST_SDA_I BIT(1) /* SDA line sense in */ +#define OMAP_I2C_SYSTEST_SDA_O BIT(0) /* SDA line drive out */ =20 /* OCP_SYSSTATUS bit definitions */ -#define OMAP_I2C_SYSS_RESETDONE (1 << 0) +#define OMAP_I2C_SYSS_RESETDONE BIT(0) =20 /* OCP_SYSCONFIG bit definitions */ -#define OMAP_I2C_SYSC_SOFTRESET (1 << 1) +#define OMAP_I2C_SYSC_SOFTRESET BIT(1) =20 /* Errata definitions */ #define I2C_OMAP_ERRATA_I207 (1 << 0) --=20 2.39.2 From nobody Fri Sep 25 20:47:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFC92566C62; Tue, 8 Sep 2026 15:43:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882206; cv=fail; b=WwHrKP5CG+cH9+0amE55jmtOHr15PGHiokzktWTmmuvRt2IAMk0osb1aFoTJtHUgnpEFiBOSjXugr/0G74AvZwXJgHOrR88TzL2UkEzSO+6fBBuIVJgvJ5+J8wNseQeDUexi/BHVhlQwTQnS4Yy0/CrXcFyw4ERsPro0YK6KWXg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882206; c=relaxed/simple; bh=LoHYzUm33+DhlSubiLgNm/sQPDqd9gekmtuKygzQ07o=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KMFN3UIYHlTKFVRrId+45WnRN6G1NHODDcw7FlhgMG/klVR4+y0XkQ2VLrijrfiKymeHrw/pWAVHi081OBfRw1VQszuHUDuVZedaY4SeQMmg4v6BqtS7pbOP+ukD5O6TcMDeH0oxqwzmDxFd/1pAIjUKItpuRf60nX8qpsxFYtk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=eNbmuEsD; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=H3BZtnzG; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="eNbmuEsD"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="H3BZtnzG" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 688EjsxR2032914; Tue, 8 Sep 2026 10:43:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=ZfAsMKRts3q8ehU1gxlKbE3P3wSPL4Yyd8AJfmA4p +Y=; b=eNbmuEsD30f3EuE04G2pwgYrP8ZGabliuvVt231Va/tlloRyAQ8FU1rEH aRwQ/2EyZPC4W7sTwWbaw8KMEfKGcgq93KqCVeAoPCMtDLW+4PjsOSG6KoSoyhej Hi5qWXJeBloVqzLtG/0oF7rX5TWAm/8BV533Q1tjHq4BafM0aR8VgmkKOOKKZnU4 yrwp56plyaGSgynahoJ6Tuegwh++8kBm1yaAh6AWRZiiPPmDCQbLvzd8l8gsTNsv dJSgUoRLQsHhpwZSYhZze35jLtnxHZvgGVffpvn9Ari6KLxca92cU4RnNYijKZ9n +nhUlZfhieXik/OL5jeHor56dK2zA== Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11010007.outbound.protection.outlook.com [40.93.198.7]) by m0380145.ppops.net (PPS) with ESMTPS id 4gjffmtbgk-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 08 Sep 2026 10:43:12 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nxUVLJ4R+uvzVk6oDvEX4iWvsVzVyUnzshGyjcqpGzeIeztuwr3Bx5pGsBvfr1fh4D01Tn5A01AjXXRFodJ0gH/I2iIiAz0v3dP91YbHLPdFYH0hnmsFEVqjEQCDq4UR5GAKKN5pSAtZhUQV6pEx/wpNcjhR47SZIrOwS2J6Uqo/M2RFXa45xetkd3TUGzSdmTTKHFq80axgEgBniN+VXze+iBmqB+mFe2DW5MbUofDY4g6lA7u8Xgjfq/p/dMl9QpLTXM0gcISnz9c4bQJjECkE6hrU5lBDyahr8xbn0ANSKqLylpcj15XsdSJcq04cA8+AjSKy80hWYh/R7IE5Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZfAsMKRts3q8ehU1gxlKbE3P3wSPL4Yyd8AJfmA4p+Y=; b=t7LE45jlBCQFdZp/U5oirsDfrZsWeUEn8K+SFEpR5lLeFXSroWp6S2KtNNO9HbeKcj74HG6eRt0zcd7YP76AHM8PuLI9wy8al5U2w0f82eCtsLyUHfb0luMl3gOMEBAZ3Hhy+S29Je9anfNj+6cF5Q+VukjxA3SdtL7p42aaCLzfg00pYLUWYmVAOvYqT+FoGFxnjRHdn7iGmeLcaCe3H/t+LjcKFefWbCPGHiPsUbCe9AXF69N3NY212yGyP/niNkdkZDjtArQUUabC0vr9udfwFykSvn8OYxhdb2PqsF0IcFFPG11S3QdMShJjIoaShnKUQ+7bWKMGMTKbw1Z+tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZfAsMKRts3q8ehU1gxlKbE3P3wSPL4Yyd8AJfmA4p+Y=; b=H3BZtnzGiECtgCPZH4c41yqTa3won0VhBSy/2vtea9l0kbubD4NeU1ldbOLzmx4BCR555fPphUUsxEd9anQjlf49v1d/TfUq/Bav7CL7B9erWEs46Hl9aVj0XJ+SrVb3RN31DZb4K/O0WKoCa9wtDVHHjuMLj1WNsQBVE9sfvVo= Received: from DS1PR03CA0018.namprd03.prod.outlook.com (2603:10b6:8:233::15) by CH3PR10MB7307.namprd10.prod.outlook.com (2603:10b6:610:12f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Tue, 8 Sep 2026 15:43:09 +0000 Received: from DS3PEPF0000C37D.namprd04.prod.outlook.com (2603:10b6:8:233:cafe::8a) by DS1PR03CA0018.outlook.office365.com (2603:10b6:8:233::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Tue, 8 Sep 2026 15:43:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by DS3PEPF0000C37D.mail.protection.outlook.com (10.167.23.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Tue, 8 Sep 2026 15:43:08 +0000 Received: from DFLE206.ent.ti.com (10.64.6.64) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:28 -0500 Received: from DFLE214.ent.ti.com (10.64.6.72) by DFLE206.ent.ti.com (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 8 Sep 2026 10:42:27 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE214.ent.ti.com (10.64.6.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 8 Sep 2026 10:42:27 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.33.213]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 688FgNWi3725209; Tue, 8 Sep 2026 10:42:27 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH v2 8/8] i2c: omap: Add OMAP_I2C_BUF_{TX,RX}TRSH definitions Date: Tue, 8 Sep 2026 10:42:23 -0500 Message-ID: <20260908154223.116074-9-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260908154223.116074-1-afd@ti.com> References: <20260908154223.116074-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37D:EE_|CH3PR10MB7307:EE_ X-MS-Office365-Filtering-Correlation-Id: b05971bc-fa9a-4c1f-af29-08df0dbfe199 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|36860700016|82310400026|6133799003|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: APkPiA2xYY6EcsYtthvOWMicRazYnqFhiIOETF/6CddDTbC1z0orch5OJSO3lJzojBCY7gODk44R4kyu5YKGUrHBZgKr4QsCYeOGNTeOga2/3NPwrIabaAJwxah8jqSFLZ4/d8qAyEc52urz79KAjFwU5eaoG0btwXgC1lrM8h67QS2HpS5y9RXIMKgngf6S+TQx46v0ALoSpPNtz3Wv4vq1nZOnFQgbAFY+DoXWxqPgF8PVlWxMJIm8PZdrJIAh9tokdnQtK8bNw56cCFzdIC43LbcMNYJ2zerp9Pga4CbcO4MHZj9aUn0o5Ynx0NwTTgJp8YDJ1EpBgAMTffteIglr6p0DQ9u7R2dr4JBY0AU7jZ7hyBS3K1Qxl6kZ2GNaMOl4vMyNphhqw4Ck0ytsyQNJmHsk5iteY6P0GKLWXPOLqUrmBMSPCogfOVLgI0FveYInmgakd9FG/Z2MeScuyECNzFXFN5CVnUeRg7km33Ewm5BFZgPNRXYWrHnqxASGtgBVQpyr8m2wfAnNKz87NGPNjGytQCZmyQXyGfjc87AkYEbCas4GejOBdAFByC/rCzX1oeVhrEw2uAYD3t86I/YTDwFtvgIOwGbMpfwFD8JDUqGsBSt+lNdSw1gB+4JCoSy8fCXDMVNGweeqrx4yfZ++6tcQfmDEogqRQPT46+rDXLTa6q2/uQfLUOiFXzfaKhslBaXKWPamFnV0e5muBg== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(36860700016)(82310400026)(6133799003)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: t1RD1/JUV3czFMKIEHPv+GLmQdS6lsYYVBcaaJbNrfQDz8EvKoakx/c74KVy8ezfhEpWR+W2YTQ9Tt6wyFUntWCzznaIDKlyxpaeAEbUvMSmlZYMaHspZ2Qzrp5naYiWWiC8T6dUVtqXf5egkyUNmp4rNmwnhp5333ebHtKrq13Q7FeAXFNbPgZPCSLrCNmSP6+e+hqYZhh9vludqenxE5/x95pPxXpuwV4/pLp8nLXbFdgZBYkKBt0zEqMX/ofufDKZuPcLWJ462XttZQ2WcIUvZK7abLqqmSMoGBmfKmI+MYsxtq80iEvxKM+RDSwha7sqsFPauaDftMPgydnta+/UVHsPlLrA1L/OU0xzMrlfawch8KnUYPjFAybYdjiWzR7ZJtg1Sq437sqOhaYzTwcYacLorWa5g67mKXyqh4D+FFR3A/oMjW8qONw1exO0 X-Exchange-RoutingPolicyChecked: hHlQKoN2vkSQIEdNYPIGyHUquaXcNwzlafhmyzzPO8SUYJ2/+os1aMhHw2DmMsXu3tOVrLubF3W4ezaxb1ZLB7TbdJG1RpVV38QuSAt5fmQB9AA6380ckDWoAVa8/nmRWJEN9MFvh55tgUlSSvsqjGldNebJEcej+ryEOQov9+/ednVEwixK68V9kzqIOL1IZP7C5Kw2Gm70JOCdAdu6/vk+APUoTGVkhW4hjTtMkye+pwYKFVybVX+RGoBqWBZ1udq9/DmXpTepXbdbOq15Xx2A3EdwccmY32l1ssNGWU4j53rlDkAn8d0aZy+do8rcOQZN78G/xeKXwOI1XZQfEg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 15:43:08.3746 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b05971bc-fa9a-4c1f-af29-08df0dbfe199 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7307 X-Authority-Analysis: v=2.4 cv=FewHAp+6 c=1 sm=1 tr=0 ts=6aa02d10 cx=c_pps a=r+591f3cnXeovruRxJw0Jg==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=9kDT9J43iM3-Rq2zlG0A:9 X-Proofpoint-ORIG-GUID: jLO7EJyM5J3XXQDMKE0fGdOFCb0eFv1X X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX56rDq4XiLWDc oJxTcGASGMmZTvoZAUx5Db5FPW/Ifyp9F/HjXAvMqHQtsldHbb8rEoxyPjSAeZYI9UEd7dYso0N 9B6PdIWHCxsoUJQ3Q4tl3+OSTTImt9Sm9xf3D91P9g3B1WPUMI9+MomsS9elg+KASu+MaeAgnt+ Ipo282qim4ntqFH+gJhznoz+LzXEpoz+fx1JhpQh/xLL5YsiJV3LANlZnGcnemEqYbof73BxSd+ 5I2+Z42pALdw0LUyx6xJzlcbuAqIYs7hRl3E4fxWGIG6Ivji4bPQHnjFFqoLWQWg5e6BgPmiOpM 1CIX/CnAHIOFgovf1jNYchUpXf7RlCp/SIP3OAF3yMawOYaqpxfvKODjT5KllxEswHn22zBV8NB PMGtdKveuRckB8/oswVt7rZhHGEL6FwpIVop22bv7xjFJmc8j9GZqidLVolVwqlV/auNxVcDXz7 /kK0jVOljJqnuDSwtUA== X-Proofpoint-GUID: jLO7EJyM5J3XXQDMKE0fGdOFCb0eFv1X X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2OSBTYWx0ZWRfX1fBodRzmT04D 5KIoe0RXS3qwd2sLxqbFmLFQCWGqtOROd20FLBctHa4IxPr7c7q3raCNXq/aQQIdu8GelkqQREa iTQsgWU4e5ADCpK1htpSZe8+C/FAd58= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 impostorscore=0 clxscore=1015 phishscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080169 Content-Type: text/plain; charset="utf-8" These were just magic numbers before, give them proper definitions and use those in code. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 41464f92da046..e3c23234056b4 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -31,6 +31,7 @@ #include #include #include +#include =20 /* I2C controller revisions */ #define OMAP_I2C_OMAP1_REV_2 0x20 @@ -97,8 +98,10 @@ enum { /* I2C Buffer Configuration Register (OMAP_I2C_BUF): */ #define OMAP_I2C_BUF_RDMA_EN BIT(15) /* RX DMA channel enable */ #define OMAP_I2C_BUF_RXFIF_CLR BIT(14) /* RX FIFO Clear */ +#define OMAP_I2C_BUF_RXTRSH GENMASK(13, 8) /* RX FIFO Threshold */ #define OMAP_I2C_BUF_XDMA_EN BIT(7) /* TX DMA channel enable */ #define OMAP_I2C_BUF_TXFIF_CLR BIT(6) /* TX FIFO Clear */ +#define OMAP_I2C_BUF_TXTRSH GENMASK(5, 0) /* TX FIFO Threshold */ =20 /* I2C Configuration Register (OMAP_I2C_CON): */ #define OMAP_I2C_CON_EN BIT(15) /* I2C module enable */ @@ -602,12 +605,14 @@ static void omap_i2c_resize_fifo(struct omap_i2c_dev = *omap, u8 size, bool is_rx) =20 if (is_rx) { /* Clear RX Threshold */ - buf &=3D ~(0x3f << 8); - buf |=3D ((omap->threshold - 1) << 8) | OMAP_I2C_BUF_RXFIF_CLR; + buf &=3D ~OMAP_I2C_BUF_RXTRSH; + buf |=3D FIELD_PREP(OMAP_I2C_BUF_RXTRSH, (omap->threshold - 1)); + buf |=3D OMAP_I2C_BUF_RXFIF_CLR; } else { /* Clear TX Threshold */ - buf &=3D ~0x3f; - buf |=3D (omap->threshold - 1) | OMAP_I2C_BUF_TXFIF_CLR; + buf &=3D ~OMAP_I2C_BUF_TXTRSH; + buf |=3D FIELD_PREP(OMAP_I2C_BUF_TXTRSH, (omap->threshold - 1)); + buf |=3D OMAP_I2C_BUF_TXFIF_CLR; } =20 omap_i2c_write_reg(omap, OMAP_I2C_BUF_REG, buf); --=20 2.39.2