From nobody Fri Sep 25 20:46:59 2026 Received: from mta1.migadu.com (out-127.mta1.migadu.com [95.215.58.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA91D53ED1D for ; Tue, 8 Sep 2026 14:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.127 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788877603; cv=none; b=o3INfb+WeQfDN5W69oU9Js6tVrBWVVbb9VGsqpMWRp53yPeN5Emu04VaKX13XfJlAzb03G8q5UXA6fOa2yLIsThD4/QxQILVHjSUmJ9u7d0l3e6qsiEVbBBYD0f0bIF68LYeZCtiO29luLBUEQov0EZ/2ngiAv8hfY2gmNzf2JY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788877603; c=relaxed/simple; bh=s9TT0fZk57NAYbdQgPZkg4s8vZfT60FtoXTyRRE+hbY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UdID1+8a9VVVWGd0RWcgxtLVkDPor+Ha3/Q/ewYioqqNKqTCQ/xoXw1twoDQYXJPDa9+4jVlI0qYeaorUT82jpJG0QJajQqu5yUjZBEAw7WHgpYGhNMaKa4q4IR/KjQnyRXMAGk/1p4sroRNYsslMSatYtO2NubrLGHRGwBDTY0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=oUf2b2Me; arc=none smtp.client-ip=95.215.58.127 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="oUf2b2Me" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=s9TT0fZk57NAYbdQgPZkg4s8vZfT60FtoXTyRRE+hbY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788877594; v=1; x=1789482394; b=oUf2b2Me5yQ1AkdLjcXZPsY7ezdSRSf+FZqsh6OeISavuE1DxUeM4PkWAKetZy6F/KgvOdTk 7YjM/Zm4Oj25/F61ESN1YtuOf0/UIxjFagO+BoPqwcXGe2jsfoNh+pG3w11trKG/0qEeEuiFq4r KaIfZarT0vQOs2O8ZK+a/KCU= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 14221e000fbbf8e3; Tue, 08 Sep 2026 14:26:34 +0000 X-Mizu-Trace-ID: 14221e000fbbf8e3 X-Migadu-Flow: FLOW_OUT From: Fuad Tabba To: Marc Zyngier , Thomas Gleixner Cc: Radu Rendec , Kemeng Shi , Will Deacon , Fuad Tabba , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] irqchip/gic-v3: Release the partition node in gic_irq_get_fwspec_info() Date: Tue, 8 Sep 2026 15:26:30 +0100 Message-Id: <20260908142632.2795308-2-fuad.tabba@linux.dev> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260908142632.2795308-1-fuad.tabba@linux.dev> References: <20260908142632.2795308-1-fuad.tabba@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" gic_irq_get_fwspec_info() never puts the node it takes from of_find_node_by_phandle(), so every lookup from a four-cell PPI or EPPI specifier naming a partition leaks one. The node is only used for the comparison against gic_data.parts[], and the mask returned points into gic_data, so it can go out of scope with the lookup. Fixes: 68905ea65ceff ("irqchip/gic-v3: Add FW info retrieval support") Signed-off-by: Fuad Tabba Reviewed-by: Marc Zyngier Reviewed-by: Radu Rendec Reviewed-by: Zenghui Yu (Huawei) --- drivers/irqchip/irq-gic-v3.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 6e1fa5b247fc4..b0142b0a93fa4 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -1728,8 +1728,6 @@ static int gic_irq_get_fwspec_info(struct irq_fwspec = *fwspec, struct irq_fwspec_ =20 /* If the specifier provides an affinity, use it */ if (fwspec->param_count =3D=3D 4 && fwspec->param[3]) { - struct fwnode_handle *fw; - switch (fwspec->param[0]) { case 1: /* PPI */ case 3: /* EPPI */ @@ -1738,7 +1736,10 @@ static int gic_irq_get_fwspec_info(struct irq_fwspec= *fwspec, struct irq_fwspec_ return 0; } =20 - fw =3D of_fwnode_handle(of_find_node_by_phandle(fwspec->param[3])); + struct device_node *np __free(device_node) =3D + of_find_node_by_phandle(fwspec->param[3]); + struct fwnode_handle *fw =3D of_fwnode_handle(np); + if (!fw) return -ENOENT; =20 --=20 2.39.5 From nobody Fri Sep 25 20:46:59 2026 Received: from mta0.migadu.com (out-124.mta0.migadu.com [91.218.175.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA700538D73 for ; Tue, 8 Sep 2026 14:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788877604; cv=none; b=n+upFcJKDUW78y6Q2NMuQFgtngCWWoKle4dqlZexL0CVRPZdbQjdpiyOzW9PHK/6cdD1jnqiDniAzirxlHMvjDN/EpZhmVoORDe+qA94S5SvL/qdt0JttqReH7p/+uZoRmF9LizQPl6HKWggz2ntqtDU/C4WtiU77qvmo8W5W34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788877604; c=relaxed/simple; bh=KVsuIyiH5SB/1+xKdlUgJ1F2EW9DnV0+Qj4eqAyuRUo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=otg3S3slU8usbOd61RvRT5FJgCWlKwDGIYrjY/RUyajOj3LO4W9k5lq/Khz3EPawhSYRhwKiJmAgLAzFwd6Eo5l45b8xI8DJSomYaFEx7g0kHGXiJ0fpwSAEBY8/74DsxoXN6JmsEEB9toXA7doYmM1SKuXer0CQqz+uCItiX0c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=g9hqNW2L; arc=none smtp.client-ip=91.218.175.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="g9hqNW2L" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=KVsuIyiH5SB/1+xKdlUgJ1F2EW9DnV0+Qj4eqAyuRUo=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788877594; v=1; x=1789482394; b=g9hqNW2LcNLLLCtn9UMeGlfa5Q4h4g98K7xEuiX+kheDKs71iCgh7uXLixB47QWqiqqCKhq9 gy+s+dfT1glSMFh68f7+n+PTyvclNwUCE1n29sxKGAJaez28Latuw6RPbuLeOusxg/je1Q5s2si /8Qo+waJGUEWl3uhtA3vWTrE= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id e08221fc077519c4; Tue, 08 Sep 2026 14:26:34 +0000 X-Mizu-Trace-ID: e08221fc077519c4 X-Migadu-Flow: FLOW_OUT From: Fuad Tabba To: Marc Zyngier , Thomas Gleixner Cc: Radu Rendec , Kemeng Shi , Will Deacon , Fuad Tabba , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] irqchip/gic-v3-its: Don't clamp nvecs to zero when id_bits is 32 Date: Tue, 8 Sep 2026 15:26:31 +0100 Message-Id: <20260908142632.2795308-3-fuad.tabba@linux.dev> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260908142632.2795308-1-fuad.tabba@linux.dev> References: <20260908142632.2795308-1-fuad.tabba@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GITS_TYPER_IDBITS is five bits, so id_bits reaches 32 and min_t(unsigned int, ...) truncates BIT(32) to 0. nvecs becomes 0, its_lpi_alloc() rejects that, and its_msi_prepare() returns -ENOMEM. On 32-bit ARM the shift is undefined instead. The clamp is correct for every value below the maximum, so only that one value is affected. Fixes: ce9e40a9a5e5c ("irqchip/gic-v3-its: Limit number of per-device MSIs = to the range the ITS supports") Cc: stable@vger.kernel.org Signed-off-by: Fuad Tabba Reviewed-by: Marc Zyngier Reviewed-by: Radu Rendec Reviewed-by: Zenghui Yu (Huawei) --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-= its.c index e9807af235373..81a96149f9154 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -3484,7 +3484,7 @@ static struct its_device *its_create_device(struct it= s_node *its, u32 dev_id, * Also honor the ITS's own EID limit. */ id_bits =3D FIELD_GET(GITS_TYPER_IDBITS, its->typer) + 1; - nvecs =3D min_t(unsigned int, nvecs, BIT(id_bits)); + nvecs =3D min_t(u64, nvecs, BIT_ULL(id_bits)); nr_ites =3D max(2, nvecs); sz =3D nr_ites * (FIELD_GET(GITS_TYPER_ITT_ENTRY_SIZE, its->typer) + 1); sz =3D max(sz, ITS_ITT_ALIGN); --=20 2.39.5 From nobody Fri Sep 25 20:46:59 2026 Received: from mta1.migadu.com (out-136.mta1.migadu.com [95.215.58.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E392552954 for ; Tue, 8 Sep 2026 14:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.136 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788877608; cv=none; b=Mlc7NHjjQZprKDGCaWIt20dKiYThxipWx72LJee9hej2W3hNd6ZAMk3o/pnAAFsyMF7S/bvGMrraTTtS2oCKuituDWUCR0lGYJFI280ANw+4F7z6gBHZg8SGHTlNnNnwypAN3WHfZnhVv2rE5tr+by05Pci8QmqiGkESD9I43BU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788877608; c=relaxed/simple; bh=nBNi3rr/ynuXU4SgyyxAlr6fIfq350MdVspuBNckMOI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=st70+K/gX50GiglZXZrL0C+XGEkzdeLNkmA5dI9aS/UU09x1c5cqPQRPDwR+WuwtJxabnySHwt0CtHxQp45c21LjVyZP7mNRdiUl99tGD2JGsqtRCRDGVpf4VDWnZKNScVsAEcMdkva7gNOvy4Zhn84qXuEV8JpJh8EzYaQkexU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=e0W48CzJ; arc=none smtp.client-ip=95.215.58.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="e0W48CzJ" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=nBNi3rr/ynuXU4SgyyxAlr6fIfq350MdVspuBNckMOI=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788877595; v=1; x=1789482395; b=e0W48CzJU7EbNKzAtEbpGqNrB/IaIf24kcvNpIfG/+D1XnKnK3L99QVaWHUgKL0J6QiFr839 aMEC5xObauclnZnxySDjg2QaeFznJKE11bXCiP0K+bL1LbtuZz6uqy+/VeIOzjfFKME3QtcIf2Y RShliwTu8FVfJ7dM1Bc5ZirA= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 7cbc54a65df9e3cc; Tue, 08 Sep 2026 14:26:35 +0000 X-Mizu-Trace-ID: 7cbc54a65df9e3cc X-Migadu-Flow: FLOW_OUT From: Fuad Tabba To: Marc Zyngier , Thomas Gleixner Cc: Radu Rendec , Kemeng Shi , Will Deacon , Fuad Tabba , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] irqchip/gic-v3-its: Clear vpt_page after freeing the pending table Date: Tue, 8 Sep 2026 15:26:32 +0100 Message-Id: <20260908142632.2795308-4-fuad.tabba@linux.dev> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260908142632.2795308-1-fuad.tabba@linux.dev> References: <20260908142632.2795308-1-fuad.tabba@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" its_vpe_teardown() frees vpt_page without clearing it, so its vpt_page =3D=3D NULL guard only holds the first time it runs on a vPE. struct its_vpe outlives a failed KVM_DEV_ARM_VGIC_CTRL_INIT, so a retry that fails again frees the pending table and the vPE ID a second time. Fixes: 325ff3e78c64c ("irqchip/gic-v3-its: Prevent leak in its_vpe_irq_doma= in_alloc()") Signed-off-by: Fuad Tabba Reviewed-by: Marc Zyngier Reviewed-by: Radu Rendec Reviewed-by: Zenghui Yu (Huawei) --- drivers/irqchip/irq-gic-v3-its.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-= its.c index 81a96149f9154..f5d89e829c168 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -4599,6 +4599,7 @@ static void its_vpe_teardown(struct its_vpe *vpe) its_vpe_db_proxy_unmap(vpe); its_vpe_id_free(vpe->vpe_id); its_free_pending_table(vpe->vpt_page); + vpe->vpt_page =3D NULL; } =20 static void its_vpe_irq_domain_free(struct irq_domain *domain, --=20 2.39.5