From nobody Fri Sep 25 21:40:24 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AD22524AFC for ; Tue, 8 Sep 2026 11:00:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788865216; cv=none; b=RUoTqL/Z8Jc8xmXxUHx+bv37jR7eSVLYbf00GIR0ZUkE6AOV7eUTeltzIm1ykTpnc664G0TxzYUsLXAZU9aK7g2hhh9Ic7NPjICmVr6r6VONt8az/LlIZLhrfGzSzw5dmTk7xmgzP3+Zk7r5WLJhxLLIIb+/2I7CyFDUDqxO7C8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788865216; c=relaxed/simple; bh=y9Gr4AywwMVYDnuywxdASoBv1xZ0f0lO8p7SQzvuLRA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R9RnEzj1pTzyFH2+yp7avFCL/+gnzOJkUm2fsERqlaCiWcpYXS4UUUvwGtvOPjU4aZdaRbuuHsr9CffwWmKWZB8iUQVh+w/ZLbnXsX2bC2JfRW9aCV2xaBr6nGwimaJrVOgpTpHMqMl+xkdoExFgmGN5SoqixbWomWx+Lg/P1sA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BCPhik24; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BCPhik24" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccdaea75so285982a91.1 for ; Tue, 08 Sep 2026 04:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788865213; x=1789470013; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aiaBPjiI7pIKbuKui3KX3gQd9H7z3U0hyAR/GzHBHQo=; b=BCPhik24nDLqKBt/0/dtT+P0u4nKKobr1IrYzo2U6OwieMGwIv5cA63b6wz9aZDThG hLwApMlQb41Hi9RlheUNIVK6PeTYhH2t0L0pU44jrjK5vU4w1BHaizC4ch/HBsJYE9xf zOqokZPX6lCdCEgum1QPBXvojXBMXhlI0veICco0w30CNUt/0jiyny/TLayScTFzRRW5 lSmemoiBEGIoAilGs+knsfr3vg+/J5+rokqmUzeTEzbpksakjl89eAlIuT7iXdAgxBkI sRvDtBjGK4cUPKECyqQ9RSlxyUSUX5+lYEuKQ4Ct7Zt5TfNr72i+xsr0CElSfPyWeXzD r8Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788865213; x=1789470013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aiaBPjiI7pIKbuKui3KX3gQd9H7z3U0hyAR/GzHBHQo=; b=m4pIkNrKZ2ypPw43YSK3tNDsla91zrqfkDm3hW88P2OTWkOT/sNqOawlFYF7hkVyMj cCKV7wt65nKrs5MXFlFhr2XVSklgLR3u7vrWdNFWiyJflE6JuZoCHOqMa88BWthqb0u9 yY2AGYa5cgn1BRj/kexBicseaSCkNFMKwSPcUPYMKsxQNZ5vC2wrX7CVIw6GhsdxR7T5 9tqaC06uQdFvtGRVPDcCNzrg/cXTe031P1RCrIozhjCiCqADb7PWkkliyxgM2Lb6dlRz a7JF24SrHgQTLNYzJswm+9bS6qwjv3hHGfoakIBIlPjiWWNZVlXXgHm4B8I1buJHKD/O eTRg== X-Forwarded-Encrypted: i=1; AKwUvBxX86yT3isW743j7GpoSRisGjAfPaMPKAX3VIxcc8qkXMHv8atZJzEJQX6HElri/IfwI45JPkwC7XUhPO8=@vger.kernel.org X-Gm-Message-State: AFuF++n1h3xeIK3mfbphBEpYuU9LDFteNsmZkFTKlsN5bJtXE5gd4ptP aINgu6iKwFRK/HHHT6nFIomuzqjEK3BxvbY70YTU46JBvc5mXAjgIlM= X-Gm-Gg: AYBFou0EEw71U56asM2Z+6KV3rmkRoihfz5KRXhmLxpTpJROc43FTZKRH+LwI1SzYxV YpMj8Dw279/JrebG0w+OfaxTo9bKHWyU9/7k8uxvQI1oW/eZy9jPV1r1+CDo/X6nBxXwyGu77O0 P9bv92oCAh54LFiA3Qm0xDMNyS+vRdvvGfGuq+WVZ8gkKXaHX8lY+nuHKXFT9PjeXMvDk7KOkiu WwnZ09xgXo+a1WNT4ATNm151kYPRqM0aKLkMNXm/biKEsX5a44lHtllXbmZ4Hd0pDh6IkLEAZyr aQ3ptJp461eeaYBNVAElFMH9qD6cJFHgsPxm8SXMz49HwOxNfQ+RvVQbS3sv+61ix5AeYwsdJw0 D2wUfe0lJTFIJCOYGoaMAy3AZ8kQ7J/jFvkmoG38G9TuaHNhGvrCs9tsM09IuQX5rNzwhj+i05H 9TDWH+RXG33wzfJz/Vf7w+fMwPi4eWi01Zq9dDCn0MAizmO8QTSuaHlR18KLygrwBh695wBTcpQ FhnExtV5HIyBR0s X-Received: by 2002:a17:90a:f945:b0:395:8124:ac53 with SMTP id 98e67ed59e1d1-39b8bd31191mr5493595a91.6.1788865213271; Tue, 08 Sep 2026 04:00:13 -0700 (PDT) Received: from ydg-Zenbook-14-UM3406GA ([2001:2d8:6467:d689:f6ea:9d29:b387:9ed5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08cacbb0sm32429842a91.13.2026.09.08.04.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 04:00:11 -0700 (PDT) From: Donggeun Yoo To: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: linux@armlinux.org.uk, daniel@makrotopia.org, o.rempel@pengutronix.de, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, donggeunyoo.kernel@gmail.com, stable@vger.kernel.org Subject: [PATCH net v3 1/3] net: phy: dp83867: handle the active-high LED polarity mode Date: Tue, 8 Sep 2026 19:59:57 +0900 Message-ID: <20260908105959.70453-2-donggeunyoo.kernel@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908105959.70453-1-donggeunyoo.kernel@gmail.com> References: <20260908105959.70453-1-donggeunyoo.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs") added PHY_LED_ACTIVE_HIGH and made of_phy_led() set the matching bit in the modes mask when a LED node carries the 'active-high' property. dp83867 was not part of that series. dp83867_led_polarity_set() only recognizes PHY_LED_ACTIVE_LOW, so PHY_LED_ACTIVE_HIGH falls through to the default case and returns -EINVAL. of_phy_led() propagates the error, of_phy_leds() drops the LEDs registered so far and passes it on, and phy_probe() returns it. A device tree marking a DP83867 LED as 'active-high', which leds/common.yaml allows and ethernet-phy.yaml references for led@N nodes, thus leaves the mdio device unbound, so phy_attach_direct() falls back to the genphy driver: the PHY comes up without its DP83867 configuration and loses the RGMII internal delay setup. Active high is what the function programs when no polarity mode is requested at all, so the initial value of polarity already satisfies the request and only the case label is missing. Cc: stable@vger.kernel.org Fixes: a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs= ") Assisted-by: Claude:claude-fable-5 Signed-off-by: Donggeun Yoo Reviewed-by: Andrew Lunn --- drivers/net/phy/dp83867.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 88255e92b4cd..61a941aa02d9 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -1150,6 +1150,9 @@ static int dp83867_led_polarity_set(struct phy_device= *phydev, int index, case PHY_LED_ACTIVE_LOW: polarity =3D 0; break; + case PHY_LED_ACTIVE_HIGH: + polarity =3D DP83867_LED_POLARITY(index); + break; default: return -EINVAL; } --=20 2.53.0 From nobody Fri Sep 25 21:40:24 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11DC4C6F08 for ; Tue, 8 Sep 2026 11:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788865221; cv=none; b=OMzQuQlqcJFjCJ55b0ba5AI4g6PNn7gTrFj6qN+7vJaw7d/sAEUPwvjprbyXtjP8P6br1oIgF2RhNdRqhcojDf7fXrDrHNnjSkFTXhUw5rfgwsNb2vjEZHPdE2sLZ96568SaQZVIdLg0XBmJToZuoPDqtyCNf1BMEmShbriS7NI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788865221; c=relaxed/simple; bh=Suqd5ftmj9Y6jk+Ge3M0i5T+AGs4crNAREB6UPMJwV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=orUEjzV215Zxv6qofMb1ryrlbXDaJB9l3EJKP417VDmYgxJ7ZZOoUsjx7i7v/CliYUTUehiqEBgZ8Nh/ZJj0FzxTXqxjiRy2ux97bb26D4eQWVAEo0E1oILS6JsNv9O9WpO1mI1xHb1RWvR7XxnVZdZ2DK4t5cbhseRr5BRrhDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XaKesQsa; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XaKesQsa" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-38e42560ebcso3230972a91.1 for ; Tue, 08 Sep 2026 04:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788865219; x=1789470019; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5MIH5m8h4rgx1wf2ZdrB4T0rpezySvGnbGk7lhC4ZfU=; b=XaKesQsayHa33cKi/oxjUxR1e7fx9zCCzLvtX4oKd1R+tq4A5G1D27r34HcDaUQJtg iYmfJroc0p6vmNl0LnuSfE7x2OyeUJ6GfmvHihAechfBWtRDlJoMb9RmzINHnZqzImU+ KqrJuGrL2EDf0XF1kOLTCzCCuPsPicOe1+HEjDB16iXWnAjw52AkTFskGo55Fgv8Uhi5 qKTPDjjHkn+4/tQI/HwNkHDvc8o3XoXs+i7AmAu4+f0GjwaUCvLffUvZg3F6Fzx+52f6 g3bRXv4vTziTlQW70VkU+gzg2U/sZKK9MAI5K7j7evQqCMxDti8o9vlIuaKH1qs12W/x kL5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788865219; x=1789470019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5MIH5m8h4rgx1wf2ZdrB4T0rpezySvGnbGk7lhC4ZfU=; b=YZeZxJs3V/EPEYG2miUhn4WWpum37XeDY+jWtnsTp456CJDlhxgg89q4F4fSj7CGW8 JcwJ+t4xB8JYVtJ/KFwYhids3H1MdXY7RkOTyWh7eXofVzk8wESRsbuB6NRh238xLqPg xMEnvjAQmqb2Tal0S9g2o1Y5Iv6DxOqecQq+AZ1MLzu72jc2fcoJOSy5U+Zq0hEUi6Wv NHWcSdtvrXQuzWzp1sAx1f6o2eoVWzHIE11XSlxX/2hiu6ivV8as5KT6qkN6afRxggKO Jk250YDPzC7oUTGr/s9ugbBApRgFveUYyFVLREposLh9/MFHyEvmYN4HxTjmuMNPSXXu JzHA== X-Forwarded-Encrypted: i=1; AKwUvBwdt0V8AigenkuQ7KeVC9S3Oe9EfTxHG2WEoEg99vzcXLqdur9hdiAWetwdULL0QSJrxA8hU4px5FLkjis=@vger.kernel.org X-Gm-Message-State: AFuF++kNxQMUEqu35T5vPA7iRGXhMKzjodEksr02JcO85yWMN3T431LS EJ0OxKvxiwz7P6kU/lL2CIbCl1ziqxY354LrGdiusLKR7mB+/oSwXEM= X-Gm-Gg: AYBFou05fJZGg/GeTpO/Ry/QMBPhWNcgSu5pI4jfLmjO19XcXIaO2VRPRS+7zYvL8PD /zo/0hoy9wP8gAJd1d1ECvCWNOa05vXWLuXNdocFXKa51MSCpUlHSi3krd3nWhUknFcsuLSAOjP Kc5yXUQalr3xMIic4j2WMuhCG3cbr1xE5rrdXZMskl4WIa7mmVhafiHHqcswrVGKT6xmCEX9YGC Kam77FhhFKqsY/YVKvijftZ/CNkrMW68ZsjiykdANfsdSH8lKHLdMLN3TA3MsLVxW1BanE0IoZz U8bPSa+ZZb5y/aD0S5KUtOfm3Da9QPdAE6amUwyZzxyEdPEQNh6qnLnVBpIDeMZ+ji7wbJUsxyL ueEFG+DSz2JbeFsD8UELKK4EkxTBl+hgkyufIHZOydYuavyb49uQ4gKkG0kyDGTvWI932x90x7k ltsYrZgrw83OmeOtKr2Df+XAK5oYSzR+J3+fThrzi4R16y1IZvmqjRUV/hXdnB5cl03YPihghMB qhnwGC+Uu0F5K9Q X-Received: by 2002:a17:90b:3d92:b0:398:bf7e:b267 with SMTP id 98e67ed59e1d1-39b2614df9dmr43960484a91.2.1788865218856; Tue, 08 Sep 2026 04:00:18 -0700 (PDT) Received: from ydg-Zenbook-14-UM3406GA ([2001:2d8:6467:d689:f6ea:9d29:b387:9ed5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08cacbb0sm32429842a91.13.2026.09.08.04.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 04:00:17 -0700 (PDT) From: Donggeun Yoo To: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: linux@armlinux.org.uk, daniel@makrotopia.org, o.rempel@pengutronix.de, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, donggeunyoo.kernel@gmail.com, stable@vger.kernel.org Subject: [PATCH net v3 2/3] net: phy: dp83td510: handle the active-high LED polarity mode Date: Tue, 8 Sep 2026 19:59:58 +0900 Message-ID: <20260908105959.70453-3-donggeunyoo.kernel@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908105959.70453-1-donggeunyoo.kernel@gmail.com> References: <20260908105959.70453-1-donggeunyoo.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dp83td510_led_polarity_set() only recognizes PHY_LED_ACTIVE_LOW, so PHY_LED_ACTIVE_HIGH falls through to the default case and returns -EINVAL. of_phy_led() propagates the error, of_phy_leds() drops the LEDs registered so far and passes it on, and phy_probe() returns it. A device tree marking a DP83TD510 LED as 'active-high', which leds/common.yaml allows and ethernet-phy.yaml references for led@N nodes, thus leaves the mdio device unbound, so phy_attach_direct() falls back to the genphy driver, which cannot drive this 10BASE-T1L single-mode PHY, so the interface has no usable link. The callback initializes polarity to DP83TD510E_LED_POLARITY(index), which is the active-high setting, so the request is already satisfied and only the case label is missing. Cc: stable@vger.kernel.org Fixes: 5b281fe7e396 ("net: phy: dp83td510: introduce LED framework support") Assisted-by: Claude:claude-fable-5 Signed-off-by: Donggeun Yoo Reviewed-by: Andrew Lunn --- drivers/net/phy/dp83td510.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/dp83td510.c b/drivers/net/phy/dp83td510.c index d75dae6071ad..9e9a41bf6457 100644 --- a/drivers/net/phy/dp83td510.c +++ b/drivers/net/phy/dp83td510.c @@ -439,6 +439,9 @@ static int dp83td510_led_polarity_set(struct phy_device= *phydev, int index, case PHY_LED_ACTIVE_LOW: polarity =3D 0; break; + case PHY_LED_ACTIVE_HIGH: + polarity =3D DP83TD510E_LED_POLARITY(index); + break; default: return -EINVAL; } --=20 2.53.0 From nobody Fri Sep 25 21:40:24 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 005585293E0 for ; Tue, 8 Sep 2026 11:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788865236; cv=none; b=AcnjFqrf0yHfgAuzWp18pyvawVFwefasar7uas+vM+4mrmd2DrXwnB8ci8KUJjwGwETxFPohv+J2HaXcLK+uAaUKdsfoCo+QaHWp4W2feLCqIP6bU/FooQkGKgEjRSPo2ushFxE2zJUAatCs+szJrJh7KgYUDI7POZv1KROqSFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788865236; c=relaxed/simple; bh=7YonU+3U3Csgg7NVd1AGIrmwK8SsFgirVwtU4hC2YHk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iBs/lHDqC08gA0GdoPcjTruWzJlxkIGBhGSJOPuMHmR0kIJ8Pj3RWMNsgIz4lE+U13AureJpesuuvuaWEkImzBQMn0IquTy5HhM9nI2mcma3XHlQ02XFqa2IpX6TOAoC3As1x8KViM0ueT2ScU6c0spqlH9lw2zQvOW+f1V9Sz4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hw52+2Js; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hw52+2Js" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-cbee846deecso5222630a12.1 for ; Tue, 08 Sep 2026 04:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788865234; x=1789470034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1LQOiRmCK+7QjsHZ0o37HxXuGfkjXxAF0goXiA50ma4=; b=hw52+2JsO+1UNjgLYqHy1Lt3O63eTH+P6uwOEoHrK/shkV+itUIFZGuSm4oKEFAmkt GyIFL5GhgGAwcAnF4a3FdPJuMMlMqEl93/rzbBpBoDfQHf7wotgkIIKQrJWXoHO1bxbW cVTIzkclE0RzOEI6f3lUKSycSC/gSua7XGZ+IWRaNAn1rjvnVGerxnfoXibljnvxdXWV IaBjn9cflhrxLhj+X2VzvKBDX+kAa+cN2dGpN5oiID+TymDLi2HlVRmMBs0tV5HOkBsg A+NsZ9T+mM9HSDqG69o68xqnhkD7YWHwbgROaeHV+TznHELZ8R7IwsbLN2reqK4RyCWQ qfQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788865234; x=1789470034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1LQOiRmCK+7QjsHZ0o37HxXuGfkjXxAF0goXiA50ma4=; b=U1+00wLBZpV5FMCeflx56JQsv8VKDZivVpzqHZEnYax0rISOmlDvG5aN2dQ/XSwLVQ GaZW7/No93o1onLJxfSbViqGQoHCVsvxA+qhZigxtmTmYlOJ5xD2zWJzwYNWMUTb3mEC sqSDdmJDpU+mwmeAbJtQfp2LgmIFQKThGwsYI9CX4eUC5fo3S4YLiQFYivqDmlfADEm8 6+cGX2b4a6UdE3qSDm8K+aln8tpzfp3MUbNwPdlRX3Fy7u3VCNYf+mbTdI8AMKnC0HJj Fb92R8uy/2NLrcCdpLLGEw+Mho/HtPW9nay49GLe3qRgcNZ9/2KD7gCyoZM486yDGWBr a7QQ== X-Forwarded-Encrypted: i=1; AKwUvByfPcc3Dg+NvQtWbjSFQuM/TeGy2PJQdTRLTuNhBsUFyOWDHrRatRweed/NPc2ZimdkOVkIVoB8xUu5Imk=@vger.kernel.org X-Gm-Message-State: AFuF++mxV5vfUoJdmo8MDQBjUFJ2tKc92DjGbQxZ1kyYWrPdJVfz9Nti +gsb7DZmw3ZLppi3SfaAERwLr045NHtcB2k1WXgtP0senQCObktE1Uc= X-Gm-Gg: AYBFou0UaE5Ns59s1mtsUxBMR9WVd8kbNwqoQv9p6MHGR/GDBKgTa0Q0ps9np3JrjhW brlmrXDJ8WsUMSyEw0ZeV9ZX0Q4rO8XVL7i8NWHQXvgGC1UE9DiC8tLtKKrviPUIvV3zMZBggW/ cJR8mS65xpUrQdGLYc5fBJfZ9tiErY1Tejp/AxGDrhFM7bz4+PD6huJKAcOWXqoOfOdZSfILyo2 piLv8oSiD62QE6+sLmFft0JRMFqesajvUJnu1lf+n8JDOWCg1bKHhlejs06UwfRXjmujOMP5rCW DMozr4tM73AUkVTo3ijtdqpuxniHaptTQNGja5iGmEzRlQSndFRPLi60Z8cGeWcZYRKPvMZEdSW P3FXsqrrI4fc6wJPWTiGG+zKH8hjndyjq5wLQm3R+uh4PEAV8pvwnTjN7LbMECs0rCFHE/y0GCh REkjVdZaJsYgzVAjGRDtgg5rpki6epQk/D2J8qOwr9Dxof04gmTcgj++drAnb3pDt+hiK2Ho6J5 xMvJeMETdM2La2M X-Received: by 2002:a17:90b:440e:b0:380:fead:448d with SMTP id 98e67ed59e1d1-39b261e1011mr40346945a91.13.1788865224500; Tue, 08 Sep 2026 04:00:24 -0700 (PDT) Received: from ydg-Zenbook-14-UM3406GA ([2001:2d8:6467:d689:f6ea:9d29:b387:9ed5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08cacbb0sm32429842a91.13.2026.09.08.04.00.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 04:00:23 -0700 (PDT) From: Donggeun Yoo To: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: linux@armlinux.org.uk, daniel@makrotopia.org, o.rempel@pengutronix.de, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, donggeunyoo.kernel@gmail.com, stable@vger.kernel.org Subject: [PATCH net v3 3/3] net: phy: qca808x: handle the active-high LED polarity mode Date: Tue, 8 Sep 2026 19:59:59 +0900 Message-ID: <20260908105959.70453-4-donggeunyoo.kernel@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908105959.70453-1-donggeunyoo.kernel@gmail.com> References: <20260908105959.70453-1-donggeunyoo.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs") added PHY_LED_ACTIVE_HIGH and made of_phy_led() set the matching bit in the modes mask when a LED node carries the 'active-high' property. qca808x was not part of that series. qca808x_led_polarity_set() only recognizes PHY_LED_ACTIVE_LOW, so PHY_LED_ACTIVE_HIGH falls through to the default case and returns -EINVAL. of_phy_led() propagates the error, of_phy_leds() drops the LEDs registered so far and passes it on, and phy_probe() returns it. A device tree marking a QCA808x LED as 'active-high', which leds/common.yaml allows and ethernet-phy.yaml references for led@N nodes, thus leaves the mdio device unbound, so phy_attach_direct() falls back to the genphy driver and the PHY loses its QCA808x-specific configuration. active_low is already false when no polarity mode is requested, which programs QCA808X_LED_ACTIVE_HIGH, so the request is already satisfied and only the case label is missing. Cc: stable@vger.kernel.org Fixes: a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs= ") Assisted-by: Claude:claude-fable-5 Signed-off-by: Donggeun Yoo Reviewed-by: Andrew Lunn --- drivers/net/phy/qcom/qca808x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/qcom/qca808x.c b/drivers/net/phy/qcom/qca808x.c index 8eb51b1a006c..3ba58f14e248 100644 --- a/drivers/net/phy/qcom/qca808x.c +++ b/drivers/net/phy/qcom/qca808x.c @@ -603,6 +603,9 @@ static int qca808x_led_polarity_set(struct phy_device *= phydev, int index, case PHY_LED_ACTIVE_LOW: active_low =3D true; break; + case PHY_LED_ACTIVE_HIGH: + active_low =3D false; + break; default: return -EINVAL; } --=20 2.53.0