From nobody Fri Sep 25 21:41:03 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D58EB41DE11 for ; Tue, 8 Sep 2026 08:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856116; cv=none; b=fmpkd95bHzh7g8ejxhNVKuE1EkTVS/wxtI/HoH2SAO78qYFNit4EKS4fdKUG2jZPSU3YfSAx6ocfh/FKs5EeCSjHkytEdPwAsZXhTx86lX10WjoaRnKRCmu6K93k14HhRKhQ8b+cfEscgx0VJRYFG/neH6Sitc8X6uP4Kjdiq8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856116; c=relaxed/simple; bh=0pC7ctkGeNewlXTVr325Y7LXGf9gQxuih85kMSrjigI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qZ2xXI/OJl13alAM4gc9Od7edqiCPN+tB/mCHtzcvFBoa405FHLqSP6n3UW+eiYvvPCOimVDs81ge3a7uc12vzBenP3us7L/5qJg4ORDMJzQQ9H9+PYdrtcZYiu7+eAfOpEFgRTd/BWWKFk13sUuY3Ti/7UYIPPjnVM7mtGSTQg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ofkNmySt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FEhSW/BQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ofkNmySt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FEhSW/BQ" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886M1AR2979240 for ; Tue, 8 Sep 2026 08:28:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=JaWxqW0guWQ LGddd73wExT8hAoeqwzidPzMb7Po6lo0=; b=ofkNmyStFzHs91ob9A1Ts7e15K3 Sdzz9xmOYVz9wx4Im2G/wbfkq0c5XTnbWiJZAntZAVGE7LUHUppCS64L3PQJOoZk Jz1u5V9VW8KFwb2DGHAT0RdBUvW1/ETSApNvPIGWkdK5BkHaNy32XF3457lnc/t/ iqASfor7iIXXT0tA5L1TEh/rdpkdnxopF6mLigjRQVo28et2+tmaep8JRbRFI7tw +tMH+3a0+Wu7YYnMNWzJrK4BlZPeAFPvbgEoW84C3pIvbEgPSbr+DywtMDeO0osR +cTaLkvnrbkrg2nIXoE1BXtcM/u72XnmfCTbHX/w/4jus6GW+JBCAhR98Aw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghuykbwqe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 08:28:34 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93975d63ffcso483065585a.3 for ; Tue, 08 Sep 2026 01:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788856112; x=1789460912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JaWxqW0guWQLGddd73wExT8hAoeqwzidPzMb7Po6lo0=; b=FEhSW/BQU3vpL4NclwSaLuP/yIcMtXhT3gOH5EE54oU9IeDSMJ52SHZmByde8EW5ma JlKVp3MGTMN4TG9TvjPMJYfkVsgER41R7PP/RFQwBmhOtKWTupCnH1Y5qLwoIpQKWpZy z7WkfFH8OOOy4DLDJZ5Tekrez0LtuvX+DI7qQfd1BtQzUn8HXUvfuX3mmcp2iPuKkZ/m rlCkUVbcIJS8CLF1ZiEAwKRcSvF01q7Ua9Ou2AWRjakcGC55IAswn1vQWGB/UlprjOEc vhh7dv3Nd3BPsx7lxmGZGFzW4XS1U6kdqIaADWl6Jjyw0SG9/UNQhTwMKwPOCNBg8P63 TneQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788856112; x=1789460912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JaWxqW0guWQLGddd73wExT8hAoeqwzidPzMb7Po6lo0=; b=HqhRXtAmSXbSZVvBka4EufYjzZgY39szG+vayUQmNShmpUzSwuEHj+BGzJ9wSli9GB 5/oQCv9oOfKLn3MLV1bNLBaxIAhVLVqLMI8jYEZaBAKKyjPfiFYK1YfhPRB8R+tX+wHY 3z9315pik5E7N9diDG/SWg+5mMjGirWA5xt6dtSYu806uN9WPL0XCX7frS2IFxM7QgY6 JMLHURs4OojbH5feOPIGuaFQ9ArzGbcTodq0oyvX+NPggZz/ehFUc1NsGmiudmE51pfM 6BUWh+t7cEB5f0j0+PffP3nSlAFOhPFKGG2gn7luZ+Pwp2mrS68Cqcm79zacVhE/rK3y LTkw== X-Forwarded-Encrypted: i=1; AKwUvBw22Fw0rftfQwml7bGegat46M4HivGBjfVQy/iZzqShnJSDykX7VjwTTsn2JL3FRjrP+RfJ2L6rxpZtomw=@vger.kernel.org X-Gm-Message-State: AFuF++nXZ2AVQDeQ3P8E5cudQvCb2UNixHHH/OiQOIWJ70mxCZXQZ1Ro u0Fyu/wxJLiug52vo5phAbScET4V+lyChc9d/raUE24WLIOn7ZKpVGiEXn+6o7R4k9APP9Himug ris7gZSS8Cyaw+yh8CTmZ7XkUM4VSNE80R8vEhx3fIxyz6W8AOKBx3jMiSNQimFzzRWY= X-Gm-Gg: AYBFou1ZEQcJaQJj/J07q1pOvZEAeBCP/1KqbP20TFQSIWzOWLkiUq/6KO8WjO4eFsq d5Of8nlc9KP1xWRVDbJzbs6y5h/rcjgHRfCkR23mMo3yUmUgKa2Pvfb5WkR0zUmBjQtgG8Yb7cu te7QFH5kTenrsBfpL1F5befixYEyQdqKkIXwEkNBc0bUw1h5Oila1cRinN6oRY66O/ozipnt9sd +lqbpsJhCRZqmOnNDedPn0ndP3RLEAKVYPkibWt0XxIoVEofWhWv/RDxvgxUJqVwisZuO9ChjTM +uyqnOc+snhUM2m7gH/IQOxOWaBTQj6MoatAAk9lQ9cXYFrhXpxXFNgLALVCqdEnKMNOy+dgdNc o+YXfc40GBVvvfQ== X-Received: by 2002:a05:620a:29ce:b0:937:6832:1f04 with SMTP id af79cd13be357-9398042bf14mr2983382585a.34.1788856112359; Tue, 08 Sep 2026 01:28:32 -0700 (PDT) X-Received: by 2002:a05:620a:29ce:b0:937:6832:1f04 with SMTP id af79cd13be357-9398042bf14mr2983380585a.34.1788856111944; Tue, 08 Sep 2026 01:28:31 -0700 (PDT) Received: from debian ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf7736132sm369414605e9.12.2026.09.08.01.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 01:28:31 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: srini@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla , stable@vger.kernel.org Subject: [PATCH 1/6] ASoC: codecs: lpass-wsa-macro: use v2.5 Compander1 addresses on v2.5+ Date: Tue, 8 Sep 2026 09:28:01 +0100 Message-ID: <20260908082806.648797-2-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX1o70GTNY/tR2 l83a1+4QAT2SR0jZlgQAJ7Y/Ecopv33a2EC1Fo3yRBQdW0gPmI28l+86CQM+ezojVtv+wZnwJ0h DMhK4N43BCWZcdJseulgUyMvLnLm+8g= X-Proofpoint-GUID: L0Xk-hQETNjW1W8xycbkGBw5yL6ANknD X-Authority-Analysis: v=2.4 cv=ObSoyBTY c=1 sm=1 tr=0 ts=6a9fc732 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=cQ6CwtaciBsBVqg4_WcA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: L0Xk-hQETNjW1W8xycbkGBw5yL6ANknD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX3rAf+dr5/HpA VNNupkRCiTZWc8rtkpgMBkQ3lAhI6kntnzcdu3gBJE+NQZ8R2oCk0dYfDeYXL2ORUwc8JojbEYi mR4SyQwHi/1iS6tnkuC7pbGkNiOiFM7CuzYdubAHAbO2ByfPAz4o6Q07z8kcEL8vwTo0w6YAQTH 7JRYuFcO+d+pgB8AuO7vH0ZmEwF4HeElQ5L8iSEbKloqfjUR8N8rpaRz/X6sStNmCPkBpYTO7eW 5FS+TrDAZRyf0UqxCcmSpsI5HPwDexhJiM4E9vo8lmidNQdsN5FG7bDIsFZAB0kCZkdkvOMrona sGE2if+6TaD/XOMG2+LuRMJZVL0yxOdWOKNTlup1jjD1bIs0btK4QmSAYzYc9Xl+d0SaFlHR8P7 OQbzg0HFFfJAVTM3JYRXXyv8hPpC0rpLdpZsk83PMlUyfVVRRSkP2pUG2w6Jfql7h/qFJm+wADM pcxBsGI0wrBLTFiUpfg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080088 Content-Type: text/plain; charset="utf-8" wsa_macro_set_spkr_mode() unconditionally writes CDC_WSA_COMPANDER1_CTL3 (0x5CC) and CDC_WSA_COMPANDER1_CTL7 (0x5DC). On v2.5+ silicon these registers moved to CDC_2_5_WSA_COMPANDER1_CTL3 (0x5EC) and CDC_2_5_WSA_COMPANDER1_CTL7 (0x5FC); the v2.1 addresses are dead on that hardware, so the update_bits() calls take a bus error: wsa_macro 6c90000.codec: ASoC error (-5): at snd_soc_component_update_bits() on 6c90000.codec for register: [0x000005dc] The flat regcache had been hiding the read side of this by returning the zero-initialised cache slot instead of doing a bus read, so the error only becomes visible once the cache reports the miss honestly and regmap falls back to a real bus read. Select the correct address for Compander1 CTL3/CTL7 based on codec_version. The Compander0 and Boost registers used in the same function have the same address across versions, so they stay unchanged. Also collapse the two mode branches to a single sequence with mode-selected values, which is what the switch was doing anyway. Fixes: 727de4fbc546 ("ASoC: codecs: lpass-wsa-macro: Correct support for ne= wer v2.5 version") Cc: stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-wsa-macro.c | 42 ++++++++++++++++++------------ 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-ws= a-macro.c index cfd2ac0a6cda..7a2b0cf9398a 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -1129,27 +1129,35 @@ static const struct regmap_config wsa_regmap_config= =3D { int wsa_macro_set_spkr_mode(struct snd_soc_component *component, int mode) { struct wsa_macro *wsa =3D snd_soc_component_get_drvdata(component); + unsigned int comp1_ctl3, comp1_ctl7; + u8 comp_val, boost_val; =20 wsa->spkr_mode =3D mode; =20 - switch (mode) { - case WSA_MACRO_SPKR_MODE_1: - snd_soc_component_update_bits(component, CDC_WSA_COMPANDER0_CTL3, 0x80, = 0x00); - snd_soc_component_update_bits(component, CDC_WSA_COMPANDER1_CTL3, 0x80, = 0x00); - snd_soc_component_update_bits(component, CDC_WSA_COMPANDER0_CTL7, 0x01, = 0x00); - snd_soc_component_update_bits(component, CDC_WSA_COMPANDER1_CTL7, 0x01, = 0x00); - snd_soc_component_update_bits(component, CDC_WSA_BOOST0_BOOST_CTL, 0x7C,= 0x44); - snd_soc_component_update_bits(component, CDC_WSA_BOOST1_BOOST_CTL, 0x7C,= 0x44); - break; - default: - snd_soc_component_update_bits(component, CDC_WSA_COMPANDER0_CTL3, 0x80, = 0x80); - snd_soc_component_update_bits(component, CDC_WSA_COMPANDER1_CTL3, 0x80, = 0x80); - snd_soc_component_update_bits(component, CDC_WSA_COMPANDER0_CTL7, 0x01, = 0x01); - snd_soc_component_update_bits(component, CDC_WSA_COMPANDER1_CTL7, 0x01, = 0x01); - snd_soc_component_update_bits(component, CDC_WSA_BOOST0_BOOST_CTL, 0x7C,= 0x58); - snd_soc_component_update_bits(component, CDC_WSA_BOOST1_BOOST_CTL, 0x7C,= 0x58); - break; + /* Compander1 CTL3/CTL7 moved on v2.5+ silicon. */ + if (wsa->codec_version >=3D LPASS_CODEC_VERSION_2_5) { + comp1_ctl3 =3D CDC_2_5_WSA_COMPANDER1_CTL3; + comp1_ctl7 =3D CDC_2_5_WSA_COMPANDER1_CTL7; + } else { + comp1_ctl3 =3D CDC_WSA_COMPANDER1_CTL3; + comp1_ctl7 =3D CDC_WSA_COMPANDER1_CTL7; } + + if (mode =3D=3D WSA_MACRO_SPKR_MODE_1) { + comp_val =3D 0x00; + boost_val =3D 0x44; + } else { + comp_val =3D 0x80; + boost_val =3D 0x58; + } + + snd_soc_component_update_bits(component, CDC_WSA_COMPANDER0_CTL3, 0x80, c= omp_val); + snd_soc_component_update_bits(component, comp1_ctl3, 0x80, comp_val); + snd_soc_component_update_bits(component, CDC_WSA_COMPANDER0_CTL7, 0x01, c= omp_val ? 0x01 : 0x00); + snd_soc_component_update_bits(component, comp1_ctl7, 0x01, comp_val ? 0x0= 1 : 0x00); + snd_soc_component_update_bits(component, CDC_WSA_BOOST0_BOOST_CTL, 0x7C, = boost_val); + snd_soc_component_update_bits(component, CDC_WSA_BOOST1_BOOST_CTL, 0x7C, = boost_val); + return 0; } EXPORT_SYMBOL(wsa_macro_set_spkr_mode); --=20 2.53.0 From nobody Fri Sep 25 21:41:03 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBFBD434E5F for ; Tue, 8 Sep 2026 08:28:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856123; cv=none; b=aA215wOoEf097yfeR2OmhDU/hLQULXXg/B+M7gV+3lu5vBDCIHiGahbFhMXB62Z5ENWtXZP/0boT8AaGTYt9j9R6toPBztSWq4fHn6DVqo+bLUoZbfh3LuPR7iRBKBIeqjFy/hzBvy6lds6m///+Y4SFG2T5jKVWDYsWoWS6ZD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856123; c=relaxed/simple; bh=/c4NFy4mbqgcTubVGDjrm/L6/KR3/OhBlimCDlvlQro=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WTG+VLLncj6LU2JOWwQTNMMyrpbr7ksexnvSqqnf8cnEHtD2E6X5n2TyChEMg4dnw7YR/XQeuNtvCV8UIsBdBanJ2dpYW339/API+4Cl0dtX3bcr3AfAzdMCljbrCaCpdbV17LqGUN06KtsslP63WShlTHUnVZqiTBnnuHcud1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Er8OCECr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BID3uF9Z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Er8OCECr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BID3uF9Z" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886M9Wn1521661 for ; Tue, 8 Sep 2026 08:28:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=UTCiQoU464h tRcfb9JVhf0FdQsMAlBERFwecvyCAnaI=; b=Er8OCECrtI7kIrpa0dzH28R5A+y MeNFcIbAqY3h/yV8hdCACo/72q+jmpR1MU0snJ1/BcX1vDxUB/rmhHy0hOg9WjRb UUpQrhJH3pjL9JBMbhI7JCYxvgTnMFJruiYcep+wYeUlDLJZPM9QhNUyVRGdVXfM pgsGIlteR/0I9+23QUnBBgSJIWHTPbBkCARkMn24BjgfROVsJnFR7cGxiJWS+DK+ C8uTGnsny3+m7YrUkUV54nOFi1snMvJNB5PziODKnaj+3oO/fHMoFy/CjX9GXzCA QZq4yw/TAjTQhOV59fBbKJHCsNioPd4Gd0yI33rI4xAZIH/El88LUr0rc8A== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gj077jsap-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 08:28:39 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-52d33c89a29so97120481cf.1 for ; Tue, 08 Sep 2026 01:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788856113; x=1789460913; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UTCiQoU464htRcfb9JVhf0FdQsMAlBERFwecvyCAnaI=; b=BID3uF9Z3DgDKmwlB0w3t6I74C5o1uRWR0FRx/QFFjzF4AyIeHRZOx7Hvf9o5ku2r+ pMU6iiAPGiLxcJ24pZUc1U7lVxI6518os7kFlgYt4dcJca3vjOx6J8NpKh6DMJUPCbXJ Kx8CcqNmWq/96rn3eSTFmSxD3SLaR7nJ8WD+eLlHnfQ025JtGoRKZbYT3lW4zllcFUH2 5+U4XcUM7+lnG/eZJ9oX686apeFADTxvQD7iEju7Lytv1TALAKmhW+3daZnZjLvcisxA wJFaHCwnGgd5Pn2co3YfSWn81Q06NcyXbk2T6r0NJx6tXgj2dWrDoNQdRxTQzjJUuxtJ yANw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788856113; x=1789460913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UTCiQoU464htRcfb9JVhf0FdQsMAlBERFwecvyCAnaI=; b=PNY447cmeHq8b25n9ogqht7fiNt6PShbYDhXiu4IkHQrkAXPUSqRS52X/vDcC8pdVE ygMtMnAgsT8EDXo5Uknns3Bf0BdlTJLYv0MG9bdAesPDhh/b31CdDnLZA/b7+g2v9uTV Yx4BfDDY6ebGPCGm2DXpbEF4kMbsOIig6bvUDICwT7uWg7PzMAX/TRf2inQTO9vTQ6uq DFzOfKyakB9olKuyAA6O8eZpU+NkbOvUBmjnhHRU3Isk7q5i1sxxNk1QXP5vuYQjCzdM CnOy6OkGObxUIfMzG660aHtv3Xn8FY0IDT+ZlZ2Ht1u7dwQbyaMqADZq82L8R/r7hSIf aq/A== X-Forwarded-Encrypted: i=1; AKwUvBxZ15P1d0sIGHfy+CGAKUrzK4ETywtcBEouGkBSb5yy2zZQ5tP5BS6G2vQ55DOIoaEpwAiLvSdMtg3086A=@vger.kernel.org X-Gm-Message-State: AFuF++kznuueQvVovAGnazNzVwEk2c9I+PYWjgULxtQSHGBYpKe2FaXy Dyc+SrApslGRIjQqPDBWvZl+cCvxbrpCbpjN8hehnWTkeL7sJcv0LM2sJjCLc11M+tod8CmoMTm vkOJZhHUsIqHz51EZXQrFpNsLNia7N0nnPUUiJA/gs1LzfR76rBKDhq6kaGPEe5CXz3M= X-Gm-Gg: AYBFou1YdYiKZbo7lycqIr4BUjx7AegkgqHcPxSA10JJSOZg7hWb4v36zy3YrMm1xkV v4dCVy9jfGiYW6Vdw4AqHHcle+i+LgzLp/VdND8VJ+ScpuIqPakx+6jRU6hrtvxxVGwWLRDXdr0 sSZXVbHEp6P9wD5qdm8ECJRLD7MiBlYJVe7DkulBma3Gt6E+G/98lYQkF1YRcxvDBbuGFzn+W5r pEpUblQl5XIxrn9ys/TmTCenq+2DSAwvvfoMASSMuytE3hMvkZ7MQ+cDV74XOBm+2XffE2V/LbM fDfAtKOicFMuPZ21ITppl8K5Bqxar8hYV1fZbP4pPWurXSB0EoUqqYERXbCBN/esMTKCa0fHJXp DcNNw1FDhIP8kEw== X-Received: by 2002:a05:622a:153:b0:527:7813:a439 with SMTP id d75a77b69052e-53054982b53mr329351601cf.27.1788856113585; Tue, 08 Sep 2026 01:28:33 -0700 (PDT) X-Received: by 2002:a05:622a:153:b0:527:7813:a439 with SMTP id d75a77b69052e-53054982b53mr329351381cf.27.1788856113183; Tue, 08 Sep 2026 01:28:33 -0700 (PDT) Received: from debian ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf7736132sm369414605e9.12.2026.09.08.01.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 01:28:32 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: srini@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 2/6] ASoC: codecs: lpass-{rx,wsa}-macro: sort reg_defaults before regmap init Date: Tue, 8 Sep 2026 09:28:02 +0100 Message-ID: <20260908082806.648797-3-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX6tLkVyl1pv+R k2gj94LWUJu7MIboDzY3Vsa2zEebRSzWx7snv2cEnuIbpq0hOR0TTAd+/2I4zjqneVLRmhKLaVM kMxWn/OmPfTTddPW6SQK1oAZOPGcGk9PrL5pnLTetJ0DcGRCUnaa8Yylw78LxQoSgzSR3VU0ZHX RgSjKuHA4QnkiJnXqJbx93LZtVox9Z/8OIaEgMpNsGtg9ib6APcWgg/YA2v61tV3PjrQZ6uHQiG CCJ/mWVdQBx1hTdf9TTRGxjCXgoN81gMOuAqnQjmrz9XrfypHYvJGQ5W9E5RiPx/neEJct8cIY5 oHBK0uupLx0q9Yg3a248kRUTQ3Bf8csIpR0U5H5AWxfyh6SWyKUtPQfEtGTNVOEPSmZaqy4efVd q4yauvWbW+bgjOCI9n0Ly4KQtyxZ+VgPSxDv48vucrsZDPDfU4rUJPdmPYdPK+dk0oxLZcVoMx0 resIQylcf+9HIqB/c8Q== X-Authority-Analysis: v=2.4 cv=Xbe5Co55 c=1 sm=1 tr=0 ts=6a9fc737 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=EQvkBjYcCjhqL2gfLRsA:9 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: MUwvc3-1faUrd1gxGcRqy_bPwzAP7NUo X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfXyhG/gDJ+WLwO xEQ237xeoCSu4d1gjeD5yYaUm/aRaDyuIWZJp/g/bPlgOph5Aj3spJzTC7/guGAOcnkqsijQmkQ F9lOI7DAEE3m1yU+3Cf99C4BU2/HAS0= X-Proofpoint-GUID: MUwvc3-1faUrd1gxGcRqy_bPwzAP7NUo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 suspectscore=0 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080088 Content-Type: text/plain; charset="utf-8" Both drivers build the reg_defaults array by concatenating a base table with a codec-version-specific one; the resulting array is not in register-address order because the version-specific ranges overlap the base range. Regmap detects this and prints wsa_macro 6c90000.codec: Driver needs fixing: Unsorted reg_defaults, sorting the copy rx_macro 6a70000.codec: Driver needs fixing: Unsorted reg_defaults, sorting the copy then sorts its own copy at runtime. Call regcache_sort_defaults() on the concatenated array before handing it to regmap so the warning goes away and regmap does not have to sort a second time. Keeping the base/version-specific split is deliberate for readability, so a static reorder is not appropriate here. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-rx-macro.c | 2 ++ sound/soc/codecs/lpass-wsa-macro.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-= macro.c index cac0451f8139..4dac376927bb 100644 --- a/sound/soc/codecs/lpass-rx-macro.c +++ b/sound/soc/codecs/lpass-rx-macro.c @@ -3855,6 +3855,8 @@ static int rx_macro_probe(struct platform_device *pde= v) return -EINVAL; } =20 + regcache_sort_defaults(reg_defaults, def_count); + struct regmap_config *reg_config __free(kfree) =3D kmemdup(&rx_regmap_con= fig, sizeof(*reg_config), GFP_KERNEL); diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-ws= a-macro.c index 7a2b0cf9398a..4d7e7e30f460 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -2763,6 +2763,8 @@ static int wsa_macro_probe(struct platform_device *pd= ev) return -EINVAL; } =20 + regcache_sort_defaults(reg_defaults, def_count); + struct regmap_config *reg_config __free(kfree) =3D kmemdup(&wsa_regmap_co= nfig, sizeof(*reg_config), GFP_KERNEL); --=20 2.53.0 From nobody Fri Sep 25 21:41:03 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0350442A149 for ; Tue, 8 Sep 2026 08:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856119; cv=none; b=Xh1Yv1qNfBX2Y5VeLIN6totbcCv4JPY4FaNbVe/Peo0Q6yfjgE1rcfjLjsZLDfAEIljXuh7HBd4cDaUHm5XXXvuJowPEwfIor0gJMojn8TJgPKfoaBQAi2N4II0BY3C0J+IHx2DAeaQjeyYPZPVWyhT94GGhPBpk4EEhgiFiuVs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856119; c=relaxed/simple; bh=5yK5VjioLO4s2+u2Ao+PUYV1VoXMngX3XYw8sOkTCrY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ldVl9j1pxeAmiIaj+GyGTHZBiKHcrClHofS/C3aghgVT7dDqVfiIykVMvkeQER7LTmT64tLXzMpP8BSoCKe7XHx28eDLn9UlDlpLz8b/CdhqXEFBqIMrENpYh73wN2BQ3Ut8EzH662hechCTC3IUBdvW9bgxiz6tidMKJN+vMTg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i2POOVhh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G39Xp6X1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i2POOVhh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G39Xp6X1" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886LrbF2154211 for ; Tue, 8 Sep 2026 08:28:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=sXjpkE7BmFu zBqyfX3D2KUtSjVLl7POjhlaiCf0eRHc=; b=i2POOVhh8JifsAe5NPp6xZkg4Al VQY/oYKGSyKOfGw/u8RdVvGbOYDMfg/ECodVTvhUQWkwNTfYxaTvHfFVP/d9WjdS TU4lyQcOo3F9+GotqtkLhg+4rf7OeTrVJsNNHQnZ8oXj7rQ3VF3gMtT2So0XOF0Y kVM8qQbRo4SbMVe2do0sQCnzNs2BvUrPdfsdCPEkZSQLgtrGW/s+42LiDIzVNdp7 eFmRlr9tkiV+40GYYxej7ueEiirWMGUYLnfzCfPimphtah93WFNwCHD79s/5qh2R A4qYFjZvGg7Vgi6ENYL7w5cTyfd7y2b67zvK12UX59Xes8N19OCK1cgzEeg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gj1rwjfr0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 08:28:35 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e82060977so696631085a.1 for ; Tue, 08 Sep 2026 01:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788856115; x=1789460915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sXjpkE7BmFuzBqyfX3D2KUtSjVLl7POjhlaiCf0eRHc=; b=G39Xp6X12uRpMG9uavIh0izM1mmQMjDRbQP5jvuoVHkR4XddS7iB0d+o7pQqE9OjOU uyp0IpiSCKBZFvbWvVPPqP4FchCR9OlW43sz20JdPq+StO/tUyTTAM+dYkC8XvqPBHqo KIrgMKilLUTfj+DhBWomvwjn9ioBmp75HtsvIWuLHe7bzfxp/FPagByEMHdzVuEf4DR7 k+hAc6pXgAhWZqeco6fcbqHLdOp5nkyj7GnxN3f1tC3zPn8Fn6zmRuSnwG+XOjn83mnz nh/9bFtA0lzE4z7XXq+cxltYkumyCf0jQzAb+mmSMyexv1rluXgLJFbR4PrSQzzLwn+y 8u1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788856115; x=1789460915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=sXjpkE7BmFuzBqyfX3D2KUtSjVLl7POjhlaiCf0eRHc=; b=pUL1sOCFX81/uuvK0XdNnwWXiOAQrEBQzRlWs7sHgCX/ZYalkJhAOSvoHIaC+aVC1J TdXimT0USvscduImqkKYbtFBMSII3tCmZq/SZRm/klgW/9/SqLrkPJQEEFQfSQ3dW8HX 4pS2jP2536jcAQOQWl14olAX5G01ozd3WYi1gVaFACgdMnqMOSYspvwW65hEtP4uE7vy ClweuBD35nvxQ2MwaLWMaMwGS0/WIb02qsuZaBBtoyrVj7imRvAeWG4dlzvRNF1IYT98 7jd4sJPomoHqKJLsq+N9QqZqXJnMaa/Q5REAzEmldQSN6Oc9iGDsl7a+xZRws3SmLyC5 GiRw== X-Forwarded-Encrypted: i=1; AKwUvBzt2ByuY9bMJwIpJrsGLcOYoGjdD9QELzBqjgkF4sA+zNmFD9sPbu+wshLx7GUMjPmoPcCPX9GQQnHDmk0=@vger.kernel.org X-Gm-Message-State: AFuF++kqQG8LsOASvJ0JmKa70JmkfvKQU8cfQwcN4y9OD0P82zzFOxOp Srhr2/aIlelZwO6T4tplPGB1vd/Q6grY129K3kO5fC+E8pO8oeUpqJCic7/UwCthIHAYLou3593 bL+GZsTYDOjvJ6G6pS/BS7fTj2Pw5WsaCTTjBmX2MqN8JOxBYGmgNI95F00Z9aVnAtxE= X-Gm-Gg: AYBFou26ys5kMwcjD0engMqJ31JWS/WD3lL0imfSMGVetWcm5/nFpl8o4hEZ/c1p1ek g8qaxEAF/UW0Mlf0Zv8hmfCDirkHyA81i0ueuy1jqnEdwN5chfHQDGxcFXoJg1hyBB/ZNEI7+QU iZFBsi5yjK50BiKyrzcqGtgDTbXfJdbsMOf5fw6UbtSoq1p/B+e5ZrACKaLMyLmr+troHrjGHg/ 8WWP9iwqcn1DEoD482IoEHN+rZwCCc29xO5CYLtCiRmQMrNw6p5MGJaiL1/cVeElkt93+KcUkAk IqRmoudwGJpvUM7Ch83kRkVOdwhRktPTuttAYpq/EozquzCWBPIQsKZYXmASKkAprlhR/QBz4YX oGJfvqtBXbIqMPQ== X-Received: by 2002:a05:620a:4857:b0:939:5d22:d1f0 with SMTP id af79cd13be357-9396dead4a3mr2191183985a.2.1788856114745; Tue, 08 Sep 2026 01:28:34 -0700 (PDT) X-Received: by 2002:a05:620a:4857:b0:939:5d22:d1f0 with SMTP id af79cd13be357-9396dead4a3mr2191182185a.2.1788856114348; Tue, 08 Sep 2026 01:28:34 -0700 (PDT) Received: from debian ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf7736132sm369414605e9.12.2026.09.08.01.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 01:28:33 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: srini@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 3/6] ASoC: codecs: lpass-wsa-macro: switch cache to REGCACHE_MAPLE Date: Tue, 8 Sep 2026 09:28:03 +0100 Message-ID: <20260908082806.648797-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Ga8nWwXL c=1 sm=1 tr=0 ts=6a9fc733 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=_mTl3-Sb4fPHxIs9D7QA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX9C//mwjOy471 hD6KvVtvhcnguISD1T0E8cPy+O7g8ox7/8ku/CE9dTReUPo8RPTfaS0UJKmBZ3t6TiUEpIAzEJI pAk8OAlOa6QwyIaIkNIBq2KVEGaBSPxEIqsosn+mtqwFY3D0MS/WSQu3+xJ0j8KBHdzJd9izsj8 21Ym+BO5dhpDi6zZQQ8PsLxeRpvkURjMhupTKjpJgi/lqG9SC5Ef8mnqCdgLxl+wMRUNqWUszHX Od0MceQVVnQLHWxz8r4urehfqXaS7y1gMLM16WvwGc1Afq26Yr9aAV1SONbKYr6+ajJ6S9DT9vH A5sCTG3xs+D39W5MTUsXFx/9TOVb5fVE7g27NRZFNNBlSQ0fhTfdzzy9WcnJXgEjqoukoS5j0vC ltOTfUKq4BjW97CtHCg5xAymBk8z8QAmEQEwLHGReLG2n+kqz/NMVHEy7Cp85WTiVi2W9IhNRGJ hzxR5l1p+U9psvSGrPw== X-Proofpoint-ORIG-GUID: 0qITSihpKJ0rOMZiq93zCK055uzvSkn6 X-Proofpoint-GUID: 0qITSihpKJ0rOMZiq93zCK055uzvSkn6 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX/a9rmyijG4x+ 8vrqCia1e7Z0iz6SDkGXbjAkqNBob1sj+47vqCocnGi6FnfeOecI38gpN3tGYuZSjjfJOFN+ih6 fvUZF5tnPJc7wBA7awFEfCf4qwKIPjw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080088 Content-Type: text/plain; charset="utf-8" REGCACHE_FLAT hides missing-default reads by returning the zero- initialised cache slot instead of doing a bus read. The caller can't tell that value apart from a real hardware value, so any un-defaulted, readable, non-volatile register that gets read silently returns wrong data. Since commit e062bdfdd6ad ("regmap: warn users about uninitialized flat cache") regmap dev_warn_once()s the first such miss, but any subsequent miss stays silent. Switch to REGCACHE_MAPLE. A cache miss returns -ENOENT and the regmap core falls back to a real bus read, so the caller always gets the true hardware value. Write-cache behaviour is unchanged. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-wsa-macro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-ws= a-macro.c index 4d7e7e30f460..d254518634cf 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -1109,7 +1109,7 @@ static const struct regmap_config wsa_regmap_config = =3D { .reg_bits =3D 16, .val_bits =3D 32, /* 8 but with 32 bit read/write */ .reg_stride =3D 4, - .cache_type =3D REGCACHE_FLAT, + .cache_type =3D REGCACHE_MAPLE, /* .reg_defaults and .num_reg_defaults set in probe() */ .max_register =3D WSA_MAX_OFFSET, .writeable_reg =3D wsa_is_writeable_register, --=20 2.53.0 From nobody Fri Sep 25 21:41:03 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913DC4248D7 for ; Tue, 8 Sep 2026 08:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856121; cv=none; b=Uab7vdkO9RLSRIP1AtxkIYSnSQGkOq1H4dwv7TL+Q/Ef2gCtgN23GRBIIOc8CHAfstC3sicNq3G4svRDgLhZiJIO7B6BnlISAhy+z6Pfa9H2izkm+nALDFmW8ub6Du1qVCDsjTta/U9U4N6kxqVl7ZvMAENvuRs/eBeXji4eEAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856121; c=relaxed/simple; bh=JxnapY64WEraZBfFqGiiqSghc4VaHYhDcojpYQOcQPk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gSJJI2K+50SrcqBTzDXe7lYfSyp7XtQcZDhajV/0oTNPmJV4wB+d2OUIQ88btghtemqKtu81j8JMHa9vchGPh/UUFfLTem5zut7P9sOIbLXVnmnvYbF+594vkAwSCy7s7kGIVmrPbnHOo59gzGeEoRg4TIMXF90jVk9X6i18L/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dEUDUKwG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c1lYs+9y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dEUDUKwG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c1lYs+9y" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886M5Of2363340 for ; Tue, 8 Sep 2026 08:28:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=JXNafIa8Dz7 9WQZ8cwkWKsQ6SpxY30pfaCRfbyo2NUE=; b=dEUDUKwGZWCGzXrPfWL+dZkWkI2 18rgdi0b5IfbdvOhX/qJbrjQT1f8ypmWm657Fw8qlLRXWk9zmlcDBKRC+D67ZlxK VSBqwKKptkl7S4tGX95xsel4MF7JBNNjdIYqryIy8xYSbJefWcRtVTUiXC8qNQc7 h7VIWIMCzfTBEBUOHdeDBwbsybkp0G5fZvwjKVYVQRkoyNzNcykoC0lP+06zu6zw XVmHu/h2tHADjDrePIeaY9eUFLsIJoWEKGV9ghJgL68dU4sex+1CjhRtyz4AlOJc AHNwz0JEQhdcZG/aRMDIKGqGVQhYzOfxFqKQXJqXyVVm+jh9CK+5HtoKWsg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjaguh24t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 08:28:36 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92ec3146553so1040096385a.1 for ; Tue, 08 Sep 2026 01:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788856116; x=1789460916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JXNafIa8Dz79WQZ8cwkWKsQ6SpxY30pfaCRfbyo2NUE=; b=c1lYs+9yO1KxOXlt5qg/zcwq5toNOUj52r3QC/9zW0ToTWbQnYpNsfiOnp+GrSlX+v gTxbwA3niCScku135UHGYenqWZ1BWIzD6PhDrRojBkwfa//5PIiAshFDXy6ZoKBaf9Y6 ViqVcIuJgpfHcRNvDuJqiMwALGp6xcAnlHtqQEYqMcNgbfnTzUMfA6B1ZrmG5k/JUdL/ dN+Tit9iNvzSjo0AMFBTXkVCffC+F9x0YT9ZPGRx1FCCuKe03QA61+rgxDbZqAddMF/X 2xiynQ51dtsXUUvg7IpYmibtUxp748wGKGOwTEqfE4604kV9ONc3EE7ZNew4hl00WPqy aVjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788856116; x=1789460916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JXNafIa8Dz79WQZ8cwkWKsQ6SpxY30pfaCRfbyo2NUE=; b=r/7eTevLS/E8v0Q1IXzqUt+jumv7EpUS/j4HlFoThyuCZB/vUgHbfexH9HAovO8ULQ AvvNkT79LvsiGmR2w3KxUGuhhX4e/EQSoIJdjKaeKjRNHFWbhw5zXukZVdI7oM8Rr7K8 JQ9HFSdUct1/5519GMH8KkyiCHKj+b2AKBiX7EX60RSL/LYDjbuMRNdse6QFZTfFCLT8 lkoHvWXWBE4cuSZTYzqgCF0pBaSBnwdgmoTMvOhwESlQ58CydlXS1RPtQ8NbjFc3hbHx gbfvSFqwBqg58oX+K9gyJec+AM+6Cru7w+gNq+3T/JEYufZ7IMPFPOcl4jKn6+Noe6CT wMlA== X-Forwarded-Encrypted: i=1; AKwUvBzSE3Bmb2+Xiw0Pl16ezc6S9+g2yc2k37u2NZJUdh8yLJMHaPtztDb3UlGlpe7/YVMK/f/eXNYmF0KMCyA=@vger.kernel.org X-Gm-Message-State: AFuF++nDzoy7VhOe4LyRzMSMKcBrctITjDZy7sJ4/nhoNVH9k0F3W01i dHwJIDjufkgArGYEYGxPhb8Ji3LZFSBcgk14fb4K/GDISK7mP+T4DrvBooQNPznSanrvpgjlXKj eb3ZdBcw2+GAF+DSjpJTY8I30D4cl/t8GKbcDdceyyhitiAzDRIKBBxs+VC9MGQi5qD8= X-Gm-Gg: AYBFou0jfvtKRl0yovYm1+FrwgSyfJYeuuFdPbSOrE7NqZ6uzTysbOaVVHctavSM9fq ePoOdALRDvXHtL7ngj+UO478nHT50fLLEig1j0SE11g+70qrQDG+Unyr8rKC/zrtMkJPIkubAlm n2V6gyUA9ZvtAgvrZf2MhUd2C4MIq7glKJ828Ix8AbAKflD1KWAbfkW/DSO8COJ3ERUzwyAzqII eDxhJdXKoYrubaiWc6uGdMB+vZSP3bAf7GHshq6KwfwbPautXsEzr4EAX8GqAdnN0qz4DAnFKGh poNbz4e5nhFfgXxeQ163zkTg4boCBWRTUJQSeIqmJPO1sIPQU0Ebc6bhrYdfg8rVrhjYuAc7NwR inzOzsMiSAj2/2g== X-Received: by 2002:a05:620a:a2d2:10b0:939:8bfc:471a with SMTP id af79cd13be357-9398bfc4f1amr1804849385a.49.1788856115959; Tue, 08 Sep 2026 01:28:35 -0700 (PDT) X-Received: by 2002:a05:620a:a2d2:10b0:939:8bfc:471a with SMTP id af79cd13be357-9398bfc4f1amr1804847385a.49.1788856115562; Tue, 08 Sep 2026 01:28:35 -0700 (PDT) Received: from debian ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf7736132sm369414605e9.12.2026.09.08.01.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 01:28:34 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: srini@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 4/6] ASoC: codecs: lpass-rx-macro: switch cache to REGCACHE_MAPLE Date: Tue, 8 Sep 2026 09:28:04 +0100 Message-ID: <20260908082806.648797-5-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=TqLWQjXh c=1 sm=1 tr=0 ts=6a9fc734 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=_mTl3-Sb4fPHxIs9D7QA:9 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: EgcbY7VoEH6FW1T6LMjDJgNmL0NhkyiW X-Proofpoint-ORIG-GUID: EgcbY7VoEH6FW1T6LMjDJgNmL0NhkyiW X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX6BM7GqB/je1j L+9C0DGOJCNnzJMBc+dFvRTL5hZMJnev5q86uDa8g3+tD7NB1nBn+X9lool7vRN286hNPC9g8h7 b6Qcq3Pxs+EAtEewtA8HGEQsuM0T//Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX5dvNsGQzEWrf GFxOfzDaV+Lua7RCo5wvpSumGRh9DGBCaqn2Y3nI7vKb1bAuYFJRUmrMoMxmQBCMntbGaMaeakn dTKF1pcz4sC8mSeLazeFw8d3PaERr1XpNw/0i8i1bIainacSRjq/elavbR6sy6WyyWIyZfzp57c f22PMnmkgZMr5DTWGmCEtXYyCvy7QDHXBB2TCuuQfqC+Nn6dJo3el0/Ij00A4kPDIzDQA5C20AM d/5nBOmVemNjrLuQiNFrVkPevKsipYbR5ptDRPmGUQ/er6A/h3s6UoMQeAqzGyWYIDG16tvlphR q4fYfJtr97/YbiTtDfDXLpBdKvEdCa3AwZIY/PDnhlnKweW+4L06ZfHRQsWDiNR1lDeXguzSEKd mCA0Ib5vdiakzyuMPsbb610YLvs95BDXzlm9V8N726/QbrV3P9Bn8VrHP4ZC1I2P5zosv8Vcacr p8doqPuNYtgHL4bSzVw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080088 Content-Type: text/plain; charset="utf-8" REGCACHE_FLAT hides missing-default reads by returning the zero- initialised cache slot instead of doing a bus read. The caller can't tell that value apart from a real hardware value, so any un-defaulted, readable, non-volatile register that gets read silently returns wrong data. Since commit e062bdfdd6ad ("regmap: warn users about uninitialized flat cache") regmap dev_warn_once()s the first such miss, but any subsequent miss stays silent. Switch to REGCACHE_MAPLE. A cache miss returns -ENOENT and the regmap core falls back to a real bus read, so the caller always gets the true hardware value. Write-cache behaviour is unchanged. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-rx-macro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-= macro.c index 4dac376927bb..fefd4430172a 100644 --- a/sound/soc/codecs/lpass-rx-macro.c +++ b/sound/soc/codecs/lpass-rx-macro.c @@ -1674,7 +1674,7 @@ static const struct regmap_config rx_regmap_config = =3D { .reg_bits =3D 16, .val_bits =3D 32, /* 8 but with 32 bit read/write */ .reg_stride =3D 4, - .cache_type =3D REGCACHE_FLAT, + .cache_type =3D REGCACHE_MAPLE, .max_register =3D RX_MAX_OFFSET, .writeable_reg =3D rx_is_writeable_register, .volatile_reg =3D rx_is_volatile_register, --=20 2.53.0 From nobody Fri Sep 25 21:41:03 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9BF242DFE6 for ; Tue, 8 Sep 2026 08:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856121; cv=none; b=dtcE1m7FvR8eRl45ZRntkYwNekkJDMBeaVvycyIp53tBWCeU7hl2xmDrZ+Xx/h33Jxdsz4TL1Quwyuaxqsmigc5C6W2KswkZzc0ZAvzArA3P9DKMCFlqD1iz9uF0gqmc6imhsy71Knq+DWXiXWzjW2JRWW/4cVc4CQCW3lJfNQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856121; c=relaxed/simple; bh=z9P+ywUBSNkvNLZ0UrmxpKOG870Ab70CHNlvp5eJxSg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WwcKFJHOJQTJ1Fl80jseQT/B63VGbNTIr5HFi20z0LcLMEZRhfTKOU9019uG9UPNmp/Be+/pdp7Lho79YQp+kPNTKWAVgpnZ7QV+5FZV0ER13VbEBVuxkSVooOjReM1SFYVcpzCRckEMEhfB24004gXuCJx/bJ042WlOXAqmHwc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PUyu1woa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Da5b91dz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PUyu1woa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Da5b91dz" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886LlJC1477673 for ; Tue, 8 Sep 2026 08:28:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=sO8eEMJF16c 3bC85Z00Il17KWtgP48sEVSRstL21fnM=; b=PUyu1woaiCQvYq9ktdRE28uIXgJ uYCqmccQVV7jCFZbSOimX84cXYBuyYm58R19XNjBxewLnc3bq3BMzARoQ7cjP2PN 9roacdsHFbrIB8Veln0lILQTT1p7BGbUAqWLHK8sukAqV2evS/mE4aPeeP2JV7N3 2h9ejHBJC9xFe7huJnd7298e+IyCssKU+7iR65PmjcN0rnIrN47mH3/0QN1JAq+Q L8jQxJp/O+aqi1QvogOMQre6KVZMUVd9+UCwPtp0EKP3+ZHQmqaUOsVpP4q4sDzV 0MeVCFSs/PEotlyKvCQ5U13godf9wtRye4+nqHeMfr2XfbIn+zL9IHOPTYg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjatjh0d7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 08:28:37 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-939665a1ae6so434970885a.0 for ; Tue, 08 Sep 2026 01:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788856117; x=1789460917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sO8eEMJF16c3bC85Z00Il17KWtgP48sEVSRstL21fnM=; b=Da5b91dzUs7lzn7xvORPBcAKohR7qzipE4VZSkabCZH18aaZbFaDTJVjav47FlWHaL 7YZkaSS+g/ezSX7d5L1OlUQYwu/lFTMJc+ueIshSU7IWBoSWD1M4erIhJytQQ0xBCgQ7 72E3gRQGrNwVzn9C2kZqUbqq1sWQBW5wJbp1jBU84eaOL2VH0cIRVH+CvD7i8uOHSWD8 jYQXwcvXRMj3oUrG8IP2Ozok9OE7la0HEkPBZWyAaNdksS8pji261qrAXROE4hgeA+Tn voBaUwVFu5jnnUvqEKNmKFRJ4tosQJcU+WtSdkxaJpnyqF0DzOn0erxVGkT6NIM/8YQD w97g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788856117; x=1789460917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=sO8eEMJF16c3bC85Z00Il17KWtgP48sEVSRstL21fnM=; b=linRlCGDGVjksN1wye6w2QK2Vv2CCLalAYYLz+QYaIJJfV6Sa4ZNZCt8UsKW49pVXj VpXSjPdaJahXe1+WrRu2jaI+R20TyOImbts/HyBMkEnptJuB+OgcotnqsZuLdbjRwfLe vc+9qVyIG+6MYClBBTMFVUh7/9t3U2IXMsA28bDHBK6Toh1p+2WJmDQjYvYOmM544Ake +oyAM152vAD2hA4YkoxcUt7H0kNPdEsrnvFQ8Cok8+PYSlFb3psEMe+j2rh5zkIjgNsj PvdVyNDkKvK8LGABHO2p+6gcXAawxNLHP/NGyAyTgDlaZxC6pFBgB5fGNAFACLZ0c/Ja a3NA== X-Forwarded-Encrypted: i=1; AKwUvBxBG+2Bw1xwrXQHeAI93r0WMzq92+xTF/nkgXrUHM1FhS9qVdRvSdGsY9dRlsXyBMuLzI4iW5R0+A4BZWY=@vger.kernel.org X-Gm-Message-State: AFuF++nvARooSeAi+AH3TWm8hkCNaD0uHJJIBLe1M76vILpSebdALk2T 5oQx1U/tPYUYRQcOloCiUOF9h72n3dDrbgAOXhvj6873aIPEC4+iPD/4NPJorSblaJICd8RllgF 6wqJqqSZG3qVlzo+XV3cKsbfBMUGQggTxdsNxFJTZGCeBsB3tosF1IkztzKV1fEueF6o= X-Gm-Gg: AYBFou39FhkDr0onzD9HJsOjfbzp3g/CMu15LwS2IOaTACcZ3myEoV48+uu/SN4WdWT o36IEkWcHSnsL5sC1+JBJhZeY4fK5r5WjqV8Xt1FuxkJyvtk7rgP7I0elb3r6sf35/PyvqGYT+A IjT2EvcyDBqcjbcfDVDrFh37xcHvKgGIk45YvSmTiDfvBCopVeWXzC5QdTHpdUvnG/JX7VthRpV QBzfdY94nhQcTAWK0DGTvDknJDa398tJK44NT4kl4EqeyFMBN+Et3OH/GPcZDxA7a1IEYaJG8/o ka3vUZWBmhobgUqeLJVk+U+TbPlniaJhdXMBuql4yU9M/ls3+vXhG2bx3uh1pGnDFDfYVho1U+9 TB6y4RKlmHm/gTw== X-Received: by 2002:a05:620a:a38d:b0:939:6132:62cc with SMTP id af79cd13be357-93980426af4mr2295508985a.27.1788856117166; Tue, 08 Sep 2026 01:28:37 -0700 (PDT) X-Received: by 2002:a05:620a:a38d:b0:939:6132:62cc with SMTP id af79cd13be357-93980426af4mr2295507385a.27.1788856116729; Tue, 08 Sep 2026 01:28:36 -0700 (PDT) Received: from debian ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf7736132sm369414605e9.12.2026.09.08.01.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 01:28:36 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: srini@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 5/6] ASoC: codecs: lpass-tx-macro: switch cache to REGCACHE_MAPLE Date: Tue, 8 Sep 2026 09:28:05 +0100 Message-ID: <20260908082806.648797-6-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX7N9nlpznbuEP SUULUdYkxacLkbg+vkEklrS1v22cAP0W22kqrqpkI5Y6IJYW03xQmFLddSLs8GHKyE02WYKenzN OoYf4rYZ4FV4Q7QUNSTjN6i3QjacgmI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX0Jrh8okkczrV pXgUM+ECIuNGB9v1sLY0jVE0xQq08xcOZpL89HWS2sRLDbrOn2fLM8JBJJ04NXz3O8vev+jHC1S yfsa/UMSG+x33eBXdDbAnzIahBc0Ag8JPpvlbN0LRB+GNB/JfsYlTJHIM73rCjkAFx6wFignxzv CSiH+wa+8+Qr12DnPymwfkN2PYn4X84dmJkq42CzEGdaiXigr20TMAQWJOvBJ/lQmFooZScqZVd KSr/fJc6rrVtjDHS2cOOGqAgYZ6/dXzGfjg2yd1guG+AsGZz8BuC+qOHWuafYM3pJDI8a3DdgHv 1PenYeOvAgYw6MQNuahMYas3BjzsXsZjrNuabP0LzuFaix0p4/ul+CiiZM3zC8XsjugK38LT6Hq FIH6EYk8dS/ks0YXQsziaRuNqTsEdIBVGVqV2sm9/ANArvvzpFY64JygCjXvKPTI2MhmHQUk2T3 47h/a2jmNWyVBx2vLmA== X-Proofpoint-ORIG-GUID: SVVzQANMMRPcz8XoAWcH8x2lWQzOhKen X-Authority-Analysis: v=2.4 cv=QrduG1yd c=1 sm=1 tr=0 ts=6a9fc736 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=JkBDmzDGGkIbPcWOdIMA:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: SVVzQANMMRPcz8XoAWcH8x2lWQzOhKen X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080088 Content-Type: text/plain; charset="utf-8" REGCACHE_FLAT hides missing-default reads by returning the zero- initialised cache slot instead of doing a bus read. The caller can't tell that value apart from a real hardware value, so any un-defaulted, readable, non-volatile register that gets read silently returns wrong data. Since commit e062bdfdd6ad ("regmap: warn users about uninitialized flat cache") regmap dev_warn_once()s the first such miss, but any subsequent miss stays silent. Switch to REGCACHE_MAPLE. A cache miss returns -ENOENT and the regmap core falls back to a real bus read, so the caller always gets the true hardware value. Write-cache behaviour is unchanged. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-tx-macro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lpass-tx-macro.c b/sound/soc/codecs/lpass-tx-= macro.c index b73a19eb9981..b1cd5e34624a 100644 --- a/sound/soc/codecs/lpass-tx-macro.c +++ b/sound/soc/codecs/lpass-tx-macro.c @@ -602,7 +602,7 @@ static const struct regmap_config tx_regmap_config =3D { .reg_bits =3D 16, .val_bits =3D 32, .reg_stride =3D 4, - .cache_type =3D REGCACHE_FLAT, + .cache_type =3D REGCACHE_MAPLE, .max_register =3D TX_MAX_OFFSET, .reg_defaults =3D tx_defaults, .num_reg_defaults =3D ARRAY_SIZE(tx_defaults), --=20 2.53.0 From nobody Fri Sep 25 21:41:03 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC36743551D for ; Tue, 8 Sep 2026 08:28:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856123; cv=none; b=pdMIhWz1ljxSRBoGiIeGxKDGkrZo3We2sR4NEgBeSDDjWKUbNm9Xg+A1bZ6wJSSIpZvaURqYTbzzbrGp0DaJ5NjB4rudzbw19rn1P9sGhJpCirFba0JGqRBVyI2oiZimHBTlasOy9uYLIdQrOhCrQvuNN44rRzyaa8TdXbfJmGI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788856123; c=relaxed/simple; bh=UV6jW6PMil7wWOmF4aoKmw9vf001ePaKteC/8MM4q9Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g4lf49PaTLeG+mr46IIztOAF+dVgsGgrRdQUlp8cRwy26IzCS2aMBGWGwbs+r1fIV5r944UmRzwzlU+QdTA2GY4zpOANfewKs+sqcXBFefn7wzexL8gDPYVNKCDNioogncp50tVGqYeri9JZbrSOd1HZOKlMZP0UzlbMaq5RUEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KYhXzThO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V5Bd86CJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KYhXzThO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V5Bd86CJ" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886LqFL2502437 for ; Tue, 8 Sep 2026 08:28:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=7hxdjuB2VuJ ASIx/RNJeFcGgL7NijdNk1gCzSGxAfo4=; b=KYhXzThOSxck3UYlN9f+e1kCMbQ VFMseCENxvIDaByXZfg7lE1h13bkZhQ26t3hK1avdwB4oZLSkjpYDZ3GVU8mcLjY +VtXXAltAHICROviLOFGYpODaVSNKcDVSjIz5AlfBi4h8Vo09Bgd6gL+qs6C+Dmi Nmm+Meh4XAN0GNnV/OgmFoMuRFuq00oaliyPuAMvZdUrnYTj02wcNOZRK3lCzzf6 AL/6cKGOTqk29BlX3Ej2AfBZWkjS7XBp8tXUNtNHF6XsroLSPqfPZuxvGvSV/GHV s+TOBpWyAKvPNUno/IeNdnkpwa9fXbcU/VYLlzCXffA3iLJsLEm5EVWvhqQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjcv7gjfj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 08:28:39 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e5fc4c7e9so413982385a.3 for ; Tue, 08 Sep 2026 01:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788856119; x=1789460919; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7hxdjuB2VuJASIx/RNJeFcGgL7NijdNk1gCzSGxAfo4=; b=V5Bd86CJD/ELymYVWsPVPUEFZcCxNZh5zdZz9SV2hECvnIxJOPo+q+dyXk8sg05fDu QzAd2e00cfsAFtUwtLdF52EyB2nRXbppmckdvTAcpica8qPjNQkz5qdk6OKRG1nlVRhB DO1tDcmF4ZvNS0uS9uj/tuWfBcxa8Vy+G6PhaN3H/CKDAIsZfSNi3vvYK9+ijDRXwj2K cxVUG8Nn3IWYCXhkGbcDwoo72o08z28jFRqHBJxHfk7MHDcM3NVSJHWRl3kiusSmZARz psFWE5lr17VDlkVNLBFR6pDCX7pwLbHkxeeGU8fBoOYdJqgMXHWY/V/biwruUB8uRn8z Z60Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788856119; x=1789460919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7hxdjuB2VuJASIx/RNJeFcGgL7NijdNk1gCzSGxAfo4=; b=Ro88SLs9yD9OuZkcM8vqmHa1+ImHcpb6ZNzSv0aZjZAw8TZqVlhAMaBE+5JbN3NxsO KndeHAqTQ7Vcojbt98rF2sv+ifIiLA8Zauu/bDvUeVpCtSxu7iyXE0yZLbjv0EZuZp5Z rOtOq8pjA/gOinANOp4duvKmb7rYXXL2V/MMefIHEKtXjsGt7lqCEDhfe+KiGvYWcBWM QzShcGRBwMWImanRc3oUuQpZtZKTsVGrR6OsuRRCJ9mPdXC4TnVvLEm97K34qySKmRB4 9pYCgHV82qllOS0ypfIhDoExGDXyCIz3I8bO6dz0pDZPyZH+IoKyMJ6n1via/yFai/Ij RdfQ== X-Forwarded-Encrypted: i=1; AKwUvByvxDl1mr72wuem26m7hnkMTvvsvw5V/eOBrCRoLiP+ruBs1Y4twIHFGe9fE7zUF+Qvu44kHw+sIEE/vug=@vger.kernel.org X-Gm-Message-State: AFuF++kTbxqWoDg4f4c2LZLBrJMmAjR8we76zp7H4TLTsFKseelzZeHT TDX8V7zalmAjRR0+pPchCR12aOAvhIXvLWJXGkFTF1ZSuh+CS5XnF+zP7uUyDzJqidUVRUyTwwk w7mr7ByVVSD8MegqHJ4VwFGRyKdeP/DkVN94C2adHG7baRrR2rTiYI58oM7manCybjU0= X-Gm-Gg: AYBFou0lATg2N8p1qeFHGqkaHCV29dXtT7g6ntai4IszmO6Qg+oE6H5zWRw7DMx9YZt 9hzC7AR9dqiDeETB7bH+CNsaLWeY61Xg+onZDXJdIvDgRSFL42NCgf38spY2DxPZOYe0w3kYL/y +PM7CFmgb8pBbwUB9SfM4CGwkG9RI7WAW85mnJcoLmqvj4wBrosZBMryGumuP22QYv+3Dd724gg YiiqPhhgKtzrAXCoUufiVfZMXmaFJVbAqyFUoHkPHwhjX5rqsQiYJDxOKWIbppBbiBmla9yLPT8 6iEmypBRU3i4DjPFcWqVr0SxkVeJGgPsdfDsP1fJT5ML82TD3UpD/vztzxvbLRUn24PehfuqBWc 9SwnYPW8sLazFNg== X-Received: by 2002:a05:620a:4887:b0:939:6de9:208c with SMTP id af79cd13be357-93980586029mr2943832885a.49.1788856119109; Tue, 08 Sep 2026 01:28:39 -0700 (PDT) X-Received: by 2002:a05:620a:4887:b0:939:6de9:208c with SMTP id af79cd13be357-93980586029mr2943825285a.49.1788856117945; Tue, 08 Sep 2026 01:28:37 -0700 (PDT) Received: from debian ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf7736132sm369414605e9.12.2026.09.08.01.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 01:28:37 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: srini@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 6/6] ASoC: codecs: lpass-va-macro: switch cache to REGCACHE_MAPLE Date: Tue, 8 Sep 2026 09:28:06 +0100 Message-ID: <20260908082806.648797-7-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260908082806.648797-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=CMEamxrD c=1 sm=1 tr=0 ts=6a9fc737 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=_mTl3-Sb4fPHxIs9D7QA:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfXzVcfs6zrHQg/ Zd6n4D7yvXbFTpLpViTTNqdZMMG08kLxQM38TwSOTCddmJtWy1k/KKPInzjma27qYN/WlQ4uwdb rlVY8OL6BoEQGVwzJFsFOtGlfDdLjCY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA4OCBTYWx0ZWRfX3n85B6qnWQIs NqGSvsuSNTnQhcOf9gqBdNUEhKHB92TlVoIxc+INeFaYK0fAF4ITmi2KS3HwzWkJlOfjyFZv9NK dt6YHRlrWOYesF14hp87ENoq6qNPxowzIQb96op5Xts1l+bQyuTJ5/Osz+mqQpln5dmew7AA3ky jpbas5IdmxM6nfuY5snRIdSFFY3jHoyT6sI5saFfLQ+BAcCXwlmRsy6/7ZSB79JK2yS9ZX5imri ypBDMh9Rz6gFKW9e1rw6mVY55VM1ou14cHATgREAj2dM32wg90jijPohx3+DP2hJj6PRT+4MZyk ubuOTCMw9IBElKYqj3gOrnbCvHolgoXE2vCw0LycX5K/VSlGFqAwLCoOzZhSk7ADtftGbYj72rY kKx/GaQEFKd6ltDD4Dwwg+aORMZBnUSr15rVay2hFYqlqsBOTpyyPs4EIGeS5I8MkzpGZEYtOs8 fn/ZUnOlIpZbB2kwCqA== X-Proofpoint-ORIG-GUID: NInfu4q-1EJ2j6eu8SvgOeG6GU901GaT X-Proofpoint-GUID: NInfu4q-1EJ2j6eu8SvgOeG6GU901GaT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080088 Content-Type: text/plain; charset="utf-8" REGCACHE_FLAT hides missing-default reads by returning the zero- initialised cache slot instead of doing a bus read. The caller can't tell that value apart from a real hardware value, so any un-defaulted, readable, non-volatile register that gets read silently returns wrong data. Since commit e062bdfdd6ad ("regmap: warn users about uninitialized flat cache") regmap dev_warn_once()s the first such miss, but any subsequent miss stays silent. Switch to REGCACHE_MAPLE. A cache miss returns -ENOENT and the regmap core falls back to a real bus read, so the caller always gets the true hardware value. Write-cache behaviour is unchanged. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-va-macro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-= macro.c index dbc5795b9273..f0797715ab54 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -454,7 +454,7 @@ static const struct regmap_config va_regmap_config =3D { .reg_bits =3D 32, .val_bits =3D 32, .reg_stride =3D 4, - .cache_type =3D REGCACHE_FLAT, + .cache_type =3D REGCACHE_MAPLE, .reg_defaults =3D va_defaults, .num_reg_defaults =3D ARRAY_SIZE(va_defaults), .max_register =3D VA_MAX_OFFSET, --=20 2.53.0