From nobody Fri Sep 25 23:10:00 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B3513AB262 for ; Mon, 7 Sep 2026 20:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812637; cv=none; b=jfymF1+2MwmiVIZk+IXQfr6hQoX0k0K5KzWb7xR+knfoyTfNQMsDJHspTu159pazhzffcQkRIO2bMzJozUpL7pLzgVto7P8iyomOaP0ZqccwlOXQVfWq8GQ+bvOprVEjCxL7Fp40XZvWvDKTaGOsOZ1x6SfH2Adx6ye6cUtfGZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812637; c=relaxed/simple; bh=eZIUN/lYfehnQlzthxyb/UGydSLzCEUV422r4IFRfA0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r56wRwCuTFIIoHAnTFFbhuG7/qTy9NH4uxCDM6CKMuHhcYGIvfpIuLPnyQYchz4QSU1oswLy3SoharPeS3eB5DbI4505S6fN9EguyLM+WQheuZE7wRdZ64tHzUScss4Xd7/1QujpW2iI6ocnjKG+FRtVhx+CGOBT1YHRyKtVLNE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F3oZ67UX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XM0Tlw+B; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F3oZ67UX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XM0Tlw+B" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687H7max4061938 for ; Mon, 7 Sep 2026 20:23:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jbfjPo2s6iAx/iJD/jmcJcwK+bjVeCVPpo0oSlaiXmo=; b=F3oZ67UX1RHwHaY2 2ks41rJXj8oohRWvyNnEfwjfdVuApvjyXdYmoAMk9sd/oj4ncqnguZwxMA9A+dvz vXVnjuPDRyYgW1+CPE1yI2HXF3AuW2b0I4W78tij9xzE5PwyJVhGIhtmabNFnEYM JKIHJVxFm3In3WwwFb+W74rVd4F2nU43kE20GVQa+BPlxgElWN+pwzjA6SyxK/vD WxHwwW/SvxUWGhy3cy9sei1Yvl45QEu1poVZxFdiXc61obj/qyx64PS1ck+pGk8N layIBheZtLcYmS6SPSJYOm6sfkHG9USGAF9H9SiAX47oRC5lwjBKkaoksnXlJSMF 81jmzg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gj077gskc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:23:54 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cc1b8088202so3430863a12.3 for ; Mon, 07 Sep 2026 13:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812634; x=1789417434; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jbfjPo2s6iAx/iJD/jmcJcwK+bjVeCVPpo0oSlaiXmo=; b=XM0Tlw+BBVbXRwGIH/8SyWMIEYRan/Q3tXniust7swc4SdeoAXZaMCQHlxh6lDnNgw DcKe++EuNFdA2xKUq6qrK+mcEynIy7uXdqRfESRLC7F8XEpT9eVapa17fp3CEztF1OMG KnAbgKiXzL2HHfxcuhewxR0oiULV8llSrmtNdYIuD9py/Xi4DZ6HMjGwhHgWUUXh2s8U F/tEqZxw+oFIGUDffiB3KiO/z9eqjbrucbioz7I66bYMq6CMwypxcd0Gz4YGN/P1OMor y+C93FNzjvJWefMXUTxDpaAbu5Q+zbiTyIpzLJrkcyTxwT/f5Ogmle1gMTFdycI/yo/Q npZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812634; x=1789417434; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jbfjPo2s6iAx/iJD/jmcJcwK+bjVeCVPpo0oSlaiXmo=; b=g8dOemqaUbZfRvDmDzN+fL7xviUvXbzgM+lU3d0WKIYk4PeKxiy+x6JWvEggQSFaw7 O4Cpx+75yKMWrGsWfvZc1wJmEwwhWmTgcEZc+953oZpK19dh0G26sHdJpELNa9JU5XA9 e0BCu32gNkoFuoa4ETXRf26dNS1c1h1uz3P6uEcPDBxav4g/MOd+ANxqKn4Ei2s5v2Kj baaV/SKs0CWQuvuI2fBb4pDd0jPIgTsmKXcPP3EhGWX6VoNLs+F0qR2v7BxzaZBSxyyh 5ji2xai24LT06U2osFEYi+pd4Sn4E3OFZQG/EvmMAdL1z7QuuI4QvgcNg9N0cy1hGr34 djYQ== X-Forwarded-Encrypted: i=1; AKwUvBwPgZpHp5SEmA3cloP/YkS3ytPmMZL63JZBu8P8XLRP5usghQYg5fWSqw2qEgpKBEF45qL3AlT2yVWjQ3w=@vger.kernel.org X-Gm-Message-State: AFuF++kYfT9BksOUWsaQk8eZxZvImRD/CinrHWK8OXhBXDkPu8Vg2REr 9KmHK6JmKbJtzm+lWyZdjwqiyjwAZDqMqkaeLUlGPZuepG6G8Cbkp5uZftmrpUdqs0PkQX5vqg+ ZJ3wD1z5zyFOEcT4QeT+A2OKFta328GhQJaA4BMGzg1QgTg8nI1KsPN+Jc0zfKMVofO0= X-Gm-Gg: AYBFou0zbrjnS01TGFnK+hxri5j6VyVB9P0qlFAzb6und3UK9b2NRSghenMd8syE7c7 yMhhK3ExGJfmc97HLI/ESvScb/yxKv9mU5Nia3z6bD94kBk2Q7L3wbPE2Yjhb3Mg4N51Uhzzj50 xSLnxl5hdYWDtEKMj0MY98DK8xxpVs8VN/hajva1uPrae6Zgw2irYQG5JQV1qqVvJe0PZ/T6PhN M/JPE0RMcDkZ0f4tj55z/OJcDJJfhsBwC72GS+NL32dEsKMRNs6oV8XQn0O+ZdA4aYQBoYgR8DK DZRxbHhZWJobUuP0a3CxLTMkADLaJ60rNO1hF/u91l5t7pVHEu014OBYCABb+R5Hv+NdF3FuqkH wC+HMqCbytTIFV3syBDUqfUqvcpO7DQ== X-Received: by 2002:a05:6a21:3e0d:b0:3da:7154:2ebc with SMTP id adf61e73a8af0-3da71543f94mr17530377637.7.1788812633769; Mon, 07 Sep 2026 13:23:53 -0700 (PDT) X-Received: by 2002:a05:6a21:3e0d:b0:3da:7154:2ebc with SMTP id adf61e73a8af0-3da71543f94mr17530332637.7.1788812633303; Mon, 07 Sep 2026 13:23:53 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:23:52 -0700 (PDT) From: Mohd Ayaan Anwar Date: Tue, 08 Sep 2026 01:53:13 +0530 Subject: [PATCH net-next v2 1/9] dt-bindings: net: ti,dp83867: add supply properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-shikra_ethernet-v2-1-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> In-Reply-To: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=1977; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=eZIUN/lYfehnQlzthxyb/UGydSLzCEUV422r4IFRfA0=; b=EuF5sm/rCRNcDvnc0/rvFoyKCG0xmsve1yn8yP2rElyQjKuDHGy0wFbLRBR8A7X6m3So5bE+B uQ7Mpbc/lRHCURbTTlk4ukQleNVcUHRC9kRyYA8PFbgEBPjPxluUPRY X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX936MQz8OYTmQ 27kxz5yk8cKXv9dQmuVk2re7wTM3TUfAudGsjRYy00EBXV8ovIAJ26P5S1S+eQyzjOkkGypzO2c MqjTwPaZmJf8WyAr6rICIOEl0e647Dz+YPk+uiPGu5uKb7yLhE9/z384KLYH/dZn4dqzXYpxjta ecj3v9+spMs3Env33LGHqTilzLRJXm4eVzOREYc7xdCNpEwTXu1fR+nLEmKj/ku6Aa0LtoXrBEz 1AJXa09DO4jMJViQjSKLGOkf9wehOTCAuN68faewpSlbj11x8wHK2gxqvHRXMNhokQ0ClxrPfEO LJMToJHvPwsdc+l7GPCCzDN97S4ClMI7T2BTqAlfELtamYYk8Kg2vkbzVYiIeCA9i7xiVnakR6o COuhOYZOVX4Oq8g+Kdo/YpC8jcI0yPGne79qwwOLXw8oBZkRjkt99F7gpCIXp2q994O9R4AC4+w KSkaRkLHyit2xNxbikw== X-Authority-Analysis: v=2.4 cv=Xbe5Co55 c=1 sm=1 tr=0 ts=6a9f1d5a cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=9lbML-Ic3bjincHAjDUA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: uG1DHmWRSkzs64xPOXXFMmmryarQdxjd X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfXxJwjblEtp7o9 HyUgxXLv8/0WMMXOPZOGwF7sT0YHEhfmvckple1mVQ42NDvkepTaZFSPOFIZddZsQDVbUEbgaa3 8lmjGSZ8+AAjpyciE+rlfUga3jTzOak= X-Proofpoint-GUID: uG1DHmWRSkzs64xPOXXFMmmryarQdxjd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 suspectscore=0 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 The DP83867 PHY has four distinct power supplies: VDDA2P5 -- 2.5V analog supply VDD1P0 -- 1.0V digital supply VDDA1P8 -- 1.8V analog supply VDDIO -- I/O supply, which can be 3.3V or 2.5V or 1.8V The DP83867E/IS/CS datasheet (section 8.3) describes two power supply configurations - "two-supply" and "three-supply". 1. Two-Supply Configuration: VDDA2P5 and VDD1P0 connected, and the VDDA1P8 pins are left unconnected. 2. Three-Supply Configuration: VDDA2P5, VDD1P0 and VDDA1P8 are all connected. VDDIO is a separate fourth supply present in both configurations. The datasheet specifies that it can either be 1.8V or 2.5V or 3.3V. Some embedded board design expose a GPIO-controlled regulator to control any one or more of these supplies. Therefore, document all four of the available supply properties. Signed-off-by: Mohd Ayaan Anwar --- Documentation/devicetree/bindings/net/ti,dp83867.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Docume= ntation/devicetree/bindings/net/ti,dp83867.yaml index 4bc1f98fd9fe51260b767b0a1b8b7eaf974a9af9..e78f08ded3d0d449ab75bf33d81= 4fd49587f8387 100644 --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml @@ -118,6 +118,20 @@ properties: Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h for applicable values. =20 + vdda-2p5-supply: + description: 2.5V analog supply (connected to the VDDA2P5 pins). + + vdd-1p0-supply: + description: 1.0V digital core supply (connected to the VDD1P0 pins). + + vdda-1p8-supply: + description: 1.8V analog supply (connected to the VDDA1P8 pins). + + vddio-supply: + description: | + I/O supply (connected to the VDDIO pins). The supply can be 1.8V, + 2.5V or 3.3V. + required: - reg =20 --=20 2.34.1 From nobody Fri Sep 25 23:10:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACD934F30CF for ; Mon, 7 Sep 2026 20:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812661; cv=none; b=TqeHmDDyZr/8IT4zcVYTWkyCSBGcRnj4btkGauJMMU5NWYVbU24E3MDofwuqCmrwdBNyP4wkcuB+txv0tZHqd4cTRBqzH+K01VsjD0UoGTCGZ2HupedQAI9+yF7Ne32pPShu7c7hr+G8EWEPfEDiCKcI96rx4RRnbWpxfQ0ACRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812661; c=relaxed/simple; bh=jAZUog391waib5poEaz5VaRKy/HfMl4AFD+Z9YWtswA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aNT0h3YEgrNM9IaUcdz0Ffu6N8Xxi3b7a+dQdNBLpE71HvW4QsbIArMjb2iJ82KLv9S8I3/qHC85N8bR+wosL1jrp9P4SBaHLOqSMdZkTsPW+bSkLbJga/CxGtUskseBGZ7Anl+dT90z2hPfWaQGzfp7uyUdczRFfGQ3H08a7M8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Yjo8of4e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dsPAhY0W; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Yjo8of4e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dsPAhY0W" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687H8BoL4183691 for ; Mon, 7 Sep 2026 20:24:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BDFrSG1eq5takqmdP2umAB+q8t+A/RdaXA3/66CSsJw=; b=Yjo8of4eO3dgkOiY 3Rn9v30BZ66pdFQUKXMgX8BAub6xKgb/nufZWLzUux7OPOQLCLCC/TC6/AGgKfOz 4reUvEh/QQE9hU+83G6rTyOi31ty/YJUCdOLeOMRalgulqn809B7eCwy+E0Fe+wB /dXpmAtjUhu8yN1jzsIznLFwpUeD7s4/sCgAD3auxPNjr/7Y43/+Qv2Nzf/eNLHl 7YzYHI/YJJlesEAnUutY54DoMf+rGAqpj+c4BFpKDlDdU1tQagWQZAbTl9E4EGMi YgLKX85rPgpXT+dixMPAwL4qyPCc6uj6rgM4jt2lYRbugqda+9tTKyXkQ+6UMbvC +JrMVA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghtfx28ec-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:24:02 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cbb20f82a0eso2727636a12.0 for ; Mon, 07 Sep 2026 13:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812642; x=1789417442; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BDFrSG1eq5takqmdP2umAB+q8t+A/RdaXA3/66CSsJw=; b=dsPAhY0WdCwH7TYaqE1xKKlH3xPpSqTiheVEpaauVU/vHhWICALYLAYkfo5C3aBpSz uuD0Y0Y9XxcFiaHBmr7sCkkZqSkO+HC/YzlF8cfy1mNoxkV0ys6aIhR6TDPU4ZHNxziv 9Ufu7fIYkHowAiJkhMHOQFUpPnfeIXfdQwWu0ckh3P4q07Se4csSZ7q13o2x51UUuhgH IYzMOK3YyNo4jdVIzZ7S49DDjPOHxpkjQr622hphmm6lY55zIe5qYgJxGNAszJM2RyHg 1rHyj/L5ZJHhN3XuvdUk9h7So33RcPh8dIR9+GWLf4IWhQCem9V/ShuGWfldCClV0gG6 iNCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812642; x=1789417442; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BDFrSG1eq5takqmdP2umAB+q8t+A/RdaXA3/66CSsJw=; b=eBHwoLR1LE64CaBvWzu55oXl37h6QDvigWrEgXvnIwP3JVoD3+/fzpla8wIQ0GwbXz EKcvND+RGkvXol/ITZME8N/RedruyNqZCbU/xLjZ8fj7m4glE5Gv7FJRVEtpFzYM0LDk 0J7aPCRZUUal0LEnG8Nt5fExV3AxxTfMIRwVaBcSohULTDkDaW5QxOXGmhVlFHSvKNkv PBF+a+bJRXUo2x4eUPPw3LrVNfbved+hJyXFRelyqndubU2nYJjtMKvDovg6FNIjb4lL eIoob2ty+vf7PlNTeHexEit2sZYScgjqPVjGZUEkHUhFFzapAcAkt4nbuSTqAKpdIiT7 l3ug== X-Forwarded-Encrypted: i=1; AKwUvBzS4Bc9e4ZrsGNLF3mXnvWc9ODacPFRX6n/59FGKgishVai/tj3njXQomxIRMNhmvaxDfnw6AOoGd8VPc0=@vger.kernel.org X-Gm-Message-State: AFuF++lVgyYpDOholMilgSXBS5A/gms0PjkGe+VVdM5+9qJGLjL1S7mW z7RzxnMsE0ltIk1kFHA/D2htG5i5oUQ06JjGvOOWUiTpFPKSlS8xtYoQeAXxmW2UTSCdmkCadOI ycSMqvwvHx/mblNx9hmLSVoeWMv305NStAWJEvBEfJdNdWKfNSSgocZWoA9UK3SFgJwU= X-Gm-Gg: AYBFou0MzH/kD329rjxAPOqwOjOi05BPGt3YD5V0Y4AIGGhgdRl/b5GwkB0gTjnUVdY ishATQmYB1onwqewO2bo0FxuIIRJA8x1G7pdC9Z00fUmvYIRvZH7UWhVMwj9qOvfs4cYdPdItPj 3RBQ5AySmEIJ6q0TKyCF/xYINbxeEr3APo3zyYeHuNrWhUVqOWLKzW0UkSVMwPVdM19oXjCgcyk Mw+hwgKg+th8tbhaczwOKKw04umJ/yZlPaX4qdI1yjJ/qik/Nr09hX0FdeYonlu3Uq6JSBdnPSy s0woLAidlR4HsD55UQEmW9wNiIHG1SaGGSd5bezZzMZ0wH/zdo/p3ZQ4daiqtgyk2iNv5NdDZNq 4rbN7rBqybg/lJoofIeN3wgBYXwXoCQ== X-Received: by 2002:a05:6a21:510:b0:3d3:adbf:777e with SMTP id adf61e73a8af0-3da3a167fb9mr39912002637.19.1788812642084; Mon, 07 Sep 2026 13:24:02 -0700 (PDT) X-Received: by 2002:a05:6a21:510:b0:3d3:adbf:777e with SMTP id adf61e73a8af0-3da3a167fb9mr39911964637.19.1788812641662; Mon, 07 Sep 2026 13:24:01 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:24:01 -0700 (PDT) From: Mohd Ayaan Anwar Date: Tue, 08 Sep 2026 01:53:14 +0530 Subject: [PATCH net-next v2 2/9] net: phy: dp83867: add regulator supply management Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-shikra_ethernet-v2-2-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> In-Reply-To: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=2136; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=jAZUog391waib5poEaz5VaRKy/HfMl4AFD+Z9YWtswA=; b=DHYLaLQ+gXL49XZqtb6eATiMimarC5O+tgQ+agl8xwwu1/xxfwpt8n4/qEUHFiyLy+f77rDwd TUNDQALem7ZCzzJx56lUODiCdje998TmLDFIHjtXVqoGFBNUxXf/UFH X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Authority-Analysis: v=2.4 cv=Weg8rUhX c=1 sm=1 tr=0 ts=6a9f1d62 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=uuhe7hOpKvpPPjRdXc0A:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: HSu7GbSMNvoR_8cDCTbGscJ4LG44Ip3R X-Proofpoint-ORIG-GUID: HSu7GbSMNvoR_8cDCTbGscJ4LG44Ip3R X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX6bzJ7c3KOaVe xU1Yjbs6l4g3Uq7F8lsnFGx6HhhDlGCSydG2vPM4gVhKVztwJ9wml5gCvNSKHtZ8UGd4C20gN9R DPyyWhY9mt8hvCS3stm/cEr/r6cSPOk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfXxnSobRD6t08e 3SK9jvbXNVbRpGdeU4V/lVbZ4MH6w5SBk8OHndyyE04EN1yR5PSPa1iu17nuUZYExYXwuBrPzRt /KqEa4Hz+xdl7BmSCD+1mB6LN/hZ2t+qEpT69+pNWqGMNU5okH8RxiUmESDXd9ekW2Lz5T/B4PQ fmwNJMKcHYcW5sAanGOl9nWIOBT03LAbGWzy2+Zm0kB82DjSLQHooNXebOaaz8V6bl2VRuFF5ev EZRrx2PzSvF9eC2ho9bMPLsJDN7rWP+GjkCNnZuOmfb4OdK2qMKosINa28XYnT7M5ZJCrPGApi5 AJEgcVYTnZMgwtihej6VVRxugNL9Wrdrmog1wiMPoBYXqjHVD1Owf+lTJjWQx6CmeKtC7iMKzuq WyHHiaFrqqExF7jIwStea6Nt9Ui694fxCHIhVXU+fBMiQp+D+P7q+Ow+c2KShW5okfSdHwzXsf7 1dDh45nU98RNPr554MQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 Some embedded board designs use GPIO-controlled regulators for the DP83867 power rails. Add dp83867_power_on() to enable all four supply domains at probe time. Absent supplies are silently skipped, so boards that do not describe them are unaffected. When any supply is newly enabled the driver sleeps for 200 ms before returning. This satisfies the post power-up stabilisation requirement mentioned in section 6.6 of the DP83867E/IS/CS datasheet. Signed-off-by: Mohd Ayaan Anwar Acked-by: Andrew Davis Acked-by: Lorenzo Bianconi --- drivers/net/phy/dp83867.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 88255e92b4cdbd6da2e2c1d10f9c72348d28dbc3..dbeee7cad6f0cbfeb127bfd28f4= 3ee2a16c78879 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -15,6 +15,7 @@ #include #include #include +#include =20 #include =20 @@ -719,9 +720,41 @@ static int dp83867_resume(struct phy_device *phydev) return 0; } =20 +static int dp83867_power_on(struct phy_device *phydev) +{ +#ifdef CONFIG_OF + static const char * const supply_names[] =3D { + "vdda-2p5", "vdd-1p0", "vdda-1p8", "vddio", + }; + struct device *dev =3D &phydev->mdio.dev; + u32 count =3D 0; + int i, ret; + + for (i =3D 0; i < ARRAY_SIZE(supply_names); i++) { + ret =3D devm_regulator_get_enable_optional(dev, supply_names[i]); + if (!ret) + count++; + else if (ret !=3D -ENODEV) + return dev_err_probe(dev, ret, + "failed to enable %s supply\n", + supply_names[i]); + } + + /* Datasheet section 6.6 suggests a 200ms post power-up stabilization */ + if (count) + fsleep(200000); +#endif + return 0; +} + static int dp83867_probe(struct phy_device *phydev) { struct dp83867_private *dp83867; + int ret; + + ret =3D dp83867_power_on(phydev); + if (ret) + return ret; =20 dp83867 =3D devm_kzalloc(&phydev->mdio.dev, sizeof(*dp83867), GFP_KERNEL); --=20 2.34.1 From nobody Fri Sep 25 23:10:00 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC20C46A60E for ; Mon, 7 Sep 2026 20:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812655; cv=none; b=OmzX81EAeDNFsPhzBtTdXkBL1swkNiHEpitAISGSFVnnz7ILLCgRzZPzivxOGJe8DXKBb1aqBpiMY+mkZ3JOQowsBi/Xm5lo4A3g25ji+6Hjd05zgvoIoN+8twtcQOxoRMmcd75DpQJdasYk+nUSNqponjznaFF/ByTnBBAvjDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812655; c=relaxed/simple; bh=1tqS6Dvk6HqdQruGW7WjMOOIlEWgJQuXPAL9e/OSA7c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rT3U/reMD6TMFX3D83g/wOqCNqk4f7QdQvlwUAFei3mNocRNwiAjusizZitgEgsRvl2zUmJA3G6uUO0xlZX14RRDdEAXDkvQkO7s53Z3mrePueCvSj7tw/XpSmyHNFg5Awm7WfRS68D4AXITByk3ZJ61F+k22QtDbzDoym2lNVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ly8bzrqQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kanuK5ES; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ly8bzrqQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kanuK5ES" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687H85Dh838236 for ; Mon, 7 Sep 2026 20:24:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kIQdmFx4PDOd5O9ixmJ7nfhs+TOQEPZyJ9aGwi2TRlY=; b=ly8bzrqQLmKCfTbk Dgegf9qo1/QceiD70j29Iro/J0WLlveKFwBBuAHrPaUkrs/qS4/cWBw2RsOzkZ5V vBpPYorrbAJe8yLF/6x8Czso1h2DkzgxkgoAaEt/mrIOwrW4iKSAuXNTi3Fg8U8V qEjMSYrUlgnNFYgOIrBBNzEjh8JF3jhfJ563iRCbirj4F+5AmqTjLmmlqp4jn+mw zduDJUZufrm1BFlD+PYz1M3orc2+DYiFyF005X0kfDmUUTrl/af4GLpJjisdSzYJ xM8KfmiGeBe4tQG6dkXVOx20PkPrSRW4l6osrnSXCaEnu8fhVvrDlSOFgmBfwc2p ZfBWUg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghssg2h3u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:24:11 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cc1ca15334cso1792463a12.1 for ; Mon, 07 Sep 2026 13:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812650; x=1789417450; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kIQdmFx4PDOd5O9ixmJ7nfhs+TOQEPZyJ9aGwi2TRlY=; b=kanuK5EScl3tMQrOz87s8yUbw6ueHKAZMZscebNdZsoUfSmukqRaII3NWR12B7bnJ7 RjwclfS3OBHmN+BSW4NM9RlknCh+PBYR5Cj/vQ/ya5GQ1ahHOTN0mIyYsh1Q94rmiqEw wBaUqF36G/YuZXYti3uQk4TMQq7iAxiYFgRtJBWuGzqm9QSB5XAGybncQlRTFxz2GflV Vn+sqD9h3DHvlHhygMnbKqEAFQIZEzZ5gXeP8twMiA2mSwh/vLyEl6oTAssHX6uAqyeK iRs8g7ig2bhAYddFsHFX8rnhXVFfTtiy3EEYyX0MKNGIR0H7BVJbYMQlRH7VS/g1+d6x NJow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812650; x=1789417450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kIQdmFx4PDOd5O9ixmJ7nfhs+TOQEPZyJ9aGwi2TRlY=; b=i29AQxjJypMfAtQDNcYnQ6Y9XqYZXq63ulSGr137BYKoU8uLGISh1+SDskGbyrwGZr M7zAhVzTJOm0ahAfNQnfDQmN9VkqYO050ocD5J7J4MHJ5BlznUCZtfFz4OVZ/qpHK/sI /9nXC2dAF0W7qmmj5qZyZuB9vC1n/WWJz8ppByS8+BT3fJrV6xjTDt3wgd+1AtMxyDcZ eDtvF9PSQeNT/uJytrOXYqtttlweiTXRxgqKKiuIjJQ6aGoMlGBYz5n6iC5oiI9OfbcC EEoU7LztjhzYY/MFlCm5V7SiBk0zm/OAPty2zb7Skke1RiUObQ3O/whCJZcfrSuHyd75 JwLw== X-Forwarded-Encrypted: i=1; AKwUvBxwmkSva69gWTkrRLoor3+V9yi2oGMQZN1W9YFZmg7YWH8aNpvY/UNEbTWWMwbiXZFxS00bouujz+7s/LA=@vger.kernel.org X-Gm-Message-State: AFuF++nnrtd5Ko5rqsJbV8j9Yv6y1cy4Jl9Jtt8kOhFIEw0C3aV8OAfn 6EAqpSuSiVU8v6JhGcHiPqck/jFSbxM52+K2O5PKImf2KJn/p6yuoE2QgTToRgzLs9220LT1OHd dTS6ylv2K8sVuwPolW/y9aKvbJE3B0eT8cYZmEU9GIe00uaHHOwFPSlCcMNL8VMqjJn0= X-Gm-Gg: AYBFou3XrWrRo+H2nOhipadhE6BEqhDG+njU3tIoC0IUNsSTCjmpaBSR0Cz3sims4fe Rrb9F7TxfnkbsJ8izeCaqY8gTFxpdyTYbl8wyAwkT6GRB52TnJhKTTuJlVss9jFWNl6SIMS9uy0 6AnF8LEBtjDpbYIJ3bPrIXCgsqAq3t5gTifJGypYdtO0WNzsKXsHOvbdLXvUfbFCwFPLh/AKe4E yl6Bs4qPIun27LUXSFg9R1qa8eZZDjVU9qLDd2sh/1Yf4RzMIk5fmzjFycKCjtpKbtmX9B+yKuq O5KiMfGHE1/U93AYf8gemn0QvB+Dd+Zd3hlgAbHrsbVFAtQodkMn9u8x1fXufraRN0RPUEey2tp 6FEbTaRRxyMnRquUp2OwoYOCQP2PrZA== X-Received: by 2002:a05:6a20:1441:b0:3c3:9070:96b3 with SMTP id adf61e73a8af0-3da39cffff0mr39040581637.3.1788812650412; Mon, 07 Sep 2026 13:24:10 -0700 (PDT) X-Received: by 2002:a05:6a20:1441:b0:3c3:9070:96b3 with SMTP id adf61e73a8af0-3da39cffff0mr39040530637.3.1788812649993; Mon, 07 Sep 2026 13:24:09 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:24:09 -0700 (PDT) From: Mohd Ayaan Anwar Date: Tue, 08 Sep 2026 01:53:15 +0530 Subject: [PATCH net-next v2 3/9] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-shikra_ethernet-v2-3-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> In-Reply-To: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=3972; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=1tqS6Dvk6HqdQruGW7WjMOOIlEWgJQuXPAL9e/OSA7c=; b=CrUJsHdZ6c2FYOwXEPMoV00IX+6Ep99Hv0mU9sSCTtavP+7P0xPU00RHkfInYorGHLTw+7fko 6sEW89emChQDJtjxcn+QfkPpX09AxlVlDL6j/LdQlY8piS4N+gGFkCq X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX2T0oCIPbTmgi akapzpNt2BDt0CCXYrcMaM64/H5SHQZUV3y5CwZcQFhAjIiWhfvjbk2VxlFqndbjnpVrKj6jC0r 8gtoUPcFEYgtooiAxDXtS0Bx+Jpv9HJSWIP5r2qkM/3vlOdyBqARTPGgzYuYBjZtiRZBMoR3Qat fcCitmRFQI+7DZYA8ddJQvu6qdEg5MUAo8uCvlZ/N6nWiBHNCwSoaProu4XR7kWP4AWRzbF7NcO bZy+1TY/RxEB/3IF4UpC9iikBvc7vHRqOUbk5SwhSM2QO99AwCnHewEShBCew8MfQV9jzABOfDW +o9Sy1BxnntuKNrWLMcnQ9iGBMnZXQXYlqvroCvcgoCoIvT0kAux7xBpCKbTGHZf5Y641RWSLQi q3fGmdu1+eLPA/d1jeWtVxeCXnYc8jQ/xpvj1t10fRKkB4IEVRg7C/bUmpgO80KYmOZow6V+3nd 3q8Nqjf9bTS7zAfJWvQ== X-Authority-Analysis: v=2.4 cv=MrJiLWae c=1 sm=1 tr=0 ts=6a9f1d6b cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=DJPLBmofjJW9p3Fp6mMA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: Aq4CalDMzxdkftpTEXwPLuFR0F3tV5Wi X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX6QBoYIYYAgbe bho4Leo2cXsWjp/n5bTb1b6encn8GvMIqm0KIjoJI8qv+KJTBOzKAdqb2S9Bp0fyTsA75ROnR0s unbvx7xRxuqD7PeceTpseSHoQ/e/x90= X-Proofpoint-GUID: Aq4CalDMzxdkftpTEXwPLuFR0F3tV5Wi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 Shikra's EMAC requires two additional clocks for NOC interconnect access (axi-noc, pcie-tile-axi-noc) beyond the standard four, and an OPP table with required-opps to vote VDD_CX to SVS when the NOC clocks are enabled. Add qcom,shikra-ethqos to the compatible enum and use an if/else block to constrain Shikra to exactly six clocks and require operating-points-v2, while leaving existing compatibles unchanged. Add the relevant compatible to the binding document for snps,dwmac as well. Signed-off-by: Mohd Ayaan Anwar --- .../devicetree/bindings/net/qcom,ethqos.yaml | 50 ++++++++++++++++++= ++-- .../devicetree/bindings/net/snps,dwmac.yaml | 2 + 2 files changed, 48 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Docum= entation/devicetree/bindings/net/qcom,ethqos.yaml index 423959cb928d945aa3e758a3c803d12bd61ec42b..ad2cc706fa74041486cd90c3d0e= b1dde0acaa27c 100644 --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml @@ -14,9 +14,6 @@ description: dwmmac based Qualcomm ethernet devices which support Gigabit ethernet (version v2.3.0 and onwards). =20 -allOf: - - $ref: snps,dwmac.yaml# - properties: compatible: oneOf: @@ -32,6 +29,7 @@ properties: - qcom,qcs404-ethqos - qcom,sa8775p-ethqos - qcom,sc8280xp-ethqos + - qcom,shikra-ethqos - qcom,sm8150-ethqos =20 reg: @@ -57,9 +55,11 @@ properties: - const: sfty =20 clocks: - maxItems: 4 + minItems: 4 + maxItems: 6 =20 clock-names: + minItems: 4 items: - const: stmmaceth - const: pclk @@ -67,6 +67,8 @@ properties: - enum: - rgmii - phyaux + - const: axi-noc + - const: pcie-tile-axi-noc =20 iommus: maxItems: 1 @@ -81,6 +83,11 @@ properties: - const: cpu-mac - const: mac-mem =20 + operating-points-v2: true + + opp-table: + type: object + phys: true =20 phy-names: @@ -92,6 +99,41 @@ required: - clock-names - reg-names =20 +allOf: + - $ref: snps,dwmac.yaml# + + - if: + properties: + compatible: + contains: + const: qcom,shikra-ethqos + then: + properties: + clocks: + minItems: 6 + clock-names: + items: + - const: stmmaceth + - const: pclk + - const: ptp_ref + - const: rgmii + - const: axi-noc + - const: pcie-tile-axi-noc + required: + - operating-points-v2 + else: + properties: + clocks: + maxItems: 4 + clock-names: + items: + - const: stmmaceth + - const: pclk + - const: ptp_ref + - enum: + - rgmii + - phyaux + unevaluatedProperties: false =20 examples: diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Docume= ntation/devicetree/bindings/net/snps,dwmac.yaml index 2449311c6d28ed3fbf8c92526ce8b872900653f4..6a1aea371c0b42ef71f90d89276= e15159c3b3277 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -74,6 +74,7 @@ properties: - qcom,qcs404-ethqos - qcom,sa8775p-ethqos - qcom,sc8280xp-ethqos + - qcom,shikra-ethqos - qcom,sm8150-ethqos - renesas,r9a06g032-gmac - renesas,r9a08g046-gbeth @@ -632,6 +633,7 @@ allOf: - qcom,qcs404-ethqos - qcom,sa8775p-ethqos - qcom,sc8280xp-ethqos + - qcom,shikra-ethqos - qcom,sm8150-ethqos - snps,dwmac-4.00 - snps,dwmac-4.10a --=20 2.34.1 From nobody Fri Sep 25 23:10:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DA744F30F3 for ; Mon, 7 Sep 2026 20:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812661; cv=none; b=myGq5P3tFX9XMbcz2q5us+i0nupvLiz/rNyBKYRBRNUisLQLnSVOqQiAbcjRybrEN6zknwtGY1I65TIkoI/DfhThsFUPZtI6b1A2P6LXJGtXSmQ0+RUZu6XDBRFBeYOCS9aCFeqEgBn1Z+POXkptf3uS2z0uL7qIPBxVyYtgWcw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812661; c=relaxed/simple; bh=AH+qx0x4KP0Ub7IhYEI/kkBrCs/Qa/fQa0F1JhH3QPg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Dca8YoocT7FtLsIFqs6NNSEVzuRTl+GrvSIC6ecWjRwDe14gRW0KJgAA4C36PWGI2NSSJyr1iYnCyPThAi653QgFKnxLHoVSe4ozqsL7cN2/UZfZuqkNZfBveL3bN5Mnn9DRvI8mwNKrpImjWaKOcY8bHk73TvXCfyNYTofER88= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o7lD6MeY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MexD4V2L; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o7lD6MeY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MexD4V2L" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687H7mZg3484612 for ; Mon, 7 Sep 2026 20:24:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Az1erGSnETLR/YFXkBczCQXpiybLwgDvwwIrMae0ihw=; b=o7lD6MeY26M1WO8v 9ZKqJ7uMQagH3gzeQUnBdtWxeQ5RfAP5np2R0w16jZkuPezpH+PTHTAp6hgECdR7 7/8u3EzEwe+XVZxcPYjXTQ6V8acwYo7kNQWU+D4ZgB3ymzTwQW03MrT2hshiLFY+ wuomhCCkDFfYTt1l/3uVhiB9ilBcjpWNp2t9eyy5jYXMT4W822v8UeXr0Q7eFii/ 90q90l9ISJ08bfpWrXyuv73IMxPOXr2eHwZu+ROOyi39d5gy7QgZdYNjOBVWm2ls 3zh+hpSyWIp6TjRMvN8gWoJ4i72Fl7QFcjNMoTwSy/WJ1UbmEvDLgAd2mgicN9Mk 0ekCDQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghtty2588-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:24:19 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cfa4e4684bso7225835ad.2 for ; Mon, 07 Sep 2026 13:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812659; x=1789417459; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Az1erGSnETLR/YFXkBczCQXpiybLwgDvwwIrMae0ihw=; b=MexD4V2LvqXnUk4MUfN0PS44nPiTLdFSEWNwIw7aChgZbpq1RPmaQmzLh4+QKvhH/G kFfCR1YSO0qHP+065gDqQz+oMQL/Wb2Elj9QneNSe34AWJJW+42LgpTri9fDyGQVBVxz GjW3rlXglh0Xdjh2OoqtqT8fjj0bitEYNSuWZmcrVtPAj4uuhHkboDFsQZrINm4ONhsP BiUk79gjrgY82w5RO7rJNdsG7mK4ZiVTNmtkpk0dAb3KeK+xge0xGBUvup9o73aUyjop pR5LATEDkR5JPF68C/3Gv4IgbIEhUJxx616KDVkw6bLPNLHnVSLEjdkd4CFnkz6E2Gm8 Hm9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812659; x=1789417459; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Az1erGSnETLR/YFXkBczCQXpiybLwgDvwwIrMae0ihw=; b=eBkGQOCOODkKAv0RDrvvcH5/MLKDscMhqGr3W6w2CQx9rL8V1Lu0iK+bbnZEPW4K6e QNnrwpG3ZEbTHPKztrP3hpnPDAA8W3QFKy+ej+fumoKM1po6letJVANiNOmVFKUE7OFx l8fgw9aMY1wpW4E5c8mNgoLUJp4HvvqXdTze5ppobWwIdOW25IA6k+PPpDLtQlXQY1eo z3NVlWWr4EaO5RqrZ33eugYQ4qGUBj5Pl2+UqQhaY93s+N0JbxayHHd0AnYHFKC+DQWG 6gt8rduq1KQ8a8/xGwIYolxvPW8sxCrHGJ4urdmwSDhJQTr2MtEdoIHAwyiN/7K22f0b P9sw== X-Forwarded-Encrypted: i=1; AKwUvBwX+WA5ZsyO2hzrEikOk//c3Ea/CRYxaNpO+ICpRwpfvC+/paUV0r/uZJAGHu3/thZPTn0YnBhadyqpceE=@vger.kernel.org X-Gm-Message-State: AFuF++m1ccm2xaQidnIF0bwPeb5FqhnNQAoItsKZYwaH4T/OxBZ/KwRL VDiWThwRB1StS1u4vmFimvyWtgtIMNzPM3v1As74hrnmzaKRWcMHLCaC3gL7KJcRQRKkF2nx8RP MceC57YXpQmS0X3g1Z3c+56KtnsQyeQZBCuf7v4/au/nhWyxHXslyjVEvWaafixooun8= X-Gm-Gg: AYBFou2Y8t+//AS9fOa7esLE8rZJujaDO8hcMhuMsBGweEhuFwRaT/5ka2CB3IwlSMt 5792kEyId3ylvHbQoQ22HzRzSvvqdg97C9SYzh1FbOVgaLpRzuMVVv6Cq8asHfZZ1ugMQRZx9os xom++IhAsMjiEO9DT//khMZVZZHV4hhLTiZWB3NziCoYssPoCLeRPDBRaSdtLdkuvGMMLDf5+8o EBFo7niwIiEeIhQVWnsiYO7LvDKoGgSdgPlnH5hV3x9R6tPlZRZair+TxQooENXSWH6mp3Hzk9R K/JdJGiZqYJtqkFTFSIE/ARK4pWQb4eHuDnZFF/kRCxeB+GH82j5vDy5wBFmdif2hKPaEKfwt5K HrUywAw++mJdE1yRnM+3KCi47e83GRg== X-Received: by 2002:a17:903:40c6:b0:2d8:d4cc:5bb1 with SMTP id d9443c01a7336-2db1286ae13mr343732885ad.17.1788812658776; Mon, 07 Sep 2026 13:24:18 -0700 (PDT) X-Received: by 2002:a17:903:40c6:b0:2d8:d4cc:5bb1 with SMTP id d9443c01a7336-2db1286ae13mr343732285ad.17.1788812658328; Mon, 07 Sep 2026 13:24:18 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:24:18 -0700 (PDT) From: Mohd Ayaan Anwar Date: Tue, 08 Sep 2026 01:53:16 +0530 Subject: [PATCH net-next v2 4/9] net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-shikra_ethernet-v2-4-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> In-Reply-To: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=1916; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=AH+qx0x4KP0Ub7IhYEI/kkBrCs/Qa/fQa0F1JhH3QPg=; b=U5M2VtaJtZnsRmWp4CktPyNR78lRXabNZ4gb/HF6l5Rtx7QqP9hm+vavujwv54agyXymDxysK jc5fEfZKW1GCvBMrlVtVw8Cn0R+P4nBWRzKjVpV/PEYH5ZGT4L5Xlkq X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Authority-Analysis: v=2.4 cv=QNBYgALL c=1 sm=1 tr=0 ts=6a9f1d73 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=Vjzh3eGJV6Wj_RHhdNYA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: peJbxk5KpDXsmm0bDABxONJFvxr-1n1B X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfXwb2VPNJqBhh9 xR+rOpsWJ28hYS3wFGNntg8f461hs90DHp5i7UOjad1j0Xd+YaMuOFw5lgzqAX6LEyDYhWF8HB9 5ngDCOPvj3P/BneNt3m034rZ08XHBP8= X-Proofpoint-GUID: peJbxk5KpDXsmm0bDABxONJFvxr-1n1B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX+NS3X1edpbzJ brZaoM4vNNFJomQkYjvJyMeyZiKatIGTJzggKs2fjitvHWAHwdT0Pri9hmpSviHufNIzjqV8X2O gbc4c7hTTYOiChJqKEvDBLzLgc0doRP15DlEjflsv74RdUQyU0xtp2NMRpiMPdi/5QN2FGRekV3 CXWeggJz1UDdiu0pwR7pztv21DUpcqeH74uBs14HC2LMT94/WRhdugELau0PWfVCLO7hJOm3yrh D3EXosPzeIqZSWOZhK2N1CC/Sx43WY5T9rDwH2lyL4vehLbgGUXsqyNpUQNZc+2iG6RkNCrx1UR BQAw1+e4COvw6RPcG0p8Iz+pShGOO1C4oCVt/+iCampehmTF2H8+WwHKKSQ8FsOz6By/0gdolk6 uurbafkCgR5n4MLv7QadSDmQ7bvOBjb3rG7r6y/9lFvDQFH/AyPxon4G9t9rFV+wG2aEu/BSJ11 oHbb9DbNeiKZ9IBidoQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 clxscore=1015 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 The return value is never checked by its sole caller and the speed validation duplicates a check higher up the call stack. Convert to void and remove the dead code. Reviewed-by: Maxime Chevallier Signed-off-by: Mohd Ayaan Anwar Acked-by: Lorenzo Bianconi --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index ac7d6d3e205a1ab5b391def879d6f1033a0961b6..44270c25d874f72e7f971757fec= 659d36468c315 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -371,9 +371,8 @@ static int ethqos_dll_configure(struct qcom_ethqos *eth= qos) return 0; } =20 -static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) +static void ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) { - struct device *dev =3D ðqos->pdev->dev; unsigned int prg_rclk_dly, loopback; unsigned int phase_shift; =20 @@ -384,11 +383,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos = *ethqos, int speed) /* Select RGMII, write 0 to interface select */ rgmii_clrmask(ethqos, RGMII_CONFIG_INTF_SEL, RGMII_IO_MACRO_CONFIG); =20 - if (speed !=3D SPEED_1000 && speed !=3D SPEED_100 && speed !=3D SPEED_10)= { - dev_err(dev, "Invalid speed %d\n", speed); - return -EINVAL; - } - rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE, RGMII_IO_MACRO_CONFIG); =20 if (speed =3D=3D SPEED_1000) { @@ -479,8 +473,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *= ethqos, int speed) =20 rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, loopback, RGMII_IO_MACRO_CONFIG); - - return 0; } =20 static void ethqos_fix_mac_speed_rgmii(void *bsp_priv, --=20 2.34.1 From nobody Fri Sep 25 23:10:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B69DA517BC2 for ; Mon, 7 Sep 2026 20:24:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812670; cv=none; b=VuBXmN1MI5Rj8aOKtIH6lPT9+H5kYwEzHvFT0aoqukfk6F6DBsPvnn0gRflWsri1dRN4D6SMzYROf5omtSFUzfYcqlCdHYndIkOoeqBwmsLGSikoKnz5E3eviQULnBnvrFaVkndcQeKITRNUkk/ICG75mrClGFkeqBSCZmOYFgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812670; c=relaxed/simple; bh=H1FwwnCAzH++7RGqPRMDkA7lx0MXBiHM+RuBRtHZzLA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ne9iTK91YswhJoaoACO2LtD7lHSk99q9qYbgMul/Gh/cq7Luh88+EBbo7qlSnPiBHa0iq9y3gZCHysa9e4xIHMAqJIrkkirjM1t4tbxjjjWCruwPI5iOXuhmuEogcD8J08UzMnHg6V/cVjXrNX0OJeFduA3NkJTKpbAXUYDeF3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oXXlmoTR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fT/0u1za; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oXXlmoTR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fT/0u1za" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687H8Id04184278 for ; Mon, 7 Sep 2026 20:24:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cSW22gDP0aHXM9uYQ6GNqbB9X8L4peq6obrroaX1pIE=; b=oXXlmoTRr1saKrev F840BrG63g+79L9cQDvQOUzAdtHc15i3Iupnmogi2qIfmG6JAdpPmhvwBrvWHoPR Fp5koZlCQIb59yiobyKict0sA9mzTDNZHGKKLMEryt5YaoOsPTjpA0NvZML2H3gy aTunk1oAcu0ofjoJhgJFRWHHGMwtndrk5TXMcL7hDNVH7UzPTqQVOJGEI152mKOC hCxvt/lxW81UAHxRzgkXGGReuovfYmxOHRc034IizTCEmddyuP9cUVGog4HZBRLT v00BI0NU2Jz4yiBtWhmfZaeAaPYyE/uXxtR2OzanVdMHQlr2RPVLwRXNi7R7x8jA 1yF64g== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghtfx28fx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:24:27 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-399311947f6so6502636a91.0 for ; Mon, 07 Sep 2026 13:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812667; x=1789417467; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cSW22gDP0aHXM9uYQ6GNqbB9X8L4peq6obrroaX1pIE=; b=fT/0u1zaIOyGUpe8QJCzxmsnrfRTk1cjxMQ8Y0xbqqc8T9g73Mjjk01DcihlTyAP4E lrS4nNAbtvSfN7ChKTpinXz34G1Bl7YZoq2zP2Ta6WGs7ju4MDIsxOW2fYGcaTsMhJEZ C0NZEYMhiA8YMSOni31wSYhXLbY1/KgsgHlZHw3YgaDmkrAAsKNiSQ16EurBVrZLTdC+ hjDkoPEgye5B0XYJ+0SjS4zBujOuB/ggmcRKE1MwK5lOJes723TATw/7pUZkrpDvZJS8 yJOg67i5l9jFXGMHCFHuB3wlzzXY/pfGBfL8lVWiHYgAnb3Jsf2SxPNuYQIq+3ISl3E4 YaxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812667; x=1789417467; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cSW22gDP0aHXM9uYQ6GNqbB9X8L4peq6obrroaX1pIE=; b=g1txztrcv2op+nuvo/4E9yzKU8rD0VMCkViZBJTMc/FTqiI/doeZCuyVxN0Beg9Bed 1MIuuqN+YT11ZcuSGcEAuZiiv0Mc8GDe+KsqtsqWk8EB4IRx6fhb/KwjPiIO/SXJ1cBI AOCk8LfyYUBVfrJmNHPrstaiHX/BwmFL55QksnLJy7N1SKUnrCWyGSuFw6QOcX3VX7cV pjc2qYMIt4GSYUDT4CqhWNTCVyIZdbfjYdgAm2GLlziiUk0UMZNhzcdHEk1WTkYdI71O xXkZmL6CBYnYhlicYOHWp63v4hF5FUjigGNAew+Z5Y2sBF3cUhY/ixlxgzbSHhr5A6nY h/Aw== X-Forwarded-Encrypted: i=1; AKwUvBwcGeM+uDXbTeebl/Xw+bG4tlwcaW5ipSattWj+ti/jiZJm1FWDSWaEBH/u/qsCgl8osqQYVv9pUvyxphY=@vger.kernel.org X-Gm-Message-State: AFuF++kh8sm25rodxdFGzySEh3GRLcqQRWZpJ7E5eg0/VudgcyDblrKd Vn643zXKRCFo6FH8/CsiMSGnfPEi2FBTauBf4yLqkohdNsZSX6TGeQttvWCoGHm33oraU43Rx+a XHxFuTseUtX6ALXr3IGiZtyump6G79d4DSEddxsNn/qJA/5oA8b0ILF4hPAtgRx52GHI= X-Gm-Gg: AYBFou1qNQCZaPzbx5YyXNgHOQwXRhfGNw6qiTsnkcKWwnzz9opCnPYEn4qZtdrQXR6 0roFBmdAOF0QdCMhnZSSYAcY2UgztNWJuZOlQKLo71AB0NWrlxOuAQYclmEVsp18Jz8CcloQfUK U+uVPlLxBhrbO/JmnYCCgIo/g1Kj6MSp9uC5iRN9K5JzHGOkXnf7qzLoksxy+/m9h6WU2JLe66U DPxW4za1ZLW9SnK7xStiwxu8ESbouEQ/4lhkTunqiyX6NlZCSlzVmwQ2njJLCdN6KfeWzllca1X 3lDgXdvqiCE3aOkUmm3M/qxpGqiwdswWnqdm8VkdIU9UB5FBsuNRfV+ASTAPAGYaBNjJj8S0dSq V4fGV+U6hmSf9CpOcmYqXgtq92nXj0A== X-Received: by 2002:a17:90b:280b:b0:398:c315:fa6f with SMTP id 98e67ed59e1d1-39b261cfebdmr34880040a91.14.1788812667215; Mon, 07 Sep 2026 13:24:27 -0700 (PDT) X-Received: by 2002:a17:90b:280b:b0:398:c315:fa6f with SMTP id 98e67ed59e1d1-39b261cfebdmr34879983a91.14.1788812666696; Mon, 07 Sep 2026 13:24:26 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:24:26 -0700 (PDT) From: Mohd Ayaan Anwar Date: Tue, 08 Sep 2026 01:53:17 +0530 Subject: [PATCH net-next v2 5/9] net: stmmac: qcom-ethqos: fix RGMII_ID mode to use DLL bypass Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-shikra_ethernet-v2-5-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> In-Reply-To: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=4883; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=H1FwwnCAzH++7RGqPRMDkA7lx0MXBiHM+RuBRtHZzLA=; b=rz5FzNCKy0hd45LxMN56ldZNlxCT9C+l66wapiVjvwVNMp4Wb0CADNuNN+/vQqvusiXsWP5nZ 2qR2KLNcUABC/i79ckJMTAgQrKraAz1CKhSKic/CFTpMB7eOlwdN3M0 X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Authority-Analysis: v=2.4 cv=Weg8rUhX c=1 sm=1 tr=0 ts=6a9f1d7b cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=ctJ5fWpjfrpFC8ASC0YA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: L3ZOEF6dhzUOoh_gnFWDHrjLuT5WQUaZ X-Proofpoint-ORIG-GUID: L3ZOEF6dhzUOoh_gnFWDHrjLuT5WQUaZ X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX2OxMYWeIur12 j+c6SJZtk39fXAboqnd0HcxtrNvPVX9ePo5a+DXjgcLF0iQtlp6AUfOV0cEwxHPsQmrv79/64ZI sBO1WCHPEiVrucVYW69SbBs9YqDbt2w= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX63DlXmSra3Lc 5uXYcg8bkr1gQzz8CC+1aABsC8LE2Ly61MqN8I3osj9YTLRiCpQBSg/NyfoAcNpIMJ7dAUnX2ng qKzBEqkRpr7WNhfIBkTOMvpRrKHT/6yu6NIMzyBDChcylHjIhCy85VBcfQJGEIBBc03erjDHosm rkB8S2i2SpKlBJhCspgzEDNG5M29lE4VOq2s6tMgtywRTP5xuk8kftstF5yDnpUPqZVIMpHH1SO S6OeGB6WcmwUyJRMldARfao5QB4hySBAPXYgnrw+Zv7fnR+UI2MwfAzsjGKxloQE5dUmZj4ITob kaCLYKAUyRgY+Aa6uQc2YxO0wxxkQaSvCgNSGomDDnPIlxrrG4EPS20shGPMfduHLbRV0a90aPg 693mOYXJ6GqpvSBmcklzyTAt8kHpL6gYxSH2fd4GD/5rjGuujtbDfZ/f6xVM2uBfKcxV4aVIJGC SzwACkIUyNgdahrmnSA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 When "rgmii-id" is selected the PHY supplies both TX and RX delays, so the MAC must not add its own. The driver currently falls through to the generic DLL initialisation path which programs it to add a delay. Power down the DLL and set DDR bypass mode for RGMII_ID, then program the IO_MACRO via a new ethqos_rgmii_id_macro_init() helper. Also fix ethqos_set_clk_tx_rate() to not double the clock rate in bypass mode at 100M/10M, and remove RGMII_ID from the phase-shift suppression in ethqos_rgmii_macro_init() since RGMII_ID no longer reaches that path. Signed-off-by: Mohd Ayaan Anwar --- .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 67 ++++++++++++++++++= +++- 1 file changed, 64 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 44270c25d874f72e7f971757fec659d36468c315..53fb9de4d92c7f1b3c51c183064= 024f06150444d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -67,6 +67,9 @@ /* SDC4_STATUS bits */ #define SDC4_STATUS_DLL_LOCK BIT(7) =20 +/* SDCC_USR_CTL bits */ +#define SDCC_USR_CTL_DDR_BYPASS BIT(30) + /* RGMII_IO_MACRO_CONFIG2 fields */ #define RGMII_CONFIG2_RSVD_CONFIG15 GENMASK(31, 17) #define RGMII_CONFIG2_RGMII_CLK_SEL_CFG BIT(16) @@ -183,7 +186,15 @@ static int ethqos_set_clk_tx_rate(void *bsp_priv, stru= ct clk *clk_tx_i, if (rate < 0) return rate; =20 - return clk_set_rate(ethqos->link_clk, rate * 2); + /* Clock Rate Requirements: + * MAC added delay: 250/50/5 Mhz for 1G/100M/10M + * No MAC delay (DLL bypass): 250/25/2.5 Mhz for 1G/100M/10M + */ + if (ethqos->phy_mode !=3D PHY_INTERFACE_MODE_RGMII_ID || + speed =3D=3D SPEED_1000) + rate *=3D 2; + + return clk_set_rate(ethqos->link_clk, rate); } =20 static void @@ -405,8 +416,7 @@ static void ethqos_rgmii_macro_init(struct qcom_ethqos = *ethqos, int speed) RGMII_IO_MACRO_CONFIG2); =20 /* Determine if the PHY adds a 2 ns TX delay or the MAC handles it */ - if (ethqos->phy_mode =3D=3D PHY_INTERFACE_MODE_RGMII_ID || - ethqos->phy_mode =3D=3D PHY_INTERFACE_MODE_RGMII_TXID) + if (ethqos->phy_mode =3D=3D PHY_INTERFACE_MODE_RGMII_TXID) phase_shift =3D 0; else phase_shift =3D RGMII_CONFIG2_TX_CLK_PHASE_SHIFT_EN; @@ -475,6 +485,42 @@ static void ethqos_rgmii_macro_init(struct qcom_ethqos= *ethqos, int speed) RGMII_IO_MACRO_CONFIG); } =20 +static void ethqos_rgmii_id_macro_init(struct qcom_ethqos *ethqos, int spe= ed) +{ + rgmii_clrmask(ethqos, RGMII_CONFIG2_TX_TO_RX_LOOPBACK_EN, + RGMII_IO_MACRO_CONFIG2); + + if (speed =3D=3D SPEED_1000) + rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE, RGMII_IO_MACRO_CONFIG); + else + rgmii_clrmask(ethqos, RGMII_CONFIG_DDR_MODE, RGMII_IO_MACRO_CONFIG); + rgmii_setmask(ethqos, RGMII_CONFIG_BYPASS_TX_ID_EN, RGMII_IO_MACRO_CONFIG= ); + rgmii_clrmask(ethqos, RGMII_CONFIG_POS_NEG_DATA_SEL, RGMII_IO_MACRO_CONFI= G); + rgmii_clrmask(ethqos, RGMII_CONFIG_PROG_SWAP, RGMII_IO_MACRO_CONFIG); + + if (ethqos->has_emac_ge_3) + rgmii_clrmask(ethqos, RGMII_CONFIG2_DATA_DIVIDE_CLK_SEL, + RGMII_IO_MACRO_CONFIG2); + else + rgmii_setmask(ethqos, RGMII_CONFIG2_DATA_DIVIDE_CLK_SEL, + RGMII_IO_MACRO_CONFIG2); + + rgmii_clrmask(ethqos, RGMII_CONFIG2_TX_CLK_PHASE_SHIFT_EN, + RGMII_IO_MACRO_CONFIG2); + + if (speed =3D=3D SPEED_1000) + rgmii_clrmask(ethqos, RGMII_CONFIG2_RSVD_CONFIG15, RGMII_IO_MACRO_CONFIG= 2); + else + rgmii_setmask(ethqos, RGMII_CONFIG2_RSVD_CONFIG15, RGMII_IO_MACRO_CONFIG= 2); + + if (ethqos->rgmii_config_loopback_en) + rgmii_setmask(ethqos, RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + else + rgmii_clrmask(ethqos, RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + + rgmii_setmask(ethqos, RGMII_CONFIG2_RX_PROG_SWAP, RGMII_IO_MACRO_CONFIG2); +} + static void ethqos_fix_mac_speed_rgmii(void *bsp_priv, phy_interface_t interface, int speed, unsigned int mode) @@ -493,6 +539,21 @@ static void ethqos_fix_mac_speed_rgmii(void *bsp_priv, =20 ethqos_set_func_clk_en(ethqos); =20 + /* For rgmii-id mode, the PHY should add the required delays. + * Therefore, power down the DLL and program it in bypass mode. + * Program the IO_MACRO as per the settings recommended by the + * programming guide for bypass mode. This will ensure that the + * MAC core doesn't add any additional delays. + */ + if (ethqos->phy_mode =3D=3D PHY_INTERFACE_MODE_RGMII_ID) { + rgmii_setmask(ethqos, SDCC_DLL_CONFIG_PDN, SDCC_HC_REG_DLL_CONFIG); + rgmii_setmask(ethqos, SDCC_USR_CTL_DDR_BYPASS, SDCC_USR_CTL); + + ethqos_rgmii_id_macro_init(ethqos, speed); + + return; + } + /* Initialize the DLL first */ =20 /* Set DLL_RST */ --=20 2.34.1 From nobody Fri Sep 25 23:10:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 561D4431E68 for ; Mon, 7 Sep 2026 20:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812680; cv=none; b=q80VeaPt6dY7lgJnyMoMVVBp8MjKGA75kLOFrLgcjT0/qwoWJwGZC9bcsquGElxD6NT0bpntJQ7cj0zpwvmH4USxGGp8UomdqMQHpw6kSa/sZaKC2YFF46BWM/FF1czV55pI/di8B+xSmgocmdcpbvDgbj0oE/MahOkMoawB3YQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812680; c=relaxed/simple; bh=OvmGJXWTrtFVyiq8kkMO2myxFyrf9kt4/dp6hHNffZ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AUibJhbMWkMAaSdRifbMyCc4KNVL94FnVaVcfidjquwx1u2rijFREjaihvI79ToUoXvQuSSG2OIU9fnL1j8hJAtGqVwIgDA24k+isHAnkdsYaZkttB+4uDY3FVpajemKXA5cYxKVGZOyvBUp4dTOnWgRGqpI69S8FNbs8aCq1yo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AI5J/Xub; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NValjlwZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AI5J/Xub"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NValjlwZ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687HWTWR565741 for ; Mon, 7 Sep 2026 20:24:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +HYeP9I0GCFZQ5ANdwKliPovJIbIMV4i61aW+Ci2/bg=; b=AI5J/XubM63NeOJ3 Q0bl4Hg1WHZkUSuOSn8ZBIYajlndQ972eHqh4oLnplJDTzTB0jiFrdTRBjwWFKs8 2sC/wg6jfndPfvJhPSLsXWpKIA+E2Tx96s6QwcewE4roBSavGwIHxXsRd3+BjiDE ayrmAyYnFn2vsH25i5YtTmz4PYGNQU4sTHkgCDkqELzHOYsEKK+q6x+b4nHhrkw6 ioeeJ31U1m/qXh3F7/3Sx5Jh9IBiBCFX1XSuEYIMt+qCS7/8fiWGHvkL+17UdBqf CV40sUX4mdlZ+dTFwaWjHgTV3uOw054aEcVSHkFrEVcHw0uZTEzcXO9B9TzdAdfU le6LkQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gj1rrgetf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:24:36 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38dbf293831so8012893a91.3 for ; Mon, 07 Sep 2026 13:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812676; x=1789417476; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+HYeP9I0GCFZQ5ANdwKliPovJIbIMV4i61aW+Ci2/bg=; b=NValjlwZXROs6gl0LVzpx09KIxUxhc3vi76jkHenTRvIY8GlBMhXoQRNjXJWzvzd9s ymanEv4LWfybwamYdrZf6Gpdv5EyjAwoLrK9lOgozNhl/iFuiqvhO8+3hnks32jmzFF/ BUgYt7Ae1u27HBOQGtS+a13oG0WWOOcnhtzdbdghRNLDujSHu0EiWRv2HJm//GhvuwZp +p5xRWzx5idHD6nNuISsNFHZF6n5+y2QVn/FX8Fc5IQr3m9klQHZN1RUZSdT37PS7Vai rpQ/VDWA3SAB5zYm9GWiz0Tc5bUAIoQPcg+LBS0GBYZjNk8krw/O5wUMQtIAT7FI2Guc AXwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812676; x=1789417476; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+HYeP9I0GCFZQ5ANdwKliPovJIbIMV4i61aW+Ci2/bg=; b=AR5pJmT5XiguHX+Z0NCBrapfJfPKGBD3TjzVnsshc0sQ8rwVT+iLDSC8JDYkAYJTDE v4WBJ2ClmMtjhDXrLqsJ6iSILxQlHOuR3guSzrtHhcc6Op81Ej+wwBqN5VlFW9etrOEb NCiA3giaEXiVnFDwdj18A+kUPa1mTjG2GrlQR9y619sryGVTI2CHyZ4B10jPcUHLRtMz NBw1gcCJAcIaIqltrJq8rPuE2acwxqmrAVUX47a06ltTWhtabIRkZGK0MYOkUqgd2DI7 XeyOUl/n75H+GDM33u78/BooRKL/YhtiL4eUmSj9KGkdAgMLrcVKBJ4/+Q7HIPe6QYPq hthQ== X-Forwarded-Encrypted: i=1; AKwUvBwmVGUDImSSJNz47k2M2Q1c+mbHxkrPGDwwEoLcs34NDiMCDQryknx6aRpuMzlOU6450ioyUKD6LoF3juo=@vger.kernel.org X-Gm-Message-State: AFuF++kRgRakUMqZIOBHe1mvkwFVFVC/rW6bkporoRWF2RINciK9k5WM 11kjv7gfzJ66miPThhxRWWCaTz6am5HdeOUJ0FnrcRvdqI1upPO2jDMzqFo7tc1WT+svk4Ypidr kEbhAz+EtwDNZwG5mG1sTEMIaUXXxvNWcEYhwQFopkMDyH59JiOmDOl3qJdk87dVzY3Y= X-Gm-Gg: AYBFou322ZTjvUSg/Uj+dUq3Yidz3cT8q1hMbcAhtpiN72uDpiUaHnfYGocT4BfyxS+ Em5fRAzfXbuGXDbCfeVLDkJweXpix3s5V1ZlN4xIWmmqC5KIdwDWzEEuFzL6qDZmrrhVFCVSE8U 1gOQs1SjmfBqbFIF2T0Xq8uZYlNUqTR1M4TcD/fHFv8yZLpD1QcXyRFzHn6gcowcOSOnJXpPuu8 u1beYTt0DLYf5Wdf/kxPo6bpxZqwkmh/1X5+vAlWcCPiVQMQ+lrb9Wk+eoFc6/rePk1bRqvCRze lHVQy6YqVbBJcr/6/QS1s9W58EWT+95pD5wEyPQpotI60nc6XyfFkYgSGzjMgfXSYzh6oWYKxMA mnsDaFlQzPXMZ83TtlClNBzid/NWZGw== X-Received: by 2002:a17:90b:268d:b0:398:bdb0:adb7 with SMTP id 98e67ed59e1d1-39b261e1beemr40352047a91.16.1788812675469; Mon, 07 Sep 2026 13:24:35 -0700 (PDT) X-Received: by 2002:a17:90b:268d:b0:398:bdb0:adb7 with SMTP id 98e67ed59e1d1-39b261e1beemr40351940a91.16.1788812675029; Mon, 07 Sep 2026 13:24:35 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.24.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:24:34 -0700 (PDT) From: Mohd Ayaan Anwar Date: Tue, 08 Sep 2026 01:53:18 +0530 Subject: [PATCH net-next v2 6/9] net: stmmac: qcom-ethqos: warn about legacy RGMII PHY modes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-shikra_ethernet-v2-6-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> In-Reply-To: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=1435; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=OvmGJXWTrtFVyiq8kkMO2myxFyrf9kt4/dp6hHNffZ4=; b=gZT/4dzpGgbBKDcmTineyWKwhP2SiV3nr0psphFKz3N/i048ZPv6oxaDasRhwQFJ5SZTNwxcI osJt7ozA19pDbpIWJx+1zSZf5asWNRUm1a7D4FQHFRm3p+DbT2ldB4N X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX1o9pb3+TC2LF eAYl6nrmCdm4TPTuiG/1a7AxRIqJpn5T0a115THyd66B2kZ0wJj6ZZO0MKmILxQj2r3uM+sdiR/ XR1RTSytlYf32Qskbo/7qWAr4K8tMZQ= X-Proofpoint-GUID: Llqku5J5TU-pd-nm6JncyQBtOe76M9AF X-Authority-Analysis: v=2.4 cv=NsjhtcdJ c=1 sm=1 tr=0 ts=6a9f1d84 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=VSm8jR0bnqFplKljzc0A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfXyAU8TcYpi1Ve DFzcvmPiSiVvwFUF+cGuRkxiNuwd5IhdWGTanAe/9/CgVocxJlzy8IYpd0DAgO5yQCf9FgPZ1KZ A8iV0qfk2e6Yy/tUz+aRKgKa8uHkrqHrbnfioPRiTmCtEGEy7dsj/4hOHno/lsMBPtazKeuL8Zl aSKlJvd47C/Pn8GJUrIAvjJhnkrhYcXfEI10q/GoyOuHuI07m5MG7VjHpaoiw4fIMel3NzhdN6p d6p1Sr4EKFFHqoN74R+l4OkPOfmXRRGEMdqfEuEbdj6uE1fqelqrWIFhTrOeqidIrCpLEUU3kGU 2RfOBGQokZ0SZAp0hIgg911koN85ycShreec0zT138pXU/FvuERf5ZAMOSTWxPyYu5/DCd4IRwp c8YEwee2iwuhDghYeCav3dLHWW4MgpQ1fhyXlbxVe7ib7CT8w57PWz2EcNIsEl/XiYs6FAc6xTo ejxcKArW8gaTr7pdBHg== X-Proofpoint-ORIG-GUID: Llqku5J5TU-pd-nm6JncyQBtOe76M9AF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 The qcom-ethqos driver is moving towards using "rgmii-id" together with PHY-provided delays. However, existing DTBs use "rgmii" and "rgmii-txid" and must remain supported for backwards compatibility. Warn when either of these legacy PHY modes is used to encourage users to migrate to updated DTBs using "rgmii-id". Signed-off-by: Mohd Ayaan Anwar --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 53fb9de4d92c7f1b3c51c183064024f06150444d..a92bf4a6a2dbd987893bd4a3890= df770bb7a7e56 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -764,9 +764,11 @@ static int qcom_ethqos_probe(struct platform_device *p= dev) ethqos->phy_mode =3D plat_dat->phy_interface; switch (ethqos->phy_mode) { case PHY_INTERFACE_MODE_RGMII: - case PHY_INTERFACE_MODE_RGMII_ID: case PHY_INTERFACE_MODE_RGMII_RXID: case PHY_INTERFACE_MODE_RGMII_TXID: + dev_warn(dev, "legacy RGMII phy-mode detected; consider upgrading to a n= ewer DTB\n"); + fallthrough; + case PHY_INTERFACE_MODE_RGMII_ID: plat_dat->fix_mac_speed =3D ethqos_fix_mac_speed_rgmii; break; case PHY_INTERFACE_MODE_2500BASEX: --=20 2.34.1 From nobody Fri Sep 25 23:10:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 330374CB8AB for ; Mon, 7 Sep 2026 20:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812690; cv=none; b=N6WYNFh6krK8o0J9vuMZ4U6+BaKWfdmno8rO4lS31nsZCkma95Zk4zAcvO3MLoIRsUrzpSEL7yCb3k8+m5UjR5k6UOUjAvNHRakmztlpYGTEBUqyTfW96tuzt6QrpbA/pkIdEgM4juasOG5s7HIa9THyJVWNS3rIjqpt4MeicHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812690; c=relaxed/simple; bh=lnIs5iGMJ1/TyrszL3HdmC9OvNff74ciWiwlTO04duY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YO+ozgCT6D6kpuESua8NsAoyb2I4t04zGvAOpWIBNCAlk4iE4TNO9xYm4SF2YgscSOemqVZeDMc+7ZPnJHbPOHWWASjXJtBpFYH3Mm5/vzjmCOQKlaZtnIUIdQYHZ17B7OGRIg+hCUM76m8LwCGaz7BrkhkTfWLOljkshRqbRc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XfBO1OeD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VObA1KbF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XfBO1OeD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VObA1KbF" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687H7waG1314987 for ; Mon, 7 Sep 2026 20:24:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +JaG7DKTSi7xhDFXHxjPdAJJFng2xHhnPLV5SDhTiMQ=; b=XfBO1OeDaI8C8yE0 nMeDOlsvy9eWugwFQNl++ShzxFd/G/y2X2kxXGh4JfcPlC/gdaPLdvswvM5S7iKD XDpEj7k9esOziJqN3xCslzyTcWCKh4gTyGJhSFOXq8Jj4VTFzVBjgiheDjCtMpQ5 IazvdXSZtSj67Uo5Oe368CLMrXbUh3IybztdeJ2vYQ52WpoIfo9MWPnidmQBFMN+ zxewce3cJaZPR8z0j/CNABPngsvr9KxGgNr4HMfDuTJl55heBScAealMO0czB5dX 2n0HHdotg4BLQiMPraZMkSRYqrD/pYkq1I64CQzbGiw9VPkCz5iKvWqWXALfMpIQ ZBusoA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghuyk9uwx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:24:44 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2d94f086fedso53676195ad.1 for ; Mon, 07 Sep 2026 13:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812684; x=1789417484; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+JaG7DKTSi7xhDFXHxjPdAJJFng2xHhnPLV5SDhTiMQ=; b=VObA1KbF60AVm++QDTG7YVM27UPp1YUI+9PticX4boPkVUQm8nQge7m6gyTVvNwEJR pQbYJ/7eO1BKq4VqVAGTuXIN6rH90QK398KgvNVSS52sq23ezksmAvABYWpaDBJb0Pyd /9mh4DkNNK0BIq7a+J43Z2FZ7dp9Ej3w6LbqFFcD4SPp/JV1njisQC/jvkAd9t6hJxC/ sbsY4FKGf0ji77NUrvJjZmCpFtnudzf9gMvT/gcJHLyZ/zxE5iMDAdLy0EXaagHEwibH 3Ph7d7HujsPqa3ntz6sUdJvh3BpYq8rDd8DX7eYvyc1VTNWKTiawogBNDiJaO4uCkFJJ CmbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812684; x=1789417484; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+JaG7DKTSi7xhDFXHxjPdAJJFng2xHhnPLV5SDhTiMQ=; b=DUXQtrs1VaPwbB6UcAM0558G1I+k2snELgBqZRaJOwwigOLvmH3QYBWm1BTlKYpl9b kzcBiOni3f1FC73XlhY/+gbwES/mQrdmCRzPUiW4vpiye2SqR3UB7ofm0O6orbeA9cvD 9Gg6xQ0nlZwTTBPnTk0Wr9Rf1MGi1O1GKbhZuB4pLDdUSD7RWsD5m64X1tldtPTRduZ5 58kSohSGMgWFB8PRG/pRzh8ZPKt9r+wh4YvE35oITQnQZ/DuGJB6APUedyvDE8XAFIxz nfwm9Ue7xedeirRX7ZA6AAY+qKFvgGEkRAUnBc9s8IhDpiHdCKSiRn+1LJxBynCwk7NK HKoQ== X-Forwarded-Encrypted: i=1; AKwUvBwUQ2rFZqaNnwF11UYh9Sy2Ljjj6GgPwnBIJw1wDqhRpLsPcXq6eIYWBOn6D79IO+jYICqJEXYX/QEQ5ks=@vger.kernel.org X-Gm-Message-State: AFuF++nSI/4Kp+HZ0jBI82VUiP2R9s0HLRV6YTLGpmRnuF2ljRdOMZA8 J/UvV1o7Q2Pi7JlKKoHvuDSJI71Je/qSEKrniuwLMSyN/z+PhMtU1qMasm8ko5jEjd4qSK8LgT0 NHwutsmRPojfc9FrpxSMpAY3qvH0zrU0QQDXYy2uXgVi6pq7+msWo1Bh8sgQJqSsQoHlDaYaiqa g= X-Gm-Gg: AYBFou2ZOTy2Jt+m8tHO4u0UyRAF+VuOHGIWabyXjJpY5o5Vl+aNrx/WpmvVTQj8n2Q KkxiIJumAItt6i3Egjh8YKpBRw/vK8+yJ4vubyuwc1pMSg1r9m4ow9Wgsk6Z2eonLc2sb7RAay6 pGKVK+wPJLh0YY1C89nEzgpF97Gwu4DwWht4IHjXuYCOJqwNMr2DHtsLabW0llfPwt0OU52fo9d YbSBK3QPBqTCQzfsq2R/maf0mPrvlViZ2Vs7pfrnWwnZAJ7SopV5AB3ecK2IuZ2eDYEfVduvbYW c8SX7fFlxWPAyPSk2ig2FoL/cNC3DoZJO652HRh0hxHcyKbrIuBNmDvqsxXVMyy0seOdQ0fxxEk h3XT7H8oMAa7jys7wxh6BR2r5onrByg== X-Received: by 2002:a17:903:11c8:b0:2d8:d4de:fa80 with SMTP id d9443c01a7336-2db1235721dmr345681825ad.4.1788812683844; Mon, 07 Sep 2026 13:24:43 -0700 (PDT) X-Received: by 2002:a17:903:11c8:b0:2d8:d4de:fa80 with SMTP id d9443c01a7336-2db1235721dmr345681275ad.4.1788812683356; Mon, 07 Sep 2026 13:24:43 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:24:43 -0700 (PDT) From: Mohd Ayaan Anwar Date: Tue, 08 Sep 2026 01:53:19 +0530 Subject: [PATCH net-next v2 7/9] net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-shikra_ethernet-v2-7-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> In-Reply-To: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=1202; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=lnIs5iGMJ1/TyrszL3HdmC9OvNff74ciWiwlTO04duY=; b=PlfItwBPYCNw7E604PKTJ17SgNiJIFuqKR0zm4aGtFG1ZqfCDUXoVzeUencwPv+khFYTEm8U/ eKLk0dGU4CQAJ1XjFA1wGqgeMRDsFUVkiV43j1CRG6ATflSZwIqafK4 X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfXwPhc6JDidRFm A66sXPcXBn5sCWE+HkTgP9ShTEoswBMNT/UIj9ld3PU4Uu1mjVzPzVkVLcjM/ePLhoA0ZgUMQa1 UwaxWSdeMyww8CWaXOv300tjc4lF7uU= X-Proofpoint-GUID: bbaxGafFsjkMUXeLNbpl4HMXzePXdk87 X-Authority-Analysis: v=2.4 cv=ObSoyBTY c=1 sm=1 tr=0 ts=6a9f1d8c cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=oGeBSM6iGANWI8Y-5VEA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: bbaxGafFsjkMUXeLNbpl4HMXzePXdk87 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX0s/rVfI1SWLK cqxybyFMZTbp+9PZULBAWsrN+5jnfGB2PmjqQGkb8WdbYfKew/a45XXVFYRD+0TxSPccVkAQ0s2 USfi7JgMXe1LrBwM3ySZbpEnZYvT9MrMzdjoLElFHyphyci35wa2Kvv1LOv4U/cJi49/1++DJm2 hM6kWCeABU93zR0d/H8ZlsOsSzau2gEmHVl4YXvf+b2PxbmTjPFDzW9VVPuV8x/opasQrviHJXy +vtM+lrf+zH4ZUmGExMPY2Fs1AEjkOasK7P40QvH+gCTiGKThHicHwG7h3btBe4P/LZ/q3Q2ra5 ATu9085sWJh6894w9952/aGXpq5RfA41N4rwojX3kLDBSXEQ6gUeIPn3CwYIVTKxtGcmWmHaT1p vVnhMcv7KwazuAh3H+Rm4E6VVGtg/v1C2uofLQJirmFfCHlpwhc3/eUlTbhTz/1fNf+HbFC53wS XEMTSbiQjOQR1ZEY8xQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 On probe the RGMII link clock is initialised at SPEED_1000, which translates to a 250 MHz source clock even when no PHY link is present, drawing unnecessary power. Initialise at SPEED_10 instead; fix_mac_speed updates the rate once a link is established. Reviewed-by: Maxime Chevallier Signed-off-by: Mohd Ayaan Anwar --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index a92bf4a6a2dbd987893bd4a3890df770bb7a7e56..2471871562ed9915398614d5c88= d1c6673829db8 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -814,7 +814,7 @@ static int qcom_ethqos_probe(struct platform_device *pd= ev) "Failed to get serdes phy\n"); =20 ethqos_set_clk_tx_rate(ethqos, NULL, plat_dat->phy_interface, - SPEED_1000); + SPEED_10); =20 qcom_ethqos_set_sgmii_loopback(ethqos, true); ethqos_set_func_clk_en(ethqos); --=20 2.34.1 From nobody Fri Sep 25 23:10:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754D54EC647 for ; Mon, 7 Sep 2026 20:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812699; cv=none; b=Sk9mT4a5yPguMluliorrciAdRwV+6mrF7bGisYHkfdMwkpsClzsFze9yLNt3w4wm+ZIxeufMBnmCO+K5wsPpaIaxxiogUnLQEJN6XJKWyUI5rZRaZyg7vPAWz5SkB7IC+pQ0Y6U7XAKhUUWOE/Rb/KzPjMWfzsWObWDbgj+5yDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812699; c=relaxed/simple; bh=lKQMPlISxVjQ0B3VRRfDDxS4lZ4Pq36AYneIrLWTVa0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ukUXtpyodC1P3MKDlDWqppA7ezEBl1xV5Pv/lRjBy6kpRZx2+e3TtsPSyrKIEH8USaTnlLYfAdpXxjoIHhEbogWz7mgL2Sfje0VQdMEYN+8Fxb0r+uUF77444eRO2/IMcyeaKvshyVucVgbwF238YZyWnThm+LUHDOO5WJgehlc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fq8CTt0/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ib4O9iI3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fq8CTt0/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ib4O9iI3" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687H87974183553 for ; Mon, 7 Sep 2026 20:24:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t3omiMkZWtgzaHHRt1sFImgBtpza9a0r1HxxkeHWh5k=; b=fq8CTt0/rfiOYHVQ QSGtjR/Clx7j3W0tx/g11l7kYCgJu+Esjpy3lz21RxIdEgCslX/AGWbPMVwmwRlE Sdg7/TG9CFrU6qOvETH8qBdmrL33rlkDywZNvjTRBEXrfk0k28KR5x+cBAPXLzVm HNhVuA8kxQxJCcHLOKUFarXqESXMValUWhXq7q3P74WV2YUX0LUr/qH8lOy2NlBa cxKuWOQSMJbKJLlIrAOIwKkPwYMCE819yX2dy6cLAI1BzV+ME0XVPPDyCgd8qZR7 IjQRAdrE9zyhJPMmi8LE8baHO+3LbDJ9KB7Mcbw9ho30Lggw1Wp7M+W/XwnMCp1k gdHufg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghtfx28gw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:24:52 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-398d292eac1so8104741a91.1 for ; Mon, 07 Sep 2026 13:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812692; x=1789417492; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=t3omiMkZWtgzaHHRt1sFImgBtpza9a0r1HxxkeHWh5k=; b=ib4O9iI3xuqzrMQe0QT/NF679RX4xsjE4l54QyDoBg4Nv5qG0xmBBEA4KO+uD3xAKR iWvh5Rk3chOqkqUSBjyhwGuCHGYf0sZRn2ZZbfYqkAiYTmVWxj6pebE7JB7sU1dUnEAl 1EodyehxlgUwJiEl3kj1j6D/t9pSkdPSsOExcmQNPEsF6tZUbEfUsGaNaZCNpKrMB7vK SbMNMKlJy/MUyVysLdJl7iQ8o3PatnIFnW0WGd/kxIGtrCoX/MxHvCNSRmd2fMi5Zmn3 Y1OFnLGcEW1VdnhWNEoaMduVXffMuf84mcnb6ClFWQfNka2c3aYRejmLkYcDPrIxvBcy 733w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812692; x=1789417492; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t3omiMkZWtgzaHHRt1sFImgBtpza9a0r1HxxkeHWh5k=; b=Re23a0pToOyhhtqCz9X69yAC0LGRBPy4u/ZOkXyPsqUPSFO5YmIGztX7Y/8hVFIbzS npS0X2SsSbljLkiqd+SnIvDOTEznXk5mvfptDpzev3+77m8q3keVj4JZj2hvXej6eF2u +pcHQUUuhfILxFXNSzrEQh5+WePtPlJfpW6BdeL0hwqhHpFdyt5YVOtGeUESkYAHlXMH 6Nn8hjSCTvHoUQsluaQuTo3kTknNJwG8ZVeZTGpci9cQIAnliwoYTwjpSExq0fGeVgvo nhn9YzTmhUzLkeQg+cn9u8f9txOdIhTCGacxYIrfwEE76BWJ1lWkvsZQmDp9KFpHGaMh 7frw== X-Forwarded-Encrypted: i=1; AKwUvBySOsVUgmUd+JaNF7Ek7Dslo7p4LVkzOSSnY7kGrUfqxIkCtP69ffnF/7YK/6QHcPxwyUPpl+7cDfSTEmE=@vger.kernel.org X-Gm-Message-State: AFuF++n7Avw4ZKxnpDI75SF4LI43+xkMThC4X2jz4YRFTu1GFz4niJ3S YEmB7hwJxK9ROo0tqPd2y+rdrCoybOg6v30jJCReDlDsjesgzUv2MM1LY7GHY1AY7riCeGaZxVs CcbyKpQNb/niHLcc4XnlVL1f6ToNhCrne8oqmqqgnBTDDl2pbEUWIw5I/gmv2CXNJuDqYsov4Fo U= X-Gm-Gg: AYBFou0shdwnHRYEDZMKeKqyzcE/nfVbZuQxl8fAysGh3nx/nZimMV9iOrAni+3mKo6 bmrdGWtM2vQzSD9FKkE84IHZPRZH9lHRadwBC21V8hmD1irL8yARs4zb1FJyziJibWiqn45bq+l SJdctI7IwwX3bwFDpJrXgIu5MU+s/lyhKYoM0pbUxKY77dq7KlI7qBDT0fDvQIZuSRw6ULb3ONc rsn07TFDocaYH7LVapnfkogOE/eZqic/hDNIPbUHEWfa9DKyI4cH65kAgJP+HgRmNcTqrutY3AX eHDGdcbW7O3l7gKZVNcMK3mpTZDT5+QA/uzGS0NekldsLKUTpy0v5oRucSk5SllGjgmCE5VOi+j b4k4D9csgV2lbpqxMpuoU64PSXWxrnQ== X-Received: by 2002:a17:90b:390f:b0:398:de23:9af6 with SMTP id 98e67ed59e1d1-39b261b216dmr36938655a91.15.1788812692195; Mon, 07 Sep 2026 13:24:52 -0700 (PDT) X-Received: by 2002:a17:90b:390f:b0:398:de23:9af6 with SMTP id 98e67ed59e1d1-39b261b216dmr36938594a91.15.1788812691719; Mon, 07 Sep 2026 13:24:51 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:24:51 -0700 (PDT) From: Mohd Ayaan Anwar Date: Tue, 08 Sep 2026 01:53:20 +0530 Subject: [PATCH net-next v2 8/9] net: stmmac: qcom-ethqos: add per-platform NOC clock voting Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-shikra_ethernet-v2-8-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> In-Reply-To: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=6498; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=lKQMPlISxVjQ0B3VRRfDDxS4lZ4Pq36AYneIrLWTVa0=; b=FD9Eh3b3BBC8+5eruwt91ntgGZGPwaLxcrjqWpb/c4z1D+jjsLiyHOSjy/TA7jPdlXslyKU+v PVh28r2jXSaDoUDm0Qrrpr/70G8RXVu4KBKDUnHKWbC/CpkZ0MDmHUw X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Authority-Analysis: v=2.4 cv=Weg8rUhX c=1 sm=1 tr=0 ts=6a9f1d94 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=EpEVno_IuBtMqvs2hnIA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: 4ILS3bMT47GR4LrZaY37vSoPM8Ozs2Qh X-Proofpoint-ORIG-GUID: 4ILS3bMT47GR4LrZaY37vSoPM8Ozs2Qh X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfXxqhZpxHamDEd sjf0q0H6kbet7AiWoNuRK3E+xjh21zDQYN6acVOZUUq7nmLGrcM7ZTLIWMX8c+sutL95do8GUKO l4tm9RC2X3al+QDpYS9NUmTg3kT5g78= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfXwscJ5RH7wZ31 iBOmErISo0A+hPbuJ+UsNFeu9dT3YQBUuZz34IY02iIEYjxQ0Ke24d2fha40X58FmNOHrtVQ0YN jOOrqzysNv3c+7r3/POx2lRp5EMw4yE09tLEYqi5HKG7dp+SO37VFoeYUUEV9CixTnqR5pwG7qN Gske0ZyFCCHWHbkGUPcMEZXaZ+daeVwhGa7sKo+xox18EH8q9ISBIxNO0Bqts9nmJ1Css1S7k2U 7jl2WjC5NJUrkBL7AsnMlHBfAVTD0ZHRIwRgFg8hH9au8SW93Og3VUhcuQvn8qxqCHzCeCZ6+zJ uApFRzWViW9KQg0X5OtWd5RpsgIi4TZDnGHppc9wNMewW9IKhoF76rSisbLZqJB0729A+YXKxy6 qLgtCjStNxspinEMUBdVqG9AApVwkLB07j3YkJc0O5XrRuh8bi85aazRwhPqMEo7I2vZpUx53bL DNLSimLO2OoeyZ/KfQg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 Some SoCs gate the EMAC's path to the System NOC behind dedicated clocks that must be enabled before the DMA can reach memory. Add ethqos_noc_clk_cfg and the corresponding fields in the driver-data and runtime structs so each compatible can declare its own set with per-clock rates. The clocks are acquired during probe and enabled/disabled alongside the existing link clock in ethqos_clks_config(). No functional change for existing compatibles. This will help us when we add support for Shikra. Signed-off-by: Mohd Ayaan Anwar --- .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 106 +++++++++++++++++= ++++ 1 file changed, 106 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 2471871562ed9915398614d5c88d1c6673829db8..8871d285941162c72e2a8f79d2e= ef915d9283796 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -7,6 +7,7 @@ #include #include #include +#include =20 #include "stmmac.h" #include "stmmac_platform.h" @@ -84,11 +85,18 @@ =20 #define SGMII_10M_RX_CLK_DVDR 0x31 =20 +#define ETHQOS_MAX_NOC_CLKS 3 + struct ethqos_emac_por { unsigned int offset; unsigned int value; }; =20 +struct ethqos_noc_clk_cfg { + const char *id; + unsigned long rate; +}; + struct ethqos_emac_driver_data { const struct ethqos_emac_por *rgmii_por; unsigned int num_rgmii_por; @@ -98,6 +106,8 @@ struct ethqos_emac_driver_data { const char *link_clk_name; struct dwmac4_addrs dwmac4_addrs; bool needs_sgmii_loopback; + const struct ethqos_noc_clk_cfg *noc_clk_cfg; + unsigned int num_noc_clks; }; =20 struct qcom_ethqos { @@ -112,6 +122,10 @@ struct qcom_ethqos { bool rgmii_config_loopback_en; bool has_emac_ge_3; bool needs_sgmii_loopback; + + struct clk_bulk_data noc_clks[ETHQOS_MAX_NOC_CLKS]; + unsigned long noc_clk_rates[ETHQOS_MAX_NOC_CLKS]; + int num_noc_clks; }; =20 static u32 rgmii_readl(struct qcom_ethqos *ethqos, unsigned int offset) @@ -689,15 +703,51 @@ static int ethqos_mac_finish_serdes(struct net_device= *ndev, void *priv, static int ethqos_clks_config(void *priv, bool enabled) { struct qcom_ethqos *ethqos =3D priv; + unsigned int i; int ret =3D 0; =20 if (enabled) { + if (ethqos->num_noc_clks) { + ret =3D dev_pm_opp_set_rate(ðqos->pdev->dev, + ethqos->noc_clk_rates[0]); + if (ret) { + dev_err(ðqos->pdev->dev, + "NOC OPP rate set failed: %d\n", ret); + return ret; + } + + for (i =3D 1; i < ethqos->num_noc_clks; i++) { + ret =3D clk_set_rate(ethqos->noc_clks[i].clk, + ethqos->noc_clk_rates[i]); + if (ret) { + dev_err(ðqos->pdev->dev, + "NOC clock rate set failed: %d\n", ret); + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); + return ret; + } + } + } + ret =3D clk_prepare_enable(ethqos->link_clk); if (ret) { dev_err(ðqos->pdev->dev, "link_clk enable failed\n"); + if (ethqos->num_noc_clks) + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); return ret; } =20 + if (ethqos->num_noc_clks) { + ret =3D clk_bulk_prepare_enable(ethqos->num_noc_clks, + ethqos->noc_clks); + if (ret) { + dev_err(ðqos->pdev->dev, + "NOC clocks enable failed: %d\n", ret); + clk_disable_unprepare(ethqos->link_clk); + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); + return ret; + } + } + /* Enable functional clock to prevent DMA reset to timeout due * to lacking PHY clock after the hardware block has been power * cycled. The actual configuration will be adjusted once @@ -706,7 +756,12 @@ static int ethqos_clks_config(void *priv, bool enabled) qcom_ethqos_set_sgmii_loopback(ethqos, true); ethqos_set_func_clk_en(ethqos); } else { + if (ethqos->num_noc_clks) + clk_bulk_disable_unprepare(ethqos->num_noc_clks, + ethqos->noc_clks); clk_disable_unprepare(ethqos->link_clk); + if (ethqos->num_noc_clks) + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); } =20 return ret; @@ -734,6 +789,51 @@ static void ethqos_ptp_clk_freq_config(struct stmmac_p= riv *priv) netdev_dbg(priv->dev, "PTP rate %lu\n", plat_dat->clk_ptp_rate); } =20 +static void qcom_ethqos_noc_opp_cleanup(void *dev) +{ + dev_pm_opp_set_rate(dev, 0); +} + +/* Some SoCs gate NOC access behind dedicated clocks. Acquire them here + * so ethqos_clks_config() can enable/disable them at runtime. The OPP + * table is used to propagate the required VDD_CX performance state via + * dev_pm_opp_set_rate(). + */ +static int qcom_ethqos_init_noc_clks(struct qcom_ethqos *ethqos, + const struct ethqos_emac_driver_data *data) +{ + struct device *dev =3D ðqos->pdev->dev; + unsigned int i; + int ret; + + if (!data->num_noc_clks) + return 0; + + for (i =3D 0; i < data->num_noc_clks; i++) { + ethqos->noc_clks[i].id =3D data->noc_clk_cfg[i].id; + ethqos->noc_clk_rates[i] =3D data->noc_clk_cfg[i].rate; + } + ethqos->num_noc_clks =3D data->num_noc_clks; + + ret =3D devm_clk_bulk_get(dev, ethqos->num_noc_clks, ethqos->noc_clks); + if (ret) + return dev_err_probe(dev, ret, "Failed to get NOC clocks\n"); + + ret =3D devm_pm_opp_set_clkname(dev, data->noc_clk_cfg[0].id); + if (ret) + return dev_err_probe(dev, ret, "Failed to set OPP clock name\n"); + + ret =3D devm_pm_opp_of_add_table(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to add OPP table\n"); + + ret =3D dev_pm_opp_set_rate(dev, data->noc_clk_cfg[0].rate); + if (ret) + return dev_err_probe(dev, ret, "Failed to set initial NOC OPP rate\n"); + + return devm_add_action_or_reset(dev, qcom_ethqos_noc_opp_cleanup, dev); +} + static int qcom_ethqos_probe(struct platform_device *pdev) { struct device_node *np =3D pdev->dev.of_node; @@ -795,6 +895,12 @@ static int qcom_ethqos_probe(struct platform_device *p= dev) ethqos->has_emac_ge_3 =3D data->has_emac_ge_3; ethqos->needs_sgmii_loopback =3D data->needs_sgmii_loopback; =20 + if (data->num_noc_clks) { + ret =3D qcom_ethqos_init_noc_clks(ethqos, data); + if (ret) + return ret; + } + ethqos->link_clk =3D devm_clk_get(dev, data->link_clk_name ?: "rgmii"); if (IS_ERR(ethqos->link_clk)) return dev_err_probe(dev, PTR_ERR(ethqos->link_clk), --=20 2.34.1 From nobody Fri Sep 25 23:10:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84F8E524B02 for ; Mon, 7 Sep 2026 20:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812710; cv=none; b=G5AL8MQ2oOoTpFU3C5mjAAOJoV/HZdiFMN5N94611SwQnWEnoKmfKl97hziHR0StmYFmDwfsPeMR5JJFYn+2ObgkP/IlU6USFFcdv7WvVCjBcXi9495/9OKSga/R7RhiPLlkdBjLPA7NpiWIDCVcdPg/VNVx/BC/yrTJhWwb3GU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812710; c=relaxed/simple; bh=KsLk75r2w7Y7Td996D/f1RY9lIMY3ClaAGPh1T4xOuA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IQcdbE1sBerxal+yAVOVfFv2N+JyUHDh9/Lxl2EBGuWHpDPmYBBE0A0nr6gVltia3xQTBvNfxZxKWePgw8U+sBBqEuM5hMUcvjsBg+l7otqwvoVDXlwD5GYUDm5zynw1XF8d4Iap7phoaVfLG2qYrG+8DhCHTQnVScYpTBl5uIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T4PlL33X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RHdNhOIG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T4PlL33X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RHdNhOIG" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687H7sbJ1642252 for ; Mon, 7 Sep 2026 20:25:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Hrvy+QoVG0RLYoH5IBz54YMeR8SjZQtO5lp7S4xTaVc=; b=T4PlL33Xk5zjDyxh BUlto0g8F5GJA1rMWVho56/UPhEgBpa/mWZ44L0nFhxxBesK6Q1CrjnoQPzPXzG4 UN4i5ePBHUpBptW4fo6NEjAkgiSt4uVx/YIu2NvRuGbLfUkv2V0x/K/Sds2kOS7u XzgMUGLwY8gRY5IpTY0kI0T8F3bdc/b+zXXIA2p6sXl6alBn4YeRtHuMeUQnSCMW xpzRJeCeuZB8wvrroUJpamTu7CwvU10JlSQyvjTaEK5dqC0M4QZUt32wSAuBnX/6 HyNGUiWay4EnOU5H4Roy50/BdILONCtYj5A30283rnN/EEO3mK0sNZqvI1xY+2ID rdPFCQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghruaawpv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:25:01 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2db3b126c9fso27800585ad.0 for ; Mon, 07 Sep 2026 13:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812701; x=1789417501; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Hrvy+QoVG0RLYoH5IBz54YMeR8SjZQtO5lp7S4xTaVc=; b=RHdNhOIG1Lsa2l4RsJoBmURkL3+B1A/rf7gGu9aaD9un4N73SfPgYpgJHJ1ROdlqRU l3DILlfI60grNpvrlEIw0jxcBUVzZ+SxWJWDSodRGYHPnsR7IVCUFjIZUX4L1cO35AMw RA7rsJAHikqfYJZM40FBYR5tKSiJy1BAGlKPS7h7IEwgE5E7oFiBsNn2Buf2IkXD/uMA 4biQFLZ2/0/zYPQIKdKrsKRcEssrxyrCxxidM5v2VTIGMN4J2+B+E4yZwXwifpBrFe8r LB2Z0RTayFMKoJ2kLAlrZ8FBL7+dyiH6b2bryT1FQAaMzJSP30OoLo0JybppqKWQbr6y HuYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812701; x=1789417501; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Hrvy+QoVG0RLYoH5IBz54YMeR8SjZQtO5lp7S4xTaVc=; b=bNnUcOFb9BGU/70Knvmzx0lava3I/ab6W/9N1P5aOC16J/H8GG06sooN6N6ZvXa+n0 E1Vh4RxfSYVHO43HYao4NKby7ysCiW3sfehqdHKgq7tjj0GxulrHXwbXwN4BYMLtBa/5 Y43j1AfAbyDle6K9DWp4CNexwn8HPH3n9sQWTPNa+dyEkg9jUYkrpVt1vzDiY2tTxZrP s6v0ckrM9g9cf0RAVJwRR+zGXUdaDGDK/ZY4jGIAsCn9/d9ACK/hF6ewHgPYaQ/sJL94 hYRHIxM3Ii70JRjPJmEm1ePqeVpfecRC3+ADjJsLaC11floCXXI4ibJCnXlyW6yZpllL d4IQ== X-Forwarded-Encrypted: i=1; AKwUvBxO4g8rdqDNWtg7RTkasgaXEL7fmzZDzQNGwrx90hVem8RzbwBcpFgvA2i4BUP7iqa7ggExxaOWdgCJWbo=@vger.kernel.org X-Gm-Message-State: AFuF++neDFMR+UGPaUnfdsqxtP0g9LQ6OlS119hhwqIAjfZnv/LVmsQJ 6S8HHbil7u8Xjh7O4IlOm/E2arMBknjeqtfk6DTMvGzFGoEXw5CezJp8kUQ5G/bBKGTrVtAB/GW 9ZToQWUNG1Az/c+lUYcXeG6439GwYYtLp2xdErhE47Kk3OP34r1EUL2RZCciu5aMs9Ww= X-Gm-Gg: AYBFou0rx0UWB9Hl+H2tUqcsunpeSO25YhVu8mOuzTI7NpIRlmo1xW+rR1iZGdqjngu q49DOwq+SnpwwNIMMJIhB3SPZtoxZKB0edVW/G5sLnJQRYldfAIQHh17BWOYSalQn4pUbCyPsDB f0k1l6bcrmym1qjIl7A8MPxfMkh81ygDWNLmo6tst4CS+jevx5eRiqlfhTzTjvA76PzziuVmjS5 IvHk1zTeZpZCEko1O51CIhimL5iWnxso+YGXvw95eH9WuT4hZLQ5wzoCnHzWw8SMWm8dln17xG6 I2XY6d1XXYTPZcRnS1u5RXnRoG2PeAR7T4pWUoLX3blJuftSBsJl63/oIelfdN0Hx+lpAgHkx57 Vt2gb0935RjVYckmr8cvuAqoUgzdUBQ== X-Received: by 2002:a17:903:4b04:b0:2d3:160b:c01f with SMTP id d9443c01a7336-2db124b1ae2mr337578425ad.6.1788812700524; Mon, 07 Sep 2026 13:25:00 -0700 (PDT) X-Received: by 2002:a17:903:4b04:b0:2d3:160b:c01f with SMTP id d9443c01a7336-2db124b1ae2mr337577745ad.6.1788812700084; Mon, 07 Sep 2026 13:25:00 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.24.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:24:59 -0700 (PDT) From: Mohd Ayaan Anwar Date: Tue, 08 Sep 2026 01:53:21 +0530 Subject: [PATCH net-next v2 9/9] net: stmmac: qcom-ethqos: add Shikra EMAC support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-shikra_ethernet-v2-9-bbe3389d0652@oss.qualcomm.com> References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> In-Reply-To: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=2805; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=KsLk75r2w7Y7Td996D/f1RY9lIMY3ClaAGPh1T4xOuA=; b=dBBGlbQ+PXRK8wV2RTj9A9/IfrTUGHY9GlnPObuNyviClmSFJez2HMSBuIgjBJYSaU6yfzIKP OhRIpYexXv8CIc9lrWT634bEjV/CIGTmd+QQsDzMWwxUsfQ4OwMfErw X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-ORIG-GUID: w0bpGJHU_YJRiQUi-6wb8ajNdAB9rM_z X-Authority-Analysis: v=2.4 cv=U+aiy+ru c=1 sm=1 tr=0 ts=6a9f1d9d cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=8IO8aBILldGQKMPJy6sA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: w0bpGJHU_YJRiQUi-6wb8ajNdAB9rM_z X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX3Q82AdhaWnxG bM3MazOhHb9AaZMebARn0fx+I7HaCYW7NBZmEO1l0PIMX1m2HdXqgGralXTyNxXsb4L3f7Mo/hJ NLMt6XEKs37tuFjoE27ce8AYfrcAmrY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfXzKRN6wTq8Nbn za48n7okPu0hlrsCfkuqmDZkAfbuRk5UpKzN6uQhPJeuwAgITvHUUWYSwHIhotJL94ANtEEn6k1 7Ux/mKXjTIxkAlMpuo7JtytPV0vcPZcdbO5mXzLUdPbEijyt3F1H6Ng6o7RPU80Z9nWFr4+yYcI qgPVmZueqT3cG+qQTYfkOOSIXkSFCloKl7WEMteiWV7BJfd7n7swWNA936ivQ9Laptqr3BMDU6D kHsXtCjYKfe/q/SXI9JFaniXgn4jXVYcNR+sYGPDodeJMAhgZc8MW/vL6UL7jfd+/W119a1gU/Z 8YnolbKJ9fSU9v6FlWzIXnvGg48tK7PD7GCqgJYHSkYNjfggbun6Q8Z9wgy8dalOIr8q7I/apSz nJB+VoTSAWuIyqDkuK5dxa09Xnr6NbPKkqIbRSwvMTE8p76ssF+ssuvj3n7JR6SQeFLaOEILG8P ikT8rFiA59k0YeQWl8w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 Shikra integrates two Qualcomm ETHQOS controllers based on the Synopsys GMAC IP, similar to previous platforms. Register qcom,shikra-ethqos backed by a new shikra_data descriptor that enables the three NOC clocks required for DMA memory access (axi-noc, pcie-tile-axi-noc, stmmaceth) all at 120 MHz, and the 36-bit DMA address width. As part of the NOC clock voting logic, the qcom-ethqos glue driver takes a second enable reference on the "stmmaceth" clock, which is already enabled by the stmmac core. All three clocks in shikra_noc_clks[] must run at 120 MHz for NOC access, and managing "stmmaceth" through the same clk_bulk path keeps the rate-setting and enable/disable together. Signed-off-by: Mohd Ayaan Anwar --- .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 31 ++++++++++++++++++= ++++ 1 file changed, 31 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 8871d285941162c72e2a8f79d2eef915d9283796..c474f1e5a043777a52bcbff8a48= 8640f6dbdca30 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -328,6 +328,36 @@ static const struct ethqos_emac_driver_data emac_v4_0_= 0_data =3D { }, }; =20 +static const struct ethqos_noc_clk_cfg shikra_noc_clks[] =3D { + { "axi-noc", 120000000 }, + { "pcie-tile-axi-noc", 120000000 }, + { "stmmaceth", 120000000 }, +}; + +static const struct ethqos_emac_driver_data shikra_data =3D { + .dma_addr_width =3D 36, + .has_emac_ge_3 =3D true, + .noc_clk_cfg =3D shikra_noc_clks, + .num_noc_clks =3D ARRAY_SIZE(shikra_noc_clks), + .rgmii_config_loopback_en =3D false, + .dwmac4_addrs =3D { + .dma_chan =3D 0x00008100, + .dma_chan_offset =3D 0x1000, + .mtl_chan =3D 0x00008000, + .mtl_chan_offset =3D 0x1000, + .mtl_ets_ctrl =3D 0x00008010, + .mtl_ets_ctrl_offset =3D 0x1000, + .mtl_txq_weight =3D 0x00008018, + .mtl_txq_weight_offset =3D 0x1000, + .mtl_send_slp_cred =3D 0x0000801c, + .mtl_send_slp_cred_offset =3D 0x1000, + .mtl_high_cred =3D 0x00008020, + .mtl_high_cred_offset =3D 0x1000, + .mtl_low_cred =3D 0x00008024, + .mtl_low_cred_offset =3D 0x1000, + }, +}; + static int ethqos_dll_configure(struct qcom_ethqos *ethqos) { struct device *dev =3D ðqos->pdev->dev; @@ -962,6 +992,7 @@ static const struct of_device_id qcom_ethqos_match[] = =3D { { .compatible =3D "qcom,qcs404-ethqos", .data =3D &emac_v2_3_0_data}, { .compatible =3D "qcom,sa8775p-ethqos", .data =3D &emac_v4_0_0_data}, { .compatible =3D "qcom,sc8280xp-ethqos", .data =3D &emac_v3_0_0_data}, + { .compatible =3D "qcom,shikra-ethqos", .data =3D &shikra_data}, { .compatible =3D "qcom,sm8150-ethqos", .data =3D &emac_v2_1_0_data}, { } }; --=20 2.34.1