From nobody Fri Sep 25 21:41:36 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75034A014C; Tue, 8 Sep 2026 12:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788871504; cv=none; b=Xfdp6VU8+C7WYzM9kJZHTnCE6/1KwVA2eVrzdOmtf/sG4pspkhjWn5nqLFBL37+TwvTgtyv5cH+c5QOXan4jZdkEUns1p0Ed5tUYDF0wNU+g1UgInOmDQM4m9RpiO5wTRDAvTxE4pnmO16Ua/+2dbt/2tU5BXbu3ls0DV+uQ7P0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788871504; c=relaxed/simple; bh=VFryqqzhM6lSSy4pdb+U7EIAsRSleqEPMNVWVeCSDEY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p0H02Cyg0+L0H9di74AzsLFO53J7M2dPxyx6LC7Ay4FKpWhdS8q6ps5HONHQd/nfNmQKCd4t6//QmsLHC43VoUYguCLP1SEuQefBMBP8b/XctWiIyCMr65WbkH20xUuXDHN8oQ65dnMNWuUwjGn7QpY4LxqQN/gSTbfZ8bom2Og= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=afWsrmjO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="afWsrmjO" Received: by smtp.kernel.org (Postfix) with ESMTPS id 751A3C2BCB8; Tue, 8 Sep 2026 12:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788871504; bh=VFryqqzhM6lSSy4pdb+U7EIAsRSleqEPMNVWVeCSDEY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=afWsrmjOmN2spwI9V5Gq+ptION1ON4GzIJVcRHD+Gys4Qp0aQyyRyGpDNhGNTMe3K Cep5LswnJcUhNv0B3ipisWUwcyjYZeUQpx7TvpUXLNkqVLIvF3j7Atqg8XCCNe9K3U SK1WA7giHIz07OQj4BCggJb7xg68BdQmOVmo4zoC+PJkQt7aeU1TBXcLlpS9SylVI9 flsVO29m70PUCXj57E8vaAPjiUU1vJXeo3iOhDWzGwG5NIxgPc6nc37xlEKHwMy50j 3oLe2VCifwBMvw/rvWdh/bkezFom4CeULKobni32lN+6HhRqchvRl0+Few02bF88LE h21ZlIebIsHpQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AC2C79F9E; Tue, 8 Sep 2026 12:45:04 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 08 Sep 2026 14:45:02 +0200 Subject: [PATCH v2 1/3] drm/panel: ebbg-ft8719: Set prepare_prev_first Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-ebbg-ft8719-fixups-v2-1-5454ae1f5581@ixit.cz> References: <20260908-ebbg-ft8719-fixups-v2-0-5454ae1f5581@ixit.cz> In-Reply-To: <20260908-ebbg-ft8719-fixups-v2-0-5454ae1f5581@ixit.cz> To: Joel Selvaraj , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sam Ravnborg , Marco Mattiolo , Linus Walleij Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg , Casey Connolly , stable@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1322; i=david@ixit.cz; h=from:subject:message-id; bh=rkKe1B3w8nfJnM/PyCVxhpwlE8OgOguOydHVF4lcyVc=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqoANOWhebknUywxD5wXoUqrrutGzcfC1TSC2Mq SrOYSEh9xOJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaqADTgAKCRBgAj/E00kg crXcD/43mQI7xN9miQgoykM1OpJnWuQGafBFybMVjDZFyfkt7CTMOwFv5FpL1r4/pFWXQodJnWe sPpd67/FfM+fcYokvSJE5a8ntXH1Byy+ydbTCtGN025m2+RPndkBKuthCOvRR/zDc9eCQ0mZmbs EbfNd2X6f1GwpAahLHoHLJ4lblEDTTal3aoXEjn5NzMYFGlKhmDsRp2Pt1o3l4rnEjNnS/r/ckC 163s/4qNMyRcqmJ+zxpxXcyXb+t29j+Yxgg2AjIwQ5+Nbx4m/gwIRdABebKIzgBlpNC8Y4geGHp Zm+uRAw4udaFkIkquEyJe0ac31M6fcV6RE2iNjYgZQ7NKwS1qvLPGTDuVd0/6XrFXyKzFecAgxR HadSlAnvPzRIVKSuvKqlfAGbetGQf0NxEFzbG50EP9wq0EPP1g7/R+mWKX5AdmB+90RU8vewyLO 8pR/tpihVs2uZUR5h6au9GZVkFVBQz6HpJf8Z5155L2MGVOYWQ6sqkGU1bwMWUnfyiz+FofwBqU IVtrIm3ctSVzz9elUXCVL3MfOLkiYO0cwlvoFxSzcSl+dYLogNjyXsLH6fKnGYLK4Cwr30EMDcm qMFs7q6aGhxI3ovBV7iBbBNVLvwY8Z62oxyCoG9076APn23uEN2/VsRcjarLkez9nRak5RwU5uV IWn6n4jI+fzGF6A== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Casey Connolly This corrects the host initialisation sequence so that we can send DSI/DCS commands in prepare(). Cc: stable@vger.kernel.org Fixes: b00de0e237da ("drm/panel: introduce ebbg,ft8719 panel") Signed-off-by: Casey Connolly Tested-by: Marco Mattiolo Reviewed-by: Neil Armstrong Signed-off-by: David Heidelberg Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c b/drivers/gpu/drm/pa= nel/panel-ebbg-ft8719.c index fb9f9f42be4f2..1ab09c50a6306 100644 --- a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c +++ b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c @@ -193,16 +193,18 @@ static int ebbg_ft8719_probe(struct mipi_dsi_device *= dsi) ctx->dsi =3D dsi; mipi_dsi_set_drvdata(dsi, ctx); =20 dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_CLOCK_NON_CONTINUOUS; =20 + ctx->panel.prepare_prev_first =3D true; + ret =3D drm_panel_of_backlight(&ctx->panel); if (ret) return dev_err_probe(dev, ret, "Failed to get backlight\n"); =20 drm_panel_add(&ctx->panel); =20 ret =3D mipi_dsi_attach(dsi); if (ret < 0) { --=20 2.55.0 From nobody Fri Sep 25 21:41:36 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A769A53ECEF; Tue, 8 Sep 2026 12:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788871504; cv=none; b=EN5f77Zcd0+hvLq4m6dxl8Z40QqH/DwUdw3F2U/IYR0QaePiJx9R9Xen/0E58FdXHl9+Fdtms7rUUBDd3tMeLfmUHkaAqBYliPCJBzIe3lQWjahIkJB7vvLg4BbTmtUpSYW/WRHtT+pmt+J9nymrckBKXVqB+owiMQbSqjfkFZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788871504; c=relaxed/simple; bh=vzch2M62/WWHWost2D/9T230FaN7wq32AuSjdqMctMQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MUYT9ubZnl0vmnfJ+/YE+M2gclyDEknsx+Ll5evAU+jvq9Hz3cumzxpxyqLjxtwZO1QqedUfzSDBlaoW2IOoCs+9BzsVXnR6omsOi/ucpMVCwVo9dh/uGqTEb8kNFOrM81OjSBCo3Zdx2oFgNjrBGKuUPeU/TdjarrRi7TVlgvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kiS+uzC2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kiS+uzC2" Received: by smtp.kernel.org (Postfix) with ESMTPS id 80982C2BCFD; Tue, 8 Sep 2026 12:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788871504; bh=vzch2M62/WWHWost2D/9T230FaN7wq32AuSjdqMctMQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=kiS+uzC22HVOdgVM8xJzFJJOpakF1Ym0C6VAUQRTpznk+I/ZtO5w9G+w0t/GoCb61 f4wbyU3Km6pvxpJom1q/WTBm5VvbRmDaiCvSxQrbrISlmZHD71SXpBA5Z4j3JDdBsC oNKn/zHg1Uy+CxzdMH56RNb0NUVMvGe0kGIPSZJbugdYXD0JL0UhACP5/P2eiVpQ7I ZR5tKl7uEOluP3o+IcTHLHdmJVbJmj3AfjGycuUrCYX/nnJXGvtdGegfeWzvYoUwYU DFZL8gE4Qf39gf6Vllyg+u7Zu9tYBzr8rmF7N7TO5u/IwvTOEdsEKbK+44Q3BVPFYG Md0ma5nKeEqMg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647FCC79FA1; Tue, 8 Sep 2026 12:45:04 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 08 Sep 2026 14:45:03 +0200 Subject: [PATCH v2 2/3] drm/panel: ebbg-ft8719: Fix the MODULE_LICENSE() string Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-ebbg-ft8719-fixups-v2-2-5454ae1f5581@ixit.cz> References: <20260908-ebbg-ft8719-fixups-v2-0-5454ae1f5581@ixit.cz> In-Reply-To: <20260908-ebbg-ft8719-fixups-v2-0-5454ae1f5581@ixit.cz> To: Joel Selvaraj , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sam Ravnborg , Marco Mattiolo , Linus Walleij Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1249; i=david@ixit.cz; h=from:subject:message-id; bh=pcKWoYS6L82YgpVkEYWbN55kI5NvaLGqQcKX3/w4Jbc=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqoANObviOu0ox4MSAY8PbmPEAfrKuso2+WBjwi ga4pOVvfDWJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaqADTgAKCRBgAj/E00kg ck7SD/9BssSUhW1R5woL/myJctiVqZjTmd0pwcw+ZwuaNzsI4ZSLE2XXFR2bgpZ+zBvAqf5iJn8 x15C6iD6dvW713r0htE9XL/VhtJHqULfQgpF3Eeq8ZF0VbKYKqcXFvm6ItQKeM1cThN8RBN16iz oxLg+9/FlVoeNPKnS/lkvG73Aa/KJ51Mjf43SuCX1rHl/mmWvcUX+eCg92SPMrt7tOE9Pb11FZ4 Z7MblAsgt6Lb466HFpIFUeAoCDW55yQMk+5aifONk7uIa0bEYCsSLTybDHeKCjnQXzSqu65lyVd O1BYLHu9kC8Po79tAbPhZuS/Y9pWUTnurEJKEtyEQ3rmawwwRtQ73oGH2s1cWheTbherinsap76 TFQkHeP3L5iNqnfMi2qTF2ZvDpf0CXCD3NifBdfsU3LjdK14+Z/I4HD7R0WYAAHkgO41W/5yU/g rrrl8JUxiGjYGPJ3WTE8T7x2xuvHP1sk4lGJrqD048XzJKOuXo3eM4v1juypspfAyDO0Xe0tyMl GSabg/Bd9nXct3H/8fRqCXyCcRDXucbUgm5fi/5uAVfz1JxfOGw8m+O+0W+H53SJiCyHPoUg5IG QhixLZeVqlNzoSzYzEGuG9Ooj9bUP7C43dY1ni3mAZW4XMFNZ/Xh/bZqDSQG0lLO5bdzdKAvwaP 5n8FnYrInSqhPmw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Replace the bogus "GPL v2" with "GPL" as MODULE_LICNSE() string. The value does not declare the module's exact license, but only lets the module loader test whether the module is Free Software or not. See commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") in the details of the issue. The fix is to use "GPL" for all modules under any variant of the GPL. Reviewed-by: Neil Armstrong Signed-off-by: David Heidelberg Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c b/drivers/gpu/drm/pa= nel/panel-ebbg-ft8719.c index 1ab09c50a6306..14982263a94f1 100644 --- a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c +++ b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c @@ -241,9 +241,9 @@ static struct mipi_dsi_driver ebbg_ft8719_driver =3D { .name =3D "panel-ebbg-ft8719", .of_match_table =3D ebbg_ft8719_of_match, }, }; module_mipi_dsi_driver(ebbg_ft8719_driver); =20 MODULE_AUTHOR("Joel Selvaraj "); MODULE_DESCRIPTION("DRM driver for EBBG FT8719 video dsi panel"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL"); --=20 2.55.0 From nobody Fri Sep 25 21:41:36 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAFEE53ECF3; Tue, 8 Sep 2026 12:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788871504; cv=none; b=MXIAxjJ5li9n8ITUlNrQXmQ/o2anu0SJf304W1mir093m8EhdoQzfnIo+atumHTfLtpvK8Sf/hfy9LFaX6CsLTfNGJyspEU5wAaZxpEsQHzEseGkrI19ZDPV/A8b65DIDw2GbujIXwcO6HP/958GwVrzIaABKUI2hf3xO8xJBhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788871504; c=relaxed/simple; bh=4fuDNklbywCb7qoO5dLJnpOotv58leCBq6uit2rmcKE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=e4xHlQrvXHbA3Yg2xNfyOmDUHIHspiyO+nhCNYyiqVE6Xp6lCl9xvv59ekDKvyibKVyTOqsUY5Zq06pKuvJUZ1tJlyHSHXgTw7ebHCIlwNFa0p+dOxn07cfWrDW0bD3FCEXlvgVzG+37FIQfkwVKth/DrMKWLeGWpnqgjUoceJ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qwY4QiEj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qwY4QiEj" Received: by smtp.kernel.org (Postfix) with ESMTPS id 8D738C2BD01; Tue, 8 Sep 2026 12:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788871504; bh=4fuDNklbywCb7qoO5dLJnpOotv58leCBq6uit2rmcKE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=qwY4QiEj97q+Wf5HHuPaI5ix9P11uCyD2YTSXJerYwM1cdyRWe0h8UyiJf/yES9+9 NVYQmzQIlDrwt8R4Cg3HGdHwhV2ezP5vRG/ZKsndRVcVTW2w1uTNsayGh/Ei6TjfjD aWtuSWScjy1zDHU0VCtXOlbar/oDeWcQv0RvB6Xc3o4Oo4SqY8gGqLgPYAnt2zZMD4 f6ZKe//WQXatZzcJXDTu3WPSrJfRceHI4wL7ly6o7VI5wjazkBRIYr39z11NdNFkLG IdbCIks6gPgoqn+2i/a2Znda5YGPHZTN2jlMk1/yfWdXMwfx8b4RfF1ReZR8GrrAqr 7EpEaAU2+fnsA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7705DC79F82; Tue, 8 Sep 2026 12:45:04 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 08 Sep 2026 14:45:04 +0200 Subject: [PATCH v2 3/3] drm/panel: ebbg-ft8719: Split initialization into enable/disable fn Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-ebbg-ft8719-fixups-v2-3-5454ae1f5581@ixit.cz> References: <20260908-ebbg-ft8719-fixups-v2-0-5454ae1f5581@ixit.cz> In-Reply-To: <20260908-ebbg-ft8719-fixups-v2-0-5454ae1f5581@ixit.cz> To: Joel Selvaraj , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sam Ravnborg , Marco Mattiolo , Linus Walleij Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3584; i=david@ixit.cz; h=from:subject:message-id; bh=p59FHt+W5RxJxYzBAZ41gjyX0PrqfPnJroW1P4JaiHQ=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqoANO4JeodgFDo3sfvRALM9dtf/AW0QxG/TDpk O4JX5PpurCJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaqADTgAKCRBgAj/E00kg ch4ED/kBbl106wXrSg1G9m+3LB2P1WbofO4pTJc0f7pF03qbU8bV5HoUip4tdyriX4T1FWPfwc4 4/1ea49TeJgoshYNKq/uMUbEaVkuAZSfGxeZBZWR+KSQgzcrMmcBaY95/xJgCW0ECsTShqHOc2o 388J4TMMQbYfl4Ypl+WEaFVjBt672e+nn7j69kVd5CA842LBbPfXAC443DwrbuAhs+0wm1N+aFS 9qdcQOR14Pt8+NGUTRu6/FwAULpScQybwZwCsAtf4uFiCBzK3QMyhNxGoYSHBYmfCtRmiHAHJLC NgvO0OP1+BLK3Qk+Jgh9YQNmO/SCExw08LCQVjcfzrfiT+fcDhWORgnFEPYOXzi4+LYb8AxdZlJ zr4zklkzAPm6z4qb0A4YxMxisu2PwTc66YJIw73BGbvUnBFo07erFs+SGkUuoE5LPpn0ENZWMSM C1eBUWjQfNqL0GfXO2mrjp4/MXES1gWAzwUseRUN0fCfLih7t5ueCX4OOgpuqQDuQSqZCNnt4uU iQp+RSFAQENJgeO8tqZXBcRXl+MuSUO3sxz6un2OISH3D0EtXOTkeGllE+6ZYGndpBFUw51C3MQ uoKGPWSxkEXxO7RR4pLRuseOa2dprp7nP9y5MpqWmCPpaaIab+X43y9q5TMbA98b705ytD4jWAq YyhTn26GWCJXBbg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Move the MIPI commands into enable/disable callbacks since they are called between prepare/unprepare callbacks. Signed-off-by: David Heidelberg Reviewed-by: Linus Walleij Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c b/drivers/gpu/drm/pa= nel/panel-ebbg-ft8719.c index 14982263a94f1..1652de70900f1 100644 --- a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c +++ b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c @@ -49,74 +49,69 @@ static void ebbg_ft8719_reset(struct ebbg_ft8719 *ctx) gpiod_set_value_cansleep(ctx->reset_gpio, 0); usleep_range(4000, 5000); gpiod_set_value_cansleep(ctx->reset_gpio, 1); usleep_range(1000, 2000); gpiod_set_value_cansleep(ctx->reset_gpio, 0); usleep_range(15000, 16000); } =20 -static int ebbg_ft8719_on(struct ebbg_ft8719 *ctx) +static int ebbg_ft8719_enable(struct drm_panel *panel) { + struct ebbg_ft8719 *ctx =3D to_ebbg_ft8719(panel); struct mipi_dsi_device *dsi =3D ctx->dsi; struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 mipi_dsi_dcs_set_display_brightness_multi(&dsi_ctx, 0x00ff); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 24); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); mipi_dsi_msleep(&dsi_ctx, 90); mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 return dsi_ctx.accum_err; } =20 -static int ebbg_ft8719_off(struct ebbg_ft8719 *ctx) +static int ebbg_ft8719_disable(struct drm_panel *panel) { + struct ebbg_ft8719 *ctx =3D to_ebbg_ft8719(panel); struct mipi_dsi_device *dsi =3D ctx->dsi; struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 - dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; + ctx->dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; =20 mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); mipi_dsi_usleep_range(&dsi_ctx, 10000, 11000); mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); mipi_dsi_msleep(&dsi_ctx, 90); =20 - return dsi_ctx.accum_err; + return 0; } =20 static int ebbg_ft8719_prepare(struct drm_panel *panel) { struct ebbg_ft8719 *ctx =3D to_ebbg_ft8719(panel); int ret; =20 ret =3D regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); if (ret < 0) return ret; =20 ebbg_ft8719_reset(ctx); =20 - ret =3D ebbg_ft8719_on(ctx); - if (ret < 0) { - gpiod_set_value_cansleep(ctx->reset_gpio, 1); - return ret; - } - return 0; } =20 static int ebbg_ft8719_unprepare(struct drm_panel *panel) { struct ebbg_ft8719 *ctx =3D to_ebbg_ft8719(panel); =20 - ebbg_ft8719_off(ctx); gpiod_set_value_cansleep(ctx->reset_gpio, 1); regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); =20 return 0; } =20 static const struct drm_display_mode ebbg_ft8719_mode =3D { .clock =3D (1080 + 28 + 4 + 16) * (2246 + 120 + 4 + 12) * 60 / 1000, @@ -148,16 +143,18 @@ static int ebbg_ft8719_get_modes(struct drm_panel *pa= nel, connector->display_info.height_mm =3D mode->height_mm; drm_mode_probed_add(connector, mode); =20 return 1; } =20 static const struct drm_panel_funcs ebbg_ft8719_panel_funcs =3D { .prepare =3D ebbg_ft8719_prepare, + .enable =3D ebbg_ft8719_enable, + .disable =3D ebbg_ft8719_disable, .unprepare =3D ebbg_ft8719_unprepare, .get_modes =3D ebbg_ft8719_get_modes, }; =20 static int ebbg_ft8719_probe(struct mipi_dsi_device *dsi) { struct device *dev =3D &dsi->dev; struct ebbg_ft8719 *ctx; --=20 2.55.0