From nobody Fri Sep 25 22:21:10 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8DEE38E100 for ; Tue, 8 Sep 2026 07:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851462; cv=none; b=JN/453aefc7evlhTIffL0eqQGDczWlRrsEbWD/0d00oLzpvMA5zst3ebIo4kHJWWrex0O8Lwt60MQev5ch/LM4ub1JSBmLb+FBbLfq3Qs4xfDv56YSVat7zSC4fpLZDI22rI7XGs/sV8PGdwmJzkdX6KM4fQF+4gdrcoKF43SNA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851462; c=relaxed/simple; bh=ZG093MO2ef10q/LWPvFaNq71LX74/rGkq31nYz5GUvY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mHCKckL6xpAEeiWgxOtvOLhCTiw5KpGbJrUuoT8/wXJDtjg/S1lw/ncR9/QM2YeqiwBAyRKP14Br+9XQc2C7VHbwZ4QRfoJl4KDWufnwquTi5z8Y4r79S+bNX2KL7X3ttf7L4yuxYviD7go9HAztESY3L0FPMR9zjBNCo5TIvX8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d01t0aLc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H5VO5JOI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d01t0aLc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H5VO5JOI" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886LhnN1477306 for ; Tue, 8 Sep 2026 07:11:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 89kOUuqbTMD7KBwxWQmwEktFk33uBWpQA+q0IsoXFqk=; b=d01t0aLckEBoXC7j nxjktvZpRydcpmhlamcAjJTIc3W4sje0zKN52B91cYt4i9cBIBwPOuyyPI0GeQe/ x68hWIoJA8heF0tVkI4RC+D1Vv2KelJ9xixSL1YHMvj0OcW/MfyrpfmOnWEvyJkB WGJmu8isy1wRKn6guD51kZDb55xEI/xq6nYMnL+AEznwlZObGBh3mNa07xBWgYkl uPCZGtOPrVVvM3xai32j8q6jAgdw3b4q6usiOQjRoB+vQ89Sq8tb+3ZOKJ9nSe8d F6RmogpBPWzNNQ7EyH9pAHDi43IwOisAUoDjR++LLIz5NRFMDUXZ2LdCW/SgFoC1 TcN4tw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjatjgp4e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 07:10:59 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e5e38fbc5so708333985a.2 for ; Tue, 08 Sep 2026 00:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788851459; x=1789456259; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=89kOUuqbTMD7KBwxWQmwEktFk33uBWpQA+q0IsoXFqk=; b=H5VO5JOIEyQ/p8MW0ZxmB0N9CHD5JBHNzOcAf53DC8mWQ/FBRvVfDzBJBNNyczfnM2 dmf6euZYi5QExEhxFhpmcysOxqV/vzi6fHIVF+nuTSiVwhduOf0L7xXmF4z5dazeNMlY V1qOAzlZRVCoeUEiPLQItq6BU5eCfSlV091xTZOpTpLGtOM0TPfOKEPBu25jkM5QkGu5 Z+Q2Tc/G3PHHSgVxm6tfJlmvBRUhRwg7yw3E/PS8FEHqFg5RKlKSkftV5+qmx9//IW38 pHQdv4oucX/iGFONAIhjR+10X0+3qgB+tydtt5EewAdjgR/uoNjFXQ4/vL/Jp3dbqmbj bftQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788851459; x=1789456259; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=89kOUuqbTMD7KBwxWQmwEktFk33uBWpQA+q0IsoXFqk=; b=Q/X/XOXbBk4ECXbCwS0AA6WCymBvGR14NT1u/fDMWw7k1Rddq8ODwgNkLHgPEJ5HqK JjV3kTm/AxZaxWmSJRDMf9+Z3T1EmePEqrO0E9xmwYS9vU1nJBI0/6/8/wm9i6oSlZVS BIYF73CRaMSHZkn02zODbYpY8eo7HbkAJy+WvAr2GVEUTfPMClALkAVqW3vzFfNZOWeO blO9gdpbEthbZupo7g8VCFWCJSX/uVov3zIyy1/bwDgv9I+mIeudkCoT+Wb/Ve7xrfJj sVqvX65oeTY0hS4FPzAdR7L8U9L11bu7ih2lCBMuMI5QRGFZpKTni0aB9sSX/+zlWolq 2/Rg== X-Forwarded-Encrypted: i=1; AKwUvBxar2EQq7EIgYgQjpIf5ITHz9cr0NKsseiINOX5F87iX9ULc940Ao93Q3ULUiIDjwTy8ruas2k4AhQKTvE=@vger.kernel.org X-Gm-Message-State: AFuF++mU7Sbp/npJKHn3pvfcvYLxKkuA+2s4Z5/NqidYrgUStr1/DRu7 +r2kErsNbfAizbGN7Dmdxdi7fHIFmHPqiv41elZj9tEn6KJls4vkMNVnUDPlrH6dbY44UjGCcHL 5Iqbk1Vm48itnUZ+IhIuUdgqTYK9w+wok8VYiovtquQGPY37vkpT2629guYGjixtgP9I= X-Gm-Gg: AYBFou2gLE1H41eBGveHfalx/5UtSNp7MlRjJ3dF8cLODPZLFri240K3tuNNTFlOwMu w3QvwdMXImiAa5dKe+bMu3hSM5TXsuCzw0m30CuKKwRyzZ6nCt5fDgTjP7yR2lCaan076akORN9 2fdMcGh7ihx5zszsgAcByno1TP3qxmVSgpCz+votDmM+3k2eF2Ye5oOP2VeBn3iIhzIb6ZWlL2x kX5VEW3pHFB5XvnIU5Ev9gEZ/2Xk15QUxKLqVPruigGOZN/K4qLHcJbwJr5VkT8F/eV6G8FKk13 gvG+nkj8QNRC1SC86s+n6Ca+yrk6SpDFd2PaMBZX+d2RAxTGa98p0ThLAb/ma1FIGPZB+/Sg5Xu o8059lRo80pwSaGPe+aJhIDk= X-Received: by 2002:a05:620a:3707:b0:939:ab90:8f6a with SMTP id af79cd13be357-939ab908fd9mr1195393985a.18.1788851458804; Tue, 08 Sep 2026 00:10:58 -0700 (PDT) X-Received: by 2002:a05:620a:3707:b0:939:ab90:8f6a with SMTP id af79cd13be357-939ab908fd9mr1195388985a.18.1788851458361; Tue, 08 Sep 2026 00:10:58 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5927b68sm453173805e9.1.2026.09.08.00.10.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 00:10:57 -0700 (PDT) From: Krzysztof Kozlowski Date: Tue, 08 Sep 2026 09:10:41 +0200 Subject: [PATCH v3 1/7] drm/msm/hdmi_phy: Cleanup after msm_hdmi_phy_resource_enable() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-1-dcf8956878ca@oss.qualcomm.com> References: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> In-Reply-To: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1590; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=ZG093MO2ef10q/LWPvFaNq71LX74/rGkq31nYz5GUvY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqn7T3vtS3HqWXUdSsiVISeU47Im6ROW1p5A6Fk 05xiUy9rpSJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap+09wAKCRDBN2bmhouD 114AEACRO7SvCxub/ywNPr/vKZhyFhbU2JGDgp/FmhNnXiUs5W0/MpyTWB4t9M0ZLv1B1KKWqxU 6cIujtV0TMmQv0UOUoNqd48IREUrMtK8loR+ocxNUeetJ4OrYGG1APFlVT3Y5fyfZtAT13tHDDY GS7PLrdz9xI8IjU0ctGea9dQg4KXS0A3gJq+bNlan7j/O0NR5nIonwMLM6TIU4joM10NR7flK/t owfigDxvRpBr1EwTuDHi3tcLjJAxKWhnyVE0U+NOvKVEF5us5Z/v2EPv76A1suO1QDV4IZYvaks E/zgnXRFI4bNDnNXpDsglIQBNACSK1OtWVP30eGoSi9v2ZkGwc2LoU0GtYRG7xa+NDVs1iIZ0AH aWqjDV1EoJfgcYsxZNZrQ6cw5uHFbiz8LFNXRsm1CyI+HCGThYI9b+x5pqJiKCtYhtkTolcRqFg S6TplqNWUYXsKOlhRlBqzLKPzPcqtgO4a9U4XP/bVD7X/whtZCvW6U7RKoXJrANsmRTMPrsVocz 7/msBWD7N82wzP3dlOYnKFvPOvS0vovO8yYNcjCSyZka1mkX4yP1mIRAFdU0CEtnc1jwbyt0LYs 5KD1cOlPg+2B5fC7ZuWtUiMbLVXt9BOjMPV30OCg99Qi0BgFI2MYvWDNVrwWZXr+Tir/3RAxN+Y LkgdcouDjYxwaTQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX3lPeTV2bBpiq op5mF0irnMWXa9mlzeRQfJyE7YO5m1upSmj4cZaecQUBMY1Gml7uLoC3y8vwQJMTxg5yitEY3C8 qG2pVLEXBF1Y9u1sNyUODqQX8s5ovUw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX0k99hUL9Kh+u qfSsHQ5qHWNZcEMxHKqqXlDokMikVylwdF63DsX9OO3Pc8KiJIROj/lHh+H6rHM3juUi6z/g2zE 0xsckp5ZXlPyuav8uTzvnqRI9f2ltijm0A3IY427XIaXf+qypAXht9VfRzguGYbUQ9VKQV7AWbW guiZanZmOxSeeGh7bOM3hQxU7WByj5tlpwOZ4VuwVH6EwFmwTZ0p5cGJwXPDNNngCs6dDUEUAfx rc6iapbEZBBbWJk8nEinWHs/EJohHBf956bqFy6BtLOvjn5UWazf2FwhBPfD1SXSwS+ucMB4+8q ftoUQUBQ9LDwBLbv7fYlGwBBOa4tdGLPkHM5G/tfsXGQYvVKkVSQzlgdasIP/MBCuKrH8UZi+sz ACZnyitkTXbqeyYZokuuAXSEbH8Enyo6BW0L0FlWrZ4ThRcnjWIcAt13Rv55l4IrvIDB9PGr6tN v32OisQ/TCZam/lJqwA== X-Proofpoint-ORIG-GUID: u21jfElMDdjGruT_FEXjdg9C-29QSok3 X-Authority-Analysis: v=2.4 cv=QrduG1yd c=1 sm=1 tr=0 ts=6a9fb503 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=bp1g5Iz1D7c7guLF1_8A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: u21jfElMDdjGruT_FEXjdg9C-29QSok3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080072 If msm_hdmi_phy_resource_enable() fails, e.g. when enabling regulators, it should reverse the state of things already changed. msm_hdmi_phy_resource_enable() is used also in probe path, thus such failure, which could be simple deferred probe, would leave these resources permanently enabled for the rest of the runtime. Cc: Fixes: 15b4a4523859 ("drm/msm/hdmi: Create a separate HDMI PHY driver") Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c b/drivers/gpu/drm/msm/hdmi= /hdmi_phy.c index eb1088755cb3..15e37596bdb1 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy.c @@ -67,16 +67,28 @@ int msm_hdmi_phy_resource_enable(struct hdmi_phy *phy) ret =3D regulator_bulk_enable(cfg->num_regs, phy->regs); if (ret) { DRM_DEV_ERROR(dev, "failed to enable regulators: (%d)\n", ret); - return ret; + goto err_pm_put; } =20 for (i =3D 0; i < cfg->num_clks; i++) { ret =3D clk_prepare_enable(phy->clks[i]); - if (ret) + if (ret) { DRM_DEV_ERROR(dev, "failed to enable clock: %s (%d)\n", cfg->clk_names[i], ret); + goto err_clk_unprepare; + } } =20 + return 0; + +err_clk_unprepare: + for (; i > 0; i--) + clk_disable_unprepare(phy->clks[i - 1]); + regulator_bulk_disable(cfg->num_regs, phy->regs); + +err_pm_put: + pm_runtime_put_sync(dev); + return ret; } =20 --=20 2.53.0 From nobody Fri Sep 25 22:21:10 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B56C39E194 for ; Tue, 8 Sep 2026 07:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851465; cv=none; b=NX4j9Jh+1NAGD747vOTAeE0gusEs2TPpCjcBvcIA8k1Ua2KxVbxVXu2Z/+vIZXBFHRCe9LdM7RcCtctAViZ0fc4BeGQTj3YiHLZIILY6sbpTgt1hzE+hCVKFAhZpffqfrrkw8QKA6L89DOkXLjE0EWBrdrWyIce2wolRPHofIqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851465; c=relaxed/simple; bh=gCPjQLee8IZ6ZI1o3PKvV9FFsQQqDDwLDIvAlHVSnmc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iIsP3oE8k3c0YQ20ekEx/yhi7A/r71+CkHyhcHNDeIeq3ksG9yAjh1XqDySKuNcfn6X0XSxHffLiYWuXtL65Rki5KCAe3gb2YYk0d7YoHoZi2Jc+fB1IgKiGUbTuBYbwWNJxTkIcv4NT84D1hzhhvIVH4mkNYg13gPsT6kKl1SU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ae/v62/I; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kV9JuV5B; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ae/v62/I"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kV9JuV5B" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886LnVJ1645958 for ; Tue, 8 Sep 2026 07:11:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HH0NlUkAHggOm55GmMCsiEP7bNk66V1yTa1Hyg0NTUI=; b=ae/v62/Ia/7o/ONV uPTVJrnFMxE2KJ1Y4nwTly7EVJi2ddlRmjJ+rtVX0UdVmn4K441X+MOAVw6c8uyF kpneSqlrNGKJ6z0+41PpLx2ejHkBdH5C3//E/k279cH1lUUIWDC7STcDh1GLtJkb jxfUk1krGFylMz0Lnr4FSMttLzGSoX5T0p6n0WfmMcxgtv99T8Yds6xlBRsuvILb gga6sq60qiAFoPR5wOo1HO09nx7N/z12inrNYUsZf4zGkqRjW++/ZB95wo+hqdwT vN2sJ5MgqSKto+whf3EA3/xf7hcXLDHHtQKEVbK2XcPjZYvMwEj5VHr9FbXbl8o9 vNv81A== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjcvug7pa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 07:11:02 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-939a6937513so227965585a.3 for ; Tue, 08 Sep 2026 00:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788851461; x=1789456261; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HH0NlUkAHggOm55GmMCsiEP7bNk66V1yTa1Hyg0NTUI=; b=kV9JuV5Bz1qFzGB3ZdJNm1U8/YTy+KVKD23q2TgrUISvKLnfATgygonpu/VhvCwUqz GU1oJnp2sa29qSxn7MN4WZMd1/EcHpt6ceOzZniT5C2Qdmh504u6eJbxAIBsVpB+vBAE TKeHPLXlzc+0Ipopn0lbF5TiaoMF6yhYI/9aDt/Tb0kU1WgduaW3zCVxq8Yjxd6Ii3ys 5FI/JIkEZp0Vsvn0iHbXEafYlGqUBULYMjFiu+ZyS8bIraP0kDMnUOX91RcdIP8cnsEY ys/lCYjK3GE+WRSHmbFPg6+PNWXFqKZ90uc0Ojre8URJevWT63UMm7NW08TH5XM9GDiI 89Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788851461; x=1789456261; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HH0NlUkAHggOm55GmMCsiEP7bNk66V1yTa1Hyg0NTUI=; b=rj55Y4tBUga7XPEUrR5yJyuxD0dVSM07g0eusQmveBImVPzW/QZbMAPkAq0dn6Rgyd HURdOWqRqRy5lFc/IIVACwI2TBUWIbFMvvjKGKIykbjrLI66we+VcWUUtP9ZNYR0tuf9 KIsc26i6H+ia9ZVxEJDw7B1ueA0RGfOfHVVv1X3TUCHlrbuWsjMSUsWh0pDg5TERpGi2 Xp+Jk3/v3MH1XuZR2sNGFOh3UtScNG+zQHHTXR8tYEKZIy8orb/+uGZdcm6kyB7UYeOA p6m5njK5q00ZTSooWY0cGtE4kXDy0F+wFZ/VGDFkl9clnBLKVfxLSyzSqJOxKCXOD0Ch WYxQ== X-Forwarded-Encrypted: i=1; AKwUvByF1VB3lI3vLLGlCAYWf3XBBiXS9iJjHuLIpX58ZkwarZ+Ql+XhnEVJ0UKwq4vh406HvAQaRVSc7S5vzRw=@vger.kernel.org X-Gm-Message-State: AFuF++kEMVsQ2dLRPgYAxbI6BwZUEhA4QyQCriJeOfnwO8xiuMQCy4px ZT26yMAW8iypTlpa1bwkmhXl9+AjMx2jkKYsglB/uL2ujFCESM+TqX9Sex2AFMvWc3X6g27FS7L 1JguBLbcglpTQoJq0LU1UFTQ2JDUVnxEpqyopATPpWMpxEm6pQoWLZmhOsFNu7vWGOok= X-Gm-Gg: AYBFou36KEPrgo+alnpqd+aasdRyZyd5IxjEDxuTtq4U9IsfFY2PP/wi1uCUeP9giXP E1/PNXXe7ORCzi/4Gyvhaa7T5KsPYHStLU8uwpl+9fIn11BjprBK5Rme5FfESXKv2hgbhP1QJyI /Hki2eI4PqM8SDP4Rg/zqbzRbmg6weBiLEOMqJOy6Yivmoc2VfaxVPnZTcktCV7aVtQF7MIkcPW DMtRUVeTDzHkDQazju3Ah37rHa6ywq5eYP8lgDThFOBmiyi5/kb79HnpJh2eN5KymDT+s2YxSoy 1KAqIYEuPNyk2OkuhQGAIMKOwWCQbjiPnu/u2YICzHxu4JkCiV8eWzJmCMYlH96dWXrREXoXlaP cG9AaG3QH2O3AfDRClMXrWCk= X-Received: by 2002:a05:620a:1998:b0:939:2940:6368 with SMTP id af79cd13be357-9398037189bmr2454042885a.19.1788851461268; Tue, 08 Sep 2026 00:11:01 -0700 (PDT) X-Received: by 2002:a05:620a:1998:b0:939:2940:6368 with SMTP id af79cd13be357-9398037189bmr2454035685a.19.1788851460804; Tue, 08 Sep 2026 00:11:00 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5927b68sm453173805e9.1.2026.09.08.00.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 00:10:59 -0700 (PDT) From: Krzysztof Kozlowski Date: Tue, 08 Sep 2026 09:10:42 +0200 Subject: [PATCH v3 2/7] drm/msm/hdmi: Handle msm_hdmi_power_on() errors during .atomic_pre_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-2-dcf8956878ca@oss.qualcomm.com> References: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> In-Reply-To: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2516; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=gCPjQLee8IZ6ZI1o3PKvV9FFsQQqDDwLDIvAlHVSnmc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqn7T47t9PIoGOvtY3A4jGlgUHnqVJUTLHI1x0C PyFXomucWeJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap+0+AAKCRDBN2bmhouD 107ND/9wWvZWNvTtHTd/hKE/PbowEdSQof1zsPcrXjmwUH8OWj3bH1OjbaqDUNcULYAqqfb/r4l nUWbjdLAZ6SQHG3bXBueBsMpUu1jq7MMHUfseJj2CNNlgqDH+i7hNlXqXAYHTM6NlThoPOuWg/O qa1I+8NX+9dgncWQCQO9VL1DR4Do8TdX7M7uzJ+XqC6IPb9wygQw1P7OMY+0XhvY7GJRwDf76FN M0xqKxVyNJMOVJQkOJ2Dq1eSBVWM91sFSMDYnjVtef8tY5RwNweHiEFf2dK2sFAV2SQo+nXYu3e 1te6/w8V52dr+Xf0SXg4ibI+/OEFMShpqrLYCh2/Anm4evONOc2HuNZOi0jeY0dpzCAm4LSSnNE ilWieia8LghXhGIXO5HAr+VCGzsmkKYJt2Q8seeuFkabnskt6H0IUD1XX9fWQL1lWDXsDl1SQEv CAuvaOBT76B7G39PFZ5jwQQk/Fry+AAJrRyPZfEH7VW8I8bYsplCOQZjYOLYEBcoH7I+3Kv49vz bE/HzBYaYOJCs9a3IohQnKLSCzkcy31sNhUzn8YDydxS8A7lr+14fO/dhtKSBRiF6s8jpG5vC+w USgHJ6OmNlmP4onu8C1WMoL0Xf0VdwvYHCuS2o/76Mf1sgU7hgFYMxQ2Ci/F0TWQdQy2HSJ0hxa 3AcmKaInUP1iWrQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=ePkjSnp1 c=1 sm=1 tr=0 ts=6a9fb506 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=IzbfGf_HrtPdoiX6LZ8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: xh33_1CXfvSvHMokhIykO186Fdwh95eR X-Proofpoint-ORIG-GUID: xh33_1CXfvSvHMokhIykO186Fdwh95eR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX8AZutp7CBgj6 G/Kb+4cSauvzt4xIT34axDeLY+ZWw5edoA0hLjcQwUCDnShGLm/SUECmGK6NhYDrZEvC3/nVfE2 eFt3X0w+iwul3UNZEgae50RMK0dVVAiungKbpOIB5Ow7gUvq2OKZ2MYuLXHlI2OR7+8ndSyKPgt R+2c9izf9DqCOfIO/iD5iW1OtxqPrJrJgA1EoboQeM6wsKJfhifBkPXjpsSOJkGGV5wlz81IRWk aGixiy4//g6TDvbj8E6SF6KRFdtBdelmAjmY9wjgT4exJrvLUbPsDYA/5zo8TLJZwH423QxvLox ivDFvO04/ZCkqQ4M9MBFcP7pd86E2qTlmGXoUfRBW6LR5AQpmF2Zj8xuOM4T1KUkCvRnfdL3uEn dDg675DyRI1Wf0soWGzbRz6/8BfP4/uCgUCt3wxk5G9AoNYozi+q6zZ4Py42KpBYObMDoieE5Cw fVbX8E9VI0dqYkgubrw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX7SiH9GEJsK7E dhp7TYLP/67GIoE8f/yjxE9J0G8p+JnKbRlyJbb8d3ejJstBoAWfVrashsT2zSYxQXHS8PABydB xlznr2aO2NCjel9LSq00eyNUj/s9Iuk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080072 Properly handle power up failures during .atomic_pre_enable() by aborting the .atomic_pre_enable() to avoid accessing registers why blocks did not bring up. Otherwise this could lead to imprecise aborts when accessing MMIO while entire power domain is off. Cc: Fixes: ba3d7bf3a7ab ("drm/msm/hdmi: Convert PHY files according to new desi= gn") Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index 157f19bd90b4..db85400e574e 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -13,14 +13,16 @@ #include "msm_kms.h" #include "hdmi.h" =20 -static void msm_hdmi_power_on(struct drm_bridge *bridge) +static int msm_hdmi_power_on(struct drm_bridge *bridge) { struct drm_device *dev =3D bridge->dev; struct hdmi_bridge *hdmi_bridge =3D to_hdmi_bridge(bridge); struct hdmi *hdmi =3D hdmi_bridge->hdmi; int ret; =20 - pm_runtime_resume_and_get(&hdmi->pdev->dev); + ret =3D pm_runtime_resume_and_get(&hdmi->pdev->dev); + if (ret) + return ret; =20 if (hdmi->extp_clk) { DBG("pixclock: %lu", hdmi->pixclock); @@ -29,9 +31,14 @@ static void msm_hdmi_power_on(struct drm_bridge *bridge) DRM_DEV_ERROR(dev->dev, "failed to set extp clk rate: %d\n", ret); =20 ret =3D clk_prepare_enable(hdmi->extp_clk); - if (ret) + if (ret) { DRM_DEV_ERROR(dev->dev, "failed to enable extp clk: %d\n", ret); + pm_runtime_put(&hdmi->pdev->dev); + return ret; + } } + + return 0; } =20 static void power_off(struct drm_bridge *bridge) @@ -287,13 +294,18 @@ static void msm_hdmi_bridge_atomic_pre_enable(struct = drm_bridge *bridge, =20 msm_hdmi_set_timings(hdmi, &crtc_state->adjusted_mode); =20 - mutex_lock(&hdmi->state_mutex); - if (!hdmi->power_on) { - msm_hdmi_phy_resource_enable(phy); - msm_hdmi_power_on(bridge); - hdmi->power_on =3D true; + scoped_guard(mutex, &hdmi->state_mutex) { + if (!hdmi->power_on) { + if (msm_hdmi_phy_resource_enable(phy)) + return; + + if (msm_hdmi_power_on(bridge)) { + msm_hdmi_phy_resource_disable(phy); + return; + } + hdmi->power_on =3D true; + } } - mutex_unlock(&hdmi->state_mutex); =20 if (connector->display_info.is_hdmi) msm_hdmi_audio_update(hdmi); --=20 2.53.0 From nobody Fri Sep 25 22:21:10 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822003A0EB8 for ; Tue, 8 Sep 2026 07:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851467; cv=none; b=JNpCcIDlWZKa4Mqm4t99O2n14amonQj8c/EAFjFB7kBCN909NDC18dJuTZFqq9EHnzhCZS2jCo8AqOkeDw5ClJm3+xC107svlDO/xIyOwPIf+rSu+iD20hYpAnqHX3HqpdCMFF+WsHMnkQZy+/LK+RESlC5rugcbhc43jkH0/Hs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851467; c=relaxed/simple; bh=NIsM6HvCeVJ35nWFFLJNWwCPf0RLm8el3fb5T4Hse0k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AzQVSr67GyedmFSHW1qiNrTfYAJ8p0fCCDvIOjOJ5+K6neZYkybFCZ8Sa+WahmAXDbWjnxThwFwns9QnOMvtI7qCU5gQRCB1B9GX65/1FOIBtA8TDPrEi6+/yRAS9IgWIUA2Oa5YteJgNl60qiEBA67cuax4x79TMecgkwz5+sA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A8Xz7Zdy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h46C9GOJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A8Xz7Zdy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h46C9GOJ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886M0xH2172912 for ; Tue, 8 Sep 2026 07:11:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= q2zFzzLUBztHpAlThCWGXoxQohXTYyYKFSjILxdt7DI=; b=A8Xz7ZdyAkeaAwLJ 6UJTfNONpzJAFMrh8KS8KVLccPftP/jj9BYeLN6w3C5lLW+yU05kyDq2M+Q2x7HA wffZqzsPYWTHg6fBicjTyFwQh8ptakbow0VCAy/m8ElHElu/jX1xtOrqY9Ql2lHn DELf51Il/pj2k2HTv9VCHUnK0tpHJ97HLJj36obqum6KySg/QhMyM2S4Vg0isEY3 whyaf5Q71MJN44Z6U0Hm9LVRk0PLMaGo9oDs0fxiP1v6tsth7TF/jS1jHjkYMNzi amB6BKRO5jkeFlr56FacfVCHu4kabvoklPzO0X8HOmICs3iFkmMuiIQkWFjupB0+ pSFm/A== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gj1rrj69a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 07:11:04 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e53b8a302so795143585a.1 for ; Tue, 08 Sep 2026 00:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788851463; x=1789456263; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q2zFzzLUBztHpAlThCWGXoxQohXTYyYKFSjILxdt7DI=; b=h46C9GOJKkGWjaSd8SU2dUE70+ltaQAm5IjTPG+F1Zcc1AljTnO9Nl1aVCBWmOdKJ8 cCn2LUxWECYMu89Auej1iTLXibJzXHVK3hCvwvhIvwga9E614x7Q1uX2B2k7PdxfmzPL DfyYyRKeeDhpky6BIoGqzI5Rlmpy8U0ASm1jwk2VIvobJ22pBrvp+SVSiPTZPRrrEJAb 93Ua9rfk+ajLI/Was9U587M4kvN6nTYxTwUamM8pUzzSFZE0FDBsaIaz05VijVLYxgpN InEG7RktySbWtxpjJpCYQye2/Eqiywp1ewwWt/9ZPO1nB7jG6R2wir3k2Qi/mVRzQHps l3lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788851463; x=1789456263; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=q2zFzzLUBztHpAlThCWGXoxQohXTYyYKFSjILxdt7DI=; b=eTmDsc23v+V7PpBU49JYb9U9b+jwr1UKRQTmfjIu55kH1nFKO3OP2uQmqDK1Tupw6x 4XzeOB3iVQEBfIj/idqi78x0ye9Y5Vt8HzdDp9A1fJB0hxRezE9HLyop4LKld8AJnfpj LhqdjQv0h1dvHO+GckuoOqqYFVq/sxPNXZjxgbWaaqh9bJC5N7USw291lTpB1m90bqBQ Q0FjehX+D3dGHc/cabxsjPXicDmcef4Ogmp8eYTnrTC5lLVZKiRaGDplP0/npdLJXyWk q8zsJtye7AX3uzhf/t8n84C0Iyo/hXGp///0JhEhD+uKp1qnsqJY+AdxRFxjIfVZUZW1 98NA== X-Forwarded-Encrypted: i=1; AKwUvByvSws2iSBYSgnpPnCLcFvLLMgBqllBb8fBQaoD+mnAVVxHBJ+s/6NPWf/7qqIyATfNzPjG2Jbsj/b7WTE=@vger.kernel.org X-Gm-Message-State: AFuF++lGCaX0su4ICXTbvwfZE4zLTFPS9SKOTksHQgVTl7K0fW4NGXqU fDJcfK9nHT7wauVTxnUHQ37t4pZHh/kLmAVd8KFu+hLydYikm9WqfK2IZDNXLQRC9kggAH5Sx3M Ocuf5rIS6jbndU7JVZbz9YjUjp1wFQbZrBPjdXY+UklTCdpLlFMqaEtObiRcHchx/0Ns= X-Gm-Gg: AYBFou2Dt9FHyfy9bN3pGsAjKymUAOK0FiucjDa0R+1+7oLTPw+99nszg73FZF3JjOs 6DqIav8SvQTMtclz9mzcqdKcSBSauh9Yz8HAt7yu/3w8gtPqLCkJOwQFb4LfsfJ820r+oBgWBgP NDtSvy88rKNDwvLSIFbf9AQiT4ch0xnOiPqcjm4tgnZZSOX1nO30K+o62mAQvLSZ1AoLAUs6Dif NRZxnwaceGwXHQv0fs/TB0Sseaaw4vNRc5MEIN83LF/ddJaV6cKLTgMMd63ul1EzaSfYjTv6HSY yvWR0s96+PXloK+p55jfQcGgYBEmKjKeQbckdFsNpVYZRtYUILzsRBfk750O6EJHlfVC1QSanUN uVgaPzOx599m8twL31+j9cDc= X-Received: by 2002:a05:620a:3941:b0:939:c0b3:6d8e with SMTP id af79cd13be357-939c0b37c88mr163058085a.30.1788851463464; Tue, 08 Sep 2026 00:11:03 -0700 (PDT) X-Received: by 2002:a05:620a:3941:b0:939:c0b3:6d8e with SMTP id af79cd13be357-939c0b37c88mr163053785a.30.1788851463045; Tue, 08 Sep 2026 00:11:03 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5927b68sm453173805e9.1.2026.09.08.00.11.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 00:11:02 -0700 (PDT) From: Krzysztof Kozlowski Date: Tue, 08 Sep 2026 09:10:43 +0200 Subject: [PATCH v3 3/7] drm/msm/hdmi_bridge: Correct poweroff/audio cleanup order in post_disable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-3-dcf8956878ca@oss.qualcomm.com> References: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> In-Reply-To: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1240; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=NIsM6HvCeVJ35nWFFLJNWwCPf0RLm8el3fb5T4Hse0k=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqn7T5bK0YomfryI+UZIU9Qa8Ma7aQK72X//AJY Ac8FAPhtiCJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap+0+QAKCRDBN2bmhouD 11jbD/oC1+H811NF0TnKCwrr0Pqpxtgsk21hz36/GUYUtCUHvz7fDXG8dmh7218pz2qYSqvoC88 Fs0i81yoVdKcsd0TNM6v5wPYMk7ec2+scAC7KgIrxiupAFdnOpTHSLaGrg4HdnkHEZSKAkk8uoI XptY651pioNBvNz4rmjACNZU2Np44zer8aWXSlGtz5vde/AuYtqDAkHL//3d5Ql3NVjfzWm1rUH YIVqzbexMaV/wvamlkAtxr7J+2/el42mgj4PTMLMObB4peGbMpecUXzOtXtadDO8Y/AXMiwiSVX Y8nIO/GTvvtkIwc0MJseXE46JbLdt8gQngmADmIABFpJ4JRoa8zZJm+G/1gRVXxauruqgfmyTZh gj50iQGe+1Fvl+2vQ6KZ6L9fzJLmoCnrxRu9wAgDAcxeZWrjcW8FiUczqNBffcDrvymBAcjmSe7 cMXARBgZdeiu36dNcnfIOXDRftZ41cDfZtsgl/UTGDhq7KHPIKytwwthb4GCepicVpY8Dfne6n+ NoCD9oQCo02I2YO6Cqo6YEdIZIjhhC57rOmqcyuthO41K73DK7R0Oyk66aXdRuRLqSt89i45NUj 2b9t/EAon0M/ik/1j4fqZBCedG1Y8BVikzqZCjMBLmzrXdGS6V+QegloQXByLPIDHn+P8CIAnxD 4eAOjPmEhxoWy4g== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfXwYX8qwBgnotk 6t69YNvnknqyDcEk2+IdhpQC+2/h8smIfhyRPfULLIuI7shP684uAZMpYyV7Xz0FL4HrITFr9Bx SpDQVX2uCrLgMNs9JK7d5b+zBxM70hg= X-Proofpoint-GUID: HiIuSmzlwEc8sPN9YcW5Mtx4cuNGp_TA X-Authority-Analysis: v=2.4 cv=NsjhtcdJ c=1 sm=1 tr=0 ts=6a9fb508 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=agfB2vzvzBSRJA4gfngA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX3A2SK061Vrwa RQR08izRq0WVqaAvxtB/9sgLloupgveJDnf2ADuZ+v5NfZW9niKPaRL/IZUdsVzY7+OsHV4kBiq PM76kV+AJ9zOnKdc6LrxdpptZnv7gaq1nSYFtBcgwOmMiDKO/DmYHkPhFxCAkGDOy4Qg9OdJyn2 pgTOxM+tCgf73L51GbCMCF4BC00bIY8N+TZDuY7z2TXoMWDZiiiyQxrWf3iQssyJd4BTmjHu+nW NT4TFkiSpLi4ACsZz2QnvMl0foMS29QMj/j0lYeFy+epGFLrLyrUyREIrEIG8myb6PyMFr7dVa8 TkJaWNxJof06WGNfm/50+rVRW1Hq25RdmV8bo9oq/zI9PR9YRdrJ1wIZQDIdioZ0BB78SG3X5Tb 4hNrr/IQAq8M/q//i+1JgVJtY/3mKWkbkreLyslWi9swGUJdeMoJVddbqwzhSua9UaTfeNLvDKP FA92vclMaVHcKpZ4OsQ== X-Proofpoint-ORIG-GUID: HiIuSmzlwEc8sPN9YcW5Mtx4cuNGp_TA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080072 Turning off the power in msm_hdmi_bridge_atomic_post_disable() should follow reverse order of powering up, not only because it is logical, but also because msm_hdmi_audio_update() accesses registers thus block should still be powered on. Depending on specific timing, existing code could have accesses to MMIO of powered off block. Cc: Fixes: c0c0d9eeeb8d ("drm/msm: hdmi audio support") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index db85400e574e..1860605850c9 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -339,10 +339,10 @@ static void msm_hdmi_bridge_atomic_post_disable(struc= t drm_bridge *bridge, msm_hdmi_phy_powerdown(phy); =20 if (hdmi->power_on) { - power_off(bridge); hdmi->power_on =3D false; if (hdmi->connector->display_info.is_hdmi) msm_hdmi_audio_update(hdmi); + power_off(bridge); msm_hdmi_phy_resource_disable(phy); } mutex_unlock(&hdmi->state_mutex); --=20 2.53.0 From nobody Fri Sep 25 22:21:10 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2DF433120E for ; Tue, 8 Sep 2026 07:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851470; cv=none; b=QjZWqAMLyrYLPqWuItWtaK1btPidjOfEkjizQkPAfMPSDs0Sw120CeGtBHsDQ6jQWWhfj5tZc/0iXzihrxWIeASMMu50zANI3zpGuPSjP7iylobt39slwyGyw97ye4/8vP56p7i7kczIsAn3YC/P+urbZWit49xbdTxRfePWriY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851470; c=relaxed/simple; bh=DVXNSz/QqITCQAR3c9vgiIReGo6sp1REqUL1NIZWtK4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XQsr1MNouQiG0jsLHPPEI+zkGGr6yLAeB8jWomQZpNCSomG+ZjfUUe2DhfyHtNrj0IQEP+UuAseFT1pAh5OF8gD2QzMzJRPzywHAWgca+kL6JMVSuwGtmT2GzU1N9TCfWNXedH2/Xy2eMXXiM63WXkk+/noIJPxfEzmJvPd9OGw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nOVR+D3X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S7OzamKv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nOVR+D3X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S7OzamKv" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886Lr9g2502501 for ; Tue, 8 Sep 2026 07:11:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E0C2reVv1oSwnphcZX04pJknqbbG7msmctVikhe2z4c=; b=nOVR+D3Xa5S6DRd/ 1KKeE1mxAIPGXaULM90bjkDTDUbgxkoD1yEXL0wk37gs0zdkGEAoJGyIVS0WymQc hmK/V/7joRSlL5pOpdf0XjslTgJrvK/CSu+sBFOhYKn20Ubl5opN32dWaqRd+UbG t64JIm8tpLVVxc9P3aL5ycaTh+XSlOFprqrIYmpiyxlBYZvOYzgpZ2xHeQe8Wrlp /joKRVRy2fN/fcXg19D7A36CRr5fJkH//8yhdb+zGkxCiLMWlwSN8V30CODCBhcl FWYzMCs42c7Ratjzm18VRve6iOeDpos+dqdv4mj+Zw/uMRgFLevq+n39R2M/Uxrs m6Tbcg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjcv7g8pb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 07:11:06 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-9390a2c895bso881206285a.0 for ; Tue, 08 Sep 2026 00:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788851466; x=1789456266; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=E0C2reVv1oSwnphcZX04pJknqbbG7msmctVikhe2z4c=; b=S7OzamKvKV5CDYTt4kWeOb8Ie5cg7vQZrU9mMqSX1Wk9lXL3Q9QrI4+5Ay/DygxP6V jidXi1T7Tzt9tgB0vUvuJnrMVxCsIBGHlsjige/h3Dxv8G0YcfS/Cl8/JP/OHtIJ3gMO dJG4+6aJIvPLSmy+Xoj3SaHqGaRt8/GCyQOP17hh/2GNKoco+iSN22Yuw41zQE2zaCrR nBS+vXtIc/cphgDrn5z7Or00sXWhphL9bNrUHD5Xp3teKI0MtUJYXQMksw9T8zWgf/ie En+bhnto4shguiUJQ8jyuBjfoE6+Av/EBW9p57QOILD8zpG+4+9to25Edkdxb8k+eVff lmuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788851466; x=1789456266; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E0C2reVv1oSwnphcZX04pJknqbbG7msmctVikhe2z4c=; b=jcoTQbae9nGQVJQZVk0umja5KEZ6Kg91axF4vyDYzvcprqxRhEZVH1wA//uCQb0OEu Z+wd12fRlgaHmLNfaTaxMUfq+nKqE6TqAlLjieX1g1sZ5HfcW6GYJro9wzO7o5h+yM3H Un+67X516J8TX0cbBxIexb7/5YkUjt7TSdaARyB9+tmpyPVsKevFeODKXQgsiIUux6uB CjAUBQYy0owexZ1tsz/a+NIafZo5H4tya4PpCqS2Q5xpSqBXla1MtfNa0ELh6ORp7A++ ggvTuQF1sT+R5/r1ZTJyLqMbPiURPoaXCWPQ8yhRnvS9RoVYhLhe63jK+LoG0TsGpOlj +7Ew== X-Forwarded-Encrypted: i=1; AKwUvBwQmd8/rYAfJPkjHe2tXn6j9TAzsbdr0TndzmycLl16zXg4QnZu6m3q66kdRph7P3z4XXdZ0sEVa4pksts=@vger.kernel.org X-Gm-Message-State: AFuF++lmr+zewyVTK5SSeGu0KtLLxLmdzb46m/oQVsaU/BGDWXEYyPKm NcKDPFOA2qV4vTq/CG5kU3E6ue9ymu9ULuIExxMgknQIKbqS0XvmThmib23shA64PVKtGpwZKYy tlOd+iBLXtyQFtJo+07TXDQRn5SkEvLvC77zZmi0x0vDM2efz/7ZXT31/5PWPgrXfO8A= X-Gm-Gg: AYBFou1YRu0IyfDZEK6LyvmfsCtJelJ9h1t5+2XlPkZLYCdobhKyi8RqdTvf24DMdYL J2mvg8kDoaLaQru1DQmQX8By3Ydj0THmx/AQBXnd/jZf0yFxz85qVGFUXrmq/e9OJRHqWiyt8+e uKIj7/YmMbJhdtKIw3OX6+IT2qjEjDqcGp/p2ADQ9YtJgzWSnuM2TARq+5Be3D6oarlYH2INNiz 6hamO0PPw6mQj88UYqyVP16mEZ/yIDablifceRufD4wDPbdQwLcMkzF+i3RbyKh9E8ABcBgmBn7 PbSCskTm5KS6n8Xa+tVohKT8aZJF0qa0ukL4CvVGT5AiDiv3fvCQkYLTwpvtXylRHtudHXsuGL2 nJLUcb4heJ/2gDqPNDRx6++U= X-Received: by 2002:a05:620a:1a06:b0:932:fcb4:4d0b with SMTP id af79cd13be357-939806da006mr2798142085a.24.1788851466266; Tue, 08 Sep 2026 00:11:06 -0700 (PDT) X-Received: by 2002:a05:620a:1a06:b0:932:fcb4:4d0b with SMTP id af79cd13be357-939806da006mr2798137885a.24.1788851465895; Tue, 08 Sep 2026 00:11:05 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5927b68sm453173805e9.1.2026.09.08.00.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 00:11:05 -0700 (PDT) From: Krzysztof Kozlowski Date: Tue, 08 Sep 2026 09:10:44 +0200 Subject: [PATCH v3 4/7] drm/msm/hdmi_bridge: Drop redundant initialization in msm_hdmi_bridge_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-4-dcf8956878ca@oss.qualcomm.com> References: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> In-Reply-To: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=909; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=DVXNSz/QqITCQAR3c9vgiIReGo6sp1REqUL1NIZWtK4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqn7T6ccwdo8OoNNuiJLkAwQshlOHv5IiHfaTkw avBRqliwh2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap+0+gAKCRDBN2bmhouD 1yBND/4q44Xvc48hMxu1pda3s+T5mew5AFxVcvM0Vnhayn/pLc/O3Br0Ly/OcFOuJebwixVWGk4 tXe06Yq8vc6IB9NNzOZJS1mAhYdpECWPENX4auSJ3R6quDLguKJUNNsduorlxRQRJ4Xj4GnBNRK OlkzZqTCEy9TY7HrbZ9jCRawrXhczzP1E86LNgV7hzXmTbydYHkYpZce+CXDgaEhoLsgexnT3Qx rNsufGslZHQhaX/mlfuutiCkcYj7mz0BRpVLu+BlFKMp4p8eractYTD4jkaUsUtkt5lUrszwdP8 Y9bckC/HX5zPbpepFNoyWjPAnR0jDGsGWS7Ey9Q5OqpbpQPLDDH4+lQMlEEKiCdIaXYY3AAJdjJ XT7Uu5Y7TnMeUtMJGniF9J3lyCP6ShkwHJbxpchJueFdIG4JRTgwk/c/5bdoR1XdG8Kj7NGR+DG odpCkiZLllzBdcAFbMtmjHLLOkDkSRszbSw1c9USEwVOOWPKHiDstrrcwVM4t5QEYYNGQ3Y8EK/ YoClYAQACSCPEsv2u+pfAYhE8MJJSuFXsN1At847Xk1vH3/BKfg8tznJuX2FZmrRXhW48Vk4pAj 9XxyQs/YNWh54LNI8aGgUEtT/gEQr3z5XfEd5iPSwX5DuasRf/5SxuUIuECa1uFhhzf9OZIROCb kcxfrWQx4C86GIQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=CMEamxrD c=1 sm=1 tr=0 ts=6a9fb50a cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=RZP3y24nY_lDZDhlvS4A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX7+NSPgoR1UOm EoV2z905IesEs02pfqsaXa4HVDoYwHJY6ry0MVk94ZsxofR0LHDsrPbAdYTO4IDiRu95bFlx8l0 wUmBzo2SW/5stK3kElXTQr8NZ3e1Q+8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfXxK9vueVCnJTW 3KXvERjpW2LSyAURCEjiilUH/RW9Ao9+2WuziUN4Qa0Uw9CFjRjYHKvOeYk7iN16qpbHppCXC9A CTGsbSGfQ27NTtWXU2QwYj3tP4WYGAob9bk+SJTIYpCzuVU3ULF38M5K7i0DPHIbg78oEAdVJlB E3BkAZGhE8RKJceDAz8Pc8ZLyw1qAcltsDHIiHqbn8GAkx1N3ufaI3c8Q5hoBnNOpMh7eHBSpoi MA3ASwmJDD7j1Dt7R4hgv1SfPOKoUM22MCOV9JBK1h/j/dwX6vjRnwKR820dChVWstnP7lyaw5V DEeC/Kvuaka/eJ9x/FKWt9RjPvprDmQWJWdWBDn+KrvTRE0PKl1rRW+WdrUm73tghIKBLzk8UBo YiH9jdTABRqFwxVwis7bNLXPzKx/291odAX8enIWUtIh07rQY1/82hHq6k/ehG6hvsBCKyixleJ JAMbAX2eIc9xlZ07z+Q== X-Proofpoint-ORIG-GUID: h4aSasPEt2FS8Td8CXrxuU8oAff-fmL9 X-Proofpoint-GUID: h4aSasPEt2FS8Td8CXrxuU8oAff-fmL9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080072 Local 'struct drm_bridge *bridge' variable is assigned in ~13th line of the function, before any first use, thus explicit NULL initialization is not necessary. Reviewed-by: Konrad Dybcio Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index 1860605850c9..49587927e8a5 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -484,7 +484,7 @@ msm_hdmi_hotplug_work(struct work_struct *work) /* initialize bridge */ int msm_hdmi_bridge_init(struct hdmi *hdmi) { - struct drm_bridge *bridge =3D NULL; + struct drm_bridge *bridge; struct hdmi_bridge *hdmi_bridge; int ret; =20 --=20 2.53.0 From nobody Fri Sep 25 22:21:10 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246D6370ACE for ; Tue, 8 Sep 2026 07:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851471; cv=none; b=CUc4Ga7UFpWwc7GDUTQgIBiraNgUqkGh7zDZjHhn2/PUSWlMSb8rLbBuCKx/AmOsxkZb0+/w/ygMZ/IJ51nIZWZG3qtu7ihuXUhvsQ0nQQSQTpCHEuVvAJXN+V0r0fLszxEdmAjtKDbA/dML5SeC7OzyIrt8i7KN1crCzA5uKRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851471; c=relaxed/simple; bh=Wpzp/cK3JYV/8SlC8t8vd470HwV9IihYSTjTRLAsIu0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hTEQAEeaR5HDRO5DCugQlZK3ju/ccSWEXzw6nLHv4Y4HMF1gSQMJ9xcc3ia270tDbyoQ9tfOwQUG02tgsF9CmfN/+ulpUTjta8NRadwi9UzaMW1/93l8snLVUkPgiASx+xhkDNmUyEcU+X8PJWZm9+6+f8vQD97anEMbQj8IizU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WGcKJ0ca; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ii3JAsts; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WGcKJ0ca"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ii3JAsts" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886LdYC3299143 for ; Tue, 8 Sep 2026 07:11:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5f4iUpOb3yH3JsFpfvQ0KdsnnuKnbeOttiwhu6PZwtc=; b=WGcKJ0caoM3MNYsI kTAtfJAYbYZ7Eywwr4p9/VhHn1ihucM02V/Q1eKF7bxhvo7wVjWFP4Y/5ZkNGcWv 8U9UhRXBx/XeDfDp147sptkMKZG3rOQufbQLDyj6rRlwG5y/i7QOUYN5ImD+qJzp eOLJdf0amU8mKWoB4wCmXH8exhs6+soAY7PaaoQXt3oScaEPmPDqHC6+vY5SA3oE wkHMRze+q/VquDCRIQ+Fa2e6Wbq3bvz4eKplzRBa6IGcm9j4OeuPs3/y88rO2wEm iHxYf3zkq+AMlBHMobx/U7nzlUnE9S5J+1Us991otwt+6XPh37GB9ewLmlHnSYAB o/kCsQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjb0p8mwt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 07:11:09 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-936e393061dso552719785a.2 for ; Tue, 08 Sep 2026 00:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788851468; x=1789456268; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5f4iUpOb3yH3JsFpfvQ0KdsnnuKnbeOttiwhu6PZwtc=; b=Ii3JAstsp6qUZglM6MRK0z0pIBk+idLRQlmEDux9hGo/gdyR/aA7YHx1POcbUqnikY +kHBg43ixHigCM+7ooiRxiFnAW9z8cDGq/9bajkcV7i6D/nnCZ6tTqpvCil3zhskb4+1 deos4t5k22U+gFBrjzNFhgGLWgErBshFXhKKMnGONoAlyRpC5vYd2q7uTVhSZLDyGR6/ oKuNfDiR6RAk1qBM5Ozyawf2BhAgRHS/SvJkQzjAGZsvTdrc3RRFhZBM1z/8SCrlb2ih 2UI7SPbmlnDa7K4GWuS1LasuHcIOWC2KVjKme6Cf9x77zSFCUXbLWwEZTm838vDo32tf z8vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788851468; x=1789456268; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5f4iUpOb3yH3JsFpfvQ0KdsnnuKnbeOttiwhu6PZwtc=; b=aUDPw8PNw6qwZHwWm0+DBDeVfTStM5D01Pp8UsGm6HAd+bXe/h+9RCLwQuWvV+L7w1 ztFFrFBXPKNNj6NiU1bwgxAriuV215xXnsQ8D8cj2/wqBvoYN2dDMvJ+emnWHPKeNr4+ TQw6YTMQol5W77YsVZDbvvyOD9NSYn92BYYoSd9cmwzUDnFQhl2dWZjsEVa1bWiEhzaj iZGw0NTtq2edQ6O+Qk6Pfv8Dq8IBbxmwRx8RoJWypZUI/T4+FsI6vv1CkZg1Z4tgD31l c+wmkf12v1BytpLD3fvy6yUraq3b8vmdg8fEygsjchLusPlPRkUUxRAF5aPqnw+w/08J wgbQ== X-Forwarded-Encrypted: i=1; AKwUvBwQYNpBy76Q3ys6n34ICdVE6s9/snc8rdLMT+OHeqBA3vNYqIm9/RHurkYJTDnZSslJNtiUXRlL3V4WwGo=@vger.kernel.org X-Gm-Message-State: AFuF++lnSiRGVM59/5tXJvP+aU1j9/KM5rIGRBVlLVs+xI6ovj55ZeMv b0onrri2JWGUj/CAMgv8amHduLB0OI+wpZkGb7WQgbS1AE40Jbdwo31zKwxyjT6oXQdU3392b2p tUJCTKHdrM9GV833Ypq0PzW7zdFtVBEjyxjfWGd6UutcvrNRkIn5yGR8S9XrVGRyiNQY= X-Gm-Gg: AYBFou0/kldieDqjIM4WHu4iU7RRk9Nh6SKSmDzMItkO8h0jG28M3v/rprkU1yb3ZzG wyDSj5jglyZNOjhNLBXOhoyKmMDbo5fHyKKOapsV1voojrGlTy5E0bVGotnykRROPQSOc6PIeMx VJYEDuswNvqvvZeqAcwUdP7IGp5BDOgqar6E4uM5O2PorOcbRWfESsKn0foJv7nz2ea8IgFrjcB 2AFHfdnnWl+dFA238hhVxltNLD6EGydKmtDYlzV7rZgG+i1iuNk7e76wg4hzP9qiFOYLXsKZykt 8UaocgnBclLEBBCbnk8vZ2paszKUVeT96CmV7w6C1B0urDuMmuLmAgET1ODgibf/oRXIbaQn2C8 YOSENVR9I0owj5PFWMMRTPb4= X-Received: by 2002:a05:620a:6413:b0:939:5cd5:e243 with SMTP id af79cd13be357-93980324c12mr3025893985a.6.1788851468430; Tue, 08 Sep 2026 00:11:08 -0700 (PDT) X-Received: by 2002:a05:620a:6413:b0:939:5cd5:e243 with SMTP id af79cd13be357-93980324c12mr3025888785a.6.1788851467992; Tue, 08 Sep 2026 00:11:07 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5927b68sm453173805e9.1.2026.09.08.00.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 00:11:07 -0700 (PDT) From: Krzysztof Kozlowski Date: Tue, 08 Sep 2026 09:10:45 +0200 Subject: [PATCH v3 5/7] drm/msm: Properly handle msm_ioremap() without name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-5-dcf8956878ca@oss.qualcomm.com> References: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> In-Reply-To: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abel Vesa , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1351; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=Wpzp/cK3JYV/8SlC8t8vd470HwV9IihYSTjTRLAsIu0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqn7T7GoYekeeNs936mhSqK6BTQzcjxgH/n/DP4 3PSvBcLAmKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap+0+wAKCRDBN2bmhouD 1y4FD/92yv8+hHdjHnG5SA81WkyDML6FYcE9zaxhdIMgyRMN20VVvPLGmh5cuUShIvlbKsq0TzI T/b6Rel4LYsz/QtZJB9DcGki+3k1DHDpmiEbqtINZk3dNhqdABLTPi2rCHYg5zkIxsMrkqRcNjo vTWdv/fEFpNC7n9dJ75Y1AJiaktcoC+M1Rup9bmEREZvW1tZr/KlCy++WCr8Jtsoz6sYpZz5kYE lAUaHlfFX4wc62YvBCalhyctCQMw2PD9Jb/wo9AMLkGNrb/lnj1OzNP3q77oKAuYOflY+G+neZ2 UqNObT2Is4xuc2WVqtqSMaLRnKtAGEeNMDWj2H5EvJw3U2Wx4WZ9OX372zgSTBnAcy67PS9ybH9 rRDzT4QnCDLkVjo/5wJkIOw/TILMPymDK/VBd9ZJH77AZxWckUmAWO7zASl2neMk78F3rHZOaYW kyuQMR17A8mrJqbYxD+ZUKNKKIfiee+HcBabo94KkSu77Ul8XX2E+rotqFI4dKU0DPwqQNmW1qo nGly+iA47fok9w04upya8/OmXgpgyObpaTLxUTJAyqYQnAyGfwx5A8OO4lqHHs39Xfdh+TOJ5H/ 40Yp6xcWuRpphG6oucHjBPUpQPZgBnzWAtr/VhhrpSLMNS85SwRBjVEhcVhbKUJ77L8XusVizD5 dMPXziW8Ml1jDsQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: yRgsdauGAj4ft-NVJScevi3jAiO6J7rG X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfXxop4OO12YfuN jm/2FO80i/4SLAM1+ExDg/KI9r6Mkfnptk4X/KcLlBblpIW4OHngIbDtGyePLgR6oVPrmIfYdvA Y/9HxOq0Z4uUD0Pc3ZSqo7iFlAqJQuQ= X-Authority-Analysis: v=2.4 cv=HL3z0Itv c=1 sm=1 tr=0 ts=6a9fb50d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=or9nyMeYumr6D7LEzWYA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: yRgsdauGAj4ft-NVJScevi3jAiO6J7rG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX56UA8XDoSM0D InMbADyqFEkGMS4m5Ypm9U7Bhvlo6NNCzN1GJ8/PEFkZbX+F8uGP7CSITDBn+o5SkGwob1EmApr 1arLv0CAwJBh4nMc1UEU9v/CraDjfmIODShZ0us6bFloRJNAoO0owLJ731DgFTVgdlgzfDRfUk9 3x+nJe7G7z8gHmVsLTIOsiBQAs7shGMH4RYjShX58JXt3jMYAEqrVzaZ8aR5mLxTSJtdfZsPUtM ljJo4n/+bJ/1tuskKF0hKAbbYff3HdPEd20x+YrgfZl+1DazjIpVdmy/JUTDmLbr6nl9L6I+SqY 3w0TWErYI1rr7xZPLGYswwb7zQHFsX2JRz8fy4siJb9TMSOHw8sgR7LAbAWurcHFQZWKEhcdGxn kjXTS7rETWpyrkRlzxJcbcFijJKrXxnDV91T4C4bQIKrq7NwuBIjTQN/uhXFwOouueSoYGHMML+ C/U0EsnpZBk8KdJYQig== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080072 msm_ioremap() accepts being called without name of the region to map and in such case maps by index 0. However error paths still use the name in error message. Reviewed-by: Abel Vesa Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/msm_io_utils.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm/msm/msm_i= o_utils.c index a6efe1eac271..0a4ac0fc5fb5 100644 --- a/drivers/gpu/drm/msm/msm_io_utils.c +++ b/drivers/gpu/drm/msm/msm_io_utils.c @@ -77,7 +77,8 @@ static void __iomem *_msm_ioremap(struct platform_device = *pdev, const char *name =20 if (!res) { if (!quiet) - DRM_DEV_ERROR(&pdev->dev, "failed to get memory resource: %s\n", name); + DRM_DEV_ERROR(&pdev->dev, "failed to get memory resource: %s\n", + (name ? name : "#0")); return ERR_PTR(-EINVAL); } =20 @@ -86,7 +87,8 @@ static void __iomem *_msm_ioremap(struct platform_device = *pdev, const char *name ptr =3D devm_ioremap(&pdev->dev, res->start, size); if (!ptr) { if (!quiet) - DRM_DEV_ERROR(&pdev->dev, "failed to ioremap: %s\n", name); + DRM_DEV_ERROR(&pdev->dev, "failed to ioremap: %s\n", + (name ?: "#0")); return ERR_PTR(-ENOMEM); } =20 --=20 2.53.0 From nobody Fri Sep 25 22:21:10 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DEAF3AB5C7 for ; Tue, 8 Sep 2026 07:11:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851479; cv=none; b=XSsaB1aYcCJRQxgZ98qIjsj39GzLjJMvD9p6KaQWIGdAy/PaP72T5ptD46Ev7hUfsTu6kEKElsaBw5MtHwXh40lF1snsSGt8v2KvmMRKryNsRRi+VxpwUiSjSPKUhiqGccT+CqmSazdR1zwDodJQcbEHkwqyMm/Vbj5lxcWKx3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851479; c=relaxed/simple; bh=/YVh+L5neHC3SlylyZSkY52kedS/7Okrqq86t4o1xdw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ePZ3gvf2PbacWiNoS+YpnPqwlRUkgFGxhk2oinbVsw1HJxLmupTLtVLqQpRoY+iwkYrZ5gF6nvJk0xc3gYO5Q/67LLQFgmoCRMKrHQzg1b/VJeSW111ZO1++Cw5YRQ+XW6SKUFsHmCIjiOOJezjAJoVzMTfhvvmuKeBeOKPvlw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YWd3/x6x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aGJwL4Ur; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YWd3/x6x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aGJwL4Ur" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886M2rw2363262 for ; Tue, 8 Sep 2026 07:11:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vizWdKJGFAB1HJu6hwMtO5oQyxT7j0M+cp6kkFJFsqU=; b=YWd3/x6x6QElHoo/ Rq8maYDdWwher25gq8UvsH8W3wFuQa2RmH2XzDMv7K+tGRdHf+h/8twJl+GHU9iX 0wo+M0BLuKh4ph1BU/Cs535nTfu/LPvk9838UwAuthFsajWrjnoFr0xnyJufpRbb lNLcmkcFHzsE9um+ZgFk3o0Gf3sFU1USjsx66LObA3v4XL3Q1LtlZboRnN1pbpc2 iBNI+ptIRh+kST4EOJksRqykPVxq4Vbc7QwPYQOdbjzNcYaw4UUFmW9s2m11Mi9n OB+zwPv6s/G0Rb4U0J6u79i7zHLwu0cfLolmLYHeSrvBvhX/FiK8QF49ajPvmwh4 VKWIkw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjagugrfa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 07:11:16 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-933023a5980so315440985a.3 for ; Tue, 08 Sep 2026 00:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788851471; x=1789456271; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vizWdKJGFAB1HJu6hwMtO5oQyxT7j0M+cp6kkFJFsqU=; b=aGJwL4UrBk2szHj6KgAeBTvx5ov53W6AZM8s7JEJgVqSyZCm31ShXbycxKCDxsXdtA QyWtDTHzShYnV3ucrwkRpRMB+AFqfurL36KakVK2PGteryPZHVC2X0hs6CvGnQpY3MvC Yx7NmQHna45606+JYjiJ3Df0wTDZQytSTD1Jgronv2Cf1kQbuiduIUWwe8DQTSoLFlC9 jVHmSrEhGmcx37jBsbny904TjwIm8jf/TW6lvA+7v+Gok73WiV4LQeh+vz73QJCKJQNa vyeH3DP5J8jKJfA/LSeUqFXqMkVk6pfVPEm8Bcrn5ldP0r9k93KZVB3xK9oy8QSn9o3W DBPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788851471; x=1789456271; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vizWdKJGFAB1HJu6hwMtO5oQyxT7j0M+cp6kkFJFsqU=; b=CsOxjOOdXiXYmQhWdBgVSmeLc+IuKQELHzzL/GCKKCv+jqmVNBVEgvz0BwCunYqUNd OrzVIN5evuL4VKUNKPbhiJ4zWrZnZV2UKeYOQnOvpx1kyidDjBApmAFeS9YnChhC3O3g +2XlgdZhofI9roCv5kWTLwtVHgnb5+egarKuTgwMXAYjXT6SxHFvQF2yd+C3/1v5sAyV kfsNE5eKhxg8Klf5vd7EEsu3pNhG5uNnfwgk+I3N85KYSK4vXmtLCc0FGsdFPH1hKHH0 qxHijKCoaFjaspQPQvxJ9pNJipEAWuRPLR+xpWiSZdgJEYr/f6djjdbSgR0r7FKtbv70 0K4w== X-Forwarded-Encrypted: i=1; AKwUvBzDjmfq5LZOJeWetWnJ+qTLG9nDMc1kOt7hy45/BeWECdmihdKcdDUtL3cn+7Brmzw5p4ktBNrrm9soPfw=@vger.kernel.org X-Gm-Message-State: AFuF++nx3lANmUkTHwptBH18CvGrU2ogzUsDRX4XUcFii59Ep0WGJIKY lQRxzbHHqnZyBKu6Q26Yxmm/CEZzfdXEM6UIpyz9PEabMKtDwsmaTPSz4rWlnmC0VmngaYT9ui5 sIVS1wTEYEyL5qjKsxOP80uXlnNRzFR6XuzrGQqQSqMso8+CwfkTfTbEpBRsnzWup7iU= X-Gm-Gg: AYBFou0WzC0Fmm6u+wsJuItapIx+ym93l5bwlcoS3C0sEux62WdlSRhlORI5GWJQvKM VXTwWGI0Fdh20dbz95IcO2L+fXN94yI3Ha9w8Gs6RjwNVx562uU9gCmq4nu07DKeipHAPi9LIt0 V2jISq6yuDUkfkT8UOSYQStogUNimbA8Wu/C7wU7CAl+k1F+cQKmoWlK8adLFcMk0ivzZvaD+Ud tSq+7bZPU6T26YJtRBp2Iuq3y2Exhq/aDq7aevWp2TCPfGOGXvXv3M1mNRFPIqlOvg2M1a3nnAJ jQTXmxek36ZTyLpycbq7xiPlZ2eGRAJZ0YuSup5SZNTl1rvvCnHsvXWvghYXmLMC9qUexFXmKy7 yOzG9Zcyz0V9zQ2Wt+bp2Wr0= X-Received: by 2002:a05:620a:404c:b0:939:df5:977c with SMTP id af79cd13be357-93980361c84mr2939058485a.19.1788851470956; Tue, 08 Sep 2026 00:11:10 -0700 (PDT) X-Received: by 2002:a05:620a:404c:b0:939:df5:977c with SMTP id af79cd13be357-93980361c84mr2939053485a.19.1788851470435; Tue, 08 Sep 2026 00:11:10 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5927b68sm453173805e9.1.2026.09.08.00.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 00:11:09 -0700 (PDT) From: Krzysztof Kozlowski Date: Tue, 08 Sep 2026 09:10:46 +0200 Subject: [PATCH v3 6/7] drm/msm/dsi: Fix indentation of if block in dsi_mgr_bridge_mode_valid() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-6-dcf8956878ca@oss.qualcomm.com> References: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> In-Reply-To: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=859; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=/YVh+L5neHC3SlylyZSkY52kedS/7Okrqq86t4o1xdw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqn7T83kk1ueDOHgN3MC+5UmBLJIc9NjJCJ5Y7N DmU5EQiskSJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap+0/AAKCRDBN2bmhouD 18SDEACK4ZXwaPj6vlMd2riLCLR4YgeaRdhNMnQter3mdIFjzJ9Fx0TqmUYCGzTgr9rOlk0jNSQ Hnx7vAlVwuwbioeZsA5bjMNPXGw3VwhJeJoAuc37uDcKqyQSo3RLX4GSBkpA8HO/SBrmUfyZEXb IdSq7wjCudqZpP6sQk5pphUO+LkYKjmpe6N0GgEfIc33FuG321rOGZR5ArA+9dnIX4k3QbBAmcG rW5KiumnjA1tjnisiypPgxRV7b2bkRc68jBTjOGd3TIYSNp9+qZfhDzCRFJfrOCCPQ/1749e/eC FT76z4ygQB7IujEvsVO4qMDYmb+orXblx0lD8pYiO0tdT9DmwldC8gfSuzLocovqOMQrQM+pET2 LsXzK8WiB0DzeBhbYBDBUqgUILlNI2pMEofo0XIE8nhZfw8SOBCY5sLjBjP74fWjXWbaZPsdksc X53CyPj+sPfLrwbXuhwYfPuSC7WPhEfMxMQQPEdfRUvJZxBq1L9MkgKSBLTK2yJNsQMOe36I+Yj EAcBpdz73gLIY+KaBK2MwfDTWuF2LRQPKUrwmBCLFG4URcm+mvgAf1azEw72xvq7nu7MxjLcxi2 m2GopMOFMiJ0O/vjEu23P6XqZMKPPkqQYFd417E5C2PTlmSSalZxeQ19mkh+iARDvS9e4V90XpG 2Bl4iljfW42V8DA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=TqLWQjXh c=1 sm=1 tr=0 ts=6a9fb514 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=mamL7KDpJlut8y4y1IgA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: vPSdDuJAdn9VBVBdY6zKSyCkCe8uyeUF X-Proofpoint-ORIG-GUID: vPSdDuJAdn9VBVBdY6zKSyCkCe8uyeUF X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX+Iu8YyhOHzth yie5BM6Z8KFpbjf5/OdAPBnporuPRKQ09JFWd2ppxi4uw2783pAtWGTtuOubAa6hA1KK1ancPEC A2ah48R7Rvx8XCX4GPgXgSQ9qHIcP/A= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX33vzcamsYCu7 Az9g01tc/3nZl8VkVqj4R8MFaIe+XlFUvLvHp/1xmqgJ3Ho37U40Wqy7URX/UDGOA+TVLFigEnY WqQrZWInNn0ehrJtInFO66mxNdD36N1cFVDRb705vy9DQeKnRjnEtj8QBPKnwu6l56ZIa9DSjwl nLxCJMVcAfVYAXc3b0l0SI+WTCtLxgA3GGOjIftJHNg8w5+GzkG3dhGPskZ3tFpZG3opjqbclPJ KJVF6Y2gF0uEXKbicWf4dBr7j0EIijIF4H4sbcyK/LzOTIGNl+DiU+1QrnFWU3kU+ixurzbFsbb 9Zldb7CwIE/vWyMA/8iP4TePFkXbO2Oy/ZT93eIR28SLi/FHnddhqCkZjo8cy7nZ9yL2nXBKCQ8 owV7gv6TZGdS48J6k4d+OLZlPCZtzkgh9g6j3OfKOzWEXK6DUvepkUsjdx9qK7+RdM22daLwCAi X1ZIHZtI5Mh0tlYww9g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080072 Correct confusing indentation within else {} block in dsi_mgr_bridge_mode_valid(). Reviewed-by: Konrad Dybcio Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/ds= i/dsi_manager.c index 959daa88b1d0..531d4ff78f56 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -429,7 +429,7 @@ static enum drm_mode_status dsi_mgr_bridge_mode_valid(s= truct drm_bridge *bridge, if (dev_pm_opp_get_opp_count(&pdev->dev) !=3D 0) return MODE_CLOCK_RANGE; } else { - return MODE_ERROR; + return MODE_ERROR; } =20 return msm_dsi_host_check_dsc(host, mode); --=20 2.53.0 From nobody Fri Sep 25 22:21:10 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4E663AAF71 for ; Tue, 8 Sep 2026 07:11:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851477; cv=none; b=lMKwJQmxWPpN21juxKfELEY76/tQEYxc3KD9LHeM95oQQnPZpsekHDNAXpr5slHwJCN7ozR8a4bLfDGePLJGzvDMkxcHt2L6K/om3UIIkycc4r6qhbHRItuUDbchKPkesCkltKSLI4fyvocBH4MlROlDvISWzxUl3nvMN78Y62o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788851477; c=relaxed/simple; bh=dxt0nRLMlCSOHXCt5GgWA+SbZAKlsIeSxAesz/KABiI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ewPDjkFsd3CGxIhwp62vLTapjkT0Io7FGWGpO2FsZ36Czr9T8txAF+87jjqp+PeA8A4OYIddnIS5Y8aO7qIAGAga8lYQQwKztQdIjf9JEpILCwbbHeJ9XG7Kea9txA7H0Z656QF5OcJ5Bq6ExyurtGAiuiMmkbpQd6A0umyBsFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GtPmM1f3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CF2YLa+e; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GtPmM1f3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CF2YLa+e" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6886M0IA2979113 for ; Tue, 8 Sep 2026 07:11:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5Zxd143ASUomJNNgHPeOAeQIGghuC3wI/sji5Dtl2sM=; b=GtPmM1f3isY+uh8N pdBqgLuXJb7JBeJA2dPIzkM5geLG5/9uRvpMY4lKxfNVf3A023aLEFZBiajDFqLl 6tiNTA9BqFC7NIKScvsugAmQKsTjBZ972F96fbAR3n5BTtwAHcSHmxIdkK8EFJ7u LqNRRc+luSSfnFXauixOh0q8LJu4IWf13TwYiicrPlM9tmc7BjV332qE5DM8UHXk 4VFPDOMgCvr4NU0DP5A899uOKOjxij1QyoUaE1K8DGhcP87PjMoyUk9s9VHrjP1R vxF1ycJBzQ4KE/SsQGxGVPNz6MO6MSP6ppYTFHOjfixcXaIjTp30kla+yfL1oHR7 6Egv9A== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghuykbkbj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 07:11:13 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-90cddf4f59eso72943766d6.3 for ; Tue, 08 Sep 2026 00:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788851473; x=1789456273; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5Zxd143ASUomJNNgHPeOAeQIGghuC3wI/sji5Dtl2sM=; b=CF2YLa+euET/dcVYtIRJgEN07kgQUnxBjpMiYhy7phpgJaM5Ur4BZ0C6lOAG5HF3ME GHLz6ygxVAkbjD17WbqsUF9JIR9razmm4TDGMa32wf4yDOxMiR6j6b/1R86FdTSFMYxm ZeI6C19h4pSGWdR4azOPEm8ihffB5sxFiT+1Niiiar2PvXWM5jY+F/J5MWR3bnacygy0 Om2o5Lxy+zEq2W6zSZyRehKnTSGaxTa3V1WCnotJl233fJAMSblRHY8KIkfolTmHHx9T /OHTfbEvSZQmUPIa27bF6G+mpc5rMKSdwVsqaLM/bd5mx5AY2b6Ipmhu0FlXUStDuW7s pnBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788851473; x=1789456273; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5Zxd143ASUomJNNgHPeOAeQIGghuC3wI/sji5Dtl2sM=; b=UCJtxAmwY9QkvQZO2izna26wX1a/3g+8rmc8fOdUios+ITcuVIW0JMKbgqhBeBctcS z6HDJDvfyXBMwLdUONyGuFtPw3Rr9jWygJ7XjyKA4xuSA6E+t1smWR6PzNxODy8lx1v/ Mimk1QTwav4JWOz5jg42nR5AFLLjTrw8/uBJXJC38o54ndIjtUyUD0rXekXyVX9Iri6B 1UR7OLvgse8Ygxcqh8I5d6uzXaP078BQzDwD7U7iN4WG0XAiNtMb7KUyST7+eOAbHO7D D4IfT9faQKRq1wiq5iB1GOPXfFxTKT95OVhF2RhNNzFisjqFgAwdKb2pJohXYUJcp9lE ZEPw== X-Forwarded-Encrypted: i=1; AKwUvBwc6O30LLcVa0w45VWd7k93aVGcOccPBiRLyQfbN1X/LecQAGg9pjeJBJkL7ka28DHV2TqXNbX4zyE+z+c=@vger.kernel.org X-Gm-Message-State: AFuF++mzoBfLrc27PtpAYXTJm3p8Ela6kJzdGZKe6+TWGOXRB5HKBtJc wKx4zaAr5Zz8deSRqEz3n9qPVw6I6xevnqRL//LWDkecd7MbbZJIiZ66qY4DB61jEZNYhdKq+R/ EAUqG+lHWnMzufk7JlRkKy0AXvzlYHAKuT9AB3MNSVyofNA+Q8hJkmsitPFo89kD4KwQ= X-Gm-Gg: AYBFou254k0C1IIs1P08pa7/U3uhCrGizwBvO6YRH9X5XEZq0urpjP8ZeG1kpcA0m+H UmGoDkNQVrx+YLdzfumw4uDf9A07tHHQwOTbEhPrd9sOLx1KgaBESPUAU610M44Sfvlt5R+vkjm +ksijA7XFaujomSbC95N323VbD6/O7kp6szvq/BXoMa2GbqnzXSfFtCET0Aqa+NvZht2tOsQJsb dX3hXDRU/CNcMpA9u5FxIVjh5bPbdQPkD/eyWFt1DjadBcYndj2e5B5mUMVZ9qug6hmnUSqMWC0 PyfPg3yZr9Os60P3evmv9ECeZEeFl0AGZhibZUmnM2pQ9sX3/moGea+gz2UtsiA3PIN41c9u+wo oCEkwj9QcBF4eoPSCuEDeqbo= X-Received: by 2002:a05:620a:4386:b0:939:ab43:77a1 with SMTP id af79cd13be357-939ab437868mr1036813485a.6.1788851473068; Tue, 08 Sep 2026 00:11:13 -0700 (PDT) X-Received: by 2002:a05:620a:4386:b0:939:ab43:77a1 with SMTP id af79cd13be357-939ab437868mr1036808385a.6.1788851472658; Tue, 08 Sep 2026 00:11:12 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5927b68sm453173805e9.1.2026.09.08.00.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 00:11:11 -0700 (PDT) From: Krzysztof Kozlowski Date: Tue, 08 Sep 2026 09:10:47 +0200 Subject: [PATCH v3 7/7] dt-bindings: display/msm: hdmi: Correct name of disallowed supplies Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-7-dcf8956878ca@oss.qualcomm.com> References: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> In-Reply-To: <20260908-drm-msm-hdmi-fixes-before-eliza-v3-0-dcf8956878ca@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1120; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=dxt0nRLMlCSOHXCt5GgWA+SbZAKlsIeSxAesz/KABiI=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqn7T9MnI6ATGiwoaT3dl5k4X9A1cAjL6JxfQxT tHgqDDpmN+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap+0/QAKCRDBN2bmhouD 1159D/wJEN5EBolsu3UWPjUjuiwXYqvL7bczKzQULBtpg205n35tDaTi75OTlxy1e9JEgIRrQam /+VQ4dojOQuXB7Rm5XKKYkAM96q+S4z7JWRi8GD4roaJbPWlxLAOkFjsLfQR7okQW0L6Jae5b56 qg5t4gmct2lyrOVYZ4n3m4EGz1vjf+AttIjwKxdaXOFFBVfDsz8X9n/ZwoyhwhhvlfpuRa0yqzZ /GQiVg3TlnQIGlHh+MGoN57q6aDjdD2pDf9gtS8uBlSCIJOWsN/REIMM9ydibPl81DivKDnFPkw 11nuWJDSKkdiJFXMoqKW9IPeDJ9RtCnpJzqkj5Xuq7W/kb+jQXHZDkn+wuK5U35YU59B6TGicQJ gOh0HlYFeIww10cex+Ag2zFis1gMzJL+8n4CVL2CbCyn0EAQ/Z/6+876Tbs3p5ZZqeVSztP5Afl QbRkVOQdrawJGCrQMi4atnXequexJkSOi8Wl/F6Z1ttC+aQGxJAGz+59+ef81QiH8jrlgZC1ile U7g/lj2XMEvhTUtvHDK0aAqIMGBffTNeOiRe84i2z2twEuM+KUBSCMPOEEHJw222BiltuPKGtgT RVJlLPUj+P3zm0XsUhuesMJeHN8lesO1hrMGrDWW3GYMWwML2nuqLSVXcM4B4SBtLjFXqkKiWbr FzBPqMDD17Y6ZYw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX6Ut+rArcUPxf cIKnoWdRIpXpkoERj90fNKBIb4ZytP/8U/aYxzIqmuLiqHwiilqGkDufZDhF4U1hr3fmMhohM8R gB2dSgq7pwlaXdQJQEkgRrb03Cf0NzY= X-Proofpoint-GUID: 0PHbKvoH0RqOuQaK9tZaktKVpfjG30v8 X-Authority-Analysis: v=2.4 cv=ObSoyBTY c=1 sm=1 tr=0 ts=6a9fb512 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=LSMMCDwwRte7x3nqQVUA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: 0PHbKvoH0RqOuQaK9tZaktKVpfjG30v8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDA3MiBTYWx0ZWRfX512yP/uJETdi GpFHI6TdRhS7KZdXfPlmBFI5/UtvEpYLfTOpHOZLFcQlVIJLH8qgCGpHTZ6YvczNN4S2xwXYeQZ LBI7fRP3Zs47FYFdSFU75Z6R62ARF3sjbwjdyz+u6Eq1/GKbYJgduGmbr4sH+8oXy7GmMYTqwST 2GYOu/pexVWiNDIv6iRGBkek7isYEK0wDgttsLHIL2aQ5AcoVUkx6pQeT6zhrc67DAiuW5YKeYy H0JV+3/0eMTdG7zijbgubvStClPwYNe5DcRFvXfje4KOaWC4dRFbldS3uZYXn9WgTHPwqeGt/rv tP3KJNSUFgSK3vouSvl2eIk2YWjKq+2kkSPynqnKysnJsBRqMFhFSdYn553oL/roitTsuMynH+C b6P8SKCLTUoy4AtPUrMVjkvTtGLUlZBjuQjmv/tFUcrfrnWVHnsrxvkRzsCU8jU4cNIT9gQ9Og2 fmURRmWuinm7aCtoH4Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_01,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080072 There are no properties in DTS or Linux drivers called "core-vcc-supplies" or "hdmi-mux-supplies", so the binding probably wanted "-supply" properties instead. Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley --- Documentation/devicetree/bindings/display/msm/hdmi.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.yaml b/Docu= mentation/devicetree/bindings/display/msm/hdmi.yaml index dfec6c3480f3..02d27ccad024 100644 --- a/Documentation/devicetree/bindings/display/msm/hdmi.yaml +++ b/Documentation/devicetree/bindings/display/msm/hdmi.yaml @@ -113,7 +113,7 @@ allOf: - const: core - const: master_iface - const: slave_iface - core-vcc-supplies: false + core-vcc-supply: false =20 - if: properties: @@ -136,7 +136,7 @@ allOf: - const: core - const: alt_iface - const: extp - hdmi-mux-supplies: false + hdmi-mux-supply: false =20 - if: properties: --=20 2.53.0