From nobody Sat Sep 26 01:03:52 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8D12E400E0D; Mon, 7 Sep 2026 06:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788763916; cv=none; b=A9MBfkPn9fSGqCae3CxbOptrfS7Ts+MhdfWJEYx3wYZ7ZPHXe4PTMX8fGnfXC/x7K9CfnIvYD2BFqD0IA3MKLZ1UGacZYkqg0m53syjxGOcd0zQ9fxskav8hCVXI+y9+8WCyj2BtNNBTr4Ayb2V94VKne4Yq5vxLfsRye3zr/9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788763916; c=relaxed/simple; bh=scDfxyhNg1bG79fwu6qx21uFWXyGYIjw4uigagAZxBw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WMpw+CNRD+oFKs5FO1aq3PpBDp/LPfEH5NnXe2TN0AKonkk4StCQuEB1aQ23j92rXo22XjaXZpF+kjTm2JSd09HQbr5z9K75IphGN1neGmAAGI39hB+E0zWaijlEZC40+gVp8MbV70AZtokg+/J/qc5POsf/xpn4hHyCoopp2jg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=LSvcmFN1; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="LSvcmFN1" Received: from CPC-namja-026ON.localdomain (unknown [4.213.232.18]) by linux.microsoft.com (Postfix) with ESMTPSA id 8C88920B7129; Sun, 6 Sep 2026 23:51:06 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8C88920B7129 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1788763874; bh=kwT1ACYBFBE0L6UHReIYgcjonQdxzEfTZoRpDkWPd7E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LSvcmFN1tatrDZPNQrB/lmid695ocnAeP+m9i/dbMsKpruBmXoaSvofS0YkcwNnaE 1FIHeelSKFsY8Pssto3RI56QMvKapdznrUwchtbEeX17quGtiqGdaYnjKscZq11DcF a01SSKX9L7S516IfUG25FYZWx6JBV7BTgtLCds7w= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Wei Liu , "K . Y . Srinivasan" , Haiyang Zhang , Dexuan Cui Cc: Michael Kelley , Long Li , Nam Cao , Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kees Cook , "Rafael J . Wysocki" , Radu Rendec , Sean Christopherson , Kai Huang , Dmitry Ilvokhin , Shradha Gupta , Christophe JAILLET , Thierry Reding , Jiri Wiesner , Daniel J Blueman , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org Subject: [PATCH v3 1/3] x86/hyperv: Set irq_retrigger for root partition PCI/MSI irqchip Date: Mon, 7 Sep 2026 06:51:27 +0000 Message-ID: <20260907065129.269262-2-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260907065129.269262-1-namjain@linux.microsoft.com> References: <20260907065129.269262-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Hyper-V root partition vPCI MSI irqchip lost its irq_retrigger() callback when it was converted to msi_create_parent_irq_domain(). The callback was present on the original irqchip and was dropped during that conversion. On CPU hot-unplug fixup_irqs() migrates the interrupts which are affine to the outgoing CPU to a new target. If an interrupt still has its pending bit set in the outgoing CPU's IRR at that point, fixup_irqs() resends it on the new target through the irqchip's irq_retrigger() callback. As the root partition PCI/MSI chip no longer provides that callback, the pending interrupt is silently dropped, which can result in lost interrupts, stalls and "No irq handler for vector" messages during CPU hotplug. Restore irq_chip_retrigger_hierarchy() as the irq_retrigger() callback for the root partition PCI/MSI irqchip, so that a pending interrupt is resent on its new target CPU via the parent x86 vector domain. Fixes: 4691db0704ac ("x86/hyperv: Switch to msi_create_parent_irq_domain()") Cc: stable@vger.kernel.org Signed-off-by: Naman Jain --- arch/x86/hyperv/irqdomain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/hyperv/irqdomain.c b/arch/x86/hyperv/irqdomain.c index b3ad50a874dca..1e273d7d6c5b3 100644 --- a/arch/x86/hyperv/irqdomain.c +++ b/arch/x86/hyperv/irqdomain.c @@ -304,6 +304,7 @@ static struct irq_chip hv_pci_msi_controller =3D { .irq_ack =3D irq_chip_ack_parent, .irq_compose_msi_msg =3D hv_irq_compose_msi_msg, .irq_set_affinity =3D irq_chip_set_affinity_parent, + .irq_retrigger =3D irq_chip_retrigger_hierarchy, }; =20 static bool hv_init_dev_msi_info(struct device *dev, struct irq_domain *do= main, --=20 2.43.0 From nobody Sat Sep 26 01:03:52 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B51954078E3; Mon, 7 Sep 2026 06:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788763925; cv=none; b=o6VEglbEMX3cZgWOQwIelfY3u0Qews8cqWAo5Oxqlig3mp7Bh/KZ7wUwZjNV3IZ6n1OJ4pJVis3QUPy4u0t311/18TJhW8ZMvsTeGa3p2vkI/1jU9t6kE/A6ValZQn0WiS21V3v8iLF01kA43kxcVMJ8Id2lQQSiOpiA/aDhFzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788763925; c=relaxed/simple; bh=x/7uSEeiZT11jqgXuHksjLSI8/j0CCD7Mkmgf0Gy6cw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cloDmNiLx4f6Hw5XwS1wb7GU0hTzRKMY7dizsEP2vzyshn8fa0Lqb2hWUOb2QC3PZHzSOHaa7qqggiT23naSen0K+utq1/dg5X89jgvTQYeUeopMrn6ZWjVgFCKnd113JLcW8I8cE/SavHnrzBKr+VlTYJGoDysNo8oa5EzpFPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=ilyp63WM; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="ilyp63WM" Received: from CPC-namja-026ON.localdomain (unknown [4.213.232.18]) by linux.microsoft.com (Postfix) with ESMTPSA id BCD3620B7135; Sun, 6 Sep 2026 23:51:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BCD3620B7135 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1788763884; bh=5kWhgv4HVeF32pTYCYq8ecDF5paAIOM1AAGpCnaQlaM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ilyp63WMCrz7s3Bo1TAcncQ4g3mWrCcTGwHi+qH3+RGUfdHzQcoePohsL9oQQl0XU EBeXHMMkp/SIfFcN9XnMF0RNF3rwBzXjJs4ESBdgT6R63OLgAgROHscZTDyPgg5i6t 13je37PUnUgT0X4ByHSwUxEga9Xm2qmS17kC2iD0= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Wei Liu , "K . Y . Srinivasan" , Haiyang Zhang , Dexuan Cui Cc: Michael Kelley , Long Li , Nam Cao , Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kees Cook , "Rafael J . Wysocki" , Radu Rendec , Sean Christopherson , Kai Huang , Dmitry Ilvokhin , Shradha Gupta , Christophe JAILLET , Thierry Reding , Jiri Wiesner , Daniel J Blueman , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org Subject: [PATCH v3 2/3] x86/irq: Fall back to irq_chip_retrigger_hierarchy() in fixup_irqs() Date: Mon, 7 Sep 2026 06:51:28 +0000 Message-ID: <20260907065129.269262-3-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260907065129.269262-1-namjain@linux.microsoft.com> References: <20260907065129.269262-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fixup_irqs() re-injects a pending interrupt on its new target CPU by looking at the outermost domain chip and invoking its irq_retrigger() callback directly. When the outermost chip does not implement irq_retrigger(), the pending interrupt is silently dropped, which can lead to lost interrupts on CPU hot-unplug. Keep calling the outermost chip's irq_retrigger() when it is present, but fall back to irq_chip_retrigger_hierarchy() otherwise, which walks up the interrupt hierarchy until it finds a chip that implements irq_retrigger(). While at it, use a scoped guard for desc->lock. VECTOR_RETRIGGERED is now set only when the retrigger succeeds instead of unconditionally, which is harmless today since apic_retrigger_irq() always returns 1. Suggested-by: Thomas Gleixner Reviewed-by: Shradha Gupta Signed-off-by: Naman Jain Reviewed-by: Thomas Gleixner --- arch/x86/kernel/irq.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 30122f0b3af96..e0163f7ac7368 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -470,6 +470,7 @@ void fixup_irqs(void) struct irq_desc *desc; struct irq_data *data; struct irq_chip *chip; + int ret; =20 irq_migrate_all_off_this_cpu(); =20 @@ -490,21 +491,23 @@ void fixup_irqs(void) * nothing else will touch it. */ for (vector =3D FIRST_EXTERNAL_VECTOR; vector < NR_VECTORS; vector++) { - if (IS_ERR_OR_NULL(__this_cpu_read(vector_irq[vector]))) + desc =3D __this_cpu_read(vector_irq[vector]); + + if (IS_ERR_OR_NULL(desc)) continue; =20 if (is_vector_pending(vector)) { - desc =3D __this_cpu_read(vector_irq[vector]); - - raw_spin_lock(&desc->lock); + guard(raw_spinlock)(&desc->lock); data =3D irq_desc_get_irq_data(desc); chip =3D irq_data_get_irq_chip(data); - if (chip->irq_retrigger) { - chip->irq_retrigger(data); + if (chip->irq_retrigger) + ret =3D chip->irq_retrigger(data); + else + ret =3D irq_chip_retrigger_hierarchy(data); + if (ret) __this_cpu_write(vector_irq[vector], VECTOR_RETRIGGERED); - } - raw_spin_unlock(&desc->lock); } + if (__this_cpu_read(vector_irq[vector]) !=3D VECTOR_RETRIGGERED) __this_cpu_write(vector_irq[vector], VECTOR_UNUSED); } --=20 2.43.0 From nobody Sat Sep 26 01:03:52 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE2052EC0A2; Mon, 7 Sep 2026 06:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788763934; cv=none; b=RpiudiLhB5dcdkPo+uXx8IJ39hzr8VTqjBaAokt5W8Ge6byPQPdDkN1IphaFKQKF6YXi6ys3gZ9TBho0TT4F90tOpFFlYQfxB3QyIU9OY928mWaaEFKg0qRqSNKvKv5ekV0teH2B/H9CB+aDUvT/Cn0r+TOuK22Rwz9PsYDOayU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788763934; c=relaxed/simple; bh=0tbKc9fZhKvoTnOKxwtOQaa2+oMH40JwveDwxJpUM1c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W6pDiPxl6ND0J3ybJ69ccx9uOGSe5zCUYR3HC3cXFL6HEF7boU/VbAfhX+JrkVpFnIMOLdwQEh6mV7JhPpUIIuMqLAhF2fAzw/Al05P4JAvjKzY/ueg1Jws/EHpJnfZDssp6bMIa8bBk89vCyiqv5Sx/8wujd//NpHtOHwMtg1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=aETJPblr; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="aETJPblr" Received: from CPC-namja-026ON.localdomain (unknown [4.213.232.18]) by linux.microsoft.com (Postfix) with ESMTPSA id ECEDF20B710C; Sun, 6 Sep 2026 23:51:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ECEDF20B710C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1788763893; bh=E4c7wIrlFU3ULdF2/N81BPKnHb8lv3UruDQAdVdOzLI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aETJPblrODw/dZpUUqVs3rsgFqLEzTlKpgEOWQxGDs1u41pgApn3sSBgfzQc2WkSt C8fGTrCx2s1jkFXNn22J5RSRCN1edQl7oLdFRJicocXKoB0tpxdTo6pU8cVyQe8kac 0MAnD7hGhnvCp48WxM4Ft6lrqQyoZyH7rziaDZsM= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Wei Liu , "K . Y . Srinivasan" , Haiyang Zhang , Dexuan Cui Cc: Michael Kelley , Long Li , Nam Cao , Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kees Cook , "Rafael J . Wysocki" , Radu Rendec , Sean Christopherson , Kai Huang , Dmitry Ilvokhin , Shradha Gupta , Christophe JAILLET , Thierry Reding , Jiri Wiesner , Daniel J Blueman , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org Subject: [PATCH v3 3/3] x86/irq, iommu/amd, x86/hyperv, PCI: Drop redundant irq_retrigger inits Date: Mon, 7 Sep 2026 06:51:29 +0000 Message-ID: <20260907065129.269262-4-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260907065129.269262-1-namjain@linux.microsoft.com> References: <20260907065129.269262-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With fixup_irqs() and the generic resend path (try_retrigger()) now both falling back to irq_chip_retrigger_hierarchy(), installing it as the irq_retrigger() callback on the outermost domain chips is no longer required. The hierarchy walk reaches the x86 vector domain's apic_retrigger_irq() for all of these stacked domain chips. Remove the now redundant irq_retrigger() initializations from the outermost domain interrupt chips, including the Hyper-V root partition PCI/MSI chip. msi_set_affinity() is the only site that invoked the outermost chip's irq_retrigger() directly. Convert it to irq_chip_retrigger_hierarchy() so the x86_init_dev_msi_info() initialization can be dropped as well. No functional change intended. Suggested-by: Thomas Gleixner Reviewed-by: Shradha Gupta Signed-off-by: Naman Jain Reviewed-by: Thomas Gleixner --- arch/x86/hyperv/irqdomain.c | 1 - arch/x86/kernel/apic/io_apic.c | 2 -- arch/x86/kernel/apic/msi.c | 4 +--- arch/x86/kernel/hpet.c | 1 - drivers/iommu/amd/init.c | 1 - drivers/pci/controller/pci-hyperv.c | 1 - 6 files changed, 1 insertion(+), 9 deletions(-) diff --git a/arch/x86/hyperv/irqdomain.c b/arch/x86/hyperv/irqdomain.c index 1e273d7d6c5b3..b3ad50a874dca 100644 --- a/arch/x86/hyperv/irqdomain.c +++ b/arch/x86/hyperv/irqdomain.c @@ -304,7 +304,6 @@ static struct irq_chip hv_pci_msi_controller =3D { .irq_ack =3D irq_chip_ack_parent, .irq_compose_msi_msg =3D hv_irq_compose_msi_msg, .irq_set_affinity =3D irq_chip_set_affinity_parent, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, }; =20 static bool hv_init_dev_msi_info(struct device *dev, struct irq_domain *do= main, diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 7d7175d012288..18f49a251f23b 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1857,7 +1857,6 @@ static struct irq_chip ioapic_chip __read_mostly =3D { .irq_ack =3D irq_chip_ack_parent, .irq_eoi =3D ioapic_ack_level, .irq_set_affinity =3D ioapic_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_get_irqchip_state =3D ioapic_irq_get_chip_state, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED | IRQCHIP_AFFINITY_PRE_STARTUP, @@ -1871,7 +1870,6 @@ static struct irq_chip ioapic_ir_chip __read_mostly = =3D { .irq_ack =3D irq_chip_ack_parent, .irq_eoi =3D ioapic_ir_ack_level, .irq_set_affinity =3D ioapic_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_get_irqchip_state =3D ioapic_irq_get_chip_state, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP, diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c index 66bc5d3e79db3..aad2f15eb2176 100644 --- a/arch/x86/kernel/apic/msi.c +++ b/arch/x86/kernel/apic/msi.c @@ -137,7 +137,7 @@ msi_set_affinity(struct irq_data *irqd, const struct cp= umask *mask, bool force) * IRR. */ if (lapic_vector_set_in_irr(cfg->vector)) - irq_data_get_irq_chip(irqd)->irq_retrigger(irqd); + irq_chip_retrigger_hierarchy(irqd); =20 return ret; } @@ -246,7 +246,6 @@ static bool x86_init_dev_msi_info(struct device *dev, s= truct irq_domain *domain, info->ops->msi_prepare =3D x86_msi_prepare; =20 info->chip->irq_ack =3D irq_chip_ack_parent; - info->chip->irq_retrigger =3D irq_chip_retrigger_hierarchy; info->chip->flags |=3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP; =20 @@ -313,7 +312,6 @@ static struct irq_chip dmar_msi_controller =3D { .irq_mask =3D dmar_msi_mask, .irq_ack =3D irq_chip_ack_parent, .irq_set_affinity =3D msi_domain_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_compose_msi_msg =3D dmar_msi_compose_msg, .irq_write_msi_msg =3D dmar_msi_write_msg, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED | diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index 8dc7b710e1250..2bb7a6f466af3 100644 --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -509,7 +509,6 @@ static struct irq_chip hpet_msi_controller __ro_after_i= nit =3D { .irq_mask =3D hpet_msi_mask, .irq_ack =3D irq_chip_ack_parent, .irq_set_affinity =3D msi_domain_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_write_msi_msg =3D hpet_msi_write_msg, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP, }; diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index 40726dfef2733..a19e1faf98750 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -2471,7 +2471,6 @@ static struct irq_chip intcapxt_controller =3D { .irq_unmask =3D intcapxt_unmask_irq, .irq_mask =3D intcapxt_mask_irq, .irq_ack =3D irq_chip_ack_parent, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_set_affinity =3D intcapxt_set_affinity, .irq_set_wake =3D intcapxt_set_wake, .flags =3D IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_MOVE_DEFERRED, diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/p= ci-hyperv.c index 89816a2bd7cd3..cfc8fa403dad6 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -2119,7 +2119,6 @@ static bool hv_pcie_init_dev_msi_info(struct device *= dev, struct irq_domain *dom info->ops->msi_prepare =3D hv_msi_prepare; =20 chip->irq_set_affinity =3D irq_chip_set_affinity_parent; - chip->irq_retrigger =3D irq_chip_retrigger_hierarchy; =20 if (IS_ENABLED(CONFIG_X86)) chip->flags |=3D IRQCHIP_MOVE_DEFERRED; --=20 2.43.0