From nobody Fri Sep 25 23:10:23 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19E9F4C6F04 for ; Mon, 7 Sep 2026 13:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786051; cv=none; b=PTE3eQzT+uFW9BSpSf19RdXrhkdMzvwpqXZyZFiMgTire7UoBiLtnWnH83V2b9UD8gToc8DKI7TW15XUV5mTl0p4LSgqcagsw0y3pOYWw5F/+JEf1UmTUKwIoMOnE6oDE9Z5WX/mZJoE5iKyAMTnrIhgYuLewiGTO0E4CC8kCus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786051; c=relaxed/simple; bh=yyFXmjX5xn4LHf0Cfw4ccz4CCqq/j5rE2bpo1iUGClo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fo0NGLQRSyroUZ9SzdWka5zE+wQoxFuxekiZPGFM9ji576pF/qj/RedN/09s9ISHtfKwyHR3Gi9rGH35fkE2e/PHvmaMixyJBpILCS0wy8fwKPNcBgHH5evRmDzFW/hbkm2jNmxrzg0Jr53z0WqkzYy9q8nCfsEQnh+u8EXkw1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MtLu5hYd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LAGy5AM3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MtLu5hYd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LAGy5AM3" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687AnRXU4064577 for ; Mon, 7 Sep 2026 13:00:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vnsP6hjeAwNYcPMBk8GfKispcvJsO1pbP/Kx9Lnz6c4=; b=MtLu5hYdHHBHD+Yc /wh4ApHi4GUAzU93qQZULgTnpk9hXgd1DZyqn0mqhJm+sQYmZKdSCAfJQklQBDKs Myuh+dH5Oz9LEipTM6rBykD+UsQtibUrvuPcdyguabknHBGifHG1ysEr/nezcvdT CgZ5lCIS4fPyi+g/fklNX8eOfLdl5DufSLk64ps4SG8hdg5MPbwM6VVZYsa56IXs KrhdGzaXMjJi1I3GV4vKhiJjWVUgGz07rKXdRbH9ttIPSfUNO7FPrK2OQOCXTGWv J2UVljv91S5iybpSz0IegQdwPEqqqrupQc6I4XPIg/L3GdeVfLi0PHehi2agOiDa dlJCFQ== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghs86s9ft-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 13:00:34 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-97bf8f3a38bso198460241.0 for ; Mon, 07 Sep 2026 06:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788786034; x=1789390834; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vnsP6hjeAwNYcPMBk8GfKispcvJsO1pbP/Kx9Lnz6c4=; b=LAGy5AM3Me+5p+s4sqtaWlXqxujgKeNmr9DyCOCyVicrxWYrkMi/1mVEZGwGdIUwSz yYSySHg+/eFLcvPJJfoCHqGXoxlIFgPH3VAdajy6TfcPgIa9OWvJFiP60FjCJj6LBgF7 9VaP2VNSXCJo/czP3O7ExQyO/aokn43pniIa6S8bOZjaWJRGa3WzS7urGhZSRR/LoDGO q+zu7+Imjqbv1Fljf/lsqMYikVunyQn3AQfp+sUxqqDydLDTvij+GTxkt4j/RlgDI86s I18bGLn5E+iuHzzqY8kG3r0SXGEbz8mIw0pfrz/rwFDTt9YS2944r+5lG3yziKNCO1bo z2hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788786034; x=1789390834; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vnsP6hjeAwNYcPMBk8GfKispcvJsO1pbP/Kx9Lnz6c4=; b=TJuH26psl81WWqy8ekChd68XnUOBZ7gt/MsyQv9XwnvnIqkjfxckzy/SEgTf61/qs5 a5zAeDjj3LI4lIAZxAmhFMShrxjFmXUByfB1OxAFvaCLJ5JWXhGGCMxKo8kQ9WH2Cnlx SMOeIIbgxfnp5BQF7brmakgwWn82TayIxewSJt/XG2+WWI/Ynzw7zsRWufFBi1kFO7We E3Ttj7DtPCYGWVpNAGbdDi1t+78lKF6AjGwhBXHGrN63UxdJTQRu0RWNucz9f67MKOZj B3EbZsrg+66f9SfxAp8aaIpotcie7XTUxJBb/Bm7A3oDUvkdnpEZIlSidFimG1dh5UC7 t02g== X-Forwarded-Encrypted: i=1; AKwUvBz+kNfIR/COueXBT5XADKNZyuVOWxg+yRjsoN8cS3OAo6aVjwJqPD+3Rzl+f0x9aMIAXkIpxdMooyvUqBk=@vger.kernel.org X-Gm-Message-State: AFuF++kWFJwOxlA71eu7AwGVOhE4Lf2n1Ff5rxWA0aTFjybQsfRLtWhL UXoeXRF9HGECA38EGgL5pVVyuDomX5C1JvX92St4EPpel1nEOexJ2mEc1LCqm3gwcawb3gGcqbG JBk2cfz99w/PLEVqzCO4SR3QZ/m5DFfr72MgX3fcZ7cQO9x/HAB2tABONXXFeazhpesY= X-Gm-Gg: AYBFou0rGYluAUZOazLg7y84/nu3FrOBkp7jz/brjQ278vLbsOKcyJCZQeTE6iiWPZj AxdWSqUtZKOKnvBeqS77ZTQTlDBecGoyuPEQ8egY38eFJqWTAy5azZWVelEwdEcuAXd9XDSnE8s YUknCZfevgAXY0Go4dloggZztTy36O7aYAnyTX2KgjMgEAw5NliAfNEckwWcs8dWHUmLznQbqgi NREMqCLIb66HGff70vvR2IweSsgJ4cn5zI+6U5TNr+ozebLiz4p80y4pJABZTbvtKCe263hqbjc PtNJSn8CkTbPK/UyIxao20MfWbFPHBw2FiLY4faddqOVK4EOSXPt+l6cRJ2a7unN9yOQAsUpNWS 4tT9OwgGNm7tQ4nSj8ZlS1lg= X-Received: by 2002:a05:6102:292b:b0:782:e19d:6f39 with SMTP id ada2fe7eead31-78a4a483c93mr6602111137.0.1788786033551; Mon, 07 Sep 2026 06:00:33 -0700 (PDT) X-Received: by 2002:a05:6102:292b:b0:782:e19d:6f39 with SMTP id ada2fe7eead31-78a4a483c93mr6602074137.0.1788786032993; Mon, 07 Sep 2026 06:00:32 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cff81c9b5sm198751205e9.4.2026.09.07.06.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 06:00:30 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 07 Sep 2026 15:00:15 +0200 Subject: [PATCH v2 1/7] drm/msm/hdmi_phy: Cleanup after msm_hdmi_phy_resource_enable() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-1-b097cf1eac77@oss.qualcomm.com> References: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> In-Reply-To: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1532; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=yyFXmjX5xn4LHf0Cfw4ccz4CCqq/j5rE2bpo1iUGClo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqnrVklronCnP9I21nHkLe4UhlAuAhPrNlcB+Ld wfUHRDx96iJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap61ZAAKCRDBN2bmhouD 1z8CEACWoKnaQY4soxW93YzD/YdKVaoCi4vf+eBJPUfeyh7K82OTTkysJ8cMtu/TQ+2HDBY/LNa DS1U3plaMTfKY1pTYWAEoE/3RS2mdncjoMDqXX6Qrcwwhv1KP6uOdn2ZO3qtrs8GxFiku4Lj4u5 i3HY61pkGWkQLEQBhSGGcZbEALxnfchvx962Zz506VqDHTo7OxzS/DrG5icMcKFYgkPPLpUVbs9 thZ8aRUKGXq+Kb0ER8sGiORDA6dcw3XL7MGcGwUDBDst/UNx1AEzeKfDaWTi6Vq02jFMSC2b9cz QD+Q81zprx3jlALkNZ60CGDWViwpZanrdZx8H2dUOUL6h2ymrSF9QFCoG7ycbro+ux+JE/Nn08Z tcbIofFFJauZcRazikXJBWdTfn6UOoFO4NMp3Swd+uQxscSvbfG45+WzCUSrAA2CyNNOJn/fXeF H44NRdjsqMnqUaPvX9tcmkO1A163kbbMK1yNfhp5NRk86ab1IXvH44dvGTMXbki4EAM8kzH2rpO tRjzW2p3M1TXIo3eUmjgY2BuYT0lRkUr/8j47MN7N0t8HBxXTPpX/YSxdYti8VUpBGLPw/gieOh D4VEdeMwkl5PCk2aJuo0baVABpwFFdemjhOtpVMJc5yoohP5nmP8rNIZxJoN7nXVTN0+WQcIBfe XpFkgulvgPJrpHQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: fBWdUyLa43zUFTD9lDXeLPkYhOcKOcFv X-Proofpoint-ORIG-GUID: fBWdUyLa43zUFTD9lDXeLPkYhOcKOcFv X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX0Kf7hi/K6Cvy kDYQdLDVHC2O+ASel2IhHhCnga8D07djKQwjiAl+gafZKJHYVTNt+fvE9oAeEI9YbNS5HSu98Pf Q4+l6CVH0EJMEzLXfz4kO0f3fVwOtFY= X-Authority-Analysis: v=2.4 cv=LseiDHdc c=1 sm=1 tr=0 ts=6a9eb572 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=fGoX3SELrpdlimCKowgA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX5NfimIUHKa2q A6yJ9VXzO9y/tAjjYf7CpIyxfeIg3w3b3S5z4GALi8Sh/RC59d6qPXqTYAZ2nlmIcAvDcWRaUtS V6BGy1jMpU6CkEOUKTo2jATyu7gKhAkX2q7jGbkP2T4IVL0OEdVuiuZFgiKWl7n0aes4C/Rw3Lk zSz0LPsZLqqEaez+MggdvMy0UjcvhEMbXvJH4UdFc757taRLfVPnwWzJ2A9RhmEIVUrQtqOx+uW StTWozgcvPUNu9MzReX4+ncBDRXB3EttS1ahP9Vs68zTdixJVWLO8ukKsMIHdR1f+HWB8WyaSoO wfW84yAqI9igjNb/h7pNyeD1oM6cEe9P8bQx0jXQiyo0kahPBGHd+y47m0uD7X3yx3g6NmczX8u GtziCSES4CQYWmli2FIRAmTmwl+cbsoie75bvgZa4MoU6hgjyaR9pU0kArpMCYDvKwBJeqtv69/ dl+vkV0x2/GfGxwXpZw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_03,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070143 If msm_hdmi_phy_resource_enable() fails, e.g. when enabling regulators, it should reverse the state of things already changed. msm_hdmi_phy_resource_enable() is used also in probe path, thus such failure, which could be simple deferred probe, would leave these resources permanently enabled for the rest of the runtime. Cc: Fixes: 15b4a4523859 ("drm/msm/hdmi: Create a separate HDMI PHY driver") Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c b/drivers/gpu/drm/msm/hdmi= /hdmi_phy.c index eb1088755cb3..fd675f537f2b 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy.c @@ -67,16 +67,26 @@ int msm_hdmi_phy_resource_enable(struct hdmi_phy *phy) ret =3D regulator_bulk_enable(cfg->num_regs, phy->regs); if (ret) { DRM_DEV_ERROR(dev, "failed to enable regulators: (%d)\n", ret); - return ret; + goto err_pm_put; } =20 for (i =3D 0; i < cfg->num_clks; i++) { ret =3D clk_prepare_enable(phy->clks[i]); - if (ret) + if (ret) { DRM_DEV_ERROR(dev, "failed to enable clock: %s (%d)\n", cfg->clk_names[i], ret); + goto err_clk_unprepare; + } } =20 + return 0; + +err_clk_unprepare: + for (; i > 0; i--) + clk_disable_unprepare(phy->clks[i - 1]); +err_pm_put: + pm_runtime_put_sync(dev); + return ret; } =20 --=20 2.53.0 From nobody Fri Sep 25 23:10:23 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0334C4CB8AB for ; Mon, 7 Sep 2026 13:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786059; cv=none; b=l5CPE6R3jSJYGQr5nUCbQpGhSFU9b2kUVay5momW9xLA10sKurvRNRG5ruc/yfJuV4q4MjlpLlf6kbl+tyZa1leXZbmRqF35qLjE1NDMVSjLHl73rM1ppsfgUfTC9/7FV/dNYwd3oTR34jFNq0iwcWK2Wb+MgWQicRNpDnzoigc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786059; c=relaxed/simple; bh=gCPjQLee8IZ6ZI1o3PKvV9FFsQQqDDwLDIvAlHVSnmc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YvNDT+37vEg3jEvhY/ItOKWQKew73PJhZnne3eGBdMGsEk6XO9Fz5vsdrTC43SEJUiVcaDvYMAmXJfYUr2Rov8J2hwYOcBG3SIHegAJdokeZuImq+Co/Xhy0BDBMfg/PWWsNnDc4IRDxvUdJpg8xiadLQOaZ8/z/B+BomkA0cgE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=larfk0Wl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dEuXZiim; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="larfk0Wl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dEuXZiim" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687AnDcb004214 for ; Mon, 7 Sep 2026 13:00:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HH0NlUkAHggOm55GmMCsiEP7bNk66V1yTa1Hyg0NTUI=; b=larfk0WlpEup5H3m Ee/0P6ULDeJf8uBNe18+jf18aEKhu9xGfIFxIttialr25DSZEavIL/551vZ+uQaC OwZkD8yPg4ifSq+CuBuLFWbu4ShJZJL0YErS8nT3JsBzyo+uJppopbv16l8ZdCfx d1X2nHP3uiglbrC09FSelq8LJEHPGUEFbl6oMDgZ7PpJDOpie9rBIA+p6W3LoPo7 ptfIvNap0Ql4lPEzqHzptAWl988S07yxFFTTLxvyiI8yX1sk0NIKQZucN2ttjHKn PAMYo9Lgmt/bu6poZlLRhwWd/MRH8IvLEW8yiea2kA+wp9C1ziZKcrxoyOiEhXFM JVWMsA== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghssg13a3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 13:00:37 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-7563011591bso302185137.0 for ; Mon, 07 Sep 2026 06:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788786037; x=1789390837; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HH0NlUkAHggOm55GmMCsiEP7bNk66V1yTa1Hyg0NTUI=; b=dEuXZiimvydS46TF++eIje/CG4MaS/xRtTZkB6Zai11uz7Ia2ML1MDb6NimiWJvIH3 DLN+H1gpgN9kgpMo35Hj1JwcYlRWNdrr+b4NjZel9mVvhopTKUSRAAJ3WqAkpRe1ggH7 gXAhFr7yGP2L7XNdo8Uwz0CTM8auuHeJD1fLzHuqeywpeCFKHcf4ERSWzHcxdbAttOP+ cjvwdVkDPfdbKkPPEqrU4N+8Qt6WMy7Qqcm8FkAsWJwyzhOPSjADbM9KgkfWCug3wq+3 /oYKxAS3WN4kiTvk4DX+HGhLM8iEBbzjfuF/p5zi4WY0T6knb65Q+QV1UDxR4TTphCKf mhkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788786037; x=1789390837; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HH0NlUkAHggOm55GmMCsiEP7bNk66V1yTa1Hyg0NTUI=; b=BZ6Vslb5LoLoHJNwgnUP0VcJ4mkJZsIKrgt3Y5t8eOVQj2fGbP1vrM4yP2ScJVX+o7 rAKBXbvHUjoCsk2hdiFw7j+CoVotoE1hTj8dL9a3K5EODbJD1MvT5DaEIPt6dhB8nVWK M+hKHemGFYNecbv9mdMeFjTVlwYjn+hB+EYB9siaGflxAkWsdxiWOabkTNEef8lFRy7B RuXCKygDzOcAi0rJc1L5ocAQXuNxhQ97SyRa9u1jh9NJQOlInnI8bK2a0JlnoZSzMrE4 IeaI9v05Zk1OwxVopnUOjl2tUV2Hl5xV9t9Mfqf4soCkeOm5ZZ2h2uWK2fTPbkivudTB adSg== X-Forwarded-Encrypted: i=1; AKwUvBz3WkJnXZuoIT/rSQp3YdR8jke+7Nx8Zhd0u2tFwTjxODHaTyVFj/Nm+bpwjc/bYY0sVpxj3bB0cKdp0LQ=@vger.kernel.org X-Gm-Message-State: AFuF++nKbtZt+sib8SPMFKl6wPwVHahORSYYhQRCdf4mFdMaNpryYyj4 rXB8pIuiLBjs8wbMRDNICjaiUZ2vfZjpoM0JFuEZflqz3zYWjGxyoPo5m7DLNIOqWEgcPCCSSRM A4hPPYSNOp86WhbVNQ/kfqsilIlgwocCIZpQcNMCSv/2/wB2PulHWT5cCgX4VYEbHPcg= X-Gm-Gg: AYBFou1f2baaWeQeXQUmH0nWahg5xPY19eCxBF7TEWdO9UNUnXAtL9f76dfsLoF+s4C cTlbRWLPC84RlEv3xropZhl/LDyj+exhnXmdaXA5zmbj837NLqCNRXMm0X93JQHnK7K6uHMRzgm ZUkA66Zzw0l7GUSMPZnO6nmcg3jIyknbFwzxEjW6wAF99JDd52j6CHxP3q9fEschEnJ4Bx5Hu+g 9E6CiewDAK7Y469WQcdJy56QKZV7YSx0/iOOXLxkr8pkYQwELlAbnVIFJUNKhaFl/4pIEjuh37P XK3KQMaJNKR69qRMQGRFDnItpgCOQWlzYlJfoW5jgTUHlmRVsqY2LnZsxBoJCq5bXKFqW3BB2z6 cAJ5TkKC7IeIkRi2FSgHFxbs= X-Received: by 2002:a05:6102:5091:b0:78a:8a0:7126 with SMTP id ada2fe7eead31-78a4aa97d5bmr6957323137.10.1788786036757; Mon, 07 Sep 2026 06:00:36 -0700 (PDT) X-Received: by 2002:a05:6102:5091:b0:78a:8a0:7126 with SMTP id ada2fe7eead31-78a4aa97d5bmr6957293137.10.1788786036018; Mon, 07 Sep 2026 06:00:36 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cff81c9b5sm198751205e9.4.2026.09.07.06.00.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 06:00:34 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 07 Sep 2026 15:00:16 +0200 Subject: [PATCH v2 2/7] drm/msm/hdmi: Handle msm_hdmi_power_on() errors during .atomic_pre_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-2-b097cf1eac77@oss.qualcomm.com> References: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> In-Reply-To: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2516; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=gCPjQLee8IZ6ZI1o3PKvV9FFsQQqDDwLDIvAlHVSnmc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqnrVl5qXohDCURU+NBjhbzxqePcwXPR42atlwW MKZXfnzXIqJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap61ZQAKCRDBN2bmhouD 13MLD/499ImyZNhv8KqXl37bfiQdgVu9Me30Y0fF1ckmJODd9Kkx2yUhO9VjmaeT7PgdxTDZzxu flb9jXTKAnkw0NGD1hd42UsH1Qkh1qJ6oD9EyqdPFwt2U/jhZFYCrA4O6GQiqAgjrgtHKOxx/HX f4QQ/+6h4ALMYtMDlSboskVDJy/L3QNA/hVVqhhp6qv+6Uoo932d8kCe88jVAbvrtxRfls/nO7z oR/mIRFUIJ9ly1p/4DTJgWgWADs/cIQAw5uBUszxsg+jvJkK9quTp7cJ7a5nXqoehBajDaj+SpI HMQKNWX7WfkQoMyUNGRmt71fAOvRb9xbfU9YUnhg7MpH1KANwJWU6XlKzhKnKFs92lz+Tky7MYz wjI9BTQ30YdhpON4qjuotYrA1JMnmobv4lpY4ODuTqxndsik8+AYPtMRB/q8R6xTHvhHbhM0cim UnnvfML8SJdnU1nkbl8KKH69Xj9FxIy5ztYtzng8ys7YQfXZ0hxtMKw747WPyGPdrI9JwYr1zDa hbhVIiTLQ6DitBSoGJRCXcU8up8kDjabFU/OpK4vAt8M6DkjH8/w9mYhT7dnGbX3a0gsqAqvxXm qJL3p/bK1iZivrvdLFe6O1r5cwRor9QBOxn2kF2DCx/hA2vjSDDYRKBOPDoyiLo3I7IsJSOYWEb QgNRexijnPWjaaA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfXyf5AdvRJ3h0f YpIgmKHpZO97MSpKHiz1w1/95GOhU8gx7FZ9897OkBcRQaIU0LMJlFFAIpnPZ3wRc7vPSjSXVLF abjsSQeIf2bpDYen5nanDOWlwP69bNQrG9xJPEqar1uk0pmWzYEtl8WUTs+qpxvfFWrxR/NIwLS iTBVpiIUqRuPzKOq9RzoIcFLCJbx/0PSnosgzQBXHH3npJQCKX2WKumhoq2mhVn5n4k8LoqYmzG jGsJAk8jvsBU2jK/CZgNqzsD32gzZ5vP7GEImt0oMGVjG4l1CruCW7yIvwaU2nM0YeTdtBjkv25 y4PbF4rSwHUSpgSlRAmsYsin6l9SPShDyyt/PX0M72D5iib6C7r1oLOzFG0cZUhf+jRa8sS6Saw xC6FDd6QANGHprSPIyFJsW/J/tWUBhmxaUF8wk3JISSjOUUtGeNVG8FMd/GEQcN49wDguvnGHgP S7Q1sTHMg2EDhwjrvbw== X-Authority-Analysis: v=2.4 cv=MrJiLWae c=1 sm=1 tr=0 ts=6a9eb575 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=IzbfGf_HrtPdoiX6LZ8A:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-ORIG-GUID: occgiZzsUjRBcWfHNwznfeu0JIrGS75V X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX+kdvDSR9I5s+ N7357uiTa45U0/nuwH4DrVHwPG8beCkBA2wUXxVA3YnM0LNvyZo2RraBUY0K1oVdagHzYVYPhJ4 ezXK03zn/8A1DBxJAFqBOrNeTEDX54U= X-Proofpoint-GUID: occgiZzsUjRBcWfHNwznfeu0JIrGS75V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_03,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070143 Properly handle power up failures during .atomic_pre_enable() by aborting the .atomic_pre_enable() to avoid accessing registers why blocks did not bring up. Otherwise this could lead to imprecise aborts when accessing MMIO while entire power domain is off. Cc: Fixes: ba3d7bf3a7ab ("drm/msm/hdmi: Convert PHY files according to new desi= gn") Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index 157f19bd90b4..db85400e574e 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -13,14 +13,16 @@ #include "msm_kms.h" #include "hdmi.h" =20 -static void msm_hdmi_power_on(struct drm_bridge *bridge) +static int msm_hdmi_power_on(struct drm_bridge *bridge) { struct drm_device *dev =3D bridge->dev; struct hdmi_bridge *hdmi_bridge =3D to_hdmi_bridge(bridge); struct hdmi *hdmi =3D hdmi_bridge->hdmi; int ret; =20 - pm_runtime_resume_and_get(&hdmi->pdev->dev); + ret =3D pm_runtime_resume_and_get(&hdmi->pdev->dev); + if (ret) + return ret; =20 if (hdmi->extp_clk) { DBG("pixclock: %lu", hdmi->pixclock); @@ -29,9 +31,14 @@ static void msm_hdmi_power_on(struct drm_bridge *bridge) DRM_DEV_ERROR(dev->dev, "failed to set extp clk rate: %d\n", ret); =20 ret =3D clk_prepare_enable(hdmi->extp_clk); - if (ret) + if (ret) { DRM_DEV_ERROR(dev->dev, "failed to enable extp clk: %d\n", ret); + pm_runtime_put(&hdmi->pdev->dev); + return ret; + } } + + return 0; } =20 static void power_off(struct drm_bridge *bridge) @@ -287,13 +294,18 @@ static void msm_hdmi_bridge_atomic_pre_enable(struct = drm_bridge *bridge, =20 msm_hdmi_set_timings(hdmi, &crtc_state->adjusted_mode); =20 - mutex_lock(&hdmi->state_mutex); - if (!hdmi->power_on) { - msm_hdmi_phy_resource_enable(phy); - msm_hdmi_power_on(bridge); - hdmi->power_on =3D true; + scoped_guard(mutex, &hdmi->state_mutex) { + if (!hdmi->power_on) { + if (msm_hdmi_phy_resource_enable(phy)) + return; + + if (msm_hdmi_power_on(bridge)) { + msm_hdmi_phy_resource_disable(phy); + return; + } + hdmi->power_on =3D true; + } } - mutex_unlock(&hdmi->state_mutex); =20 if (connector->display_info.is_hdmi) msm_hdmi_audio_update(hdmi); --=20 2.53.0 From nobody Fri Sep 25 23:10:23 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 883894CA798 for ; Mon, 7 Sep 2026 13:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786055; cv=none; b=nppihxEeqz6LuL0MK6WS5wFKxLmMZZrZ2aI1/wde+BHNnRU1sunYyJetaqqMzKW/7lJWWaocdQPu8bbkZlJhxEo+lX95lbCG60JXQJ3iastGINqdIyrrQxUZM/ttK80JbZBTKk/1WXTJBi1JtropldTpb404E6f172zGodkAmTg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786055; c=relaxed/simple; bh=yhhU2Xo1HHomz5Uesadm2LHNkZ1Ed1iZL1EHcx6SGho=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Lj61nn0Wpx4TY/SjN5YFjlrId0pf5/hfJPMWlZWpPRWJISVAQKnY0HIJPx0X31w5e7r3JLHs8ZmykgZF+Au0Z4+GGCUVBLJ1bpHfjQwylZd6G5p5ibdPD0+Rs3YXOiUCkaG2zgHqU4jgsUqdSnEOCR8aO7A5k3YjJBARA640uzo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UB+lkARR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aVzVl9MV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UB+lkARR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aVzVl9MV" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687AnAMI4064240 for ; Mon, 7 Sep 2026 13:00:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ywUruZg+R8a1lUYV8BGnIItve+PwkWpsyPFMDteRsLk=; b=UB+lkARREkDBMKC0 NviQrMGhrf6qxwQ0kJkpeGOK0gyFBtu5bEZB80GNB99VMGPpr0d/zCRJ6gVPycD6 dd2zUFwXYd+FgzEcd5zQ3KfOPc0uAMl+kdZ3BF3aMaJK9pbcnKIiUCxnDhvWKQ2c FsNO3y0stzSUe30zxk/z0JyG1j8N+Jefe31DeqHKJZZtF+zMcGCzkJIlbSrNLx4h dVklD1Yh19CImWCqB6MQiggJKerJIDwD+fB7kV/JfE7J93Btyr+PEoJFhiDL7aN3 CNGvDBtCN7HCwCfouC+H3PQ1OKQtigVcymAzY6VeVZw+CuGmOo2G9m8pdYgkNJ9g Gt3cRw== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghs86s9gq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 13:00:39 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-785b66a7017so815710137.2 for ; Mon, 07 Sep 2026 06:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788786039; x=1789390839; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ywUruZg+R8a1lUYV8BGnIItve+PwkWpsyPFMDteRsLk=; b=aVzVl9MVi/t+sctYuortDMNOGtCk+pfdHRPHMLjk1Z2vVsRTobQEjAclf5w0QGKUUN UKnCbP3xVU7skKrPvAwb3CWmbvMO0YrrA2RDUo4z8M0YoIBiTPkn/Uj07ega6IZvhtdS BJ1V9GjRq+JScRBU7WXiHzfUCEvHCAOWrFNxlJd8dKg99c3qACxh8JUHCMa4smUTnGcT C3uLfGla3YKQkWiu9+vLkaFh4uOiPJ0g+fAH0+0iWqjIqrzzUmEFjzuKXeTWlx/H0VN0 WOm1x/zcIHaDzqyPW9KiE6omPLyL6Lugzm3zu4SpKUW6VcNwk2uzPcUQ7Rm06SZgomkH 5w4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788786039; x=1789390839; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ywUruZg+R8a1lUYV8BGnIItve+PwkWpsyPFMDteRsLk=; b=XWBc3Ci0m3eLBWc6Ad1UMPgoYJ5Y5CNoy1RTiilN+IzXP/uhchrjol5w1EjbNs5L51 Vp3UGTTWK+HiDcS9DXH1j3Jat9Hf60LZlkk+WR0Oid4NDvhDBSN+itndW1fwD58g2fBU S0nj9mSIu+A8qaw6cRyUtf58dJH20/6+gpbqfqSIRT01mzIXL+7m2bEwLkXM17S5z5sG cbna44uGT1xnFC7TskMvePlVkfY/wiuFXeF7dl0Km9pnnHo9VitHEX5bEcsb6rd3HdY0 DZLy86ep6lQNhwOZeWUYJ0tjRkWLt2BJw25uidWnHMRBTH6cpw9MsqfVQEs15IWD9Bc2 +s5Q== X-Forwarded-Encrypted: i=1; AKwUvBznjR7p+bpqBMg4UAemQ0jO/dbuKEAIZqsyEpn33l/io71dvUSGyOYLfWehYT9R8uCDuj+N6mAfFo56dR0=@vger.kernel.org X-Gm-Message-State: AFuF++kNoH60LAS66zdlC2oVgeRZrsTgV+iWmrolMhxZc20YugLUO8Vk cNdBuaFvLDYRnPoVDpNMB8SHPIQSbAuLh2QmYGZNCw36qVjj8BhDvfm1ZxXkq8qxZHg6tS5u7R0 Bd9sI+inZufAAkU9H9jKPP4XjCc/87sSsaIFNVqySeskN9+D0ID9fkZT08aiTR0BlYe8= X-Gm-Gg: AYBFou0pKOyEPUHkONCjMadeFXi6WMQBCac6PnUeIBnV/QBUfKsGzRU8wRqeOjA/wzM 2d9edJpEnV1xDm49Uhl+4GbhMcznv9Oc4mTI1nOSc+x8N6GpswEHVLSiJwlaxpf3hP9wkXPpY8q g34xTi3noPtc0MiBFG5PI2syUG0yRw3CT9/gIfT2SsqJTIByPzcY5Q6+vT2HjbaFj6VhFS3Bcyu IjylISJ90TF5rnVZ8ZIckjbKa/SVqyK3/9d7BjEWoGDt2oCTcds1mprs6CmHIs4eBvIqnpJ8odZ eK//SB7/Y0kpiwAWfpppZvCuZQkG2+EjyM5/G5l6Ed8kCQ34n+/V/l7fHB4cKZ7Ghdr8CgFJgI3 vvEZf17F7MpsaAh5L8zZWDgU= X-Received: by 2002:a05:6102:8093:b0:779:5049:87b2 with SMTP id ada2fe7eead31-78a4a42c1a5mr7069234137.0.1788786038992; Mon, 07 Sep 2026 06:00:38 -0700 (PDT) X-Received: by 2002:a05:6102:8093:b0:779:5049:87b2 with SMTP id ada2fe7eead31-78a4a42c1a5mr7069209137.0.1788786038488; Mon, 07 Sep 2026 06:00:38 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cff81c9b5sm198751205e9.4.2026.09.07.06.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 06:00:37 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 07 Sep 2026 15:00:17 +0200 Subject: [PATCH v2 3/7] drm/msm/hdmi_bridge: Correct poweroff/audio cleanup order in post_disable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-3-b097cf1eac77@oss.qualcomm.com> References: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> In-Reply-To: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1272; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=yhhU2Xo1HHomz5Uesadm2LHNkZ1Ed1iZL1EHcx6SGho=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqnrVm9n6dtVYfAPmpBWbc0P+7KtDPbjgKRiO2g f4xFQpu2UKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap61ZgAKCRDBN2bmhouD 1765D/9gKq/3TyVo1ZvMaJQhsBKEKzFGivfDq9Tvk5dBvKhTnupclkca5zjjzVs2+6xsrH+ebOc UaKECIR8jCV8y4oLCYPrBb04t5QEuywEKLav4f8RuzYc1psWyNlISEKFLf1MQI5tlLStM11UTvV gUhfCfCC5R2osFIct+5xQeJswYXOYOXXxkjr0A+elhiW3yNyM0e/GeYg93Y0if1K7bU0TQvnteU WZS1hR2UuDsqqmYrzkxAM9S1G+slI29BNbjIpaQ944nEaatkS3O+V9yAeihjw8o4HUMDbd8q1ri eCqRs4RZrMxC4Og5PzhjG68Jo00Ank1cvyfhYOVKaXZB2tHg+iOg7plTlh4c7t/0SGLR5EJy1aA xrlWghOna8gaVdvphL6SoXVWxSNQcUpckkoTFssePYtiysub7yo5T6YNT5vPEuOyhFQRyP/owuy 15FdgKApFnqNg/Fi/YUvl/NJHJ9nqWBPo6J7crUTH3KBnttP7QBEl+HdGWz9pTGhLGzbMEi5hzY z81bTiM0Zc9WhxB5ylU9jEZ09iFlJDJ2a6e+dgCwNiHP+IWwgG8gsaY/7Y0IwxgRb97N+TYwRvN HTYZ/lwQelPeuZoRkg6X+iskdnFRfUe3EQZMImT87AuS+6G47b17BXHjnOR036Xj5Z9EPvxMrw2 zBfJY2CFdIPJWUw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: Qg26Xk8rl0GbKRD9kiK3iGeYlI8Q0_pO X-Proofpoint-ORIG-GUID: Qg26Xk8rl0GbKRD9kiK3iGeYlI8Q0_pO X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX8V33xgUeMGYB HlAsrCNYYyzfpy7qSb9p71incwHoXJufJGX5OT2x44KuHtGZVSxm3pRcpXeD6QtrbcNSRQOnQrb CTT4H0MmlXBJccNFGd+4ddvtBAfLmRg= X-Authority-Analysis: v=2.4 cv=LseiDHdc c=1 sm=1 tr=0 ts=6a9eb577 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ksbDLleXNvo7xJVorFEA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX/gZpryCF668z rW2u4Zykbd6KVFuK4wAvndzvYLvtfIAQ+Ky13FyQ0U64bGE4SZCAFW1sp9T03F8TQQ5piAu6P8M Mrp/3WhzmWgs9rtYxD7tYhiFXMPMAcNgMbjPRiaE2PIdAAii50qAfdfKxK1OFMN9P/6f4DBK9Tj C7sjwAIlkjemN7OJpbMiLKBLGxNWHhK8uQGXTOv9ioUYSrwhvJEVl6wTzcRXIsdERd3B9ooKhjT 2e3LopGZwjoek6D5exO0KIlJ7zHx7YgXLeL0LW0GBJ0rGrHuOZREtmeR4lmrW24jY4MXRpkVxMw 1ozCWVV+MU9YiGpDb2m/RgSu/hTmyfU0Y702maC1jA1lSMDwsrx6oQ2UNGhulcQRMDc51CWvVIl 8aWNnI+r6UcQBspw+fRGDG+f7xD5aAwMPgDRFgHpPMdVwUmABD2Jt1tx+uHVoa8DCuDOxO70vSH 76LlZxwLMMgtGUWZgXA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_03,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070143 Turning off the power in msm_hdmi_bridge_atomic_post_disable() should follow reverse order of powering up, not only because it is logical, but also because msm_hdmi_audio_update() accesses registers thus block should still be powered on. Depending on specific timing, existing code could have accesses to MMIO of powered off block. Cc: Fixes: c0c0d9eeeb8d ("drm/msm: hdmi audio support") Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index db85400e574e..04c893062dbd 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -339,10 +339,10 @@ static void msm_hdmi_bridge_atomic_post_disable(struc= t drm_bridge *bridge, msm_hdmi_phy_powerdown(phy); =20 if (hdmi->power_on) { - power_off(bridge); - hdmi->power_on =3D false; if (hdmi->connector->display_info.is_hdmi) msm_hdmi_audio_update(hdmi); + power_off(bridge); + hdmi->power_on =3D false; msm_hdmi_phy_resource_disable(phy); } mutex_unlock(&hdmi->state_mutex); --=20 2.53.0 From nobody Fri Sep 25 23:10:23 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C72D74772B7 for ; Mon, 7 Sep 2026 13:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786059; cv=none; b=fOponQP7ute3K2aSm4j5kqa3KAfxR4F9C0GYGs/KAvqsyxFtj1xtQo+9FwLJtOBxzK90uBGugaE2rA5u39eHDFohoFp/R9ifuWq1k5dmuSPhC6pffMwJYrgum5zZTIbcmiemU1wQ6jVV1bAC3EydRQIfZ/CAKZziHGb++PoYEZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786059; c=relaxed/simple; bh=lpPbeM6c8VvIV5J0fpRx6DMejGRPAycCbF+JSHgz2Hw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fLB6rysxQ/lowsAqOBeKoE++jk8UgyJov03MG7vDTwijH+FavOnVDOgcYdSR59gaF72NMiue0KaOnXEjfFpmnIGRbcGQVtvGfDAqsQxs4IbuZuHgeI7y66nC5fHxbRc22ULJhqdnHn8D3POkFYgzVLh5ESMYHHPaerXRNTJTKBE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XUZdxr7m; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cGr77XLW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XUZdxr7m"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cGr77XLW" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687AvJWs496162 for ; Mon, 7 Sep 2026 13:00:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oOCrMECTJmCrKwJs/AjWGhAhZLHRv6vQjyZ6M+guQ54=; b=XUZdxr7mZFNkNTFP sTtyHTKLw8amstQ/qeGkdGX4+b77Tm9hJ3Sz5K83eyFhOUkL8OfloU1cbZ7I1JXl 9Y+gvlE3GnVNxTD0fWEzKNKFgnQMRvHAGDD2MLj9gqwjc8g+/DLAYcujXeJECs/I gGX+sDe0+ZzOk4F5Ke2khBAHhuwjmntx6quy2SgdPrTR0MoSTA8AyXUImFuiHRDZ F6aeobqnC7r9n57K56IluFmUbL82yHF/xdgpiZoITwtwLcIFCsrOhdDjy5thQNjM P9N7oHaDMO96AvT1haLipN67lUtSf43qiy7pWMmGYu0v2v/jSjQGwO0bWNjvNovG U4oARQ== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghuyk8d6y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 13:00:42 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-7866c4ed349so3086361137.0 for ; Mon, 07 Sep 2026 06:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788786041; x=1789390841; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oOCrMECTJmCrKwJs/AjWGhAhZLHRv6vQjyZ6M+guQ54=; b=cGr77XLW812185t5R5ZHKyS10PYYecps7qi33ArZsKlxeZNu9upKkW/KSQQeqZN3j+ 0Znym+ygYDEgNCisfXPfENuY0LDkDdjWfx3iZ4ZU8YjaqZIpgwzSuq9QWNUVc5XJQRtt arGnliBpqc4lhUUbG/Lg1AnAd4zyK/8Jz9ukPwqGZRnrXTuyaS4ExFf/XjkmP/+RGFNl jzPxIFnMzocD2q+0rKWwKkwljXB+6OuVAg6XPKwPC4X7z15h6ct6NZi2pCPKs+PqpDtb ij1nJGJyHGRxG/Y47lpQf4o88ohbEmaaudGQU5SR59lCYUMtSUHW05GpjxWekJqlF/9B +tjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788786041; x=1789390841; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oOCrMECTJmCrKwJs/AjWGhAhZLHRv6vQjyZ6M+guQ54=; b=Ze1zFrFWgYZ8hOJr/2QUDVuvqvMTqJwBbLJbUAJNi6Ys8+fOZj3naQWLRua2PPWq/z jmwOjZb/319c9f3xn8SDD2fFQTJa48IvLKE6hgWqUhWXAV3psD/QWEk7mtpH7iYUj4iv Qte8NhOiMUVUBX8t7TGb6WFjAuagOazf9HJQmPvAsVMOOWpmz5tVHgVROvL+40Zq2CFf vfyxrybW/qUidudQ1raa8E1pFM09YNmo3XPcLUFj3VYN6fAvmM9ELFDYnixjLY4Dc8lw rQFfwki5m7x9hLKkgxDTAVqJeMnjN6dovWIXiA5tEeOX3ZXFGGESBTajwp4D4OZJ9khJ LV0Q== X-Forwarded-Encrypted: i=1; AKwUvBwAKfGsdsEGF2G2kyTN8Lq4ZTar39WapISO++1puD/02HV4Xz6ftwwNxfrdHztoLfQllpLHIaNOAvXDV1A=@vger.kernel.org X-Gm-Message-State: AFuF++k/UcJPGhD/HK0glhqjOAkKzyW9pe+2sORX4wdX0/DuCYnVAjhP ksWGhry3QuPMYTi8VZxlf5VMmgmGCiUlxfgeqYIHG1/uaoN52E2M2YPRII6q8bCBZe10imJns1j k1fqZGjMmp2jgNvSXdBo+qmcGy/cM5vB49tpQgGFPwu9EjxuwLCiOGvN7EWGCJBXSRvo= X-Gm-Gg: AYBFou2hJBj1w24N3sel04nzhC/Wfabh9yUwN5NwXITFw/ajmyuoDHcGrq1rGPhwWCF H4CqGyPrFBLXkwj2zn1xBv1M6BXAN/yaPjMqwWaXxENW/CsctecRMMBIOO941yeFlhks/vsadr8 X9o6syYUgEvMmReYygj6j8Ll8f84Tnr96E/NrUlasBgvuY781K8Q/pYqNoxX+NH2JqmWBJg/Vbf Gfb2UDwAnk7ryGROAidTM5kHo91+6y9+mkie5Bo6VZ5f+4roTsyH4LX9ZhrGuUIuE2zFQL333Yd 70KKRb7RONcLLdH8Ur9DvMQymFlv9K7MBBAy64N+zb53j7mMUSuj6EvgJlxMyM4Mc6QpdTBlRjQ lRvUHTxLBPnyIAXYH6AlZTZo= X-Received: by 2002:a05:6102:1481:b0:784:b9ec:9144 with SMTP id ada2fe7eead31-78a4a9c3a45mr9664127137.8.1788786041501; Mon, 07 Sep 2026 06:00:41 -0700 (PDT) X-Received: by 2002:a05:6102:1481:b0:784:b9ec:9144 with SMTP id ada2fe7eead31-78a4a9c3a45mr9664094137.8.1788786041073; Mon, 07 Sep 2026 06:00:41 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cff81c9b5sm198751205e9.4.2026.09.07.06.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 06:00:39 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 07 Sep 2026 15:00:18 +0200 Subject: [PATCH v2 4/7] drm/msm/hdmi_bridge: Drop redundant initialization in msm_hdmi_bridge_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-4-b097cf1eac77@oss.qualcomm.com> References: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> In-Reply-To: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=909; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=lpPbeM6c8VvIV5J0fpRx6DMejGRPAycCbF+JSHgz2Hw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqnrVmM7LwsR9IfN8orQYy9CM5ColVQFdi2Uxw+ R1SoJgAFDmJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap61ZgAKCRDBN2bmhouD 12GkD/42dhUM3tdTjVHlHyOQ7i4kV0Aan+nz0E+fR4TctoYft9l66IJD9FM+HWeUC89stXt/EIK 6LpHTvJ+b36jnJGjNf8EHYsqmo1HoKt+khdlrHPyM5lEAzyPD7RynzOdKZsdz1zictBsgCJfjPD L+Wf3hSqhX1Fsr9opjEdDkhKyULS/OSKaQ+J55baoZQfoFKXXh2BAkhex+dABVJ7MSx2z+f5OTF 0IElxMpwoqE1m+LkD54pBbkVnOHlqQrWWNKwDJl411Yq1oyGANl90ZabtI5OxaJcad6hh8u7EDm 2vCklTdYoFl1zNsYVmBi5r9iLwcN4RRp0ueNuJ/km/BzJbR6Ad1hVMB4NxT3pfUOwBkLsUZRxiC ZbAdbqDZ0dpdKB78kUqhSG+xPxtACQxTSr4+oH1vrytIxyKdagXWHziIVUKYpklGFogWF39J048 AnDV4+gqGjNWa7QHbaYrbNqdQnMghBzumeYKOrZpXQXIVz94wNn48563ddTHz3Pc+eaLRL4TBUn 4DuWY7tOrno5IQdppx4UWBjkHsVObLKxPcLdnf78QMi3eKvVRjF7kf6ZaPfnbp2AtuxVTeDkBCq JGB2CVKzS4Hbk/vDl7kzLY23iJrEEbMpwvegL8yuBMOhXKa9U58zta4Ox0HVw5jv53/epe5b9LF qlKdMnieE0dCW3A== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfXzwvV+nizETwx z/Ioe56NIQWz6PC3YOmHWkqiKRAKMfFnL2fBl4qErTO7iMn1T7uHJSrluPvSyVk+lHjGtWOe4Yx KG7Io+jEx1wnhejc3TxZ2y6vauyJTBI= X-Proofpoint-GUID: OZk2vRZag3IEH1K5vZEoVDVZYW-CNgSa X-Authority-Analysis: v=2.4 cv=ObSoyBTY c=1 sm=1 tr=0 ts=6a9eb57a cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=RZP3y24nY_lDZDhlvS4A:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-ORIG-GUID: OZk2vRZag3IEH1K5vZEoVDVZYW-CNgSa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX/0WmPzWz4jZF In8DhUSejotUR68FUg5EOhjMpLjm10U6WZD85lK03OeFTMQMQItw4VZ3OL7TAsEAuCNp4/teaRg R1+oZXBJ2XWN1QrRE1aVV1CnQS0KDass8MV7gTJ2Jw/YfltV7EiNbba9sK8CiGKriSsqJo/PrXm G6agimbLHJV2g+0XhOWDfKbeSdSxJGepxIfTM8ca4jVv0uj8mhgehKpC4oPaEJwOO4tzjcc1ske HV5eYkM/oy+BHNZotwTtONgJroVxgKvfI4z5aiw2G5IDmJ/OEsYxw0qSHczR8/wdBCn15iI2ueR svKZWVyA/SKykBOdNRa1SD51NP92hmcKX+hVNF6miEUdPUbvy2lLkt9aMNWP8/6O+ambJgjy0qs 7qECLVNN1Tb41lH23ycYWx2Dd5tMpDj3quGCP5jDhkZVaVl6sLIkrR77OD9d1wz22wJmwGIwm7I 4bY5npBbeS1o0zuCGBQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_03,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070143 Local 'struct drm_bridge *bridge' variable is assigned in ~13th line of the function, before any first use, thus explicit NULL initialization is not necessary. Reviewed-by: Konrad Dybcio Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index 04c893062dbd..5400edd7507a 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -484,7 +484,7 @@ msm_hdmi_hotplug_work(struct work_struct *work) /* initialize bridge */ int msm_hdmi_bridge_init(struct hdmi *hdmi) { - struct drm_bridge *bridge =3D NULL; + struct drm_bridge *bridge; struct hdmi_bridge *hdmi_bridge; int ret; =20 --=20 2.53.0 From nobody Fri Sep 25 23:10:23 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D19624D8DA2 for ; Mon, 7 Sep 2026 13:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786066; cv=none; b=hsVV9nCtptsDd3b7L5EMMJNWsN4HVp5v/0DIw17XyQBny89hduknZaDDMqiJrayJ8XJlaM26W9w3v0mofdJLStKmWvBuCSq6mj/FLXByQ8cNMg5u10xXxFwsIhMjAm/xG0I4uL+in/IuW7rePZvlcc2J/m4zqqIPuvSWhTxYe3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786066; c=relaxed/simple; bh=ZRj0b4CjBJiY+zbzfjhuo2OcOIwPPNsvrYbekJ6R8r0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gDXsYGTbfg+oKNwqFiMS2eA6y1tMMEZ6F6mgETJMRpt0RwPKkUyp2RGNom0D0apaoa2R8XRkDj1Q0EzE4atfydbj9bqDjzLjapZd2AruAmdqwkYqIBj6OCsVBb4dCTHVO3DxhVxrr4Io+1KCN2LYwX8Y4F97LgQr1zZI/Udg8r4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eqtCptda; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fRFcCa9c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eqtCptda"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fRFcCa9c" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687An5Np3230511 for ; Mon, 7 Sep 2026 13:00:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NGtKVbi4qmH7perY7eTj05kWZ+nIVJ906qYqVXk+WkM=; b=eqtCptdaQTArUrq9 g+YYDgNZL8xz6P55yHV8P9TugFEVvLfjnZG9WaD6pz0SXa00xXJCmf8P0NXmzKNk dKjozeCc0EhLW5lDT0zS9PjwLCUqS+9IAjE19ql9DRDLZpT/DVG4R33Uca5oXe/v vhrEtKJJEaU9Xm4nHHWqA8sACbErCenB3DlCSEQI2xTjYckmk2cRqcO7XJPMlLGy fz+hrqdyj07xAlTCggL2WFxaaQyZS1zMWPRP+LHDFm3yL58lbPUmrPhik0Xc2/HI eH+S6YQrfyuGFFiqmeeG30zXFDXpqv1obIKD4VhZlPHHDUPFc3CMbduRO9RlbGme 96lIbw== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghfxktstq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 13:00:44 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-980989f5030so2133820241.0 for ; Mon, 07 Sep 2026 06:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788786044; x=1789390844; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NGtKVbi4qmH7perY7eTj05kWZ+nIVJ906qYqVXk+WkM=; b=fRFcCa9cFX6yO6uU2FmHzh9cICU9w8OukChyqv1w7PEw6BiR7rv3S3s1ypTuTkbpVh bJyQXj8n2ELCfVBd8oBP5ptSvRTg6IQvWgnhVoAQ5sQ1iatbXHPQ6rn3hd2nVbG416ik CJqC9W4XkOma1I/303G8QuN60hWiOn6k/7Xz7D8wphIsWNkd1a63VzoTpZcWzdiofMBI PSvXBB5skQzqelGWiMlsarn31WQzgUpAu7QNyEvhwBvClkQtNHlyhmDbZ6dGz+m2URpj wSRTz7eqj0XAdd+8ODGYj2s/0Rc+LBv8BjWq2+k8zV6ccndzewqOr2vJbUTM2IxcesFA ISPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788786044; x=1789390844; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NGtKVbi4qmH7perY7eTj05kWZ+nIVJ906qYqVXk+WkM=; b=OdMXZ5pW45stI650lsmEc5KhUpvFWDNeHR4rYNMWTr7arxN4Sci6RthatY8Fglrvrd N+QmBKpwaKW0EKwJSJ48JzrqUUwElzzQQlCJuk0Q5dzLgV8nJTQ7WgwO2BAinCoojUhX +V18ZoVUEdDUYH1EArVFcdI9YUoaIOz28gCmkLx2igZzeGVR6ouO/A6sQ7MLULvdPG1q 9Y2zuqbVFkUTNCuHJBm3amZl8i/XLvcZ39CQL8XZl5+JKMA+/LxurQm2r54VRXE739Ac EOvk67IyLQPKkzrmhc21U8NeZrC2q9EZmv6hc6spf9IRQUGvVS0Nl+yR9Fw1Nt+jB7hw OB+w== X-Forwarded-Encrypted: i=1; AKwUvBw9ks7G35duK1Np97tcz8aDhEyeFm4WGN/bo25MQmWhpAeJs+7k/B032uzcIxn1knV0OElbGyrsUibLnRA=@vger.kernel.org X-Gm-Message-State: AFuF++ng5/MW8zvpIU/qOEmtatVTgSyuCh3LIB5HdG5NdeoK0O+Fm0UE EeAEGNzGB74TJxy3VyQivtR8C37xyoSaUvrLW2YPFofFNSMM7QPCFb4XbLwL/4FmymNfVCYKQ7K SuwE1hewUPCbQblRPzWrCKUlpMW+GPqtwDRwaKjsLqkI5W5XU5sOW+iwxky0UwMZiZBo= X-Gm-Gg: AYBFou2nSAadvSYXSTLytX5nZf+oex7rxuR7+TIMaDrR6RSeW7LBQbFzVVcKC12JNiY r7+Yv7LaW3PelgumVQUTOJ6fObhuVn9ghdRGfMTs/Tlc77ZMt04aFEZ7DpqHLdlbsFT3AkWmIfj ehipu9yjSQ7ukTzXv9rXAtzPw+HtvUXjmy9f1hN5EdnNAIrCe0tH/eL+DRH3D4mYT8UnvK5H1bY REtKRYAE87sDsUn8oGvaIxoawuZOlY+AKcnk7G9G+TIxnJNkyihea4i3oz0eE4th3wzV9ANGKfC Vc0HNkxWKsfzR8zu/2SpiGQuczG63WhigYv8l7F9/ePHpaO20Y4DgM+H3gzwLkytFnlc/O2g930 SuwB7F7AV8c+/yzDVWzEs+U0= X-Received: by 2002:a05:6102:6b03:b0:77b:ae7:1bba with SMTP id ada2fe7eead31-78a4a72eac3mr10147539137.3.1788786044391; Mon, 07 Sep 2026 06:00:44 -0700 (PDT) X-Received: by 2002:a05:6102:6b03:b0:77b:ae7:1bba with SMTP id ada2fe7eead31-78a4a72eac3mr10147506137.3.1788786043927; Mon, 07 Sep 2026 06:00:43 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cff81c9b5sm198751205e9.4.2026.09.07.06.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 06:00:42 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 07 Sep 2026 15:00:19 +0200 Subject: [PATCH v2 5/7] drm/msm: Properly handle msm_ioremap() without name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-5-b097cf1eac77@oss.qualcomm.com> References: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> In-Reply-To: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1298; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=ZRj0b4CjBJiY+zbzfjhuo2OcOIwPPNsvrYbekJ6R8r0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqnrVnrY6Un3qGaV6R6PpT9owSV1PPsQRqJT1Ex C2z7Fs67BuJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap61ZwAKCRDBN2bmhouD 1205D/9oWdKMeZv4Gh96mdTXW/owcShNTFOLsw4lBV1YwwAj4kNcymfEgy2EQ+YIaU+Aovimm/E t4YfGU//Ef5YuFn99vyC63ba36uJ0Ym1iC4htCpHQ23dv5s8qJBhobHPRFoetDR2MphnyIBAhWs 9ODbrE+woaW8W7gqhAxhiNmMZtS+TEUMdX5BJTEQ7th10nq5BcPx2tEbjgIegl9fwXvprv70WkB r7cZVQqUfC75A+Fq9G5vJii9nlLWZoTkrbQp3OSiSO5G5d03a2AY0VMB4WhU2z1Xjp52GpPl9YG SNiBoFtffa4SJ/jrl/xsPV3uO+TNt+Du70F2GTu9Vfkn+mC5dz4GgUcn5X3oqJ9BMCZNmaeUFrN VAgPMpfPMWJTYjw0VxGK1/kV2rZ4iMZrmD3nvaAKi50JIZbqEjjvKM7ZURTehO8apsMIK1Uypd3 SNN8Pw9o0a5oDhA82eGLQM01Gb+IdJoegdBCmJGm8jnOWvIDLJmE/I7f0H38IdDlnOQKkVPtIEL 0bVuLgxfq9rfD6FM/a0vrICd2Bcs2ReYsXeNUoAhKiAPz08WhnDxkdOKA0u7jfwL8HRj7+TPEKD nzZ8sUPIS/ewcSwFtvdxnbplBnnOneM/1WlezQfRxHzprfKcMjrCVLMAX+uzCgxIF7YAKxphMg3 Pm5R9KUrUBX2DyA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX9XDuHQf2/+Gp 1raW5R3JqAruyeqRdRD1QKgGa4s0m7pDX6jsRXb3WKfe8w5tsIwywIrv69tfi1Z5dMxcS9/5XoJ wtXy315IaAmRKoazWGYNorr3nPKX8rTGSdY0qsHcFZ5wn69UM4efv3rVmvQCOq5880Qcai4IOnY 6NNSE8cg4ccI1sYzGpWw3AmP916Fqik46C2UMW+EZL46nc0AAIGp6xXYUvJX4m7rh6JCw6Q0ZpU 43tKgPlR1dDYRwlvOroOZT613d8xNRXNoAYN6f+WZ9AYl42ivh+7ZyCx2SF+erWx8Mi/LO+qB/r dAwa+fCuM4rdOU0PQ44LcRIvmHVPsDhd2oRJJVvpCDjXC1/w2bdNt7LfNSGf2SjTO9OZhMOtYK+ 10r6JokWFI0n3im2hE53vS4TEoVFqjZF1GS384+Z1ATzLWPAC8d1ztbcfsjLSUruUQPbd58PAde tuu2V+CwLWRMVPWtXSA== X-Proofpoint-GUID: e808ERmYXmCGo9hMP1whD517HxT5REy7 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX3JDUiHtcJnYP LU44Jm0htx5Mvor6K2IMBYE00CLYIklz21KKE6rVb+o9fML/4Uex0vBeybpRxPsI3GP6uaeymhb iadSTfHyCkaKmlsR15hE6Esqw/QHYr0= X-Authority-Analysis: v=2.4 cv=daOwG3Xe c=1 sm=1 tr=0 ts=6a9eb57c cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=or9nyMeYumr6D7LEzWYA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-ORIG-GUID: e808ERmYXmCGo9hMP1whD517HxT5REy7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_03,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070143 msm_ioremap() accepts being called without name of the region to map and in such case maps by index 0. However error paths still use the name in error message. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Abel Vesa --- drivers/gpu/drm/msm/msm_io_utils.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm/msm/msm_i= o_utils.c index a6efe1eac271..0a4ac0fc5fb5 100644 --- a/drivers/gpu/drm/msm/msm_io_utils.c +++ b/drivers/gpu/drm/msm/msm_io_utils.c @@ -77,7 +77,8 @@ static void __iomem *_msm_ioremap(struct platform_device = *pdev, const char *name =20 if (!res) { if (!quiet) - DRM_DEV_ERROR(&pdev->dev, "failed to get memory resource: %s\n", name); + DRM_DEV_ERROR(&pdev->dev, "failed to get memory resource: %s\n", + (name ? name : "#0")); return ERR_PTR(-EINVAL); } =20 @@ -86,7 +87,8 @@ static void __iomem *_msm_ioremap(struct platform_device = *pdev, const char *name ptr =3D devm_ioremap(&pdev->dev, res->start, size); if (!ptr) { if (!quiet) - DRM_DEV_ERROR(&pdev->dev, "failed to ioremap: %s\n", name); + DRM_DEV_ERROR(&pdev->dev, "failed to ioremap: %s\n", + (name ?: "#0")); return ERR_PTR(-ENOMEM); } =20 --=20 2.53.0 From nobody Fri Sep 25 23:10:23 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC1534E13E1 for ; Mon, 7 Sep 2026 13:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786062; cv=none; b=d8cAM1ca7sdixfJWT0ie3pVGemnCi9FOv82lIWsIDk40JSOSptYVY6gYZxXeFBDiCH1+fkKSq5KgbAu8vQWUfMGF4+Tlw0uB4AT4uxfsO7ytppPAIGPaElgjfI8h2czTvj1wCWDm2razRJZMGByEBAGt7jKJsXIHSiOOEPcnw2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786062; c=relaxed/simple; bh=/YVh+L5neHC3SlylyZSkY52kedS/7Okrqq86t4o1xdw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hD0v+w72GtkvbJH3A2n+v73xKe++gZENvQJe/IgyN/KW0QKDFQaMrt/Yk9/B7HwpCWYwLAnqI0pVhjF8nMoFwsgOpTUAL4mlrzpYDX0W2usFKgVwlUkJBqgF6czZlGN37f4YbRYHxyIlJAcbaxN4BZNr7h40zhojbTWNeZfaVnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U0QyZFyb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xabq7Gu/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U0QyZFyb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xabq7Gu/" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687AnDch004214 for ; Mon, 7 Sep 2026 13:00:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vizWdKJGFAB1HJu6hwMtO5oQyxT7j0M+cp6kkFJFsqU=; b=U0QyZFyb5KLlWYk8 y8Ms9NBX7C+Phqwu8Ja23/VESvpzoMvk/JXsL3Oi8uNXNanZvrQBAURcGEln0dhU imAGiOxBvNb/EkQcgf5b+PafT+OV/fS4GjbzG0IU4k68ReQbByXmawJTIJrLP1z4 op2+k7il8TCk4R7rQsUOd9W6EgH7GgtVk5DVcWIDMMBKBcxRjvtBXnlAOII/nzX9 vaB3S3hSlWAYT+jCsuGDzB8cX6OKU+P+yR/5pv8Vz7yDHbx1Gr95znCsuiphDKEY 8rW0xgGTs0K29ojscyIzxbq80hyJH701/z3VFhjolYhfdTSXUaEBdu/EStDorqvF /xHrNA== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghssg13bb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 13:00:47 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-78a6d5cc851so79148137.0 for ; Mon, 07 Sep 2026 06:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788786047; x=1789390847; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vizWdKJGFAB1HJu6hwMtO5oQyxT7j0M+cp6kkFJFsqU=; b=Xabq7Gu/Tsg9c6CEsjt77iLNyjzW8YFHI3Q9oBLeTAc23mxZnxMLbkdJnbuY2/dXuz Z7/hKlR+vldvMdHq4zNY+NXuggozVArqLu2KVZKMEho8Q9Qh5Qol509nfFmDRmbR2A8U n8tw1LnKl+pWCec7tWc3TS9N1LPvjWV5m97489vq5Qpp/jVcXAG3fMEVB5WbgVEoOjxl bitcvTaZAjrqSPt/wwYeWjeFYb4dWNityHyjwby7Ze5JmWiictbMD7A9QLiqj+P31bN2 Ea0WoVS/w4sPphH44AS1R+cUn3dYdq9pYkx5C4mojeVs9pEXIjrZw3MWZy5dNjcNuPoD R9Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788786047; x=1789390847; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vizWdKJGFAB1HJu6hwMtO5oQyxT7j0M+cp6kkFJFsqU=; b=CZ4KRe0rH1RWVtOhXtbieu9HpXcov6SutPvZhR9DcqZSfEeXYUYWeRJY/vOckl2LRK uQSs0Vz4iGc4dIzjNgk8RaHFpeOTgX1YfsvPJXY9k3boT5Dj9gOhVEMLdgGFGyX6gOBQ I88Y6FcQZ487rKLkYcKaL7SKO5PCPYtGHHqgNl/4+07wRHLeZBBj7bj24HvN6LscnbrX BzsnHzVGjS9bo//iYmbRXphIpUj0kNQ+eXrTeFdXB9xI/wwLKSSTWZjr0G8egP/Gxv7S G7Rzpi0e8O088DZOUKYiuGNSNv49ZiaUypSpC9WljBIKPkF5+PK3EhKAPOC/8+sGcOnD lHfw== X-Forwarded-Encrypted: i=1; AKwUvBwHD7yPd9zla5lGwom/jaPgmQx3VDrG/FlpdBLDr5kviYmOlQeDt0zhMwNb1MWCwR/2Uz/hcqSvpqtOJCQ=@vger.kernel.org X-Gm-Message-State: AFuF++n9lO/VmSfqpJUg299hNOp5DlC4hqbcpKMqNcN3H9MdqhcKJwg8 jO4iJpXwZ46ci6609q2bKNsBjp8ItjRZ7I6KJMrnQop222eTkZ7Ci1x3roPljK1/jwGTy+unXIo vjYvQBS05RVATmSE/tvxBL0fHG0z3BwuHyj/5UlPz71AMMl7pd+RXiJmXRvdxCTkvmyY= X-Gm-Gg: AYBFou3RBxTky5wltyZbw1KFqoJRxanIUvzXAXCj8q7hErBMrhp/6K+hFJj8fAm6W0a ORJGE6kJXpbZKNj79kb1NvDDo4Dqc0y8SnsLeLmBJEgeKTV0wtXW+qcAOsR3yHteNVWEaEelU1g 1QCVwjYgzLv14y+JR/enpqE0j0tiM0vrCWiY/mplbqGEvGuuNGgwnYhRah2/5xADXClZiPpFM+C CJR75iY/q18baqIAS6IWBTN6CcQK6qheXMFdneGYu4quFobP3jxOrI71qT7TDzBJ4VR1Ek0/clt H1NdwiRiyeRWxvzMP5QQYL/OApjYpm4SmM1xQchCIbb8mE3hbKdxe4u7+gS8YjkQnBVtLmnmwpg oNG/3xq9S/iaeCcPwc1jUXL0= X-Received: by 2002:a05:6102:3054:b0:726:cd42:d023 with SMTP id ada2fe7eead31-78a4aa3506cmr6713737137.11.1788786046837; Mon, 07 Sep 2026 06:00:46 -0700 (PDT) X-Received: by 2002:a05:6102:3054:b0:726:cd42:d023 with SMTP id ada2fe7eead31-78a4aa3506cmr6713717137.11.1788786046373; Mon, 07 Sep 2026 06:00:46 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cff81c9b5sm198751205e9.4.2026.09.07.06.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 06:00:45 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 07 Sep 2026 15:00:20 +0200 Subject: [PATCH v2 6/7] drm/msm/dsi: Fix indentation of if block in dsi_mgr_bridge_mode_valid() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-6-b097cf1eac77@oss.qualcomm.com> References: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> In-Reply-To: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=859; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=/YVh+L5neHC3SlylyZSkY52kedS/7Okrqq86t4o1xdw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqnrVoYKlet5BEdF1OEjdeDKF+CC9/cDNCyhAqO C0NL1jHwCGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap61aAAKCRDBN2bmhouD 14WZD/4rXDWg0PmMoA6VCJqIYCdWf2B2C385vSgk3FZWplp0SgmTcNpbmjOSPlHGniaeJhHigKY 5eWv5VAbVWk0RbXURY7nWAjuiT5wQU1BD3TKph93/rCeSYv49y6wMgVF5/n6JgsnwFYsoQcCwCu cg4uhPP+nBBnCqS2U5p676DWciFeYK6VSt+CHjXqVbwSKOG03hMlOBOEstfnCMes62cVn0PNRjR hNwbWj2uxqiJ0IanXuzipepLUVCtTRkarlTYqknoHut5aWnA8rEKMyrtODemUluLfyO9o/v/Hlv CpkkImTeuXnquiiLF4Cifj6awb0uEhNFkCEY+JPEo+/IERu+HJkc9WkX53OhYAmXIWhAnjNZAaB UD1C/5I0xX7mNx1bTqgMGyQgO598ksl+yh9kVNPzPUzR8m+W4iemj3IUvonBxSNMPL8F1lCY3vs rq0JLcBWX5Be6azuvjAQxPCgthxCMmwBJdRdDemMHCG/gl9gN9R9TwffIZLxQzZaa+X42ZUfURU 21Kl6OVsZ0fhWUuq85MJxerUaNApLgJ70HKbgGNupaTC8HR0O8eL6kW+60yAZ4Fjc+9YMf5A31G mL73oJ7JYyv3a4OwP7gZGFjiZERCRnFiGmDpNyANgLMTgg2ArbPMTjvCuOeipfZySPx+wkb+G2M S2sUfT62evsbUpw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfXzvy9TIHrFIg2 Z8Q8Y2GfBMIpZ87xO+HQ4Micz5Sak2ScEY70rePIkx0SMDtkylBet6YnQJFqYApFFJkVE+/ySut T5xz7FjBRkB3DY4u3HC667EQ1wkduOFIYr7+7bZgdQSmSCxKC2ZLi1WIKSpq5KnZjKYHqKdtZvx Z31fmMI7qk5UsIhJ16xcJsu5Hu5Z6Cws1Rmg1aom4mFmX75YPOZmBS/1AEdq5mRBOGvqTeEQf3m f5tD+43WM9wdNs0RGOtZ9OSqyfU/TdzcmdHSJS78MZtQtSahLvd15Nq4bcoyKa29LNRJ2QxHwdA LeDPQAaNxamT2tj3osPoVJDQNRJbPDNylLcmmngZOEw5PjvKVbPkpnCebejLR6ioKCmM7XFCx9L 4g0frNMM/Vfzv31YKWyzld8mn9vCu2Xdq05IoOQn9j2IFE7qrgjgc17OSx7PbWFs/clo6VkAWi0 wI/iydrO98yyhZeLheA== X-Authority-Analysis: v=2.4 cv=MrJiLWae c=1 sm=1 tr=0 ts=6a9eb57f cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=mamL7KDpJlut8y4y1IgA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-ORIG-GUID: WlOnxF6tCmIeZZMX_2ph_vStk0ck85KG X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX+SnIBK1ly3Qc XNd9bdtAiq081ZsPBMMr4jRq112JyZZKS2Xe4UZKcaHP5JUnaGHnOQRGcQb4q6UsQdUMj9Wn8yy J+7RRXfRax9Rig9dC73Tv0LBF1b53WA= X-Proofpoint-GUID: WlOnxF6tCmIeZZMX_2ph_vStk0ck85KG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_03,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070143 Correct confusing indentation within else {} block in dsi_mgr_bridge_mode_valid(). Reviewed-by: Konrad Dybcio Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/ds= i/dsi_manager.c index 959daa88b1d0..531d4ff78f56 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -429,7 +429,7 @@ static enum drm_mode_status dsi_mgr_bridge_mode_valid(s= truct drm_bridge *bridge, if (dev_pm_opp_get_opp_count(&pdev->dev) !=3D 0) return MODE_CLOCK_RANGE; } else { - return MODE_ERROR; + return MODE_ERROR; } =20 return msm_dsi_host_check_dsc(host, mode); --=20 2.53.0 From nobody Fri Sep 25 23:10:23 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30A89463B94 for ; Mon, 7 Sep 2026 13:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786068; cv=none; b=LVxmD7LxQLkLRAqAVNkjFIs4hpoSUSOf8Xtd+3D0FJF+G0YWDKj1jMn9cGFlyBBD3jrlM6Hs1UE+yY8McjUdoEX3Fik9rekBtyzAyOqyDfsynShNeo/v+uLS78Hkp7Ee8B8bBxl3DUKspN3Yp7ISY3FzuNnXQTBArF0fU+C+HiY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788786068; c=relaxed/simple; bh=dxt0nRLMlCSOHXCt5GgWA+SbZAKlsIeSxAesz/KABiI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oTRYZA3UH1szX87GJ4D0EA5LcYYGNHf7eP31yIvZojm/Au0+htmixyyGEeRH6ekzkHGgtMM8caytkXhgRftzQPP1CEp+1IQV1qJpNTD9ZUGXpfxcenjfQtoWHed81FBJxDn3efPMMPNCnu3lstPXyp/ZgQmTV04iTsfAxw+SQLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JeyDuyqh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VK9jB/4i; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JeyDuyqh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VK9jB/4i" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687AnGtO3863138 for ; Mon, 7 Sep 2026 13:00:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5Zxd143ASUomJNNgHPeOAeQIGghuC3wI/sji5Dtl2sM=; b=JeyDuyqhPyOJhQNo dwaVgIkG+yKlIXzw44icOX4UHs5HZFBeWgQVQ8b9S6rXB1dym/fL15+FLHl+hm+e Ch9MzwqSRQNVphWaHMvcHlaynYiW3wIPsMCtbMQcbmxP2aah+G2U41aAqxvOT/e7 fVzOZ8RIFHpyL1o3FopcWrr70Szpg7np8EL9VE2w3zp24ZC7Vtgy+/iF2+QO8/9V 9Z92mipyt65jv3eRdkbY84hQFN9mfZHPYaBcQAi4o9/Qishd2kdIjAwcvsWpjfc/ PLVqCPtqGqo7amL5/WBHZjmBCS+D28FJiYMAlis2L9oIwk+3FqXEWtIlAsRJSyMU 6AV9UA== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghq66hwe6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 13:00:50 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-97bf8f3a38bso198540241.0 for ; Mon, 07 Sep 2026 06:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788786049; x=1789390849; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5Zxd143ASUomJNNgHPeOAeQIGghuC3wI/sji5Dtl2sM=; b=VK9jB/4i/B6LRZLWV8LG5PD/jJBQd1eZsMjCJ4WON33XL6XuA8c8JI25gyGf2h6pPb MwwfbogZe1KlVERJBwy4yQdsZmFqLcaXHTL38TAkBWL7R8ruoFHxtNMTEIKTqqK4TqVi ryKsO07sbAZ0gC6Mrqup/NiEDTf2WDHXFqvosJo8dMJqDLkZaa55KU1drFE0XiBZTDa0 /Sc3Va+of/2qUFG6hsXLnYMnG8iHeex3iCspM5t1vnz132p6ecru+Lc2kVwJapw14PQo HsQHhXoBNWWiPeRucHT0ryciRUSkFdWPr/a8FqUTz5/0yOS6/vC2oEwTC6MaSQLsAz3D ekZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788786049; x=1789390849; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5Zxd143ASUomJNNgHPeOAeQIGghuC3wI/sji5Dtl2sM=; b=CEFecOfzE/2fq9/a8iYVfyIlA7mwkDoe9Wxkzh535ax9Wm62KwV8aAd8Fzgl6aVY2D 2Ay4X3AerWMQngKsxa3GkoetBvTfmpDtCnosGMZnwa1yLzfxNXxo/pXiMlPDdsbHBV9T VT/HUcdzNHcnc50dkOW2STtVp65MthgN+xFx1thIqdV9Yo8w1rd6rlwZCe3mlwFaNmpN zqP4h+vWmPxtTXnY4dlIM3iWTga5aZAX/0MGlUhuI3BMn8TTp9403b4hAKxmSeu/QH0K o750CwsQakjzR3wX3XmKLYTk2enNDre89CO6h1e6qqyP7z6/gYmXmlJp31Qst1QL3coi wFrA== X-Forwarded-Encrypted: i=1; AKwUvBxgzy0kjCyTDTZCYMDVLgoIOG6B1hjqaYc8JH5FIeooGvQkyUhY93M1MW2m0mHDgpBQ48vVnZJV3Wkcnls=@vger.kernel.org X-Gm-Message-State: AFuF++k3c/p96vmcUmJfbUl27Bvgvz+ZpuRpiNlUfadDreNsLNXWvrfJ rybxRBPcZyXlELbRKx+8FZWhyMrfjunusnRgYdHUqJzQsiz0Tsl+WR+ENPQpg0QmvPPgFtC1f3Z NZNdFH5Wm/mTrOpI16K0oCJqyQmfc9np5NswKa3/01fQTx8IQta6MFzZ9MMxErse4pqc= X-Gm-Gg: AYBFou2imvAVB2IwAwy3HQ3teOGTKvC8L8hRls02A/w0j3oyx/D1NF2fImjlytGBCJc tuv5hyrDusj/m4krEbzxXBUKXRMqgQQx2AD7qjdogLzzbW/hIf0eg+wMYX2OyziGAFk0m4V0o9L ODZ6jmMSmFEEswgiYRcDhJIkdvPhIaFls6pVJ4jgImJx62hd9mh+prVapsHPFP4fEGNiYKh9y/Q d30Qhzi4B06A+XCcyr1SNgO8oeSjZT5ATKwxVtSahOCQ1OSmapA0Orq1a5g7T7TD4ZGKZBgfIkv Fz9ExPRORvfQFQKwYIyE3YsCFH6eydozz2TvspsICJmfHVEVidC/4/pEWL0uHdajZ671zeolZcd FSdwT8x/MBD/cx2Km9GmsMMs= X-Received: by 2002:a05:6102:8099:b0:76f:eaa2:6fa7 with SMTP id ada2fe7eead31-78a4a6d4adfmr7328434137.2.1788786049292; Mon, 07 Sep 2026 06:00:49 -0700 (PDT) X-Received: by 2002:a05:6102:8099:b0:76f:eaa2:6fa7 with SMTP id ada2fe7eead31-78a4a6d4adfmr7328410137.2.1788786048792; Mon, 07 Sep 2026 06:00:48 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cff81c9b5sm198751205e9.4.2026.09.07.06.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 06:00:47 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 07 Sep 2026 15:00:21 +0200 Subject: [PATCH v2 7/7] dt-bindings: display/msm: hdmi: Correct name of disallowed supplies Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-7-b097cf1eac77@oss.qualcomm.com> References: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> In-Reply-To: <20260907-drm-msm-hdmi-fixes-before-eliza-v2-0-b097cf1eac77@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1120; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=dxt0nRLMlCSOHXCt5GgWA+SbZAKlsIeSxAesz/KABiI=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqnrVp5cFMmNVGYy9ANhImIAHyKD5dGnRPUBeVP O1DuCsl5oaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCap61aQAKCRDBN2bmhouD 16++D/0bbkHFrM/DSB17DsFeQob3v757v8onIfgsK4xIpUIPtiULuD/AG8t0JcY8swQx5ckcrCm raqmFRD4zTdXnygkjlS+0MUr9+5zVTDvB1N58YdxWso47cdyTrA9XES4yWIHADmk4Yu/EobsWA8 +Kg0jWeqjDVoifxxk2ra9XUq9p42HzDHADKOitroD3WMzx2hGpBsIpJdPWIWf66/k13GlWRCAhg eVThPzf9myJWdnmeODBJ+vJQrl4rpCMsKOBWcpa0HBQXCfw/hhRcIl7aayrAKJuefX01wDYuYvi ZbZxGOPIsbcoZKpgeLFOOtxOKal0cFCn+p+ikNF9GKmxjGENd6Q8MWgTaHVH+l6sMaq4FI/6FhT vpvhxZFAeE/sOAvCQnkJqHhCYtaF6fXFkuSRTO4eMyq1dMHWXxTQ9Lo1/UBINsi/YvHrniMsdv7 fi3TFc/mxIm68i8ahUny1DvLamzdcNHpOUiCBpFVe50QKnT3nUEZt+Vwx6Qwsid+BfaSkY/X84e 3s2cQSFrXlc5/sjrmlNb/vbnvS3JM06B6+6e5/Ac0Z8zQuTIXdjZO6wuodgUGzrrOAksYJIoATo Ea4/8xYhjDsnO1tUaqOt+DmnKYLA/MIwvBs/N2t+ybpJZM0ZHumq1j0MzkiIpDokDx5UdGWrxUS /1ynteKFLOmJsyQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=QPhYgALL c=1 sm=1 tr=0 ts=6a9eb582 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=LSMMCDwwRte7x3nqQVUA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-GUID: tSPf_XzcguKGAQsH6XreJf-A4lxmSHJJ X-Proofpoint-ORIG-GUID: tSPf_XzcguKGAQsH6XreJf-A4lxmSHJJ X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX3Gj8CVSNmu3K TLsxSEyWMkjHNoGSiBs7nwQlv42esoa2Xi02jDslp+2r8htDLBsUf7iDxIhdzQEd/ZV3ihZstoB AfTxpwFGOSLUIPw1XDGZjcvrP9/8Rew= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDE0MyBTYWx0ZWRfX6yn5UexT+cDU S7NQJhRoBcl2VLP5GyFABd21a9PlqbU/DNjaxSwgWKVtUt1SqVC0Py1BYOpHUuahawJGxBAqs4x Dp4kjG/J2SnfCfXIDjsmuUtGcHgfVhumTmQ9GR8R696Lv2NcXIc1/sX/HOCjXpaFVuTwV36SKXJ zC2bqfrUiGiTjkhy+YuVLxbi67tAdz1LjKU4RxFCJh3aaql1sV9D1sKnSbjtq+ToBXlzuLgdA4z 5BJrESG4zrShH38uRCIs1AjCdrLq2N2na/JorloNCoUuGxNOTbUNkH9bci+cddmdlYxKeqWHP0W 3fYiLOo7Z8FAyAKEo0bMLyb8KV6g5hel6OAKePEvY5RzH+TKG1JXZM/tQh+xXgCS8fqBxAEf8Aq hrAHkR5dBifAaEsKUSNIyT6BwX4BzgKSiuSmG5tv47rdmn5UFkfy4vA3j/oKzX5ZKx8IOaqwjuv DvAqZO1T4SOP3FbepBw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_03,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 adultscore=0 spamscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070143 There are no properties in DTS or Linux drivers called "core-vcc-supplies" or "hdmi-mux-supplies", so the binding probably wanted "-supply" properties instead. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/hdmi.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.yaml b/Docu= mentation/devicetree/bindings/display/msm/hdmi.yaml index dfec6c3480f3..02d27ccad024 100644 --- a/Documentation/devicetree/bindings/display/msm/hdmi.yaml +++ b/Documentation/devicetree/bindings/display/msm/hdmi.yaml @@ -113,7 +113,7 @@ allOf: - const: core - const: master_iface - const: slave_iface - core-vcc-supplies: false + core-vcc-supply: false =20 - if: properties: @@ -136,7 +136,7 @@ allOf: - const: core - const: alt_iface - const: extp - hdmi-mux-supplies: false + hdmi-mux-supply: false =20 - if: properties: --=20 2.53.0