From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4641E3839B3 for ; Mon, 7 Sep 2026 20:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812230; cv=pass; b=DgMMcZdnYq7/h1r8GLbjF/d/Ic68oRJC6WKkUG15cckqttCQ+/uf610Mgf8NV8WloGxJz4ncI/hWDyo2DxyLbIX/LkDC0d3LGfr815LZjUxcK4lFSa+ThoQzUAxYRM5KmWfbrAZtms8tga7y0OXqPgOvDw8QIdHU/UVeGY7A/qg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812230; c=relaxed/simple; bh=Fw+pEp91dA7obohAWpnhT9o4vjgtW35KWbqZzipARa8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I3zx+8qaYHLWzvJIFP3aXK1I7MHl6FGlpgAUptVKs5jQ4SlVL04VHVJBzNpSgV7QQbaHOt7A6jr2U+Tf1RveNbhiNwrAWRFdQS6NSu7YcRy8XCf7pO+yZknfam0/gfRxeKCifSY3TmYDUqOUeDNqRjpxS1CJh1JbAy86+LTjXoc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=FS/t2oQg; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="FS/t2oQg" ARC-Seal: i=1; a=rsa-sha256; t=1788812184; cv=none; d=zohomail.com; s=zohoarc; b=Ew42n71Vzh717kdpmNMyGJLNpyPrIPYHqTSBmhJrCABm6mpBmoIge5YrigvMCYVH0Z0Mmu1Lqa2v/f+WrjFO2MlT3bZSD5vC8/sg069KMSfzjoZ7E7+g2QIqjqU+y4n8HWmkSL9iQH1WUqgC2jRO1gkxxl6rb0rG0hW1uZ5Uu5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812184; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=JDUEV1gvHja4fWSVHWE1yshZgxKxjnzS5u6zcvauO/E=; b=aSrHoXUCoTqwLlb2SihH/vMG6XOUKVDMShW7lUVEQY0daMz7oUGbo4xr4GD7T30Pfv24yCyqliRYi9LWF9rJM7zjIMejRiOiXwvEFbH5sK2trYtbJW03NjKj6j0u0KdtlCNTvDRcOvSYdxwO/9l1/q0i3S5vzmliVcVf7dW2lIs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812184; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=JDUEV1gvHja4fWSVHWE1yshZgxKxjnzS5u6zcvauO/E=; b=FS/t2oQg/+RGcBqHJpPoUDFdaEfQ8VH+PGVKKocDisuGYkHNrqgMyQt8hoDwcAox CyBR34YebSnNeGLCf2S5fyCoho5vds19ozHL8kF+zzacXOFZP++ieDiYE9yIa6Z7OmF c9ruuT5zeZCrEgdf8BBNlh30ce5fXSOicFMmuPms= Received: by mx.zohomail.com with SMTPS id 1788812183730149.07471808885703; Mon, 7 Sep 2026 13:16:23 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:10 +0100 Subject: [PATCH v8 01/16] drm/panfrost: Move shrinker initialization and unplug one level down Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-1-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6327; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=Fw+pEp91dA7obohAWpnhT9o4vjgtW35KWbqZzipARa8=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuL9aGBZRBKe+kFgPuI8gbUU8QzA7IBKe6lb c8SzQr3y2CJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PbniC/9BY3m/3Vj03PvkeFobg3xxZtV0zFNBmxF36pcc13aZwtZnjk5NektcS8EyGli3JfYzMYM rsZ6KpofxBlpkDF44wVZ8bMbzSeFl5L2lo6o078KU3i3oMQHtXQXNV3/saeqzx9MuVo+TF7eq2o ZO5SdEkYuNsqE6uIRVDuctPqbmADu5TRFtVo9v5PZJB3Kj5ylmNh72+TdbVGdpF2i0Wfh4ir78K MBuxQk2a7FgQL4sUOrmONIyWI+KQkExsJtrRCbua2mLi+a+rQoftTk+Yd78uGzGTwlw0J8f+TzX 3vGAqablhWL4c5OWl/jn73vJca5z1ylaKz/sFeuW+EKbTHPF8vq1SrhDh1mVr98OkLMlJW0RzKe +cmUufBpBgvR8thM3qrHQfgMHowgV7wngus07FvSr4oqGiSBZBSX/jU5/WFdn27pjssRIV7AgiY pT9xOHGlbyoFHHbKUpnoepmPXGW1404syCQAN0muTOvMnkHZhUpzjNNPRPvgZ3NB7qZVs= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Since the moment we call drm_dev_register() the device should be in a position to accept jobs, so it's best if the shrinker is already initialized by then. On top of that, make shrinker functions take an panfrost_device pointer like other functions in the same sequence and rename them accordingly. Essentially mimic the init/fini behaviour in Panthor. Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 8 +++++++- drivers/gpu/drm/panfrost/panfrost_drv.c | 6 ------ drivers/gpu/drm/panfrost/panfrost_gem.c | 26 ++++++++++++++------= ---- drivers/gpu/drm/panfrost/panfrost_gem.h | 7 ++++--- drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c | 8 ++------ 5 files changed, 28 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index 485349faf251..05c40d5a20b5 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -280,9 +280,14 @@ int panfrost_device_init(struct panfrost_device *pfdev) if (err) goto out_job; =20 - panfrost_gem_init(pfdev); + err =3D panfrost_gem_init(pfdev); + if (err) + goto out_perfcnt; =20 return 0; + +out_perfcnt: + panfrost_perfcnt_fini(pfdev); out_job: panfrost_jm_fini(pfdev); out_mmu: @@ -304,6 +309,7 @@ int panfrost_device_init(struct panfrost_device *pfdev) =20 void panfrost_device_fini(struct panfrost_device *pfdev) { + panfrost_gem_fini(pfdev); panfrost_perfcnt_fini(pfdev); panfrost_jm_fini(pfdev); panfrost_mmu_fini(pfdev); diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panf= rost/panfrost_drv.c index 96a66d673ba6..9882a3ede75f 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -1003,14 +1003,9 @@ static int panfrost_probe(struct platform_device *pd= ev) if (err < 0) goto err_out1; =20 - err =3D panfrost_gem_shrinker_init(&pfdev->base); - if (err) - goto err_out2; =20 return 0; =20 -err_out2: - drm_dev_unregister(&pfdev->base); err_out1: pm_runtime_disable(pfdev->base.dev); panfrost_device_fini(pfdev); @@ -1024,7 +1019,6 @@ static void panfrost_remove(struct platform_device *p= dev) struct panfrost_device *pfdev =3D platform_get_drvdata(pdev); =20 drm_dev_unregister(&pfdev->base); - panfrost_gem_shrinker_cleanup(&pfdev->base); =20 pm_runtime_get_sync(pfdev->base.dev); pm_runtime_disable(pfdev->base.dev); diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c b/drivers/gpu/drm/panf= rost/panfrost_gem.c index 3a7fce428898..f39c0f50ed4f 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem.c +++ b/drivers/gpu/drm/panfrost/panfrost_gem.c @@ -15,20 +15,24 @@ #include "panfrost_gem.h" #include "panfrost_mmu.h" =20 -void panfrost_gem_init(struct panfrost_device *pfdev) +int panfrost_gem_init(struct panfrost_device *pfdev) { - int err; + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && panfrost_transparent_hugep= age) { + int err =3D drm_gem_huge_mnt_create(&pfdev->base, "within_size"); + + if (drm_gem_get_huge_mnt(&pfdev->base)) + drm_info(&pfdev->base, "Using Transparent Hugepage\n"); + else if (err) + drm_warn(&pfdev->base, "Can't use Transparent Hugepage (%d)\n", + err); + } =20 - if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && - !panfrost_transparent_hugepage) - return; + return panfrost_gem_shrinker_init(pfdev); +} =20 - err =3D drm_gem_huge_mnt_create(&pfdev->base, "within_size"); - if (drm_gem_get_huge_mnt(&pfdev->base)) - drm_info(&pfdev->base, "Using Transparent Hugepage\n"); - else if (err) - drm_warn(&pfdev->base, "Can't use Transparent Hugepage (%d)\n", - err); +void panfrost_gem_fini(struct panfrost_device *pfdev) +{ + panfrost_gem_shrinker_fini(pfdev); } =20 #ifdef CONFIG_DEBUG_FS diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.h b/drivers/gpu/drm/panf= rost/panfrost_gem.h index 79d4377019e9..5c823cdbd980 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem.h +++ b/drivers/gpu/drm/panfrost/panfrost_gem.h @@ -129,7 +129,8 @@ drm_mm_node_to_panfrost_mapping(struct drm_mm_node *nod= e) return container_of(node, struct panfrost_gem_mapping, mmnode); } =20 -void panfrost_gem_init(struct panfrost_device *pfdev); +int panfrost_gem_init(struct panfrost_device *pfdev); +void panfrost_gem_fini(struct panfrost_device *pfdev); =20 struct drm_gem_object *panfrost_gem_create_object(struct drm_device *dev, = size_t size); =20 @@ -154,8 +155,8 @@ panfrost_gem_mapping_get(struct panfrost_gem_object *bo, void panfrost_gem_mapping_put(struct panfrost_gem_mapping *mapping); void panfrost_gem_teardown_mappings_locked(struct panfrost_gem_object *bo); =20 -int panfrost_gem_shrinker_init(struct drm_device *dev); -void panfrost_gem_shrinker_cleanup(struct drm_device *dev); +int panfrost_gem_shrinker_init(struct panfrost_device *pfdev); +void panfrost_gem_shrinker_fini(struct panfrost_device *pfdev); =20 void panfrost_gem_set_label(struct drm_gem_object *obj, const char *label); int panfrost_gem_sync(struct drm_gem_object *obj, u32 type, diff --git a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c b/drivers/gpu= /drm/panfrost/panfrost_gem_shrinker.c index 2fe967a90bcb..fefae87535d6 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c +++ b/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c @@ -95,10 +95,8 @@ panfrost_gem_shrinker_scan(struct shrinker *shrinker, st= ruct shrink_control *sc) * * This function registers and sets up the panfrost shrinker. */ -int panfrost_gem_shrinker_init(struct drm_device *dev) +int panfrost_gem_shrinker_init(struct panfrost_device *pfdev) { - struct panfrost_device *pfdev =3D to_panfrost_device(dev); - pfdev->shrinker =3D shrinker_alloc(0, "drm-panfrost"); if (!pfdev->shrinker) return -ENOMEM; @@ -118,10 +116,8 @@ int panfrost_gem_shrinker_init(struct drm_device *dev) * * This function unregisters the panfrost shrinker. */ -void panfrost_gem_shrinker_cleanup(struct drm_device *dev) +void panfrost_gem_shrinker_fini(struct panfrost_device *pfdev) { - struct panfrost_device *pfdev =3D to_panfrost_device(dev); - if (pfdev->shrinker) shrinker_free(pfdev->shrinker); } --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 104553F3265 for ; Mon, 7 Sep 2026 20:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812233; cv=pass; b=BB2E0N0CyVZkC6gXrXlqEOjmsApfhXGdZQnY7Tu91A9bweIDroH6/vdLIFjsJvQ5NmlPG6vAKnRCqDz6SP2F7OqotoXf3DCAAz610omSfNUe06uakjA0F7CpSd50VY3HJeE/kGwRJXk21mpm00q2HjdSwhFhssZ3YmwA4funIAg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812233; c=relaxed/simple; bh=BseDd5ptshL8O0X6ZZAknqhIzPZMy2A4L4RfHDWk90U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z6pv9dObUwF4HlS98/wT9toS/FFTzYf16hVdlyYXMlrTokhMoVL3Bz+iYu5oou2tTF7yJf5JYV2urxtwjKUht7UQbqGASp+PdHtFiuKTUKO/XJ3CoYir4H8D/hbjCWfZdZhIFIiu7T/iJ7pac/zI+pp9BAsjYrLzYV94Sr8va1k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=DeJR9Wrf; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="DeJR9Wrf" ARC-Seal: i=1; a=rsa-sha256; t=1788812192; cv=none; d=zohomail.com; s=zohoarc; b=V/jLP+7tey+ziHCAydBMSuWBtRM8uIkJBwD3wQNc7/zEASBF+0DptDch+ycMErPpMvmWs1vuDbLeG0RllPlz5QrwinNBBgq6aU6MjGXQGliw0aSR7U4SHTztHmen0eIoUs0w+dKV9CsTQqEHDbUs3xL84JRoifmTIbLdGF12vYY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812192; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=LZw4Kt2mQuWgyKmlrDPFTNJYeu3IN02ygsBncDd+4ds=; b=AL4d2Sb4447lFmSZDUhdSYNOblb7cCPNq6z7NE3aFDmVL/g+Y+QgMa5PxW9kmnC0SXuU3XRfGeVm6+cqumq7LgpeQPe7Ai5Y/2mzWH+AromfVHroGsSkXlcUIGlzXWrOxOxNltGvzWWB4s1xbOqJProxqTTQmr0rw7ypvnkYI5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812192; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=LZw4Kt2mQuWgyKmlrDPFTNJYeu3IN02ygsBncDd+4ds=; b=DeJR9Wrf8VJTJimc/hwGTqzh3cmSIoNoAmvLFMS1Sw5GuKWLuVnbozjj4HDHy3dh 4W0a47AAd65LOvHh69Yl20IjerLwGE17q7n2cEKDu6mpU3ZRTAa3xTHljTYkvDF8i9A tAxu8cAoNgubEXwCfn/UcuF9gIwjE6lAkP/Mr49s= Received: by mx.zohomail.com with SMTPS id 1788812190402290.1891005109519; Mon, 7 Sep 2026 13:16:30 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:11 +0100 Subject: [PATCH v8 02/16] drm/panfrost: Move lock and modparam initialisations into their subsystems Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-2-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=7189; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=BseDd5ptshL8O0X6ZZAknqhIzPZMy2A4L4RfHDWk90U=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuL8Mg7uPKqvPbHklzdrAXkABQyCNWYDVbrp MvCcbrCMwuJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PYpWC/9sfR24clVLXeM/oE7W4IxigiBEvidxoQ/d5z5XSzjJZ8fFRqnvQhcwUc/dkJEOmj2379j CY1Cn0bM9UNn790dRGZFWtvXpE01KPOb1MdrzO5J9c9Z9guXe6mSmlkfk9t38Xs93uvFtXi8Aou qrWbdYQyvNXMRStWrYk/NNtHC38CBb3G6nUmNxp2TBQkh97JlUSuAxZ7feKftHg92LM7ZRng/Ac rHpXzM+lY+RT2C4coYS3Okk0/XnqD+pgUYJwy8XFtjTN58et8Tu0OPl+1vvzkkKDWX5C4uRkjzZ RwbyoSDuXVn6oaSr/IiTt/w/K+sIj0lskgIZnrmzRvDxY+Enp1i2c3t0kngWVZTuZcYBhql1Kmx 4n0Qy+wyS+dayB3tZcPi7The9G+mMvS4VBoFFAhUYuaTlFw1V/wqgBmNEA2CbQYeBNAy1v7yd5J q7fyixWZMW/dWI4r3pR0kn/2y1Fmtq0RMYBHkRnG8hAZHID6x4NaPa/wkRx7pySnYJU/8= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D The device init function feels a bit cluttered with things that should be done in the specific subsystems where those locks and lists are being used. Same goes for module parameters, it's best to limit them to the subsystems where they're relevant. Then we can also discard panfrost_drv.h since the transparent_huge_page doesn't need to be accessed elsewhere. We can also simplify the creation of a mount point, because drm_gem_get_huge_mnt() would never return NULL if drm_gem_huge_mnt_create() returns 0 when kernel is built with support for transparent huge pages. Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Boris Brezillon --- drivers/gpu/drm/panfrost/panfrost_device.c | 7 ------- drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ---------- drivers/gpu/drm/panfrost/panfrost_drv.h | 9 --------- drivers/gpu/drm/panfrost/panfrost_gem.c | 19 +++++++++++++------ drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c | 3 +++ drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 ++ drivers/gpu/drm/panfrost/panfrost_job.c | 1 + drivers/gpu/drm/panfrost/panfrost_mmu.c | 3 +++ 8 files changed, 22 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index 05c40d5a20b5..c1a2e93a2b9b 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -216,13 +216,6 @@ int panfrost_device_init(struct panfrost_device *pfdev) { int err; =20 - mutex_init(&pfdev->sched_lock); - INIT_LIST_HEAD(&pfdev->as_lru_list); - - spin_lock_init(&pfdev->as_lock); - - spin_lock_init(&pfdev->cycle_counter.lock); - #ifdef CONFIG_DEBUG_FS mutex_init(&pfdev->debugfs.gems_lock); INIT_LIST_HEAD(&pfdev->debugfs.gems_list); diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panf= rost/panfrost_drv.c index 9882a3ede75f..59af79a534fa 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -21,7 +21,6 @@ #include =20 #include "panfrost_device.h" -#include "panfrost_drv.h" #include "panfrost_gem.h" #include "panfrost_mmu.h" #include "panfrost_job.h" @@ -955,12 +954,6 @@ static const struct drm_driver panfrost_drm_driver =3D= { #endif }; =20 -#ifdef CONFIG_TRANSPARENT_HUGEPAGE -bool panfrost_transparent_hugepage =3D true; -module_param_named(transparent_hugepage, panfrost_transparent_hugepage, bo= ol, 0400); -MODULE_PARM_DESC(transparent_hugepage, "Use a dedicated tmpfs mount point = with Transparent Hugepage enabled (true =3D default)"); -#endif - static int panfrost_probe(struct platform_device *pdev) { struct panfrost_device *pfdev; @@ -979,9 +972,6 @@ static int panfrost_probe(struct platform_device *pdev) =20 pfdev->coherent =3D device_get_dma_attr(&pdev->dev) =3D=3D DEV_DMA_COHERE= NT; =20 - mutex_init(&pfdev->shrinker_lock); - INIT_LIST_HEAD(&pfdev->shrinker_list); - err =3D panfrost_device_init(pfdev); if (err) { if (err !=3D -EPROBE_DEFER) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.h b/drivers/gpu/drm/panf= rost/panfrost_drv.h deleted file mode 100644 index a2277ec61aab..000000000000 --- a/drivers/gpu/drm/panfrost/panfrost_drv.h +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 or MIT */ -/* Copyright 2025 Amazon.com, Inc. or its affiliates */ - -#ifndef __PANFROST_DRV_H__ -#define __PANFROST_DRV_H__ - -extern bool panfrost_transparent_hugepage; - -#endif diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c b/drivers/gpu/drm/panf= rost/panfrost_gem.c index f39c0f50ed4f..383ac8cd5645 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem.c +++ b/drivers/gpu/drm/panfrost/panfrost_gem.c @@ -11,20 +11,27 @@ #include #include #include "panfrost_device.h" -#include "panfrost_drv.h" #include "panfrost_gem.h" #include "panfrost_mmu.h" =20 +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static bool panfrost_transparent_hugepage =3D true; +module_param_named(transparent_hugepage, panfrost_transparent_hugepage, bo= ol, 0400); +MODULE_PARM_DESC(transparent_hugepage, "Use a dedicated tmpfs mount point = with Transparent Hugepage enabled (true =3D default)"); +#else +#define panfrost_transparent_hugepage false +#endif + int panfrost_gem_init(struct panfrost_device *pfdev) { - if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && panfrost_transparent_hugep= age) { + if (panfrost_transparent_hugepage) { int err =3D drm_gem_huge_mnt_create(&pfdev->base, "within_size"); =20 - if (drm_gem_get_huge_mnt(&pfdev->base)) + if (err) + drm_warn(&pfdev->base, + "Can't use Transparent Hugepage (%d)\n", err); + else drm_info(&pfdev->base, "Using Transparent Hugepage\n"); - else if (err) - drm_warn(&pfdev->base, "Can't use Transparent Hugepage (%d)\n", - err); } =20 return panfrost_gem_shrinker_init(pfdev); diff --git a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c b/drivers/gpu= /drm/panfrost/panfrost_gem_shrinker.c index fefae87535d6..72cd7a165e6d 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c +++ b/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c @@ -97,6 +97,9 @@ panfrost_gem_shrinker_scan(struct shrinker *shrinker, str= uct shrink_control *sc) */ int panfrost_gem_shrinker_init(struct panfrost_device *pfdev) { + mutex_init(&pfdev->shrinker_lock); + INIT_LIST_HEAD(&pfdev->shrinker_list); + pfdev->shrinker =3D shrinker_alloc(0, "drm-panfrost"); if (!pfdev->shrinker) return -ENOMEM; diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panf= rost/panfrost_gpu.c index 7d555e63e21a..8a15ccce08e9 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -516,6 +516,8 @@ int panfrost_gpu_init(struct panfrost_device *pfdev) { int err; =20 + spin_lock_init(&pfdev->cycle_counter.lock); + err =3D panfrost_gpu_soft_reset(pfdev); if (err) return err; diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panf= rost/panfrost_job.c index d59b4863b8ad..476c936b54e6 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.c +++ b/drivers/gpu/drm/panfrost/panfrost_job.c @@ -874,6 +874,7 @@ int panfrost_jm_init(struct panfrost_device *pfdev) =20 INIT_WORK(&pfdev->reset.work, panfrost_reset_work); spin_lock_init(&js->job_lock); + mutex_init(&pfdev->sched_lock); =20 js->irq =3D platform_get_irq_byname(to_platform_device(pfdev->base.dev), = "job"); if (js->irq < 0) diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panf= rost/panfrost_mmu.c index 4a3162c3b659..5c393ed6e310 100644 --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c @@ -955,6 +955,9 @@ int panfrost_mmu_init(struct panfrost_device *pfdev) { int err; =20 + INIT_LIST_HEAD(&pfdev->as_lru_list); + spin_lock_init(&pfdev->as_lock); + pfdev->mmu_irq =3D platform_get_irq_byname(to_platform_device(pfdev->base= .dev), "mmu"); if (pfdev->mmu_irq < 0) return pfdev->mmu_irq; --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0CE5419304 for ; Mon, 7 Sep 2026 20:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812244; cv=pass; b=KG08MpPciegGCE79J2qnDUulxJ6odAh5EWBLA2qnM3DkJ/EOemwRL/Ra53f04W1dmpCiVOU36M0X+yJFXBx2PW66Y3/Pi02d1ySjmiC3XFrlYcZXHKFElOofrulOoCBgf6VV1/LiB1e/jwaCXHIINGLOVRoyJtJ3P5Dth5s6A/A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812244; c=relaxed/simple; bh=KpBZvM+jDCQcDp+jAb4hb9VNZO+PYTWBYmA084H6WNg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XvibA7ykuJopTtIkw+6Qxh1UsG9hCey/H/ERjifl/bbKZPJuTsMTITwf90wtnfmJd2OPsQXP7nUhB1Yf/5E1dy10g7aP3gucV+iwTVT1jbIEcHHUq832S+sXYWNqMNq8uL6uqUN68YEH8G8HunNFyKEyizN0ZVpPkF24OUBuCfY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=NgW5/281; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="NgW5/281" ARC-Seal: i=1; a=rsa-sha256; t=1788812198; cv=none; d=zohomail.com; s=zohoarc; b=Gux+MABPZ4Zp/X3vMO0yNHvw2joX+GYM5tW1/79JkjVSKHlpQO6+82jS6pzBRf+PxqfJXs4jeGFr2JcL23NvOsdaCXgnnt+ynOM7f2u5LqEbe24HyLotMXDNk/t4yVjzgr6XiMBL0I/AfpzYDRs9ldwvp4TNoNEzX/1qPkYpQD8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812198; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=qA5nkyPf4OsAk/8123sJ/LUfYJEvp6UZplI2BJVIXLE=; b=I7qgndIfYQWk9qY4jtnaZFFHBiuL60vTHsjJRsblwvmZFgtODSR1fF6F42AQGxls8RjkeBs89fzPVRBKxEEbqTiOMukikCdi+QhodjEqRdh/m0MFj/8lLrTPS8whozwDvTBfRmU2XktmJSkLxuebGj8Z2whsPA1zVGq7J/Wb7gQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812198; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=qA5nkyPf4OsAk/8123sJ/LUfYJEvp6UZplI2BJVIXLE=; b=NgW5/281Jd6TWeKqlkCHE3xnOG5WIO4yYkZsbC7sMWdmn2cDXFZKTdqxwsq+/txB ML0sDZvClkViPj1M+9/Ig9Bc/au8/Yk0dsjPU8UFgIMIaPDuSPYyKzxMrjn1dfeJDNG f3b74gPAmlR12eZpnRDs5yNi4e63GYMiWxWOWGMM= Received: by mx.zohomail.com with SMTPS id 1788812196307957.031485346041; Mon, 7 Sep 2026 13:16:36 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:12 +0100 Subject: [PATCH v8 03/16] drm/panfrost: Move debugfs initialisation to relevant subsystems Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-3-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=12684; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=KpBZvM+jDCQcDp+jAb4hb9VNZO+PYTWBYmA084H6WNg=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuL4nhJKwkCoIQtQAk0H2opc9MSHmuL9pzNc 1/aq0utUneJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PazFDAC2zk98E6GGapV5h90uZaD4L6cc5yKUKQyWk3l+LYtFpJ/A+QWWW5c5/cWiBKvh6AfLSd9 /8/GACsOn1SOTfZULMqipzWQ0vVT1ORdK6q806Llw1PumfUwP4n1/rj0duBAsh86LLJ1THlUtiM O9RINLxBRrC1KnwPy+0JSa80wWBmfMZ6b+AFDQuuJrtGfKiTA3a6hVLTQI5pzuowJvHf1X2v4xJ kS6bkawwDwZ31Kyn49qROTU8PdKkvm8NhCnWkWsd/0cFSLDw8WBq3tlMcteAmAFqHHobu0VhKiN meidZ11ROJYGsqkH9/HYkCKwL5e4KaNQ3RmW0Qs40ph70lVdcOFMZNWud3QJrBhk4RhgKh/2hnh rBNOqkcB0Jim3wlZA69vlkXiMyvAGo8xVCeCQqZzDSFIsdCxfnb2P6xUf3jl4MuTgOjz0sMdL21 WK57RYM4H12qTXyreWUGny1KKdTO9U0y9pK4iMQ9wlgPqn9vJWnlofjEN7lFh7dJAzYnI= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Because debugfs knobs are a device interface, and also the different knobs deal with specific subsystems, it's best to move their initialisations away from panfrost_drv.c and into the subsystem they provide information about. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++ drivers/gpu/drm/panfrost/panfrost_device.h | 4 + drivers/gpu/drm/panfrost/panfrost_drv.c | 129 +------------------------= ---- drivers/gpu/drm/panfrost/panfrost_gem.c | 29 ++++++- drivers/gpu/drm/panfrost/panfrost_gem.h | 3 +- drivers/gpu/drm/panfrost/panfrost_job.c | 99 ++++++++++++++++++++++ drivers/gpu/drm/panfrost/panfrost_job.h | 4 + 7 files changed, 144 insertions(+), 132 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index c1a2e93a2b9b..5bf528f41278 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -561,3 +561,11 @@ EXPORT_GPL_DEV_PM_OPS(panfrost_pm_ops) =3D { RUNTIME_PM_OPS(panfrost_device_runtime_suspend, panfrost_device_runtime_r= esume, NULL) SYSTEM_SLEEP_PM_OPS(panfrost_device_suspend, panfrost_device_resume) }; + +#ifdef CONFIG_DEBUG_FS +void panfrost_device_debugfs_init(struct drm_minor *minor) +{ + panfrost_gem_debugfs_init(minor); + panfrost_sched_debugfs_init(minor); +} +#endif // CONFIG_DEBUG_FS diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/p= anfrost/panfrost_device.h index 1fe1554f2652..a0b9a2145fc9 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -341,4 +341,8 @@ panfrost_device_schedule_reset(struct panfrost_device *= pfdev) queue_work(pfdev->reset.wq, &pfdev->reset.work); } =20 +#ifdef CONFIG_DEBUG_FS +void panfrost_device_debugfs_init(struct drm_minor *minor); +#endif // CONFIG_DEBUG_FS + #endif diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panf= rost/panfrost_drv.c index 59af79a534fa..55fc22e8d4d4 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -792,133 +792,6 @@ static const struct file_operations panfrost_drm_driv= er_fops =3D { .show_fdinfo =3D drm_show_fdinfo, }; =20 -#ifdef CONFIG_DEBUG_FS -static int panthor_gems_show(struct seq_file *m, void *data) -{ - struct drm_info_node *node =3D m->private; - struct panfrost_device *pfdev =3D to_panfrost_device(node->minor->dev); - - panfrost_gem_debugfs_print_bos(pfdev, m); - - return 0; -} - -static void show_panfrost_jm_ctx(struct panfrost_jm_ctx *jm_ctx, u32 handl= e, - struct seq_file *m) -{ - struct drm_device *ddev =3D ((struct drm_info_node *)m->private)->minor->= dev; - const char *prio =3D "UNKNOWN"; - - static const char * const prios[] =3D { - [DRM_SCHED_PRIORITY_HIGH] =3D "HIGH", - [DRM_SCHED_PRIORITY_NORMAL] =3D "NORMAL", - [DRM_SCHED_PRIORITY_LOW] =3D "LOW", - }; - - if (jm_ctx->slot_entity[0].priority !=3D - jm_ctx->slot_entity[1].priority) - drm_warn(ddev, "Slot priorities should be the same in a single context"); - - if (jm_ctx->slot_entity[0].priority < ARRAY_SIZE(prios)) - prio =3D prios[jm_ctx->slot_entity[0].priority]; - - seq_printf(m, " JM context %u: priority %s\n", handle, prio); -} - -static int show_file_jm_ctxs(struct panfrost_file_priv *pfile, - struct seq_file *m) -{ - struct panfrost_jm_ctx *jm_ctx; - unsigned long i; - - xa_lock(&pfile->jm_ctxs); - xa_for_each(&pfile->jm_ctxs, i, jm_ctx) { - jm_ctx =3D panfrost_jm_ctx_get(jm_ctx); - xa_unlock(&pfile->jm_ctxs); - show_panfrost_jm_ctx(jm_ctx, i, m); - panfrost_jm_ctx_put(jm_ctx); - xa_lock(&pfile->jm_ctxs); - } - xa_unlock(&pfile->jm_ctxs); - - return 0; -} - -static struct drm_info_list panthor_debugfs_list[] =3D { - {"gems", - panthor_gems_show, 0, NULL}, -}; - -static int panthor_gems_debugfs_init(struct drm_minor *minor) -{ - drm_debugfs_create_files(panthor_debugfs_list, - ARRAY_SIZE(panthor_debugfs_list), - minor->debugfs_root, minor); - - return 0; -} - -static int show_each_file(struct seq_file *m, void *arg) -{ - struct drm_info_node *node =3D (struct drm_info_node *)m->private; - struct drm_device *ddev =3D node->minor->dev; - int (*show)(struct panfrost_file_priv *, struct seq_file *) =3D - node->info_ent->data; - struct drm_file *file; - int ret; - - ret =3D mutex_lock_interruptible(&ddev->filelist_mutex); - if (ret) - return ret; - - list_for_each_entry(file, &ddev->filelist, lhead) { - struct task_struct *task; - struct panfrost_file_priv *pfile =3D file->driver_priv; - struct pid *pid; - - /* - * Although we have a valid reference on file->pid, that does - * not guarantee that the task_struct who called get_pid() is - * still alive (e.g. get_pid(current) =3D> fork() =3D> exit()). - * Therefore, we need to protect this ->comm access using RCU. - */ - rcu_read_lock(); - pid =3D rcu_dereference(file->pid); - task =3D pid_task(pid, PIDTYPE_TGID); - seq_printf(m, "client_id %8llu pid %8d command %s:\n", - file->client_id, pid_nr(pid), - task ? task->comm : ""); - rcu_read_unlock(); - - ret =3D show(pfile, m); - if (ret < 0) - break; - - seq_puts(m, "\n"); - } - - mutex_unlock(&ddev->filelist_mutex); - return ret; -} - -static struct drm_info_list panfrost_sched_debugfs_list[] =3D { - { "sched_ctxs", show_each_file, 0, show_file_jm_ctxs }, -}; - -static void panfrost_sched_debugfs_init(struct drm_minor *minor) -{ - drm_debugfs_create_files(panfrost_sched_debugfs_list, - ARRAY_SIZE(panfrost_sched_debugfs_list), - minor->debugfs_root, minor); -} - -static void panfrost_debugfs_init(struct drm_minor *minor) -{ - panthor_gems_debugfs_init(minor); - panfrost_sched_debugfs_init(minor); -} -#endif - /* * Panfrost driver version: * - 1.0 - initial interface @@ -950,7 +823,7 @@ static const struct drm_driver panfrost_drm_driver =3D { .gem_prime_import =3D panfrost_gem_prime_import, .gem_prime_import_sg_table =3D panfrost_gem_prime_import_sg_table, #ifdef CONFIG_DEBUG_FS - .debugfs_init =3D panfrost_debugfs_init, + .debugfs_init =3D panfrost_device_debugfs_init, #endif }; =20 diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c b/drivers/gpu/drm/panf= rost/panfrost_gem.c index 383ac8cd5645..518f24549b9d 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem.c +++ b/drivers/gpu/drm/panfrost/panfrost_gem.c @@ -9,6 +9,7 @@ #include =20 #include +#include #include #include "panfrost_device.h" #include "panfrost_gem.h" @@ -735,8 +736,8 @@ static void panfrost_gem_debugfs_bo_print(struct panfro= st_gem_object *bo, totals->reclaimable +=3D resident_size; } =20 -void panfrost_gem_debugfs_print_bos(struct panfrost_device *pfdev, - struct seq_file *m) +static void panfrost_gem_debugfs_print_bos(struct panfrost_device *pfdev, + struct seq_file *m) { struct gem_size_totals totals =3D {0}; struct panfrost_gem_object *bo; @@ -756,4 +757,28 @@ void panfrost_gem_debugfs_print_bos(struct panfrost_de= vice *pfdev, seq_printf(m, "Total size: %zd, Total resident: %zd, Total reclaimable: %= zd\n", totals.size, totals.resident, totals.reclaimable); } + +static int panfrost_gems_show(struct seq_file *m, void *data) +{ + struct drm_info_node *node =3D m->private; + struct panfrost_device *pfdev =3D to_panfrost_device(node->minor->dev); + + panfrost_gem_debugfs_print_bos(pfdev, m); + + return 0; +} + +static struct drm_info_list panfrost_debugfs_list[] =3D { + {"gems", + panfrost_gems_show, 0, NULL}, +}; + +int panfrost_gem_debugfs_init(struct drm_minor *minor) +{ + drm_debugfs_create_files(panfrost_debugfs_list, + ARRAY_SIZE(panfrost_debugfs_list), + minor->debugfs_root, minor); + + return 0; +} #endif diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.h b/drivers/gpu/drm/panf= rost/panfrost_gem.h index 5c823cdbd980..3008afcf4bff 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem.h +++ b/drivers/gpu/drm/panfrost/panfrost_gem.h @@ -164,8 +164,7 @@ int panfrost_gem_sync(struct drm_gem_object *obj, u32 t= ype, void panfrost_gem_internal_set_label(struct drm_gem_object *obj, const cha= r *label); =20 #ifdef CONFIG_DEBUG_FS -void panfrost_gem_debugfs_print_bos(struct panfrost_device *pfdev, - struct seq_file *m); +int panfrost_gem_debugfs_init(struct drm_minor *minor); #endif =20 #endif /* __PANFROST_GEM_H__ */ diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panf= rost/panfrost_job.c index 476c936b54e6..00fb36c577df 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.c +++ b/drivers/gpu/drm/panfrost/panfrost_job.c @@ -8,6 +8,8 @@ #include #include #include +#include +#include #include #include =20 @@ -1138,3 +1140,100 @@ int panfrost_jm_ctx_destroy(struct drm_file *file, = u32 handle) panfrost_jm_ctx_put(jm_ctx); return 0; } + +#ifdef CONFIG_DEBUG_FS +static void show_panfrost_jm_ctx(struct panfrost_jm_ctx *jm_ctx, u32 handl= e, + struct seq_file *m) +{ + struct drm_device *ddev =3D ((struct drm_info_node *)m->private)->minor->= dev; + const char *prio =3D "UNKNOWN"; + + static const char * const prios[] =3D { + [DRM_SCHED_PRIORITY_HIGH] =3D "HIGH", + [DRM_SCHED_PRIORITY_NORMAL] =3D "NORMAL", + [DRM_SCHED_PRIORITY_LOW] =3D "LOW", + }; + + if (jm_ctx->slot_entity[0].priority !=3D + jm_ctx->slot_entity[1].priority) + drm_warn(ddev, "Slot priorities should be the same in a single context"); + + if (jm_ctx->slot_entity[0].priority < ARRAY_SIZE(prios)) + prio =3D prios[jm_ctx->slot_entity[0].priority]; + + seq_printf(m, " JM context %u: priority %s\n", handle, prio); +} + +static int show_file_jm_ctxs(struct panfrost_file_priv *pfile, + struct seq_file *m) +{ + struct panfrost_jm_ctx *jm_ctx; + unsigned long i; + + xa_lock(&pfile->jm_ctxs); + xa_for_each(&pfile->jm_ctxs, i, jm_ctx) { + jm_ctx =3D panfrost_jm_ctx_get(jm_ctx); + xa_unlock(&pfile->jm_ctxs); + show_panfrost_jm_ctx(jm_ctx, i, m); + panfrost_jm_ctx_put(jm_ctx); + xa_lock(&pfile->jm_ctxs); + } + xa_unlock(&pfile->jm_ctxs); + + return 0; +} + +static int show_each_file(struct seq_file *m, void *arg) +{ + struct drm_info_node *node =3D (struct drm_info_node *)m->private; + struct drm_device *ddev =3D node->minor->dev; + int (*show)(struct panfrost_file_priv *, struct seq_file *) =3D + node->info_ent->data; + struct drm_file *file; + int ret; + + ret =3D mutex_lock_interruptible(&ddev->filelist_mutex); + if (ret) + return ret; + + list_for_each_entry(file, &ddev->filelist, lhead) { + struct task_struct *task; + struct panfrost_file_priv *pfile =3D file->driver_priv; + struct pid *pid; + + /* + * Although we have a valid reference on file->pid, that does + * not guarantee that the task_struct who called get_pid() is + * still alive (e.g. get_pid(current) =3D> fork() =3D> exit()). + * Therefore, we need to protect this ->comm access using RCU. + */ + rcu_read_lock(); + pid =3D rcu_dereference(file->pid); + task =3D pid_task(pid, PIDTYPE_TGID); + seq_printf(m, "client_id %8llu pid %8d command %s:\n", + file->client_id, pid_nr(pid), + task ? task->comm : ""); + rcu_read_unlock(); + + ret =3D show(pfile, m); + if (ret < 0) + break; + + seq_puts(m, "\n"); + } + + mutex_unlock(&ddev->filelist_mutex); + return ret; +} + +static struct drm_info_list panfrost_sched_debugfs_list[] =3D { + { "sched_ctxs", show_each_file, 0, show_file_jm_ctxs }, +}; + +void panfrost_sched_debugfs_init(struct drm_minor *minor) +{ + drm_debugfs_create_files(panfrost_sched_debugfs_list, + ARRAY_SIZE(panfrost_sched_debugfs_list), + minor->debugfs_root, minor); +} +#endif diff --git a/drivers/gpu/drm/panfrost/panfrost_job.h b/drivers/gpu/drm/panf= rost/panfrost_job.h index c3f57e41a571..3e3b9717838f 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.h +++ b/drivers/gpu/drm/panfrost/panfrost_job.h @@ -74,4 +74,8 @@ int panfrost_job_get_slot(struct panfrost_job *job); int panfrost_job_push(struct panfrost_job *job); void panfrost_job_put(struct panfrost_job *job); =20 +#ifdef CONFIG_DEBUG_FS +void panfrost_sched_debugfs_init(struct drm_minor *minor); +#endif + #endif --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C553A403123 for ; Mon, 7 Sep 2026 20:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812251; cv=pass; b=VYxJ8ihX3AwFVTZe5IxLNyayHJ30ua1dthcjQbfvGv34qZRPJZdslTJk3oRxPKxfzpfQFxyU4fr+/TqnKWioVmAfQLnMHF3Cs5SpgBtdSzx1YVm7gDegbLpPeXNjLFSO0hdRAjz0reYH4wXO9RUzWwyOnwqT+l3C5tZywkIlwV4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812251; c=relaxed/simple; bh=ZbKj/0+gldpyeLSSMbRlmpp9mm9nCUYXI4PymrPfLzQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VWZNrBttGUmWXdprvmbrvrrVRVmcL37P7FA0p8GoKqCDi0nu7w2ouuHCgbdaZUsQMWjEHL4LIpPBQBy7tiBo36fbP++G6we7+f52i1hhAYBh800ol1CS2re35kzismucyW8Q2wSEqdOmgCePlu6XNZQcMUrPRoHuerDH4Oh0A18= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=aStQ3//W; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="aStQ3//W" ARC-Seal: i=1; a=rsa-sha256; t=1788812204; cv=none; d=zohomail.com; s=zohoarc; b=Lk1VyW1RduOYr/votXjGTKoZv3ApuXi1MoTxSlkOIPBKwNiLXxOLqPJcT7nhuFwOhfS3OD0gBmus2Gv4YTalo5YyHaYnW9ulm7AQRbunpn+lc0A/ZBtUnb89sJq+BfAkVYhMEvKtegFe6q0QopXs7PsFSQuCkLgJ5kxElf+zadg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812204; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=5tcaP2IVkF4SV3ksstD6wFI9LNYjrG0cIcTQTiq6ocI=; b=kxmU8N/EsvLrbz3kx0wYuBrCuYrLKp4Wf1TcMqX/tbkJIKEp8XDiLbx0ZTD3OklRSXeD0WkQvIoQwictsvm7Mv1/U9Le0Ty+amMOOBUL0QdhDTTvVd+JqWFyVlXcNzV4SN6tM7xxPSOGLLjdL9aomwo0yXYECXUt1Y3bIUDu/nc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812204; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=5tcaP2IVkF4SV3ksstD6wFI9LNYjrG0cIcTQTiq6ocI=; b=aStQ3//WutN4gDYL+K+jRQh2U5IDbnIbnImb/Nd/9BVSMis92eW2heZlcDHv5qVT oFzRmVshCaH+ORsic0Vgv6bnMyzrOIFTBPcgvnR+yjt1fdTR6rBFWrQ0fN7eVdG7SVe f7xFXIgiBTN6Z6o1alZxQmSNj5bprz0T8/OPp5Cw= Received: by mx.zohomail.com with SMTPS id 1788812203105323.20898422512926; Mon, 7 Sep 2026 13:16:43 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:13 +0100 Subject: [PATCH v8 04/16] drm/panfrost: Skip NULL checks for clock enable/disabling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-4-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1586; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=ZbKj/0+gldpyeLSSMbRlmpp9mm9nCUYXI4PymrPfLzQ=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuLFQB3kuAe2s4OLXRbm2QA8UQZJmdiu6KlS pSPzhjo0Z+JAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PfdEC/9z8a+i28SOR38Gf8e0Q/MKS09Pp9Ibpl/lrQSNQKa21zdl2Jj9MVMcBysXwG4avHH1Qcf p4En5+6xxg4O4e35NnevUqDOOyHP0I+mXhqpPagrhGdxsYb3H6l6UVimyx2RKLGCk7BkV3YDqTM TIwsSPbveF1IoUItEa5v3ql0dNGZ660wsBxNbOc5ck2Pr0CZRIydpKp4UiFmkb+W3QbJE7TPrG3 VyuaJ83muGw5NcaLNQ8HN928tIwkgruJR4Qf3BL3N5p2pFMSWAMn0Qy0dLLM5fC75hxAvjbzfo9 ufwuA2PiekAkVTM6VZcBKxp7frIwwK1LnCGLC06hCHf0iK96QGPHA8zpxeIyJvl9HQHd6uy/r7e TyJr5G9dVWHB9/evd6Y3rBbxHhOLuHSQ7ymp/LrHeVNQN4Re54TrPGb52c3w7Ph+sSMYWbyLjml OytbI6nKkYN3gDOMPZ2ReE4mEy/Aw4nBweFcVK3yDhQOCoX+3Esg+5SOhAVzd6nmBO5Iw= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D The clk_* API can deal with NULL clock objects, so we can do away with NULL checks in client code. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index 5bf528f41278..b3a53504bd01 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -510,11 +510,9 @@ static int panfrost_device_resume(struct device *dev) if (ret) goto err_clk; =20 - if (pfdev->bus_clock) { - ret =3D clk_enable(pfdev->bus_clock); - if (ret) - goto err_bus_clk; - } + ret =3D clk_enable(pfdev->bus_clock); + if (ret) + goto err_bus_clk; } =20 ret =3D pm_runtime_force_resume(dev); @@ -524,7 +522,7 @@ static int panfrost_device_resume(struct device *dev) return 0; =20 err_resume: - if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS) && pfdev->bus_clock) + if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) clk_disable(pfdev->bus_clock); err_bus_clk: if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) @@ -545,9 +543,7 @@ static int panfrost_device_suspend(struct device *dev) return ret; =20 if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) { - if (pfdev->bus_clock) - clk_disable(pfdev->bus_clock); - + clk_disable(pfdev->bus_clock); clk_disable(pfdev->clock); } =20 --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12EB8403123 for ; Mon, 7 Sep 2026 20:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812255; cv=pass; b=Ray+LjntFmS8AnWrOsg9EwEQw9whQWRGGCXVQGGp9nV5O2rxdwVJ6+y371YC9fEea+EB82tguFZvVy/0vyiWfM0NH8z0epktDDCAR+8mTjUxrNwHj6c/c/nHnEDBP62HAOKa43pAsEFQ/h9l0PtOLS0cCzQ/Y42iRoRzMYycNlI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812255; c=relaxed/simple; bh=xtRlWEclna7fpBZRwaaN8ipv7QPcm0cUBvxcGdCNDXY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gIkzsRnXOGv70NKrR8eotz4EeHRmyeB1nQpHFBKb/kHKDEkKriYMYwjxZu/+N8Oni+nyGhuUsL/SyNRhVKG7AZmbVQrkl4IWrn6LvVCwyv4LstNVYJ9Ajk9APUSfxmwD6NkrdubiXhx/SMUnOI3a3sk8LQpT74lMpryb64N76dg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=HDc411/9; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="HDc411/9" ARC-Seal: i=1; a=rsa-sha256; t=1788812210; cv=none; d=zohomail.com; s=zohoarc; b=VZweWr/VK1lIqOpiPKfJ3+/D68RNj1Bwnb8afrmu3xKh3s4Ue2+rfNbpbCuVlKDh4FpOFQhtkkjXdLlYlcW2nlv8uasTi31yUW5s3VPDzU3cVfE6+qHzXyoX2rBDI1TsNcfj28zmAqMWWQdqTbFYatgID7uBt91EMkiXEBuDTX4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812210; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=8yU6CY1Li0Akzlr3bt5a2BjknT/kv0BwUncj4FmHAak=; b=PeUm4PzzgULRYRqIfTg84CjPivXwC6jRxs+u3JQYfU23GfZTkP5BMrBavp11v+tStquWlVF+7tGov/uqjl7aNgge1VGfPvCPISqbeFUsfaF2WEXjim+gwFLUepdqSwMqCwcVm/A0j6nkxfHouEzqFbuVyXgCVDUlUA2OXeT0fSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812210; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=8yU6CY1Li0Akzlr3bt5a2BjknT/kv0BwUncj4FmHAak=; b=HDc411/9ep6Vl1Zlc6wrTEyMCjldmgT/yjgZOAChAMNCEYihhsaXlTgX3SrytoBk 2xnWogINHtU7wG1aeQlfuBM/G/0ccAdtZlECBhbZRFVlpD9bffzdav1XmcxCAyEZmMa eufa9YaoyQXftzShs0RuFo/uXnuZbjKtcMi8xSvA= Received: by mx.zohomail.com with SMTPS id 1788812209620170.80202207594527; Mon, 7 Sep 2026 13:16:49 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:14 +0100 Subject: [PATCH v8 05/16] drm/panfrost: Consolidate device clock management and reset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-5-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6154; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=xtRlWEclna7fpBZRwaaN8ipv7QPcm0cUBvxcGdCNDXY=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuLPdzQp9kdK0/PHUc8LOp3rvkhSKmLjFgxc dzPbe2HQQ+JAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PeQTC/9ZlXwaut9zQMKhYCr9G2afCMEOCnw3V97nW19O53hRJtnbN37H1rp0Ss6excwQYL/J0On SYXjf8nU993olKzcCOQfDDd1L7nJI+MAkualUmo1EF7RNEDZnbWZ0aazAZg24imBa1VVhgZnYKq fzm960T/SKn5774PImVpxz8jpD9GyErgTxYT/BqCyv/2w7Mg5s83f/rWlI4AlIyrsA0NEpQ/RcH FJc70/6saHG9e5ivd4wmEl+ASI8S/mvKDNEY54iHRwgZwnyg1upONiRGVOxo/th5QZvOMSaY5gB DVzQuOsYAGJ53aSVgu3mSaHliFxicOV9I2GHm8D+xB+gORNs5Rk1KWpLGj7T8JCuAFm9skysHri iMscfF6sA/M943Pi5aO76dKdpPZ9MUq3oi3xznuGCH++pVSXEE8gnRiP/+yfgV8zTrS3qhUqb8g 1vCN4qu41gNMoAHtxscOTifklyK4rlYWU3B040hfcaeqaP13u7s4f+3mF5F91BgT3nPP8= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Gather all clock enables and disables into a single function to avoid repetitions between driver init/fini and device resume/suspend, since these clocks are always handled in bulk. Also do clk (un)prepares and dis/enables at the same time, since the clk_prepare_* family of functions can simply increase the refcnt of an already prepared clock. Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 110 +++++++++++++------------= ---- 1 file changed, 51 insertions(+), 59 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index b3a53504bd01..48135e412b6c 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -34,10 +34,43 @@ static void panfrost_reset_fini(struct panfrost_device = *pfdev) reset_control_assert(pfdev->rstc); } =20 -static int panfrost_clk_init(struct panfrost_device *pfdev) +static int panfrost_clk_enable(struct panfrost_device *pfdev) { int err; + + err =3D clk_prepare_enable(pfdev->clock); + if (err) + return err; + + err =3D clk_prepare_enable(pfdev->bus_clock); + if (err) + goto disable_clock; + + err =3D clk_prepare_enable(pfdev->bus_ace_clock); + if (err) + goto disable_bus_clock; + + return 0; + +disable_bus_clock: + clk_disable_unprepare(pfdev->bus_clock); +disable_clock: + clk_disable_unprepare(pfdev->clock); + + return err; +} + +static void panfrost_clk_disable(struct panfrost_device *pfdev) +{ + clk_disable_unprepare(pfdev->bus_ace_clock); + clk_disable_unprepare(pfdev->bus_clock); + clk_disable_unprepare(pfdev->clock); +} + +static int panfrost_clk_init(struct panfrost_device *pfdev) +{ unsigned long rate; + int err; =20 pfdev->clock =3D devm_clk_get(pfdev->base.dev, NULL); if (IS_ERR(pfdev->clock)) { @@ -48,53 +81,31 @@ static int panfrost_clk_init(struct panfrost_device *pf= dev) rate =3D clk_get_rate(pfdev->clock); dev_info(pfdev->base.dev, "clock rate =3D %lu\n", rate); =20 - err =3D clk_prepare_enable(pfdev->clock); - if (err) - return err; - pfdev->bus_clock =3D devm_clk_get_optional(pfdev->base.dev, "bus"); if (IS_ERR(pfdev->bus_clock)) { - dev_err(pfdev->base.dev, "get bus_clock failed %ld\n", - PTR_ERR(pfdev->bus_clock)); err =3D PTR_ERR(pfdev->bus_clock); - goto disable_clock; + dev_err(pfdev->base.dev, "get bus_clock failed %d\n", err); + return err; } =20 if (pfdev->bus_clock) { rate =3D clk_get_rate(pfdev->bus_clock); dev_info(pfdev->base.dev, "bus_clock rate =3D %lu\n", rate); - - err =3D clk_prepare_enable(pfdev->bus_clock); - if (err) - goto disable_clock; } =20 pfdev->bus_ace_clock =3D devm_clk_get_optional(pfdev->base.dev, "bus_ace"= ); if (IS_ERR(pfdev->bus_ace_clock)) { err =3D PTR_ERR(pfdev->bus_ace_clock); dev_err(pfdev->base.dev, "get bus_ace_clock failed %d\n", err); - goto disable_bus_clock; + return err; } =20 - err =3D clk_prepare_enable(pfdev->bus_ace_clock); - if (err) - goto disable_bus_clock; - - return 0; - -disable_bus_clock: - clk_disable_unprepare(pfdev->bus_clock); -disable_clock: - clk_disable_unprepare(pfdev->clock); - - return err; + return panfrost_clk_enable(pfdev); } =20 static void panfrost_clk_fini(struct panfrost_device *pfdev) { - clk_disable_unprepare(pfdev->bus_ace_clock); - clk_disable_unprepare(pfdev->bus_clock); - clk_disable_unprepare(pfdev->clock); + panfrost_clk_disable(pfdev); } =20 static int panfrost_regulator_init(struct panfrost_device *pfdev) @@ -436,34 +447,17 @@ static int panfrost_device_runtime_resume(struct devi= ce *dev) if (ret) return ret; =20 - ret =3D clk_enable(pfdev->clock); - if (ret) - goto err_clk; - - ret =3D clk_enable(pfdev->bus_clock); - if (ret) - goto err_bus_clk; - - ret =3D clk_enable(pfdev->bus_ace_clock); - if (ret) - goto err_bus_ace_clk; + ret =3D panfrost_clk_enable(pfdev); + if (ret) { + reset_control_assert(pfdev->rstc); + return ret; + } } =20 panfrost_device_reset(pfdev, true); panfrost_devfreq_resume(pfdev); =20 return 0; - -err_bus_ace_clk: - if (pfdev->comp->pm_features & BIT(GPU_PM_RT)) - clk_disable(pfdev->bus_clock); -err_bus_clk: - if (pfdev->comp->pm_features & BIT(GPU_PM_RT)) - clk_disable(pfdev->clock); -err_clk: - if (pfdev->comp->pm_features & BIT(GPU_PM_RT)) - reset_control_assert(pfdev->rstc); - return ret; } =20 static int panfrost_device_runtime_suspend(struct device *dev) @@ -480,9 +474,7 @@ static int panfrost_device_runtime_suspend(struct devic= e *dev) panfrost_gpu_power_off(pfdev); =20 if (pfdev->comp->pm_features & BIT(GPU_PM_RT)) { - clk_disable(pfdev->bus_ace_clock); - clk_disable(pfdev->bus_clock); - clk_disable(pfdev->clock); + panfrost_clk_disable(pfdev); reset_control_assert(pfdev->rstc); } =20 @@ -506,11 +498,11 @@ static int panfrost_device_resume(struct device *dev) } =20 if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) { - ret =3D clk_enable(pfdev->clock); + ret =3D clk_prepare_enable(pfdev->clock); if (ret) goto err_clk; =20 - ret =3D clk_enable(pfdev->bus_clock); + ret =3D clk_prepare_enable(pfdev->bus_clock); if (ret) goto err_bus_clk; } @@ -523,10 +515,10 @@ static int panfrost_device_resume(struct device *dev) =20 err_resume: if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) - clk_disable(pfdev->bus_clock); + clk_disable_unprepare(pfdev->bus_clock); err_bus_clk: if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) - clk_disable(pfdev->clock); + clk_disable_unprepare(pfdev->clock); err_clk: if (pfdev->comp->pm_features & BIT(GPU_PM_VREG_OFF)) dev_pm_opp_set_opp(dev, NULL); @@ -543,8 +535,8 @@ static int panfrost_device_suspend(struct device *dev) return ret; =20 if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) { - clk_disable(pfdev->bus_clock); - clk_disable(pfdev->clock); + clk_disable_unprepare(pfdev->bus_clock); + clk_disable_unprepare(pfdev->clock); } =20 if (pfdev->comp->pm_features & BIT(GPU_PM_VREG_OFF)) --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFD8A3CC337 for ; Mon, 7 Sep 2026 20:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812259; cv=pass; b=jB78UiKmb/FRXMNo/6U/DY6XMGqm1h96v3hF1dk2xiHPGbJGcPvwQsAMuElHlno/9VNOEMmAHvTYnjq8/c+1Ex5THhvAbKYb8bz6O/fKN8eyNaGFdGLHlJ+MIjJ1eBrCHDmU2oqp99vedT28H+tXUaRn60OIDCY9xdsb8jfe3xc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812259; c=relaxed/simple; bh=MXDSZuGOlvNH11js9h2jqHaS2B66edvM5cQo30VukSA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Uxtg4ahZGjBRw4D8JPlT0oZLXW6x4ICAv9lw2jfTBSswUVEgrf+EDsjCnWN4Li5krNjGatyOZOLzDyJJ8dacSoTbco2l5YlWDncxXe52gIBEIN5HEJ49sIy8Iv4M2aF4kNKWz14qWsv65OkCr2Mxpxx9B+SRl97T0T6606IlFE8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=aKUaxKl2; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="aKUaxKl2" ARC-Seal: i=1; a=rsa-sha256; t=1788812217; cv=none; d=zohomail.com; s=zohoarc; b=WD8ccLcdh8s7Fa6MHqhzpICylP4GYTyORQfj9MOoRcd303iM3ibn6iT2XC+m7+E8iLx2R1CkPJ6O+piS9Dz4YudONK5gvOsRSADJPl2qAKQqlFT7QQQ7kH1ZAwiBf0hfRe6qbifvD6qSA0PUaaVe+SDMJY6NZMIb2CpCgWJVJgI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812217; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=uE6tGIUw4nUFeMlGUIl2Vj3+Z0EEpcFNwJvK87yeLC8=; b=h/h/DsbJ/xbhdmECWnmELI7dauVlrhQtEKnd70qvsS8yvYzlstL+oxvKiz/M52ns7OkTNx4wUwIUQHHxF0Be7JcspPb3/mblhnb7an8cL+/CND4w/hCQVmif0SrN4L7Sfajna7ATHZfQ7VPlQ07RMeAo2HFRAvil0NmViiktdxQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812216; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=uE6tGIUw4nUFeMlGUIl2Vj3+Z0EEpcFNwJvK87yeLC8=; b=aKUaxKl2TLC6TN4jGZkM/FbyEClN6aT0D1om3qM3gOPSLKdSXNLQgvFZ949Oh9kD wZszQXnqQ3T8wBt89xFbsNmVj1SC3NHPVjDhgl4OBB9fQJYP3tJ09Q90jfl4+DGLth3 mnhKsIStpcin0ucVQdFvRSU2NLne7tWDO9hmbIQ8= Received: by mx.zohomail.com with SMTPS id 1788812216128147.32011858226542; Mon, 7 Sep 2026 13:16:56 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:15 +0100 Subject: [PATCH v8 06/16] drm/panfrost: Fix PM refcnt and autosuspend issues at device probe/remove Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-6-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3143; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=MXDSZuGOlvNH11js9h2jqHaS2B66edvM5cQo30VukSA=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuLlGOzIgawUwuYpp0nKK5dQPkI8bbCvB+Lh 9KIWjh3znSJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PRqZDACpAFQtVm5Nhz/+t1EZw9uGhQ53sKfdFN0qq5r2BCy8vIeb1MgZJwaBHlkMI502otkcW9l 2UWxCI4H3CXJdG9k5gEQcPrUDTIGpPp/MVHZPvOvUwdAlZyv8Xl07VEuaNYI2oBZAp3uJckX8w8 SETgA4DujgTmEGyV9aWufusH5bv5QKtqzyk/fK74tY58zmDWYRj/xJw/WRSKJjHfTJAYUQ+AnNk HomidiH/na6IQwIg7p40ha2DxTivAreXIiLlkP40qMWm3Q4rrtY/9/B194IC2dcT0k7O5OMv/1a r1yOZxJbj36NBFtUCOK1jWNzKfrXkV6a0VZe2XlGSjxQ/Re3d8wPStnFCmzY9v3X61dy17Y4nH5 vhJkUc5sHOz/a9hqAZ6hED2HTha8tokx+Z186ty0hageFM0m9AQCGyFRThVr32jXphUY1FtH8G5 QN1IvZxMGY2zjKYrNK8iXfc4MLObNtzq2i/oCGAL0lr/iTG/0ceoLfUQ39IgFpRoDUED4= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D During device probe(), failure to do a PM get() will leave the usage_count set to 0, which is the value assigned at device creation time. That means when the autosuspend delay expires, runtime suspend callback won't be invoked, so the device will remain powered on forever. On top of that, failure to call PM put() during device unplug means Panfrost device's PM usage_count increases monotonically for every new module reload. The outcome of both of the above meant that: - Devfreq OPP transition notifications would be printed all the time, even when no jobs are being submitted. This quickly fills the kernel ring buffer with junk. - Because MMU interrupts are only enabled when the device is reset, the very first job targeting the tiler heap BO after device probe() would always time out, since the driver's PM runtime resume callback would not be invoked. To fix the above: - Manually adjust the PM refcnt at device probe and removal time. - Ensure pm_runtime_dont_use_autosuspend is called in the wind-down path. - Call pm_runtime_put_autosuspend() when device is ready to accept jobs - Move pm_runtime_set_suspended() before panfrost_device_fini() so that resource unwinding happens in the opposite order as initialisation. Signed-off-by: Adri=C3=A1n Larumbe Fixes: 635430797d3f ("drm/panfrost: Rework runtime PM initialization") Fixes: 876b15d2c88d ("drm/panfrost: Fix module unload") --- drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panf= rost/panfrost_drv.c index 55fc22e8d4d4..a3eff77add55 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -854,6 +854,7 @@ static int panfrost_probe(struct platform_device *pdev) =20 pm_runtime_set_active(pfdev->base.dev); pm_runtime_mark_last_busy(pfdev->base.dev); + pm_runtime_get_noresume(pfdev->base.dev); pm_runtime_enable(pfdev->base.dev); pm_runtime_set_autosuspend_delay(pfdev->base.dev, 50); /* ~3 frames */ pm_runtime_use_autosuspend(pfdev->base.dev); @@ -866,13 +867,16 @@ static int panfrost_probe(struct platform_device *pde= v) if (err < 0) goto err_out1; =20 + pm_runtime_put_autosuspend(pfdev->base.dev); =20 return 0; =20 err_out1: + pm_runtime_dont_use_autosuspend(pfdev->base.dev); pm_runtime_disable(pfdev->base.dev); - panfrost_device_fini(pfdev); + pm_runtime_put_noidle(pfdev->base.dev); pm_runtime_set_suspended(pfdev->base.dev); + panfrost_device_fini(pfdev); err_out0: return err; } @@ -884,9 +888,11 @@ static void panfrost_remove(struct platform_device *pd= ev) drm_dev_unregister(&pfdev->base); =20 pm_runtime_get_sync(pfdev->base.dev); + pm_runtime_dont_use_autosuspend(pfdev->base.dev); + pm_runtime_put_noidle(pfdev->base.dev); pm_runtime_disable(pfdev->base.dev); - panfrost_device_fini(pfdev); pm_runtime_set_suspended(pfdev->base.dev); + panfrost_device_fini(pfdev); } =20 static ssize_t profiling_show(struct device *dev, --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9E4440EB90 for ; Mon, 7 Sep 2026 20:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812262; cv=pass; b=G5mvQwPaf/sUmGlb9s4dh0LYWZVR7iocXw4ld1gUtJSQIcnS602smGAUf7h0yd+8AWd4M5gnm995L7gCI9pQ7RKMC8XTx2dzmuG1J1NMqpIddaS8DeKNipeAtt0GMJC7GBfsGZ5I8niZb6d/9OibwAf7j4YsQS6Aep/TG+rBdg8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812262; c=relaxed/simple; bh=rGbyQBkNbY5a1OXBSal5Mure3AlHLFxQtfgc5Bhzvks=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TtN/knVChU9gh2lFPJhPXD/YoP2QFbxHNf2Sis1FEqXA0Yr+2wxmBsmCSLfliquXhdQJ8KapPHVCR6xi0k9mEzdXx79z6jM9IwwyXHUyEekujXhC8f/snLGvT08eU3TQwK/ev7vHOq9vpqSTNHvdo0408XGnMruRBvaM3KIrn+E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=OkYAS+er; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="OkYAS+er" ARC-Seal: i=1; a=rsa-sha256; t=1788812225; cv=none; d=zohomail.com; s=zohoarc; b=dYNKUAJqmY3Eb8hWS5x4V/J+yB1mCNh9e1m9iCc50kHCxZewqkTohNail6EEH/twJ2JJ5frw9PR6NklXj0iVxSGC+9e2kebO4+01yH7fN7IIX6wEkPHtZtYnWGBFPeDza81x5EjhnpqCj2fkafUFhSajRl7BWCET3PXAFJDDmNA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812225; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=YLJJEy7HObDD1CKVtOGtdrfPLM+ZQOVKX8SKLnJRFuQ=; b=FSQN4vx7dhFnsQB/X3sDtJJWKkz7Wpe/fZUubbzbeF7hTXBz4d1Rgo+Kmpm7rJ/+5ATv4lfU1YD1sb3dwcx3Xduq/gEPo5Tg4A5jI6HveZ9S8E1Eg9j0hlVoxJ2Wg0JReTXyoAD0vfaZx9kwyAPqYdTQUxJhB8Xov8jI6izKUJE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812225; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=YLJJEy7HObDD1CKVtOGtdrfPLM+ZQOVKX8SKLnJRFuQ=; b=OkYAS+ers/VMJXAFdqndkqLfDC5sJXp33Ni8tcHxTOMVf4VUmN+I6gfX5zxxvRJd pmDqxDexYIRgIxn9F71tpTAH9jmZS8h/sl/hoG9EJExRd1gfGqWbfM8G3U7pET6QZ1T J8Wf3yzX6abaCN5CyWoEnW5E2zPwVJR6TPCLJy1g= Received: by mx.zohomail.com with SMTPS id 1788812222585108.3592958177884; Mon, 7 Sep 2026 13:17:02 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:16 +0100 Subject: [PATCH v8 07/16] drm/panfrost: Explicitly enable MMU interrupts at device init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-7-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1801; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=rGbyQBkNbY5a1OXBSal5Mure3AlHLFxQtfgc5Bhzvks=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuLF0nluNX19rU6e8V3pONf/VzWK+9S3VHqT z4TNSxPaYKJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PcwEDACVEUHO8dvfooVtX1F1DJILBe/KymO2ZRBAWtouaFAsmGzeae5Xltbx4kfuaOYscHtsOwH jCenrLKzRUk9SvEb2OtBn8cTb5Sr1nSYY7NFbAxnfGndC8dPgpCQchSJFH7MBsXgPdxKnKPT3/a O+DjoKG8+lr1/qxBbxoUNxzWcoBcE03g40YDK0p/JEwZEqbkx4CdHZzc31wm1g1cbMKGWYQWFAJ Oq8ZdoOKpXmdrEnnz5uOY/NMY+GgDOD3YWvmZfjqvRhp4BGSBur0A2IfUXHoejGv5PoiC4x2N6X gPdwtLxd0BU7357BOOELbcO/fgc3hqPisLbMNOgGmr5qUGo90MHQ5N5oDMdWk89Wl5ThiKjRXed QJF7W3MmS2zBD98eYFH35Hr5HsChD/qeL7F8hs/y74On5NdVaqAvn3neZ0K8Ff7+Y5SxL2/1w6q EoL8jUx6dE94SVcx9KALmgeREatPILyBUh/IH/LLh673+AETDnvbnlFbStJQfJvnRY0t8= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Because the device must be in a position to accept jobs between the time drm_dev_register() is called and autosuspend first kicks in, there's a very narrow window inbetween during which jobs targeting the tiler buffer object would time out, since the device's PM status is 'Active', but no MMU interrupts were enabled at device initialisation time. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe Fixes: 73e467f60acd ("drm/panfrost: Consolidate reset handling") --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panf= rost/panfrost_mmu.c index 5c393ed6e310..faa62643caf1 100644 --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c @@ -336,6 +336,12 @@ void panfrost_mmu_as_put(struct panfrost_device *pfdev= , struct panfrost_mmu *mmu WARN_ON(atomic_read(&mmu->as_count) < 0); } =20 +static void panfrost_mmu_enable_interrupts(struct panfrost_device *pfdev) +{ + mmu_write(pfdev, MMU_INT_CLEAR, ~0); + mmu_write(pfdev, MMU_INT_MASK, ~0); +} + void panfrost_mmu_reset(struct panfrost_device *pfdev) { struct panfrost_mmu *mmu, *mmu_tmp; @@ -355,8 +361,7 @@ void panfrost_mmu_reset(struct panfrost_device *pfdev) =20 spin_unlock(&pfdev->as_lock); =20 - mmu_write(pfdev, MMU_INT_CLEAR, ~0); - mmu_write(pfdev, MMU_INT_MASK, ~0); + panfrost_mmu_enable_interrupts(pfdev); } =20 static size_t get_pgsize(u64 addr, size_t size, size_t *count) @@ -973,6 +978,8 @@ int panfrost_mmu_init(struct panfrost_device *pfdev) return err; } =20 + panfrost_mmu_enable_interrupts(pfdev); + return 0; } =20 --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 361DD2512C8 for ; Mon, 7 Sep 2026 20:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.180.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812271; cv=pass; b=kAESO+Poz0OTA8OwR45ffpsZbMiyePzwND7vp2063tQr2YruSXHdNDKrt2b+3vR87TnPvOrLRIpyvFnMstMSUrdY7mtjQTTn3IL4qUma1jgPaLPlYVG04PFGyeKp53J4iQM+q+EyK2mCI3CGoC2vgI3ficNM6Vc9b6hNdASabgE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812271; c=relaxed/simple; bh=F80dE/xqs+i0X5VauRBHNJkrVG6wPijB1c9Nd17vLV4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JqJo2KDUfJ0sHXg+R+Oq03H5SAyqmaWsNvIWkn3PGxOt9A1s4rI64SQ94k1gx4i29Od1CZU4vYX8JvQkLN6lQEEc2wiQEU9cMT36TVQ9RzlrHVW7XWgrDzd6yHxBupHYV8IRIKabraxx7+bTrekAYw7cf1kVdvKWHR5lK4KdcyA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=AZKttDI1; arc=pass smtp.client-ip=165.173.180.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="AZKttDI1" ARC-Seal: i=1; a=rsa-sha256; t=1788812235; cv=none; d=zohomail.com; s=zohoarc; b=b6RzJpFG35AJAVeEGCxJ67n+D2OrR36A93bpNyZw4NaXpY+zc1nKaYggEyVF/ojhjNSI3AilNdnZzdMEFREkN/qx78I7sm/55SPaPp5/BDe8P4HitAd2cEuKjDa0mqNAWJEOtJJs5M4GAYxmFupKEu0D4wOLJE47L4i5UVB/KnU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812235; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=5TbboicgS2mWaIpPIltnspzcsGg/Zur7OzHvZuUvftY=; b=FBMg6TU1ozyvD+nq6Yz6sHc6tcZBCCgRuB2fWhswCVsVMuPFlMyr4sqwc8uy6PoWOTZMgurXeTziX3uFFyIa70eaebAZKsCcGiGjPOSXbj+gVPr08/aIcsBhboEqhEjR9K8n9EDCvGJ+ER1zBVaBWcT/q/yHHNj5HUKcjw/YPJ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812234; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=5TbboicgS2mWaIpPIltnspzcsGg/Zur7OzHvZuUvftY=; b=AZKttDI1/ATzGmXKowU9CJsuybX4spWPtCAlt1BL5BtccL00YkmdK3CUQIYvAkZ3 EE4msNr4or+uW32UcKii7DN/aGQAhLIPdWos6aq8dk3VSUeIKcCu8UKDoapiSbR1qBG O4JsAVFvfH6HTZrT/k0TF8i5oN0CvVfrRRhQLir8= Received: by mx.zohomail.com with SMTPS id 17888122340911021.5922630388368; Mon, 7 Sep 2026 13:17:14 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:17 +0100 Subject: [PATCH v8 08/16] drm/panfrost: Move all DRM device initialisation into device_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-8-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5230; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=F80dE/xqs+i0X5VauRBHNJkrVG6wPijB1c9Nd17vLV4=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuLqdS4sO5laCcDW4yXXQOayW5ynYzo/nHqU TVp2PJUxq6JAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PT7UDACbnE5Hv/DuJTendtEOdILpZ9t/a+R/ZDwk+p3UxEklawEHdZdVbneq6zMErA0QUokiDXF LSXz/ht7YgT3ib/gVXKaVbpx762dnSAOySPPt9sgo7+5gJHIkcEKLelp9OqmhVACFf/XCAfrkkW KooAPmkcBNATeaalPsyNdhHF7Rx7i5mlBlRtVRB4441OxUqmSwAz//M5bBEhQ+DDKDg9CzgYAnE XknA0nmH2EDq4Eznlv5vHpTLJO7nJXJs5tgjOz3nG7U4hzq+b3UocRXLRXibw8uqKy3Mw0w0JmW N7jvGuj50b5inugxXf2le6kwMtkzVcB8oxulu7vQJDN8zfRTFbIGoNJdG8t3slTXeCCejAFwk+1 hs6uzGqB94bbeLUieYbDi3SNHFX3JQ680t1YonjR1lVk10Qs+jG/BC047VO2MNY7NCaoKd0ReLt g5DC+mI1GJOyV6m7UcXiZHLgzBfP0bM4us6rpbiBh5EEJpwm5OBOGKtcwVnFlExgmD2+M= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Ideally the probe() function will do as little as possible, and all device initialisation and registration should happen inside the panfrost device subsystem, just like it's done in Panthor. This also simplifies resource unwinding in the error path. Do the same thing for DRM driver remove, as in, sweep most of the action into panfrost_device_fini(), just like we did for device probe. Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 37 +++++++++++++++++++++++ drivers/gpu/drm/panfrost/panfrost_drv.c | 47 +-------------------------= ---- 2 files changed, 38 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index 48135e412b6c..be4443e41d9a 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -8,6 +8,7 @@ #include #include #include +#include =20 #include "panfrost_device.h" #include "panfrost_devfreq.h" @@ -227,6 +228,12 @@ int panfrost_device_init(struct panfrost_device *pfdev) { int err; =20 + pfdev->comp =3D of_device_get_match_data(pfdev->base.dev); + if (!pfdev->comp) + return -ENODEV; + + pfdev->coherent =3D device_get_dma_attr(pfdev->base.dev) =3D=3D DEV_DMA_C= OHERENT; + #ifdef CONFIG_DEBUG_FS mutex_init(&pfdev->debugfs.gems_lock); INIT_LIST_HEAD(&pfdev->debugfs.gems_list); @@ -288,8 +295,31 @@ int panfrost_device_init(struct panfrost_device *pfdev) if (err) goto out_perfcnt; =20 + pm_runtime_set_active(pfdev->base.dev); + pm_runtime_mark_last_busy(pfdev->base.dev); + pm_runtime_get_noresume(pfdev->base.dev); + pm_runtime_enable(pfdev->base.dev); + pm_runtime_set_autosuspend_delay(pfdev->base.dev, 50); /* ~3 frames */ + pm_runtime_use_autosuspend(pfdev->base.dev); + + /* + * Register the DRM device with the core and the connectors with + * sysfs + */ + err =3D drm_dev_register(&pfdev->base, 0); + if (err < 0) + goto err_disable_rpm; + + pm_runtime_put_autosuspend(pfdev->base.dev); + return 0; =20 +err_disable_rpm: + pm_runtime_dont_use_autosuspend(pfdev->base.dev); + pm_runtime_disable(pfdev->base.dev); + pm_runtime_put_noidle(pfdev->base.dev); + pm_runtime_set_suspended(pfdev->base.dev); + panfrost_gem_fini(pfdev); out_perfcnt: panfrost_perfcnt_fini(pfdev); out_job: @@ -313,6 +343,13 @@ int panfrost_device_init(struct panfrost_device *pfdev) =20 void panfrost_device_fini(struct panfrost_device *pfdev) { + pm_runtime_get_sync(pfdev->base.dev); + + pm_runtime_dont_use_autosuspend(pfdev->base.dev); + pm_runtime_disable(pfdev->base.dev); + pm_runtime_put_noidle(pfdev->base.dev); + pm_runtime_set_suspended(pfdev->base.dev); + panfrost_gem_fini(pfdev); panfrost_perfcnt_fini(pfdev); panfrost_jm_fini(pfdev); diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panf= rost/panfrost_drv.c index a3eff77add55..f77780c72a1a 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -830,7 +830,6 @@ static const struct drm_driver panfrost_drm_driver =3D { static int panfrost_probe(struct platform_device *pdev) { struct panfrost_device *pfdev; - int err; =20 pfdev =3D devm_drm_dev_alloc(&pdev->dev, &panfrost_drm_driver, struct panfrost_device, base); @@ -839,46 +838,7 @@ static int panfrost_probe(struct platform_device *pdev) =20 platform_set_drvdata(pdev, pfdev); =20 - pfdev->comp =3D of_device_get_match_data(&pdev->dev); - if (!pfdev->comp) - return -ENODEV; - - pfdev->coherent =3D device_get_dma_attr(&pdev->dev) =3D=3D DEV_DMA_COHERE= NT; - - err =3D panfrost_device_init(pfdev); - if (err) { - if (err !=3D -EPROBE_DEFER) - dev_err(&pdev->dev, "Fatal error during GPU init\n"); - goto err_out0; - } - - pm_runtime_set_active(pfdev->base.dev); - pm_runtime_mark_last_busy(pfdev->base.dev); - pm_runtime_get_noresume(pfdev->base.dev); - pm_runtime_enable(pfdev->base.dev); - pm_runtime_set_autosuspend_delay(pfdev->base.dev, 50); /* ~3 frames */ - pm_runtime_use_autosuspend(pfdev->base.dev); - - /* - * Register the DRM device with the core and the connectors with - * sysfs - */ - err =3D drm_dev_register(&pfdev->base, 0); - if (err < 0) - goto err_out1; - - pm_runtime_put_autosuspend(pfdev->base.dev); - - return 0; - -err_out1: - pm_runtime_dont_use_autosuspend(pfdev->base.dev); - pm_runtime_disable(pfdev->base.dev); - pm_runtime_put_noidle(pfdev->base.dev); - pm_runtime_set_suspended(pfdev->base.dev); - panfrost_device_fini(pfdev); -err_out0: - return err; + return panfrost_device_init(pfdev); } =20 static void panfrost_remove(struct platform_device *pdev) @@ -887,11 +847,6 @@ static void panfrost_remove(struct platform_device *pd= ev) =20 drm_dev_unregister(&pfdev->base); =20 - pm_runtime_get_sync(pfdev->base.dev); - pm_runtime_dont_use_autosuspend(pfdev->base.dev); - pm_runtime_put_noidle(pfdev->base.dev); - pm_runtime_disable(pfdev->base.dev); - pm_runtime_set_suspended(pfdev->base.dev); panfrost_device_fini(pfdev); } =20 --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF53F3839B3 for ; Mon, 7 Sep 2026 20:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.182.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812279; cv=pass; b=uiOulJ8XmCLAQseNJDsWqDjKnMJLskt/E7IQbrr6hX7YteH12hqcK8qCkuzrmIamhAMHX99lEJ0C+8AWr+W8ihPoy/m94G/E6CHkFIO9384w2Qs2Ty8a/PuZLmrFYjOC76wQRGLLTejbwQ1OqqPHOdN67PB2NPKA377HNApeXWg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812279; c=relaxed/simple; bh=msNOWUffbRkrfSraVB7gjtlcxGicDQCYrGfFUU2cXOI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fvk4pAMAxHnxo6n3Okacs+w/Jt42G5y7i3++5NUGtTY3e4Dt/vmkmkCZ6NkvFf9i9nuAia17/0HchyfUv7SrTxCxbWXxYc+AAT7En9xKoQTvaweFqwCp4ZyEOkT/M11GcVJOz8F78M8z603q5EYFssR7pqX0Vf2AipGSoIbl6zA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=L79uMPTB; arc=pass smtp.client-ip=165.173.182.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="L79uMPTB" ARC-Seal: i=1; a=rsa-sha256; t=1788812241; cv=none; d=zohomail.com; s=zohoarc; b=OSTxbewsjM9Z19ffh94qj7iQorlww6IBMPVN5hFZW9LIKEJc18keOwMyk2tTcUfKmm6ru1oBSaXEjjtFm/F7vzNRiPUAFlQsDd75uQTmWxLBTqbEe1gGHDYVN6ZsSxhHHteXYmrh8UjGoegQrD2x6LSN1jg9X1/wwNZviqb0aVo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812241; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=6M13TZPP7oUqvUc1g291xz+3tm1ArWqnIZv6qGHUXZI=; b=mn09mE6lnkLifsOA20MNOo1x4OiJknYTrqv5ziRJ85JTIb8tOh0l8LaZCrU067dD9+t/Bws5nQsKWXsSUPnXMpZEsUVu2DT8a4Rnf0XR6cWV9T2HkI9ZdJjc9TP9c7ML5p1LwsGJIaHwI8PT/H33/io/foRTjDvk62fx9WloPnY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812240; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=6M13TZPP7oUqvUc1g291xz+3tm1ArWqnIZv6qGHUXZI=; b=L79uMPTBLKfSCrpIQk4uZcw9HpKbyaFghFm4gDxxRZ8Gb/tNkQwrCTXyQvu6BjWo xHoejVDcJUlmB3Ts8Wi8bDm1Fe+yB1Z4rgqRlmUF8YLNdH3D9OF58ULH/+iY5+O98fq a+EzwLLd41g69k5GUhvj/V3atnRumyzyBJfa4020= Received: by mx.zohomail.com with SMTPS id 17888122402391000.8631023574272; Mon, 7 Sep 2026 13:17:20 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:18 +0100 Subject: [PATCH v8 09/16] drm/panfrost: Add warning messages to fatal error conditions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-9-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1571; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=msNOWUffbRkrfSraVB7gjtlcxGicDQCYrGfFUU2cXOI=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuLt2MzWFZ8f9diCxsE79Tm9S5k4ihOsVvHv a4asE5tJGyJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PbLkC/kBMI9NHh2ycE+ZTpq+MbjuTGEOUEIgg5cRpASEzm2JGWMggNyI1PG3DvaEQNrZt2IgE7r oHjXB1a34nhziioqr79LDceou45C8w+7SAKDiWe71488bShmLRjGRuYDg7zZlzSYluUEZxrbU9q t/h7en0Dj355qRfxmG76Igan2Ep/wYx8kv8YuNHQgcWTRG+TwkdGxGaP8o17ZN+46IpRTBwOA9a MgjNJEjfFgcA6Ur8fLChH7APvSUbx0I6FTKI7tSPz47gZ/v4gRuW3Xcx19DC+k3e5jrk6zJ3wPr LG+/u4/OvIOgXg+Kk1DtIFw8GZAOqu0o7Dz9f0Qyc5jRVQgWyblykzp67qYp1c5o4ORfFGNBsNG WjSNU75XXk7YWj1+Wl+/SXgtuV0t/D4O9oZ/OzAlYWeCypVx0z2DYYfNMtWO+hrrQj1zSlW5uhD 9hSFhMSIzgQb1kEJvRIcIpMhWaIZAcbc/e0b5Xbf0ZcDQKdI8InwdyUjJoQ7U9tLUMCns= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Rather than just failing silently, let's warn the user of device remove not being able to take an PM reference or the PM suspend path still reporting inflight jobs. Neither situation should ever happen. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index be4443e41d9a..f0fae6fa1e24 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -9,6 +9,7 @@ #include #include #include +#include =20 #include "panfrost_device.h" #include "panfrost_devfreq.h" @@ -343,7 +344,7 @@ int panfrost_device_init(struct panfrost_device *pfdev) =20 void panfrost_device_fini(struct panfrost_device *pfdev) { - pm_runtime_get_sync(pfdev->base.dev); + drm_WARN_ON(&pfdev->base, pm_runtime_get_sync(pfdev->base.dev) < 0); =20 pm_runtime_dont_use_autosuspend(pfdev->base.dev); pm_runtime_disable(pfdev->base.dev); @@ -501,7 +502,7 @@ static int panfrost_device_runtime_suspend(struct devic= e *dev) { struct panfrost_device *pfdev =3D dev_get_drvdata(dev); =20 - if (!panfrost_jm_is_idle(pfdev)) + if (drm_WARN_ON(&pfdev->base, !panfrost_jm_is_idle(pfdev))) return -EBUSY; =20 panfrost_devfreq_suspend(pfdev); --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 710351DB92C for ; Mon, 7 Sep 2026 20:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.182.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812291; cv=pass; b=GOzFP/qfg2a7KnJr46RKswO/N6z9aTJEpvwLhpnu4uOmKmendIr2DCqWo+L9klN/78ZkuUkaRmqi8l5rnJuNsNPG3kXrT7i3EsMSIN1pLHC3aLlf5gYpgdqI5j54vewR147T2gqO0WXtb615qQ/J/jsxqI069UGInc+Lu7+fXW0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812291; c=relaxed/simple; bh=eDn5Yrvo+UNTyZZswV8LnMNa0J4/HbH7rB91vZac1CA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PYgtkSc0t10P1n2c4rXZL0cQuDbJPmGR1MzD04diulctw0bEBVL1mz3J6ft4j5MkjojrxUcB403wZkbOBzbwPiAx0nAb0b600tc16sobPshItrFLUtLixoo6JqjSVag1cq/a62D4Iqfc/l7kRHTny7fzKXB2UyNB0CV4dJURd1M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=lACJUHaJ; arc=pass smtp.client-ip=165.173.182.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="lACJUHaJ" ARC-Seal: i=1; a=rsa-sha256; t=1788812253; cv=none; d=zohomail.com; s=zohoarc; b=On5WxD9EIZrbINOjqvGceeA+s48TBWUhqDolgRPinDRa7D7xvXyJVOlDCtxrmtGtHvNliXBWDFGwKNJQYZLovS46sl5zE3a+1Ir65BOpXRlIXBm8+Ocjg+dK7VQHz2zpwnTjqHEtQdfh3zvOe8JFUbwd/zcPk101P2ODQ05E5/0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812253; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=xvtZy+588vvNRELPvHTWe8SWq3OINK8uRg+k6pQWcYo=; b=Ko65kix8Aq3p3EN+3mlbQJiLMWtzTz/Vq9SiIqNnUaqEhZNjhdIUEzsCXW48MxpkrmD6dh+x2aWKi393dZiz3odG9I3CaQiQAcll/qEg11m6STI2l+vRM2aTkv+Fi67fS9Yd1IDLGCUNt0sYUmwjssufoL6x9m8qnFbSOhcHHBc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812253; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=xvtZy+588vvNRELPvHTWe8SWq3OINK8uRg+k6pQWcYo=; b=lACJUHaJpzPqdaOqiaLUKejOqoVr3hKUCaAM9Zm4pJb5weGeTDgWzjwQWZy9pS+B bS0kg/WB/6aWUdFON46mEcyIslLDEB3Alo8cEF8BG3e6wN3mkO9pweitIfJvIYAbeJU /iOklhes6lP7R3dRoEprXJpeYDSvTL4emVTGIo/s= Received: by mx.zohomail.com with SMTPS id 1788812251808736.0281902780624; Mon, 7 Sep 2026 13:17:31 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:19 +0100 Subject: [PATCH v8 10/16] drm/panfrost: Add debugfs knob for manually triggering a GPU reset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-10-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2042; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=eDn5Yrvo+UNTyZZswV8LnMNa0J4/HbH7rB91vZac1CA=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuLCvCf/HPVs0saeTT1IGHl2q9STZRkgskWJ Ff78vzuaJOJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8biwAKCRAOJn5M7lND PabHC/9isn3kvCiylQapm3680r04dKN1kLLvHCyvLXO0yZSJQRLpGDbye/NUBRyCdMbXc/MHGPg wbWWnhRkyXgSEey+Zdu15kW23cMZxlxg9ZKsJf/Hq5ynS+H3uqkdBw+NSQG0AHB92KGwEtMT57P 5sJUi716X/sGQoPLZPnvVjAuIjSn0y6/3brweqoOnEGXfbRYSNH6LZRtDDmiQaVLywonSAk5nyN 0VZxd2uoscQ+yasR1GdJT2QmrtxTpf+ZS1Gdq0U1wlKi+D1NA8u1Xoe1R46rSjOJ6l+d/Dd2cKj NdHhKdPE/W/voHqOJ6Zpme4CDAiAoCb1meewXwgJvMOCM5V3tPyLSkCFWm00vuoqDBmEH/nGtS7 m6Lmo8U0Ea0jjltF2vM3iTCJQnf7EEn34WKEAn00BhtopaqYwWa0SfTd3N4vlAX+2v0DCaRoROi WG2nF0R/D4pWGaz0IEXY5m6ZHOaBsHseDRs8beKt9I1NB8JYwHIlnH82qgc8DNltolZoU= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D This will be of great help when testing potential races between the GPU reset sequence and other parts of the code accessing HW registers. Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 37 ++++++++++++++++++++++++++= ++++ 1 file changed, 37 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index f0fae6fa1e24..f171abe26f80 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -2,6 +2,7 @@ /* Copyright 2018 Marty E. Plummer */ /* Copyright 2019 Linaro, Ltd, Rob Herring */ =20 +#include #include #include #include @@ -589,9 +590,45 @@ EXPORT_GPL_DEV_PM_OPS(panfrost_pm_ops) =3D { }; =20 #ifdef CONFIG_DEBUG_FS +static int reset_get(void *data, u64 *val) +{ + struct panfrost_device *pfdev =3D + container_of(data, struct panfrost_device, base); + + *val =3D atomic_read(&pfdev->reset.pending); + return 0; +} + +static int reset_set(void *data, u64 val) +{ + struct panfrost_device *pfdev =3D + container_of(data, struct panfrost_device, base); + int ret =3D pm_runtime_get_if_active(pfdev->base.dev); + + if (ret) { + panfrost_device_schedule_reset(pfdev); + flush_work(&pfdev->reset.work); + if (ret > 0) + pm_runtime_put(pfdev->base.dev); + } + + return 0; +} + +DEFINE_DEBUGFS_ATTRIBUTE(panfrost_reset_debugfs_fops, + reset_get, reset_set, + "0x%08llx\n"); + +static void panfrost_reset_debugfs_init(struct drm_minor *minor) +{ + debugfs_create_file("reset", 0600, minor->debugfs_root, + minor->dev, &panfrost_reset_debugfs_fops); +} + void panfrost_device_debugfs_init(struct drm_minor *minor) { panfrost_gem_debugfs_init(minor); panfrost_sched_debugfs_init(minor); + panfrost_reset_debugfs_init(minor); } #endif // CONFIG_DEBUG_FS --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE91D1DB92C for ; Mon, 7 Sep 2026 20:18:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812296; cv=pass; b=LFLLZ+wzbZn6NYkUWebs66hhtb5kdlJSKW8wt6nX21rKpgtWKYsjbsqSAYYYrKT6HGOz5jp7xWs9HYiZplN/BMVkBLivH4U5S/9wzxAjU9Ds8TaxTjkMhNqoPOoMCRK05SNv2oXWb2P0G+xmClwkPufBonJVSEFQl/Roeq+x780= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812296; c=relaxed/simple; bh=1NC6JbP9YeSjejJ7XZFftPMwKC3c1jXoMn6zNAHeTm0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nCQCaP7Mub6dGxR0WwQzJdQqIeV5tQ4xKMM2Zna4tUKssoGYDCEuZz34/gF4J87YHhmu+6PvgSiNVCTgXQPLkwzsDGBNpTkzi2VcCIkKuMx+bW8Q5x7SftAg/Rq4jLjLoInxkO5FN+TAeZ6RXc+G8PIBhp+IhollmlwBk4LwTXU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=ivwPVqYJ; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="ivwPVqYJ" ARC-Seal: i=1; a=rsa-sha256; t=1788812259; cv=none; d=zohomail.com; s=zohoarc; b=GMtUKTtttRh63fjJaZYpIPxB6MJ1JebYp5J1i6B6OvOZqW47MV3FriI7QVtJIjoGK9K0FpMPusuxi82SS1rHsts6e2u7mAEvDzcpVjbArVgdY0oQ+qs+Z1NfPTA1jipPVqCatbHnMGWW5RiKgeUl14geYY1+d0rrmJJv7Qg8z/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812259; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=3zLgjT3JfLXHkpzJh4PbWNTcLr4FUqsFF57+vQ+BFbA=; b=GAVTaR+TnJp+1P0+qw03vBEnP3vG6DwrGj8NvYFoy5rvawMgnjNPEPU4WtQ4sF0Xsf9iV3p05z+DkOxsZ9+xxapqX/2olcKqyDQlY+ptjYpg8dVS09VR/2Ba5spZQfk/J9FoIjcz3mUqEO2j6Ei10lGzbrtmVYwY67l19Nw3vlY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812259; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=3zLgjT3JfLXHkpzJh4PbWNTcLr4FUqsFF57+vQ+BFbA=; b=ivwPVqYJnSTj3y3GmkSv6ZJT3pdt7kCeBDaKfqfXkSM/3JuCS40Oyhmm4d2fjry9 xr/fTf/uCjNYGgMqmFrtTXLITOM7Yj+4o1Mq0owVcO5DUFFNh35eP1UvwB29v/G4IOp 04+YO/X8fWuWICSM4FLZcw92JMPsEl3Tjlg7zyrQ= Received: by mx.zohomail.com with SMTPS id 178881225815759.26404361009304; Mon, 7 Sep 2026 13:17:38 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:20 +0100 Subject: [PATCH v8 11/16] drm/panfrost: Move perfcnt GPU disable sequence into a helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-11-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2775; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=1NC6JbP9YeSjejJ7XZFftPMwKC3c1jXoMn6zNAHeTm0=; b=owEB7AET/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuMiTt2d+wImlyKxEtoe6rsa7dwdgxK+Jjf0 b+M7/B32i+JAbIEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8bjAAKCRAOJn5M7lND PRvAC/ikslosiDkvd42qK1SUtPBJLBi/k6/w9QMrP+9yTSsv8/ZwsuV1W8JtinLe4z+5IX4bQ4K uXjJBr3Rjq143VWs2sAqUWPYArt3n4bkfGoZrvear+6CG2eX2tKjxBeaDzza+Eyn0FgedBwXcWr CxDHqYuyYHVgMxQf6lhKxJZf7ISQj+v7/CnhmkFrtYX384uDIGKmFHntTorjYEH0vN6ZvVvL9U/ tgv1/116Kbj8zoAVyATjvM1nwj60PukhpvrCc8MkzwL5sehDfT8nmfghCI6fGWJjHPXFtMVY2+w ZOlFYJNRW6/HjWR+OAd1SdvAnlECoY3LkIkYBzDcJyWs48iEj5RFBvYCa3TewOFgWmka3tO/rLh oFZgX1wFhDYHiDLwH1jzCcAwH4EXEiRZEA7S91YvdOBmT/qV/olU1QQE2Suokxt1yNWR+PLcK70 soebv0OSaNALZV+1vekPdzAZ2gfSy+PHSKRX6LteHbIYL0wpiDwLzwpOqG1ZHEiEdfYA== X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Just for the sake of avoiding repetition. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 31 ++++++++++++-------------= ---- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/= panfrost/panfrost_perfcnt.c index 7020c0192e18..f71534e741b6 100644 --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c @@ -35,6 +35,16 @@ struct panfrost_perfcnt { struct completion dump_comp; }; =20 +static void panfrost_perfcnt_hw_disable(struct panfrost_device *pfdev) +{ + gpu_write(pfdev, GPU_PERFCNT_CFG, + GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); + gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0x0); + gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0x0); + gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0x0); + gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); +} + void panfrost_perfcnt_clean_cache_done(struct panfrost_device *pfdev) { complete(&pfdev->perfcnt->dump_comp); @@ -193,12 +203,7 @@ static int panfrost_perfcnt_disable_locked(struct panf= rost_device *pfdev, if (user !=3D perfcnt->user) return -EINVAL; =20 - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0x0); - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0x0); - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0x0); - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); - gpu_write(pfdev, GPU_PERFCNT_CFG, - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); + panfrost_perfcnt_hw_disable(pfdev); =20 perfcnt->user =3D NULL; drm_gem_vunmap(&perfcnt->mapping->obj->base.base, &map); @@ -327,12 +332,7 @@ int panfrost_perfcnt_init(struct panfrost_device *pfde= v) perfcnt->bosize =3D size; =20 /* Start with everything disabled. */ - gpu_write(pfdev, GPU_PERFCNT_CFG, - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); + panfrost_perfcnt_hw_disable(pfdev); =20 init_completion(&perfcnt->dump_comp); mutex_init(&perfcnt->lock); @@ -344,10 +344,5 @@ int panfrost_perfcnt_init(struct panfrost_device *pfde= v) void panfrost_perfcnt_fini(struct panfrost_device *pfdev) { /* Disable everything before leaving. */ - gpu_write(pfdev, GPU_PERFCNT_CFG, - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); + panfrost_perfcnt_hw_disable(pfdev); } --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DFBE3F2101 for ; Mon, 7 Sep 2026 20:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.180.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812305; cv=pass; b=rScgoyFD1zFTAsxxltHJQzmW6hDPgEM2+pwNQb+Ftfin0ytrxj9KbT1/4RDYSroP3fX4AukF3aKRLPeC5Jul1LYAw14594mcuHg04XTy1Hq2zUe2dwylGc51NYeNurvwu2wu1vBTIcBj3gYBwqWoA6W+Jz4Dlax1Swqb0QlHOfk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812305; c=relaxed/simple; bh=F0RVJv4zmQDLG69ZrU/+60HS5v7NarQ+E2qnB8Iq9Pg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mHZK4wDNWAhgpcjQ8qdm33Am2gOp4lBD233Bo7jzPBzORI6NAexXsms8RGktUNU+Hb6HK2+2tgWcf9t9wX73W9QI5XAiEz9BHhUaPjRXsUf6UoL2thKHLHDOTjTvORv2uTXrTqKjTJz7PnDBSwNKTOE+S9r1EbiQqQW81McwS6A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=I0IQYLU/; arc=pass smtp.client-ip=165.173.180.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="I0IQYLU/" ARC-Seal: i=1; a=rsa-sha256; t=1788812265; cv=none; d=zohomail.com; s=zohoarc; b=GYjQgPJubFsGiy/35g4tujCU2mk3L3glQRRnQFE1a9XpMYSPTrRkHygwPmkQaL5BVm9rssBvpe2S9q2fBTLublKOevR/W/OXYWRF54MA+mL253Vfs5kvOx1VabogLIF8MvJ97b2b4kxXva+34M22Pa+fqWpEKfRyUJGoeo9vLFI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812265; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=nWV812BLSXmGL2bwlh63A8Rlix0yVVzCrVgfDvlUkzI=; b=KUeDBGJfdJLV5Nfq+89JjgXFQSLAiGxgSzunTyVkksD2FACVs6lCNVGDqoJdQsTP6GyHpMSB5sZ6HWJ/MkDIOuQ2t201Feq+s50VnbueupbqB0rc+Xk2Zj1DTsN7EbsWl0hP/eZElKZt913Cs5okQfFz+URftqhZ+mKqucy5oCY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812265; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=nWV812BLSXmGL2bwlh63A8Rlix0yVVzCrVgfDvlUkzI=; b=I0IQYLU/Ps55gJIig3jwpzqIbIKlZKLFwIv+6QYm2NJMui2Aja1jV2gE6mbRiFRu hj8kWsAPRKSZQUOAGU4ZR0oHsxBsxqqLfwvxFlhxIAUZwKjvic0MxNbYdMIGVFt2DWg IzR/wTUoZsPGiwyuPpCDvfncyscuLO7sYmSM5KRc= Received: by mx.zohomail.com with SMTPS id 1788812264158519.255214047487; Mon, 7 Sep 2026 13:17:44 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:21 +0100 Subject: [PATCH v8 12/16] drm/panfrost: Skip cache flush/invalidate when enabling perfcnt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-12-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1654; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=F0RVJv4zmQDLG69ZrU/+60HS5v7NarQ+E2qnB8Iq9Pg=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuMJTRWQbeT8wNHkFP/Pq7V1jdosBksWXbnJ +FG5RORZeaJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8bjAAKCRAOJn5M7lND PSZlDACBWqZieqtvUkETvF9tpl6Iq16M5aSBAp29K14Ixxj2FLmXT/dboXH5fpp4Enx7vQP+EYD UrvVukt119plJsP+LZXyedjLHAcX4okJoNzWQ9gMi6oFeIV1LR7/fJh3NiwjWIIiggWgJOoWNtr HqeAAA+1FCo0VdqO33Fqpr1sjESbhRAWd3DmVG/avcJekR8C21RY+54jaYzXw0y27o5EyGpxRRW 6rC57YZGW/eahj+XNdQsP6L3fb/5VNhcRBuQLCWBsX6YOUyGD2TAceQlPAvLclM+p8XbAZYvQMY WUTeUwJsN0hpJ817TeXnV3RxwGDMqrJR1zjJ6XO7FIiSQVmVBPahRc+02hO1x+sHqvRR81WVIXf RNL3pCq8OqDleNLjNBYX53lUrm3YAUJmyE4m0WALSgFKmaInKfVJj3yIqXouQYqDTM3yFc84KPH ZkG/mKR7VwuVBZEY+GgniJpNm2eWzeZ2YA6pU3xxQFRNgzJEKLKsRSlHKD6znf/ROB3DA= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D The GPU cache flush/invalidate operation is unnecessary. First off, the GPU doesn't read off the perfcnt sample buffer, only writes into it, so an invalidate doesn't make a difference. Then flushing GPU caches after each sample has been written is enough for the CPU to see updated values. Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/= panfrost/panfrost_perfcnt.c index f71534e741b6..ffc77121070e 100644 --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c @@ -124,21 +124,10 @@ static int panfrost_perfcnt_enable_locked(struct panf= rost_device *pfdev, panfrost_gem_internal_set_label(&bo->base, "Perfcnt sample buffer"); =20 /* - * Invalidate the cache and clear the counters to start from a fresh - * state. + * Clear the counters to start from a fresh state. */ - reinit_completion(&pfdev->perfcnt->dump_comp); - gpu_write(pfdev, GPU_INT_CLEAR, - GPU_IRQ_CLEAN_CACHES_COMPLETED | - GPU_IRQ_PERFCNT_SAMPLE_COMPLETED); + gpu_write(pfdev, GPU_INT_CLEAR, GPU_IRQ_PERFCNT_SAMPLE_COMPLETED); gpu_write(pfdev, GPU_CMD, GPU_CMD_PERFCNT_CLEAR); - gpu_write(pfdev, GPU_CMD, GPU_CMD_CLEAN_INV_CACHES); - ret =3D wait_for_completion_timeout(&pfdev->perfcnt->dump_comp, - msecs_to_jiffies(1000)); - if (!ret) { - ret =3D -ETIMEDOUT; - goto err_vunmap; - } =20 ret =3D panfrost_mmu_as_get(pfdev, perfcnt->mapping->mmu); if (ret < 0) --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32286419304 for ; Mon, 7 Sep 2026 20:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.180.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812309; cv=pass; b=hd03Wfzw3kGqlbuwnDrvRm1Gno+hpuIfPMem5ED5PxVzY5jZCfwau1Hey/rSPe9ciKASDfWVIuqOfynXvpC6beHaOMcfcNBYMPyLydmdX978k5YQypdcdz4lwbyjBUrUEKYtcT4hZI75V7Uux5sn3EqvFtskRsgzfssqJdum9WQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812309; c=relaxed/simple; bh=ylClgdA4qjN8YjgAXTrojrPeuTeRxcjN/yXHiltT8+A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W3dxRd2emgStviht8uO50LFvW4lo3PHDW8/lDX4d0ffNVDVavNPE5Uw78pG44WoZZ/PgXniaGp8QvcmEDyO13q48FfBIh6UVrTxKInqdpsqCvp7OhbTJgcOnx6+9OkQbIq9UXqDKhuN7IKxqb+aUUWe89fs8NpLXm0Vok/hnhmk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=KouGYzhX; arc=pass smtp.client-ip=165.173.180.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="KouGYzhX" ARC-Seal: i=1; a=rsa-sha256; t=1788812273; cv=none; d=zohomail.com; s=zohoarc; b=iqGmUPd3NYHfDsNs0S5IEuqQgG/+WH35dgOPaORy557zPSgFVEcaFM6LgJqlHEyL2xc17YInbAk+2j8fl3NQUyrJxTyJOvANzoUGfafbtGYZPrhE/TlcXGupEB66o7ffIUs4njl/Oa+rKd2H1Ssul2icTLQHKYGovnhEwK+fiEk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812273; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=rne2vTyla1RUI4gVDThBMRFsSeWjoijKTX5hYO0ZMA0=; b=S4kct4LmvDlFpiv10SKJvb0riJJUnQLia0ZP9uoCdOZ3w8IKEAU0LB0VKSnGRKP1wHy57l30GAPLOWN1az9YRI6VWouTuwmnO9+YGIvvn4/Gpk+pAGa3W11ev0VStSD3WcnW73+o9d2dhkraP3bfcTQdo4C1BrnuzYKAi5AS3Bg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812273; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=rne2vTyla1RUI4gVDThBMRFsSeWjoijKTX5hYO0ZMA0=; b=KouGYzhX/i7h35u6Fa77v+9fi5PIKxLNaNvwDQd+8T2IDwY/Tg73PZlwTU1ndD8d oitSbLssBO6rWy0SEgIaC4KROXEIfesK7y8WLX7DKb5Bz9O8BPb4uyAn8wQHmvPof/8 r1+hHfydk/yQ3tt3zNkGQMtEEP5Szk8mt/9omO88= Received: by mx.zohomail.com with SMTPS id 1788812270652238.69801899306844; Mon, 7 Sep 2026 13:17:50 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:22 +0100 Subject: [PATCH v8 13/16] drm/panfrost: Avoid cache flush after perfcnt sample in fully coherent systems Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-13-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1088; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=ylClgdA4qjN8YjgAXTrojrPeuTeRxcjN/yXHiltT8+A=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuM4rLA8yYhDgAmlST/vT34bi8mFHGBb7Jer Gk5hzn+ez6JAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8bjAAKCRAOJn5M7lND PSUvC/kB7OfTro6nzEnw21+jkSnM3DhhAE5ibOK/OyGQd/8Ltq4QqyqkJTu1JPyMy5dEF3JCtwk LloWOb3Y/BdBAEh6t+VO9/pg3MW33Knvx80bU0wlZ8oXkbOb5sRWWeAhro0pV3VH9K4Cp2ua8l0 Od2igDPO7vLlEABonI0u4ANlE/TBKFhF+zHlpl+tZO/28EJEe09X6+fTDKRn+64GYAOcrd11FcK VSMW+jqyxeq4jpci3W0uroibThhEX4FAbfQUF2RW91qx1poFV45pzZq/6jdmIgWLwtiBiGFpLcU BQXk8rLGpcDEIyq7KPQI0fbIeyGU5HS5fyyQHj+TnDbKZdgNZMlGu/VHynehD2QsRwZ7GcOaEi0 10f1cX4vXne+NIu4tQiXqm31AXSzeIXsloTK7XDK9MT7CNsTxk8Za0jXOEQOMedbSbkKhotrq74 KI5qW6Dy0K02dkXUT7KLxUrsBc98JD4zZgyJ+bBt0QR0swxCMs4pyJTtQGwrNn314rx8k= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D If the GPU and CPU are fully coherent, then there's no need to flush the GPU caches after a perfcnt sample is made available. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/= panfrost/panfrost_perfcnt.c index ffc77121070e..b3f71d7fd82a 100644 --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c @@ -52,7 +52,10 @@ void panfrost_perfcnt_clean_cache_done(struct panfrost_d= evice *pfdev) =20 void panfrost_perfcnt_sample_done(struct panfrost_device *pfdev) { - gpu_write(pfdev, GPU_CMD, GPU_CMD_CLEAN_CACHES); + if (pfdev->features.selected_coherency !=3D COHERENCY_ACE) + gpu_write(pfdev, GPU_CMD, GPU_CMD_CLEAN_CACHES); + else + complete(&pfdev->perfcnt->dump_comp); } =20 static int panfrost_perfcnt_dump_locked(struct panfrost_device *pfdev) --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CE5B3F2101 for ; Mon, 7 Sep 2026 20:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812315; cv=pass; b=qPMrKZltW9+QlHp5g/Mf+79Dux83cvyFosKLjtF+MMAQIc03wrsMouRUEdmpDt1cS0h5nhpZNrLr1KS5xpf4GMFm12fiIpPGo+CKcjLhqXFXHwPdM/opLa4NyiQZyFzPUJqKA1V+qFrezNvmPKzKglaJUbR4Y23HPfbnqUgv9NQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812315; c=relaxed/simple; bh=RLXJVqDsqciJ2yl5PsUrLuoeCj7qRp4bu3LBKb54af8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t1c4YnM2wh5FPQFt6ylObuNRWrPZUsXeJ8BMGhvzZ+Ujrd8JSDZJmg6nQinHuMbX7PMBkO5uFW/tjEyc7QHgvLMYIVm22ZcNdSjxcqkVQpBTP83WRqT+XBcMEVSbic+vRwu29KWqZCUetuFWy8Fi1+NLW0pYYoS92ie4buSL0T4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=cWsuLsUg; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="cWsuLsUg" ARC-Seal: i=1; a=rsa-sha256; t=1788812279; cv=none; d=zohomail.com; s=zohoarc; b=MuA8NHhE1oHwzXPlO4jmuk6dhxBSmhNzY7Yijeoe1+8/yz3fbUMNNeI76Phut8bua71eI4gHQsWTy76r62JDoDrIAo+FohCIilhmrKZONjPHpTRzPE61PF1IVqAvN8U0rk9u9N+i7palD/rYyTRaYy7MU2K31Q796x5qVjHVdXY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812279; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=QpVjZQIXEM6PuM7BJI1fj2uYWU3Giv1q4JGW4lXGAUQ=; b=A3IKjnZIz+olCDLUFnGfNMx8vBtKNLVr0KmaLF8wjx0BAkkxL6+NBtVlucMoufrdEVCU583mvWdWCDA5hbYSw8CsEXCyb9MyRFuxd/i9vhDZOdoIHHclwSfZ9XFAV8heF7yM0/vBzRI/sEpCy3OTd6Ox+91A/hxlekNH/Tv7/t0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812279; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=QpVjZQIXEM6PuM7BJI1fj2uYWU3Giv1q4JGW4lXGAUQ=; b=cWsuLsUgV33aRvZ36uMK96b86LSCQCDvz6OU5nQnJXcI5D7sTIF0c9XfUHhBdvED UxtRyVKF2FOdoregGHnFOJt3JioK+/Abb18T9H03gSFa8/38KucIomWQmtvOQLY8AcG m7xizWX+40+xSu66W0MQNkf8qu6MGQOU4TJB2Ox0= Received: by mx.zohomail.com with SMTPS id 1788812277306611.3921507709811; Mon, 7 Sep 2026 13:17:57 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:23 +0100 Subject: [PATCH v8 14/16] drm/panfrost: Introduce a reset lock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-14-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3001; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=RLXJVqDsqciJ2yl5PsUrLuoeCj7qRp4bu3LBKb54af8=; b=kA0DAAoBDiZ+TO5TQz0ByyZiAGqfG4zIy/uoHluHI30JJNL0ohN3HvSelA46mFR+kXQLX7B/h YkBswQAAQoAHRYhBDJAMOjABRdd+TcHpA4mfkzuU0M9BQJqnxuMAAoJEA4mfkzuU0M9lpIL/2Gs 13JUt2Ff8xhtU1X2fbFpyQnGsubbEKvRdqEqPcJsBZt4+XRovsaWjtm0URouLtNada2IOcBEF+3 khQsRardsNyiGGWDLc3hcdDwtTXggDY4+eKOdvyO0T2lJgExI/L70etMHmEf8NU4O+66tT95ozx AJE+xJoMQB546lBbJ3CgFyjCk3xeTo+bSPCYy/wWpApKjdSBAa1CybpbZmMHUp1ta5FLKWIn3Ov 8a3P81YzjNz338gGuM6Op0KA5pDelpOukfDOX9bgVyv7C/X3oJedJgmx8I0x8mn0cRHNm++ZqFI KziFyHNnpZWrqpw1LIzyI4HGh0jnUfiYXGF4fTnK3LXWQJzMqr3ZZBWpu3vQ6FE8V+LYuApRYCz JZYasrVJRs9KjutvUb5LD6ODWteRzSa7kL3yteJIIlBE6NV4kTOEu/4rpteWYIgzV/2isVJeDaS 3PXedRKeanZkqqJoVd13DLEowbGNSwDJab36MnNYTi1SDjzygrAOLHJiiO4g== X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D So as to avoid accessing HW register while a reset is ongoing, a read/write semaphore that envelopes the reset sequence will help driver entry points avoid racing with it. For now, the only such racy entry point is the ioctl that returns the current GPU timestmap. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 2 ++ drivers/gpu/drm/panfrost/panfrost_device.h | 1 + drivers/gpu/drm/panfrost/panfrost_drv.c | 9 ++++++--- drivers/gpu/drm/panfrost/panfrost_job.c | 1 + 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index f171abe26f80..e90efcff5ce7 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -466,6 +466,8 @@ bool panfrost_exception_needs_reset(const struct panfro= st_device *pfdev, =20 void panfrost_device_reset(struct panfrost_device *pfdev, bool enable_job_= int) { + guard(rwsem_write)(&pfdev->reset.lock); + panfrost_gpu_soft_reset(pfdev); =20 panfrost_gpu_power_on(pfdev); diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/p= anfrost/panfrost_device.h index a0b9a2145fc9..63452febb1cf 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -165,6 +165,7 @@ struct panfrost_device { struct { struct workqueue_struct *wq; struct work_struct work; + struct rw_semaphore lock; atomic_t pending; } reset; =20 diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panf= rost/panfrost_drv.c index f77780c72a1a..571a26b84126 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -41,9 +41,12 @@ static int panfrost_ioctl_query_timestamp(struct panfros= t_device *pfdev, if (ret) return ret; =20 - panfrost_cycle_counter_get(pfdev); - *arg =3D panfrost_timestamp_read(pfdev); - panfrost_cycle_counter_put(pfdev); + /* We should not read timestamp register while the GPU is being reset */ + scoped_guard(rwsem_read, &pfdev->reset.lock) { + panfrost_cycle_counter_get(pfdev); + *arg =3D panfrost_timestamp_read(pfdev); + panfrost_cycle_counter_put(pfdev); + } =20 pm_runtime_put(pfdev->base.dev); return 0; diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panf= rost/panfrost_job.c index 00fb36c577df..c2b1f1087e21 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.c +++ b/drivers/gpu/drm/panfrost/panfrost_job.c @@ -877,6 +877,7 @@ int panfrost_jm_init(struct panfrost_device *pfdev) INIT_WORK(&pfdev->reset.work, panfrost_reset_work); spin_lock_init(&js->job_lock); mutex_init(&pfdev->sched_lock); + init_rwsem(&pfdev->reset.lock); =20 js->irq =3D platform_get_irq_byname(to_platform_device(pfdev->base.dev), = "job"); if (js->irq < 0) --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732F93F4827 for ; Mon, 7 Sep 2026 20:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812323; cv=pass; b=HtUt4eDnO+egTRIuHzrolwuIJwcNoF81wSx9KWsPlA/olQrsTa3y7w1VblCTjW2sJiJFbJf4mRlPWdr4SmSuMrA3WtAvlISxMCF4zk2RcVcyz1HkmNNYTkHZfORH+8lYNW8BkdEs4gA3R+vGYbRkjZEP6JIq2JinS/I+QZyRctw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812323; c=relaxed/simple; bh=sPwIALqJdDKFcy/vIQzIATEGWi+POmV9JcKjb1g1PbY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SnwUK/V2eR+y5LO+yXOjVi9DiEkjg+JvRie5aSymzaYFK85pM1tG2spn1Q3XWarA4GX0KMGuYgfsod8l35OZVVnUqZwbm1nK4/YWvtWcXWUhnjcpSo3b3/KSDxhgnY87UhVdirU70r3bQ7aMb6rzDOFXN+jy/lJLVsqd3UeCaQY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=OxdhLkD8; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="OxdhLkD8" ARC-Seal: i=1; a=rsa-sha256; t=1788812285; cv=none; d=zohomail.com; s=zohoarc; b=fKnZGPnueTtmpgHpFiEz8gvr9vKi8Gnbi+urayEG/sG2ZCYaAx6AknE0dTPi2NR3ObmRpY1KPBJcNbSihxJq2Q/TH0hUztEbI9u6uzg9V2xxsJGz1cN+/qltqnLaniMG0j4TlVbjWnb4rgxeXVXctQs5qa14Lh435PMyxfw9IjM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812285; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=EScfnB2oes8qbpSLma0BrWwdrxPPDz5Uchyixa9eKYs=; b=LWPUN8wM4bjR0O5keRlZY76gb/LN7NafYHQrRsM0kxUoS5c0poUCWw7+NMfwMxT+4ukToX18rF9oFJR/slGArtzWz/LyCkyEJ3R4hXKedgz5p4QBxztdx/Pi6yLyzUlSOkU1w2mE7i8+NtXmBbAHstRQ2/K50W2D0+ZjztouyQY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812285; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=EScfnB2oes8qbpSLma0BrWwdrxPPDz5Uchyixa9eKYs=; b=OxdhLkD8WYMVerpDDAsfL5aEsRxWeV8Ro9YvCrlSl3N/ajQ3/CAaHqJ9WTwye5Yh UQpgOfNq0sTHVbZBG3tdtGn/3ORl4C6rtUkwQM3Z1PL2vdpWsUXYVKLC8cistoIkKSM TbVR0P9ofxrMfaVGw7jU7SZAcBNdgWt5AsD8Lii0= Received: by mx.zohomail.com with SMTPS id 1788812283765940.3041392959459; Mon, 7 Sep 2026 13:18:03 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:24 +0100 Subject: [PATCH v8 15/16] drm/panfrost: Fix races between perfcnt and reset sequence Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-15-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=12592; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=sPwIALqJdDKFcy/vIQzIATEGWi+POmV9JcKjb1g1PbY=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuM+6ys5jhcBTfjODuTYFhdkZ0pFEGuG8Wpx 7Ct3T/go3yJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8bjAAKCRAOJn5M7lND PdGAC/4mTAlUIDRjabRYzjbK+hW4Huc13cFew5LYhgHBI9Rwb9fKo7DJxgklrW6Gq4sz/2nflQn EqQVogbHEZItFbulztjQbkbgXDPJuhPm1s6TdQBLNnbDD6hCx/gRR0VTNv2J82hMnIHQAq4kaHD immCwl73u12DrvHs0pSTPU0lvUzS2SwQcrGMcrnwqYrqTOc/BZ0eJoV2nuhc+y3igZt8i1kn05S YE8NG+fxe/oHFV97vLA9mhpGgxVYxwK6Z8F+41Bkv+YVDUt/xv+6bKqlhZZXq6nqE8wpfO12fKx EzMDbZzGoJ++l7okznfnCNPs6Vbh3bQhW2JHK+HheKMBvNIY/9vPd7fC+vd7+kUoQLHfwXcWaOX Fjb1fa6pfBv/gJbXckWsoPTCByBeqay/NCBU74wS/wa8p+7B0g0xOwiB0d4K0q0ZJMrgQJ8HemD Z9ky81Rm1ppzXSwRUw4c9y39s236buVozRJ1aDomNj3pmZ5zAFCISp8whuxQTJVvUn7bQ= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Formerly, the reset sequence would race with panfrost_mmu_as_put() when tearing down a perfcnt session. On top of that, poking GPU registers to program a perfcnt session or obtaining a dump might lead to undefined behaviour when done at the same time a reset was ongoing. Use the reset r/w semaphore to govern access to the hardware at reset time. On top of that, expand the DRM uAPI for the perfcnt DUMP operation so that userspace can be made aware of a reset having happened, because that means counters will go back to 0 and can no longer be accumulated to values previously kept in user space. The new perfcnt-aware reset sequence also takes care to reestablish perfcnt to its original configuration if there was an enabled session, or else flags the current session as dead if that failed. Fixes: 73e467f60acd ("drm/panfrost: Consolidate reset handling") Fixes: 7786fd108777 ("drm/panfrost: Expose performance counters through uns= table ioctls") Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 2 + drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 195 +++++++++++++++++++-----= ---- drivers/gpu/drm/panfrost/panfrost_perfcnt.h | 1 + include/uapi/drm/panfrost_drm.h | 8 +- 4 files changed, 145 insertions(+), 61 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index e90efcff5ce7..690598342a86 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -476,6 +476,8 @@ void panfrost_device_reset(struct panfrost_device *pfde= v, bool enable_job_int) panfrost_jm_reset_interrupts(pfdev); if (enable_job_int) panfrost_jm_enable_interrupts(pfdev); + + panfrost_perfcnt_reset(pfdev); } =20 static int panfrost_device_runtime_resume(struct device *dev) diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/= panfrost/panfrost_perfcnt.c index b3f71d7fd82a..fef01000deb6 100644 --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c @@ -11,6 +11,7 @@ #include #include #include +#include =20 #include "panfrost_device.h" #include "panfrost_features.h" @@ -28,11 +29,15 @@ =20 struct panfrost_perfcnt { struct panfrost_gem_mapping *mapping; + unsigned int counterset; size_t bosize; void *buf; struct panfrost_file_priv *user; struct mutex lock; struct completion dump_comp; + bool reset_happened; + bool dump_finished; + bool owns_as_ref; }; =20 static void panfrost_perfcnt_hw_disable(struct panfrost_device *pfdev) @@ -47,36 +52,110 @@ static void panfrost_perfcnt_hw_disable(struct panfros= t_device *pfdev) =20 void panfrost_perfcnt_clean_cache_done(struct panfrost_device *pfdev) { + pfdev->perfcnt->dump_finished =3D true; complete(&pfdev->perfcnt->dump_comp); } =20 void panfrost_perfcnt_sample_done(struct panfrost_device *pfdev) { - if (pfdev->features.selected_coherency !=3D COHERENCY_ACE) + if (pfdev->features.selected_coherency !=3D COHERENCY_ACE) { gpu_write(pfdev, GPU_CMD, GPU_CMD_CLEAN_CACHES); - else + } else { + pfdev->perfcnt->dump_finished =3D true; complete(&pfdev->perfcnt->dump_comp); + } +} + +static int panfrost_perfcnt_hw_enable(struct panfrost_device *pfdev) +{ + struct panfrost_perfcnt *perfcnt =3D pfdev->perfcnt; + u32 cfg, as; + int ret; + + ret =3D panfrost_mmu_as_get(pfdev, perfcnt->mapping->mmu); + if (ret < 0) + return ret; + + as =3D ret; + cfg =3D GPU_PERFCNT_CFG_AS(as) | + GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_MANUAL); + + /* + * Bifrost GPUs have 2 set of counters, but we're only interested by + * the first one for now. + */ + if (panfrost_model_is_bifrost(pfdev)) + cfg |=3D GPU_PERFCNT_CFG_SETSEL(perfcnt->counterset); + + gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0xffffffff); + gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0xffffffff); + gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0xffffffff); + + /* + * Due to PRLAM-8186 we need to disable the Tiler before we enable HW + * counters. + */ + if (panfrost_has_hw_issue(pfdev, HW_ISSUE_8186)) + gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); + else + gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0xffffffff); + + gpu_write(pfdev, GPU_PERFCNT_CFG, cfg); + + if (panfrost_has_hw_issue(pfdev, HW_ISSUE_8186)) + gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0xffffffff); + + return 0; } =20 -static int panfrost_perfcnt_dump_locked(struct panfrost_device *pfdev) +static int panfrost_perfcnt_dump_locked(struct panfrost_device *pfdev, u32= *state) { - u64 gpuva; + struct panfrost_perfcnt *perfcnt =3D pfdev->perfcnt; + u64 gpuva =3D perfcnt->mapping->mmnode.start << PAGE_SHIFT; int ret; =20 - reinit_completion(&pfdev->perfcnt->dump_comp); - gpuva =3D pfdev->perfcnt->mapping->mmnode.start << PAGE_SHIFT; - gpu_write(pfdev, GPU_PERFCNT_BASE_LO, lower_32_bits(gpuva)); - gpu_write(pfdev, GPU_PERFCNT_BASE_HI, upper_32_bits(gpuva)); - gpu_write(pfdev, GPU_INT_CLEAR, - GPU_IRQ_CLEAN_CACHES_COMPLETED | - GPU_IRQ_PERFCNT_SAMPLE_COMPLETED); - gpu_write(pfdev, GPU_CMD, GPU_CMD_PERFCNT_SAMPLE); + scoped_guard(rwsem_read, &pfdev->reset.lock) { + if (!perfcnt->owns_as_ref) { + *state =3D PANFROST_PERFCNT_SESSION_DEAD; + return -EIO; + } + + if (perfcnt->reset_happened) { + *state =3D PANFROST_PERFCNT_SESSION_INTERRUPTED_BY_RESET; + perfcnt->reset_happened =3D false; + } + + perfcnt->dump_finished =3D false; + + reinit_completion(&pfdev->perfcnt->dump_comp); + + gpu_write(pfdev, GPU_PERFCNT_BASE_LO, lower_32_bits(gpuva)); + gpu_write(pfdev, GPU_PERFCNT_BASE_HI, upper_32_bits(gpuva)); + gpu_write(pfdev, GPU_INT_CLEAR, GPU_IRQ_CLEAN_CACHES_COMPLETED | + GPU_IRQ_PERFCNT_SAMPLE_COMPLETED); + gpu_write(pfdev, GPU_CMD, GPU_CMD_PERFCNT_SAMPLE); + } + + /* + * Here we release the reset semaphore because perfcnt should not get in = the way + * of a HW reset. Besides, a legitimate reset might be issued during the = wait. + */ ret =3D wait_for_completion_interruptible_timeout(&pfdev->perfcnt->dump_c= omp, msecs_to_jiffies(1000)); - if (!ret) - ret =3D -ETIMEDOUT; - else if (ret > 0) - ret =3D 0; + + scoped_guard(rwsem_read, &pfdev->reset.lock) { + /* Either sample finished or reset happened */ + if (ret > 0) { + ret =3D perfcnt->dump_finished ? 0 : + perfcnt->owns_as_ref ? -EAGAIN : -EIO; + if (perfcnt->reset_happened) + *state |=3D PANFROST_PERFCNT_SESSION_INTERRUPTED_BY_RESET; + if (!perfcnt->owns_as_ref) + *state |=3D PANFROST_PERFCNT_SESSION_DEAD; + } else if (!ret) { + ret =3D -ETIMEDOUT; + } + } =20 return ret; } @@ -87,9 +166,8 @@ static int panfrost_perfcnt_enable_locked(struct panfros= t_device *pfdev, { struct panfrost_file_priv *user =3D file_priv->driver_priv; struct panfrost_perfcnt *perfcnt =3D pfdev->perfcnt; - struct iosys_map map; struct drm_gem_shmem_object *bo; - u32 cfg, as; + struct iosys_map map; int ret; =20 if (user =3D=3D perfcnt->user) @@ -122,54 +200,31 @@ static int panfrost_perfcnt_enable_locked(struct panf= rost_device *pfdev, ret =3D drm_gem_vmap(&bo->base, &map); if (ret) goto err_put_mapping; + perfcnt->buf =3D map.vaddr; + perfcnt->counterset =3D counterset; =20 panfrost_gem_internal_set_label(&bo->base, "Perfcnt sample buffer"); =20 - /* - * Clear the counters to start from a fresh state. - */ - gpu_write(pfdev, GPU_INT_CLEAR, GPU_IRQ_PERFCNT_SAMPLE_COMPLETED); - gpu_write(pfdev, GPU_CMD, GPU_CMD_PERFCNT_CLEAR); - - ret =3D panfrost_mmu_as_get(pfdev, perfcnt->mapping->mmu); - if (ret < 0) - goto err_vunmap; - - as =3D ret; - cfg =3D GPU_PERFCNT_CFG_AS(as) | - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_MANUAL); - - /* - * Bifrost GPUs have 2 set of counters, but we're only interested by - * the first one for now. - */ - if (panfrost_model_is_bifrost(pfdev)) - cfg |=3D GPU_PERFCNT_CFG_SETSEL(counterset); - - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0xffffffff); - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0xffffffff); - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0xffffffff); - - /* - * Due to PRLAM-8186 we need to disable the Tiler before we enable HW - * counters. - */ - if (panfrost_has_hw_issue(pfdev, HW_ISSUE_8186)) - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); - else - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0xffffffff); + scoped_guard(rwsem_read, &pfdev->reset.lock) { + /* + * Clear the counters to start from a fresh state. + */ + gpu_write(pfdev, GPU_INT_CLEAR, GPU_IRQ_PERFCNT_SAMPLE_COMPLETED); + gpu_write(pfdev, GPU_CMD, GPU_CMD_PERFCNT_CLEAR); =20 - gpu_write(pfdev, GPU_PERFCNT_CFG, cfg); + ret =3D panfrost_perfcnt_hw_enable(pfdev); + if (ret) + goto err_vunmap; =20 - if (panfrost_has_hw_issue(pfdev, HW_ISSUE_8186)) - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0xffffffff); + perfcnt->reset_happened =3D false; + perfcnt->owns_as_ref =3D true; + perfcnt->user =3D user; + } =20 /* The BO ref is retained by the mapping. */ drm_gem_object_put(&bo->base); =20 - perfcnt->user =3D user; - return 0; =20 err_vunmap: @@ -195,13 +250,16 @@ static int panfrost_perfcnt_disable_locked(struct pan= frost_device *pfdev, if (user !=3D perfcnt->user) return -EINVAL; =20 - panfrost_perfcnt_hw_disable(pfdev); + scoped_guard(rwsem_read, &pfdev->reset.lock) { + panfrost_perfcnt_hw_disable(pfdev); + if (perfcnt->owns_as_ref) + panfrost_mmu_as_put(pfdev, perfcnt->mapping->mmu); + perfcnt->user =3D NULL; + } =20 - perfcnt->user =3D NULL; drm_gem_vunmap(&perfcnt->mapping->obj->base.base, &map); perfcnt->buf =3D NULL; panfrost_gem_close(&perfcnt->mapping->obj->base.base, file_priv); - panfrost_mmu_as_put(pfdev, perfcnt->mapping->mmu); panfrost_gem_mapping_put(perfcnt->mapping); perfcnt->mapping =3D NULL; pm_runtime_put_autosuspend(pfdev->base.dev); @@ -255,7 +313,7 @@ int panfrost_ioctl_perfcnt_dump(struct drm_device *dev,= void *data, goto out; } =20 - ret =3D panfrost_perfcnt_dump_locked(pfdev); + ret =3D panfrost_perfcnt_dump_locked(pfdev, &req->state); if (ret) goto out; =20 @@ -338,3 +396,20 @@ void panfrost_perfcnt_fini(struct panfrost_device *pfd= ev) /* Disable everything before leaving. */ panfrost_perfcnt_hw_disable(pfdev); } + +void panfrost_perfcnt_reset(struct panfrost_device *pfdev) +{ + struct panfrost_perfcnt *perfcnt =3D pfdev->perfcnt; + + if (drm_WARN_ON(&pfdev->base, !perfcnt)) + return; + + lockdep_assert_held(&pfdev->reset.lock); + + if (!perfcnt->user) + return; + + perfcnt->owns_as_ref =3D !panfrost_perfcnt_hw_enable(pfdev); + perfcnt->reset_happened =3D true; + complete(&perfcnt->dump_comp); +} diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.h b/drivers/gpu/drm/= panfrost/panfrost_perfcnt.h index 8bbcf5f5fb33..8b9bc704b634 100644 --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.h +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.h @@ -14,5 +14,6 @@ int panfrost_ioctl_perfcnt_enable(struct drm_device *dev,= void *data, struct drm_file *file_priv); int panfrost_ioctl_perfcnt_dump(struct drm_device *dev, void *data, struct drm_file *file_priv); +void panfrost_perfcnt_reset(struct panfrost_device *pfdev); =20 #endif diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_dr= m.h index 50d5337f35ef..b2c46fa0811b 100644 --- a/include/uapi/drm/panfrost_drm.h +++ b/include/uapi/drm/panfrost_drm.h @@ -47,7 +47,7 @@ extern "C" { * them for anything but debugging purpose. */ #define DRM_IOCTL_PANFROST_PERFCNT_ENABLE DRM_IOW(DRM_COMMAND_BASE + DRM_P= ANFROST_PERFCNT_ENABLE, struct drm_panfrost_perfcnt_enable) -#define DRM_IOCTL_PANFROST_PERFCNT_DUMP DRM_IOW(DRM_COMMAND_BASE + DRM_PA= NFROST_PERFCNT_DUMP, struct drm_panfrost_perfcnt_dump) +#define DRM_IOCTL_PANFROST_PERFCNT_DUMP DRM_IOWR(DRM_COMMAND_BASE + DRM_P= ANFROST_PERFCNT_DUMP, struct drm_panfrost_perfcnt_dump) =20 #define PANFROST_JD_REQ_FS (1 << 0) #define PANFROST_JD_REQ_CYCLE_COUNT (1 << 1) @@ -270,8 +270,14 @@ struct drm_panfrost_perfcnt_enable { __u32 counterset; }; =20 +/* Perfcnt dump state as influenced by a HW reset */ +#define PANFROST_PERFCNT_SESSION_DEAD (1 << 0) +#define PANFROST_PERFCNT_SESSION_INTERRUPTED_BY_RESET (1 << 1) + struct drm_panfrost_perfcnt_dump { __u64 buf_ptr; + __u32 state; + __u32 pad; }; =20 /* madvise provides a way to tell the kernel in case a buffers contents --=20 2.55.0 From nobody Fri Sep 25 23:09:23 2026 Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D4BF3CC337 for ; Mon, 7 Sep 2026 20:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.182.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812328; cv=pass; b=hgnRTUBBG4nylIGv6+4s0aWZfK4HD0kNlyvv5bgIovIEnCXlz2OF1ve805VmtxlAEtBbecEsdY4psEQGPWuFcefAyJMAX1tp9Vx3tVM8u+EHhb/fr3RiLKQqhIb0cuxpkPMcTyjlS3ONIt0U7MrVGbFJGEEdwSUxi36Gb7KQNwM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812328; c=relaxed/simple; bh=fcINJblJRb432SfE3VmHwqT0pqshFhBkvIiNxSLnr6s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=itAkjc+5yT8kDwavRGAhgU++EGsjxCFBERxvXFC1RJsnhTRlMuHgU75jh3aH0s7d5Bp3ZJNFH5JYPbg1jUcgkrTLKizwPOCPfy23pJMkFT4H7RttyDaiA1OpfJOy/ghs29BIBOAUXgsWo5IBtDbSqilJtfoZam1sI/0h4Dk0wWY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=ODzSJp3X; arc=pass smtp.client-ip=165.173.182.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="ODzSJp3X" ARC-Seal: i=1; a=rsa-sha256; t=1788812291; cv=none; d=zohomail.com; s=zohoarc; b=HsSESzIReyq8ohGsCaKzZrhVmJwLEXr2ANOLQ3GNpPJkEihi8LLo1pahexliMX9onj26bBeQQdpFOTvCGkaiJq16/Jst/mGM71bvVgnpMcvPJiGq15V1YXns9mOHTWv6lL6sDxuAFDU+0xdv41KV4u7APn4NzeBrFyuf01G8zYU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788812291; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=GiNAk1ddULmDOvtto/fkJvNwC9OGSrBfiGgPyvguuH0=; b=hcelYD4J3cRqES7P0DMZoHlrGR5G20PQGNzSMjkUNNiHJARpVoWA0+Ev0/5otyGFrgdNonA63lHs59X7LgR60J/zStNsamPSMZmu2pYVxTCe4BRBQI8t/PnkEs76VvbABdK+TJPSKSCOEOjuSoAZg2Ut0iG3pCPiFbzLnzLSvHg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788812291; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=GiNAk1ddULmDOvtto/fkJvNwC9OGSrBfiGgPyvguuH0=; b=ODzSJp3XyuPT6iipXL7WtbnPP3Vner73f3nlKb/wlOCv62gVieaJSM2HNVl04JIy It/yc3f04pAgz+XZdV4drB+1gYTlkiFfi9x+mKCcFyyyimpYTd/o0fbpgC9cao3Lzw+ cmt1r9fwyWi8ogrpJc/TeH+zK7aWy8Lwj2wdoYWg= Received: by mx.zohomail.com with SMTPS id 1788812289723366.9762585632135; Mon, 7 Sep 2026 13:18:09 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Mon, 07 Sep 2026 21:16:25 +0100 Subject: [PATCH v8 16/16] drm/panfrost: Bump driver minor to reflect new DUMP IOCTL req field Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-claude-fixes-v8-16-c2bcb5e82184@collabora.com> References: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> In-Reply-To: <20260907-claude-fixes-v8-0-c2bcb5e82184@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1175; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=fcINJblJRb432SfE3VmHwqT0pqshFhBkvIiNxSLnr6s=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqnxuMjIWVkrqvWdN8Cru2QMhlsN+QjHzTfzIIr +pKdzEdXCGJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCap8bjAAKCRAOJn5M7lND PXPMC/9xkqRLGYZ1vg0t6bsCK7x1Q5AHKkFpkXG4jrl8j0JxKUX65dDN9/mSjBGcYJlbs0L3yLy +uh+czRcVcojFWpr9ibBflRh8hK+Yqltc+7TMUxRmW8I7TRQRJSaJ9absc6WAksrlRYl7M9j27S M6TzcuUxPE3KjycLtSJHqy50e1yxpoE4Pt5gmt9rsYC3qbMSY8ZnNlMZABhzEjp5OtLJ144wY+/ QbaKDBF9BWccq8fPc4RMFtUN92DF1ajKcoFveWwRvNA7MwR5NLQUtZyf2SrZvBFrMtZM0IKpkpx N4chlfl3iZpJrwg0aSbgQP86cn1mVga1pUZKDiSpm1Yyi9C9qaBZMqHvAfUk8cT89GJJUm7VJzU 0Ttmxt7Lq+urlmmqlojMNhKSrDtP8bbLDuBrQFVMn04NaRynDNOSNoGwoGhZyFdhJkQQRM7Z6IT vTNphLb00qTsyQ5YNnLmMvo2g8XwKH3bmLZEgtgvvtbrgpXUJFTp1XXRmKKMIFAfDNmQ4= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Expose expanded PERFCNT_DUMP IOCTL interface to user mode. Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panf= rost/panfrost_drv.c index 571a26b84126..de9b1c115181 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -808,6 +808,7 @@ static const struct file_operations panfrost_drm_driver= _fops =3D { * - 1.6 - adds PANFROST_BO_MAP_WB, PANFROST_IOCTL_SYNC_BO, * PANFROST_IOCTL_QUERY_BO_INFO and * DRM_PANFROST_PARAM_SELECTED_COHERENCY + * - 1.7 - adds PERFCNT_DUMP req state field */ static const struct drm_driver panfrost_drm_driver =3D { .driver_features =3D DRIVER_RENDER | DRIVER_GEM | DRIVER_SYNCOBJ, @@ -820,7 +821,7 @@ static const struct drm_driver panfrost_drm_driver =3D { .name =3D "panfrost", .desc =3D "panfrost DRM", .major =3D 1, - .minor =3D 6, + .minor =3D 7, =20 .gem_create_object =3D panfrost_gem_create_object, .gem_prime_import =3D panfrost_gem_prime_import, --=20 2.55.0