From nobody Fri Sep 25 23:10:23 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 587744CB8D7 for ; Mon, 7 Sep 2026 14:00:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788789660; cv=none; b=CkDChXnI22GmOviZTUHiLGWaJ+OpWxk2nqU2AiHWzgkhrVwqTrPhrYBzS7XrBDHtspag+XgScMTbWiYsG5m3zrSBqroN4DzGFayLba1uJeRzxMzNJn96mBZd0XCI0xeusYfEG4T4KRwxUb06OS5MKEImUNhxay3VLp9Md+tYxfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788789660; c=relaxed/simple; bh=YAgyDv+00NlMfBI48daNj603uX3psSBnQCjEdKjLrPA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=t5iWYytpt5Zud4s0a1spjdAAMopDLV7zBH3iElU2yWRrQuyBf5mpRla70vcaVZ7iuCpiCdng7V27tjOErHAIcu4pjv7Xt1pyAt+PjXCmQ5/e8Arh1czLUd5w6ffXPHa1vAtfsxpg5eGQvZGEslHgmfsXiegZgtr7GfRXv4gX2Dc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thegoodpenguin.co.uk; spf=pass smtp.mailfrom=thegoodpenguin.co.uk; dkim=pass (2048-bit key) header.d=thegoodpenguin-co-uk.20251104.gappssmtp.com header.i=@thegoodpenguin-co-uk.20251104.gappssmtp.com header.b=hnbGhjgA; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thegoodpenguin.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thegoodpenguin.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thegoodpenguin-co-uk.20251104.gappssmtp.com header.i=@thegoodpenguin-co-uk.20251104.gappssmtp.com header.b="hnbGhjgA" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38a0c7e841fso4606040a91.2 for ; Mon, 07 Sep 2026 07:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thegoodpenguin-co-uk.20251104.gappssmtp.com; s=20251104; t=1788789658; x=1789394458; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=8jgbrYh5zlt6SCZ9hvN3S2HoSjS6tvqEiP9J6AFTYQc=; b=hnbGhjgAosB0wItaxrHtGbTy2pxBBcWH8dPPRf9L+iLoT8x2yOVmoWXlHPFg9dPqnc S9AorkE6zIrOpzUSFwcmFgK+Nhou5doJsatrOQYFB3UGP4YQmxYkdejBmghYLFw2URj5 W+pUqey2nB8M+YAdhhxflAuP2dm20+8iaD3P3Ful6jpCuXE4D408zhjBXyZi/S9Etx1G vQNfHxyNRWthbTbiWhDQA2HtYDKOQBrgPhXV9ShZOsqHAS2C7U8PYTpSsc2z0D/d7jQI sg1iNL7iSHIelRx9k6Nrauvk2mC+jP4TPTbjHLWKCzLYFLcPmdWxjR4Q6NEJ2aA83ipe amSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788789658; x=1789394458; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=8jgbrYh5zlt6SCZ9hvN3S2HoSjS6tvqEiP9J6AFTYQc=; b=BD5OeCh6qqZmQDJVlxVdzNIipYSL7aY+IQ9v06+1TQs045wLpC8H+sT40k8rdWrmE1 tNB9t1tP5p3JGAEzeqXM/tJxVyTseK4/opQ6D7lcbSCheZIcWueMWEF57C+jFTz3tZo5 1u8dArsWZmvG8wNUybk0nLloC8ms9CFdm/2s2aNk3CkRvuwEEu4t8IRtU/43ZK0aArWS 901piyYdsJDrbobnsfTsYzvQZWo3k+2mXycUcFcGWkjJLxT1wcns5oP8mHTqDt9uT5Et qVHfkgHqY24E/0Spt2HTOzCEFv1axWadxBwMLQ7Ip4S7xYBP8K3wenja1NAmh5Lj3NyI 084w== X-Forwarded-Encrypted: i=1; AKwUvBwVCwYB71saieojD8WpyvNQVkjP+EThthfKOCNeFR8z8KXBftMyF+c2EZaWxMeIzbgSRBAY10CC+mhC6ck=@vger.kernel.org X-Gm-Message-State: AFuF++nXxX+7iNsd6ghu8erEYyKrzlQVBim5//voo442FNugJuZ/BPFp H1UuGNehtF4DtZO9ILu3ru3TUnvD34VMVG+4C6OEUFlTLVJHTYEEYxxUENWaorUnG+8= X-Gm-Gg: AYBFou2UhQQDBqaBF/UQc2TmoKxzuw9VEulcpnq2yw1Ye84teyyXg3rt1V8HzL1rrAb rTfqMcvvVpyO7cA6FFVZpRk4qDEDrB4anfjcYw+ah4W82WynnyHBuKdPuepbNhaQvuIlZlZMgam 2qj0hRnZrPqMGma9XhYhC0ELoR6GRsyzZnWtKFQxSD+Mpb3y0g8smgYglf7T7E36KQSOS6Mf8AM 2w/NbliPt7qg8B2zOgXvT8pGq4YOMJHqgo2lTzuf53KF30iqChkQmiRQuLbdk2D/w3Ho4DscoZ/ 2rJPFCRur5WIsxD6ujl2x9p85QWWQ08LoYS+jnS+9xpqTk8fII+qrUsIda/ML3fntc/PpOs8NfK GOK4rgUu5a06V5TOXRXzCuINlQpZQVj6UaBxWaHFIH3Ed8WSjNkMmJSptXkZFUnV46c0sT/ebA0 B7FbNIEh1qO165o2KGzfVFydVYXYGbrth4dKWdr05vC4xEjVD96s9GuH26i4+nFjW492DXoSgji k062Uc= X-Received: by 2002:a17:90b:5344:b0:38e:4f41:83df with SMTP id 98e67ed59e1d1-39b261e0f14mr35201195a91.15.1788789657257; Mon, 07 Sep 2026 07:00:57 -0700 (PDT) Received: from [10.42.0.1] ([2a00:23c7:1d1a:9c01:9f74:2a4b:1c38:e2d8]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-336c2571039sm10083615eec.25.2026.09.07.07.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 07:00:56 -0700 (PDT) From: Pawel Zalewski Date: Mon, 07 Sep 2026 15:00:45 +0100 Subject: [PATCH v2] firmware: coreboot: use named initializers for acpi_device_id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-acpi-firmware-v2-1-e0b6d40823d1@thegoodpenguin.co.uk> X-B4-Tracking: v=1; b=H4sIAIzDnmoC/3WNQQ6CMBBFr0JmbUlLUKgr72FYjO0Ao7ElLaCG9 O4Crl2+5P33F4gUmCKcswUCzRzZuxWKQwamR9eRYLsyFLI4SS1LgWZg0XJ4vjCQOBrdWlUjEkp YN0Oglt9779r8OE63O5lxi2xGz3H04bMfzmrz/rVnJZSoqLQVSq10TZexp857O5DrJna58fn0g Cal9AV/witwxwAAAA== X-Change-ID: 20260904-acpi-firmware-5c9fd18aaea0 To: Tzung-Bi Shih , Brian Norris , Julius Werner Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, Pawel Zalewski X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788789655; l=3008; i=pzalewski@thegoodpenguin.co.uk; s=20260430; h=from:subject:message-id; bh=YAgyDv+00NlMfBI48daNj603uX3psSBnQCjEdKjLrPA=; b=WHNy1rFomYD3aDjsNKbv4C8y+mqAIrV++jJIFNpZpRsZA6nBoQEoc5ZSNVO7kLakMzw2WrA97 idrqAzO5HtbBoxxRFUafh3XamGIZJjkelaQDBxhMHTnXNEnrc6sXMKw X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=vHq4n9IonORH2GTzLv8r6CWAFHzgfBuNkQPXA8NSly0= Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base. Also drop explicitly setting fields to 0 where it is redundant. Signed-off-by: Pawel Zalewski --- This series is converting lists that contain the acpi_device_id=20 struct, which is defined in the include/linux/device-id/acpi.h=20 to make use of named initializers (which they do not use currently). This work is part of the on going effort in the kernel associated with device-ids [1] The plan is to convert acpi_device_id::driver_data to have an=20 anonymous union, similarly to what was introduced for PCI and I2C device ID tables.The goal is to increase type-safety (as most of=20 the existing casts are gone), to improve readability and to make use intent a bit more clear: ``` union { kernel_ulong_t driver_data; const void *driver_data_ptr; } ``` But for that to work all lists containing the structs need to=20 use named initializers first to avoid triggering -Wmissing-braces. I already have patches that implement this and touching a lot of kernel subsystmes that use the acpi_device_id struct and that list keeps on growing. Therefore, I have decided to split the series per every subsystem into: - pre-clean-ups that convert the lists to use named initializers (which is this series) - actual implementations that make some of the modules use the driver_data_ptr union member That way the task can be fragmented into manageable and independent chunks of work and makes this effort easier to review. Tested builds on a64 in Yocto using 7.3-rc1. [1] https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylib= re.com/ --- Changes in v2: - Rebased on linux-next - Link to v1: https://patch.msgid.link/20260904-acpi-firmware-v1-1-7e4d7a09= 198e@thegoodpenguin.co.uk To: Tzung-Bi Shih To: Brian Norris To: Julius Werner Cc: chrome-platform@lists.linux.dev Cc: linux-kernel@vger.kernel.org --- drivers/firmware/coreboot/coreboot_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/coreboot/coreboot_table.c b/drivers/firmware/= coreboot/coreboot_table.c index 25ee8cf53429..2c8c928fbb33 100644 --- a/drivers/firmware/coreboot/coreboot_table.c +++ b/drivers/firmware/coreboot/coreboot_table.c @@ -250,8 +250,8 @@ static void coreboot_table_remove(struct platform_devic= e *pdev) =20 #ifdef CONFIG_ACPI static const struct acpi_device_id cros_coreboot_acpi_match[] =3D { - { "GOOGCB00", 0 }, - { "BOOT0000", 0 }, + { .id =3D "GOOGCB00" }, + { .id =3D "BOOT0000" }, { } }; MODULE_DEVICE_TABLE(acpi, cros_coreboot_acpi_match); --- base-commit: af5f12805e5cefa4fe68d6127c7e1fb78cd5535c change-id: 20260904-acpi-firmware-5c9fd18aaea0 Best regards, -- =20 Pawel Zalewski