From nobody Sat Sep 26 01:52:47 2026 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012000.outbound.protection.outlook.com [40.107.200.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A5EA274B53; Sun, 6 Sep 2026 07:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788678894; cv=fail; b=u/MeeikWqVMKpJ+dkpTZAhZj8rf+kvLVgcAqmTo6Zr3UNCpXVT6DUuZdwHbn/tA9R63NjcYR4zynxR4VHV7SMyYw6ykLhbZWAJOMm817/udWUa357Ou/hsoGQIEhvRyVD0W0BSD0AiiHg/CXebCIv1VPMmXittU11Xx1JwRCP24= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788678894; c=relaxed/simple; bh=WUPBzc492uG9+j7vEXXgn1tpb5MTuRb8hcbCwhyFmc8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pQcCV8s2h15Nlbx0iZ+GKWxx0+jQPKfAyaZPfPKhxDrhKnMY7ilVdZiJDb6BonEUnQUzKHhj2587sW2EDodl7rR8K0Z10MtUIwA4D4TLPbrC3Iv29fNV6KNl4vSCGeN1s7V2S7R4uZYOjxwwsg9gpVNpl+/1eKksCvZF8rgMt5o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qsmwu6PU; arc=fail smtp.client-ip=40.107.200.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qsmwu6PU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O6zo7xX8q02Ok154F0YjsiPsafk3li0NDnWhxxNWl5CkNQmVB0RiyQmrO4XVNoIT3dk4BE7g2TEWIE2RxsvBS6xni1pZstkRNYSl/LpRcCr+M15/rixoz4vPx5AEWc0l5FpugdxaUoRHg9AnWTdak+vkhlTkZXJbYb2QkpdKlrpIyjZlEUGn+BDNS3dea9mcwfsa/jPXOi1n1Pqsd7Q/B5FYRDKxlLjKtSvgddQSDRhwR8ExXj2uKm6qB0Ium7fM1KbATdtK4fX40MxkSAggIGcVROnTVhly7tXJ3OB7MWyEUdi1ZQkCsSh4TrvsoQ/pl3dQaAC2a+7Xrfw9G+cmqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L3451Uc0B9byiYsKzdzGLih+2AfWg2zpoEJlXdDj+pQ=; b=fXJmpFEqlUmsvGp+ce+LbUvJ2Doa/9f7nIfSM2LpTz7ifuVDznNyas3mH4C7RNelbjFu+U86IJxUO5Rh59NnhqncjhS/mJ/Km/eDO20VK/fgd2IKjtz4s+8Xx34itR0EGVAqQjjXUCrb1E6oEEj1Q7Q6XkTaXgcoWrde8ifGypaiHsy2GHRWZs9179OQjrmbBDbuZj1KjqRTXIZf30tJPQdqlZpozTijoKeKT3i/PRjOCGVQvoZFmHhgIug2ySylAuEs1I9Ham4ARirSciRlcYp4R1tvTFm746WBlQUKhK4JjpKkdeXeIE6nVizSr83OYCyyXaX71u0FHeprFutHqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L3451Uc0B9byiYsKzdzGLih+2AfWg2zpoEJlXdDj+pQ=; b=qsmwu6PULbB91oJz7yNY1ck1aVvf8gtcQtp7jgglyAWNCvuUgV6IXCMsP87JPnhfqQdGF1QHAFpKs7ev8aFwjHOBOs4Mz7MHN0u1MJStSQ6A1pR7R5HUUlzg4dNUTL8vGIa0cxS/uEn5fTgBiNXqBngM7ha53q6s/6wUeuOMU4I1/YF2f2yhuPBiFlC8WvQoWGpJBFXOQeoYyMnNUken2x7Chv463gEqCvRU+9G42IHgkZmAHonCE06Il8yZEc4lDLcC5rodQ+DQKnbXTfrO2ydQ65Mpz76At8dFO//2tJXDxpc/ChnZxjaWgVTnglZJPYoSbmqYkxlrqpU/1wj8Nw== Received: from SA0PR11CA0160.namprd11.prod.outlook.com (2603:10b6:806:1bb::15) by DS2PR12MB9664.namprd12.prod.outlook.com (2603:10b6:8:27b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Sun, 6 Sep 2026 07:14:47 +0000 Received: from SN1PEPF0002BA4D.namprd03.prod.outlook.com (2603:10b6:806:1bb:cafe::79) by SA0PR11CA0160.outlook.office365.com (2603:10b6:806:1bb::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Sun, 6 Sep 2026 07:14:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002BA4D.mail.protection.outlook.com (10.167.242.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Sun, 6 Sep 2026 07:14:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 6 Sep 2026 00:14:29 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 6 Sep 2026 00:14:28 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Sun, 6 Sep 2026 00:14:23 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Edward Srouji , Gal Pressman , Kees Cook , Leon Romanovsky , , , Maher Sanalla , Mark Bloch , Or Har-Toov , Parav Pandit , Patrisious Haddad , Saeed Mahameed , Shay Drori , Simon Horman , Tariq Toukan Subject: [PATCH net V2 1/4] net/mlx5: SD, serialize SD LAG init/cleanup against LAG mode changes Date: Sun, 6 Sep 2026 10:13:29 +0300 Message-ID: <20260906071332.3759199-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260906071332.3759199-1-tariqt@nvidia.com> References: <20260906071332.3759199-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4D:EE_|DS2PR12MB9664:EE_ X-MS-Office365-Filtering-Correlation-Id: e469592f-bb64-4a3b-a730-08df0be6880f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|36860700016|1800799024|376014|82310400026|23010399003|6133799003|10067099003|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: wSfod2dIS0xjKcl6+RAcSZDEl4yRrNKVwCBiN+CXX5fO+dlb+b7Q/5cmcZNDy8n9nhrTWSK4mPLO4W4wUupof0d3n4zAsgm6PpDwFTN4yDvi/pnDYhWjbpQr1MVYeGfpMVsF8PwK43v/MXqlABQnOi92wOFDR7zB6vv4QgHcj2L84SkepSizIxNqQ8t3q4chQTU7xROUh3caYbjYf0c4MDtOW8jvvUMLK9JHwTJ9UivO/Zr4jx9Xv88pL9OhZ8AHfev/vySX5smu2fPyBFHAYIzGNiANP8cmlX0fNX3dq9JUnO9QNxfWTd+bAU1Our+EJHcvUdMaHaRjmmjqWLUnTUtsBGRCXlt3uff4nrWDP0rOcZiP4lF1G81bkJq+bS55kNPrwM/KZ5ZtWnxGQZ9AkVwq7no9L1kU/NQBy0UdmQjwT32iN/UbQlzzkThy/ZiF29/EDwRM/7GN6VzECoUJC8ZIPJ/u4MIItWsua1ag/gGlcX2bVoYS2L1XlZ84xW/5qsPEVh5L9oYWpYzGNZHYxriW5o6s5Nxxf6DWsGNfKhkoFdrf5xyXqyqXFRRC4DIZ+wtRGwirFzz5sHaTrDM89egyOpJ1tCHcfVZi40y2DX8/Aekc8yP1YA+WSclIatTnAXifubnjjChNeQwl96mYoyLyReaLEtb7ZYMrPqE+tsM8c1O0pvUXtJfpWJWceczvEW7XRwWKtX5RzXRibMzhlQ== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(36860700016)(1800799024)(376014)(82310400026)(23010399003)(6133799003)(10067099003)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: u30u+kH2zRG46O8DLhqBhBOy/CPMONcBux48OO7JHhIGRLjMyJI7CYthK1jidbPU7Ua1r3Sie0KxD9nTgeMeUZueuu2wHXWILrVERvJmk9oIg5scnQvK8hR6W4VzDnuEfqGK+4MTFf4iUMjONzA0dG3D0FuxwClGvR5Gn0DJtAyFXzjlhYiIOMbpgYnxjN9gjGLpBwRS1j5q7Mv76d829K7EKcOMG1RKj3IAMmIkmWpjO0WILqMubpbH5hf2dETttMUsvWk01NAo6tTcXSo6ZQQdmVgQbS99zuUUMQ8CUMN93vmQnaY6kGdtjoNUEpGrgAU85NmgjG6Xmc0bMCzZz8x/Zg6k9QBE1U6GR1ikUY2tAnqgagCR1jW4EEZkJoqajOj42jQ6WKBLVTzmgnTgB8NgbrAbRN7cMc2fuO44kLjkiD1mT+efKkao7aj4Gvam X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2026 07:14:46.1597 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e469592f-bb64-4a3b-a730-08df0be6880f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4D.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9664 Content-Type: text/plain; charset="utf-8" From: Shay Drory A secondary SD is spliced into the primary's shared LAG device (ldev) by sd_lag_init() and removed by sd_lag_cleanup(). The LAG mode-change paths drop ldev->lock mid-operation while iterating ldev->pfs, and rely on ldev->mode_changes_in_progress to keep the member set stable across that window. sd_lag_cleanup() did not honor ldev->mode_changes_in_progress. Which means a concurrent SD teardown could xa_erase() and kfree() a pf out of ldev->pfs during a mode change's dropped-lock window, leading to a NULL/use-after-free dereference of the secondary pf. Make sd_lag_init() and sd_lag_cleanup() wait until mode_changes_in_progress drops to zero before touching ldev, mirroring mlx5_lag_remove_mdev(). In addition, fold the SD shared-FDB teardown in mlx5_lag_disable_change() into the main locked section. Otherwise the two acquire sd_devcom and mode_changes_in_progress in opposite orders - sd_lag_init/cleanup takes sd_devcom then waits on mode_changes_in_progress, while disable_change increments mode_changes_in_progress then takes sd_devcom - an ABBA deadlock. The same ABBA deadlock is present in mlx5_eswitch_disable(), which takes sd_devcom between mlx5_lag_disable_change() and mlx5_lag_enable_change(). Move that call after mlx5_lag_enable_change(), matching the ordering already used by mlx5_devlink_eswitch_mode_set(). Fixes: 3c103110835d ("net/mlx5: SD, introduce Socket Direct LAG") Signed-off-by: Shay Drory Reviewed-by: Akiva Goldberger Signed-off-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +- .../net/ethernet/mellanox/mlx5/core/lag/lag.c | 30 +++++++++---------- .../net/ethernet/mellanox/mlx5/core/lib/sd.c | 13 ++++++++ 3 files changed, 28 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/eswitch.c index b6e2c153b4f7..50e158b6a684 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c @@ -2062,8 +2062,8 @@ void mlx5_eswitch_disable(struct mlx5_eswitch *esw) mlx5_esw_reps_unblock(esw); =20 esw->mode =3D MLX5_ESWITCH_LEGACY; - mlx5_sd_eswitch_mode_set(esw->dev, MLX5_ESWITCH_LEGACY); mlx5_lag_enable_change(esw->dev); + mlx5_sd_eswitch_mode_set(esw->dev, MLX5_ESWITCH_LEGACY); } =20 static int mlx5_esw_sf_max_pf_functions(struct mlx5_core_dev *dev, diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/lag/lag.c index 2285c889c215..aee5ce471eba 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c @@ -2589,6 +2589,8 @@ void mlx5_lag_disable_change(struct mlx5_core_dev *de= v) mpesw =3D ldev->mode =3D=3D MLX5_LAG_MODE_MPESW; if (mpesw) mlx5_mpesw_sd_devcoms_lock(ldev); + else if (sd_devcom) + mlx5_devcom_comp_lock(sd_devcom); mutex_lock(&ldev->lock); =20 ldev->mode_changes_in_progress++; @@ -2599,26 +2601,22 @@ void mlx5_lag_disable_change(struct mlx5_core_dev *= dev) mlx5_disable_lag(ldev); } =20 + if (sd_devcom) { + mlx5_lag_for_each(i, 0, ldev, MLX5_LAG_FILTER_ALL) { + pf =3D mlx5_lag_pf(ldev, i); + if (pf->dev =3D=3D dev && pf->sd_fdb_active) { + mlx5_lag_shared_fdb_destroy(ldev, pf->group_id); + break; + } + } + } + mutex_unlock(&ldev->lock); if (mpesw) mlx5_mpesw_sd_devcoms_unlock(ldev); + else if (sd_devcom) + mlx5_devcom_comp_unlock(sd_devcom); mlx5_devcom_comp_unlock(primary->priv.hca_devcom_comp); - - if (!sd_devcom) - return; - - /* Teardown SD shared FDB for this device's group if active */ - mlx5_devcom_comp_lock(sd_devcom); - mutex_lock(&ldev->lock); - mlx5_lag_for_each(i, 0, ldev, MLX5_LAG_FILTER_ALL) { - pf =3D mlx5_lag_pf(ldev, i); - if (pf->dev =3D=3D dev && pf->sd_fdb_active) { - mlx5_lag_shared_fdb_destroy(ldev, pf->group_id); - break; - } - } - mutex_unlock(&ldev->lock); - mlx5_devcom_comp_unlock(sd_devcom); } =20 void mlx5_lag_enable_change(struct mlx5_core_dev *dev) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c b/drivers/net= /ethernet/mellanox/mlx5/core/lib/sd.c index 4cdc50cd6f03..99cf455a61e1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c @@ -345,7 +345,14 @@ static void sd_lag_init(struct mlx5_core_dev *dev) return; } =20 +recheck: mutex_lock(&ldev->lock); + if (ldev->mode_changes_in_progress) { + mutex_unlock(&ldev->lock); + msleep(100); + goto recheck; + } + pf =3D mlx5_lag_pf_by_dev(ldev, primary); if (!pf) { sd_warn(primary, "%s: primary not registered in ldev, skipping\n", @@ -388,7 +395,13 @@ static void sd_lag_cleanup(struct mlx5_core_dev *dev) if (!ldev) return; =20 +recheck: mutex_lock(&ldev->lock); + if (ldev->mode_changes_in_progress) { + mutex_unlock(&ldev->lock); + msleep(100); + goto recheck; + } mlx5_sd_for_each_secondary(i, primary, pos) mlx5_ldev_remove_mdev(ldev, pos); =20 --=20 2.44.0 From nobody Sat Sep 26 01:52:47 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011061.outbound.protection.outlook.com [40.93.194.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0191B274B53; Sun, 6 Sep 2026 07:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788678900; cv=fail; b=tpclbUfr8oiOWooqNzAL23QYxab8mMRG3Q19QIDAVoK0us6fKxM7m0t+d+pMWtIw4o8I4LOiMaeGZBqALr6prE+efcIyDZMES+/cj5yJGOJcyiusesRs9PMr5wXAuPt5hZVErErhwDeXLEs5PBENW5ho+TR6mTFj0x7B8KgfdBs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788678900; c=relaxed/simple; bh=ylClRsC5Sp3zN8Xd30lUqPW5XbERBmGZJNIlTP2CrQM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GgmWy7ZXMwDEcgSgHgFx1XyEmh+8rbJJGIFYLZ85R5wMgtiVFRepzQU4WYuqNHEsRcM1ZnLzG0vTI4YyUgSLtdvzfuw/PmcAMUK9L2VGGF22UIwQsU9t5a3zoRInSiNl1EAZS0+prV6QsjCrG8r2wy0UJc+f9wppr2oepUs7g/g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=B6exEYPI; arc=fail smtp.client-ip=40.93.194.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="B6exEYPI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y6r1Toj0+0Ui5L5XLYNWvkIHgV0f22DTb5KIXims4zepsF5m1VUACBVxtAhBUxnUdxl9zib7gx8mIJGxCcTBRrePnKqlWiI2hLSyClx27iNyj1HGcXge+Yd2g/82JzlY35AibaxcSV+JQwHtpRBCL4p6dCb+3sb0p6eOEj/QURj2bdrBjrjBAVQaa2ljTit8NDmpeWz9l6sb55xyXuvdeD4KP8+ltbgJosSQVFHi83kFqABbW8IRyZHC52KyCU/iqv12eCTiO2UTqQgLMZVEMK0pWmq0LAFf+DhlnuYZ7k8b8btANKdRtg3ejfJh7xWMH+kw4z4bMxNFMwDalfMCiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=60O3CEEx81ew4Yc1qsDRTpiNdTdgDRQPRJY4e24VZtw=; b=NWfedMiL14LVuU19V0HvH3dFB1QRbJfTRQJHHHtlgoyZMxqZPneicBwTrUR5Q+OHLshes2k6m2QQ6KYgRGoiSHDHnulCfSQ+figvqt1K8V1aTW+P4y9U7r2HrKgWQz6b5OqAayHlEs2ajyE5kZQw0abDulJSb/LX8KUSOOWkkvIWFD+/KF5wKA/lnpivqJ9DeurZS7M1RJN9wMPomBHPN20BjMiQTdzhngjquZ6hr1ZSeWEyZydv4aoJL/LQwGKc2iQI+M8vsk+2U+BL/ZF0UliU76m8bY/ADU3ywY3iYYp+UFLRLQp6VrvGgmgCAPPsIoG+JHuQeBTFB9hhLlEmTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=60O3CEEx81ew4Yc1qsDRTpiNdTdgDRQPRJY4e24VZtw=; b=B6exEYPIDy838aJjfMn5Aqknc5LAIfJQ/5CcI9svjciwvUGqDMe56Y61uzBDkc5hVubfOZlypfgJm20N0GeNfcTXBt2YdMfXnufq13qtCurxrNNdLJoEf+9eVt13QYdqEItEGk6ROOinC++MhdSaDFzubkCe1aIySvw4SBh7L4olL6irBD+WGgIa5F1hOBSk9knFCot9cZh4EnpoDt4ne0cLoxYRfdTLBgLYu8R3P8JqgsKsiAUql+7yiXNexEhItsxVV7r9exEMVwFaM4u49A67igEVPtPsu3XByArmYKK31SpFSC/O42uROuEOKf7qc5cxiyqRSYFm1LPCxwAQqg== Received: from DM6PR02CA0111.namprd02.prod.outlook.com (2603:10b6:5:1b4::13) by SJ0PR12MB7474.namprd12.prod.outlook.com (2603:10b6:a03:48d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.13; Sun, 6 Sep 2026 07:14:54 +0000 Received: from SN1PEPF0002BA4E.namprd03.prod.outlook.com (2603:10b6:5:1b4:cafe::36) by DM6PR02CA0111.outlook.office365.com (2603:10b6:5:1b4::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Sun, 6 Sep 2026 07:14:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002BA4E.mail.protection.outlook.com (10.167.242.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Sun, 6 Sep 2026 07:14:51 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 6 Sep 2026 00:14:34 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 6 Sep 2026 00:14:34 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Sun, 6 Sep 2026 00:14:28 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Edward Srouji , Gal Pressman , Kees Cook , Leon Romanovsky , , , Maher Sanalla , Mark Bloch , Or Har-Toov , Parav Pandit , Patrisious Haddad , Saeed Mahameed , Shay Drori , Simon Horman , Tariq Toukan Subject: [PATCH net V2 2/4] net/mlx5: devcom, Base component size on linked devices Date: Sun, 6 Sep 2026 10:13:30 +0300 Message-ID: <20260906071332.3759199-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260906071332.3759199-1-tariqt@nvidia.com> References: <20260906071332.3759199-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4E:EE_|SJ0PR12MB7474:EE_ X-MS-Office365-Filtering-Correlation-Id: 39294668-560a-4559-bcdd-08df0be68b31 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|36860700016|1800799024|82310400026|376014|10067099003|22082099003|18002099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: 6xKsY92Klj21g9H6B3kclVfAdPIokrwsH93aHWuqdG0HISdfKl7KEMDDDGkA8ELd+gkTEEjapfx/NdQum1WQekeUcYGZO8tbOAUPc3bbRRkzgnjKJ0BxyqqsJ9OusrF5C7oKkmkMCUw2Dw+FOOYDrwKxKWECZ/qGyGs7LXAWE/DEumkBSZZaOfgLRAEXVpeC3MORQj0FgkXanXy1CuGMGlTHnPEx92xFlKK2C5oqqB9EceXsmumCjCgXVDjaRGUP3eUpsaaVSFlvo9QLk27b451qKXp43pBL7vS5ZXSBHJvmjeEBMH+CTOVc+svJpp35G5jrImKdzE6DsxsMLDgx/61uHedczlYnC5Pwg9Dr+jcf3UsU/21wAhQoz/HNaMfyvzLz8RHxfqymG5WvlGeohGt7SpQ0bwk6UjqERitU5qKQPFv71i5f0sNttrX0u+8lZ6lqzYwKuAU/zVwrB0XzpdCHCZwJFnRjlXrQw877CMmFeKKruccTgYasCv4aoOtSzPPqjjENYPoHBb23FqAZzv1S8aNGsmGo3zlwu8ZWNKVv6Sf5i+rh/S519YlwUQsv2UPY6VL1i3SljkUAIArMvxchW86tdEpVdipU7BaSPPoeN64IPg4+IB9hPPZ7cAUTZVFIBUBg/VydXxdTH8my0a2G4uqP6Vdgn3D9dSu+xzcqhUHoJtIVlCf91/1YEL0BS0HXCx2FxZZpaDtbeYU3Nw== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(36860700016)(1800799024)(82310400026)(376014)(10067099003)(22082099003)(18002099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KviJNB7evNulrQWzL3yUFDmnzoC9aIEPzOQAaxwv/BdqWcLAv5nYEzqgrewbgG5FR0W8sgXDgNLh6WMA6Bx1CI8kTNryf9OtgbS4wf/4vO1QlJ8StcTDuG0dnfX5XAx+0xOE6p3i9LSlGgq7Vq7SeBmtTsjOK7VxFROhUIYcgSQ60QrVOcT5QVK8o4c6oupuvKBBTPPIBoj5ON9GWNaJaH2/DiuYfB+ymVWEvfzXZxUC+SfK/r7waTjzZ7lZSjfeinXmqV9z23lv2alYM2bWsEV4FxoNsj+r+wnEk9lASluoHb/+OELpuf/rTdg2YNrJKLqlKiwSt++rSZqOSxArevtOZCMUsKNP1eCYwUzKcrbXdzBgA5PdoMprTs3AHXxZiZ12J+DbjA4mTmkTAmr4XnZbQGowr8nxDIxuEONI762V+Djphulcyd8n69SWSTjz X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2026 07:14:51.4231 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39294668-560a-4559-bcdd-08df0be68b31 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7474 Content-Type: text/plain; charset="utf-8" From: Shay Drory mlx5_devcom_comp_get_size() returns the component's kref count. That kref is bumped in mlx5_devcom_register_component() under comp_list_lock, before the comp_dev is linked onto comp_dev_list_head under comp->sem. The event broadcast (mlx5_devcom_locked_send_event()) walks that list. Hence, a caller can read the expected size, but send_event won't be sent to all peers. In the SD group registration path, this lets a member broadcast its role-election event over an incomplete list, electing a primary that never completes the group, is never marked ready, and leaves the group with a stale primary. Track the number of linked comp_devs in a dedicated counter, maintained under comp->sem together with the list add/remove, and return it from mlx5_devcom_comp_get_size(). Fixes: 9bb1ac80738a ("net/mlx5: devcom, Add component size getter") Signed-off-by: Shay Drory Reviewed-by: Akiva Goldberger Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c b/drivers= /net/ethernet/mellanox/mlx5/core/lib/devcom.c index 64f92427602d..75855481522b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c @@ -37,6 +37,7 @@ struct mlx5_devcom_comp { struct mlx5_devcom_key key; mlx5_devcom_event_handler_t handler; struct kref ref; + int nr_devs; bool ready; struct rw_semaphore sem; struct lock_class_key lock_key; @@ -170,6 +171,7 @@ devcom_alloc_comp_dev(struct mlx5_devcom_dev *devc, =20 down_write(&comp->sem); list_add_tail(&devcom->list, &comp->comp_dev_list_head); + WRITE_ONCE(comp->nr_devs, comp->nr_devs + 1); up_write(&comp->sem); =20 return devcom; @@ -182,6 +184,7 @@ devcom_free_comp_dev(struct mlx5_devcom_comp_dev *devco= m) =20 down_write(&comp->sem); list_del(&devcom->list); + WRITE_ONCE(comp->nr_devs, comp->nr_devs - 1); up_write(&comp->sem); =20 kref_put(&devcom->devc->ref, mlx5_devcom_dev_release); @@ -284,7 +287,7 @@ int mlx5_devcom_comp_get_size(struct mlx5_devcom_comp_d= ev *devcom) { struct mlx5_devcom_comp *comp =3D devcom->comp; =20 - return kref_read(&comp->ref); + return READ_ONCE(comp->nr_devs); } =20 int mlx5_devcom_locked_send_event(struct mlx5_devcom_comp_dev *devcom, --=20 2.44.0 From nobody Sat Sep 26 01:52:47 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010052.outbound.protection.outlook.com [52.101.201.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F9F3382F0F; Sun, 6 Sep 2026 07:14:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788678900; cv=fail; b=L29qYYMcFXTRpEvpTLUPYDgwIAhcJahd/53HD2b8Hp0Zf3oTFSOWXlVg/W7v9B6cBj11SLopD8O0cr1cBTwyamrc9G48vLtYSVcG5EuVL369C9rPMrJamqCJ4NyFlQxzNVgpH8HzAHMdM2dnMrprVQQ4L7c5aGxhY3b5hNoIv/Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788678900; c=relaxed/simple; bh=3C43RGCoijl5pSO+jK9JjwUAhH2khtERvFURnNA+q5U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RieU5Gt9b52cHsgoJIRKQApUUcvYxFt6oLOhEqMcIcssF7CqzVJF0MxeFq5YvRs4W5F8ZC3eY/yl7rbF8tb7ZLwHw9IHc6N+gF4OlziPe3onfdVMUIciB/sUOsm+p8O8sFe1wp73K2LUh+eIPhZq9FJkU9cidC8HJHWMj8BvXAg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=bpVhBsXa; arc=fail smtp.client-ip=52.101.201.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="bpVhBsXa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kPwVMAtgRnMgMTFJ53aw72gfzuVNXWU2L840OjEVP4je/MwZGn1NbhoFTxOgQXjW5cGgizfHEx2Bq0XZyGulEjGdBbTj3lm+yHdCaVKHrhBU18L1hVIGCdPfM0RGlH8fuhXgQsguDU3oItTOPOPG8+CZaFvzuHXa8RKEzwi//frTrsUq2b5uzODrf2YWuFS+mKypBYV6dQyuCTyOL2ZNnBbaET9YBZDW0HvGNVqgyvbj1wlSEzibQlklBIW70bCAzKk5U8YRHuycaLrKOcghQ5y9Fj6egn1FUbv2UTu9hQfCjhYL+7gJSqT4l+aCL//TZl+xxzAJHAwCyQGZgWHE5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Ys6udKrioHTsVwcyOTFWipQwoGwGZY6EuzE+v/TWBc=; b=lpALhcmjIn9TgerjMDCaumE+y8Bqyys3s4Dl5bFmBysHomJNYyuOHDZZExctWCuBnkY/6295BdopXXXLT3rNNs6LnqlksV4YK2LkeJfG+ORznwTXQSCeMl2htk4u63GoeZ6WQb/H+esTS+g5OKbthnjB131S4RucKrGONeNjWtr+iNoD3WlCzDRhCJ5cIIlPx5jF7Oz7vBe5zSft0JUzqRjFe6PPH9LMrrXR+m/96HO0yjC9nyf6DzlPYKilAphPRZ3urJDWFySt5f7klzVprzYXFEJ3alxT4Jgnw84ehs3wwx7YX7AmyDZFez/D8pmWVsez5IenXA0SP1aZ85vUdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Ys6udKrioHTsVwcyOTFWipQwoGwGZY6EuzE+v/TWBc=; b=bpVhBsXaMFI+pLksGA3mt6QT0jEXTjlqdDTiO3Q8lXBeVXEr8iqmeJMgfAB30gxZEw9Re+vRUWk03ZmXEr/p/Aq8eYjj3a8rTiDFP1J3d+PCpx7fCI+kLaB2Vr1lMhxAF8gH1ELA9u7NXO0W5zls5tO+QMtwYELdgNRtx4nMo7nbd2A2AC+vHZKE3H2yIv47w/GzwIm8FVIxi2OiKNf7VDCr8p2104icAInH/dMCFdoqi6llsOLSL8ES8lOTXZ9k4XlI4xvQjwAxo+6rSqNEsRC8DhXz2V9ZSB7+JIrMnBvSaYuSIOxyPlfkHsCyjgFszUlAG3jEFY9mCZm8F8tMzQ== Received: from DM6PR02CA0131.namprd02.prod.outlook.com (2603:10b6:5:1b4::33) by SJ2PR12MB8883.namprd12.prod.outlook.com (2603:10b6:a03:538::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.8; Sun, 6 Sep 2026 07:14:56 +0000 Received: from SN1PEPF0002BA4E.namprd03.prod.outlook.com (2603:10b6:5:1b4:cafe::af) by DM6PR02CA0131.outlook.office365.com (2603:10b6:5:1b4::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Sun, 6 Sep 2026 07:14:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002BA4E.mail.protection.outlook.com (10.167.242.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Sun, 6 Sep 2026 07:14:55 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 6 Sep 2026 00:14:40 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 6 Sep 2026 00:14:39 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Sun, 6 Sep 2026 00:14:34 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Edward Srouji , Gal Pressman , Kees Cook , Leon Romanovsky , , , Maher Sanalla , Mark Bloch , Or Har-Toov , Parav Pandit , Patrisious Haddad , Saeed Mahameed , Shay Drori , Simon Horman , Tariq Toukan Subject: [PATCH net V2 3/4] net/mlx5: SD, unload reps on shared FDB create error path Date: Sun, 6 Sep 2026 10:13:31 +0300 Message-ID: <20260906071332.3759199-4-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260906071332.3759199-1-tariqt@nvidia.com> References: <20260906071332.3759199-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4E:EE_|SJ2PR12MB8883:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c1c0b4a-b982-4ba4-fa45-08df0be68daf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|23010399003|36860700016|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: fZrlc3EpRHoOzy5TK8ixn9V63mXwJ7P0AnTaegRO6mA02sQqvmGDDMI2m8IjoC/9xpHqKwiJR2K+v/wOmmhfXg724HydGepA6jckr140nwGuk+ylLcoerbErippOIj4KDUg3IOTLtAsgV9Q2nkTWp3yvoEJTN7KKe7u/7b3bZyKNXIlrCF1nNGfh9oKKDjMOGMWccZ6PQknskzA1Rz6OevLAZM0zGCouzv8+B7rfAPDmW6eqcveWgAKLnxZbUpFgxvVGJ1d9VFTGAPJiHru/+NwxbIOV/pEDYR6UVWPxDqpRaqLGMXS31NSFrhLbZqgmk9qMlUGN58oeHMlsc5pKiqDJIbeNCmuWvEtg0FJArExrKXCzkMNvlWvd6Ehtw5OXvTGI7RMXAPArZTg3F07erqn29PR5NEWoxGzsr1LfKtBE6V3epNreOoHJJZoiVWFf+lfIbPRj0LdTkFfWVqM0YYKC9Jx9vZaxioDP/WywaBdZQbZqngsJojfXmYXyLGbJu8L+ZD04SKyZdWCERd01BIkQEazYMvLbEV29z+grap0PUihXQB6KpKbB1yWYhtD+pU9vO8TasqsN1RJWr7rIhIbWL5eQK8LvEUMhniCEuGDNHjRNwueW6/xc6TIZ+4va3ALE6KtrxC6OWkTsi+xDBLIQw6CSyCiyfxN6VCNpI22J8I1mnvn7xEghDVKrZZKAuNw78EWUoHISS0WNCAtIgw== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(23010399003)(36860700016)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CKPPac8JUc30Eh6/C9nKTqYLVlNHPyfsxJTvrUn1ZaNngxHwvzYy9SmFrP5vtj+3uL1x5yasp2SfPVxXpirrzfyT1zQU5FtO3UQ7kUg8vki2zJq2KitTmbtRC83MQ3LbGA8bXKTIjpJLNaM8xScpw330KmPiPka3gTRDD0BgNXTz69GCwTh+jIv8lLapxjSpUIuzbGXVOdYnOab0kwtrGULMAoeUdPMA7ZtyP0Pu932QMmhJzZyAlBFdBOLf7+lyZKBn6dzJwVggxgnREHUBbawGJb4a10XZkBlylIUCZr1nUKE6nyHUHtKREUCMNGZL5547i1KmR+40zOAMPw5Wbfq9pgmyt/ZqmU3m4nsHdIxkkNjsVXnVyOgB7DHoOFVtjr4EbVr3zgt8VdGFH2GwIZDGMZBJf49sGOXd96tCez24bVq5hw5x4svsxmNB9WvV X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2026 07:14:55.6046 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9c1c0b4a-b982-4ba4-fa45-08df0be68daf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8883 Content-Type: text/plain; charset="utf-8" From: Shay Drory The teardown path unloads the representors; align the create error path to do the same. Fixes: 68c2dd59a6c7 ("net/mlx5: E-Switch, Tie rep load/unload to SD LAG sta= te") Signed-off-by: Shay Drory Reviewed-by: Akiva Goldberger Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/lag/shared_fdb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/shared_fdb.c b/dri= vers/net/ethernet/mellanox/mlx5/core/lag/shared_fdb.c index 6b4ad3c53f2f..424040918fa3 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/shared_fdb.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/shared_fdb.c @@ -270,6 +270,7 @@ int mlx5_lag_shared_fdb_create(struct mlx5_lag *ldev, pf->sd_fdb_active =3D false; } mlx5_lag_destroy_single_fdb_filter(ldev, group_id); + mlx5_lag_unload_reps_from_locked(ldev, filter); } err_add_devices: mlx5_lag_add_devices_filter(ldev, filter); --=20 2.44.0 From nobody Sat Sep 26 01:52:47 2026 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011012.outbound.protection.outlook.com [52.101.62.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68AFB3E2747; Sun, 6 Sep 2026 07:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788678903; cv=fail; b=p1FWJ8rrd0XBm4zu9m5gs4kp+d5IVZ3Xlw0YDclRjm9IaEM+M0lAjovj9YE8goOADhnMHPv5KHxn27JzeksySEU0HYBYlbEPZWAWLYITJPx5Ll1OZrdfdPvmxoMnA60+v7c2i9y/iNsYBCP1nUXB+HkWs6C28AWqm08DR3ikOXU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788678903; c=relaxed/simple; bh=5mQr5VFnELFhewAyxS51nhzplhS7+FZUqQCbzizsFF8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=r/9wHkZGRq1KSgJSW93fz1qGAPYrpdzoUKcQ7PauRciE6vPuA6spWy3tR2/0WFhuOIDb1b8KCLuCxMMLRG10ws3OE1KY5AqZensKJ7RxQcQB4dB6bFRqk5+EUiwAok1cNg71WKhsPyLn33dw2kTNag6X1iB3Of2mUbG/IFityNc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=D/40ebjt; arc=fail smtp.client-ip=52.101.62.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="D/40ebjt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wGpwj9l4V25Vzid3V2LsK6GV2o1zVIEjPuKPdHen+Zdec//wk6LcvMRvBq5wd+l/vDNdobNfxnxP+bSxccru3iGEd2IrqmtprKqhRmE7VE3zhJl/hFP77J2+qM5f0ibZ0+q6MthyfRILjk1T+OUXB7GPqgsr6SklbImzCsCYPq+BsYYqid4HoX7xjSlSvgBOf/B3/kObFZeoclC9zUOOAmHduIMIeE4rasGkAuZ3GgKBYqy/1dTAzW6h10b3GBImEBbVxFvB9x14WldMafundQN7fz8ghGa/KJ4Hzoux7AG4kNj/Vj+r6vhKKyhlNG8q488B8aQwsSC+IjzZR0URVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xftvjPCm+T5iMKs81lqZK6BF5KbIl1o3U7HEfGQVAmU=; b=mBP+iCBD9qtDpagZLt/fzqUCNzLy62b+2Ky+iE1e9yUGvGAfli/MvE2G7FEyFxLQ1bA17/mEKxNRsH9gk5NKIuE5Y/3/Qoq+ljmkgqWye3+au4FS7oU0M8a6dYQ4Ur9EdgITB6oCfvQQmLmSDeGKbXA9v//ld1xAXj57vMm5KYjoHCPqYYMOENBPAGsGYxeg6TD1CslYH5EwSzZLeqQ0M5Iz6feQR6Rlo+1AHLlyiks/knMU+KsA0cQHcpLxEM7Rp+feeg63NLrokPn12yeIokgRO/XG6+aAdK9JWmXIIi9RtFMhlHD8ktDkYPmR9D9U40Jt8F5kwxvMmwgp5B/e4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xftvjPCm+T5iMKs81lqZK6BF5KbIl1o3U7HEfGQVAmU=; b=D/40ebjt3GScmuQOwoot2GQm8HXv+oYzWMSu4Ct8l3UmVYTOmf6IzePsWjb190PbKVuOP/DF86Zj2Lz1YUGlTxq2qScCrkCgjRwxFAfdbsuofMxSslEYqmZA8KVU0UqzdhQ8CGwQGSe2/PN6lJffybNQc183tWxtklfK+1l0GoRiK2001QpGCODiUI2/bgmMZL4Ppu2yI+GAwDHbJF0T/l1eXSEvCY5WodwPAsr4dii0FAHrCxY7lcot+s5AKbPdox8duk7r54s3zjSffeFv0RvhzGBd87DASikRbj1kUp6yU0zwjBrmQ6BXCHG6/oh0ljT5UXVzl13hg/txgXZcbw== Received: from SJ0PR13CA0209.namprd13.prod.outlook.com (2603:10b6:a03:2c3::34) by IA1PR12MB6577.namprd12.prod.outlook.com (2603:10b6:208:3a3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Sun, 6 Sep 2026 07:14:56 +0000 Received: from SJ1PEPF000037AF.namprd03.prod.outlook.com (2603:10b6:a03:2c3:cafe::2f) by SJ0PR13CA0209.outlook.office365.com (2603:10b6:a03:2c3::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.6 via Frontend Transport; Sun, 6 Sep 2026 07:14:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ1PEPF000037AF.mail.protection.outlook.com (10.167.244.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Sun, 6 Sep 2026 07:14:55 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 6 Sep 2026 00:14:45 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 6 Sep 2026 00:14:45 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Sun, 6 Sep 2026 00:14:40 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Edward Srouji , Gal Pressman , Kees Cook , Leon Romanovsky , , , Maher Sanalla , Mark Bloch , Or Har-Toov , Parav Pandit , Patrisious Haddad , Saeed Mahameed , Shay Drori , Simon Horman , Tariq Toukan Subject: [PATCH net V2 4/4] net/mlx5: LAG, reload IB reps of LAG master before the rest Date: Sun, 6 Sep 2026 10:13:32 +0300 Message-ID: <20260906071332.3759199-5-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260906071332.3759199-1-tariqt@nvidia.com> References: <20260906071332.3759199-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037AF:EE_|IA1PR12MB6577:EE_ X-MS-Office365-Filtering-Correlation-Id: 68232021-123a-4cd5-4296-08df0be68dcb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|23010399003|82310400026|7416014|11063799006|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: LiD0wkbrkgqDf08p9DMEZ5jz6wQVRKdxaWy9o6S7ri5flVetZMmouPSQOjFDBaiFgAzBy26SB6GwMWYIPGNQAR5xQ88CnG3BCjdCmVQreEDgKH+GOpSLFCyFYjSdyn9rjblgZT5IJ52gjAqQJ1ZRO4SmgfQhHMj8ljkaqKeL6AJOvp9f/yEcoWGkvL5nr2DylGcaGysyMnYef3qhrXpTRsjHt2aRQfCRQzLqLwdisR+oPLYtf7uNnTT5oTWbJlMMG1whqrCjscahyFUFMk68dAe+xul7WXXyGBgK6nDqfNwJjyYBYlxmprC6FLoepH8bPFPB+tJl7nvI7HW2arPACm6yi4vfDhA8uW/1t5oM+Z1TwUc7nDikaIsMiPrVhaGv6CzYWgSBI+dcFdZOMNr+cenuLEgYF6hsULveAGTRxMbigGzeGsTpcaQZLzfic3PiSYutinMHUq74UlzNxpX8SgRpe/iR/Esh66qpqRSjSXU29DgWMWmIStEFJ+2LbYn/M2iG8ASbcYXGprMoW1S2xuEWqcR382ieoz/0xhAayqxh4enTyv6lJIUVXzUjw5MhiNH/v3xSY96hw0lR7zqPGE7U98IonendavwzP3OJG2ORB5i8UNaEvA2md9wHjtDOtqsQhK67txTO4ZhFSqmJrLTpzU5TP/FLhfVfe7Ku8Xrt46vBMdz/DttuFTecdI0KKO2AGxE9EmEEWyEzuUy3HA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(23010399003)(82310400026)(7416014)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lnT/M0lkoR5zBbG2uZVLuMo6qiRFG/a+tpq8GE6VLLxMJrJi0mPInV7XKP405luale+oqOx1cr02re09dCmhMA/NHdMn88AX2m/BLDjG6KkYfPzoOrBjBySo1fL4SgvqTRRMnyUMYKstG9N1xPd/Vt/g79ZZxLzbfpTeuaNzOMItYcvKjKT3vkdNcjX3mqLGL7U08UxZHL9Bg4Ut0QVZ/cYFdF88LsgJNzWCwcyBEsYUePyxZMFoekTeN2K8ci4IAyFWDI9XGycBmUeGTKjKDmMyl4c4lHhryNh1x5eaM+Mk+zJZ8kkGqy41gzRiUCeXLKxuk4x6eQf4V9fANMoXeRWVX4haClsKx7VdpXnmxO4/LuG9FZLXdCyUrG5cXt9xEUc8hdFQJTWIoXb93Y3PvQ+x8qWA/h0ufxBXH+ig4Q3zhs84yXHVRyXZvuFwqkiR X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2026 07:14:55.8889 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68232021-123a-4cd5-4296-08df0be68dcb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037AF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6577 Content-Type: text/plain; charset="utf-8" From: Shay Drory In a shared-FDB LAG the master device creates the bond IB device; the other LAG members do not create their own, they populate a port inside the master's IB device. mlx5_lag_reload_ib_reps_unlocked() reloaded the members' IB reps in iteration order, with no guarantee the master is reloaded first. When a non-master member is reloaded before the master, it tries to populate its port in an IB device that has not been recreated yet. Hence, reload the master's IB reps first, then every other member. Fixes: 2b204cdb1206 ("net/mlx5: LAG, use xa_alloc to manage LAG device indi= ces") Signed-off-by: Shay Drory Reviewed-by: Akiva Goldberger Signed-off-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/lag/lag.c | 44 ++++++++++++++----- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/lag/lag.c index aee5ce471eba..4984c812268c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c @@ -1263,25 +1263,45 @@ void mlx5_lag_remove_devices(struct mlx5_lag *ldev) mlx5_lag_remove_devices_filter(ldev, MLX5_LAG_FILTER_PORTS); } =20 +static int mlx5_lag_reload_ib_reps_idx(struct mlx5_lag *ldev, int idx, + u32 flags) +{ + struct lag_func *pf =3D mlx5_lag_pf(ldev, idx); + struct mlx5_eswitch *esw; + int ret; + + if (pf->dev->priv.flags & flags) + return 0; + + esw =3D pf->dev->priv.eswitch; + mlx5_esw_reps_block(esw); + ret =3D mlx5_eswitch_reload_ib_reps(esw); + mlx5_esw_reps_unblock(esw); + + return ret; +} + static int mlx5_lag_reload_ib_reps_unlocked(struct mlx5_lag *ldev, u32 fla= gs, u32 filter, bool cont_on_fail) { - struct lag_func *pf; + int master_idx =3D mlx5_lag_get_dev_index_by_seq_filter(ldev, MLX5_LAG_P1, + filter); int ret; int i; =20 + if (master_idx < 0) + return -EINVAL; + + ret =3D mlx5_lag_reload_ib_reps_idx(ldev, master_idx, flags); + if (ret && !cont_on_fail) + return ret; + mlx5_lag_for_each(i, 0, ldev, filter) { - pf =3D mlx5_lag_pf(ldev, i); - if (!(pf->dev->priv.flags & flags)) { - struct mlx5_eswitch *esw; - - esw =3D pf->dev->priv.eswitch; - mlx5_esw_reps_block(esw); - ret =3D mlx5_eswitch_reload_ib_reps(esw); - mlx5_esw_reps_unblock(esw); - if (ret && !cont_on_fail) - return ret; - } + if (i =3D=3D master_idx) + continue; + ret =3D mlx5_lag_reload_ib_reps_idx(ldev, i, flags); + if (ret && !cont_on_fail) + return ret; } =20 return 0; --=20 2.44.0