From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C79C3D9699; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; cv=none; b=D0YlcWZIJhxjxCDIphn5ISQj63RQQTve3mla4i4NBO8Wf21JLcs/Q4Fwtb+WJDtpolzLZg7Bpq4b/+B1ObyA/BpmHU0dCVFAbj7ZNND8WJF8DXx5trXK9nJk1Ov0WctsOjWUPLJMbzife/EVJ2nQKQn5eo3i1ELk3H4Qh/W3EgQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; c=relaxed/simple; bh=94YUykDJzjneOKnFmtYOq460CkFRZAGPAcv4chtjAxM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Qk9+XVSPDnJCkDfuMxHQuuv38JasN8dHxneEVXYIg3B5WKRCY9LYTy9vW/kIljaEqYo3n1XjuDfsH55RcThRMpMaIo9OEbSJF3VrExuPPjmFcwmhoRWY0jeHLjuyRCM1licNv1bCnYYBxSX0zaU8fJSfoBvPfFFw2JQmq2Ltuao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bTAtsiWy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bTAtsiWy" Received: by smtp.kernel.org (Postfix) with ESMTPS id D9465C2BCFB; Sun, 6 Sep 2026 04:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670020; bh=94YUykDJzjneOKnFmtYOq460CkFRZAGPAcv4chtjAxM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=bTAtsiWyTrC2SZPueX9YD46SyQOJ8sJ7iwcpHKGVgvCliT07krdfi52iL4ILB2Jsn VN8lUvC9PnsHpkGoYSTzSWvGHHJ+m9304hRNPhaEDzCeT7ROQ/rr5WQp+iKJcTg79B bAZkdRVaFR+BBvF4PP5XUj49dnxJ3MPNJn9T1A4qzJhK5UNZkHyYtzcxKp5uojyHCi e54LvH4Xs8LnXq7oBDvmbOOlpzlVakTowCZfsZ1O+JRQfwmx2m02tunyR20NRhqVzI 2zM3KGmMud4TJbOj8NHXo0EfWWDmOh3hSK6EcwFR3pxcQgsRmRLHHpXz8mJEhiV+Di BqustFMEKCImQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B305FC79F9E; Sun, 6 Sep 2026 04:47:00 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:40 +0400 Subject: [PATCH v3 01/10] usb: dwc3: core: Allow glue layer to pass reference clock rate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-1-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=3846; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=XS2lUluyNIQ284w/BNk2sQpv86j1/GqdSRhm4g7gG/k=; b=ln773ZOe+KluNYTyTnUGM8nINo99XePdPYdT2B6W4sXaG5m3uysRn3WLXjPAJj2+E6wocu3gW YPANHaybeczDbUGjlKbq+BYYQu/ft2U9vzXc80xPfuRywuau6TuTBoa X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Add ability to pass the reference clock rate from the glue layer to the DWC3 core driver. The core calculates the reference clock period and frame length adjustment based on the reference clock rate. In the flattened snsp-dwc3 model, it is currently not possible to pass a reference clock that differs from the default since: commit 613a2e655d4d ("usb: dwc3: core: Expose core driver as library") The new glue layers (incl. Qualcomm's) set the ignore_clocks_and_resets flag in dwc3_probe_data to true, which disables the core driver's clock management, thus it also doesn't acquire the reference clock from the devicetree needed in dwc3_ref_clk_period. There's an existing DT property 'snps,ref-clock-period-ns', but that's been deprecated. In addition, basing the rate from the period is often not accurate enough to derive the frame length adjustment value. This prevents moving chipsets such as IPQ5018, IPQ6018, IPQ5332, IPQ5424 and IPQ9574 with a reference clock rate that computes values for the period and frame length adjustment different from the hardware default from moving to the flattened model. So, add ability to set the reference clock rate in dwc3_probe_data, then have the core obtain the clock rate and use that to calculate the required period and frame length adjustment. Signed-off-by: George Moussalem Reviewed-by: Varadarajan Narayanan --- drivers/usb/dwc3/core.c | 6 ++++++ drivers/usb/dwc3/core.h | 2 ++ drivers/usb/dwc3/glue.h | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index fd5c2cd36c59..6ff0e4822b49 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -420,6 +420,9 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc) } else if (dwc->ref_clk_per) { period =3D dwc->ref_clk_per; rate =3D NSEC_PER_SEC / period; + } else if (dwc->ref_clk_rate) { + rate =3D dwc->ref_clk_rate; + period =3D NSEC_PER_SEC / rate; } else { return; } @@ -2334,6 +2337,9 @@ int dwc3_core_probe(const struct dwc3_probe_data *dat= a) goto err_put_psy; } =20 + if (data->ref_clk_rate > 0) + dwc->ref_clk_rate =3D data->ref_clk_rate; + ret =3D reset_control_deassert(dwc->reset); if (ret) goto err_put_psy; diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 608daeb7ef10..4181d57a6cd3 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -1032,6 +1032,7 @@ struct dwc3_glue_ops { * @regs_size: address space size * @fladj: frame length adjustment * @ref_clk_per: reference clock period configuration + * @ref_clk_rate: reference clock rate provided by glue layer * @irq_gadget: peripheral controller's IRQ number * @otg_irq: IRQ number for OTG IRQs * @current_otg_role: current role of operation while using the OTG block @@ -1261,6 +1262,7 @@ struct dwc3 { =20 u32 fladj; u32 ref_clk_per; + unsigned long ref_clk_rate; u32 irq_gadget; u32 otg_irq; u32 current_otg_role; diff --git a/drivers/usb/dwc3/glue.h b/drivers/usb/dwc3/glue.h index d738e1739ae0..ed96b10d8cd8 100644 --- a/drivers/usb/dwc3/glue.h +++ b/drivers/usb/dwc3/glue.h @@ -33,6 +33,9 @@ struct dwc3_properties { * @skip_core_init_mode: Skip the finial initialization of the target mode= , as * it must be managed by the glue * @properties: dwc3 software manage properties + * @ref_clk_rate: optional reference clock rate for the DWC3 core to compu= te the + * period and frame length adjustment required if these values + * differ from the hardware default. */ struct dwc3_probe_data { struct dwc3 *dwc; @@ -40,6 +43,7 @@ struct dwc3_probe_data { bool ignore_clocks_and_resets; bool skip_core_init_mode; struct dwc3_properties properties; + unsigned long ref_clk_rate; }; =20 /** --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CBA23DB63D; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; cv=none; b=hSS+IQGJAsYsY4hgisC95Vesajkblci2rf+pNH1M+I+fIApUyCUh4ZJCWyuw86sbxRm2I1uHhqcx8ZU9ADO3FOcrQ/zF/dyF4jePyV8vdaQamw1JQdMEIY5Oz8a964aufb6QaH9tuImlUcualcxCkh2jOcihW7bvkmTvYkDJiFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; c=relaxed/simple; bh=Ikpi+gT4ywjhff6FSiJKyaOR6iEOydvAYf67drdysoM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lqzwvLymH+i7wse0UVVqXhj717hXxYuaoZSLx8sQDIRRIJZEIVqr6pxoowqfVWqWJQrJyXTHbON7XfdQ5ruqJwGL6zjs47AgtRK/32/mlLhpmO6WXbz+exEslP9EdNwPZyrLokqu+7sGBs4DBUgFuq/zoxlVI05giyMcRk4wSCY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=py9fKql1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="py9fKql1" Received: by smtp.kernel.org (Postfix) with ESMTPS id E9874C2BCFA; Sun, 6 Sep 2026 04:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670021; bh=Ikpi+gT4ywjhff6FSiJKyaOR6iEOydvAYf67drdysoM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=py9fKql15RS7DERbqSTcts9NS0y34IrwCqUZVZLIWLF5SWFSzsJeN/2iCmMmxdRVH 4GblO76Pq8VJpnrIKcxl6V/d8UuzjuFnfV826RKtKtYROusT2pBZeTXLUUwD5HKTcK zkqxvPbhDhW6uNUYs0m/PU5KTlbVP/GcmK0QDT/qNls+fQ1A+vZcT9epfX0l2Z4w1/ w9WHd55s+GxERCNbO/0yGQB/dWLDOJGudT9gcIUrV+kiNHRXW4D0zEEhku/Wj1IPXZ 5JEajI3ZvE7WV9ODzEtxqxFO/oclOJ0xsf9ZUfOqN5j6+n/pm5W+t5rZ89OMVVda3h khLbbuHcLap7g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C917CC79FA0; Sun, 6 Sep 2026 04:47:00 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:41 +0400 Subject: [PATCH v3 02/10] usb: dwc3: qcom: Add support for selecting UTMI as reference clock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-2-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=1928; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=o+kaADaB/p5iiIE1oFwC/8s5jkCmJhEr9uLhza+Gk4A=; b=jdoxNq02LkiVU+QjL52dFm4hoFrIyClozniAK3hpKN92xpLxs2NgMSqqRhfHI1+E5H+C8j/KZ TKvs9C59Ds1D2RK6MEsDvJRMBNGLmaS1BbILAb/4fa8lUksoqVSD6Ac X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem On many Qualcomm chipsets, the UTMI clock is used as the reference clock (ex. IPQ5018, IPQ6018, and IPQ9574 and more). Since moving to the new flattened snps-dwc3 model, it is no longer possible to pass the reference clock to the dwc3 core driver. The clock rate is used by the dwc3 core to compute the reference clock period and frame length adjustment. This is needed when the reference clock rate used computes values that deviate from the hardware defaults. Above mentioned SoCs require values different from the defaults and, as such, the core initializes with the wrong values which leads to non-functional USB operation. In Qualcomm chipsets, if available, the UTMI clock is used as the reference clock. Therefore, acquire the reference clock by name ('mock_utmi') and pass its clock rate to the core using the probe_data structure. Signed-off-by: George Moussalem Reviewed-by: Varadarajan Narayanan --- drivers/usb/dwc3/dwc3-qcom.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index ac68b4218b56..8c1aca40c810 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -617,6 +617,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev) int ret; bool ignore_pipe_clk; bool wakeup_source; + struct clk *ref_clk; =20 qcom =3D devm_kzalloc(&pdev->dev, sizeof(*qcom), GFP_KERNEL); if (!qcom) @@ -698,6 +699,14 @@ static int dwc3_qcom_probe(struct platform_device *pde= v) qcom->current_role =3D USB_ROLE_DEVICE; } =20 + ref_clk =3D devm_clk_get_optional(dev, "mock_utmi"); + if (IS_ERR(ref_clk)) { + ret =3D dev_err_probe(dev, PTR_ERR(ref_clk), "failed to get ref clock\n"= ); + goto clk_disable; + } else if (ref_clk) { + probe_data.ref_clk_rate =3D clk_get_rate(ref_clk); + } + qcom->dwc.glue_ops =3D &dwc3_qcom_glue_ops; =20 qcom->dwc.dev =3D dev; --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6952F8E99; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; cv=none; b=kXMoQgkcyUkzokf97NwisH3AiaS6MjnQuAcfTWOfyD1AspPeMzbZ/XKhuJDoobxeCLHgdYHFIq3YkyOWerP+KZ5jwJxUuCgrsXoy/u3xunpswYLasDsfv93XpWarAXeHH4uEnq4EwrhkEljE2Cl5CZyo0o/CBJf/L1ixqXyrpe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; c=relaxed/simple; bh=JaVt7yZdbJ9bWdkGGPA5mC2d1T6xwdo0sQd87FyuVTY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q7swx2jaJYjt1l919J0af0aBJvZpuh7vbfZRXWu3uo0C/kwPPRjvU7+i9ahddi8k184mNClmOPHWO320LKesXL6AXXhhGl6txh8d99EWZRocdnrgsDFK+PlCiUPwVr7+ITZwauhGwLd0u+RhWNh/v41aymGK9YmwcS0HaXBIT/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sTKKtom/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sTKKtom/" Received: by smtp.kernel.org (Postfix) with ESMTPS id 02121C2BD00; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670021; bh=JaVt7yZdbJ9bWdkGGPA5mC2d1T6xwdo0sQd87FyuVTY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=sTKKtom/7OPDghe9kGfapYhdmasIY65xkExt3aqAHGHUBWbcZWiJHoJAiXbMbd8NW vy/ikxHVFXjRf3OrZRmRGyCKeXBJdJiPRu/pRqzAPe1DnZUIU7oR0UOh92hk1nt8gd AEwr41sP5OL5hdyeGU0pl7ix+4QP+VPYuTXMNFZD99dXDaw+Kqg/ELKXQDj/5eHBSS KA79YMTRTnik7UlHDtZapLZb2J4EK1CoZgQL3/T0XkCsU6S3RUqjdMZo1108pzUnbI aAfFJmz5fjRk2QRzOCxJKVsb2CLfT3TriUJkb4rT1Yrd3DnbxFHM+X2jOuXTkMqwIK hYKeAOs8EiEYA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB99C79FA1; Sun, 6 Sep 2026 04:47:00 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:42 +0400 Subject: [PATCH v3 03/10] arm64: dts: qcom: ipq5018: Flatten usb controller node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-3-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=3217; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=d4OUV1ubr3frsOV//1ALOKp4iIE5azs6C7X+EbQ6/2I=; b=nITrPC21x9Y9BL71zqAWKhah5eSe+DL7XTNs5FqNeF4gC3YqQ3mTDf5UxgG+oEjRJVtIMfYdD HbGHsVn7DufAObR7M3KkKhhhTGevRPTKzU+XMyjE5xgVD6zxbSWKzFA X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller node and update to using latest bindings and flattened driver approach. In addition, set the right UTMI clock rate and override any clock rate inherited from the bootloader. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 6 +-- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 51 ++++++++++++----------= ---- 2 files changed, 25 insertions(+), 32 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/bo= ot/dts/qcom/ipq5018-rdp432-c2.dts index 33eef92b19b1..8efb2b21ed9e 100644 --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts @@ -110,11 +110,9 @@ data-pins { }; =20 &usb { - status =3D "okay"; -}; - -&usb_dwc { dr_mode =3D "host"; + + status =3D "okay"; }; =20 &usbphy0 { diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qc= om/ipq5018.dtsi index 4fc627b47fe7..956d3217ec52 100644 --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi @@ -580,16 +580,9 @@ qpic_nand: spi@79b0000 { status =3D "disabled"; }; =20 - usb: usb@8af8800 { - compatible =3D "qcom,ipq5018-dwc3", "qcom,dwc3"; - reg =3D <0x08af8800 0x400>; - - interrupts =3D , - , - ; - interrupt-names =3D "pwr_event", - "dp_hs_phy_irq", - "dm_hs_phy_irq"; + usb: usb@8a00000 { + compatible =3D "qcom,ipq5018-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08a00000 0xfc100>; =20 clocks =3D <&gcc GCC_USB0_MASTER_CLK>, <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, @@ -599,30 +592,32 @@ usb: usb@8af8800 { "iface", "sleep", "mock_utmi"; + assigned-clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; + assigned-clock-rates =3D <60000000>; + + interrupts =3D , + , + , + ; + interrupt-names =3D "dwc_usb3", + "pwr_event", + "dp_hs_phy_irq", + "dm_hs_phy_irq"; =20 resets =3D <&gcc GCC_USB0_BCR>; =20 + phys =3D <&usbphy0>; + phy-names =3D "usb2-phy"; + qcom,select-utmi-as-pipe-clk; - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; =20 - status =3D "disabled"; + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; =20 - usb_dwc: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x08a00000 0xe000>; - clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phy-names =3D "usb2-phy"; - phys =3D <&usbphy0>; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E0E03DE43F; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; cv=none; b=Y8CettEgp1KoSZ2hAlZ2IqQ5WisH2i8koN0RurJGa7SGjYpBDKdR69qYXJ6KpdUQml/3TPFWu5R1h+x6o18hpsUt16FaTncF8U9U+aQqyZu4BzE1TP8e4UmC3M+PBYVCcRkHHCLtMBEMpbyQg1DP/Py0aWG1FfNgbep+alxMTK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; c=relaxed/simple; bh=YUIor8yMS9GKkHFUZ11ZoJQm/DvRtyUy5+W583C/if8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HD54evi3Odov0lX047elqLXUZt/1yU/hXZLSXY63DgKFJUIUgPAphSnumDkGdUR3wbdJC6Tx86BQHsKlpHqN2/A70sZYpY09NaFoaoQ3RipLucY9rk969aUSZpMwak38ZfdlgBLr5gd5Kzh5Mkp6S8cEMgD89dSgW4J5kslRaUU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f8yyGgBd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f8yyGgBd" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0FD37C4AF0B; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670021; bh=YUIor8yMS9GKkHFUZ11ZoJQm/DvRtyUy5+W583C/if8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=f8yyGgBdEOaP0dcHraZpaCs90Da69esTRpsIwv9r/2ilF/IGD0NeCaFU3C1leAd6n oV0euphYhvJSZO4LwXiU88t6hanCBOf4ZAArBVvCjXgxfIyFb03xNGHqro9s0DpCEP eA536LelqcWqr6TTF73pDCYlcuPsMBDpoDKpi3F2luERLwaW5Bg0q2DuYp15FFgmxv VOd6q4ci1LVvGJ1RDFNH1v8umKxQASctrZg0sf2tPOlpAm/Psg93HUenzekhhTaqrK PJwxVlaEDbbEtjYwtNCIj4dDH3d872sgqKtd85cbUzxNwEJIyVBcXFde3ePNX0a02m BDF0VIwxCeMFQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE426C79F9F; Sun, 6 Sep 2026 04:47:00 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:43 +0400 Subject: [PATCH v3 04/10] arm64: dts: qcom: ipq5332: Flatten usb controller node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-4-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=3451; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=PYOFo1aWcJ8CI++Ruzl5x/cryb7/w2wzFL+6CGLmDk4=; b=01fTuIF5eaQFE2aaDUTxhZhITF3mfrZ+xTGGCvtv3n96cCEK46ooNHjT7Oa8k1/e1urILE7bg 8/7o9iNcK0+Denv1NORD5NWBinFbOLJcgkx5j98XiA2AyByh4VkE64e X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller node and update to using latest bindings and flattened driver approach. In addition, set the right UTMI clock rate and override any clock rate inherited from the bootloader. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 6 +-- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 57 +++++++++++++------------= ---- 2 files changed, 28 insertions(+), 35 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts b/arch/arm64/boot/= dts/qcom/ipq5332-rdp468.dts index c224ffc65b08..25a70cd884c0 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts @@ -90,11 +90,9 @@ spi_0_cs_pins: spi-0-cs-state { }; =20 &usb { - status =3D "okay"; -}; - -&usb_dwc { dr_mode =3D "host"; + + status =3D "okay"; }; =20 &usbphy0 { diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qc= om/ipq5332.dtsi index 74d9de8d7641..b8c54c75b161 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi @@ -493,16 +493,9 @@ qpic_nand: spi@79b0000 { status =3D "disabled"; }; =20 - usb: usb@8af8800 { - compatible =3D "qcom,ipq5332-dwc3", "qcom,dwc3"; - reg =3D <0x08af8800 0x400>; - - interrupts =3D , - , - ; - interrupt-names =3D "pwr_event", - "dp_hs_phy_irq", - "dm_hs_phy_irq"; + usb: usb@8a00000 { + compatible =3D "qcom,ipq5332-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08a00000 0xfc100>; =20 clocks =3D <&gcc GCC_USB0_MASTER_CLK>, <&gcc GCC_USB0_SLEEP_CLK>, @@ -510,34 +503,36 @@ usb: usb@8af8800 { clock-names =3D "core", "sleep", "mock_utmi"; + assigned-clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; + assigned-clock-rates =3D <60000000>; =20 - resets =3D <&gcc GCC_USB_BCR>; - - qcom,select-utmi-as-pipe-clk; + interrupts =3D , + , + , + ; + interrupt-names =3D "dwc_usb3", + "pwr_event", + "dp_hs_phy_irq", + "dm_hs_phy_irq"; =20 - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; interconnects =3D <&gcc MASTER_SNOC_USB &gcc SLAVE_SNOC_USB>, <&gcc MASTER_SNOC_USB &gcc SLAVE_SNOC_USB>; interconnect-names =3D "usb-ddr", "apps-usb"; =20 - status =3D "disabled"; + resets =3D <&gcc GCC_USB_BCR>; =20 - usb_dwc: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x08a00000 0xe000>; - clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phy-names =3D "usb2-phy"; - phys =3D <&usbphy0>; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + phys =3D <&usbphy0>; + phy-names =3D "usb2-phy"; + + qcom,select-utmi-as-pipe-clk; + + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDFB63E008A; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; cv=none; b=u7a2SODy51CK1ehnRD+uNWrCTm/jHGUzZoG0sk+mltKaO1DZfbTTkmnlWo3e1l4xElg8HV3iOyslzqsfwZep72XIbY5D6lcGQygZ1SStEsQCagdpHJlckKpVem+TSchptRTx8mwihVe6W477vz/gWjry185bu6IWNyV5QbG0svI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670021; c=relaxed/simple; bh=Bbwqxn/dYETE0fH+5VZOc5Z5ZrxCBQN1qc3+VDfAIDc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YXa88qjPa5Znw98ir1HazzpGn8Zc6L2tbbprlA3FGnHaXzwDj1Os/TVITIvAjqKql30CtlLR0KVzYQsQKNptKJjEvx5I/Of9/5SDnS4HexwiqlZ/k/gKdEQk8bY1rcRsy8tS//IuYBG0+pIc+jwGllViPYeS3R5IFtTC4FwMG2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I8vbaJUi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I8vbaJUi" Received: by smtp.kernel.org (Postfix) with ESMTPS id 2390AC4AF13; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670021; bh=Bbwqxn/dYETE0fH+5VZOc5Z5ZrxCBQN1qc3+VDfAIDc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=I8vbaJUirvqI0QJNYWrXYqskrPkNOfXQCLXfhN0CB19Hn2ylwsQr82fQ57Tm9yaKY 9MnoSfipM+CaDDDUfBBKlLDIw2BO7VoB/ImT/SmuE8SVPjkjyAIPLBD6cFmDlah3QL 8ZcX8URMtbrCmq4xm/oC1TjTMvHl3lHNcdNlix7QxsJD/SNBFZLuc8K39Hydn/Q1Gp U8xAZ+UHXwk+mleZYA4ex9Gzru1UYGVOyZ+lGfMJ4kYmUMDRfb2PPIKEJ0pdlj33uw yLRxsUIgkgClfDyhD4nvBlOGm5h+AtDA0jMm1/uoGA2oha3s6G1rlqBQXbbAiCFJOA j6lP8R8yMTHwg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B996C79F8C; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:44 +0400 Subject: [PATCH v3 05/10] arm64: dts: qcom: ipq5424: Flatten usb controller nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-5-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=5216; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=y0UKZW8UPAFUmI+uUPmVraXJ0oMSSqbxgtDqSe4LuFQ=; b=HKVT4e4w510vQuOeA+tQkz2VKdhxTBmaBnbPDA/lxEE+q/kJ/ql5/M3Pdvp3OaRG5TgIKSqW1 1cTVrBcMD8kBNKX9cITR97NwA6GUO/tyxRWR1IbWllj7ltGNvBUAKsD X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller nodes and update to using latest bindings and flattened driver approach. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 12 ++-- arch/arm64/boot/dts/qcom/ipq5424.dtsi | 86 +++++++++++++------------= ---- 2 files changed, 41 insertions(+), 57 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/= dts/qcom/ipq5424-rdp466.dts index be8657239c46..dfd6a124686a 100644 --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts @@ -74,14 +74,6 @@ vreg_misc_0p925: regulator-usb-0p925 { }; }; =20 -&dwc_0 { - dr_mode =3D "host"; -}; - -&dwc_1 { - dr_mode =3D "host"; -}; - &pcie2 { pinctrl-0 =3D <&pcie2_default_state>; pinctrl-names =3D "default"; @@ -282,10 +274,14 @@ &uart1 { }; =20 &usb2 { + dr_mode =3D "host"; + status =3D "okay"; }; =20 &usb3 { + dr_mode =3D "host"; + status =3D "okay"; }; =20 diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qc= om/ipq5424.dtsi index 702061e16a58..de795ca2a905 100644 --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi @@ -639,12 +639,9 @@ qusb_phy_1: phy@71000 { status =3D "disabled"; }; =20 - usb2: usb2@1ef8800 { - compatible =3D "qcom,ipq5424-dwc3", "qcom,dwc3"; - reg =3D <0 0x01ef8800 0 0x400>; - #address-cells =3D <2>; - #size-cells =3D <2>; - ranges; + usb2: usb2@1e00000 { + compatible =3D "qcom,ipq5424-dwc3", "qcom,snps-dwc3"; + reg =3D <0 0x01e00000 0 0xfc100>; =20 clocks =3D <&gcc GCC_USB1_MASTER_CLK>, <&gcc GCC_USB1_SLEEP_CLK>, @@ -663,33 +660,31 @@ usb2: usb2@1ef8800 { assigned-clock-rates =3D <200000000>, <24000000>; =20 - interrupts-extended =3D <&intc GIC_SPI 395 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended =3D <&intc GIC_SPI 396 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 395 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 397 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 387 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 388 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "dm_hs_phy_irq", "dp_hs_phy_irq"; =20 resets =3D <&gcc GCC_USB1_BCR>; + + phys =3D <&qusb_phy_1>; + phy-names =3D "usb2-phy"; + qcom,select-utmi-as-pipe-clk; - status =3D "disabled"; =20 - dwc_1: usb@1e00000 { - compatible =3D "snps,dwc3"; - reg =3D <0 0x01e00000 0 0xe000>; - clocks =3D <&gcc GCC_USB1_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phys =3D <&qusb_phy_1>; - phy-names =3D "usb2-phy"; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 qusb_phy_0: phy@7b000 { @@ -730,13 +725,9 @@ ssphy_0: phy@7d000 { status =3D "disabled"; }; =20 - usb3: usb3@8af8800 { - compatible =3D "qcom,ipq5424-dwc3", "qcom,dwc3"; - reg =3D <0 0x08af8800 0 0x400>; - - #address-cells =3D <2>; - #size-cells =3D <2>; - ranges; + usb3: usb3@8a00000 { + compatible =3D "qcom,ipq5424-dwc3", "qcom,snps-dwc3"; + reg =3D <0 0x08a00000 0 0xfc100>; =20 clocks =3D <&gcc GCC_USB0_MASTER_CLK>, <&gcc GCC_USB0_SLEEP_CLK>, @@ -755,34 +746,31 @@ usb3: usb3@8af8800 { assigned-clock-rates =3D <200000000>, <24000000>; =20 - interrupts-extended =3D <&intc GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended =3D <&intc GIC_SPI 409 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "dm_hs_phy_irq", "dp_hs_phy_irq"; =20 resets =3D <&gcc GCC_USB_BCR>; - status =3D "disabled"; =20 - dwc_0: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0 0x08a00000 0 0xcd00>; - clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phys =3D <&qusb_phy_0>, <&ssphy_0>; - phy-names =3D "usb2-phy", "usb3-phy"; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - snps,dis-u1-entry-quirk; - snps,dis-u2-entry-quirk; - }; + phys =3D <&qusb_phy_0>, <&ssphy_0>; + phy-names =3D "usb2-phy", "usb3-phy"; + + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + snps,dis-u1-entry-quirk; + snps,dis-u2-entry-quirk; + + status =3D "disabled"; }; =20 timer@f420000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 208BC3E0C4A; Sun, 6 Sep 2026 04:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; cv=none; b=i8z9sQci9gcx7dqYpXJFaq7EuogavHdsuteHgVi0h+sOSEbQSlWssbC75xIzOITFY+LrYE2CdqKhTuPnhAuRsA6I9x9Ldvl58hkwKH+n7IBG8NqwaqZPfbt9LjcRD+ScKHP44aDnZNJpM6FdgVAha+x2OUTao04OsbAN3i1mzNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; c=relaxed/simple; bh=XU/WWn6wXEnjfkMrNJ55MXZyduZW1YwOpLbOtLkSfNA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AkimYJPSwZaUbnZcHbJnu9+82B+ejEm2y9qx94/qTu4z+a505NTYtxxekipnKzxjF4Y8BM1EeYmca6i+clA85RdtiQ/kasWeWDl/Tf6HciYplEmR/ktoVh/xIb/2Vs52Gu7Q0S83U+PWit2B0CSfUZeQu/a7jeAy3AIMw8B0HAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GAe7iQE1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GAe7iQE1" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3121EC4AF17; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670021; bh=XU/WWn6wXEnjfkMrNJ55MXZyduZW1YwOpLbOtLkSfNA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=GAe7iQE1d7oTIQiwJCFVxCXSbnFFy0bSvk3wy38U+TY40oVOxiOLQejCXMENlnMww R62+fSfVwHUsIddAOlk2SKy7bISLRuANSda9fW7T033aoOipYEPXTRUiwFYGWRfvU4 VRQBI2oMsTrayBKhV8AqvxT7tgBpIrWrxrU46cpvDQuR/Biz/6xO7asG1WX8Fh+pjV zhIaq6bDVOKm+sHmvfYlUDYM5PBYPQidOgNnCHpgji6vl8jLDK3KPEQv1h861HqDK4 nNAmT7P9iY8KcoFmF2iOrhTjU/iaTpoL1IH3BPdYCznLgdYLToS51rM1yzhC5P9En2 xdpg35vMTBVgw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D43EC79FA1; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:45 +0400 Subject: [PATCH v3 06/10] arm64: dts: qcom: ipq6018: move DR mode to board DTS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-6-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=1428; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=aGVdbmVqvLfMC/B1qmTc6oe5SvSsjf2fzGsuzsOSZC8=; b=Xv2RysEOavWlN109J2KyxKnXlte5xkgurtiQ4I3ztOapEV+QDc5uarxRYihwjWXkv/i/CW5r3 DzRsdah5FrCB22aODabCVtMkpI4+wkISdQ7DuXKMleVpPuDwXa3Nsoi X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem The controller is DRD capable, but it's currently set to host mode in the SoC dtsi. Unset it in the SoC dtsi and set it as host mode in the cp01-c1 board DTS file. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 ++++ arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot= /dts/qcom/ipq6018-cp01-c1.dts index 9c69d3027b43..a366be17c251 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts @@ -48,6 +48,10 @@ flash@0 { }; }; =20 +&dwc_1 { + dr_mode =3D "host"; +}; + &tlmm { i2c_1_pins: i2c-1-state { pins =3D "gpio42", "gpio43"; diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qc= om/ipq6018.dtsi index 0701517275d4..c02110ad9cb0 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -460,7 +460,6 @@ dwc_1: usb@7000000 { snps,hird-threshold =3D /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; snps,dis_u3_susphy_quirk; - dr_mode =3D "host"; }; }; =20 @@ -716,7 +715,6 @@ dwc_0: usb@8a00000 { snps,hird-threshold =3D /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; snps,dis_u3_susphy_quirk; - dr_mode =3D "host"; }; }; =20 --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBC473E0090; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; cv=none; b=GKnDqdXbkI5T3m+U9XcyGyOh81RAwQzxi8At2Om1hJypsiI4LzGIjo4TqBB8ZXOiD8fjGDgDBLR/7SqW+noxAEZD1zWBI8rgRfTNjcFPxUFuYz+mH+T1DuHwSnBgpU6me0nkXsLj+xaptEf1dkor6kpM94YLvqsWmcPyYhekqIA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; c=relaxed/simple; bh=DYnvjyUMNurv4oidNp7Ai8v++lNDC917FZknQTTjveU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nETwBHR8z18hCtnVHTB3cNBud9N5aaBcgQtTYNaZQB1P9gmGQcbvsevV2JDO1YIJ4crdvPULZf1OfrHHZ0Hd4gFx9z1Ew83+wIgIUJj2ux6ktX6Z+KehV5/thVaYTlaRHmOOSTmMEdPkuFpeZbe9kxS2K+y3kwcJ2MAm+TBKznc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YPs+66km; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YPs+66km" Received: by smtp.kernel.org (Postfix) with ESMTPS id 44A95C2BD04; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670021; bh=DYnvjyUMNurv4oidNp7Ai8v++lNDC917FZknQTTjveU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=YPs+66kmzrGbQXS5+aBBIm/0qGq3a28EqjcPwRsPHbNI1V1R4f4zDpV0KlweUUwVU SHD4FJM1deorP2rREBJJVOzClhTp7XjpHwWwJqE3cGlgm80v6QJ5KswD8TVrjq0b4k vthgl9QlI/l5bCHfJJXkka9lkTdJ23cVxeDvkqtz7/gcK262pdEbEixtuihDWAbDqP ULZXM1Q5YAmFwrqJXjdjks1vE3soKL6R60amqqAtFxNWr0Y6Evf+R6o2JWZaA+nBC1 oKyvMFXE3zCaL4FYBxNm/ILKYGqSMGJ3T0hwq0bhh4SnDlEcATqp33EQdxpnXmIvGG S1NUyNwgcxBOw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31772C79F9E; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:46 +0400 Subject: [PATCH v3 07/10] arm64: dts: qcom: ipq6018: Flatten usb controller nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-7-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=5041; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=QMYZOel4Z7ohvK/v1QgPC715UMdbY7FAiCKD4hgbqKc=; b=1JmXJB/g03B3GX1/U7rJmh5iWYzqjYyFt/UUrB9VYljlqwhmNNP4iNhA0pD/vnlkGbTvYL8yR QyKuP1yzHHlDnUp76U2bejdaq1hxCAIQo9wzPZ/Nnv3xwDF8e3eDmih X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller nodes and update to using latest bindings and flattened driver approach. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 6 +- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 93 +++++++++++++-----------= ---- 2 files changed, 44 insertions(+), 55 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot= /dts/qcom/ipq6018-cp01-c1.dts index a366be17c251..dfc3aac955e8 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts @@ -48,10 +48,6 @@ flash@0 { }; }; =20 -&dwc_1 { - dr_mode =3D "host"; -}; - &tlmm { i2c_1_pins: i2c-1-state { pins =3D "gpio42", "gpio43"; @@ -88,5 +84,7 @@ &qusb_phy_1 { }; =20 &usb2 { + dr_mode =3D "host"; + status =3D "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qc= om/ipq6018.dtsi index c02110ad9cb0..4f5f8b628bf2 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -423,12 +423,10 @@ pwm: pwm@1941010 { status =3D "disabled"; }; =20 - usb2: usb@70f8800 { - compatible =3D "qcom,ipq6018-dwc3", "qcom,dwc3"; - reg =3D <0x0 0x070f8800 0x0 0x400>; - #address-cells =3D <2>; - #size-cells =3D <2>; - ranges; + usb2: usb@7000000 { + compatible =3D "qcom,ipq6018-dwc3", "qcom,snps-dwc3"; + reg =3D <0x0 0x07000000 0x0 0xfc100>; + clocks =3D <&gcc GCC_USB1_MASTER_CLK>, <&gcc GCC_USB1_SLEEP_CLK>, <&gcc GCC_USB1_MOCK_UTMI_CLK>; @@ -441,26 +439,25 @@ usb2: usb@70f8800 { assigned-clock-rates =3D <133330000>, <24000000>; =20 - interrupts =3D , + interrupts =3D , + , ; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy"; =20 resets =3D <&gcc GCC_USB1_BCR>; - status =3D "disabled"; =20 - dwc_1: usb@7000000 { - compatible =3D "snps,dwc3"; - reg =3D <0x0 0x07000000 0x0 0xcd00>; - interrupts =3D ; - phys =3D <&qusb_phy_1>; - phy-names =3D "usb2-phy"; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + phys =3D <&qusb_phy_1>; + phy-names =3D "usb2-phy"; + + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 sdhc: mmc@7804000 { @@ -668,21 +665,18 @@ qpic_nand: nand-controller@79b0000 { status =3D "disabled"; }; =20 - usb3: usb@8af8800 { - compatible =3D "qcom,ipq6018-dwc3", "qcom,dwc3"; - reg =3D <0x0 0x08af8800 0x0 0x400>; - #address-cells =3D <2>; - #size-cells =3D <2>; - ranges; + usb3: usb@8a00000 { + compatible =3D "qcom,ipq6018-dwc3", "qcom,snps-dwc3"; + reg =3D <0x0 0x08a00000 0x0 0xfc100>; =20 clocks =3D <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, - <&gcc GCC_USB0_MASTER_CLK>, - <&gcc GCC_USB0_SLEEP_CLK>, - <&gcc GCC_USB0_MOCK_UTMI_CLK>; + <&gcc GCC_USB0_MASTER_CLK>, + <&gcc GCC_USB0_SLEEP_CLK>, + <&gcc GCC_USB0_MOCK_UTMI_CLK>; clock-names =3D "cfg_noc", - "core", - "sleep", - "mock_utmi"; + "core", + "sleep", + "mock_utmi"; =20 assigned-clocks =3D <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, <&gcc GCC_USB0_MASTER_CLK>, @@ -691,31 +685,28 @@ usb3: usb@8af8800 { <133330000>, <24000000>; =20 - interrupts =3D , + interrupts =3D , + , , ; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "ss_phy_irq"; =20 resets =3D <&gcc GCC_USB0_BCR>; - status =3D "disabled"; =20 - dwc_0: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x0 0x08a00000 0x0 0xcd00>; - interrupts =3D ; - phys =3D <&qusb_phy_0>, <&ssphy_0>; - phy-names =3D "usb2-phy", "usb3-phy"; - clocks =3D <&xo>; - clock-names =3D "ref"; - tx-fifo-resize; - snps,parkmode-disable-ss-quirk; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + phys =3D <&qusb_phy_0>, <&ssphy_0>; + phy-names =3D "usb2-phy", "usb3-phy"; + + tx-fifo-resize; + snps,parkmode-disable-ss-quirk; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF94D3E00B4; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; cv=none; b=mYl02Iar0If/VhuV7u0Vc9LaI1eLKrca1mW+4yaj4mXz3O3CWj+XXirMNAzTdHkwpxZDrjwIg/BN9TqrjNnlop89qwsfE3cLP5Wv/okKN02bpPKmx7yrCn4i/4wQbwI8ZZzY1se669WZse1fIwPF3SgAixZuIAFy6mcDxmKA56I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; c=relaxed/simple; bh=yePW7swJKp/CoAXYJIlRrxTJvJHLYrZ5g7dI2UeDTAs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jNWKFlOcH4zovH8Joum1wSK4xxKT+sy4g963CGUIzW7N/zpNJIdJRKTy2E+7pEkH6w8DqyHIG22d0AYTvk6x8iZiK8tmp8lIKTFIrQjOf3RK1lTp60xDxAUv62t3pj/Dohnv8mXzsJiLPGSH5ul/6vpxMllLQFFtVAhbK6ySnbg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=soi5SNDF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="soi5SNDF" Received: by smtp.kernel.org (Postfix) with ESMTPS id 57C65C4AF0F; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670021; bh=yePW7swJKp/CoAXYJIlRrxTJvJHLYrZ5g7dI2UeDTAs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=soi5SNDFh/trvsmHLVZ76ty370tAJh8AzmfD39kbQyaqKZ0ca5kEuXTmDwXfN8W3T mPzQYgYReIdgnN56dCGg5OaM2a6mwQe4jCq31KMbOmxGrmBbzc5Kjq3fyuuiKFe6u3 7QYGX5ncvQnVHTxOYpq/nmwpTI7axMkmwRdP35P4MoDSwf/EZDmuYK0aqeHATOTbwr Y1AJXn4TgplBIE8wgWTsGxv1WNlbskH8sd4GzZiATRRbbbwNqMebSPA4DGbAthNidF Z0ynexfVhW8Oa8GRvN8Awm9+gFIPK7tsT4+E5aLxs0sqd1ewYnmHXe/mdEANC431Xg Re0LV1ALJx3oA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43FADC79F9F; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:47 +0400 Subject: [PATCH v3 08/10] arm64: dts: qcom: ipq8074: move DR mode to board DTS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-8-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=1442; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=e2bv63iiEX2vz7ZO+5BDlb9OpNBUY7Sx/1y6B5CVxhA=; b=tdvDgmtfQNfTNjTOU8XvzRd+3v/W49bvVzIlI1XsYR/iaw9NxHZFMcU+cU5m1y27CHi0F12XS erP6HDk2bIkBsF+fEWtJY0jXnskvcCDAtaQgAXNVWr6pwyoSWd48wX2 X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Both controllers are DRD capable, but DR mode currently set to host mode in the SoC dtsi. Unset it in the SoC dtsi and set it as host mode in the hk01 board DTS file. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 8 ++++++++ arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dt= s/qcom/ipq8074-hk01.dts index dea5ece600d4..75827676bde9 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts @@ -52,6 +52,14 @@ &blsp1_uart5 { status =3D "okay"; }; =20 +&dwc_0 { + dr_mode =3D "host"; +}; + +&dwc_1 { + dr_mode =3D "host"; +}; + &pcie0 { status =3D "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qc= om/ipq8074.dtsi index 75a5ae30d966..5c57d9cd72fc 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -671,7 +671,6 @@ dwc_0: usb@8a00000 { snps,hird-threshold =3D /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; snps,dis_u3_susphy_quirk; - dr_mode =3D "host"; }; }; =20 @@ -721,7 +720,6 @@ dwc_1: usb@8c00000 { snps,hird-threshold =3D /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; snps,dis_u3_susphy_quirk; - dr_mode =3D "host"; }; }; =20 --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6C83E00A5; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; cv=none; b=WR3/ppdSBN3703BqlAPb1lbB3kJXLXXjZT3wsAoCAdlYyN9MP9Z/eeJ8/DqtvFBbFjFAQVLuFon/Amet/Dwys4XB4JBH1f9zE+fda3MIOlwWLYYRZVOgalKmlWWkT1CfyVhpn/VEGzIPyaid7H7N3R5rvhMSWCXbu2P4+A0lAVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; c=relaxed/simple; bh=xoukKYFvKtH0yVYC52oTXyZxdkrrVfGnS9OTDeei6DU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ehCNdFiFBQ82bArg9XoxcUj3CvBCIuJ2f5Ex4ywWq/5RoVA4d/XLIClDRwH0bj68tKB5ohP5II9amMIGfiCuobhK6CLl3/tVucD8JCI3utTbxydB6RiyIKnlvFEfOXklXtWxLJ3+KJv68i76wbj2djUdnzGiz74UVdwerwSiWjs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TVjy6iTT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TVjy6iTT" Received: by smtp.kernel.org (Postfix) with ESMTPS id 68B9AC2BCFF; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670021; bh=xoukKYFvKtH0yVYC52oTXyZxdkrrVfGnS9OTDeei6DU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=TVjy6iTT1Qz6ze6y7NeSzEKp8NMinTWRe9O3Hbt/aD2qYpt3e3Dp0cSJRIIRXzGjD 17Ak6/P/lhckXMIbZ+DVdsHewbKbiju4rlzCPvPod1bkmcIenfeF34GBegRotP0X0R F9zZ/7BTNYeaTtf5ECNXmc17CsR8rOJ3TaBYoc5Kf+r8JIKvmORCD9sUzV8HHscS5o kvLgdl2KVGzdlupClCswScd58Nzuzl5c4z/conIbYMRXU1XLVcYzshOVsbvtwctTLi AwRA2hFtIosqPlyQ8FHtdTWBYTATSlvPGQ34dexo06oSazy8vYx9GkF7IHDe/tRWXG R/aNjv4fCVdQg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56134C79F8C; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:48 +0400 Subject: [PATCH v3 09/10] arm64: dts: qcom: ipq8074: Flatten usb controller nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-9-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=5701; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=uxth14kMmQNJdlzw9mv+WW7U6sqEqBSC4dgsram9iyE=; b=5Lb1womhZCVVcpnhAbLq/rMFmzhLxmQ2BNZXnwOFo+nYlerFfREzNCK6OEJv5S15e7o/x/OnP DXOiwho+QxTBEaWinExdmIIkmEPjskJvARFMRUTxn/gdKiDZM+KqGRd X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller nodes and update to using latest bindings and flattened driver approach. In addition, fix indentation of properties in both nodes. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 12 ++-- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 108 ++++++++++++++------------= ---- 2 files changed, 54 insertions(+), 66 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dt= s/qcom/ipq8074-hk01.dts index 75827676bde9..2a3b497f9598 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts @@ -52,14 +52,6 @@ &blsp1_uart5 { status =3D "okay"; }; =20 -&dwc_0 { - dr_mode =3D "host"; -}; - -&dwc_1 { - dr_mode =3D "host"; -}; - &pcie0 { status =3D "okay"; }; @@ -125,9 +117,13 @@ &ssphy_1 { }; =20 &usb_0 { + dr_mode =3D "host"; + status =3D "okay"; }; =20 &usb_1 { + dr_mode =3D "host"; + status =3D "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qc= om/ipq8074.dtsi index 5c57d9cd72fc..45745b58495c 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -625,102 +625,94 @@ qpic_nand: nand-controller@79b0000 { status =3D "disabled"; }; =20 - usb_0: usb@8af8800 { - compatible =3D "qcom,ipq8074-dwc3", "qcom,dwc3"; - reg =3D <0x08af8800 0x400>; - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; + usb_0: usb@8a00000 { + compatible =3D "qcom,ipq8074-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08a00000 0xfc100>; =20 clocks =3D <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, - <&gcc GCC_USB0_MASTER_CLK>, - <&gcc GCC_USB0_SLEEP_CLK>, - <&gcc GCC_USB0_MOCK_UTMI_CLK>; + <&gcc GCC_USB0_MASTER_CLK>, + <&gcc GCC_USB0_SLEEP_CLK>, + <&gcc GCC_USB0_MOCK_UTMI_CLK>; clock-names =3D "cfg_noc", - "core", - "sleep", - "mock_utmi"; + "core", + "sleep", + "mock_utmi"; =20 assigned-clocks =3D <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, <&gcc GCC_USB0_MASTER_CLK>, <&gcc GCC_USB0_MOCK_UTMI_CLK>; assigned-clock-rates =3D <133330000>, - <133330000>, - <19200000>; + <133330000>, + <19200000>; =20 - interrupts =3D , + interrupts =3D , + , , ; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "ss_phy_irq"; =20 power-domains =3D <&gcc USB0_GDSC>; =20 + phys =3D <&qusb_phy_0>, <&ssphy_0>; + phy-names =3D "usb2-phy", "usb3-phy"; + + snps,parkmode-disable-ss-quirk; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + resets =3D <&gcc GCC_USB0_BCR>; - status =3D "disabled"; =20 - dwc_0: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x8a00000 0xcd00>; - interrupts =3D ; - phys =3D <&qusb_phy_0>, <&ssphy_0>; - phy-names =3D "usb2-phy", "usb3-phy"; - snps,parkmode-disable-ss-quirk; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + status =3D "disabled"; }; =20 - usb_1: usb@8cf8800 { - compatible =3D "qcom,ipq8074-dwc3", "qcom,dwc3"; - reg =3D <0x08cf8800 0x400>; - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; + usb_1: usb@8c00000 { + compatible =3D "qcom,ipq8074-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08c00000 0xfc100>; =20 clocks =3D <&gcc GCC_SYS_NOC_USB1_AXI_CLK>, - <&gcc GCC_USB1_MASTER_CLK>, - <&gcc GCC_USB1_SLEEP_CLK>, - <&gcc GCC_USB1_MOCK_UTMI_CLK>; + <&gcc GCC_USB1_MASTER_CLK>, + <&gcc GCC_USB1_SLEEP_CLK>, + <&gcc GCC_USB1_MOCK_UTMI_CLK>; clock-names =3D "cfg_noc", - "core", - "sleep", - "mock_utmi"; + "core", + "sleep", + "mock_utmi"; =20 assigned-clocks =3D <&gcc GCC_SYS_NOC_USB1_AXI_CLK>, <&gcc GCC_USB1_MASTER_CLK>, <&gcc GCC_USB1_MOCK_UTMI_CLK>; assigned-clock-rates =3D <133330000>, - <133330000>, - <19200000>; + <133330000>, + <19200000>; =20 - interrupts =3D , + interrupts =3D , + , , ; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "ss_phy_irq"; =20 power-domains =3D <&gcc USB1_GDSC>; =20 + phys =3D <&qusb_phy_1>, <&ssphy_1>; + phy-names =3D "usb2-phy", "usb3-phy"; + + snps,parkmode-disable-ss-quirk; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + resets =3D <&gcc GCC_USB1_BCR>; - status =3D "disabled"; =20 - dwc_1: usb@8c00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x8c00000 0xcd00>; - interrupts =3D ; - phys =3D <&qusb_phy_1>, <&ssphy_1>; - phy-names =3D "usb2-phy", "usb3-phy"; - snps,parkmode-disable-ss-quirk; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF5BE28851F; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; cv=none; b=p1YiZgNUvuzvvLrLD6X+UMzxdl1tA2ZiTuKY26cJYLLtLBVSxjzSCKcU1GOHg/QdFxul9rwnLNuO5LekpTfMC4KOvnW4ZSAIfWz0DVy0SshKvosvPRMQ+d9LI1+tVTiYBR2tIL7Kb619mECusPIgkhGiXa7mdoQtwaEF7OX2+vQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788670022; c=relaxed/simple; bh=SUFE2Dky6cQoVddOB+SeWioBwtDfQj0rCyByHsrBZYA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ncxp5X10lbrtZJllRYdZKgY5nYTdzIZsh2bjAfBTyCHmCqzm4R2+wk97hii7JSqxRob26YG0V2e4s1MJfzy312PJIxP3H9toaGGhhG5mkNMvfMiQ4tp7WVjYZ3tBGTdXY7oqjwTLb7CJ8yDcMPz96kQcKKAI/+vOQ9UassuPv4s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kFevK5tf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kFevK5tf" Received: by smtp.kernel.org (Postfix) with ESMTPS id 7B0B7C2BCFD; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788670021; bh=SUFE2Dky6cQoVddOB+SeWioBwtDfQj0rCyByHsrBZYA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=kFevK5tfTKIUTwyPDnUjzqQZxLZU+P6S+ojdXC7eaaYg8EYaHlZVuICCatahXXXUN 1lcJ4adSvG7PLEcCUtLeYae70HalcEWTsRHal3rC0GESHFpo04yPqs83i/eoKcA39m fTxZpdlYnty7YQ1d9YE+wejmNJN4Ix5nQNEJ+9StXn3o7JXZQJcI/rj86dlvkRRRRT MJptatX3ipieImrGDrr4bkCemHt8mkYj6EIRrOREFj7Yt24sNLg9qGgG5z+vYHfXRa 1U3o7NU5WXw+rLSx70Ps8ePs7desA0Kx5WfyrcMOvs5CZh9h/alD7oxrOuAI7l8flz fxcCKXNFMZ5Mg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67697C79FA1; Sun, 6 Sep 2026 04:47:01 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 08:46:49 +0400 Subject: [PATCH v3 10/10] arm64: dts: qcom: ipq9574: Flatten usb controller node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v3-10-13e4e0f63123@outlook.com> References: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788670018; l=3383; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=tC+/n/l2GL/RsZoPV770YyexNIiGMPAPlCiic/jUtRw=; b=jPP0ec1ndGEEKu+1KpZpm+xBXD11ZT5GR739/IPOTjwRgjegzk5tru2sM0TtEmPzTqidDJtkq 0lmfBS30v/9DtvyKIE2bAvIftZrtTOClnTRy6QAjV3By4QwKpJzxVGX X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller nodes and update to using latest bindings and flattened driver approach. In addition, swap interrupts for dp_hs_phy_irq and dm_hs_phy_irq as per order in updated binding. Signed-off-by: George Moussalem Reviewed-by: Abel Vesa Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 6 +-- arch/arm64/boot/dts/qcom/ipq9574.dtsi | 48 +++++++++++---------= ---- 2 files changed, 23 insertions(+), 31 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/= boot/dts/qcom/ipq9574-rdp-common.dtsi index 62877b46f9b3..0d06a838c233 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi @@ -252,10 +252,6 @@ flash@0 { }; }; =20 -&usb_0_dwc3 { - dr_mode =3D "host"; -}; - &usb_0_qmpphy { vdda-pll-supply =3D <&mp5496_l5>; vdda-phy-supply =3D <®ulator_fixed_0p925>; @@ -272,6 +268,8 @@ &usb_0_qusbphy { }; =20 &usb3 { + dr_mode =3D "host"; + status =3D "okay"; }; =20 diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qc= om/ipq9574.dtsi index 5a5bda5f21a1..199ec0c2ae9e 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi @@ -756,12 +756,9 @@ usb_0_qmpphy: phy@7d000 { status =3D "disabled"; }; =20 - usb3: usb@8af8800 { - compatible =3D "qcom,ipq9574-dwc3", "qcom,dwc3"; - reg =3D <0x08af8800 0x400>; - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; + usb3: usb@8a00000 { + compatible =3D "qcom,ipq9574-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08a00000 0xfc100>; =20 clocks =3D <&gcc GCC_SNOC_USB_CLK>, <&gcc GCC_USB0_MASTER_CLK>, @@ -780,32 +777,29 @@ usb3: usb@8af8800 { assigned-clock-rates =3D <200000000>, <24000000>; =20 - interrupts-extended =3D <&intc GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended =3D <&intc GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>, - <&intc GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>, - <&intc GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names =3D "pwr_event", + <&intc GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", - "dm_hs_phy_irq", - "dp_hs_phy_irq"; + "dp_hs_phy_irq", + "dm_hs_phy_irq"; =20 resets =3D <&gcc GCC_USB_BCR>; - status =3D "disabled"; =20 - usb_0_dwc3: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x8a00000 0xcd00>; - clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phys =3D <&usb_0_qusbphy>, <&usb_0_qmpphy>; - phy-names =3D "usb2-phy", "usb3-phy"; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + phys =3D <&usb_0_qusbphy>, <&usb_0_qmpphy>; + phy-names =3D "usb2-phy", "usb3-phy"; + + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0