From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE6F376A0D; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666766; cv=none; b=Ex+/cM/BwUhdRXJJv+BlWJu7njH9JNc2S5U3PpphkLLJkxbzB6KccxvyiSU2a8l1qJ+om7azwghXZHlqFXH1XP1tvuMJikWX5y7rPDyqGnEZfuiTKJbA6G/MvaF/wz5lKILP3wLoZNdV6+ycL1mRMnCk31Zq1KQCtgH47H3jTBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666766; c=relaxed/simple; bh=94YUykDJzjneOKnFmtYOq460CkFRZAGPAcv4chtjAxM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J/X+51JkWaS6sofh/0r1OUy5MtkPAtQIKwbrFrANNPupzx7BVrRTiHQhz+Dsqdqe/Z+ZkhVAXbBxrKjiE1UZ3P4avFtgH2HzJsMs2kyeSDJQgA12Gsp9F54Xev6Mx0ySAAZXU6MLLG4F5dAgoha5wQe55suQj0imAXjWrApS+bs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s8AAKkcX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s8AAKkcX" Received: by smtp.kernel.org (Postfix) with ESMTPS id 61C5EC2BCFB; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=94YUykDJzjneOKnFmtYOq460CkFRZAGPAcv4chtjAxM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=s8AAKkcXpmLnkP2gekjiJ0vIJky8fwqc1wFmYBPj0qtVTbExZQmMCsJFQ05nkkQxn j40r4R4dh1xw/vdCnc43OowsrDBWitx6ZQ6M3kUiwvgbUVI5mxy2UDMXAhLe6a9ctr F0WIeqawTbsJN1Hn6YiajgWOqKIah5Y7ZHyjbpJlTskjQ7HtycUp0lyCp9JIQ5jW/v 3RuViWsbKkaQQz5i9St/OZhzQL9HtVbWomHXgve44viwhgxtva838oeT36FZCs9yw4 Ip6SNZnTQsrhNIgZjVe9Qy/eHSU0Gm0wAtueui4Zx2DzF93TVPU6dXqdnbb8fWmJiW yMyTaGIlY+vEQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3563BC624DB; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:40 +0400 Subject: [PATCH v2 01/10] usb: dwc3: core: Allow glue layer to pass reference clock rate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-1-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=3846; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=XS2lUluyNIQ284w/BNk2sQpv86j1/GqdSRhm4g7gG/k=; b=u1hsW82CJUk1uNXi7suuLsLUiBqRvTSbqX7awyaNXZPWzJQHI2mWGXmISXw+e4VXd3F3dWkDe f2rg3Qghv21COEIn/prywPMDcesQWQ4Q3JTyTd8g4REzI0krTczYuhO X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Add ability to pass the reference clock rate from the glue layer to the DWC3 core driver. The core calculates the reference clock period and frame length adjustment based on the reference clock rate. In the flattened snsp-dwc3 model, it is currently not possible to pass a reference clock that differs from the default since: commit 613a2e655d4d ("usb: dwc3: core: Expose core driver as library") The new glue layers (incl. Qualcomm's) set the ignore_clocks_and_resets flag in dwc3_probe_data to true, which disables the core driver's clock management, thus it also doesn't acquire the reference clock from the devicetree needed in dwc3_ref_clk_period. There's an existing DT property 'snps,ref-clock-period-ns', but that's been deprecated. In addition, basing the rate from the period is often not accurate enough to derive the frame length adjustment value. This prevents moving chipsets such as IPQ5018, IPQ6018, IPQ5332, IPQ5424 and IPQ9574 with a reference clock rate that computes values for the period and frame length adjustment different from the hardware default from moving to the flattened model. So, add ability to set the reference clock rate in dwc3_probe_data, then have the core obtain the clock rate and use that to calculate the required period and frame length adjustment. Signed-off-by: George Moussalem Reviewed-by: Varadarajan Narayanan --- drivers/usb/dwc3/core.c | 6 ++++++ drivers/usb/dwc3/core.h | 2 ++ drivers/usb/dwc3/glue.h | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index fd5c2cd36c59..6ff0e4822b49 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -420,6 +420,9 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc) } else if (dwc->ref_clk_per) { period =3D dwc->ref_clk_per; rate =3D NSEC_PER_SEC / period; + } else if (dwc->ref_clk_rate) { + rate =3D dwc->ref_clk_rate; + period =3D NSEC_PER_SEC / rate; } else { return; } @@ -2334,6 +2337,9 @@ int dwc3_core_probe(const struct dwc3_probe_data *dat= a) goto err_put_psy; } =20 + if (data->ref_clk_rate > 0) + dwc->ref_clk_rate =3D data->ref_clk_rate; + ret =3D reset_control_deassert(dwc->reset); if (ret) goto err_put_psy; diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 608daeb7ef10..4181d57a6cd3 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -1032,6 +1032,7 @@ struct dwc3_glue_ops { * @regs_size: address space size * @fladj: frame length adjustment * @ref_clk_per: reference clock period configuration + * @ref_clk_rate: reference clock rate provided by glue layer * @irq_gadget: peripheral controller's IRQ number * @otg_irq: IRQ number for OTG IRQs * @current_otg_role: current role of operation while using the OTG block @@ -1261,6 +1262,7 @@ struct dwc3 { =20 u32 fladj; u32 ref_clk_per; + unsigned long ref_clk_rate; u32 irq_gadget; u32 otg_irq; u32 current_otg_role; diff --git a/drivers/usb/dwc3/glue.h b/drivers/usb/dwc3/glue.h index d738e1739ae0..ed96b10d8cd8 100644 --- a/drivers/usb/dwc3/glue.h +++ b/drivers/usb/dwc3/glue.h @@ -33,6 +33,9 @@ struct dwc3_properties { * @skip_core_init_mode: Skip the finial initialization of the target mode= , as * it must be managed by the glue * @properties: dwc3 software manage properties + * @ref_clk_rate: optional reference clock rate for the DWC3 core to compu= te the + * period and frame length adjustment required if these values + * differ from the hardware default. */ struct dwc3_probe_data { struct dwc3 *dwc; @@ -40,6 +43,7 @@ struct dwc3_probe_data { bool ignore_clocks_and_resets; bool skip_core_init_mode; struct dwc3_properties properties; + unsigned long ref_clk_rate; }; =20 /** --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBD0E3115AE; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666766; cv=none; b=kguPIeQH9BL5yo6IjxMwMsJ64oxy4syHizUfRJZxFPiG56nbdMJD2S5IpXJACAWy7CR6X65hLQPTQeh4iUuKu0gr6BE8IjPh+N5UbwCqVDH/yFr/L/D03oiT8ifExV2LR0FdrkA9TjjkhioLrqf5hxLHrWg/LwBG8+8fWpge4K4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666766; c=relaxed/simple; bh=yjN8BnmDkR0uFIUwMGdTsKJWkiAR16qGHk8nilYb2Vs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FYKV1xbW+vxaXOuNLlRJulDDQW+AHHAvtmeje+TMoX+pCyVCZV9Jz0ZHmB/zmGSaGgx+qh1eWMtPQZnBiODx61b39r4D8cyczdMP/yUBiq8TeuOEnNKZRh4jn5lBDbWWWEhglE6VwOLQcURjxaNERWIRJYV6V6nDvt71jLwbnXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QmpCUVEU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QmpCUVEU" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6E226C2BCFA; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=yjN8BnmDkR0uFIUwMGdTsKJWkiAR16qGHk8nilYb2Vs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=QmpCUVEUuN+4gvmCI0XT+EOHgosC4G04uzGV6wAJRTAMTKKWSNFUG+4N/XvrWmSuh x2dWToNOcK9IJLyEWD+rfQOqR5yVth897jXLO/IGUvbOqEFRJ9IN6zAu+ENjp2GSic MzYBGjX+9BXVfkHNl//g5LfY+y/oqM910AAgFIeyUfVKTCdMdfONRljfivo80h7PNk HnXMx4RDi74Ge2v5Cv1ZyIQcUqzoY0frUsNqBvYlVQMgBsShKvmTii0f8hJwc5TnNa xpannECh+iyPAThNBAfYp/hSz9ZMQ5n+vuh/ATkYUaMBtHfhQuAMgHkdGwoTY2m9So 5/gG4y8gmbPSg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 449AEC79F8B; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:41 +0400 Subject: [PATCH v2 02/10] usb: dwc3: qcom: Add support for selecting UTMI as reference clock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-2-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=1905; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=yWBu+uKd1BoOvs9eAQw2PN8F6cbr1YXtNLEtHmwjaTU=; b=1NrJhBoq+aXj8XpxYjzA+nI3lLv4PJJSB494ZT4/NTXskR1RkyxHGTaVIMiFw4cINZG1AFm5t SxM78vb+Zh8DKNOCMCUJkq2RMVT7ubB8dORRy8lsUdHQclXv7E5Fq1o X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem On many Qualcomm chipsets, the UTMI clock is used as the reference clock (ex. IPQ5018, IPQ6018, and IPQ9574 and more). Since moving to the new flattened snps-dwc3 model, it is no longer possible to pass the reference clock to the dwc3 core driver. The clock rate is used by the dwc3 core to compute the reference clock period and frame length adjustment. This is needed when the reference clock rate used computes values that deviate from the hardware defaults. Above mentioned SoCs require values different from the defaults and, as such, the core initializes with the wrong values which leads to non-functional USB operation. In Qualcomm chipsets, if available, the UTMI clock is used as the reference clock. Therefore, acquire the reference clock by name ('mock_utmi') and pass its clock rate to the core using the probe_data structure. Signed-off-by: George Moussalem Reviewed-by: Varadarajan Narayanan --- drivers/usb/dwc3/dwc3-qcom.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index ac68b4218b56..f4c3b370a75f 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -617,6 +617,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev) int ret; bool ignore_pipe_clk; bool wakeup_source; + struct clk *ref_clk; =20 qcom =3D devm_kzalloc(&pdev->dev, sizeof(*qcom), GFP_KERNEL); if (!qcom) @@ -698,6 +699,14 @@ static int dwc3_qcom_probe(struct platform_device *pde= v) qcom->current_role =3D USB_ROLE_DEVICE; } =20 + ref_clk =3D devm_clk_get_optional(dev, "mock_utmi"); + if (IS_ERR(ref_clk)) { + ret =3D dev_err_probe(dev, PTR_ERR(ref_clk), "failed to get ref clock\n"= ); + goto clk_disable; + } + + probe_data.ref_clk_rate =3D clk_get_rate(ref_clk); + qcom->dwc.glue_ops =3D &dwc3_qcom_glue_ops; =20 qcom->dwc.dev =3D dev; --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBFAA3BB9FC; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666766; cv=none; b=c1CQIw8DqQn+lVsTHpbkxwqZkFS1+Uw9sIeGp16j8xLI93/03pNt+45NzuujtUGnPK/VFcecdTNN5ZyEZTrsiVcsSQjeuvXwL7K/ite+HOaRC/h9xqWuYZUnTG5W+/AkqUtTEAs6PNKoTCsmpxX5J1KdpcU3/p8U2SATCLDFuaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666766; c=relaxed/simple; bh=JaVt7yZdbJ9bWdkGGPA5mC2d1T6xwdo0sQd87FyuVTY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=isiGxjf9kBki6TWfNAXkKJG9WH5xw36+gG4f/mw1vpD2ip9LmkVILRKnn8ds4Lr+E0fNkFTE1c4/+RfH9kJ23rFBljCQO77xihXJ4APuClteVINpybK2KCqRdEukSlcvo86qhKnonj+ZS1Wq7/jOWk2YkAGALZ3TSNPDmZaGpjw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Yg5rbnud; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Yg5rbnud" Received: by smtp.kernel.org (Postfix) with ESMTPS id 77C10C2BCFF; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=JaVt7yZdbJ9bWdkGGPA5mC2d1T6xwdo0sQd87FyuVTY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Yg5rbnuds58tqWZRjXzPNy/n8izx+aqFeeRF91R3KDZpX/Yv+YqNrqr2wsE158cjH JTg+eqN5VLNOINl5vT87KVe4kMdWTDfjvZpv8Zq+Ievwf16m5keA4dOrtEXF+P6chO HQb/lYtR3iLmupoPxdJ07BiRYu+psu/r/6a7bf/jpPFJZinygETi6Po8jrkDJVHrNC s80OkI6pojWBPUTc8xIBjfQ+u9Hod6stROY9WBEEAV7zN91z+iBrGnhI19Zm4hg/sQ n96Uk9zVTiRDmlB5e9aPQ03S67bxDKFyXNK9Vz0fyv4L1+Je0SPbWG1nDSndqaWVBf T1KgQpWYdUhxA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53AAEC79F9E; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:42 +0400 Subject: [PATCH v2 03/10] arm64: dts: qcom: ipq5018: Flatten usb controller node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-3-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=3217; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=d4OUV1ubr3frsOV//1ALOKp4iIE5azs6C7X+EbQ6/2I=; b=gb7aWJMe5r6tJ8REzjiJM7mKtSIEt1xg0oUsNTDPCp98csv/pCQ/SD2VKO+R2/xrhItZv95z8 4Ay+Zq0n3kiCZCI7eTnEmvf8AJMvX9QqFHlK5QPQOXVLA/SXUe2wB0N X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller node and update to using latest bindings and flattened driver approach. In addition, set the right UTMI clock rate and override any clock rate inherited from the bootloader. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 6 +-- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 51 ++++++++++++----------= ---- 2 files changed, 25 insertions(+), 32 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/bo= ot/dts/qcom/ipq5018-rdp432-c2.dts index 33eef92b19b1..8efb2b21ed9e 100644 --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts @@ -110,11 +110,9 @@ data-pins { }; =20 &usb { - status =3D "okay"; -}; - -&usb_dwc { dr_mode =3D "host"; + + status =3D "okay"; }; =20 &usbphy0 { diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qc= om/ipq5018.dtsi index 4fc627b47fe7..956d3217ec52 100644 --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi @@ -580,16 +580,9 @@ qpic_nand: spi@79b0000 { status =3D "disabled"; }; =20 - usb: usb@8af8800 { - compatible =3D "qcom,ipq5018-dwc3", "qcom,dwc3"; - reg =3D <0x08af8800 0x400>; - - interrupts =3D , - , - ; - interrupt-names =3D "pwr_event", - "dp_hs_phy_irq", - "dm_hs_phy_irq"; + usb: usb@8a00000 { + compatible =3D "qcom,ipq5018-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08a00000 0xfc100>; =20 clocks =3D <&gcc GCC_USB0_MASTER_CLK>, <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, @@ -599,30 +592,32 @@ usb: usb@8af8800 { "iface", "sleep", "mock_utmi"; + assigned-clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; + assigned-clock-rates =3D <60000000>; + + interrupts =3D , + , + , + ; + interrupt-names =3D "dwc_usb3", + "pwr_event", + "dp_hs_phy_irq", + "dm_hs_phy_irq"; =20 resets =3D <&gcc GCC_USB0_BCR>; =20 + phys =3D <&usbphy0>; + phy-names =3D "usb2-phy"; + qcom,select-utmi-as-pipe-clk; - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; =20 - status =3D "disabled"; + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; =20 - usb_dwc: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x08a00000 0xe000>; - clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phy-names =3D "usb2-phy"; - phys =3D <&usbphy0>; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBDCE368941; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666766; cv=none; b=Votr/NcpCjYWqo0GkdmsD0StIXiX5I+uED8XXyv/qvP4LZNcMl7DEKsE48bhpyfsCAy7a7j4jEuSf+g25wMQDrwhBi80wSWhlOGNGHTNGgTqnRzqBNGeFFzvV7pKhzF+w/eHldE2JK0KN0mm13ZfoR8HBoVNf3d11q6Kx8irCCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666766; c=relaxed/simple; bh=YUIor8yMS9GKkHFUZ11ZoJQm/DvRtyUy5+W583C/if8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WxK0iT+ia2zFvcMMxvV4BxcxdkN/N79fLHlgPDIavkcXlqR2G46FksyuI7Hx2pZ1ZRzdmvtL15e6SBrI+r3ZTSo3poSpM8O+XdpPWd/c/s++eWxwQtdEpMw/M8GNPe7rjUUwAUQkup1nsS0usPe72nN/SN4M2jPSWt/vYtD5kDo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TlsBjnqi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TlsBjnqi" Received: by smtp.kernel.org (Postfix) with ESMTPS id 7A550C2BD00; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=YUIor8yMS9GKkHFUZ11ZoJQm/DvRtyUy5+W583C/if8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=TlsBjnqiGLDntGNtz3YQwhk1MYjx5C1v0RHCb+pMzqN1IS9VSnTOeFfv70RbzRPuc ZYBCC2PA8swj18pL9HH56M/9OCxWSTbkka0/rResmdVRg3uJUSLj7NZXy84+IyXbK2 5VtFXShje8KdT+m+SVSIK7dEUSp5RPgCj/GS9SL8AOdwJzTb6V+xmXX6V0+8G+h36r hUa0XJSq4iqyt0Ipctj100XN1sb+WGLwCoa/i17z+N3YhzwhLdIhH5b/dEwcT2BE35 moQh2kf/17jffDWpZvByhaq9h32iqQGFvEkbZcZVJA1NHhNohII4eVyZnzXKOfXrQc lF1lWk80zM2dQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62784C79F91; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:43 +0400 Subject: [PATCH v2 04/10] arm64: dts: qcom: ipq5332: Flatten usb controller node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-4-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=3451; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=PYOFo1aWcJ8CI++Ruzl5x/cryb7/w2wzFL+6CGLmDk4=; b=NpmCX88gzmh8l3vQslzOqwEELCIhjYjVsqyyGLvD1cippDnctpTiyVhvcEmsCUYv6eaQKab5Z jl66sDydZt3DWKbF9qxM5RVm+VtnuA+IzZ8rN+Hyw5XNjKZHaXjXm97 X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller node and update to using latest bindings and flattened driver approach. In addition, set the right UTMI clock rate and override any clock rate inherited from the bootloader. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 6 +-- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 57 +++++++++++++------------= ---- 2 files changed, 28 insertions(+), 35 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts b/arch/arm64/boot/= dts/qcom/ipq5332-rdp468.dts index c224ffc65b08..25a70cd884c0 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts @@ -90,11 +90,9 @@ spi_0_cs_pins: spi-0-cs-state { }; =20 &usb { - status =3D "okay"; -}; - -&usb_dwc { dr_mode =3D "host"; + + status =3D "okay"; }; =20 &usbphy0 { diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qc= om/ipq5332.dtsi index 74d9de8d7641..b8c54c75b161 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi @@ -493,16 +493,9 @@ qpic_nand: spi@79b0000 { status =3D "disabled"; }; =20 - usb: usb@8af8800 { - compatible =3D "qcom,ipq5332-dwc3", "qcom,dwc3"; - reg =3D <0x08af8800 0x400>; - - interrupts =3D , - , - ; - interrupt-names =3D "pwr_event", - "dp_hs_phy_irq", - "dm_hs_phy_irq"; + usb: usb@8a00000 { + compatible =3D "qcom,ipq5332-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08a00000 0xfc100>; =20 clocks =3D <&gcc GCC_USB0_MASTER_CLK>, <&gcc GCC_USB0_SLEEP_CLK>, @@ -510,34 +503,36 @@ usb: usb@8af8800 { clock-names =3D "core", "sleep", "mock_utmi"; + assigned-clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; + assigned-clock-rates =3D <60000000>; =20 - resets =3D <&gcc GCC_USB_BCR>; - - qcom,select-utmi-as-pipe-clk; + interrupts =3D , + , + , + ; + interrupt-names =3D "dwc_usb3", + "pwr_event", + "dp_hs_phy_irq", + "dm_hs_phy_irq"; =20 - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; interconnects =3D <&gcc MASTER_SNOC_USB &gcc SLAVE_SNOC_USB>, <&gcc MASTER_SNOC_USB &gcc SLAVE_SNOC_USB>; interconnect-names =3D "usb-ddr", "apps-usb"; =20 - status =3D "disabled"; + resets =3D <&gcc GCC_USB_BCR>; =20 - usb_dwc: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x08a00000 0xe000>; - clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phy-names =3D "usb2-phy"; - phys =3D <&usbphy0>; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + phys =3D <&usbphy0>; + phy-names =3D "usb2-phy"; + + qcom,select-utmi-as-pipe-clk; + + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09D63C2795; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; cv=none; b=uipsDRFMO0mxNj7WzGPPZo/TfKAgtMiz1fkYlOrmxpuw2sLkruBWdCOeOolQ31mtYJ87nsvKZ+okO19XyLQrxKpx69s8nASFwrQZr7/O9mcQ/a5LGZ9xI2/zBFKf2D7PVCwucWS4kyX8rYPAErjQjA48Omf3NsL3PN2tgF5iEgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; c=relaxed/simple; bh=Bbwqxn/dYETE0fH+5VZOc5Z5ZrxCBQN1qc3+VDfAIDc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S1Vza6S0miwGxgpuKBJikOZHzFgJzKiqYwRqeC+LxIAOr/+/6AmbkoeeUV6oWHfpqJAaZl6MjER7NpBmdWldzbkjVPzOTJ86a4SV9CjyH8C/oDKmXpZFnfpdMm2hZcBjT+NQ/ooQ3n4tDcI88D6/OYrlLzyHPkIRwLqVWY45m7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TPYg+FT1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TPYg+FT1" Received: by smtp.kernel.org (Postfix) with ESMTPS id 8A57DC2BCFD; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=Bbwqxn/dYETE0fH+5VZOc5Z5ZrxCBQN1qc3+VDfAIDc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=TPYg+FT1YiIyWYXuKUIFT50rsJ1T+KW0A2WzpeXV8KNWPug12kC/92IJoBMaZmsai JUbGZqNRliCuByVvkLiz7FFytWqHTDmMjo74968CYFpDEP6h5H1gmW3twqzkw502hC 6FfOVBalRGdBsGfVl7n7Wq22cIthFYXMVHxq3fGwpMbPi0QTkQPxtbqEP8QdUothkT mdTl4gj++TBf4DtO0rixnf1Xf03YwKU15qlnvcDGx+n7t8ZXpe4pxK//CN6FxYtWry iJ7yBgm2YXHuVqb3HTWCv1lkD0FunkGn2dEvuAKMylDDJT3e/bLNUE1mo74Rvnxtoj XfwALNV8ouUkg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F82C79FA0; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:44 +0400 Subject: [PATCH v2 05/10] arm64: dts: qcom: ipq5424: Flatten usb controller nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-5-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=5216; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=y0UKZW8UPAFUmI+uUPmVraXJ0oMSSqbxgtDqSe4LuFQ=; b=tk+RhyQgjE94xgIgJ04yl0AXK8IJU7LaHG6rYVf5uD/7CqiZX4j9dFhihB459clbNFkQgBBht WhIx5JSY7oYCsgJkw6te3Hj1kRDNJ6J1ZkPVchiK5H3wUEYSm0N7CLK X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller nodes and update to using latest bindings and flattened driver approach. Signed-off-by: George Moussalem --- arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 12 ++-- arch/arm64/boot/dts/qcom/ipq5424.dtsi | 86 +++++++++++++------------= ---- 2 files changed, 41 insertions(+), 57 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/= dts/qcom/ipq5424-rdp466.dts index be8657239c46..dfd6a124686a 100644 --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts @@ -74,14 +74,6 @@ vreg_misc_0p925: regulator-usb-0p925 { }; }; =20 -&dwc_0 { - dr_mode =3D "host"; -}; - -&dwc_1 { - dr_mode =3D "host"; -}; - &pcie2 { pinctrl-0 =3D <&pcie2_default_state>; pinctrl-names =3D "default"; @@ -282,10 +274,14 @@ &uart1 { }; =20 &usb2 { + dr_mode =3D "host"; + status =3D "okay"; }; =20 &usb3 { + dr_mode =3D "host"; + status =3D "okay"; }; =20 diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qc= om/ipq5424.dtsi index 702061e16a58..de795ca2a905 100644 --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi @@ -639,12 +639,9 @@ qusb_phy_1: phy@71000 { status =3D "disabled"; }; =20 - usb2: usb2@1ef8800 { - compatible =3D "qcom,ipq5424-dwc3", "qcom,dwc3"; - reg =3D <0 0x01ef8800 0 0x400>; - #address-cells =3D <2>; - #size-cells =3D <2>; - ranges; + usb2: usb2@1e00000 { + compatible =3D "qcom,ipq5424-dwc3", "qcom,snps-dwc3"; + reg =3D <0 0x01e00000 0 0xfc100>; =20 clocks =3D <&gcc GCC_USB1_MASTER_CLK>, <&gcc GCC_USB1_SLEEP_CLK>, @@ -663,33 +660,31 @@ usb2: usb2@1ef8800 { assigned-clock-rates =3D <200000000>, <24000000>; =20 - interrupts-extended =3D <&intc GIC_SPI 395 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended =3D <&intc GIC_SPI 396 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 395 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 397 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 387 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 388 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "dm_hs_phy_irq", "dp_hs_phy_irq"; =20 resets =3D <&gcc GCC_USB1_BCR>; + + phys =3D <&qusb_phy_1>; + phy-names =3D "usb2-phy"; + qcom,select-utmi-as-pipe-clk; - status =3D "disabled"; =20 - dwc_1: usb@1e00000 { - compatible =3D "snps,dwc3"; - reg =3D <0 0x01e00000 0 0xe000>; - clocks =3D <&gcc GCC_USB1_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phys =3D <&qusb_phy_1>; - phy-names =3D "usb2-phy"; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 qusb_phy_0: phy@7b000 { @@ -730,13 +725,9 @@ ssphy_0: phy@7d000 { status =3D "disabled"; }; =20 - usb3: usb3@8af8800 { - compatible =3D "qcom,ipq5424-dwc3", "qcom,dwc3"; - reg =3D <0 0x08af8800 0 0x400>; - - #address-cells =3D <2>; - #size-cells =3D <2>; - ranges; + usb3: usb3@8a00000 { + compatible =3D "qcom,ipq5424-dwc3", "qcom,snps-dwc3"; + reg =3D <0 0x08a00000 0 0xfc100>; =20 clocks =3D <&gcc GCC_USB0_MASTER_CLK>, <&gcc GCC_USB0_SLEEP_CLK>, @@ -755,34 +746,31 @@ usb3: usb3@8af8800 { assigned-clock-rates =3D <200000000>, <24000000>; =20 - interrupts-extended =3D <&intc GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended =3D <&intc GIC_SPI 409 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "dm_hs_phy_irq", "dp_hs_phy_irq"; =20 resets =3D <&gcc GCC_USB_BCR>; - status =3D "disabled"; =20 - dwc_0: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0 0x08a00000 0 0xcd00>; - clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phys =3D <&qusb_phy_0>, <&ssphy_0>; - phy-names =3D "usb2-phy", "usb3-phy"; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - snps,dis-u1-entry-quirk; - snps,dis-u2-entry-quirk; - }; + phys =3D <&qusb_phy_0>, <&ssphy_0>; + phy-names =3D "usb2-phy", "usb3-phy"; + + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + snps,dis-u1-entry-quirk; + snps,dis-u2-entry-quirk; + + status =3D "disabled"; }; =20 timer@f420000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0C183C2796; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; cv=none; b=MaQZTojqg4JL3OOohMKgzzeIADyzAUFCekRTdA/6GQkaBO2S59/KMeZeB1wnz7et2XEWXjhfzswyyVPf9JszktOvixfqKgA8crnxdKqo1EDm6wZbcrcbOByaQ6Fsdwxf65aerVkpp6mkgSuxV+G/iOORebFIqY5R3xPqFOoQi5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; c=relaxed/simple; bh=XU/WWn6wXEnjfkMrNJ55MXZyduZW1YwOpLbOtLkSfNA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GeYykZgRdwID7kJ+KXuKE0dsL/n47zz5wzqTGjjcfGRlil28dRG9ecr5UGSbzwOHkEfUhbCIsDuUDTrqKKEP457I5A/mVw1ZJwig2OYcKj+8Dvb6QH+pqMh4SBWnt4J+jA9qHx7nL991MH+HXF2XJu24Vs6A7z7GRLOkhWf1edE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kwN3SV0A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kwN3SV0A" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9AEEFC32782; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=XU/WWn6wXEnjfkMrNJ55MXZyduZW1YwOpLbOtLkSfNA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=kwN3SV0AHP0rq+WGUrARGzaYyjjTrU1ZrNQdi6KUd+qbTHkv91zdZSx/PDcB0p51Y lecNwCRePQJomafyKuvSkL1oev7yQp+1gnZR4cC62H+bSwAF2aoQuKkky3VyS+ON3m ytwlbHpjOc7rFxaWgQ2qCUVXnlF4SnjvCRMZ+TBJe+ei17nwXD0k3gFG6Rdhl4HKec cf5ihheu1b/trwjQnfeRVS8zVAhBQhryI1RVoLCExWni65EjE0vK+OAe5OruzIz3Jt seNQXl4cUp0Pse86P9tU1P7bwxQgIxID45QLK/61OSKIrIdmzyl0XZ7Sz/9E6jXhx8 B05TKMpBF0wSg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81324C79F8C; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:45 +0400 Subject: [PATCH v2 06/10] arm64: dts: qcom: ipq6018: move DR mode to board DTS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-6-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=1428; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=aGVdbmVqvLfMC/B1qmTc6oe5SvSsjf2fzGsuzsOSZC8=; b=pU0XsMbU5kHa5qlEPqBb36gmSFBGQ+/VDqKxjy1m/4Ui6ObpiyfoxjxcrNHvHWAUdy/hcoQXJ zA5OjZoTRsmB4UgEs8lCzZY2GOpGQiRzN3YRWqzgzJkDRETIYZDjalb X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem The controller is DRD capable, but it's currently set to host mode in the SoC dtsi. Unset it in the SoC dtsi and set it as host mode in the cp01-c1 board DTS file. Signed-off-by: George Moussalem --- arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 ++++ arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot= /dts/qcom/ipq6018-cp01-c1.dts index 9c69d3027b43..a366be17c251 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts @@ -48,6 +48,10 @@ flash@0 { }; }; =20 +&dwc_1 { + dr_mode =3D "host"; +}; + &tlmm { i2c_1_pins: i2c-1-state { pins =3D "gpio42", "gpio43"; diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qc= om/ipq6018.dtsi index 0701517275d4..c02110ad9cb0 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -460,7 +460,6 @@ dwc_1: usb@7000000 { snps,hird-threshold =3D /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; snps,dis_u3_susphy_quirk; - dr_mode =3D "host"; }; }; =20 @@ -716,7 +715,6 @@ dwc_0: usb@8a00000 { snps,hird-threshold =3D /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; snps,dis_u3_susphy_quirk; - dr_mode =3D "host"; }; }; =20 --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F08623C278A; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; cv=none; b=sgLxiVOgyR5mPgaENEPu4wIablC8r9j/NxyU+dWE91RPzIRO9QQDDUqF4HKL22b2B3Zn2yWEaBYuQRFCCBpAMcZ17CF6KuDpPb7cAKB1z7al7PTjtJqVShNUVaMkU9KPiHgmNqP9YR7KZnIopg7PNHvBuliw4vrjOMLRo/FBIjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; c=relaxed/simple; bh=0svs8ahh0j1q3z35L2oG653ooANpfHSBFq1ld4+10Es=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=su87yplSvJdPMAoN2iosKs/ky4pfcipLACApUhKu7jRFi7f/mldq9L8yLnpvikRykswXKW3FfAl/KvF4KrHPukH++F5HUNOGkn69yNhvonw8BC6eckOeWh1jUlYseYgSSnP36ktje8AAkecAzKS2JkJRaYZeV4D3uuBzYKX7hbQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Yavy/BoH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Yavy/BoH" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9F7DBC4AF0F; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=0svs8ahh0j1q3z35L2oG653ooANpfHSBFq1ld4+10Es=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Yavy/BoHdBA98TJTCj6rJrrsoREAMXzdoqOVAZms+l1X9wBaIhfKxWifDJ396JVJH kSP/BrT7c3LgcHSDEXupdX0f4N0wPhGsuu1iGpw6t7qf+BQclcenJq8LD6m391AJQm u/F/lr8pCujA0KZWtzlbEwdBLn9tUK6X2n+8XtM9KT9ZTbuc6KUHBY9ZBJXEI66/1x 7Yzko/LNG4slrXnRZnEdAv+5YlNsHszeQJp6mFXJHZb8t5q07bVgeqvtZdgmEvKjV2 WUc91dSpwNUd0cG2NrRaYfApohkmb7Dy5VfwzQI0RlBrPTPTKRHXPMPm7tEYFmbmSg t1PwlmYzNwWwA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FBCFC79F9F; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:46 +0400 Subject: [PATCH v2 07/10] arm64: dts: qcom: ipq6018: Flatten usb controller nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-7-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=4941; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=s4UIVKnCdrIeTfKhR6sRYnJFlZ9SJqbUehANTZdNRxY=; b=MSqkGdVpjZIXHuTxfz7dOh264ixtrTAy2AaoxHkKnJEEvsejUrZ48AYMS25SVxaiYN5bhcHok JuRxwX3l5CJBQ6IQgdgb6D7RkoV1UiIDCvtw6oeIvzsEMi7GiZUoEKQ X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller nodes and update to using latest bindings and flattened driver approach. Signed-off-by: George Moussalem --- arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 -- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 93 +++++++++++++-----------= ---- 2 files changed, 42 insertions(+), 55 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot= /dts/qcom/ipq6018-cp01-c1.dts index a366be17c251..9c69d3027b43 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts @@ -48,10 +48,6 @@ flash@0 { }; }; =20 -&dwc_1 { - dr_mode =3D "host"; -}; - &tlmm { i2c_1_pins: i2c-1-state { pins =3D "gpio42", "gpio43"; diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qc= om/ipq6018.dtsi index c02110ad9cb0..4f5f8b628bf2 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -423,12 +423,10 @@ pwm: pwm@1941010 { status =3D "disabled"; }; =20 - usb2: usb@70f8800 { - compatible =3D "qcom,ipq6018-dwc3", "qcom,dwc3"; - reg =3D <0x0 0x070f8800 0x0 0x400>; - #address-cells =3D <2>; - #size-cells =3D <2>; - ranges; + usb2: usb@7000000 { + compatible =3D "qcom,ipq6018-dwc3", "qcom,snps-dwc3"; + reg =3D <0x0 0x07000000 0x0 0xfc100>; + clocks =3D <&gcc GCC_USB1_MASTER_CLK>, <&gcc GCC_USB1_SLEEP_CLK>, <&gcc GCC_USB1_MOCK_UTMI_CLK>; @@ -441,26 +439,25 @@ usb2: usb@70f8800 { assigned-clock-rates =3D <133330000>, <24000000>; =20 - interrupts =3D , + interrupts =3D , + , ; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy"; =20 resets =3D <&gcc GCC_USB1_BCR>; - status =3D "disabled"; =20 - dwc_1: usb@7000000 { - compatible =3D "snps,dwc3"; - reg =3D <0x0 0x07000000 0x0 0xcd00>; - interrupts =3D ; - phys =3D <&qusb_phy_1>; - phy-names =3D "usb2-phy"; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + phys =3D <&qusb_phy_1>; + phy-names =3D "usb2-phy"; + + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 sdhc: mmc@7804000 { @@ -668,21 +665,18 @@ qpic_nand: nand-controller@79b0000 { status =3D "disabled"; }; =20 - usb3: usb@8af8800 { - compatible =3D "qcom,ipq6018-dwc3", "qcom,dwc3"; - reg =3D <0x0 0x08af8800 0x0 0x400>; - #address-cells =3D <2>; - #size-cells =3D <2>; - ranges; + usb3: usb@8a00000 { + compatible =3D "qcom,ipq6018-dwc3", "qcom,snps-dwc3"; + reg =3D <0x0 0x08a00000 0x0 0xfc100>; =20 clocks =3D <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, - <&gcc GCC_USB0_MASTER_CLK>, - <&gcc GCC_USB0_SLEEP_CLK>, - <&gcc GCC_USB0_MOCK_UTMI_CLK>; + <&gcc GCC_USB0_MASTER_CLK>, + <&gcc GCC_USB0_SLEEP_CLK>, + <&gcc GCC_USB0_MOCK_UTMI_CLK>; clock-names =3D "cfg_noc", - "core", - "sleep", - "mock_utmi"; + "core", + "sleep", + "mock_utmi"; =20 assigned-clocks =3D <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, <&gcc GCC_USB0_MASTER_CLK>, @@ -691,31 +685,28 @@ usb3: usb@8af8800 { <133330000>, <24000000>; =20 - interrupts =3D , + interrupts =3D , + , , ; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "ss_phy_irq"; =20 resets =3D <&gcc GCC_USB0_BCR>; - status =3D "disabled"; =20 - dwc_0: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x0 0x08a00000 0x0 0xcd00>; - interrupts =3D ; - phys =3D <&qusb_phy_0>, <&ssphy_0>; - phy-names =3D "usb2-phy", "usb3-phy"; - clocks =3D <&xo>; - clock-names =3D "ref"; - tx-fifo-resize; - snps,parkmode-disable-ss-quirk; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + phys =3D <&qusb_phy_0>, <&ssphy_0>; + phy-names =3D "usb2-phy", "usb3-phy"; + + tx-fifo-resize; + snps,parkmode-disable-ss-quirk; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F31443C2B82; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; cv=none; b=P//WaLIv+pERRHZFXkhMudS6I89b81HX05SIfiTltt+Vy0KUaZAhdzT6teC86f7HUQrqsQPu7pNSjaJJZlIpPRc2bWp1TF1WnV0ODiBQaDAJLDC1736oFoM4nIvNG40rh6JYoEqifNHK16Fq928EXlgZRBCcGGtR4OIVdpGQrqY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; c=relaxed/simple; bh=yePW7swJKp/CoAXYJIlRrxTJvJHLYrZ5g7dI2UeDTAs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V9qk6QrximIUoQLpT7ia1anDp1uEwaxduYQA9jQRmRsH7g99oyX4q+UPdsGu2xEhANzgzb2AxJA1SIefuG183oDROLUkREgs1nYliILuu8BYqeb7Yns42th7O66YmPUcQbJKRpzO7gVWpxDYYrmeE58m5Cme7mTvzI7ySSDHSw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NVOGJkjT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NVOGJkjT" Received: by smtp.kernel.org (Postfix) with ESMTPS id B1E12C2BD05; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=yePW7swJKp/CoAXYJIlRrxTJvJHLYrZ5g7dI2UeDTAs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=NVOGJkjTSe7zrqAsZWbWrLRfZxMjlL5Eb6hl/1G3dGC2zR67jxFSnuj7OW1xBm91s U3lSlkgLcnQhzVM4ZHE5HF3G5Iwi1AcUa56KXbTAT8FF/pa25Vwpma6nP919veqOoL wNyj7AzWjIr9YAbqQuUrj3PJ5MF0hCkHszcmVVv5Jq03xoMhtRL8d2gfCj8L0pEw9m Inu3wNGrxWMdCRVYbK/CVKAqdLFqHpr25JatQkdqR9RfAfFFcA56qZNF/HvBsP3cpU UPN7SU4n0vGgJkDaRDflQl1otAA6bB2bbEKXEsx5Y/2x64EbGJjRVv14qCihYRU/Lj 3jQludKMeGaUQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFF8C79F9E; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:47 +0400 Subject: [PATCH v2 08/10] arm64: dts: qcom: ipq8074: move DR mode to board DTS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-8-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=1442; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=e2bv63iiEX2vz7ZO+5BDlb9OpNBUY7Sx/1y6B5CVxhA=; b=awhmJK0WkTBNEITZA3WInbCpwJZGXBfTGtJXBZErRwIMc5nvzUO/j49DVivooSLA4rV1czXcJ E36w67eqmwYB5v99mG9qWgIapUdL8va1/5ywp0kJul/CfI33VOQjUlN X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Both controllers are DRD capable, but DR mode currently set to host mode in the SoC dtsi. Unset it in the SoC dtsi and set it as host mode in the hk01 board DTS file. Signed-off-by: George Moussalem --- arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 8 ++++++++ arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dt= s/qcom/ipq8074-hk01.dts index dea5ece600d4..75827676bde9 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts @@ -52,6 +52,14 @@ &blsp1_uart5 { status =3D "okay"; }; =20 +&dwc_0 { + dr_mode =3D "host"; +}; + +&dwc_1 { + dr_mode =3D "host"; +}; + &pcie0 { status =3D "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qc= om/ipq8074.dtsi index 75a5ae30d966..5c57d9cd72fc 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -671,7 +671,6 @@ dwc_0: usb@8a00000 { snps,hird-threshold =3D /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; snps,dis_u3_susphy_quirk; - dr_mode =3D "host"; }; }; =20 @@ -721,7 +720,6 @@ dwc_1: usb@8c00000 { snps,hird-threshold =3D /bits/ 8 <0x0>; snps,dis_u2_susphy_quirk; snps,dis_u3_susphy_quirk; - dr_mode =3D "host"; }; }; =20 --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F054E3C2785; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; cv=none; b=Jehdj8k/6n09g8C/E9Qx3QlJu6c02koDxkC2osY5htm8t5KLR/H08JpuE8WjgMZZsQTRYFxnlYk+M20J6KNihXgIZuVZeNIw7Gf/Y5Rqx3MH2lbpEZyGmiWgmj3l4jqE+wwHt6NJo7T45Pck0N06chbB9dByT3Sw3TZ9NrASVJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; c=relaxed/simple; bh=xoukKYFvKtH0yVYC52oTXyZxdkrrVfGnS9OTDeei6DU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=snDgewExtimLuCYnZhtbac5QBLff0lEogIcu766zscdELd1ot0i6u+q22j9RdJscEcNhc3RQD7uhw21RIF4sUXDUXdC8fd9j+zKHLw4aoV8xqQScFnQ9hRHjP/EMTpfBHgr50AHGqRU0TGLCFayMjX3xlbCvFC+C7f0NxmmxdN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kn+OkcOP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kn+OkcOP" Received: by smtp.kernel.org (Postfix) with ESMTPS id C4249C4AF0B; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=xoukKYFvKtH0yVYC52oTXyZxdkrrVfGnS9OTDeei6DU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Kn+OkcOPdN8EFLsV4zcvm13MTEpvam1I6h/zZ0Btf31RvAWy1H+4Kl89xuoounP73 y4cztt6CYdV0ySpFG0/X5ZhpFmpHLXsdnj04+zTvfzkpSL1M/BcACVzinFXSocRx1+ gR7cXHixKJpSzkbv8XaFUP6ycb3rvd8WMKsgZUUwcie/loewSU3vFNg+fPRzaqoMp7 14AnZMMc0AUBigfzoRpk/hcV7XGtiJgM/BiS9dylca6Eiz8uGEkht4XYqmuZI9vC5P xxBhCioEywuTtl2QCGZGEYAbko/xDwj3PT8WgNCTM5u97+eH9Jll61qLSejK21jHg8 B97eXRBG0O8cQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B04DBC79F8B; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:48 +0400 Subject: [PATCH v2 09/10] arm64: dts: qcom: ipq8074: Flatten usb controller nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-9-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=5701; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=uxth14kMmQNJdlzw9mv+WW7U6sqEqBSC4dgsram9iyE=; b=QHP4STHYhNi+VOXHr7Q67p8tXG9z8jAYzvGGHm6FIi9blrP+CG6GJJQsDysbh9O7X6o3WI6CF sErwi8agU/HDStO9+XZVBHJbRKJJWJxXJcjOKYMeK2nnv6iVCupisQh X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller nodes and update to using latest bindings and flattened driver approach. In addition, fix indentation of properties in both nodes. Signed-off-by: George Moussalem --- arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 12 ++-- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 108 ++++++++++++++------------= ---- 2 files changed, 54 insertions(+), 66 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dt= s/qcom/ipq8074-hk01.dts index 75827676bde9..2a3b497f9598 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts @@ -52,14 +52,6 @@ &blsp1_uart5 { status =3D "okay"; }; =20 -&dwc_0 { - dr_mode =3D "host"; -}; - -&dwc_1 { - dr_mode =3D "host"; -}; - &pcie0 { status =3D "okay"; }; @@ -125,9 +117,13 @@ &ssphy_1 { }; =20 &usb_0 { + dr_mode =3D "host"; + status =3D "okay"; }; =20 &usb_1 { + dr_mode =3D "host"; + status =3D "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qc= om/ipq8074.dtsi index 5c57d9cd72fc..45745b58495c 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -625,102 +625,94 @@ qpic_nand: nand-controller@79b0000 { status =3D "disabled"; }; =20 - usb_0: usb@8af8800 { - compatible =3D "qcom,ipq8074-dwc3", "qcom,dwc3"; - reg =3D <0x08af8800 0x400>; - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; + usb_0: usb@8a00000 { + compatible =3D "qcom,ipq8074-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08a00000 0xfc100>; =20 clocks =3D <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, - <&gcc GCC_USB0_MASTER_CLK>, - <&gcc GCC_USB0_SLEEP_CLK>, - <&gcc GCC_USB0_MOCK_UTMI_CLK>; + <&gcc GCC_USB0_MASTER_CLK>, + <&gcc GCC_USB0_SLEEP_CLK>, + <&gcc GCC_USB0_MOCK_UTMI_CLK>; clock-names =3D "cfg_noc", - "core", - "sleep", - "mock_utmi"; + "core", + "sleep", + "mock_utmi"; =20 assigned-clocks =3D <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, <&gcc GCC_USB0_MASTER_CLK>, <&gcc GCC_USB0_MOCK_UTMI_CLK>; assigned-clock-rates =3D <133330000>, - <133330000>, - <19200000>; + <133330000>, + <19200000>; =20 - interrupts =3D , + interrupts =3D , + , , ; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "ss_phy_irq"; =20 power-domains =3D <&gcc USB0_GDSC>; =20 + phys =3D <&qusb_phy_0>, <&ssphy_0>; + phy-names =3D "usb2-phy", "usb3-phy"; + + snps,parkmode-disable-ss-quirk; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + resets =3D <&gcc GCC_USB0_BCR>; - status =3D "disabled"; =20 - dwc_0: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x8a00000 0xcd00>; - interrupts =3D ; - phys =3D <&qusb_phy_0>, <&ssphy_0>; - phy-names =3D "usb2-phy", "usb3-phy"; - snps,parkmode-disable-ss-quirk; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + status =3D "disabled"; }; =20 - usb_1: usb@8cf8800 { - compatible =3D "qcom,ipq8074-dwc3", "qcom,dwc3"; - reg =3D <0x08cf8800 0x400>; - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; + usb_1: usb@8c00000 { + compatible =3D "qcom,ipq8074-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08c00000 0xfc100>; =20 clocks =3D <&gcc GCC_SYS_NOC_USB1_AXI_CLK>, - <&gcc GCC_USB1_MASTER_CLK>, - <&gcc GCC_USB1_SLEEP_CLK>, - <&gcc GCC_USB1_MOCK_UTMI_CLK>; + <&gcc GCC_USB1_MASTER_CLK>, + <&gcc GCC_USB1_SLEEP_CLK>, + <&gcc GCC_USB1_MOCK_UTMI_CLK>; clock-names =3D "cfg_noc", - "core", - "sleep", - "mock_utmi"; + "core", + "sleep", + "mock_utmi"; =20 assigned-clocks =3D <&gcc GCC_SYS_NOC_USB1_AXI_CLK>, <&gcc GCC_USB1_MASTER_CLK>, <&gcc GCC_USB1_MOCK_UTMI_CLK>; assigned-clock-rates =3D <133330000>, - <133330000>, - <19200000>; + <133330000>, + <19200000>; =20 - interrupts =3D , + interrupts =3D , + , , ; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "ss_phy_irq"; =20 power-domains =3D <&gcc USB1_GDSC>; =20 + phys =3D <&qusb_phy_1>, <&ssphy_1>; + phy-names =3D "usb2-phy", "usb3-phy"; + + snps,parkmode-disable-ss-quirk; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + resets =3D <&gcc GCC_USB1_BCR>; - status =3D "disabled"; =20 - dwc_1: usb@8c00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x8c00000 0xcd00>; - interrupts =3D ; - phys =3D <&qusb_phy_1>, <&ssphy_1>; - phy-names =3D "usb2-phy", "usb3-phy"; - snps,parkmode-disable-ss-quirk; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0 From nobody Sat Sep 26 02:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B27D3C4B6A; Sun, 6 Sep 2026 03:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; cv=none; b=PONOiDLx4GKTB1nicxdLZGB+sOYcaMsQHvgIBc/yCoog3u3rpmJ273OjuTTnB0HakuBSdJwjC1ksp1K1d5GGrTmPVvrvA6p0aYvrIPwOy3Aa714mkWuEgrvmIxubr8dDPXnCsvHG0VOJxY7TCSW/MaY0lTKbUJ3lUSyx1ZgGPJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788666767; c=relaxed/simple; bh=8tDaH+3AXpsTJ7Hi8IWULF3TZ/VQvjF6t0tc8cX2NIU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LOnyrYbwG3GP05op5tb8rdR3fondJlY4feJsN2h3kYEm2i+oxQnpvfqQ7BX/VGJ0YGv3LbO6jIV+ow0B742y3W47hSGvMvB35py+FtVDcHatoopqgz2XJHrP/CSo9618OIvWcOK5Ta4V3QhAjHjutEovrmKO9pUx5cOOyswHksU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i0OjbjO2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i0OjbjO2" Received: by smtp.kernel.org (Postfix) with ESMTPS id D46B4C32781; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788666766; bh=8tDaH+3AXpsTJ7Hi8IWULF3TZ/VQvjF6t0tc8cX2NIU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=i0OjbjO2iAhKeg40KmY3QHl7m/elF8zT+bCg9vZrLBeYwjNs57aBKN+oTRsWtrGeU E2JZa2p3GFEPYng3ogqd738Oo300svjG7JqG4Gw/YUbcRo3oUk9NrCz2kxwNeR1TpE Vlk/ikDqS3MTAfUjij+RDRyr6QS6tUoBb/oo91YhSoFtbeWyH9eQeg9ouuOmu5xaoA VIohfw2bOyfQyjvMs7Fr1PRCVofzZeqyvilIa8oKfDO+ARYSzKZQmE0s8R07kh//Rh J6fWMzKWdtZboePwvwnfw1golGnxbKAdQ6z3c5a2Wt+s68iaSgnF/93cB/zPPH8Bvr A7eBCYqLJHXQg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1485C79F91; Sun, 6 Sep 2026 03:52:46 +0000 (UTC) From: George Moussalem via B4 Relay Date: Sun, 06 Sep 2026 07:52:49 +0400 Subject: [PATCH v2 10/10] arm64: dts: qcom: ipq9574: Flatten usb controller node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ipq-flatten-usb-v2-10-dab83120b10a@outlook.com> References: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> In-Reply-To: <20260906-ipq-flatten-usb-v2-0-dab83120b10a@outlook.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan , George Moussalem X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788666763; l=3122; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=T+nwJe6bIqHYvmzJcEpOj0yFVwDqzzeofqVbUpwIM9Y=; b=dVFjIdgAi/4zW6P+88qDIOpfpFflRIugSSZ4sFus5MvxEawlJWnLUVgsVHmEy/mWY/FVg6d21 dJNn52Sfof7BVewmCehW3pL2P0LnZTvhEWRzhtAPo92+kGRyY1VUc5j X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Flatten usb controller nodes and update to using latest bindings and flattened driver approach. Signed-off-by: George Moussalem --- arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 6 ++-- arch/arm64/boot/dts/qcom/ipq9574.dtsi | 40 ++++++++++----------= ---- 2 files changed, 19 insertions(+), 27 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/= boot/dts/qcom/ipq9574-rdp-common.dtsi index 62877b46f9b3..0d06a838c233 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi @@ -252,10 +252,6 @@ flash@0 { }; }; =20 -&usb_0_dwc3 { - dr_mode =3D "host"; -}; - &usb_0_qmpphy { vdda-pll-supply =3D <&mp5496_l5>; vdda-phy-supply =3D <®ulator_fixed_0p925>; @@ -272,6 +268,8 @@ &usb_0_qusbphy { }; =20 &usb3 { + dr_mode =3D "host"; + status =3D "okay"; }; =20 diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qc= om/ipq9574.dtsi index 5a5bda5f21a1..cf2eacb16c36 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi @@ -756,12 +756,9 @@ usb_0_qmpphy: phy@7d000 { status =3D "disabled"; }; =20 - usb3: usb@8af8800 { - compatible =3D "qcom,ipq9574-dwc3", "qcom,dwc3"; - reg =3D <0x08af8800 0x400>; - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; + usb3: usb@8a00000 { + compatible =3D "qcom,ipq9574-dwc3", "qcom,snps-dwc3"; + reg =3D <0x08a00000 0xfc100>; =20 clocks =3D <&gcc GCC_SNOC_USB_CLK>, <&gcc GCC_USB0_MASTER_CLK>, @@ -780,32 +777,29 @@ usb3: usb@8af8800 { assigned-clock-rates =3D <200000000>, <24000000>; =20 - interrupts-extended =3D <&intc GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended =3D <&intc GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names =3D "pwr_event", + interrupt-names =3D "dwc_usb3", + "pwr_event", "qusb2_phy", "dm_hs_phy_irq", "dp_hs_phy_irq"; =20 resets =3D <&gcc GCC_USB_BCR>; - status =3D "disabled"; =20 - usb_0_dwc3: usb@8a00000 { - compatible =3D "snps,dwc3"; - reg =3D <0x8a00000 0xcd00>; - clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>; - clock-names =3D "ref"; - interrupts =3D ; - phys =3D <&usb_0_qusbphy>, <&usb_0_qmpphy>; - phy-names =3D "usb2-phy", "usb3-phy"; - tx-fifo-resize; - snps,is-utmi-l1-suspend; - snps,hird-threshold =3D /bits/ 8 <0x0>; - snps,dis_u2_susphy_quirk; - snps,dis_u3_susphy_quirk; - }; + phys =3D <&usb_0_qusbphy>, <&usb_0_qmpphy>; + phy-names =3D "usb2-phy", "usb3-phy"; + + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold =3D /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status =3D "disabled"; }; =20 intc: interrupt-controller@b000000 { --=20 2.53.0