From nobody Sat Sep 26 01:05:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 088023D3308; Sun, 6 Sep 2026 13:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788700754; cv=none; b=aQFHSyW4++9X8ULohDm/5DTilX2y2uYOEJK1M2pWqoOnytH+Sr2nYd5ZbwjORN2j6AeZGX7JDmpVp5EZ7TlraTZQMLc0Q60pTPwswdrFgAK/ZMD0gp5bRvn10UBEti3IiknSAsEMv4cvYgHYMO2bwVKukhjLgRX0ggtMR9a5+hU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788700754; c=relaxed/simple; bh=kNVsV8jEUDBx8YJnZ3D2TG/jephKjsRz2aHGkVRdHyY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BTCF+8B0uJT16euPfCcoq9+mnkwuTk2/xYSVsBDG7DYPI2FO9V5Q/y+b4ma1hojbJuPqQqqgXQ1ojPMmTtgA7Eg25uO1RFFlEhPk3zQPvSUDHYzff3C7UMr9VKvayDy4bpxBMT/0ipVIrVopvKS8H9+8uMj5+S/IY+2GcRzztEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q2jRVWxL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q2jRVWxL" Received: by smtp.kernel.org (Postfix) with ESMTPS id 96DFDC2BCB8; Sun, 6 Sep 2026 13:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788700753; bh=kNVsV8jEUDBx8YJnZ3D2TG/jephKjsRz2aHGkVRdHyY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=q2jRVWxLoaqHVInd5vI4zZO1ZcB60SvCJy1PrwphLvIPHde2vEkAWfsVvg3u6TfK2 +N6KzkdINtxC7NFtBYgAxLT+BatYZvjoS2K/lS7n0y0afAIb7kP1G33kYxszxEilY9 YTcW5vwZ0+34eLYHNRF6Mbu8RCQ48eWFn0rG+taTKty8NkrZnG+ZVjDHEiK5omLuyk bp1A614v2vMQhfqRGW7+letSkeUUzYZpHDKdNTE7PoexrkK7CidTHXYDQgD2zslEYQ vTfvgTGfZn1I+C0PiRjcvMzSG7EWY6C1EFvPJGIM3dnOB0XdWBOqgcvcJA6GGi+pXA wc4S6NQVtE0oA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AD2C79F99; Sun, 6 Sep 2026 13:19:13 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sun, 06 Sep 2026 15:19:02 +0200 Subject: [PATCH 1/3] drm/panel: ebbg-ft8719: Set prepare_prev_first Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ebbg-ft8719-fixups-v1-1-4e846510cad1@ixit.cz> References: <20260906-ebbg-ft8719-fixups-v1-0-4e846510cad1@ixit.cz> In-Reply-To: <20260906-ebbg-ft8719-fixups-v1-0-4e846510cad1@ixit.cz> To: Joel Selvaraj , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sam Ravnborg , Marco Mattiolo , Linus Walleij Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg , Casey Connolly , stable@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1210; i=david@ixit.cz; h=from:subject:message-id; bh=MdKS4MaN+wl5Cm+tdhGjh1Y6pdj5edF/ffF4+200w9w=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqnWhPI76LaG4om4ZpsbFRORTnkEMFZ4suxTmK5 QUqeYXA9JSJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCap1oTwAKCRBgAj/E00kg cga2EADLwprPfozo4mnQ3SHTqkt5yXwlnKlXeLiAuz3rs7kylKD/ov9rwC4F9et4v1qo5i9d5Vo bQ86yjgrFQhjW10D/8T5tgK/r037RdK2WMNtlj4j8yqIYOzepyZ5DSyo1tXTYSf7rtdgoXfS363 PsuDFzL6GSfairKq8AbzjgyCRuZg1N4/ankH9+1vYBP5Z14fAmo4jnEJgktYWK7gK4DQWb9zvOb U5XjoyVpfjO7pXsHgwV9ejQ/t3Pz5dZspJCtDSLywJl+v0qNUnPwDOJv7pdsKLyuJm6VZyGDFjV Cgr1U1jO2rB72t59pCQQU+0uRux/GafvV/IL5orsNLxrf/2Pi8gjYcRWWG52FzWzjiSh2CLCbg7 bzGIxDGxHJVsfXXgC+WgXnrqb7EmIbcppOCvXggTSJ8fDPC1a6AHol5SxyZThGXTIhDTWND7rrw S8oX2llUvvtPMXR5nG3vtd2y+BByn4E0Xg13NG3lsO5xtRHGxN3EeFx5QnnB6Tkr/0tpf+SjwBI GznskK6hFt3ABwr49l/yFzFtJdYCp0a7YIQ4J/XEPwxqvCB9z9RQUgrQkf7u+8NdsPfQmeXyTXV m02TQhR89R6SPmvkhfKwgHHUipoRuiiisBxmoth875tFgRXhCPswQPB2WFIbVfhbvzlEJmyKRti WeFbOiq9oK3gZpw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Casey Connolly This corrects the host initialisation sequence so that we can send DSI/DCS commands in prepare(). Cc: stable@vger.kernel.org Fixes: b00de0e237da ("drm/panel: introduce ebbg,ft8719 panel") Signed-off-by: Casey Connolly Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c b/drivers/gpu/drm/pa= nel/panel-ebbg-ft8719.c index fb9f9f42be4f2..1ab09c50a6306 100644 --- a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c +++ b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c @@ -193,16 +193,18 @@ static int ebbg_ft8719_probe(struct mipi_dsi_device *= dsi) ctx->dsi =3D dsi; mipi_dsi_set_drvdata(dsi, ctx); =20 dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_CLOCK_NON_CONTINUOUS; =20 + ctx->panel.prepare_prev_first =3D true; + ret =3D drm_panel_of_backlight(&ctx->panel); if (ret) return dev_err_probe(dev, ret, "Failed to get backlight\n"); =20 drm_panel_add(&ctx->panel); =20 ret =3D mipi_dsi_attach(dsi); if (ret < 0) { --=20 2.55.0 From nobody Sat Sep 26 01:05:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 086DA3D1AA6; Sun, 6 Sep 2026 13:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788700754; cv=none; b=PFtNeVw10Cmc6O1vbvoBcVNsL9HjL/X4JfIaAJQpA0nI4ko38ya1VsS+cUiMccUkVxsPJR1O1GMORhmhrMiTdySTlNJPQkCex4yLTEy+VeP0Lqycwfld+SWNrDwf6jkB1zAvMv5lCQOOxydT3kS6/zyHVIUzf3Dqo+wsZliCr1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788700754; c=relaxed/simple; bh=gbjy5RTDqdhCv6DILtDb7fYiIvaobCHJMRXApRCH1z0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LQ7goMnmXPmKV0ynlKkJ233eRVqlEuCBw3d1cDmOAosKS20X4KJgz90GayHwVkUF3JuavBAEr8y9NyEh2casU+J70G8/KNlkorQU6JWmyh970H4DmmORZ3h0JOn8j5a1C5oKAr97+a4dFl7JbhNvZa2mWg5atJX/7QU2PonON2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G8wA+Ii1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G8wA+Ii1" Received: by smtp.kernel.org (Postfix) with ESMTPS id AD763C2BCFD; Sun, 6 Sep 2026 13:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788700753; bh=gbjy5RTDqdhCv6DILtDb7fYiIvaobCHJMRXApRCH1z0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=G8wA+Ii1SqM5ZEW9lgftcqJknYH9oOoIarL4SI7aYBCJFGXzJ4r7FVjNBK2iXniLf 5eq0F8FmXN+55mllFo+OzDf2LMy/Zs86vmBSDipa7wYLJpDHKek1Z3HaLhhOsrdctH g/EFbOyMLSpNNUrZO0qbMEVZV2oMUcSGY5kaiXh/gRjXFp5AaMg8PbkA0RDtMpjcm/ v3g31HzvsdQGXW9f1u+jWkdhZLrOx9cioz7ymE3d5lYbWnwOCeoECD2relGMcdq/Cv G02tlnWbR11oPLsHWOQ+vcqpvTcec2+pgze1gW7vVCRl/eloKFd5VS8XFj5wwazkFg OW82qW69EDvfg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 878F5C79FA0; Sun, 6 Sep 2026 13:19:13 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sun, 06 Sep 2026 15:19:03 +0200 Subject: [PATCH 2/3] drm/panel: ebbg-ft8719: Fix the MODULE_LICENSE() string Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ebbg-ft8719-fixups-v1-2-4e846510cad1@ixit.cz> References: <20260906-ebbg-ft8719-fixups-v1-0-4e846510cad1@ixit.cz> In-Reply-To: <20260906-ebbg-ft8719-fixups-v1-0-4e846510cad1@ixit.cz> To: Joel Selvaraj , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sam Ravnborg , Marco Mattiolo , Linus Walleij Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1192; i=david@ixit.cz; h=from:subject:message-id; bh=K+6x5A7ftBFeZ8okSqt/u0WpvagsMUKZ/4i4XfBmirE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqnWhQKxw/18Yi3JTzGNeX5AKT86t+qacac3fYZ YrXf92tobCJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCap1oUAAKCRBgAj/E00kg cqHbEACUzO5xpCO6DJHKL+wZE4cGM0+6FVzSI2CJiTlBmx7ivsSVlVTUm9VzMpRoGmMoPmep8mx jk+g02tU1yTP1uoMxWxLsN1BGU6v42Yelh3j3h8t0T/Cwi/HsYSuZXE07fG9EErm1QZoe/lugHI jf8WfnXlQy/2rcadTEYH5huYkCyFmQ6dHZ4kt2LBidufQ+P603p8b+tqX5IfkN/Zl2ZMJReyPev 2D1RgK3VGbH0euiZXZPh9ukLP/kM5fVzAaYfbVGzNP5Hm7Tj5GL18ZUtMuPsgfToPSxwHIgagYR COdrUowbB7a6aJHZ92j1b7G9bSz2UODSzPys2c02J705RWqU0/lCfQBL2wuvlO4hMVN79yAsHW+ jsynWFbsb0gWjkn6HLi3AEVGLtIQULjbCiQp7JIdcaRGput6HEp8+si02v8OJVGmR0d+mYHpFpt eqyvezPNajC2GDVPFTNCPFpNy6VnZn0AcsYKs86cR4Xv6Vt8IzF/zyVceSHZ1Hf7gUs6cTUUuSI Vpuj2srixPiX/6oWFubE0N1BzhClsJ7sTIgnmYGIbn7iNGPyk3qoPPwvjNPURDlgsFLOdZPboup 7fFgqJ2duCnQZApnt+1sfIzL67YANFVfiMn/pkWq54ohlBO8JwUD2kRn0ttMWBMJVKZsPA/CFC4 zNaES1kh101L4AQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Replace the bogus "GPL v2" with "GPL" as MODULE_LICNSE() string. The value does not declare the module's exact license, but only lets the module loader test whether the module is Free Software or not. See commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") in the details of the issue. The fix is to use "GPL" for all modules under any variant of the GPL. Signed-off-by: David Heidelberg Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c b/drivers/gpu/drm/pa= nel/panel-ebbg-ft8719.c index 1ab09c50a6306..14982263a94f1 100644 --- a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c +++ b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c @@ -241,9 +241,9 @@ static struct mipi_dsi_driver ebbg_ft8719_driver =3D { .name =3D "panel-ebbg-ft8719", .of_match_table =3D ebbg_ft8719_of_match, }, }; module_mipi_dsi_driver(ebbg_ft8719_driver); =20 MODULE_AUTHOR("Joel Selvaraj "); MODULE_DESCRIPTION("DRM driver for EBBG FT8719 video dsi panel"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL"); --=20 2.55.0 From nobody Sat Sep 26 01:05:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 087733D1CB5; Sun, 6 Sep 2026 13:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788700754; cv=none; b=HKSKO6XoZsn1XH6AXn3aXGJGclkYNP/Z/ob7zUI0b8NV8cWeFpQQFXQlnJvC+WiLgRrkYbJLZZ3KcbDsUQ90ZG7sbBcAWPNaDy7GYKc5T56gxcpjvqCYJVw9XfCkAhR4mAI2M/C3/X+s1e+5vv7AC+SoJtAWvUv/dgMN2xnDZhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788700754; c=relaxed/simple; bh=W8YOe2fo/FY8tQcyn3AaXI/DbctGrOF/V/GQL7T1bdk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EsOX4SBP7cF9nsrgdicPfA9T4VlRM3fGbFyZ8pKbSL3GyDZfMeo1IbOHA06LRMObdSRpmkYqiwZTaQzrtjUTEJ2orW5F5CrjM17JAzENYtpXYEEBDs/zjWq7vLQOSZr63FUF5AVvnYbRkK3B/9UapJe5csblFx0p8+rW3+1MZp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k+X8QwkZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k+X8QwkZ" Received: by smtp.kernel.org (Postfix) with ESMTPS id B5153C2BCFB; Sun, 6 Sep 2026 13:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788700753; bh=W8YOe2fo/FY8tQcyn3AaXI/DbctGrOF/V/GQL7T1bdk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=k+X8QwkZryQyOeRWzOnqsd/DBItTFsgJ+Be16voLpsHXzY2zIc5dUlGwNth3YxAOh gpB1PJqvUJJRn2gpo7HRqBm1Kgm+t7A52JpE9LP+fy/GRol0G4IVYpe8NqDNaasW9W gdAlqq8KQRM8CiFgTDtYvGs6dYzluGdNdMN//Bk3n69XJ/VckrYywA5H/HciLoC1t5 QZzKXzrltsQy6RQ/OhGyOYkIO7OLaDHYQwmjBtKjVqIkap1oRXaRvohl2hGjO11j1y 7A/ymBda7TJRXWVJCZlSNIzFqC94KN25UdcZIcUIbZoPrQn/WW3+8ZhImZllOLpAEm 3frOMODs7Cfuw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA3FC79F85; Sun, 6 Sep 2026 13:19:13 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sun, 06 Sep 2026 15:19:04 +0200 Subject: [PATCH 3/3] drm/panel: ebbg-ft8719: Split initialization into enable/disable fn Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-ebbg-ft8719-fixups-v1-3-4e846510cad1@ixit.cz> References: <20260906-ebbg-ft8719-fixups-v1-0-4e846510cad1@ixit.cz> In-Reply-To: <20260906-ebbg-ft8719-fixups-v1-0-4e846510cad1@ixit.cz> To: Joel Selvaraj , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sam Ravnborg , Marco Mattiolo , Linus Walleij Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3544; i=david@ixit.cz; h=from:subject:message-id; bh=p73JyBK1o/C+mzNNbgxiVSAcxnHLj7kGgIMlHReDhbk=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqnWhQKcmvi4k32WSvJMa+9RTRNnsJ3444kkldI UU8+0T300KJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCap1oUAAKCRBgAj/E00kg cmfJEADMw74MxiUc/eG+RdvFVRxScOnT/2Uk1muqQih/IgZrYeBDR02nIKGAIndxVVWLrz+HCCF RfC+ndb4uF/F5GIaerIr1X4jZaASuEz8tUVGpvJGJPJnd1Y5wxDDgf424BaVS2NaCF9ee1zqTe0 2C8C2XoAJo2W3zwKM06HcbskeHWHW4ajhk2BohJ/BBi7ii6PZnu64QiPAql7VVly7RXbad1b5s8 G1I2FMVuI2X7ELCeBg04M71JzuHMkKB7wbTKhVaUIwmek0Q/2jZkZ6v/9jrgVDGx9/z1yKTtWCo 9uLfJwpjRBPmN/JFfAkg17KPxgem/RS+G5h3N0fXA/plDfY1ohkqnF81/pA6Rmr2GwIjV5pOfPy 4uin18T+D4Io/XXNxVB8wVgwqqdvDnPl4JHdj1oP4b0UI137/GyuTi4LWyPfADKu+U5mD35vUNs Q/7KcDDROCXZpCZauMzP3uviiEuHTb90wnR9FE9qUc5Xp03A7WF0rtjbV8HVnZa4wpC1Q92WziZ kTmDBqFpeOshhnONb0K6cStqNlNBkHy4eY7RvbnzzkezoSACSCoxBtqapbIrtJ4qE3NQ2cCOtNn tct4OV2wVskppsD02f17dh6eoqRChjm/Im7b5E/vz1RxVVBAYqHz4aUxSftJQNgM3RaG0SidxDv KmcqYW9U8UROOwg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Efficiently this already happens with prepare/unprepare calls. Remove unnecessary login and just use enable/disable functions. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c b/drivers/gpu/drm/pa= nel/panel-ebbg-ft8719.c index 14982263a94f1..9965f46f1a316 100644 --- a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c +++ b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c @@ -49,40 +49,42 @@ static void ebbg_ft8719_reset(struct ebbg_ft8719 *ctx) gpiod_set_value_cansleep(ctx->reset_gpio, 0); usleep_range(4000, 5000); gpiod_set_value_cansleep(ctx->reset_gpio, 1); usleep_range(1000, 2000); gpiod_set_value_cansleep(ctx->reset_gpio, 0); usleep_range(15000, 16000); } =20 -static int ebbg_ft8719_on(struct ebbg_ft8719 *ctx) +static int ebbg_ft8719_enable(struct drm_panel *panel) { + struct ebbg_ft8719 *ctx =3D to_ebbg_ft8719(panel); struct mipi_dsi_device *dsi =3D ctx->dsi; struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 mipi_dsi_dcs_set_display_brightness_multi(&dsi_ctx, 0x00ff); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 24); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); mipi_dsi_msleep(&dsi_ctx, 90); mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 return dsi_ctx.accum_err; } =20 -static int ebbg_ft8719_off(struct ebbg_ft8719 *ctx) +static int ebbg_ft8719_disable(struct drm_panel *panel) { + struct ebbg_ft8719 *ctx =3D to_ebbg_ft8719(panel); struct mipi_dsi_device *dsi =3D ctx->dsi; struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 - dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; + ctx->dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; =20 mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); mipi_dsi_usleep_range(&dsi_ctx, 10000, 11000); mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); mipi_dsi_msleep(&dsi_ctx, 90); =20 return dsi_ctx.accum_err; } @@ -93,30 +95,23 @@ static int ebbg_ft8719_prepare(struct drm_panel *panel) int ret; =20 ret =3D regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); if (ret < 0) return ret; =20 ebbg_ft8719_reset(ctx); =20 - ret =3D ebbg_ft8719_on(ctx); - if (ret < 0) { - gpiod_set_value_cansleep(ctx->reset_gpio, 1); - return ret; - } - return 0; } =20 static int ebbg_ft8719_unprepare(struct drm_panel *panel) { struct ebbg_ft8719 *ctx =3D to_ebbg_ft8719(panel); =20 - ebbg_ft8719_off(ctx); gpiod_set_value_cansleep(ctx->reset_gpio, 1); regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); =20 return 0; } =20 static const struct drm_display_mode ebbg_ft8719_mode =3D { .clock =3D (1080 + 28 + 4 + 16) * (2246 + 120 + 4 + 12) * 60 / 1000, @@ -148,16 +143,18 @@ static int ebbg_ft8719_get_modes(struct drm_panel *pa= nel, connector->display_info.height_mm =3D mode->height_mm; drm_mode_probed_add(connector, mode); =20 return 1; } =20 static const struct drm_panel_funcs ebbg_ft8719_panel_funcs =3D { .prepare =3D ebbg_ft8719_prepare, + .enable =3D ebbg_ft8719_enable, + .disable =3D ebbg_ft8719_disable, .unprepare =3D ebbg_ft8719_unprepare, .get_modes =3D ebbg_ft8719_get_modes, }; =20 static int ebbg_ft8719_probe(struct mipi_dsi_device *dsi) { struct device *dev =3D &dsi->dev; struct ebbg_ft8719 *ctx; --=20 2.55.0