From nobody Sat Sep 26 01:55:17 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEAB049EC5E for ; Sat, 5 Sep 2026 16:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788625074; cv=none; b=e9tPs0etppJ7pyLTUSxWqH3dmob01jhWNlBKTLXsDEtH1aZ78Z8/rqA8dQfoS0hhe4ylha8C6Nv9UEq7BuIbceMIFoKf0LPn4Srj7ZozWZ17hcKrpIjNnQNeRg5C/E5GB2l//jisUIKMvKHFhdtOjcwdt1TnQvEbdOclSCl2dLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788625074; c=relaxed/simple; bh=nGh6RsM7aCBkLteBnwvgaaPX3UTn8UTU7R4yvf+CRk8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a47MAPHKPVP7ojqUtl0HrSKc3D5kMX3lDIGRUu6RxWlfp4EIdB9X9uYzicxLxGblQG2GZRU5fNSBAr0py1A2QlSEYrEVrKqT10fdjFm3P1/HwczRxt/HD4wWEvggrIe9vcWrxIApnTkbY/95BkP79SRUzwJ4gAd64AOhfKGsNag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HBPN5DKL; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HBPN5DKL" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-382ef647e20so2099709a91.1 for ; Sat, 05 Sep 2026 09:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788625072; x=1789229872; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=JcOig9NKf5o6Qbc3piYOUfGf8ABZUBGBIb0kMgo7Eu4=; b=HBPN5DKLbgE4qlPJWqkWqstycZdUspgB0H2lGiKaKIqmv/ICoLam+Gc3mrbYrpSyuV wBxlVIBrObpUjTfvFTYZ9B0JW6FmwFSFD18UucvM4Un/lisEpF0kbqXHQNtz+GdmHFhR dgwUPX9B2aJmXVMnFHk6qmTTdgSKS/kSUUeKy2TGreTFKQIyOqQ4Iw/RsjII++7Ma4b2 GTpEj8quREwX/STxLMQrCPgvCNoA6xsvM59ii2UfaeOV8qbcLV/evnRRdda2pcoSoPzv ffoDcVLS9Qr3DkyarJITvVaO9yzELhUy1J46rJ1bgyarvsXX0FBOH3RPO3PLnyxtMAjo a/Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788625072; x=1789229872; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JcOig9NKf5o6Qbc3piYOUfGf8ABZUBGBIb0kMgo7Eu4=; b=jxasiNZjoWSnYSdPTIN/vlXHWYfn06i/TCe5g4xv9E4Iqay8w0Cfs2/m/EFmke3wxn CyGnKaQZbrxXYj00JTmrOw3HWA5OQWGEAA/mMvr4Nlw13Y8IyZgG+Y5z/XsGde9r12qo 6o9IohCxsJVKdVazumodZbxFhQ+6Zmgyq3AdN3MZeZCAY8zFVbjsOyxuDLSD5N7YEGrS 8oQbm9O4ij9zaE8dmE+vgH04/EI6WWeE++2QGGJ2LKDpU1xD2rNVsHKmx5XcyUNpiZrI yIz2nQ7euWkB287JlSKDOCg+Fug2jXHRViziyRKB7fYifryoaq6SPs7aFuopmwnSX6N9 e3CA== X-Forwarded-Encrypted: i=1; AKwUvByG4gv3F8VaqyTLznq8eN4EJoHRPVXxMHIIYkoS3UDqN05OLNbIwxdp6yB6VICWsJRGzbBxFCdXCsbSyqg=@vger.kernel.org X-Gm-Message-State: AFuF++nABYTrk9npGGrNmEmM3CBN3y3oh6u0R2grR2vCbpLKjc3909vP 0MGknTyodrsNILJ3RqSN7OVdDs+58qbU3EZ6K+rd2QWXsRSXEWVAgfJD X-Gm-Gg: AYBFou3u4sitloFG8fZ6FFUklvyYgC25+iSdMUvBzTuad9CZ/IVf0+eS30V/VHgsnjC OvfVxeJbl/IFP9Jua4VfXKiW3L1YqLDBIY5sR5FQM9fm/9g/NlXzxYnwPdxQaZvHI1oXA3iJXb9 y5mnl9Ftncyoq2A7ASoZ1onYelzEarSYEcDSOGvWovLuJTMyF8TwyPucHb3uqpvxQHZxJVGBOZi RAjXzpzaVw3evwT7kEfouyiBd3kdb49Y6TpZgIUA5jJXMA5ek4diJKPtFmp1jGUKe5q/v8af9WG JFgJJpT5YzBChSzasCog+OBNawkUi+C4sGVMKcG+g04UhCjvHwrLMaxgMKcJnG+dzM5KP7iHqbi V7i6sA3Vo+L0dIfFTZKn9R09GnEOV9nz0K/i3steYpP9mfzo1jruB0RXh7R2P7UdpSWiqczO9JO MzJsXmuWu0oRQI6/42cfFjEADs/WPsML2Aa8XmaFVlaGxND6X5V7XW1I3Ol5ck9Srx9sxkjtZvT muX+J4= X-Received: by 2002:a17:90b:4c03:b0:398:cb56:e92 with SMTP id 98e67ed59e1d1-39b26130698mr18530874a91.11.1788625072094; Sat, 05 Sep 2026 09:17:52 -0700 (PDT) Received: from kernel ([45.251.35.121]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3346ea43377sm12992382eec.3.2026.09.05.09.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 09:17:51 -0700 (PDT) From: Mohamad Raizudeen To: bhelgaas@google.com Cc: alex@shazbot.org, skhan@linuxfoundation.org, jkoolstra@xs4all.nl, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Mohamad Raizudeen Subject: [PATCH v2] PCI: quirks: Fix out-of-bounds MMIO read in mellanox_check_broken_intx_masking() Date: Sat, 5 Sep 2026 21:47:43 +0530 Message-ID: <20260905161743.5766-1-raizudeen.kerneldev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The mellanox_check_broken_intx_masking() function maps 4 bytes of MMIO memory using ioremap() with a size of 4 bytes, but then reads two 32 bit values using ioread32be(fw_ver) and ioread32be(fw_ver + 1). Because fw_ver is a pointer to a 32 bit type, fw_ver + 1 advances the address by 4 bytes. Reading 4 bytes at offset 4 goes past the mapped 4 byte boundary. This violates the API contract. Fix this by increasing the mapping size to 8 bytes to safely cover both 32 bits. Fixes: 1600f62534b7b ("PCI: support INTx masking on ConnectX-4 with firmwar= e x.14.1100+") Signed-off-by: Mohamad Raizudeen --- Changes in v2: - Fixed a typo in the commit message("ad" -> "and"). - Updated commit message to use "violates the API contract" instead of "page fault or kernel panic" to avoid overstating the risk, matching the feedback from Alex Williamson on a similar patch. Link for v1: https://lore.kernel.org/linux-pci/20260827071940.B7CC01F000E9@= smtp.kernel.org/T/ drivers/pci/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index de9bbccda21f..b30ca4244f14 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -3714,7 +3714,7 @@ static void mellanox_check_broken_intx_masking(struct= pci_dev *pdev) return; } =20 - fw_ver =3D ioremap(pci_resource_start(pdev, 0), 4); + fw_ver =3D ioremap(pci_resource_start(pdev, 0), 8); if (!fw_ver) { pci_warn(pdev, "Can't map ConnectX-4 initialization segment\n"); goto out; --=20 2.53.0