From nobody Sat Sep 26 01:51:48 2026 Received: from mail-wm2-f11.google.com (mail-wm2-f11.google.com [74.125.225.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B50738E5DC for ; Sat, 5 Sep 2026 14:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616941; cv=none; b=qwqVG3Fx5uSa6k/SzBqR6rXPI/bAHjpYa5eYsN4csNZ7TpYWXjN5fcgHvtVY59p2aPaikb/rRiT/o1CeFgGb6ZL8dhxFhayE8oZdEXYEt2iAgFsKdNfKiBTD3o7m2f1cxmpWWNAil+5rLZYt28Fy6Kg3P63cm7plgLtIQA4ZSGI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616941; c=relaxed/simple; bh=/HG9Myx+SswQeekFwNoyEv5medtLqspzxw3pTIkbj3c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uZZWEVVjS8V27vvKVt4HnH0iI1t2cw6jp33+d05BpcX3O2tTReRzgrXDJy3TNZJXjPWi2KjImgp1uSd4jlr48f6AoSxK+h/wW3vsrduaYoTCec7jJklBqRWzjednxkb48KgW1Uc4nLMCGe8qUFQfd6Dlg1NQLttWzia/jDibW1k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QXBSGrv6; arc=none smtp.client-ip=74.125.225.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QXBSGrv6" Received: by mail-wm2-f11.google.com with SMTP id 5b1f17b1804b1-49ccf0fbf41so8261355e9.0 for ; Sat, 05 Sep 2026 07:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788616929; x=1789221729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=icDFr+1kJOyXzKJSmWL1jSVXiQ38MI3ua/+Z5tbVNKM=; b=QXBSGrv63wfSJdBhvfnVHS0A0Ukvr2MIRyNoAnu7h/aIf3FTmv88YXexQ1zK/3X68h uedPGBcqpeIc107SEgLYHvdLacAtw19Udn4fL3+YrJxyoNGPgzsl8ZjeNh9ukOhfzOWU AG+hhjmgIZnUgYaLmyHzO2RKVwW57VTOvWocC/YSzwdM1xwM+Qnxk2ppzN/j6Wzl1Y3X LzNQTsxcxcPdSbc/BKMkM50niW6ceLax/sMg2NKvnP+D39YIiFsJ4QqAcf3ks1oLYNPS IRZ8aEI/uHZfUxI0iiN/aH1iDajaXYCe+QwXZJgV5lmPU15ADgeLE6U5NkWA1QjvzdtZ 2Big== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788616929; x=1789221729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=icDFr+1kJOyXzKJSmWL1jSVXiQ38MI3ua/+Z5tbVNKM=; b=rDeou+v6K/0Q52/F2hXZPna+OfMjpzgsgWq669pD39U7h5R2qT28wR5k0GeGYI7cHg 5M5aQQ7bwQ4nV4+dr9U/+EFrq1gHLElK5zZljoEDE6PCL9I21GAhh2pZ00wlfI454caG uJYvjLjFePtpSGBmZXle3dPS1aHHno+RBFKAtG/8ii0Illisfxy59m6tJKGlfRl/mSHW qT1T+83k/7FG3WIzsJ1Xma/LLldUZi/TZlxboM/5Wv2Ngc2WU3jv/DUJFRTp+SADKVOa y3WHUTpGCa/EtOkM/d+V7QY3Xb5/z1PNOYYaCCHDlk5X1XqlCn1f+CBT9o26KqS4yw4J 7c2Q== X-Forwarded-Encrypted: i=1; AKwUvBxmxoyquYPcnrdmhZ6BLF2Vx3lq0K3zk5c/zNX48EIhaIDf2gy7OT7u4n5cFRQP0oq3AzsP5ycGoH+CP5s=@vger.kernel.org X-Gm-Message-State: AFuF++nRoN42L2uW+SXFLvYV/e9cQ/LlwxNiXjFGvZtzxi83GNUFpb3e NrLs6ZcdcrteK9BNfn6jwLQiXUWqh6dIP4Yt4ab7J6p7N5Azmiadnlxl X-Gm-Gg: AYBFou2EgKWQfYRMG1CJeZTQS8Pbo0p9Z/nGjlx3m+Tq7Za8VfrjTw1HEmWC+KLGqxb St8wMj6017/+yW0xqIBWRk6peaMsKXaGyutpYY2/OYMif+kuf3zVm1vs1u8LXrWvtCndBkksW6b /BIt8hVGZgIrHaXhMGjyjVw2N0Cb93OwrJqLsSL+p0KlejK/O4RwC24AB/4RU64m3nrDQb+CIUd dIQRojRjJ9CJLy2eH5DuXvBcY64HE+FWiXjRdEFXznOGpdFvS6/jm+9QUaFr0I+FO8drJyNvFd2 7oDu4xnTzs6939ucIppkEEHCC7DRmeeGTnrymCqty4UNxTJPJM21GdH699baFSmUotuwfyD+UaX KTaaEwdpRF3Emzs9rRBBLy3xVwi6dp6pQT/+um0U9xHf7/i7xuooeZhqTffTAOwSgUmhhe5c/ZG UFoqjP9w0mZ1H3cE609rr9ssWHe52b06qtyjnODA4jw2iLu8IZNX2U1vi2mw+S12PAaJF6vcAeH hisrkvmqUsyN0k= X-Received: by 2002:a05:600c:1da8:b0:49c:cf18:494e with SMTP id 5b1f17b1804b1-49cf825a530mr148106805e9.12.1788616928651; Sat, 05 Sep 2026 07:02:08 -0700 (PDT) Received: from outlook.com ([2a02:587:6022:4b00:84ac:4417:9f37:a496]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf755c22esm149866765e9.0.2026.09.05.07.02.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 05 Sep 2026 07:02:08 -0700 (PDT) From: Christos Skarlos To: akpm@linux-foundation.org, david@kernel.org, muchun.song@linux.dev, osalvador@suse.de, ljs@kernel.org, hannes@cmpxchg.org Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, kas@kernel.org, vbabka@kernel.org, jannh@google.com, pfalcato@suse.de, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christos Skarlos Subject: [PATCH 1/3] mm/mmap: fix various coding style warnings Date: Sat, 5 Sep 2026 17:01:38 +0300 Message-ID: <20260905140140.60792-3-christosskarlos.kernel@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260905140140.60792-1-christosskarlos.kernel@gmail.com> References: <20260905140140.60792-1-christosskarlos.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Resolve coding style warnings and errors flagged by checkpatch.pl script. S= pecifically: - Remove the obsolete filename reference in the top comment. - Replace and with . - Add missing blank lines after variable declarations and replace spaces wi= th tabs where needed. No functional changes are introduced. Signed-off-by: Christos Skarlos --- mm/mmap.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 4bf26b0f1e6e..626d3d2493ae 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1,6 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * mm/mmap.c * * Written by obz. * @@ -50,9 +49,9 @@ #include =20 #include -#include +#include #include -#include +#include =20 #define CREATE_TRACE_POINTS #include @@ -526,9 +525,9 @@ unsigned long do_mmap(struct file *file, unsigned long = addr, * And don't attempt to combine with hugetlb for now. */ if (flags & (MAP_LOCKED | MAP_HUGETLB)) - return -EINVAL; + return -EINVAL; if (vma_flags_can_grow(&vma_flags)) - return -EINVAL; + return -EINVAL; =20 /* * If the pages can be dropped, then it doesn't make @@ -832,6 +831,7 @@ __get_unmapped_area(struct file *file, unsigned long ad= dr, unsigned long len, =3D NULL; =20 unsigned long error =3D arch_mmap_check(addr, len, flags); + if (error) return error; =20 @@ -942,6 +942,7 @@ find_vma_prev(struct mm_struct *mm, unsigned long addr, struct vm_area_struct **pprev) { struct vm_area_struct *vma; + VMA_ITERATOR(vmi, mm, addr); =20 vma =3D vma_iter_load(&vmi); @@ -1017,12 +1018,12 @@ struct vm_area_struct *find_extend_vma_locked(struc= t mm_struct *mm, unsigned lon =20 #if defined(CONFIG_STACK_GROWSUP) =20 -#define vma_expand_up(vma,addr) expand_upwards(vma, addr) +#define vma_expand_up(vma, addr) expand_upwards(vma, addr) #define vma_expand_down(vma, addr) (-EFAULT) =20 #else =20 -#define vma_expand_up(vma,addr) (-EFAULT) +#define vma_expand_up(vma, addr) (-EFAULT) #define vma_expand_down(vma, addr) expand_downwards(vma, addr) =20 #endif @@ -1227,6 +1228,7 @@ int vm_brk_flags(unsigned long addr, unsigned long re= quest, bool is_exec) int ret; bool populate; LIST_HEAD(uf); + VMA_ITERATOR(vmi, mm, addr); =20 len =3D PAGE_ALIGN(request); @@ -1290,6 +1292,7 @@ void exit_mmap(struct mm_struct *mm) struct mmu_gather tlb; struct vm_area_struct *vma; unsigned long nr_accounted =3D 0; + VMA_ITERATOR(vmi, mm, 0); struct unmap_desc unmap; =20 @@ -1454,6 +1457,7 @@ static vm_fault_t special_mapping_fault(struct vm_fau= lt *vmf) =20 if (*pages) { struct page *page =3D *pages; + get_page(page); vmf->page =3D page; return 0; @@ -1711,6 +1715,7 @@ __latent_entropy int dup_mmap(struct mm_struct *mm, s= truct mm_struct *oldmm) int retval; unsigned long charge =3D 0; LIST_HEAD(uf); + VMA_ITERATOR(vmi, mm, 0); =20 if (mmap_write_lock_killable(oldmm)) --=20 2.55.0 From nobody Sat Sep 26 01:51:48 2026 Received: from mail-wr2-f0.google.com (mail-wr2-f0.google.com [74.125.225.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C29ED388880 for ; Sat, 5 Sep 2026 14:02:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616947; cv=none; b=vB0ztbMGc1Eh37o/EsWeRbLJwTpfXCv3yWoNUkE4eXKOlCgqPyNdxW1W+kLQSFujou6+QgmfKBb20WulZWbro3RvF5FRxtJ9vJFFNIETLZBz7Ha0xqmXr0K7lUMdcJB9dwT4ZIqow2U/Y8KmEYLOzkzrkS+8hScBp52ZpP52HEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616947; c=relaxed/simple; bh=ivNMj0j4sdXK5+XtlbC7L0D6sf/KfptnZi74YjwFkIM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lt+theclzmAzbqLyNWbb53sRgJC/tfbhqdvcxpd3CzCF0aG/SPNliqJbkfkmyz+mkpPws8xWKKuSNUiszCPUmgJYMtSQqMkam9SFWY1YVKGuRazlaDiBNINI+jOtSJyqOpiDCA8RbptN0NXMZPwk3xb5M3srxEh3RhTV2z/R9e0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jDn7XQsU; arc=none smtp.client-ip=74.125.225.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jDn7XQsU" Received: by mail-wr2-f0.google.com with SMTP id ffacd0b85a97d-48437cc1b11so551771f8f.1 for ; Sat, 05 Sep 2026 07:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788616934; x=1789221734; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1j3T5b2cEL6pgSZfKmDhv9K0ynuzYhpAf3KEcht699E=; b=jDn7XQsUb05tq8tPXK2WWfOeS137avwJiN+n24LBMXD1DwYg1Rcpvz4h+Y/Rn7YkzH htOgtpVBwGBwJKJ5vRKrZdu+nSaUy12I7Lxx5k+JDeV2uWWHixyNlbAl9V4K940W0cDZ kuobth1REkBVVAhbzTkoQyOrcSDPUElRkunhVIJ2/JTVRn2RCoYn2FqTAEesNxv5l8MN ee4Pna2/k36FzutBVEUAMLH4IYH1n3Gildv2em0PxyR4Va/ElNZDKKawBQ0HeQnLnSZ+ SGBpmjKiC2DlHwMu2zT/vp9sI6y30jLv2z6nVSF/Eiv7wBTJa2d7hHlHkT9f0z6hFKRS p7jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788616934; x=1789221734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1j3T5b2cEL6pgSZfKmDhv9K0ynuzYhpAf3KEcht699E=; b=bhlbJpgSL/+bNwKswNoRhB3L8xe+seYwtpMWp65fvncUxcZ5OEJ6d/hLTdqwtQzaNE WubIpIPIRSexeIXk3bvJGPzHUS32gxvXh4dTi6j0KD0lydZ4aP7jrIZu6foDzizwy761 fIu9X1kp3KK2yNZQy4IDYN0rVzA0vesHIxFEtvgCv0caMJCZZsXczjciVm5zEqILwvZq ZDiqVtnLf+x4+8mtClplv29ZaAXJq8KVPbk99MW+9EW/dT8OrPbjUvw+6Z0+vubrAyq+ LZO5MnOiHtYup9lS2m9RdUH+frV7OZl+wUvTayf+XJb7J4CRDhHemTGrGe+rrWPmqMC+ 2ZeA== X-Forwarded-Encrypted: i=1; AKwUvByplF/NWBBG65k8Pu0QijIRRf91Z+6ebwEvoKM0bo6dfoN9UOZW3CeZcwXAqlkM6WlPX5szLJ3sFlLWIV4=@vger.kernel.org X-Gm-Message-State: AFuF++m/vymvHKUnFQY8lttJT532/8ujdto6ovR6dxicb+rsf5TBtD2S mYBJ8CLBiRbuZKpJJ+Yyz5JVn0TSLwjy7BVVc+9KmgIt6kqu4Qni7CLj X-Gm-Gg: AYBFou0ijBJ3AfsVeVNPJMPKlKQbMH8R8h4dBOKiUOJyd+ceNPcoVKM6xJgCp02c5Vw O5/SMjnWc2er+NAxWzUZj9yUk7fSfiQqNpb8EmlILEqdbiSnSHRkB0TPpI3XZFBrLA4jIQzmupD +rOhIs+53zRP3WLoFpVFMa+omh6JFaS1yOxzga+CVcTieSX3DGyFR706Ih2QFbtqjB9D34Lb/iU RD5rugj+kW8Hkn8bP5kj2pREQltSfZsktdoNGIywymbtoe2ZXrelUQb5WyAJV1lCboK0kx6DhJi lyIOtHAH9QlKJpl4POAjsAZ0cQup2soBJ6IBXbNNxmhdYLIQ9G/9yChX+K8hSwuB4qYS7WTx4YX vXJCGtj0JBP8aEoLPBlzhrtHzTI0+7HDT7QyJKFh8TNj8FLwJy8zP5/p1iP4cZFbF3CyFx8MBtr uq+KT4srGv6o4C9YP7sDFCuzJ2DCZifulSIVMOenvsincQghUL3AzZat2fs8+92FtPuqeFESoqt YT+azq94kwqUY/XF7KVfm0yxCTf7w== X-Received: by 2002:a05:600c:c1d7:20b0:49c:ffe3:2b3f with SMTP id 5b1f17b1804b1-49cffe32f58mr50527755e9.3.1788616933800; Sat, 05 Sep 2026 07:02:13 -0700 (PDT) Received: from outlook.com ([2a02:587:6022:4b00:84ac:4417:9f37:a496]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf755c22esm149866765e9.0.2026.09.05.07.02.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 05 Sep 2026 07:02:13 -0700 (PDT) From: Christos Skarlos To: akpm@linux-foundation.org, david@kernel.org, muchun.song@linux.dev, osalvador@suse.de, ljs@kernel.org, hannes@cmpxchg.org Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, kas@kernel.org, vbabka@kernel.org, jannh@google.com, pfalcato@suse.de, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christos Skarlos Subject: [PATCH 2/3] mm/vamscan: fix various coding style warnings and errors Date: Sat, 5 Sep 2026 17:01:39 +0300 Message-ID: <20260905140140.60792-4-christosskarlos.kernel@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260905140140.60792-1-christosskarlos.kernel@gmail.com> References: <20260905140140.60792-1-christosskarlos.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Resolve coding style issues flagged by checkpatch.pl script. Specifically: - Add missing blank lines after variable declarations. - Replace "unsigned" with "unsigned int". - Replace spaces with tabs where possible. No functional changes are introduced. Signed-off-by: Christos Skarlos --- mm/vmscan.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index f11491ee9ed5..8637cc0910fa 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -535,7 +535,7 @@ void reclaim_throttle(pg_data_t *pgdat, enum vmscan_thr= ottle_state reason) * writeback to a slow device to excessive referenced folios at the tail * of the inactive LRU. */ - switch(reason) { + switch (reason) { case VMSCAN_THROTTLE_WRITEBACK: timeout =3D HZ/10; =20 @@ -1529,6 +1529,7 @@ static unsigned int shrink_folio_list(struct list_hea= d *folio_list, VM_BUG_ON_FOLIO(folio_test_active(folio), folio); if (!folio_test_mlocked(folio)) { int type =3D folio_is_file_lru(folio); + folio_set_active(folio); stat->nr_activate[type] +=3D nr_pages; count_memcg_folio_events(folio, PGACTIVATE, nr_pages); @@ -2073,8 +2074,8 @@ static void shrink_active_list(unsigned long nr_to_sc= an, LIST_HEAD(l_hold); /* The folios which were snipped off */ LIST_HEAD(l_active); LIST_HEAD(l_inactive); - unsigned nr_deactivate, nr_activate; - unsigned nr_rotated =3D 0; + unsigned int nr_deactivate, nr_activate; + unsigned int nr_rotated =3D 0; bool file =3D is_file_lru(lru); struct pglist_data *pgdat =3D lruvec_pgdat(lruvec); =20 @@ -2614,7 +2615,7 @@ static void get_scan_count(struct lruvec *lruvec, str= uct scan_control *sc, /* * If there is enough inactive page cache, we do not reclaim * anything from the anonymous working right now to make sure - * a streaming file access pattern doesn't cause swapping. + * a streaming file access pattern doesn't cause swapping. */ if (sc->cache_trim_mode) { scan_balance =3D SCAN_FILE; @@ -3416,6 +3417,7 @@ static bool get_next_vma(unsigned long mask, unsigned= long size, struct mm_walk { unsigned long start =3D round_up(*vm_end, size); unsigned long end =3D (start | ~mask) + 1; + VMA_ITERATOR(vmi, args->mm, start); =20 VM_WARN_ON_ONCE(mask & size); @@ -7748,7 +7750,7 @@ static int __init kswapd_init(void) int nid; =20 for_each_node_state(nid, N_MEMORY) - kswapd_run(nid); + kswapd_run(nid); register_sysctl_init("vm", vmscan_sysctl_table); return 0; } --=20 2.55.0 From nobody Sat Sep 26 01:51:48 2026 Received: from mail-wr2-f11.google.com (mail-wr2-f11.google.com [74.125.225.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CD038E8B4 for ; Sat, 5 Sep 2026 14:02:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.75 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616953; cv=none; b=reOZnYC9k8i9HQj3+8doBaR48E2XfFZnp33rWKG920vK3hsX9NOjnLq6WKdXcUWd5SmDCTMAjbm+FCRATFJXlxRs/J/JVlZCT12u3y0WWLpIT/R7Wax1DAuzcLFoyrnGksxTkaO299Mj8ThV5VQ5K4g4ax/EVGG6VZXMLtkvwqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616953; c=relaxed/simple; bh=XYa/sNO0rkEa/2+8FJLR+KN9FCWceJLtMiHEoyXNxqE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZMDdHrOIOW9jszkkJJFl1URkXUtPOcewFOkrD4q78TrV2NI64K4PFYVqeIeDMWhHP33mpXVIMBkjWli16jizbb1tWpRhmgpUCCwCtK6W9u4jNmNCWScAYeolVBN5r+QIE0b5/lVLlYypuV+ZIlBa5FtzPt5FZCuLnZs5XsK/yIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EVTmcyka; arc=none smtp.client-ip=74.125.225.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EVTmcyka" Received: by mail-wr2-f11.google.com with SMTP id ffacd0b85a97d-483960225ccso630196f8f.1 for ; Sat, 05 Sep 2026 07:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788616941; x=1789221741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lAVqgBHrMqJB3BSpfl35IypQuNVtfirpz6pazsL02KQ=; b=EVTmcykaSU1FRZcFYRZd03FJBIySZvbcWt2oTXrQhHDgzfmHpP5m7QcpmZnViEgKkR J29mtBFmylGBP2xjQhHHEFwjzDwhepVS6KqyccJg/XH0io1FmPP3MXmRTjIm9PpzSlUZ gWz1a5C+5tI0KxZncAoio2zgch8++j6WBVkvc7UAJ8rSYUfTcJR8Q/7Przjl4L/lAsvQ sv8WX05vwnomK7TYf9ekGzcRRPRbIkSaNsYdx7HTELKhGnlmBMqyBmQhzgd+g8XlcsSX F8NtuA6KwmkxNpjCx8cLpEGJ/BnpItegv8+FOYwqdN+ZejuKzoxwfufm7aF5ofva1py5 UmpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788616941; x=1789221741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lAVqgBHrMqJB3BSpfl35IypQuNVtfirpz6pazsL02KQ=; b=C07TLNJOIMZfdBoMMML4Qp5CJuysNY6I/8nYSqwFNoFZ+W45LCHaSEVNnUIEscgoG4 bgGgTLln5cs3xZQ0ie2OUNEaR0BUm0K4V/tLRzpEqdXnO6yDa3SiVBA90dLrtBvzXhJi kwaE+gMB1E7I+ZW/TUZOyooOTOdb7RSXKOGNX4xV6aG9MfyaF1trNzTOzLDvNug7HJ6o 5MBIg1oNIR2me8X9yvXnLBLgtkNreO33m4h4+3ZemtPeelMVjgcYBfwz7U6jm1Ajtiic Q+ehAhj7EyBSUD2/5sGRCU0g+3eqhzr2xaz3qk53Qr025rGwZibMiLFgWWk5nM6E+2wD IOaQ== X-Forwarded-Encrypted: i=1; AKwUvByHsTFLvvJExb+o6+bd2w0LoI/xvUR6hx3BbqcFcW/fB9vFaOfF/mbbi8rFwHxDFQsxyTR7Y5sr3XrZlcs=@vger.kernel.org X-Gm-Message-State: AFuF++lLBFB7HjfCVZjrdY+152417gPLproNyFgHYIbDZ8B2ARUPgt+O E6R/T+4XsI2ec0s6JnmXw1gjwow9S3pxJJz+1Qj8PyamhYLo+cG1QmCt X-Gm-Gg: AYBFou0OMX/QD1DV7DB/hh+FuH6p559yDarS8avRf5kY8aDTgfkGaenVOotiGiDhuk0 ssoFbfDZpI7AY7vQjFblBqv0cnkcl49v3w5P86WpAcw53SGWYTWlbOl1VzYazIkL9ENM7G/RClV Hfr1X6fQHRehLb1j1LBytyJhZT0PiERUC43M9H2PNlZRrbGpuabRSE0c2Hc/WS3Yw+yXTcIgZ6R YTcVOw8JaGn5vNePBb4WFEeZZcg5HfPV8DtyPgPLadBnFUTahiSWn33LLFb0uSbNADWmaFvb5Jr 3OG6aDA6VCgh29nFRkajEGFj9rEByeexl/YU9oXRze5YveQJfm8mEJCI1nxWX1HlsOGmfAhnJVF OXBVANKsmpL6W22XPlC32DgtybSZCMZmW23cS8rG98N5HVH/V6E16SbDKXYFjGa86ZvqjGJWwkr 7Ezgz64YcGRJSEoxhHR+9bYWfwKJByxCvJOGE1b7BlswKSl6kshHLoHrWF7dtuywHUnliIRru8S vEdAdhyA6wH6ezEF8ic5+PnOEEk4Q== X-Received: by 2002:a05:600c:4f83:b0:49d:91:274 with SMTP id 5b1f17b1804b1-49d00910374mr51848155e9.10.1788616941497; Sat, 05 Sep 2026 07:02:21 -0700 (PDT) Received: from outlook.com ([2a02:587:6022:4b00:84ac:4417:9f37:a496]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf755c22esm149866765e9.0.2026.09.05.07.02.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 05 Sep 2026 07:02:21 -0700 (PDT) From: Christos Skarlos To: akpm@linux-foundation.org, david@kernel.org, muchun.song@linux.dev, osalvador@suse.de, ljs@kernel.org, hannes@cmpxchg.org Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, kas@kernel.org, vbabka@kernel.org, jannh@google.com, pfalcato@suse.de, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christos Skarlos Subject: [PATCH 3/3] mm/hugetlb: fix various coding style warnings. Date: Sat, 5 Sep 2026 17:01:40 +0300 Message-ID: <20260905140140.60792-5-christosskarlos.kernel@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260905140140.60792-1-christosskarlos.kernel@gmail.com> References: <20260905140140.60792-1-christosskarlos.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Resolve coding style issues flagged by the checkpatch.pl script. Specifical= ly: - Fix block comment formatting to keep tailing '*/' on a separate line. - Add missing blank lines after variable declarations. - Remove anecessary braces {} from single statement blocks. No functional changes where introduced. Signed-off-by: Christos Skarlos --- mm/hugetlb.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 4f6f58bf3db6..ec8e799e356e 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -145,7 +145,8 @@ static inline void unlock_or_release_subpool(struct hug= epage_subpool *spool, =20 /* If no pages are used, and no other handles to the subpool * remain, give up any reservations based on minimum size and - * free the subpool */ + * free the subpool + */ spin_unlock_irqrestore(&spool->lock, irq_flags); =20 if (free_subpool) { @@ -3700,6 +3701,7 @@ static void try_to_free_low(struct hstate *h, unsigne= d long count, for_each_node_mask(i, *nodes_allowed) { struct folio *folio, *next; struct list_head *freel =3D &h->hugepage_freelists[i]; + list_for_each_entry_safe(folio, next, freel, lru) { if (count >=3D h->nr_huge_pages) goto out; @@ -3764,6 +3766,7 @@ static int set_max_huge_pages(struct hstate *h, unsig= ned long count, int nid, unsigned long allocated; struct folio *folio; LIST_HEAD(page_list); + NODEMASK_ALLOC(nodemask_t, node_alloc_noretry, GFP_KERNEL); =20 /* @@ -4188,9 +4191,9 @@ void __init hugetlb_add_hstate(unsigned int order) struct hstate *h; unsigned long i; =20 - if (size_to_hstate(PAGE_SIZE << order)) { + if (size_to_hstate(PAGE_SIZE << order)) return; - } + BUG_ON(hugetlb_max_hstate >=3D HUGE_MAX_HSTATE); BUG_ON(order < order_base_2(__NR_USED_SUBPAGE)); WARN_ON(order > MAX_FOLIO_ORDER); @@ -4832,11 +4835,11 @@ static pte_t make_huge_pte(struct vm_area_struct *v= ma, struct folio *folio, pte_t entry =3D folio_mk_pte(folio, vma->vm_page_prot); unsigned int shift =3D huge_page_shift(hstate_vma(vma)); =20 - if (try_mkwrite && (vma->vm_flags & VM_WRITE)) { + if (try_mkwrite && (vma->vm_flags & VM_WRITE)) entry =3D pte_mkwrite_novma(pte_mkdirty(entry)); - } else { + else entry =3D pte_wrprotect(entry); - } + entry =3D pte_mkyoung(entry); entry =3D arch_make_huge_pte(entry, shift, vma->vm_flags); =20 @@ -4919,6 +4922,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, st= ruct mm_struct *src, last_addr_mask =3D hugetlb_mask_last_page(h); for (addr =3D src_vma->vm_start; addr < src_vma->vm_end; addr +=3D sz) { spinlock_t *src_ptl, *dst_ptl; + src_pte =3D hugetlb_walk(src_vma, addr, sz); if (!src_pte) { addr |=3D last_addr_mask; @@ -6321,6 +6325,7 @@ int hugetlb_mfill_atomic_pte(pte_t *dst_pte, folio =3D alloc_hugetlb_folio(dst_vma, dst_addr, false); if (IS_ERR(folio)) { pte_t *actual_pte =3D hugetlb_walk(dst_vma, dst_addr, PMD_SIZE); + if (actual_pte) { ret =3D -EEXIST; goto out; --=20 2.55.0 From nobody Sat Sep 26 01:51:48 2026 Received: from mail-wm2-f8.google.com (mail-wm2-f8.google.com [74.125.225.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9920221FB6 for ; Sat, 5 Sep 2026 14:02:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.136 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616938; cv=none; b=Q9iYxagsnxcE17w3t/klmdkg1RtydCbxBz5D1mFZAcXMhcfviEO/zUtJJgKI6sBNVd5gZru5yZeL3LhytdfqJyMAxKyr04ubOnmp1fUFwHS6/N5z8uXc/lsqUwdsmkBRW9Vp8z+F/jT5W7jvWicFDeCc+6OAXGyKVmoU8n1SvtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616938; c=relaxed/simple; bh=fVURs952Qxa+Ey6m7QLrY+2zX9hiMyr1lqWQc/XAV7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sHDQwziYk8gN00UEFbSmikrrsok65bWRrUQPJlNrpWLQONq0bFSzgkxNdjyONHb6QBAoGT6mkVPcMtBHOhn+dGgVna61JGrwLZW1Z7pKZJrduucVo/155l2bIhVOid97/I4DRrGjegogeI3ZMxI5o5Si9qStBln5MMVcZt6BYpc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jETfmPkI; arc=none smtp.client-ip=74.125.225.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jETfmPkI" Received: by mail-wm2-f8.google.com with SMTP id 5b1f17b1804b1-4956bc73c0eso7428485e9.1 for ; Sat, 05 Sep 2026 07:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788616924; x=1789221724; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XYwBU5ZHVueM1YfQFwjzrz4zbhTksf0+irRokmEvL88=; b=jETfmPkIzfjOrQHlfkZkTC4icmnUvlICnczkIUqcSSatvMQlQIEu/BQ/Gvh9lqr9ta zCFnggOTdQ+DGgnl9XvOl+ihTwkYD2tQCoHaNdP10KuU1HD63AhfIpvNHgCifUCb+ENA 9WD0YJEdPHPUZys7QCR0AYnxB6Ya5bwW05gsM5pBqsxg50vZLTJKGuZejFkeBWS8zM2b 8Eqk923Kq83+KOEQmXU7yax6UuctSNrTGsMoep0hLCTKRK7hQGDsVSG1O3G9VLOxs8oL qukFkmhN9T+1OfqxbuttLyhGcNJZCJYLmDXx6xxupIO6cZpXSA/oWPh3pUZjJZOFXJ80 Cy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788616924; x=1789221724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XYwBU5ZHVueM1YfQFwjzrz4zbhTksf0+irRokmEvL88=; b=kmRmwYWAatIPsFDEKTsPL918lyuHHgEPXjT6qu2vnQzkBx6EEilv4FOSVQDToXapDf RqNGti3SCDCQq43fUrRqqK8RGLWRqTCXAUtUFqDP8kENuIkpe6oqQ56ZcaQNahr6VmJ3 lFVkIcOFswg4oR+smkHYqBJyIDQrrRKExGT4KM+h1oPgC1TiCzWKHBRDwMxlOnwOZ6Fg enq+Qvmu/gOM5Z4PqsndZ8mscZlKi/apVXGrQzozQzenLha4Z0c/e4rSj6vWEHKvAi4T lUI8/9PBHqvw7NPcUBNIGBjaMkFmE5sVzx2Ot1w9h2yFcv023RuWaCTRs6xbKSpix45A bejQ== X-Forwarded-Encrypted: i=1; AKwUvBww/4yHDUP+B+e4+x827B+ALBkNuz0ixnJYWgpF5OOxtOk5XqlAlVY9YWN3v1JbhAmfy0KTsVZ1Ij5i/3Y=@vger.kernel.org X-Gm-Message-State: AFuF++mberKGj/hyCjsVtZhYW5rYdiwW/wfB434AAiTdwrWcZ0P+ddbt UCSXnLIAZ7DO0pMICP3pUffmOcS/B754XCtc1OV7N3j9c0b9oX3ghb7G X-Gm-Gg: AYBFou1cUuHMVrhu81fhnMf6NCnNzhuSD3bsOuVsPa0hdP4nZX1T+m/Nf3biTN67Hq1 hMy5scjGRvxlRgcuGPvieRC4Nc55IjtEnlUUYbj4+vsWW7A0Fr9MGCClbjO1LMP/TxYaA0GLy4L WfdXoIFNlD7hr0UyuYI2LyZFClMZMWfS3gc4kWwZKI3lYPVTR4rwOQ36w6QIHmkl0/BjpUgnsw7 KZ0L9ZiH85bYVDPQDuovz7OMi88hnxw01DWx8OcwQ/fwNesBpB3T92Gqfeg4EnSEQUzHBEV+7wJ r+kIv24h/nLXlcxz0J5MiH+Fr/kfPo2KoURoYyu8Vvx1U/uYDbcms+pLl892X8REknkO1ljz9Fc 7ryU1YtCrR+IkcZ8xpm/wR743tXkZrbWvfN/QiJ18Gz8BT3hBvbkTKPLmNDDY7OEvyW8dAiuZTY zUEQxRVmhwC9AeATpprgg0FSfMOBlaLaRsC/dEn5utlLYJZfNtiW7WljuFx1mycHP3UmEp+0L8v 3PHRKuqRjwbUlPdHgHg/6dEFqZ3t3OpBgNPIv+TQg== X-Received: by 2002:a05:600c:81c5:b0:49d:433:c3b6 with SMTP id 5b1f17b1804b1-49d0443096amr36943665e9.27.1788616923081; Sat, 05 Sep 2026 07:02:03 -0700 (PDT) Received: from outlook.com ([2a02:587:6022:4b00:84ac:4417:9f37:a496]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf755c22esm149866765e9.0.2026.09.05.07.02.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 05 Sep 2026 07:02:02 -0700 (PDT) From: Christos Skarlos To: akpm@linux-foundation.org, david@kernel.org, muchun.song@linux.dev, osalvador@suse.de, ljs@kernel.org, hannes@cmpxchg.org Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, kas@kernel.org, vbabka@kernel.org, jannh@google.com, pfalcato@suse.de, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christos Skarlos Subject: [PATCH] mm/huge_memory: fix various coding style warnings Date: Sat, 5 Sep 2026 17:01:37 +0300 Message-ID: <20260905140140.60792-2-christosskarlos.kernel@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260905140140.60792-1-christosskarlos.kernel@gmail.com> References: <20260905140140.60792-1-christosskarlos.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Resolve coding style issues flagged by checkpatch.pl Specifically: - Add missing blank lines after variable declarations. - Remove unnecessary braces {} for a single statement block. No functional changes are introduced. Signed-off-by: Christos Skarlos --- mm/huge_memory.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index ced400f72d43..371ee8d38c45 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1104,6 +1104,7 @@ subsys_initcall(hugepage_init); static int __init setup_transparent_hugepage(char *str) { int ret =3D 0; + if (!str) goto out; if (!strcmp(str, "always")) { @@ -1510,6 +1511,7 @@ static void set_huge_zero_folio(pgtable_t pgtable, st= ruct mm_struct *mm, struct folio *zero_folio) { pmd_t entry; + entry =3D folio_mk_pmd(zero_folio, vma->vm_page_prot); entry =3D pmd_mkspecial(entry); pgtable_trans_huge_deposit(mm, pmd, pgtable); @@ -2613,6 +2615,7 @@ bool move_huge_pmd(struct vm_area_struct *vma, unsign= ed long old_addr, =20 if (pmd_move_must_withdraw(new_ptl, old_ptl, vma)) { pgtable_t pgtable; + pgtable =3D pgtable_trans_huge_withdraw(mm, old_pmd); pgtable_trans_huge_deposit(mm, new_pmd, pgtable); } @@ -3901,9 +3904,8 @@ int folio_check_splittable(struct folio *folio, unsig= ned int new_order, * swapcache folio split. Only uniform split to order-0 can be used * here. */ - if ((split_type =3D=3D SPLIT_TYPE_NON_UNIFORM || new_order) && folio_test= _swapcache(folio)) { + if ((split_type =3D=3D SPLIT_TYPE_NON_UNIFORM || new_order) && folio_test= _swapcache(folio)) return -EINVAL; - } =20 if (is_huge_zero_folio(folio)) return -EINVAL; --=20 2.55.0