From nobody Sat Sep 26 03:51:25 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41FF931716D for ; Sat, 5 Sep 2026 09:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601046; cv=none; b=j1TAguep3qNYpuFTPkF4mr5cf50pSQguZxnZS5BtPEXEMu1ClhAdDaaXsGfZ4ymYzoHU7sT7ubkmKb1wEjYRYhUZDBbnaafIOEAxP9Yals6tj2GLSpX44fSoG0HtDuNQVtWrHfOeCLEIH79E/esY4bI2wPDWbxbCmaTkp9fObZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601046; c=relaxed/simple; bh=bgK+DZod7mmJgogZgW1zioKzetKNGqoKIW9z56Vpb+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UswacV91UdPDbE0adhOaLSZMDNzSFY2DXTIpYU6W1USvRDDqyiAd23Q5mIH6lYce9bTkTkXgi7SngOuh76EiZLoaWNhxttYs8uuxRiliPMss6gQ03xcn978378DpYfdAHSZjNNcfoeqUpEX2IevNLkuB5jAmcnDGyyNgWvT9miw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bMkXDOnU; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bMkXDOnU" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38ea87caafeso1501374a91.3 for ; Sat, 05 Sep 2026 02:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788601045; x=1789205845; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H2F/5Rn1z2wIFmLqiH74YcGVKvaBMa7CAe2jvYLlnR4=; b=bMkXDOnUhFY952NeJ7mzCCk5f1M5IfgmOHE19Fe+IcCesYYwXKAgt1XQWtuv1X6Frp l+srvH7ueIGWkqZ1dUigfw09Fhkrsfu0mBmMF5CTQtAcZher/hm4HhnjUYtduC2dtQOw wXgMd9afjuOQFxWu8DkGazMVbw1kUHq0DHUhAEkZfFln9lbwG4tsuUjnk3MBGYkOCRGM jumYEk8KHnqtaDttthoEJpMzmwypf12MDX7qluj4zteke2iegEq8CMD31U5zhWN1Ch6X 6+SllM4rfA2mbxoylUpDiqfk8BUQeZ0rm4HMPEDZ1HpccePsrp0duON61KbT236gLIGP fKbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788601045; x=1789205845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H2F/5Rn1z2wIFmLqiH74YcGVKvaBMa7CAe2jvYLlnR4=; b=cEA/b8ArLL8qAEnvVFFUXbnH2WJ4pkBowpUHLQz3Jnll8TEAofLmIV8TWwxQJI64do 8ZCwuYY//AkQoeTrecSMa6dlL6PI7LFPX149MnO0FXkavH6GPPmsSPcfDuFtjAll09VC AX/9DNkTjK9KRBMoU8erYV6xueQlvuVCiLJW9fERRkfzglMnL4ppgHVNPaj5OE6XFsWN ZKQEXl4ovQcBiWR1G5ra+cNK7+/7PJCxxH/jsSugiDz5FUmQFT0V3aDsNyBN7JEtcsOo hUwzxSk3b2MhX3M+ZGOc/MQsbVRTJttP1G1Wk6bjOj46vTSosVVe8dRq3jQFgYxhWOAL aCYA== X-Forwarded-Encrypted: i=1; AKwUvBwEPeCWmMhU43gIz72ZxF3x7V9ThVNNPJ4D1kF4n8XQg8xM8xt3guzLLBBGURJ6jtg2z5lMZuDkQ+emABY=@vger.kernel.org X-Gm-Message-State: AFuF++lI2MGQiuUK9gXB0gfFR94oWmaUU34CUwwOteEqGZYryM0uUgJ/ i5O0WVswgtqiXL91IJBL8Glt1Id6LbNIvECJlJzRzTEPItgJhHha9TeT X-Gm-Gg: AYBFou1yVT/LyUka/5KBj0waa2GsEAMk/RdLEsrCEY3Arm1UZ3GDBaAVgi5fe+8Cr1V 2vMg8AwDkh9JBQOdA3YP1geis71OixbwZsPMVsoKIPPiLslHdlkgy2WnLF+zSYJ3ERxL/ajCtuL iw2geLiSANZrKxb7NTEGOUbEtjU4gPqa1vdy02FIOLI8MgC/GMYXg6rMJlLYSe8xtq5gY09jKzs iKlC6sG2OVc9PGxgIdsHFoSlONpOtL4vN49sr/tfoOSbHMUsEwpkMMs/m8761a1x1p2XorwdyGH 2syKi8zBSmUiL+gTVF+h3+ju/mmkJ9zok1l6+WIIJbTTlp/UwboNzploPo9thalPy5+yzB/hXZq IRpTG0TAb2IrhHaPjx7hMGI5gAxVCNLL/pHStYlIvptF0xRo/vDu7lZ0IjfhU59nxp3bh1wIK/I R63B19e4GEpNisBTo8QyFa19ob3BKEXw6U1axyoSh8XzfwthY15AqCU427WA== X-Received: by 2002:a17:90b:1e03:b0:398:b17b:3bd2 with SMTP id 98e67ed59e1d1-39b260dda6emr15831418a91.4.1788601044620; Sat, 05 Sep 2026 02:37:24 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:5b5:60e7:9f67:1689]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d086adsm15763353a91.15.2026.09.05.02.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 02:37:24 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v3 1/6] iio: adc: bcm_iproc_adc: sort headers alphabetically Date: Sat, 5 Sep 2026 15:06:26 +0530 Message-ID: <20260905093631.48667-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260905093631.48667-1-mdshahid03@gmail.com> References: <20260905093631.48667-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Sort the Linux kernel headers alphabetically to improve consistency and make the include list easier to maintain. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index ab66b97d2f04..e46e3761993a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -3,14 +3,14 @@ * Copyright 2016 Broadcom */ =20 -#include -#include #include -#include -#include #include #include +#include +#include +#include #include +#include =20 #include =20 --=20 2.43.0 From nobody Sat Sep 26 03:51:25 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFE62388878 for ; Sat, 5 Sep 2026 09:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601055; cv=none; b=GlZFPxTj7bXVvZYD7qbtTQDhvAQb2MyA7Ti7A0Mnvx3cJ1NK0qQLJ/hUaWBjJtcGN4pz/TcSSMfK4zOaufj2rDcO+rRIg1PpUKxJXWBtZXOp18zqN3+Pi44cqX5ASNtRRnigWdkrRSlvGZ01c5rrUL7gYQ9wB6fX9BXfivABbjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601055; c=relaxed/simple; bh=Xp9ENmv/lelwk4unttBWYQyxWUh9lt3BGxEuS6wNFkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jeq04YMjl5Bf9LTQVwxlRp/pjy03s/dJSIxqU2/avSBvi1J8RHiyKYHDrN5nNoknsELADj4EqYqkko8nFj4gXzChAIoh0Lqt5LxQ9dBLRJqHJt+llDGXPqfperPD+ZkosV8hLjMbuo5MC3kDSmV2ZKYMfGOgdoismUzvj9ZQVMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r/6pu3pz; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r/6pu3pz" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-39b35105ba4so1232730a91.1 for ; Sat, 05 Sep 2026 02:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788601053; x=1789205853; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9qSf28+gMU1cPc/sgLS/ZHLrlXSMGyx8oSsqQzyWeBs=; b=r/6pu3pzfhbiP6NDy5oXJU8bHG4PUYoqswdSgm1oCFDSY2AkCvxUDM8fjqvhmcyw/F Ln3AcTdW6VAZV5O55BJi4YnNbRVyafctoo9ghvpDgknXJWpv2MuprBMYqtfM5KOOYnoH vWP2PnhQ5Q0YuGwCQMbkWUt+QV5Ga4CHmzkLnGRvB0sP1JECMebyqIZea7MGR0ugoeYN hgfw7D2mSBMzcQOY8Nm6MuWpHXJcMl9XqykPuwxrquYJW0a/BtL16XiGrQt/L7hclLEz n/D1k0D33+PmMDss7qQ6T1usQ1l4Mrcz/b4zZjctw0bHOS3/ftJKFRYydI6xdnQHniRH QuuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788601053; x=1789205853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9qSf28+gMU1cPc/sgLS/ZHLrlXSMGyx8oSsqQzyWeBs=; b=D0sJtEHvyoxbug/qzokbjU/us8/wrWXK9bDe54Ln/0yleS+8F+xz4V7VDshQNNTtNx r32+iAx4pBAqOeAyb5f1CBMpTn+Su5gbut1T4Q5JA4s5RN5AE6Jq1ReInmopT4/uj+Kc 85Jg6D93fswsJut9rCNEfaMreXnHwuwVyXLYvtJH1qXvEwc3BJdKiAs7k0UCVqyTrq9q Dg7mZ87Zevz2i2mThlEXj/NH712ND9LvboRs15G6nRtyhlragfjDpaG9bS7stwjCgpoT OO/ggsI3jDXGjTJqny9FJbhMGUVW8vFE0L2LVQJ3dqMvYsUHQrjeVpY3lGPFCx1ziwmc YFwQ== X-Forwarded-Encrypted: i=1; AKwUvBy0uwm7B/s9p5in9esL2tk+IbUt3D2ph7W/Mi0wSlxko8A2lQ4dKxt1vLBCIgoqfLzNjDOw+Wc7afQ8zME=@vger.kernel.org X-Gm-Message-State: AFuF++mxcKO5bY6+9FImrfDAZR0eOruEK+38vQsA3SkoYXoas9huIp5T KydB5I/SbHIBhxCeLa+4gry2KH1wxXtHyZUpyGfwyql+uNb2q4g7HWz4 X-Gm-Gg: AYBFou170mfv8sg7DFE2aLK4ytn5T4mHbRBP5jUwOgJTGAIEohLxRMeqxNz8wKIdW3p YJ7pg40pR0rjgYCnNj6xTJgl2L1GxvXYJKpoakNWQcHIntnUeWEOnEMKLSOAj+pkySuHlh/ItSl XX+puuszGnULecGXgcvKwy3QrWxxHkmOonHhu9YOrTeUAWuUMEx1oEfjuoeLVz/DDj73ywgmw2M ui6hm07bfTrQiSP700FMTdcIb14OmxPgRbCTxCizWzHg26+G5FMgo31suQ/QPO5q+bRmmF4WtZM yiUMSt6V8CrZScFIECno/nPoGkPPsmjznbkVP0vhxNzTVhhu/Q2h8IhwrDrF5wp1sgP0KlWeF8H 7Y0RTGfapSh7MI94kcMdsdivBF0Up+Af+J1uMDme4OuHFNC8+d3mRojT6M9HBMdr5QAAKvyh7u7 ap2oDBq3yy+VYXGQI5tHwLGn3J/xCKWiQ44UEpBx7rRB9fw6LbkXhsyNkJrw== X-Received: by 2002:a17:90b:1a8f:b0:398:d2a0:87ff with SMTP id 98e67ed59e1d1-39b26101029mr16362724a91.1.1788601053217; Sat, 05 Sep 2026 02:37:33 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:5b5:60e7:9f67:1689]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d086adsm15763353a91.15.2026.09.05.02.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 02:37:32 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v3 2/6] iio: adc: bcm_iproc_adc: fix include dependencies Date: Sat, 5 Sep 2026 15:06:27 +0530 Message-ID: <20260905093631.48667-3-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260905093631.48667-1-mdshahid03@gmail.com> References: <20260905093631.48667-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Add the headers required directly by the driver for the APIs and types it uses. Remove the unused linux/io.h header now that register access is handled through regmap APIs. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index e46e3761993a..e54f613d266a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -2,15 +2,18 @@ /* * Copyright 2016 Broadcom */ - +#include +#include #include +#include #include #include -#include #include #include +#include #include #include +#include =20 #include =20 --=20 2.43.0 From nobody Sat Sep 26 03:51:25 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A141F37D11A for ; Sat, 5 Sep 2026 09:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601065; cv=none; b=Xt3s1Y3LACaepVyP4hkr/MNCd/e4cZNXUXu+XWuw8VXDGI91DSpXbwZck9+MJDZG5y+IUwD3SVezOKqvTWUDpV6eDf0uBgh4rIBEbIU1/t0gy2mubbLAR+vaN0rTcSTGcAtrG53XrSYREWfTm4QiKg13RAJYoWd56A6ZfaCUbO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601065; c=relaxed/simple; bh=ksZpg4YtS2mtCV6zy/VLeMiRp4B1dHYEiUMBm61k9Lo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dj4avR2bl/xMx11cOI7Dx/2Wn1HF61JLz9509hMBssf9dVFDHAqNOqJQxfUsIh1kuaFo7tjF2aPYaK/WKtwWWxyK8O4q3WPk7Msuixckk0+wjBNfe/4G3RK6lIA1WqWXObrS83q2IAN+tWbhcSyAweq1OydCdlV8MgCPnZpRF+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GiEwRQ9K; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GiEwRQ9K" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-398b1e63c49so2649155a91.0 for ; Sat, 05 Sep 2026 02:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788601063; x=1789205863; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wQgZhvROIqcSSraACFKP6/ol+N08WZO9uWFrqbiZaYY=; b=GiEwRQ9KRixr7zUiDarGX6vYNRSWjRvfA6P/WKi3YC+h49Rq6ZtS7XbNvoLb7a25Nj l6k9o8mYbQVqsy5hQM1PLrJd1AuXi/JhPxfY1JUUmnbfEn1JBnVfFWhWWcrDbG3AQRq4 dV/3CWAYVP15WhfGsKCbAY4JgGwbzl78rzTNfiirdpr/qaA2XO851gqiyGxOr+gidGih ME60pB18zWQjnpE/yiKO6ov4zyjJVt/MBOkipUM+DAtqgmm1kVHbuvn0aySFEZv0fJrJ H0EdKWzTdncoJo+si7eOVV/zSGU9Q9ibDSaj5yY71+ueuRglfi2yG7GylFHUbxSC4CJu JaUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788601063; x=1789205863; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wQgZhvROIqcSSraACFKP6/ol+N08WZO9uWFrqbiZaYY=; b=rO0cQ+xMYnnl7MBgbtMi5hnLfAiNjKqIsAxnLqsGKnDcPOzoyjAaJNIjrrhCqNuvWw 7Wz2AD0x37YqzDKXLxg7zudZd8RFRPK9yfELarwgRNLGEDkS+utuE3atsurETIBZwRs2 BRs8gOuN1xRyPY91BsesXWbwgSB0JIQJMwHtot1+5qUeOISm8WeIivZr9d6cN9Gpb+wl UW2RxotwMVYeB5idCUgGqvgNWTQ3lMTJnT2O2iDk6v2PljG4P3Kns6/JCNh/KRcr11Ye R6oYGDOsqmnKRvIWkYFHbIechBPryZtQnqXK84GpqAEvWcV4m016rVYrPtqAKkQ8m+GV MqQA== X-Forwarded-Encrypted: i=1; AKwUvBw6X25ZiouRGJ9G/XVyzg0P2Ul8zXrlGgnwY9CeGNnSHpdPrKXdzE2arA6Wml9u0NspcjsClBSON2TSrps=@vger.kernel.org X-Gm-Message-State: AFuF++knhkZ+DwGBal4PR3J6S4G6+FCyyTTnZ3zFDNWsVnG91E1vAx3e vDQ0dwWIiqwydLxnbupWw1qA/Q1qWsH5wKqVZAM84OKdOOfNV6BaJj7b X-Gm-Gg: AYBFou2Gfwh0w/pbNhGB4JLuIhDKyQOm01ynXhrgoyS2fA7VKg9xU2MrrpwSIV9XAy1 Ty63ElPBniPJ0qsm4xeH5aDYEM9O1d5FFQj3HCcZXgjijtqO9v13RjtV9nV66tFnlZCZRFz2kDI xc5HWPmk2MI0KDeDmc/eJKxXDf2kiJuUUvWISU9WHASasrjx7QSK5UUfhf1hxxPaLOBsIz3Jtcf YJOhiAIh7qNFBv2K+pbrx/1tuU04Dn1u4yxKnyNAnIzUc+83C9OCVl0yQwmesYSVvIfvKJnv+IA xg3BsOwbK+6JFy6Yu/zDDsmV1X8NQpOndk/ZaPIMjPsfoDF3TDqHUe6KhlI/rvRA6SoknyqJdLY 4OkUr/BQhfezSKGHUj1lJJ5QpjkFnHcV5wuoisfceAM6P2zW7dJx4OzWll1LpLPc+XOCLU2tq0t 5fsIDYw4eVzEFw9qj8LnTfS+pGsW8ZeKz60yzcLlQX5PLgdx0/nql8Y/lvbQ== X-Received: by 2002:a17:90b:1d4c:b0:38e:6d55:b1a6 with SMTP id 98e67ed59e1d1-39b27c121dcmr8907641a91.3.1788601063050; Sat, 05 Sep 2026 02:37:43 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:5b5:60e7:9f67:1689]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d086adsm15763353a91.15.2026.09.05.02.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 02:37:42 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v3 3/6] iio: adc: bcm_iproc_adc: use devm-managed clock Date: Sat, 5 Sep 2026 15:06:28 +0530 Message-ID: <20260905093631.48667-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260905093631.48667-1-mdshahid03@gmail.com> References: <20260905093631.48667-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Convert the ADC clock to use devm-managed APIs to simplify resource cleanup. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index e54f613d266a..3bbf814d4c8f 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -109,7 +109,6 @@ do { \ =20 struct iproc_adc_priv { struct regmap *regmap; - struct clk *adc_clk; struct mutex mutex; int irqno; int chan_val; @@ -510,6 +509,7 @@ static int iproc_adc_probe(struct platform_device *pdev) struct iproc_adc_priv *adc_priv; struct iio_dev *indio_dev =3D NULL; struct device *dev =3D &pdev->dev; + struct clk *adc_clk; int ret; =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*adc_priv)); @@ -529,10 +529,9 @@ static int iproc_adc_probe(struct platform_device *pde= v) return dev_err_probe(dev, PTR_ERR(adc_priv->regmap), "failed to get handle for tsc syscon\n"); =20 - adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) - return dev_err_probe(dev, PTR_ERR(adc_priv->adc_clk), - "failed getting clock tsc_clk\n"); + adc_clk =3D devm_clk_get_enabled(dev, "tsc_clk"); + if (IS_ERR(adc_clk)) + return dev_err_probe(dev, PTR_ERR(adc_clk), "failed to enable clock\n"); =20 adc_priv->irqno =3D platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -550,10 +549,6 @@ static int iproc_adc_probe(struct platform_device *pde= v) if (ret) return ret; =20 - ret =3D clk_prepare_enable(adc_priv->adc_clk); - if (ret) - return dev_err_probe(dev, ret, "failed to enable clock\n"); - ret =3D iproc_adc_enable(indio_dev); if (ret) goto err_adc_enable; @@ -575,19 +570,15 @@ static int iproc_adc_probe(struct platform_device *pd= ev) err_clk: iproc_adc_disable(indio_dev); err_adc_enable: - clk_disable_unprepare(adc_priv->adc_clk); - return ret; } =20 static void iproc_adc_remove(struct platform_device *pdev) { struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); - struct iproc_adc_priv *adc_priv =3D iio_priv(indio_dev); =20 iio_device_unregister(indio_dev); iproc_adc_disable(indio_dev); - clk_disable_unprepare(adc_priv->adc_clk); } =20 static const struct of_device_id iproc_adc_of_match[] =3D { --=20 2.43.0 From nobody Sat Sep 26 03:51:25 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A3CF33C195 for ; Sat, 5 Sep 2026 09:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601077; cv=none; b=Hyk/OQI7r4bUHSO0xnlqEl5GkkhfWMA8Llxt1g7fkAAOTIweFUERELyaSWeNdVpL9Wp/HVO/TGEPjifEpYvv+GX6YfQVAsJ5lDbojlbTi1rmhA9O50yyH2VPyeXUvSMu//+dLw44FU2KEit4elgVr3SJA8AIpm8sv2+AcFZp4pE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601077; c=relaxed/simple; bh=mZPq9LcmgwAvNURf/extfUGWqqJSNfRaX6LbCY+2TTM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MBZRRFNorIkegzAuXPYDpxVuvRDqlu+nJHaecfr86sLzjpBUK8Je9UgvX9NxWAqtwytklwmnRjw/fCyCfFaiayU7i6Z9L2JrYUy5Dd2HAa+viIxmGo/x0v05wg3zAz5xWBMUxjpNFQhWYXRY4FiZ5VwQpimqF+gh1jOIEsYVahc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rNohPktb; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rNohPktb" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38511175ad3so1611203a91.2 for ; Sat, 05 Sep 2026 02:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788601073; x=1789205873; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cdCH0/RB1tBvaj1W6sXWObI//sTHWe8b2CDTC69fJ18=; b=rNohPktb0DxxJNtokoj+tdSF8Laf8JvPGaOjvofMq7Oy89G4iudPODk0Wm0k7oXoXn bv8gNuZ41rz/COfBA37gKvRaVN2zXoy/qKPJ9G8SrO9OVNM6Y8cPMD3AQqyV8OFMG8oh GIr+MR/udKmMwNsp0+Hqgu9NQhg4BjyOlKV/xbakFma/0p/lmr4dkyHCYncm2X8zg7J3 QES1VHnwaPhTsxVGIyD2nV3pr8gBFX3bsaHeWhKQlVay9JtjvSk7iO7RO0qtGv4AcrzQ k4D/SGXKkowa6Ig1lm/MHfrup6DFL4OIoNXKT1a7AkMPfzssTpZhU82KM00f/p9VSyv1 jqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788601073; x=1789205873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cdCH0/RB1tBvaj1W6sXWObI//sTHWe8b2CDTC69fJ18=; b=eY0+WYR+JDreTKNw103qLECteCJa9EE1ir//pErKhXj0bRs0nYFfpYZuhILMgSX547 AkSBeIxuf77Lf/bTwCX9eqk5X2Vwu3WKuD5hLi3tU8Eid4GBPxGptHgdmNm8bg0RaJHA l+Vb6xkm3nMnlBcaSL+1kKyrlMNr830tiZvjtHtrCTSLTkIyu2uM/DSnF1KYDrxuv4Jn OVZ/vDdYRPqKQ3Xy8ZpadIFrB9Wb4QlAfQsYhO0c3Sb9mwcVstp5sfVEVt8XDDk5ngMH U9sOrfHPwHap14AsiNK9rcWrjqIUXpxoO/v5pwO3hr/a0fkFeT4i//3YmkSRK/m9x/pB 7+ZQ== X-Forwarded-Encrypted: i=1; AKwUvBzt+h8xtTs7E/40SsiOamZkQ0if3q9Q9Fxs1yPxhn6Wy3XdovdKKPMEsH77M27bvp4Tw03CvizFTcl9Ulw=@vger.kernel.org X-Gm-Message-State: AFuF++mu8rnqSrxhngYi3uxtnssEThaU17f+nVW4b/nQY/R2kaffdnYE Dp6LCgGhxkqIccmZFiJ40HUeSzfNA5jvsQIcbjKrw+s+VwfGqxIgvqSe X-Gm-Gg: AYBFou0v6GTMt0nms+VZXmzlhjirQ2Wb+xE52UJsAcU6kfUdGCS57GR6HqZnnIhyIa6 M1fdXMkLjZN3Ne93DuIc/LjMBQcs6zPLbJC60QFUYfqYvhuaRH+dvpHQZey4ewNKOaI2yANwOGN 5U3v1HEf9GCc4VkeAIfGrI6q+v5Y/jAcAnSWwJGb7GN58Ig/N4yMeV8eI0gNwOIXsmoBQsttAg6 +uu5ut8BKPh7NZL5rF/9OhdoTGaKfjrjhMD6VrQ7LZesQJs2Ep1Fgfxy1h3zus2GP791vfPj08u JZD6Wsowz+OojQ4qQaifBVYmjV6dGoq5APIPYeeoIvH6ooWZ4SnPcIFB5/GLoiiFYTDdCPCdW90 pGJ3znNMwk9avcgLJIhwTGbIf3DnRnENJja+CSdfBR94+HuMLEHanZGUZMQ+mo5wDj45d3NvTGU 22eTJmPYMhKgCS4TbjaRP1y0/XESaXPPy4rrs9s9DIJLfmnwJNm9wbwlZyuw== X-Received: by 2002:a17:90b:3b8c:b0:398:9bd4:d13 with SMTP id 98e67ed59e1d1-39b26242a75mr15470856a91.18.1788601072809; Sat, 05 Sep 2026 02:37:52 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:5b5:60e7:9f67:1689]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d086adsm15763353a91.15.2026.09.05.02.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 02:37:52 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v3 4/6] iio: adc: bcm_iproc_adc: use devm-managed ADC cleanup Date: Sat, 5 Sep 2026 15:06:29 +0530 Message-ID: <20260905093631.48667-5-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260905093631.48667-1-mdshahid03@gmail.com> References: <20260905093631.48667-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use devm_add_action_or_reset() to disable the ADC automatically when the device is detached or probe fails. This removes the manual ADC cleanup from the remove and error paths and ties the ADC cleanup to the device lifetime. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 3bbf814d4c8f..24fb41751e93 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -450,6 +450,13 @@ static void iproc_adc_disable(struct iio_dev *indio_de= v) } } =20 +static void iproc_adc_disable_action(void *data) +{ + struct iio_dev *indio_dev =3D data; + + iproc_adc_disable(indio_dev); +} + static int iproc_adc_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, @@ -551,7 +558,11 @@ static int iproc_adc_probe(struct platform_device *pde= v) =20 ret =3D iproc_adc_enable(indio_dev); if (ret) - goto err_adc_enable; + return ret; + + ret =3D devm_add_action_or_reset(dev, iproc_adc_disable_action, indio_dev= ); + if (ret) + return ret; =20 indio_dev->name =3D "iproc-static-adc"; indio_dev->info =3D &iproc_adc_iio_info; @@ -560,17 +571,11 @@ static int iproc_adc_probe(struct platform_device *pd= ev) indio_dev->num_channels =3D ARRAY_SIZE(iproc_adc_iio_channels); =20 ret =3D iio_device_register(indio_dev); - if (ret) { - dev_err(&pdev->dev, "iio_device_register failed:err %d\n", ret); - goto err_clk; - } + if (ret) + return dev_err_probe(dev, ret, "iio_device_register failed\n"); =20 return 0; =20 -err_clk: - iproc_adc_disable(indio_dev); -err_adc_enable: - return ret; } =20 static void iproc_adc_remove(struct platform_device *pdev) @@ -578,7 +583,6 @@ static void iproc_adc_remove(struct platform_device *pd= ev) struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); =20 iio_device_unregister(indio_dev); - iproc_adc_disable(indio_dev); } =20 static const struct of_device_id iproc_adc_of_match[] =3D { --=20 2.43.0 From nobody Sat Sep 26 03:51:25 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF5363D3D0E for ; Sat, 5 Sep 2026 09:38:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601086; cv=none; b=hWiFzLI605PNsXaHChK54oIkFJByIAttSIwSbwRMCcEBlyVdCjQrRqd3HzzumB7z1IVdTBdTMjfSGfDExYtszupImIo0xUIoaopxb3oLUIAwwQrihWf4fSJnuzPgRrfAEZHH9uAgxcuNMWGmMQjMh8ZhYDGGZZfXMpOJj0cWpWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601086; c=relaxed/simple; bh=vUdNV9wDoEuZJ8Vepu5sM2pMfaScmqCwYv/P2v1M6tM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j1QcfaZ/ZmSJMBwVBGPxen6O1FkfLBqEwY6nhQ/doR1wHMAuUlQ7iO3IU1gtPnthGAMYOh6LgrQa5ryXpcQAvLftyJqIlEI+HLCV4I1h5+70iHPGqkNIh+OLC47X8Fn+ohyUx9oYxufV1GOZbB83RzQqYJ+j4ndB7Tx2WCOeYdw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UyYOzbws; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UyYOzbws" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-398c1101c1bso1827699a91.1 for ; Sat, 05 Sep 2026 02:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788601081; x=1789205881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8D/ScigX6w0Ntks8tt1Z8HJ/HOkWf3QCL1/JDcSPE1w=; b=UyYOzbwsGSCaUmxfD5zxhg9iyyKaMmoJ9mfMd2TwhtmnPurq/IifM9OVZRkS08d5gp X0pAc+c8mS2X35TW+bcEFlMQ7NOhqJVMzMotzvSrvMuJJY0oiredyG0Rt52Sb2SoWNM4 3d9j0JEnUaGby+ebPsV9sC4mNX2066ftwhWpRIjxYehQsQ0EiUwoIA5WMCg+6Azf0vhm jIWpRk9Oe6Og/aZCpVAgqWKT/LDXhfEd836ngZgPYeeBpiO24rpOI+Er8ck1FanZqal7 sMe+jTDtJLSSblA95ySWPR5PRPwG4wXi4n0dyZX0P5BW628JHv4DsjoHAiLfNW8plXI3 RZNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788601081; x=1789205881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8D/ScigX6w0Ntks8tt1Z8HJ/HOkWf3QCL1/JDcSPE1w=; b=faE3WDtZ03QQtWs0t26MsXf+1k3XQVLcRUtVcb377mw3ueR3SlCl6Y18xTmicCx9Jc 84RfILwuMAaF0qo5O5OAx8MwLji5qy92cGVr50b2gSEW6QsLjnq2Y9z7K2u5ktbAvygB lmQVnzGNFijQbe4QAC6dvcKjmSgSlhc9xKi6OzI4nxbrhyl+FGANAHw86dM5wOBtFm7P zg8eQVWiDmqoubzkhV8bz9tbqRvQpRXcnBGznh/w0o2qRqqZy5+Uz7SpWpxBFesYVKzT 0/AYiElDUnATz9qNX5bqn3OcHfae0o6va1I4jmv7gmZQ2RzQ7dinFZfewGiVJukwX5LP 5EaQ== X-Forwarded-Encrypted: i=1; AKwUvBwedtlifpmW9DMvyES1k+WbxJEcsxeU+CsC/I0JWMMWGSZZACqbMfc3tDC4FDVJLVvC9VDFGA6PGMIFtr4=@vger.kernel.org X-Gm-Message-State: AFuF++kkPMRCMGVm4si4gSMpVqD6pjHOMxkqtQb5qjWToKvTRl/Jg1Zp AEeNsoldWOfc9uSvdpy0JS3t+QOVk5m/WVgF7Avu3uM8Wy+ABL4oYeaS X-Gm-Gg: AYBFou3sZq8kOw2/efRx6OnLQRA6S9N+/SdQZDEZ4SCTXKO5cP6CJKuuqzioYlSPL6m 7GGVAXQnh7d9nmnh8jkfdKm8bnXVtRObJB+0PHOireTkFJtjSdDcIZI4gtLwubMT/Cq2zLN1MOm h66d/dQjCvtIVBmpJIprr0XZkrzeQgYB88RklE4Egby0xpMDPtyggCxtwhsbN0rRuRtAfV3Qsbx +dEZYWyZDl31uYyFGhs1Ur2iLJfsYf2Zq9UgHrEmNse1C8CO2tXAN2qhPDWotx3hXRK7BzOWavf tejyKJPfcYQaH2hN4xQJhu+W/SiZX6FtlVIuleS0hDGpHXfc9P1eaL60Ave6uy8Lv7dJZf+H12e ZDK0wT1ZzJJDD89k91Wb9FAGdXMzU772RQ7DEqXfU/D1uO4oODr1Yzzvh/gdaPkVdkNk7UURNve 4AmPB4Amv9yAp3cws6rMI/PP8gDWqksVDHmI8VPXlhodcwgk12thdZ5eq4Ig== X-Received: by 2002:a17:90b:3b8d:b0:398:b426:ca4b with SMTP id 98e67ed59e1d1-39b2624f10amr16533121a91.22.1788601080936; Sat, 05 Sep 2026 02:38:00 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:5b5:60e7:9f67:1689]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d086adsm15763353a91.15.2026.09.05.02.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 02:38:00 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v3 5/6] iio: adc: bcm_iproc_adc: use devm-managed mutex initialization Date: Sat, 5 Sep 2026 15:06:30 +0530 Message-ID: <20260905093631.48667-6-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260905093631.48667-1-mdshahid03@gmail.com> References: <20260905093631.48667-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use devm_mutex_init() to tie the mutex lifetime to the device and improve debugging when CONFIG_DEBUG_MUTEXES is enabled. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 24fb41751e93..f4676607682b 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -526,7 +526,9 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv =3D iio_priv(indio_dev); platform_set_drvdata(pdev, indio_dev); =20 - mutex_init(&adc_priv->mutex); + ret =3D devm_mutex_init(dev, &adc_priv->mutex); + if (ret) + return ret; =20 init_completion(&adc_priv->completion); =20 --=20 2.43.0 From nobody Sat Sep 26 03:51:25 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0D43D3D14 for ; Sat, 5 Sep 2026 09:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601093; cv=none; b=ijfTRvdiTunvrmmLDJ2C4wka0IJsDKMPU9A3P1mNrt1rNKdG2Og7BeMm9NQv1OIVQ4ktAk8mqSvNxV3onGR4+UabGWmn50/D6yCcDuDOOXkXpMPm7xrEG60KBYjGiu6XmMi4JIV9zrZtFWUMmbIC34r3hwObaJ2JigYe+vhlECU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788601093; c=relaxed/simple; bh=/SnvANubHgj9t723fD3mWASr15hxcpq0LbaSmB4ROXA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GRT+ODpa6Ipzc+5Q7fNhU/wApCAXuhP0Nf4c8zmbzEbTfQEJxgGzpGdyA5kese9A5eojslxlIOlHFAJZyCIlsa/1LauYNA7EqHpoowB9Z3Hfqq+R4dJoHcW/p8vL2N3tF4WLHqBDjLMboXhAf1ekPdjIO5Y82cRnpoVh8vwr+4c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qFzKWe4v; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qFzKWe4v" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3964dfb5a69so2559227a91.1 for ; Sat, 05 Sep 2026 02:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788601089; x=1789205889; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FKhaAa1V6dcazyDIDdMRIu/saWb8D7tpQe+JyGNOhTA=; b=qFzKWe4v6mY7w15FxyEseDpJtEZmkYtf7jV7h5U8m2y3uoq+lAEAGIq68NqHIGWoXr 3HJizsIOmFMWHvA6n2qyPY5rNsEUBIPQ32nOtVCUyDBQj3E6MhenCzQfQgFPRs7pFeFk 5B05p+ZZ7V0oTumGQn3ZRB5huy5+euDIwP0YQ9+k3XVF2P7I35Ef9OTQq18AA7tQyOaX HOZBvuy9J3VNNubAu/FJWKkwBkd1LqvYiXelfyDhbOdwafEBfR5Cgiy2rLOHkQ3V0G+E q6A4aJDYYulW3wmKKHFDBR5aGQESEixBI7woiO52XNbfzPo6460I9jmuNCzzzPKAW3Ec l5nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788601089; x=1789205889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FKhaAa1V6dcazyDIDdMRIu/saWb8D7tpQe+JyGNOhTA=; b=MQwP18nTXalETb8/601JCcLkXiwmzWwZWs8ueTusECLqgisasuc8KZ9/Oa0bI+G8lV 4OBY98uhp0cYbEG0cLakiOKY3AkrPztkKDz4k4Kywnnx1SfI723yTyLX7E5s4E47wQ8e l8HAQHYKrAaDzPOOs5aVovbL5czgV7yB2NQ42hGS5/zE1ZA0touARkwJbOMkS2sjBGCL m0T2K1SxOc05li+7X6Mrq91vhX6Aumj7xwTfe7WkceYTYb9l8AjpCcnBR/gNLJ9RjVDW 0GLTKuhXNavfX3VXYgilNvnzYBJZ+h8mVhEL15A954IalOOdcJK8+SBdZ8gBulRmTw15 F+2A== X-Forwarded-Encrypted: i=1; AKwUvBw9dmSvqVm1DQUgTwI2NKh048K3E4sFwsGklqPhRBww8pQPGy6z0zvD0qgIhsCo8IPWb8zXj0G5YF3nz5I=@vger.kernel.org X-Gm-Message-State: AFuF++nQ2wFQTxJrrk6S0gaghva1gIzDRx/ooPeRMPi0JDHeCeRpVk+j PbBEVQPt097+tmz/wLAZX/NWkW+7MBANjGPTwYvOlMhHVHoVNgrQGiAD X-Gm-Gg: AYBFou0ccZimZdrtsVAudKvlmIsiyb55vQoDAzoy5EkTC3/3W8zJrcnSbKbFgVjkit9 FKKPpBxVHeQsrWAsI9JjIFn/MsP66mr6tW/F8HqN8vG6sTlm4fePw+A325WdJQ5KQAxCQ7xldU6 Hr6I0fbOtiFPD3ku3kQrQgxdp9kCQsirXWi6/CtKTp7rvDRChlu3Cr9dFxpsa3jOjPlgbEZ5C53 ZXM7U80MkD0GfOx4klLkw1Ysv6/cUwxxPECStuz474kWMehMKvde1QE1xbplJNeRANRCjmMJ/tY mr9JS3cEUjaJnYnPlYL8BQus70B3BXj1M69oWAIfuQhZpqEE5QNw653cOY1iZkIXiPefVMm5oUz JNBamcyDx24Zimm6O/qgC5QnrpyRT4iuXQBH38jiqjjnmuxRWYQaZEYuftetniNi1cx2oeaR1vF Y45asjjwv7vNgtT29r8yLzT1xH6F6pFHP6LuQadnKg4XNmbDuLz+visBmENA== X-Received: by 2002:a17:90b:3d89:b0:398:9be8:ea69 with SMTP id 98e67ed59e1d1-39b262167e7mr19037767a91.22.1788601089070; Sat, 05 Sep 2026 02:38:09 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:5b5:60e7:9f67:1689]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d086adsm15763353a91.15.2026.09.05.02.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 02:38:08 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v3 6/6] iio: adc: bcm_iproc_adc: use devm_iio_device_register() Date: Sat, 5 Sep 2026 15:06:31 +0530 Message-ID: <20260905093631.48667-7-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260905093631.48667-1-mdshahid03@gmail.com> References: <20260905093631.48667-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use devm_iio_device_register() to automatically unregister the IIO device when the device is detached. This removes the manual iio_device_unregister() call and makes the iproc_adc_remove() callback unnecessary. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index f4676607682b..6eae7596ac8d 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -524,7 +524,6 @@ static int iproc_adc_probe(struct platform_device *pdev) return -ENOMEM; =20 adc_priv =3D iio_priv(indio_dev); - platform_set_drvdata(pdev, indio_dev); =20 ret =3D devm_mutex_init(dev, &adc_priv->mutex); if (ret) @@ -572,19 +571,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) indio_dev->channels =3D iproc_adc_iio_channels; indio_dev->num_channels =3D ARRAY_SIZE(iproc_adc_iio_channels); =20 - ret =3D iio_device_register(indio_dev); - if (ret) - return dev_err_probe(dev, ret, "iio_device_register failed\n"); - - return 0; - -} - -static void iproc_adc_remove(struct platform_device *pdev) -{ - struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); + return devm_iio_device_register(dev, indio_dev); =20 - iio_device_unregister(indio_dev); } =20 static const struct of_device_id iproc_adc_of_match[] =3D { @@ -595,7 +583,6 @@ MODULE_DEVICE_TABLE(of, iproc_adc_of_match); =20 static struct platform_driver iproc_adc_driver =3D { .probe =3D iproc_adc_probe, - .remove =3D iproc_adc_remove, .driver =3D { .name =3D "iproc-static-adc", .of_match_table =3D iproc_adc_of_match, --=20 2.43.0