From nobody Sat Sep 26 03:10:40 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9298C35294E for ; Sat, 5 Sep 2026 01:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788571791; cv=none; b=XMvWYwjHw+bQcQuVCLOcsoZENYA69OJewsSzHBo5KNSSClGPvsIx4KLxHZwd0aOyXw4RlH0EytiPY5KBZA52foQtMigLBXef0V66zA+Us1xbVNfQZkZufEwWPwwsI2RyT95kMqL34Klhf85qu0WblAdc8bm6twhxngS1lzjyL8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788571791; c=relaxed/simple; bh=kB6Y69J8xQxNRoZtC+QJTY6pTN5GuxaasoivLO+XkQc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=sxkBm8hFxffSyt3SPHckNwDBcqCQMJO2khBVAexgq7tqlfpGYruWwOeQUH9kcyYTBrqGgGWI6o3C5oQm1t8GkQrXBsvp4pQO7yVhunGpDmF6QClytm6MXI5IxAVE5PYPbarDrl3HpmeIApvqRfNfSW7/k0kNTXF7ksC4dqBDP90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mIjbi+7I; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cq0EqpKq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mIjbi+7I"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cq0EqpKq" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6850vfg41263931 for ; Sat, 5 Sep 2026 01:29:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=DJAH+WvW2+8TfCFgQvit0O UCkyNjque5PSlZgBoGoZA=; b=mIjbi+7IDfQDMpQKVAVGH/mz9L3EWXl6PsZU+z HWDDR6UTNe4yOs1aJ5xmoiXQj02o2go4v1hw/kG3ryqt3ntWDEdfifPJdL8fwemo 3PhycyhLMHQelVpz37GCJxn0RBY28AtRAnkFeN81Z2dLMH/JN+yQDU9L0hRf1fL9 iiZufik9trHgUyawLOYK75iWRJlq3UZTjeOnRFs40fTWrRR7G+Tjrz8Io2ojKNw3 +QzO03ue3Vnri6d7xkoCdkAiInd5BFSsKHqe6dUcrNd0eNiDOX2VngTmD3r881I2 cXWrDQujzZUSeGdpnznt6j57Z2e8g2H9x0Ic4VVPQzq80pVw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gg011jvrc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 05 Sep 2026 01:29:48 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38f283baf1fso1827336a91.3 for ; Fri, 04 Sep 2026 18:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788571787; x=1789176587; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=DJAH+WvW2+8TfCFgQvit0OUCkyNjque5PSlZgBoGoZA=; b=cq0EqpKqglVzuyLkM/ibAlwsLry0YZU07V3SCMLRpd7F+d0ZRAZ88ARYmXcxWF6jQz 7zpqxJfHORWwHiCnmwJDy73Wn03EdabhKXquL2bI1Il3+wo9W+filoFK9KNiab5HZXQB Kf0q79iwypUG2PbI8v83jOcDMSHgYbFITF8dKv6lohEVGfxD50EDJNdgdeksKYnK5ycu HCVQVy0DsYcpKtNVr8ZVWBsBtnuphvYzgjKG2TJ4XMoCfDaQtMxLCqgjb2zMez47ZeJ3 d00+KhoYCbFbRUwv+k4L5t/D9Mhry6xqeZ76w2n1QilwauHAg795rfUgmdMYVaxz4IKj IjIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788571787; x=1789176587; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=DJAH+WvW2+8TfCFgQvit0OUCkyNjque5PSlZgBoGoZA=; b=DT6XfyEkwHqsW5OwZGP+0ULdwQguDNSOcGQUYypsrTkqKRvffIqh2AUq4jheubnAp8 51Y7gifdourrQBt097A4QXC7zGLIBQE47jEY47pA0yOl4abP9v0w09WLTkC6E2fdv63a Z+yb713kpurEu97HUgg38MkaUbydf8ddtnEVI3ZUNpH8jMPooxKD88bypMP+u5vtXgte LAoqRpgLlYTvAHMEWVtAOIvMztn2VhSwh4WhBlmNlCG3mQLpg7tqEYYVR8PLmnQtq/oz sOGc2Mj1JJ609deqktNOYKVQHuBhv/EgxMNmneRDDAlNFMXgPMiSug3gUmWj6kmRN2sz E8Gw== X-Forwarded-Encrypted: i=1; AKwUvByPsl1Ua9lP/PWJ/fOs/Kx5TV8aIuB5jccssZiWtTEp6zUa2hxlihgwAOsWn3wiI2jsZVJmSnDtCc3kLs8=@vger.kernel.org X-Gm-Message-State: AFuF++lMFNv4OeqdCZ/xVi2Ajqjw0ALrEcfb7iirTQj4cOVcHYBM3aQm fsraGPb6SA4ttQoVmqF2HIb9zNA4EOe2q2yOYBHsK+oclDlHKsjA/HuLxY/AKsBQdEc4mTF1pTH g+4otbDL40VeuZ1tstaqZJzIefTac9CTT3LEaOVSpadyJXN82tIz1SXB1w3WC3iyqI/0= X-Gm-Gg: AYBFou0tBnPfBcOcnfZ/26SFpJkMK3vBa/yCTU0bCkvEPlwNTdrpE7voGJiajVIKgjZ 5Zry/Carmcv29J7AyOdNNcpO2lfaa+6V9k0m2Aayxaa9WT9pC/6hn8BDCAN7bik1TSsCKkSAZwM 21EZ/IdRwx4HG6w5TeHNxIK9tF2gJ5jw9cSvuES4cen4gL7pGwAX769BfiWRZaDoY5W8kftXeMd Gj+XFM7n44aKRSjFL1hDIwVcZ6WJ1Vp+1Q0WQV1y4wKfBiB3ZuSYZnBHkyGQWCekheq1vZXSlh0 9jshIk5TyuL4+YtS+6w8HP+xxJgxlF8vqbP4lRvQ++058J/gDjOTe0Mdans7+XBomI/YNgOfdlX 8re1Dg/5lbAwPkFd8oHadeoCW6KMqxnJVES4= X-Received: by 2002:a17:90a:d003:b0:398:ba9e:75ff with SMTP id 98e67ed59e1d1-39b26273a40mr15274065a91.21.1788571786853; Fri, 04 Sep 2026 18:29:46 -0700 (PDT) X-Received: by 2002:a17:90a:d003:b0:398:ba9e:75ff with SMTP id 98e67ed59e1d1-39b26273a40mr15273974a91.21.1788571786086; Fri, 04 Sep 2026 18:29:46 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b8f44d7sm9833268eec.22.2026.09.04.18.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 18:29:45 -0700 (PDT) From: Krishna Chaitanya Chundru Date: Sat, 05 Sep 2026 06:59:29 +0530 Subject: [PATCH v2] PCI: qcom: Add register dump support for PCIe Link Down events Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260905-regdump-v2-1-f7d34f9d4f46@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAHhwm2oC/2WNwQ6CMBBEf4Xs2RK2RFFP/ofhAO0WaoRiFxoN4 d9t8ehlkpe8mVmByVtiuGYreAqWrRsjyEMGqm/GjoTVkUEW8lScEYWnTi/DJBArvJjqqKlQEO3 Jk7Hvfele/5iX9kFqTvVk9JZn5z/7VcDk/a8GFCiMlLotTVtWSt4cc/5amqdyw5DHgHrbti9Hr t++twAAAA== X-Change-ID: 20260811-regdump-11719f75de0c To: Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krishna Chaitanya Chundru X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788571782; l=19186; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=kB6Y69J8xQxNRoZtC+QJTY6pTN5GuxaasoivLO+XkQc=; b=s1j92S2KFrf4BVXbNaXU1FyGoiy9PtGZ+vcrCtMCng5av9ePD/PeUVMe6y7OAVY7Ji1IyOczt MBiLykbBMFhCEw/MmvSAiKI2Z03BMUS1PmzVHg7QJ9U9qp9wh42T0Sc X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA1MDAxMSBTYWx0ZWRfX7YPJhX9o/9en CBspSlh6EOB7i0JKo9YXlEVr1GQLfXF05m6TCNX4IJ8X6mU1v2LTvIBEoNVNsyIamcYpz72Jipc mUNeYRXsybaZSoPJyGY885Pb6x53i3gNKd8lbFRcezRi8uBvOcJFhFhZmr6RbrkfexU7wmqodJM FN4o0nIxJa+EA5K5Fb3ORY7krJy00KDqLfbGPbfv9tcJbk7IKzlEcWXkeG/AKVxzucWqUmSchI6 zZgcI+JG64BQ3CNtBJwl8HeJYDV5qgEO5eDNkNFfsG+2Izp9YWywl8iXiVxlDfENFkEGcwOw5WU N8t/tyOB0x0myYHVQk1Exo934B9MtZoM8VPLTr3d/3sGPQcVEYCtIy6rhUTzor6vAhs9B0nTMkD 8EkUKraDAQwDLnkOCYM+cVumETEPNs3SM3OPwQwP2cwWB4JEe+7yGbbQDfH9AuMAmem8XWYBo46 FdcGTa7rNIKbIKeaTPA== X-Proofpoint-GUID: G1qC5lQg8huwc-PYLlSMevllCMzmz2dC X-Proofpoint-ORIG-GUID: G1qC5lQg8huwc-PYLlSMevllCMzmz2dC X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA1MDAxMSBTYWx0ZWRfX7ZkPo1ngUydz DC9G/CSsJ8o8UEyX3Uk3VcR2cEhNzG0tu1d8ezht7lvjz64ZK6a1PRLnxXdUHiPVywpifeQkaJ6 jg/kQsN6B51087qCBMkKVLYTT+N7BYw= X-Authority-Analysis: v=2.4 cv=Ibi3n2qa c=1 sm=1 tr=0 ts=6a9b708c cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=8Y_m6EmoaoLLPnfUj1gA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-05_01,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 clxscore=1015 adultscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609050011 When the PCIe link goes down unexpectedly, being able to inspect the state of key controller registers at the time of failure is valuable for root-causing the issue. If a storage endpoint is present downstream, the dump is printed directly via dev_err() so it is visible in dmesg immediately, since a devcoredump read from userspace could otherwise race with a storage failure. Otherwise, the buffer is handed to the devcoredump framework so it can be collected from /sys/class/devcoredump/ for offline analysis. To keep the dump readable given the number of registers involved, entries are packed as "offset: value" pairs, QCOM_PCIE_DUMP_REGS_PER_LINE (4) per dmesg line, with a section header ("DBI registers:", "PARF registers:", "MHI registers:") identifying each register group. Also expose the same dump on demand via a new "regdump" debugfs file under the existing per-controller debugfs directory, so the register state can be inspected without needing an actual Link Down event. Signed-off-by: Krishna Chaitanya Chundru --- Changes in v2: - Fixed the sashiko comments, add missed qcom_pcie_ext_parf_dump_regs usage, print the dump one line at a time instead of as a single dev_err()= call, create debugfs even if mhi is not present. - Link to v1: https://patch.msgid.link/20260811-regdump-v1-1-f22db3fb37c2@o= ss.qualcomm.com --- drivers/pci/controller/dwc/pcie-designware.h | 6 + drivers/pci/controller/dwc/pcie-qcom.c | 351 +++++++++++++++++++++++= +++- include/uapi/linux/pci_regs.h | 2 + 3 files changed, 355 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/con= troller/dwc/pcie-designware.h index 0735ae940924..ee97a5e9ed9e 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -290,6 +290,12 @@ =20 #define PCIE_RAS_DES_EVENT_COUNTER_DATA 0xc =20 +/* SD-EQ (Gen5 32 GT/s per-lane pre/post cursor equalization) registers */ +#define PCIE_RAS_DES_SD_EQ_CONTROL1 0xd0 +#define PCIE_RAS_DES_SD_EQ_CONTROL1_LANE_SEL GENMASK(3, 0) +#define PCIE_RAS_DES_SD_EQ_STATUS2 0xe4 +#define PCIE_RAS_DES_SD_EQ_STATUS3 0xe8 + /* PTM register definitions */ #define PTM_RES_REQ_CTRL 0x8 #define PTM_RES_CCONTEXT_VALID BIT(0) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index b58a607b713f..ba41a0eb43dc 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -33,8 +34,10 @@ #include #include #include +#include #include #include +#include =20 #include "../../pci.h" #include "../pci-host-common.h" @@ -44,6 +47,8 @@ /* PARF registers */ #define PARF_SYS_CTRL 0x00 #define PARF_PM_CTRL 0x20 +#define PARF_PM_STTS 0x24 +#define PARF_PM_STTS_1 0x28 #define PARF_PCS_DEEMPH 0x34 #define PARF_PCS_SWING 0x38 #define PARF_PHY_CTRL 0x40 @@ -62,11 +67,17 @@ #define PARF_STATUS 0x230 #define PARF_SID_OFFSET 0x234 #define PARF_BDF_TRANSLATE_CFG 0x24c +#define PARF_CLKREQ_OVERRIDE 0x2b0 #define PARF_DBI_BASE_ADDR_V2 0x350 #define PARF_DBI_BASE_ADDR_V2_HI 0x354 #define PARF_SLV_ADDR_SPACE_SIZE_V2 0x358 #define PARF_SLV_ADDR_SPACE_SIZE_V2_HI 0x35c #define PARF_NO_SNOOP_OVERRIDE 0x3d4 +#define PARF_CORE_ERRORS 0x3c0 +#define PARF_L1SS_SLEEP_MODE_HANDLER_STATUS 0x4d0 +#define PARF_L1SS_SLEEP_MODE_HANDLER_CFG 0x4d4 +#define PARF_INT_ALL_2_STATUS 0x500 +#define PARF_LINK_DOWN_AXI_ECAM_BLOCK_STATUS 0x630 #define PARF_ATU_BASE_ADDR 0x634 #define PARF_ATU_BASE_ADDR_HI 0x638 #define PARF_DEVICE_TYPE 0x1000 @@ -83,8 +94,12 @@ =20 /* MHI registers */ #define PARF_DEBUG_CNT_PM_LINKST_IN_L2 0xc04 +#define PARF_DEBUG_CNT_PM_LINKST_IN_L1SUB 0xc08 #define PARF_DEBUG_CNT_PM_LINKST_IN_L1 0xc0c #define PARF_DEBUG_CNT_PM_LINKST_IN_L0S 0xc10 +#define PARF_DEBUG_CNT_AUX_CLK_APP_REQ_EXIT_L1 0xc14 +#define PARF_DEBUG_CNT_AUX_CLK_APP_READY_ENTER_L23 0xc18 +#define PARF_DEBUG_CNT_AUX_CLK_APP_READY_ENTER_L1 0xc1c #define PARF_DEBUG_CNT_AUX_CLK_IN_L1SUB_L1 0xc84 #define PARF_DEBUG_CNT_AUX_CLK_IN_L1SUB_L2 0xc88 =20 @@ -188,11 +203,48 @@ #define PERST_DELAY_US 1000 #define FLUSH_TIMEOUT_US 100 =20 +/* Dump buffer size for the link-down register dump */ +#define QCOM_PCIE_DUMP_BUF_SIZE SZ_8K + #define QCOM_PCIE_CRC8_POLYNOMIAL (BIT(2) | BIT(1) | BIT(0)) =20 #define QCOM_PCIE_LINK_SPEED_TO_BW(speed) \ Mbps_to_icc(PCIE_SPEED2MBS_ENC(pcie_get_link_speed(speed))) =20 +#define QCOM_PCIE_DUMP_REGS_PER_LINE 4 + +static const u32 qcom_pcie_parf_dump_regs[] =3D { + PARF_LTSSM, + PARF_INT_ALL_STATUS, + PARF_SYS_CTRL, +}; + +static const u32 qcom_pcie_ext_parf_dump_regs[] =3D { + PARF_PM_STTS, + PARF_PM_STTS_1, + PARF_INT_ALL_STATUS, + PARF_INT_ALL_2_STATUS, + PARF_CLKREQ_OVERRIDE, + PARF_L1SS_SLEEP_MODE_HANDLER_STATUS, + PARF_L1SS_SLEEP_MODE_HANDLER_CFG, + PARF_CORE_ERRORS, + PARF_LINK_DOWN_AXI_ECAM_BLOCK_STATUS, + PARF_STATUS, + PARF_SYS_CTRL, +}; + +static const u32 qcom_pcie_mhi_dump_regs[] =3D { + PARF_DEBUG_CNT_PM_LINKST_IN_L2, + PARF_DEBUG_CNT_PM_LINKST_IN_L1SUB, + PARF_DEBUG_CNT_PM_LINKST_IN_L1, + PARF_DEBUG_CNT_PM_LINKST_IN_L0S, + PARF_DEBUG_CNT_AUX_CLK_APP_REQ_EXIT_L1, + PARF_DEBUG_CNT_AUX_CLK_APP_READY_ENTER_L23, + PARF_DEBUG_CNT_AUX_CLK_APP_READY_ENTER_L1, + PARF_DEBUG_CNT_AUX_CLK_IN_L1SUB_L1, + PARF_DEBUG_CNT_AUX_CLK_IN_L1SUB_L2, +}; + struct qcom_pcie_resources_1_0_0 { struct clk_bulk_data *clks; int num_clks; @@ -275,12 +327,15 @@ struct qcom_pcie_ops { * @override_no_snoop: Override NO_SNOOP attribute in TLP to enable cache * snooping * @firmware_managed: Set if the Root Complex is firmware managed + * @has_ext_parf_regs: Set if the PARF block implements the extended + * register set used by qcom_pcie_dump_regs(). */ struct qcom_pcie_cfg { const struct qcom_pcie_ops *ops; bool override_no_snoop; bool firmware_managed; bool no_l0s; + bool has_ext_parf_regs; }; =20 struct qcom_pcie_perst { @@ -1597,12 +1652,14 @@ static const struct qcom_pcie_cfg cfg_1_0_0 =3D { =20 static const struct qcom_pcie_cfg cfg_1_9_0 =3D { .ops =3D &ops_1_9_0, + .has_ext_parf_regs =3D true, }; =20 static const struct qcom_pcie_cfg cfg_1_34_0 =3D { .ops =3D &ops_1_9_0, .override_no_snoop =3D true, .no_l0s =3D true, + .has_ext_parf_regs =3D true, }; =20 static const struct qcom_pcie_cfg cfg_2_1_0 =3D { @@ -1624,6 +1681,7 @@ static const struct qcom_pcie_cfg cfg_2_4_0 =3D { =20 static const struct qcom_pcie_cfg cfg_2_7_0 =3D { .ops =3D &ops_2_7_0, + .has_ext_parf_regs =3D true, }; =20 static const struct qcom_pcie_cfg cfg_2_9_0 =3D { @@ -1633,6 +1691,7 @@ static const struct qcom_pcie_cfg cfg_2_9_0 =3D { static const struct qcom_pcie_cfg cfg_sc8280xp =3D { .ops =3D &ops_1_21_0, .no_l0s =3D true, + .has_ext_parf_regs =3D true, }; =20 static const struct qcom_pcie_cfg cfg_fw_managed =3D { @@ -1760,6 +1819,287 @@ static int qcom_pcie_set_max_opp(struct device *dev) return ret; } =20 +static int qcom_pcie_has_storage_ep_cb(struct pci_dev *pdev, void *data) +{ + bool *found =3D data; + + if (pdev->class >> 16 =3D=3D PCI_BASE_CLASS_STORAGE) { + *found =3D true; + return 1; + } + + return 0; +} + +static bool qcom_pcie_has_storage_ep(struct qcom_pcie *pcie) +{ + struct dw_pcie_rp *pp =3D &pcie->pci->pp; + bool found =3D false; + + pci_walk_bus(pp->bridge->bus, qcom_pcie_has_storage_ep_cb, &found); + + return found; +} + +/* + * qcom_pcie_dump_advance_col - advance @col and append a separator to @bu= f. + * + * @col tracks the current column within the active section and must be + * reset to 0 by the caller at the start of each new section; a newline is + * emitted every QCOM_PCIE_DUMP_REGS_PER_LINE entries to keep the dump + * compact in dmesg. + */ +static size_t qcom_pcie_dump_advance_col(char *buf, size_t buf_size, int *= col) +{ + *col +=3D 1; + + return scnprintf(buf, buf_size, + (*col % QCOM_PCIE_DUMP_REGS_PER_LINE) ? " " : "\n"); +} + +static size_t qcom_pcie_dump_reg_val(char *buf, size_t buf_size, int *col, + u32 offset, u32 val) +{ + size_t len; + + len =3D scnprintf(buf, buf_size, "0x%03x: 0x%08x", offset, val); + len +=3D qcom_pcie_dump_advance_col(buf + len, buf_size - len, col); + + return len; +} + +/* Same as qcom_pcie_dump_reg_val(), but tags the entry with a lane number + * since the RAS-DES SD-EQ status registers are read once per lane at a + * fixed offset, so the offset alone can't tell entries apart. + */ +static size_t qcom_pcie_dump_lane_reg_val(char *buf, size_t buf_size, int = *col, + int lane, u32 offset, u32 val) +{ + size_t len; + + len =3D scnprintf(buf, buf_size, "L%d/0x%03x: 0x%08x", lane, offset, val); + len +=3D qcom_pcie_dump_advance_col(buf + len, buf_size - len, col); + + return len; +} + +static size_t qcom_pcie_dump_reg_table(void __iomem *base, const u32 *regs, + int nregs, char *buf, size_t buf_size) +{ + size_t len =3D 0; + int col =3D 0; + int i; + + for (i =3D 0; i < nregs; i++) + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + regs[i], readl_relaxed(base + regs[i])); + + if (col % QCOM_PCIE_DUMP_REGS_PER_LINE) + len +=3D scnprintf(buf + len, buf_size - len, "\n"); + + return len; +} + +/* + * qcom_pcie_fill_dump_buf - fill @buf with key PCIe register values captu= red + * at Link Down time. + * + * Returns the number of bytes written into @buf. + */ +static size_t qcom_pcie_fill_dump_buf(struct qcom_pcie *pcie, char *buf, + size_t buf_size) +{ + struct dw_pcie *pci =3D pcie->pci; + u16 exp_cap, aer_cap, l1ss_cap, secpci_cap, pl16gt_cap, pl32gt_cap; + size_t len =3D 0; + int col =3D 0; + u32 val; + + len +=3D scnprintf(buf + len, buf_size - len, "DBI registers:\n"); + + exp_cap =3D dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); + if (exp_cap) { + val =3D dw_pcie_readl_dbi(pci, exp_cap + PCI_EXP_LNKCAP); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + exp_cap + PCI_EXP_LNKCAP, val); + + val =3D dw_pcie_readl_dbi(pci, exp_cap + PCI_EXP_LNKCTL); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + exp_cap + PCI_EXP_LNKCTL, val); + + val =3D dw_pcie_readl_dbi(pci, exp_cap + PCI_EXP_LNKCTL2); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + exp_cap + PCI_EXP_LNKCTL2, val); + } + + aer_cap =3D dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_ERR); + if (aer_cap) { + val =3D dw_pcie_readl_dbi(pci, aer_cap + PCI_ERR_UNCOR_STATUS); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + aer_cap + PCI_ERR_UNCOR_STATUS, val); + + val =3D dw_pcie_readl_dbi(pci, aer_cap + PCI_ERR_COR_STATUS); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + aer_cap + PCI_ERR_COR_STATUS, val); + } + + l1ss_cap =3D dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_L1SS); + if (l1ss_cap) { + val =3D dw_pcie_readl_dbi(pci, l1ss_cap + PCI_L1SS_CTL1); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + l1ss_cap + PCI_L1SS_CTL1, val); + } + + secpci_cap =3D dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_SECPCI); + if (secpci_cap) { + val =3D dw_pcie_readl_dbi(pci, secpci_cap + PCI_SECPCI_LE_CTRL); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + secpci_cap + PCI_SECPCI_LE_CTRL, val); + + val =3D dw_pcie_readl_dbi(pci, secpci_cap + PCI_SECPCI_LE_CTRL + 4); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + secpci_cap + PCI_SECPCI_LE_CTRL + 4, val); + } + + pl16gt_cap =3D dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_PL_16GT); + if (pl16gt_cap) { + val =3D dw_pcie_readl_dbi(pci, pl16gt_cap + PCI_PL_16GT_LE_CTRL); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + pl16gt_cap + PCI_PL_16GT_LE_CTRL, val); + + val =3D dw_pcie_readl_dbi(pci, pl16gt_cap + PCI_PL_16GT_STATUS); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + pl16gt_cap + PCI_PL_16GT_STATUS, val); + } + + pl32gt_cap =3D dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_PL_32GT); + if (pl32gt_cap) { + val =3D dw_pcie_readl_dbi(pci, pl32gt_cap + PCI_PL_32GT_LE_CTRL); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + pl32gt_cap + PCI_PL_32GT_LE_CTRL, val); + + val =3D dw_pcie_readl_dbi(pci, pl32gt_cap + PCI_PL_32GT_STATUS); + len +=3D qcom_pcie_dump_reg_val(buf + len, buf_size - len, &col, + pl32gt_cap + PCI_PL_32GT_STATUS, val); + } + + /* + * Gen5 (32 GT/s) local/remote pre/post cursor status, read through the + * SD-EQ registers inside the DWC RAS-DES vendor-specific extended + * capability. For each lane, write the lane selector into + * PCIE_RAS_DES_SD_EQ_CONTROL1 then read back + * PCIE_RAS_DES_SD_EQ_STATUS2/3, which carry the local/remote pre/post + * cursor values. + */ + if (pcie_get_link_speed(pci->max_link_speed) =3D=3D PCIE_SPEED_32_0GT) { + u16 rasdes_cap =3D dw_pcie_find_rasdes_capability(pci); + + if (rasdes_cap) { + int num_lanes =3D dw_pcie_link_get_max_link_width(pci); + int lane; + + for (lane =3D 0; lane < num_lanes; lane++) { + dw_pcie_writel_dbi(pci, + rasdes_cap + PCIE_RAS_DES_SD_EQ_CONTROL1, + lane & PCIE_RAS_DES_SD_EQ_CONTROL1_LANE_SEL); + + val =3D dw_pcie_readl_dbi(pci, + rasdes_cap + PCIE_RAS_DES_SD_EQ_STATUS2); + len +=3D qcom_pcie_dump_lane_reg_val(buf + len, buf_size - len, &col, + lane, + rasdes_cap + PCIE_RAS_DES_SD_EQ_STATUS2, + val); + + val =3D dw_pcie_readl_dbi(pci, + rasdes_cap + PCIE_RAS_DES_SD_EQ_STATUS3); + len +=3D qcom_pcie_dump_lane_reg_val(buf + len, buf_size - len, &col, + lane, + rasdes_cap + PCIE_RAS_DES_SD_EQ_STATUS3, + val); + } + } + } + + if (col % QCOM_PCIE_DUMP_REGS_PER_LINE) + len +=3D scnprintf(buf + len, buf_size - len, "\n"); + + len +=3D scnprintf(buf + len, buf_size - len, "\nPARF registers:\n"); + if (pcie->cfg->has_ext_parf_regs) + len +=3D qcom_pcie_dump_reg_table(pcie->parf, qcom_pcie_ext_parf_dump_re= gs, + ARRAY_SIZE(qcom_pcie_ext_parf_dump_regs), + buf + len, buf_size - len); + else + len +=3D qcom_pcie_dump_reg_table(pcie->parf, qcom_pcie_parf_dump_regs, + ARRAY_SIZE(qcom_pcie_parf_dump_regs), + buf + len, buf_size - len); + + if (!pcie->mhi) + return len; + + len +=3D scnprintf(buf + len, buf_size - len, "\nMHI registers:\n"); + len +=3D qcom_pcie_dump_reg_table(pcie->mhi, qcom_pcie_mhi_dump_regs, + ARRAY_SIZE(qcom_pcie_mhi_dump_regs), + buf + len, buf_size - len); + + return len; +} + +/* + * qcom_pcie_dump_regs - capture a PCIe register dump on Link Down. + * + * If a storage endpoint is present downstream, print the dump directly to + * dmesg via dev_err() so it is immediately visible even if userspace is n= ot + * available to read a devcoredump after a storage failure. Otherwise hand + * the buffer to the devcoredump framework so it is accessible under + * /sys/class/devcoredump/ for offline analysis. + */ +static void qcom_pcie_dump_regs(struct qcom_pcie *pcie) +{ + struct device *dev =3D pcie->pci->dev; + bool storage_ep =3D qcom_pcie_has_storage_ep(pcie); + char *buf, *line, *pos; + size_t len; + + buf =3D vmalloc(QCOM_PCIE_DUMP_BUF_SIZE); + if (!buf) + return; + + len =3D qcom_pcie_fill_dump_buf(pcie, buf, QCOM_PCIE_DUMP_BUF_SIZE); + + if (storage_ep) { + /* + * printk() truncates messages longer than LOG_LINE_MAX, so + * print the dump one line at a time instead of as a single + * dev_err() call. + */ + dev_err(dev, "PCIe Link Down register dump:\n"); + pos =3D buf; + while ((line =3D strsep(&pos, "\n"))) + dev_err(dev, "%s\n", line); + vfree(buf); + } else { + dev_coredumpv(dev, buf, len, GFP_KERNEL); + } +} + +static int qcom_pcie_regdump_show(struct seq_file *s, void *data) +{ + struct qcom_pcie *pcie =3D (struct qcom_pcie *)dev_get_drvdata(s->private= ); + char *buf; + size_t len; + + buf =3D vmalloc(QCOM_PCIE_DUMP_BUF_SIZE); + if (!buf) + return -ENOMEM; + + len =3D qcom_pcie_fill_dump_buf(pcie, buf, QCOM_PCIE_DUMP_BUF_SIZE); + seq_write(s, buf, len); + + vfree(buf); + + return 0; +} + /* * Qcom PCIe controllers only support one Root Port per controller instanc= e. So * this function ignores the 'pci_dev' associated with the Root Port and j= ust @@ -1862,8 +2202,11 @@ static void qcom_pcie_init_debugfs(struct qcom_pcie = *pcie) return; =20 pcie->debugfs =3D debugfs_create_dir(name, NULL); - debugfs_create_devm_seqfile(dev, "link_transition_count", pcie->debugfs, - qcom_pcie_link_transition_count); + if (pcie->mhi) + debugfs_create_devm_seqfile(dev, "link_transition_count", pcie->debugfs, + qcom_pcie_link_transition_count); + debugfs_create_devm_seqfile(dev, "regdump", pcie->debugfs, + qcom_pcie_regdump_show); } =20 static irqreturn_t qcom_pcie_global_irq_thread(int irq, void *data) @@ -1878,6 +2221,7 @@ static irqreturn_t qcom_pcie_global_irq_thread(int ir= q, void *data) =20 if (test_and_clear_bit(INT_ALL_LINK_DOWN, &status)) { dev_dbg(dev, "Received Link down event\n"); + qcom_pcie_dump_regs(pcie); for_each_pci_bridge(port, pp->bridge->bus) { if (pci_pcie_type(port) =3D=3D PCI_EXP_TYPE_ROOT_PORT) pci_host_handle_link_down(port); @@ -2316,8 +2660,7 @@ static int qcom_pcie_probe(struct platform_device *pd= ev) =20 qcom_pcie_icc_opp_update(pcie); =20 - if (pcie->mhi) - qcom_pcie_init_debugfs(pcie); + qcom_pcie_init_debugfs(pcie); =20 return 0; =20 diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h index facaa324bd86..0e82d89e747a 100644 --- a/include/uapi/linux/pci_regs.h +++ b/include/uapi/linux/pci_regs.h @@ -1176,12 +1176,14 @@ #define PCI_SECPCI_LE_CTRL 0x0c /* Lane Equalization Control Register */ =20 /* Physical Layer 16.0 GT/s */ +#define PCI_PL_16GT_STATUS 0x0c /* 16.0 GT/s Status Register */ #define PCI_PL_16GT_LE_CTRL 0x20 /* Lane Equalization Control Register */ #define PCI_PL_16GT_LE_CTRL_DSP_TX_PRESET_MASK 0x0000000F #define PCI_PL_16GT_LE_CTRL_USP_TX_PRESET_MASK 0x000000F0 #define PCI_PL_16GT_LE_CTRL_USP_TX_PRESET_SHIFT 4 =20 /* Physical Layer 32.0 GT/s */ +#define PCI_PL_32GT_STATUS 0x0c /* 32.0 GT/s Status Register */ #define PCI_PL_32GT_LE_CTRL 0x20 /* Lane Equalization Control Register */ =20 /* Physical Layer 64.0 GT/s */ --- base-commit: 657b57e3c02c1aeedb694c54870387d556b8840c change-id: 20260811-regdump-11719f75de0c Best regards, -- =20 Krishna Chaitanya Chundru