From nobody Sat Sep 26 01:55:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E69EB379971 for ; Sat, 5 Sep 2026 13:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616656; cv=none; b=l1h0CtEBk0+ygnIF4DDB5sh3oHyZX/hV1AlWbnzmgEnTbYt7CLqicgFrMsU0PDrvMZIUz0g5U7PAMJjX/i9yb5BI5GQXetjsnBe2g8er7X/SMRJksGBUSleenD9N5IfH3hadFViy63EnWoUQnfD77PxF0givUsHUb9goHTbhrPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788616656; c=relaxed/simple; bh=ikHgJDa2Qm1BlxjM4lp7UIe+qHcDX+O9Bj4MCXtoyEg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=AW9pW+yCx7fBNq8PlL8CMtE8w2THx4CHNW7WnHiVHlSdeDkq4xPd5zPvrFvYZA5vKRvXLdcm/nU3L6L2InDKt16EZ92M4HZ+0XW3pMjaaEjt0P3ITc5yv3PMzK5bm4cF5pW86RpZ3eTpv2hTMZ/kftBOWda5T99ppKGU3+LkL7k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SHpd8Mus; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WGR3C7bn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SHpd8Mus"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WGR3C7bn" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 685BVPNn3378167 for ; Sat, 5 Sep 2026 13:57:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=2LFZfCamiBEggn0dx6WAfW rq2n/TLdV6C1L7akXdRhs=; b=SHpd8MusjuT7TRRx4QSNxt7eCL4JLOrqmgIWbs rEtBf91my9cbDdLuQoP8maTv9c6LuuNqgteZeG4iPP/r3Bep9CkWVigFqXguXdM/ bsX1MU9Jqw55Y+yABfQkOlDQxIv1JSSYkQ8/siwRcTxA5+xeX8KFXlmk+alXKN1h ccQWbRvZSK5JetD9659k7Umv2chDlg5wcKmsIkupOaF03M5iDERJoKrTSrQkpdm/ lMtUS5PzDFKd/9QE5hKcJeUIAQWtf8q6GP/b1ST1hQzF7BDEDlyGkbuK9j+ad+L5 95SboIKyr5/sFHVSQl8wWQEJy7T3LX19M6xu1Xeu6kSAauQw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gg8sd1jf0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 05 Sep 2026 13:57:34 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2d9336581a2so31007195ad.3 for ; Sat, 05 Sep 2026 06:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788616653; x=1789221453; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=2LFZfCamiBEggn0dx6WAfWrq2n/TLdV6C1L7akXdRhs=; b=WGR3C7bnmGoPp/6zgz+UU6yoPkZXruPnywpFD+KY4kMYwcKgJFq/ynqgVmaeAOTSho JRGuxy+1Z3oiQHB8+xLEnGbKU3ylYQ+cBDLx7Udmiaf8apbe1LVhk/Iix0TLW71rsz+M bIKoeykwrOWIVH/rbYQq4UEVUlGUQyBqv8y02YRTJGypfBnQoV+HjsOqiDeiwwHvQ7CN EPD3d1aMJu4Mb/OTFThA1nM589sbyTNo4HQcXzvv4kQRZqNINZrNXgNyIw7ZV1/ixL/j 3Pwa5ckztVl2jVxW2Ssg/k/m4t51AuKxz/f1MYEeKbkFZ76/wF6+oDVfqIBZBQtWhuT3 A/mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788616653; x=1789221453; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=2LFZfCamiBEggn0dx6WAfWrq2n/TLdV6C1L7akXdRhs=; b=QxcGicgGsdFtaCmpVJJTW6FufORLvooeg2sWhheGf406gBzek4W4G5C/rr4M/FRk9+ yIU27ijnSkM0sGimUdCV8sBTykeoZyhACHLhCfr+YqvYOWM1RTlvKUd42Awd7lodmq+q xqEkWoPI9kdNk/Yv+JZYpilCR03VydLbOHDbKYpJ2rwJWxKkrd5RW4ioF/lShVBW+OAS 0FoYo7RuZQSDoYEEfcO5fFsVfO3E0VACQjamXHelkH0Aac6TD9QY6+MnYLU/SX+YbyXf eEBmv7O9rEzs8oFrC7seXpjfMeaFyN1qQI4cd0ahS91XHH046tUhnYrYbi+i0dnaZERl Ux5g== X-Forwarded-Encrypted: i=1; AKwUvBx7aUV+ZsyQnMWegf/HuKTlZSMQB5CvpEPMO+i2UXRCrv/WfDlbp9zjn/nYrab4j3obn/yyxGVdXcqfcQM=@vger.kernel.org X-Gm-Message-State: AFuF++nOGrEFplZVLS9vkbXxYiKoq8m9NeeL5dTb5Ovf1A11mgyNoEVX gDZCfjg4K2fuPkf1z1N78ue2CpF2KrghN+q5ia+mR9Wpgn3TBs/LOT2fHNFuc4KFLQfc3quC7/W em5qO1+LZR+aF1nyFqdgRTTjXY5DOm7cN0Zf87f3lVvc1ooTSZz8A7pGQroZ2q9b3KKA= X-Gm-Gg: AYBFou1CuHQSCA0vRazxSften3dIkq9y2dgDhH+/ZS/tWNBVkloMDIyOUoQvCe2Py1k 0KReNXZgoOr4k9apN42/gfQwkcdkmc9tCw08xcvPYh/e50EdEtuXCgPR1qHTQfEnUsUpjDLb1q2 llKSZfMKWBUEH51ScHszl6BbL9yyQts7Vs0cDx0u3wNhJgMrtVZWQSdDJozV1Ugl5W0qDm0EEJI G7RZ1eftckg7F9fffkts+hHWBn43o4DDnkUCj54pr+Xo6e+D8B8k/8iGfYTRxwK45DCXPgupWbY /Fx/CiI1t7KgRElBTNEVVo6z/90MhPU4cZVufPJxFJv+3iAuJdISXw4ZnWGj8zk0jT5BCWvsSjh ZTRz4W7GPlkYOOD72NLbekWgB9QXEoqb1Vg== X-Received: by 2002:a17:902:fdab:b0:2d9:599e:df95 with SMTP id d9443c01a7336-2db122edaa3mr190314605ad.3.1788616653378; Sat, 05 Sep 2026 06:57:33 -0700 (PDT) X-Received: by 2002:a17:902:fdab:b0:2d9:599e:df95 with SMTP id d9443c01a7336-2db122edaa3mr190314045ad.3.1788616652901; Sat, 05 Sep 2026 06:57:32 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339bdf26c5sm14374895eec.27.2026.09.05.06.57.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 06:57:32 -0700 (PDT) From: Vishnu Reddy Date: Sat, 05 Sep 2026 19:27:23 +0530 Subject: [PATCH v2] media: iris: Retain firmware confirmed video_format across GOP restarts Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260905-read_video_format_from_firmware-v2-1-21a606cdd288@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAMIfnGoC/yXNQQrCMBBA0auUWRsIoxb0KiJhkkx0hDQyaWuh9 O6Nunyb/1eorMIVrt0KyrNUKUMDHjoITxoebCQ2A1rs7cWejTJFN0vk4lLRTKNLWrJLovlDyoa D90dE6lM8Qau8lZMsv8Pt/ned/IvD+M3Ctu2UAQi1gwAAAA== X-Change-ID: 20260905-read_video_format_from_firmware-ecbb322a6fd4 To: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vikash Garodia Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788616649; l=4284; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=ikHgJDa2Qm1BlxjM4lp7UIe+qHcDX+O9Bj4MCXtoyEg=; b=b5j7Dk8CIc8X2niZYv3TvY98C7P+rVqYeL9ANkw8vr/uv3GL91RREHxn8PyBGswkYM3NBcWQI eeE7bgU+NQjDNp5M9Z2JjJ78bke9O4CEW2Kz2HN1Wyz3I4YVgxg9MhU X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-GUID: OUMJJeYeZENHPmmfxR38zrTVGkqDrNKA X-Proofpoint-ORIG-GUID: OUMJJeYeZENHPmmfxR38zrTVGkqDrNKA X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA1MDE1MiBTYWx0ZWRfXx+mW1IPDQS5E kKLjlbgYK0Z0ZG7SXEdDV1FIeU2AzXeYPaeNc6g3ZMatxJSmJM/7PxRhu/BmeIXS24a7UUz0tmb KcGFkGDAKJi43h0lgE8lWpUNFoKdEp0= X-Authority-Analysis: v=2.4 cv=dfmwG3Xe c=1 sm=1 tr=0 ts=6a9c1fce cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=UrH_bzIhgnSsKCIZztAA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA1MDE1MiBTYWx0ZWRfX6p1oggjt/b10 T29SS7hqrPfGS21sp4xyw0iwfOb8Z6l/Spmvl33vsppRrjQoqLW1IHaxSPHEYo1OK7ARNQYlkEx kyTHAJpCVjE7XfpQEjVpZuIqPaF4nmZ3NqGsD0w0K9+nLeS/YY3l7s6MEYn5v2nCKyQsxxsmpjq ExgOMMuCEKDJsMxXFgW8o2MZ95KvcCGEoUJJZCNcAyIpTn5tz+qE6Y4Cj+SL4wqnHe3SxYkaHOe QJ+LnpP4FEDxo8cQcmtXcsr2ragjvehgPMTTIDgBdWb6xrnuyjxkJ4gVuCJbUq+eXpy+BGsfJNn KRw2NngO9ypxYu6mLYKsR5ljLelp6V0zYhMnQjFPqjvWF49AOjpsgUGNZp8ljfIV2KaMkZv+Z/Z 7BiIgl/tXrE288ACjOkhzdGK3/jiThMYg0804j9R3yGPhW/cNhUDM9EI1Zume7diyLmNzJNAyjq D3n9gHfpnOBisPH0Z8g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-05_04,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609050152 During speed-based rewind, the client restarts the decoder queues once per group of pictures (GOP). This is because playing a GOP-based stream in reverse requires decoding each group forward first and then showing its frames in reverse order. Each restart makes the driver resend the colour info property on the bitstream port, which firmware always treats as a sign that the stream's properties may have changed. The driver never stored the video_format value that firmware had last confirmed, so it resent colour info with a fixed unspecified value instead of the real one, and the value firmware received kept differing from what it already had. On every restart during rewind, this looked to firmware like a real change on the bitstream port, so firmware sent a settings-change notification, and the driver treated it as a dynamic resolution change and paused the port. The client then removed its buffers and built new ones for a resolution that had not actually changed, stalling playback once per GOP. Store and send back the same video_format value firmware already confirmed so both sides stay in agreement across every restart, avoiding the false settings-change notification. Signed-off-by: Vishnu Reddy --- Changes in v2: - Updated the commit description (Konrad) - Link to v1: https://patch.msgid.link/20260901-read_video_format_from_firm= ware-v1-1-499edea4d200@oss.qualcomm.com --- drivers/media/platform/qcom/iris/iris_hfi_common.h | 1 + drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 3 ++- drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.h b/drivers/m= edia/platform/qcom/iris/iris_hfi_common.h index a27447eb2519..439197e9e199 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_common.h +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.h @@ -141,6 +141,7 @@ struct hfi_subscription_params { u32 fw_min_count; u32 pic_order_cnt; u32 color_info; + u32 video_format; u32 profile; u32 level; u32 tier; diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index 388a36ff2b07..a43a9d7687ad 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -358,7 +358,7 @@ static int iris_hfi_gen2_set_colorspace(struct iris_ins= t *inst, u32 plane) struct v4l2_pix_format_mplane *pixmp =3D &inst->fmt_src->fmt.pix_mp; u32 video_signal_type_present_flag =3D 0, color_info; u32 matrix_coeff =3D HFI_MATRIX_COEFF_RESERVED; - u32 video_format =3D UNSPECIFIED_COLOR_FORMAT; + u32 video_format =3D inst_hfi_gen2->src_subcr_params.video_format; u32 full_range =3D V4L2_QUANTIZATION_DEFAULT; u32 transfer_char =3D HFI_TRANSFER_RESERVED; u32 port =3D iris_hfi_gen2_get_port(inst, plane); @@ -806,6 +806,7 @@ static int iris_hfi_gen2_session_open(struct iris_inst = *inst) =20 inst_hfi_gen2->ipsc_properties_set =3D false; inst_hfi_gen2->opsc_properties_set =3D false; + inst_hfi_gen2->src_subcr_params.video_format =3D UNSPECIFIED_COLOR_FORMAT; =20 inst_hfi_gen2->packet =3D kzalloc(4096, GFP_KERNEL); if (!inst_hfi_gen2->packet) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/dr= ivers/media/platform/qcom/iris/iris_hfi_gen2_response.c index 8c2644c7f6e8..8b1ff253a560 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c @@ -581,6 +581,8 @@ static void iris_hfi_gen2_read_input_subcr_params(struc= t iris_inst *inst) full_range =3D (subsc_params.color_info & 0x2000000) >> 25; video_signal_type_present_flag =3D (subsc_params.color_info & 0x20000000) >> 29; + inst_hfi_gen2->src_subcr_params.video_format =3D + (subsc_params.color_info & 0x1C000000) >> 26; =20 pixmp_op->colorspace =3D V4L2_COLORSPACE_DEFAULT; pixmp_op->xfer_func =3D V4L2_XFER_FUNC_DEFAULT; --- base-commit: 9d80aa4617b32f5054c5aa471d06b66704854935 change-id: 20260905-read_video_format_from_firmware-ecbb322a6fd4 Best regards, -- =20 Vishnu Reddy