From nobody Sat Sep 26 04:37:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1655C33F5B3; Fri, 4 Sep 2026 13:13:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527599; cv=fail; b=RGbB3LhcvcZXnO2+9TPLEjZi03K3vZju4HrLKxffetzkCHBqB+zFB9vu9r4lCgTx5Ls5VARIoh0ovNsV8gu2ig2ZIiYSD5n9gjle6xM0iHTylPbyRtk8cyMESbXgXpPNY8f6GniXYoPctLwmEDlgvOLwZjesQ1aSxLlCpx+z278= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527599; c=relaxed/simple; bh=GDn6C24jQP/nYwTqVRg5BwRDzzRAK7MhPAq6yGPJ2yo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=o3OQfii5UshM3XzS8BLK/L8VfInEiwGhsm5cqvfyX/YlqBZpUDq9WDSnlkD7PQ8uUs48GKuyRO6O2gHkFSxtXg2W777271C/F5heVgEyzvtMqd2oQWGqvVypzDSlTjl9mHltgtrCIoirfVf8vfSK++Jz7z1oXJ1F2zsLIg9ooDo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=SLw6rmHJ; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=A8S2ZOa6; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="SLw6rmHJ"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="A8S2ZOa6" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 684AHELu3456761; Fri, 4 Sep 2026 08:13:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=sbXxU+1wdiI2yQMPe0FuJNV+bhlJlCPVgH3GrkZHY 84=; b=SLw6rmHJy7p4BNNewwyDNhzfizeHJ6thRjGiz6CoQbxYv/f0lT9XCy8pY eUYsYz/WhdfQom5atSkso8Z5GMdjMXvgl/p4MMNUXcC9peLAVIxkGOOkSALQl4P7 14EvxcygDoCAVEOxv8sxi2xThI3Ps39q3a+1hBaAAVLtjDAGVvJ/9C09eLnw5qEm jVJ74eHiMAcsyZs6bNq3OSozIcTrUUilRzJMvde8w+jnzquDFgXnnajbXMWTQ86+ piFSruH0qRI1Y5ny7DryMoebCUd7Gu0k4FLDQJlZS/L5+BhoG6LB8OKK9Ux5dMvJ K0nnNcq1L1PwcGJCXr/uPr+sovfxA== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11013071.outbound.protection.outlook.com [40.107.201.71]) by m0380145.ppops.net (PPS) with ESMTPS id 4gfk4xv399-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 04 Sep 2026 08:13:05 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=POkG3DTNS7urWZnCK/U4Jg9bJp4jFNAfohbuk2RvIbnnt5W/fNmkY4tRZ6Mgnc7pLCC4et3S6ygmx/nStxqQ7LIL3HP2myIZeJFwZ5SzA1LUC/T3Ykx+PUOK8jpL7Blw262E4n4Ui2vTz4/XmVUp4IYbHLSp1N9MVdAf0z7irLEOQn9SrmSSH+6z39ReeGRp4F+KO3Vt5BLwDgWJSFoMCi1S+uum76Vc1C+f8bZjXMo39K+OZm7YntSoLZ1n+l46eAV0z3YaQP1+pEBYzxMFe1L7HPPLGixcky1nQ34I53FWvn6NSHqAXN261Mj2X0chDZFpcBvYKeSjzGuHRZEsTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sbXxU+1wdiI2yQMPe0FuJNV+bhlJlCPVgH3GrkZHY84=; b=fK/37kHR47TdqeVNKD00h1cAC43Kb1euNLZS3R0i4dJ8vSYTm+gN0AywJ6B1cSL7hTo+BwJatXLyxvH4wbPljdJrxg3O9dcLFjRwqUtwUGjbawGsoN8eG2qNFLLBaOQNpR950YmHNZQqQN+NRtKwstYgSOXRb39AFEVb/NqcJ+T/YHLuHnFs+0v9zofbGrv5bF4mOq6Zvrvpt/CjH730r0iAlpuFkSkeMgtMtRC3BAo+dH5bT2uOHDcIskywRh215mgsTSWN6tlJzEZK9C+81lCjhVmk3TcY05U3INuUPrZPNXEgEnAJ9XZz+LBrwlpo5tH1URCHjeRbw/wTby8V9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sbXxU+1wdiI2yQMPe0FuJNV+bhlJlCPVgH3GrkZHY84=; b=A8S2ZOa654MStDItZikVczcj14Lb5xpiqmSIhFeZFzi3IVJYgfCX1ASbSMqXV2LnW9SqVcsDAqvRLGck/gKwWWmeX3XOJHo1331Pp2WYq/JJl1xdAQhBoZ0rGq1BrqsVJF3+fZ3nprN4bcYJF+PoTEGuZ/KeurA0iofQITu90Xk= Received: from DM6PR02CA0155.namprd02.prod.outlook.com (2603:10b6:5:332::22) by IA1PR10MB6268.namprd10.prod.outlook.com (2603:10b6:208:3a0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.4; Fri, 4 Sep 2026 13:12:59 +0000 Received: from DS2PEPF00003446.namprd04.prod.outlook.com (2603:10b6:5:332:cafe::41) by DM6PR02CA0155.outlook.office365.com (2603:10b6:5:332::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.13 via Frontend Transport; Fri, 4 Sep 2026 13:12:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by DS2PEPF00003446.mail.protection.outlook.com (10.167.17.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 4 Sep 2026 13:12:59 +0000 Received: from DLEE211.ent.ti.com (157.170.170.113) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:53 -0500 Received: from DLEE210.ent.ti.com (157.170.170.112) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:53 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 4 Sep 2026 08:12:53 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.36.126]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 684DCq52371029; Fri, 4 Sep 2026 08:12:53 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH 1/8] i2c: omap: Drop bit shift for I2C register addresses Date: Fri, 4 Sep 2026 08:12:45 -0500 Message-ID: <20260904131252.2126353-2-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260904131252.2126353-1-afd@ti.com> References: <20260904131252.2126353-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003446:EE_|IA1PR10MB6268:EE_ X-MS-Office365-Filtering-Correlation-Id: 19f350b7-e63a-414e-3d4d-08df0a863e44 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|1800799024|82310400026|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: i4xZgCkD2gVK8jzwTR1DKDACEj6uG8uyXRllzk0Ue8I2V/ckOyDvurTjJw/74R6cmWvQzS10V67NOkDC+kMcS0rdZY/Ygn6+2dCNgaFLC76vyKEJqhCFSzNRLWi94Jg2iby1onUKKGXPeASL1FE09oCl70ZiQ3aCVePeS2FttZj0bYf8if+l1cv2Jiq07Ow4pAI1CoZ02Z4Xm9UaPNq55SpiOdJcAW+FaiiGOVPv+G0OE5CAv885s4+DaZ63hIs6bMAofP3qzzbu38gd8uXzjbNlX66dfmlpsy9OmPckrodUGL1NW383uESrbTPC41EcN/XXQpqocxCUojCQpf1D45zTee/Mhby9uSn81ZOD64nrdgG4P+NXA9sZ+SLLxUp78tBaUUah7XW5apsGtytl1cubSUKp167euaeSRNWlfDuNZA8KrkrlUoY/oRwuQg5Xhn27Y/n1ZVcJ3DlrvTu/L54DdxbZ1+rmtT2n0oO9MWXcjUZzh9tZf+2BP4AsfRijkbZhliDb8KM3FUWG3/g6EG/+YWkVGESRAXaXMEj/oxpu9NTapbCrQe5pgEANvsA4TIAu+qi5E0JU4xCYJVAu4saTvQeSUkA7pZYYQ+PO2GVcbieVoY3Jav4dQtv9kxuSJfvonwRrlhkU42SjpABuy9gScZ86SNmrwdGy7AICO4+hvYU45B8YEH1rhj3Jpqk45ucbyJPq14+p3FEy8/7ecQ== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(1800799024)(82310400026)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 14xC5m3p8L7L88yvxJSZwKm6BaBxE5K1zw9tU88KYsyTUg2Wa9CnbuUqenF9lowi6Cs7lCVkJZDerhU4/vpXrbBus/4rrHrO+K7fviQs/v8s1l1KIGexO3Qnq46LFznjOaw2NKtiSggKbeEaPjbQfS3aCPr3yGmX6q/1KeWpBJ9nPOMeQKmogXfH0GWYar5Ez/9Bvw2k1g3GoJCy2lwxyoxcDkYBhldasIA07/EQK5GljGvH8N99Mhn7NH/JRNtMJlsPqHnlFKImidowWE+5Jw0ZXsJJSHIg4Q0kz5NWLtB6BpZ14mcFHQ+ytupawavQS81L2QV9faPjbgdwijnQ1W/RrY9A+BlAObDEIdhw7YEFf8NfbYMlPEZ3QNTgjhPsQftafHP5n9l7BZS9u8xWXlpQYZK6pdAspcup1gyxiFw1DqH8XMQPNE4fCEvnYP/0 X-Exchange-RoutingPolicyChecked: Ui3p6IprTgM+R5InbsFZhzPQpej4Hcxg05Bgr+RYcG327ias4Q95RD4uGbzXnKLjg0rNF3pGd4hrL0ngTBeAZmTh6gIzpz6LV1oe/5lPq5q3CiKUpJUlikx1Jinri/i3bY9KQN0HuabqZ0D8HwYhsudUaggONJXRvCC++MQ5M0Cg0M21oKcPNHrf0HuIBkoX9+kNOCM7gx+zefZRveE15WVeW5I4JCgKyUutz50dnhJK4WUBqb5w4zVwcZOHTRKnxYD/KMa3qq6zx6/hlN1BZCTbpf4ADK4RGFUYiG3XgcQ4Difb9d4MANCKK1Z0nVizqyHlSMndgZ2S+/Ti+aq0CQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 13:12:59.5582 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19f350b7-e63a-414e-3d4d-08df0a863e44 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003446.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6268 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfXz3ME5cwcY3dL ekvoUXvOYCxiO4oDWWj+KzNbaC6eDtDFeC5Sg8V/NCn1n2AGivkEh/GBvKeYiIRtk2mFSCYSEZl DRLF04s+4HQpfABrcTSSb/nDgVCdP+Y= X-Authority-Analysis: v=2.4 cv=TKd1jVla c=1 sm=1 tr=0 ts=6a9ac3e2 cx=c_pps a=eHfeAi0ej4loD7KcX6Y+qw==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=0HO5tbt_YLp_22CWDAYA:9 X-Proofpoint-GUID: 13HWF4Nh1eHQJcSsA92wnnoIr2BE53zv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX+RzQUO+Qus3v W8yy3oWqCcHyxYORwZpM2xSC4ATYW25xdGX30iK55LVe2Mn24I3CmaS2Ta12uYiRSZpD2glT6HD x/F/dS4p2oEExjkptAytxNiaZ1FthVpHD0eaVGq0xK7rnhFQ0aGrajYbcmpxySL7mQP7f+bg75M 7gzQ1x7+Z3BHimR3y6aIiJoB1O/jFPF77EgjbwGKATP7+J8mXGudeC38p88xqh2xDy+OM1ouj4N C2ownnA+t67u4jzBCk1bCOl5XUsRVxdUKKSkcUDWgpyhet38o1nTr/uIq/W4rAsW0K3knvAt0Bu U2/uGICm6gwvNh7/lmy2V7AOqO8lEXvc0r2oNLmxDbF+Tw4qoJgjAdrZqaj27xJLOW1mhUXcHAn ZfZcUw8VrUMbqqV/a1lt6QRGT9lhdYF4RpSjIOVImqtToUCkJnL/5NmTJofmxheyvsUpHEMfkr1 pEaQVMTob+c8sfd/0ZA== X-Proofpoint-ORIG-GUID: 13HWF4Nh1eHQJcSsA92wnnoIr2BE53zv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_03,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 clxscore=1011 phishscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040119 Content-Type: text/plain; charset="utf-8" No remaining board device uses a shift other than 2, and no DT supported platform ever did. We can drop this flag and use the pre-shifted register addresses. This simplifies the register access. Signed-off-by: Andrew Davis Reviewed-by: Andreas Kemnade --- arch/arm/mach-omap1/i2c.c | 4 --- drivers/i2c/busses/i2c-omap.c | 50 +++++++++++--------------- include/linux/platform_data/i2c-omap.h | 5 --- 3 files changed, 21 insertions(+), 38 deletions(-) diff --git a/arch/arm/mach-omap1/i2c.c b/arch/arm/mach-omap1/i2c.c index 94d3e7883e027..bc7828a858941 100644 --- a/arch/arm/mach-omap1/i2c.c +++ b/arch/arm/mach-omap1/i2c.c @@ -61,10 +61,6 @@ int __init omap_i2c_add_bus(struct omap_i2c_bus_platform= _data *pdata, OMAP_I2C_FLAG_16BIT_DATA_REG | OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK; =20 - /* how the cpu bus is wired up differs for 7xx only */ - - pdata->flags |=3D OMAP_I2C_FLAG_BUS_SHIFT_2; - pdev->dev.platform_data =3D pdata; =20 return platform_device_register(pdev); diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index f02d294db42a6..72f979eec7311 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -180,7 +180,6 @@ struct omap_i2c_dev { struct device *dev; void __iomem *base; /* virtual */ int irq; - int reg_shift; /* bit shift for I2C register addresses */ struct completion cmd_complete; struct resource *ioarea; u32 latency; /* maximum mpu wkup latency */ @@ -217,23 +216,23 @@ struct omap_i2c_dev { =20 static const u8 reg_map_ip_v1[] =3D { [OMAP_I2C_REV_REG] =3D 0x00, - [OMAP_I2C_IE_REG] =3D 0x01, - [OMAP_I2C_STAT_REG] =3D 0x02, - [OMAP_I2C_IV_REG] =3D 0x03, - [OMAP_I2C_WE_REG] =3D 0x03, - [OMAP_I2C_SYSS_REG] =3D 0x04, - [OMAP_I2C_BUF_REG] =3D 0x05, - [OMAP_I2C_CNT_REG] =3D 0x06, - [OMAP_I2C_DATA_REG] =3D 0x07, - [OMAP_I2C_SYSC_REG] =3D 0x08, - [OMAP_I2C_CON_REG] =3D 0x09, - [OMAP_I2C_OA_REG] =3D 0x0a, - [OMAP_I2C_SA_REG] =3D 0x0b, - [OMAP_I2C_PSC_REG] =3D 0x0c, - [OMAP_I2C_SCLL_REG] =3D 0x0d, - [OMAP_I2C_SCLH_REG] =3D 0x0e, - [OMAP_I2C_SYSTEST_REG] =3D 0x0f, - [OMAP_I2C_BUFSTAT_REG] =3D 0x10, + [OMAP_I2C_IE_REG] =3D 0x04, + [OMAP_I2C_STAT_REG] =3D 0x0c, + [OMAP_I2C_IV_REG] =3D 0x0c, + [OMAP_I2C_WE_REG] =3D 0x0c, + [OMAP_I2C_SYSS_REG] =3D 0x10, + [OMAP_I2C_BUF_REG] =3D 0x14, + [OMAP_I2C_CNT_REG] =3D 0x18, + [OMAP_I2C_DATA_REG] =3D 0x1c, + [OMAP_I2C_SYSC_REG] =3D 0x20, + [OMAP_I2C_CON_REG] =3D 0x24, + [OMAP_I2C_OA_REG] =3D 0x28, + [OMAP_I2C_SA_REG] =3D 0x2c, + [OMAP_I2C_PSC_REG] =3D 0x30, + [OMAP_I2C_SCLL_REG] =3D 0x34, + [OMAP_I2C_SCLH_REG] =3D 0x38, + [OMAP_I2C_SYSTEST_REG] =3D 0x3c, + [OMAP_I2C_BUFSTAT_REG] =3D 0x40, }; =20 static const u8 reg_map_ip_v2[] =3D { @@ -267,14 +266,12 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap); static inline void omap_i2c_write_reg(struct omap_i2c_dev *omap, int reg, u16 val) { - writew_relaxed(val, omap->base + - (omap->regs[reg] << omap->reg_shift)); + writew_relaxed(val, omap->base + omap->regs[reg]); } =20 static inline u16 omap_i2c_read_reg(struct omap_i2c_dev *omap, int reg) { - return readw_relaxed(omap->base + - (omap->regs[reg] << omap->reg_shift)); + return readw_relaxed(omap->base + omap->regs[reg]); } =20 static void __omap_i2c_init(struct omap_i2c_dev *omap) @@ -1214,19 +1211,16 @@ static struct omap_i2c_bus_platform_data omap2420_p= data =3D { .rev =3D OMAP_I2C_IP_VERSION_1, .flags =3D OMAP_I2C_FLAG_NO_FIFO | OMAP_I2C_FLAG_SIMPLE_CLOCK | - OMAP_I2C_FLAG_16BIT_DATA_REG | - OMAP_I2C_FLAG_BUS_SHIFT_2, + OMAP_I2C_FLAG_16BIT_DATA_REG, }; =20 static struct omap_i2c_bus_platform_data omap2430_pdata =3D { .rev =3D OMAP_I2C_IP_VERSION_1, - .flags =3D OMAP_I2C_FLAG_BUS_SHIFT_2 | - OMAP_I2C_FLAG_FORCE_19200_INT_CLK, + .flags =3D OMAP_I2C_FLAG_FORCE_19200_INT_CLK, }; =20 static struct omap_i2c_bus_platform_data omap3_pdata =3D { .rev =3D OMAP_I2C_IP_VERSION_1, - .flags =3D OMAP_I2C_FLAG_BUS_SHIFT_2, }; =20 static struct omap_i2c_bus_platform_data omap4_pdata =3D { @@ -1384,8 +1378,6 @@ omap_i2c_probe(struct platform_device *pdev) platform_set_drvdata(pdev, omap); init_completion(&omap->cmd_complete); =20 - omap->reg_shift =3D (omap->flags >> OMAP_I2C_FLAG_BUS_SHIFT__SHIFT) & 3; - pm_runtime_enable(omap->dev); pm_runtime_set_autosuspend_delay(omap->dev, OMAP_I2C_PM_TIMEOUT); pm_runtime_use_autosuspend(omap->dev); diff --git a/include/linux/platform_data/i2c-omap.h b/include/linux/platfor= m_data/i2c-omap.h index 3444265ee8ee7..fe6753cd17bf5 100644 --- a/include/linux/platform_data/i2c-omap.h +++ b/include/linux/platform_data/i2c-omap.h @@ -23,11 +23,6 @@ #define OMAP_I2C_FLAG_16BIT_DATA_REG BIT(2) #define OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK BIT(5) #define OMAP_I2C_FLAG_FORCE_19200_INT_CLK BIT(6) -/* how the CPU address bus must be translated for I2C unit access */ -#define OMAP_I2C_FLAG_BUS_SHIFT_NONE 0 -#define OMAP_I2C_FLAG_BUS_SHIFT_1 BIT(7) -#define OMAP_I2C_FLAG_BUS_SHIFT_2 BIT(8) -#define OMAP_I2C_FLAG_BUS_SHIFT__SHIFT 7 =20 struct omap_i2c_bus_platform_data { u32 clkrate; --=20 2.39.2 From nobody Sat Sep 26 04:37:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 239D234A78F; Fri, 4 Sep 2026 13:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527602; cv=fail; b=gquJ782waOZx1EMJmklFCDbNyRdQTI+CydGoDu3Yk+VysCfYFWmEw8TYJmB6eAfKrtydgyY7yd4aLazJ+Gq6iHJjMlBvTK97524VpYe/eLipJpRSUL6zBWKj9DUKcIJvsDe/mILUzQ5FjaQ6iOQ3Ym0RAyRpi0+JUen8Gord8u0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527602; c=relaxed/simple; bh=I97W1ZiOxMU9Clhfb5W0JgnaJjkcMSpf1tjrFbwACAQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hwO0LWP6sFKv+d7+g/4Tn/qkIaXmqEq4X4Djph6xlbe1H5Jf8akHxACvRG46ZU/EPpagYYE5ceucDLOpBA0FEzp9K+hnjtv7ideNYgo983oxiMZPF869Z1Fd9NeKrWsSUHA8pOV5GkR4BtMzPjoXXvHKqz1N/TC7eYPo3O5SLL4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=JfiHR81X; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=tHDap9ZG; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="JfiHR81X"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tHDap9ZG" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 684AHC2i3456741; Fri, 4 Sep 2026 08:13:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=lO16gPxRXl7jH/QfB5/83C5ycP63pTzI9gmCVlo6z 9Q=; b=JfiHR81XUH+tkV1Jy5lWptMTdd67HTt1NMwPAN4p8ta0FPCZfBdZC8R22 NHrnVAY0YuNkcCHGxI3UDrpuBv1VzWxTlHv7VQBHP+Ku9nnHu379jYlaraeIAePn PilKTz0d389jHwVJCFnmnZ9S3GQZP7okXfq9F6ZqytKDEkx5YTvqL5zuvRVlMvkn K/aDzXDaKvKIbF3Ey6om2SBcY6DWdv27WjEx4qmoz8OybnBCgQCp9uFbC5CDavDp meLC2DCqnxLtD6X2USemL/6Qt4FHXCAYbfWW7c9DMZ/xawISGhrOC4HyxL1W5GjS 8QUJrpm4bj/x+G+WRsY7tif/On6vA== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11013016.outbound.protection.outlook.com [40.107.201.16]) by m0380145.ppops.net (PPS) with ESMTPS id 4gfk4xv39k-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 04 Sep 2026 08:13:06 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ObNCSPEMK4VJ/AGfeCghK9kCqKqKe2kVXkVTSG5QtX6jEAFLmPBdspxqvPfT31zWWgEehfO1PRu0S332gwQ+5K69Wc//HyXeC/nkPy4RU5agLJZqcY7Z4k4QysedvXFOcxcdZt8H42kHbZdIgraSNrX+zPl2vjrIiN2U3RNNn0F9jkGH/ql7saFgwkrgmrcHB1hso9dUiWFtt3nb5OgbqgDhEgJzAMZQWsfeoXTGcO0YoLbckcpWBD/6+e7Za+u/h+HSN6E+aGk6y2+3/wpSleEBFvFeHK8LZ/rE+L+3sz1vPgIa21ThVVWmeZitAeHu5rEutISoFJHBuAa41tQa5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lO16gPxRXl7jH/QfB5/83C5ycP63pTzI9gmCVlo6z9Q=; b=gO2C/RsreFfKqdqCT9lK03LrTXWPDGoYQyJx3LoH0pmgcGhHbduDxWWot+S/diKu5dpuQm96UqpIubvJ5PBdLQSdKjGWPQYYhAweIOL4vN4v21zA1sXKe19XSx7KBS2ajjMhK3jXQNteNWaIqdzxMj5eKEnaj987kvasUXfCMghS8rS6Oh18DGfhRzTo+UuM18e7jjuaFyzHjVs3JvE8TsIEF+IxX7odonwvsvPU213weB1duX2T4c2QuNjVopSkKLpohbrWgJrb4Y5e7KPOltpggtv1qXGl4tnjVcsv977lBKpMW6S4xU+LJLEwoW+f5APoaFoSEwwwJpNblzPLCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lO16gPxRXl7jH/QfB5/83C5ycP63pTzI9gmCVlo6z9Q=; b=tHDap9ZGBr9/RIw8ORN6SX1yAQDveqjO8qMdly2uASXwenq2/oODKmW/QiFlflmjSLXRYZidKEOyB5q/aULkSMFbndJ+n+dc7RHNDpiRqhSgsPeFEfqYl04e7WMIZ9rVihxryXfWhjD/077NWoJf+/ty22P1zpKeOsWZdZwiUSU= Received: from DM6PR02CA0139.namprd02.prod.outlook.com (2603:10b6:5:332::6) by SN4PR10MB998047.namprd10.prod.outlook.com (2603:10b6:806:211::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.4; Fri, 4 Sep 2026 13:13:00 +0000 Received: from DS2PEPF00003446.namprd04.prod.outlook.com (2603:10b6:5:332:cafe::9d) by DM6PR02CA0139.outlook.office365.com (2603:10b6:5:332::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.13 via Frontend Transport; Fri, 4 Sep 2026 13:13:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by DS2PEPF00003446.mail.protection.outlook.com (10.167.17.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 4 Sep 2026 13:13:00 +0000 Received: from DLEE214.ent.ti.com (157.170.170.117) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:54 -0500 Received: from DLEE208.ent.ti.com (157.170.170.97) by DLEE214.ent.ti.com (157.170.170.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:53 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 4 Sep 2026 08:12:53 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.36.126]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 684DCq53371029; Fri, 4 Sep 2026 08:12:53 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH 2/8] i2c: omap: Remove unused is_rdr and is_xdr variables Date: Fri, 4 Sep 2026 08:12:46 -0500 Message-ID: <20260904131252.2126353-3-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260904131252.2126353-1-afd@ti.com> References: <20260904131252.2126353-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003446:EE_|SN4PR10MB998047:EE_ X-MS-Office365-Filtering-Correlation-Id: ebb08e27-2f27-4583-fea8-08df0a863eb6 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|36860700016|376014|1800799024|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: iDz4VOEz8GAdlEzXcrjpMSCtpwT/FjEbhHeyjEWD6ySPhgT3tLw0A4ijEer4oYyMXwEGuBmBqv9GqKbZ4Ha/ewS3eHYyK8qlvhfMTLkmaQuBEhOFhjjLVSAEOlZKNOrkGYiw6Ef9dwA310xW8yddMBoCuPtVIU3zrb0oXdRRFGtFOXuY+WVxPGItEhExULiO61OIPvrqQsVdwm/6VObwGLn/HBEV0KdLJAtJNh3HmdUOVdtuj2bRgNg05mGMfiI8EKLS8ZVq5x4AtovbXsnSpmFW5L/Id4K8xgSIhCOBzM8KX9yvROSEjHpbOrnfZwJg6lXesZJj/t8l0HxR2mR6BAlJjoqiuJCuzD0dZKsB6lDcU1B2HYglmIL7y3lAeaefWfHnQEkBcrzAK60xJ8cvXq57tYDZK+3q/fQLIaFjZJDz/znqI2z40VvitI0dd/GIvPfHmZqQb67j4eTH6qjFk4K3FUq2moL72j043Lrei8pHB2Rgndi8x+VkJ6LKMdU54SEGHwBhCLPjRrrO+3jSDus7vpK3SakOQVAEoWCzRpY+Y4xgARiW8LK9iqxcKAbEgiPiUjw1ilgJytPYjrpJZahfDhLTuv83yQ6CtdjYxonE5b5trwhjFstw90ySVh0GgYLjGdp1W+kUAjh+1x7PZF55hPSMrBZTtrXDvcqB21QR4AQhs4fthS+7EEnbdGQDQ28uUUqxmdGQ29mP8Gjq/A== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(36860700016)(376014)(1800799024)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +NCCaUggvDaoODafJn72Brkb+2lK2XhqD/Vgv41nZsgcqh9NElY8acRGzUXt5VJqSUcWrFUfpPZwOWA8NxCi+oD7MFxAXViYfNtX7Vy4ATyW7Vr31OsKnu0czhfGcYgrPO3Tf9UaTVdzjWBWS7e2w9NUM8QBE8u4LXAwHkxe4jkfLCRpVFzv4vT+TPN8vdBu/+942P23n5eDi2zlSELK6g4ZT9wN+zWqJn0/Epth8Col31tvAl2MXfewEtjf1g0z+Xtwj8TWLVKXpeB8nPwmj4OrxgBu7mV180Kew9Y+u2XMK15/1n2AbjfA+xZr/jvUQKmTpMn60AEiqHydupU/rzG4ASv30iD5v/e/pJOmwyARRusSuTGoPeXtRV1VIvfo/nFJam7u8LW9Bxiqyg2lQP4mXib7YRHa8oaqIC22mi86GTnj6npnzYENeniN/tnO X-Exchange-RoutingPolicyChecked: yiveW4XTHXLr479+Jb26h18KnLySH1X4KuBfSnYI87LmqefqFjWPE1Zs8P4i3MFXR5ewDC1mnx808qE3HnBjn3267JlvtKqPDWT2T+C9YqZLCl3VePz2HsGijoAjzR9UiHQLUeTzqX1mLOZrHPtcKDoFbOMoXvTVqvdWo780V4zh9oC/8pDfs7kQtVNQXlq/OWJvRH9XP2bAx6+xF2GRsRW1NspRoDMVwAf3FA7F29czXDqAXsuDbaEKiGQvKdFs0LSzphO6dXeU6Ygpz+kXQTyYIgIYjiOYsIKYY3bgSQH713ZvuA9X4yUCvN0GFLsM4WppRbv++nh4WHhK0yrc2g== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 13:13:00.2991 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ebb08e27-2f27-4583-fea8-08df0a863eb6 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003446.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB998047 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfXyAJ45xJd8yao sRUn2r+Q+dPa1u3e9SAszSQsUf8UIfsEB7RwvxsXEcy94w1NuhpCCNzY25GQLB8Qc6qFkv3NoTP HuB9y0Pc+EJ+Ul1BMNF+qlg8y8IP/u4= X-Authority-Analysis: v=2.4 cv=TKd1jVla c=1 sm=1 tr=0 ts=6a9ac3e2 cx=c_pps a=+8K2uRBjRfMG8L7NFMG7mA==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=eUdvuMK_en-A6lLaKTEA:9 X-Proofpoint-GUID: oFYRla1w7VqEUVuvGK5JBFec_099yZav X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfXxKuVR3Q3+AWG gh3WyfqkUhrZ7Pp2N9h2BJw1cPYJBviGjczu70h4sYusDKCJ2Y2nGOZjYi+A4pEIuxJx9oG644Y z/TraDssBked7rOKQArc0RFAL+85cptYEXDILDjB1cMaEH29M9H9AdMs+sT7heORPSeN2xJmXnc AG5gwe7o0ikio0lI8Af5HNf648D4h+PaJz0rGHg5TTFQ932+imEnGK1/4vcXwTozIj8QA2/c2L0 HaFJ52i5l3vA8nP5tCVBR5ESLUEselv9xdQZEz9W2g77nRlXf2mqdRpr7AFQJQeU1PgUyCfsHtD No7i6j/dFqXg5qT9KOrH9kYIq9ZlTkS2322EM/sG5qMUFZX9304rF+icYEhvPxr2rnF8qznTNfQ YoYHX3QtrNJdCbnnmaH6Q2+1dV3w5CWELCtWzhnXFabhyy52vQ5rPvQ8tFpPAdyDc1FhmbDCqY8 QlLGyjCHj4xNGcQnB4g== X-Proofpoint-ORIG-GUID: oFYRla1w7VqEUVuvGK5JBFec_099yZav X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_03,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 clxscore=1011 phishscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040119 Content-Type: text/plain; charset="utf-8" These are passed into omap_i2c_{receive,transmit}_data() but are never used, remove them. Signed-off-by: Andrew Davis Reviewed-by: Andreas Kemnade --- drivers/i2c/busses/i2c-omap.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 72f979eec7311..68b0a043f1e51 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -993,8 +993,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *omap) return 0; } =20 -static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes, - bool is_rdr) +static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes) { u16 w; =20 @@ -1014,8 +1013,7 @@ static void omap_i2c_receive_data(struct omap_i2c_dev= *omap, u8 num_bytes, } } =20 -static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes, - bool is_xdr) +static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes) { u16 w; =20 @@ -1119,7 +1117,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap) OMAP_I2C_BUFSTAT_REG) >> 8) & 0x3F; } =20 - omap_i2c_receive_data(omap, num_bytes, true); + omap_i2c_receive_data(omap, num_bytes); omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RDR); continue; } @@ -1130,7 +1128,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap) if (omap->threshold) num_bytes =3D omap->threshold; =20 - omap_i2c_receive_data(omap, num_bytes, false); + omap_i2c_receive_data(omap, num_bytes); omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RRDY); continue; } @@ -1142,7 +1140,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap) if (omap->fifo_size) num_bytes =3D omap->buf_len; =20 - ret =3D omap_i2c_transmit_data(omap, num_bytes, true); + ret =3D omap_i2c_transmit_data(omap, num_bytes); if (ret < 0) break; =20 @@ -1157,7 +1155,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *om= ap) if (omap->threshold) num_bytes =3D omap->threshold; =20 - ret =3D omap_i2c_transmit_data(omap, num_bytes, false); + ret =3D omap_i2c_transmit_data(omap, num_bytes); if (ret < 0) break; =20 --=20 2.39.2 From nobody Sat Sep 26 04:37:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD70C490BEF; Fri, 4 Sep 2026 13:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527634; cv=fail; b=V2peEvE1ZFDR5+MiK+5ueivLJO86huAmUDwFwNxSYWOhZSq1q9cXSJ/NlFRB6yFTlA65flw/cuVXqCDQc3fFOVhPw/XtidlYuW5t2QTZgz2IeYY6zx1pr/KBwRY8YwpxfwamFsAH369wtw7JECuJf3fysJhb2rJj79l6+ZTGmYk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527634; c=relaxed/simple; bh=D3vWuoujBubp5bT9ZHDQeih/pkyy+vORMKoxxQ99wHU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PVWuFFTLz9fp5jXLd2pgxkpDjHL+VIbsu9+gNX3s74AArTlvM/UMAEg/s2+xdseEYQ9SBHDCdKbrREjLE2UTi0hZtx3XsQFKJMwIrzpp6aACJVIlKJkacc+pCSvF5Ve2VhbZOQmO2GVESJl7yguGXrUl0iL1Ozq4dr89NtsRPrU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=iZxEtp72; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=tXHdJDSU; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="iZxEtp72"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tXHdJDSU" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 684AHJ5n1941784; Fri, 4 Sep 2026 08:13:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=wBYMysOBsG3Mpnztt/jp8rqcUrVbJ5vmIz1uOCkQQ 8k=; b=iZxEtp72ZxquPGYexV0Kn+/HHZYWLVqr8fChAwozSBn4Tfky4ludAlOAz drOlxMZU8TrJG0rnLat93T/yQUZTwlivbw5Q9bens/EgMqR3KAj2E5fhN9oLNOEo Ucp0E3+4IIUe3NKY7Hs/ibVzZ2avEBOuDEinJGKIAfQDxOxqipEIKlOFEJ8XkeOX 711V1R/83nzAmsPl3fwHch/cWhjUNdAgq+lCS2UE6A3+xh2m/8MDRsR96PMcTXcA lSKCF4S/+lsG5tQsdsn9fI13vMq38UHusZ9VVPZCEH14MTSJ160TkZeP/a+L3Sia R39CSwNDXH8mLlH72w0ayoox9Dk6A== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012062.outbound.protection.outlook.com [52.101.43.62]) by m0384305.ppops.net (PPS) with ESMTPS id 4gfrs326e1-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 04 Sep 2026 08:13:45 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fUOKLcNEcjK+AjgajFbKBimCPyJUIwQlamsv8enP6dN1+aO9zGhxEcLlHVHHZsu4uev+d3RyxKo+1dOrslveWbUq7J7Ow0xxZvZNQCb2zSYmLFiQAoAmKSfPa6uq0JZP3YBAGVCoKkj5gmb+pJmD6yzOamkQ83mrhmzpOavdZlqER9IR/ihVoEfdzVZq9FZbXL8b2+XxPeEkUpRmZ1M7ngRBcoMC+A37XF9oyWOKTcNV+gtGJky0IlFvy0qwfEmQ1s7j1nVfvQh7EnLT/kf0HXq1r+TEf6TTcDtpabFH5IZa0rXKoknX9NY4noM3R+hbWH0h/wyOpEfENgNLsFRAKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wBYMysOBsG3Mpnztt/jp8rqcUrVbJ5vmIz1uOCkQQ8k=; b=xXmstLmkrOKvBiBcwKzvudN2BFTga8CzPcfvLOqIJpDjUxdI830fcq/SILIGx87GD1odjrbNOyqt/FijCBaIWnbZXFdrgkHZxwKErKKqoJwlZLYCZFl4UnFoABDGbJThZO9XVTCtOjp6u7hc7dcDpAocI2MM6GzcLbyc+M/8u/WQ4BWDkT4OPhOaLvlTOtOtL+UfRcpkrgcIDlqHfQC9gLPE/qgcxhSXg5b9/qZ1foBn9qDpe6ipoCEcmAmTcc4KKqBwydjx11Bm+2mpOMBDFpHyUCaUby1UjHC5DVLOzZ/sCtAlttmtR+HfSAJ8JWTF4FqgdUFWvH398ULKvnEjCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBYMysOBsG3Mpnztt/jp8rqcUrVbJ5vmIz1uOCkQQ8k=; b=tXHdJDSUsSo98hYulpCOAj+yBBbW3JGGU18RmtmCaLAxcnBq+/4YHjfhQoJGYSYtObF4zFtVe6w+9Q/3vdyIebKRU+B1/Lsz1NpRzfaMOf8WGqBM9EPUL+Nc1FERkyL7I5AaVcb6018J7s/08nZrWgD9yrs2/juJINWScSrMucY= Received: from BN9PR03CA0105.namprd03.prod.outlook.com (2603:10b6:408:fd::20) by DM3PR10MB7971.namprd10.prod.outlook.com (2603:10b6:0:b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Fri, 4 Sep 2026 13:13:42 +0000 Received: from BL6PEPF00020E62.namprd04.prod.outlook.com (2603:10b6:408:fd:cafe::6) by BN9PR03CA0105.outlook.office365.com (2603:10b6:408:fd::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.12 via Frontend Transport; Fri, 4 Sep 2026 13:13:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by BL6PEPF00020E62.mail.protection.outlook.com (10.167.249.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 4 Sep 2026 13:13:40 +0000 Received: from DFLE201.ent.ti.com (10.64.6.59) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:54 -0500 Received: from DFLE214.ent.ti.com (10.64.6.72) by DFLE201.ent.ti.com (10.64.6.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:54 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE214.ent.ti.com (10.64.6.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 4 Sep 2026 08:12:54 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.36.126]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 684DCq54371029; Fri, 4 Sep 2026 08:12:53 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH 3/8] i2c: omap: Use devm_pm_runtime_enable() helper Date: Fri, 4 Sep 2026 08:12:47 -0500 Message-ID: <20260904131252.2126353-4-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260904131252.2126353-1-afd@ti.com> References: <20260904131252.2126353-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E62:EE_|DM3PR10MB7971:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a6d8da7-8e1b-4bc6-6cb1-08df0a8656a8 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|23010399003|376014|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: OMXtockAohKig/PmM+LzPw3h827LNhOb4MQrIKvYJfsUj4+phlppTxv0DXMkf0Dr24xQsMW0CkZPHNKqZlIHoPIGnosjFPemCsG+5GBuIjrIQCp/5TZENRJ/a7zxrLqQI2boBaL8ncr3DFQGv1WiHU6ycWvd5CYLLLAtSj6mY1goAT//A35x/201rIjKQ1PtcZRYt4NuPSekMdLh6f3Of50a2qNnY/juTFpWIrNS3HEB++cwHE/OfET/H8OqWDp1ub3gex96Ye9SgNW+Y1FFxXZg0nmE5vMoqP4LV3HPXEWueHduh/GEbMXKw4r1/T2ZRe9U2DikftljeNHWNj3PncikRrvjtn7MnosrLmUyT3OmCL6hJhTnIWJKQWVOKvFuYKsm3xlX0evkQmvu2cf0C4HgiwPwftrYX+AVILgBqXC2Cch+NHLooFTqIvv0ILBn4FKTr9s98RoLr/ojS5yxOPXVJUfYFW9/j/ydYcq2V5FC3RakjTKK1qhZv7m1vkf5cX07X+5V0qYdSBzmNnl/ERXBG519f6i7RsYII3qG2mzCgbo0DuXIQV4quu0JaxGW2cT6OjWWpB1ZD4eccT9aPcy4qO8yq0grzYx2Lxo8x/eeYbs+G0s7byZ8x3PjYsoYwYepcWzqQjQ+7p2Hh/N4KnEB12UYuasenSd15LpV6XaRfaGZclwAJQgC06NZ+7hoaEOV77wBWlyPvNNSJjHXWg== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(23010399003)(376014)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OoYpMWt24460MXnMQMY5dHGw+t0RVln0BLXIN21MIqI3WuIA4I7C9obt2H9DC0CIxBkRvuJsN6FIEtIKW1gUwUqwJFKTTcAQ1R64A8qdeJ3nDCQOUPlPxMlJ0/+Ae6AsslxD62s1EVYXIb2klJsPPjV5hBNEkISnYpQAJqMDLhLzgE1vKthcKcdz+7hWLQPmf83SU9+8Y8OVD1/SxXCBDxnvi1C9LODtADtz/HEhoAyMxB8B3H4ixSeFs/ES7dxYyQYPzt87cj76X92qTvGE3JA6VEoX3r9FrHvqkcJGiErH3cwg7oqJF2LTkc72hzKEa90FluWCQm6PYFw3A+M+ZpOuj51hStDayi9r+P2PdltPtE7N6JfnrO9J/xGH4FnqbG4ac3yD4C6nst9Bk5gpo99fJk08RBT+zzfvs0+4y7RCprPp75gpr3VFG4ECOqNO X-Exchange-RoutingPolicyChecked: ThjkPAWFolfui4eJaWKlFf3qQo6Ozf1Cla6IQcSkRaGO3q93SQzMYFUplY8YCKfiCx6VMM7SWQyArCOswkITw/Gx09QmUNiDnbU7/lnTV3VJUY2ek+070Y+LlYrV2OZUrq4Em4jqiHAoPRjBOxOTrgWsiK9WjXxsqhl/JigiQSmDbnbKyKE6n40XLPgAN7RTsUDLXmC8fKJm6LmrXCcba1jYtcyN6TcvDaB6A3DY2P2/9BOusglK6cXr84k04PCsI37lVFkdlNrQQtcLoUdtEG3p9lN2N8F+TUZzI1qfa510NiVYBSLwTG4+rE2gfujwJw4SKd3SYf8Q1e7l4qrW8A== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 13:13:40.4507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a6d8da7-8e1b-4bc6-6cb1-08df0a8656a8 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E62.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR10MB7971 X-Proofpoint-GUID: DnA599IKDjSM7LNx0UF_hwGZDNi6rz8N X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX4a9LxXqNFaln dyVtD/lmeZVpHnMlmh08/AShSFknugfSu166IHxQ/Ip5i4QezBWZUELHcDEPGp1OZhrJ1mulY28 c/lOxSO5Mx7CwJoHMf8/JtSvbWRv1x0= X-Authority-Analysis: v=2.4 cv=GshyPE1C c=1 sm=1 tr=0 ts=6a9ac409 cx=c_pps a=qMfGPIaByV4ZnHoTJsbowg==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=c0zHu0wbgw2R5NnQJfYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX8CV4E1NRrYxS jS0NlaX2LI/xaH/hh30y8GMb6ooOoWeP2Uu50cd2fhlhX8Rr54trp3d+xcfpaTfbdO5V/Jij0CN KavDH9GX+3Mwui8pLiwete6sAKBqFgANfenpsdUQmXOxoPLDrEN4Zs/heOrUagZci8yUPKh0JFC npvchc0yZKVCUDmu01jEGl2+otGtdUzPDQPsjm6jUGrjizmgqLrTl8JdCWW6wu6z2Q6jBtf0uTz 7E5pqtTLUPJ/Bpoz87OYdOrPuCjnbiQ1xvRf87rCVTJq4cMDW2/MKZiQ7ijQARhqF5n/BZumBCD 6uTnmt3qUWEfyqM1ALTlsa01PDrkJ087ZXnHFhf/JvQiBtgBf8NmsjJkh4FXC4RR3zclTuaDKqp vSYk44RXGXKw2D4n9dotj8cKHxJmN0s864jzEyrXX08+BgP/DVfAwWyyS98V6DyYHfvzTOq4x7Y Rs/TjOZcJjyukEYp2Xw== X-Proofpoint-ORIG-GUID: DnA599IKDjSM7LNx0UF_hwGZDNi6rz8N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_03,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 clxscore=1011 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040119 Content-Type: text/plain; charset="utf-8" Use device life-cycle managed runtime enable function to simplify probe and exit paths. It will call pm_runtime_dont_use_autosuspend() for us. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 68b0a043f1e51..e03519d939755 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1376,13 +1376,13 @@ omap_i2c_probe(struct platform_device *pdev) platform_set_drvdata(pdev, omap); init_completion(&omap->cmd_complete); =20 - pm_runtime_enable(omap->dev); + devm_pm_runtime_enable(omap->dev); pm_runtime_set_autosuspend_delay(omap->dev, OMAP_I2C_PM_TIMEOUT); pm_runtime_use_autosuspend(omap->dev); =20 r =3D pm_runtime_resume_and_get(omap->dev); if (r < 0) - goto err_disable_pm; + return r; =20 /* * Read the Rev hi bit-[15:14] ie scheme this is 1 indicates ver2. @@ -1496,9 +1496,6 @@ omap_i2c_probe(struct platform_device *pdev) omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0); err_put_pm: pm_runtime_put_sync(omap->dev); -err_disable_pm: - pm_runtime_dont_use_autosuspend(omap->dev); - pm_runtime_disable(&pdev->dev); =20 return r; } @@ -1519,9 +1516,7 @@ static void omap_i2c_remove(struct platform_device *p= dev) else omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0); =20 - pm_runtime_dont_use_autosuspend(&pdev->dev); pm_runtime_put_sync(&pdev->dev); - pm_runtime_disable(&pdev->dev); } =20 static int omap_i2c_runtime_suspend(struct device *dev) --=20 2.39.2 From nobody Sat Sep 26 04:37:00 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31210494A02; Fri, 4 Sep 2026 13:13:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527638; cv=fail; b=njphTbb8mdo0z6Yy5a9c7DXfDbP46lX51rQGKeNKmX5IoPShJZ8X0ORwxiNpNc6D4Qn3INZ8adkVHkjgQTsFBlDYeGwOT/InbKLjJc5RSIKUkl1DXPpMLQaaqNUBLxqL3Q86dXVtAJID42NTuz8TZzKgPEInqjBSQVFABF81PSM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527638; c=relaxed/simple; bh=zRdXX2S7cfFWaed8buWY1oJSQQ+1NNUG+ZARWvgYeJQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qlLsDNr7ZfgNs2GnaIQktlM9vb3/90XzpaFiGxv3/WFBVmnS1qruxoIP0h7ObqI0ofyqZWnexjf2qinX3ukA7HvwMRGR26/+nZKaMyZdjw2QS5wpq4lTCu8nWSOR5ZAhXpuM6yNyhHFfji+U1q4dcC4ADcWZK1EM9bdnYHAhpvc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=ADEHn3f4; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=lv3Q3RpB; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="ADEHn3f4"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="lv3Q3RpB" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 684AHcue3603256; Fri, 4 Sep 2026 08:13:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=K7POOkoENI7pBO6nO+goDRRn5n4Glh+Ta45eXMG4r N4=; b=ADEHn3f4Kgi1X7O9p2iC0M8fduKUTww9q1ttSfuZ9uejWt/t+yGFWoJGE WFhVkIF/Y45zJqkTLYgCQUn2zJsZBXjjRsJTO8V0WKgeDm0VDi+HGMgokuYOyazc 76Pht00AfzhTQDHTwnmwNUopW7yvZ9tNKhsVbFmMu+hS0qw6w9AqD2OjaBWOanuy T4L3f4TB4epj+FSwBpvsyjoQW2d9c0e42CxJ2m3pxqSmx3GWI/adYqhAZ7Vb8ppH Bga1N3hp9I6QIUc1EMORMGQJLLFhZFnzmw+1ZHDJrTqkhKs4z2B8e1x1EL15WT0y 8ibw1UE6lTOf+4UuAp+o+bnpraTDQ== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11011001.outbound.protection.outlook.com [52.101.52.1]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gfdfq6ev0-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 04 Sep 2026 08:13:46 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GLg9N7ocDiPutxjqM8rRyygyfq4XqV+0ppV0/+mjcX8sUNX31xQhXOBQfgvVmdQ2OpItk7NH0sYFqKdBQlBuu9dmf66ORVRioIu0zPLHG9xDFDj2r7EdhXdTWLrqmfa8YcLXwb0llCJrj8LKHOZJz99DFk077I/pyyHgJbcjoFF8cPHuLi527E+VsS4S7O04kBcr2yfqm/HfEeFSLRsh/tLtCUhdAjMkRpPO4poRWJ+5xYR0X4wS2lvYlJ5al8V5TXvI9/g9rXZ8ydpqu4OVbObyDuviZ/WI3SxJXmS9sjSSI6EJZKO7y3PRLGy/xCHsdjEQtWFb7Hq+J4JOsY2v6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K7POOkoENI7pBO6nO+goDRRn5n4Glh+Ta45eXMG4rN4=; b=DI/akh5juhNsaBsX82hi5tTDdoYuIhN6v99uWt87ZYPCg5QaOGaXwBs9EXyr+AVBbCgB4GH7fENK62c1Y/ZPZw/UZTzGzXtzimwBDiWzTEdzuFKGT+DNkEhlm5ljz5TaBiZDr8e2ulJmOfszacLjruQ+qXJlI9YkkkPoh4mX7lFhrqkDV6q81sXgABgzu+0kELBOx/jtYuvoacovKmWePxM+2FZnfX6+ICPodjGcaiq1olLHhPnD9EHTfR4MWVpWdfklbZ2b7ELpcGa1m0nCxa5U5vhg0cFtYs+921Omu8h80qHRtcJRQHrkDcB1S4FxQILZqiJZbbP6KSuTs+Sfsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K7POOkoENI7pBO6nO+goDRRn5n4Glh+Ta45eXMG4rN4=; b=lv3Q3RpBeRjGQcyiZKlfkhCjTM9sY3+0BE6cL9cyoqW+e5g9EIKVZjFavydg7O0YNn7oAAQcjCDV89VeXZ7Jo+LV1lp4RXRbHScDNRmBFmsMhVEVYHTOBrrWxGS3Ss8ceK0cbe32tL3F5vAB18SDQJC/sO/IOnZ1H+OP2W+tEU4= Received: from BN9PR03CA0745.namprd03.prod.outlook.com (2603:10b6:408:110::30) by DS0PR10MB6919.namprd10.prod.outlook.com (2603:10b6:8:11c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Fri, 4 Sep 2026 13:13:44 +0000 Received: from BN3PEPF0000B36D.namprd21.prod.outlook.com (2603:10b6:408:110:cafe::44) by BN9PR03CA0745.outlook.office365.com (2603:10b6:408:110::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.11 via Frontend Transport; Fri, 4 Sep 2026 13:13:43 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by BN3PEPF0000B36D.mail.protection.outlook.com (10.167.243.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.1 via Frontend Transport; Fri, 4 Sep 2026 13:13:42 +0000 Received: from DFLE206.ent.ti.com (10.64.6.64) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:54 -0500 Received: from DFLE206.ent.ti.com (10.64.6.64) by DFLE206.ent.ti.com (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:54 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE206.ent.ti.com (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 4 Sep 2026 08:12:54 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.36.126]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 684DCq55371029; Fri, 4 Sep 2026 08:12:54 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH 4/8] i2c: omap: Combine event flags register definitions Date: Fri, 4 Sep 2026 08:12:48 -0500 Message-ID: <20260904131252.2126353-5-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260904131252.2126353-1-afd@ti.com> References: <20260904131252.2126353-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36D:EE_|DS0PR10MB6919:EE_ X-MS-Office365-Filtering-Correlation-Id: e2ca11f3-d9c3-4768-a2a8-08df0a8657ba X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|82310400026|376014|1800799024|56012099006|10067099003|6133799003|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: FeEJWGXmx+HeW5SeKXzGRHd3ruKkKIpENoYRfIu3X5eyzSmB7ceMgUxc+fkuiPVlVM9Mlp6J4wO/c9pIfV2Q6AnFwZ29pJonzYR+ciAaRT0CKbtFa3P7fT7aYqcTDgVgfiofRGLNVrr596t193CDURDQlD3MRf/7/f2H6tKaDxkwplubbRsmcJuMgDDirOcD7Rbb3bRlDJQixw1zfqyJqleioepFoATngvhjPUWIV4ji62GjipBW6wqu6yXERgx10sYusN84DtN2o3Fudb4eAH1V3HXNh9nm3wNJyDSOQlt4bPROb28JKugmVDDSOfPeehu6OH7zUDh3rpNac0o1eC2y8IV9okJ/Dd+GrdeIRObeAtxXKU5/Oww/tm+sFmsCLxF4WKNBt+OINtoCCMpOW4tNj3nPmfKtZDyaOF9HHR/vYgL35vkjhNuosfFZ4lpVIqXVexaY+yGkSxqBqCcPZDz48bSwAy4RPOwNsrWy85srMCyveI7yMTM+Z8046WQ9E5LW1wm+uemxAkDSTB/MV9WcqKdrgXchJZnWngHy+KCQ+CHE87UNmbdCcfwPI773fuzlzVxXyheKYDlD7r4CAbYyFdpMJfLSe8wrOGr24uWNF+fkqv5C3PGESwfSWWLlJmMvKKA27/Tw5nGulibCQfGuBnIKzS3Wjhw0cZJbhJYVNKmyOiS+Qb6M6aQ2Lya729ZuTjOgAjOOYRjXnxKfvQ== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(82310400026)(376014)(1800799024)(56012099006)(10067099003)(6133799003)(3023799007)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 23WkC/IBvbXlaH5gpL9KZHiC0SCGKECx49c9QxYKpxoveRYkwj4Ei5JucOwl8lttg4tJj+XBmW/GIFmk9nS/kKbPihsh9Ox7Xfgre2pYAENabqH7lQB8RmUcZW2ttUvAAFlDDAq99zuEV1Wd+KzM8pvvUhGbWLjAOhlpBAhNX6EQjOWT/S67OdIGHf5Ty8Oow13EyzvKctssYHiTDA5IXnD79ln0Wgcnc7q1M1ZtEOY0ASHs1IcBjQAdZNS09pinrv1GDAPY6z/KJIdw9p9t1L2BUsXn8nsToaXz4OX/sWOJqmcLRNvo2DzdNg6ZvmLh9wsw7SGHjFx8lzS2GSOVszOEdSV/Kig7kAc8nfC0Aj98SjXX7/fH+lB1EZFMmEGSkxPsfin0VbbPNnAwfxC1+lHaeeAx3EQ/qAo45CRfT6VgeG1sA4tdCxtqdDAeMDYZ X-Exchange-RoutingPolicyChecked: 4PAqhSmy5hGQtuGmjDBAdPOc0QEKEkr7Nc6GU/eB203E2Wi1WLmLAbgO/WRSPvSP9XHZLBSJf/QKphSlVISO9glpX1Z1waT3aLBXlZflVVR5Buo6LT2gh36aQ8MfDcoMZ8j5LEMqCYHWmHSZ3barDmDID5PKzGIJWKxBlcCBYgmz80O1VfrdUKuthOo0rKKdzYvYQFSxMf/uXTN1MbsY1eCMvIZjRqfPvwKDlrfiYKRwTlukpYa84yHO08W13z9zaNF+yRSvQCLuMM6l1AycIoBKBXtOMOzrhb0ZgZAG0PStbaZfkRcrdJCqZTdR1nizsa8+4rjzKJGiXLx257gsjg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 13:13:42.2421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e2ca11f3-d9c3-4768-a2a8-08df0a8657ba X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36D.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6919 X-Proofpoint-GUID: 9GQdz-k_kUZwhIj2oN1vYHofV3k633Ts X-Authority-Analysis: v=2.4 cv=K8YS2SWI c=1 sm=1 tr=0 ts=6a9ac40a cx=c_pps a=v9d8l4VwGb/BX2RVr192eg==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=-VTgE4bae0sfXoRtrj0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX+IKSgxodIoO8 NPoBbgWJDDrkFevIsS+ZJiiomFqaMzLPBnS60HJ3gvXEA1eOfyGQf9dMTiMQkIzX0O+IOAHfGIK zG3+oi8AGB/CG4/mno+gRfjnfpr7F4o8/dr3WVGarjwQXKLnQSHFwAyMsSTINty90WV28XG42BA VnCB7FKpJR2WborzQukOxPkg9a3vzcVyBoY7vmDseIwLlb0VZByksODAArdcrA95mLzcNtGRUKt 5aEJMDqJNdgVZ2TUedu2QY/H7dm430+nZs84+RcLxPQM4oRpvghdSpi+yGzFA8LRkCIsQInHvTl 44CREHtt6zGZjpWqKJda+vXYJm7O1CgNIgJV0rtGbMvSBcYYVOAuWB5mFUaz0x2PEODOyUSH7m6 5lflSFTtbTUiS1/u19kjnf4OsR8+OCIlAqeLaThm2UjQqBWkAjPxyinK0LUOsucAI8bYXFUm+ok Bqh66PA5/acKAJrxRMQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX4Tci7ycM1DPw N72f4m7gT8ptBrikkeBbeH/JUvVp7vPs31/FKmhoDt9m1eOXBOeEySOqXiUj4R4SQ4xyldUA648 5FF2P9fQB/le36D2EdCgkp8XcxpWs8g= X-Proofpoint-ORIG-GUID: 9GQdz-k_kUZwhIj2oN1vYHofV3k633Ts X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_03,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 priorityscore=1501 clxscore=1011 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040119 Content-Type: text/plain; charset="utf-8" The position of the status, interrupt enable, and wakeup enable bits for each event are the same in each of their respective registers. We only need one set of offset definitions that can be shared. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 58 ++++++++++++++--------------------- 1 file changed, 23 insertions(+), 35 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index e03519d939755..cc65dc90770d1 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -78,16 +78,7 @@ enum { OMAP_I2C_IP_V2_IRQENABLE_CLR, }; =20 -/* I2C Interrupt Enable Register (OMAP_I2C_IE): */ -#define OMAP_I2C_IE_XDR (1 << 14) /* TX Buffer drain int enable */ -#define OMAP_I2C_IE_RDR (1 << 13) /* RX Buffer drain int enable */ -#define OMAP_I2C_IE_XRDY (1 << 4) /* TX data ready int enable */ -#define OMAP_I2C_IE_RRDY (1 << 3) /* RX data ready int enable */ -#define OMAP_I2C_IE_ARDY (1 << 2) /* Access ready int enable */ -#define OMAP_I2C_IE_NACK (1 << 1) /* No ack interrupt enable */ -#define OMAP_I2C_IE_AL (1 << 0) /* Arbitration lost int ena */ - -/* I2C Status Register (OMAP_I2C_STAT): */ +/* I2C Status bits (OMAP_I2C_IE, OMAP_I2C_STAT, OMAP_I2C_WE) */ #define OMAP_I2C_STAT_XDR (1 << 14) /* TX Buffer draining */ #define OMAP_I2C_STAT_RDR (1 << 13) /* RX Buffer draining */ #define OMAP_I2C_STAT_BB (1 << 12) /* Bus busy */ @@ -95,29 +86,13 @@ enum { #define OMAP_I2C_STAT_XUDF (1 << 10) /* Transmit underflow */ #define OMAP_I2C_STAT_AAS (1 << 9) /* Address as slave */ #define OMAP_I2C_STAT_BF (1 << 8) /* Bus Free */ +#define OMAP_I2C_STAT_STC (1 << 6) /* Start condition */ +#define OMAP_I2C_STAT_GC (1 << 5) /* General call */ #define OMAP_I2C_STAT_XRDY (1 << 4) /* Transmit data ready */ #define OMAP_I2C_STAT_RRDY (1 << 3) /* Receive data ready */ #define OMAP_I2C_STAT_ARDY (1 << 2) /* Register access ready */ -#define OMAP_I2C_STAT_NACK (1 << 1) /* No ack interrupt enable */ -#define OMAP_I2C_STAT_AL (1 << 0) /* Arbitration lost int ena */ - -/* I2C WE wakeup enable register */ -#define OMAP_I2C_WE_XDR_WE (1 << 14) /* TX drain wakup */ -#define OMAP_I2C_WE_RDR_WE (1 << 13) /* RX drain wakeup */ -#define OMAP_I2C_WE_AAS_WE (1 << 9) /* Address as slave wakeup*/ -#define OMAP_I2C_WE_BF_WE (1 << 8) /* Bus free wakeup */ -#define OMAP_I2C_WE_STC_WE (1 << 6) /* Start condition wakeup */ -#define OMAP_I2C_WE_GC_WE (1 << 5) /* General call wakeup */ -#define OMAP_I2C_WE_DRDY_WE (1 << 3) /* TX/RX data ready wakeup */ -#define OMAP_I2C_WE_ARDY_WE (1 << 2) /* Reg access ready wakeup */ -#define OMAP_I2C_WE_NACK_WE (1 << 1) /* No acknowledgment wakeup */ -#define OMAP_I2C_WE_AL_WE (1 << 0) /* Arbitration lost wakeup */ - -#define OMAP_I2C_WE_ALL (OMAP_I2C_WE_XDR_WE | OMAP_I2C_WE_RDR_WE | \ - OMAP_I2C_WE_AAS_WE | OMAP_I2C_WE_BF_WE | \ - OMAP_I2C_WE_STC_WE | OMAP_I2C_WE_GC_WE | \ - OMAP_I2C_WE_DRDY_WE | OMAP_I2C_WE_ARDY_WE | \ - OMAP_I2C_WE_NACK_WE | OMAP_I2C_WE_AL_WE) +#define OMAP_I2C_STAT_NACK (1 << 1) /* No ack */ +#define OMAP_I2C_STAT_AL (1 << 0) /* Arbitration lost */ =20 /* I2C Buffer Configuration Register (OMAP_I2C_BUF): */ #define OMAP_I2C_BUF_RDMA_EN (1 << 15) /* RX DMA channel enable */ @@ -360,7 +335,16 @@ static int omap_i2c_init(struct omap_i2c_dev *omap) * WFI instruction. * REVISIT: Some wkup sources might not be needed. */ - omap->westate =3D OMAP_I2C_WE_ALL; + omap->westate =3D (OMAP_I2C_STAT_XDR | + OMAP_I2C_STAT_RDR | + OMAP_I2C_STAT_AAS | + OMAP_I2C_STAT_BF | + OMAP_I2C_STAT_STC | + OMAP_I2C_STAT_GC | + OMAP_I2C_STAT_RRDY | + OMAP_I2C_STAT_ARDY | + OMAP_I2C_STAT_NACK | + OMAP_I2C_STAT_AL); } =20 if (omap->flags & OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK) { @@ -459,10 +443,14 @@ static int omap_i2c_init(struct omap_i2c_dev *omap) sclh =3D fclk_rate / (omap->speed * 2) - 7 + psc; } =20 - omap->iestate =3D (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY | - OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK | - OMAP_I2C_IE_AL) | ((omap->fifo_size) ? - (OMAP_I2C_IE_RDR | OMAP_I2C_IE_XDR) : 0); + omap->iestate =3D (OMAP_I2C_STAT_XRDY | + OMAP_I2C_STAT_RRDY | + OMAP_I2C_STAT_ARDY | + OMAP_I2C_STAT_NACK | + OMAP_I2C_STAT_AL); + + if (omap->fifo_size) + omap->iestate |=3D (OMAP_I2C_STAT_RDR | OMAP_I2C_STAT_XDR); =20 omap->pscstate =3D psc; omap->scllstate =3D scll; --=20 2.39.2 From nobody Sat Sep 26 04:37:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 888BC345EDA; Fri, 4 Sep 2026 13:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527600; cv=fail; b=hRTx9uHYLylzbmq9yWbR9HMBpoVBF5XYj003+v1l43He/B+5k9n80YEgRfcaQH1Z9HRP5HMiPPTpcG0bBkdJd6Pkctb3+4yudB5ikycNdA+lq/X65RL2MA1mIMuJR8BDf9ki3nYf0xMXWoKgdtZNJHAJbnoGObWHIe7YgSoxjG4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527600; c=relaxed/simple; bh=ZrCc1gcWNacZb+POfeYK99JH79xugcmevydTqlbdg4U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fsW81dbcGqCPGkzN+e7j3K9y83FdBMg7qmTleQGj+PR6oN4y6X+b4pTF1pYjjVZaTK/4qXr353BcPizfDF+GMQb+YjHbpvUjcAuPkAWV+B0+ug+o2222kCsudKQmz+BTa8aGpMWQv19mTfeG0Im6fkZ5Yt6CbIQqq4TakP6yBRs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=gkVzKUtG; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Od1OdKtr; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="gkVzKUtG"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Od1OdKtr" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 684AHCDD3456746; Fri, 4 Sep 2026 08:13:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=vPwoOeeVYXkOm95zJLw/3AUi6/evQS2lJN6KFGBIc HA=; b=gkVzKUtGWI1Vh7zPrOutOZfIzyqKrZFoaSmQwJbM+jqOsXbzQVUMdTjfd whw4gxQcfft+YSEFixPxuNFB4e7bMUTu+sVBDYV+OIayKr+s5Fq6ctY7iQA5lx+7 5ml6baxfbkGysk8/5AVOIdn6aJx0Xq32ZrbSZiLw8vwxAi/vYXIWXr/SD1wzPqBO MORgYVZKOeOe2UMLTm9NQjuxLwJDYRsM4NDsvwfotevMmWVZaPHLN2Uo6lYxNSeo 2VNFW8sbjUbga3vyTwnRfV0rMUTKikQzETZOM68ydmDPXfBH9UeehMpI50vZ9Ili bluLaLTKltZTJvuPj9CeumC2UXJmQ== Received: from bn8pr05cu002.outbound.protection.outlook.com (mail-eastus2azon11011068.outbound.protection.outlook.com [52.101.57.68]) by m0380145.ppops.net (PPS) with ESMTPS id 4gfk4xv3aj-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 04 Sep 2026 08:13:10 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jY8J6MUxpe5YtcGmtEdahDd8oIknZYbS2K3m56J4VXsKTPr3f3njpRgK4Yx6+Pal+S+PqX+5kNFbXq8Bf1gfy4kCD84PL4hX0QPCsEygzo5UEX6yV1w4ublU8K9x0+/QjOqW9LFYzhcJe+xjtum+iXFd/M40b+KPDeEFU6gvJDfEoL43Sk0I49h/G/NI1BrBls9+IXDh6jKSIiGUz4xEUDWlK5MgKg+gIYxhXEjMXjQv1aaxFnvOOarTqfzGtw+ZEW9RncMmrcu1CmiqTCD9Or9ps7Dz+EFJiJjw/qsuPuYYzu1Xs4ArOSJA7sACm0xAYqit1/TvWcDMmGwLlVE54w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vPwoOeeVYXkOm95zJLw/3AUi6/evQS2lJN6KFGBIcHA=; b=pQiH4PAPQIC9o7E0cckxxBLonh5T1ynFLGRq8Id/TSk/IWU6Ge7lCTW1sSzT6plzc5A3UQiF1WsotcGxe1zoO5jiZmGmZBCUR69lbVi1B7v/HO60ZvDinvHnbNkjjMNtOKf3IYzSMxAvgSXee649CUVeWR5Af91uW1P0kXExHJ6DYZ5F4OmIGEEa7jFa7MVSDFsgkdOJwfy7tteFFfr0LDOkWlUu5r93ioi04o9VPJWI3x4fMdsthKLW378zH7pVre2IUdrmlFvLLSmoLLgZQBqdPinEvt+dNujAV8cDGG7+cQgzHZfm/rxvwX8YhmMA+lW/tjYaYYOTxs/HcRcjKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vPwoOeeVYXkOm95zJLw/3AUi6/evQS2lJN6KFGBIcHA=; b=Od1OdKtrVa8IviKwmX8a8cp1LaF8jjKCFqrF45ZRmEbdiYe2ymV42gkVAlQkudhJrlioJRSP2CZeb+O/G4ue0ZeAg9rl3Q8OcW3aqYwPgWFSirHPPsr/gqnTBOC9Ew3kge3PAWfk7Gwsu+UMF/cuBcwQQl2rxgfaKOBgZanWV9Q= Received: from SJ0P220CA0008.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::17) by SJ0PR10MB5567.namprd10.prod.outlook.com (2603:10b6:a03:3dd::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.4; Fri, 4 Sep 2026 13:13:05 +0000 Received: from SJ1PEPF000037B5.namprd05.prod.outlook.com (2603:10b6:a03:41b:cafe::67) by SJ0P220CA0008.outlook.office365.com (2603:10b6:a03:41b::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.12 via Frontend Transport; Fri, 4 Sep 2026 13:13:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ1PEPF000037B5.mail.protection.outlook.com (10.167.244.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 4 Sep 2026 13:13:05 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:55 -0500 Received: from DLEE207.ent.ti.com (157.170.170.95) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:55 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 4 Sep 2026 08:12:55 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.36.126]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 684DCq56371029; Fri, 4 Sep 2026 08:12:54 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH 5/8] i2c: omap: Use bool for flag values Date: Fri, 4 Sep 2026 08:12:49 -0500 Message-ID: <20260904131252.2126353-6-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260904131252.2126353-1-afd@ti.com> References: <20260904131252.2126353-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037B5:EE_|SJ0PR10MB5567:EE_ X-MS-Office365-Filtering-Correlation-Id: fa94aa0c-8397-41f8-55d3-08df0a864202 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|1800799024|36860700016|376014|10067099003|22082099003|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: X1uN3QABlWzE8sgt1M6onQZ1Rl3XE1+5wj/D1PS5RCDucCbqZQyn2/M/0EkQDp4xSgL6e23+9sTXyx2KmmyqZGy+WdO96MNG+HLGiAuB+zWlTx3u1E8ZCf7bDvqxpHIpYtVPLmjpkE54R2jb1gemkNWFPIPnRyVhTfhFfKS09jlXeeDeASRcMDk4pVHERFna5eX4IqVi8ClZhkxuQ5U0kNV2eGx1z0z4w8H+ODIJppVJNu74RvMnWLlDht1M/NHg+TnVOHDuUcWP7KDOe0s4jpzk1aRgfs6gBfa8Uu+FnXBkp/2rTisLiylnNer+Cp1+SyA1tFVVlysz+8fCb+RVpB/ppISB3Vq7lz+PFZvq8bc5CP1+I4L/k3t0gLoyMGkpf3YTGfaFDrdqDiDTfV/Fc30AdZB28yUYo4g9cwJGZxZ/cRhWj2myR8AObcYeIw42kpF77CHUc6i8bf1BiGRWuk54r2DAfrz9I9V+/hApXPToIqRq8gchQVtYButBW3QjXRNlpc1Dkub52wUaJ631hvnBK/TjWLtHp4vSh6VhkbqunTWGyMhj4CUVs8quZR5Vpm8nEXdM1f+kc8wY37ICVvKojKcd8TmuxIqyaLNqiJL0qToi7kqYBEX9d7Rom7XGankAcz55HbVOCgtMkSrjt3FpXpSprx45eNQ2V0qMHL8hcTTz1ztZo6WNxhaxAdU5C0D6LuD1omzsWwCjie7S4g== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(1800799024)(36860700016)(376014)(10067099003)(22082099003)(56012099006)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 11MrpNE7BbSDc8egSYLchZKfsMe4ZQHOdjH1q11KTRY491VLa7TMFyOdyc0tBXh1WSBoNLhQVivjnHasG+AX1l7Uypwd4/O+zDB97UrrVd7JFiN7eB72W2uMpn59VPlrn84RYOgwVx4A+dMZ9rIU8fB4IzsfG8svys9IIjrKHxj8r08cFNlJN/3D0L/XhqETWr6PLDFfyL/Vp+A7Qfn2SHNr7e+MtXStKVBrcOlysKwdxYYmi1g4gKKK2A1kKUDDyKy7+yb3F7DCtv+vlT6iaGQVswCuFGHFY33OxgFmr8BeVIcJlS3yLeUbRFivOGQxA7YBz7YY/HJnNTErcVxlJ1ynAdWQgf9sZ7OVBmXwHPq8sZl63XqCqBWwiuF6SY0CRU9cKrONeXGNeL+brc5h55RDya8n4obVq6BPjdtUayr925omHQAU3Lu/VncK71Kn X-Exchange-RoutingPolicyChecked: 0Vc1PgIL8ZP99e4jHKt1DA54HaFFj0K4DlUm//FERFduGre5RGC12d3FR9ZxEOLFe2rhQl/WsdjmeV0D5fp4HqMaXQoXoP43OjBJmCYqn94NlcyK/3KE4tYRyDtcjZzhLFM4P6lCLJEis+SD9Ie9ES2Lj7xnOWZrNZ91gzyVlekNKjsASRH3OpK4RGWcn5YYUGESndCuOkGenxHQvkNTC4gaP11HrA4B/NqxyWApFo+y85819q/NQEvfZGBhbF9xaQ24L9/v1/ZsrftDQtIG/P74HfY6YcgF0mXsyM0zOkuDjrILq+RigSBUz+g5dU5CVkamfEmOXn4DcC6k+IJo+w== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 13:13:05.7848 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa94aa0c-8397-41f8-55d3-08df0a864202 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037B5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5567 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX1r/C3UR37Puv FZfpJYOlk5JAyg8PiL4U1QuSTR8iPmX1Az0AVx3hVE7D8F06lT7DZ4VdB+lZg0SsgtVUOZqwCPr QFtn0qa93fU5QnUWRg18hc5j2/Wy/jg= X-Authority-Analysis: v=2.4 cv=TKd1jVla c=1 sm=1 tr=0 ts=6a9ac3e6 cx=c_pps a=lgH93Z6fMBj3OFKE3BLqTA==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=vVWVvIjhg91t4kWa_skA:9 X-Proofpoint-GUID: 6eojDAFfG8lh-Mr1emy5Mn6VTHw0mjEM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX5NCqUZS2Vfv9 3aQcZZNvyCzlQUTKeBiOymnT0BAU2AqIj+vYFf3A2QWYr+tVnNsjioiyRTp04bJ83go0ROaQQfl nMqxiaTdE5FI4XBXnq26H0zmkGvas7dQFHguuq7ywguhEQBQpdnRAPm6oqPEFawdlJXGvSOFUFh X0zybMUlS2G8+3LbB+LZkCWX7c+pWsojqRhl34Z0/efSkSEgk59A8Lu//kJgb75an28o4N0VH7X XrMtm555tbijQYVMGnlfRROviagbYd49qXSp16RYeayWf3ljzxdpYgOJuic01fh/U8yMRNQ3fq1 VpN+Qtg+oVi+2FLEu88/p8NIaPJBcxhUcvWR7g4WDJM7GM81jttIZ7BnPGCbXizVE3dSG0MER7l HNhnCt5hMsMX7xzFWJ1QpPUNI1Am41Nv4EQHwDDbusHXfYr0ibqpwhVBaQ/XVcdGmHtraYEnqNq rztyKdCYPDCoeLWErbg== X-Proofpoint-ORIG-GUID: 6eojDAFfG8lh-Mr1emy5Mn6VTHw0mjEM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_03,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040119 Content-Type: text/plain; charset="utf-8" C bit fields are weird, use bool for single bit flags. The compiler will set these to an aligned size in the structs in either case. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index cc65dc90770d1..dc75780f76c96 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -174,11 +174,11 @@ struct omap_i2c_dev { * if set, should be trsh+1 */ u32 rev; - unsigned b_hw:1; /* bad h/w fixes */ - unsigned bb_valid:1; /* true when BB-bit reflects + bool b_hw; /* bad h/w fixes */ + bool bb_valid; /* true when BB-bit reflects * the I2C bus state */ - unsigned receiver:1; /* true when we're in receiver mode */ + bool receiver; /* true when we're in receiver mode */ u16 iestate; /* Saved interrupt register */ u16 pscstate; u16 scllstate; @@ -313,7 +313,7 @@ static int omap_i2c_reset(struct omap_i2c_dev *omap) =20 if (omap->rev > OMAP_I2C_REV_ON_3430_3530) { /* Schedule I2C-bus monitoring on the next transfer */ - omap->bb_valid =3D 0; + omap->bb_valid =3D false; } } =20 @@ -458,7 +458,7 @@ static int omap_i2c_init(struct omap_i2c_dev *omap) =20 if (omap->rev <=3D OMAP_I2C_REV_ON_3430_3530) { /* Not implemented */ - omap->bb_valid =3D 1; + omap->bb_valid =3D true; } =20 __omap_i2c_init(omap); @@ -531,7 +531,7 @@ static int omap_i2c_wait_for_bb_valid(struct omap_i2c_d= ev *omap) { unsigned long bus_free_timeout =3D 0; unsigned long timeout; - int bus_free =3D 0; + bool bus_free =3D false; u16 stat, systest; =20 if (omap->bb_valid) @@ -558,7 +558,7 @@ static int omap_i2c_wait_for_bb_valid(struct omap_i2c_d= ev *omap) if (!bus_free) { bus_free_timeout =3D jiffies + OMAP_I2C_BUS_FREE_TIMEOUT; - bus_free =3D 1; + bus_free =3D true; } =20 /* @@ -569,7 +569,7 @@ static int omap_i2c_wait_for_bb_valid(struct omap_i2c_d= ev *omap) if (time_after(jiffies, bus_free_timeout)) break; } else { - bus_free =3D 0; + bus_free =3D false; } =20 if (time_after(jiffies, timeout)) { @@ -585,7 +585,7 @@ static int omap_i2c_wait_for_bb_valid(struct omap_i2c_d= ev *omap) msleep(1); } =20 - omap->bb_valid =3D 1; + omap->bb_valid =3D true; return 0; } =20 @@ -620,7 +620,7 @@ static void omap_i2c_resize_fifo(struct omap_i2c_dev *o= map, u8 size, bool is_rx) omap_i2c_write_reg(omap, OMAP_I2C_BUF_REG, buf); =20 if (omap->rev < OMAP_I2C_REV_ON_3630) - omap->b_hw =3D 1; /* Enable hardware fixes */ + omap->b_hw =3D true; /* Enable hardware fixes */ =20 /* calculate wakeup latency constraint for MPU */ if (omap->set_mpu_wkup_lat !=3D NULL) @@ -644,7 +644,7 @@ static void omap_i2c_wait(struct omap_i2c_dev *omap) * Low level master read/write transaction. */ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, - struct i2c_msg *msg, int stop, bool polling) + struct i2c_msg *msg, bool stop, bool polling) { struct omap_i2c_dev *omap =3D i2c_get_adapdata(adap); unsigned long time_left; @@ -684,7 +684,7 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, w |=3D OMAP_I2C_CON_OPMODE_HS; =20 if (msg->flags & I2C_M_STOP) - stop =3D 1; + stop =3D true; if (msg->flags & I2C_M_TEN) w |=3D OMAP_I2C_CON_XA; if (!(msg->flags & I2C_M_RD)) @@ -1423,7 +1423,7 @@ omap_i2c_probe(struct platform_device *pdev) omap->fifo_size =3D (omap->fifo_size / 2); =20 if (omap->rev < OMAP_I2C_REV_ON_3630) - omap->b_hw =3D 1; /* Enable hardware fixes */ + omap->b_hw =3D true; /* Enable hardware fixes */ =20 /* calculate wakeup latency constraint for MPU */ if (omap->set_mpu_wkup_lat !=3D NULL) --=20 2.39.2 From nobody Sat Sep 26 04:37:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D83A833372A; Fri, 4 Sep 2026 13:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527639; cv=fail; b=Gz2GSBRKZHo9bYGikafjyRaDn/kEkzdDGY+PaBD7Z9sghvnl3Q5KZ9053XBwsVZqNfuJBk5Fgy7HLvZOSf0YMuxuhjePObdQxPCvPdYP9LqKDkReqPrTP/+pAYgI6QHZLDF4t88TA5sJlExODP3vZGDvdM9zCl5kgWdJXeYMtPg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527639; c=relaxed/simple; bh=p2e0L6BJd3eYaXNKxlq07c/fzPpFlLTGlrZWwVdbo1w=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NXz25BH9fHPqEkqIm5g9f7Em+3N55FMwa3UW7id3+plKX6DEDNc/JJw2D9ub5lloXyXIJtnEwiAQ/zfYID2Lxs0YUtRrArxG2GW8uOijvxjM/+/CTiwxWXvNzjzQ5gJkYURJZ8eHI5JHgEbxtWARhG46WarqL96ulGDYxqfnJaE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=akTu72ih; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ngc0YhP4; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="akTu72ih"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ngc0YhP4" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 684AHBNj3456727; Fri, 4 Sep 2026 08:13:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=3VEJ9S51As+8i4RFTYMsWN+iJA9+Vwrcx8aSerRNm 30=; b=akTu72ihFfWZqi8JwxAgCh7NSp4JEgMXO3B0lLUk0fPUp8pJU0B2UmQrF vPozZlzuJN1XDffBm2399U5XLxYM6sq4zDCt80j6pTU3I1lbMZJk716k8RXyr5oY Tx78dkXomQ5zPSrycz5XX/R1kXbtKvzLzyMD3AW137I43jT7aVp6Sm2mE60iyAqv 9JGoa0ovipJ9enGz3b5vpt3uF+CPEMmyXKHJ/t7Bi1b3h8vJLoelYICPZHO1qtME ps02ZEjYwE5mH4cnRRQSeYWzkqYqUbI3+gCbvWRkKmfWLYZJPkjNB8cKiXWKukT1 LFCR0V4cy+p/kdTpK0srdEo1l+XrQ== Received: from ph7pr06cu001.outbound.protection.outlook.com (mail-westus3azon11010058.outbound.protection.outlook.com [52.101.201.58]) by m0380145.ppops.net (PPS) with ESMTPS id 4gfk4xv3hw-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 04 Sep 2026 08:13:49 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UtzhRAa6EU81EAF6SrdfK3oauEh+mGtlSN0yPpxng93Ivf/K/JCCV6PBz0oUmT4Hpfa/R8P+giDr/CVn6EEnVuUOYdqNzDQtrnyOOf2fCHzg3ENt39H7zJ+RfzY+v18hpbExWhamfYdrJ4gJ4UhvtpRv7djLh29XYEBW6+28ElQijmbmWYcX/kbuHPDDyCb6umeVcmBURmkbUbUGyZcJaw3p3H6QsSM5LS/rqeUcPEXY2Rli53ZrnXI293dyU/iJyb/d4HAOeW371A4cJKBwFD48dsn8zWK5D5w5f71f+GxSNyyUhak0gfSAJwNfQ8lrmj0Fn0mvBVWB4kRt3oIWDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3VEJ9S51As+8i4RFTYMsWN+iJA9+Vwrcx8aSerRNm30=; b=yo4PLpF9a3LZEnN509hMU1STdrALi3drizmiUDrMbJnmCdszhaKE0wVE+lupy8Uimo4zhMlcmq3I4ITdG2bWQ8X0MoN1/w0mjM2v1L/hluXn6XNZl8dKHcqTM5JR/ZC5lX7PaMX0Tpb/OO6ei68FHXC74lMRps4yVKXaqGLOlzsCFUFCAWfYcA7Y7+0pdWcC/9njVuauM++VDhHHqg2WhDh4QshXJDm+5RlDUDOAD8xNC4AwZt6YqLOIqoOg0xTYA8fDSDgncSSTL2E1ZByTN8/n31IxJEjKC+pYUnMGmG0yc/YsahvAd1UUrEw0M9LN2umnIJPo/bsWj1ApigBVVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3VEJ9S51As+8i4RFTYMsWN+iJA9+Vwrcx8aSerRNm30=; b=ngc0YhP4UUZrlhfuSjfenaedG+NbM8wzbhuq2r7iRvRZ/aEeIbN8JDky9rlNwtlCd89ZvlE7ovnNhwnzz3SLuuf6PVDySM8Hgf5wOG9UgDp1QgJoGIVWuSuh4fOwqEwMID9LZcs/BzGAXLkQ1t2Lmey2Ca3JUIwHrHOmcODRfWM= Received: from BN9PR03CA0516.namprd03.prod.outlook.com (2603:10b6:408:131::11) by CY5PR10MB6046.namprd10.prod.outlook.com (2603:10b6:930:3d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Fri, 4 Sep 2026 13:13:45 +0000 Received: from BN3PEPF0000B370.namprd21.prod.outlook.com (2603:10b6:408:131:cafe::a7) by BN9PR03CA0516.outlook.office365.com (2603:10b6:408:131::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.13 via Frontend Transport; Fri, 4 Sep 2026 13:13:45 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by BN3PEPF0000B370.mail.protection.outlook.com (10.167.243.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.1 via Frontend Transport; Fri, 4 Sep 2026 13:13:44 +0000 Received: from DFLE209.ent.ti.com (10.64.6.67) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:55 -0500 Received: from DFLE208.ent.ti.com (10.64.6.66) by DFLE209.ent.ti.com (10.64.6.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:55 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 4 Sep 2026 08:12:55 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.36.126]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 684DCq57371029; Fri, 4 Sep 2026 08:12:55 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH 6/8] i2c: omap: Make reset bit name match register name Date: Fri, 4 Sep 2026 08:12:50 -0500 Message-ID: <20260904131252.2126353-7-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260904131252.2126353-1-afd@ti.com> References: <20260904131252.2126353-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B370:EE_|CY5PR10MB6046:EE_ X-MS-Office365-Filtering-Correlation-Id: ecc3437f-ce0e-4d6d-e89f-08df0a8658e0 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|23010399003|36860700016|18002099003|22082099003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: lMhnGkOV1WuzHwAIRdXufDFnInpTE14wzfdcv0BVXGaUVYzsofnoamSf4jafIMT1hOxxeul99UHvtTsM1RXDsnlEB522YsFCCPy7b4avba3qQUpkLgNFSQtV0VhKvfj6enLP0164WP/E3yyKbHrdpFzBWBjBPIvE8H+OO4DXnsupKaUsZLPyz7Rp41DgMiNwF95uUt592OYlaT6O5JsAbYYrtvuGT/2NoMoZw84/OQmLG5y9cBDvgSz4U6zCQQRNYpvb6cwJTP2KAYXyuvJa6bH8dthFa4giOCsQPZbGLkLR5kQO61a0imWy3a3r7RlRpU84CbJVqbd2B1vnUPbGhQxbneGrDETZSq2hFl+qPVTfn4IWfvoORe9XY3r3is7SZhXsc5PazXc1uwSV0vNkij+QwPVEN6VaCdcJ3QFvaTcS9tUYeGAUniAADHFn/crxHScIGgtGCVobeSKH1jTR9NJNYxiGi/LZOu/Lorv+NPIzmpaOJit2PAq/D4sl5wbZ3dqiZrCTmUbViGZtrApZm8KpFs3C328JPxbzYOXwnxT9SBIZO3bPNJGAwVqkaQ5d6ztpenM6xzcxzqQclttq7lOH441Er7BxOkij0OHx+btIRRn1prBrU60noa5Q1e8Uqtimp4UYD3/3N8NX0mYYSswAgyUioFLVO4bGzObckqqPWs9GN3Re/WNGqcIhH9XRuWlW5EqS0rcrYkz+gAOEBw== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(23010399003)(36860700016)(18002099003)(22082099003)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Wbh/6nlswSWgYCzMLnoL+57MmeizsIOrNafWHnofOwuaj9A12z+O6CqaknYRmWEBmZLGRI0CEyC4SVbIRWAyNMmsNXPLHy1SAtuDp8/CB+nVKK7Tn4Y0U3dWC9kvlzxo6yYzaU93K3blu+aU6m6u6bdbwpLxgrsxceCRdpS90in50IO3YVvFPEzsm6CVInuNsAckjuk0EreXgRlRbA82JzqodNV2GxoC9tnGPiX+oaInNKW62XeLjr+444qxxQ1sQtnCsBR5Fys2uUCNPbBg5iD13mbVq0DnTLdd+FCl3fX8GyLiaE20fmb+ws8j23t1lAe4bs+ALJ8mntiQPZUtIM6xeIo52xnUYcNf4W7KOInr3Q6A3nDf0g2/KCZlAAfDDdUPl9Huib1Jr6B76qh5ny8SrYFoDnnruaYNlpul78kcPUvPJuAFlPe0GO8Jrnig X-Exchange-RoutingPolicyChecked: bkmXDD3nyokybGup44XGuPvjYQdr0qfyi/pHNPYvwLFpj9M7coP7i0QoUvQ3toq7EEDpwwas7DvwCD+cHqspH2fWHZp1Q0LBnCMn5JDgbDQ0xsjAnv049XpKQ1es+EHw2FyWxA4Agg6y0Q3VtCvd5b3VDs2mrzfmtEcuJxmTgvecJIrdmQNTocFHOx5RDcOzS9lrNfurlMrqdi1e/pjeIJ1wnZ0y8U2yrs67NrLOUAgDz1VAJuPv7GbTRwb4mCgce5G8ox4NpkLARHRUxlh7ht749e+2879/HN/w0N9ajUX7rTjmhsMtRIBe2V2ruHMZpzPV3o1BTAcN243hlURH7Q== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 13:13:44.1670 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ecc3437f-ce0e-4d6d-e89f-08df0a8658e0 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6046 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX8kWMoJFrcALy tklS8N1jQEQVP0IDwhNTRuxnx5nck8VZfDa83/hdFJbXXq3rZfczhuToo+faYwHJ7Ela30rC2rb O37ZAB//Xy/A0dkW/qFfLZ16e8/Cii4= X-Authority-Analysis: v=2.4 cv=TKd1jVla c=1 sm=1 tr=0 ts=6a9ac40d cx=c_pps a=jKN40M1qUjEArv1iOeQWeA==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=jiVZLek5lCiKkj7Mo_QA:9 X-Proofpoint-GUID: gglpqda7xj8iSuEVCA_rNBg4JkIusllx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX/K2OnsTuGFVI uToDTQFJBULB0Ux3sOBumCmwjWja1kBrit42RNYLWPa/PCaQlq7KEVADo+ptyz4HXoTmic7ehtg lcZs/0AOvWxeSyHEwQwzY3xMhpFldZ+ZmTUOtwFqTMpK55i3EvSzglPWo0KppbGgVmbVhMOdhy1 moud5TIiCc9vYverd0mAq70+9gx4RaVNN2V2080HdmUHSB2pq2MTp8i4TKvB2dGN0MHi57aYdWR uFoy/4kteHiPlceMnzScyVm2cMhdMcB43jKAZAYQIL/RA71lSaZd8bYCfbjzeeqnBQLA8Q6UamB 8afbcUabaGPW5LdYdvfUdpaSsIhmdFrcT6DBhfD2SipmCKPI7UDaWHISa7B3KPWIH1STYUyU8mx SyjCmFdLMpiRX6pX30z2B9AeXG/GUG8dSGcC0rEuhwqDjrnEjPWQdvXjyXwQGyU/0jb+L0GaiPW 0NgJ/0vfbz4CfWNPmLg== X-Proofpoint-ORIG-GUID: gglpqda7xj8iSuEVCA_rNBg4JkIusllx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_03,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040119 Content-Type: text/plain; charset="utf-8" The bit definitions usually match the register name definition to make matching bits to registers more clear. Do this for the bits inside OMAP_I2C_SYSS_REG and OMAP_I2C_SYSC_REG registers. Remove unused bits. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index dc75780f76c96..a50cf195c28cf 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -133,17 +133,10 @@ enum { #define OMAP_I2C_SYSTEST_SDA_O (1 << 0) /* SDA line drive out */ =20 /* OCP_SYSSTATUS bit definitions */ -#define SYSS_RESETDONE_MASK (1 << 0) +#define OMAP_I2C_SYSS_RESETDONE (1 << 0) =20 /* OCP_SYSCONFIG bit definitions */ -#define SYSC_CLOCKACTIVITY_MASK (0x3 << 8) -#define SYSC_SIDLEMODE_MASK (0x3 << 3) -#define SYSC_ENAWAKEUP_MASK (1 << 2) -#define SYSC_SOFTRESET_MASK (1 << 1) -#define SYSC_AUTOIDLE_MASK (1 << 0) - -#define SYSC_IDLEMODE_SMART 0x2 -#define SYSC_CLOCKACTIVITY_FCLK 0x2 +#define OMAP_I2C_SYSC_SOFTRESET (1 << 1) =20 /* Errata definitions */ #define I2C_OMAP_ERRATA_I207 (1 << 0) @@ -293,13 +286,13 @@ static int omap_i2c_reset(struct omap_i2c_dev *omap) omap_i2c_read_reg(omap, OMAP_I2C_CON_REG) & ~(OMAP_I2C_CON_EN)); =20 - omap_i2c_write_reg(omap, OMAP_I2C_SYSC_REG, SYSC_SOFTRESET_MASK); + omap_i2c_write_reg(omap, OMAP_I2C_SYSC_REG, OMAP_I2C_SYSC_SOFTRESET); /* For some reason we need to set the EN bit before the * reset done bit gets set. */ timeout =3D jiffies + OMAP_I2C_TIMEOUT; omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN); while (!(omap_i2c_read_reg(omap, OMAP_I2C_SYSS_REG) & - SYSS_RESETDONE_MASK)) { + OMAP_I2C_SYSS_RESETDONE)) { if (time_after(jiffies, timeout)) { dev_warn(omap->dev, "timeout waiting " "for controller reset\n"); --=20 2.39.2 From nobody Sat Sep 26 04:37:00 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D09342E736A; Fri, 4 Sep 2026 13:13:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527616; cv=fail; b=LC0vGbkJcpAC4Xji+O690RjmrGE4kx9KOAmDpCmNrCUZrmV4HsMHkGw0cu2rxzFKD1e/Kv0kGrn6v9J5I8e/2f/DrX+yQWi+7eGXb6wK+FVz8p+85Wik0vaEMQsUQ6Nw6kp9+r53B3IyYpXyCBpqk2DpDR+G1/ejWW8CE6ZzAUw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527616; c=relaxed/simple; bh=Vbn+XLMaFzBjz/uvtk95yaSvYtDRv5PeHaLFfCPIbjw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ito3o7c+m6zYFdqI4fnphy5dcSPmFF1zglkFfpe5Fb+Fe997WsrowiMZHiKl55AFl5jsd9h8zFcjLGVbm6quOfpPOBli43nuvlcTWeWqmlOy0RJTVitO00elTptTCy8AJ+CdzFKa/PSgAgh3Pj7yaQgYW3PAzZHQ89jSelJMgM8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=g/Hrs1Ae; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=IdEbR7F6; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="g/Hrs1Ae"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="IdEbR7F6" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 684AHoND3238091; Fri, 4 Sep 2026 08:13:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=6JwITzJS1HiqrdKiUyafv46BdgOOqAsiTlQP/jiss aY=; b=g/Hrs1AeHr72h4pY+n7deBihi043cdmW09PVBUvgR0wkkyWZOtqyv7GBA g9n2d/UCD/fxMcLMtZqrQMAH8CgvYKV764NtQia16IU0rwz6DP519afP5dxDdr4z rRDeqydgJI0YmBMIBAtxq8ko7iCA3RtUS3ERLtFZBRAmgx1lvdMc5/owK3IMXmQR YCOKfNwxL+DnsYdgaHyBUVhkX0Lu6Xb53RXuMaRwG6pjPqI9ElzuE2NdEtIQWO5l Xe9brMWtiQnZ4lkImL0PTdAtqH+Unh9z57sK8+nJRC5MMFsBpjVx2Vz5FzG3DF2U g1wCe0XMeJv1jpS3zwZ6CSY0DWY8Q== Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11013001.outbound.protection.outlook.com [40.93.201.1]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gfu6w99kh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 04 Sep 2026 08:13:14 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N42nO0TKUz2LvWwRSIKDIIIJsFhwv5Qw+O6Z6J1U7hRI8XIBa6YH+pG8flp+peHqVunyBGrvjhLNajEn2Q6rRPhijSBjO6NpterGUl1EGzEOcMFtZrxEUzRG0Nr9TgWdi0SW+ABiMDJe5VyY/wy2FxOCHY1Q/Rz6YrF2LjZ7AAnFM99QncHyzLLC4OTAg7jhoJf/Hn3vR4632pYyem/gSnLpd7fBcQjgqd4dlZK3R1YLf6GarCo0ggB+FSMQQ1OEWEV2NTbQRy4UEZFP1/Xugj25sm675utRhU9m655ST9fyVrAmQanW1cMs6ZjNz8u4NHdYFn+iTuS7TZI5pkrT0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6JwITzJS1HiqrdKiUyafv46BdgOOqAsiTlQP/jissaY=; b=xgZtWqCLyYHHHdkJvj30r5U/Q9rYHTEeR1sFWPK8g4aaFhx/DRapJqUVjS7cPRwtahS7XMM/m7D/lS8CJX0gc7T8miOuOJws/1hX+qH47PvA4AnYkD5vJ7z3zHP4KcN7mnht/ZydvdBu6b9cSx7Afacl2QOyDjlXQvyg8kxYZa/nrqOa+cDeo7WC4Xz/HAjQbDoRZnusRItzI0K6AnBWP+a7BF9wzc+PxIfkGH+YKZQFCv/uAkgfMlhvQCLdniP2enaqvB7n1bbou/exWNn3aQ/bdECAFpuzRukng9X3vZBxcL53efj7T78R3ssJLqiPciAswlDMs2aEXru7jaisrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6JwITzJS1HiqrdKiUyafv46BdgOOqAsiTlQP/jissaY=; b=IdEbR7F6+AeSEt0wx0j/zMZLq5GNsLeym4yNsJme7cxDj34vC3zl3Azd09+Xszo3G9p/AOJ70k8y7bZFKM372c5jAFVvIEvzAQ4AzrhaNnYwbGkcDuZrcSdnE6xuhHI1OCnn6ul9B8CoZWt0ix66AY0LMw+FNv7Zwt8aNiJTZOA= Received: from SJ0P220CA0025.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::16) by DS0PR10MB7202.namprd10.prod.outlook.com (2603:10b6:8:de::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.9; Fri, 4 Sep 2026 13:13:06 +0000 Received: from SJ1PEPF000037B5.namprd05.prod.outlook.com (2603:10b6:a03:41b:cafe::1c) by SJ0P220CA0025.outlook.office365.com (2603:10b6:a03:41b::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.13 via Frontend Transport; Fri, 4 Sep 2026 13:13:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ1PEPF000037B5.mail.protection.outlook.com (10.167.244.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 4 Sep 2026 13:13:06 +0000 Received: from DLEE202.ent.ti.com (157.170.170.77) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:56 -0500 Received: from DLEE215.ent.ti.com (157.170.170.118) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:56 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 4 Sep 2026 08:12:56 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.36.126]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 684DCq58371029; Fri, 4 Sep 2026 08:12:55 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH 7/8] i2c: omap: Switch to using BIT and GENMASK Date: Fri, 4 Sep 2026 08:12:51 -0500 Message-ID: <20260904131252.2126353-8-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260904131252.2126353-1-afd@ti.com> References: <20260904131252.2126353-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037B5:EE_|DS0PR10MB7202:EE_ X-MS-Office365-Filtering-Correlation-Id: 693c0b41-6079-45e1-b225-08df0a864247 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700016|23010399003|82310400026|56012099006|10086099003|10067099003|6133799003|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: /ArhrriHRSYY10/KEO+Hr3WWr2qIXMZmZd3mSiatJPnyMy004cKZJmvSQo3plXblPGVdn0QVF+3Geko3+cDdGgCfXk9/dKE+prA9eAlLD4K8tjSP1CZXjEDpHBSwpuAjhWet/teMKeJDb3u/lm6Ze5sUPCrByuRgM1NKBNYGGbZ4GcnDFqAr6j4DeNqr8FghUDyu4irAse3h6YiOizy97tf/aDYEv7y5+TVmlO50DNwhXYT66vw0vI/5h5BCJe1OKHI+ifI4vGcQ+FTStdwyf14hK0f0E6RL9E5TYl+sNBxmaClZMZ3wM/xyGATbSO6Z8JJ/uPQL5sRADjp7euqIMfdVyXWN53qHALMzxf7vHa6b4jUqMpABGq1XWgTnVwycBG/93lkDrI2FaWup8XZ9NaaINGvOA9fDvotVX/wWYOU/2m3UePC6Pe1LCwkH3MvLOoCnTrkEz47Jp8vBmJJUFsn1ZwEfbbXPd4CoX1fFpOhFKiSVQEp3vZlfBBNnpUVJmjsIiSdUiKI9xR41DQp2/HZclzVfxvnj63uVcBDKWnO7P/4cihJmOxdExrL9gsTDNEHfyHiXRyDng2TWsuFAnbRjG4EhGwChVrNxSHXSWi0SGqqr3U0sdEGUfOLvy3jxldf7fW3ijGMVMqWI8RIYb9tinCXZ7BNu1RbBpT/eAETUXkKvIP1jHWe6UZqbhqF2ulTbLTnk7EP0eWph/jowbg== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700016)(23010399003)(82310400026)(56012099006)(10086099003)(10067099003)(6133799003)(3023799007)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rJ+BnmBKNyOKV6SODcwZGE5F75QyeBmLSI2zX8H+1hhhjXb4khyfUUA/XMx4naGT2mZGccDpXiBGrPjLas7bhF9DbaYeLpQjZCWKrNTT1cNd6odd1w+iRaZo9OFEOLDgpOT/2LlMBwAMhxqV5hqvuRXiJR+ZRKYVII9lhfdtEoGBrDQafegYchZUSFo4YV7137VgK1un5pyYMa3+ccks9ffInxP8JaRqVOKxnV4R7yAl0WQvRVz6fYyX/IAV6BocTmkXevVZXtS687XJtij/vK8G2rvalmHhHJt41KPyKiFLxP8tTeqwbypGCg6CUEu9dSLY9muov5UxXJFU9Y1EqNEZZexujb/wdN4CEnFY7WF5r1PQKmXNZs5ocORO76zIfHc5AXWo0PaC9vVJaCGoNEM6lZTkUAa1AnQD6y9NiG36SLIJOhU0yqDP/00kVi7a X-Exchange-RoutingPolicyChecked: ENV0agIBnj7cYWVlkoxV5bI+etyz//Q1lNUZynSY709MZHpHtYQlxdxdsmd5FtIkUuxHnMSpLDmOJUAilWpgKfHV85TLvC/6Y4THb22hJrRXEgOsZ3BvL1AiIiE3w+WXuED8hv+A/0d3T8oImEmEovWeiC4lzbtQkH6HFy6K5Gk9v7fVk2G+b8ApFnmXkhitC93FOrqS8kN/FJCL8H7IgU0M94VIKWGRaljudx51mHqhu2/0rrMtrfgAJ3BXdrfsOoZwP5xeu61rAqpGGWXCwMF7y0B/0OTxxMiXHA3nc3w9vAAg1vmemg4ruUCnpsVM8SHVqW3fc12oH6NIdwV74g== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 13:13:06.2436 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 693c0b41-6079-45e1-b225-08df0a864247 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037B5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7202 X-Authority-Analysis: v=2.4 cv=XLoAjwhE c=1 sm=1 tr=0 ts=6a9ac3ea cx=c_pps a=/vFeFcp+ixIfR90aQz5jMA==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=nc86A_OknvlbK2ZPRX4A:9 X-Proofpoint-ORIG-GUID: 5_DcAQjcCiE8sajEdOEks5pFoU23VVIC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX0oIgOyF/hBGA FRe2x78mF60oD/YsNL+qUdGfugqsgx+zjKY4S0mE2OIfltffyM3osaafwVpEYfo5fAw1Oir+Ain OWyPHyokzQT2gvaN+lV/XNBUhe5kiKSyNIx2bBcItOx5kLVj4He1Xa+Mj6ySH4riEwc5P22Tmqj vzKuYO0rRUuzT1nZNJeUkj1Nsw6XjPLnS83Ns20QzQoAWttU3n+unRYN91OtRFtVyzQHsLo+Er2 utb8HT8lZNUwqbVO+kRM7LZJeJSjImBjsQjkhdtm7Y634MvY2iSSiMoULCfBZT1rYfc0vfjCZgp j5h3WQWZie7F8pQgGTz5IPwHFN3fbyACKV3vpE3d9w8ZFaK/uyC/74IKcaCGqRzW03xRo/9KeKD APmKi1dUMnwT0opJ6lTy1yxpQLlH25fVZkRubjbZX8s5qAqtN9ZOGH454YsjED4hNQdvLkwy7T3 sir06ok6Y3WzvqBrp/g== X-Proofpoint-GUID: 5_DcAQjcCiE8sajEdOEks5pFoU23VVIC X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX/8pBFkvQ9AnU MHai/D+2MtAu4HLqr1WZkLHZ8n8gp5MjHWH/g32XZh2nXnJnsIDW10+n8YZIUDFAzFvu+9xtSkO rI5IAjPAbYtA1Ysa5+uAIOAKoaTRDRo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_03,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 clxscore=1011 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040119 Content-Type: text/plain; charset="utf-8" We have helpers for setting bit values and masks. Use them. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 82 +++++++++++++++++------------------ 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index a50cf195c28cf..41464f92da046 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -79,64 +79,64 @@ enum { }; =20 /* I2C Status bits (OMAP_I2C_IE, OMAP_I2C_STAT, OMAP_I2C_WE) */ -#define OMAP_I2C_STAT_XDR (1 << 14) /* TX Buffer draining */ -#define OMAP_I2C_STAT_RDR (1 << 13) /* RX Buffer draining */ -#define OMAP_I2C_STAT_BB (1 << 12) /* Bus busy */ -#define OMAP_I2C_STAT_ROVR (1 << 11) /* Receive overrun */ -#define OMAP_I2C_STAT_XUDF (1 << 10) /* Transmit underflow */ -#define OMAP_I2C_STAT_AAS (1 << 9) /* Address as slave */ -#define OMAP_I2C_STAT_BF (1 << 8) /* Bus Free */ -#define OMAP_I2C_STAT_STC (1 << 6) /* Start condition */ -#define OMAP_I2C_STAT_GC (1 << 5) /* General call */ -#define OMAP_I2C_STAT_XRDY (1 << 4) /* Transmit data ready */ -#define OMAP_I2C_STAT_RRDY (1 << 3) /* Receive data ready */ -#define OMAP_I2C_STAT_ARDY (1 << 2) /* Register access ready */ -#define OMAP_I2C_STAT_NACK (1 << 1) /* No ack */ -#define OMAP_I2C_STAT_AL (1 << 0) /* Arbitration lost */ +#define OMAP_I2C_STAT_XDR BIT(14) /* TX Buffer draining */ +#define OMAP_I2C_STAT_RDR BIT(13) /* RX Buffer draining */ +#define OMAP_I2C_STAT_BB BIT(12) /* Bus busy */ +#define OMAP_I2C_STAT_ROVR BIT(11) /* Receive overrun */ +#define OMAP_I2C_STAT_XUDF BIT(10) /* Transmit underflow */ +#define OMAP_I2C_STAT_AAS BIT(9) /* Address as slave */ +#define OMAP_I2C_STAT_BF BIT(8) /* Bus Free */ +#define OMAP_I2C_STAT_STC BIT(6) /* Start condition */ +#define OMAP_I2C_STAT_GC BIT(5) /* General call */ +#define OMAP_I2C_STAT_XRDY BIT(4) /* Transmit data ready */ +#define OMAP_I2C_STAT_RRDY BIT(3) /* Receive data ready */ +#define OMAP_I2C_STAT_ARDY BIT(2) /* Register access ready */ +#define OMAP_I2C_STAT_NACK BIT(1) /* No ack */ +#define OMAP_I2C_STAT_AL BIT(0) /* Arbitration lost */ =20 /* I2C Buffer Configuration Register (OMAP_I2C_BUF): */ -#define OMAP_I2C_BUF_RDMA_EN (1 << 15) /* RX DMA channel enable */ -#define OMAP_I2C_BUF_RXFIF_CLR (1 << 14) /* RX FIFO Clear */ -#define OMAP_I2C_BUF_XDMA_EN (1 << 7) /* TX DMA channel enable */ -#define OMAP_I2C_BUF_TXFIF_CLR (1 << 6) /* TX FIFO Clear */ +#define OMAP_I2C_BUF_RDMA_EN BIT(15) /* RX DMA channel enable */ +#define OMAP_I2C_BUF_RXFIF_CLR BIT(14) /* RX FIFO Clear */ +#define OMAP_I2C_BUF_XDMA_EN BIT(7) /* TX DMA channel enable */ +#define OMAP_I2C_BUF_TXFIF_CLR BIT(6) /* TX FIFO Clear */ =20 /* I2C Configuration Register (OMAP_I2C_CON): */ -#define OMAP_I2C_CON_EN (1 << 15) /* I2C module enable */ -#define OMAP_I2C_CON_BE (1 << 14) /* Big endian mode */ -#define OMAP_I2C_CON_OPMODE_HS (1 << 12) /* High Speed support */ -#define OMAP_I2C_CON_STB (1 << 11) /* Start byte mode (master) */ -#define OMAP_I2C_CON_MST (1 << 10) /* Master/slave mode */ -#define OMAP_I2C_CON_TRX (1 << 9) /* TX/RX mode (master only) */ -#define OMAP_I2C_CON_XA (1 << 8) /* Expand address */ -#define OMAP_I2C_CON_RM (1 << 2) /* Repeat mode (master only) */ -#define OMAP_I2C_CON_STP (1 << 1) /* Stop cond (master only) */ -#define OMAP_I2C_CON_STT (1 << 0) /* Start condition (master) */ +#define OMAP_I2C_CON_EN BIT(15) /* I2C module enable */ +#define OMAP_I2C_CON_BE BIT(14) /* Big endian mode */ +#define OMAP_I2C_CON_OPMODE_HS BIT(12) /* High Speed support */ +#define OMAP_I2C_CON_STB BIT(11) /* Start byte mode (master) */ +#define OMAP_I2C_CON_MST BIT(10) /* Master/slave mode */ +#define OMAP_I2C_CON_TRX BIT(9) /* TX/RX mode (master only) */ +#define OMAP_I2C_CON_XA BIT(8) /* Expand address */ +#define OMAP_I2C_CON_RM BIT(2) /* Repeat mode (master only) */ +#define OMAP_I2C_CON_STP BIT(1) /* Stop cond (master only) */ +#define OMAP_I2C_CON_STT BIT(0) /* Start condition (master) */ =20 /* I2C SCL time value when Master */ #define OMAP_I2C_SCLL_HSSCLL 8 #define OMAP_I2C_SCLH_HSSCLH 8 =20 /* I2C System Test Register (OMAP_I2C_SYSTEST): */ -#define OMAP_I2C_SYSTEST_ST_EN (1 << 15) /* System test enable */ -#define OMAP_I2C_SYSTEST_FREE (1 << 14) /* Free running mode */ -#define OMAP_I2C_SYSTEST_TMODE_MASK (3 << 12) /* Test mode select */ +#define OMAP_I2C_SYSTEST_ST_EN BIT(15) /* System test enable */ +#define OMAP_I2C_SYSTEST_FREE BIT(14) /* Free running mode */ +#define OMAP_I2C_SYSTEST_TMODE_MASK GENMASK(13, 12) /* Test mode select */ #define OMAP_I2C_SYSTEST_TMODE_SHIFT (12) /* Test mode select */ /* Functional mode */ -#define OMAP_I2C_SYSTEST_SCL_I_FUNC (1 << 8) /* SCL line input value */ -#define OMAP_I2C_SYSTEST_SCL_O_FUNC (1 << 7) /* SCL line output value */ -#define OMAP_I2C_SYSTEST_SDA_I_FUNC (1 << 6) /* SDA line input value */ -#define OMAP_I2C_SYSTEST_SDA_O_FUNC (1 << 5) /* SDA line output value */ +#define OMAP_I2C_SYSTEST_SCL_I_FUNC BIT(8) /* SCL line input value */ +#define OMAP_I2C_SYSTEST_SCL_O_FUNC BIT(7) /* SCL line output value */ +#define OMAP_I2C_SYSTEST_SDA_I_FUNC BIT(6) /* SDA line input value */ +#define OMAP_I2C_SYSTEST_SDA_O_FUNC BIT(5) /* SDA line output value */ /* SDA/SCL IO mode */ -#define OMAP_I2C_SYSTEST_SCL_I (1 << 3) /* SCL line sense in */ -#define OMAP_I2C_SYSTEST_SCL_O (1 << 2) /* SCL line drive out */ -#define OMAP_I2C_SYSTEST_SDA_I (1 << 1) /* SDA line sense in */ -#define OMAP_I2C_SYSTEST_SDA_O (1 << 0) /* SDA line drive out */ +#define OMAP_I2C_SYSTEST_SCL_I BIT(3) /* SCL line sense in */ +#define OMAP_I2C_SYSTEST_SCL_O BIT(2) /* SCL line drive out */ +#define OMAP_I2C_SYSTEST_SDA_I BIT(1) /* SDA line sense in */ +#define OMAP_I2C_SYSTEST_SDA_O BIT(0) /* SDA line drive out */ =20 /* OCP_SYSSTATUS bit definitions */ -#define OMAP_I2C_SYSS_RESETDONE (1 << 0) +#define OMAP_I2C_SYSS_RESETDONE BIT(0) =20 /* OCP_SYSCONFIG bit definitions */ -#define OMAP_I2C_SYSC_SOFTRESET (1 << 1) +#define OMAP_I2C_SYSC_SOFTRESET BIT(1) =20 /* Errata definitions */ #define I2C_OMAP_ERRATA_I207 (1 << 0) --=20 2.39.2 From nobody Sat Sep 26 04:37:00 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3FFD499F05; Fri, 4 Sep 2026 13:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527641; cv=fail; b=iyhjdkBb3vH6yu5fKfHRf8YOv9L1JvklZ6ZXav2QaYmWWkUYeJwauj3V4E/vrG9egWOZFtBY1nAosiRoaVhq+3yXsSSjLhmIxVHlrt23qasJjS0H3GUAPd19Mn9+7RyHZqSH+eDq9R9Px2JDqbBLy+IcTApPKJe37/7Q3mR3XWE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527641; c=relaxed/simple; bh=4TWV0hp5GelVWeGq/SU1s2vRX1iT5+aHZlIL4+XIm4A=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pU9joO4hfr59bCQ/B0sGTJVt2zf8oxe9XBk7CAOBs9IZsV/A6BpzJUwDAEOR0LBzw+DK5uE/QeEH3/oFEtaT7Ro/WSW/n3vIZfpQUKx2gNLqQHnjYwAWd4dSOE9CuhduwMPSUoZOymxksHoI7W7OuegyP6oMU8Hj05xaRdx979g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=FUJWx2Xv; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=qCUMVkRk; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="FUJWx2Xv"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="qCUMVkRk" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 684AHPLo1941922; Fri, 4 Sep 2026 08:13:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=kCaXQG8g+KbdKJZmHMWxziFfL4YtofrBzJF5rA5Nb wM=; b=FUJWx2XvSc4eAHaXV1C5fLRnN+Wc3ZcvH22wi0mHJEKwerjO0AdegzwVQ u4PzgEamCGN1qbqZGiz9pThLsBGZQngu6euUgSOhlvmopuIID9UuuRUV+ZtsKkz0 UHWB+aOeVOpvmVIeVcHPAWVdzaj49AOVb2Uvsr7TQGIF3WpfnZaLbk+YrzemzbP2 hdAb4hlx24PV2q++JfspQ4SmHQFJr+TS8heVhyAxbUdk4EY/JV/yTrtVm3XISBRz 1IQMfo7JUQqoWRSsP/YhKRXe4qbrvpdZC+yaDdEc0tuNldzIFElV2otN0kmaSYFQ o9BCNot/Ulxy5Wwd3rabtfsOfhuWQ== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012070.outbound.protection.outlook.com [52.101.48.70]) by m0384305.ppops.net (PPS) with ESMTPS id 4gfrs326eq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 04 Sep 2026 08:13:50 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SDWrmt0fXOuy08ZXbI57RZiqXn1jgEAJXjcLcgWswEP7FAIG4vR5LGKqOkNPGDujhpqh8YTjlTQcjYL8vqnkznAtSvmLouhtQctyP7MnCchOjIFI7kiIB1uhXmJ91w90p3V7tqQ99jIUSAoyR/cgRcWou1JR5clStt5SKvQQzXvyI+8d8gihFrPKoBfi9dLzJBjwQ7AMk2HRF6AkWRcuZfS7BMVwtOcMWpqIbhZSR/t21UU7Q5hHPPdY+V/60HnhZT9f7b8dNvwZhHEqh2KN1bwb0cF1/pb1cCAcLxi/ArAuFGTRePIvhobwQjmzsuVeg8lF3b23w0bark60qdv/sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kCaXQG8g+KbdKJZmHMWxziFfL4YtofrBzJF5rA5NbwM=; b=BuiLV7kctP3xb3fdLJx2cNAo511hF1KwfGktbaw/cnFwMk8bDUG7aC6MohtnN0nHIEsAb93tToSQtJn1uiW9zqLyRAcTpsLggoF4EbHJ4jVzsmknD+jfWG1zyLCsPB/L9cQp+UNla/zU/KYoTGYH4tqx2hvy3A5abdgkMUXhZj3MU0BBVboDN1fubOpbtzdOeV3L3e/b7z5WkeRm/VS6VTn5AZ0HBzjcLMKhCV4XbXCPhlikeryXNiDU2S7RueagLbXXToRYvR8UBhuFP5gJmoflRuqGYFqSNKVfNC64QBeREFdXDlTvOPbRqlouDKQHN+IL3emNyU0qcCyObJY6+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kCaXQG8g+KbdKJZmHMWxziFfL4YtofrBzJF5rA5NbwM=; b=qCUMVkRkrH31ufRGsWOksMUK1HkSbY9X5PWEeNRx0eHVJzdZmjrY1nwQywseppeGNk65WANpXFEh4teozL5i5UCe1nRbXFd0VXT414TsmLEXeawKF1HTlHiYCk+G+uC1MwYMI/ESRKaTwvJXHIYt5PGUaRjxe9u5pmW4GA7GcaU= Received: from BN9PR03CA0531.namprd03.prod.outlook.com (2603:10b6:408:131::26) by MN2PR10MB4285.namprd10.prod.outlook.com (2603:10b6:208:198::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Fri, 4 Sep 2026 13:13:47 +0000 Received: from BN3PEPF0000B370.namprd21.prod.outlook.com (2603:10b6:408:131:cafe::37) by BN9PR03CA0531.outlook.office365.com (2603:10b6:408:131::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.12 via Frontend Transport; Fri, 4 Sep 2026 13:13:46 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by BN3PEPF0000B370.mail.protection.outlook.com (10.167.243.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.1 via Frontend Transport; Fri, 4 Sep 2026 13:13:45 +0000 Received: from DFLE206.ent.ti.com (10.64.6.64) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:56 -0500 Received: from DFLE207.ent.ti.com (10.64.6.65) by DFLE206.ent.ti.com (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 4 Sep 2026 08:12:56 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 4 Sep 2026 08:12:56 -0500 Received: from ula0226330.dhcp.ti.com ([10.249.36.126]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 684DCq59371029; Fri, 4 Sep 2026 08:12:56 -0500 From: Andrew Davis To: Tony Lindgren , Vignesh R , "Andreas Kemnade" , Kevin Hilman , "Roger Quadros" , Andi Shyti CC: , , , , Andrew Davis Subject: [PATCH 8/8] i2c: omap: Add OMAP_I2C_BUF_{TX,RX}TRSH definitions Date: Fri, 4 Sep 2026 08:12:52 -0500 Message-ID: <20260904131252.2126353-9-afd@ti.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20260904131252.2126353-1-afd@ti.com> References: <20260904131252.2126353-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B370:EE_|MN2PR10MB4285:EE_ X-MS-Office365-Filtering-Correlation-Id: d40bbee4-f968-4cd8-dbbf-08df0a8659b5 X-LD-Processed: e5b49634-450b-4709-8abb-1e2b19b982b7,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|82310400026|36860700016|376014|6133799003|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: QRm/1Js9cx9hF9okz4X9qLY9LGWlfmkQtO89idP/NQieH9d4Blo/sKgymT8VfEiNzs2HsGqNgRKdS9kIWrhxw+w+4Zd3HCpdUPX7/CWNvtKCLtp/zbtvniDqtu7jKS1VJPnjfPS5PcD4IFY5aZZ4NCuSs60pAVBM7in1sLbGWDS/xmei+dm+qVbTylF/NCWepsRGhk5xidzZIdA1ueVWYRYsawR4kX7Peao9Tk2M41LylR9OKUCEqfuXaONv5uVGkZn3NaFApM/HlH+en4zWfIthegCOASinN2zyNDGzeKInW1YhCAzrGm38BlEDRMNcYnbJlqK5JAruBbAh0rrVHSTjl8KWCxF9mXCJuvNj0B6cmx+XaETljcIcwp+FqkB580A7zHVYeF2mjgkqAmGAYVmfVkHuNUqXzAfM7qywnKK94cB/Q/Z/4g7K/N5VfkOA4+g512OPo75bw1+hfOsThziIHKulwhFzG17UxYIyd4VuBxxjB/PntrcjSDEpeEba0D8zxBJJkvhZqYCeUUI+EEPmep5m5bmPIKqbbdvrJIEBVDFKkwPMR4JnMPW9eC6TPxpa8ff6cjQjnMYm2iA1jwaEjgNbFvfJTbvAi8AWLfYiw9b+6K9EzUOfWgltRjYQKp1EUOrmzPrYKVNBbyB6nBwNjq3YrqHJo7OKNPEkK94NH0Dxm/dUfoMwhCZg7XBAZqkzYd1fhX/SUHljidx8Yw== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(82310400026)(36860700016)(376014)(6133799003)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xsPIiWB6VJ2b9BjDzezisLIgbRNY2iZ50kuXrQsK6rrrcIBIDCWUBNO9t8XaEFJJ1pxzE43TBovYGK/Yk6LcVdAOc/AzzYjRhkEgv3q5nbtl/5haNrVXq6Z3HqMRV/SUz7lwvU4dq8zjtgtINEVqXE7GX0DmRYgnLzAS+l7GzoqHjPUy3CgUtCvHqJ9SYTUJh2WZ2hZmixnAvrYtnWR+/GlOx0m7o8RkCOhdcrGImeSQVO0AkOu6iEYol5OaWeDm7HK7ybB+dO/JZ6I0CKUrgWx2CGEMhYVfzmbIuyYcajZXK7OsQ/WcASYbgt+iGlcvd5Yo4pObXi1eNVEN8pzMuyqEWrjIB7TuvhUJVnbryPe0V5qQrVNi5JlegDm3ukgRueWqjfi7LJIINvWN1Hx1a+IHRMgXQ93mmG3o9fceWDp6MdDwCepZXIuMPEIipl7c X-Exchange-RoutingPolicyChecked: wOFSlS66j829t39dyZCsI1k6tXp/u+roynTJJXKzHuovqUgRbuWy8Dh+GWdooSiHl/z5OROGR99dW+rlGDDSYIL/b2oNNvu38vH0gQ0iwqggPHLAKgCNfJbopeT/1c2GXZjwBHRZugVh4PevEMH9zF+t4Rqh5zC/e5VTx3ZdyELLIrxpSuAajCLRDLlXnTuYnvJNOyLKCgyXG/Fn0pijOlcSX2Ki8YPMAt8g2ow40qIxqmzkQI6EGlWPKctl+8ZaCEsq7hISZrfAq5c3C1gGTViOmJ5kbChO/iyk5/ibBIgwzSN0Sl7xk3taXv5ZRKxCDY/cu+zpJC470i3QQ7L8jA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 13:13:45.5639 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d40bbee4-f968-4cd8-dbbf-08df0a8659b5 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4285 X-Proofpoint-GUID: Y3unDY_0_gGN_zWNXd5QOZ9cTrXpMwsd X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX1Jf0xxGbd51C m8nER6IJBIfuGuqAiOSy67IyRFo5/yWhqSTO4aRE7l3+wS/h4n817YO2g/qpkC77isAimhhGQL3 fgoZbGP8wmppjrO+c+Dn2X2vIMEfrGs= X-Authority-Analysis: v=2.4 cv=GshyPE1C c=1 sm=1 tr=0 ts=6a9ac40e cx=c_pps a=037dmpTZGv+Xy+TtntRLUg==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=9kDT9J43iM3-Rq2zlG0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDExOSBTYWx0ZWRfX96/lVQgcDWAc iUukDza2NRLnbS5+GK0h3ip2c8lSG98pq0pn59cyRHSyhBdOMZtf8ns/pWCXPLbAubATxjN7E57 KNbAHDq+cvh5S/2GXFuCP2O5IxbHZjjUvJUOzrQSYZ1AXyAwx4cQl5/nWnbYHzhvn1JFHHhz9GG TfQlsPy+8lVs2y6hXvOt7PjMzVKf9DoK6rBC7p/MZpQRf3kHbMZaM9EUXz91UC5iEDZYmYWEWf2 shZK73QFjij9oCBarVI6318xDMpUQnOXAPz2KZ+a19E3Yo/5prz+t0QqfwDR0cEhIQw+VmXY9Tf lgboNw0P2IWod4OrpejxmHs6DFu6cIhuIQji0d5FMnXhOzsCgd7/aqUDmFG5xwrOEC3ZvjukW9c g9+rope1fL3G036t5xh82ILdyB4fBxdIOiZX+HhLREGe8TGW/s2HrSjf4gJ6GfYaDHs/bIckhMM S0xdG+6Od9lRp6HHQ8A== X-Proofpoint-ORIG-GUID: Y3unDY_0_gGN_zWNXd5QOZ9cTrXpMwsd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_03,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040119 Content-Type: text/plain; charset="utf-8" These were just magic numbers before, give them proper definitions and use those in code. Signed-off-by: Andrew Davis --- drivers/i2c/busses/i2c-omap.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 41464f92da046..669d931928fb6 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -97,8 +97,10 @@ enum { /* I2C Buffer Configuration Register (OMAP_I2C_BUF): */ #define OMAP_I2C_BUF_RDMA_EN BIT(15) /* RX DMA channel enable */ #define OMAP_I2C_BUF_RXFIF_CLR BIT(14) /* RX FIFO Clear */ +#define OMAP_I2C_BUF_RXTRSH GENMASK(13, 8) /* RX FIFO Threshold */ #define OMAP_I2C_BUF_XDMA_EN BIT(7) /* TX DMA channel enable */ #define OMAP_I2C_BUF_TXFIF_CLR BIT(6) /* TX FIFO Clear */ +#define OMAP_I2C_BUF_TXTRSH GENMASK(5, 0) /* TX FIFO Threshold */ =20 /* I2C Configuration Register (OMAP_I2C_CON): */ #define OMAP_I2C_CON_EN BIT(15) /* I2C module enable */ @@ -602,12 +604,14 @@ static void omap_i2c_resize_fifo(struct omap_i2c_dev = *omap, u8 size, bool is_rx) =20 if (is_rx) { /* Clear RX Threshold */ - buf &=3D ~(0x3f << 8); - buf |=3D ((omap->threshold - 1) << 8) | OMAP_I2C_BUF_RXFIF_CLR; + buf &=3D ~OMAP_I2C_BUF_RXTRSH; + buf |=3D FIELD_PREP(OMAP_I2C_BUF_RXTRSH, (omap->threshold - 1)); + buf |=3D OMAP_I2C_BUF_RXFIF_CLR; } else { /* Clear TX Threshold */ - buf &=3D ~0x3f; - buf |=3D (omap->threshold - 1) | OMAP_I2C_BUF_TXFIF_CLR; + buf &=3D ~OMAP_I2C_BUF_TXTRSH; + buf |=3D FIELD_PREP(OMAP_I2C_BUF_TXTRSH, (omap->threshold - 1)); + buf |=3D OMAP_I2C_BUF_TXFIF_CLR; } =20 omap_i2c_write_reg(omap, OMAP_I2C_BUF_REG, buf); --=20 2.39.2