From nobody Fri Sep 4 05:19:42 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8801F64A8D; Fri, 4 Sep 2026 00:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788481719; cv=none; b=iSvRW0uX8ivwO8rB7VyVH9zDcAo/wrBdmQyHQZKgVdbLqJc4Hr5/4YxGmucMUfHcl8Q9KcYIpSZM2FMlDjsRmXk1SH9nJk2KJNThFcMqUIKPY/3IEZiOP24G8dRt6KiGTaoz9AnJC+2JReiL39RIFAANPRqgd3IsKWKetOvLxew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788481719; c=relaxed/simple; bh=E2pPTMj2y0igH8/fLVW/oBV18kRCmsEZu9oDLRGSds0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Fa0uESN2j58dPIsH0hFAvGDFNiL+B4DurarForCX5wIm4/n6SHOP7E3bPlSVI/LDivdox3FFrPL0rC2W8mu/jploRYHK2tjgxx771ZFWykIfGb30ftOJnuJqd+KKRMTi2Vi1nCurM8S/3C6/OVRfp3BMpJosGc13tOQGX7sgmmk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a5TBCL0l; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a5TBCL0l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D7A01F000E9; Fri, 4 Sep 2026 00:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788481718; bh=166TVcIhx+0QErke7o9FSwWx5qn3nWzpmAkGNjrnyxo=; h=From:To:Cc:Subject:Date; b=a5TBCL0lOqtdWhuMu8eqDhclsqwxPf/1VXkbfpNmnIcjvwjDn80KggTx9+l4jPfIG OJ+2gO/99uTovvA+HLAQNk5LgV3QqxyNxVMSYAF79F1BpUun4xBFzMQfE+3vUmDNY6 I9q1gPKx6r5qi8ZelTUBBv7ECk7+bzrm2EzAwzD/JMclfrGieDUZQD2qPXAwtu0iDP 4ngSvns5LNd+t3kVnYKkgTOCrR2urpvCBpUW7tIRO5x0g7jHIVcJnQP3p12iifdCwt 7cQQjxOOvKQnP0CZVRPR14yV8SW4M8P/hwCJR/FRofKl3gJfW5cRlBaloEThAw0k7K yki2hn2G0y2FQ== From: SJ Park To: Andrew Morton Cc: Nathan Gao , "David Hildenbrand (Arm)" , Baolin Wang , Ryan Roberts , SJ Park , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH v5] mm/damon/ops-common: use a page-aligned address in damon_ptep_mkold() Date: Thu, 3 Sep 2026 17:28:27 -0700 Message-ID: <20260904002829.116381-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Nathan Gao __damon_va_prepare_access_check() picks a random byte address within the region and stores it in r->sampling_addr. damon_va_mkold() passes it into a page table walk, which hands it to damon_ptep_mkold() as the address of the page to sample: damon_va_mkold(mm, r->sampling_addr) damon_va_walk_page_range(mm, addr, addr + 1) damon_mkold_pmd_entry() damon_ptep_mkold(pte, vma, addr) ptep_test_and_clear_young(vma, addr, pte) mmu_notifier_clear_young(mm, addr, addr + PAGE_SIZE) For arm64, before commit 6f0e1142173a ("arm64: mm: support batch clearing of the young flag for large folios"), the contpte helper walked exactly CONT_PTES entries from the aligned-down page table pointer and used @addr only to pass down to each entry, so an unaligned value was harmless: ptep =3D contpte_align_down(ptep); addr =3D ALIGN_DOWN(addr, CONT_PTE_SIZE); for (i =3D 0; i < CONT_PTES; i++, ptep++, addr +=3D PAGE_SIZE) Now the range to walk is derived from @addr instead: end =3D addr + nr * PAGE_SIZE, rounded up to CONT_PTE_SIZE. For a sample in the last page of a contpte block, the sub-page offset puts end just past the block boundary, so the round-up lands a whole block further and the walk clears PTE_AF in CONT_PTES entries beyond the sampled block. For the last block in a page table page, those entries are past the end of that page, so the walk writes into the page that follows. Triggered by the full 7.1/7.2 kernel selftest suite on arm64 (EC2 c/m6g.4xlarge). The kernel sometimes crashes at or shortly after the DAMON test. What the overrun does depends on the page that happens to follow the page table, so there is no single signature. If that page is read-only, the write faults in the sampling path itself: Unable to handle kernel write to read-only memory at virtual address ffff= 0003c5d2d000 FSC =3D 0x0f: level 3 permission fault CM =3D 0, WnR =3D 1, TnD =3D 0, TagAccess =3D 0 CPU: 10 UID: 0 PID: 3487 Comm: kdamond.2 pc : contpte_test_and_clear_young_ptes+0x70/0xc0 lr : damon_ptep_mkold+0x1e8/0x1f8 Call trace: contpte_test_and_clear_young_ptes+0x70/0xc0 (P) damon_mkold_pmd_entry+0x150/0x170 walk_pmd_range+0x110/0x2b0 walk_pud_range+0x10c/0x208 walk_pgd_range+0x134/0x258 __walk_page_range+0x98/0x1b0 walk_page_range_vma_unsafe+0x90/0x148 walk_page_range_vma+0x28/0x40 damon_va_walk_page_range+0x114/0x2b8 damon_va_prepare_access_checks+0xec/0x1a8 kdamond_fn+0x534/0x770 kthread+0x128/0x138 ret_from_fork+0x10/0x20 Otherwise the page is writable, the PTE_AF clearing succeeds silently and the damage only surfaces later, in whatever happened to own the page, so the backtrace is unrelated to DAMON and differs between runs. Pass a page-aligned address to the ptep_test_and_clear_young() call in damon_ptep_mkold(), which is the only place DAMON can reach contpte_test_and_clear_young_ptes() from. Nothing else sees the aligned address, and r->sampling_addr itself is left as is, so the sampling and region bookkeeping semantics are unchanged. Fixes: 6f0e1142173a ("arm64: mm: support batch clearing of the young flag f= or large folios") Cc: Baolin Wang Cc: David Hildenbrand (Arm) Cc: Ryan Roberts Cc: stable@vger.kernel.org Signed-off-by: Nathan Gao Reviewed-by: SJ Park Reviewed-by: Baolin Wang Signed-off-by: SJ Park --- Changes From v4 - v4: https://lore.kernel.org/20260902031655.84721-1-zcgao@amazon.com - Collect R-b: from Baolin. - Rebase to latest mm-new. V3 -> V4: - Align only the address that is passed to ptep_test_and_clear_young(), rather than @addr for the whole of damon_ptep_mkold(), so the mmu_notifier_clear_young() call keeps seeing the sampled address (SJ) V2 -> V3: - Move the alignment into damon_ptep_mkold(), instead of aligning in damon_va_mkold() and damon_va_young(). The ptep_test_and_clear_young() call in damon_ptep_mkold() is DAMON's only path to contpte_test_and_clear_young_ptes(), so damon_ptep_mkold() is the closest place in DAMON to the function that requires an aligned address (SJ) V1 -> V2: - Align inside damon_va_mkold() and damon_va_young() rather than aligning r->sampling_addr itself, so that sub-page sampling addresses remain possible for future non-PTE access check primitives (SJ) - Point Fixes: at 6f0e1142173a instead of 3f49584b262c, since the unaligned address was harmless before that commit (SJ) - Describe how the issue was noticed and what it does to the kernel (SJ) v3: https://lore.kernel.org/all/20260901201001.33271-1-zcgao@amazon.com/ v2: https://lore.kernel.org/all/20260831221151.50561-1-zcgao@amazon.com/ v1: https://lore.kernel.org/all/20260827193821.46115-1-zcgao@amazon.com/ mm/damon/ops-common.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c index 7a2e40bc7baed..7219c608b1952 100644 --- a/mm/damon/ops-common.c +++ b/mm/damon/ops-common.c @@ -61,7 +61,12 @@ void damon_ptep_mkold(pte_t *pte, struct vm_area_struct = *vma, unsigned long addr * device aspects. */ if (likely(pte_present(pteval))) - young |=3D ptep_test_and_clear_young(vma, addr, pte); + /* + * Arch implementation of ptep_test_and_clear_young() may + * require aligned @addr + */ + young |=3D ptep_test_and_clear_young(vma, PAGE_ALIGN_DOWN(addr), + pte); young |=3D mmu_notifier_clear_young(vma->vm_mm, addr, addr + PAGE_SIZE); if (young) folio_set_young(folio); base-commit: 87db3abd2b79ed6ccaaf6d3c25df6adbd8ea3596 --=20 2.47.3