From nobody Sat Sep 26 07:17:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 965073B6C09 for ; Thu, 3 Sep 2026 18:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461652; cv=none; b=G8C/dyExgXNm6WfNuWHXIYIEUuSbNfGm2dZR3i1sVRm8OgmIlUIAygciZnm0iJUyceHT0gwlZZguwOMgJzZzy4lcO3qXDOBY9EYRYof1LfMzrMZ05GcfJf46UxPRNItNArn5lLHbqagoe/2eFFowh8jnW+lxUw2/bHKEvebMtxM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461652; c=relaxed/simple; bh=eZIUN/lYfehnQlzthxyb/UGydSLzCEUV422r4IFRfA0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qPd5DHr8Uu6cPtUZT0kCOqym+rKWwyOcfXrC6zBGpo6f97ik1O6mdZbP2VrVtkDGxWnENNZUYUk/WUUQgRscQrEUCsG4b0up2MEyE9G2ABhI0iOx2KjLyJ7JJGw+lpiER2blPSlfJcTXzkjpSicKvYepi4TgWUKSU9ftYvR40IY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WqyiFDsb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IM8krRj2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WqyiFDsb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IM8krRj2" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683G3d6V820134 for ; Thu, 3 Sep 2026 18:54:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jbfjPo2s6iAx/iJD/jmcJcwK+bjVeCVPpo0oSlaiXmo=; b=WqyiFDsb1eWDZKId NODY7STdeeFa9Dzz5GOt/I6NOzR88CxjuimoDCw/cOwtphA7NyMRmQ0d+YoNAHU/ aoH4rspWjkNmuxUgaXiiTnW+2KxHI519tqNvxIK02z+5dwzVTTcVKr40kT/gzGbY 2XwCq9QNWHj7VHJaSb7BT2kM1QaDgAaCecy4yUPUWmd1xk49R+tAl8p2kU7o0mEC Ug7xOhHWVb2kmknb0mHNYlEC2RlpCRCaRdJgFgjwQLM4Y/OQL6+RigIcStGqyJx7 V8nSt/NJ9qNkYx3+C2Fkwj41W3epOf6FgC6qZ6j+P27MTA3CTkivsRCRKSiu04eE 7uCIUg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf82ka32x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 18:54:05 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e7ff7b375so160653a91.1 for ; Thu, 03 Sep 2026 11:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788461644; x=1789066444; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jbfjPo2s6iAx/iJD/jmcJcwK+bjVeCVPpo0oSlaiXmo=; b=IM8krRj2ST59du7pn6Qgg7K9wsxwSqjOPEKpkxIoFxa7o6y39Pfl27toQSEfeAXeeB UcTeM/sWR68vARKrQZ6fhrAO9zPKVvsxxoB81ETgZ7sVSciLRkdHpEeFKQDjd9rC1p93 D94EAIJDB6cIJeQu5VKEwRAl+1LYxdpCxpPcR0VpzgmoYihSGsNapUom2dJ+4F58KB7m Um5f0hmJ+EKiliOU2q0T9OP7BBYYAzMtvjEKOXCYH3vAgFD7RAAgqDDnSyduvHWjU16r OFHj6dwCoOYApO5TFuLqbyEcUMhK8KkonvYZ7V1oV4yIkRrTDKraS1kFYbRQ8LvslAYT TTiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788461644; x=1789066444; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jbfjPo2s6iAx/iJD/jmcJcwK+bjVeCVPpo0oSlaiXmo=; b=Ssm6kIDWaREPmjrNr0LvxWZH3y3Af/c7f/KgZ8MteOtPVnzLdPkugD0ANT/dB6jZmI p0W4K8xABhFoZs7UrWGXkVevo+TLhSH4NRp+CJXNsiez4tvcqReN6DSxX9s9tjtL/sOD XozFlhGVmTscDH4ji/2pc7wmY2CMgGmQEkmx8eX4LCQk01XfKUBUDE2ji/cTbXbUnaBJ Ty4roF7Y2+qSnQw/1VgleIx2kL2ffyewHKPTWWQfw8/Kpki0NkI0v3jYFTWbft2h2vW3 uLeiZjKgN5WVxGCQcElpbydL6CLVp6hhMBTcUH1+dIJW9H2c7+VjdXGQbGMLRnTU7Ue6 /vlA== X-Forwarded-Encrypted: i=1; AKwUvBwrH9F7Fq5YcA43Qy4d+v2pn2Qh6ADe6YaG030bGjnMIJjzBFs9MSxWSkfMWPrJLQVMbYllsmj2LRt3fsc=@vger.kernel.org X-Gm-Message-State: AFuF++n3+8bZLJ0WH+P2F6PNXclKcBnoMbeORzB/HDpIBS+yHt+UhOdv 9eF6AJJVLi5QW/9VFWemEJqVfpCpRBF53t0PodwKcl60fEOPcjs8dV5z0VMwa+Tj0tlQ9Toqn/+ kWs6Qn8sfe4wx23KlTinpLqXSBXyV4xkKjHSA1dXaO7O7CMF+JH+LLGVdhp3Puyv2Vvk= X-Gm-Gg: AYBFou2mp403x6ysJ5oRDckRGSA5T75CMGpOLz6TiL8YHqfnuk0yS0GVs4/zfBme9z/ ydgYKUSlqQB40CVVjed6w2s++dhXxoEs9rcxaDx32p0kqPuHkr2GBfnEgcAVLHrAs5ODFzXFQoV Q5E3l7348VjawIABAMFvz7z53RNo4CgQDKBEbmKCQJMAtrhanvtu/D895W2m/ZGDuT5/oAD+kr2 mT6Gdcp/R1JzozOptZ7Oy8olxEEzdX2Xd8RsCpVo7u065iHnJnLam0vqmTfONzXLWifCrYxkJiY e0Ub41fxyE3fWOpEk4GxRF0WeXkY2Q0ycfByLYQVN1DfWQ6ovKq90G+otxynMuyMo3WNZzWImk2 LGm2EN/lo5yAPamdZdz23R/Uv2fQhUA== X-Received: by 2002:a17:90b:17d2:b0:380:f389:447b with SMTP id 98e67ed59e1d1-39b2613e70emr682060a91.11.1788461644260; Thu, 03 Sep 2026 11:54:04 -0700 (PDT) X-Received: by 2002:a17:90b:17d2:b0:380:f389:447b with SMTP id 98e67ed59e1d1-39b2613e70emr681984a91.11.1788461643675; Thu, 03 Sep 2026 11:54:03 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339885ce1csm778829eec.4.2026.09.03.11.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 11:54:03 -0700 (PDT) From: Mohd Ayaan Anwar Date: Fri, 04 Sep 2026 00:13:43 +0530 Subject: [PATCH net-next 1/9] dt-bindings: net: ti,dp83867: add supply properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-shikra_ethernet-v1-1-a50765996035@oss.qualcomm.com> References: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> In-Reply-To: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788461628; l=1977; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=eZIUN/lYfehnQlzthxyb/UGydSLzCEUV422r4IFRfA0=; b=9YV5GbivqWa07EmRXOblUJxRz9P53VISN5Z/yvnsGCNVx+EjFrU1+3n4+/WNFMnmaAwQEwuHW 8v25iuStJetBoprE3T28uAmO9+1AnmsH0V42lDK1YK09J+0UkP6t/rF X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-GUID: IBh5oqOgixrzi1dgsc6bH123Mzaqfnf- X-Proofpoint-ORIG-GUID: IBh5oqOgixrzi1dgsc6bH123Mzaqfnf- X-Authority-Analysis: v=2.4 cv=OuJ/DS/t c=1 sm=1 tr=0 ts=6a99c24d cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=9lbML-Ic3bjincHAjDUA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX7NWbnSA5Tkw5 nNTARSvgQZHI1yYetbRh0gHF63CEu6hK4hSJFSciDIhFF5Cwr3YSUP5vJ5GqXcjtve1OwlYmk1i HT4c9gQPyGEt+1Zll4FZlR6IU4VaXzvV1mtke+8m0kgDkn/2SZxiPw90dKbAK9jNifuzcGEFCxr B/fuoDY/xj0yIAKpI9fqGQSpi1bNtVr7AXW2FD6JMGC87LJ+Ye8zS1gbh9EmC3MF8AXXDjp9r3f 0Q5P4mXl+5JnoApRVLewMeV7pI9gPM/BUqvA2E2YYljl8G75R9h/JIH4xcmZnN7OS9vvHp68fB5 ocqX56ILa6yxlEgT6RPg8Mz0rjXk2m3+m4faO0APA0buhXsSAw8yTV+EZ/fyEYcJPJJoBQagIM3 zc5VloKxo9JGhycDLS1vGqNevr4YJv4r0/lKVIJV4ceUVw1BmlSf4ru6IuDBx/rsm1XrFnmtDOZ cJMKYvhqJPg1DNU3TVw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX3eOxaJEezhaF tXxDTeGhLNcx3I9yECTdI2wwMgMgGmao5h3cyrZrx7gR4WUqZa/ROOHCQ4a64BFMDKuJaHG2JrP ZpePruqMzc07Uf0EVTqhvseUp7KeRnY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_05,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030165 The DP83867 PHY has four distinct power supplies: VDDA2P5 -- 2.5V analog supply VDD1P0 -- 1.0V digital supply VDDA1P8 -- 1.8V analog supply VDDIO -- I/O supply, which can be 3.3V or 2.5V or 1.8V The DP83867E/IS/CS datasheet (section 8.3) describes two power supply configurations - "two-supply" and "three-supply". 1. Two-Supply Configuration: VDDA2P5 and VDD1P0 connected, and the VDDA1P8 pins are left unconnected. 2. Three-Supply Configuration: VDDA2P5, VDD1P0 and VDDA1P8 are all connected. VDDIO is a separate fourth supply present in both configurations. The datasheet specifies that it can either be 1.8V or 2.5V or 3.3V. Some embedded board design expose a GPIO-controlled regulator to control any one or more of these supplies. Therefore, document all four of the available supply properties. Signed-off-by: Mohd Ayaan Anwar --- Documentation/devicetree/bindings/net/ti,dp83867.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Docume= ntation/devicetree/bindings/net/ti,dp83867.yaml index 4bc1f98fd9fe51260b767b0a1b8b7eaf974a9af9..e78f08ded3d0d449ab75bf33d81= 4fd49587f8387 100644 --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml @@ -118,6 +118,20 @@ properties: Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h for applicable values. =20 + vdda-2p5-supply: + description: 2.5V analog supply (connected to the VDDA2P5 pins). + + vdd-1p0-supply: + description: 1.0V digital core supply (connected to the VDD1P0 pins). + + vdda-1p8-supply: + description: 1.8V analog supply (connected to the VDDA1P8 pins). + + vddio-supply: + description: | + I/O supply (connected to the VDDIO pins). The supply can be 1.8V, + 2.5V or 3.3V. + required: - reg =20 --=20 2.34.1 From nobody Sat Sep 26 07:17:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3943A3C109F for ; Thu, 3 Sep 2026 18:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461663; cv=none; b=gR0vHU0HZR87n+udCwUlYnHtkS7C7TXUQz9bjjqbrCnATYn6zWFm8EYO1v5+zaJ3Mpw00mqWq0UmvCDCiE+RmK8GViIUwag2hm7QseNsDX5OhtncSPeS0H/l5OaSeeR/Wp4yfbGhghbOJ0v6E4WC5xQgqyjbtNK6FZ2EnbifBLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461663; c=relaxed/simple; bh=eAeA03T9lPFg+lYkanID++2D7piJ+xmNgdrmLwHXhVs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eb6zctKlB0gKHQ5dcLdxDrsxigpyxwQrGrdc0JyIMAiiJ0uSBY0JvCE9GgEML7cYeqH0s2s/8T4W3Fysntkvino08la4suzMXqy/VlM+71dnHTWc3Ex9lEWpB/FtH+CtKYlI29wTfuwEaQYWUr3MLtVLy3xjARgfzPkleWL84wA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f271Zlaw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BtVYkpua; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f271Zlaw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BtVYkpua" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683G3VLf1430690 for ; Thu, 3 Sep 2026 18:54:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6PjFsoLdjz3lbAFz0S9PY2FNskMpGHLSA59veDz6yFE=; b=f271ZlawdDSjuap0 f7XPf6Ki7lvPqYiVXxJcFJZaYtOp4PpyH4r0rEdXUnuoBeHv9QqqaSWaK94iU5No vE+J6nViVtcHtUtWDjwyQhPTD/qmEdATcFnUE4HCVbDaj7keVWfcELOlJPkZUb1e Kh26+VqUtlmRaiLnKNoRFJd4wwLbnXwFBItByRGDDtB0uVF9PX8OzTNXZCAYmUDp g65rArQ15MVlEsxiA1aH/LeNpgJp1gZOUIzChso4W6i4R+AV0MjZm4PwMPgdiejY qDL1WpjzKIcZFxEnGMAYBTiYYOE6RLnoQR7yP4f4rTrLZmuXhujy+2X0OtAvhhey cJ8Epw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf1j4kkgf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 18:54:13 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-398dc3d8f0fso1549502a91.0 for ; Thu, 03 Sep 2026 11:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788461652; x=1789066452; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6PjFsoLdjz3lbAFz0S9PY2FNskMpGHLSA59veDz6yFE=; b=BtVYkpuarFNms9vNk20OEmfu93KtGNb0aLfnaz58xgJMVpSQp2sz5Anfa22EEvg9+m o0136QQX/H60e7xX6gzlUKXZ6BXlSpKNrxuP6jJp18dr86XwudVSqgt8tivKCUo4rvAH +yPhDw62QJCHGiN2XJhlg5LFQrZrjcVFm840/cM0jUBqpoaCjM+n9Tv7JLc85OU/wXet OSuOjouT7Tvt1EeJO0lvXM5PqFr7aC/CfAPwY5dZ2EO8QlTTI+AKIcUHDAqG6262MaYS fZ/o5TLGEkCck1gZz/cp9ATMvnt2UBVAbUKK1b5tj9Hd1YAwWN5ZXgpHPFCh1MLLeq6O iemA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788461652; x=1789066452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6PjFsoLdjz3lbAFz0S9PY2FNskMpGHLSA59veDz6yFE=; b=N0iFDrXtDInxf+O+PR6w6vxs8rLsHuXntumZFS2drAmPo7UTrKn2XzL41urYwQeXjw jjic/dYxUboNXZAdUv0W5Iug0zFUYfZjNi2+vTy4GKG4KFPpE+kw3bhwS1RfcwC07N2J /+gAHXqBuq1BvG4xk4pF+Fl1ob0pA6G+NrWHqqxLHCpi/SI3ofy/YowluGRltG/tl4IC uN7fNSBI9AmRZYBiYItpqWRs/ZLfoQJr1S7PX9T53sefU460dp9y+e2nbX75fiTYduKX cDLx9+/UiwOiBdhmzOAq9EzZ8wqYCyGw/a21DmZAhAqxoG9pU0L3ukLmdUsWakOU3hT0 ZFRA== X-Forwarded-Encrypted: i=1; AKwUvBxcDmxBg3iagkNZMz/UmzIGTHhVHT50AlaKo00noSoaR+EWqFQyNGvQC+sf5k+kZaLgwgfpC07hqY0XrCA=@vger.kernel.org X-Gm-Message-State: AFuF++ksAjxuG9XD8Pj54QCgh4ggnZF2hOK9lFbroqmQubDeLpkJkH7e hqyyYd9Lg0YROT17mGnvIL6CH4PD9jV4BWm2k9+FWouuCRXn2c/pfQQs7kYkvmfJAwUUj1xloDR TFCZLetdzKOKADRCFQuAL9JQKGyxBzbNEAoqXbIHeD4MpcRDDq87lNY6jplr8vpe4S2k= X-Gm-Gg: AYBFou02hDjrFydCbEHDUJnZ6+AWZJHaRLvwXLgkMS1hewARRNCiH+jRqtqr7ZOMGMI 6Qg1rEU6FYqODOcMdxm9YhvLxlz+ZTatG3Pc17q5v3bglG/6oZsvnmluOYU9p0coy2xH03NECkh upYVwYZcaYnnJPB4YaBOcSTxN2ul5iV0JjpZ/TeSVX7ilTrvmthncHCxTszF77AOMRtYi22tRnD Wbv92WhEp+jfIYLnYYYNBwqwfgUXX7vSSYkWMjQEWYJfXx2niMAWeRH2Vm6w7soqWFkBc87r2G4 NdwBEs2o3s/SEH/MrAbSXe8nwCRzmHLZq58ltgEffTxf7vE9bPj0T9ya8/FYKD0EHFUXXY7OejB YXDwNkQtidFSz2uVHjVB49ucHyzWayQ== X-Received: by 2002:a17:90a:ec84:b0:36b:b903:994 with SMTP id 98e67ed59e1d1-39b07f44dbdmr9549247a91.4.1788461652167; Thu, 03 Sep 2026 11:54:12 -0700 (PDT) X-Received: by 2002:a17:90a:ec84:b0:36b:b903:994 with SMTP id 98e67ed59e1d1-39b07f44dbdmr9549167a91.4.1788461651588; Thu, 03 Sep 2026 11:54:11 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339885ce1csm778829eec.4.2026.09.03.11.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 11:54:11 -0700 (PDT) From: Mohd Ayaan Anwar Date: Fri, 04 Sep 2026 00:13:44 +0530 Subject: [PATCH net-next 2/9] net: phy: dp83867: add regulator supply management Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-shikra_ethernet-v1-2-a50765996035@oss.qualcomm.com> References: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> In-Reply-To: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788461628; l=2110; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=eAeA03T9lPFg+lYkanID++2D7piJ+xmNgdrmLwHXhVs=; b=x8k+BJMfgeIA9V79xwFwkhli5rEq070Ry+6o3SC6wsTxHrrE03KNCKUMqPOPL/UC8NES8w1xv ZqcqjmRtXccCwCyJoxOyN2R3Cfk9wAMgmMAn1re8nimq1tozDzMfu+C X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Authority-Analysis: v=2.4 cv=dufrzVg4 c=1 sm=1 tr=0 ts=6a99c255 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=uuhe7hOpKvpPPjRdXc0A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: 8BUtHAEnifdS82hz-2rZgMidrLi4-gKj X-Proofpoint-ORIG-GUID: 8BUtHAEnifdS82hz-2rZgMidrLi4-gKj X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfXx9QaBejUggNw NW10GJ/EhR6WplhtfY77Sc/MJ2vrSZrJBX8X2dRlg6oTRWv2sAuFVSln72SYpRR45STUfP6ODi0 5VKtxovoRGneVpG+bflJzRUYtyHzrNo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfXx/oNUFS2mCdw 90v6iyPDEs0pmCbcp421R/e8FdUePeGmlpXYSybft8ubMtibQ44LrPDe/Azvw9Zr/Ndf1u7nkml ngvF+Li4eQcvyjUtQ6QWu2xBBmSPXPKXOj1fyMrsXqPUCn7ICbWjldt1sPdhQl0HZDiapes5MKh tyvdrq8Sfa+J1nXKXfreDc44vNhKpxkWXjvdckHCizqENabnuUTX4wSoPVCOhao4KGEBl66EmyG LFscjposLjLIBP1PLP5EEeG+P6YJ8xdK5Po0NQ+/h91tSIz7jVp+RHoHa8M/IEjq8pKKZVpUleq aXyxY9WMkGCCAZCVadt6ZeNB0JJnO5URbpnmrHgT6zTkiKOsKaWJsR8gsTxn/pBQY0tPAGUcTiH tn6ptd7vEuju83nRApZblQsFfr4+4iFi0Ew0wIW9Z8FN6TdKU41QNsENlQvYhu9xaduHm4Oh3ap mMKV9qBWJbCwPG+yv2Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_05,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030165 Some embedded board designs use GPIO-controlled regulators for the DP83867 power rails. Add dp83867_power_on() to enable all four supply domains at probe time. Absent supplies are silently skipped, so boards that do not describe them are unaffected. When any supply is newly enabled the driver sleeps for 200 ms before returning. This satisfies the post power-up stabilisation requirement mentioned in section 6.6 of the DP83867E/IS/CS datasheet. Signed-off-by: Mohd Ayaan Anwar --- drivers/net/phy/dp83867.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 88255e92b4cdbd6da2e2c1d10f9c72348d28dbc3..e03b39fd080d12afe0d02a53ffe= f2a6adf73cd9f 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -15,6 +15,7 @@ #include #include #include +#include =20 #include =20 @@ -719,9 +720,40 @@ static int dp83867_resume(struct phy_device *phydev) return 0; } =20 +static int dp83867_power_on(struct phy_device *phydev) +{ + static const char * const supply_names[] =3D { + "vdda-2p5", "vdd-1p0", "vdda-1p8", "vddio", + }; + struct device *dev =3D &phydev->mdio.dev; + u32 count =3D 0; + int i, ret; + + for (i =3D 0; i < ARRAY_SIZE(supply_names); i++) { + ret =3D devm_regulator_get_enable_optional(dev, supply_names[i]); + if (!ret) + count++; + else if (ret !=3D -ENODEV) + return dev_err_probe(dev, ret, + "failed to enable %s supply\n", + supply_names[i]); + } + + /* Datasheet section 6.6 suggests a 200ms post power-up stabilization */ + if (count) + fsleep(200000); + + return 0; +} + static int dp83867_probe(struct phy_device *phydev) { struct dp83867_private *dp83867; + int ret; + + ret =3D dp83867_power_on(phydev); + if (ret) + return ret; =20 dp83867 =3D devm_kzalloc(&phydev->mdio.dev, sizeof(*dp83867), GFP_KERNEL); --=20 2.34.1 From nobody Sat Sep 26 07:17:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6854E3BB115 for ; Thu, 3 Sep 2026 18:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461668; cv=none; b=Hog61ktFhvTMc4yRLppfDq4xOIII3E01qUzv1iuLlIu5vT5aIEiI8CEXn7A/8TGcaOWZSuydDtQc1W+FYMRRe1b/kv7yYIq1d+rlTmjRXtKu3eEo4E1yEpBzxc3wQc+sIODL3BrEohubyMnLurD7ik9P0ZeCeMnA71B/5YvjnxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461668; c=relaxed/simple; bh=1tqS6Dvk6HqdQruGW7WjMOOIlEWgJQuXPAL9e/OSA7c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mPnDrtFXK6ao7pC7MfVQh8ba2msvL9nTm14g29iy01ZYNmdWIpYTkRmKSafCrCbI6fFCZYs527HAKB9IBfYNN8vn53RoEYRvssIY5Jm7qnn4hADHkcK8x33mACZCOzL/MZqAtgilOiJzAQ5wHZrkpWz33c3ow4Y72upwxisgU/c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E313RZY4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JGkADowe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E313RZY4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JGkADowe" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683G3ctp1430962 for ; Thu, 3 Sep 2026 18:54:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kIQdmFx4PDOd5O9ixmJ7nfhs+TOQEPZyJ9aGwi2TRlY=; b=E313RZY4M8xF9E10 U6BrPtcvoIRnxtIOC+OX7G777UqJ1Y7bC/ZxTmQppLcTY0htJDiXZXhOyT8x+j5e /QE8/msIOVGDOq61VQ53RbZCzg6QaUFkwyGYwh9Q+5k6SP78UtbSxQU2FJj1bDMN SDM7OXjcrqyaxs2xFICbreLzaoFg0Qlwb4B4AJDkr4FXSKx02vMUqwIBXHmu1bcy wcSvnNHLvmavQn6VtFFthmarBQktRaygiQDW2BDhlfBXmOlj5NyfR8FUFQ0MY5hF LEP25+e1gbz/aCygEgEF/Wa/93yZsFvHX8Yj6nPYBhCX1DYhV3laHEVN+Y1UkxR3 BSICgA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf1j4kkh7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 18:54:21 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38e54b6556aso183620a91.2 for ; Thu, 03 Sep 2026 11:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788461660; x=1789066460; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kIQdmFx4PDOd5O9ixmJ7nfhs+TOQEPZyJ9aGwi2TRlY=; b=JGkADowejH6NCJxS1cjTbE2TZj7Mjyu4iyDrEJ7KcDfGx7X26dMp3T3eDmHRyo03q2 5mNV8bn3gpTWtlziFReoMTXolkPwHKcH6nWRCzqQM3g9Jn645Y5lacZFoCR3TgDgKi9R XhGC36kNKrM+mtzZLvpfwI+NO3RAcsVp+3OhJQLwt/7NPhNmshUGtSRjRusQjBIFbjfQ xq9PpMfcIhB0KQvNmrKZODetCZl9QzvaSDiHsE/f7fkyfxYEenN3J2PdaHybWO9clgfA eQ5Gn3EjQQYfIEBad3rCRB25y+is+jVt2rx71N7t7vSy4bNVbyHDAZ+ZTg163o9NEz5P NcPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788461660; x=1789066460; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kIQdmFx4PDOd5O9ixmJ7nfhs+TOQEPZyJ9aGwi2TRlY=; b=n3qVxPB5qY8JR1V6hc8Zz5Rdd0yvyM2mJqSx2R0mRiqi2c1HSyqhUKMM80sshfIR3/ QBhv3gcwy9SdCBZJn+0Hppi3V955EoL5WArtvfz+AosbCWilQITqBt7PFWf8UG4y7Jpm Z6/Mu8oTQR/3xlAxJF2NT+M17CY8TKe7Vekqw2ChgBFtY9jNV0csGe1poBYha0+Lkv8G AWY9zP6NVsB6x9OfUuaMhhEwP38it7PFRbhQrhSL9aTd2/zhr9Kx77L1dXAJrptyNj/w eOZ6eY9YqzhC9cQHqgb0D6vV3dP5FTRVnEDBa1snTmVrI/Q89MxlAqEvfzWU48IMcDiL J8Jw== X-Forwarded-Encrypted: i=1; AKwUvBzj4VaTFWUdtlDfwurOTumNKCevIIir2BAS/jzM6Uo1l/DPa93nTa62dFCZxoRrIwQAFppmdjLpO5EMc/M=@vger.kernel.org X-Gm-Message-State: AFuF++m1kadTqicyDhP7eMHHjAnz7PGfdP5cZN94ho9/idrSJlO6txa4 TVGJHlIKgYHEzB2rlrTb+19eYsE+x7N644XrE5iPR2AHIy8Lwt75oSmAT24iFQojU1mNDzsQxgr ewDzpdR4j7e8DzNXFjhsc0K0x00cJp8tXvNo7UMrUEWuznakA94n6sbzvftbAGQogIK8= X-Gm-Gg: AYBFou30xpSBIO2F9ac/vNTUbb91vtgF7F2mQQsAzVgxGbM75aOZ7vAcGmHW5Q3xtin jbt7AjpLiZxAow+0/jgA9dtA8Fp+EwSbVWWxglh6a8pGwjtG6Gn7mYt75gg/Z/JqkO7iweRdl7w TLB95Lw4RMPyDq3+BOMqzoqKe6kMpt5U0KnHpJwWZH/nYkz8krGEmxEf85DOelOtBNSqTOcgUKK m8eiUUEHNPcUnlT7kOFuz61E94Z70rLahUEZBK6yEhGj57Ij/LMwc3ci0iYSw2zCevE70nvaSC1 lT2GjU1M005wlGv+mI2dRVR4U3JnYVr2l7Z4nhTLXlT9EIGlrxzYOUQ8ISUzuL/qwXbZrYE3SRF orXUYqOAInA3H7EJ3fBpTXh9dHVllAQ== X-Received: by 2002:a17:90b:3d89:b0:396:5fce:8e24 with SMTP id 98e67ed59e1d1-39b260d2ea8mr821301a91.4.1788461659992; Thu, 03 Sep 2026 11:54:19 -0700 (PDT) X-Received: by 2002:a17:90b:3d89:b0:396:5fce:8e24 with SMTP id 98e67ed59e1d1-39b260d2ea8mr821208a91.4.1788461659491; Thu, 03 Sep 2026 11:54:19 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339885ce1csm778829eec.4.2026.09.03.11.54.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 11:54:19 -0700 (PDT) From: Mohd Ayaan Anwar Date: Fri, 04 Sep 2026 00:13:45 +0530 Subject: [PATCH net-next 3/9] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-shikra_ethernet-v1-3-a50765996035@oss.qualcomm.com> References: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> In-Reply-To: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788461628; l=3972; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=1tqS6Dvk6HqdQruGW7WjMOOIlEWgJQuXPAL9e/OSA7c=; b=uzzl30Innk14VtQSk9wQipDRrLbmYFSpW0vMYpn4cBqiZtNV4lHQqwUJ3zYEt9gFMIbtiq2Xc WtYNlxhoAu3Dui4ZaxT1Cs/tTxLtdD+4EBW3mDPTd6R8AqCrTDYCtsG X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Authority-Analysis: v=2.4 cv=dufrzVg4 c=1 sm=1 tr=0 ts=6a99c25d cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=DJPLBmofjJW9p3Fp6mMA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: Pqp6oUt1cUNnHDGKBw1rE5roPFcv6XH2 X-Proofpoint-ORIG-GUID: Pqp6oUt1cUNnHDGKBw1rE5roPFcv6XH2 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX3NQaM9O6uSBF v17UG1FFAYW0Uf9MUc5g06hC/7ivWBabkCXRTT4Xc+mFHJtepO1siEoYXBLGaEIVRjJ4PFeuJvX 5IinIrpKzI4WNoynKHs8YQqPKHGt/uY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX0qziUi9NWO2B Ader+9cyDQM9IqKTHbYoLfsdxTheQKp7bKYqnm0xAWBBMnZrAAQASJaadD4P7rZgA1fi3khkm48 OtUIaUDWl8SAkBbG+ZRVA/ngfGvutnFpzlcEG/JH8NP5ZGmRMF/RdubFJq6UWZkhFVq6nZdZ6EK etlZmzni/wvwSKDxJiP/rxAX5P3MqNufC78IBRnS5JzsAGguj1YYkcQMGTkv7EKp9BwIGd6NmUR GEcFWXkoZNfe7M/Bm7pSuK5G46M42UZLqvefyUeJwcUsSkKCyqbysZrvVqet4LH61gtV5M6k4Ul NvvMp9Sg+uvHopOP/oRG1mcOCgvIu5Es5PZJIIlYJZYL2IgUB5UhMSbMt5+RufQ8Dj76RCsVMiX TnVQFDy2MENYoG+Fs9zO54Iojo+8WEaJvSdXdtxOwK21T+zHGHP+FZyQdFx3Jw4WMunnxkFuTVy PMx6a/RAy/6QzDLVcZw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_05,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030165 Shikra's EMAC requires two additional clocks for NOC interconnect access (axi-noc, pcie-tile-axi-noc) beyond the standard four, and an OPP table with required-opps to vote VDD_CX to SVS when the NOC clocks are enabled. Add qcom,shikra-ethqos to the compatible enum and use an if/else block to constrain Shikra to exactly six clocks and require operating-points-v2, while leaving existing compatibles unchanged. Add the relevant compatible to the binding document for snps,dwmac as well. Signed-off-by: Mohd Ayaan Anwar --- .../devicetree/bindings/net/qcom,ethqos.yaml | 50 ++++++++++++++++++= ++-- .../devicetree/bindings/net/snps,dwmac.yaml | 2 + 2 files changed, 48 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Docum= entation/devicetree/bindings/net/qcom,ethqos.yaml index 423959cb928d945aa3e758a3c803d12bd61ec42b..ad2cc706fa74041486cd90c3d0e= b1dde0acaa27c 100644 --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml @@ -14,9 +14,6 @@ description: dwmmac based Qualcomm ethernet devices which support Gigabit ethernet (version v2.3.0 and onwards). =20 -allOf: - - $ref: snps,dwmac.yaml# - properties: compatible: oneOf: @@ -32,6 +29,7 @@ properties: - qcom,qcs404-ethqos - qcom,sa8775p-ethqos - qcom,sc8280xp-ethqos + - qcom,shikra-ethqos - qcom,sm8150-ethqos =20 reg: @@ -57,9 +55,11 @@ properties: - const: sfty =20 clocks: - maxItems: 4 + minItems: 4 + maxItems: 6 =20 clock-names: + minItems: 4 items: - const: stmmaceth - const: pclk @@ -67,6 +67,8 @@ properties: - enum: - rgmii - phyaux + - const: axi-noc + - const: pcie-tile-axi-noc =20 iommus: maxItems: 1 @@ -81,6 +83,11 @@ properties: - const: cpu-mac - const: mac-mem =20 + operating-points-v2: true + + opp-table: + type: object + phys: true =20 phy-names: @@ -92,6 +99,41 @@ required: - clock-names - reg-names =20 +allOf: + - $ref: snps,dwmac.yaml# + + - if: + properties: + compatible: + contains: + const: qcom,shikra-ethqos + then: + properties: + clocks: + minItems: 6 + clock-names: + items: + - const: stmmaceth + - const: pclk + - const: ptp_ref + - const: rgmii + - const: axi-noc + - const: pcie-tile-axi-noc + required: + - operating-points-v2 + else: + properties: + clocks: + maxItems: 4 + clock-names: + items: + - const: stmmaceth + - const: pclk + - const: ptp_ref + - enum: + - rgmii + - phyaux + unevaluatedProperties: false =20 examples: diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Docume= ntation/devicetree/bindings/net/snps,dwmac.yaml index 2449311c6d28ed3fbf8c92526ce8b872900653f4..6a1aea371c0b42ef71f90d89276= e15159c3b3277 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -74,6 +74,7 @@ properties: - qcom,qcs404-ethqos - qcom,sa8775p-ethqos - qcom,sc8280xp-ethqos + - qcom,shikra-ethqos - qcom,sm8150-ethqos - renesas,r9a06g032-gmac - renesas,r9a08g046-gbeth @@ -632,6 +633,7 @@ allOf: - qcom,qcs404-ethqos - qcom,sa8775p-ethqos - qcom,sc8280xp-ethqos + - qcom,shikra-ethqos - qcom,sm8150-ethqos - snps,dwmac-4.00 - snps,dwmac-4.10a --=20 2.34.1 From nobody Sat Sep 26 07:17:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4CF3CC324 for ; Thu, 3 Sep 2026 18:54:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461677; cv=none; b=RowZzIIWVn2hlrGEHke0YNs4+rs3LQ7ThNZ3ZunB9XPpIM8nmZQVFdsvtS9gjE0P95FxblW8OgW0oUjZGOr4DwfC/2W3L/uJws1WoLrc2A2iwQi/A52VoS+dNLgIMkYU8FQaQBarQ2wV4dp6zOu9nWFoevPUoli3zTZf6ybtJLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461677; c=relaxed/simple; bh=5Xufs5yzw1meBpR74gkzyGtdf0gQ2cokHnunZolJSUI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Uaaw+OlwuG1vjVib4OQr8m5tGsBkUJ3RLxbAoWsZpbMp0qUOQIkzjCqmbgqDCKQdiOB+Ss5rtIrFURJRUsUYLXDaVh3BaADZ5w43vBRpkRBgPIkR9O8qWwTHWBtfBQlZmb4x9qPTXtc3XoK7nZiz9fvPoG5rEsQ2ZM1Ofkbl9f0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RF7LQViK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f09l+PxV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RF7LQViK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f09l+PxV" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683G3e6M1431142 for ; Thu, 3 Sep 2026 18:54:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qRtbCsR0snrc4ZRT7ffxk7qmv5fRPo5gJPF6TrEgdgg=; b=RF7LQViKx/h/cYdv SHckR1mhFiuUegvn26a0UMfpuI83lVwa1rms8Z9Nsya/OLlBj0WjJxfBXkTg0wiw SU2N/LjYm0RL5Lc+FuIvKmLYq+RyGzBw05c2VygbOD2qe2FU40BP2rfhk4fgmyeI KaGhYnT9UbdNI10/Eu1Ivsy09qsiclYl6RE1Z/O1gA0d7o/6LTUF51e1hUm6eAtn oa0YzdAw195VQnmU64L3GrbqwvVXROJD839nhtwaqEMjPviNAS+LMrjQpVwr6xih vzxgwJh9rV5Vyis4C9qlpAXBgZaaE81PccemcoXmKMZmw8GK2yh0bdRdBJAB6cWC CHXL5Q== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf1j4kkj0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 18:54:29 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-396901263b6so202864a91.2 for ; Thu, 03 Sep 2026 11:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788461668; x=1789066468; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qRtbCsR0snrc4ZRT7ffxk7qmv5fRPo5gJPF6TrEgdgg=; b=f09l+PxV7JoCdnvhjoNncOgayTMlA5GqW9EbKaY14xPWWGHY5B7REu0Be6HJaagVq+ PBBwyAHZNrXKJDUjepSs/CN1jUF3o1L5V7wWfrR8TBKPT/57+7i4mGF2WzUS6VNDqSjc Kie6ktM/Wz0J6hjfUiLi6yCt03U+mg6RZmxMTwXRv7afMYyGwicszhtSxlL0JDU5VY7a kea/z8P5AdItDoA4GyhROWuMZg7WvVA6L17PGjko46HcVBO5Bpuqri+8AT64TNrTAMAU 4JllorhH2k0cZjuzZoRsNhk0wvkMMD3zy8rPVSJiSx/etxjNlEPNQK0YuJy2tAVnJ7Nw 5s8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788461668; x=1789066468; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qRtbCsR0snrc4ZRT7ffxk7qmv5fRPo5gJPF6TrEgdgg=; b=nuqC01HkvB47q4ubwgI/5XOmZUWgLBAsPKMT/5HB9CmwkkbDE0ndtLBdebVkjcoMRs plfOnjd6uFHdeDFTfXrcPVGS17fV5rjkNt1DM8wXIzUyqEmmpmY+tgHKhsqdxirhxEWb ycBNuVmqC3+BUNT4H06lsneIBRB1wVnQyMlLsZRYEJbo3oKqVeB7cMyosU3QwD6bp2Zv 7j1U44YAv1YXaqle2PdNMAduNDfwZUA4RZBUH1gVT6uuosoVTwJy/1CQ8aCzfQO57yGB kZjiELm/tJewdLHOhK/fXMUcPoPIUuA5WCex8uTIPSWUWj7IAHO1IbO9bvjkrUeYpQob nCQg== X-Forwarded-Encrypted: i=1; AKwUvBzO8hwRf6Is7unbSD0hZZvP+FP5lB/kaZMGGemAS9lGvb6Q9CoAUioOxcT/qYKiA7jvm3Oo36Q5L4aSKm0=@vger.kernel.org X-Gm-Message-State: AFuF++kE9u3NjKgkc7JdGEmy4dQ5SWD7X4GuOlx9i+gFkHuRmV2NrNhm wRv+Ycoxs7oQBjRXf4hr+NkKk/9VBvy0PAS50JlosldpxpQdH7u3ED6pO1twuEhBqXogX7h4zqW EQksAbTARI3lXHExFo5ztzt8dXjcAOtNSQHeSPDrIvlNoY6oTZ5RvmPD7loNjt+EsUh8= X-Gm-Gg: AYBFou2JIz/EeAMNepQBOUvTqdiytj3KHgqwa3X/XBwPcwD54qrDiC1pL7HuVK9qZ+5 pUoueE+EAVV7cVnUvQlBfFoVwhzJsATFqxyyCaf8lf89GzFY4Lc1Vxj9hEMseC+Durl4fbfMNGk 6qeH9GMm4j2uxNTAqahc64LyKdW4NFrDEKnraN9jAI0DD9/hASZZr/0Pm4d/GMjbA2Jv799zbli zra+USbhthgtZmkiw0coGmLjCsoGjUSgAPLUmBENy34Df5o4R02eUmEfLeLF70o4rkq/MGUBJmS Dl8IKZkF56SM951jfHu/ms5P2GS0VhZx8T3JgEwA9krwZe0ItGeHpgN33Wg+wiBMYlcUUL9F39W VgUyCWp7IvJTm072GuTlEaEwjV/dsLA== X-Received: by 2002:a17:90b:4a48:b0:381:6c5:3f63 with SMTP id 98e67ed59e1d1-39b260d2d58mr725691a91.6.1788461667846; Thu, 03 Sep 2026 11:54:27 -0700 (PDT) X-Received: by 2002:a17:90b:4a48:b0:381:6c5:3f63 with SMTP id 98e67ed59e1d1-39b260d2d58mr725630a91.6.1788461667387; Thu, 03 Sep 2026 11:54:27 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339885ce1csm778829eec.4.2026.09.03.11.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 11:54:26 -0700 (PDT) From: Mohd Ayaan Anwar Date: Fri, 04 Sep 2026 00:13:46 +0530 Subject: [PATCH net-next 4/9] net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-shikra_ethernet-v1-4-a50765996035@oss.qualcomm.com> References: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> In-Reply-To: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788461628; l=1852; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=5Xufs5yzw1meBpR74gkzyGtdf0gQ2cokHnunZolJSUI=; b=eVFEzweOdFMUDglLnNWnuYLxu4C0abjkapXwb7fyuoQ4PkeZeApXpsh5hAGeFCRUiHhYQuDpy fHZY6wwVX4lDYrfI5Eqfjlapel1JYhXvDvXf+yBhUAD3eN9YSuBvjCW X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Authority-Analysis: v=2.4 cv=dufrzVg4 c=1 sm=1 tr=0 ts=6a99c265 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=K6GgjFCvg-rKmMkbl2QA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: xQyfE3mNZHAJ5MJ_35Rc3arIjvA4JAi_ X-Proofpoint-ORIG-GUID: xQyfE3mNZHAJ5MJ_35Rc3arIjvA4JAi_ X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX5a0YlIBQmVsk 94tOoVhoCeex0BNgxcT9jBw58anwPYCXwZfswlRUZNHdgPlMv1FoJ+X1sTOBBufI0N4QX5/vb9H yUQAV2nO5HdTaNunuXG1wyAvEpTzbn0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX+Jtf1BYo0pXQ KK5r3R1lOUXjTEh/ftlc1x/BBKSW/cPEJXqUgne8+5l9HI/K/TGl7WeXEY6AWJBBV3BzHesxLUy VVOp12ul5M70i05YjzUiYj3ob/vHrHUMm9T9j5LP6dU6+zRyDHFgl7mOXRdixKbWpAOiY2Opesb sj0aufGuvoHPBRnJYy5z31i7r9AeM8VfHJqf/oQaDAfuuZMRlpAIwB+2CQPmgDSqWeyWEZ29LyF jfiOgE7NEGaVLHtsZx4JYulQWBX0J/8bTSBOB3cuvFt7LL28i+v8JqP9xVD3z8OI8DtPvA9kZyC XmN1y3QgH04gtw8SU/5GFMXqL6C6xUnBHASuTvCudKvQyf8MqEgH1tvq0vqhcVloWvk+yGDzaPp zbCK+w46XWMfOvJzmbJYZuHlRJVnm8g9b5uTGBsTOnBWqUJYJlz3stU/mfCh9Ado2cvcejoFMc/ BqtxakKloHpcch8EUMQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_05,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030165 The return value is never checked by its sole caller and the speed validation duplicates a check higher up the call stack. Convert to void and remove the dead code. Signed-off-by: Mohd Ayaan Anwar Reviewed-by: Maxime Chevallier --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index ac7d6d3e205a1ab5b391def879d6f1033a0961b6..44270c25d874f72e7f971757fec= 659d36468c315 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -371,9 +371,8 @@ static int ethqos_dll_configure(struct qcom_ethqos *eth= qos) return 0; } =20 -static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) +static void ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) { - struct device *dev =3D ðqos->pdev->dev; unsigned int prg_rclk_dly, loopback; unsigned int phase_shift; =20 @@ -384,11 +383,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos = *ethqos, int speed) /* Select RGMII, write 0 to interface select */ rgmii_clrmask(ethqos, RGMII_CONFIG_INTF_SEL, RGMII_IO_MACRO_CONFIG); =20 - if (speed !=3D SPEED_1000 && speed !=3D SPEED_100 && speed !=3D SPEED_10)= { - dev_err(dev, "Invalid speed %d\n", speed); - return -EINVAL; - } - rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE, RGMII_IO_MACRO_CONFIG); =20 if (speed =3D=3D SPEED_1000) { @@ -479,8 +473,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *= ethqos, int speed) =20 rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, loopback, RGMII_IO_MACRO_CONFIG); - - return 0; } =20 static void ethqos_fix_mac_speed_rgmii(void *bsp_priv, --=20 2.34.1 From nobody Sat Sep 26 07:17:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3146E3546FF for ; Thu, 3 Sep 2026 18:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461692; cv=none; b=c6yPiSqA7ekTe/FBFWSLCRHPCwVo93smO/UiON2LTKEm4dFAZVno8OKmwk9hJaWWbfXKt+wlwclwExaE0DYBFbiNOWCLmV+HjIXp1p0zW/NyZrzczlUs2LuXR1VJwVuXu+C0XG9PjYuYsyupFzOoB1Y3ezH471RlPhxYhU1II3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461692; c=relaxed/simple; bh=oPIOV+gVLaskH06k2h0yfpHO+z9xupXJmiUCrslRjTc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eAK4XCl32wfwPj6PR+BJVUZ1mXNAms9qvznql3WTNVECvBahOEWtImCHmQcvNMk/FUZMmDZxoiGtsvAcuiWnReX7nAPRBcX/SBJFDCotwy1gt/zUrwyw9R8aqVuywdYgeJglP/az7N+t7vBzDhuq2PCGPcAxpxaTWtbiMalwisk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SOVT39CT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VAQ8X3Aw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SOVT39CT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VAQ8X3Aw" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683G3fGO1209697 for ; Thu, 3 Sep 2026 18:54:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CMUpW6p9PAs/kdnPc2ogQtTbd49AApNHpaOy6dca8j4=; b=SOVT39CTaHfspJNN T0Xwf9QKRY7cTVbR/hYBMXr0mA37ZqoNFCi2Yx2roa+ltesTIreKH5oequXd87e/ 8H+0NjFxNRpUqaYAU7WAXe/77IUrWPH6Zqo8xhZVXHgdTpIUa97Zh9QOxVKNeyrL 5zSp7WvHzt72FKP1ut8nQ+Se3KWQ6oynA7vudhhz3h1E20Ngo2fbcZG0z72DDUKe 0/zahxl8j7PCxomsLjrthRPXTqsaJf/RG/HyrxEJQBJ01RhOyIixY2bczMMgM2PU 72rvn3Wyr9QnxJC+xGkh2Fy0xM4/4U67AnZJ+s/lnE/6UMj3+O2ZmWVhndCuHV5j di7uag== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf6p72e56-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 18:54:36 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-396901263b6so203124a91.2 for ; Thu, 03 Sep 2026 11:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788461676; x=1789066476; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CMUpW6p9PAs/kdnPc2ogQtTbd49AApNHpaOy6dca8j4=; b=VAQ8X3AwhA63OB0YF5KLx+mcgaxmqBxejuWC0v8HmiBcmlFzgSle2Rr2YPd3gVCxF/ I6EuHTFJJt0O07BjAUURfmrNcg1yOoF8Yyi/5YZEqf+ZnCj1D4K4oqhuK6Pe+/HLIMBV m6zdOi5TfCodtI15oi5Yn4igwn5noB8D3muR591jhdGo8JgzLYe03Vsh5FH3s4CirNse YaVQrJwWFWK+KDTUogNO7CPaOF7SqdZip26XrYsGUB4w9FpKWaCOap3bkCieJO6nuUoW 6wHzQFvEPxafRvTioy4ofJrO27cKqWeYQyQszMWIICxAZ0J2Kf14oIZCwLn7hR+1fxOG 5izA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788461676; x=1789066476; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CMUpW6p9PAs/kdnPc2ogQtTbd49AApNHpaOy6dca8j4=; b=lq/to5E7qKgTJdZcHmqXB0MZBZRoDLgwXYiIurkw3zoWqr/VkAAgKejouq3S00wGhM jVQTNu9dw/NeM6zdgquYlpn796RH2BmAymIckbiZWFIiPymmJ5R9YJOmB+wbEl4dZEm3 xOwTDgQiS3+bFs6xNkx4gAiJVMGDStLhjEnU/2AqMlIR641enecy2WiLrUPLFQMuEYQ9 bFvLiyA1J5hgAad3X8wIUd1l44qFjHIwXRhVzNClQGzyMXzd8zFQIzToi8hftpOlHr0p SKiOasqp6HL+Ug+V0DYmj6CnAA2i/qNNhbSeEuhL60P+Wornlfu2L+S69oHzMAarnHAo IdDg== X-Forwarded-Encrypted: i=1; AKwUvByB0Nc1Wjvq8NQ3DjBq+zsl2ZJMOwV74cB3TG0MdjI0bKC51cDeyTIIe7mPPsJn55RoSZbMXfu4WUZ2YMI=@vger.kernel.org X-Gm-Message-State: AFuF++lLMnvpE5jNxf/C3yjI2ZrqkOn5HRnFCNDCCP4t15BJAzuXvTAS HeY1uCi8maJezK1WtnDS6lSK8cSS2yfwQ/wIssOiQ8kwcgyePjgOET+0m7CcCL3LBb1r+WtWNDI 3IHmzc3nbIjsrYCzaucUbnoIEhjKcZAZWYe70kcFENbJ1V1dRxglky6mxZxpdT50vEMk= X-Gm-Gg: AYBFou03v/4zhy5Z61yrWW4rmhTLXCqGvjzyoQTTHGDOaYA54cwtN3uieKqBUDcHrhc qYzLYH9+FWQne4m7t2UaAFILHZlalXzDMIJZI4r9+vxB6BtvHaZDyRG72nbX9Y68QQiuKT14TfO SraoOSxfWp5vor7cir2WyvsJiBNgEzhLguQ7DGwcALB8aW4e9VZiax0UwRRtfpUbqixrHBJuHZE Lnk82mOEUpIuvLmazCcBOThwK8YfAuc3xyiFax0k833k4qUoSxTYiD8cRxDLWJU/cCWTdLbmoU9 I1vc8pp0u9W0RenOEoHE2mnlSn4C+BQP1VpjvhzueZjvFSvD1zbmE1u95EYgRChTf0twG/X0nk4 09qkjEDyduIPKKBadpNV+lVjsgEBxqw== X-Received: by 2002:a17:90b:51c7:b0:398:e73e:5a0c with SMTP id 98e67ed59e1d1-39b2609f34bmr937531a91.1.1788461675691; Thu, 03 Sep 2026 11:54:35 -0700 (PDT) X-Received: by 2002:a17:90b:51c7:b0:398:e73e:5a0c with SMTP id 98e67ed59e1d1-39b2609f34bmr937450a91.1.1788461675090; Thu, 03 Sep 2026 11:54:35 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339885ce1csm778829eec.4.2026.09.03.11.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 11:54:34 -0700 (PDT) From: Mohd Ayaan Anwar Date: Fri, 04 Sep 2026 00:13:47 +0530 Subject: [PATCH net-next 5/9] net: stmmac: qcom-ethqos: fix RGMII_ID mode to use DLL bypass Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-shikra_ethernet-v1-5-a50765996035@oss.qualcomm.com> References: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> In-Reply-To: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788461628; l=4880; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=oPIOV+gVLaskH06k2h0yfpHO+z9xupXJmiUCrslRjTc=; b=sRHi8BoPgbISk0KgC4JVIGsrHJ+lg5f/DF9tLeSaANkxWpr2474ufayQ5HWVVmUWbphyvASaL lMGakYLTTy4BLwe+7HrABFpLsuTJ22zRFKGrMtVA2WdExt1i5a56LXF X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-GUID: eFtZAVcgb5nQz8M7Tl5gFg9CnVtsxwCA X-Proofpoint-ORIG-GUID: eFtZAVcgb5nQz8M7Tl5gFg9CnVtsxwCA X-Authority-Analysis: v=2.4 cv=OZyoyBTY c=1 sm=1 tr=0 ts=6a99c26c cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=ctJ5fWpjfrpFC8ASC0YA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfXznlo7Eyk1tj8 1wSR7UUAukws+Q7j1WsKH3M6JyI91x7WPmwIXBsS74B2N3t+ZahTKV1OTT3orkwAoc9ThBAh36l BtcYc5EoMWCaoYHSFTBV2LN3Ob+1aE0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX3T/8WifxthQL JNJBT8UxcWVQ2Mb4RqAfxyYy8B75zJXt685fFn5ljOjNn9hqg/taUBjbilO0qBIodIGtR6kZMTQ tE1wr8UfIVDncSCna1XYvGsOOvqgiXzjTJo2smttaFqv8ax4k2Ocxcxnd+qA/czcH3TM0XsEaNl pSSZuMMPrylzECjMMcaexThg/jnFmjq183NO6+Z1Yuw7MWT36G7uRxNaSpfUM2tDSjKVz7gG4Kz BXcqI3Zwp7SwZXqzSZNLv0BIBiv1ErHE3PHopxEzbphUP70X9+N/KqdmNZ9f4dbBprSIhLDkbw3 xF/xWNYL2EXsBsRyYiJSMPstAZ59NugDd6bntiM0AUzDZ2gLzCx03o+5egzBnsRDcLWRxiG5M/i xN2U2nOz57LHjAJLO1E0dEIagdJSiw/0razJBg42Z72SBKojjEb+qPUUsfsq4r5KoTx8ZuYhWSo xT5JQkKr01IqkCVWSKA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_05,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 impostorscore=0 clxscore=1015 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030165 When "rgmii-id" is selected the PHY supplies both TX and RX delays, so the MAC must not add its own. The driver currently falls through to the generic DLL initialisation path which programs it to add a delay. Power down the DLL and set DDR bypass mode for RGMII_ID, then program the IO_MACRO via a new ethqos_rgmii_id_macro_init() helper. Also fix ethqos_set_clk_tx_rate() to not double the clock rate in bypass mode at 100M/10M, and remove RGMII_ID from the phase-shift suppression in ethqos_rgmii_macro_init() since RGMII_ID no longer reaches that path. Signed-off-by: Mohd Ayaan Anwar --- .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 67 ++++++++++++++++++= +++- 1 file changed, 64 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 44270c25d874f72e7f971757fec659d36468c315..67738c1598c50ade22f2d548a6d= 66911c348af51 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -67,6 +67,9 @@ /* SDC4_STATUS bits */ #define SDC4_STATUS_DLL_LOCK BIT(7) =20 +/* SDCC_USR_CTL bits */ +#define SDCC_USR_CTL_DDR_BYPASS BIT(30) + /* RGMII_IO_MACRO_CONFIG2 fields */ #define RGMII_CONFIG2_RSVD_CONFIG15 GENMASK(31, 17) #define RGMII_CONFIG2_RGMII_CLK_SEL_CFG BIT(16) @@ -183,7 +186,15 @@ static int ethqos_set_clk_tx_rate(void *bsp_priv, stru= ct clk *clk_tx_i, if (rate < 0) return rate; =20 - return clk_set_rate(ethqos->link_clk, rate * 2); + /* Clock Rate Requirements: + * MAC added delay: 250/50/5 Mhz for 1G/100M/10M + * No MAC delay (DLL bypass): 250/25/2.5 Mhz for 1G/100M/10M + */ + if (ethqos->phy_mode =3D=3D PHY_INTERFACE_MODE_RGMII || + speed =3D=3D SPEED_1000) + rate *=3D 2; + + return clk_set_rate(ethqos->link_clk, rate); } =20 static void @@ -405,8 +416,7 @@ static void ethqos_rgmii_macro_init(struct qcom_ethqos = *ethqos, int speed) RGMII_IO_MACRO_CONFIG2); =20 /* Determine if the PHY adds a 2 ns TX delay or the MAC handles it */ - if (ethqos->phy_mode =3D=3D PHY_INTERFACE_MODE_RGMII_ID || - ethqos->phy_mode =3D=3D PHY_INTERFACE_MODE_RGMII_TXID) + if (ethqos->phy_mode =3D=3D PHY_INTERFACE_MODE_RGMII_TXID) phase_shift =3D 0; else phase_shift =3D RGMII_CONFIG2_TX_CLK_PHASE_SHIFT_EN; @@ -475,6 +485,42 @@ static void ethqos_rgmii_macro_init(struct qcom_ethqos= *ethqos, int speed) RGMII_IO_MACRO_CONFIG); } =20 +static void ethqos_rgmii_id_macro_init(struct qcom_ethqos *ethqos, int spe= ed) +{ + rgmii_clrmask(ethqos, RGMII_CONFIG2_TX_TO_RX_LOOPBACK_EN, + RGMII_IO_MACRO_CONFIG2); + + if (speed =3D=3D SPEED_1000) + rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE, RGMII_IO_MACRO_CONFIG); + else + rgmii_clrmask(ethqos, RGMII_CONFIG_DDR_MODE, RGMII_IO_MACRO_CONFIG); + rgmii_setmask(ethqos, RGMII_CONFIG_BYPASS_TX_ID_EN, RGMII_IO_MACRO_CONFIG= ); + rgmii_clrmask(ethqos, RGMII_CONFIG_POS_NEG_DATA_SEL, RGMII_IO_MACRO_CONFI= G); + rgmii_clrmask(ethqos, RGMII_CONFIG_PROG_SWAP, RGMII_IO_MACRO_CONFIG); + + if (ethqos->has_emac_ge_3) + rgmii_clrmask(ethqos, RGMII_CONFIG2_DATA_DIVIDE_CLK_SEL, + RGMII_IO_MACRO_CONFIG2); + else + rgmii_setmask(ethqos, RGMII_CONFIG2_DATA_DIVIDE_CLK_SEL, + RGMII_IO_MACRO_CONFIG2); + + rgmii_clrmask(ethqos, RGMII_CONFIG2_TX_CLK_PHASE_SHIFT_EN, + RGMII_IO_MACRO_CONFIG2); + + if (speed =3D=3D SPEED_1000) + rgmii_clrmask(ethqos, RGMII_CONFIG2_RSVD_CONFIG15, RGMII_IO_MACRO_CONFIG= 2); + else + rgmii_setmask(ethqos, RGMII_CONFIG2_RSVD_CONFIG15, RGMII_IO_MACRO_CONFIG= 2); + + if (ethqos->rgmii_config_loopback_en) + rgmii_setmask(ethqos, RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + else + rgmii_clrmask(ethqos, RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + + rgmii_setmask(ethqos, RGMII_CONFIG2_RX_PROG_SWAP, RGMII_IO_MACRO_CONFIG2); +} + static void ethqos_fix_mac_speed_rgmii(void *bsp_priv, phy_interface_t interface, int speed, unsigned int mode) @@ -493,6 +539,21 @@ static void ethqos_fix_mac_speed_rgmii(void *bsp_priv, =20 ethqos_set_func_clk_en(ethqos); =20 + /* For rgmii-id mode, the PHY should add the required delays. + * Therefore, power down the DLL and program it in bypass mode. + * Program the IO_MACRO as per the settings recommended by the + * programming guide for bypass mode. This will ensure that the + * MAC core doesn't add any additional delays. + */ + if (ethqos->phy_mode =3D=3D PHY_INTERFACE_MODE_RGMII_ID) { + rgmii_setmask(ethqos, SDCC_DLL_CONFIG_PDN, SDCC_HC_REG_DLL_CONFIG); + rgmii_setmask(ethqos, SDCC_USR_CTL_DDR_BYPASS, SDCC_USR_CTL); + + ethqos_rgmii_id_macro_init(ethqos, speed); + + return; + } + /* Initialize the DLL first */ =20 /* Set DLL_RST */ --=20 2.34.1 From nobody Sat Sep 26 07:17:02 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 029373C872B for ; Thu, 3 Sep 2026 18:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461697; cv=none; b=r3AZ0yfNqJHCiCa5qLHbs/HAG8UCgTAy7ayPUuAdTE+BLQnqwNEnGSQI2IEW8bwH3v7qqmOmo75TKGoCAm2Q54EGBO3S6K3Cx0V7BPE8StENeQoc9m4GF8a7lhcdZ5iP4LaB2Gp8j1iYyePyTKxXJbShG3Ln4+btENwxB875QKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461697; c=relaxed/simple; bh=K+J5JXbqYwK3TUxpCoU6dPlVnyBExv1tcHHZpJs6rIE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lF9KFjBR1ozZeotL57gDUIpmakoQiptRQV+lbSfJsZCw2B2SEzs3wLn3EB0TjqEvituIzHTnPgAeZbftYJYbDIpVmVzQsK0incrgCqCRgVOeNx6TlDv9ON1y3DYILQRsOOoYH5AvkFwJJCa1D9HwZNjdSfVl4BLKI4rC0SfAgpw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LDxQXeGl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ob7Ifg0m; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LDxQXeGl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ob7Ifg0m" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683G36Ew2088737 for ; Thu, 3 Sep 2026 18:54:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3fb9YsdSg+DwmlZQq76W2/Ut2yqDfurujMD1jRY9bls=; b=LDxQXeGlbB+zParA 4JxeTWgUg4obq59z2T9jEIaY3sJqLOVnjcOZ5op30LxQgwucPzpW7H6GqETZJ4Nq V/RMxDDvTzTuINKMeFSWBzRs8fQUDiJUxt/T9310441FBwZfVZCoe5joc70zRfbW 7OAVPgp6wGQDLsygXQpX1eDQwHazn3JiK8MPOllZhyt8PkFoAD35JF3cDm7/zqlP FGQpNXbFxOVzz0xoG6uYMKBBSNEGZuH+2BN4CBSjbCIKzp4fa+lmQBLS3hOEyseR qiM65+SBwSRYgUBgBNrFseN2Sa0sFg+IWnjSf22omtTmaBIG+wfOIfyVKs3uDPQ6 yplvAQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf9b19r1g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 18:54:43 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38f5ac7416eso140862a91.3 for ; Thu, 03 Sep 2026 11:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788461683; x=1789066483; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3fb9YsdSg+DwmlZQq76W2/Ut2yqDfurujMD1jRY9bls=; b=Ob7Ifg0m5OCuZgMuEyx8JT7urnNM33jwjDd6DeVn53pIobfw2jU2sZbhd78n8BUp1T adz7VgVLpcBVIl5dOzKtCqm4bhPjdlZSLNf3hNh79pcft7so426N0jb4weeQDYB/wpe7 U7MmL+PY1hEK+0Cf334q21vjRNGfqR2ZpQ8xcylqH9hCFG27n9xb73tb0CN6jSCpvD2i PHWKkhnpx0cwAUYOFhXHuHgl7gDARePSHX9kc4MP5kWs/oJ5ixvWQlk8HNW5vQAMNFK1 +gbEjUJ4eeHomjzs0tU/Q03NJU8+VaPmt8MqdiT0qdNKaLajAziTJuordS+C2NaAdw/W MbzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788461683; x=1789066483; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3fb9YsdSg+DwmlZQq76W2/Ut2yqDfurujMD1jRY9bls=; b=OW1jkqiKCIkwM5VvimvNAK1b6wbemtSS79MVX7iAugS9vSUyxMr96/4ykdAn7WomU2 aORCy1nSxOmHiNXJGPgthAWCz6Aq49Rn00U4/eYIVifOL8Wfx3lG8dbSK67Mjm+ihkMt wYT3AnOYjxpNLxtJAQQuuiL1UrRmetnhjWXwu7SRRQ/LZLYCC9/5I1JLjprhW7Mo4N47 qnRKbxzZHXpd45OZzTfpZQbBAWujkT5XQka7XAW+oRwugGSY9jNBtVGlG/G5aAiyQtq1 9uiBXdIMkLA9XfA9+00LQGZIruMsVakRPANp+SxvZRqr1UFW18TPCAWD8BzO9+aaqjYj +8Gg== X-Forwarded-Encrypted: i=1; AKwUvByQBjUCS9RbJy2cQ6yejfxIvZhQS7e88e3INgGxyKWMXX9lbur/1x0gkg+5oBijeQfMscnoHm2Xa6XGd5c=@vger.kernel.org X-Gm-Message-State: AFuF++nwEejhzwJLLt6nqhlswDPN1SbY6v35kCmAp7KD7VPLVBoo3iMq 4PpYVCAfWL/CEGIqXm3up2OBUctJaQs3azjq5LuU+omlxmYrUD9VoQe/Mom3WT7+1p02Bk212S2 IrCanFqK0GYLAb5aoNWWGEGusGjpNG5FqzYSfMmrdzJD6qOLYAWP9bpxFB7SplhfXO0Y= X-Gm-Gg: AYBFou2a53y5QMWwCpgPRN0QtzMqzYs1CfEccfkiOQJXpOBKvkqmrTxAIhEeul2a7cS hWvmnRqPwepNNEEOHsgTo+AzfQI0UmvOk7uDKoS7tE7Z+Xq5Nalta4JstOxVfRYS6JcXtDbunWY DNcrJfJlq5kP87EgkjTfZw8T8Vfi8nQGcYmT9nCCMRbU+7GTymdMNWktAKC7Eg7E8V7Rlg5CRNM qZaXS76IINL/MoxlnJ4D9vcDC7qxgfE5APg7UiO+k47Zwr0wvOQAUYbyRlbIzMqh+PtYrYj3kBt DAbKP9csB6unhWmTl2jHQ4+aKgJmUVN8kNC2MOXzo7JNg0rlrt0TAf51HDOWT8oVLDY0HHJagRq 09ehwhNq2BaG19/2LcvEH1qLVrGfghQ== X-Received: by 2002:a17:90b:2d0b:b0:398:c794:ca26 with SMTP id 98e67ed59e1d1-39b263167f7mr723092a91.25.1788461683335; Thu, 03 Sep 2026 11:54:43 -0700 (PDT) X-Received: by 2002:a17:90b:2d0b:b0:398:c794:ca26 with SMTP id 98e67ed59e1d1-39b263167f7mr723030a91.25.1788461682819; Thu, 03 Sep 2026 11:54:42 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339885ce1csm778829eec.4.2026.09.03.11.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 11:54:42 -0700 (PDT) From: Mohd Ayaan Anwar Date: Fri, 04 Sep 2026 00:13:48 +0530 Subject: [PATCH net-next 6/9] net: stmmac: qcom-ethqos: warn about legacy RGMII PHY modes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-shikra_ethernet-v1-6-a50765996035@oss.qualcomm.com> References: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> In-Reply-To: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788461628; l=1105; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=K+J5JXbqYwK3TUxpCoU6dPlVnyBExv1tcHHZpJs6rIE=; b=VDlMBVbP9rRPq/DX36zllF3huKy8nLST52QEJlSSp+jxj3Zs1EezJmpRt51v27kOytNJ7XBqv 7jGNDwMby5uAoWl595g90dVdQe+h9jNOgpVxmQVVPMCnxoHZ/z8q+ZM X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-ORIG-GUID: lZxJkQLupsmwIahNQjMwz_GQ34dgZdNY X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfXxdojahfOVM4p +U+J5LzBsJUstGWPhXWZ0yy85Xxofm191SWI1hgQnEIQiPnIpAkqvzZrrQs4rYniuqHgMLG8sUh ne/DgJSK9qg6TDZNvSjzf6wDzM3WfZ8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfXxoOjLDNBiJqc xNM7JdJ5b2ur2lViPbFskwA02/Yj9dr3jHvALjqM78QeVm4KIPiuwCBh8SmVLJJC20ORTh/LZgt CU6yoMWQ3L5ApXxB6QCs4x9AE9CirYbfqCalfuvUuJAJkTZqmCtbAcVeQfz+Oj7qKCWVofh/4fj wkkdeTDvY4Js5u0OvS72Q1Ucnzteej/ApDdXdr0m+z3vaKWBi/0RSu0e14mvu24pbC3/ZEH5Bxo t6wQqa34UPazlAnRV+I863wHMEJHQWdXbmcxXZJjiOtEPT58tMRzkkkLoCkeSZsOt17VSirfKi7 013CNEuBgZpHF4TyrzyOhGr7pvvHwZ9N6dag3HbXIg6RMDSttJl4JAw4xriJNjkJtxEPYUSrPFh Fl1mxe25JGF8YMM729CmjVoqquTU4Y7mIyH+Q6AqcqewPlyvF6UMEEE9EnDbbUUlVDfHdFpITyN pBE9Q4GuMlBkT2hpQmA== X-Authority-Analysis: v=2.4 cv=NNTlPU6g c=1 sm=1 tr=0 ts=6a99c274 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=IeZn-EEC65Et7LrU5-sA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: lZxJkQLupsmwIahNQjMwz_GQ34dgZdNY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_05,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030165 The qcom-ethqos driver is moving towards using "rgmii-id" together with PHY-provided delays. However, existing DTBs use "rgmii" and "rgmii-txid" and must remain supported for backwards compatibility. Warn when either of these legacy PHY modes is used to encourage users to migrate to updated DTBs using "rgmii-id". Signed-off-by: Mohd Ayaan Anwar --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 67738c1598c50ade22f2d548a6d66911c348af51..2ca2f03de30174c9771fdc517c0= e21e3b392ad76 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -554,6 +554,8 @@ static void ethqos_fix_mac_speed_rgmii(void *bsp_priv, return; } =20 + dev_warn(dev, "legacy RGMII phy-mode detected; consider upgrading to a ne= wer DTB\n"); + /* Initialize the DLL first */ =20 /* Set DLL_RST */ --=20 2.34.1 From nobody Sat Sep 26 07:17:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3B5A37C112 for ; Thu, 3 Sep 2026 18:54:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461702; cv=none; b=t3uOqYyarxTg6+UD+ayvkTPJBIfr8AXa4Lrea4qMpoHvqBBqEeYdcP0zktoMVWrwIiNvI51tsatIqv+KprE+BL4ysGO+sGSEa+XuWpD7m4i8FCvwgtL9uFm91byFghCwnJwL0eOMtnSREYAoG3BRQZV6sr/rO9AM7Nn/KfwIqA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461702; c=relaxed/simple; bh=NBTqBhye392K1VYn8d0VzVca9aW2/O/mLmzqGu6EcfQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O4c7SlQEGdzRLMkotAu+vrFX6D/W59aUAM+zB+KGhqj9XHOfUUQsd1qAgENkn3WyqbcUpgELe1TAbTXBYmL0W6FuVOMdlfPiMhpJPkTghHEbbXEcvA+ZMUkc0IJ+lgDMEdojeAHRS05lpLaC1bq4ffoEGzywIWEYJSS/lSsBbpM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bmhM9tdj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QosA6VjN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bmhM9tdj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QosA6VjN" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683G3AVT927810 for ; Thu, 3 Sep 2026 18:54:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4yNYglhW1QFSU5SJ+MYIp50snQakRJQqdoTsNwGOnW0=; b=bmhM9tdj2jqm7G6T 27Y3mutqMaRxG3zMDedlThsxvqK42jBaeaD9ofSNEXZylyW7zziij+p9sQE3W6qa 4Wre5op4L91Ayjk5OmB4+dQ/E1+X1Yypho6rrKkkuh0zxl14mOEhvjl5NAqDt8UH atuN85rTsNEE9Y1uAHfKrT1zCnQaG0JvNdVvF0MwlCFtyZNhaKcTxe9RR9MXezC5 bpMc1zzdJRW2cwbmjKQJlrd9DuxFNDJAEQzPxhkWb20a0ofy6G6oDn/IW2oYwqd5 /yMN7fpuXc8NOvw9h2bXUFATvqW5CHGcEW+beOTI/9KcrhtL1HbUb31S9Kw4m1YZ 5flx7g== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf6tx2buu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 18:54:52 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-396638f9a18so177645a91.2 for ; Thu, 03 Sep 2026 11:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788461691; x=1789066491; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4yNYglhW1QFSU5SJ+MYIp50snQakRJQqdoTsNwGOnW0=; b=QosA6VjNaN36A6fJD+yq/rOLQDoCW11SfWKrd9YF7M/Xnag0H2emuzjcL9b8T3ZXm2 r+8Ol458C98jfyxCklZXKHOm1ueb3ThPTPcMfhIrsQWG3pCIGCVq0PY3HXk46jnz2fk4 zMsjNX2qSVXZ6IHdw2eepuusXBbu/AKEjF21ALJDunagAOeEAZuVJqMhPWpOSK5yKOsq rnpQ9VMsEVPXlzOXxWoGoGtU03FBexTfCQclL5Oub5j9nU1fZQrGYboMNsKFu6p2JSmo AqO1EvMvOQVtFul7/ct43SZ6EzpsEiiX03Mc5SFt4Elap8nF2U6zPeqrXyliofU6rEia f+Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788461691; x=1789066491; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4yNYglhW1QFSU5SJ+MYIp50snQakRJQqdoTsNwGOnW0=; b=GPj7DWxnOvV8raPBHu2eTtLS/xMEwegO5HjcHowK2g3OdWVb7ASI0tv4J0GC/INBbA Gw4h+/a7oUr3sB4IIJ0s14mUqaXHPcYsn50NPRKd5TH6+72I/oBQQF7eC/lPbTX4C6BF vnNhjX2+pHxs5KDgkRJHjR/bK2hFraUGDKwplDVlmdnYJXQ/GXUgs9gwHbW2q94khTUC m+7tHi8lHJpTAEe5QSn0ss3t/aGN8QBwCCJ/EeQYqUm8m8cuyjIBwZu6nQXlzGDTcwaI 3KCob8aDBzbKaRX1B3ldUu8PP2ACe5gVNC2RtcFc6FvuOddZuPO5LcYQ6sPMPgFJH3zE U/Rg== X-Forwarded-Encrypted: i=1; AKwUvBw1BI0b/6A1d2/YR6JpLjbscTIeNyuBEqz/U8KIp1rO85uHD1HGkpinAci4fnYJ5vAC99tUV2r6WI9CDzA=@vger.kernel.org X-Gm-Message-State: AFuF++n0m0CNg2INuEHqIIkPu9XaNIf96YDRR6pN0hSMJJV9LUEBZkpw K2eaUMHa/VbAnh1VwQa19puTOOuaErPjmvCdnidkHIqtqAJln8J2DU8bGNGgKtWwWzXcLn9BALm 4Hgug8tTfvUEpXMjt/DyUsQtKVPY5QfrUVUC1ihMZPzLdb28zzvEIdOSFhEBMpLPklDw= X-Gm-Gg: AYBFou3W4n+fDP5Fo6lPKpLeCga7RvdjQMvVBEtWdnBiW+Bcvk2xniY1regPzqkuT1h oslRkwCUsJRzvx87pxn3AbE3Gb8Sa1qD7H4+RhhMzZFlIN3iieY9Oh2KVFn0EXegp1iRdCxVkT6 rSSfBjBGLBqh6Wpy7HVpdgQGSMHac8fDeXkpYFxUfN5omulMF3Axi3ZvxM/P9s0YliWlrBdtXne by2fVL5eQHJr1qVdXvMDanyOUMfdj+DcOSE9vsmlFDHdOdllK1mH8xzj7Yxj13ndMMxUR7mQaSX TXKpcJ42EI+kcbb14TvBYgpcsQ+rPmgqYCJprXml7yx2iAe6xI9G8iWBG1UXQsCDZROgVoQUO/x oT1YEIp1mYqyO3Brl7IDAViIVb/7nJQ== X-Received: by 2002:a17:90b:1d52:b0:37f:eafd:3505 with SMTP id 98e67ed59e1d1-39b2612eb8amr773681a91.6.1788461691051; Thu, 03 Sep 2026 11:54:51 -0700 (PDT) X-Received: by 2002:a17:90b:1d52:b0:37f:eafd:3505 with SMTP id 98e67ed59e1d1-39b2612eb8amr773621a91.6.1788461690575; Thu, 03 Sep 2026 11:54:50 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339885ce1csm778829eec.4.2026.09.03.11.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 11:54:50 -0700 (PDT) From: Mohd Ayaan Anwar Date: Fri, 04 Sep 2026 00:13:49 +0530 Subject: [PATCH net-next 7/9] net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-shikra_ethernet-v1-7-a50765996035@oss.qualcomm.com> References: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> In-Reply-To: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788461628; l=1138; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=NBTqBhye392K1VYn8d0VzVca9aW2/O/mLmzqGu6EcfQ=; b=XG6OG86F6AP75Xr/1HV4kKPEVE9c9n7Ucn6qBz1XILjvZck4+RuFYA28UG0ao+qFKjm8Qgtgo YOhobDDsRmVADfjFTp8bHa/dwplCnyCgS1YL5fI1Vv81CiN51J51n0j X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-GUID: hmyT9j4zravmrocRct90YO_drruCHCzz X-Authority-Analysis: v=2.4 cv=TqjWQjXh c=1 sm=1 tr=0 ts=6a99c27c cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=dsjofxfk3bnWsHuiCQUA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: hmyT9j4zravmrocRct90YO_drruCHCzz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfXw++oJr6+gWl8 +aKtd1lDUW6VmxJRVaOcvMwiNURWPjKN2cC4bzYvCh4qbo+yT2cMB/wTPJaoo6ouyIhEPh7fQ3T /8BZ/R+kG+GQt+HnemrQT/q2R0wP/1VVosl1r/j/vp3CxHljwmkwhBXUGHqyGffa36SToQl6K3J pdW2L+38Z+jZTnltPdp8aSwLlHrGOnhGp+GEosaNSRI2OGqiZw+dUB/ffzNhF+vmr3Q3gEuCcpp PVJHrtvRNd0sQkAF1N01RuhkRDfHMtCwCaGSnUzCFtqpgk+bQCpRqhM23573c4xZFXI2fvbLSpJ xROv1JhXu17QMh8nZbOlOu4gKjJ8XafbUXHjRN7nSxy1yKOX8Y4ZSYVaDqfgA6Yh+Lp+hXgL24z 951mP3BiOkYhpWMnFI2lJjBLoJoDnFcLB4GhiJJvYg2rkv/wS9H3dWCXzpI4lOO6FIQuUUyMMmw tm5x1zzRCinlFKSG8Qg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX2zV2BzVtuVKS +m72srHrLq8CblqDHcRjGc4AixUbxqD2+z5MhhDayZ1YEvoKZsTh3sf9SSD1cZCBa732wKwx1jz xTpdM4c397H3+ITiiI+IuMkuExWwVq4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_05,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030165 On probe the RGMII link clock is initialised at SPEED_1000, which translates to a 250 MHz source clock even when no PHY link is present, drawing unnecessary power. Initialise at SPEED_10 instead; fix_mac_speed updates the rate once a link is established. Signed-off-by: Mohd Ayaan Anwar Reviewed-by: Maxime Chevallier --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 2ca2f03de30174c9771fdc517c0e21e3b392ad76..4f9bef662c5796ce3cca64b19a5= 95bcdbebbf336 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -814,7 +814,7 @@ static int qcom_ethqos_probe(struct platform_device *pd= ev) "Failed to get serdes phy\n"); =20 ethqos_set_clk_tx_rate(ethqos, NULL, plat_dat->phy_interface, - SPEED_1000); + SPEED_10); =20 qcom_ethqos_set_sgmii_loopback(ethqos, true); ethqos_set_func_clk_en(ethqos); --=20 2.34.1 From nobody Sat Sep 26 07:17:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9034E3C109F for ; Thu, 3 Sep 2026 18:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461709; cv=none; b=qG1sXZtuJUHj6dIAIVAv5U4OAm3Vi6h5Gm8g3lFDwkHjfinPhRNHgTdDbHXOUkJ6kh20ea7uTRX/H9iDqeibOZrFMuFKpW7Qk5JXA0RR0eSqe8WVcn1fbDL00yTfE8+1EunvIV9zafI0iFyZtoDZDjDg/aRtk27Rf2wdnM+kNEs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461709; c=relaxed/simple; bh=3qNv1gt53nDwmaZH3husajnhbdisLPvYiqw3RUvnSA4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s2SmPUo37MG3/dAYFlb/DSo6TTo/pvjgoEEL4Bc7zxX40SjuIZoE3utW95Y8keuNognkciWB0/+UgDYgVG5OamKWRte5aP6pWSAmkzxoEUHiTFnj7fZhcJ2UEMTxIhhMSU4a8RrFls6gvczqUE7IKAyk+7kcLjTRPXiTtcRxVeo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ahrb7FLx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OU8kW518; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ahrb7FLx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OU8kW518" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683G3H8u927995 for ; Thu, 3 Sep 2026 18:55:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IRq6FO1Wgh0OU+E4Zz5vIqKFC7LhLdGz4RbBzOB8Y1s=; b=ahrb7FLxlCP9y0bt cAFx5oVRJmHjZABg1PjfYicyMyRlnzwjhT0sfbeXfAsw21iU5V4JsBUewn1K/31F 3Miho5zFr3Gf/F0BBBjANjTFQi6cHSa4S6uCOKQc2DJ0hBYvCCXts0akge/QkKs9 lLc0jaXuHweSaVnhUvF8zCOR64vAM4n6/07lYyiexdagP38bDnqXxjRe1zgE5GKN iChl/GFMoeAb2mG7cZB5PGJaHp9HnNlrqJbxiEBLBaSjXZ4lFPBtIlw08MHBlHz3 c5kT8iS8oPrmHc5W4T0r25XHKSC4gZwLvgIKkZ1+2FGIvNfzICuKJaL9MvfNpA9a VDo/pQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf6tx2bvc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 18:54:59 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-ca8aee88725so369119a12.3 for ; Thu, 03 Sep 2026 11:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788461699; x=1789066499; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IRq6FO1Wgh0OU+E4Zz5vIqKFC7LhLdGz4RbBzOB8Y1s=; b=OU8kW518IPdc6OpupOdTbUC3zC9Sasj0jB7C7VQ5aQ70SP1aTD+S9H2y+RBKhWbu6Z G82jK0XWniznFggjdQYL+u8R7xDWNSu5D4chNVYBSPYGcop7O00Q0m/wTuiPTLquqYH3 V9eOOxNMTEx1KbrtgPXj9W8N10dtRjmUYo+HiLfBnpidD27Kz8KEMkLcg7kboQ8V05Ft n9woi3TwsLeN3l3nGjs9cT9cvOcVQtm+1nrpa+8lOqnvxL8Y8/HJikBLyuUSwhiBS8pb V8DVFo4xUsUidw+6FkzNIVNj5Tx2Zvjf7sRuu54KpwrGY4iZM9d+J3I2V1ke2qXUCgCc E6EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788461699; x=1789066499; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IRq6FO1Wgh0OU+E4Zz5vIqKFC7LhLdGz4RbBzOB8Y1s=; b=Nwlo0qOrPwB+E1tjSDMNIAl6v93EkfJYoKcTRh3GrPCdjaj7DOszDaq7AoQPCis0lC rN/ZygGbGOQ3xL8MxBRdq6WEwQB5XG+/R25WQtRID0TtI+TxZrTpBAw6TyNJFrINaP8o Qr3Nn//P996457gJqU6JnKU5z0qrvqLGuslGV6ah9xbnxJCs/ZyFkbFHIE8HafgEgpBa JqZ99ZbV3QXHbQKUmQo5NhgXIqRKSPTCwd0FTHEwTlzLViSSPvFExtyl6PLd8gjgsuEL p3tbHCSbJjLtO3zAq3gKNTlfxG5EwVzQOy8plm8Z22TgWkFVgp4IOQ4jDW19HK0S5oCb O49Q== X-Forwarded-Encrypted: i=1; AKwUvBwK0WFrBUc2WILr8UUxHFM83zOlZcBhgETK5/UPSKl0INNTy2l582fSPnvWpL8rmDsp9KSZcrhKO1cO8hU=@vger.kernel.org X-Gm-Message-State: AFuF++l7IuCJhqTQRQqZ/c5fAXHIyzLlXDOoP4pYB3ikgNowhzg6NTTj 4rYN9MAxhAbp1tYSce9Yd6t7yQXyK29xsGc0jO4l0VPTFoNLCzkGIDq/b6Fkh9SBMERd4VZiH/T 4VADZ63EogiovGuT3MkNC+mNfLHDsFSLYMORWZ+kp6cHXg4ZcOKaNvaoUhsbWVhCFdm4= X-Gm-Gg: AYBFou3yseWJogniEhhhnsKCsQgqD6Tqu9fURj2dGgFeCGVxK0fa1Q9pfguGxZpYDdK gf0CX6lRhUeMaOtaAcdr9Yksx7KCpiyg21lIzE23+T7D0EZHRKC7+vBni75LnySn+MW3/AweN2Q 7Ua2pRT1W5OGg6Rb8enzXWm1mx0DlK01rVnnfUy091qhtF0R9AgxJs9Nd412nd+wtgBQDfE/1yW QGJ1y2GNH8Sj6XRO6Dlusil13w/ikFw0El9IBTS1K4TuyoqemdamNkSLwmgHOZnj0ZleXTei0L2 j+BnaPXtZ/j9DcBZXgx5QIHHsfUhZDLTa/vC6K9/oL77eNzFEScyx73R5x8uV14IJFsvaeX+giN 6dTeHQVjfVgKxkuE9ZDxyujYjfLBggw== X-Received: by 2002:a05:6a21:6816:b0:3d3:afa7:8101 with SMTP id adf61e73a8af0-3da3a16d1cdmr786607637.28.1788461698741; Thu, 03 Sep 2026 11:54:58 -0700 (PDT) X-Received: by 2002:a05:6a21:6816:b0:3d3:afa7:8101 with SMTP id adf61e73a8af0-3da3a16d1cdmr786529637.28.1788461698279; Thu, 03 Sep 2026 11:54:58 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339885ce1csm778829eec.4.2026.09.03.11.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 11:54:57 -0700 (PDT) From: Mohd Ayaan Anwar Date: Fri, 04 Sep 2026 00:13:50 +0530 Subject: [PATCH net-next 8/9] net: stmmac: qcom-ethqos: add per-platform NOC clock voting Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-shikra_ethernet-v1-8-a50765996035@oss.qualcomm.com> References: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> In-Reply-To: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788461628; l=6340; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=3qNv1gt53nDwmaZH3husajnhbdisLPvYiqw3RUvnSA4=; b=tT0xjbelciTRGJKzrX4LgzDWW4xxzHa+Wp/2FPlqaG/hynm5ROaZNmS3jqmRfWpOIwkDXy2pv MG6s7z/MzO8B5WV/Lk3pM6k04iN/CQFs5mEAZIg7O5uTQqeVprKDkrJ X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-GUID: tBemlAA2d6oygGuqu8QQ2ell2xAJ3u3x X-Authority-Analysis: v=2.4 cv=TqjWQjXh c=1 sm=1 tr=0 ts=6a99c283 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=LOscwf8DjUB2Y-oEo0sA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: tBemlAA2d6oygGuqu8QQ2ell2xAJ3u3x X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX4kxaJZBlctkr NenCOJTmRVuc4xIc0BKeaCGqhXcylhur1PXQt1CS/qT/2Ah4G1KTnPJUU1eqTiZA9FAvr3JXWgl p+QpOawtWJWavkeMztvyyZLbYNeId0UYTQeZvucftUXKTjmvXksjeF76UiLxCHSqAe7wR66PFk3 DwHMmJMWtCY70P+jC2lScSoZBpEzF7O2nIsEPdPQHAwM9/0CDKtsaEFWbDDxDJB97Dwx/wzzXrq TM2VzhW1kbS7GO4U7I4ru/0k74DHuqBEYlaBFbk4cWhld2tvbJ90JXAimmrkBXEwcGKQH1qZO/l TqcV7LgtoVPGQmTQXmhn8plrIVWgNkGaN8fbnF08gQpBfYjbwFE2Wd1d68WOmv8pqbIJ075UCyT 3VSMy30O1QIrVz2whrqNZOvy2SCZ03dAQHylYZAtnITcbvEcIOZ2M3YRnx7yH4MRyBAZycaImtk EbhYwfbsi+0n9RRBrCw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfXz8HJ+FCCKDq1 by3rD77YMUhHpEPF8/fg0BfS2EcSK0pliSj0YWZMezMw05O980eJeDu7LnARkoITXBzZYl9+qP2 REDc5hacjq15SMdOLNipmT93i0ubrtw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_05,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030165 Some SoCs gate the EMAC's path to the System NOC behind dedicated clocks that must be enabled before the DMA can reach memory. Add ethqos_noc_clk_cfg and the corresponding fields in the driver-data and runtime structs so each compatible can declare its own set with per-clock rates. The clocks are acquired during probe and enabled/disabled alongside the existing link clock in ethqos_clks_config(). No functional change for existing compatibles. This will help us when we add support for Shikra. Signed-off-by: Mohd Ayaan Anwar --- .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 101 +++++++++++++++++= ++++ 1 file changed, 101 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 4f9bef662c5796ce3cca64b19a595bcdbebbf336..a31541506a4c930c76374d7d8b7= eceb6f51f37a7 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -7,6 +7,7 @@ #include #include #include +#include =20 #include "stmmac.h" #include "stmmac_platform.h" @@ -84,11 +85,18 @@ =20 #define SGMII_10M_RX_CLK_DVDR 0x31 =20 +#define ETHQOS_MAX_NOC_CLKS 3 + struct ethqos_emac_por { unsigned int offset; unsigned int value; }; =20 +struct ethqos_noc_clk_cfg { + const char *id; + unsigned long rate; +}; + struct ethqos_emac_driver_data { const struct ethqos_emac_por *rgmii_por; unsigned int num_rgmii_por; @@ -98,6 +106,8 @@ struct ethqos_emac_driver_data { const char *link_clk_name; struct dwmac4_addrs dwmac4_addrs; bool needs_sgmii_loopback; + const struct ethqos_noc_clk_cfg *noc_clk_cfg; + unsigned int num_noc_clks; }; =20 struct qcom_ethqos { @@ -112,6 +122,10 @@ struct qcom_ethqos { bool rgmii_config_loopback_en; bool has_emac_ge_3; bool needs_sgmii_loopback; + + struct clk_bulk_data noc_clks[ETHQOS_MAX_NOC_CLKS]; + unsigned long noc_clk_rates[ETHQOS_MAX_NOC_CLKS]; + int num_noc_clks; }; =20 static u32 rgmii_readl(struct qcom_ethqos *ethqos, unsigned int offset) @@ -691,15 +705,51 @@ static int ethqos_mac_finish_serdes(struct net_device= *ndev, void *priv, static int ethqos_clks_config(void *priv, bool enabled) { struct qcom_ethqos *ethqos =3D priv; + unsigned int i; int ret =3D 0; =20 if (enabled) { + if (ethqos->num_noc_clks) { + ret =3D dev_pm_opp_set_rate(ðqos->pdev->dev, + ethqos->noc_clk_rates[0]); + if (ret) { + dev_err(ðqos->pdev->dev, + "NOC OPP rate set failed: %d\n", ret); + return ret; + } + + for (i =3D 1; i < ethqos->num_noc_clks; i++) { + ret =3D clk_set_rate(ethqos->noc_clks[i].clk, + ethqos->noc_clk_rates[i]); + if (ret) { + dev_err(ðqos->pdev->dev, + "NOC clock rate set failed: %d\n", ret); + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); + return ret; + } + } + } + ret =3D clk_prepare_enable(ethqos->link_clk); if (ret) { dev_err(ðqos->pdev->dev, "link_clk enable failed\n"); + if (ethqos->num_noc_clks) + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); return ret; } =20 + if (ethqos->num_noc_clks) { + ret =3D clk_bulk_prepare_enable(ethqos->num_noc_clks, + ethqos->noc_clks); + if (ret) { + dev_err(ðqos->pdev->dev, + "NOC clocks enable failed: %d\n", ret); + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); + clk_disable_unprepare(ethqos->link_clk); + return ret; + } + } + /* Enable functional clock to prevent DMA reset to timeout due * to lacking PHY clock after the hardware block has been power * cycled. The actual configuration will be adjusted once @@ -708,7 +758,12 @@ static int ethqos_clks_config(void *priv, bool enabled) qcom_ethqos_set_sgmii_loopback(ethqos, true); ethqos_set_func_clk_en(ethqos); } else { + if (ethqos->num_noc_clks) + clk_bulk_disable_unprepare(ethqos->num_noc_clks, + ethqos->noc_clks); clk_disable_unprepare(ethqos->link_clk); + if (ethqos->num_noc_clks) + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); } =20 return ret; @@ -736,6 +791,46 @@ static void ethqos_ptp_clk_freq_config(struct stmmac_p= riv *priv) netdev_dbg(priv->dev, "PTP rate %lu\n", plat_dat->clk_ptp_rate); } =20 +/* Some SoCs gate NOC access behind dedicated clocks. Acquire them here + * so ethqos_clks_config() can enable/disable them at runtime. The OPP + * table is used to propagate the required VDD_CX performance state via + * dev_pm_opp_set_rate(). + */ +static int qcom_ethqos_init_noc_clks(struct qcom_ethqos *ethqos, + const struct ethqos_emac_driver_data *data) +{ + struct device *dev =3D ðqos->pdev->dev; + unsigned int i; + int ret; + + if (!data->num_noc_clks) + return 0; + + for (i =3D 0; i < data->num_noc_clks; i++) { + ethqos->noc_clks[i].id =3D data->noc_clk_cfg[i].id; + ethqos->noc_clk_rates[i] =3D data->noc_clk_cfg[i].rate; + } + ethqos->num_noc_clks =3D data->num_noc_clks; + + ret =3D devm_clk_bulk_get(dev, ethqos->num_noc_clks, ethqos->noc_clks); + if (ret) + return dev_err_probe(dev, ret, "Failed to get NOC clocks\n"); + + ret =3D devm_pm_opp_set_clkname(dev, data->noc_clk_cfg[0].id); + if (ret) + return dev_err_probe(dev, ret, "Failed to set OPP clock name\n"); + + ret =3D devm_pm_opp_of_add_table(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to add OPP table\n"); + + ret =3D dev_pm_opp_set_rate(dev, data->noc_clk_cfg[0].rate); + if (ret) + return dev_err_probe(dev, ret, "Failed to set initial NOC OPP rate\n"); + + return 0; +} + static int qcom_ethqos_probe(struct platform_device *pdev) { struct device_node *np =3D pdev->dev.of_node; @@ -795,6 +890,12 @@ static int qcom_ethqos_probe(struct platform_device *p= dev) ethqos->has_emac_ge_3 =3D data->has_emac_ge_3; ethqos->needs_sgmii_loopback =3D data->needs_sgmii_loopback; =20 + if (data->num_noc_clks) { + ret =3D qcom_ethqos_init_noc_clks(ethqos, data); + if (ret) + return ret; + } + ethqos->link_clk =3D devm_clk_get(dev, data->link_clk_name ?: "rgmii"); if (IS_ERR(ethqos->link_clk)) return dev_err_probe(dev, PTR_ERR(ethqos->link_clk), --=20 2.34.1 From nobody Sat Sep 26 07:17:02 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D57C3B3880 for ; Thu, 3 Sep 2026 18:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461717; cv=none; b=SnRZR1dTrL5VlIjJpeXJB814oo+IW37giMQC8zpDo7cXU6eYEl92xTNaPRqd5Sa0ERTSQ8aiwRPwjhYwplPN6OdBOYyCKQ0iAmc1MXRl7d3YaNjUbAzFJHaaLGc7CERpflKaVK8CxKqK5TSUr3ogxr2EznVxXrA21TTyMUjA+4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788461717; c=relaxed/simple; bh=6Sz2cqNRtW1LNezPdy1yYmWDiunh7gud6qBkVKoWCGw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mrGy5NYHvRRJh43Pie73OmCQD/094e/B5DDbmvU9ISqE73db6Jkjpb8jcwznYAHIoWUpYSLJv6/Tz9XXLPv7U6IY79JnQcSPmLdzaxqbT7F6gqciAxwhkGrYPxaFbWvhTAXj5otuj5Wafc8oW4U3x3Ic+N5goxldnRs7m7+NLDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ADFubAnk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XgvX972b; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ADFubAnk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XgvX972b" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683G3FPQ417571 for ; Thu, 3 Sep 2026 18:55:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nlYWxFwCRtD+CyHkSV4Q7s20WNU8tKwVLibr/6VJ2QU=; b=ADFubAnka63XDCbD aqDT+9JpXBDtCltgiFy6CDI2ukQgiTLWpoMa/bial6A+VkAtZI5K4/2ONSDjqfME e5dyGBqysDMrx1dA2+d92LztUUNy9I6DtKsRLVVRXYMo1F8ljZCLNAahjZ3Wnwr9 Cj87k9RIRIVwMjKzNqhbWlvO+AHEnSxRIkDse/Z/+P0bVJ8xQGLT4w677r/DUmls xaBJt/9B/0yQBpMl9x22IiMXuRM0RTlPw2Dit8p6trc2/onrUtQ9tBLHqpXyvfkE pEmeIxLiRuRVF1sgTV5tXAuVP1pQyDjRj1VXS6b3vjyn12eq7SvdHqA/49Qbh6Tf GAzKfA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf51m2wpx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 18:55:07 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-399311947f6so203844a91.0 for ; Thu, 03 Sep 2026 11:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788461707; x=1789066507; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nlYWxFwCRtD+CyHkSV4Q7s20WNU8tKwVLibr/6VJ2QU=; b=XgvX972bJ1tRXKKEa0ykfdYCD1rCLfefX9mygNjidOwY8wkNHFLuV4YwNt3cvisYBv aLDA3W5RZVAeQLA5Y3WpKn/Nzffhzpa8Wm2qrwP7EJbuP6myNXqHpVxyIpWvrH4HZQQa 1MCan0IbjFJGQvHUC+ymf4zpofPMqhLglUH4M2KLe8K1cI8WdWXqvvYiqc90V/Wl0vcE tSuG2UOiY2IniFFzfc5Fht+QCFYa9DeElGkh4XbZtlSGLUwAxGu5S02QaTqWk3/+euiZ M6tbw6tJ0FvpDqtXp1SxyCf1zIsQ7pxTdegd0lFcyQwY4sdOUAo9ovkTktY063FO5cYt f/7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788461707; x=1789066507; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nlYWxFwCRtD+CyHkSV4Q7s20WNU8tKwVLibr/6VJ2QU=; b=n5tDSM+VbWVCo9prDIfZ8Eq4zecoR5B+/FO125x77KI02iLBd0Sonx/vXS74IP6lwj KbFnLZ2v6Wyo/0UHdzJANOFVxZjokHJV92obiS+T4TOXGHd/vgFi3C+K2vjLxaxsZd20 HDgnPADKcB65ta3wnJVzPFvYEvQ6FGqKVqVjbE3ss+A8cCXXubEQxgYQRJp0AmVyx2G6 fM1dq0rfkUPjY6SustXzcNuuCmWSmYbN6/qhWKNzqbvzO32pYPLrSuIuRf1TBEb5d7XM XzSy1eJ2bypuxTY9CFc/Zza7hQ7Opp/SBW2LM04SEQ7ZedBIQAwy1y6+hqyj006HMyaN nx5g== X-Forwarded-Encrypted: i=1; AKwUvBxJVleja1kt/p+rBwNk44NG6XR/owXpuRtHGksyxBlBj50MAmk1oOrR6bEqhdYbKs1npmUcOhJ6ta5kmRs=@vger.kernel.org X-Gm-Message-State: AFuF++kCyFCW0VaQboRb6Nr5a6HKsUcPqcc8CEPRRaqeoaEab1qCXxdH tG3B1opS8gCb+gShv6TBRqtKDcEZqc9xE7I63omDMGVXkdZwz4ws9q5dx+OB1wKPOwipAebyXgF S4D4qf+DAVE3jROXQOHx+dQ2mYgwM4F3MIB17QGqiMXIpw4jGUrP8n4y1XFIqqRvUYu8= X-Gm-Gg: AYBFou2Q3pGTBe/5zCPpR1KHjd9NLLfHJSydZsek9MLPGgU+0wP9Yoq6OBSkj8LnXF5 IQg8z3o2Q73bg8pPPfUPijCPDSYLyzIVYc5u5qK6fUOZ9QNGNOKyK0mWwwsFvDzNVZs4iPyVFXf y+cQdQ2pGNw2vk92oAQT2fQiuRIvYccX99c/Zw1qlCV9nJnn2iXwr6eCMPAG8HAOQs7nYia3KNY VsHj2zCtGb5S3SAeF4R+RK/qByUZ3Li2Ny3/gYPBD64un0FT4BuBiwrTfUc0Ogf0iVYDSPsX9c6 xFJ20X+G3PJMz886pYAHsU0SOikggTBjtVhw/LYBpt4Oh8jEHFzB04n+SVEHbAczxzlZfEn13Ki ilKC9Spjr+fYMj00E1fQYPrskc+y7Vw== X-Received: by 2002:a17:90a:ec8d:b0:38e:67e1:15b with SMTP id 98e67ed59e1d1-39b261002f5mr881613a91.6.1788461706825; Thu, 03 Sep 2026 11:55:06 -0700 (PDT) X-Received: by 2002:a17:90a:ec8d:b0:38e:67e1:15b with SMTP id 98e67ed59e1d1-39b261002f5mr881474a91.6.1788461706059; Thu, 03 Sep 2026 11:55:06 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339885ce1csm778829eec.4.2026.09.03.11.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 11:55:05 -0700 (PDT) From: Mohd Ayaan Anwar Date: Fri, 04 Sep 2026 00:13:51 +0530 Subject: [PATCH net-next 9/9] net: stmmac: qcom-ethqos: add Shikra EMAC support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-shikra_ethernet-v1-9-a50765996035@oss.qualcomm.com> References: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> In-Reply-To: <20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788461628; l=2446; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=6Sz2cqNRtW1LNezPdy1yYmWDiunh7gud6qBkVKoWCGw=; b=eafzCTaX5oGSJgmMpw+62BELOmcZDQ+A8rVZfjvC7Ql/q2fwMZyJnskZrX4L7XK4y/BoPFoX5 J7ufBnL3yKMCY/FMtq9NyBMLv+s59whooCZWyBOXtIPKdRElcMhpUII X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-GUID: QQUa7ezCLpyTxs9KoEhHS0DpwB1LFe8K X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfX7aFHkg3g82CD Ilns6H0m1LDqTBTkkAfN0LEVtoQcw9aKwODf3Fjmg5I+Ss69UVWbjUTVZvY5Gc7MJDPoZG+Zicc rzmiMiQVfeoQkaHvn56stlynUg99rUrIs5BaW3+42aNrZvFRSkqXL9WypHBpPHka+e9NtZIBAY5 KlYbiYLeuy3utXxYBkhxQGjPat7St+9vKFQQQjUZaUZ9GGu2bPxdjjxuQqiJSDhusqCKV15LIno HnWvGtVnqOvKT6+vlnM+DRZ1VYsukSKazuzBVB9+ZXviN3iGnJV/VpRuUCbCxtsLnGf4TigrRzs UvAAB6Akxf1vMmEQ2QYcQgC8f6kHyW1UgSGokzco9rCqEXOV8VGt/cdhpBefuGXKXJ2SNjSQANJ lZ1CVB6K0FQYOc5LuSibG4CXLdWsoJX2joGpz7oJSWWP4ft79LarEfPpdzQViv+2a2HMtfYsagI Cj3D9UmWFNxdSxBq7mw== X-Authority-Analysis: v=2.4 cv=X8Ji7mTe c=1 sm=1 tr=0 ts=6a99c28b cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=BjTvb0yH8tSpeHeYq6YA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDE2NSBTYWx0ZWRfXy5gOeB/iaQwj X4vMrhYy+4tS+fakks84hJgyYotbNHJwt0fRCDLQl7wEz+zRDsmADgRILosHmo7A1Qa4d88W3qG +D+L/0Ml8v5lljuF9Wu1XffNvBFq++Q= X-Proofpoint-ORIG-GUID: QQUa7ezCLpyTxs9KoEhHS0DpwB1LFe8K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_05,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030165 Shikra integrates two Qualcomm ETHQOS controllers based on the Synopsys GMAC IP, similar to previous platforms. Register qcom,shikra-ethqos backed by a new shikra_data descriptor that enables the three NOC clocks required for DMA memory access (axi-noc, pcie-tile-axi-noc, stmmaceth) all at 120 MHz, and the 36-bit DMA address width. Signed-off-by: Mohd Ayaan Anwar --- .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 31 ++++++++++++++++++= ++++ 1 file changed, 31 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index a31541506a4c930c76374d7d8b7eceb6f51f37a7..f96680456472d1fa7b72bd404c1= ddc20e505f05c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -328,6 +328,36 @@ static const struct ethqos_emac_driver_data emac_v4_0_= 0_data =3D { }, }; =20 +static const struct ethqos_noc_clk_cfg shikra_noc_clks[] =3D { + { "axi-noc", 120000000 }, + { "pcie-tile-axi-noc", 120000000 }, + { "stmmaceth", 120000000 }, +}; + +static const struct ethqos_emac_driver_data shikra_data =3D { + .dma_addr_width =3D 36, + .has_emac_ge_3 =3D true, + .noc_clk_cfg =3D shikra_noc_clks, + .num_noc_clks =3D ARRAY_SIZE(shikra_noc_clks), + .rgmii_config_loopback_en =3D false, + .dwmac4_addrs =3D { + .dma_chan =3D 0x00008100, + .dma_chan_offset =3D 0x1000, + .mtl_chan =3D 0x00008000, + .mtl_chan_offset =3D 0x1000, + .mtl_ets_ctrl =3D 0x00008010, + .mtl_ets_ctrl_offset =3D 0x1000, + .mtl_txq_weight =3D 0x00008018, + .mtl_txq_weight_offset =3D 0x1000, + .mtl_send_slp_cred =3D 0x0000801c, + .mtl_send_slp_cred_offset =3D 0x1000, + .mtl_high_cred =3D 0x00008020, + .mtl_high_cred_offset =3D 0x1000, + .mtl_low_cred =3D 0x00008024, + .mtl_low_cred_offset =3D 0x1000, + }, +}; + static int ethqos_dll_configure(struct qcom_ethqos *ethqos) { struct device *dev =3D ðqos->pdev->dev; @@ -957,6 +987,7 @@ static const struct of_device_id qcom_ethqos_match[] = =3D { { .compatible =3D "qcom,qcs404-ethqos", .data =3D &emac_v2_3_0_data}, { .compatible =3D "qcom,sa8775p-ethqos", .data =3D &emac_v4_0_0_data}, { .compatible =3D "qcom,sc8280xp-ethqos", .data =3D &emac_v3_0_0_data}, + { .compatible =3D "qcom,shikra-ethqos", .data =3D &shikra_data}, { .compatible =3D "qcom,sm8150-ethqos", .data =3D &emac_v2_1_0_data}, { } }; --=20 2.34.1