From nobody Sat Sep 26 03:57:58 2026 Received: from sender5-pp-f112.zoho.com (sender5-pp-f112.zoho.com [165.173.182.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E189A48CD72 for ; Fri, 4 Sep 2026 17:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.182.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788543535; cv=pass; b=BvG5sZzNRYu0u776Kr3acF4QnQ1vq4oYDU3U+MgXtMJw6wD2UURu/97Uo25vjtWk0WeBM07+TvPeRV3/2v9v0fEUTkAcv8kKbInUCrErb1CAU397ARp+HINOuqnjXZZyW1M4VtzYqYEe7XokWY4lz7bDqBaQrxi5aV12/IzMwWU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788543535; c=relaxed/simple; bh=v/nRMX2wHHTP+BdyGOq+Q+OmdYITNmIkl7hHRCvfj8g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=FXoFgBaiPjmqTM4fBJ0tYM5vAyG2tmlDIFayfLLDBtSHeT+2rnKeUKuTB8X/f9ouniC3A6VWRw38KrtVXvSy0MUf4HHWul98ouCVIZ/PiC4r6BbuFTG176TLdFVN5IDUdgVv6y1uLR7XJS2AT5HmmUCLmUnwoUDnsdKs54exWV8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=WUspQdC6; arc=pass smtp.client-ip=165.173.182.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="WUspQdC6" ARC-Seal: i=1; a=rsa-sha256; t=1788543509; cv=none; d=zohomail.com; s=zohoarc; b=DMmuDQCoVURACoylxNlrDTWGD4xmPuPutKR29iKrvYugqgOJM+zv5l/Jd0VXjujuvspPe6XmVj2nlJ4d/R7wlyRaTdAFofUPJNk8Am66ByH5x7a5LUi9lu+0QyUeaKRuE1bEp9AkqGLBJGkq5iVDRi0YzlfjZCL10c8X2NOE68g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788543509; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=mbgZvM7xkVgSImbz5HrGSlrEC5Uq6gmeWqTe1iVYHgs=; b=ByRtpFCInWU3XH6pqJBgO3z8pLI5RwatQ5CBXidyiAtp4CGmAc14pO7Rh4AUEa/4hqEQ7NxZCFvkVU3gsA1Y2ayox+VI8cCvT9cZpV6t3TgU3NLoM54YprC6M4oVSrmXITX2itZ+PGsXiR4sOVdKn484YBXpUDpdh380cEf9iXw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788543509; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:To:To:Cc:Cc:Reply-To; bh=mbgZvM7xkVgSImbz5HrGSlrEC5Uq6gmeWqTe1iVYHgs=; b=WUspQdC6+N1STCL9QueteIAoUOjMLRtyYKIEkb0026Ycy+tOuCxrfVAxEcbl4hqg tXyXr+sjY0FGKP1daPrKQZ4/uEryPkcUKXzCdIQ/tLcMo9dE5yAMEpLJeoE18T/qrtf CZ9SiX8qbjjrSRGbbNM/wrwUan9eYbPq4gthHc/U= Received: by mx.zohomail.com with SMTPS id 1788543507298300.5394887204635; Fri, 4 Sep 2026 10:38:27 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 04 Sep 2026 19:38:09 +0200 Subject: [PATCH v3] drm/panthor: Display priorities of panthor groups over debugfs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-panthor-sched-group-prio-v3-1-678afcca08b8@collabora.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/32Oy27DIBBFf8Vi3anA+AFZ9T+qLABPYqrYOAO2E kX+92Ini6pSq1ldae6558EiksfIDsWDES4++jDmIN8K5noznhF8lzMredlwJSqYzJj6QBBdjx2 cKcwTTOQDOK3aU2NE3WjOcn0iPPnbjv48PnOc7Re6tPFeH4TXOW+m5xuzJiK4MAw+HYqOBhh8d DDiLcEmAFwDl2yj9T6mQPfdexF7+aWo/lZcBORTslF162qJ+sOFy8XYQOY9r+7gpfwBk+IfWJl hpq1cq21lleS/Yeu6fgO8b4ibXwEAAA== X-Change-ID: 20260814-panthor-sched-group-prio-c987f6a15690 To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Nicolas Frattaroli X-Mailer: b4 0.15.2 Analogous to what was added in Commit d41c79838c47 ("drm/panfrost: Display list of device JM contexts over debugfs") for panfrost, add similar debugfs information for panthor. The group priority does not change over the lifetime of the group, so no effort to synchronise with the scheduler lock is being made. Signed-off-by: Nicolas Frattaroli Reviewed-by: Boris Brezillon Reviewed-by: Liviu Dudau --- Changes in v3: - Move group number to after the per-file specific information, which helps readability - Link to v2: https://patch.msgid.link/20260831-panthor-sched-group-prio-v2= -1-a74c79b4b830@collabora.com Changes in v2: - Take groups xa lock around the loop in show_file_groups to guard against group object UAF - Flatten the listing, removing most of the code in show_each_file, printing that info for each group instead - Also show queue count for each group - Link to v1: https://patch.msgid.link/20260818-panthor-sched-group-prio-v1= -1-1836857c53e9@collabora.com --- drivers/gpu/drm/panthor/panthor_drv.c | 1 + drivers/gpu/drm/panthor/panthor_sched.c | 73 +++++++++++++++++++++++++++++= ++++ drivers/gpu/drm/panthor/panthor_sched.h | 5 +++ 3 files changed, 79 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index 46a3080b0b20..8cdba0c1a14b 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -1769,6 +1769,7 @@ static void panthor_debugfs_init(struct drm_minor *mi= nor) { panthor_mmu_debugfs_init(minor); panthor_gem_debugfs_init(minor); + panthor_sched_debugfs_init(minor); } #endif =20 diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/pant= hor/panthor_sched.c index 60b2417deb81..ac6aee554820 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 or MIT /* Copyright 2023 Collabora ltd. */ =20 +#include #include #include #include @@ -4175,3 +4176,75 @@ int panthor_sched_init(struct panthor_device *ptdev) ptdev->scheduler =3D sched; return 0; } + +#ifdef CONFIG_DEBUG_FS + +static const char * +panthor_sched_prio_str(enum panthor_csg_priority prio) +{ + switch (prio) { + case PANTHOR_CSG_PRIORITY_LOW: + return "LOW"; + case PANTHOR_CSG_PRIORITY_MEDIUM: + return "MEDIUM"; + case PANTHOR_CSG_PRIORITY_HIGH: + return "HIGH"; + case PANTHOR_CSG_PRIORITY_RT: + return "REAL-TIME"; + default: + return "UNKNOWN"; + } +} + +static int show_file_groups(struct drm_file *file, struct seq_file *m) +{ + struct panthor_file *pfile =3D file->driver_priv; + struct panthor_group *group; + unsigned long i; + + if (IS_ERR_OR_NULL(pfile->groups)) + return -ENOENT; + + xa_lock(&pfile->groups->xa); + xa_for_each_marked(&pfile->groups->xa, i, group, GROUP_REGISTERED) { + seq_printf(m, "client_id %8llu pid %8d command %s: group %2lu priority %= s queue count %u\n", + file->client_id, group->task_info.pid, group->task_info.comm, i, + panthor_sched_prio_str(group->priority), group->queue_count); + } + xa_unlock(&pfile->groups->xa); + + return 0; +} + +static int show_each_file(struct seq_file *m, void *arg) +{ + struct drm_info_node *node =3D (struct drm_info_node *)m->private; + struct drm_device *ddev =3D node->minor->dev; + int (*show)(struct drm_file *, struct seq_file *) =3D + node->info_ent->data; + struct drm_file *file; + int ret; + + scoped_cond_guard(mutex_intr, return -EINTR, &ddev->filelist_mutex) { + list_for_each_entry(file, &ddev->filelist, lhead) { + ret =3D show(file, m); + if (ret < 0) + return ret; + } + } + + return 0; +} + +static struct drm_info_list panthor_sched_debugfs_list[] =3D { + { "sched_groups", show_each_file, 0, show_file_groups }, +}; + +void panthor_sched_debugfs_init(struct drm_minor *minor) +{ + drm_debugfs_create_files(panthor_sched_debugfs_list, + ARRAY_SIZE(panthor_sched_debugfs_list), + minor->debugfs_root, minor); +} + +#endif /* CONFIG_DEBUG_FS */ diff --git a/drivers/gpu/drm/panthor/panthor_sched.h b/drivers/gpu/drm/pant= hor/panthor_sched.h index 9a8692de8ade..d87cbdba4d40 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.h +++ b/drivers/gpu/drm/panthor/panthor_sched.h @@ -10,6 +10,7 @@ struct drm_file; struct drm_gem_object; struct drm_sched_job; struct drm_memory_stats; +struct drm_minor; struct drm_panthor_group_create; struct drm_panthor_queue_create; struct drm_panthor_group_get_state; @@ -55,4 +56,8 @@ void panthor_sched_report_fw_events(struct panthor_device= *ptdev, u32 events); =20 void panthor_fdinfo_gather_group_samples(struct panthor_file *pfile); =20 +#ifdef CONFIG_DEBUG_FS +void panthor_sched_debugfs_init(struct drm_minor *minor); +#endif + #endif --- base-commit: 17c6b88e85ffe5de5720004ae8c2176d52944aca change-id: 20260814-panthor-sched-group-prio-c987f6a15690 Best regards, -- =20 Nicolas Frattaroli