From nobody Sat Sep 26 04:01:51 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D64B4EC661 for ; Fri, 4 Sep 2026 15:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788535447; cv=none; b=ZT3r6sH8XdrLgnqJn+rdY1Qs8vwkVoBdv5gR8FttU7dfXadGpHSslJ/8y29CXP3bjrQWBv2QOuGVO4M7mlBuI9hratldN/FNInNk7YeEbhyAVXFashDAyFfLU56bjdkQvcKFbW2lo/SBMIi1h/3HYUMINtqBZasq63l6/xrkVB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788535447; c=relaxed/simple; bh=3dZpk3ql/VOUcsd/ip7svqEsusEqDY6uWmgL27Pxopg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=pHyib9b0mZ+Ykz8wL+5lk7rTH3fwa9oAIxDqLcCmBxUG7ynCB7cZ2IJCfuEegskcuYdPor66yvDz5YdSurXWIkZqwY8LhGTOcOdu+NoXRKPZhbaw6zFzI0sDA15JaK1ys4Y7wn2aOC8zDwXEM5IJlTBJ9j2nWznoFAoIt3k3piE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thegoodpenguin.co.uk; spf=pass smtp.mailfrom=thegoodpenguin.co.uk; dkim=pass (2048-bit key) header.d=thegoodpenguin-co-uk.20251104.gappssmtp.com header.i=@thegoodpenguin-co-uk.20251104.gappssmtp.com header.b=IMP3AeYn; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thegoodpenguin.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thegoodpenguin.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thegoodpenguin-co-uk.20251104.gappssmtp.com header.i=@thegoodpenguin-co-uk.20251104.gappssmtp.com header.b="IMP3AeYn" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49b8be0409fso8146925e9.2 for ; Fri, 04 Sep 2026 08:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thegoodpenguin-co-uk.20251104.gappssmtp.com; s=20251104; t=1788535444; x=1789140244; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=G8jKhCG2cQQizumBfeZP6zYIa3G30UFI5xNJCludORg=; b=IMP3AeYn2d0DlpZmv1kUV4dyQyi7cxwFRF411rcOLQFQ6oq5BMsMkwEUj06CrizGVs ON7WmRyATPT7rCQir/bJ4Of/wo1CRQbohd8/vC4o0G+aGdOEQQGVT6sT3kOel5dHvo5K yCb/+8UIfnZopKYVNxYLbzAyMVx+t4aMo3OyysdgvBS1d98JWDIbt/lI0T41pruYIrsI XecNVlnPMW+mBuG4rR18xfpVze43EAvxq081JnprCZFQVcgcF2G7NCJivvbbJAcldtYl mtl7lPtprpaFVDaAqA4zqLuZrnzNSNlSeIixL02Jiwmc0Elvy7XkmKIOsvD8RaIrQYsR A4ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788535444; x=1789140244; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=G8jKhCG2cQQizumBfeZP6zYIa3G30UFI5xNJCludORg=; b=nYzGzMrgBnVIqwMH50IpUeEjKH+k9Aa2WjGt/x2RPlGQBqmJNQq6y6zxPy6s9k9UNt xBjU59/4HwV3yljw2r7DnBHhEuHMtvO2BxMLjLpTVcklyREwYwQEl39wn2xowlvHsV1H FwmVbPDWYYbkmoHHVF67ChK6QoMnYcQwifyrE4A+Ji4Logq/IzP2P40iTvpioPH60RY+ FYQl010/h5/pR5+tB9qtU0ariVDOskOqIPagCSA0PGJmJ0WO5z5uj2Krb3vSPOmPq/oi zyvNAGyZDJi+CJ8yA6SmXaAMj5r5BQMJVc0vntRMKh74L3z3qTKsEjSrMt0ygS2Eyv0x 5rFw== X-Forwarded-Encrypted: i=1; AKwUvBxiTlZKW+GjHrE2cV/3EJZTNpUGfjJ/J9bCcYv/r03NRk3Q6ZLdEh0ClZ5+inBwpByLrKpNre9Y9MWgj20=@vger.kernel.org X-Gm-Message-State: AFuF++lQN2iOv3AIToU0AyQ4wWwFntB39IbDipRd6IETm0OCNuIBm1B5 SPCHAFVbBELdkS7W778xDH+YvwTAW57NHybGKAOUZ+0/yB357jAdiErBa/stisq81nnIuTg5Uxi MaFBW X-Gm-Gg: AYBFou1tVePiPwpMMrmIlQQh2To5/D5NT4yviKdoHpyrww2wMhuIdWlD1Pf4Itt1yIz Mgq1c+jujvERqWg5Do0t6qxaAvASeSE/FkDbFzkwgzgqzYHpsYfYnMeSwlw41itTG32AcLx55Bp 8OS3pfggI/2MljMSYIlYEMg2G6PtgFm6mqZ/XC/A3CGAiyXOIpPp6UM0MgY3WiiRcrkcsYxiwd8 mU1nbZOlDmCDnNZ01/I70VWtx88efNowesA5M3w8Icm+Rkqc/T9Pf+z2OK99uwz30vrUeMWhh9l jtCbW/yFgD3kz9fAUzFPkxT4ykWJmw1BercBqioF0C6sAarH56sBikjQdAVZqyBab3WnTAkh9xf s2rXyLjVGJDaE8ObdLpnmchEwEeNe2kDyr02GE6ZxgBQwoytrOjOg2F/ccoyM3bqrE768u8boSf j5UVGk9EZJ+Wr6zJJCnEEU8ITlDjfEE9y34ZSHip4cOUve6u8Kv27/SgeO3969g6TC89I9Ilp0K bslKRXQtEiU4DTl X-Received: by 2002:a05:600c:4e0e:b0:499:bf8c:cfd1 with SMTP id 5b1f17b1804b1-49cf81e6063mr74559575e9.2.1788535444047; Fri, 04 Sep 2026 08:24:04 -0700 (PDT) Received: from [10.42.0.1] ([2a00:23c7:1d1a:9c01:2568:24c4:f44a:8310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf7736132sm74890805e9.12.2026.09.04.08.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 08:24:03 -0700 (PDT) From: Pawel Zalewski Date: Fri, 04 Sep 2026 16:24:00 +0100 Subject: [PATCH] firmware: google: use named initializers for acpi_device_id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260904-acpi-firmware-v1-1-7e4d7a09198e@thegoodpenguin.co.uk> X-B4-Tracking: v=1; b=H4sIAI/immoC/yXMyw5AMBBA0V+RWWtSguBXxGLUlJF4ZOqViH9XL M/i3gscCZODMrhAaGfH8+QRhQGYHqeOFLfeEOs404VOFJqFlWUZDxRSqSlsG+WIhBp8swhZPr9 fVf92WzOQWd8J3PcD/9U4hHEAAAA= X-Change-ID: 20260904-acpi-firmware-5c9fd18aaea0 To: Tzung-Bi Shih , Brian Norris , Julius Werner Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, Pawel Zalewski X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788535443; l=2650; i=pzalewski@thegoodpenguin.co.uk; s=20260430; h=from:subject:message-id; bh=3dZpk3ql/VOUcsd/ip7svqEsusEqDY6uWmgL27Pxopg=; b=tYx/OWBgdFUcq+ZTe5T/sNIp89JKZ7ZAt3rHXtCEoUnmLWeieC6Go9T+oUjdpscHDmg+76l3t JuXdYWjlaDwACe2n4wyH5LoGG7dNgsnp6jEZozPFKH05aYvAWmGfAkm X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=vHq4n9IonORH2GTzLv8r6CWAFHzgfBuNkQPXA8NSly0= Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base. Also drop explicitly setting fields to 0 where it is redundant. Signed-off-by: Pawel Zalewski --- This series is converting lists that contain the acpi_device_id=20 struct, which is defined in the include/linux/device-id/acpi.h=20 to make use of named initializers (which they do not use currently). This work is part of the on going effort in the kernel associated with device-ids [1] The plan is to convert acpi_device_id::driver_data to have an=20 anonymous union, similarly to what was introduced for PCI and I2C device ID tables.The goal is to increase type-safety (as most of=20 the existing casts are gone), to improve readability and to make use intent a bit more clear: ``` union { kernel_ulong_t driver_data; const void *driver_data_ptr; } ``` But for that to work all lists containing the structs need to=20 use named initializers first to avoid triggering -Wmissing-braces. I already have patches that implement this and touching a lot of kernel subsystmes that use the acpi_device_id struct and that list keeps on growing. Therefore, I have decided to split the series per every subsystem into: - pre-clean-ups that convert the lists to use named initializers (which is this series) - actual implementations that make some of the modules use the driver_data_ptr union member That way the task can be fragmented into manageable and independent chunks of work and makes this effort easier to review. Tested builds on a64 in Yocto using 7.3-rc1. [1] https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylib= re.com/ --- drivers/firmware/google/coreboot_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/go= ogle/coreboot_table.c index 25ee8cf53429..2c8c928fbb33 100644 --- a/drivers/firmware/google/coreboot_table.c +++ b/drivers/firmware/google/coreboot_table.c @@ -250,8 +250,8 @@ static void coreboot_table_remove(struct platform_devic= e *pdev) =20 #ifdef CONFIG_ACPI static const struct acpi_device_id cros_coreboot_acpi_match[] =3D { - { "GOOGCB00", 0 }, - { "BOOT0000", 0 }, + { .id =3D "GOOGCB00" }, + { .id =3D "BOOT0000" }, { } }; MODULE_DEVICE_TABLE(acpi, cros_coreboot_acpi_match); --- base-commit: bc35965f6940a9bf834d54187b6088b8eb09206d change-id: 20260904-acpi-firmware-5c9fd18aaea0 Best regards, -- =20 Pawel Zalewski