From nobody Sat Sep 26 07:14:45 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011046.outbound.protection.outlook.com [40.93.194.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 306994FB9D0; Thu, 3 Sep 2026 19:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788463259; cv=fail; b=BbIQFiYjyZ6QaLlJWnJvPINlXbtMi83I5GXjGSXkSjTgoU+dUMPEJ1pTW7UTaH1U68XpyDnErNm1cghbdRfBLBIYEp/X7cg6uq+/CalMwxsZfJrJZV00lnD41XJ6c3fAM1Kq87V/rZmtBWNFbl/hp9PqxDrZxSoU0OGD1pmjNuE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788463259; c=relaxed/simple; bh=JHX+ClqCHmbl3yxHj1j1Qh14p/CoTzskApT/G878HHc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s+Ipolw9YGs9O0KrIfjv8WKS5Afh/SemXCmmiKkQU1hg3EACjqqZ7rHvCc4w3HGpBNIuoAeooooKP5my04Fwl4tmDe3yMmpAGK5lqmhvPX8+31oWdHo0NllSd7LhhkuaLBaL6L2B8SzqlZ7cGWJbie1TFVvo3em331PrQ0CFxz0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=O/lp+ZIu; arc=fail smtp.client-ip=40.93.194.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="O/lp+ZIu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=koxi0eJoJAgaaQT9TmdyrMSgAkIsHGZ5SpG4zUDudHXlwvDX30rw6OFfQ45/XXU+AVMbc6LQJUNoFG9GVpXBdOsnNdpA/AegB4X+zdxs849EfoLvKdr0mrel+dQ+tPA/UIfUDKHJuQTA/e/PWisB/cZ3/Bz59MddBI89jsAUvhSpNTzo0ONt5TwGxgIVhEGMHIDcJDpQOuPh/I3k6Av0Vtv55PPClRI8siYdERP6cuLQ+WAGhCpg4BhImHGYNj0U6dWcZ0/+PSDGE1NYtYlUUX9cMAAV5KnEftsYXPNmxejuu+1H7xy1hqa/jvrBZU2qgBLUsol9fNaHJ9kqx+/KWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9pOfT5NABTVSjGQyUGnhcgDtMcasbgfkdEocM6q3KGo=; b=JuXGydAwfcWwQri3coGZ+mWVIIHrguKqvt6SQG6cCjmPEw6GMZPUMD0nxyxvmVwJzvz5A42FP4b38fdN6t8pjghWQ2ikMsOK60agn08L4wmhtJ3QsXW8N9eSysNVvRXNIWVxrEiUOqJAr0uwbZlTEaFC9YQDzkkIkt2E+WYZlwuCYwxboavwH87xlIZZXf3JIRG8iNMhemRZAsyo64k8+kpQKOKzGYv7Wz732ArT3bkgq989H4f4MGm6//ezz2wna9i5cEDQRCM4IL5RJwKHQyU2tEGXi7G5Vnqrt/srerhFah207HNTHNWzxhqWnj0BISzJYiqPwj+TyFkSXJVILA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9pOfT5NABTVSjGQyUGnhcgDtMcasbgfkdEocM6q3KGo=; b=O/lp+ZIuWSFsEAfIx+I9p4oFWwn+XT+Gg6Aj90oSopLre3QrDae4OR+Pme1u9KIUzLLMXCA0DtpLb20r1RMBhKitGx2JEjjlFMJeAis8+0w6404pVM43mFZCanaULEWn9gwZ4yit8TW0Kn5Msmttmz3WwtrBT2+jFcGtXqdYIE6ML8kXtngzMrNdUD7/OMPm6zVkh29mBGIBiRHAm8ZNF0aYM+2bUWIWh4tbRu9Jqo7BVxK/EehY+cNNL1SUJC1O/tC3CBe0/EQt+3BC4+znG1X77hT/0cz7eKP7z0FveBA/qFQdwRPeKOWrHtRdGulfZlSYowam8+pIEm7FrQQvlw== Received: from CH5PR05CA0003.namprd05.prod.outlook.com (2603:10b6:610:1f0::16) by MW4PR12MB8611.namprd12.prod.outlook.com (2603:10b6:303:1ed::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.13; Thu, 3 Sep 2026 19:20:45 +0000 Received: from BN2PEPF0000449E.namprd02.prod.outlook.com (2603:10b6:610:1f0:cafe::2) by CH5PR05CA0003.outlook.office365.com (2603:10b6:610:1f0::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.4 via Frontend Transport; Thu, 3 Sep 2026 19:20:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN2PEPF0000449E.mail.protection.outlook.com (10.167.243.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Thu, 3 Sep 2026 19:20:44 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Thu, 3 Sep 2026 12:20:17 -0700 Received: from vdi.nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Thu, 3 Sep 2026 12:20:16 -0700 From: Chris Babroski To: , , CC: , Subject: [PATCH v1 1/3] i2c: mlxbf: Fix master GW corruption from unmasked SMBus flags Date: Thu, 3 Sep 2026 15:19:59 -0400 Message-ID: <20260903192001.114263-2-cbabroski@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260903192001.114263-1-cbabroski@nvidia.com> References: <20260903192001.114263-1-cbabroski@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449E:EE_|MW4PR12MB8611:EE_ X-MS-Office365-Filtering-Correlation-Id: 74483bc8-f51d-4769-6661-08df09f073b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|23010399003|36860700016|1800799024|11063799006|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: NdU4eYKGzmkC3oNSTqoj/N+VIKum1b2NSGI/hI0kJGnQ6tF2O3eYCVTD+99ghEF0X2r6a1dvnoQTUJ2zGqYrkJAmTYYQG2sRl8mKgOX4PlracQORr71E5yqv+TfJIte1YfObTHtQSDJL7stDlsffbPSKBVEB8BG3XVEclj/5LbFR3gUdUggI3w5Bf1LTTSTUH6/173B/OY28p8YyfiLkb0C/Eq4GFntpa/IA9pqVfnxNjNtmUJZKTaoxTnLjZU0dEHgxvzHBOT1I0CB+NqPsdAcgk5N44X5HqXL3VlLhTKclVXNXQWkNZWhoJZDO1CiPrmecGAUsliubw7ODJhREIx7z9b6E3Oqhm/86lTsxvL/PDPd3wa6EMq1fT3qdMMbPKPAzKtjbjQ+t6DhUcDidPmj7gkBtsWEZHhziA1nCpbuzjajv7GlbzOBFGu7IkgWEBRRqAsLlq1b495/yD8I+IFOR6tB4CoETCEm3MNGbfVU1za5hynT2taKJsKmxkj7aIN1npr7H96mNZ3KPTS0W3gM0kq6SAyW5tEGvWWx/VnHxyUN7+rJeRptu159kKF3Xj+CJF63a38B7XMNHE/5kR7So1qp5v99PGMp7WEu271mLw0Z3oKsUTMM8/FdHTVJULGEEy7feArSbyo2JJXjD5GVlbvpGP/TePsMxlA7eD5HiokjfZGl4XrY4O33rf/ycO1PfrKpphxZVb7w0hPQvaA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(23010399003)(36860700016)(1800799024)(11063799006)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6a36oWqHRBh3HKIUGxrYyP9YQzKjfRos0VR9S9eupM6VnXLFZw5j5GBPUTtj3cTYv0UITvoxjp19zbbDQreRb3pERTjPB+TvjCw5+U2mo6mBpb0iPUbCRjRSn3uEVN1ejE310CRGtf1xsFMxaahO2jQMr8ljtJ4vyRyd0XmGmeSXX0ucQ/8BAkV4Qn4BoU4fYIE757dIReKIqoHdYaaeVKTJkRLN2+CwgjGl6X0J4l6C04Mv6jAnIR9jdEgppQWdSMUh2K10ePT1N4ZOxhmBtYp/cBLXcFWGvZeaJ5zoGdEk/e4ssgk5Dtr3rnawuowO4C6hrAwpUvNHczY0WwssKR+ZK+RA8D/0FRk0HSDZbC8AawnGnaq9jMNm1wYcnvH3eWrEvsQsS6Uk71IWTtUgtA/IcN2HuU15X6tykJfk0AfEJfUUnql6K0vMCVEImrX9 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2026 19:20:44.5924 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74483bc8-f51d-4769-6661-08df09f073b3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB8611 Content-Type: text/plain; charset="utf-8" When the MLXBF_I2C_F_SMBUS_BLOCK and/or MLXBF_I2C_F_SMBUS_PEC flags are set, the flag bitmask values are shifted and written to the master gateway control register instead of the single-bit flag values. Shifting and writing the bitmasks can corrupt adjacent bits in the master gateway control register like the slave address used in read phases. Convert the SMBus flags to boolean values before setting the master gateway control register. Signed-off-by: Chris Babroski --- drivers/i2c/busses/i2c-mlxbf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c index 24ccc4546ab8..93fc9f0ba72c 100644 --- a/drivers/i2c/busses/i2c-mlxbf.c +++ b/drivers/i2c/busses/i2c-mlxbf.c @@ -740,8 +740,8 @@ mlxbf_i2c_smbus_start_transaction(struct mlxbf_i2c_priv= *priv, * submitted by the first operation only. */ if (op_idx =3D=3D 0 && flags & MLXBF_I2C_F_SMBUS_OPERATION) { - block_en =3D flags & MLXBF_I2C_F_SMBUS_BLOCK; - pec_en =3D flags & MLXBF_I2C_F_SMBUS_PEC; + block_en =3D !!(flags & MLXBF_I2C_F_SMBUS_BLOCK); + pec_en =3D !!(flags & MLXBF_I2C_F_SMBUS_PEC); } =20 if (flags & MLXBF_I2C_F_WRITE) { --=20 2.34.1 From nobody Sat Sep 26 07:14:45 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011037.outbound.protection.outlook.com [40.93.194.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 468073F326F; Thu, 3 Sep 2026 19:20:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788463265; cv=fail; b=SuO96eZ/TRiHYMBsusjw3O8ZbE7sg6EJXLc1FhX0BhZ0a/EuOh7wv7iMYGxgH9DB8iFViROFxJCl9wdOyB4izPsTMojrw4Im8Qg+mErQh2affSgs6gWsHy2OPIWXZr2zoO5UgXthoTUiDIBJ1F0HDdfJqqxyclvNH8Ve9fmuCkY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788463265; c=relaxed/simple; bh=WSty7POrxHuubrjL8qc1l/sbNrq/qcsPIXgEGlGr5gY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qK24F/ZZNtkQa2BUgQT6+p+KPYP1PaIALVtBYqgDzpRKdnEkbSt1t9N8pOPlczJ/aYGv4hypjpqEAkbjqjeIEn6O0RlyVnqUPZmrXzsjUMwijns1EAGKxFIFoNH+d2qj20/jYwbjZ2FT9dNZ+JFxowdlbrx7isvYfCyCE0s5zs0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=iNmrbOks; arc=fail smtp.client-ip=40.93.194.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="iNmrbOks" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bx5uN9NY3MVZSah/IPmEeI/Zl7Y77666qRZvJco70kGaLhldm95jiEk/CkuWVIhFPNZvu3vEfhmxiuSaBM891kzPEAXURTjINbR6hAl/XHGtNaQdDDonDcUJGjScbb4iOTbJVsXHAhKrO3Tf9R6wSJEZVK6DX8N86J/gy6Z+LaOblj7kOo9cSXamxS5xm6U1dl1zggYdYZU63aqRE/0XzFG9u7fYomgGEFcXayYXFL3PcnQtt+98WJmotW0ZBAi0DonmPKZ1JFC0dAfTVbuIjkGUuV/oriXqLJ2roPLYMLf4hQaSHJ4tMMQVoj99v4l/ngWKXnM2KZqytrRSXYjkLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WD9x1z3wiPM1Ga8e66LGCp0v3Bpu/rav0mT0ZgphOjk=; b=GFmtn8T00Li56PATTZUTRwBzb6qsxNNZnlQAjsv5rKeHspRIOaA9VHdhC+0FUMVHcuvlehIc+1KkAsA7eG1XYtwuqtoYkL+34xi7aCshWXDYlYf+Eyah5aveYQWzrh9NlbFNdrh2DoS2k+Vn4XYKn/tCYfWVhxDOCeZg69+Zo7MAc3caDL14qtrKgxaL/WqyK5U1c3/eLc8jhmU2SxlZYjaqqCU2r+SnoH5prVHy/7S0fo1czvuhBE0td2QJUmafDjLDrMZGWX1AbKI4EI/joQy+c32m44zEejjOQTRlo1ea7du1ZTfE6W8jC0Kj4H0O+mmG/gABuIMGIm8Cc4t76g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WD9x1z3wiPM1Ga8e66LGCp0v3Bpu/rav0mT0ZgphOjk=; b=iNmrbOksaFI+cgihyoFaVGA0oaCaBgcoxV0ZhE8JqQqYMGnWQVQs/c/URhzcCgzUH8xHxblJzRwqMUIqFSPHsYrmdK61cjGra23Hwe4LZB+5krOKf2nXMI59u4h5GWJ7VYWNJi86nHIP/+3zVh0yxT0UKAmDAt1T0MaBoocBEVWAAJ7Lbnewn+fx0mmm91w/WH0iDcM3fu76vdVNAjUiYTC65MuGv8T4RHkU9oXHJ9JsGImVZtefNT11slOHbWK177BsVJwHMGEHekf3Ww3YRSoUDyvRXYxhTGdCZFF44HrAPjUlyz36/tAfg5saMyOGz0Y4trhkTgAh1oBXLyrq/g== Received: from BN1PR14CA0007.namprd14.prod.outlook.com (2603:10b6:408:e3::12) by CY8PR12MB7243.namprd12.prod.outlook.com (2603:10b6:930:58::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.13; Thu, 3 Sep 2026 19:20:47 +0000 Received: from BN2PEPF0000449D.namprd02.prod.outlook.com (2603:10b6:408:e3:cafe::a) by BN1PR14CA0007.outlook.office365.com (2603:10b6:408:e3::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.12 via Frontend Transport; Thu, 3 Sep 2026 19:20:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN2PEPF0000449D.mail.protection.outlook.com (10.167.243.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Thu, 3 Sep 2026 19:20:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Thu, 3 Sep 2026 12:20:18 -0700 Received: from vdi.nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Thu, 3 Sep 2026 12:20:17 -0700 From: Chris Babroski To: , , CC: , Subject: [PATCH v1 2/3] i2c: mlxbf: Use GENMASK()/FIELD_PREP() for GW fields Date: Thu, 3 Sep 2026 15:20:00 -0400 Message-ID: <20260903192001.114263-3-cbabroski@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260903192001.114263-1-cbabroski@nvidia.com> References: <20260903192001.114263-1-cbabroski@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449D:EE_|CY8PR12MB7243:EE_ X-MS-Office365-Filtering-Correlation-Id: 86e7bcd0-4b8a-4246-c731-08df09f074ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|376014|23010399003|18002099003|22082099003|56012099006|10067099003|11063799006; X-Microsoft-Antispam-Message-Info: PGWULStsDr3V0tcLb1ddWwe6Sk2AMu2Qf/qm2U0yweFysroVrVaKOtne9zjYU6zwV2Co54pUHrs0EbjQfzcOyAc+JYB+WqLxmytXvf9HbXjoxlfnXQBFiNcFYRbsBLrJMi4K3qOelhgokGwwdWQvdPki0vTRK//zSP7NvL00ncOlMTgqt02rx2k3To32LLfaS/RqQ1siSOxVYY4ljtYbyTx+5yZx4RD1ngCfyi0CjKO8BkA/5b9fgW3NV8amyCsVsUYsBBbyM76ZrgZD0OgAv4rj5ClguyMeonF9PaB9fRqM9RI+aPhx/OWVXU3w3amVrMspNWcbnv+zcaaRCncs0g6szZ6+vurtGHYmOeyhUK9IblIkexTzJ4sSplqjBEcOH/s1zClJr+ztmYsNbJcLWN9LVkWXspU2izTmdCFzY+C6RHL9hJ1Og+ditkXa4zu/vIFRviDIZ6Anz7eetp3czG9wNLWxyuL3VoeSS+8/CQa8vWxwpD/NKuZ4rqknEXsK95eOeSXeQue77UKz1AjPUZucC/qKkVUqVNofXI3d+e+9bNldM8+iAedgkTMBS1q5i+4fwOAczrLSCBU6RMiwMRzqClghl8SPvr5u46v8hAgay5vJ8NQHjrgE1gLC+izmH2AUrShelovxHnRBWxAsodLcEhXTjVwdNKckwy3R0wcdo3fXAxOLeTQ5/qr09pT0hc2+olVUHp9Bg0x9EQvp2Q== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(376014)(23010399003)(18002099003)(22082099003)(56012099006)(10067099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: t/9iVWhQ0Y5SoTMuSUo6c6G7EnKV3o4y19HqwsKPHSzuuxsYgS7a2TqKH5RD+YxZOkK2OjY4oAxux1VSWP2QpUL/XrpGpjK9pz7/WZ0KCDPB9xmPjSsQ2T6/yWyjWAN0nSo8z0zYeBxgij/40k8dEsIKn2jSmec6YPYZ4/55cQPcEk3yCsZ8pAcUucTrd/3g330S3o6ToBni9CGT6K7BEFVPeoHP9X7veoXqt+JJm0c9nzz9Mkh4YdnDM1rNaX6Bm1jxr4Abe4iZtFnRf0yXtDT6AdpTsM0gL93HnUUOtXh3W/6zHzEoaoaN9JDi2EWmMQaQ703bvL3JLKauVMZrq5ChsDQVyG8GYDek2Eq+rKBuyz1Qn/EclHneiBdqIpx/q6tRE1qpyTunhLwHYEwsd00Rgb+0qbaq/feHvu4dQrxfZuVE5GUfucqQJlJTYIxu X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2026 19:20:46.3197 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86e7bcd0-4b8a-4246-c731-08df09f074ba X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7243 Content-Type: text/plain; charset="utf-8" Replace the explicit shift amounts and rol32() calls used to build the master and slave gateway control words with GENMASK()/FIELD_PREP(). This makes the field widths explicit and matches the style used elsewhere in the kernel for register field access. Also change the single-bit master GW PARSE_EXP and SEND_PEC control bits to be set with a plain conditional OR instead of rol32(), since moving a boolean into position via a mask is no longer needed. Signed-off-by: Chris Babroski --- drivers/i2c/busses/i2c-mlxbf.c | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c index 93fc9f0ba72c..2d2dc234db7a 100644 --- a/drivers/i2c/busses/i2c-mlxbf.c +++ b/drivers/i2c/busses/i2c-mlxbf.c @@ -219,7 +219,12 @@ #define MLXBF_I2C_MASTER_BUSY_BIT BIT(30) /* Busy bit. */ #define MLXBF_I2C_MASTER_START_BIT BIT(29) /* Control start. */ #define MLXBF_I2C_MASTER_CTL_WRITE_BIT BIT(28) /* Control write phase. = */ +#define MLXBF_I2C_MASTER_WRITE_MASK GENMASK(27, 21) /* Control write= bytes */ +#define MLXBF_I2C_MASTER_SEND_PEC_BIT BIT(20) /* Send PEC byte when se= t to 1 */ #define MLXBF_I2C_MASTER_CTL_READ_BIT BIT(19) /* Control read phase. */ +#define MLXBF_I2C_MASTER_SLV_ADDR_MASK GENMASK(18, 12) /* Slave address= */ +#define MLXBF_I2C_MASTER_PARSE_EXP_BIT BIT(11) /* Control parse expecte= d bytes */ +#define MLXBF_I2C_MASTER_READ_MASK GENMASK(10, 4) /* Control read b= ytes */ #define MLXBF_I2C_MASTER_STOP_BIT BIT(3) /* Control stop. */ =20 #define MLXBF_I2C_MASTER_ENABLE \ @@ -232,12 +237,6 @@ #define MLXBF_I2C_MASTER_ENABLE_READ \ (MLXBF_I2C_MASTER_ENABLE | MLXBF_I2C_MASTER_CTL_READ_BIT) =20 -#define MLXBF_I2C_MASTER_WRITE_SHIFT 21 /* Control write bytes */ -#define MLXBF_I2C_MASTER_SEND_PEC_SHIFT 20 /* Send PEC byte when set to = 1 */ -#define MLXBF_I2C_MASTER_PARSE_EXP_SHIFT 11 /* Control parse expected byt= es */ -#define MLXBF_I2C_MASTER_SLV_ADDR_SHIFT 12 /* Slave address */ -#define MLXBF_I2C_MASTER_READ_SHIFT 4 /* Control read bytes */ - /* SMBus master GW Data descriptor. */ #define MLXBF_I2C_MASTER_DATA_DESC_ADDR 0x80 #define MLXBF_I2C_MASTER_DATA_DESC_SIZE 0x80 /* Size in bytes. */ @@ -288,7 +287,7 @@ #define MLXBF_I2C_SLAVE_ENABLE \ (MLXBF_I2C_SLAVE_BUSY_BIT | MLXBF_I2C_SLAVE_WRITE_BIT) =20 -#define MLXBF_I2C_SLAVE_WRITE_BYTES_SHIFT 22 /* Number of bytes to write. = */ +#define MLXBF_I2C_SLAVE_WRITE_BYTES_MASK GENMASK(28, 22) /* Number of byt= es to write. */ #define MLXBF_I2C_SLAVE_SEND_PEC_SHIFT 21 /* Send PEC byte shift. */ =20 /* SMBus slave GW Data descriptor. */ @@ -643,14 +642,19 @@ static int mlxbf_i2c_smbus_enable(struct mlxbf_i2c_pr= iv *priv, u8 slave, command |=3D MLXBF_I2C_MASTER_STOP_BIT; if (read) { command |=3D MLXBF_I2C_MASTER_ENABLE_READ; - command |=3D rol32(len, MLXBF_I2C_MASTER_READ_SHIFT); + command |=3D FIELD_PREP(MLXBF_I2C_MASTER_READ_MASK, len); } else { command |=3D MLXBF_I2C_MASTER_ENABLE_WRITE; - command |=3D rol32(len, MLXBF_I2C_MASTER_WRITE_SHIFT); + command |=3D FIELD_PREP(MLXBF_I2C_MASTER_WRITE_MASK, len); } - command |=3D rol32(slave, MLXBF_I2C_MASTER_SLV_ADDR_SHIFT); - command |=3D rol32(block_en, MLXBF_I2C_MASTER_PARSE_EXP_SHIFT); - command |=3D rol32(pec_en, MLXBF_I2C_MASTER_SEND_PEC_SHIFT); + + if (block_en) + command |=3D MLXBF_I2C_MASTER_PARSE_EXP_BIT; + + if (pec_en) + command |=3D MLXBF_I2C_MASTER_SEND_PEC_BIT; + + command |=3D FIELD_PREP(MLXBF_I2C_MASTER_SLV_ADDR_MASK, slave); =20 /* Clear status bits. */ writel(0x0, priv->mst->io + MLXBF_I2C_SMBUS_MASTER_STATUS); @@ -1888,7 +1892,7 @@ static int mlxbf_i2c_irq_send(struct mlxbf_i2c_priv *= priv, u8 recv_bytes) =20 /* Prepare control word. */ control32 =3D MLXBF_I2C_SLAVE_ENABLE; - control32 |=3D rol32(write_size, MLXBF_I2C_SLAVE_WRITE_BYTES_SHIFT); + control32 |=3D FIELD_PREP(MLXBF_I2C_SLAVE_WRITE_BYTES_MASK, write_size); control32 |=3D rol32(pec_en, MLXBF_I2C_SLAVE_SEND_PEC_SHIFT); =20 writel(control32, priv->slv->io + MLXBF_I2C_SMBUS_SLAVE_GW); --=20 2.34.1 From nobody Sat Sep 26 07:14:45 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011057.outbound.protection.outlook.com [40.93.194.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 108413EEAD8; Thu, 3 Sep 2026 19:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788463265; cv=fail; b=oMffOrmiIIsfb4Qnr9IiUG1DyKYgPP5iEz9Yytms5o4rfYhB0fVOvDVXp+2ya0d+3q8XbvFUoG9DHcMZtZ4pPvWqeuv98nZ5mq9MNcSRdHvPD0CDHHs6fzZAn42syUWSZF4m/CpM+lTLVjvA2Jabu1II9T2kNsvMpBERtFOIDQM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788463265; c=relaxed/simple; bh=kBG7JB1HUHF9YGiGJUkQWPVBXNvzJ+Sbu+LsrhRdJfY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OeSoShFLvpojG89J1FkoCt68/4g20NLK6KzwNdWU544i0EYfynkuvfUrCszuc/sCyaVre7A9HLIk96yY/KU5Ox4y5/iUeSSu/LdruNiAvkYcXCBazPAb2iyznYy1VewWQVOHoj1NAJS3FGcPy9tfC8PnL3Z4+N053O3gWTSmy/I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=kFwRwOLU; arc=fail smtp.client-ip=40.93.194.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="kFwRwOLU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=viUbpLB9yg6jE51d2EVnxozgqlAXo3uWl67NhATlEXhTt62i6U4QctGHNg980/FHAC81gUm01F/M6FKjmnc6CugZUzzd22ASZWn6GYmfinryH2+LPXVjD9gWnabGJhRXMteR+FpqsTC+h5uZIqen5N9IU8Lk4G9KBd7rSwOxmjIHgWoP0UA2wuhVH22EdCwT5Vkg8SrZ1uGlkNrYXxu78wPokG9Dl5Yc3q863SEZXxpi9xxgdPecjIoHXa8UmjswTeu8Z7cL02gidhX9LHjCJnJCYoxRAEKuFANCsYm0aYR4vT+nkCvTd65KBDDs/g0hngwBJo4wo0hCrKFDQEbwTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5NoZDDKdZAQt3LVexNxELn34Es3F/PegtKn6o7HV3F0=; b=cFNEsR2bnO1O11EKFN3bQUJ0DyWfkbgKzw0cF3U60nCnbxaWJUaIq8CQzlg4nqwn+T9Z3FQ1BqtmRR5kf+O6W7udO1TswpirMyL9v8455XuQVjjeHjwJ/3bhMbOvjMkO1ed1+3HVBvKY0sgQWwwYMYav+G0K+aCmC2zS2ynGm1d1tdIk6cLsbf3X/MlsAWYY7yWMFqkvX9jGmLe/392Kb0EdWX+B0IeYSJVzemcIsYqRp7w10UpWUV8JbFCfKMCIhVqEEZuz+JDlpoQNDw+PeM3hTibRX2hq1aHJAk49eV7GqG7lotRljfO9EEpPbXZWzGcKdAhb9YJS33Sua3hPsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5NoZDDKdZAQt3LVexNxELn34Es3F/PegtKn6o7HV3F0=; b=kFwRwOLUrVS1Nk7Dimsk18STIOcVTJvsh28ASB8CCONgqZBbPyGzMUP/AJOInw2ON6moB2SeDc9mctlvzfLCgzGm61J85fzxrW4+Nx+nYbfHnSfnHHYS4/YbBqOKvYoRaEyIkpiNYTZxYjko3U2adYXaf/Xy9ZmWS5V4YFZrmOKnIh5RihqivqYYBKxdpUsllJkakjuzJlvpLrX9G5iFpLzW45aFhLfAVn2Rj1QHbG2vKz0IbphlJQuDclKXrbbNq31Vn9S1junp9BMohYQYGPLpojDAVl+7gM/e0Gj5Om8obuckCAeSxTdfqq+Gwh5/GPABdeBYNpKhREnXlRllwg== Received: from CH5PR05CA0017.namprd05.prod.outlook.com (2603:10b6:610:1f0::7) by LV2PR12MB5918.namprd12.prod.outlook.com (2603:10b6:408:174::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.13; Thu, 3 Sep 2026 19:20:47 +0000 Received: from BN2PEPF0000449E.namprd02.prod.outlook.com (2603:10b6:610:1f0:cafe::59) by CH5PR05CA0017.outlook.office365.com (2603:10b6:610:1f0::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.4 via Frontend Transport; Thu, 3 Sep 2026 19:20:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN2PEPF0000449E.mail.protection.outlook.com (10.167.243.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Thu, 3 Sep 2026 19:20:47 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Thu, 3 Sep 2026 12:20:19 -0700 Received: from vdi.nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Thu, 3 Sep 2026 12:20:18 -0700 From: Chris Babroski To: , , CC: , Subject: [PATCH v1 3/3] i2c: mlxbf: Remove unused slave GW PEC handling Date: Thu, 3 Sep 2026 15:20:01 -0400 Message-ID: <20260903192001.114263-4-cbabroski@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260903192001.114263-1-cbabroski@nvidia.com> References: <20260903192001.114263-1-cbabroski@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449E:EE_|LV2PR12MB5918:EE_ X-MS-Office365-Filtering-Correlation-Id: c78fef5c-2076-4044-bbf1-08df09f0756a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|82310400026|36860700016|1800799024|10067099003|11063799006|22082099003|18002099003|56012099006; X-Microsoft-Antispam-Message-Info: +7VZk0a7sej5K/QMS5HYqhdmMfqnNU+Vu9CtPh6sGoFvomyaYbwR0sBypl9mUqiMftehboP28dwqS0skFIdMJrdBBtrc9V5FW8XADJQBbU8GpolkaT7fZZllfXD5GTqHEU0+y3wObsRJATx4PXoojeGJQycH7yir+7NFN+9eaZAdcwkSmXaXYHxuAEFNRdUzyPz0MlCQrgEuw3ikERZ9CreMnXMzde6RcSvFfG9JVZqCSGVLzYXv3/jSGWXsc78OKTZftWmL57OfOmIx2CIQnQVbnGzVKCE/BscMqkwxvbwACqo2/ELMGyxcbx+iWj0hn5g6kZbsVBlbjvkyc2n0Tt9Omfr1MJsi/nyJokL/j15NV7GXEWoje8lb3sdHC/5tVdaTU6J/4vHk9zSFDm8L9WHmv32MPFPVo+aw5jhUuptG4lkfY1Z819lDGIRL0Z1sk3fMh9Dp0ET/nRZxjDjxNgFx9bBkUefgagGwMRXgl2X1sdANyaq92ECXHa6VgsMsAP0InAdrTBtKbSrOo92+jYDmii65THaPHXXOb667D8aQ6oVI1m6Zh+y0olr4t3ZqIfvc19Kd42qxtbcaVvKj/HCXYVq3RbYIe9WSMyav1imCSLyzktodjzYc/I0MBePeHgdSgkBC3h4Y8oZCHlitCjJc7NhrC+wVVjNCxz/eYo5yhGjfkmEEKmC5yQoSms9zLy5kMfgfzTrEXzFbyzxRJg== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(23010399003)(82310400026)(36860700016)(1800799024)(10067099003)(11063799006)(22082099003)(18002099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: f7F0+BGXGakmkBuKCY3gxrj4Gtoj93oTS8SA0SDe7ZqvaLlrHSlxuSX1iAuAyvPvUP9YJbkPghEkv7YtgUKb2mYBHkGwtLyH5s7ivrhjPPV8z6+mN6FQBVMNxflwI4u9t1og59nxj/Ah3SHyNFsmY6ykt0ldSAv2c5gdKc/E9iN51wAPTf+Wdisfsx/pyIFOvhl1BtmbBZ6sK9GNR+1gu4mtnfOE9gtFcJqro9JFkTsAsf7z2i/IwqQPYILnPE5TAytPzVxkzKiVDsViWyBMzyFmemNrnyx5RiYf+RFT7Cu/heuGY+3S1kvmP/eSupKBZf/Sz+FdZzdhNTCm7Cg9+A/w58UOMsrXTS5qv3Rr5b8Zzrh6TPI/AAmGYCMLj6kHYjQtiyQH1irNpgyBB0Ol0ljOqJ6LvWpxn9bsfKqs+eEBDjJ31/28469ytGXP0Ki3 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2026 19:20:47.4801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c78fef5c-2076-4044-bbf1-08df09f0756a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5918 Content-Type: text/plain; charset="utf-8" The slave gateway control word write always cleared its SEND_PEC bit, since PEC is not supported on the slave path. Remove the dead pec_en local variable, the corresponding register write, and the now-unused MLXBF_I2C_SLAVE_SEND_PEC_SHIFT definition. Signed-off-by: Chris Babroski --- drivers/i2c/busses/i2c-mlxbf.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c index 2d2dc234db7a..deaf22df68d0 100644 --- a/drivers/i2c/busses/i2c-mlxbf.c +++ b/drivers/i2c/busses/i2c-mlxbf.c @@ -288,7 +288,6 @@ (MLXBF_I2C_SLAVE_BUSY_BIT | MLXBF_I2C_SLAVE_WRITE_BIT) =20 #define MLXBF_I2C_SLAVE_WRITE_BYTES_MASK GENMASK(28, 22) /* Number of byt= es to write. */ -#define MLXBF_I2C_SLAVE_SEND_PEC_SHIFT 21 /* Send PEC byte shift. */ =20 /* SMBus slave GW Data descriptor. */ #define MLXBF_I2C_SLAVE_DATA_DESC_ADDR 0x80 @@ -1822,7 +1821,7 @@ static struct i2c_client *mlxbf_i2c_get_slave_from_ad= dr( static int mlxbf_i2c_irq_send(struct mlxbf_i2c_priv *priv, u8 recv_bytes) { u8 data_desc[MLXBF_I2C_SLAVE_DATA_DESC_SIZE] =3D { 0 }; - u8 write_size, pec_en, addr, value, byte_cnt; + u8 write_size, addr, value, byte_cnt; struct i2c_client *slave; u32 control32, data32; int ret =3D 0; @@ -1888,12 +1887,9 @@ static int mlxbf_i2c_irq_send(struct mlxbf_i2c_priv = *priv, u8 recv_bytes) mlxbf_i2c_smbus_write_data(priv, data_desc, byte_cnt, MLXBF_I2C_SLAVE_DATA_DESC_ADDR, false); =20 - pec_en =3D 0; /* Disable PEC since it is not supported. */ - /* Prepare control word. */ control32 =3D MLXBF_I2C_SLAVE_ENABLE; control32 |=3D FIELD_PREP(MLXBF_I2C_SLAVE_WRITE_BYTES_MASK, write_size); - control32 |=3D rol32(pec_en, MLXBF_I2C_SLAVE_SEND_PEC_SHIFT); =20 writel(control32, priv->slv->io + MLXBF_I2C_SMBUS_SLAVE_GW); =20 --=20 2.34.1