From nobody Sat Sep 26 07:59:35 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B349D4963BA; Thu, 3 Sep 2026 11:48:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436128; cv=none; b=BrvVDoILi+vNz801XSOMNT2JlXx99u+oziAx8Mkj1Pl+0CXxBg9Ft6pYLe5pqhcetqa2qd6oKnFUQ77pwhDZyiTfCFMeEuJ9KekdCgUbJi1tkcfgr1J2/oVqh3MFUrGBxzQg0ECEpZ4rLCkzzLaDKKc0TH0gEqmxAqy4DAyYNn4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436128; c=relaxed/simple; bh=bGa2/5JDzh3TVEiG+tkgj/DTA0QkKftaBg3BIIR7AUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YpW1k5Lrv7uM7a1QYq3rAV0L3zb92YVBYdbJTavUAsj9ljWyLW7cP6rs05enADUAl0r2ai2PP4BiW+moe6J9+qHU+DEM455sF8xP2YPv2WPvl2NN4zl0JkvV2YelU95tvUja7XtThQjqVnPI+C2KMU9MQR/M3sa4Qv6uiObouwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=k4kOH51Y; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="k4kOH51Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788436123; x=1819972123; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bGa2/5JDzh3TVEiG+tkgj/DTA0QkKftaBg3BIIR7AUI=; b=k4kOH51YhqPVwSqUjXBpBfU3rvSCJlmIsG4np3SV9AicSXZ1t5jn4Hp9 yWzVK0+UznpEoPL9sRk7dBZpZBYR3vn/mAREnSUcpiEA8dUiyqW4cWjHz OuhfwGaDMPmVxAFatI2HeN3UAwSG4i+TX+oALy+pWMp1ouTFNAfRY+YAC 2SOdTG/FFlZpWSleXRefPdbwt5qnZSAjoaotuSuXnrFQ9fOqdQi4wYS1l Uyi/UN5LLJ4Nk/oYv7aenPxDfMuNtOvWME0VU4WaYoTNWxy6kAKOs3GdI C/4Vf/hjqn3Cw9vn1Kx4shludhwe2GbZHgqJnonwYN2DU01JKhc4yTii6 A==; X-CSE-ConnectionGUID: Ve+34ebERG2r14PElqzWBg== X-CSE-MsgGUID: kt+5q32oSTykHe9FJe824A== X-IronPort-AV: E=McAfee;i="6800,10657,11894"; a="106436198" X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="106436198" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2026 04:48:37 -0700 X-CSE-ConnectionGUID: qNNSb7JkSH+3d+RAwvBPWg== X-CSE-MsgGUID: +6t5g5VqRTiAJaAik2juFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="270235103" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa009.jf.intel.com with ESMTP; 03 Sep 2026 04:48:35 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 3545B9B; Thu, 03 Sep 2026 13:48:34 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Andy Shevchenko , Linus Walleij Subject: [PATCH v2 1/3] pinctrl: intel: Move intel_pinctrl_get_soc_data() upper in the code Date: Thu, 3 Sep 2026 13:46:12 +0200 Message-ID: <20260903114832.1996235-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260903114832.1996235-1-andriy.shevchenko@linux.intel.com> References: <20260903114832.1996235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" While it's exported function, move it upper in the code to be on top of the local user. This brings a consistency to the follow change that will introduce similar helper for the intel_pinctrl_probe_by_hid(). Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-intel.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/= pinctrl-intel.c index 261ec2ee63ef..fd02409a2415 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1714,18 +1714,6 @@ int intel_pinctrl_probe_by_hid(struct platform_devic= e *pdev) } EXPORT_SYMBOL_NS_GPL(intel_pinctrl_probe_by_hid, "PINCTRL_INTEL"); =20 -int intel_pinctrl_probe_by_uid(struct platform_device *pdev) -{ - const struct intel_pinctrl_soc_data *data; - - data =3D intel_pinctrl_get_soc_data(pdev); - if (IS_ERR(data)) - return PTR_ERR(data); - - return intel_pinctrl_probe(pdev, data); -} -EXPORT_SYMBOL_NS_GPL(intel_pinctrl_probe_by_uid, "PINCTRL_INTEL"); - const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(struct pla= tform_device *pdev) { const struct intel_pinctrl_soc_data * const *table; @@ -1757,6 +1745,18 @@ const struct intel_pinctrl_soc_data *intel_pinctrl_g= et_soc_data(struct platform_ } EXPORT_SYMBOL_NS_GPL(intel_pinctrl_get_soc_data, "PINCTRL_INTEL"); =20 +int intel_pinctrl_probe_by_uid(struct platform_device *pdev) +{ + const struct intel_pinctrl_soc_data *data; + + data =3D intel_pinctrl_get_soc_data(pdev); + if (IS_ERR(data)) + return PTR_ERR(data); + + return intel_pinctrl_probe(pdev, data); +} +EXPORT_SYMBOL_NS_GPL(intel_pinctrl_probe_by_uid, "PINCTRL_INTEL"); + static bool __intel_gpio_is_direct_irq(u32 value) { return (value & PADCFG0_GPIROUTIOXAPIC) && --=20 2.50.1 From nobody Sat Sep 26 07:59:35 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24220494A10; Thu, 3 Sep 2026 11:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436132; cv=none; b=MN2Be+KwlGILZd+RddDV2kZp//EsaDdHKDwQ3mWLJuTt10gHdw6d9FR1kFJKn7pPpc/5jMKGyLhaAKlgoA2gw5CGx2qazU426X3dsP6Zy3xDYr0EndXJaT5JhFZhDcthmnC5d2UwXyMf8jwRJhYTcET6qzKL8+xzwPoX1cMUzOo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436132; c=relaxed/simple; bh=E93yCynpB4MkNLpRhDyIDYbO4DNgZdIchrcTLxIanL0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LNKHPOYSohm9yX1Vs0TFoRDnpw53I1M26uICQoA9T6sruqNhupebAz2lx5xbxAOAD+YqPse3CyK3Na/SRZ7q0dRMd5FU5WG7rr6C+zSDSJ8+r7wP1wMA+A1Xc7ac9t3yuUfeGYosHwI8lwA0xRBs4tU4NHHVGQyR1JNCW2NLLzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=g2GbqnXT; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="g2GbqnXT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788436127; x=1819972127; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=E93yCynpB4MkNLpRhDyIDYbO4DNgZdIchrcTLxIanL0=; b=g2GbqnXTGjmhoautrDKKDO2DYORNROS488xYVhPt6bawiVcpciIB1LxI BgVsY0DVnBMBJrN1eaM+r1Mf5K1B3A2Ycr8B/o39fHyu3ngZLiWJ8PDjR 2i6c5sxteOcSHj4nMKII2xgKv/763k3AbtC+BZ/NYJeBRY9QDz864DfgB Smgw96miNNVHIlQNAnzyWDaaSZNHp4bHBktOD3ZAGm/kvbU8/b+wPmqwX 13szUyyyHo8jcV1I0H5dnZb/ilIgEkxV0y6H2AkfSaLc67kEsiEpQwAVG u4OVm0+3bTDqtxoc/RscrEjLxjrK+tlJyYAampAC2hjZS6bJksf9SNxT2 w==; X-CSE-ConnectionGUID: 5JGZ5TJMRcebix/vpGKlCQ== X-CSE-MsgGUID: jZbd4UG6QO+T6FnpwUuzLw== X-IronPort-AV: E=McAfee;i="6800,10657,11894"; a="92616604" X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="92616604" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2026 04:48:37 -0700 X-CSE-ConnectionGUID: ArKCaQO0RRKyrhpHGUV6/A== X-CSE-MsgGUID: 6QyCYrUpT+GsubKRHywAlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="267939182" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa006.jf.intel.com with ESMTP; 03 Sep 2026 04:48:35 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 392AB9D; Thu, 03 Sep 2026 13:48:34 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Andy Shevchenko , Linus Walleij Subject: [PATCH v2 2/3] pinctrl: intel: constify parameter in intel_pinctrl_get_soc_data() Date: Thu, 3 Sep 2026 13:46:13 +0200 Message-ID: <20260903114832.1996235-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260903114832.1996235-1-andriy.shevchenko@linux.intel.com> References: <20260903114832.1996235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The parameter of intel_pinctrl_get_soc_data() is not going to be modified. Mark it with const qualifier. Suggested-by: Mika Westerberg Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-intel.c | 4 ++-- drivers/pinctrl/intel/pinctrl-intel.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/= pinctrl-intel.c index fd02409a2415..08790bff2951 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1714,11 +1714,11 @@ int intel_pinctrl_probe_by_hid(struct platform_devi= ce *pdev) } EXPORT_SYMBOL_NS_GPL(intel_pinctrl_probe_by_hid, "PINCTRL_INTEL"); =20 -const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(struct pla= tform_device *pdev) +const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(const stru= ct platform_device *pdev) { const struct intel_pinctrl_soc_data * const *table; const struct intel_pinctrl_soc_data *data; - struct device *dev =3D &pdev->dev; + const struct device *dev =3D &pdev->dev; =20 table =3D device_get_match_data(dev); if (table) { diff --git a/drivers/pinctrl/intel/pinctrl-intel.h b/drivers/pinctrl/intel/= pinctrl-intel.h index b5476b9de0db..b7ee7fd0c5f2 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.h +++ b/drivers/pinctrl/intel/pinctrl-intel.h @@ -225,7 +225,7 @@ struct intel_pinctrl_soc_data { size_t ncommunities; }; =20 -const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(struct pla= tform_device *pdev); +const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(const stru= ct platform_device *pdev); =20 struct intel_pad_context; struct intel_community_context; --=20 2.50.1 From nobody Sat Sep 26 07:59:35 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C25AC495024; Thu, 3 Sep 2026 11:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436137; cv=none; b=BnWPCE7NU6+k832lg4W8f76HwR0zXTFKskUD96o5pZ9O4zuY1aT3DbsA451aAhxx7YDJg3OeRtXv6rwlO29JwEi1iBc17mDrsu2VHK9Voq2HbGDNYDPQGdD07KhQLnYqWXG8TfspPvJNp6k/vyHoPQd9YMjAxvZJ9auESHqSapw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436137; c=relaxed/simple; bh=hPsA9AGIzkcM8ijY/bT4wr6kElfRWTVev09ubwpCLHU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=t0we+6VTu8iaAsJSWimgTGUakCUJn/yLwi/QJXcjyK9ELjNKxNxXdniup906gKS95KCDybaW/7p47wMwZ/poxyD5dTP0gTOw0T9dWrKeG5iHQJ7pybRcKig7E8L3eA+6RK5KhSdP8Bd8p05REsIijZPqdd1orLhaNbmrcsK76ec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZFN6E/lL; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZFN6E/lL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788436130; x=1819972130; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hPsA9AGIzkcM8ijY/bT4wr6kElfRWTVev09ubwpCLHU=; b=ZFN6E/lLqz7U8WgGiu7yxwwrDGGy4jDyoD7A+U3C7q2fNmBgDOReS5NP fC7/OBysB2aAQq1bZVSKTrX/Yo2yxsFNIkDo7cgmJHjLzPVFlNSf6EFOG lTuNnDDVQQE+HrfzkdlLLJuG2L1Y8yQ8p6P6aio8Vy187vYoESUjLpxGI 2AnIT3u9LKasTOPbGI1l7TUz5mNdmu1ZN8XU59ecSX0twVGRyckjn1IRN fA/NE9Jj5wDehOxEbMeX1kYS+6KnfjuPhwJimzidrL01ozD2YVx5avqcR Bx6M1vhIRu6TmXOY7TuQOKKCEqO1ybK+rS0g8fD3+FujNguViXW4hedUw g==; X-CSE-ConnectionGUID: 3/KOm8X8QgC8AwTYIRH+pQ== X-CSE-MsgGUID: LClJqOh2Tyq8RvBrNzp95g== X-IronPort-AV: E=McAfee;i="6800,10657,11894"; a="106436200" X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="106436200" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2026 04:48:37 -0700 X-CSE-ConnectionGUID: 7xKhq2GUS8KKhwXnV6ki5g== X-CSE-MsgGUID: ntu+y8nrSUmyGUu0Qv4AhA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="270235102" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa009.jf.intel.com with ESMTP; 03 Sep 2026 04:48:35 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 3D4ED9E; Thu, 03 Sep 2026 13:48:34 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Andy Shevchenko , Linus Walleij , =?UTF-8?q?Radek=20V=C3=A1lko?= Subject: [PATCH v2 3/3] pinctrl: intel: Try to retrieve driver data for pure platform drivers Date: Thu, 3 Sep 2026 13:46:14 +0200 Message-ID: <20260903114832.1996235-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260903114832.1996235-1-andriy.shevchenko@linux.intel.com> References: <20260903114832.1996235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The Denverton pinctrl device can be instantiated by the Intel LPC driver as an MFD platform device named "denverton-pinctrl". On affected systems the platform device does not carry the INTC3000 ACPI match data itself. As a result, intel_pinctrl_probe_by_hid() fails to obtain the SoC data using device_get_match_data() and returns -ENODATA. This might be also true for other platforms that can be enumerated by ACPI _HID. Fix the above by trying the pure platform driver data in case the firmware node is not set or doesn't carry the necessary information. Reported-by: Radek V=C3=A1lko Closes: https://lore.kernel.org/r/20260827184259.32386-1-rvalko@lipicko.cz Tested-by: Radek V=C3=A1lko Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-intel.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/= pinctrl-intel.c index 08790bff2951..1363301098d5 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1702,13 +1702,32 @@ int intel_pinctrl_probe(struct platform_device *pde= v, } EXPORT_SYMBOL_NS_GPL(intel_pinctrl_probe, "PINCTRL_INTEL"); =20 +static const struct intel_pinctrl_soc_data * +intel_pinctrl_get_soc_data_by_hid(const struct platform_device *pdev) +{ + const struct intel_pinctrl_soc_data *data; + const struct device *dev =3D &pdev->dev; + const struct platform_device_id *id; + + data =3D device_get_match_data(dev); + if (data) + return data; + + id =3D platform_get_device_id(pdev); + if (!id) + return ERR_PTR(-ENODEV); + + data =3D (const struct intel_pinctrl_soc_data *)id->driver_data; + return data ?: ERR_PTR(-ENODATA); +} + int intel_pinctrl_probe_by_hid(struct platform_device *pdev) { const struct intel_pinctrl_soc_data *data; =20 - data =3D device_get_match_data(&pdev->dev); - if (!data) - return -ENODATA; + data =3D intel_pinctrl_get_soc_data_by_hid(pdev); + if (IS_ERR(data)) + return PTR_ERR(data); =20 return intel_pinctrl_probe(pdev, data); } --=20 2.50.1