From nobody Sat Sep 26 07:55:28 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 560DA415F28 for ; Thu, 3 Sep 2026 08:11:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788423105; cv=none; b=W6t+UfAjfrZQ246lZLodMZNzHrkT5cTDlSLK6kGK/c3m5coVnt+RJar5IlAcpr4ZaiPk5TXUP3IZudeap3rvIqZAfchJZ4KXn+VEN+Ga3UPn6XomqapDAKLvXojhqaJFWe/585poX4D4TF4SsoTAJ7sQ4k2ro4oICXMinqEq8ZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788423105; c=relaxed/simple; bh=Xghtyt6ElU9KfeHqS2XyTMJZnCsweO3xMPanse4xLdE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mbR52a/LpGYe9LwIyKsUnPi7bqK6pxvkvVmcDlnR8arH9dEoWmCJB9zSkd0Oaj6PpCpyykFvDT0Y2VpEGuW9jrKsWIEmkn3FBG5EIR7z64n9uFFsr9WTzwrTg3ztXA44I94IGGFIpveXDg8nE0ZzWMruS1tuRaIhCajHzxuqTjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KIHvzsjV; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KIHvzsjV" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3965d3d9ab8so1818899a91.3 for ; Thu, 03 Sep 2026 01:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788423104; x=1789027904; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=/Yz/sPhDz2lFb8/Y0OGM2xcNq9RbNJiy8D9exw5GDnk=; b=KIHvzsjVVGHJzw2KxZdaPTKQlhgFP0ze6y/rIyiIzoEV7ibu+o7125fKOo/V01R4Df xQSrtOhwFVWtnOhKHH2tYSwFool/JhxLIswxcYtAc9M25JxILIuCYtiE9ySLV0BO4WUo xzxdH75ckaUA8S37Rxb1Z27HPe90K+dJSTcMGNdn0VkBKPtcyCl4quj4SitdM/XhSe4t HbNVGuuezgPVtiYo/DFcYbunjWlS7PadLMfxBPJlqI3j6bDm3RFSA49Q07Mw7Ze2xBQy Zzc9V4r9tk+mLCoWzcpGCW9d/qmr+qymbFLcL0awzj7PSmrTCNiqoSyHUAjtEKFOngIm fgpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788423104; x=1789027904; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/Yz/sPhDz2lFb8/Y0OGM2xcNq9RbNJiy8D9exw5GDnk=; b=GpgIXQwubFVX6orMdIb6TGY5rZdmLZPBy2y7xngxHq5EdmcGh6BceiF+yLw1oYGnyT EPsuTay+Etn0JL1yS3s5YJ3bLBFtnRZo1HKQvbQZngRByuMFsp+zbkHCoW8hv796+1N+ Ljjg5UequhnBqS9YzK7ySqLlIxWNTLkAUXphG63QDOWqMQmm6INcBykOuPLHvaypORxu 8IE85zJNBp7aWOGt2KAe3xG0vvVy9bdm8CMWCfjGMQyWdamyGV1eYo145vtRsiNaH2w4 mX65MNJrCJZ3vmmTdROwmkRhlNUOfGtwJv8y50IWqMZhgLaesL+FRgzjoSFJtn43uqAT a+Yw== X-Forwarded-Encrypted: i=1; AKwUvBzWIRjV7hW1JNlLd+8ShWf31L6D8Kzzc4lBIQUFB7Dt1f0LGsFKRPqUSR1+kBxy1VfU83lLapBcunQUyZM=@vger.kernel.org X-Gm-Message-State: AFuF++mGG8OQJNhosoWmIpThbq21G7KttLI01ork/t6voZlcjIWbSdqG wBLkRduv6GpSHK25ibSg2xkLzh2upJXOoXl9vLdDWY/u8AgY0ROXRXYG X-Gm-Gg: AYBFou3LPNGMCmeZpriuxKTbioXuvEEQMN3Ib66xw3bftlLMhgFwOVJMAVPvnQlYrxU KUt3taCQ+i36HZTe7DazErzGR66DFMYZ060IxWVaA0PhaALck9Y1mbl7Vb3mu0GKExZ+NqkFfLe kpFzwnie84AXPVETmiMi+u/bYlNSC3KJP2wc1P9VSKVG1eOAg2xKFEozD0QqdNPzE3MyQGz6vLZ C3+LifRmkJ4WCid+0TE1YLDRLm4wtfT7stWfYoXI+RMnCnsT7GVOKD5XFfo0SCnXMhhOPDZrXhm u+hwABPwq49qB/h0Q3F7aIa/cN6JkcON9qgQU8EFKjaL+0G9y16kjyIlsBonwOtpjkheCwgR3/Z G/4W4ZjKcZf/Vw3c0hAsq9KOydPw/wMhhPCy0Egr2V9A+eBIo/ubPF9IohCkIn1HEkfX5Xn3uqo miJfXz7XaWv67svuJDVaXDBZVU+oeSiKxM608mvsARo95T/XehXtfJK7fA/g5p0N4P+A== X-Received: by 2002:a17:90b:1dc1:b0:398:d6f4:c61a with SMTP id 98e67ed59e1d1-39aee13c22dmr16834798a91.17.1788423103692; Thu, 03 Sep 2026 01:11:43 -0700 (PDT) Received: from Default ([2409:40f4:101d:c1aa:6821:531d:eb9f:2aaa]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3326e39365dsm4519895eec.20.2026.09.03.01.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 01:11:43 -0700 (PDT) From: Jeffin Philip To: raven@themaw.net Cc: bodonnel@redhat.com, brauner@kernel.org, autofs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeffin Philip , syzbot+df1db6e034b3953e19f5@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: [PATCH] fs: autofs: fix memory leak in autofs_fill_super() Date: Thu, 3 Sep 2026 13:40:48 +0530 Message-ID: <20260903081048.132524-1-jeffinphilip14@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In autofs_fill_super(), we create a new inode using autofs_new_ino(), however, if we fail to create root_inode, (that is, root_inode failure path), we return -ENOMEM without freeing the new inode(ino) that we created causing a memory leak. Fix this by adding autofs_free_ino() to free the inode we created in root_inode failure path before returning ENOMEM. Reported-by: syzbot+df1db6e034b3953e19f5@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Ddf1db6e034b3953e19f5 Fixes: 66917f85db60 ("autofs: add: new_inode check in autofs_fill_super()") Cc: stable@vger.kernel.org Signed-off-by: Jeffin Philip --- fs/autofs/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c index c1e210cec436..6b15a3717ba7 100644 --- a/fs/autofs/inode.c +++ b/fs/autofs/inode.c @@ -323,8 +323,10 @@ static int autofs_fill_super(struct super_block *s, st= ruct fs_context *fc) return -ENOMEM; =20 root_inode =3D autofs_get_inode(s, S_IFDIR | 0755); - if (!root_inode) + if (!root_inode) { + autofs_free_ino(ino); return -ENOMEM; + } =20 root_inode->i_uid =3D ctx->uid; root_inode->i_gid =3D ctx->gid; --=20 2.55.0