From nobody Sat Sep 26 08:48:44 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C7122BDC1C; Thu, 3 Sep 2026 06:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416611; cv=none; b=it/dTfm+b7z3KCEeE7MzuvuQ8WkK9JAUkX2WH3ph5s0RlNoY8JnSuGOWUnKB9unqw96nJsab+3SfQEGG4nFR375+jlX2N4oHG7vQg7hfe6gjsUyhgmFi9F//EgYyWmUUAr0+QoAsybJ9IIr/lOqE8kkKG9CWpuf270NQbve+XlE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416611; c=relaxed/simple; bh=SaB9aXPUYYvGwQvhTxrdrk4O5rz23QLKf9SfjrmIcMs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m8gHY+DzjCbu1xdo+tGBGAlMLer6hpyKGbpqSqJgD3S+5oVTS3cIFsP+6RgbvPye6dyRLx5apod1qLKryc6IDHldq+8BhmGivq1sABZu8isWdffPdjdlH3xY0jChQKJesKhkd6wZOV1ONmg/ke1wkKOFLjoQIvXqkoVCHuHKMpE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=Sykx5Cgx; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="Sykx5Cgx" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7DE961FDB1; Thu, 3 Sep 2026 06:23:23 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1788416603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WKsSDk9GkEa82koVjVF9sHtV2XmBuB9AUujVQP91OZU=; b=Sykx5CgxFRaMO/x/vCTep3m1K4Qu4g2XCpAUQsOw/azpEXx4U7UyGSgpzTEijDd1aTHLOv 5K9DlB1AwWpxzvxC2sk9kyBCcA+aEHND65c6HCeNBWdA35pHT+nsT5FnjW5GvhnLWrhLRr PohAjbagV/7p9iY9BDVCsfvdxS6XGMw= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2C01413736; Thu, 3 Sep 2026 06:23:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IDcwClsSmWoVKwAAD6G6ig (envelope-from ); Thu, 03 Sep 2026 06:23:23 +0000 From: Daniel Vacek To: David Sterba , Chris Mason Cc: Daniel Vacek , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qu Wenruo Subject: [PATCH v2 1/3] btrfs: consume the given iter directly instead of copying in csum_one_bio() Date: Thu, 3 Sep 2026 08:23:14 +0200 Message-ID: <20260903062317.3928665-2-neelx@suse.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260903062317.3928665-1-neelx@suse.com> References: <20260903062317.3928665-1-neelx@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7DE961FDB1 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.00 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="utf-8" This is just a small cleanup to avoid copying the iter twice in async case. We already have a copy csum_one_bio() can consume directly. No need to copy again the second time. We can use this copy also in the sync case and get rid of the parameter. Signed-off-by: Daniel Vacek Reviewed-by: Qu Wenruo --- v2: Use the bbio::csum_saved_iter in both cases and simplify even further. --- fs/btrfs/file-item.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c index 581ca5653be9..4a7681557ec1 100644 --- a/fs/btrfs/file-item.c +++ b/fs/btrfs/file-item.c @@ -797,18 +797,17 @@ int btrfs_lookup_csums_bitmap(struct btrfs_root *root= , struct btrfs_path *path, return ret; } =20 -static void csum_one_bio(struct btrfs_bio *bbio, struct bvec_iter *src) +static void csum_one_bio(struct btrfs_bio *bbio) { struct btrfs_inode *inode =3D bbio->inode; struct btrfs_fs_info *fs_info =3D inode->root->fs_info; struct btrfs_ordered_sum *sums =3D bbio->sums; - struct bvec_iter iter; + struct bvec_iter *iter =3D &bbio->csum_saved_iter; const u32 blocksize =3D fs_info->sectorsize; int index =3D 0; =20 - for (iter =3D *src; iter.bi_size; bio_advance_iter(&bbio->bio, &iter, blo= cksize)) { - btrfs_csum_one_bio_block(fs_info, &bbio->bio, &iter, - sums->sums + index); + for (; iter->bi_size; bio_advance_iter(&bbio->bio, iter, blocksize)) { + btrfs_csum_one_bio_block(fs_info, &bbio->bio, iter, sums->sums + index); =20 index +=3D fs_info->csum_size; } @@ -820,7 +819,7 @@ static void csum_one_bio_work(struct work_struct *work) =20 ASSERT(btrfs_op(&bbio->bio) =3D=3D BTRFS_MAP_WRITE); ASSERT(bbio->async_csum =3D=3D true); - csum_one_bio(bbio, &bbio->csum_saved_iter); + csum_one_bio(bbio); complete(&bbio->csum_done); } =20 @@ -850,13 +849,13 @@ int btrfs_csum_one_bio(struct btrfs_bio *bbio, bool a= sync) bbio->sums =3D sums; btrfs_add_ordered_sum(ordered, sums); =20 + bbio->csum_saved_iter =3D bio->bi_iter; if (!async) { - csum_one_bio(bbio, &bbio->bio.bi_iter); + csum_one_bio(bbio); return 0; } init_completion(&bbio->csum_done); bbio->async_csum =3D true; - bbio->csum_saved_iter =3D bbio->bio.bi_iter; INIT_WORK(&bbio->csum_work, csum_one_bio_work); schedule_work(&bbio->csum_work); return 0; --=20 2.53.0 From nobody Sat Sep 26 08:48:44 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F5362BDC1C; Thu, 3 Sep 2026 06:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416615; cv=none; b=lJUw0YMQ14P2FU3znmxPfh05X64MozRREr1RWscf6q4MymihkHrP+da03+vbQWTlHidT7LJfUcuSjPF6SsJqQ7B9SOhIMVygXVoSziSxfG4s6TUiKF/FCia2lxnO5o+Arbfy1+C1j4EFLPV/y4R+xGmxF4MPPP98QA3C0hTT5q4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416615; c=relaxed/simple; bh=0t4SnB+S0ybvtQvhutv6dDJUnDmQA8XgTKf82VCqI9c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZXRaDt361YA6EGNK+9dyacrn08ninkNNcUXQIWNDYr5vKSwGOvisQBt9wUA6fuBXUof70567KWYyVMw1wU0AtXoDIlwqG1qKH2lJHRmstWJLRPCgE3dIpF1pOQvHy1z5Jh7oe0H6jorLl3gonjYZAOBPtNXGuthMLK7GC3tPl8U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=DCVNfkHl; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=Nj/fSERK; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="DCVNfkHl"; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="Nj/fSERK" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 217A821E07; Thu, 3 Sep 2026 06:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1788416608; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sfXDvErAVYiffVsYFRcL1awa1CCQQAqkDQEPuekIlFo=; b=DCVNfkHlO/Pi8fbzT8tx1EitbXLdXk/XHUpwM3rWD7gY4XZjUngMXTlPpp0Ns3kAyv6/4o I9BFUwuDgMiZf1oB1uuR5Rh9ShRiU72UI71Przb7KUUFSfF7Qh4X2nqDYd4eySc5M5v+0F /TJeRkLtbBV/uXWzIT+ekF7osHktbLE= Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1788416604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sfXDvErAVYiffVsYFRcL1awa1CCQQAqkDQEPuekIlFo=; b=Nj/fSERKZ8tSAhnthbC5hdtY98LtmCB0qkJPNpk93PI8gYzmcX8VD+qJlnzQFtLi4InzGj /xYQ+Zfj6xHEupfo/ucybxVjTlHcyb8bty7To/pUfgAyz8NJqfTVpMiR76LNexWOnMmwpc dC7EcGQPtK13OOGsjEq/vxK5o/upHzg= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C53EC13738; Thu, 3 Sep 2026 06:23:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eGybL1sSmWoVKwAAD6G6ig (envelope-from ); Thu, 03 Sep 2026 06:23:23 +0000 From: Daniel Vacek To: David Sterba , Chris Mason Cc: Daniel Vacek , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qu Wenruo Subject: [PATCH v2 2/3] btrfs: use bio::remaining for async checksumming synchronization Date: Thu, 3 Sep 2026 08:23:15 +0200 Message-ID: <20260903062317.3928665-3-neelx@suse.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260903062317.3928665-1-neelx@suse.com> References: <20260903062317.3928665-1-neelx@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.80 X-Spam-Level: X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:mid,suse.com:email]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" We can use bio::remaining counter to sync the offloaded checksuming. As a result we can slim down the btrfs_bio structure by 24 bytes and simplify the code a bit. $ pahole | diff - /* size: 328, cachelines: 6, members: 15 */ + /* size: 304, cachelines: 5, members: 14 */ Moreover this will allow us enabling async checksumming with encryption where we need to checksum the bounce bio instead of our regular one embedded in btrfs_bio. And so we need to extend it's lifetime. This is the preffered way to do so. Signed-off-by: Daniel Vacek Reviewed-by: Qu Wenruo --- No change since v1 --- fs/btrfs/bio.c | 4 ---- fs/btrfs/bio.h | 4 ---- fs/btrfs/file-item.c | 6 ++---- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/fs/btrfs/bio.c b/fs/btrfs/bio.c index 19b4855969f5..771b7d598aee 100644 --- a/fs/btrfs/bio.c +++ b/fs/btrfs/bio.c @@ -103,7 +103,6 @@ static struct btrfs_bio *btrfs_split_bio(struct btrfs_f= s_info *fs_info, bbio->can_use_append =3D orig_bbio->can_use_append; bbio->is_scrub =3D orig_bbio->is_scrub; bbio->is_remap =3D orig_bbio->is_remap; - bbio->async_csum =3D orig_bbio->async_csum; =20 atomic_inc(&orig_bbio->pending_ios); return bbio; @@ -114,9 +113,6 @@ void btrfs_bio_end_io(struct btrfs_bio *bbio, blk_statu= s_t status) /* Make sure we're already in task context. */ ASSERT(in_task()); =20 - if (bbio->async_csum) - wait_for_completion(&bbio->csum_done); - bbio->bio.bi_status =3D status; if (bbio->bio.bi_pool =3D=3D &btrfs_clone_bioset) { struct btrfs_bio *orig_bbio =3D bbio->private; diff --git a/fs/btrfs/bio.h b/fs/btrfs/bio.h index b7bd377a0162..bbf362b8668b 100644 --- a/fs/btrfs/bio.h +++ b/fs/btrfs/bio.h @@ -58,7 +58,6 @@ struct btrfs_bio { struct btrfs_ordered_extent *ordered; struct btrfs_ordered_sum *sums; struct work_struct csum_work; - struct completion csum_done; struct bvec_iter csum_saved_iter; u64 orig_physical; u64 orig_logical; @@ -93,9 +92,6 @@ struct btrfs_bio { /* Whether the bio is coming from copy_remapped_data_io(). */ bool is_remap:1; =20 - /* Whether the csum generation for data write is async. */ - bool async_csum:1; - /* Whether the bio is written using zone append. */ bool can_use_append:1; =20 diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c index 4a7681557ec1..0fed4e0d32d5 100644 --- a/fs/btrfs/file-item.c +++ b/fs/btrfs/file-item.c @@ -818,9 +818,8 @@ static void csum_one_bio_work(struct work_struct *work) struct btrfs_bio *bbio =3D container_of(work, struct btrfs_bio, csum_work= ); =20 ASSERT(btrfs_op(&bbio->bio) =3D=3D BTRFS_MAP_WRITE); - ASSERT(bbio->async_csum =3D=3D true); csum_one_bio(bbio); - complete(&bbio->csum_done); + bio_endio(&bbio->bio); } =20 /* @@ -854,8 +853,7 @@ int btrfs_csum_one_bio(struct btrfs_bio *bbio, bool asy= nc) csum_one_bio(bbio); return 0; } - init_completion(&bbio->csum_done); - bbio->async_csum =3D true; + bio_inc_remaining(bio); INIT_WORK(&bbio->csum_work, csum_one_bio_work); schedule_work(&bbio->csum_work); return 0; --=20 2.53.0 From nobody Sat Sep 26 08:48:44 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0C2438239F; Thu, 3 Sep 2026 06:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416616; cv=none; b=UmS6XCnWtK362+jUMXw/iIS9ozyx3u3abIwvmFN/XHVuSky0rXsju8APFQ7+2tj1C37RzwB5/+uibUHEj1NOUdmzNIXhPIVYZyNj6J6M6y7n1FoJJapv7Qjd3mj+OqSpzmmV2UFkJIDYwCfEY7xywCkwOMrOYZznXsUcu2hVzR0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416616; c=relaxed/simple; bh=O0cVIWf4avJOs+FgyAmC/vpb1u2Py8iQ8gxPX2Pp9iA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cuChVvld5BcPznkLJG3jgh7dchbTzO9yswRKNJW4iSPIz+iqZj7OAb+T1zKhsMi4UcKxtlwOf0+mSVA+nxcSK8ZFPqK+xbtz4ep6jCnZlNfluNx+LGzYbIKxLN8i11n5iBswYMsaO6tjaY9XkCBNgdp5vKNmknlLG8k+choRl9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=fk0f2JtE; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=oS69zHaO; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="fk0f2JtE"; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="oS69zHaO" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8891D21E86; Thu, 3 Sep 2026 06:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1788416608; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kDYF+bA8W2P21A53YU1WTOJcp0b2M/FDnDwv/bnunBQ=; b=fk0f2JtEJJvp2wW/kkmeNnXJrEcGzBpR4v83XpqwvC9On/V1HnaF6nbjd5nMD+IepA8Quh /Omh5j9BLaSiDL526mjfKa3TvWGsyKrW+78WwMusGhTLrtPYdia3PFB/IFuBCOE6G8MwjU OvX6IOyzP9Feh3YvzDAuDQucpXOaotc= Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1788416604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kDYF+bA8W2P21A53YU1WTOJcp0b2M/FDnDwv/bnunBQ=; b=oS69zHaO+n5b1PKxb87HbG3JSZXxcJ6hfZQgsufM3BCPlErGSJSOR1EyW9Y+afBBWnAYT7 /OR0O7treh0z0d+4EvgIeBX2zLxzf90Sks9Ei0PpvqDw0EYI9MgWkTuUKLdERr7uro1QOq KKIQrICzMtf97SUjmETomBaU7Dl074E= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 398BC13869; Thu, 3 Sep 2026 06:23:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UAF5DVwSmWoVKwAAD6G6ig (envelope-from ); Thu, 03 Sep 2026 06:23:24 +0000 From: Daniel Vacek To: David Sterba , Chris Mason Cc: Daniel Vacek , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qu Wenruo Subject: [PATCH v2 3/3] btrfs: promote async checksumming out of EXPERIMENTAL Date: Thu, 3 Sep 2026 08:23:16 +0200 Message-ID: <20260903062317.3928665-4-neelx@suse.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260903062317.3928665-1-neelx@suse.com> References: <20260903062317.3928665-1-neelx@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Level: X-Spam-Score: -6.80 X-Spam-Flag: NO X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; URIBL_BLOCKED(0.00)[suse.com:email,suse.com:mid,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:email,suse.com:mid]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="utf-8" There was no issue with this feature since it's introduction in dd57c78aec398 ("btrfs: introduce btrfs_bio::async_csum"). No need for hiding it. Signed-off-by: Daniel Vacek --- v2: Introduced this change. --- fs/btrfs/bio.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/btrfs/bio.c b/fs/btrfs/bio.c index 771b7d598aee..db426ee6e587 100644 --- a/fs/btrfs/bio.c +++ b/fs/btrfs/bio.c @@ -569,11 +569,7 @@ static int btrfs_bio_csum(struct btrfs_bio *bbio) { if (bbio->bio.bi_opf & REQ_META) return btree_csum_one_bio(bbio); -#ifdef CONFIG_BTRFS_EXPERIMENTAL return btrfs_csum_one_bio(bbio, true); -#else - return btrfs_csum_one_bio(bbio, false); -#endif } =20 /* --=20 2.53.0