From nobody Sat Sep 26 08:37:09 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD30333939D for ; Thu, 3 Sep 2026 04:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411173; cv=none; b=RFSJZhFEbPwdJXI2yuNvgE8+wKrpRxZr4H61gG0tux3O8x/cEOskW1XGe6Yrkf2m15gi+md8a0QoL5mzjiTSRBpL860G4kMb2WmS7pkMGBkOVC+JON7whmTtvxeXLIHiD00PlR6lrCkriUSh2vVCoQFJ1qsLcH9K0/BWAXL+RPM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411173; c=relaxed/simple; bh=Q7QQT7/BVhDq1O498rAEP2puFeqnHzBBniDPqc+j0VM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iWZtKPdrIGZjlcTSUv15QfzHqviFPZZ62J2H8oVW2DjC0ystCa4VCGKFI2RGL+Ca4agEpJJu+bdwdhXNvWPChac/TcLw7H84Pc6Mob+LXVwvYQbDBmeLXk5743vEnHZqw2Sie2C9IuNY1oKUKWtq5NR+iqQs8IgHqpbUfVXEcwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fpszpUry; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fpszpUry" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-39682983a0fso2494811a91.3 for ; Wed, 02 Sep 2026 21:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788411170; x=1789015970; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aHaGtDWIabgwE9bMPCVResetCLU3h+f9hWvuf0/laf8=; b=fpszpUrym7NqzDbQ/RgsCEPnsy2l1rnSVO71NqZpKIXz08fx+r8iX3COikHZxN3M+c PTm9tSzrNhaemk9FDi6Lrdx9PJc9NStZ+odBlR7zu92gqrLYR4cmWRx8J3/clIv+Sgce 2LqGgAHLciSGCUTezaCzkelSZUOgTzIR5BGYZFyxOFUsHWDAGqwEwphSEbfkkfwwJyIv KdytoqDkkqJCb41vLdeDwNdSJSBaxVc0VFTYyJtcSC1Vu/OuCsBP7y8ZyAKW5EJ8G2K+ rA8w219pNe1k4i6GJ6eiDnHuKvFEo8YBH5RCXwRblAviIahCKC98GM6AYNhAkuJUb8+k 8luQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788411170; x=1789015970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aHaGtDWIabgwE9bMPCVResetCLU3h+f9hWvuf0/laf8=; b=VpmaRaoFCsOlzIPQZdZptCpNj8/lqJUVPjFotpc4LKdViMfaQpfVTZad8tZug6UwWq 7dKxroAJ4whkDvfTgzC9QuxoUSVg0ZFUSBv1nT9raokDZl5la7s7BP7kWjikC95VcOkS i3bTm1XUJ2a0Xsvkgb9ll2ec9XJmf7G8l7klf6OZWzk2grENkJnNPKzcH0bupFuY78nZ /vIDL1/MS+0AMfTIm3ENhInRePzvO8yTvloJELXO6n94fIoebR2yHh6U8LJtjd3tfX+b +gPsMsVGttty1udTXc0EmYpH2DYH0vX8iOOc5muml/VConXrmqaDPjWrd0zGCb+nQ9ic 95YA== X-Forwarded-Encrypted: i=1; AKwUvBz+6Xr8drumKQr546tfx2B9z2NnAiyTHfS8UKNvKwS++lDQMTWKzKGijaowYMd9S+/iqoJnUmUNeA1W+ME=@vger.kernel.org X-Gm-Message-State: AFuF++l88Noa/XDf1sM0M9Yb10TC5v7bPoJNl/g/3d/jPRuMfR4iPj9q L9RHEqhWpjK14sQdff2LMzd5nUYzen6SVN/A/r7igXhp0PBr8HXLElaV X-Gm-Gg: AYBFou1gCZX9X5sXOAfHgCR4XP4HGk2T5pB2yIiHIBDCSxDXaJ/g61ElGLTpS8XVHZT vPtxmW/1vKuJ2ydAccm+SFe3d1IwKzI4v4WA3IHrKdZnjTwV1o0CJumcdmrFjoMhAE72bI4NKHw ee44LF7ue+E/s269KVqq5wSvqnbGvfxaVqdwq0cWb+8ohMB8j8ygUPRO0qsDVKnkLLyXsu5gaco 7Fl87z6RxSqeyAB9fg2PT1ShR9kiLemnXwmcxi4yBUYuKUN3E5l0pAVJujsGOXgA7mCY14dCOi4 5nB/cSjQFEPdNximb2rxPoSQ1Ow5FzXHqtbzNBswsvnvZWr6F4JKYvJ0pFZRbXDNeMFOba+u7/k MuipVgoNKhojc8JztgKEvBlbLUakY4EHvoA8XxUvKZu8HDQS0vx/Q65g1hXLQqjfcBv7Lv3XEsG mbehS45XS2CTj6B6UWvN4pVbZDEoTQDPB4H3UYz+Cj1pInQEXss6COlgzudv/ENnskWQPa4GTGe Xgv6zo2A23Oo2bgpghBI3D2xdiIbIPgceTODmIpRtkURRIOzahBN3ooK280fF9T+uLMpOERyzMF UR+O X-Received: by 2002:a17:90b:1811:b0:398:c724:1bb1 with SMTP id 98e67ed59e1d1-39aedee9313mr14120611a91.8.1788411169700; Wed, 02 Sep 2026 21:52:49 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d0d7e8sm2747538a91.16.2026.09.02.21.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 21:52:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Shunli Wang , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v4 1/5] ASoC: mediatek: mt8183: Fix wrong clock cleanup on clk_set_parent() failure Date: Thu, 3 Sep 2026 11:51:59 +0700 Message-ID: <20260903045203.175337-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260903045203.175337-1-phucduc.bui@gmail.com> References: <20260903045203.175337-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc In mt8183_afe_enable_clock(), when clk_set_parent() fails, the current error path incorrectly cleans up the previously enabled clock instead of the clock used by clk_set_parent(). Fix the error path to clean up the correct clock when clk_set_parent() fails. Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver") Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v3: - Add a Reviewed-by tag. sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index cc4f8f4d3dab..6ab0734ad136 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -137,7 +137,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIO], aud_clks[CLK_CLK26M], ret); - goto CLK_MUX_AUDIO_ERR; + goto CLK_MUX_AUDIO_INTBUS_ERR; } =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_MUX_AUDIOINTBUS]); @@ -153,7 +153,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIOINTBUS], aud_clks[CLK_TOP_SYSPLL_D2_D4], ret); - goto CLK_MUX_AUDIO_INTBUS_ERR; + goto CLK_AFE_ERR; } =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_AFE]); --=20 2.43.0 From nobody Sat Sep 26 08:37:09 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B218309EF2 for ; Thu, 3 Sep 2026 04:52:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411176; cv=none; b=UrFykx/hAFTFJt30G26000oY6FLz7YL5eoowMI+vYO7JvfvbOz8As+Cy8L5XFN0MtPK3Ygso0NtBW5ZEsKAyPIGzNc4WtuLOguqrhvrhjw22mrhYcMN/nBVUV84HTOIOMA/CX2LFr9edfbUGUyT8oLCS+AU7sXFCnbGEe6X0tPg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411176; c=relaxed/simple; bh=HMjTaFNf++XBhM+sgnYCzvPtzS89AMLTDJUPnErkVb0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GgyVIafxDy2gjO4hYZkqOOr3QJ3uOMIiC6sZ0l/fO/z2ZcyjWil3DJi5NnyTwOr5lkrFQUZ/rcb07JthAPlwgGq62L3Xtehww3619PtPxV3ie3lm9wK/D1+ZFpFV9hG8211BUSDZli/U0PC6epnLtRdaJrWSeI7MaUf9zFTUako= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VSKY/KPZ; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VSKY/KPZ" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3966791a6eeso2320538a91.3 for ; Wed, 02 Sep 2026 21:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788411174; x=1789015974; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/QLhY24jUWuW0UFPT8wZxIclDsrKF9CvBHKSfEU+hkw=; b=VSKY/KPZluXLISft5GI5rtLi0X5DuGl+guzpDZh7I2Cljk75LTqpS5mp9AuGTSnFv4 iUwaXn3K4uf9zjWln1cqwBcCbUAzhryejWl+seFc0qLjw1uQwNfonnj+L6q7sIFl6+KO j5in9+XpcmznrUE+eR9h6gdX6xJ8hkbjAYG6thTexalQAsDfffRnZUaDEHzN9+mKva5k MO6yIKsvcCr+LO59z/weNrjZr5v8kL6QNm0WkOLtAg8Az04+OkVwCkcv0if73POWRe1L wYvgssHLJvropg2wsn5MQdGOh4ZEX47o6VKXnSf4eGfjKtnguwPTng+OATWPsfBhf+rw PocA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788411174; x=1789015974; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/QLhY24jUWuW0UFPT8wZxIclDsrKF9CvBHKSfEU+hkw=; b=Uyrymb9+GsQvtPeoI0MxV9krMCZk27S5GHG0lQJkDfNIy+n4JnS0sUfMYDSDLeFd+L jUeCJ755WoQy8hZfGaWXuErw310dxEc0WOTbh17ZXo0WfR4ilp4eGkoWNSyTp4eIJxQM bD4JtyBjTpo/HrSBCwztefjpR8eebWkc1Orvh7rK3zTwFMFd2g8DBth2Zx2vMnof2pu4 DZMwj+8EfDYDfajzCII05Mc6zTjzftDlz4GR0QroLxg63njPWQYNpZiQXTjhWxIamhpZ iE9q7Dmyz8fVwx+OiuTXjXPy/V+3Z969kFFNP2PviBzpXdiazTrBAURIzosdn7iB5p04 Rhjg== X-Forwarded-Encrypted: i=1; AKwUvBzJix1WjZx+R6kIoDXGtc0sZIL4JDIyNLOKeMo78zRhza4HuOnivJJNKNey4cMAQjE3mC9WIAYkmssY7TI=@vger.kernel.org X-Gm-Message-State: AFuF++npDEN0UEugVceM7JzBgEAHqfZ5nU1A1WLFXxtCSvQhYVRyhE0E ZTL0vrjAYIMMvlSQXoOYI92EyiW9jWpITnG9Zh+pJazd2gQGo7ZTieNz X-Gm-Gg: AYBFou19kPE3+IVAemWoSUSbuNfCinSc+I84rSlxs7IQskzxabHoid5iMQ8sxOH3YJj 5wvazGcl6fFLDxyNYQKxMhfNt46jNmNeMf55EdH4YtN9Cz3RTZsu4Hqpj5bHqWi94lv9AAie/Vr N9/Kh/Tp/VzM6jXgCF0XGTKUheWuaTyrfa87Wnxl6Hri67uFpyyjRf5KTeI1n98xDy6wDHFg2j9 e5tAAM1bPcH5UUeQfDWOcGmo7gCVrETM+YSj3/OrEeZHScKObOCabzZm08axqOQ8BzTuwiARE0y GGc4FEo3Qil0o8dthptgxlUDxUpXt13Go0U9S58xOUyfca4JUZUhsigmIemB1NCdwIW1N3kZ3Yp eIobsv4rgaQqnpaRfe4Yi4M59RzVY5+3pZvdo+M77u3ru9yHBKHSiyqK8gzW6iNzaEiEC6EZ0GQ ONfpAfCUUQVsQs4Lp9ED/9JqryL9mhdkb1BBXxGInhFVkI/fJIeX5OYgnf0T3ofCr4JRacLAQR2 +/vkHtGCpU2YmqdALJRFot0fMQPV/BkIWCGlWVMPThrVqGYdSw/tcJHUiJhk2eiIyPOa9QDdZZt /ByT X-Received: by 2002:a17:90b:3ec5:b0:37f:ed7e:7e42 with SMTP id 98e67ed59e1d1-39aee172d61mr14055157a91.14.1788411174299; Wed, 02 Sep 2026 21:52:54 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d0d7e8sm2747538a91.16.2026.09.02.21.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 21:52:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Shunli Wang , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v4 2/5] ASoC: mediatek: mt8183: Fix clock handling in mux disable path Date: Thu, 3 Sep 2026 11:52:00 +0700 Message-ID: <20260903045203.175337-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260903045203.175337-1-phucduc.bui@gmail.com> References: <20260903045203.175337-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc In the disable path of the appl*_mux_setting() functions, clk_disable_unprepare() is called after clk_set_parent(). If clk_set_parent() fails, clk_disable_unprepare() is skipped, potentially leaving one of the clocks enabled. Remove the goto exit paths so that all teardown steps are attempted and any errors are only reported. Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver") Suggested-by: Cezary Rojewski Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- Changes in v4: - In the mux disable path, remove the goto labels so that all teardown steps are attempted and any errors are only reported. sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index 6ab0734ad136..dd1a5925af96 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -271,7 +271,6 @@ static int apll1_mux_setting(struct mtk_base_afe *afe, = bool enable) dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD_ENG1], aud_clks[CLK_CLK26M], ret); - goto EXIT; } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_ENG1]); =20 @@ -281,7 +280,6 @@ static int apll1_mux_setting(struct mtk_base_afe *afe, = bool enable) dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD_1], aud_clks[CLK_CLK26M], ret); - goto EXIT; } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_1]); } @@ -298,7 +296,6 @@ static int apll1_mux_setting(struct mtk_base_afe *afe, = bool enable) afe_priv->clk[CLK_CLK26M]); clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_1]); ERR_ENABLE_CLK_TOP_MUX_AUD_1: -EXIT: return ret; } =20 @@ -345,7 +342,6 @@ static int apll2_mux_setting(struct mtk_base_afe *afe, = bool enable) dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD_ENG2], aud_clks[CLK_CLK26M], ret); - goto EXIT; } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_ENG2]); =20 @@ -355,7 +351,6 @@ static int apll2_mux_setting(struct mtk_base_afe *afe, = bool enable) dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD_2], aud_clks[CLK_CLK26M], ret); - goto EXIT; } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_2]); } @@ -372,7 +367,6 @@ static int apll2_mux_setting(struct mtk_base_afe *afe, = bool enable) afe_priv->clk[CLK_CLK26M]); clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_2]); ERR_ENABLE_CLK_TOP_MUX_AUD_2: -EXIT: return ret; } =20 --=20 2.43.0 From nobody Sat Sep 26 08:37:09 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6463833939D for ; Thu, 3 Sep 2026 04:52:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411180; cv=none; b=HikvEemSrBFr1L5t6kr0qep0oCXC8oA7rJyJKx3kOkS9HdeixvQnUHCXpEDSxUZaU5dohi3eMmMC80SSw7gbDWi04h6nzXoowCsZZ0N3fXlbWycTFQvw5lkI3BDgDNGx24NwVg7gzTM515197zPZHRWYxg3925EgA9mjT8EM8KM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411180; c=relaxed/simple; bh=YO0IOWBf+lVgCQX7sWvBD+Ngwz+1wef3xZYXUiMvXPw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P8BmXFuVg4he8BIndvSzPpdVmrUpzi2mS6mTWld9nemQacX+3tph0XjrrqSqR6UHCS+dq83xMTVdNol4WBuTM0/65BCYD7yjQyExiwBP1JMueTp3D18Tbd24mRwubaxA65kAJ9gYebeqdD5uKjUyacKGx8cWHDhpbkDtFNqFMYE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h/9v5E5T; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h/9v5E5T" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-398b1e63c49so583223a91.0 for ; Wed, 02 Sep 2026 21:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788411179; x=1789015979; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FrPM2Xk8RwUrDDJTGII+4iO1GsIG/syrGzbLRZRG6MA=; b=h/9v5E5T+BrQVw8sP3ewZoQhCLCM7f9OIBttmrAPRIg0VWW2kKOOmvdfeq4/1kcnAX f2aqPlHTvEZunlRi4JMCx2IdvEDeBoYuBt9k49nfiSX2FCt0KSpGu5je5LQu9idq8vr1 EhIJNCGJEFzL+KCD5lUN+tEr2N41EDCOBuN4lPhyys/Qbw3RI8XOhQ+SDgH9x17adkUi mbOMR8H+Cy4gT6DCgFG8ppYaJVkGnz/05wnzqswY9tHbovOS1dYPfd0MWSgYroiYOvqp MgNNFvyrd3Hf3riRso54HaOrwXZkjj0c4Pgx8U7SLpQCYUjuzAVC8Z0OE33QAcGY79cL 5dig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788411179; x=1789015979; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FrPM2Xk8RwUrDDJTGII+4iO1GsIG/syrGzbLRZRG6MA=; b=iyEIu2wWgH/Z8al+5emtxEBmuR1PJxt+gRGElZ+YA5EwshmSG1Vtw8uG8rASCy4RkN rB1x0YzSG97WNROHiq1CR1/F78ObIL46SFIujhPet971kWFXu0F3JbvDvbnj22uel6gP tWAZs3/lq9lDZZkP/V8mjghF6uK5QZUIFNBBor0SH/Wy4ql+xiAXv+ND0rfhn730kXXv R1rDg2gFWm6ROZ0L3NAe2983FCN6OwzpJtf4GF2l+by303YygbaWq2BnIWuWKMJTA64V CMfn4lZujZwSm0tUXuWpZ1GS8PIIlo4Xblqa9tj3otvNPbRtiud6umvmKkh6hhv86ESs qk9w== X-Forwarded-Encrypted: i=1; AKwUvBy9qA3GjreqphExeQOVbULgEA5nDD5NSEFdo/PPQaV2BAsVQ+OGWCRb9CyRaOkxWSO6Sw2C+VqBkH9APSg=@vger.kernel.org X-Gm-Message-State: AFuF++mSDfVbol7wUzsCdmtcx8fqBxEs4B5+E77X5jRh0WSAsfEhokj/ x6Mag5xESadGvvLErdHy+8pc+qR7KC1+Pf2ZHsKlwE63wOsnxgpdEvpf X-Gm-Gg: AYBFou0LoJb86tR8Ed2bwPhLL++Sandr0joAHoqrON25WFWKMOp9TgJ0OZMDVIOjhRC ftS3H7D5bUOHbiw4G8quyTPCKKU2y43G6bpSYMfH0PUJ2iIRRdLSnISJy5gjpdoVmR6QF2NuGCm ZSPHTcmMOkpzbZeKKDiGUACMLDhScoeMTx26oGgfAYaoqFFN6xsi3CLrZ2cyz1pNoW2djHIwEDH 4GuJLot13rs7eRHtoa2HlN6F1xBUKPaRU3HBe5DSmyPCiKTNmTiWI+YjuSG8KFrvoLFvo8rOfnB 3mzooo+65jhDIMCIXDY+i3jYaMqEB1OZrvsen58Oms+NpvFY1RVV68448kWACzLHLqLX4Nwu20r xBVl1w5d7x/RaTyCRVG/eoPRYuAIdD+UZwQnI1EV91cxDNRm4rglI4UU674Yq9JhRbSCeKaZyeQ 4yXmTN/nxOool6oVlpdA9ec+08wn7ndQdalEOIE7J0v0jNPwf7nQBl2z02huasahz/0qKOIGJ8j 7s0kNj5SGSdk5zJwPkzlDzEGpFjSVMK2pOrMgLLQ7Rg1LBXMHdlc25EgJ6z/JqACRhqwV8J3dez qpJh X-Received: by 2002:a17:90b:2d84:b0:398:9bd3:d6d1 with SMTP id 98e67ed59e1d1-39b132964ddmr1173209a91.11.1788411178721; Wed, 02 Sep 2026 21:52:58 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d0d7e8sm2747538a91.16.2026.09.02.21.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 21:52:58 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Shunli Wang , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v4 3/5] ASoC: mediatek: mt8183: Fix APLL enable error handling Date: Thu, 3 Sep 2026 11:52:01 +0700 Message-ID: <20260903045203.175337-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260903045203.175337-1-phucduc.bui@gmail.com> References: <20260903045203.175337-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Currently, the mt8183_apll*_enable() functions call mux_setting(afe, true) but do not check its return value to handle failures. In addition, the cleanup paths of mt8183_apll*_enable() do not call mux_setting(afe, false) when the enable operation fails, while the mt8183_apll*_disable() functions do. Add error handling for apll*_mux_setting() and call mux_setting(afe, false) in the cleanup paths when mt8183_apll*_enable() fails. Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver") Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v3: - Return directly from apllx_mux_setting() instead of using a goto label,=20 as suggested by Cezary. Changes in v4: - Add a Reviewed-by tag from Cezary. sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index dd1a5925af96..06556689976d 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -376,7 +376,9 @@ int mt8183_apll1_enable(struct mtk_base_afe *afe) int ret; =20 /* setting for APLL */ - apll1_mux_setting(afe, true); + ret =3D apll1_mux_setting(afe, true); + if (ret) + return ret; =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_APLL22M]); if (ret) { @@ -405,6 +407,8 @@ int mt8183_apll1_enable(struct mtk_base_afe *afe) ERR_CLK_APLL1_TUNER: clk_disable_unprepare(afe_priv->clk[CLK_APLL22M]); ERR_CLK_APLL22M: + apll1_mux_setting(afe, false); + return ret; } =20 @@ -430,7 +434,9 @@ int mt8183_apll2_enable(struct mtk_base_afe *afe) int ret; =20 /* setting for APLL */ - apll2_mux_setting(afe, true); + ret =3D apll2_mux_setting(afe, true); + if (ret) + return ret; =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_APLL24M]); if (ret) { @@ -459,6 +465,8 @@ int mt8183_apll2_enable(struct mtk_base_afe *afe) ERR_CLK_APLL2_TUNER: clk_disable_unprepare(afe_priv->clk[CLK_APLL24M]); ERR_CLK_APLL24M: + apll2_mux_setting(afe, false); + return ret; } =20 --=20 2.43.0 From nobody Sat Sep 26 08:37:09 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6462309EF2 for ; Thu, 3 Sep 2026 04:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411185; cv=none; b=DibO5rmpA2w5L19gqEQsu+6tP/S0tC450EL6otBB5S83mpKgaQBx9ztEHs4pYIOT23iVgu1Y/KrNtcLp4s4QSY+QzNDNv4S2PHGPKv6JayjQocrS1JEAsPzUFtPy7oq4+2hAIxUcX6iEiED2pWi7CNeZ2BtH2VqACIq3XAmHG4c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411185; c=relaxed/simple; bh=LZvlbcsgGaGSFhVc9VXtl4EgwIRrrp1Uij6NVG3vb9c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nyRpmY5UT65DM8OH05tIk0neJjHVOYcSS281c61Y9IHGdEDmftofiVnVdbh32HJAK6e1/OI4m73pRWSGg6+6nSXDdscvLavbTIti+JZ79I6G87N6jALh3qtJy9mog4DSw+9IFEv/MowF2aJmzYModXnbZf54SmqUD8VT983SG1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RX3CoRwk; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RX3CoRwk" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-398b1e63c49so583266a91.0 for ; Wed, 02 Sep 2026 21:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788411183; x=1789015983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=flo82f6nJyQV/amkHfEW5LTC13dBqnuwC2IX8NNo5OA=; b=RX3CoRwknFAO+CrG4DmVQpch18D1wocZFeIg77g9ineHqyvO/smYB9bxk1dRFz8+qf 1gX/t9Q0+SFBe70xHKhlqu3cXMZyTxuYzl38Pj6lSV17ufmrqNRv53l6Tkzo9490OV7e ZR94HvmEYkzbQGjlD1mjs+0NwgsSAxRO6goXCZTdYsNmabpJT+O03o9WKmBn2GLSeONn 7AqUoocCKcBZeRjQObVpzPj2u8ua5s0zYPsc+ODX9+AcWNwZO+323URFMtk8GBqf1CIX GtnAA88mIN+Pjd0hBG0PgjpUCQseAsln8AqxZJpdqBFZwWRMJA5/zrm0g9oku0ng4z4B Gq+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788411183; x=1789015983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=flo82f6nJyQV/amkHfEW5LTC13dBqnuwC2IX8NNo5OA=; b=b09C/06HdV2xzD4Pt9KLlCJ8FS+FJXtPZpvs2w9rVZPFIc6p2BZHMqePAbR4l0SxMZ MW4ld0JGprkE6+UB3JPQDgqHCkI0ZHsCP/3g7lo+XeaemuMtFxUBYY4WWAabHL42FRU5 j0NNZo9EjyjOQ4kXx7iSNYq+A0V6w/+rnudOKJ1bbJrrids79u8IWl5C4dmQW1PJ2kJM 7yxVr7HM1MmxdNsIqNbO80ODcPiEyMIVnM9j7yklDokyIpjBJfmB0fXAf0PTDnTi9gdX H3f+3mbPBzPoz5mQCd8mFutSJ1bm6DHULDLRPdM9q1xjnVnA/1OtNsh4tRo9xN3WH2th Ag+w== X-Forwarded-Encrypted: i=1; AKwUvByRQ/4WcoAXvHCzyUXyPewjzraLRttsTvQQpD3zUaNMFnFHJylb4VQ6yJkVJNf321Y6tc6Xsh23862VXpo=@vger.kernel.org X-Gm-Message-State: AFuF++lhfXnLQhAQ1PE+wv4NhYTMllNE5bibFaEQ1rqCcC5sPse6kCT9 +Mk6PTdrmcOYfwq6YNmkV7Tevq2h1GERQBcj3G9aOiEuZfgZTjoJTRQ3 X-Gm-Gg: AYBFou1JsTgHU3AqQRoK5BjN/DQeM8Ek1SqSWBnhA4g14YKMG4Y9KeZ2XhXxVDvJgAW tzbWApA0arwxfliqN/p9HAGxGI8Cgf9rIKUL/Aa0tzUJLkYwKuHHrvCaEJtfCJQW1rkWHKdyAIA +bbSfq8MN9RtYHGta2SPjLnKeEN9khEEUy1na7XTMlaLQiLo5zxY0t+aRfeDdo9iGaHeCjS6bP3 0/Xx4vtyiiaKLnaH8ZQEptpG63baWw7bhKoHvs8l8p3xUhLH6tGC9sFqcS7wOj9eHwPNk61bHh9 dqVYXQCU68VaLVrFjxwxspNe+qMotm6bKko38u7rewfJrKhAZoI+BnUkyczjBktS/2zw+jjGRds PAflPT/FETMcaKp3xeq1dTTvbvs1rPYyOQIH45ycT23YCOsue/UiGIeBOKEhCDTfXd9w9C4/DgM 50iY2/3rsvCszMP+YelsitclKJ0550vK3M/IS1oVTHT1c4DSNqG0h+vKRVYQrYy0CDDH9AcL4oC BxCOfPE7K5DWsCN4+hQmQ5PO8VNZm6SgdjL8nKi89mBkrhQy2IoJtSVhd+3nZQgXXPKFUDxEjlG Skk8 X-Received: by 2002:a17:90b:2c87:b0:398:ceef:edde with SMTP id 98e67ed59e1d1-39b133026e6mr1191332a91.15.1788411183106; Wed, 02 Sep 2026 21:53:03 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d0d7e8sm2747538a91.16.2026.09.02.21.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 21:53:02 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Shunli Wang , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v4 4/5] ASoC: mediatek: mt8183: Use dev_err_probe() for error handling Date: Thu, 3 Sep 2026 11:52:02 +0700 Message-ID: <20260903045203.175337-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260903045203.175337-1-phucduc.bui@gmail.com> References: <20260903045203.175337-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Replace dev_err() with dev_err_probe() to prevent log spam when probe returns -EPROBE_DEFER. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v3: - Add a Reviewed-by tag. sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index 06556689976d..40f9afcdaa16 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -101,12 +101,9 @@ int mt8183_init_clock(struct mtk_base_afe *afe) =20 for (i =3D 0; i < CLK_NUM; i++) { afe_priv->clk[i] =3D devm_clk_get(afe->dev, aud_clks[i]); - if (IS_ERR(afe_priv->clk[i])) { - dev_err(afe->dev, "%s(), devm_clk_get %s fail, ret %ld\n", - __func__, aud_clks[i], - PTR_ERR(afe_priv->clk[i])); - return PTR_ERR(afe_priv->clk[i]); - } + if (IS_ERR(afe_priv->clk[i])) + return dev_err_probe(afe->dev, PTR_ERR(afe_priv->clk[i]), + "failed to get clock %s\n", aud_clks[i]); } =20 return 0; --=20 2.43.0 From nobody Sat Sep 26 08:37:09 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BDCC23BD06 for ; Thu, 3 Sep 2026 04:53:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411189; cv=none; b=WywH/ny1sUb7zBfiij19rN3ALg0Xcz8hwVAsPTpCwig32VMmH876okFS28mhjP6QaugarKPkjWmUPXq8wvPVN0I2mOsW5IL0AekvZlZ+XBnH7gp4H0BDnrSHjCzKBSUmO5l/hU+bUamYFztGGQmhVloNvIqLwhBkTDHjUd0GZR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411189; c=relaxed/simple; bh=3GhUN1YWxQu4bJXtiFoeLFL4w/RSX1buQvfT36CMNsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YNrHMcUuIOir6A76SOFPKBha2ppOn+XI89JrlRlHkfIlShhcjNPNoGsimgC2YoifeJdi8GdMc7njAg2WzkoW1dxbKTxsd/IQY5EfLzOlSiHRqAM0SxuxPHQcFWZWJWOFFWSEJgjVeRn5eo2SYJYC1eFxSH9uAOgwyqNM8N7r7d0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=medGUtK+; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="medGUtK+" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-cb5b8572b70so2092277a12.2 for ; Wed, 02 Sep 2026 21:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788411187; x=1789015987; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a4ksl9SsTnU1qraDN3sQ8M70vtHGdDPB0HKfqeC0tuc=; b=medGUtK+zwgPcPqNiqnsb24JTkDaQqeihSAJbSe5lZ296VUmAt2ttAR8AcW6cvu1XA VCOEDaYkBRto834W/C8O2IfbRKy+2xzTZI6JZr2TfxDKJuLGd7/I964VMBiaKlYe3n3N yV5vU5c4Y+wCmQlILojZocSXL0DHDq+YEvo/2ezQyjekPOl7iVizrmwaGtcqX+Y2KtW/ xZ2X+fwIujT+YZVIQExNhMyjO6LaiuJE6b/cbQRqipyNT4YYImIzUerF7359ruTQtPJ9 Ba7/ejneD+g2RFBPaGKOhp2oL4jQ07u1mMj7JYovztd5pZxjtiSL72KQBwiWSTq3UPWf WGWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788411187; x=1789015987; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=a4ksl9SsTnU1qraDN3sQ8M70vtHGdDPB0HKfqeC0tuc=; b=V8hJFbZX5btx1m4LH8i90AnplrVXnxQW07xqJhIkK0uD47QuZ4O1nGEUspBFqKZbxk m1oP7gSvXfztQZrVnhccebYPtMlQGk4SwWSLSxO+YthysVEkDcBcNWsRq9ziglkqMekI jwx/oZF2xi6XQXC9QH+FQPTpvjRFBFNd1Ff8rTEZCLztBhVN7En9VVkbeqDfGYl3SvA4 hPtDrbMOqdAbLWkAEwTn4R/95Zx033X1GRqViGsiPqpb6BB5aDNroRP4JmgM2DiBnV0G EMSpR0IU1AfsNi2qHet7AKhWh4k+Qoxj36cQsHQlO8NdfHqpxiFPjgBS5N3PSdASc50z qt1A== X-Forwarded-Encrypted: i=1; AKwUvBzmKZZOogQNy9xpr1dDQrRtk++7vn9AIY/00HcUpERjk7Oqlpv6MBkNsO9jniltWrWffGVMeFKbRRSP+ME=@vger.kernel.org X-Gm-Message-State: AFuF++nq4+LeTcAnasAba3UgtL4ZRUbS7C9vrZuKpcVMwhGuuuVIVahg NaLjJLi0PVU1imUcdkbpe6WquDUNyzIn7m701JkJZ2hT/DyaaR3SogsjIarKXQ== X-Gm-Gg: AYBFou1I2664s1ARQyKi3EL485jJP7QBKA+MgOJ13SPzNSunBk+d61f6dwjENWb2Tnc W3ARIYmFNKExP+7AUyuaBgh1nB81RNhGbJXE8D/rmrkjgm2GH3bzrKHmGfpaoEwfOSYALbohoFv PAYPskWObRXxla9udH4mk3qAOV4PQUer0nslVuGO6lyv1B714YMqcIRcj2l/LBACCJi1Mw9XApB 8B8uVmNSdTkBc7ZfGFV/qQ7CZT6r7wVNnggC0K7LM3DqUx1C5TeDEhe45MhDLBHX955otA3tdgQ O8LgVsSi8HBTof58cHw8ETxz9IUBuGV2VZE/uDj6c1zl56NOfZ2Xj4MFA257qGrNA0i+gBrctSz duiV2pUK3aJLSX9kZUzAbWSd1bHI5lr2EnwwqEJHNCpVpdrMDMOw8zQPnBChHvwFvul13omLBjT VVTiFQMaAS7IfyKuTc8S2mZSt9NQ+YG+iz8wU+z2nfctK6cP2lZL+Q7dSekzfn4jis/xhTbMAn4 /9th36f6UKh8ZaVujmtEZKy3nJ7THZZyYw6NTjqn2r3dVBelPQiTKlvIqK6ABTqV2OK4IErxgfW rYZbvX2UAQnM7j5E X-Received: by 2002:a17:90b:4407:b0:398:9bd4:d13 with SMTP id 98e67ed59e1d1-39aee219427mr14283857a91.18.1788411187416; Wed, 02 Sep 2026 21:53:07 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d0d7e8sm2747538a91.16.2026.09.02.21.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 21:53:07 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Shunli Wang , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v4 5/5] ASoC: mediatek: mt8183: Drop redundant probe error messages Date: Thu, 3 Sep 2026 11:52:03 +0700 Message-ID: <20260903045203.175337-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260903045203.175337-1-phucduc.bui@gmail.com> References: <20260903045203.175337-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() calls are redundant and can be removed. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v3: - Add a Reviewed-by tag. sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c b/sound/soc/mediate= k/mt8183/mt8183-afe-pcm.c index 2634699534db..46b7a2bb6aaa 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c @@ -809,10 +809,8 @@ static int mt8183_afe_pcm_dev_probe(struct platform_de= vice *pdev) =20 /* initial audio related clock */ ret =3D mt8183_init_clock(afe); - if (ret) { - dev_err(dev, "init clock error\n"); + if (ret) return ret; - } =20 pm_runtime_enable(dev); =20 @@ -903,10 +901,8 @@ static int mt8183_afe_pcm_dev_probe(struct platform_de= vice *pdev) =20 ret =3D devm_request_irq(dev, irq_id, mt8183_afe_irq_handler, IRQF_TRIGGER_NONE, "asys-isr", (void *)afe); - if (ret) { - dev_err(dev, "could not request_irq for asys-isr\n"); + if (ret) goto err_pm_disable; - } =20 /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); --=20 2.43.0