From nobody Sat Sep 26 07:15:50 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AD524BAA11; Thu, 3 Sep 2026 14:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788446919; cv=none; b=LTzK1CSraA1ZzHcZ6Y1vPUv8kqfGshVSx8Kr6XJgLttaWiGkIYqQiX9OUOCTcxm8nBiCDBXlpG5rAU0psV5ES1Tr7lI10oQ2NEo4A2qZkcw+Os7F5Mna3G8h9AiDg1wNMG5qfJrKO4+FYpPorJtDPV/6cmthmzkV4Cu8w42NET0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788446919; c=relaxed/simple; bh=5gXb7Svmbzm19E+aV5DRmQMlrpXRccSgrIB48SHfJZM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uvVktrVjuVMF/RPYH8IAOe1bUS1+wjlqooOjLqPkwqVDP+WU/Hx2/mjSlp+Tr34wBaBFLiUfJoUJLviLgb4OUH5a3y7GRN/3zLvll2bFzp+MhAFzdlM2ZYGqqTrtU9RM4NTrd0Y7RLb1ATQmbLaDUb5wkzkfj73nuAlSkQBwYWc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ML/ABLet; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=sDvH/H9K; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ML/ABLet"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="sDvH/H9K" From: Gregor Herburger DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1788446915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKX7vhK3Qg0KTc+n/IWnFbUYvJzoTnDiZZHzdRCOUWw=; b=ML/ABLetsAw/guKeltqNyRNdfrMmg5U3qwfjCiRU4zqBliyDa82+rETs4OPMz8APikUg2y 81LrudpBwxGeBh4ONb2z5Ta2CUQRkDfEhrR54QxaDV1wUyzw+GCna0CAPdkhGF4WaTYFOs n2PhpB0oBe8Cqs6iNg+opfSpK5P9zfp4REjxfJ9tm6cj8YI6HI0nQTyg/pSHJZw45opzQQ geTGmPPPi/HpmCRECA7kjLSdB/6QT77r8/tKbBah8iv6Z5pk2aaeJ80oswJ3z/0AQcJZHF r/n2y3yqaMPbSUrDrDXrq5ZN5rptj5YbtURLk//KDJum7fEhoBWDCHCVqLApZA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1788446915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKX7vhK3Qg0KTc+n/IWnFbUYvJzoTnDiZZHzdRCOUWw=; b=sDvH/H9Ki2EDi3kbo3VDKivvFCGTX1tbPLv5B8MCai5X46Pu/Q42BtxPdiPkC+l2Pa/yvh AGXJSOjx1obWNoAw== Date: Thu, 03 Sep 2026 16:48:25 +0200 Subject: [PATCH RESEND v3 1/4] firmware: raspberrypi: reorder rpi_firmware_property_tag enum Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260903-rpi-tryboot-v3-1-ce94c347e932@linutronix.de> References: <20260903-rpi-tryboot-v3-0-ce94c347e932@linutronix.de> In-Reply-To: <20260903-rpi-tryboot-v3-0-ce94c347e932@linutronix.de> To: Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Eric Anholt , Stefan Wahren Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Gregor Herburger X-Developer-Signature: v=1; a=ed25519-sha256; t=1788446914; l=4658; i=gregor.herburger@linutronix.de; s=20260226; h=from:subject:message-id; bh=5gXb7Svmbzm19E+aV5DRmQMlrpXRccSgrIB48SHfJZM=; b=Islazb9ATXh8rxnUph7we5O2UGynEnbAUEgoq38ysuBOPmIwX33jReharHFMuKEyjLFEZmTnH chAYXI+VQBgDsPpEVOc2lLWP3ceLlLN6tM6y3GyKQf68FodeEUxnvWb X-Developer-Key: i=gregor.herburger@linutronix.de; a=ed25519; pk=u72Lv7+/lS5CC1hmSrb17lv/6CK7HBh4Lvz77PHA5LM= The enum was once ordered by tag values. The later added tags were added in a different order. Reorder the tags again. No functional change intended. Signed-off-by: Gregor Herburger --- include/soc/bcm2835/raspberrypi-firmware.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm28= 35/raspberrypi-firmware.h index e1f87fbfe5542..66cc5a426c3c5 100644 --- a/include/soc/bcm2835/raspberrypi-firmware.h +++ b/include/soc/bcm2835/raspberrypi-firmware.h @@ -72,26 +72,26 @@ enum rpi_firmware_property_tag { RPI_FIRMWARE_GET_EDID_BLOCK =3D 0x00030020, RPI_FIRMWARE_GET_CUSTOMER_OTP =3D 0x00030021, RPI_FIRMWARE_GET_DOMAIN_STATE =3D 0x00030030, + RPI_FIRMWARE_GET_GPIO_STATE =3D 0x00030041, + RPI_FIRMWARE_GET_GPIO_CONFIG =3D 0x00030043, + RPI_FIRMWARE_GET_PERIPH_REG =3D 0x00030045, RPI_FIRMWARE_GET_THROTTLED =3D 0x00030046, RPI_FIRMWARE_GET_CLOCK_MEASURED =3D 0x00030047, RPI_FIRMWARE_NOTIFY_REBOOT =3D 0x00030048, + RPI_FIRMWARE_GET_POE_HAT_VAL =3D 0x00030049, + RPI_FIRMWARE_SET_POE_HAT_VAL =3D 0x00030050, + RPI_FIRMWARE_NOTIFY_XHCI_RESET =3D 0x00030058, + RPI_FIRMWARE_NOTIFY_DISPLAY_DONE =3D 0x00030066, RPI_FIRMWARE_SET_CLOCK_STATE =3D 0x00038001, RPI_FIRMWARE_SET_CLOCK_RATE =3D 0x00038002, RPI_FIRMWARE_SET_VOLTAGE =3D 0x00038003, RPI_FIRMWARE_SET_TURBO =3D 0x00038009, RPI_FIRMWARE_SET_CUSTOMER_OTP =3D 0x00038021, RPI_FIRMWARE_SET_DOMAIN_STATE =3D 0x00038030, - RPI_FIRMWARE_GET_GPIO_STATE =3D 0x00030041, RPI_FIRMWARE_SET_GPIO_STATE =3D 0x00038041, RPI_FIRMWARE_SET_SDHOST_CLOCK =3D 0x00038042, - RPI_FIRMWARE_GET_GPIO_CONFIG =3D 0x00030043, RPI_FIRMWARE_SET_GPIO_CONFIG =3D 0x00038043, - RPI_FIRMWARE_GET_PERIPH_REG =3D 0x00030045, RPI_FIRMWARE_SET_PERIPH_REG =3D 0x00038045, - RPI_FIRMWARE_GET_POE_HAT_VAL =3D 0x00030049, - RPI_FIRMWARE_SET_POE_HAT_VAL =3D 0x00030050, - RPI_FIRMWARE_NOTIFY_XHCI_RESET =3D 0x00030058, - RPI_FIRMWARE_NOTIFY_DISPLAY_DONE =3D 0x00030066, =20 /* Dispmanx TAGS */ RPI_FIRMWARE_FRAMEBUFFER_ALLOCATE =3D 0x00040001, @@ -107,7 +107,6 @@ enum rpi_firmware_property_tag { RPI_FIRMWARE_FRAMEBUFFER_GET_PALETTE =3D 0x0004000b, RPI_FIRMWARE_FRAMEBUFFER_GET_TOUCHBUF =3D 0x0004000f, RPI_FIRMWARE_FRAMEBUFFER_GET_GPIOVIRTBUF =3D 0x00040010, - RPI_FIRMWARE_FRAMEBUFFER_RELEASE =3D 0x00048001, RPI_FIRMWARE_FRAMEBUFFER_TEST_PHYSICAL_WIDTH_HEIGHT =3D 0x00044003, RPI_FIRMWARE_FRAMEBUFFER_TEST_VIRTUAL_WIDTH_HEIGHT =3D 0x00044004, RPI_FIRMWARE_FRAMEBUFFER_TEST_DEPTH =3D 0x00044005, @@ -117,6 +116,7 @@ enum rpi_firmware_property_tag { RPI_FIRMWARE_FRAMEBUFFER_TEST_OVERSCAN =3D 0x0004400a, RPI_FIRMWARE_FRAMEBUFFER_TEST_PALETTE =3D 0x0004400b, RPI_FIRMWARE_FRAMEBUFFER_TEST_VSYNC =3D 0x0004400e, + RPI_FIRMWARE_FRAMEBUFFER_RELEASE =3D 0x00048001, RPI_FIRMWARE_FRAMEBUFFER_SET_PHYSICAL_WIDTH_HEIGHT =3D 0x00048003, RPI_FIRMWARE_FRAMEBUFFER_SET_VIRTUAL_WIDTH_HEIGHT =3D 0x00048004, RPI_FIRMWARE_FRAMEBUFFER_SET_DEPTH =3D 0x00048005, @@ -125,10 +125,10 @@ enum rpi_firmware_property_tag { RPI_FIRMWARE_FRAMEBUFFER_SET_VIRTUAL_OFFSET =3D 0x00048009, RPI_FIRMWARE_FRAMEBUFFER_SET_OVERSCAN =3D 0x0004800a, RPI_FIRMWARE_FRAMEBUFFER_SET_PALETTE =3D 0x0004800b, - RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF =3D 0x0004801f, - RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF =3D 0x00048020, RPI_FIRMWARE_FRAMEBUFFER_SET_VSYNC =3D 0x0004800e, RPI_FIRMWARE_FRAMEBUFFER_SET_BACKLIGHT =3D 0x0004800f, + RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF =3D 0x0004801f, + RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF =3D 0x00048020, =20 RPI_FIRMWARE_VCHIQ_INIT =3D 0x00048010, =20 --=20 2.47.3 From nobody Sat Sep 26 07:15:50 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3238F4BB808; Thu, 3 Sep 2026 14:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788446921; cv=none; b=sVLrVqqIDKAofd89fMz1ubYmuzL+ih8v3DJWYqcLU9tYRv8pbSvsOFnEBMfH66aamjqTgTkoEyqDEcx6kM7z7tSfxbfjoGTViCDB134M5geQGLxsCrg/pBl+tJi+D0WAMDTE2sXlA3hsg1cNq1SPNqAqUh+A1uGnAEpWpbxp3xk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788446921; c=relaxed/simple; bh=JTGSzF3cwcMgL2GV7Aem6Nhh3tKER7RTd2LK3CeGm58=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=opTfLQeAXyLjHWOrasVFYA/hWLlA0HHesL/D7z9dk21FpS1SdKe0IrgIxopq5Lcgwk/1XwwF2erOWYcLIweEHGiU3IokjEPTNH8L7q4lIfOELS6mhW+3uADeKevGtkx8OxZLMVFdUpoflWvxkHEeSGTar/r2anvbfi5Qzv95aJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=kcVOrehi; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=P1qSdgCo; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kcVOrehi"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="P1qSdgCo" From: Gregor Herburger DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1788446915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZlSADl29CmHDkOq9VyOqS+dZQ9n9eCe+aPQc5gMZi0s=; b=kcVOrehiwgUoztKT9Doz9kR8GAfkysGGReM2dGcyf6nX0TUcyvfE7Vpg80SnsFnCQcfuoT 2P+o2iOEZF3B+thhyIV5n0pWeHcuhD5xUKCFyP19ffTUUd57s8sCI73Ni/sFT+lwFl4yUZ Twju7jhd5xPY71EzR04t5KrdBnLVReJ2aOKiP1lRd1dnbwNc3bcp8EqB6fyM7/8djh24Ik l++baqbC6xMTz+Tb0VmNH/Sm81jp4CtN0+nUS6CfrAakfo3B+Y7vyeJrP1EHxDxqspuPxX nDIEM4vCcioJ6ojPxuzMPvy7MigXlATaDOQtxe49tYBRHEkGM5UryyOljoT7dA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1788446915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZlSADl29CmHDkOq9VyOqS+dZQ9n9eCe+aPQc5gMZi0s=; b=P1qSdgCoBr6gRHhxabq39aEzODHaVKeJRcSVvM08+BFlTNdCGlzoFy6ogEmdxFdOgTR+2k v6SdiaWd3MpqwkDg== Date: Thu, 03 Sep 2026 16:48:26 +0200 Subject: [PATCH RESEND v3 2/4] dt-bindings: raspberrypi,bcm2835-firmware: Include 'reboot-mode.yaml' Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260903-rpi-tryboot-v3-2-ce94c347e932@linutronix.de> References: <20260903-rpi-tryboot-v3-0-ce94c347e932@linutronix.de> In-Reply-To: <20260903-rpi-tryboot-v3-0-ce94c347e932@linutronix.de> To: Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Eric Anholt , Stefan Wahren Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Gregor Herburger X-Developer-Signature: v=1; a=ed25519-sha256; t=1788446914; l=1239; i=gregor.herburger@linutronix.de; s=20260226; h=from:subject:message-id; bh=JTGSzF3cwcMgL2GV7Aem6Nhh3tKER7RTd2LK3CeGm58=; b=e2HL80+u/GDmdsWfWN9gm+5v/i+IHGvOH1IKTzBafJrpft5pylwb0GoDHDIMutWy3xnh13Ypn srE6thv//R0A6PtCaZhb1OlXf64wIdvAjgxZli8on3LiieDAAdo0PmI X-Developer-Key: i=gregor.herburger@linutronix.de; a=ed25519; pk=u72Lv7+/lS5CC1hmSrb17lv/6CK7HBh4Lvz77PHA5LM= The Raspberry Pi firmware allows to set a reboot mode called tryboot that allows to try booting from a different partition to allow updating of the boot partition. Allow reboot mode properties by referencing the reboot-mode schema. The firmware allows a 32bit value to be sent as reboot flag so restrict the maxItems to 1. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Gregor Herburger --- .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++= ++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-= firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm28= 35-firmware.yaml index 983ea80eaec97..28c5713860468 100644 --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmwar= e.yaml +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmwar= e.yaml @@ -133,6 +133,15 @@ properties: required: - compatible =20 + mode-normal: + maxItems: 1 + + mode-tryboot: + maxItems: 1 + +allOf: + - $ref: /schemas/power/reset/reboot-mode.yaml# + required: - compatible - mboxes --=20 2.47.3 From nobody Sat Sep 26 07:15:50 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF9244BB80D; Thu, 3 Sep 2026 14:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788446919; cv=none; b=BPJOptBYOj8P5vXE20a3vDmJwdboe1OWfqXCc7z3xR9w3Rp8W4aak21WXRbyueIOv1WRNfQhyLWULDw4tc/aIJWSksj3gU2Azo8YPPIyLy/9DISwWMIj9lqIeUVaBH3n8YR6fdDtIEgAPpp9mo397UX3SY19SQxdXmYFowgBo+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788446919; c=relaxed/simple; bh=7PR0tE664SrEKUrrvEpFf3dr9BxOTxo3gbfyZ5sTqwU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y6FIQFlfLWh5O1OkOGvwhYguE6OIsziPQogPq3lZIWbhxSz1SsEghIWucTg5PzTc+CRMR3iD+VRng6SLCeHp5z1Qsf1fVQmYmKL0RWXJZkGCsxbu264e0pvjChhq6lL4ej8SwudA1ZlsugGL+UXdW4MyF1sNuwRE/5oYwGQedpw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=QMufVQds; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=PsH/xDLN; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="QMufVQds"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="PsH/xDLN" From: Gregor Herburger DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1788446915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mSiPl1Eq7KKLTt1UhXrTqQ8J4cUQVL1d4HGOdMyYuAc=; b=QMufVQdsYuUDNntGCbXiKOsw4H4d1WuJWkRXsKmuKp9kSuhhjZN8Y3XI5VZyrX76McB5oB TWENZ6L8dOws5wmr3yES2EPlxPWuiW+0AdVPTgam0DquyyHQluTMsqR31EcaLnvxajyLLK lTah5iANXTKZmcrN4pyAMQLnCDVng8SA7DCNoD/QpeODLXT2Sc7cGIunSneLlZJejN9zfQ PKjn2gZ8Sb1WLyOd3aJs477E+sOvioUtzDFEKxpvUl0ixGUUBH8Gdjx5eLC+FhkI2FxYo+ JOjtgGdPKk7Hmw0GE/2gvEuoNddOYiKgtMr6hs39g8DtWPTZ9IfN4cic5eUBXw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1788446915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mSiPl1Eq7KKLTt1UhXrTqQ8J4cUQVL1d4HGOdMyYuAc=; b=PsH/xDLNtKV1q4CCq2HHgjs+jdHtdnM2CGrA7SsSn/1Cu0oO7BvYplOG+9MgLXcw8EACmD Y0/k7TOGw/UDvwCA== Date: Thu, 03 Sep 2026 16:48:27 +0200 Subject: [PATCH RESEND v3 3/4] firmware: raspberrypi: Add reboot mode support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260903-rpi-tryboot-v3-3-ce94c347e932@linutronix.de> References: <20260903-rpi-tryboot-v3-0-ce94c347e932@linutronix.de> In-Reply-To: <20260903-rpi-tryboot-v3-0-ce94c347e932@linutronix.de> To: Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Eric Anholt , Stefan Wahren Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Gregor Herburger X-Developer-Signature: v=1; a=ed25519-sha256; t=1788446914; l=5567; i=gregor.herburger@linutronix.de; s=20260226; h=from:subject:message-id; bh=7PR0tE664SrEKUrrvEpFf3dr9BxOTxo3gbfyZ5sTqwU=; b=rwnGF9xmd2kcTpNKSYflBkj2VOpyD2hiaUK268FmJ2yxnx027qSmQ/FDKvM5yMloSNQbxW7V8 tjc7wBNIO7mD7fwXPQ9NTW1eTKOrwij2GfceV/Y7IMirrCOsTo6zP+j X-Developer-Key: i=gregor.herburger@linutronix.de; a=ed25519; pk=u72Lv7+/lS5CC1hmSrb17lv/6CK7HBh4Lvz77PHA5LM= The Raspberry Pi firmware has a tryboot mode where it tries to boot from another partition. This can be used to create a A/B update scheme. To enable this on the next boot, the RPI_FIRMWARE_SET_REBOOT_FLAGS message must be sent to the firmware. Add support for this by registering a reboot mode driver. Furthermore, safely registering the reboot mode requires adjusting the teardown sequence. Replace the manually called rpi_firmware_put() with a devres-managed called (devm_add_action_or_reset). Without this, the cleanup function of devm_reboot_mode_register() would trigger a use-after-free error by attempting to access the firmware context after it had already been freed by rpi_firmware_remove(). Signed-off-by: Gregor Herburger --- drivers/firmware/Kconfig | 2 ++ drivers/firmware/raspberrypi.c | 40 ++++++++++++++++++++++++++= ---- include/soc/bcm2835/raspberrypi-firmware.h | 2 ++ 3 files changed, 39 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index bbd2155d84838..34605bf7c9734 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -115,6 +115,8 @@ config ISCSI_IBFT config RASPBERRYPI_FIRMWARE tristate "Raspberry Pi Firmware Driver" depends on BCM2835_MBOX + select POWER_RESET + select REBOOT_MODE help This option enables support for communicating with the firmware on the Raspberry Pi. diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c index 0aa322e9a2e73..2a0c40b8052e5 100644 --- a/drivers/firmware/raspberrypi.c +++ b/drivers/firmware/raspberrypi.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include =20 @@ -29,6 +30,7 @@ struct rpi_firmware { struct mbox_client cl; struct mbox_chan *chan; /* The property channel. */ struct completion c; + struct reboot_mode_driver reboot_mode; u32 enabled; =20 struct kref consumers; @@ -273,10 +275,37 @@ static void devm_rpi_firmware_put(void *data) rpi_firmware_put(fw); } =20 +static int rpi_firmware_reboot_mode_write(struct reboot_mode_driver *reboo= t, + unsigned int magic) +{ + struct rpi_firmware *fw =3D container_of(reboot, struct rpi_firmware, + reboot_mode); + __le32 fw_magic =3D cpu_to_le32(magic); + + if (!magic) + return 0; + + return rpi_firmware_property(fw, RPI_FIRMWARE_SET_REBOOT_FLAGS, + &fw_magic, sizeof(fw_magic)); +} + +static void rpi_register_reboot_mode(struct device *dev, struct rpi_firmwa= re *fw) +{ + int ret; + + fw->reboot_mode.dev =3D dev; + fw->reboot_mode.write =3D rpi_firmware_reboot_mode_write; + ret =3D devm_reboot_mode_register(dev, &fw->reboot_mode); + if (ret) + dev_err(dev, "Failed to register reboot mode: %d\n", ret); + +} + static int rpi_firmware_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct rpi_firmware *fw; + int ret; =20 /* * Memory will be freed by rpi_firmware_delete() once all users have @@ -292,7 +321,7 @@ static int rpi_firmware_probe(struct platform_device *p= dev) =20 fw->chan =3D mbox_request_channel(&fw->cl, 0); if (IS_ERR(fw->chan)) { - int ret =3D PTR_ERR(fw->chan); + ret =3D PTR_ERR(fw->chan); kfree(fw); return dev_err_probe(dev, ret, "Failed to get mbox channel\n"); } @@ -302,9 +331,14 @@ static int rpi_firmware_probe(struct platform_device *= pdev) =20 platform_set_drvdata(pdev, fw); =20 + ret =3D devm_add_action_or_reset(dev, devm_rpi_firmware_put, fw); + if (ret) + return ret; + rpi_firmware_print_firmware_revision(fw); rpi_register_hwmon_driver(dev, fw); rpi_register_clk_driver(dev); + rpi_register_reboot_mode(dev, fw); =20 return 0; } @@ -321,14 +355,10 @@ static void rpi_firmware_shutdown(struct platform_dev= ice *pdev) =20 static void rpi_firmware_remove(struct platform_device *pdev) { - struct rpi_firmware *fw =3D platform_get_drvdata(pdev); - platform_device_unregister(rpi_hwmon); rpi_hwmon =3D NULL; platform_device_unregister(rpi_clk); rpi_clk =3D NULL; - - rpi_firmware_put(fw); } =20 static const struct of_device_id rpi_firmware_of_match[] =3D { diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm28= 35/raspberrypi-firmware.h index 66cc5a426c3c5..f905bff0fb3ea 100644 --- a/include/soc/bcm2835/raspberrypi-firmware.h +++ b/include/soc/bcm2835/raspberrypi-firmware.h @@ -81,6 +81,7 @@ enum rpi_firmware_property_tag { RPI_FIRMWARE_GET_POE_HAT_VAL =3D 0x00030049, RPI_FIRMWARE_SET_POE_HAT_VAL =3D 0x00030050, RPI_FIRMWARE_NOTIFY_XHCI_RESET =3D 0x00030058, + RPI_FIRMWARE_GET_REBOOT_FLAGS =3D 0x00030064, RPI_FIRMWARE_NOTIFY_DISPLAY_DONE =3D 0x00030066, RPI_FIRMWARE_SET_CLOCK_STATE =3D 0x00038001, RPI_FIRMWARE_SET_CLOCK_RATE =3D 0x00038002, @@ -92,6 +93,7 @@ enum rpi_firmware_property_tag { RPI_FIRMWARE_SET_SDHOST_CLOCK =3D 0x00038042, RPI_FIRMWARE_SET_GPIO_CONFIG =3D 0x00038043, RPI_FIRMWARE_SET_PERIPH_REG =3D 0x00038045, + RPI_FIRMWARE_SET_REBOOT_FLAGS =3D 0x00038064, =20 /* Dispmanx TAGS */ RPI_FIRMWARE_FRAMEBUFFER_ALLOCATE =3D 0x00040001, --=20 2.47.3 From nobody Sat Sep 26 07:15:50 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2ACC4BC022; Thu, 3 Sep 2026 14:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788446919; cv=none; b=prf7W7zFwKCBrLeboO82WiZ8uYIn6CHWooIp+mmbzBDS1p1EAYv2jPsDevKQ5b1X12HL09mO5nPodDc7w+gOcvSmIqvdmzJGyjmTEIBm9yULhvf9MAZMGxsELZHOgiqNOaIz4mqxGjhBBAzp8hvEC8yx/epApuUmNXCoowkLtps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788446919; c=relaxed/simple; bh=mtAzetqs605P30BAlqjqWHlKtFDY7Xar7nSqW4P19ok=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fEn5b8HEJHvlx7pnZOa9CbkqFcmDnV9doI17TQoT72MdBBQZ4SNSASlvtJPXajw2r12SWgrtXQdUyKikvAFst2FiEg08H9Lsd7kzBPltwCXkMsA0kDMT0vOm9BprxqAx8XSWr8JxIV2VmKPdPnz1xR1yuNhB7fJX0rLj1wZTHIg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=kLfVyQdq; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=Ue6BL3zR; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kLfVyQdq"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Ue6BL3zR" From: Gregor Herburger DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1788446916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=64FPqO/LfunvshSq+IFyW+9AM3tTCc0dWxi+1v1KXro=; b=kLfVyQdqKaqWu7+ybKASS563UxQtYZQCXW+jvNUpiHVRuUSrmWEunpaZ8yN6rchzHe7WG/ nZsi8XFEnpx1a8d2Xuc4ht01xZiUJuuttoiadvocAugLXdSTybNqJ3pYLsjPL+NTUbtTBk 5CZyrL/L6CTrOY4jGZds135uSGEsBk1AOz4ra6EfdLSnKNSjyoUakbhWSRUNr7TShhkE2t PtawV84luBeYm+Zr5PQfL2rym1Z80ESMWugrhcXHh2F2zme3r1ep6HFzAb7IKfxxfvwET8 5JtHKX18GmAIdhXO6mQBCv0JSyqUxpAtlmQNBGjKpi83HaANn5HSNDo+cWS4wg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1788446916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=64FPqO/LfunvshSq+IFyW+9AM3tTCc0dWxi+1v1KXro=; b=Ue6BL3zRXDnF5m1W78nftmClAV9ngCWDzm/IUGSdGRDPGMy72QlMr3yGb5wYwFK9dj5YEQ 2VnMh8i+KmZPOjCA== Date: Thu, 03 Sep 2026 16:48:28 +0200 Subject: [PATCH RESEND v3 4/4] arm64: dts: broadcom: bcm2712: Add reboot modes to firmware node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260903-rpi-tryboot-v3-4-ce94c347e932@linutronix.de> References: <20260903-rpi-tryboot-v3-0-ce94c347e932@linutronix.de> In-Reply-To: <20260903-rpi-tryboot-v3-0-ce94c347e932@linutronix.de> To: Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Eric Anholt , Stefan Wahren Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Gregor Herburger X-Developer-Signature: v=1; a=ed25519-sha256; t=1788446914; l=866; i=gregor.herburger@linutronix.de; s=20260226; h=from:subject:message-id; bh=mtAzetqs605P30BAlqjqWHlKtFDY7Xar7nSqW4P19ok=; b=xbHsHiNURnjx5H8h6p0fX9G85TwP3cQqhi9Hqp8E1Q1j4HtVhpeOYMX9K0gQk1wSvQq/5bvr2 86ibDgOwGqVAYWZJCqq+hvDKXmCr654G7E6uJNW37l2oN9zGNXm4v45 X-Developer-Key: i=gregor.herburger@linutronix.de; a=ed25519; pk=u72Lv7+/lS5CC1hmSrb17lv/6CK7HBh4Lvz77PHA5LM= The Raspberry Pi firmware driver allows the tryboot reboot mode. Add this mode and normal boot mode to the node. Signed-off-by: Gregor Herburger --- arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi b/arch/= arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi index b7a6bc34ae1ab..67095c7ff770d 100644 --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi @@ -49,6 +49,8 @@ firmware: rpi-firmware { compatible =3D "raspberrypi,bcm2835-firmware", "simple-mfd"; =20 mboxes =3D <&mailbox>; + mode-normal =3D <0>; + mode-tryboot =3D <1>; =20 firmware_clocks: clocks { compatible =3D "raspberrypi,firmware-clocks"; --=20 2.47.3