From nobody Sat Sep 26 09:16:54 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D2D537756B for ; Wed, 2 Sep 2026 17:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788371260; cv=none; b=tP14Ap6yebha++WLounYwo1Rd+Zx1QJin/vYeAw+PCXkkChskuA0pN1F7E+8A9EC+ryQT7DdETW6zSaUu0o32HHSSLV6n195Z6rTOWLgJJE8tgxAOjQ5MuPAffbSKddtYVtZACqi0jrWP6ReLIuegtyToon5oudvfgwsE5+EOJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788371260; c=relaxed/simple; bh=gXEosb8CMRb1UXN41ZT9pY3EtnW7zgAt89WGeEYzu2c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Wz+LSbAuemxK6+hepXUUz3tZVr9XMB0TEY0P0u18qpYvk4J09vtZA2zmtctATMjfr5WcO0Nby/+mssDLQ5uF/0fykmF217SEATlkGj729qssDzHRCLd6inbraldcM5VfL4bEvcf5elNx+xJX/M7gDYexuFSh8S6FctRNjSP3fko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eSR9BfuY; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eSR9BfuY" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-398a5aad413so1272419a91.3 for ; Wed, 02 Sep 2026 10:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788371258; x=1788976058; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Ay1coFvWOs2E2g41bXIVDKRlEoaNqpmJez8UBW0Q5bY=; b=eSR9BfuYsSUpniVwiv4SGZC2rX2fnQiLrpTyvwttsURol7txP1s8e7fRWjXU66cshP T4tN3aSbDT01+72POcXZ5TLUj4+LjHts2P4miSKrelFpt76Ts2xPBGv2hnJZtzZJQutQ /zTkb8OcVZIImXXVmQhjwJRN400SJoEVQnXrs5qTHtoISDm+V8CIxJuoAZSq4wpM1Ezv 55MjLNFU7VM2qLUmLTxT8A6Oz8ou5G42UCNe5fz5ptwHVFOULOQL4U4tQymAeTQ2dpry EjS0gT1QSYT21UILCniNl8Qr70ndMNBJ0o8cjA8cl5zsp+Ow5Jn+5GP1v+MkgG2HJ/OD bW+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788371258; x=1788976058; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ay1coFvWOs2E2g41bXIVDKRlEoaNqpmJez8UBW0Q5bY=; b=Oebg7GgSukbOUiE6P8TJqiQ6ytX1s6XClBZKeq4d9St0X1KczuZp6QUf0TJBwrFUMq R6tgB+gWyVqyIXMnIxgozOpRPh0s0stryk35irbeQELN9aF6Xgn1FQGPQ/xLv0PNdHmS 5q2QBHoqVXMY8N9xTWOA9GMrn719odU0/CkdoSbHBL+k8bGhkFXAjqssnK0q8ktz8brm kM1TVHf+WOAz3xxnxrfndmbzqYf/Zrv3h6Vn/riL02rTtENUA+LklZ8zKka0p3FLqS9L uUdmy4ynYE4zfiPADsUsc1aGzZ+6RUes4ernhAxu+rE+aBuvznvcT4IS14TookWYB2dH iKUA== X-Gm-Message-State: AFuF++mB8m3RZZ2zUp9VnWI82C0R14ODXLz8nlzn1XU0Q9Kjb8/TdMBH Eol22uIZVhKjbV/VcTwftC5S72buwg94r0IBNwXrvqKfHhs7dsMJnU2V X-Gm-Gg: AYBFou01xNZrHvxCyNN+DExbisCCksckdrylZ2wShJUFWYhJYC41Vkd3t2s67KK4p2m Vut/OPOmBTwfQEi13oP5k8LQvbpYMZ/YHtPZ8gfMOJoB0bA1AGtcU6pwAuKdq/2kWgPOPYJU9w3 qiG6gl03fHFI/HKmhdR1rFmUZI/z17NsF2xrn+I7grhijRtgtXTpyifm83xTl8wN619oizNvjOY qYWaQBW5oeANV51zElF0IGnoAAya6sMqITUKHn2VTPu+sYycLGe67gJGHKx6lXsauwV57KvCqBz YeG16qrHxgMLxhhgpo6Q5Cpwe752ouJzU1ipPDwyj97+CCG/8KYLUkBqIGFgmuMngOABXXkpS1h /3t8UJiCT8Z61wgROX/DmB3Y+N+1sR4OpoW1tfNnBVD3scGJFv0DuTrTwceU8IOfC6NKYYbDHEX kQH6Jb6NykT1sFrC8+E+yZvxeVQe/cayopsIJs040TzT07E7KWmULDe1/EYbv475bT5Zu0C9EQ2 acVqDzha7xYzOpE X-Received: by 2002:a17:90b:2f06:b0:398:a2a3:b631 with SMTP id 98e67ed59e1d1-39aee12359fmr10172568a91.19.1788371257581; Wed, 02 Sep 2026 10:47:37 -0700 (PDT) Received: from mizar.onca-liberty.ts.net ([182.10.129.37]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b083f04d1sm470584a91.8.2026.09.02.10.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 10:47:37 -0700 (PDT) From: Idotoho Reimon Simanjuntak To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Denis Benato , "Luke D . Jones" , Corentin Chary , Idotoho Reimon Simanjuntak Subject: [PATCH v3 1/3] platform/x86: asus-wmi: use named masks for TUF RGB commands Date: Thu, 3 Sep 2026 00:47:16 +0700 Message-ID: <20260902174718.16228-2-idotohors@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260902174718.16228-1-idotohors@gmail.com> References: <20260902174718.16228-1-idotohors@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Replace open-coded bit shifts and magic numbers in kbd_rgb_mode_store() and kbd_rgb_state_store() with FIELD_PREP() and named GENMASK() masks. Define ASUS_WMI_TUF_RGB_STATE_CMD_ID (0xbd) as a named constant instead of an inline literal, making the required arg0 command ID self-documenting. In kbd_rgb_state_store(), remove the unused intermediate "flags" variable entirely. The old BIT(1)/BIT(3)/BIT(5)/BIT(7) construction is replaced by FIELD_PREP with per-flag named masks (TUF_RGB_STATE_BOOT, _AWAKE, _SLEEP, _KEYBOARD), building arg0 directly. This preserves the exact sysfs input format ("cmd boot awake sleep keyboard") and the resulting WMI argument bit layout =E2=80=94 no behavioral change. In kbd_rgb_mode_store(), replace the positional shift expressions for arg1 and arg2 with FIELD_PREP using TUF_RGB_MODE_{CMD,MODE,RED,GREEN} and TUF_RGB_MODE_{BLUE,SPEED} masks respectively. This is a preparatory cleanup to improve readability before adding model-specific quirks that depend on these definitions. Signed-off-by: Idotoho Reimon Simanjuntak Reviewed-by: Denis Benato --- drivers/platform/x86/asus-wmi.c | 48 ++++++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 10 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index a65090429..efc730c2c 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -15,6 +15,7 @@ =20 #include #include +#include #include #include #include @@ -1047,6 +1048,27 @@ static DEVICE_ATTR_RW(gpu_mux_mode); #endif /* IS_ENABLED(CONFIG_ASUS_WMI_DEPRECATED_ATTRS) */ =20 /* TUF Laptop Keyboard RGB Modes *****************************************= *****/ + +/* Command IDs passed in arg0 byte 0 for TUF RGB WMI methods */ +#define ASUS_WMI_TUF_RGB_STATE_CMD_ID 0xbd + +/* Bit mask for the save-to-BIOS command flag in kbd_rgb_state_store (arg0= bit 10) */ +#define TUF_RGB_STATE_SAVE GENMASK(10, 10) + +/* Bit masks for kbd_rgb_state_store flags field (arg0 bits [23:16]) */ +#define TUF_RGB_STATE_BOOT GENMASK(17, 17) +#define TUF_RGB_STATE_AWAKE GENMASK(19, 19) +#define TUF_RGB_STATE_SLEEP GENMASK(21, 21) +#define TUF_RGB_STATE_KEYBOARD GENMASK(23, 23) + +/* Bit masks for kbd_rgb_mode_store fields */ +#define TUF_RGB_MODE_CMD GENMASK(7, 0) +#define TUF_RGB_MODE_MODE GENMASK(15, 8) +#define TUF_RGB_MODE_RED GENMASK(23, 16) +#define TUF_RGB_MODE_GREEN GENMASK(31, 24) +#define TUF_RGB_MODE_BLUE GENMASK(7, 0) +#define TUF_RGB_MODE_SPEED GENMASK(15, 8) + static ssize_t kbd_rgb_mode_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) @@ -1093,7 +1115,12 @@ static ssize_t kbd_rgb_mode_store(struct device *dev, } =20 err =3D asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, asus->kbd_rgb_d= ev, - cmd | (mode << 8) | (r << 16) | (g << 24), b | (speed << 8), NULL); + FIELD_PREP(TUF_RGB_MODE_CMD, cmd) | + FIELD_PREP(TUF_RGB_MODE_MODE, mode) | + FIELD_PREP(TUF_RGB_MODE_RED, r) | + FIELD_PREP(TUF_RGB_MODE_GREEN, g), + FIELD_PREP(TUF_RGB_MODE_BLUE, b) | + FIELD_PREP(TUF_RGB_MODE_SPEED, speed), NULL); if (err) return err; =20 @@ -1119,28 +1146,29 @@ static ssize_t kbd_rgb_state_store(struct device *d= ev, struct device_attribute *attr, const char *buf, size_t count) { - u32 flags, cmd, boot, awake, sleep, keyboard; + u32 cmd, boot, awake, sleep, keyboard; + u32 arg0; int err; =20 if (sscanf(buf, "%d %d %d %d %d", &cmd, &boot, &awake, &sleep, &keyboard)= !=3D 5) return -EINVAL; =20 + arg0 =3D ASUS_WMI_TUF_RGB_STATE_CMD_ID; + if (cmd) - cmd =3D BIT(2); + arg0 |=3D FIELD_PREP(TUF_RGB_STATE_SAVE, 1); =20 - flags =3D 0; if (boot) - flags |=3D BIT(1); + arg0 |=3D FIELD_PREP(TUF_RGB_STATE_BOOT, 1); if (awake) - flags |=3D BIT(3); + arg0 |=3D FIELD_PREP(TUF_RGB_STATE_AWAKE, 1); if (sleep) - flags |=3D BIT(5); + arg0 |=3D FIELD_PREP(TUF_RGB_STATE_SLEEP, 1); if (keyboard) - flags |=3D BIT(7); + arg0 |=3D FIELD_PREP(TUF_RGB_STATE_KEYBOARD, 1); =20 - /* 0xbd is the required default arg0 for the method. Nothing happens othe= rwise */ err =3D asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, - ASUS_WMI_DEVID_TUF_RGB_STATE, 0xbd | cmd << 8 | (flags << 16), 0, NULL); + ASUS_WMI_DEVID_TUF_RGB_STATE, arg0, 0, NULL); if (err) return err; =20 --=20 2.55.0 From nobody Sat Sep 26 09:16:54 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E81613806CE for ; Wed, 2 Sep 2026 17:47:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788371263; cv=none; b=TLXECeckWst2krX2Tzj1W+l32TcT8a5Qgl8rW/1RD4ux0z0gO/alSXVk4nxQQmo2C6iJo/TCeomuqByaCRKLcKaGuDs4Ubh42spA7Sbyo+FJ+s+fBYCjDsBF+UFtny6IF3s7V/sHz7WGj8e5B69OtX6zwo39Oa7viEadZerNUeI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788371263; c=relaxed/simple; bh=Gnwo5g26ZdBjXhq4bVso0MSd0E7+9jZGiDZSY4ytsB0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sVh4WYoFHNBTQb1fElaMWWJWf0Ltm0g+oCuykmOiIxTwLWAI93RWBvMFZLpUmvsSHcUybe1jj3d3nlGU0fTQwpJo160TY7sPRvg+lqHqdTWa7ICnI4wPeTYgyrT4yUxZjkCc+Wvk+D+DvqqPKawPr/a4mmL80HunXsfFPt/QYK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r2qnkU+k; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r2qnkU+k" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-cbe6295f05bso83124a12.1 for ; Wed, 02 Sep 2026 10:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788371261; x=1788976061; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gK8IuesNoWdraXJ5wAwBcjG5iXv0jgZkzfqTlwxb+kU=; b=r2qnkU+kRTRP+5kIsVBJNtsa+8TkGLLVK1UarvQmJqRfq7PjGGkkNXnIBDNAr6BQ/8 o2QzqZvhGTn3Rx46QTufnSVRljZzap1wKQ7evnTMqGVzZs08eN9ckLw68vSlQcpt6scy QuNmtiVwn9Uunxhq8lwuUqcqTZh4aVNNt4b2fN4t3ICwcsj/Y/mmFcDXw1UVJzbfx8Ft NiroxIhFiTwOMw5Z7vvJG+ZLBqzDmWMgcLivo4ss/b9aihQrsStOGL0YoC4QMW7iycg4 kQFBXjAk1yVw9bwY7xWgoh6YzhXcKPj4oWCK7oO/s1+GOq20nAs5Zx6Fh+zzvD7saPgT lMbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788371261; x=1788976061; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gK8IuesNoWdraXJ5wAwBcjG5iXv0jgZkzfqTlwxb+kU=; b=hk3jvuEaTJfXMv6XvUk6S3CX19ycaQWZzw++qfCPQvyN7wN9Q/El23O0edvaYWzhYv K+ZD5l+14zwQAMvJkUiEwO3Yz8vvG/r+KFyKsxQY49Aa9yc9lJOnJyyWhOK6+K1ZYHH9 fzBho0jYYnP6XH00G2TrAlOqYJysjBHmffeSxHKkVFNXztcFmq00pOf5ZEiJa0pRE9oP 45vFcQVHInFRqv23cRVknYxgAoYFMGFHXjU7MhIpqGm8r5LWj4M/+CGJJfUQ+FOG8SBZ qF0IMFDakFg14SPGG4oazY11V1+b3CKx6JHXIk5Gxdhvg5aoXvmynlfyRsou+rFaHf0t uO+A== X-Gm-Message-State: AFuF++nyUx4ghMIKxK37ygia7HQDlo6YVyg922QEMHrRrvMU6w1mnANU TXlOlpjbkM8Qe51OaPyWXxkNnaO7P4ZvHwvBvqBBBq/lZ8N4PJG3AXsI X-Gm-Gg: AYBFou0nGbTMY8IeQjLtV3Q5Id+tWyE9R26Sp6zIY3u23B1zs+mgXN1OGwNXJSSX6Uw lYnwlyVSG3KRWBFQNSaZoobWxMrwpt/iDBKtGbQxxQGcC0mPW58xYweaXgooSfOqNehvi1iCWqL F32u0myOiZdLRJxPHunG6ixZfsG3DtkXZZGOnk7gYS8kHHUeyyG1nM8pYwgueWJcc1WOtD0kC3m glvI2MWRRVbpzQIkU+cYGvF5qi3QTu/DlSBnayktcpUR+m8TLk4kXIA0phvFc5L06x2ctyEbogh vbVulB2IBq9nRc6tLZ6HKOR0tlVVPJz8RPS0HDyz8LVsiljehQZ6zvyRqFY/a9bJuuFC4Ga+Vl3 rhbesecIifNg+QFNwfCCV1Btcb7m7LmP0A+cCnKhZsHMnEMaA3ZOM/9DWiM5IVjmVUNC99u3tnB MgNlXRVe0mJ44YxCfF6BJMJ+RQrLGpc0F2ADPFPY3ngc6cy6cq28sDpFpa2JVKbwh2WPHwgAyoh P3XjtM= X-Received: by 2002:a17:90b:2b4c:b0:398:9bd3:d6d4 with SMTP id 98e67ed59e1d1-39b0865335dmr746973a91.14.1788371260842; Wed, 02 Sep 2026 10:47:40 -0700 (PDT) Received: from mizar.onca-liberty.ts.net ([182.10.129.37]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b083f04d1sm470584a91.8.2026.09.02.10.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 10:47:40 -0700 (PDT) From: Idotoho Reimon Simanjuntak To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Denis Benato , "Luke D . Jones" , Corentin Chary , Idotoho Reimon Simanjuntak Subject: [PATCH v3 2/3] platform/x86: asus-wmi: enable TUF RGB state for FA401 via DMI quirk Date: Thu, 3 Sep 2026 00:47:17 +0700 Message-ID: <20260902174718.16228-3-idotohors@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260902174718.16228-1-idotohors@gmail.com> References: <20260902174718.16228-1-idotohors@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The FA401 (TUF Gaming A14) series does not expose the TUF RGB state WMI device (0x00100057) through the standard DSTS probe, yet the EC does support the keyboard backlight power-state flags needed for sleep strobe functionality. Add a DMI-based quirk in asus-nb-wmi.c that matches on DMI_SYS_VENDOR "ASUSTeK COMPUTER INC." and DMI_BOARD_NAME "FA401", setting kbd_rgb_state_available =3D true in struct quirk_entry. In asus_wmi_add(), change the kbd_rgb_state_available assignment to also consider driver->quirks->kbd_rgb_state_available, so models with this quirk get the RGB state sysfs attributes even when DSTS probing fails. No PM/sleep/backlight changes are included in this commit; those will be addressed separately once the RGB state interface is available. Signed-off-by: Idotoho Reimon Simanjuntak Reviewed-by: Denis Benato --- drivers/platform/x86/asus-nb-wmi.c | 13 +++++++++++++ drivers/platform/x86/asus-wmi.c | 4 +++- drivers/platform/x86/asus-wmi.h | 1 + 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus= -nb-wmi.c index aeb461b16..47ceb6e46 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform/x86/asus-nb-wmi.c @@ -155,6 +155,10 @@ static struct quirk_entry quirk_asus_z13 =3D { .tablet_switch_mode =3D asus_wmi_kbd_dock_devid, }; =20 +static struct quirk_entry quirk_asus_fa401 =3D { + .kbd_rgb_state_available =3D true, +}; + static int dmi_matched(const struct dmi_system_id *dmi) { pr_info("Identified laptop model '%s'\n", dmi->ident); @@ -562,6 +566,15 @@ static const struct dmi_system_id asus_quirks[] =3D { }, .driver_data =3D &quirk_asus_z13, }, + { + .callback =3D dmi_matched, + .ident =3D "ASUSTeK COMPUTER INC. FA401", + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, "FA401"), + }, + .driver_data =3D &quirk_asus_fa401, + }, {}, }; =20 diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index efc730c2c..e7b2402c9 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -5181,7 +5181,9 @@ static int asus_wmi_add(struct platform_device *pdev) =20 asus->egpu_enable_available =3D asus_wmi_dev_is_present(asus, ASUS_WMI_DE= VID_EGPU); asus->dgpu_disable_available =3D asus_wmi_dev_is_present(asus, ASUS_WMI_D= EVID_DGPU); - asus->kbd_rgb_state_available =3D asus_wmi_dev_is_present(asus, ASUS_WMI_= DEVID_TUF_RGB_STATE); + asus->kbd_rgb_state_available =3D + asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_STATE) || + asus->driver->quirks->kbd_rgb_state_available; =20 if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MINI_LED_MODE)) asus->mini_led_dev_id =3D ASUS_WMI_DEVID_MINI_LED_MODE; diff --git a/drivers/platform/x86/asus-wmi.h b/drivers/platform/x86/asus-wm= i.h index 5cd4392b9..9bc0b6145 100644 --- a/drivers/platform/x86/asus-wmi.h +++ b/drivers/platform/x86/asus-wmi.h @@ -52,6 +52,7 @@ struct quirk_entry { */ int no_display_toggle; u32 xusb2pr; + bool kbd_rgb_state_available; }; =20 struct asus_wmi_driver { --=20 2.55.0 From nobody Sat Sep 26 09:16:54 2026 Received: from mail-pj2-f4.google.com (mail-pj2-f4.google.com [74.125.227.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748A538229A for ; Wed, 2 Sep 2026 17:47:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.132 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788371268; cv=none; b=Lk2H/Y6BfMJEMQ/qtZDEd3HEkOctrmbWChUKa2ZvZWQRRP9FAZn9sYJAN5de5G0dS/6qBBqkr6Yd2QiA8ccnrorpVENf3IbZ7vl3D0SFagTQ7nU73ekaJL5xlU/QiVzkzXz6Swt6mic8/5jweAMIW4Z2WQi16ZgaFR3WDuEjOKA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788371268; c=relaxed/simple; bh=l4BWUyVmdw3bRhpu4w/TpdB1tZZEAfrwW7TjVYO4510=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=icM3f7Rh8TTJ80xEtOONJucg97SxGZil8bdAxYxMKxXhjXjYD9Z3HW6y9CoenDkEPxKu9VjDeoOulzm21a/BTraqytbJ6qCdmctHuWvw9x5dImimk2RclmdubiCYjtxsg/SRSAUTc0yVqCXGhKUX88HSQkD/k0k/5FKH5MHKB3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cz+zPtaX; arc=none smtp.client-ip=74.125.227.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cz+zPtaX" Received: by mail-pj2-f4.google.com with SMTP id 98e67ed59e1d1-3896ccc93b5so435218a91.1 for ; Wed, 02 Sep 2026 10:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788371267; x=1788976067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9hgiYD9mAy7lLdpoQ7MWx+A7lz5nT32B2WH2DceHLJ4=; b=Cz+zPtaXWApdZ0v6C98cSj5sRMjHcf5hxOqgMLuskIPUpmibhBuyWFUKu1QhnbOgGp WtrlV5CIfGLghePSCCw7QDjOC/9cJ9lKdnZcnUGoBN4/UBhQR2/Px+JhD6T9hbywopUx 66mHHpnoT0hLZDJwwKQW5Nqy0kbVPmtDz6iOOTXcbWOUsr7EKXMrRMOYMTWHc94qw9+W Z3PaDinM7hHRm3d6FPR/OzF2LhpS7T1MRcMfo4+f109KpTyksR8TUuRPoq6TWY5YE7h+ iIdZMSFvUWPr6gqqgJG3MxWJN4hy4U6h+kjhUeD/JsoYWxouv8tPPRYbUNNdG5/x1xDT VZeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788371267; x=1788976067; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9hgiYD9mAy7lLdpoQ7MWx+A7lz5nT32B2WH2DceHLJ4=; b=ZIb0oeaoBpYEbqkZ7zo2mb3I2kBNgrEQ6eUT5dZxl0HLDCoPYjwnYVya9UTaxBR3l6 VqMT6YwCujyjm+uENZgnG+RvlwPKm89YExdcymmFz/Et3mSWDa2aqNvN96eyr+EIIFJH AMuDDnx6y2Y4fIQ6ofCKQ489/3p7SdFoCNptUi/+m2UNWA4XkaBUGzN5+UhopJFpye2M TsSc8WN7X/6tE+RbQpN+zGRcN0CAArgbNwVYElBA4lf25r+yo7RyDuARj63ECIdbpSjI 79SvYujuX3MbjSR+8xwgGe2/opDRNscQDur1W1mH6vzJKqsPsAhCEGX21hRcC2IVY+AP l1TQ== X-Gm-Message-State: AFuF++kFAPrmn6BDoloNQz/3NSPfw12HbL9j4nZnW+VfY32ad8Bi+XBX XF8N0uomZCzcieEA54vJ9W5tPin9E+J1PYPMp/StEghndpOb5hVR/gBm X-Gm-Gg: AYBFou3tJZ6pxoXJl1/YMXFPKcO8VAbBFqsf/CQIZscAommTkA3HdwjXCvBACsD0dIv bEGN0URRVcncTby+sB262af1caoNAk34/0WJp1LfCnkpKWIiY57aK8hHpn4NNSBzkcCf3ru4vn9 /k16aumdabWOmSqhFbPGWnN0RccIq9wDtIefAyPf4v9iG3nrlb+boOVbaTJHPdx9N3laDf965cU wqRiDHI7yLFpJ/q0m9Q5F0ecNC+H88UBug5tu2m+qZtXfF1Q+G3sjB6OViTFrb4UEDvUpNv22uB FgvyxndCDAS47Ol51iDVweiFYPNFx9/0MawadOv4ROYyEMZBXb/CWaFyDrKq8tesSh29O3pXnty HoMieAnslyV+TjKsDUijkny8ISwmhT+i4YHeDF+YIkrOzdy7rLd8FlY/QTtxeRFftXgpJ976yf1 oFw+h6Bmx/3mLHE+/5lKVaDK693W8N6QS2vnDHsf5hEc+njAUuUf5wEUkIsyq0rR4pmlyFOFWiy yby/cuCLoy2iTWF X-Received: by 2002:a17:90b:5908:b0:38e:5b59:c2ff with SMTP id 98e67ed59e1d1-39aedec4caamr10276108a91.3.1788371264027; Wed, 02 Sep 2026 10:47:44 -0700 (PDT) Received: from mizar.onca-liberty.ts.net ([182.10.129.37]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b083f04d1sm470584a91.8.2026.09.02.10.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 10:47:43 -0700 (PDT) From: Idotoho Reimon Simanjuntak To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Denis Benato , "Luke D . Jones" , Corentin Chary , Idotoho Reimon Simanjuntak Subject: [PATCH v3 3/3] platform/x86: asus-wmi: re-assert FA401 keyboard state before S0ix Date: Thu, 3 Sep 2026 00:47:18 +0700 Message-ID: <20260902174718.16228-4-idotohors@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260902174718.16228-1-idotohors@gmail.com> References: <20260902174718.16228-1-idotohors@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On ASUS TUF Gaming FA401 laptops, the display server or graphics driver blanks the keyboard backlight (brightness=3D0) during suspend. When the EC enters S0ix with brightness=3D0, it disables the sleep-strobe effect. Track the last user-configured non-zero keyboard backlight level in asus->kbd_led_last_level, and re-assert it with the light-on bit (0x80) along with the configured TUF RGB power state in both .prepare and the LPS0 s2idle .prepare hook. Hooking LPS0 ensures the re-assertion happens after all devices (including DRM and display managers) have suspended, immediately prior to low-power S0 idle entry. Only re-assert if the TUF sleep flag is active in kbd_rgb_state_flags, respecting any user decision to disable sleep LEDs. Initialize default flags at probe so the strobe functions out of the box. Signed-off-by: Idotoho Reimon Simanjuntak --- drivers/platform/x86/asus-wmi.c | 68 ++++++++++++++++++++++++++++++--- 1 file changed, 63 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index e7b2402c9..03d2af604 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -257,6 +257,7 @@ struct asus_wmi { int tpd_led_wk; struct led_classdev kbd_led; int kbd_led_wk; + int kbd_led_last_level; bool kbd_led_notify; bool kbd_led_avail; bool kbd_led_registered; @@ -310,6 +311,7 @@ struct asus_wmi { =20 u32 kbd_rgb_dev; bool kbd_rgb_state_available; + u32 kbd_rgb_state_flags; bool oobe_state_available; =20 u8 throttle_thermal_policy_mode; @@ -344,6 +346,7 @@ struct asus_wmi { =20 /* Global to allow setting externally without requiring driver data */ static enum asus_ally_mcu_hack use_ally_mcu_hack =3D ASUS_WMI_ALLY_MCU_HAC= K_INIT; +static struct asus_wmi *asus_hotk; =20 #if IS_ENABLED(CONFIG_ASUS_WMI_DEPRECATED_ATTRS) static void asus_wmi_show_deprecated(void) @@ -1146,6 +1149,8 @@ static ssize_t kbd_rgb_state_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { + struct led_classdev *led =3D dev_get_drvdata(dev); + struct asus_wmi *asus =3D container_of(led, struct asus_wmi, kbd_led); u32 cmd, boot, awake, sleep, keyboard; u32 arg0; int err; @@ -1172,6 +1177,8 @@ static ssize_t kbd_rgb_state_store(struct device *dev, if (err) return err; =20 + asus->kbd_rgb_state_flags =3D arg0; + return count; } static DEVICE_ATTR_WO(kbd_rgb_state); @@ -1944,8 +1951,11 @@ static void do_kbd_led_set(struct led_classdev *led_= cdev, int value) =20 asus =3D container_of(led_cdev, struct asus_wmi, kbd_led); =20 - scoped_guard(spinlock_irqsave, &asus_ref.lock) + scoped_guard(spinlock_irqsave, &asus_ref.lock) { asus->kbd_led_wk =3D clamp_val(value, 0, ASUS_EV_MAX_BRIGHTNESS); + if (asus->kbd_led_wk > 0) + asus->kbd_led_last_level =3D asus->kbd_led_wk; + } =20 if (asus->kbd_led_avail) kbd_led_update(asus); @@ -2155,6 +2165,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus) =20 if (asus->kbd_led_avail) { asus->kbd_led_wk =3D led_val; + asus->kbd_led_last_level =3D led_val > 0 ? led_val : ASUS_EV_MAX_BRIGHTN= ESS; if (num_rgb_groups !=3D 0) asus->kbd_led.groups =3D kbd_rgb_mode_groups; } else { @@ -5146,6 +5157,7 @@ static int asus_wmi_add(struct platform_device *pdev) asus->platform_device =3D pdev; wdrv->platform_device =3D pdev; platform_set_drvdata(asus->platform_device, asus); + asus_hotk =3D asus; =20 if (wdrv->detect_quirks) wdrv->detect_quirks(asus->driver); @@ -5184,6 +5196,14 @@ static int asus_wmi_add(struct platform_device *pdev) asus->kbd_rgb_state_available =3D asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_STATE) || asus->driver->quirks->kbd_rgb_state_available; + if (asus->kbd_rgb_state_available) { + asus->kbd_rgb_state_flags =3D + ASUS_WMI_TUF_RGB_STATE_CMD_ID | + FIELD_PREP(TUF_RGB_STATE_BOOT, 1) | + FIELD_PREP(TUF_RGB_STATE_AWAKE, 1) | + FIELD_PREP(TUF_RGB_STATE_SLEEP, 1) | + FIELD_PREP(TUF_RGB_STATE_KEYBOARD, 1); + } =20 if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MINI_LED_MODE)) asus->mini_led_dev_id =3D ASUS_WMI_DEVID_MINI_LED_MODE; @@ -5324,6 +5344,7 @@ static void asus_wmi_remove(struct platform_device *d= evice) struct asus_wmi *asus; =20 asus =3D platform_get_drvdata(device); + asus_hotk =3D NULL; if (asus->driver->i8042_filter) i8042_remove_filter(asus->driver->i8042_filter); wmi_remove_notify_handler(asus->driver->event_guid); @@ -5424,17 +5445,54 @@ static int asus_hotk_restore(struct device *device) return 0; } =20 +static void asus_tuf_reassert_sleep_rgb_state(struct asus_wmi *asus) +{ + if (asus && asus->driver->quirks->kbd_rgb_state_available && + asus->kbd_rgb_state_available && + (asus->kbd_rgb_state_flags & TUF_RGB_STATE_SLEEP)) { + int level; + u32 arg0; + + /* + * Re-assert keyboard backlight using the last user-configured + * brightness level (falling back to max brightness) with the + * light-on bit (0x80) set. + */ + level =3D asus->kbd_led_last_level ? + asus->kbd_led_last_level : ASUS_EV_MAX_BRIGHTNESS; + asus_wmi_set_devstate(ASUS_WMI_DEVID_KBD_BACKLIGHT, + 0x80 | (level & 0x7f), NULL); + + /* Re-assert the last user-configured TUF RGB power state */ + arg0 =3D asus->kbd_rgb_state_flags | + FIELD_PREP(TUF_RGB_STATE_SAVE, 1); + asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, + ASUS_WMI_DEVID_TUF_RGB_STATE, + arg0, 0, NULL); + } +} + static int asus_hotk_prepare(struct device *device) { + struct asus_wmi *asus =3D dev_get_drvdata(device); + if (use_ally_mcu_hack =3D=3D ASUS_WMI_ALLY_MCU_HACK_ENABLED) { acpi_execute_simple_method(NULL, ASUS_USB0_PWR_EC0_CSEE, ASUS_USB0_PWR_EC0_CSEE_OFF); msleep(ASUS_USB0_PWR_EC0_CSEE_WAIT); } + + asus_tuf_reassert_sleep_rgb_state(asus); + return 0; } =20 #if defined(CONFIG_SUSPEND) +static void asus_s2idle_prepare(void) +{ + asus_tuf_reassert_sleep_rgb_state(asus_hotk); +} + static void asus_ally_s2idle_restore(void) { if (use_ally_mcu_hack =3D=3D ASUS_WMI_ALLY_MCU_HACK_ENABLED) { @@ -5444,20 +5502,20 @@ static void asus_ally_s2idle_restore(void) } } =20 -/* Use only for Ally devices due to the wake_on_ac */ -static struct acpi_s2idle_dev_ops asus_ally_s2idle_dev_ops =3D { +static struct acpi_s2idle_dev_ops asus_s2idle_dev_ops =3D { + .prepare =3D asus_s2idle_prepare, .restore =3D asus_ally_s2idle_restore, }; =20 static void asus_s2idle_check_register(void) { - if (acpi_register_lps0_dev(&asus_ally_s2idle_dev_ops)) + if (acpi_register_lps0_dev(&asus_s2idle_dev_ops)) pr_warn("failed to register LPS0 sleep handler in asus-wmi\n"); } =20 static void asus_s2idle_check_unregister(void) { - acpi_unregister_lps0_dev(&asus_ally_s2idle_dev_ops); + acpi_unregister_lps0_dev(&asus_s2idle_dev_ops); } #else static void asus_s2idle_check_register(void) {} --=20 2.55.0