From nobody Sat Sep 26 10:01:21 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 604684A499C for ; Wed, 2 Sep 2026 15:08:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788361708; cv=none; b=mUjlTEj+cU+7h8h54w+ecwCSGeZbhMkXUqVFfAe26QRY3HYqbXfYfEl9rNHLX6JCj0BB8dR8Nh59JAiZRgFvSW/9wpiDW1wE+sFsh4W3qUV4N+v1VH86bU1ifbcDyhrbaDts8mJjhqEMhkWa8+yjG7geF2ZMIOB0EnOnTVw6c/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788361708; c=relaxed/simple; bh=/HKgCiJN5fApcjoYOWUqya6eaxeq86J2EHBdERMhcXE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BZrbtvIyb6lN8NJjSGX6G+8e86S/b/HHqsid+MbIviLVLGeTP7fLRKczjX7jmo2kXaJJnI5rVLRFMp9U5clmsHv2lLKLAFHuGY2lkAOGlwbg6fRqyTH7U/EfiLDH+IKkepiu+PmWmGke8Y0GiYq39OJyiBJb6TdYofNnUHZyJC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qNndLlrm; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qNndLlrm" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4998b5a63e2so11711195e9.1 for ; Wed, 02 Sep 2026 08:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788361702; x=1788966502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dIdHMopzum3T1T5pILtPCf6cLbfxy4UO4dLC+zmw/HI=; b=qNndLlrmec+vA6tER8RzdOtOKTbmOoe8GuvyzDu5xPPYMJZFAdwqlugr2QCwpbuC19 fXhjd1jEOfH0Qip4C6TScjHC4nxcIluVRPlXacanVsH1KPXPwvd/MGr80sAPNePNz6xP M8LMltnLZNKLn+ERHXT6yf/T1v9iLmZuWQdv3vhF1jEUg/IoNm9Fzdr2qzQx7mHrQwnc jmOfgYcyLmN21MciPYyXawI5oiiePi+/1dLiTTzNLrg0Xp9NaGJc6QQD/Zl1Lg+zWZQu m2VzU1VR/Ns3MR2i/F6/Rv07txckt2mri0LwZNDmWMaHIHvpe4JzH/aOC2p6Nrnda/r6 QpMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788361702; x=1788966502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dIdHMopzum3T1T5pILtPCf6cLbfxy4UO4dLC+zmw/HI=; b=L8067AToi7tCjZ3yF8KlIpuvXV9LkUaLeA30ZXGWahYQm4gsF4IF6bShv96gbcgfRo xvor/lZlpxXUPB+gqOQ+Jih4YB9EiKuwwoFBWtprhWDco7DcI5b5KrMcjcGWWVxtruk0 komm0WaQalpwBKnH36dbUN6ZxYlErJQ4xwVdr2bOBLeSvGQGJFafII7X0Ben9oGkm51e pktyqsMn1zN3eXm5/gytxSTkJ3+16vwE1l2pp3ZO3pRTtG3byP+tb4IwI0nJFDpVUeaO oTdIPMQE/lYYYOO4uYuICMepAhGs3C36re61/p5BdKLYhTbkt77dePgabD3EJcqnfdMb aJag== X-Gm-Message-State: AFuF++lH/Fzz48dkDS1ZgnKKrbNl+cM2orKGHXn24KF+RK11ycd7OcNA PPbUxxw+Tx+Q/0K8FJGrlN/8YAtKqqiaJyyeCd70g+4Owd1UaID4hCbGFH8VIw== X-Gm-Gg: AR+sD10MI/tlp9ElUtiJcUX3gO5Xwc44u2Co+R/ca+WKSfiEQCg8+ZvhtZTgdKSYbit zJVK7/sVH2xDWGK7F57eJILd//9o5sfiAgCwepUNM1PUC8LDY+JR/Sn8kzN+Qym+UkIJuea47sJ y89gq2dboh3DeKGSsrjrRSrzA/J5m5bO/+Bb3XmO0wI7rXMXPkTEZltQpMxMSlc2V+JeSRlHNlS A3YgYiH9XTqreMFWkiSklW9AS4XCTq82OfIyQEZ4FrujbysuXwbNIn8UwyJ054HkDauYOykArXM S89PHAajjIX4Z7nv0SOezVvawKW9gHoqncnA0WFhD4mYU2LZq7VHEhfYmzy2vbio0Kb2v8dSdsC OF3CRKlSD/ByxZ7xDNxB4EvbTqOJUFtdDtBcVgsL1DgS81hshrYHSH1fbFMn6bBGp23Ovw/zi2k Bfx7DMhr50USxMX2FEtcQM/4XjpU1OZb7v+vHgHuq5JXxhqN2lqk+VdU9XC+HOc4gO+ymMqvpCn xaxnobfzkgsxPaUAohSt6TTJpmYl4WMt6OPBuiOZDme2D3i7J6NpeUWgiSwaeaTOXaJ6u8eXy2O jlFitBikx/nJPJyuA7Q= X-Received: by 2002:a05:600d:19:b0:49c:edd8:ba35 with SMTP id 5b1f17b1804b1-49cedd8ba5emr22944955e9.6.1788361702006; Wed, 02 Sep 2026 08:08:22 -0700 (PDT) Received: from koolguy.fritz.box (dynamic-2a02-3100-1a72-6e00-ef52-6b66-008c-4439.310.pool.telefonica.de. [2a02:3100:1a72:6e00:ef52:6b66:8c:4439]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cdce3e0desm167404405e9.11.2026.09.02.08.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 08:08:21 -0700 (PDT) From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Dalvin-Ehinoma Noah Aiguobas Subject: [PATCH v4 1/2] staging: rtl8723bs: change struct member bSurpriseRemoved Date: Wed, 2 Sep 2026 15:05:41 +0000 Message-ID: <20260902150542.2746-2-fliegbert2@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260902150542.2746-1-fliegbert2@gmail.com> References: <20260715171634.1550-1-fliegbert2@gmail.com> <20260902150542.2746-1-fliegbert2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Member name does not adhere to linux coding style. Changed type as well since b indicates a boolean type and in every instance of setting the variable the values true and false are used. bSurpriseRemoved -> surprise_removed Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 +- drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 ++--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 8 ++--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 20 ++++++------ drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 12 +++---- drivers/staging/rtl8723bs/core/rtw_recv.c | 10 +++--- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 12 +++---- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 8 ++--- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 4 +-- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 ++--- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- drivers/staging/rtl8723bs/include/drv_types.h | 8 ++--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 10 +++--- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +-- .../staging/rtl8723bs/os_dep/sdio_ops_linux.c | 32 +++++++++---------- 15 files changed, 74 insertions(+), 74 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/= rtl8723bs/core/rtw_btcoex.c index 9e00424d00bd..24b6742509d8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c @@ -23,7 +23,7 @@ void rtw_btcoex_halt_notify(struct adapter *padapter) if (!padapter->bup) return; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return; =20 hal_btcoex_HaltNotify(padapter); diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index 59f13f6b85ad..9672367c1f5a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -396,11 +396,11 @@ int rtw_cmd_thread(void *context) break; } =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) { + if (padapter->driver_stopped || padapter->surprise_removed) { netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", __func__, padapter->driver_stopped, - padapter->bSurpriseRemoved, __LINE__); + padapter->surprise_removed, __LINE__); break; } =20 @@ -419,11 +419,11 @@ int rtw_cmd_thread(void *context) continue; =20 _next: - if (padapter->driver_stopped || padapter->bSurpriseRemoved) { + if (padapter->driver_stopped || padapter->surprise_removed) { netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", __func__, padapter->driver_stopped, - padapter->bSurpriseRemoved, __LINE__); + padapter->surprise_removed, __LINE__); break; } =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 179061239a6f..a6e7b57697a1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -264,7 +264,7 @@ void rtw_free_network_queue(struct adapter *adapter, u8= isfreeall) =20 bool rtw_if_up(struct adapter *adapter) { - if (adapter->driver_stopped || adapter->bSurpriseRemoved || + if (adapter->driver_stopped || adapter->surprise_removed || !check_fwstate(&adapter->mlmepriv, _FW_LINKED)) return false; =20 @@ -934,7 +934,7 @@ void rtw_scan_abort(struct adapter *adapter) pmlmeext->scan_abort =3D true; while (check_fwstate(mlme_priv, _FW_UNDER_SURVEY) && jiffies_to_msecs(start) <=3D 200) { - if (adapter->driver_stopped || adapter->bSurpriseRemoved) + if (adapter->driver_stopped || adapter->surprise_removed) break; =20 msleep(20); @@ -1506,7 +1506,7 @@ void _rtw_join_timeout_handler(struct timer_list *t) mlmepriv.assoc_timer); struct mlme_priv *mlme_priv =3D &adapter->mlmepriv; =20 - if (adapter->driver_stopped || adapter->bSurpriseRemoved) + if (adapter->driver_stopped || adapter->surprise_removed) return; =20 spin_lock_bh(&mlme_priv->lock); @@ -1608,7 +1608,7 @@ void rtw_dynamic_check_timer_handler(struct adapter *= adapter) if (!adapter->hw_init_completed) return; =20 - if (adapter->driver_stopped || adapter->bSurpriseRemoved) + if (adapter->driver_stopped || adapter->surprise_removed) return; =20 if (adapter->net_closed) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 0c00be09fbf3..fa8a83f5d3cb 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1961,7 +1961,7 @@ void update_mgntframe_attrib_addr(struct adapter *pad= apter, struct xmit_frame *p =20 void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntfram= e) { - if (padapter->bSurpriseRemoved || + if (padapter->surprise_removed || padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); @@ -1978,7 +1978,7 @@ void dump_mgntframe_and_wait(struct adapter *padapter= , struct xmit_frame *pmgntf struct xmit_buf *pxmitbuf =3D pmgntframe->pxmitbuf; struct submit_ctx sctx; =20 - if (padapter->bSurpriseRemoved || + if (padapter->surprise_removed || padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); @@ -2003,7 +2003,7 @@ s32 dump_mgntframe_and_wait_ack(struct adapter *padap= ter, struct xmit_frame *pmg u32 timeout_ms =3D 500;/* 500ms */ struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 - if (padapter->bSurpriseRemoved || + if (padapter->surprise_removed || padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); @@ -2511,7 +2511,7 @@ int issue_probereq_ex(struct adapter *padapter, struc= t ndis_802_11_ssid *pssid, =20 i++; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3059,7 +3059,7 @@ int issue_nulldata(struct adapter *padapter, unsigned= char *da, unsigned int pow =20 i++; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3191,7 +3191,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsi= gned char *da, u16 tid, int =20 i++; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3284,7 +3284,7 @@ int issue_deauth_ex(struct adapter *padapter, u8 *da,= unsigned short reason, int =20 i++; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3712,13 +3712,13 @@ unsigned int send_beacon(struct adapter *padapter) rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bxmitok)); poll++; } while ((poll % 10) !=3D 0 && !bxmitok && - !padapter->bSurpriseRemoved && + !padapter->surprise_removed && !padapter->driver_stopped); =20 - } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && + } while (false =3D=3D bxmitok && issue < 100 && !padapter->surprise_remov= ed && !padapter->driver_stopped); =20 - if (padapter->bSurpriseRemoved || padapter->driver_stopped) + if (padapter->surprise_removed || padapter->driver_stopped) return _FAIL; =20 if (!bxmitok) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging= /rtl8723bs/core/rtw_pwrctrl.c index 448611ad8237..fa47c6dd7988 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -237,7 +237,7 @@ void rtw_set_rpwm(struct adapter *padapter, u8 pslv) return; } =20 - if ((padapter->bSurpriseRemoved) || !(padapter->hw_init_completed)) { + if ((padapter->surprise_removed) || !(padapter->hw_init_completed)) { pwrpriv->cpwm =3D PS_STATE_S4; return; } @@ -404,7 +404,7 @@ int LPS_RF_ON_check(struct adapter *padapter, u32 delay= _ms) if (bAwake) return 0; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return -ENODEV; =20 if (jiffies_to_msecs(jiffies - start_time) > delay_ms) @@ -480,7 +480,7 @@ void LeaveAllPowerSaveModeDirect(struct adapter *Adapte= r) struct mlme_priv *pmlmepriv =3D &Adapter->mlmepriv; struct pwrctrl_priv *pwrpriv =3D adapter_to_pwrctl(Adapter); =20 - if (Adapter->bSurpriseRemoved) + if (Adapter->surprise_removed) return; =20 if (check_fwstate(pmlmepriv, _FW_LINKED)) { /* connect */ @@ -514,7 +514,7 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter) if (!Adapter->bup) return; =20 - if (Adapter->bSurpriseRemoved) + if (Adapter->surprise_removed) return; =20 if (check_fwstate(&dvobj->padapters->mlmepriv, WIFI_ASOC_STATE)) @@ -548,7 +548,7 @@ void LPS_Leave_check(struct adapter *padapter) while (1) { mutex_lock(&pwrpriv->lock); =20 - if (padapter->bSurpriseRemoved || + if (padapter->surprise_removed || !(padapter->hw_init_completed) || (pwrpriv->pwr_mode =3D=3D PS_MODE_ACTIVE)) bReady =3D true; @@ -1089,7 +1089,7 @@ int rtw_pm_set_ips(struct adapter *padapter, u8 mode) return 0; } else if (mode =3D=3D IPS_NONE) { rtw_ips_mode_req(pwrctrlpriv, mode); - if ((padapter->bSurpriseRemoved =3D=3D 0) && (rtw_pwr_wakeup(padapter) = =3D=3D _FAIL)) + if ((padapter->surprise_removed =3D=3D 0) && (rtw_pwr_wakeup(padapter) = =3D=3D _FAIL)) return -EFAULT; } else { return -EINVAL; diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index 3c82012fdc6c..8086a0602c0d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -1894,7 +1894,7 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor /* indicate this recv_frame */ if (!pattrib->amsdu) { if (!padapter->driver_stopped && - !padapter->bSurpriseRemoved) + !padapter->surprise_removed) rtw_recv_indicatepkt(padapter, prframe);/* indicate this recv_frame */ =20 } else if (pattrib->amsdu =3D=3D 1) { @@ -1933,7 +1933,7 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * =20 if (pattrib->qos !=3D 1) { if (!padapter->driver_stopped && - !padapter->bSurpriseRemoved) { + !padapter->surprise_removed) { rtw_recv_indicatepkt(padapter, prframe); return _SUCCESS; } @@ -2010,7 +2010,7 @@ void rtw_reordering_ctrl_timeout_handler(struct timer= _list *t) struct adapter *padapter =3D preorder_ctrl->padapter; struct __queue *ppending_recvframe_queue =3D &preorder_ctrl->pending_recv= frame_queue; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) return; =20 spin_lock_bh(&ppending_recvframe_queue->lock); @@ -2035,7 +2035,7 @@ static int process_recv_indicatepkts(struct adapter *= padapter, union recv_frame if (recv_indicatepkt_reorder(padapter, prframe) !=3D _SUCCESS) { /* inc= luding perform A-MPDU Rx Ordering Buffer Control */ =20 if (!padapter->driver_stopped && - !padapter->bSurpriseRemoved) { + !padapter->surprise_removed) { retval =3D _FAIL; return retval; } @@ -2045,7 +2045,7 @@ static int process_recv_indicatepkts(struct adapter *= padapter, union recv_frame if (retval !=3D _SUCCESS) return retval; =20 - if (!padapter->driver_stopped && !padapter->bSurpriseRemoved) { + if (!padapter->driver_stopped && !padapter->surprise_removed) { /* indicate this recv_frame */ rtw_recv_indicatepkt(padapter, prframe); } else { diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index d2b44ad60a4c..858471b8d65a 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -59,7 +59,7 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementI= D, u32 CmdLen, u8 *pCmd if (CmdLen > RTL8723B_MAX_CMD_LEN) goto exit; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) goto exit; =20 /* pay attention to if race condition happened in H2C cmd setting. */ @@ -639,13 +639,13 @@ void rtl8723b_download_rsvd_page(struct adapter *pada= pter, u8 mstatus) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bcn_valid)); poll++; - } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemove= d && + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->surprise_remove= d && !padapter->driver_stopped); =20 - } while (!bcn_valid && DLBcnCount <=3D 100 && !padapter->bSurpriseRemove= d && + } while (!bcn_valid && DLBcnCount <=3D 100 && !padapter->surprise_remove= d && !padapter->driver_stopped); =20 - if (padapter->bSurpriseRemoved || padapter->driver_stopped) { + if (padapter->surprise_removed || padapter->driver_stopped) { } else { struct pwrctrl_priv *pwrctl =3D adapter_to_pwrctl(padapter); =20 @@ -899,9 +899,9 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct = adapter *padapter) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, &bcn_valid); poll++; - } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemoved= && + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->surprise_removed= && !padapter->driver_stopped); - } while (!bcn_valid && (DLBcnCount <=3D 100) && !padapter->bSurpriseRemov= ed && + } while (!bcn_valid && (DLBcnCount <=3D 100) && !padapter->surprise_remov= ed && !padapter->driver_stopped); =20 if (bcn_valid) { diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 6a4a13544ca1..e7721a77039b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -189,7 +189,7 @@ static s32 polling_fwdl_chksum( do { cnt++; value32 =3D rtw_read32(adapter, REG_MCUFWDL); - if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || + if (value32 & FWDL_ChkSum_rpt || adapter->surprise_removed || adapter->driver_stopped) break; yield(); @@ -230,7 +230,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) do { cnt++; value32 =3D rtw_read32(adapter, REG_MCUFWDL); - if (value32 & WINTINI_RDY || adapter->bSurpriseRemoved || adapter->drive= r_stopped) + if (value32 & WINTINI_RDY || adapter->surprise_removed || adapter->drive= r_stopped) break; yield(); } while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt); @@ -386,7 +386,7 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter,= bool bUsedWoWLANFw) fwdl_start_time =3D jiffies; while ( !padapter->driver_stopped && - !padapter->bSurpriseRemoved && + !padapter->surprise_removed && (write_fw++ < 3 || jiffies_to_msecs(jiffies - fwdl_start_time) < 500) ) { /* reset FWDL chksum */ @@ -2697,7 +2697,7 @@ void GetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) u32 valRCR; =20 if ( - padapter->bSurpriseRemoved || + padapter->surprise_removed || (adapter_to_pwrctl(padapter)->rf_pwrstate =3D=3D rf_off) ) { /* If it is in HW/SW Radio OFF or IPS state, we do not check Fw LPS L= eave, */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index 737e2a818c18..2120d8c3e8ab 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -658,7 +658,7 @@ static void phy_SwChnlAndSetBwMode8723B(struct adapter = *Adapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); =20 - if (Adapter->driver_stopped || Adapter->bSurpriseRemoved) + if (Adapter->driver_stopped || Adapter->surprise_removed) return; =20 if (pHalData->bSwChnl) { @@ -724,7 +724,7 @@ static void PHY_HandleSwChnlAndSetBW8723B( } =20 /* Switch workitem or set timer to do switch channel or setbandwidth oper= ation */ - if ((!Adapter->driver_stopped) && (!Adapter->bSurpriseRemoved)) { + if ((!Adapter->driver_stopped) && (!Adapter->surprise_removed)) { phy_SwChnlAndSetBwMode8723B(Adapter); } else { if (pHalData->bSwChnl) { diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index 7f55448d544e..f611442eaca5 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -15,7 +15,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter= *padapter, u8 agg_num) =20 while (pHalData->SdioTxOQTFreeSpace < agg_num) { if ( - (padapter->bSurpriseRemoved) || + (padapter->surprise_removed) || (padapter->driver_stopped) ) return false; @@ -88,7 +88,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *pada= pter) } =20 if ( - (padapter->bSurpriseRemoved) || + (padapter->surprise_removed) || (padapter->driver_stopped) ) goto free_xmitbuf; @@ -130,7 +130,7 @@ s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter) return _FAIL; } =20 - ret =3D (padapter->driver_stopped) || (padapter->bSurpriseRemoved); + ret =3D (padapter->driver_stopped) || (padapter->surprise_removed); if (ret) return _FAIL; =20 @@ -363,7 +363,7 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padap= ter) next: if ( (padapter->driver_stopped) || - (padapter->bSurpriseRemoved) + (padapter->surprise_removed) ) return _FAIL; =20 diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl= 8723bs/hal/sdio_ops.c index da2d9088ab5a..ca50f8a5c32e 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -803,7 +803,7 @@ void sd_int_hdl(struct adapter *adapter) struct hal_com_data *hal; =20 if ( - (adapter->driver_stopped) || (adapter->bSurpriseRemoved) + (adapter->driver_stopped) || (adapter->surprise_removed) ) return; =20 diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index 20265770ed77..502da503c99b 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -295,7 +295,7 @@ struct adapter { u32 hal_data_sz; =20 bool driver_stopped; - s32 bSurpriseRemoved; + bool surprise_removed; s32 bCardDisableWOHSM; =20 u32 IsrContent; @@ -397,17 +397,17 @@ static inline void RTW_ENABLE_FUNC(struct adapter *pa= dapter, int func_bit) #define RTW_IS_FUNC_DISABLED(padapter, func_bit) (atomic_read(&adapter_to_= dvobj(padapter)->disable_func) & (func_bit)) =20 #define RTW_CANNOT_IO(padapter) \ - ((padapter)->bSurpriseRemoved || \ + ((padapter)->surprise_removed || \ RTW_IS_FUNC_DISABLED((padapter), DF_IO_BIT)) =20 #define RTW_CANNOT_RX(padapter) \ ((padapter)->driver_stopped || \ - (padapter)->bSurpriseRemoved || \ + (padapter)->surprise_removed || \ RTW_IS_FUNC_DISABLED((padapter), DF_RX_BIT)) =20 #define RTW_CANNOT_TX(padapter) \ ((padapter)->driver_stopped || \ - (padapter)->bSurpriseRemoved || \ + (padapter)->surprise_removed || \ RTW_IS_FUNC_DISABLED((padapter), DF_TX_BIT)) =20 static inline u8 *myid(struct eeprom_priv *peepriv) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index c15056ee207c..52db657e1aa1 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -799,7 +799,7 @@ static int _netdev_open(struct net_device *pnetdev) =20 if (!padapter->bup) { padapter->driver_stopped =3D false; - padapter->bSurpriseRemoved =3D false; + padapter->surprise_removed =3D false; padapter->bCardDisableWOHSM =3D false; =20 status =3D rtw_hal_init(padapter); @@ -902,7 +902,7 @@ void rtw_ips_pwr_down(struct adapter *padapter) =20 void rtw_ips_dev_unload(struct adapter *padapter) { - if (!padapter->bSurpriseRemoved) + if (!padapter->surprise_removed) rtw_hal_deinit(padapter); } =20 @@ -1000,13 +1000,13 @@ void rtw_dev_unload(struct adapter *padapter) "%s: driver not in IPS\n", __func__); } =20 - if (!padapter->bSurpriseRemoved) { + if (!padapter->surprise_removed) { hal_btcoex_IpsNotify(padapter, pwrctl->ips_mode_req); =20 /* amy modify 20120221 for power seq is different between driver open a= nd ips */ rtw_hal_deinit(padapter); =20 - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; } =20 padapter->bup =3D false; @@ -1088,7 +1088,7 @@ void rtw_suspend_common(struct adapter *padapter) while (pwrpriv->bips_processing) msleep(1); =20 - if ((!padapter->bup) || (padapter->driver_stopped) || (padapter->bSurpris= eRemoved)) + if ((!padapter->bup) || (padapter->driver_stopped) || (padapter->surprise= _removed)) return; =20 rtw_ps_deny(padapter, PS_DENY_SUSPEND); diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 6ef3a7198533..8d917e69ca0c 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -385,7 +385,7 @@ static void rtw_dev_remove(struct sdio_func *func) =20 rtw_unregister_netdevs(dvobj); =20 - if (!padapter->bSurpriseRemoved) { + if (!padapter->surprise_removed) { int err; =20 /* test surprise remove */ @@ -393,7 +393,7 @@ static void rtw_dev_remove(struct sdio_func *func) sdio_readb(func, 0, &err); sdio_release_host(func); if (err =3D=3D -ENOMEDIUM) - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; } =20 rtw_ps_deny(padapter, PS_DENY_DRV_REMOVE); diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c b/drivers/st= aging/rtl8723bs/os_dep/sdio_ops_linux.c index e9a2f3f7ec74..71d3e4babd31 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c @@ -42,7 +42,7 @@ s32 _sd_cmd52_read(struct intf_hdl *pintfhdl, u32 addr, u= 32 cnt, u8 *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -74,7 +74,7 @@ s32 sd_cmd52_read(struct intf_hdl *pintfhdl, u32 addr, u3= 2 cnt, u8 *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -106,7 +106,7 @@ s32 _sd_cmd52_write(struct intf_hdl *pintfhdl, u32 addr= , u32 cnt, u8 *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -138,7 +138,7 @@ s32 sd_cmd52_write(struct intf_hdl *pintfhdl, u32 addr,= u32 cnt, u8 *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -166,7 +166,7 @@ u8 sd_read8(struct intf_hdl *pintfhdl, u32 addr, s32 *e= rr) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return v; =20 func =3D psdio->func; @@ -193,7 +193,7 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s32 = *err) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return v; =20 func =3D psdio->func; @@ -222,10 +222,10 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s3= 2 *err) } =20 if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; =20 if (rtw_inc_and_chk_continual_io_error(psdiodev)) { - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; break; } } @@ -245,7 +245,7 @@ void sd_write8(struct intf_hdl *pintfhdl, u32 addr, u8 = v, s32 *err) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return; =20 func =3D psdio->func; @@ -270,7 +270,7 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, u3= 2 v, s32 *err) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return; =20 func =3D psdio->func; @@ -298,10 +298,10 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, = u32 v, s32 *err) } =20 if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; =20 if (rtw_inc_and_chk_continual_io_error(psdiodev)) { - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; break; } } @@ -336,7 +336,7 @@ s32 _sd_read(struct intf_hdl *pintfhdl, u32 addr, u32 c= nt, void *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -386,7 +386,7 @@ s32 sd_read(struct intf_hdl *pintfhdl, u32 addr, u32 cn= t, void *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -429,7 +429,7 @@ s32 _sd_write(struct intf_hdl *pintfhdl, u32 addr, u32 = cnt, void *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -480,7 +480,7 @@ s32 sd_write(struct intf_hdl *pintfhdl, u32 addr, u32 c= nt, void *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; --=20 2.55.0 From nobody Sat Sep 26 10:01:21 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 444794A5C53 for ; Wed, 2 Sep 2026 15:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788361708; cv=none; b=FGZgBUIqDB4IWYUOIrDlcWUWaD3uEWttpZkkt+eub10j3kDN5Pv4ZHf3+Xnrxw4JCaUaTVFi0QOsZlr6Uq/NtssYFZVsx9QiH2SP/82PR6n2JnrOxCX4PNEJWbNjd9Ug1nREZQrWqO11RcitwT7goDUwk9rkiGIkogCfX0lijrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788361708; c=relaxed/simple; bh=nCXPAnuOSmmXY2rUfpFUiSRZF1+BwzVNVA0wJjmcfWM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OvY0PcIxiKq1jd0WqvVspsuI1oaxSFZio1wi8RErs2JaKVx/8Ixa698BfrWpebBjuNOfPahZgVtSTgLEd8Wq1vQPmFMkQ4CaQ+Wf5o2Hqvvn7JgCOCwClqNqoowWT8j+nel6ttk9w/yFebeu9ZtHqBoeHVIRSJRPoE+sLbOD0W0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EK6R82VG; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EK6R82VG" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-49b965570d7so9674985e9.0 for ; Wed, 02 Sep 2026 08:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788361703; x=1788966503; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jNyVKvuZfkn0OMTvx0TpHoFHrsOmOkliSXO6rNR0S8s=; b=EK6R82VGG7KG9/L5c+9j9mkS1jE6hxyOeER4s4KFHvP900boVdMaJn+FG13qJisL7f YPiuyGwSDeTPYLSJf3Fz8BMpuTq5ipYl1eB29eZTbSf8DBSdOXvtU0ZsPK/vJZS+4TDa 1Vgbt+4AyE8X7TSmrDE5/kBhDzmEVqF0sl6DDAuDs4tCcWngH99eaS04f5LeBIFBZedE eUZRZ97iJx3mhSlDpZua+BHHnwyFt1Kg1cmUhqeCz/ygPmuoDpPGKnYEds9lcpzsj3jC ZyVPw1QT6uovxofE7YtTcS4BTvqEXBN+wfk3xs1DPciuzBT+ZEFISFeCZxJHPgMAyIiD nBew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788361703; x=1788966503; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jNyVKvuZfkn0OMTvx0TpHoFHrsOmOkliSXO6rNR0S8s=; b=X7YjOCyW0llauwvJKOhjWy9+X3DJtJEVHMBpB0CmaXBVHfPpV4Ojv2aw/N/brJyCuI DtUI0jHE5cAdf1HVJKOGpqOig8ue8W3Zfpo6YF5VcH+jbtTnXn9C7Uw1ODLGWSm29LSD Ur0x2YUkt2BrrRZ6kjmBsTdF8MSr5pW2CYw3pyTJRHCrRG/9geSi0hDsSx34RnWuUnex GnCcfBc1HeWVPs/dTvLjYev7VHAugVSyBKdc2ho8OQabTWUZIK/yMswQCWFXmGLfT3+f wl+Nv009iK2W7kvq17X4Zh85p9mcLtej8eDZhVt8lmb+mzdsTNfh+23bMDG3ll7UTOEu yhlA== X-Gm-Message-State: AFuF++mV8hNPvgxGicM1bfBNa/277I9iFRc6cLdiD0v8wJytISHSOt+h AFamxogz57hvY/t79AbfIzJzOJdDWpOC/Qzxjhe3mcJfnzeMtTWq+kQ7 X-Gm-Gg: AR+sD12gH+SCJPkxG0SeE95+HEGiCW8Bm281eBHQU/+iuuTlI0rIKqZV+egzKyGehUC K4S4QiI1J+I+pkrQoVvY2CG+6xYissJge7D3VoeKQWJzyCRiy807VjmiRrxCHvPgLMauAmiKYG2 dgX0DrzyM5NJ+0BzAiatrsGssBCnc0E77vex3hlzBFCKbSi17mg280LXdTaZtOpt6eY5O6TVlcw iomKGtwSTGFE0oxG5ZBSn0sxnkdLdoL0KgSRyEP7arj0NoUnFb9d6cJwx4cEA0u0HqlJhDY5KLw XZtlbErfL6B0EU+Ju4wNXcuxxNAVdI42Y5NIddYLq7mJOjc/aLmDBo6N7jPdR3JEdZCTAyFqS3B A5wW7qWMhdevTOjzvEkmqnIMXZVf8nOc/H+uabso5z6Yc45ztTYBJ4Hj2rFAlfnJmfGnqrfhRl9 kUiJnXO3yJtNSpSwe/PA0wUcAdXFnO61nlepsNCdgCtz4BHDtFKY1fK6t5OrNEid4XwRcX6wGGL 31jpJFYa4q6ZNvbWgj4FuG1n9e26dkmjaAApc1Aa2HOe523Fc1fsdUsa2agCdZL2DJTfKXAe9Ui DomVmXYW X-Received: by 2002:a05:600c:630e:b0:49c:e27c:6b10 with SMTP id 5b1f17b1804b1-49ce55ecea8mr102752395e9.3.1788361703060; Wed, 02 Sep 2026 08:08:23 -0700 (PDT) Received: from koolguy.fritz.box (dynamic-2a02-3100-1a72-6e00-ef52-6b66-008c-4439.310.pool.telefonica.de. [2a02:3100:1a72:6e00:ef52:6b66:8c:4439]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cdce3e0desm167404405e9.11.2026.09.02.08.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 08:08:22 -0700 (PDT) From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Dalvin-Ehinoma Noah Aiguobas Subject: [PATCH v4 2/2] staging: rtl8723bs: fix Alignment should match open parenthesis in rtw_mlme_ext.c Date: Wed, 2 Sep 2026 15:05:42 +0000 Message-ID: <20260902150542.2746-3-fliegbert2@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260902150542.2746-1-fliegbert2@gmail.com> References: <20260715171634.1550-1-fliegbert2@gmail.com> <20260902150542.2746-1-fliegbert2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixing almost every occurrence of checkpatch warning Alignment should match open parenthesis in rtw_mlme_ext.c. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 60 +++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index fa8a83f5d3cb..01d25068c64f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -256,8 +256,8 @@ static void init_mlme_ext_priv_value(struct adapter *pa= dapter) } =20 static int has_channel(struct rt_channel_info *channel_set, - u8 chanset_size, - u8 chan) + u8 chanset_size, + u8 chan) { int i; =20 @@ -269,8 +269,8 @@ static int has_channel(struct rt_channel_info *channel_= set, } =20 static void init_channel_list(struct adapter *padapter, struct rt_channel_= info *channel_set, - u8 chanset_size, - struct p2p_channels *channel_list) + u8 chanset_size, + struct p2p_channels *channel_list) { static const struct p2p_oper_class_map op_class[] =3D { { IEEE80211G, 81, 1, 13, 1, BW20 }, @@ -302,7 +302,7 @@ static void init_channel_list(struct adapter *padapter,= struct rt_channel_info * continue; =20 if ((0 < (padapter->registrypriv.bw_mode & 0xf0)) && - ((o->bw =3D=3D BW40MINUS) || (o->bw =3D=3D BW40PLUS))) + ((o->bw =3D=3D BW40MINUS) || (o->bw =3D=3D BW40PLUS))) continue; =20 if (!reg) { @@ -515,7 +515,7 @@ unsigned int OnProbeReq(struct adapter *padapter, union= recv_frame *precv_frame) } =20 p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _PROBEREQ_IE_OFFSET_, WLAN_EI= D_SSID, (int *)&ielen, - len - WLAN_HDR_A3_LEN - _PROBEREQ_IE_OFFSET_); + len - WLAN_HDR_A3_LEN - _PROBEREQ_IE_OFFSET_); =20 /* check (wildcard) SSID */ if (p) { @@ -715,8 +715,8 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) seq =3D le16_to_cpu(*(__le16 *)((SIZE_PTR)pframe + WLAN_HDR_A3_LEN + offs= et + 2)); =20 if (auth_mode =3D=3D 2 && - psecuritypriv->dot11_privacy_algrthm !=3D _WEP40_ && - psecuritypriv->dot11_privacy_algrthm !=3D _WEP104_) + psecuritypriv->dot11_privacy_algrthm !=3D _WEP40_ && + psecuritypriv->dot11_privacy_algrthm !=3D _WEP104_) auth_mode =3D 0; =20 if ((algorithm > 0 && auth_mode =3D=3D 0) || /* rx a shared-key auth but= shared not enabled */ @@ -797,7 +797,7 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) pstat->authalg =3D algorithm; } else if (seq =3D=3D 3) { p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_= EID_CHALLENGE, (int *)&ie_len, - len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_ - 4); + len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_ - 4); =20 if (!p || ie_len !=3D 128) { status =3D WLAN_STATUS_CHALLENGE_FAIL; @@ -883,7 +883,7 @@ unsigned int OnAuthClient(struct adapter *padapter, uni= on recv_frame *precv_fram if (pmlmeinfo->auth_algo =3D=3D dot11_auth_algrthm_shared) { /* legendary shared system */ p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_, WLAN_EID_= CHALLENGE, (int *)&len, - pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); + pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); =20 if (!p || len !=3D WLAN_AUTH_CHALLENGE_LEN) goto authclnt_fail; @@ -992,7 +992,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union= recv_frame *precv_frame) /* now we should check all the fields... */ /* checking SSID */ p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_SSID, &ie= _len, - pkt_len - WLAN_HDR_A3_LEN - ie_offset); + pkt_len - WLAN_HDR_A3_LEN - ie_offset); =20 if (!p || ie_len =3D=3D 0) { /* broadcast ssid, however it is not allowed in assocreq */ @@ -1027,7 +1027,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) support_rate_num =3D ie_len; =20 p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_EXT_SUPP= _RATES, &ie_len, - pkt_len - WLAN_HDR_A3_LEN - ie_offset); + pkt_len - WLAN_HDR_A3_LEN - ie_offset); if (p) { if (support_rate_num + ie_len <=3D sizeof(supportRate)) { memcpy(supportRate + support_rate_num, p + 2, ie_len); @@ -1230,8 +1230,8 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) } =20 if ((pstat->flags & WLAN_STA_HT) && - ((pstat->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) || - (pstat->wpa_pairwise_cipher & WPA_CIPHER_TKIP))) { + ((pstat->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) || + (pstat->wpa_pairwise_cipher & WPA_CIPHER_TKIP))) { /* status =3D WLAN_STATUS_CIPHER_SUITE_REJECTED; */ /* goto OnAssocReqFail; */ } @@ -1962,7 +1962,7 @@ void update_mgntframe_attrib_addr(struct adapter *pad= apter, struct xmit_frame *p void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntfram= e) { if (padapter->surprise_removed || - padapter->driver_stopped) { + padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return; @@ -1979,7 +1979,7 @@ void dump_mgntframe_and_wait(struct adapter *padapter= , struct xmit_frame *pmgntf struct submit_ctx sctx; =20 if (padapter->surprise_removed || - padapter->driver_stopped) { + padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return; @@ -2004,7 +2004,7 @@ s32 dump_mgntframe_and_wait_ack(struct adapter *padap= ter, struct xmit_frame *pmg struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 if (padapter->surprise_removed || - padapter->driver_stopped) { + padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return -1; @@ -2500,7 +2500,7 @@ inline void issue_probereq(struct adapter *padapter, = struct ndis_802_11_ssid *ps } =20 int issue_probereq_ex(struct adapter *padapter, struct ndis_802_11_ssid *p= ssid, u8 *da, u8 ch, bool append_wps, - int try_cnt, int wait_ms) + int try_cnt, int wait_ms) { int ret; int i =3D 0; @@ -2901,8 +2901,8 @@ void issue_assocreq(struct adapter *padapter) switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: if ((!memcmp(pIE->data, RTW_WPA_OUI, 4)) || - (!memcmp(pIE->data, WMM_OUI, 4)) || - (!memcmp(pIE->data, WPS_OUI, 4))) { + (!memcmp(pIE->data, WMM_OUI, 4)) || + (!memcmp(pIE->data, WPS_OUI, 4))) { vs_ie_length =3D pIE->length; if ((!padapter->registrypriv.wifi_spec) && (!memcmp(pIE->data, WPS_OUI= , 4))) { /* Commented by Kurt 20110629 @@ -3274,7 +3274,7 @@ int issue_deauth(struct adapter *padapter, unsigned c= har *da, unsigned short rea } =20 int issue_deauth_ex(struct adapter *padapter, u8 *da, unsigned short reaso= n, int try_cnt, - int wait_ms) + int wait_ms) { int ret; int i =3D 0; @@ -4166,7 +4166,7 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid =20 /* Adjust channel plan by AP Country IE */ if (pregistrypriv->enable80211d && - (!pmlmeext->update_channel_plan_by_ap_done)) { + (!pmlmeext->update_channel_plan_by_ap_done)) { u8 *ie, *p; u32 len; struct rt_channel_plan chplan_ap; @@ -4216,8 +4216,8 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid if (pregistrypriv->wireless_mode & WIRELESS_11G) { do { if ((i =3D=3D MAX_CHANNEL_NUM) || - (chplan_sta[i].channel_num =3D=3D 0) || - (chplan_sta[i].channel_num > 14)) + (chplan_sta[i].channel_num =3D=3D 0) || + (chplan_sta[i].channel_num > 14)) break; =20 if ((j =3D=3D chplan_ap.Len) || (chplan_ap.Channel[j] > 14)) @@ -4244,8 +4244,8 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid =20 /* change AP not support channel to Passive scan */ while ((i < MAX_CHANNEL_NUM) && - (chplan_sta[i].channel_num !=3D 0) && - (chplan_sta[i].channel_num <=3D 14)) { + (chplan_sta[i].channel_num !=3D 0) && + (chplan_sta[i].channel_num <=3D 14)) { chplan_new[k].channel_num =3D chplan_sta[i].channel_num; chplan_new[k].scan_type =3D SCAN_PASSIVE; i++; @@ -4262,8 +4262,8 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid } else { /* keep original STA 2.4G channel plan */ while ((i < MAX_CHANNEL_NUM) && - (chplan_sta[i].channel_num !=3D 0) && - (chplan_sta[i].channel_num <=3D 14)) { + (chplan_sta[i].channel_num !=3D 0) && + (chplan_sta[i].channel_num <=3D 14)) { chplan_new[k].channel_num =3D chplan_sta[i].channel_num; chplan_new[k].scan_type =3D chplan_sta[i].scan_type; i++; @@ -5337,7 +5337,7 @@ u8 disconnect_hdl(struct adapter *padapter, unsigned = char *pbuf) } =20 static int rtw_scan_ch_decision(struct adapter *padapter, struct rtw_ieee8= 0211_channel *out, - u32 out_num, struct rtw_ieee80211_channel *in, u32 in_num) + u32 out_num, struct rtw_ieee80211_channel *in, u32 in_num) { int i, j; int set_idx; @@ -5583,7 +5583,7 @@ u8 add_ba_hdl(struct adapter *padapter, unsigned char= *pbuf) return H2C_SUCCESS; =20 if (((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && (pmlmeinfo->HT_enable)= ) || - ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { /* pmlmeinfo->ADDBA_retry_count =3D 0; */ /* pmlmeinfo->candidate_tid_bitmap |=3D (0x1 << pparm->tid); */ /* psta->htpriv.candidate_tid_bitmap |=3D BIT(pparm->tid); */ --=20 2.55.0