From nobody Sat Sep 26 11:01:12 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFABC33ADBF; Wed, 2 Sep 2026 07:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788333659; cv=none; b=tIBdbpV5rBkGIJ2Js2j9CMPHLDgtthh1fPCvpksMKr7fp05+0euU0COsKP7qyUlTEzfNu0FgQP5y01BS/eod8czeqKjpAb9d1sQIdn2zT0RlN95gy8YZ8pfvMVCH2cf5Wr0uD/HRk7xXsI9GF9x5WotG0HKufmHG12RbnM/mV34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788333659; c=relaxed/simple; bh=gVtQAnMg281lPBWARs+MY44kidZPkrH0GbnrcjoiJIA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nec3cTkmuuXoyjd6muLD297IifeC4WJmrgjMeGs0Gqt2Z3J1e88OTNFL7gRE3AXXIeXq+YcqUqXk3vjl/BZqNHB64rm/LHWA70Y4vJL2dE6aoa1aGje7NI4xHL6JvCg0idM3lAQQh6HCnkvhD3YvSQTfBSWNSrgSMH3dKccpeC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=U1ftDHla; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="U1ftDHla" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=gV mGjSWjpDGmwlbzSXp6NqblhiPKagQEa5tD4b+1e5w=; b=U1ftDHlaIa/k2FrOho ggJcpmuY9Zst2vfGX07w5LeudPoeYcNx7GfNzmm1ZjVfmwVMwvUximoQPyQ/jssC F3XiGI/fz0IV5XFPuakwwPDA9X6XK2HVO3iXXH0Egkn6OJtd8EY4+Q7Z9W914DPq 33i+07AkuT97/bR17K5YkB9Ug= Received: from localhost.localdomain (unknown []) by gzsmtp1 (Coremail) with SMTP id PCgvCgBnP6UuzpdqMkg2NQ--.54267S3; Wed, 02 Sep 2026 15:20:17 +0800 (CST) From: wangdich9700@163.com To: srini@kernel.org, broonie@kernel.org, tiwai@suse.com, wangdich9700@163.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, wangdicheng@kylinos.cn Subject: [PATCH 1/3] ASoC: qcom: fix assorted whitespace issues Date: Wed, 2 Sep 2026 15:19:41 +0800 Message-Id: <20260902071943.522194-2-wangdich9700@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260902071943.522194-1-wangdich9700@163.com> References: <20260902071943.522194-1-wangdich9700@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PCgvCgBnP6UuzpdqMkg2NQ--.54267S3 X-Coremail-Antispam: 1Uf129KBjvJXoWxWr15Jw17Kw1UtF1kuw4kZwb_yoW5ur1Up3 Wku3ykWFyfAF4xAw1DKr18Xa4Ut3yruFZxCr4kZ34UAr1DJr1vga17tF109FWFgry0gF9x XFZIq3s8JFn3WrUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zE18BUUUUUU= X-CM-SenderInfo: pzdqwv5lfkmliqq6il2tof0z/xtbC6BFAj2qXzjGrDwAA3Q Content-Type: text/plain; charset="utf-8" From: wangdicheng Fix stray double spaces and blank lines across the qcom ASoC driver. Signed-off-by: wangdicheng --- sound/soc/qcom/common.c | 1 - sound/soc/qcom/lpass-cdc-dma.c | 2 +- sound/soc/qcom/lpass-cpu.c | 2 +- sound/soc/qcom/lpass-hdmi.c | 1 - sound/soc/qcom/lpass-platform.c | 2 +- sound/soc/qcom/sdw.c | 3 +-- 6 files changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c index d9f256d51973..5e1ee8466901 100644 --- a/sound/soc/qcom/common.c +++ b/sound/soc/qcom/common.c @@ -389,7 +389,6 @@ int qcom_snd_wcd_jack_setup(struct snd_soc_pcm_runtime = *rtd, break; } =20 - return 0; } EXPORT_SYMBOL_GPL(qcom_snd_wcd_jack_setup); diff --git a/sound/soc/qcom/lpass-cdc-dma.c b/sound/soc/qcom/lpass-cdc-dma.c index 2dc8c75c4bf0..5be13dd59517 100644 --- a/sound/soc/qcom/lpass-cdc-dma.c +++ b/sound/soc/qcom/lpass-cdc-dma.c @@ -111,7 +111,7 @@ static int __lpass_get_codec_dma_intf_type(int dai_id) ret =3D LPASS_CDC_DMA_INTERFACE9; break; case LPASS_CDC_DMA_RX9: - ret =3D LPASS_CDC_DMA_INTERFACE10; + ret =3D LPASS_CDC_DMA_INTERFACE10; break; default: ret =3D -EINVAL; diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 242bc16da36d..4f8017357aa4 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -468,7 +468,7 @@ static int asoc_qcom_of_xlate_dai_name(struct snd_soc_c= omponent *component, int ret =3D -EINVAL; int i; =20 - for (i =3D 0; i < variant->num_dai; i++) { + for (i =3D 0; i < variant->num_dai; i++) { if (variant->dai_driver[i].id =3D=3D id) { *dai_name =3D variant->dai_driver[i].name; ret =3D 0; diff --git a/sound/soc/qcom/lpass-hdmi.c b/sound/soc/qcom/lpass-hdmi.c index 6d9795306cfa..8bbe43facdc1 100644 --- a/sound/soc/qcom/lpass-hdmi.c +++ b/sound/soc/qcom/lpass-hdmi.c @@ -5,7 +5,6 @@ * lpass-hdmi.c -- ALSA SoC HDMI-CPU DAI driver for QTi LPASS HDMI */ =20 - #include #include #include diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platfor= m.c index e162627d6f86..b335b2c8bb16 100644 --- a/sound/soc/qcom/lpass-platform.c +++ b/sound/soc/qcom/lpass-platform.c @@ -19,7 +19,7 @@ =20 #define DRV_NAME "lpass-platform" =20 -#define LPASS_PLATFORM_BUFFER_SIZE (24 * 2 * 1024) +#define LPASS_PLATFORM_BUFFER_SIZE (24 * 2 * 1024) #define LPASS_PLATFORM_PERIODS 2 #define LPASS_RXTX_CDC_DMA_LPM_BUFF_SIZE (8 * 1024) #define LPASS_VA_CDC_DMA_LPM_BUFF_SIZE (12 * 1024) diff --git a/sound/soc/qcom/sdw.c b/sound/soc/qcom/sdw.c index 6576b47a4c8c..981884927e30 100644 --- a/sound/soc/qcom/sdw.c +++ b/sound/soc/qcom/sdw.c @@ -131,7 +131,6 @@ int qcom_snd_sdw_prepare(struct snd_pcm_substream *subs= tream, struct sdw_stream_runtime *sruntime; int ret; =20 - if (!qcom_snd_is_sdw_dai(cpu_dai->id)) return 0; =20 @@ -159,7 +158,7 @@ int qcom_snd_sdw_prepare(struct snd_pcm_substream *subs= tream, sdw_deprepare_stream(sruntime); return ret; } - *stream_prepared =3D true; + *stream_prepared =3D true; =20 return ret; } --=20 2.25.1 From nobody Sat Sep 26 11:01:12 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A40A314D1A; Wed, 2 Sep 2026 07:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788333658; cv=none; b=BjA2Ls2khuPjHhh+16H+De5Nx8hvGfi5tC6w8OmsdcU8plm+pLhRmFJ9SiEA9lMzFnFe/DVZ75Jry9VmTbkCW7vs+DkaABH6PM8/3Lmk2qDY1paQGsDlD5silaNBYCx1JZnuMZ7++9I/339MXx3lWuF4+o2RIRjwKofS1x5oBSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788333658; c=relaxed/simple; bh=/D36qVa1w8LjKCyvdYOxR+EYq1+D05cx9lP9Cjekp7s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nGZU/3qvJmSxZjo/BIw9TWxQrvmJDWsF0XOkpK/0FwFG7ovcFEHOGYZ4JcMzK1YkyCj4ojdfEmfOId988r18VJXW1lrI/8UHj/WOtvflNvoUNPO3+wqxZW5fCO1Ib7/Keh/b/JUeZjdvGLmyF5NkzqWcdkc+PsyM/vr5XByKVXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=npfTwp6e; arc=none smtp.client-ip=117.135.210.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="npfTwp6e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=3f K3VdKNVXJvWoOP7f+9oY2Fa6VvBCVybss9wJNWZ8M=; b=npfTwp6eYdc5tZwSq6 sXZ+Z9wxCNrvKKN3cNzb1jlGYdV3pXu5pgR9NoAo89jyTLAoqM1PK7Nr0a2Mgo+i /5sJgPQCXKwCXUIGnjSuPnFRzOQbxcy7HBXsUivcmQ2n+ldk3O1pcBBm1FKI1USn iRz5iqWoxPVJsA/fKgqmKlrlk= Received: from localhost.localdomain (unknown []) by gzsmtp1 (Coremail) with SMTP id PCgvCgBnP6UuzpdqMkg2NQ--.54267S4; Wed, 02 Sep 2026 15:20:18 +0800 (CST) From: wangdich9700@163.com To: srini@kernel.org, broonie@kernel.org, tiwai@suse.com, wangdich9700@163.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, wangdicheng@kylinos.cn Subject: [PATCH 2/3] ASoC: qcom: lpass-hdmi: fix invalid rate error message Date: Wed, 2 Sep 2026 15:19:42 +0800 Message-Id: <20260902071943.522194-3-wangdich9700@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260902071943.522194-1-wangdich9700@163.com> References: <20260902071943.522194-1-wangdich9700@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PCgvCgBnP6UuzpdqMkg2NQ--.54267S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gr47tFy7Cw4DJFyDCFy7Awb_yoWfKFgEv3 WS9w48Z34UWF4Iyw18Gr4rZr4q9r42gFW7u3y5trnrtryUZr98CF1ktFZ3WrZaqan5AFyY gFZY9r1UAa4DGjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRE3xhJUUUUU== X-CM-SenderInfo: pzdqwv5lfkmliqq6il2tof0z/xtbC5xJAj2qXzjKk1wAA3I Content-Type: text/plain; charset="utf-8" From: wangdicheng The sampling rate switch reused the bitwidth error path, so an unsupported rate logged "invalid bit width" with the bitwidth value. Print the rate instead. Signed-off-by: wangdicheng --- sound/soc/qcom/lpass-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/lpass-hdmi.c b/sound/soc/qcom/lpass-hdmi.c index 8bbe43facdc1..dd0ae4fbc841 100644 --- a/sound/soc/qcom/lpass-hdmi.c +++ b/sound/soc/qcom/lpass-hdmi.c @@ -64,8 +64,8 @@ static int lpass_hdmi_daiops_hw_params(struct snd_pcm_sub= stream *substream, sampling_freq =3D LPASS_SAMPLING_FREQ48; break; default: - dev_err(dai->dev, "%s invalid bit width given : %d\n", - __func__, bitwidth); + dev_err(dai->dev, "%s invalid sampling rate given : %d\n", + __func__, rate); return -EINVAL; } data_format =3D LPASS_DATA_FORMAT_LINEAR; --=20 2.25.1 From nobody Sat Sep 26 11:01:12 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85DA238DC53; Wed, 2 Sep 2026 07:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788333660; cv=none; b=VSqujrGvTqk89n2XYx3lfC5AK+vrRJKf2fj+6stkYY0juJrIy7OWZzDXbCc/i99XYhusMHy28KQr5uQB+MgACdzutM+2mPYsdygBD3IhbAyDtmeFO7BYT4ScN6XQVffbVkMoiM7voieJUi8yFQhMa1LjXmR34YwGg5jhz0L2VJ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788333660; c=relaxed/simple; bh=R/4XowQmGvxTlj2rCZ1tdczvx2JUZWBc0dNrP/2sr0Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RsMXgq1SsijHHm2ER7wNJQKTvxjenu8o/tzYmdw7ktVGKKBVy33xNSOwVkb7iHCm5DYAZWJyPigUWk+NDxRnca8tpC8UhxXnsk7L0tseuknAgPJOGS8wNYvCvmoCcmrH5IZvXxoEFgqD+pQRXoeI5JQqFJkFEVwlR4U89s34sTo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=YTWCjTpO; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="YTWCjTpO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=vw 1Xvpggs2mVj8lsae6MPUwNod4aHqBhrGAI+BPAJEg=; b=YTWCjTpOPUqjx8dsOM w42+CJhoFN3qpnUDHC+tpNNAiLxxYI6hyXWkT7XPHyNTBgA1Eo2LOqGf8lwrZoLo kkZR+EoNT6+UL4ARtw+n263ZOjUHhzzNRJazCqrsdA/H0QZgG6jaos1AwkYiCTUj 5Uv7cF2mF3cYbDlkOUMkUvy94= Received: from localhost.localdomain (unknown []) by gzsmtp1 (Coremail) with SMTP id PCgvCgBnP6UuzpdqMkg2NQ--.54267S5; Wed, 02 Sep 2026 15:20:19 +0800 (CST) From: wangdich9700@163.com To: srini@kernel.org, broonie@kernel.org, tiwai@suse.com, wangdich9700@163.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, wangdicheng@kylinos.cn Subject: [PATCH 3/3] ASoC: qcom: fix VA CDC DMA DAI range handling Date: Wed, 2 Sep 2026 15:19:43 +0800 Message-Id: <20260902071943.522194-4-wangdich9700@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260902071943.522194-1-wangdich9700@163.com> References: <20260902071943.522194-1-wangdich9700@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PCgvCgBnP6UuzpdqMkg2NQ--.54267S5 X-Coremail-Antispam: 1Uf129KBjvJXoWxAF4kAFWkZrWUAF1UGFy3Arb_yoW5WFWrpF 43Wan8KrZ8Aa97Zw17Jr45Wr1UGr4xtFWxCay5J3Z7Jwn8ArnFqay3JF1IgFW2kryIqFn3 JrW7Z3s8uF4vgrDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0ziAuc_UUUUU= X-CM-SenderInfo: pzdqwv5lfkmliqq6il2tof0z/xtbC5xNAj2qXzjOk+wAA3k Content-Type: text/plain; charset="utf-8" From: wangdicheng Several switch statements used "LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX0" which only matches VA_TX0, leaving VA_TX1 through VA_TX8 to hit the default case and print a spurious error. In lpass-cdc-dma.c this also meant the va_mem0 clock was not prepared for those DAIs. Use LPASS_CDC_DMA_VA_TX8 as the upper bound to match the rest of the driver. Signed-off-by: wangdicheng --- sound/soc/qcom/lpass-cdc-dma.c | 8 ++++---- sound/soc/qcom/lpass-platform.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/qcom/lpass-cdc-dma.c b/sound/soc/qcom/lpass-cdc-dma.c index 5be13dd59517..dc645fcfd33b 100644 --- a/sound/soc/qcom/lpass-cdc-dma.c +++ b/sound/soc/qcom/lpass-cdc-dma.c @@ -180,12 +180,12 @@ static int lpass_cdc_dma_daiops_startup(struct snd_pc= m_substream *substream, clk_set_rate(drvdata->codec_mem0, CODEC_MEM_HZ_NORMAL); clk_prepare_enable(drvdata->codec_mem0); break; - case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX0: + case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX8: clk_set_rate(drvdata->va_mem0, CODEC_MEM_HZ_NORMAL); clk_prepare_enable(drvdata->va_mem0); break; default: - dev_err(soc_runtime->dev, "%s: invalid interface: %d\n", __func__, dai-= >id); + dev_err(soc_runtime->dev, "%s: invalid interface: %d\n", __func__, dai->= id); break; } return 0; @@ -202,11 +202,11 @@ static void lpass_cdc_dma_daiops_shutdown(struct snd_= pcm_substream *substream, case LPASS_CDC_DMA_TX0 ... LPASS_CDC_DMA_TX8: clk_disable_unprepare(drvdata->codec_mem0); break; - case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX0: + case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX8: clk_disable_unprepare(drvdata->va_mem0); break; default: - dev_err(soc_runtime->dev, "%s: invalid interface: %d\n", __func__, dai-= >id); + dev_err(soc_runtime->dev, "%s: invalid interface: %d\n", __func__, dai->= id); break; } } diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platfor= m.c index b335b2c8bb16..2f65e6a589bc 100644 --- a/sound/soc/qcom/lpass-platform.c +++ b/sound/soc/qcom/lpass-platform.c @@ -490,10 +490,10 @@ static int lpass_platform_pcmops_hw_params(struct snd= _soc_component *component, break; case LPASS_CDC_DMA_RX0 ... LPASS_CDC_DMA_RX9: case LPASS_CDC_DMA_TX0 ... LPASS_CDC_DMA_TX8: - case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX0: + case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX8: break; default: - dev_err(soc_runtime->dev, "%s: invalid interface: %d\n", __func__, dai_= id); + dev_err(soc_runtime->dev, "%s: invalid interface: %d\n", __func__, dai_i= d); break; } switch (bitwidth) { --=20 2.25.1