From nobody Sat Sep 26 13:08:30 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6AA364029 for ; Tue, 1 Sep 2026 10:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788259173; cv=none; b=YGPHKeACBVTTnzxCEn01EiysAN0LHY2iIi9rdCCkqpLU7PSplhDoBzhQNE/zJ3qjED5DWmCVJl6sN9KhPmkshELw+Dk6G/waKmZKAGvkYj/5MOXFX4z3SjNl6fkxxCa4LLvtguKPcS6fz3OF3Qp9YZfNWiWGNd4/v/MLDgQXxvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788259173; c=relaxed/simple; bh=Wk/xdeu9s2D6TjNypVsWQOHmXWfUJMBX/XxmxZ7jtdM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pjRoU01MEPN6uTwSpcUbhxx97DW0tCeV1mer7lHQK78taojE6gc/jRsU+WRqANWPVXjmo0MD+JA9qfNrIbsAQhYITf6fHe6oBj2BJR5csM2sn9fSW9ipzZQhnLKj7YbsmHorWBuMxawlYoubWLrW97k+xISVUa5iR0B0vVlLgkU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JLCKN4fa; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JLCKN4fa" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6a63c610b8dso3528730a12.2 for ; Tue, 01 Sep 2026 03:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788259170; x=1788863970; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6jb7pMwxdDzbuNzL/3IW6rWm99OzJOPz1C4e0fB1UjE=; b=JLCKN4falShZRjzt86tHtNaFsiFQdJv5WJE67xqQ3/t4ooo2dm40xhWLq7opeMM1x7 Qn+V4TAOkRoFgvjS9Ro5SZNArFgC1mfHj6NOQOMkLpMsjC13AWaeaAeUYcjtCuIX5SFP 5saPCaYIq2sHDM8v6aejiYa0S7myYMoszqonJAt+pOODv7oOpoWqSUp6rXXr6tJpHR3S UgpJo6W7BVw08yrVO15nPePwvKOp7SjIsAxF/eHOlu4UdoXUikysD9vG0h79GF8Ce7BW zlBzDVXL7irPGo/TO+Guh/L0MUKBDKnoobD9hqQqlZp3RdcVyN67ZCYdNdUD1lpC8J2C L1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788259170; x=1788863970; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6jb7pMwxdDzbuNzL/3IW6rWm99OzJOPz1C4e0fB1UjE=; b=Hi421Y0L9LtrbafSi4vs2JolTB3tIxL/knssNHIb0qX6FFntf6ZdHMUA3S2OKWwwfB 2iIRhsHMZEjRoOM4WKHlTt21B6FDrOqLji3IOFRiA5MRuziTmr9yMeJtETaOJhT8MZqW xYo/w+G2qqWFVXvLO8HjI4LkIRyTgoxGU03VhfyKTohRC7WhP0MFZwtGA2Nfg1RxVb6x fg6xzGsz/PytUZLQnERt7eos1sa8xUN34o74Nh0ivsuBdzpnFyW7QEFZJ5N3l64pPLyB TPXDUoim0lHgXuyHbYNMrBzugM2wgI7/kv2jIhv/o9GIT55NqJUHjCrn2KLYS1B/JmeX 8ZEA== X-Forwarded-Encrypted: i=1; AHgh+RrsJFR7TVcVrefUt/9elDakIZwytoC49UkiI6J/LHCgXjNEKc5mmiG82FdfSgEP60XIne8WaV2EaltEVEc=@vger.kernel.org X-Gm-Message-State: AFuF++kRMB4iGe1kCzB/HPpP5JAjtUbHc0f2n0kt+pWSmtGU5g9lsj9q EshBpKsm4VTmrX0/A9nLn7FY7WqrzUmjmHmjescJctAd+ONJ+3DKsdTl X-Gm-Gg: AR+sD10MI9A6Wo2TmLxwqUVZvLSYUxxq3+bxkhlShRTpz+yzMPJuDNnJMWS46U5x8vC 4IKOV5tFFFwGViKITGwzUgls1kkfwt1IvbPcZXFfCapISYNQQQJx5QuHB7q2Zhuzx9xPFxhzNA3 aKqmWyffDCx540TDXx8fIfTWuAtzFVBpa3Qm4MFQk9Kx2J2Ki/WfYsROeMhOGXoQjHPNL5R9TZ8 8VCmawkqPmvxPLDlWDrODuT2HPbTqYmfm6K7CEiGSt8ATkYC+r0I0a12MsAdNQs+UK0MBcppjE4 59d31cQBIapmV6z/855fTLQkKtOvoabYW636vvCdo/TWsGsNzv+OY52eSeD8g7+TrM3TBTOkZzY klhwnIddz0tnydsONSraAmzGU7jT0n2nMVQ/gKipb9My08Eoqu8gdIz2FmgaKQfLrsibP794p4Q O38rDseKSMP1uQc/un7eAgJLbUDMHQ4u2Y14GDy60c/j5z/DWQ0oEBwXeTfZYXc7iZlWZ9pTdwI 229PON6mSWpvgt+VSO4XJIP/QkD3aE= X-Received: by 2002:a17:906:2545:b0:c25:4e5:fe33 with SMTP id a640c23a62f3a-c25b3e13d44mr415955666b.24.1788259169788; Tue, 01 Sep 2026 03:39:29 -0700 (PDT) Received: from burk (46-162-75-122.cust.bredband2.com. [46.162.75.122]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c255ee0b23esm544216266b.2.2026.09.01.03.39.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 03:39:29 -0700 (PDT) From: Philip Nielsen To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Philip Nielsen Subject: [PATCH v2] staging: rtl8723bs: avoid CamelCase in rtw_efuse Date: Tue, 1 Sep 2026 12:39:19 +0200 Message-ID: <20260901103919.20245-1-philipnielsen64@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid CamelCase naming for local variables, function parameters, and static helper functions in rtw_efuse.c as well as associated prototypes in rtw_efuse.h to adhere to the Linux kernel coding style and clear checkpatch.pl checks. Signed-off-by: Philip Nielsen --- Changes in v2: - Rebase on top of latest staging-testing branch. drivers/staging/rtl8723bs/core/rtw_efuse.c | 72 +++++++++---------- drivers/staging/rtl8723bs/include/rtw_efuse.h | 4 +- 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 7e215c9845f6..b2d22307b115 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -41,48 +41,48 @@ rtw_efuse_calculate_word_counts(u8 word_en) * 09/23/2008 MHC Copy from WMAC. * */ -u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address) +u8 rtw_efuse_read_1_byte(struct adapter *adapter, u16 address) { - u8 Bytetemp =3D {0x00}; + u8 byte_temp =3D {0x00}; u8 temp =3D {0x00}; u32 k =3D 0; - u16 contentLen =3D 0; + u16 content_len =3D 0; =20 - Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, = &contentLen); + Hal_GetEfuseDefinition(adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, = &content_len); =20 - if (Address < contentLen) {/* E-fuse 512Byte */ + if (address < content_len) {/* E-fuse 512Byte */ /* Write E-fuse Register address bit0~7 */ - temp =3D Address & 0xFF; - rtw_write8(Adapter, EFUSE_CTRL + 1, temp); - Bytetemp =3D rtw_read8(Adapter, EFUSE_CTRL + 2); + temp =3D address & 0xFF; + rtw_write8(adapter, EFUSE_CTRL + 1, temp); + byte_temp =3D rtw_read8(adapter, EFUSE_CTRL + 2); /* Write E-fuse Register address bit8~9 */ - temp =3D ((Address >> 8) & 0x03) | (Bytetemp & 0xFC); - rtw_write8(Adapter, EFUSE_CTRL + 2, temp); + temp =3D ((address >> 8) & 0x03) | (byte_temp & 0xFC); + rtw_write8(adapter, EFUSE_CTRL + 2, temp); =20 /* Write 0x30[31]=3D 0 */ - Bytetemp =3D rtw_read8(Adapter, EFUSE_CTRL + 3); - temp =3D Bytetemp & 0x7F; - rtw_write8(Adapter, EFUSE_CTRL + 3, temp); + byte_temp =3D rtw_read8(adapter, EFUSE_CTRL + 3); + temp =3D byte_temp & 0x7F; + rtw_write8(adapter, EFUSE_CTRL + 3, temp); =20 /* Wait Write-ready (0x30[31]=3D 1) */ - Bytetemp =3D rtw_read8(Adapter, EFUSE_CTRL + 3); - while (!(Bytetemp & 0x80)) { - Bytetemp =3D rtw_read8(Adapter, EFUSE_CTRL + 3); + byte_temp =3D rtw_read8(adapter, EFUSE_CTRL + 3); + while (!(byte_temp & 0x80)) { + byte_temp =3D rtw_read8(adapter, EFUSE_CTRL + 3); k++; if (k =3D=3D 1000) break; } - return rtw_read8(Adapter, EFUSE_CTRL); + return rtw_read8(adapter, EFUSE_CTRL); } else { return 0xFF; } } /* rtw_efuse_read_1_byte */ =20 -/* 11/16/2008 MH Read one byte from real Efuse. */ +/* 11/16/2008 MH Read one byte from real efuse. */ u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data) { u32 tmpidx =3D 0; - u8 bResult; + u8 b_result; u8 readbyte; =20 /* <20130121, Kordan> For SMIC EFUSE specificatoin. */ @@ -107,19 +107,19 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, = u16 addr, u8 *data) } if (tmpidx < 100) { *data =3D rtw_read8(padapter, EFUSE_CTRL); - bResult =3D true; + b_result =3D true; } else { *data =3D 0xff; - bResult =3D false; + b_result =3D false; } =20 - return bResult; + return b_result; } =20 /*------------------------------------------------------------------------= ----- - * Function: Efuse_ReadAllMap + * Function: efuse_read_all_map * - * Overview: Read All Efuse content + * Overview: Read All efuse content * * Input: NONE * @@ -132,15 +132,15 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, = u16 addr, u8 *data) * 11/11/2008 MHC Create Version 0. * */ -static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *E= fuse) +static void efuse_read_all_map(struct adapter *padapter, u8 efuse_type, u8= *efuse) { - u16 mapLen =3D 0; + u16 map_len =3D 0; =20 Hal_EfusePowerSwitch(padapter, true); =20 - Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, &mapLen); + Hal_GetEfuseDefinition(padapter, efuse_type, TYPE_EFUSE_MAP_LEN, &map_len= ); =20 - Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse); + Hal_ReadEFuse(padapter, efuse_type, 0, map_len, efuse); =20 Hal_EfusePowerSwitch(padapter, false); } @@ -161,18 +161,18 @@ static void Efuse_ReadAllMap(struct adapter *padapter= , u8 efuseType, u8 *Efuse) * 11/13/2008 MHC Create Version 0. * */ -void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType) +void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuse_type) { - struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); - u16 mapLen =3D 0; + struct eeprom_priv *eeprom =3D GET_EEPROM_EFUSE_PRIV(padapter); + u16 map_len =3D 0; =20 - Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, &mapLen); + Hal_GetEfuseDefinition(padapter, efuse_type, TYPE_EFUSE_MAP_LEN, &map_len= ); =20 - if (pEEPROM->bautoload_fail_flag) - memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen); + if (eeprom->bautoload_fail_flag) + memset(eeprom->efuse_eeprom_data, 0xFF, map_len); else - Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data); + efuse_read_all_map(padapter, efuse_type, eeprom->efuse_eeprom_data); =20 /* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */ - /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */ + /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], map_len); */ } /* rtw_efuse_shadow_map_update */ diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/stagin= g/rtl8723bs/include/rtw_efuse.h index a60e05cf699c..1e5d61f4587b 100644 --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h @@ -71,7 +71,7 @@ struct efuse_hal { u8 rtw_efuse_calculate_word_counts(u8 word_en); u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data); =20 -u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 Address); -void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType); +u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 address); +void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuse_type); =20 #endif --=20 2.55.0