From nobody Sat Sep 26 11:49:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64A0E456297 for ; Tue, 1 Sep 2026 20:05:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788293101; cv=none; b=H8cOSXC0tsTXLoqqjg+aMYeD97O3pJHo2iXLdKSFM55+bdEvGQkqRgpT0TXBcQee3N42FVccD6SMVvDjmHh4hPoJaTpC1wBXmLZ2NGq9tA3DzYAMBeB+FEVbzs6IZEFna+aFw+IAQzRIetIvdPEE0uT7ERGLwboWIcPtOanxlHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788293101; c=relaxed/simple; bh=Qvg96r1uqRi7ZsIahTd0vxEuEUAxLGPkPnDx+jmOuQs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=lKeKvTuTLaGBeiLW01To3iVYIahtvnFLVKA4fpyZwnaJtfLmgxw4JhW6dZAbo7Vit72aP9qgLx8Wy/yUNCDSp/Z2sWuX+VnMrLp7cEwktVX7zpMoh4B7xv07LTmTmTVGeR4REZWwbYCKcXdh6eHX+xcCFtrL1UjJKHGO0Gig0bw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TnzEUrOn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TnzEUrOn" Received: by smtp.kernel.org (Postfix) with ESMTPS id F362CC2BCF4; Tue, 1 Sep 2026 20:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788293101; bh=Qvg96r1uqRi7ZsIahTd0vxEuEUAxLGPkPnDx+jmOuQs=; h=From:Date:Subject:To:Cc:Reply-To:From; b=TnzEUrOnWeKc2IJhDqDEHr24D1ZpYZJTysb91o2LXRfFMdLZJD8mon8H9TFI1JY+g wHBs3NQfp/kNUO8unmeJXu9FFgc1ywOzd8wd8R6KsCjGi5+oOk+xXooNI6waXpRBPT 2W2dJA8Pcon9slfvjKvGaa/Kg9MZLGSOBq4btFOzzOIHiaEwDoKsG5XRRvq1mVWmk3 f4SK+nIxxW8UkkzcWPyH0g8mRQTtt3sZK2lTX7YK1dAKyRCEVq27puthHw8f5vTe+i 0RoJG/1mMSvdGe7mmO1fK/sMGU+FF7ByXgL2fBH+62ePRjQ/LR50qBeKVlNC2qevZa 85k4kYnncJzZg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC85DC61DD6; Tue, 1 Sep 2026 20:05:00 +0000 (UTC) From: Vincent Jardin via B4 Relay Date: Tue, 01 Sep 2026 22:04:37 +0200 Subject: [PATCH] bus: fsl-mc: register the object drivers after misc_class exists Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260901-for-upstream-fsl-mc-initcall-order-v1-1-36ffe48f767d@free.fr> X-B4-Tracking: v=1; b=H4sIANQvl2oC/x3NwQrCMAyA4VcZORtoU5jMVxEPtUs10LUj2UQYe 3eLx+/y/wcYq7DBbThA+SMmrXb4ywDpHeuLUeZuIEejm4gwN8V9tU05Lpit4JJQqmwploJNZ1b kEPwYJnf19IQeWpWzfP+T++M8f6bGI1F0AAAA To: Ioana Ciornei , "Christophe Leroy (CS GROUP)" Cc: Laurentiu Tudor , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable+noautosel@kernel.org, Vincent Jardin X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788293080; l=2613; i=vjardin@free.fr; s=20260525; h=from:subject:message-id; bh=SXlMvnAA+Yv9aOr3bof+GHsV/62VSrRffjRMXK6jUP8=; b=Q0DNQlW6k/74/YvmvMnm7KR6URJ1LrX/mfYfTlKrZ73dg+vhupeXaUuRo+NA7LhYlLA4RULEh Bl42jSLrySdALA0c54lYp2NUpW7m/nPrOleoqbafewj1sO6QtpbR7ZC X-Developer-Key: i=vjardin@free.fr; a=ed25519; pk=hppgLeFpGpKOi7LNwGEZ4jOYofJCoGd4Jf1ltAabiLw= X-Endpoint-Received: by B4 Relay for vjardin@free.fr/20260525 with auth_id=871 X-Original-From: Vincent Jardin Reply-To: vjardin@free.fr From: Vincent Jardin Unbinding and re-binding the root DPRC fails with: sysfs: cannot create duplicate filename '/dev/char/10:256' misc_register / fsl_mc_uapi_create_device_file / dprc_setup / dprc_probe Cc: stable+noautosel@kernel.org # niche: root DPRC unbind/rebind only Fixes: 2cf1e703f066 ("bus: fsl-mc: add fsl-mc userspace support") Signed-off-by: Vincent Jardin --- Issue found when unbinding/rebinding the root DPRC on an LX2160A. The failure is silent at bind time and only shows up as a duplicate /dev/char entry on the second bind. --- drivers/bus/fsl-mc/fsl-mc-bus.c | 40 ++++++++++++++++++++++++-------------= --- 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bu= s.c index 66a4fa73c5b86..7f283844e4500 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -1264,35 +1264,43 @@ static int __init fsl_mc_bus_driver_init(void) error =3D bus_register(&fsl_mc_bus_type); if (error < 0) { pr_err("bus type registration failed: %d\n", error); - goto error_cleanup_cache; + return error; } =20 - error =3D platform_driver_register(&fsl_mc_bus_driver); - if (error < 0) { - pr_err("platform_driver_register() failed: %d\n", error); + error =3D bus_register_notifier(&platform_bus_type, &fsl_mc_nb); + if (error < 0) goto error_cleanup_bus; - } + + return 0; + +error_cleanup_bus: + bus_unregister(&fsl_mc_bus_type); + return error; +} +postcore_initcall(fsl_mc_bus_driver_init); + +static int __init fsl_mc_bus_drivers_init(void) +{ + int error; =20 error =3D dprc_driver_init(); if (error < 0) - goto error_cleanup_driver; + return error; =20 error =3D fsl_mc_allocator_driver_init(); if (error < 0) goto error_cleanup_dprc_driver; =20 - return bus_register_notifier(&platform_bus_type, &fsl_mc_nb); + error =3D platform_driver_register(&fsl_mc_bus_driver); + if (error < 0) { + pr_err("platform_driver_register() failed: %d\n", error); + goto error_cleanup_dprc_driver; + } + + return 0; =20 error_cleanup_dprc_driver: dprc_driver_exit(); - -error_cleanup_driver: - platform_driver_unregister(&fsl_mc_bus_driver); - -error_cleanup_bus: - bus_unregister(&fsl_mc_bus_type); - -error_cleanup_cache: return error; } -postcore_initcall(fsl_mc_bus_driver_init); +subsys_initcall_sync(fsl_mc_bus_drivers_init); --- base-commit: 786262be6048deab760f68c8acc2c85607165894 change-id: 20260922-for-upstream-fsl-mc-initcall-order-e3316390712b Best regards, --=20 Vincent Jardin