From nobody Sat Sep 26 13:11:33 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9681A351C35 for ; Tue, 1 Sep 2026 11:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788261961; cv=none; b=VHcjXhMBZnRfYc8iwjthJEQo1SjXuaNmPtNquGg+OmblKuNHzoXCHf3y/f/87gVRiQZ71Q+1raNUPnWArzilEVgg1sS7wFtLc+cDriEhfonOjH8T8al5iL9RLMugL4aKZs5XifLWVHQ9NPFx6v5sRCwKZJz/cz+J2jCOeqwlp6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788261961; c=relaxed/simple; bh=jTp2GntyDIHxjPo3lsbT4RFexVL3HPEV5KbNlfne2PY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=oqzPEmobvzjsArYZb1jMQ1vZTElNxIlmtOLDt5QdrZR2YadmK3kgtR1qzNkfK4d5O1+KpPIdKyuVIMqUd32bMZm1WoKZ0dbcDWNWg1Ht8zto7U8oo5t9WJoHgVXUfQGBohD1fuJIp5m1myla2R748dmt1aTm6u+EkOcVKncdYmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X1THN2+C; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g0k2QBkP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X1THN2+C"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g0k2QBkP" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 681AJP062993718 for ; Tue, 1 Sep 2026 11:25:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=r1OdVL+Tbt9zws2fnd3Nhg TB2MVa0oBkflSXJea0/Iw=; b=X1THN2+CbscYwlTY6tBmR8LhY1K72I7TqCBY/u NKGkylVZ/IaVU4CwXIDW7cqKyDNkGCESpAE/Cn9wxoynpI1u6wWFq8W41zZ8aWIK Kvxtt66vRmAlbvj8NZi5yfNPTBXIaF/7dbtWW6UbZRhYOPEg4r+g3BXxwcNOTw2n OEMhLiLf6FNSrhnb6MRv8FaVBV+/dxfpOKGOO7Tl5h1nnc1aYVwMKWg+xhyiVtyw aGa2V2qN+8aFYf5sB6zxwYOgoO/yZ0buu5EQ+TA3bq8voiw9Y83RftRgK3H5a2k4 yi6qONr2yJTzPTh3ooJYu9ZFmzBsz37jurM/7EzI8XQinNTA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gdeg3c4ea-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 01 Sep 2026 11:25:58 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cc1c057f480so1000411a12.0 for ; Tue, 01 Sep 2026 04:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788261958; x=1788866758; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=r1OdVL+Tbt9zws2fnd3NhgTB2MVa0oBkflSXJea0/Iw=; b=g0k2QBkPK/pnw+TEF8fgn65NlZa7VZlil+A4iOQMaFub8fJTPhMggaLQiOfNouSSlo NC/odLRL3g9bHyEWoBUcdNC5RPfOIAO3RWVR5hOxSMa+2RDUs42k4iuF55rZkLxXr9ZY ZxAS5ZMGuvHJ7YfYlcL8petikUARtY3OlYbFqx3SW6ghAS/rAywHDk0iK6DU+6BbRip4 raTUn/razjSALh9RHvGMbB872vA/FiJCFuCCnnd41xgvZockJkDJDxXAft6PW9AoOWy3 vzDMzlh5KcO4I3gFV3y+6Vne4/dxtCZKHoQ0H2OFff4m/+JMu4UZu51g5dGlmOwHsIbR 0MFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788261958; x=1788866758; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=r1OdVL+Tbt9zws2fnd3NhgTB2MVa0oBkflSXJea0/Iw=; b=gjyh7ciNOscgoiD2lH0xXRvVNArOhp3PJ5IGYJzC+s9Zfh6k386UYzbl7bkKlKeAAB J13PDHVNW4uxphwqyQRbBSSEBwiZUzcqMeUwuHsjHiQstQ/lSdaGV4s9OUMTEWhOvcJr 8Fjujhw2HLLzxkAEadNMl9R9v54FvIF3mPiU6wXqy2gtyh0UILDtl7U7xkCe6Usenwkb kMNWXqViyytiEw+rokN2eVvOZ+1wiRx5p7n7p9uIMdLbJfj65Zwb20U2H8rHCp66lVDO IXc4TH8ZARWsJFdMt4jTnLkOBOheowsWFN9SvaMmif8M+dxSV9FxBeQd6/Jd6qj6BY1c KhEQ== X-Forwarded-Encrypted: i=1; AKwUvBzUKKoNUp/ouOUmfvTfMKkUfubpWYvDFd4KIQBgdpkQGK3rHcaj6RbJ/dGytrpfiuAJWGdSwVDZVziI5ug=@vger.kernel.org X-Gm-Message-State: AFuF++m0qfwqLB+IZSlRbovGh8ADlAHVAHSMTd+5sm+O8gdzpHstVA7Z T8UY9QVRoL4b2w8vpTFHeGJQtau/wrZjFVH7MlurM2gXU930cj9Zoxzmp8tiCsDdV/0KUP1lOak 9kaqO9QUlyZMh30PPvhPWLaJbXiKb+cQCdqIJkGnlt2B0Eu0vxQuKFnepB64qaZVYhpZRUCuOyn uuIw== X-Gm-Gg: AYBFou2TJUpMOT5GlO4D27dqAqmdcPUwJC8UsITuhzyDQlH7MEqx1XLpfIcYSZ2H7lL 3dbcOu9yG76JDtrYenrO8q+44fvLUbZf+1bs1l6NjJb7FahJ5Kd1kbIsWHg4XW4PKtusGFp7C1o g2X19oLZBF76On3i0/fdI46hNyAwQ8byv6FY43x8MpFgwLA/yl/BNudTumWFDBrcLFywoc9qbXu SA0lsaOYpVAxBMtgVKDlfdxNvwy0gKqb3lGfYMdjIDKrn3aliHqQx0q86pJysHECaRXDka+ELF0 BnTmWx2a4uxoXmwcIrai6p5J9v9HtupMkaeJ4Vtv952T7YP0gmubp/jjqahRqVHlI2Of5s2AfHw /P8xQclbv3vspi5+PQVtENKmJktsnUMAO8fGQpA== X-Received: by 2002:a17:90b:1f87:b0:395:5f43:4ec4 with SMTP id 98e67ed59e1d1-396d0a6589dmr51697374a91.0.1788261958024; Tue, 01 Sep 2026 04:25:58 -0700 (PDT) X-Received: by 2002:a17:90b:1f87:b0:395:5f43:4ec4 with SMTP id 98e67ed59e1d1-396d0a6589dmr51697280a91.0.1788261957432; Tue, 01 Sep 2026 04:25:57 -0700 (PDT) Received: from hu-anupvish-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-142e0d1b38esm34685533c88.3.2026.09.01.04.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 04:25:57 -0700 (PDT) From: Anup Vishwakarma Date: Tue, 01 Sep 2026 16:55:50 +0530 Subject: [PATCH] remoteproc: qcom_q6v5: Fix qmp reference leak in qcom_q6v5_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260901-b4-q6v5_qmp_leak_fix_upstream-v1-1-5a2e99187c38@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAD22lmoC/yXMQQqDMBBA0avIrBtIJIbaq5QSEjPWsdXGjIog3 t20XT4+/B0YEyHDrdgh4UpMnzFDXQpoOjc+UVDIhlKWRtZSCa/FZNbKTkO0b3Qv29Jml8hzQjc Io1sVvA4arzXkR0yY++9/f/zNi++xmb9TOI4TPLV/0oEAAAA= X-Change-ID: 20260901-b4-q6v5_qmp_leak_fix_upstream-64f1db4d4e89 To: Bjorn Andersson , Mathieu Poirier , Georgi Djakov Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Anup Vishwakarma , Konrad Dybcio X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788261954; l=1691; i=anup.vishwakarma@oss.qualcomm.com; s=20260805; h=from:subject:message-id; bh=jTp2GntyDIHxjPo3lsbT4RFexVL3HPEV5KbNlfne2PY=; b=4S1iYk8YbZvpfEE1J6BSuneKHU0FzRW3tXGbE/F7abh6ySZDcF54/Abe6+79qcW4vgL1MTcy6 UUrwXi5YJGIBEE9rnd4jo2Q2VPhAq6HsD34Ela/4W5whye/1FJXt39g X-Developer-Key: i=anup.vishwakarma@oss.qualcomm.com; a=ed25519; pk=Y9ilCu91UQrzHOM14SG2IjnmQ1QSroH5uVeBSWEmEDM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAxMDEwMSBTYWx0ZWRfX8L9nQHpBYAKU vXl9RlLi//qoBxfsT5t9QddWcSO6KIhrLk3zEUjdwVoTxF/9xyWSMkLCaBHWuyOTQ83D/JkPmVX aQ/JwtP56ZAmSXkwE3sXbnCToEdVvUVKs18ISoAOjoAuJu2YDwGm7cUEF78kjD0CvH4wC0J6qAC 4XXVP4qKKJzDDt4w+o5a6yI3oq2E5R2we+E+EiHKWXRXsfiNj1bxJ+9jotQmBfZkKS8CFE9jqgG LnkfovO/WvK94S9r0B1TGEs9c8uRQX98Lr8UVZAXenCKsxGUCFBL3lTgbHD1dC/1FwFWjHAtgZy uMP0f/KBmXOrT5sxFB389b4//CjLFBAw1TWaFf8nN/pbU7Zb5ptUqFjkdhUsiLrtBGEkiI4ZZjb iZxSVY0Tzgbz5NLyUXimlXu0ArycCqq39wuFkSdwut88XLV8khIp4iuXkMjGSwrZtMVW7BLYzz0 vXrWMjQ990aJA5ZAW+A== X-Proofpoint-GUID: 6oBu7YpXZrLeLxK4h7qltXnHknAUyct- X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAxMDEwMSBTYWx0ZWRfXxLdywNBKdcle sIxMbOyFhXhu8GcZBrgo0uwlbroQgxPfGGOR036SPvXVpfwrcUp4PSrtaZCC4I1SN6PNr/GReYc 4TBPoZHD0HfDyJxSdhWKTKqsi7dDBM8= X-Authority-Analysis: v=2.4 cv=NZnWEWD4 c=1 sm=1 tr=0 ts=6a96b646 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=nqt0n7EWu-dirWW6vCcA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: 6oBu7YpXZrLeLxK4h7qltXnHknAUyct- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-01_03,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609010101 qmp_get() acquires a device reference on the AOSS QMP mailbox provider. If it succeeds and q6v5->load_state is already set, the code falls through to devm_of_icc_get() without releasing that reference -- if devm_of_icc_get() then fails, the function returns without ever calling qmp_put(), leaking it. The sibling error path just above (load_state being NULL) already calls qmp_put() correctly before returning; mirror that here. devm_of_icc_get() commonly fails with -EPROBE_DEFER during normal boot, so this leak isn't limited to a hard failure -- it can accumulate across deferred-probe retries. Fixes: 8d9be5c6bdcd ("remoteproc: qcom: q6v5: Add interconnect path proxy v= ote") Signed-off-by: Anup Vishwakarma Reviewed-by: Konrad Dybcio --- drivers/remoteproc/qcom_q6v5.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5.c b/drivers/remoteproc/qcom_q6v5.c index fe148b4b3775..71b79ab827e6 100644 --- a/drivers/remoteproc/qcom_q6v5.c +++ b/drivers/remoteproc/qcom_q6v5.c @@ -372,9 +372,11 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct plat= form_device *pdev, } =20 q6v5->path =3D devm_of_icc_get(&pdev->dev, NULL); - if (IS_ERR(q6v5->path)) + if (IS_ERR(q6v5->path)) { + qmp_put(q6v5->qmp); return dev_err_probe(&pdev->dev, PTR_ERR(q6v5->path), "failed to acquire interconnect path\n"); + } =20 return 0; } --- base-commit: 89c07d98716a13454ec3fd9f97689e812cc71bd4 change-id: 20260901-b4-q6v5_qmp_leak_fix_upstream-64f1db4d4e89 Best regards, -- =20 Anup Vishwakarma