From nobody Sat Sep 26 13:47:23 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76A1B39CCF6; Mon, 31 Aug 2026 21:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788212017; cv=fail; b=lu2ZJ8I6S9AuKcvU0F1wOsdj7ZyC9ClK5ECzNGzK0GLgkThf5t8HL/Q1ag+bBGj/w6E/7ce/V3on79O6NezYlp0aQRWwvu2VqDEfxmEAV6/BSh4+TKkRIwEwWLL2XvejLLp88Uuc7qWkCH34+nqGKZhsBdLzE9yhS6fmxAhYYK8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788212017; c=relaxed/simple; bh=RqkhnFF+zwgHBWl2t0d6rMJ/5xwax66D5K2zHgGPO8c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XIpE/eLuqku1HS/5j/A4wbrixJqBAs8r0PqhzwQilXqqYylk/KoYhcsWy0A10q/wTJs+pegqx92CltzMeT1pRZGCF5w0c6S2TRtxdUcavkkMRDUDD7K3gcg2T30H43akmzF6x8m6Cw5vhEqpAIZeGxHjL8NBKMisCyRbVHw2xmU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=SVIHBs7A; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=V1hKpYLC; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="SVIHBs7A"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="V1hKpYLC" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 67VIRgJM1642785; Mon, 31 Aug 2026 16:33:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=pa6V0D8Jl3UALzk7LSsz2EU+vDCAb2Yrv0iUUc7Nz CI=; b=SVIHBs7A33CJdNse7e6pncQ9k8k+d6lCknW9SN6SKF54FVvR8ZsFHFR3d kkf+AsTy3orXUdhH5R/dDquAFWvUqcJo4sjzQlDJPna1Mos5xhEln4Bn7onHrd8N nO+0KCXA2d6lrlXqXaPHNNWlJ7uiEVY0GHADMNNTMx8SJ6uiatX8UA+NyVBAWsmd kgl6epe9bmaiMoihsW4TIZEiav+TVCthttzJpdOf3GMVf1drc7BkBmSktD/sv2eO hrgnN1puh8qCJoIvvJFNDPTErpPr7M+ipuQGDFwQ/Gn25jIu0cUG03UH7GIPaWBc tvhViutTbLanOygwJsJg2KXDg6bmQ== Received: from bn8pr05cu002.outbound.protection.outlook.com (mail-eastus2azon11011035.outbound.protection.outlook.com [52.101.57.35]) by m0380145.ppops.net (PPS) with ESMTPS id 4gd44nd354-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 31 Aug 2026 16:33:27 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gaAUj87rjGPvSauHnipINiYLfw/thu0phwPtp/Ze8Kj9m3BybASap2rGI02jjq9kYwuP3Y+xjZCzEsbwtR6R2zM5lO3JtUWcYe6YBmp3xEN4WKAxR/Rzh2QGEcCGkElOi0MXvH1VqjSxE/0YQS9J1Q24/d9nbv/ODMMllLPkbO4kb7l6iD7GYI3l4Dpjmy1nOsvgK4VLMUahoJ5fhEonyy5Yac7VJH4No3B5eYo5fjKANZLqLCavJJ/G+tORep6JWWKzS9W4AFBdJCwUdj9kMOcBqp1NLClkvz0X8+t449O5n119Oo/C3GH7md5OeYrFgE8YDWhanfcScJ1XiePi0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pa6V0D8Jl3UALzk7LSsz2EU+vDCAb2Yrv0iUUc7NzCI=; b=XnxmH4k87Z8gEhu6Ln9OKs7DjzhOLw0koAtlix4dCBs9vKGSUASPD0UgzpeuoKCy1nsTp4Ohe7O2b5lJaCMxIeCX0bDpaah6SUZD55dFxkf3gPrgoLgdprxpDFpNI9khF78pKSU52BWMhSWl6I6Dv63DP5xp26PuMFsG5pzonGgEgxJxZGbOc/+GexUSjrSjv6TxSFOuU6bukWYjbQUoOGV4dQgrJL0Rvb7rMsd8e1qvJ7MvSmdUS0daZ5yy717lEs1Jc9mNP4NwZeU9mkomW3E9eLUAFD2+y6sDQUUk1RifFe3M3eHgsNrtrV9L+agfvqFCi9rH9rcnWES3+vPsag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pa6V0D8Jl3UALzk7LSsz2EU+vDCAb2Yrv0iUUc7NzCI=; b=V1hKpYLCmBFH+un4RHRxmYJmUzqyvayngyJotI3g9MDrDy+bx/oiua8IPBpWCOmILyYqfiap+A9iWMOGSoEuOQlxPGbhc0x1/qtsP20BOKp7oEnAJOTm+jeUr0SsWSQPyP3H4P1UL+f3OjQR6CoOcL9JB3ppQsJ9VtVwulAlCAM= Received: from CH5PR02CA0013.namprd02.prod.outlook.com (2603:10b6:610:1ed::27) by DM4PR10MB6207.namprd10.prod.outlook.com (2603:10b6:8:8c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.7; Mon, 31 Aug 2026 21:33:22 +0000 Received: from CH2PEPF00000140.namprd02.prod.outlook.com (2603:10b6:610:1ed:cafe::58) by CH5PR02CA0013.outlook.office365.com (2603:10b6:610:1ed::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.13 via Frontend Transport; Mon, 31 Aug 2026 21:33:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by CH2PEPF00000140.mail.protection.outlook.com (10.167.244.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Mon, 31 Aug 2026 21:33:21 +0000 Received: from DFLE207.ent.ti.com (10.64.6.65) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 31 Aug 2026 16:32:43 -0500 Received: from DFLE202.ent.ti.com (10.64.6.60) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 31 Aug 2026 16:32:42 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE202.ent.ti.com (10.64.6.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Mon, 31 Aug 2026 16:32:43 -0500 Received: from b-brnich.dhcp.ti.com (b-brnich.dhcp.ti.com [128.247.75.1]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67VLWbYb1545515; Mon, 31 Aug 2026 16:32:43 -0500 From: Brandon Brnich To: , , , , , , CC: Brandon Brnich , Subject: [PATCH v4 1/4] media: imagination: e5010: Properly Release m2m_dev if probe fails Date: Mon, 31 Aug 2026 16:32:28 -0500 Message-ID: <20260831213231.2125544-2-b-brnich@ti.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260831213231.2125544-1-b-brnich@ti.com> References: <20260831213231.2125544-1-b-brnich@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000140:EE_|DM4PR10MB6207:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fea592e-943c-49a1-d612-08df07a77aeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|82310400026|23010399003|18002099003|6133799003|10067099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: VsI3+cpCs0PdiUl9z7Z7+t0ByZ63isowXEB0WiPTg4wLLwHGGq5gFREPUTQ3WmpLb2j8gOKcO7CeIn9tQgYFY8pmuQP9Nt9C2xcX3VCvfPJ4GW7IRsyU1Cj/2NGzybP0dVyY+PyypI4fwsB1SYxeYufffuZmYs28r4Rumo6uURanMZQ0TuPLrtU7POix0xeBwOTk2VtZ9aInCMlC1ZCJ3kART3YDbChhZsxdOg7y8n9WLdqSwnfLFNsNFG8FSpMcc3QqgAwQn/6E3i2iQJx5m+0bLZtaf75hIqKd2ws6BV+9G4Pqtn/sTKimfB8Mh0ubzWrnWKRR2+p7UuBzLbNS/nt45pfmeNGBec18DOKXQ9Xe+FmfUdLkbdnPbXnNpLl/jHqi/UJVRrXbMHiN9m1YvrVeBV1M4RSgfM7lzSyPdj0bnRe03NJJTX59cK0i3lRPn8gGb45G0LX+iasmkczPj697Flxcs4OU9WAqe6lGC/gC2MCxN5ytMPivhUjiMj43yYf+iyPiUK98gIRotppgd3p4FH6CcfxW5DhYmIwscDRM9kQhsAR8SwAYKSEope9Pis6jaFXpGQH70wguZcHf7dfTmkJxpA1cXXGdAw3DT6MYK7TmvjjbMq4MMGH5vHo/EPR0sCEGvDQk7i93IpAMPUW+m5Z0PWGZydvtKs6jzqagySxJ/RmPjaa0Ovm68CQn+cwMAcO2oVNh20XqSx0EuA== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(23010399003)(18002099003)(6133799003)(10067099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qYddbRTHwag0vhY3HeD18NHFhLPDXEZ3ocdKokfTGw4OgbcDatfvjvYIt3Wk4/dqvS4eNhKdfXLLJhod0eJePPTqXlz6gIXY+1ZMmj2kZ3mZEMlzx2XWZdgxWmkBkx0TE7sQuzRG/GH7XWUvEyN5yomLgJadjx9rqB9EG2WRltFH6u284qBWjwuZpX4N0kaOVAn6XGilNEW8JqdaREHJtgUsZFQOicfEkeupRls6k9ezraiazD/1yEqBneQwmfGcJqaw7ThoigLgr2x3Rjbb6Rl+BGkuQPPHoMewitOemJ03zEXRkExn/RGkF5q6IU4+BZM4JeJOf0JyJss0z95GuEHi7pF90KSdYDttimKcg25FjvRJpa0VSfwuOh7PsdY4BVCHm40X2e5tSN7CaGknw9uyXP9I40As+n7DsT4BWp9hQ3oTY0pqOffwa7Eo8FfF X-Exchange-RoutingPolicyChecked: G+M/NNyy3Ozlyl4UF0zlhH0XmwocT4pVTn6qgukIru/x997F5LMoEhnAQh1ocaHbEQGOQZy3sc4I1IQiu4Jx/3zb1TnX23aQuXJSjIY3AYn1UNFVE75UlcxzvUcDIbt48fnsArVDMAIHzTD9q4mXS+jusqa1/CZT7y7KLz9MjQTszGER7Ffc70YHpE6GxzmMvcTGQwgfLF1L0r4WD6slUYaG1Or2lz9y9cKeth6pYxze+9nmsmtrHjGGgdTXhae+cYCpQzMeIPE6ueQYCSb6y0vb94H66mQ7Jzd8cXNTl2jMXk6Dp9SpWFm56qwRGGTXAPXoW3KuHeSz3nDiQZpykw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2026 21:33:21.2179 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fea592e-943c-49a1-d612-08df07a77aeb X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000140.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6207 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODMxMDE4NiBTYWx0ZWRfX7dyalSoxARXe ef5nySMNDqodst/ICBIcNzkgnxXSPg2CtiQlpTaasFNkACrXi29HS9VLp00342mcTNAisYGRaaH Imapw9XFGcUT1uqB3OaTPZvMiBzdb0bcCGBubWPN4rvHNgogDF9UmdcB5PJHEik+3U084/t1flu f3hg+C5lieWSmcxGmRcnaIKIdcl4lhlfvSQdu99NEoU6YHoOU8toYbpQ/Cvf60TaNCphSr8U9Yx pkf7wQBDLrTjm95MgTSXnY/ZHAu4q4rFDWWzNDuJMeXOCiKFcMld2Uk0ZU5b2lMlTjg2Bvfyoxv DrFlpeholYZpeq5B2hKDCuHzOHVavG/xXamiVDqhaJONQZY1CLtvJGhHOZBwjMoNihdUwTffYg9 OBnseR/WdUfbBt1x4dzby8HR5wlXg2wusphGk1q/UAHCDxN9a+ktlYf3pGdqpRLjifkEIDLvIaa UUHa/thXvPvyDYlQMIw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODMxMDE4NiBTYWx0ZWRfX5+8XnV2LACNr Z0tLg34B2hp0cdjuajj8RUWytlDZ5wTv3X3uyEyAbjcNyeVyyzwJP++qSrQ7GdPT9qxdttqwz2d lcJpPxC29RZPKGPC/dffiG4Qm0zcvlo= X-Proofpoint-ORIG-GUID: CuO9kOGEF8T5btbVCiJnzpaTvXNtfTk3 X-Proofpoint-GUID: CuO9kOGEF8T5btbVCiJnzpaTvXNtfTk3 X-Authority-Analysis: v=2.4 cv=T7W8ifKQ c=1 sm=1 tr=0 ts=6a95f327 cx=c_pps a=MvJzBjTJNBx6A1eu3kpgJw==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=VwQbUJbxAAAA:8 a=sozttTNsAAAA:8 a=BvWq2gUW7f8KG5-ffTcA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-31_06,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608310186 Content-Type: text/plain; charset="utf-8" After the call to v4l2_m2m_init() is successful, the following initialization functions should go to fail_after_video_register_device. Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver") Cc: stable@vger.kernel.org Signed-off-by: Brandon Brnich --- drivers/media/platform/imagination/e5010-jpeg-enc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/= media/platform/imagination/e5010-jpeg-enc.c index 42ad9ee3993b4..d3c11337c815d 100644 --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c @@ -1072,14 +1072,14 @@ static int e5010_probe(struct platform_device *pdev) if (IS_ERR(e5010->core_base)) { ret =3D PTR_ERR(e5010->core_base); dev_err_probe(dev, ret, "Missing 'core' resources area\n"); - goto fail_after_v4l2_register; + goto fail_after_video_register_device; } =20 e5010->mmu_base =3D devm_platform_ioremap_resource_byname(pdev, "mmu"); if (IS_ERR(e5010->mmu_base)) { ret =3D PTR_ERR(e5010->mmu_base); dev_err_probe(dev, ret, "Missing 'mmu' resources area\n"); - goto fail_after_v4l2_register; + goto fail_after_video_register_device; } =20 e5010->last_context_run =3D NULL; @@ -1089,14 +1089,14 @@ static int e5010_probe(struct platform_device *pdev) E5010_MODULE_NAME, e5010); if (ret) { dev_err_probe(dev, ret, "failed to register IRQ %d\n", irq); - goto fail_after_v4l2_register; + goto fail_after_video_register_device; } =20 e5010->clk =3D devm_clk_get(dev, NULL); if (IS_ERR(e5010->clk)) { ret =3D PTR_ERR(e5010->clk); dev_err_probe(dev, ret, "failed to get clock\n"); - goto fail_after_v4l2_register; + goto fail_after_video_register_device; } =20 pm_runtime_enable(dev); --=20 2.43.0 From nobody Sat Sep 26 13:47:23 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86B723A48D9; Mon, 31 Aug 2026 21:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788211999; cv=fail; b=T3e6mzTPw9pVRLKp6NE/dQ9bqCjy/ETxuYlIueUTeLtQi8KqBwGezc+SSUt4gBop7KQog8wuZ5rtEu+LunpdJYOIS6YRxShhdUcMUaUkFd8O0I2wPTQv/RJKNbK5G9dmLxBjnk6DABvRXcDIgAmTdawJBWy0UJT78V1NWDrt5KY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788211999; c=relaxed/simple; bh=ZlFCEZ6SdXqtbYIV+Aqdb3OJwV5IzF3fbOCfH8BBthE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Vohk6FZRpYy4sU3G+Ghj+h+D2Iv/t9MupZXcyllluShUzVBpisExy8AVCuR92CKDp7xke3/atuxMUImaafrGeQvHfQJisaHD8m9PghKa/ld7KY1vPHgLK1z5Q2JmLMyGtBX5+2wwANjAxUlitGaDcL+aPH7p9iHufIAxQqzYu7o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=k25aqiKU; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=MIYtq/J2; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="k25aqiKU"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="MIYtq/J2" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67VISV7j1813506; Mon, 31 Aug 2026 16:33:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=c8zLhN6wbKbmb+w+n88Dr6k7xVATWWufmipUecH+n YA=; b=k25aqiKUK0FpT1GqoL11dq6i7WvgWK+958vAFeQMUEV/u8WNhVyZoSPxw s1RlRlhIiXvOriSjzuU+smpvmAscHb+wphV6OBmx8hm8HrBvfGW8mm/Z6Vlphib5 LsH6ROQrzrbcDQ1pPAITdjW8Z8vhXb+4wOH8y7mrvabBgfQV+TUcah2JlYuVWhEz Gq3OpOS2trb+vAIurIIvXNTj/QC4vw/rjeONqB9L0CtmLIm1t011USKLcWmTk0mq C9zYMIT5Ftq4rNtW+HBgtSMBphCTc88FLo0fwmqww6y4Jq3b9xr5M51fJICaLT/O PncDyz4kwnj0wHE2Xb7vhdv555yZA== Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11010000.outbound.protection.outlook.com [52.101.61.0]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gcet48ttm-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 31 Aug 2026 16:33:13 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k6TzFJsLlRiQ+yIj1yPCh/2+GYq0AhcDjvbLFNycqk33EByPY3nAKqmba42YFYQcflPL2mSFvTNqsh8Y4aDUW8pYVfc1L2A5ZRyIaNVISKaFif0ZnB+gIiG/ipMoyVoe5ubEZZ/BqHqWV+8Q8P3f5aobO/moDGCSdjT8lb5hlTk+V8Cg+6AVAK8AmvfGeiEkCFRu0KoOKBYRNNIwVudwSunNuY71pPerv3AFUD8B1ytEr5fMszGIHtDT03xB+mUh80prkLmdQw+aOv0eGNL6X2qK8c4/y53kjZlwHjDmYP+bgI4+8noC7UOVYVXDTVKem8vGfzcwduJlXIEv69fqlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c8zLhN6wbKbmb+w+n88Dr6k7xVATWWufmipUecH+nYA=; b=NbIXS3VhtPD72fmYKrGh8gIGHENEotkKGHx/t/+KrFGhnJL0V8ADnc4r8+x2evZuj/cjjqVcqN7SYEBofd/aGihbCI9YY7RoZtPcGr56CWmOlWsIt6Mg4hTX12Xi65/yipl6M3b9wqqguHLcGLxVWrxmnAer295pEtpjHaCMhqOomfau3trENtIIxBf0/EqY719Xr7XH6Gx7Bs1CzJ42z+heCTYhp+diWir5BOSjbPqgOpT5xZsZwcNvO8tv5Mu2psrKo7cNNrwZo/yKWYBLT7lKYBczcyLb6KwD70eoXaH2wLapUf5FaULG3pAqdl+r9DFschIhT+yCHI4CFKMXqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8zLhN6wbKbmb+w+n88Dr6k7xVATWWufmipUecH+nYA=; b=MIYtq/J2ySkmS3sIgZfrxn9I0r+5jkpWawg79L1WoEl7dIaC2spT3AtNLfCoUYN5qacilTZyUiC3bnFDp76EWUvGGV6+VxMAoTcLrT9pfDQuEZxjbM4E+G/lKnbVIOUtjnwjECMF15qbr3zmyhQ+4ufYxaEQuqXQ/XuIbz3dNuI= Received: from BN1PR14CA0010.namprd14.prod.outlook.com (2603:10b6:408:e3::15) by DS0PR10MB6125.namprd10.prod.outlook.com (2603:10b6:8:c7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Mon, 31 Aug 2026 21:33:10 +0000 Received: from BN1PEPF0000467F.namprd03.prod.outlook.com (2603:10b6:408:e3:cafe::1c) by BN1PR14CA0010.outlook.office365.com (2603:10b6:408:e3::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.13 via Frontend Transport; Mon, 31 Aug 2026 21:33:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by BN1PEPF0000467F.mail.protection.outlook.com (10.167.243.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Mon, 31 Aug 2026 21:33:08 +0000 Received: from DFLE201.ent.ti.com (10.64.6.59) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 31 Aug 2026 16:32:45 -0500 Received: from DFLE200.ent.ti.com (10.64.6.58) by DFLE201.ent.ti.com (10.64.6.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 31 Aug 2026 16:32:45 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE200.ent.ti.com (10.64.6.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Mon, 31 Aug 2026 16:32:45 -0500 Received: from b-brnich.dhcp.ti.com (b-brnich.dhcp.ti.com [128.247.75.1]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67VLWbYc1545515; Mon, 31 Aug 2026 16:32:45 -0500 From: Brandon Brnich To: , , , , , , CC: Brandon Brnich , Subject: [PATCH v4 2/4] media: imagination: e5010: Fix clk never enabled without CONFIG_PM Date: Mon, 31 Aug 2026 16:32:29 -0500 Message-ID: <20260831213231.2125544-3-b-brnich@ti.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260831213231.2125544-1-b-brnich@ti.com> References: <20260831213231.2125544-1-b-brnich@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF0000467F:EE_|DS0PR10MB6125:EE_ X-MS-Office365-Filtering-Correlation-Id: 06f987b5-e997-4fb7-1109-08df07a77333 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|82310400026|36860700016|1800799024|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: jLZtbySZMtz5K9e8DzpkkOrHomq1+p1deLZhse48WaQjM4v5+k2+yJz/Lg0H5Eyqp0L+fF1BBRvXZ02M/6nsdUJHiM+N1q25HuEuc9sbaMOAb593w/CAA4vp6mvQZ9T9mhf7fVOIO35nE7reiDYS7OqCfo9xgwgii+P0Z4ndjOzN+gXkv/YWtFgcDvlpusx0kuKQBAdxRfMUQofj3scewKj9F47y8RUQpHvFVpntOUkeYNB1NmeJXeUVjV2E4VfcOAjw/kJr5+3aYa5AhMuRuT1tF1UK1OmfUc3FRP6CpUFTa37Nrx5HTiIalJFJioDVexuSijOA7Hhkvb4nk9nC9EN8h5Ln9dWyNdKZI34Cv2zot70zfrJvbV73ggzN5OJJ8ufI8Gpge+xKmRDYRTggS8eh501UpNCajsjxzVKZiSNPHoZYKpzSpFNkyGhL0tme9ffa5KG3UEdk5zryApEm9bvTRYYjQSquMgvWwwW7ZfeB7WIs2tkM8GM4v6ePOXuyQO/aN1z5bRTgsC+Z8vbPGDAJQSi2zLOrvSivH7YStNoaW6MgbQPIpFbj/ZywkN+38bGmTJH8kO2m3Hk4a/uc3xYTbycMz54aipSNIIliXrNx5a3dnZi7/a7XZ0NLfxKPxnYJ28w1qkx9DzUzpQmcVr81GBTkdG8nHql+xP8mFmxhePGdgZ2g1Hfhkid4ol2c6LoKtQcnfnOCgJIoG0pP+Q== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(23010399003)(82310400026)(36860700016)(1800799024)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RD4EqCHZSBz0ZEUv6Aet8GabEs4vWlGsQ0Dh0+lxzThiG1i/kWyc5j6pCGsJ9c6lDvxBlAUrMRyrj7X66g/RKUOr3jr6j344axcg4vORmK4u3t10Z2M5X4Fgu8p4WHKB4C7Tfalm5vlS5abGH17XZtVP3Z3zsEGI0Z3yLNZYYoGV9ang8SCHUWBk70eX6PF2QU59shE19tIgRDTkra4j8HWo5NP1BPFX7N41z47wGxCyX8NDUBo1k0tHA9peMMJRxlFo+0x1UwdV4d73xjsEi0zzY1pCuxfG9LlHqgElwgZLsS0IDiNAKnKKYUprGWomSuSOs4+T2GUXP3+ZO8OGW61XQE2Y2Ulj8uRouGQOH/cs6AXRkyR2Pcl+vHEu0ZDVz/jfEcXPsBRcU11aXQsxM/R9DimZyP9/XF/kcfqbsLPmsz0JwbMblRNgNCkKxIKZ X-Exchange-RoutingPolicyChecked: BkOPJr8bgIMU8vUORRAJlvESXtmnisrsu5Sz4OWcG+gYH0aYJrbOmuGkv6tSrv3vr4JbRsMMltikSYWSgQ+hgkeaNHVZJ8KTPoE6+K5Vj8ZcylslWgxk4YpiXo/UWpk2reFJiOhDYMvnH3cAG1HbCNQCH+nT6826cBbrTyiFrEeU8CwDgPb69x6ZRL38Q+YyMvne8ZlH7QoS5pjQk77yhilNTg2a1qf57R3KxVswTrJlWEJ/bRnL2BCws1J11eoWFMBiZbqVzUI1NfYg4yQDMIe5tPwQaZnkZA+fjJz7l3oU7tTF+wKdtjX0tjoCklUyCw5gLoGn4ErcnJutu3FhbA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2026 21:33:08.2416 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06f987b5-e997-4fb7-1109-08df07a77333 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF0000467F.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6125 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODMxMDE4NiBTYWx0ZWRfX7m+dyoICA06G 1bGKM1n1ZvoATC7mcEv7JIUT2/MG1djA2HE2kaUY7OqagtcqCgl4lnTwWP+WWwwnykW8FQYr287 yA/gvIY3UwodS+2XMjRe07EOc6QX9aZc/zhQAz2D6Ht351z9EajMqvkbidKT6iFhzcwC27Edz34 t50EMtmAEriv5LqVzVWW0CTYFp8krOPRcGcLsVWpAhHd+EsL0mu4JL6hpTDWmJ9qD6oSpGTwsDy hJ1RLzRQGDTx7AAzx8HD9iZM6ACVjGA7jygkYSKRQob4SFXGpPzN5DM+di0Os0l8dHDDuUcEF6x Fdc1+yrx5OZKnTtK6oJetoPlV7ka/XZktZE/anlWmN+54dNUeIXAzf7kEeGDya5rWPMvcKm07qY 7rJCHsR9eGEtIikql5pmWMC1Mi7QRTWE8i8s3/Ld5UYNB+v1SGLqANd6Y+/xYkx8TuvXEV8qFP3 xMTg1783IMgbUyzr8AA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODMxMDE4NiBTYWx0ZWRfX6eOCUzmocvwN bHwB1UBj4Ac8xW1DU7zQ1fS4OhMGUgGSxJb3HcJ0BT7fWaQ10okKF6fL52X9dtUbQv6prb/XTkj iOWj0orOJVbk0YF1fR0XZP6fO9arvFY= X-Proofpoint-ORIG-GUID: MK-d0XO1w-IRAUILTbW3CwogMDlg4P0O X-Proofpoint-GUID: MK-d0XO1w-IRAUILTbW3CwogMDlg4P0O X-Authority-Analysis: v=2.4 cv=LrSiDHdc c=1 sm=1 tr=0 ts=6a95f319 cx=c_pps a=QHQ/c+VJRs0sJIezHEQ2hg==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=VwQbUJbxAAAA:8 a=sozttTNsAAAA:8 a=-BWrc3HdS1PG3WIIs5UA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-31_06,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608310186 Content-Type: text/plain; charset="utf-8" clk_prepare_enable is not called anywhere unless CONFIG_PM is set. This means without CONFIG_PM, the JPEG Encoder will not function properly. Add this call during the probe sequence to properly configure the device. If video_registration fails after clk is enabled, clk would be left on. Make a label to cover this case. Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver") Cc: stable@vger.kernel.org Signed-off-by: Brandon Brnich --- .../media/platform/imagination/e5010-jpeg-enc.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/= media/platform/imagination/e5010-jpeg-enc.c index d3c11337c815d..e98fcd3fcd9ae 100644 --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c @@ -1099,19 +1099,28 @@ static int e5010_probe(struct platform_device *pdev) goto fail_after_video_register_device; } =20 - pm_runtime_enable(dev); + ret =3D clk_prepare_enable(e5010->clk); + if (ret) { + dev_err_probe(dev, ret, "failed to enable clock\n"); + goto fail_after_video_register_device; + } + =20 ret =3D video_register_device(e5010->vdev, VFL_TYPE_VIDEO, 0); if (ret) { dev_err_probe(dev, ret, "failed to register video device\n"); - goto fail_after_video_register_device; + goto fail_after_clock_enable; } =20 + pm_runtime_enable(dev); + v4l2_info(&e5010->v4l2_dev, "Device registered as /dev/video%d\n", e5010->vdev->num); =20 return 0; =20 +fail_after_clock_enable: + clk_disable_unprepare(e5010->clk); fail_after_video_register_device: v4l2_m2m_release(e5010->m2m_dev); fail_after_v4l2_register: @@ -1126,6 +1135,7 @@ static void e5010_remove(struct platform_device *pdev) struct e5010_dev *e5010 =3D platform_get_drvdata(pdev); =20 pm_runtime_disable(e5010->dev); + clk_disable_unprepare(e5010->clk); video_unregister_device(e5010->vdev); v4l2_m2m_release(e5010->m2m_dev); v4l2_device_unregister(&e5010->v4l2_dev); --=20 2.43.0 From nobody Sat Sep 26 13:47:23 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1041A3A6F0F; Mon, 31 Aug 2026 21:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788211990; cv=fail; b=S+lK6p6thO5bu7dO4hpD9YDshZEEuY6FpAalIkYeHZJrVO3plWNVrwmHmcfycViMFIbUOsRyWAEGP9b1Edz1fHzzKu3JYIcNUVDD961vAp4SdSc+DOVSIcW4Q2fRL1mNve+DnsnBCvdvW1JG58tfwXPttZ8X3dmPKviOXPJd9hw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788211990; c=relaxed/simple; bh=fwhXzJCdieu/sQuGsR8dOWnwVBrM/+Wje8ZeoAZaqhA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RePw2iftkLdBxsaop4S8KiHO05BQltwsjqY2W0c+77xb32ysmHBbHiv/e963e2+DBB23m/+r5TdH6pRK0u1lJjcjCzAK0h2npsVbhX3rNZ/KZf0qAkL+FfY7bVy/I2WiXjmZLDo1eRDOcMEAIQ+CnPa/yJMY9PGPvuS8baolwQQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=cJgWz4m6; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=lVJseC9K; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="cJgWz4m6"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="lVJseC9K" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67VIS7Kv1444698; Mon, 31 Aug 2026 16:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=H7Av2un0hSQlY2v3HvdY95V+l2YM8/WTm9OsUFD9d jo=; b=cJgWz4m66ZKI0NjDK+6tDYl1TxX4LKJ3ARhAOH8KCRZ7lFpYm5VrzZFzv AnxYgg84QVGKo+n3PqAcn0YiRQ8jdVSNfvNF6GfKFMeeH+aLIv5MqkUPdlfNcrx3 CPl0s0q0wcf5gEty56P0vCqzAaGJN34FDeFFIVZICbOcAbhFbuC122Ik2kfGKQ6v YSkG4/ClszPIsgELWKfB/RchTxwB+Mx3Zvpxp5+i5IjNYfySv7/K5k8vz3wwXhfY JPrGrIaLOSPlUrx34GqFiYe2yrI7+kmoUwu/X6RE0BduG/heFE5cxB6G61ac/VE+ IUCbYAEDKoliJsX5LTgJ2uEx76YHA== Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11011011.outbound.protection.outlook.com [52.101.62.11]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gcejq0yv5-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 31 Aug 2026 16:33:02 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fCVSxQkAYWT+LH6/ieudgu6Se7USF6wsJ6M2w++DDtWkzKKWAP5Uf1zdnKkj6u8AqCKmjoLHCMxN64sTtSc6XS1HzXbOotKr3PfPjqanJ4LviSRRQJ9baWRgu1958W4K6ywMYDZfFR0c1xSutws92qHHno+pyZ2CqPkyYFFoKOb6j0HX/LYsGG2AauyJ/MytYHkngnBGjTA4PYqZUldjQm+chK8lrOS/b4eZIF1Pt7JNj2bjP+/dO1JoAUPa/mqnoiwB3Ni21h1p7ucmco9Zjjs9UJ8yvd8cObjiKMckRSWyKUsfN2bw5cHbTK1EjoSnLGuSBlc3GvBFEfMV0BoPJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H7Av2un0hSQlY2v3HvdY95V+l2YM8/WTm9OsUFD9djo=; b=JheZiFZ0WInogKV8vhN3T83B1lmidjeI61aTGjHWscPSNfr0ZqpJQGxzF72oHyoo31+vqhJTJ6OHxuddzka6WdkXHyJdfdGVaHmFHe1phqIBySnfMrLOA7Xkg35mx4XzYom6zFyrNhclTiRL1tmMY5TKXBu2PemWHGuXcu0H9HkxcDDbPIhqWrUFzm00DsBdXLCnjJ/Ckre1c4B7mR09FKeGnsXHwwaFU+fzlh4COhaJO1ffNzQHQXrGXj+iLrP7W05IpBpvuQkc37jeDUri9YSxpi0uT9rtCYgTyzIS81zdhO4j62zSYjUrUwF2MJwOLEEttRZZq4NI7nUuyrmEDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=ideasonboard.com smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H7Av2un0hSQlY2v3HvdY95V+l2YM8/WTm9OsUFD9djo=; b=lVJseC9Kv5/hPAVHv2YfvBGytERGxloqku3/2ICv8AMuZPlcspzg/ZTgNCWjTnccUYFRvJ5yC5Kz8fIqnfcLfIEYcVChK+L4FpXYo8HrtEvjSG07Lhe4kocBQNIcuZ+cBaIxePRZBWMXZuDQnyZE2MCGUwI/dI8G3irvy0CFwD0= Received: from CH0PR03CA0442.namprd03.prod.outlook.com (2603:10b6:610:10e::32) by IA4PR10MB8688.namprd10.prod.outlook.com (2603:10b6:208:55c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.7; Mon, 31 Aug 2026 21:32:56 +0000 Received: from DS2PEPF00003441.namprd04.prod.outlook.com (2603:10b6:610:10e:cafe::12) by CH0PR03CA0442.outlook.office365.com (2603:10b6:610:10e::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.13 via Frontend Transport; Mon, 31 Aug 2026 21:32:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by DS2PEPF00003441.mail.protection.outlook.com (10.167.17.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Mon, 31 Aug 2026 21:32:56 +0000 Received: from DLEE205.ent.ti.com (157.170.170.85) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 31 Aug 2026 16:32:50 -0500 Received: from DLEE205.ent.ti.com (157.170.170.85) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 31 Aug 2026 16:32:50 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Mon, 31 Aug 2026 16:32:50 -0500 Received: from b-brnich.dhcp.ti.com (b-brnich.dhcp.ti.com [128.247.75.1]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67VLWbYd1545515; Mon, 31 Aug 2026 16:32:50 -0500 From: Brandon Brnich To: , , , , , , CC: Brandon Brnich , , Jai Luthra , Kendall Willis Subject: [PATCH v4 3/4] media: imagination: e5010: Move e5010_init_device to Runtime Resume Hook Date: Mon, 31 Aug 2026 16:32:30 -0500 Message-ID: <20260831213231.2125544-4-b-brnich@ti.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260831213231.2125544-1-b-brnich@ti.com> References: <20260831213231.2125544-1-b-brnich@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003441:EE_|IA4PR10MB8688:EE_ X-MS-Office365-Filtering-Correlation-Id: cf049009-7174-40d8-b4bd-08df07a76c06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|376014|82310400026|1800799024|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: jiw4bSE7aKhsQmetwoLH8m4JLIQvJXICozCj7GqKm+io0xt0f3HUp5bNchcFT+j2YgiOsdoS7vwApIAUofuGNzzKabd17BrX67BxVEvsLlGX3t5SQjubPCPvuBzMVApbwBY58kX99g2uA4+ZiM5AXr6qsneTaLHN4CvVX7w/yksvSbKDqj6RE4nieVXdiWQcoPNVV+Hsdd0O3U1OfurmY6bXM6fyGr3b6T40+Q13Jv3PriY19iTpChOq6vYykL6EeJEMNjNJxjFnAgIZ10Za5sis/IOuLzQIb59mT6U8dLhDJAjKTjY6w7DzLru2iHd5QBD/ShuPfmz9GnVG925OW8E4bosJweN6w+9NA06F4r7c4ih0CYy7w5aopIrS9S1q5mjXoswMUGx0dfY+G7d5zFr2AszN8Ll3yF0q61loAP0+as7BGnWcjXVomL474Rr+aN6UGBZirSO+ceUvTqlmkyzvy4fHCxHFbtfAdyntzrvF1+zH5osoT4sOE2dASO5lJb4OSRRCLKPgEpH5k9uDfhTaHowgxizCPj8xb3KlQNfHVK5zRBn72wORXUUPnVyjQy8F2pVvA2XhKYmaXeb36V6xFnFwSZ+UnVb7ruJlivNQyGCr/ez4hIm2YhuvWf30FsNllgmV8xj2mS71hLE/sBLPfX0y7ly+FaIE+7wFGdns4OJu3X/nr9DcoEV3XyrLP6+yqWDo/dK6m+pXSLhRmg== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(376014)(82310400026)(1800799024)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OKOtyyKDvoBMRKnlZUxGeq6TTK58CbeaIwNGVeBrtigw0WCIZ7ZqrToU/7qvwV5RDrlwwji6dupbhIdemxOz/M07nfEqufMtnpkvO1s5DRo6k59Gc5vI+Qgioq4TT2L9UU5+IdWR22h+6CCHA9wzwEOYxjioxD1qh6JGltNo+6m5tV5nDSZIQUYZAmiJXp0zWpH63LAvCLAZMEux3+kynIgcF16nIBpbAEJNNUI5IacNl8E2eFLkPhH+S5khays/+obQrhF5Lb7BlpOFJh8EQlbpQ1WRxLCPR140bp9SlrydKdfSFqGD4nAOb8H4yWCpQGnA8Nvhm7qDqVOwoBJK2f6r//DD197MWs0fJMkQgEs7mNOJehPpVy2GIliZqwUnSWOwP5CQY+8dWTxkDoKic/Xnk7TPAwAN3tb+WNGLnEYhfalvBwWylbLOiZ/n0E1N X-Exchange-RoutingPolicyChecked: xbHPn6bHfuQDc5o8ZPvIi7YqMwLB3/FygD6XjRkyDY94Pw0vQt7eD0EDAJ4JSttqFvEi2im34RE3w+8G/nmTG51biSCU112DIy76E4vYYXZ661thSvwo0PosKd2VoB5zBqlQAILkSQ4y2GgcmMCVBDMu+DGq2x/3nDx74l148UbmK78KSNmrdXHvQ9ZTDs7X8XP6rGoLPhgO3av7ywsm27MP0LkZjwzTsQkmalxxVp4oOI2hTU69CDmkEp/M+8oHvGxTKW4a2Ei0pr+NYdHCaKegNw1CMCmq0+xg+UyabnLDdUBNzvm4jVjsm7TSptEhEY2Oz6zcQ/sZiiw+VM+gmw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2026 21:32:56.2253 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf049009-7174-40d8-b4bd-08df07a76c06 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003441.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR10MB8688 X-Proofpoint-Spam-Info: AW1haW4tMjYwODMxMDE4NiBTYWx0ZWRfX+ncoSDLjtFux 1H/77jQ7oytJozRZ0i9TpzgfXQQ9e1pn4+mMbMXrsR11xMqsnEXoss6QSbsSfV/pcQfJr0h4HCC 0L37aE3L/SLvH567zf8h1D9fkwH40gY= X-Authority-Analysis: v=2.4 cv=b6eCJNGx c=1 sm=1 tr=0 ts=6a95f30e cx=c_pps a=TuoCv7SfN2yFw/uhdbj5/Q==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=VwQbUJbxAAAA:8 a=sozttTNsAAAA:8 a=P1BnusSwAAAA:8 a=UlmMjaRoNFhtWZaF8JoA:9 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODMxMDE4NiBTYWx0ZWRfX7A7PsATaKWAY j+Bo8RENS66bOgtO+0BNCFTH6pWcHbyaef9Pa3HF70ulDLY0OPWLq5HOKEFjkNeFkn/KzNb6bI2 NH4WvP41YMx06tQNiwe2PGyILgm3iHD6Q6K2L8QsCEY8F2qEOyMPKaSr3gJL88dj7tuODbHNW3y 4lZUsxl3TZULRexNdcKcPaT1rv0UQlkxmt6z13cwPFuPQORsuQMdObaxhojQa0GOB9mUbW9viXO NH0JCcw1crfJM85U8WciSWgBMZqkSOZYHWm33dKWYittQrmaf42piedX7Rfk5UH/9IUQlVE6J/s 6ONpEClCMMqY3MAllgQIw9s3YNVzlODDkuF8r3zD8eJOLIlK/E3IbcnAqxfGiFy14l4O6/i0Abx ifgUDt83OXAPczrXhTsJPR9RWfqE7EF+h4JfzTT852EjUAV13fQbNWrymEzqr9IN2bkxpUpEa8/ yuk6w+XD2T3/qOAgCmQ== X-Proofpoint-ORIG-GUID: CsCd6Jkv5j492bSSebJ12_P4MiZdqVXE X-Proofpoint-GUID: CsCd6Jkv5j492bSSebJ12_P4MiZdqVXE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-31_06,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 bulkscore=0 suspectscore=0 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608310186 Content-Type: text/plain; charset="utf-8" The PM framework skips the runtime resume hook if the device was never on in the first place. This results in a crash in the system resume hook when a call to e5010_init_device attempts a write to a powered down device. Move e5010_init_device to the resume hook to ensure register write only occurs when device is properly powered on. Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver") Cc: stable@vger.kernel.org Signed-off-by: Brandon Brnich Reviewed-by: Jai Luthra Reviewed-by: Kendall Willis Reviewed-by: Devarsh Thakkar --- drivers/media/platform/imagination/e5010-jpeg-enc.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/= media/platform/imagination/e5010-jpeg-enc.c index e98fcd3fcd9ae..488f5d7e4c9d5 100644 --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c @@ -1511,6 +1511,13 @@ static int e5010_runtime_resume(struct device *dev) return ret; } =20 + ret =3D e5010_init_device(e5010); + if (ret) { + dev_err(dev, "Failed to re-enable e5010 device\n"); + clk_disable_unprepare(e5010->clk); + return ret; + } + return 0; } =20 @@ -1543,12 +1550,6 @@ static int e5010_resume(struct device *dev) if (ret < 0) return ret; =20 - ret =3D e5010_init_device(e5010); - if (ret) { - dev_err(dev, "Failed to re-enable e5010 device\n"); - return ret; - } - v4l2_m2m_resume(e5010->m2m_dev); =20 return ret; --=20 2.43.0 From nobody Sat Sep 26 13:47:23 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD90733A9E8; Mon, 31 Aug 2026 21:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788211987; cv=fail; b=nhuYAScaewsq7wN2lBPu2QBZb+WMdZLV3B3qYNDIJCUzZFl83MQQL/G1+hh81Q2tGt65ufHWrNQcyDHflgx/WgMqa1Uf+0Ja0ihveBExXN9Q2VbqB9yHzj/1rQPi69Es4IrqL4JYDPcLMdxBZ3UoX/p4I7FL8zsfCN/HR4r+V9w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788211987; c=relaxed/simple; bh=XI7yhoivd+/OWcad1HHdxRk5ehx86FBYfYtBSs20pWs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G41x7QTpFP39XVtHTc8PqUd/hYBjszSksDPD6/xbuJwsZW3IEYxoKLGV7gB1sVzhq04nKUP9m7V16lV/4ku0crneKNTYk/2obh85CNIasMZyWv8AvtZMj07u7Gqntuv2aAhPfp0HN7gQTietAq40Ht2GzzQ5uoznpb3KmrprKcg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=ICTqbYdr; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=XXnO5MEE; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="ICTqbYdr"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="XXnO5MEE" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67VISRFL1813419; Mon, 31 Aug 2026 16:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=yZW4052o6BlyNaA+pElN/rpteBva6ayyzACDzx5Og z4=; b=ICTqbYdrDdU/Y4DVYP5tvEPPV1MM5BvCAn8RfQ10RRaywEFFbwQJWpf4k XMyxqt4Kc2AlNMlyG7+T807Q9hlnp+9b2hat6OYPUNHymD/9FSLx8ZYcLoE7GTJ/ 1lQO6vo9Z7k2IQM20gE6/9ScIokn6V3HdhsJyTznzdiogV4jH2eCXl75oWf+XOrc i66kkHaITPnvqjvYpQAAZ4eQ29q9vf7G049nNsISJT/+krrc4VI18MWoCPwjAmBj B70qsA8PSFiSMEhPtjHnp5YKTcBDRxomp/OFkpkBwto6v8s0pfJLVLv9CwFnPC39 kNmjKhxuzEDq1MCbhnXP2yewUBfZA== Received: from bn8pr05cu002.outbound.protection.outlook.com (mail-eastus2azon11011041.outbound.protection.outlook.com [52.101.57.41]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gcet48tsv-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 31 Aug 2026 16:33:01 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cAFUpYaimYG2nb1Hcj8snkj7mJxGtHfcsURfC7S4WNVPmKGBPzRUj6c4HWQLQgexOvpTP54qrlqh9t+AiqgwtSjpkc+MTR8bGAnhjb7TXrT3NV5GWdqJSrNxkDGE/WU8yYyanUmRum1YIRtowsi465d+1vmaw/hRRXPPS8oDC3gSmmcXbGBtKeA2p17mcOloQHmjv8StLiY8BHtnsoOeD/aJUPNR8YFlGLzdWp4QigRzlHwFVVky4exyacG8FUCPZH6f3d6NQA18e36QWoDY/JTsZmHieUpUTzQAldT/M69g/+LJWDypqGbadiYqzuiXiKh5LT1jpBTaD8xz+DrleQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yZW4052o6BlyNaA+pElN/rpteBva6ayyzACDzx5Ogz4=; b=c9kxYb4aNHIS4EnoRE+pDpVSlQgwOj0JYOC77yV6z3Yq5GfoaSl2rMRhetcevJnlp0bhO5Y66/smvtRrnwdlMn3SrqUQ6x4GnlSMF8RX92PfY1MolnwMe15sTEpECPqT6r7EaWulWa1gj4Z+9xDmIYV2a0nXvgYD5BwiGmKnAZxhYiSllP7zC96mYTWCjvEu5mrLHds05ggm0oOuImJOt+IHFn8IZ0iCBfinahIw6PKd0A4rTp5F+M9jouTh1J/fyIg3EaTtlZzHb09dzeibkllKeq2Ma5D/DJRvsbW4JoFSLZDoHlCN3srNj4vOIHha2elAWTFOPB2d11fvp3Wiaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZW4052o6BlyNaA+pElN/rpteBva6ayyzACDzx5Ogz4=; b=XXnO5MEE4SwUdGWYW40rf/PZP0zMGkcjRJLyleqFgi851btXGVRxi7oRpBbUX66KnfWiUvvyLwZRuq5oEcCu27miAj+TOo7VzVk6JpX0i+97a21rC2a2G9AzZLObjyhoqw1UxwjbBEPi00CwNTI2CHgKfCd3Q1uCPqoqKeVvQtg= Received: from CH0PR07CA0007.namprd07.prod.outlook.com (2603:10b6:610:32::12) by LV0PR10MB997564.namprd10.prod.outlook.com (2603:10b6:408:344::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Mon, 31 Aug 2026 21:32:58 +0000 Received: from CH1PEPF0000A34A.namprd04.prod.outlook.com (2603:10b6:610:32:cafe::1b) by CH0PR07CA0007.outlook.office365.com (2603:10b6:610:32::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.13 via Frontend Transport; Mon, 31 Aug 2026 21:32:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CH1PEPF0000A34A.mail.protection.outlook.com (10.167.244.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Mon, 31 Aug 2026 21:32:58 +0000 Received: from DLEE202.ent.ti.com (157.170.170.77) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 31 Aug 2026 16:32:53 -0500 Received: from DLEE208.ent.ti.com (157.170.170.97) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 31 Aug 2026 16:32:53 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Mon, 31 Aug 2026 16:32:53 -0500 Received: from b-brnich.dhcp.ti.com (b-brnich.dhcp.ti.com [128.247.75.1]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67VLWbYe1545515; Mon, 31 Aug 2026 16:32:53 -0500 From: Brandon Brnich To: , , , , , , CC: Brandon Brnich Subject: [PATCH v4 4/4] media: imagination: e5010: Enable autosuspend for runtime PM Date: Mon, 31 Aug 2026 16:32:31 -0500 Message-ID: <20260831213231.2125544-5-b-brnich@ti.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260831213231.2125544-1-b-brnich@ti.com> References: <20260831213231.2125544-1-b-brnich@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34A:EE_|LV0PR10MB997564:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f22d0db-249f-4845-a8c9-08df07a76d22 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|23010399003|1800799024|6133799003|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: hZPcnKU9kFaIaN+OxXNMKL8158GZU3q6UZhu8aSajTmzoCGzTnW1DWhxU+0jqRB8Jp++AkaBy5bI9awAGqNj3l50DJEINOzdqPaOqg2WpbkU9tgOXhJs8YVxFbvFpZyW9g3bL2E3mWIQks3tgdN6Ib5/5PGxaTG8FwzBiBBbenTT5oGiGeiIedubPzrMIy/sR4no/q6W0s9KymLKojieMG+AMjWM+Fb4ATlY7D7jfMF+jUaYdeXc0JwURbE6j4dT/vaX4rO2mN5soOGau2y4x3xIpQQe1Vr+bKSLefURj6MX6iuL78fhyu4C+whVhqbeMsFm2pGcbX5NXloqZb2vKWOpE25in8DsqgaCd+tn01n71KSkduu/a5VyIvQnDxCc7K88NjOe0v/A2HVflbb6lXE681yyd29bvS1w6n1cywLI+1Osu5t4VTuw/L7o2Mgd0hyNuep9sqtyn9VEM/YwcplGW7n+MqrN9IH2eD6VbJmfMnRazjvz3vpsgM0u1J5ER4Qu1lUUXQh56zrwhnu1/qNOjAPfHgt/9JgItkuYox01XEcs8HUon7oFER4F0MZX+i3Nhcifb/F+MzbYRXXRDl+vHB0yKeoLH3Bi4iCyca/LXkTJ1EMwfJUvOCUy1P+J3dfmWvz4dVC1/RjdX5wLOGb1ZhPRDZpX3+/ofKJri+6z/ZxDQHIIxtinRch0EHcHiW8vEcJfRk5onjQBFtRh3g== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(23010399003)(1800799024)(6133799003)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UTG8RI0zgXZGSScHCY0d6tcHqHVC9PF5WRL/CF8+TZ1ztsebWgV958VKv+LPiRTynISoVTzrLx5LjXwBw87hGyQo7kCQv992S+4+F4/nqcN+pZ8uuBZm7pLh8V/yW3Q37qX5PZ1Yl8nlK720juN+ak8fAhRXCavGH4P1RMMcWuYTpFcp7274HqMRTuzsZLIBE9G5PRJds2ZX170TX7UXR7CDifAJHHM+hNjLPaeIFRQY/BbjCkRx0yT6HnzKEuKnI9p7NRqsZ9QoM1aTd8KD18HSF1a+Jf9kadYZ9NOXYLF/2xD07QFdd1rEY+dxUVMeDVmXnyMsIfpuYjy68SO1fvs0vhQaVXnNEA3eTbsxplJvhZ9ai6niYovhRewuRUMmIXjp2bRIudXmUlUQlqBYKAzUKVYZuYm9JSBQGPHqrWmOUiqiOx5TRXcbac+WAhA/ X-Exchange-RoutingPolicyChecked: O7WqQRIyJ1aNCf/OMpAqCWTAXS+sUwJCE8Fd1AI2nJHLx7kY9nnqH9qSjCGQKp8Yoknusj9Aye84wxcIk9dJCBgaDrWavmM5AhCyJTF6fvg9Iwu6/d211RFIpEmYV1THbUvZh1vpLxTh1N1RYSrcnpHBXwAPcqc9eTc25dN5nfY81J8Jd6qshI231GenyUzfeyY88ByC2n7mLmA5jrMdPRcRP9ucHKLrvrrArDenaRArwL57exROsCqbfh5mhbmoczzagnAkl07Pk8eIKc9/BlHErAH7tIzZwC7T5TcMOzcIkWGYE0AGnfHSid2tR/ddCpIRz4jbMXctg5g0nGrwcQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2026 21:32:58.0857 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f22d0db-249f-4845-a8c9-08df07a76d22 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV0PR10MB997564 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODMxMDE4NiBTYWx0ZWRfX9Ui8j3pcYp4S UkoI6vpDJ0nfFKKtzpKkjypmopIFIQVCA+nrPHaHkEv7f2CdcGAODr59I43JiyVx6VVgPaomWgM tc598Za2mTYl0CQV945rVQuXvB92NIvNklkSuaowlCL0k072ek96SuJOBcR0bZOAZC0+SSQeXE2 GT2Zi5kux72+pYXmOWllLoDlf/uAjTo9NRsUxguhG8PZzV5dy1Tq+RdMKZMcwz0Lq4p7N04iigz qU6xOLSBJv6DSlzVZVaKdTTHjr7p6u72tsdrpJ8owZ6AI5x7v1zRLgMx+cGy9I+xWu0xZi6j8cH eWBfS0P3Hj2b9O2+3g4j1Uek9fu255CjAEL5SJ1Gq0exT7oy/b2gQueHOYHiY84RHGEO9DgXUyc 8wpfOPFH63R1QTc1oZBaoHXgg0Xf/YNva5jRRJj+7WYX0w6yTlwrbRS+5hM5U6w3nj63nF8nV16 NlGD85/N247s8lY9S2g== X-Proofpoint-Spam-Info: AW1haW4tMjYwODMxMDE4NiBTYWx0ZWRfX3Wog36Pk4nSv ZPzZcogbavQnSCq1Caj6oOVD2BsXpE9PqtuSa1FREqGjHdPyd5RvkSxf166M9Jqq0e2mu7nhQL6 03tYGLt/DqgUTEkiZfPwCHq0OknM8tU= X-Proofpoint-ORIG-GUID: weW5-ec-63AhF2ZHYNmomGddeYrJItdM X-Proofpoint-GUID: weW5-ec-63AhF2ZHYNmomGddeYrJItdM X-Authority-Analysis: v=2.4 cv=LrSiDHdc c=1 sm=1 tr=0 ts=6a95f30d cx=c_pps a=QmrQXVULtgJTkzLS4HxzTg==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=Gi_RKHrbGS1op-ALBdMA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-31_06,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608310186 Content-Type: text/plain; charset="utf-8" Current implementation only has one call to turn the device on - start_streaming. This can waste power of device as the device can be in STREAM_ON state, but no buffers are actually being submitted. Need to set last_context_run to NULL in resume hook. This will trigger QP value updates during next call to device_run. Signed-off-by: Brandon Brnich --- .../platform/imagination/e5010-jpeg-enc.c | 41 ++++++++++--------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/= media/platform/imagination/e5010-jpeg-enc.c index 488f5d7e4c9d5..79347014562bd 100644 --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c @@ -976,6 +976,7 @@ static irqreturn_t e5010_irq(int irq, void *data) =20 v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx); dprintk(e5010, 3, "ctx: 0x%p Finish job\n", ctx); + pm_runtime_put_autosuspend(e5010->dev); =20 job_unlock: spin_unlock(&e5010->hw_lock); @@ -1105,6 +1106,11 @@ static int e5010_probe(struct platform_device *pdev) goto fail_after_video_register_device; } =20 + ret =3D e5010_init_device(e5010); + if (ret) { + dev_err_probe(dev, ret, "failed to init device\n"); + goto fail_after_clock_enable; + } =20 ret =3D video_register_device(e5010->vdev, VFL_TYPE_VIDEO, 0); if (ret) { @@ -1112,7 +1118,11 @@ static int e5010_probe(struct platform_device *pdev) goto fail_after_clock_enable; } =20 + pm_runtime_set_autosuspend_delay(dev, 100); + pm_runtime_use_autosuspend(dev); + pm_runtime_set_active(dev); pm_runtime_enable(dev); + pm_runtime_idle(dev); =20 v4l2_info(&e5010->v4l2_dev, "Device registered as /dev/video%d\n", e5010->vdev->num); @@ -1299,31 +1309,13 @@ static int e5010_encoder_cmd(struct file *file, voi= d *priv, static int e5010_start_streaming(struct vb2_queue *q, unsigned int count) { struct e5010_context *ctx =3D vb2_get_drv_priv(q); - int ret; =20 struct e5010_q_data *queue =3D get_queue(ctx, q->type); =20 v4l2_m2m_update_start_streaming_state(ctx->fh.m2m_ctx, q); queue->sequence =3D 0; =20 - ret =3D pm_runtime_resume_and_get(ctx->e5010->dev); - if (ret < 0) { - v4l2_err(&ctx->e5010->v4l2_dev, "failed to power up jpeg\n"); - goto fail; - } - - ret =3D e5010_init_device(ctx->e5010); - if (ret) { - v4l2_err(&ctx->e5010->v4l2_dev, "failed to Enable e5010 device\n"); - goto fail; - } - return 0; - -fail: - e5010_vb2_buffers_return(q, VB2_BUF_STATE_QUEUED); - - return ret; } =20 static void e5010_stop_streaming(struct vb2_queue *q) @@ -1339,8 +1331,6 @@ static void e5010_stop_streaming(struct vb2_queue *q) v4l2_m2m_has_stopped(ctx->fh.m2m_ctx)) { v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event); } - - pm_runtime_put_sync(ctx->e5010->dev); } =20 static void e5010_device_run(void *priv) @@ -1353,7 +1343,15 @@ static void e5010_device_run(void *priv) unsigned long flags; int num_planes =3D ctx->out_queue.fmt->num_planes; =20 + ret =3D pm_runtime_resume_and_get(e5010->dev); + if (ret < 0) { + dev_err(e5010->dev, "Device failed to turn on\n"); + v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx); + return; + } + spin_lock_irqsave(&e5010->hw_lock, flags); + s_vb =3D v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx); WARN_ON(!s_vb); d_vb =3D v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx); @@ -1484,6 +1482,7 @@ static void e5010_device_run(void *priv) e5010_reset(e5010->dev, e5010->core_base, e5010->mmu_base); =20 no_ready_buf_err: + pm_runtime_put_autosuspend(e5010->dev); if (s_vb) { v4l2_m2m_src_buf_remove_by_buf(ctx->fh.m2m_ctx, s_vb); v4l2_m2m_buf_done(s_vb, VB2_BUF_STATE_ERROR); @@ -1518,6 +1517,8 @@ static int e5010_runtime_resume(struct device *dev) return ret; } =20 + e5010->last_context_run =3D NULL; + return 0; } =20 --=20 2.43.0