From nobody Sat Sep 26 19:33:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 294BE3B14B8; Mon, 31 Aug 2026 10:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788173491; cv=none; b=MscIiJ0zrnPJ4qyDdY9km2nuReMkHe+w0dkCGKBuhkxzl00jtifbXPUoiVRzHLS//dve0DUYBsPnp50Y8pkKmaOQUaN7KVLOtyuGRFO4dfZww8uYwiU0r5JvxUb8z17LGxhggMbTXYH+H1uesdwEwuBOZR+R7w6evJBaBJyywJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788173491; c=relaxed/simple; bh=DRGxPsf3QJ/4dYZ5B1KOYT5N54KAXh1btjSxdomv9XM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q2c7gmUQ2Z5ycv1V3tbX1ohrP1L8Bml88duID4P9NqdLw/NbN9ok42fyap6yroFq+adeVF6kvf1T9fZ0+VrSgzjoGosFgN31/6gTkjy/xsQOFtDMoUtXUYjvMnkddTpMVfj6Ex+ZSWl709Ara4nqunPnsUUBWqGrner0QI4brVc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B13Jc/Hw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B13Jc/Hw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C8611F00A3D; Mon, 31 Aug 2026 10:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788173489; bh=7hL/ET5Qq3wr2P6zFL5txI55cnVWQQzZ2F/qHg0lYf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=B13Jc/HwFvJynvpEddSdAjEGRTOiABRThBqmHHiE/4AiD0iQWYf3HCX//4rHRXK8I gLVcoEf9n+ORgiBBpUVy2G0Zq8Wm4m0BykmnRfURD7sCFSidGdfPcF8IboCQB2JFAI pJEqB1nMiACdRRQUBzV2PVPcFgm90SOE5Ho7YmlmaRbaRQtvOpvNjYol1CIc9hNaIV rfC1wVbiQTl/bE5QGaLNmMcLxrRAtUnwzlX8bn8txjqLqOQI1+0/CEmJYJV2LpNy3D AlS5BnRLIp5/un54LIxa5UGIhjYg2JPAwnxOwmzuYbSRTsXwPbzR5xY6AXfyDxBN5R iDyF20bOAh7zA== From: Conor Dooley To: linux-gpio@vger.kernel.org Cc: conor@kernel.org, Conor Dooley , Daire McNamara , Linus Walleij , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Valentina.FernandezAlanis@microchip.com Subject: [PATCH v1 1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output Date: Mon, 31 Aug 2026 11:50:57 +0100 Message-ID: <20260831105056.756259-6-conor@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260831105056.756259-5-conor@kernel.org> References: <20260831105056.756259-5-conor@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1029; i=conor.dooley@microchip.com; h=from:subject; bh=uG6lbsSheysd9Z70Hex7XhWgc/RhjnhbE9NFxwPVduo=; b=owGbwMvMwCVWscWwfUFT0iXG02pJDFlTY1b0z56vuP7oswNFk89+4Vs38Yro1riYH5NChI+bq 3oEfIma01HKwiDGxSArpsiSeLuvRWr9H5cdzj1vYeawMoEMYeDiFICJTE1hZFi8KcpY3XCdUUaX 68S3s2s4Wpdq7FX9rSHM5L/opN/DuYKMDHf3ffh9imuCb9Y+FpV9tv2BXTo9PIflX6ScYlqa2cZ 7gh8A X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Conor Dooley The printout from mpfs_pinctrl_pinconf_dbg_show() is appended to information from the core, so a leading space is required or the world will end. Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver") Signed-off-by: Conor Dooley --- drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c b/drivers/pinct= rl/microchip/pinctrl-mpfs-mssio.c index ea1026a0d22c..502624221aca 100644 --- a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c +++ b/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c @@ -612,7 +612,7 @@ static void mpfs_pinctrl_pinconf_dbg_show(struct pinctr= l_dev *pctrl_dev, struct reg =3D mpfs_pinctrl_pin_to_iocfg_reg(pin); offset =3D mpfs_pinctrl_pin_to_iocfg_offset(pin); =20 - seq_printf(seq, "pin: %u ", pin); + seq_printf(seq, " pin: %u ", pin); seq_printf(seq, "reg: %x offset: %u ", reg, offset); =20 if (reg < 0 || offset < 0) --=20 2.53.0 From nobody Sat Sep 26 19:33:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 876853C1F41; Mon, 31 Aug 2026 10:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788173494; cv=none; b=sQP/WN0shAwDiEpGy+L9otvWyBtf9Uhm9LYLaoK8fC2yiHMXRoW0dlUacU9IHUtET9kzmv81epP2NdupIFut3HtTICCUzatMjPWkmkarsgOarBM0i6+p6VBEF4ru3UdAHlbQvrdmPp++5HDo8OvovPOm0F2ytpia981HafS2ZEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788173494; c=relaxed/simple; bh=5KgSygfc60Vc+faLJo1AGvihW9k7uqGpPOlyPBVQiQ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EqQtO66ST2nBPVd7tDP1nra6emAx6A6DYAOsNdpR5GPflsTbCSu48zo4rxlRrEQJHGdOEGutCZmYF3+X7Nt2CCAPtBmlx23UtObo/J4+g6shqFXpgiv3apsVYjrCMxIzzk4gsLA62fAC6j73ZhIwRkgrGAFxxg/J1vGTEz8vM+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UbJy2JmT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UbJy2JmT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31D851F000E9; Mon, 31 Aug 2026 10:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788173492; bh=/83joiCqy3bsVNmIOD4slIc2iG9I+Ggc1WrYrebcBzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UbJy2JmTMoekm2chm/lqgQMBIX0OUqgcusqVxPZlbfPU12hTQaZNB8OtIV6Eb5UUK M6Ckd6IOGgMLCIqF3h7mVtIvns2sFN0pNStQaKuKi0ehLjgGwO1mCpYEPWwp869hUF IHUjmPPG8D8k32DR0rzimyflarjOTt4iiyEi2njGtkSDSzGAhcJ35CxNzXKfOlLe4T T6tE98wN/wRDqwOeUaeBd9zqqj0GcEZehKPlMLHuJ0ay/KPUTYrrusXXv6QkQ+JZSl s1gFwAAD6esAjztlZtQYQ1FxLpclZiQ152KHPwlF+EMobBr3n5Ec6FqcX5RPTQin62 EdfntawphHOMA== From: Conor Dooley To: linux-gpio@vger.kernel.org Cc: conor@kernel.org, Conor Dooley , Daire McNamara , Linus Walleij , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Valentina.FernandezAlanis@microchip.com, stable@vger.kernel.org Subject: [PATCH v1 2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting Date: Mon, 31 Aug 2026 11:50:58 +0100 Message-ID: <20260831105056.756259-7-conor@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260831105056.756259-5-conor@kernel.org> References: <20260831105056.756259-5-conor@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1093; i=conor.dooley@microchip.com; h=from:subject; bh=ef5QyPGGJU2n0wuvE12uE0SJbu4v0TW83f9BsxA1PHM=; b=owGbwMvMwCVWscWwfUFT0iXG02pJDFlTY1bM/5H9KvvpciHjyzcyD2zaF6WycTKHYWyN37HLU svfBhTM7ShlYRDjYpAVU2RJvN3XIrX+j8sO5563MHNYmUCGMHBxCsBEThQyMpw13dK4m2dap+WD 7m+Ch9YfaXex198kqH/8Z3deisf0yFuMDMvvaJ/6JTtvuvoSe1cN/3N981xO7rLZw63CExty7NS qAH4A X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Conor Dooley The bank voltages are only 4 bits wide, so when a pin was unused the driver was not correctly interpreting it as being at zero volts, because the driver's value for unused had two extra set bits. CC: stable@vger.kernel.org Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver") Signed-off-by: Conor Dooley --- drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c b/drivers/pinct= rl/microchip/pinctrl-mpfs-mssio.c index 502624221aca..9e6d233804cb 100644 --- a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c +++ b/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c @@ -86,7 +86,7 @@ static struct mpfs_pinctrl_bank_voltage mpfs_pinctrl_bank= _voltages[8] =3D { { .uv =3D 1800000, .val =3D 4 }, { .uv =3D 2500000, .val =3D 6 }, { .uv =3D 3300000, .val =3D 8 }, - { .uv =3D 0, .val =3D 0x3f }, // pin unused + { .uv =3D 0, .val =3D 0xf }, // pin unused }; =20 static int mpfs_pinctrl_get_drive_strength_ma(u32 drive_strength) --=20 2.53.0 From nobody Sat Sep 26 19:33:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2487331ECE; Mon, 31 Aug 2026 10:51:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788173496; cv=none; b=lVVA+9s24hKPgyBq++BHP0U6aO3vHFJtpjQMokTZ6O28LGvp/vCA4nSof6yZVaT5Ir7/pOATUrGVWda6yqMwlVrZy9sXYGVLSdwaLFhkZYZSsYWgttvZusBMalyfYwl+HgzBPwwbIAmzsS/kZWlaeIf0mTgkaRFJZNs5BrIKA7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788173496; c=relaxed/simple; bh=1niTMfBLzbpsiIzfN+AYwRqUvyi3f3U8pFVTukwIqP0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jQr3kkYE9VG/yZJ5z1QX67fcurW4V4Ut31DMBTk13/mOul+79AkaaOnkfWQI2XFuJ2HqG8LqtxBX629fvgLKJRGHh5jkosQzrgnsK891q2Vuk0F0pZ6KZ+80Wn5ykz+197b3O7pvgXaM9b7cxpEV3nlQnk3xGGY+lgua5f/B2yM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K3DeXQtI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K3DeXQtI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FA601F00A3D; Mon, 31 Aug 2026 10:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788173494; bh=rR69ic9FQZSapE5sg/ABBzxhACPJIL3BPm0zD8pyE60=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=K3DeXQtIfnUV5+F5oMPHi9dhGZB+kNoIBsw+ZHnl5BldpgSE0cnGHeZy3LNq9WV3u VpjaqydyJ0TxkVXNKNd2ENMGt4o/OnMtdypV+iUgyGlbifQD+m3/k6B+qCRrcx8PuI XLScuN2XYZgCFwu7OSuX7p4eUO05xggujeQaYSPuC8iHvCyQiWD4vKXLlBZJXjg1d3 0qHNBzCz6YNLbak/45leEF6iH4aUDgWZxa8df8kCgI3eymfzHwvUrUnv7Dx1O35Qti v0iOHLnNNajS7nGsuWgdsO2QdkapnXLlMq4ONQEcUXmMQcTrp9KrZMGPyuSKqC06a4 dC/RMRdhF6Gyw== From: Conor Dooley To: linux-gpio@vger.kernel.org Cc: conor@kernel.org, Conor Dooley , Daire McNamara , Linus Walleij , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Valentina.FernandezAlanis@microchip.com, stable@vger.kernel.org Subject: [PATCH v1 3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage Date: Mon, 31 Aug 2026 11:50:59 +0100 Message-ID: <20260831105056.756259-8-conor@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260831105056.756259-5-conor@kernel.org> References: <20260831105056.756259-5-conor@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1466; i=conor.dooley@microchip.com; h=from:subject; bh=iZ8hHPxlioduqcAJXU0xpcnuVbcgYDtpROhjkH9+UbE=; b=owGbwMvMwCVWscWwfUFT0iXG02pJDFlTY1b8MahoOJg09c0qG1dtpzNs95RSmBpvnjb+WGok0 LZ2ttTyjlIWBjEuBlkxRZbE230tUuv/uOxw7nkLM4eVCWQIAxenAEwk6CrDP6U0B2fGNJ7+Sewn 1J22HWR8N+l+3XRD5RTTK4E9WVv1/zAyPE27+uaO/AfXvtSVO5oFy7cuOrlQWP2t1QHxHtOJMw3 YGQA= X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Conor Dooley regmap_assign_bits() is not the correct function to use for an RMW operation, as it maps to regmap_set_bits() or regmap_clear_bits() and the former will never zero a bit. Use regmap_update_bits() instead, which will actually set the bank voltages to what have been requested. CC: stable@vger.kernel.org Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver") Signed-off-by: Conor Dooley --- drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c b/drivers/pinct= rl/microchip/pinctrl-mpfs-mssio.c index 9e6d233804cb..8da0c5312ce3 100644 --- a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c +++ b/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c @@ -156,10 +156,10 @@ static void mpfs_pinctrl_set_bank_voltage(struct mpfs= _pinctrl *pctrl, unsigned i u32 val =3D FIELD_PREP(MPFS_PINCTRL_BANK_VOLTAGE_MASK, bank_voltage); =20 if (pin < MPFS_PINCTRL_BANK2_START) - regmap_assign_bits(pctrl->sysreg_regmap, MPFS_PINCTRL_MSSIO_BANK4_CFG_CR, + regmap_update_bits(pctrl->sysreg_regmap, MPFS_PINCTRL_MSSIO_BANK4_CFG_CR, MPFS_PINCTRL_BANK_VOLTAGE_MASK, val); else - regmap_assign_bits(pctrl->sysreg_regmap, MPFS_PINCTRL_MSSIO_BANK2_CFG_CR, + regmap_update_bits(pctrl->sysreg_regmap, MPFS_PINCTRL_MSSIO_BANK2_CFG_CR, MPFS_PINCTRL_BANK_VOLTAGE_MASK, val); } =20 --=20 2.53.0