From nobody Sat Sep 26 14:39:01 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7464E46E010 for ; Mon, 31 Aug 2026 15:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788190105; cv=none; b=tL/jNKKODtZLamoWiqYPcSPQbGQSOAkXS6TOeSuP2Pb4RfPC738PKyXbJRcZPwmjSzumL/WhPfMzh9sFLqVjDKtN1NNTjs73Dkb2bLV80+dB3pOxc1y6/7DCdQ5Lt8KufosBOqjE7FtB6opUvjBkxFDgVkFD0d1EDGP+ldsxsOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788190105; c=relaxed/simple; bh=UVaSnAntsnidTQyQIAWkdDSWDG/mfhc9FkANFMl71lU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Vg4mvpG8nHbFg3ft2knRy5UmPq9012vXKelDNari5u3qbrsbvdyqRZG1KzzDpJLSbNkIsmDSQ3P8eG/9gfTtwwWhg10hvJuJufN4afE4RMphzGuNpA14/uGht7k3HpfBO4MlYr9MXhCla5duU4OVO3ti22u2WZ1WGW8f3rgn4lc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dv+VGBAV; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dv+VGBAV" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3965d3d9ab8so2783649a91.3 for ; Mon, 31 Aug 2026 08:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788190104; x=1788794904; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=LzXEuTigiTiPkrsvsB4lTws1Gv1eiCRXL/HMjZW3pgA=; b=Dv+VGBAV+xNPvTURXvUpAquidUdVTNnjzTCKqfdp3UJJpd65cXNMzBLMld+TUnvsvl 3M0/jI5cJ0vlK0OvYcMcdMIhufAk84ePXu3TYpWsJznaP8cEVyf/WClCnPigPZaM5Any 0URwA8aZgD0LzdsRTDDZY16Za0XcuJ86s2Pcq6NjV417uBgzHnSy1OuSmZ9qa5uru/xc B/Q+vXyk63e1558Jw8yUDgBGShTXpJKa0bXGhJx1zzL2Thn+AVwkePtfltOxY7D/+/g2 6p1j2xjRt/20Be9q2YeElAx8j5H0+HiUJ21ImopC0ZJA5WRP1EIF4cAyxhdL5XmR7JQm yvpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788190104; x=1788794904; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=LzXEuTigiTiPkrsvsB4lTws1Gv1eiCRXL/HMjZW3pgA=; b=RibweQeSXvCCu3cnXzmbWq2mHM8ZT5PaiYLRLMzeV1IlTL3wRVZHrSrMUjxt9do2Um KOczVHDVpYGLK8iPPIw5I7IL5NfL6bcUrvAPvAGd29TzqLjrafcJiE6mX0vPhJfMLRKA U0I7ZHWoH3PPnufPvVupG4FZzOoC97h9oT7hQs2WUCYf97pmBf1lqI8vcTgKhlSk6i3r aVdUgRHori9esPtvYw/r/NlRk4WvTTdMRQNWBuz/U0YIqOHIhEHMcr5kFP9jLaVzG1Yt bKWNzuUwAc+D9Oq7Fu30VJn+pA4sYzC+gNyfbnP4dyY04wHQQhA0IWFIDfwyCAyP7PQM 58PQ== X-Forwarded-Encrypted: i=1; AKwUvBwvl6Z4o0JMSU3VtgPYQM/xcsdjUeebU8NaNKO1XJd6ceXL7urKYtRxcVIL9xzqbD12R++2RZVGuCGhDyg=@vger.kernel.org X-Gm-Message-State: AFuF++nLPkJTcvSUtlLMtQlumlKb1aNH0rn21nL5LEQO9vcZhCf7KV54 eRD+rAbtCKbcCMKseUeZZLXZzNO3NJhCEPF7btnSi+O7yPzj98c4Q1L0 X-Gm-Gg: AYBFou3QduseWDg+IroH1UoxlO8wlFqK9n1BZ2arnap0AUpz6M7b0YI/kKxeRBOXk7b D/iwgwEn+LxvogdbwXYb8s00fNYJDoKa+cSdu7Ns5H8R9eD0Jb+tvmnBvhh9ZzvDEP9x+E0+8r9 s447YELH6QDcNuN4nmEZ8eyVtlUMQC5/X5t/BiBgOLNDrY1QEQtNi/FyD3sTtrPYwjmHUnW6559 FQ13HyQgKnWOBJIzC4l+TWvzdX9JGrVkNHYgmzSnqFDXAnAAQer9Qc9tcGnjDT3uvwvcn3U2mcG mwENkKBzVrcNj/Kb8Y3OXwKL6+MaAuUBxNDE+1qblaLUGfBE4NcjXW+6gOEnqEO5cDiaCM3RQgf NlmJgBG4q06op9mH4bdRKbKpSAA8O0QPU7inFNzu3N7Xlx7AopwOSZEi5skFJ8Z66EfTtzPI1cT rJ972khH5eMgPYDRqbcCMpeMc6ygPyAnYfRSrIo1eWaier4qLOFpT/yN2gqK3TQ6J6pakk/jPLc xE3gTHmISLEblJMhJdO4uqsdnnDuA== X-Received: by 2002:a17:90b:2551:b0:37d:f983:7b5 with SMTP id 98e67ed59e1d1-396d0fe384cmr47180926a91.9.1788190103615; Mon, 31 Aug 2026 08:28:23 -0700 (PDT) Received: from urmom.urmom ([14.170.170.155]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3990bcf7ca7sm8891a91.4.2026.08.31.08.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2026 08:28:23 -0700 (PDT) From: Lucas Sproule Date: Mon, 31 Aug 2026 22:28:08 +0700 Subject: [PATCH v2] remoteproc: qcom_wcnss: Fix error check after devm_ioremap_wc() switch Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260831-wcnss-is-err-fix-v2-1-5520fd4c6b50@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMwQ6CQAyE4VchPdMEligur0I8QB21HlbTqpAQ3 p0Vj98k8y/kMIVTVyxk+KrrM2WEsiC5D+kG1ks2hSocq1NT8yTJndUZZnzVmdsQJdZAbA9C+fY y5HlP9ue//TM+IO9fh9Z1AzHfXE90AAAA X-Change-ID: 20260831-wcnss-is-err-fix-729c91ee975c To: Bjorn Andersson , Mathieu Poirier , "Rob Herring (Arm)" Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Lucas Sproule , Konrad Dybcio X-Mailer: b4 0.16.0 Commit f9b888599418 ("remoteproc: qcom_wcnss: Fix reserved region mapping failure") switched back from devm_ioremap_resource_wc() to devm_ioremap_wc(), but kept the IS_ERR() check that had been added to match the resource variant. devm_ioremap_wc() returns NULL on failure rather than an error pointer, so IS_ERR() never fires and wcnss_alloc_memory_region() returns success with wcnss->mem_region left NULL. Probe completes, and every subsequent firmware boot then fails with a bare -EINVAL from qcom_mdt_load_no_init(), masking the real mapping failure. Check for NULL instead, and return -ENOMEM to match the other remoteproc drivers. Fixes: f9b888599418 ("remoteproc: qcom_wcnss: Fix reserved region mapping f= ailure") Cc: stable@vger.kernel.org # v7.0+ Signed-off-by: Lucas Sproule Reviewed-by: Konrad Dybcio --- Changes in v2: - Collect Konrad's Reviewed-by. - Resend using b4; v1 was whitespace-damaged in transit. --- drivers/remoteproc/qcom_wcnss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcns= s.c index c856a92af43c..90747af237f7 100644 --- a/drivers/remoteproc/qcom_wcnss.c +++ b/drivers/remoteproc/qcom_wcnss.c @@ -542,9 +542,9 @@ static int wcnss_alloc_memory_region(struct qcom_wcnss = *wcnss) wcnss->mem_phys =3D wcnss->mem_reloc =3D res.start; wcnss->mem_size =3D resource_size(&res); wcnss->mem_region =3D devm_ioremap_wc(wcnss->dev, wcnss->mem_phys, wcnss-= >mem_size); - if (IS_ERR(wcnss->mem_region)) { + if (!wcnss->mem_region) { dev_err(wcnss->dev, "unable to map memory region: %pR\n", &res); - return PTR_ERR(wcnss->mem_region); + return -ENOMEM; } =20 return 0; --- base-commit: 73e3f0710014fe6d4ed98cfc02292f6121db7558 change-id: 20260831-wcnss-is-err-fix-729c91ee975c Best regards, -- =20 Lucas Sproule