From nobody Sat Sep 26 14:39:02 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8820F50AC22 for ; Mon, 31 Aug 2026 13:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183757; cv=none; b=dOcnizM1ORLWjEiKB24psWgk351vdykSv7XjISem+13XmkJ5eb8BOD6afzF9dgGtiz/uSfCvMZmq6zabmsDELh4Rzxdrnya3KTifkK/MRCrFT2d4GRvAAzfFtp5t/mTLCPBbzIo0mz1o2xBTx8PSBxbozMqyjtQpK10fbZK+RyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183757; c=relaxed/simple; bh=VA88Bb5/UdC8IRm7ZMkG/SfASBhEQ3tiVRi2aqbk8vU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=rIbi/CCnN5V8bT18Mjo1iMoi7vOmEG8547opHBrgpD9lK1DB6tQ7zfMGS0lDkDEqYwhGVmSTbiS+c2RLcPKpOiVGY0AG8QtJTLPq+jTp6ba1ewMm4SGaMGDMn4XPOw5cWnj3KFK1XkWZPxJ/N0kqotsSdttouPujD2IpTnsfWi8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VcZpN2tt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VcZpN2tt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 291F81F000E9; Mon, 31 Aug 2026 13:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788183754; bh=9D2sLJLRMjg28ShnK//LuwgfrmGy0ErZnTjHVTXBcrA=; h=From:Date:Subject:To:Cc; b=VcZpN2ttA7WHS2V+Rbxx3nWkPttnI5ALTKjxwTD6+vcfG9pBKGoTWccS9IjtnFkv/ UXjFWfS7bdf4Hr3BPQpH7aIoX/Se133u7KQu/8ijo5rceiKaKH9xYYvv16CLAIW0YG uEuhZvNzy9rOptLOq8XITfLLoY3iiH8DxrHt+Mapi0x6oP7TiGsSOB1x7FKHQgHRAT RhXQ6EklgzJjPGcDawETbD060FtxrHcxPFmmgFsumISY4lrNJ5NuRFuL9czMpQiWUf n61rwZyvcSys27QH8fQsSTI1g7a6VYWMwlQCtql+wO9lhfkNp4QG91EnnNiR1KCweF itPXRv4aZTqIQ== From: "Lorenzo Stoakes (ARM)" Date: Mon, 31 Aug 2026 14:42:11 +0100 Subject: [PATCH] mm/vmpressure: remove window size TODO Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260831-remove-vmpressure-todo-v1-1-498515e59cdf@kernel.org> X-B4-Tracking: v=1; b=H4sIALKElWoC/yXM3QqCQBDF8VeRuW5g3cw+XkW6MPdoE+jGjC6B+ O5tefnjcP4rGVRgdCtWUiQxiVNGeSioe7bTAJaQTd752l2OJSvGmMBpfCvMFgXPMUT24VxXfeX d6dpSPue1l88/3Nx32/J4oZt/Ndq2LzYWcVt6AAAA X-Change-ID: 20260831-remove-vmpressure-todo-2d764f42059a To: Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ljs@kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1841; i=ljs@kernel.org; h=from:subject:message-id; bh=VA88Bb5/UdC8IRm7ZMkG/SfASBhEQ3tiVRi2aqbk8vU=; b=owGbwMvMwCV2fu7ZrsZH9SKMp9WSGLKmtmyduPsTs74q/8cJT7YcvndnmUxOxOXyKoULk5KsJ 2SrfV/N3FHKwiDGxSArpsjy/Iv4/iCRsHmdF/zdYOawMoEMYeDiFICJ2P1mZPji+kN86iruuFi1 e1e3um4J8P8zjzk03bdgsp2M6cnz0u0M/2MFXkv2b5HjnKa278nb+eJs/WtmrE4rm/tldrJnt87 x//wA X-Developer-Key: i=ljs@kernel.org; a=openpgp; fpr=E7F417BF5214569E89D04F46CF9DCD8A81E27F14 There has been a steady stream of patches that have been submitted by newcomers to core mm 'fixing' this TODO, with all but the original having very likely been generated by LLMs. It appears that TODOs to LLMs are like red rags to a bull. In addition, TODOs in code often bitrot and are distracting - those who understand the code know what could be improved in future. Therefore remove the TODO. The work required to actually fix this TODO requires somebody who both has understanding of the code and significant real-world data to back their changes. Such a person doesn't require a TODO prompt to implement this change, so nothing of value is being lost here. Link: https://lore.kernel.org/all/20260831130316.448-1-tahasezer.is@gmail.c= om/ Link: https://lore.kernel.org/linux-mm/20260724054305.516126-1-cui.tao@linu= x.dev/ Link: https://lore.kernel.org/linux-mm/20260715143646.15828-1-gaikwad.dcg@g= mail.com/ Link: https://lore.kernel.org/all/20260227221555.29969-1-mcq@disroot.org/ Signed-off-by: Lorenzo Stoakes (ARM) Acked-by: Vlastimil Babka (SUSE) --- mm/vmpressure.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/vmpressure.c b/mm/vmpressure.c index 9629240d77ad..3de99fef3928 100644 --- a/mm/vmpressure.c +++ b/mm/vmpressure.c @@ -30,9 +30,6 @@ * * As the vmscan reclaimer logic works with chunks which are multiple of * SWAP_CLUSTER_MAX, it makes sense to use it for the window size as well. - * - * TODO: Make the window size depend on machine size, as we do for vmstat - * thresholds. Currently we set it to 512 pages (2MB for 4KB pages). */ const unsigned long vmpressure_win =3D SWAP_CLUSTER_MAX * 16; =20 --- base-commit: cee9395acd8043be0644b25c34bfa86623f2b935 change-id: 20260831-remove-vmpressure-todo-2d764f42059a Cheers, --=20 Lorenzo Stoakes (ARM)