From nobody Sat Sep 26 20:28:44 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35CE33BBA1A for ; Sun, 30 Aug 2026 17:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109813; cv=none; b=OeUUVoQlOD2n8ZtYYLTOI6qYBdQ9elFRpnrwiJnYwVyeZIWQbRynAlGRRuEDZ63lxzVhgaCVQ1WtbiPZXk0Tyo91YyrbMHXBI6rJmGiWIcSiQmZ6MeGnZPUbYY3DHl0p1y3Fo6fceSGrQ8UvY9aJvp6aE6mQB8OkvfcEUNk1/oY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109813; c=relaxed/simple; bh=bgK+DZod7mmJgogZgW1zioKzetKNGqoKIW9z56Vpb+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s5oioWrL1B8ZFhQS0DtDw0ZUoSAAhSBSaEjf+P7AOoQRid4KZKD0iv7E4W3osDZeYiK5JhDM5T0wprFa+JDDOJ+qJSGrjg5CD7wVY0opwHVmbEtawsBEDb6/rmqJQgBq7V36lcEwYAh/AqMAv4Tkf5FzzEevOgDyT/IkmK8ouBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JNENQCcU; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JNENQCcU" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38fdeaed181so4061097a91.1 for ; Sun, 30 Aug 2026 10:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788109812; x=1788714612; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H2F/5Rn1z2wIFmLqiH74YcGVKvaBMa7CAe2jvYLlnR4=; b=JNENQCcUfkz4Grh053ZdrHRJMBP1bi7Sv8ZGb7B5gtyvzNZTsXkGnVERYIVstQ268m HLRPBRq5xJVbeWxD+gD9FNJlH1bqxvnZq8zmsLIhzEZJUW7wwwd/CSKw5vYMovYCShXL TfvrBOvkqtv6ZxZuoTy107Kxmx+pXBlCZVyDyiLD05/dAYiAgCTLXUmH+pazlJu1HLZ1 PkZZ3XmjBFevIRiVSUS5TWmqM28PfttFlCuxYp8sPCwRSFpIV4Vvhu+cs392BwfTa8B5 hoY3bPfvCgpGmBWTo3vmj8Vxz2PauEMaakDvpDve9T6+K9XUGfICXK3ntDy6SlqDqxil QSsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788109812; x=1788714612; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H2F/5Rn1z2wIFmLqiH74YcGVKvaBMa7CAe2jvYLlnR4=; b=mkWtVzSqkTzO/eFeR1SElRuBtgVKZ6KskJkEWSs8DQaRz0GpZA6SbO3gT6RXEpWvIX Cz14Ai2h7b/EMc7Dn7qRJNiONigOBNfGsZ2oUsPr8nIVcDZ0InrNvMRa10RZ12btENib EwhYbstIzZaNLWJfLOfQ67CTvNpbzJ34nGQKng9B96qEsnQckyd9iF+8Y0bw4lzl3971 tatYCa0gBLQ4X9ANrWhgobIH8Kpld0COIlWm5pHdtxbJcLu1kZvM/RJB4HJDUjfxMcpn pPtGxBWZyTwL5Luf7VFYeh+f84eGg06dvNVav5jB3s6YeZt+fee4ZvXLBXvik1J5YOII OQzA== X-Forwarded-Encrypted: i=1; AKwUvBycugXEPJbTWgXnivWIs7ezXXFskvCuUZ/9kRBNdyrN2oDRjcJkvglGoEszvfCr0uYyVw2lLl3KbdiPMKk=@vger.kernel.org X-Gm-Message-State: AFuF++nwUUGK5z6CTMbTP1X0018ywmxLx62JOvkuP81KGtlRKh9L54Im UApHmtsQy0/igam2MGn4gkUp0jlb4UQ2RDmcigacrR+SMmriohe2Wspq X-Gm-Gg: AYBFou2hwocmgSHv50+s1tfEH0ub0T7ZYvDzlUbBQBku9Cx10okQVUD6PORKAQHqym3 eX6MDtl/1pHUa7ONr0+PXPR3kK1vzZHgu6Ih4iVbmIwr+4N3+e5QX+1DFNn2FCiY8sUQmGtEE7I h/FrIB5ctIGebHDhKZTXvNX2Ev5IUsKlqPNl52FdJd1Xb8dIfVcOjCuwG3dubh0TRvB57SoYfFr f7aFxSGfUyFd+wBQ9oVNJPmDyJQy58DtA9ulaPBbLbzZINEGWi0BHBXQ4Ar1u+y5NGRuKYKXZsV 7D3fKXrvyKnS1m7BDRxSZk5O3MA023GcJfUQSj+lg/QxDLyXCP0LakkLTMmJP9Yx/9h+Uq2OcHc 19PLxEl7tiRbUmMOFwiSrsrmKSALn2/qrTLEhtCT84EBkPFyrLKisMK9sy5zsHkctSG9F1oC0Fx eTFb2jX77qlnac+s9Paq0ZxLD8WVbXV8TWCEr3dgwHQJF73R0oUYNmua4+RA== X-Received: by 2002:a17:90b:4cd1:b0:398:9bd4:d12 with SMTP id 98e67ed59e1d1-3989bd40da3mr20529328a91.17.1788109811626; Sun, 30 Aug 2026 10:10:11 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:88d5:45ce:40e:490f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396b0fcfa3asm17047101a91.6.2026.08.30.10.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2026 10:10:11 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v2 1/5] iio: adc: bcm_iproc_adc: sort headers alphabetically Date: Sun, 30 Aug 2026 22:39:14 +0530 Message-ID: <20260830170919.470974-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260830170919.470974-1-mdshahid03@gmail.com> References: <20260830170919.470974-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Sort the Linux kernel headers alphabetically to improve consistency and make the include list easier to maintain. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index ab66b97d2f04..e46e3761993a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -3,14 +3,14 @@ * Copyright 2016 Broadcom */ =20 -#include -#include #include -#include -#include #include #include +#include +#include +#include #include +#include =20 #include =20 --=20 2.43.0 From nobody Sat Sep 26 20:28:44 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6365D3BE630 for ; Sun, 30 Aug 2026 17:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109821; cv=none; b=XBDNv5D7GJtfFLbRnpqXvXXsEmkXxeqfmPj3OSoCdEjGN5Y2wxN2oAuKEmnD2kafljos57nVlZtss4qos5oSzvX2HoTmW9QMT3L94TatZR1d66ywNOv6c1K6u9U5AhmlaJRT+F0XVBMC6oQ+jVQT96u3iZCFSZMETc3f9QOhrEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109821; c=relaxed/simple; bh=N0Wz03t8OH8ZGlAavGHko236gzmCzIVjxaLhAbD+UYc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZIe2s1IWv7Ce+kUsFxUJ/4umeYfRrVmT1cPTJ5fAb1FfJyQ2Wq8SVyQQ2TFYZK0qt04QVexMkLV9DecdEPxUbzTXg4Gvl09UIgZ8MWHwbC32LfMLdT4cUHU7R/b9Sfu1zAWJ4J0vFotiIqFJMCRFH1xv3wsppsSJs2yxf7NyvHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XDczzemD; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XDczzemD" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-398c1101c1bso761993a91.1 for ; Sun, 30 Aug 2026 10:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788109820; x=1788714620; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DSXd07nmgAz6SThzdSSun0e/bFs1/0gaIblRruN5ApQ=; b=XDczzemDI8Q7T/ApymBR2tnf3jdTPR0jT1BQkUjmJLEfZqtE5oSq1Z2vkrFT7xh06W YVlsB+WWY0ftCNFzseYKtl3Lrd+4VtWkcnMd5EzFZ+LoQdxWyoRFKr7MNWar+PlmGORE +R33xsjBiTp/rwXaA6/JZvI87h7zWjMTs4Su2uejFu2b3Zqh8UW2MboVouQMEBFYXhjq H2V61LSLXfiE9ef+LbpwSwt/8sToV49+X0y6aN7J6jt353ef6fYRQ7c4p6T1ebbkS2a1 b2TZTzd/gmorJdF9mBKsMgzmH8G1cuT3U5/wxDasIAStzu8u3Wqq0pnFqOzP4B/7iNwk +yBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788109820; x=1788714620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DSXd07nmgAz6SThzdSSun0e/bFs1/0gaIblRruN5ApQ=; b=TghrxsNE1sB0NTZGn1wTzJjCuVLsR3swU8MYwQ8luc98y1zSQOO3rEG4B73y1RiHf0 F63x1Ja3mATKmBiGV0fIXGy5cREmbhdUQjcA+4xsRmG2qsHga5Eq24f6oJkItSNwGEfx +1EfIMgaC10PhIVbFl0K3gQnt+4VWZepIWmvOdtHtmlBSRetG73VmeOWpNGXsqKEB5N8 dOJYf3pCVKMzpV6kVqjfQIYSXGVDoSco+31mXj63y+kHvAzv5r/S8IidRjdVrJ7nZr5Q 4wWeiWK9VT1lgkAtdgc3g/LOJzCEoCV0EEgCdb76kcXEyMR3afej3n27sJ3SDVGDlrj7 3a1A== X-Forwarded-Encrypted: i=1; AKwUvByZfKcOvKipVq96avS5DQJFcuMyPoLXmN/QXiIBrz7SkShm58bjHSW29icry8HlOYMzz/YGsuO8r7xmECk=@vger.kernel.org X-Gm-Message-State: AFuF++mswVGTyEUi3RkGs50ehKMZVqkhuB3xPSGEtFmZZINfMR0Tpqfx yt6Dy8e2O/X/xNZxfF7MbRy+ZzpV4IzrtSMnzteoLx0eiX6hlk5QTOdX X-Gm-Gg: AYBFou32CK/6s1j7SN3qaj0oYVP6V54fgEw5d3A3ptsemgUwCJqdri1BeiXfzLT3ba4 WeD+QoxK8IG5aWm5hwelj3eeVCah8Zx1xmraU//ezfoatEsr89hiOuBz84EPCgWwAsndgJylF/2 OAKWbB6fZAHo2hrLPnkLXN4o1N0LmWcU1tiLZxDFGLWWraxPScz4GNqdbMVHQG7GboMTHSUZ1O6 WfdmDImB+XB2oXWQftNATh3r8spji1q3XUVPndhoprnIiyFbakJe3/9G9EO0wPyHm0EP0eNdeWp mxPRcezaAOwUmF9OG4ilgJu/YSti32XOtzFEXn0Ia29eaTXUVvzXm73pkgidn3Pr7oVMiJ6mTpY rllI1AVjjkI67fVko7h1yHfkPvZorhoGxWwq52AC+ugz/+o0LaSVlQ/kZV3AIiGZQcmCYZwLd41 coVtJbMmM+0rf6AUmlK0/sHwnNIijrj2iaxKS7d2zaFeau1eOg7jBZ0nRNsg== X-Received: by 2002:a17:90b:5284:b0:396:4dfb:5890 with SMTP id 98e67ed59e1d1-396d0e5bbc0mr35517294a91.2.1788109819698; Sun, 30 Aug 2026 10:10:19 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:88d5:45ce:40e:490f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396b0fcfa3asm17047101a91.6.2026.08.30.10.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2026 10:10:19 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v2 2/5] iio: adc: bcm_iproc_adc: fix include dependencies Date: Sun, 30 Aug 2026 22:39:15 +0530 Message-ID: <20260830170919.470974-3-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260830170919.470974-1-mdshahid03@gmail.com> References: <20260830170919.470974-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Add the headers required directly by the driver for completion and mutex APIs. Remove the unused `linux/io.h` header now that register access is handled through regmap APIs. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index e46e3761993a..2b59819c4ca4 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -4,11 +4,12 @@ */ =20 #include +#include #include #include -#include #include #include +#include #include #include =20 --=20 2.43.0 From nobody Sat Sep 26 20:28:44 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D86973C09EC for ; Sun, 30 Aug 2026 17:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109832; cv=none; b=mtxI255TMhBuKvDzMx7nvDduECegrof9Z07OTehn+xrQ7b18kHSKYbVzzr39a51VKHItZFr2IQJe0lTh9xVneWP0HYyY7JATzknht8X9gnrZpd7S65a3aM3P0CUcBQW0Gp1ez2tRT5uoia/yMBaa4ICF1jloaPIpEdXTI8SE21A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109832; c=relaxed/simple; bh=GqNRyeTFsr7wcrfJ85wse0w5ODrwzgVQAdrq8D4JKck=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mJXycw20RPHseqy/wWSARVuC/SXqQCTtttqySmQCTduthzx2lNf40txuA8B1z73dfxZaGcifnS861hM5R2k5vBBjxY72N6plauQeYzvMsWyx3MiNLvcVGaSiemOuxmYQTcJqaCYQE0RlgbcYDsSsQ4b6bWyXOLcGi3ZYd6ruHwA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EIhBjvjN; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EIhBjvjN" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38d489b6b71so3027619a91.0 for ; Sun, 30 Aug 2026 10:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788109829; x=1788714629; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ri0QbBDUdQXRFUs7t8FRY1qNhNj6rQaG5ZybdVVmKl0=; b=EIhBjvjNPWq5uPfqy+219fwo0EdJvM+f9D70VNddK0wPAssXs/UgENtbkT68cS0Xfl 7h1L4VOVTZ/sZIcak4WTGsyAqSOsG1N6fs9XCqTjSsj6DoWsgIpijfN6w1Sxbx7G5yTe srLbPQu3x2hKV5pCCEN1gZV6sElYmGhvE7x3lYjocwypVxfgWUIzgn7E2yHXrc81rjk/ gB4YQSX8zqqu+jtEps5QWqMKIPMJNxeowAsH37H1ouvriccaAlznK231JVQJIEopG68E 1SBQ4LZ33DwietvDaIhNt2erjgmNg5KqFS/FXX5diYIwloaV7ndKORzWIUPpEc+2Yk8N 7Lsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788109829; x=1788714629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ri0QbBDUdQXRFUs7t8FRY1qNhNj6rQaG5ZybdVVmKl0=; b=llTljzzBU7POiBiaWl38F8iM5FVg1xz/t789tpjhWvv1pwSGlkhiONDR25p2+w6LHh 13wbGSkh/Y1PQrgoCo+N5fC6hdcQMxp4YP96y+xZYfUXCbXZv5d9QziNl0AW2+4MJ4kg 10DFIV1tLf14Oj/PCEhfAiAKKT4X5607hTjKkKKmkp/2+on3S7XXLHiokXpIpKBDbZ4u 4/Oy4XH1X1FKA9NpjJnHJb3FfqY7FYKKc2CNxqYF4PKoCny1KCQ+HbZ937j5xeSuTI0V M8z43idauqujB0IpAVn1OHO2G34GbbFGdN5T+ayXMM3O2OSWdf62WhyVt+Z5Q9PUOFdG KTow== X-Forwarded-Encrypted: i=1; AKwUvBzt/wzdS+UTbkVRABK0dn2zZgvZaRQdqdooTaVbdpzpwFPhspiglJtC2kg3NTBV802PEZ0+6kk/kYuAX4k=@vger.kernel.org X-Gm-Message-State: AFuF++nSPwIRXc0w8zMAEy6RLLJG69O3xNrLopXvuYm1RqMBsJplD3Co ZmlnWv/flp7iwKP4bIaZ5X3yyY2jANSzcfxGcsiaCFgSvJYPef45ofHM X-Gm-Gg: AYBFou3g8WiPXP6pLo2mX9Mu3+ahs/lj48vlcTkaGwisfRGINCgJcJwC9vODDT7iLYb K9fQzlVDbwDKx2YoH1u0nomFPBUmAz6JLw2VAoO+yP+P2lVxxIsVtNeKCkekbnuH9nMPjRAAPUr rhM8guL2sVHbLsd+afkJ2GXHENKknqWQ2ezR4OXcbquLDZG2CXLAUir9JrxOQKBlBpmSnP8hZz7 6kkgHgFXCu+je8xWjSUma9fw1VbldNVmuW7QR1TGJZUYZg1QrGKAGbQogv8XtdtJuXiVLaKVT4q qI4KsdQ5rs7ec9IfrcCERPqwe3no2B0T1xMcBH+Cce5esKZImfhJRvZrwJJ0KUt3uc8sUdpPwcC ic43OGuSMgfArf4G9Yd0hwMerZ1GhbAULZCo1AERKNAdjy6/nHL9O8Nd9zzsChILnPTSvl3YlLw BLAm6g3D9XzRu2FaTvhn9wgWxO6o95/Uadggzb+W4cIWq3/RR95ZcaZw4u0w== X-Received: by 2002:a17:90b:440c:b0:381:6c5:3f63 with SMTP id 98e67ed59e1d1-396d0eab08bmr31913392a91.6.1788109829049; Sun, 30 Aug 2026 10:10:29 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:88d5:45ce:40e:490f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396b0fcfa3asm17047101a91.6.2026.08.30.10.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2026 10:10:28 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v2 3/5] iio: adc: bcm_iproc_adc: use devm-managed cleanup Date: Sun, 30 Aug 2026 22:39:16 +0530 Message-ID: <20260830170919.470974-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260830170919.470974-1-mdshahid03@gmail.com> References: <20260830170919.470974-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use devm_clk_get_enabled() to manage the ADC clock and devm_add_action_or_reset() to manage ADC cleanup. Since the clock is only needed during probe, keep it as a local variable instead of storing it in struct iproc_adc_priv. Register the ADC cleanup action immediately after enabling the ADC so that it is automatically performed on probe failure and device removal. This removes the manual clock cleanup callback and simplifies the probe error paths. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 39 ++++++++++++++------------------- 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 2b59819c4ca4..c7fbdc21f8cc 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -107,7 +107,6 @@ do { \ =20 struct iproc_adc_priv { struct regmap *regmap; - struct clk *adc_clk; struct mutex mutex; int irqno; int chan_val; @@ -449,6 +448,13 @@ static void iproc_adc_disable(struct iio_dev *indio_de= v) } } =20 +static void iproc_adc_disable_action(void *data) +{ + struct iio_dev *indio_dev =3D data; + + iproc_adc_disable(indio_dev); +} + static int iproc_adc_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, @@ -508,6 +514,7 @@ static int iproc_adc_probe(struct platform_device *pdev) struct iproc_adc_priv *adc_priv; struct iio_dev *indio_dev =3D NULL; struct device *dev =3D &pdev->dev; + struct clk *adc_clk; int ret; =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*adc_priv)); @@ -527,10 +534,9 @@ static int iproc_adc_probe(struct platform_device *pde= v) return dev_err_probe(dev, PTR_ERR(adc_priv->regmap), "failed to get handle for tsc syscon\n"); =20 - adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) - return dev_err_probe(dev, PTR_ERR(adc_priv->adc_clk), - "failed getting clock tsc_clk\n"); + adc_clk =3D devm_clk_get_enabled(dev, "tsc_clk"); + if (IS_ERR(adc_clk)) + return dev_err_probe(dev, PTR_ERR(adc_clk), "failed to enable clock\n"); =20 adc_priv->irqno =3D platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -548,13 +554,13 @@ static int iproc_adc_probe(struct platform_device *pd= ev) if (ret) return ret; =20 - ret =3D clk_prepare_enable(adc_priv->adc_clk); + ret =3D iproc_adc_enable(indio_dev); if (ret) - return dev_err_probe(dev, ret, "failed to enable clock\n"); + return ret; =20 - ret =3D iproc_adc_enable(indio_dev); + ret =3D devm_add_action_or_reset(dev, iproc_adc_disable_action, indio_dev= ); if (ret) - goto err_adc_enable; + return ret; =20 indio_dev->name =3D "iproc-static-adc"; indio_dev->info =3D &iproc_adc_iio_info; @@ -563,29 +569,18 @@ static int iproc_adc_probe(struct platform_device *pd= ev) indio_dev->num_channels =3D ARRAY_SIZE(iproc_adc_iio_channels); =20 ret =3D iio_device_register(indio_dev); - if (ret) { - dev_err(&pdev->dev, "iio_device_register failed:err %d\n", ret); - goto err_clk; - } + if (ret) + return dev_err_probe(dev, ret, "iio_device_register failed\n"); =20 return 0; =20 -err_clk: - iproc_adc_disable(indio_dev); -err_adc_enable: - clk_disable_unprepare(adc_priv->adc_clk); - - return ret; } =20 static void iproc_adc_remove(struct platform_device *pdev) { struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); - struct iproc_adc_priv *adc_priv =3D iio_priv(indio_dev); =20 iio_device_unregister(indio_dev); - iproc_adc_disable(indio_dev); - clk_disable_unprepare(adc_priv->adc_clk); } =20 static const struct of_device_id iproc_adc_of_match[] =3D { --=20 2.43.0 From nobody Sat Sep 26 20:28:44 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712FA3C199B for ; Sun, 30 Aug 2026 17:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109842; cv=none; b=j27RIBvaU3NoJi7dIdoVXE38nx0R4RJf3UhaZbUfqsIpg2+OJZ84q8fI9o5t5zpP/kkeGvqOjUYBMkhxKZbVYkm1xgZx/PvpNMvsUiQVCAUmYXBvtSp5CR0kDosnnr+ZtpxSa+6mqDELH2aLj4s7NiJtt3b7sDHOQnkTOZM7Pwc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109842; c=relaxed/simple; bh=MHHJQfeJIqObhw73w1UomEbR7+LOBj+txdDKfQKR74M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dWVyAw5WD3dqafke6sQyCPDbciqTJHk4nZGGq/gStWhWC0Sg6dkcYfEwU9aQG3DPeqx0188rARyj7tSVwqtLY1OM29WMZ+GsKe4vbjkvrnZQJcm3ZvCDulTZmOevzwaxeZer/u6sGVF3oi1kh5Aw+Sas5rcCzksgDJk/UPMTi48= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DIwltraJ; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DIwltraJ" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-39266382df6so2217395a91.3 for ; Sun, 30 Aug 2026 10:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788109838; x=1788714638; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TFh7tNrhnkyS5rc0tyeCiGcCiB45l4CkB+Wkyp1hfZg=; b=DIwltraJ0W1MbYBY+dMOYG2YuZd5V2UQPF3x+Y4AohgLDcUyzuFEUTEMn1dRtPSk36 R0zLY6B8sovCPgmugDOzlJ6OAKdv7icblcSvgasiimwU8sR9LMtJsgpMJeNcwEsoKzAo //qdyQ+L8InvT8A8tYgK3uTsf2o39hXoZB+xVt+d3s+DARKhj/unkSAXR3MpDMX75BjN tePN1rkfrWCIxN+cHyXRvEUTTQg82SU2ULY5OynNMgR7+VAg6/+e4nyg0QtzTGnJMLUT J1h51fBa+Pkv2yDrTCz692N1RH4DtrJyqdZAAlybsGZiiQLpDPbFt2nsXYngcjElir2F Ut8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788109838; x=1788714638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TFh7tNrhnkyS5rc0tyeCiGcCiB45l4CkB+Wkyp1hfZg=; b=FKlsU7z7cbLAaU35cZKyT/WGq7P5xtvdldWexJhO06y+o/Sv65j7NMbks0H5DnKakN Ni8wx7y2HwjAS8/0B6raSIE7715Wh3ZirEPKrDvFsGlI3/pDP4uD2eB5zZPoeGK9PRAn 7Bh8L625J8+bGEiOS266zmiWmveO6vnZYFGRRc9MAEGMz0Jhs3ljVL/o8Y+hiAGA4aZC dsUyVhzVJMgoeluMOhuccAkj+noCeL8lO00wxxjq1vUxPnH8Y7wDJHW0LQFR/6cERHHF R2JcnvzGzvRwa1nnGTK2fiB8CR4cExpvPGYvo5Dm82srwN9dGx8xqWphQBNA8r+UshR3 wxzA== X-Forwarded-Encrypted: i=1; AKwUvBy5Wh04VEQQ9FkhXMyUE6bGrDq8hO/dnMzRXOof5h6Mv6Ez5g0FWXh/hkdR1q2/4xdrF4mbYNgBi3tq3YY=@vger.kernel.org X-Gm-Message-State: AFuF++n1yUf+JcPyBkFNJ1EfrpLzopTKoVQmLdOvTWYuuk7l29j2YVTq uqApQXeL3yaDRMhgkUrZcxnnE1SXaOJ5GG5BjdklKvrEw5SMg/KYziSL X-Gm-Gg: AYBFou0gOJ59JuB+E1U1nHK2hHkPLDUrbUWgblQrag2H8/gJVtbIs4ewPap0wLA20Gf AHtDu5UDUg64xmXV6dTxHFTW5guz/Dz64H6ZCSoCXRCGt9AkKwTazrmktGzQTq9o0TT21z0sgro YXbNj+ul/HNGvVBHMLMAfXU4CyWYziiI/AUN6MpjFG1pQ/PPM4iVT2b7CUPh5NLTusYWerbXflI 2//7GVSguXvKEA8TrhCucHsOvbY47px8S3vziuzGQdlhMlGviqPslZLdNqgOdj64JgCPFQ2nYFc y7kEatZgjGSU3gWaBWXs1BffcGAMCDqnF/adlM5gVw2aLTZP2odFpSJCca4M6IiK/XcLLHuPlr7 XSQYoOZekGvHFTlncdlc6IhsWyWtE0BnG3mhnX6ItvXjxug9k7TH65sMry78fhgI2lXgFxfteIS arJtaOyXU/PLlinWKZpg4rHYpX2Fd1644oN6gZCNgAbrJ7mW8FqozGG3j0gDAk7LCCega5 X-Received: by 2002:a17:90b:6c5:b0:38e:bbf1:de3f with SMTP id 98e67ed59e1d1-396d0f9d0famr35772568a91.12.1788109837836; Sun, 30 Aug 2026 10:10:37 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:88d5:45ce:40e:490f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396b0fcfa3asm17047101a91.6.2026.08.30.10.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2026 10:10:37 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v2 4/5] iio: adc: bcm_iproc_adc: use devm-managed mutex initialization Date: Sun, 30 Aug 2026 22:39:17 +0530 Message-ID: <20260830170919.470974-5-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260830170919.470974-1-mdshahid03@gmail.com> References: <20260830170919.470974-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use devm_mutex_init() to tie the mutex lifetime to the device and improve debugging when CONFIG_DEBUG_MUTEXES is enabled. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index c7fbdc21f8cc..11f2bc12c19a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -524,7 +524,9 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv =3D iio_priv(indio_dev); platform_set_drvdata(pdev, indio_dev); =20 - mutex_init(&adc_priv->mutex); + ret =3D devm_mutex_init(dev, &adc_priv->mutex); + if (ret) + return ret; =20 init_completion(&adc_priv->completion); =20 --=20 2.43.0 From nobody Sat Sep 26 20:28:44 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 058E33C09F2 for ; Sun, 30 Aug 2026 17:10:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109850; cv=none; b=XqKpceTFJqTnFmw/OCT0kMfQwAVCN2HQYIVlIbQTXDPJODMXXiFMDQCTZBfmr0KkY6e6wnpYwf1lXr6p1xiTFmQyzAWXC0Q6Pzd2uTYLxY2Ge9LM1fgdoOswlTv0RgcSw1d2PTOiB1bJ+4YPMlQvF3ITUvHKTTS0cs2p8KP5PHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788109850; c=relaxed/simple; bh=sy8BZryh+VKv74VP8uHYb984yUyfJh7wIVMGurHwjnI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H8ekQggh/3NmEzhODltZSzMc6Qk9TNqAI+D3oIRiAtnfIW44TLtONKJqydAbwiWJKPurJ4iLwE2NMdv3ygltgaJMpJ0b9b9eQ6mqCpylKPuuNigfOTEWaW9jH8McEMBjg696JsHBz6MDI/8llRYJMKdpu2yHAy7QqZXUg6vj0cw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IHgtMmR1; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IHgtMmR1" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-39647aa9d52so2617825a91.0 for ; Sun, 30 Aug 2026 10:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788109847; x=1788714647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+GRZL0uxq37pp9qHzlDeSvEEyunsmZeKfcXgUqg4T+M=; b=IHgtMmR1e28ozTFPzIVA2Feyxf74vjQZouzJ+OZZNKEKAOWUxNkH39HPj4o2TYl0Pv OWMyiLgUQJYCwNpjDPSum+bszpMkZqgv2YPPbx/BEDrIeFa9VRp+Fd7ahkdcCGoY8uE1 Gr0Tk+08W/Y7hWonPnBuwpEDSyM21a21bg2GjUfs/Ne7b0DtKmPENb+iX96hrxfL+Dom X/1n75ZvQYRqPsH/jGTcBoq2F5vfUdXfOUdZ8UMhv5YgssMwsnJVRdG0XAYlXBYgHC4+ T30rytVKcephGN/CJlju0cY5U3ln3tY/Jita2GmDhejeFPD6JtQ0e+6zt2HCl4rEgFP/ G+8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788109847; x=1788714647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+GRZL0uxq37pp9qHzlDeSvEEyunsmZeKfcXgUqg4T+M=; b=r0V1aJJtQBHQ77e3ZsOTMoFzaipWmpIEmxzdcFz74m9h9uOkru8+kIm3YYEJ6zpt3Q Lpc72+Zp66cLz+1WbVjuKK8O4jx4UKWYoyXy+6m9mo5EoDcCcNz7f8bj9wiVuraNxYiN EoWKZtgZHv076SBH551JAiOAzBU/6PQ2h9VJvzvMmrCUawHQI+flzymWhXI1g3nyPaBu JdhP3IgMEVAzJJc54zFH1FCkYAfcTBi5jUOchefKqR17ufgZnigIpt4KBCS71ssX4ePH I88EcmMCD2NgKeeU8NW023H3AcJLg2fZqRZpR3ynTf9LKRDo/bKGUcFtTTWWK8+vhXHR EXOA== X-Forwarded-Encrypted: i=1; AKwUvBzxgW8aGY4XhEakelRhKwGzmo32zhKypZbzFB9I+AWK8n3mB43+FMjWtM7U/5+QURFes7XwFWatEr9bU3s=@vger.kernel.org X-Gm-Message-State: AFuF++no8TCJ+RnOrN7lmceU7RFnXNHgiDLPWineq0BZeu9oISPBAyls Dx+Q3Jlm/fnHS6+U5FVRmQoLasevv4vhOCG2wlGlGQIjMfIHr/1DV+gU X-Gm-Gg: AYBFou1ZIMRm2mckeEd5jOUjLA6fwSu2Ix9t1CnnyFnbw1L0F1RdjOoOJipnbSzrSRW Y/TGuqmQOQwuHJkg6imbShtcsPc+6Wti+2alK7V4Cep9RsuGDX30bNQBwveBabzER8jXgxbHgVB fUZDohVDFHx1klv3TjQkbfPw61xSqd/jJwYsIqf4y+udPrzzfcIsfTvuNbcSDelqJseKdBgDlCe xFe4jQknKzmSgQnNaP95+0aolNFxJFywV1qH5VsEjXkRfuUnVjraNg0HpXwHnxO+7mN/yJvoGPy D9QAGMeVndau8nMaPzxzqwSG/QodZ4KuMIBpJjYosTiOGvShotRHBsPAh1axgrXa4xHeLuaBE2i QP5YhTW2aqK4PPOnVtmlIBd59rDzCrusRnMrTb6Vi4v2HfTA2Abx2aXW8kE9A/R7N8JRQZ1tlHi KdrYILClbBChEMgvMXWTSd0sMfxjFpli3REoYQABg0jgPhXvoze19xVzNicg== X-Received: by 2002:a17:90a:ec87:b0:390:84db:888e with SMTP id 98e67ed59e1d1-398da62a9f1mr2503612a91.7.1788109846855; Sun, 30 Aug 2026 10:10:46 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:88d5:45ce:40e:490f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396b0fcfa3asm17047101a91.6.2026.08.30.10.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2026 10:10:46 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Marcelo Schmitt , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v2 5/5] iio: adc: bcm_iproc_adc: use devm_iio_device_register() Date: Sun, 30 Aug 2026 22:39:18 +0530 Message-ID: <20260830170919.470974-6-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260830170919.470974-1-mdshahid03@gmail.com> References: <20260830170919.470974-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use `devm_iio_device_register()` to automatically unregister the IIO device when the device is detached. This removes the manual `iio_device_unregister()` call and makes the `iproc_adc_remove()` callback unnecessary. Signed-off-by: Mohammad Shahid Reviewed-by: Marcelo Schmitt --- drivers/iio/adc/bcm_iproc_adc.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 11f2bc12c19a..38a153d6fc70 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -570,7 +570,7 @@ static int iproc_adc_probe(struct platform_device *pdev) indio_dev->channels =3D iproc_adc_iio_channels; indio_dev->num_channels =3D ARRAY_SIZE(iproc_adc_iio_channels); =20 - ret =3D iio_device_register(indio_dev); + ret =3D devm_iio_device_register(dev, indio_dev); if (ret) return dev_err_probe(dev, ret, "iio_device_register failed\n"); =20 @@ -578,13 +578,6 @@ static int iproc_adc_probe(struct platform_device *pde= v) =20 } =20 -static void iproc_adc_remove(struct platform_device *pdev) -{ - struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); - - iio_device_unregister(indio_dev); -} - static const struct of_device_id iproc_adc_of_match[] =3D { {.compatible =3D "brcm,iproc-static-adc", }, { } @@ -593,7 +586,6 @@ MODULE_DEVICE_TABLE(of, iproc_adc_of_match); =20 static struct platform_driver iproc_adc_driver =3D { .probe =3D iproc_adc_probe, - .remove =3D iproc_adc_remove, .driver =3D { .name =3D "iproc-static-adc", .of_match_table =3D iproc_adc_of_match, --=20 2.43.0