From nobody Sat Sep 26 21:14:37 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F3F43B0599; Sun, 30 Aug 2026 12:51:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788094265; cv=none; b=MT/nbuCmIwnwB0z06orP5uIm/E6KHM1KIriY6sOKy100fqa06N6BP/J5+vC0AS5wUxjv6rORYUFwu5JhXHOZhpMSXwEdC433HyeIfcuB4F3p7Jz4ObZ55oAT784j9vXXuWcOMYEmdYHbYVGGMdZv1FRsNPz0xHl3RWI0G/XaHXM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788094265; c=relaxed/simple; bh=H8bityHP/ZFd+dcS6S/8dsm4yXn3yyl2EEAPOGOufmM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FZEI3Cs7RX0tCkOQk/ociKWGmFXoukEtrwgbBaV27jFdD6aRPk7kQ49CT8dV67f9fmJc0mncwtR0TOgoP5aG0/7KH6JZWM34v6eyxD2rpPtO5RCc7A4lqoU7lhO4SCg8y+iUMQG8SRKEISlRsSGOcSlWcNGA4ntC/sDbEi1FmGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.241.250]) by APP-03 (Coremail) with SMTP id rQCowAAXGzkmJ5Rq8aKaBg--.26750S2; Sun, 30 Aug 2026 20:50:47 +0800 (CST) From: Pengpeng Hou To: Guenter Roeck Cc: Pengpeng Hou , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Philipp Zabel , linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: aspeed-pwm-tacho: propagate reset deassert errors Date: Sun, 30 Aug 2026 20:50:44 +0800 Message-ID: <20260830125044.97718-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAAXGzkmJ5Rq8aKaBg--.26750S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jw4kur43JF18KF47WFyxAFb_yoWkCwcE9r 48WF9rXrW3GrZ8ur1qyrWfZFWY9F9xu3ZY9rn0qwsxJF9Ivr98ur1vkrn8ZF1UG3sIqFy3 uF4DZrWfAw13ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb3kFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJV W0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x kEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8Jw CI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1x MIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIda VFxhVjvjDU0xZFpf9x0JUL0edUUUUU= X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Content-Type: text/plain; charset="utf-8" aspeed_pwm_tacho_probe() installs its reset cleanup action and configures the controller after an unchecked reset deassertion. Stop probing when the reset controller rejects the transition, before the hwmon device becomes visible. Fixes: 18c514cc0e02 ("hwmon: (aspeed-pwm-tacho) Deassert reset in probe") Signed-off-by: Pengpeng Hou --- drivers/hwmon/aspeed-pwm-tacho.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-ta= cho.c index 1c5945d4ba377..bfce589c3fb1f 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -934,7 +934,9 @@ static int aspeed_pwm_tacho_probe(struct platform_devic= e *pdev) "missing or invalid reset controller device tree entry"); return PTR_ERR(priv->rst); } - reset_control_deassert(priv->rst); + ret =3D reset_control_deassert(priv->rst); + if (ret) + return ret; =20 ret =3D devm_add_action_or_reset(dev, aspeed_pwm_tacho_remove, priv); if (ret) base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72 --=20 2.50.1