From nobody Sat Sep 26 21:14:30 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27EE52BFC8F for ; Sun, 30 Aug 2026 11:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788088627; cv=none; b=YBaA26zRHgYBwlRjX1AL+D01jAQWtDezVY9WjV91AJOw7EX8Bw7YGzzxiqtBCJVATY2hmso/73MFkWPCr5s5ePPf6q7pRnqM63KFh+baZ6VbGO2Gv9dssBxs83zi8p5PR1gc2HY0U1eekndiaCBMa05kxM45NRfoTovzE4zVCek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788088627; c=relaxed/simple; bh=LWCyxgNbdXMvmdz8E4BAcs+q1r9d6AOdZ136H5aO3V8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UIXhAzMNbroysXmJFsUkxG1Kdb6yuOlpDbr43htPuaqUzGh4AQuGQRfjjPGPGLnlDQ1nO3/3gK5vQ9CmcG+TWyejIWE8vtEH4HpYap/MdXieD/PPCz3NuJoZFyXcrjZRofTce35sxtZRaD7heBIepySL8o9hsQ7O2WnCZxNzXT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OATbsc1o; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OATbsc1o" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-482e4952a0dso289776f8f.0 for ; Sun, 30 Aug 2026 04:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788088624; x=1788693424; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=x4VO/Cw9ZIDj95FS0KQWicgscx6hGYIjScA8+mxmLtg=; b=OATbsc1oXg6Nj+v+8A0ZKJ5iv+pKdOur/8Pa/ov7/yuhq0iqX3EXKI6tiO4EjlXa4p fQb3Cb5hvtvZoQydxo95GHzht50C59VXFcCGoQXf3pLnIiVaYbuuwcjfIeVX05/Anb/J gnaXmX5fa1Sih+qdtVw+/k9UbDeslZuFPVqvHFWACVc3/smeiRRQ5Mthh79l/bpRPnHK G3JwItC/eDKrGo3LfVB5m+qRX85UwYTmnncCVL7k9Ev2Ipr72hC9HwLlEiW+RN7zSynA +PnY7gCUdhYeMZfYuQfMLoEhEVVxElQU4K0a2wObjsIyGJgNxj1ZMZNg8QluDU+PotWo bZjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788088624; x=1788693424; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=x4VO/Cw9ZIDj95FS0KQWicgscx6hGYIjScA8+mxmLtg=; b=cnjFPca+DdwLOlDujUiVotRAu1RaOwp6MPkXTorGxUerT1SkSV3enLidd/jV8Iwgw/ IGr34zsR07XRxQpFdVkTFjBcU6LWangU7d2bgsTWPFJjBZsJezTmqdfzs/A6dp1sg9hM olNjcGm0ATpaczX/zOcS3tMtbW3m1NyX4HGPXw8ZLqXwsZLSLQwXZ9Lt1wdLaKOl6GKl xBxcV53R3ty9VL307tqSp96r1VYcm5OUE4YgFhg7H0PCnrocATKcnbegqueaEy92HaJ3 6Ct/NCwcsVRcw/EuALK89f3+Kgz973mePsK71ECUixC+Zjfql6Rk9nsJjaKoPDOuiy7a B5Xw== X-Forwarded-Encrypted: i=1; AKwUvBxcehIxVjs95UJlwsXcRnqSeAp90H+CWTyaM3Rdcx9i/taLxNMIMz+i5I5RHgb1Hp9QaVetbccUa5WsDbI=@vger.kernel.org X-Gm-Message-State: AFuF++nz4yhl3+xndIdBacWOi8OqnpETyGof488kqkBHU0CxqCeDUGGD y5ikuwQPxEbZ2xXxKhKmmg/N/vuIOrEDi1oQLaIOFxmh24zusqzt+ARf X-Gm-Gg: AYBFou2lH5gyO3iJ781TMb33GrqogrlETB39I7bQiDtE49Pfquh//DEX5fgZ/lEiBhE GlP3k9FBE8IRDiKtYgeoCi44pisSoHkUdz8cYirhbxd5IoCm4KXYL+j/GPKTg34GIWAiSCUEear fsWrYUq6Zg3RJ0oI3GDFNAp7TDqwRFE/A1LHM/4TlkOG7nALdlbs6qZVNe+q8vX41um04NoYn1T mhH4qoSSc9NobIjTo3fQRagrFM8cLasei6XOMW/K6+lRkHaTYUs2D6waXt1G9Fm0aDJ4dK4UGtp nYxoqgeZ1b/kU2EEbdgXt4ku63BdzRTsRSGjoCHvlQ1+tRECy1DV9m6x3irEZGyf1Zjr5AuAXHG GUit9wP8QyHMtHHJ/UGned1EtvGsV7a/jterY1KjVpBKdE2YZAau8CdJ9M93gT+i93dv7wDhdQc WTBg6cA99e/qIwANm4t8lS8Fif+gFZd5uHrDUt8rzj2Sf7yDm4G/KGGPo4MrbOqkgwJgqwOUtt1 HiYNLSL6Sa43FPAeQ9oRcOxHTVKBMMvbQSfGzuz7rM0uHylVskj09aXBo2fCFz1nPqB1vTi53vF rRG77mz5VN7L+w== X-Received: by 2002:a5d:5885:0:b0:482:f1fc:d9a0 with SMTP id ffacd0b85a97d-482f79de183mr14582361f8f.4.1788088624046; Sun, 30 Aug 2026 04:17:04 -0700 (PDT) Received: from pop-os.. (98.102.222.87.dynamic.jazztel.es. [87.222.102.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482fbb20737sm14000985f8f.22.2026.08.30.04.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2026 04:17:02 -0700 (PDT) From: Miguel Garcia To: netdev@vger.kernel.org Cc: Miguel Garcia , andrew@lunn.ch, jacob.e.keller@intel.com, syzbot+372a7d84708b07f64d9b@syzkaller.appspotmail.com, linux-kernel@vger.kernel.org, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Subject: [PATCH net v2] devlink: request flash firmware without instance lock Date: Sun, 30 Aug 2026 13:17:00 +0200 Message-ID: <20260830111700.1799255-1-miguelgarciaroman8@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" request_firmware() may enter the userspace fallback and call try_to_freeze(). Holding the devlink instance lock across that call triggers a lockdep warning and can block unregister for the duration of the firmware fallback. Drop the instance lock around firmware loading in both flash update paths. The callers hold a devlink reference, which also pins the parent device. Recheck registration after reacquiring the lock before calling into the driver. Fixes: b44cfd4f5b91 ("devlink: move request_firmware out of driver") Reported-by: syzbot+372a7d84708b07f64d9b@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D372a7d84708b07f64d9b Signed-off-by: Miguel Garcia --- Changes in v2: - Cc Jacob Keller, author of b44cfd4f5b91, as requested by Andrew Lunn. - Keep only b44cfd4f5b91 as the Fixes tag; ed539ba614a0 provides the registration check but did not introduce the locking bug. v1: https://lore.kernel.org/r/20260829142525.3900565-1-miguelgarciaroman8@g= mail.com net/devlink/dev.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/net/devlink/dev.c b/net/devlink/dev.c index 55959b0ff..cdbf39f19 100644 --- a/net/devlink/dev.c +++ b/net/devlink/dev.c @@ -1169,17 +1169,25 @@ int devlink_nl_flash_update_doit(struct sk_buff *sk= b, struct genl_info *info) =20 nla_file_name =3D info->attrs[DEVLINK_ATTR_FLASH_UPDATE_FILE_NAME]; file_name =3D nla_data(nla_file_name); + devl_unlock(devlink); ret =3D request_firmware(¶ms.fw, file_name, devlink->dev); + devl_lock(devlink); if (ret) { NL_SET_ERR_MSG_ATTR(info->extack, nla_file_name, "failed to locate the requested firmware file"); return ret; } + /* The device may have been unregistered while the lock was dropped. */ + if (!devl_is_registered(devlink)) { + ret =3D -ENODEV; + goto out_release; + } =20 devlink_flash_update_begin_notify(devlink); ret =3D devlink->ops->flash_update(devlink, ¶ms, info->extack); devlink_flash_update_end_notify(devlink); =20 +out_release: release_firmware(params.fw); =20 return ret; @@ -1244,15 +1252,24 @@ int devlink_compat_flash_update(struct devlink *dev= link, const char *file_name) ret =3D -EOPNOTSUPP; goto out_unlock; } + devl_unlock(devlink); =20 ret =3D request_firmware(¶ms.fw, file_name, devlink->dev); + devl_lock(devlink); if (ret) goto out_unlock; =20 + /* The device may have been unregistered while the lock was dropped. */ + if (!devl_is_registered(devlink)) { + ret =3D -ENODEV; + goto out_release; + } + devlink_flash_update_begin_notify(devlink); ret =3D devlink->ops->flash_update(devlink, ¶ms, NULL); devlink_flash_update_end_notify(devlink); =20 +out_release: release_firmware(params.fw); out_unlock: devl_unlock(devlink); --=20 2.43.0