From nobody Sat Sep 26 22:00:00 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48E8F2C3255 for ; Sat, 29 Aug 2026 14:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788013539; cv=none; b=ixOftRDvyPRKdbsT1pmgwV8AKM4H0AijaxLge2sPQKm55UyCdCfDUqtvfk6ry4By1DUXMc6/M9fx7QZDcrz7eq5DSG+EvP2j5PXTy3GIvzj/HyHgC+5WoiWAu91TRXsg+mNkMf3Izq4qKpf5gjep5HwzjVb/ZXtMGT8ew+CAHSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788013539; c=relaxed/simple; bh=ubMPolVr1RyqlqLsPDJ9Q3hMnDeZ3ThPTZSytVpBbcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZabBbaLelH92MBE+Q6UU1ZfRikH0H4O5iKJRC3QgRdKPr0wXTwAt6EWh9TY/ZT4e1zdutyvN/KiJXiR63u6o140uQTus6o8QY1ir3zejq+D2NzA0NDLOW2A8ETsz4Q+xNPkA6WO6i7uA7QVQjT57WSa95wsredJcWn3BS8CUn9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H1XKbvWu; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H1XKbvWu" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-482e6163a9dso236856f8f.1 for ; Sat, 29 Aug 2026 07:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788013536; x=1788618336; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=krHARCezf5ftbCW4uWxA5magjwIWxrSJ3wP9w668rkk=; b=H1XKbvWuR3t1lrXl7A0e8hWTHBVqUNvE1QEzLrhS1rI17wT3NXyy/RY8LnvxfnkcRY iePgqh64ynxtJ6AEiGXGkR1rEMTvjtNFeZMmZncCS5n6OOa1q231ijiPK69YHNUO72vh U0Na2DE/nxUEyfS4C9BlN6hraoNGEng4TV4ll+HvVI85RGh+IV14H3eLd26NG49B02oA 2G9It1zZomO8VevNlGbWKbrHRqeBQ8nDj6jETMM71lZOFoMbmFGqB7G0BHOSWaktuINv 6wGw1HHOUUWKrkzYyaOCJs+ZCV+Vhylrfgplqy58XLXttlEs3ojO2001T+7H+MuFeB4M 7Jgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788013536; x=1788618336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=krHARCezf5ftbCW4uWxA5magjwIWxrSJ3wP9w668rkk=; b=Hp+M+9xuZjSz7+Aqa6dM23SiYuBfGs1q4q93csAG9QGNymAKyvWHBzPYob/NG4BcAh MGX/P4tV2gib3kId5e/+foNMswOvBwcAotuIsZLrSYdg0AbGDFfbnU0nsu8vq57kNCNi /7TNqM/uHbjqvc6Gx7+gwtYENFov7lfII2Dn2cRIuXV0hE08YL8yHjhwcCgh5FDG8IpI idE1kekrYOA0ppGo755kUSvjQ/AOaIA0rn+lOF976gkeywJMU+3e00zTIT4fKk+MlZCJ JMV4sTqPqJDbye/DfLXLQ9W0JIk7DFP9TG8eAmf7rk8yPfN9itnMCKpka4+zxon+fBvE 3DCg== X-Forwarded-Encrypted: i=1; AKwUvBwYsXQkDDhBB7YZlvqeWr6hlSCASh3ck+K9qSrLkaxbGUBeLvLcYtpcDwO/3e9xQY2QJ22yDrxK3CKQQf8=@vger.kernel.org X-Gm-Message-State: AFuF++mloAkCT44jx4xnh8r6NAc8bBhYW10bnX6y5XnZkmK1PwPcWDoV 0eob3XbzXEDfgucrbcddz4wv4efi78fvmtmqwxXrnHlEC1ujKh7UnHBL X-Gm-Gg: AYBFou3q/yMT8hgab68cMf3U/bLRGwJNNtGHVadC1cYfiH8E42hNQd0S4liYPQIUXpi mcDkHsxrnd2om4Pu47JEnWHDXuccdjppdd8bPAOfyVDz84M5DlA2t0+8u1uaqRcy4Nfox6eyHVA rWL2FctXxmtCROzQDfOSgvw7XwB8Z6CiPEhmovh1jYe5JphEegOsRwyws1gdOxZhR+T8w9g++4p SizGDuToMgDcB0R+2A6/vZ0iAwyqTl1DQ3lN+N3JRXoOWLzYu7+9VGlg7gFpTS3JCzslbmechdj DwM4reGivpiowmSDW4ho+1n+sNuSE4+53WtZ8+nDJXZjRf7NN1JdBfN/huMQgvURXIzvLWCdmLV DtBk+A6mQUHvGtBGr7LwpMrpfO2r+X/pjFL6XC/QdS9MCqmEa8Fmbg7J2Rvy+r04jkgi7RWojf8 GyqCW6AaTj2MjYBgpxtdE4hrmafGYHKLlXGrTIL5mSash629Yjvq4vUHehIeOP7HSYCnsR5CwMe 7jcwlvYiXAswbvv+etbZSxNS1Og6BXWsfLE3Cmx79W3PsQda59L1/hkJjCWg1LgRbWdOxlV6gEy oJy+6uvs2ruw4A== X-Received: by 2002:a05:6000:2502:b0:482:f2f2:3b99 with SMTP id ffacd0b85a97d-482f782b2cdmr10414798f8f.0.1788013536211; Sat, 29 Aug 2026 07:25:36 -0700 (PDT) Received: from pop-os.. (98.102.222.87.dynamic.jazztel.es. [87.222.102.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482fbb20713sm10107497f8f.21.2026.08.29.07.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Aug 2026 07:25:35 -0700 (PDT) From: Miguel Garcia To: netdev@vger.kernel.org Cc: Miguel Garcia , syzbot+372a7d84708b07f64d9b@syzkaller.appspotmail.com, linux-kernel@vger.kernel.org, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Subject: [PATCH net] devlink: request flash firmware without instance lock Date: Sat, 29 Aug 2026 16:24:40 +0200 Message-ID: <20260829142525.3900565-1-miguelgarciaroman8@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <6a908733.1d9ded08.62e62.00d9.GAE@google.com> References: <6a908733.1d9ded08.62e62.00d9.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" request_firmware() may enter the userspace fallback and call try_to_freeze(). Holding the devlink instance lock across that call triggers a lockdep warning and can block unregister for the duration of the firmware fallback. Drop the instance lock around firmware loading in both flash update paths. The callers hold a devlink reference, which also pins the parent device. Recheck registration after reacquiring the lock before calling into the driver. Fixes: b44cfd4f5b91 ("devlink: move request_firmware out of driver") Fixes: ed539ba614a0 ("devlink: always check if the devlink instance is regi= stered") Reported-by: syzbot+372a7d84708b07f64d9b@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D372a7d84708b07f64d9b Signed-off-by: Miguel Garcia --- net/devlink/dev.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/net/devlink/dev.c b/net/devlink/dev.c index 55959b0ff..cdbf39f19 100644 --- a/net/devlink/dev.c +++ b/net/devlink/dev.c @@ -1169,17 +1169,25 @@ int devlink_nl_flash_update_doit(struct sk_buff *sk= b, struct genl_info *info) =20 nla_file_name =3D info->attrs[DEVLINK_ATTR_FLASH_UPDATE_FILE_NAME]; file_name =3D nla_data(nla_file_name); + devl_unlock(devlink); ret =3D request_firmware(¶ms.fw, file_name, devlink->dev); + devl_lock(devlink); if (ret) { NL_SET_ERR_MSG_ATTR(info->extack, nla_file_name, "failed to locate the requested firmware file"); return ret; } + /* The device may have been unregistered while the lock was dropped. */ + if (!devl_is_registered(devlink)) { + ret =3D -ENODEV; + goto out_release; + } =20 devlink_flash_update_begin_notify(devlink); ret =3D devlink->ops->flash_update(devlink, ¶ms, info->extack); devlink_flash_update_end_notify(devlink); =20 +out_release: release_firmware(params.fw); =20 return ret; @@ -1244,15 +1252,24 @@ int devlink_compat_flash_update(struct devlink *dev= link, const char *file_name) ret =3D -EOPNOTSUPP; goto out_unlock; } + devl_unlock(devlink); =20 ret =3D request_firmware(¶ms.fw, file_name, devlink->dev); + devl_lock(devlink); if (ret) goto out_unlock; =20 + /* The device may have been unregistered while the lock was dropped. */ + if (!devl_is_registered(devlink)) { + ret =3D -ENODEV; + goto out_release; + } + devlink_flash_update_begin_notify(devlink); ret =3D devlink->ops->flash_update(devlink, ¶ms, NULL); devlink_flash_update_end_notify(devlink); =20 +out_release: release_firmware(params.fw); out_unlock: devl_unlock(devlink); --=20 2.43.0