From nobody Sat Sep 26 22:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66FD72264C0; Sat, 29 Aug 2026 13:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788008811; cv=none; b=l0owa5fr85MgRLMxXgo8oiAgnJaPseGD47E7cprsJJgJH3xmYVDM8dZfPuTxLgI4cIEGqQFmT5YH80Pa38nXsLdTfYU1rGiErREbSevD8n8/YB4K4XiqUvXU41aVOR+Rl11GvMS4yldi0N9cfH6nPvrfLh2VgWrQREI06PVXLnU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788008811; c=relaxed/simple; bh=3T1abFEb3q0LHyV+GB3FmH+SEqo1auqa1Sh66RzFZRw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sjZ0OjgillnMWUcCbasAMhMadYxiqQlZqduijyErePv/ug0bZV9Tg7HDCQ/Wvj4guKjJkrszn0jhBTLboNOa9sbpaBoin5ovhpkrCJevUHi9nioQDbaTX1P5YAe0J+WwxxwihVXuT3zUk5QMTFmecqPZ+CTN6xEDPYttcoC77bw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fIU3R1i7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fIU3R1i7" Received: by smtp.kernel.org (Postfix) with ESMTPS id 14F33C2BCF7; Sat, 29 Aug 2026 13:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788008811; bh=3T1abFEb3q0LHyV+GB3FmH+SEqo1auqa1Sh66RzFZRw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=fIU3R1i7SrIj0hbtvjhW+X9e2UO/23Kyi5iD4B2iBxhTk7kNADDZOdG3ibyrhACCr IiJwJ4Rq7nQBGT9hwUxLOt2afkyvzuGZxIEUyHUbuWuPan3qHmYkG+DYdS1Qzg8FF2 IhbIUpjbV3puVyYFCKU0fUL9iw1NLYOkVF33gMdsm2M+IU7NWUEPiMsNPLNa6zvWjZ P9gYsKBq3Bf7QnNv+4NhnHVMGKgjf6gd+9Y2sx339B7Yq00qqQ74OYE+UQ40pVh528 Mju/+R2D5uhUfAOoF8fg4Lpn3mGpp/jrkiPrRSqaAFB2V4VeUuabUY2rdg8GgGlpzA z3u8MkbS1UX4g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA433C61DBE; Sat, 29 Aug 2026 13:06:50 +0000 (UTC) From: Muzaffer Kadir via B4 Relay Date: Sat, 29 Aug 2026 16:06:33 +0300 Subject: [PATCH v2 1/2] media: i2c: imx258: Add wait after enabling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260829-imx258-add-reset-gpio-patch-v2-1-bfd27891e225@mainlining.org> References: <20260829-imx258-add-reset-gpio-patch-v2-0-bfd27891e225@mainlining.org> In-Reply-To: <20260829-imx258-add-reset-gpio-patch-v2-0-bfd27891e225@mainlining.org> To: Sakari Ailus , Mauro Carvalho Chehab Cc: git@luigi311.com, pavel@ucw.cz, tomm.merciai@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Muzaffer Kadir , =?utf-8?q?Ond=C5=99ej_Jirman?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788008809; l=852; i=muzafferkadir@mainlining.org; s=20260816; h=from:subject:message-id; bh=6gFgGcWn8XWMZgFcAqImtkE7Mtn0Fv/loz0A+OqkWoQ=; b=uDYz4J8Nixs5xOqxBYgf/sToUz4lEo/oxloyl5W/XX50cB3pCXI9ryVqXDpD2cvMOCYz4mBB5 gDjt0HwAdhpDyOM1OGRks8jJLKAZGPyV9NUsTA31ue5+WUOQEMa7t6Z X-Developer-Key: i=muzafferkadir@mainlining.org; a=ed25519; pk=4zkv4suQ3cYcO4Z7CrV8JSSjEGLBGepUtvQCFjgnYIU= X-Endpoint-Received: by B4 Relay for muzafferkadir@mainlining.org/20260816 with auth_id=954 X-Original-From: Muzaffer Kadir Reply-To: muzafferkadir@mainlining.org From: Muzaffer Kadir After enabling the device, a delay is required before the sensor is ready for CCI access. 0.4ms delay needed between enabling and reading the ID register over CCI. Link: https://lore.kernel.org/phone-devel/apF5oxsCf7MJt1lk@kekkonen.localdo= main/T/#md6a0411e81a2e3a563c935348f2fb4f3d52df64f Signed-off-by: Muzaffer Kadir Tested-by: Rudraksha Gupta --- drivers/media/i2c/imx258.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index bc9ee449a87c..9c3a6579df0d 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -1129,6 +1129,7 @@ static int imx258_power_on(struct device *dev) dev_err(dev, "failed to enable clock\n"); regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); } + fsleep(400); =20 return ret; } --=20 2.54.0 From nobody Sat Sep 26 22:00:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66F6E5474F; Sat, 29 Aug 2026 13:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788008811; cv=none; b=LLnEWoiqaSQIbmZWDUxbcIOcTWkdY2irr40neP/6hQc1Vt981JzEKGNcAFl/rVKlsUvud9ULS4XOEYwRxm3PZBSLFcldA5B5IrqWHDZ4pvS4fi1fEnHWpXIrzHxXkHAqFDq5chpUiQfpjDYvzNOshIXRXpU1XxTYIPBMTn8rC0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788008811; c=relaxed/simple; bh=cCauXrC/bvEWWmuAeczaqiHNRpfcepfKAkAqqypm6s0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G/6HqXKFOdvTCokVMjfG09aG8zVLVaQR4edXq6J4gE1enmp8psVuIiUnmZmYkSUFztsCiFi9HhJdv4QQoXDi+d8dU86YE5rrrpDAn42uBbgcp55TWXOwkDwKVVNkwJNWSP5/ukX23kk9Uq7IOCt5LW84p8RikwCo+dIIIVr5IqY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S6vQJha5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S6vQJha5" Received: by smtp.kernel.org (Postfix) with ESMTPS id 23D5CC2BCF5; Sat, 29 Aug 2026 13:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788008811; bh=cCauXrC/bvEWWmuAeczaqiHNRpfcepfKAkAqqypm6s0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=S6vQJha5GJmTgyJxG4sduYBknLaGGphLXEHOxnOgKZ6QbMi7jwbDNaoejfmDLcBFg 1jmWHdxXVnMtrRCxzt2MObFTm0LES6jEFzsL+GHqCEW9yHXIJLJVthsveNJnnVdMt9 HJ779UDbGundhb+upobsCKRPq8MWuM3mtNCD7ZOoKuM/NkW6UPlS+J/NKH3gi83CYw UqUPJPSfz/M5mhjW8AuDrXp6W2htnz2Z2NhFnq4evDnGJCKzF0DM4fvjPm9L9GWQKM wozEUgGoRmquqDCVrdMgR8w1nFDt8UZ+j5dJyquXlgatVTAZTNzB4J7kpClrzHvp6I vuec+55zPKeoA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06BEEC61DE1; Sat, 29 Aug 2026 13:06:51 +0000 (UTC) From: Muzaffer Kadir via B4 Relay Date: Sat, 29 Aug 2026 16:06:34 +0300 Subject: [PATCH v2 2/2] media: i2c: imx258: Add reset-gpio support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260829-imx258-add-reset-gpio-patch-v2-2-bfd27891e225@mainlining.org> References: <20260829-imx258-add-reset-gpio-patch-v2-0-bfd27891e225@mainlining.org> In-Reply-To: <20260829-imx258-add-reset-gpio-patch-v2-0-bfd27891e225@mainlining.org> To: Sakari Ailus , Mauro Carvalho Chehab Cc: git@luigi311.com, pavel@ucw.cz, tomm.merciai@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Muzaffer Kadir , =?utf-8?q?Ond=C5=99ej_Jirman?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788008809; l=2313; i=muzafferkadir@mainlining.org; s=20260816; h=from:subject:message-id; bh=AbYnmMAAO6Q9SZ+P54cCQpoqnvvpRe+zS71V1ysAPrU=; b=q9yuk/z81n9lwAaG9CVZRENF6xYpN494oOHBNgm4PDrgsUWBU/jpJuYhF2X2VZb7LQnaLhOW7 rxMdLz8rY0pCjBy0VOet2rdRknrGvoZ+AXn1bbyN275zh+Yxf7l5+df X-Developer-Key: i=muzafferkadir@mainlining.org; a=ed25519; pk=4zkv4suQ3cYcO4Z7CrV8JSSjEGLBGepUtvQCFjgnYIU= X-Endpoint-Received: by B4 Relay for muzafferkadir@mainlining.org/20260816 with auth_id=954 X-Original-From: Muzaffer Kadir Reply-To: muzafferkadir@mainlining.org From: Muzaffer Kadir reset-gpio is already documented in dt-bindings but never implemented in the driver. Signed-off-by: Muzaffer Kadir Tested-by: Rudraksha Gupta --- drivers/media/i2c/imx258.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index 9c3a6579df0d..4a0663e816b5 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -9,6 +9,7 @@ #include #include #include +#include =20 #include #include @@ -681,6 +682,7 @@ struct imx258 { =20 struct clk *clk; struct regulator_bulk_data supplies[IMX258_NUM_SUPPLIES]; + struct gpio_desc *reset_gpio; }; =20 static inline struct imx258 *to_imx258(struct v4l2_subdev *_sd) @@ -1127,10 +1129,23 @@ static int imx258_power_on(struct device *dev) ret =3D clk_prepare_enable(imx258->clk); if (ret) { dev_err(dev, "failed to enable clock\n"); - regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); + goto err_disable_regulators; + } + + ret =3D gpiod_set_value_cansleep(imx258->reset_gpio, 0); + if (ret) { + dev_err(dev, "failed to deassert reset\n"); + goto err_disable_clk; } fsleep(400); =20 + return ret; + +err_disable_clk: + clk_disable_unprepare(imx258->clk); +err_disable_regulators: + regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); + return ret; } =20 @@ -1139,6 +1154,7 @@ static int imx258_power_off(struct device *dev) struct v4l2_subdev *sd =3D dev_get_drvdata(dev); struct imx258 *imx258 =3D to_imx258(sd); =20 + gpiod_set_value_cansleep(imx258->reset_gpio, 1); clk_disable_unprepare(imx258->clk); regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); =20 @@ -1383,6 +1399,12 @@ static int imx258_probe(struct i2c_client *client) return ret; } =20 + imx258->reset_gpio =3D devm_gpiod_get_optional(imx258->dev, "reset", + GPIOD_OUT_HIGH); + if (IS_ERR(imx258->reset_gpio)) + return dev_err_probe(imx258->dev, PTR_ERR(imx258->reset_gpio), + "Failed to get reset-gpios\n"); + ret =3D imx258_get_regulators(imx258); if (ret) return dev_err_probe(imx258->dev, ret, --=20 2.54.0