From nobody Sat Sep 26 22:55:49 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012050.outbound.protection.outlook.com [40.93.195.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 693E32B9B7; Fri, 28 Aug 2026 14:59:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929161; cv=fail; b=mxhVEa8vRR5U1Nzics8RBZbAzrM55pR9HaDK0IVfCQvwMlHYYJEOtLwzFDTAyumA4nXsbmjI1Mo+cz0rk/droJsrkXH9VRw18QYGMCRPiRQz/xLXGBKWQAGF6Qqqls7rBApJBNV4mwY4FK6YOgyStlHD+3hOJwvcGwe7nHsp3L8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929161; c=relaxed/simple; bh=LyW4sej8DQil3ygriqUJNiWSHDNhUKLsKrXijndzfR8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hCY1CZzeCO08HVbUmof636gl3hzeZr6HZA/o8wTLH9jHABPeXkNQOYMzX4XFyS9zblFC/mGosaaAndoHbAt8PNSxC8FihbvtMSGtSu8u7qEKtAez6/qHD6ZsxPpJC3tqi2le5L8Wuj1XJZELRcoUYCavch6c/9o10GbRM0Q5wuM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=5Abz3QfN; arc=fail smtp.client-ip=40.93.195.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="5Abz3QfN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NYriUYG6igXO+YObpj9oe/KQcRi5NVO8grfVw6rYI3vm56wQPnqVxNzUwSXBfciYOhB0l5yUPHxvQVsVnW2xbIbxEvjwEdoRSRt+HjMBDTWlXkLv03jiOGZLshIAB9oLQllJ4Wpor3wcI8LSdl+PEBQ+rqF/JiZPBKa08TDeXtE0SGOfi3UH/pp7DNLyJ8hzZtABJh+X23XThZQPC05UpfKgWUZ+tg/aNSofer4ABw2ZlkoustOjmmFDLYef+/E8axtn5B8/iEafokexYKiOgrBH3Z9H74ok78GP07IkuzuriBwj4pAwbQXn+3kICJtId52sF3e1fVA744R659ebxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BU/sinYNZ0E1P0CNVsEKgqCvoYfyFFTBSuoTJJJCbBU=; b=qCb8H68GgitjXsFbCoagQ2l3tZ6zZUbyZWIK6X5Wyc5r4jwp7Ex/kB4t8LH/J+KZbxu4a7FM2adTWUnbYMqJfCJf8/sR5MGQpMIOR6Nxt2PyOrXZe1ssZFzvfAh+30kV81b5451jrVFtcB+ky1kLsEjHBxEYqb6aXQi9u3zgvJxeIVyqmGG7+a5oiDctHpHV0OPJ0EF79cIMXBikl/OjBJffSGf6g3V5OlpIjkihJtvzwPNzHTYC9NKKezAd3v6M32EajhFZHdlmvmiTYshDzROLffJlpryf+hRHR88DULVjFDvQZDjvI2RbzDE3xVaIK84wOvHc3Ei3dep5CFYJ/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BU/sinYNZ0E1P0CNVsEKgqCvoYfyFFTBSuoTJJJCbBU=; b=5Abz3QfNN6P37qITFuFbB+S4nauq1lmLVh9IkGkuT7YAsu4jbddXwCjHKo3V+ARkVbvoCejHoUJrq2+7JY4gQF+c7mfPtMvQyNU2PDo2UrOxDgY/FtmlRc2D7Kug4oUSO7MDROlPeqYtENHc3SfIn4sBRoWc80u8t3QuUdTlvlI= Received: from BN9P221CA0016.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::18) by PH7PR12MB6953.namprd12.prod.outlook.com (2603:10b6:510:1ac::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.7; Fri, 28 Aug 2026 14:59:15 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:408:10a:cafe::92) by BN9P221CA0016.outlook.office365.com (2603:10b6:408:10a::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.11 via Frontend Transport; Fri, 28 Aug 2026 14:59:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 28 Aug 2026 14:59:15 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 28 Aug 2026 09:59:12 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Fri, 28 Aug 2026 09:59:12 -0500 From: Tanmay Shah To: , , , CC: , , , Tanmay Shah Subject: [PATCH v8 1/5] rpmsg: virtio_rpmsg_bus: rename rbufs and sbufs Date: Fri, 28 Aug 2026 07:58:48 -0700 Message-ID: <20260828145853.2843486-2-tanmay.shah@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828145853.2843486-1-tanmay.shah@amd.com> References: <20260828145853.2843486-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|PH7PR12MB6953:EE_ X-MS-Office365-Filtering-Correlation-Id: 8419eeda-c2de-4939-af6a-08df0514eddf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|23010399003|36860700016|22082099003|18002099003|11063799006|56012099006|6133799003|10067099003; X-Microsoft-Antispam-Message-Info: 7E7sbMsv1CMHwMRDbHkgPrhCX4lgYrt4PXBYjjG02A2DE1EZiIpGRKXrzGH2FxVh0pV7AshtU4HBXl5F/tV9bHEe+tpreEzX2y1J0E7ylL1n0l/ORwBmGdHfZhe8XbB+4kNY3DMG8Y4Kt/dNMdwKQPJjkVE9MlUgnJTSDu5fvZTR+FY/6UEaghW8Khn9wxKB5omsONgKFii9qw2aukC8Sf76JMCMG3ssmh3LxDXehPfaZCX9xhEJtbPRLbQCdNLjMANl3J+/WKEW9KAvQ+Kdlg13f/OHDczJy4HOuk7A+I7YcymSN5jvvI+sM9hN4oAINd5Mi6QF9TNH03FFFEMUqnOMa/JhjXS4R5gCeB3r3MFvmmffDO2dAmYs/Yn/donUN+jAXz+i5IaASNuuwwW6h9R0MJSR9AcsdLDbXqpeM6E3BHcrLXGg2zJPnqKWZhEk9+feF7puChjrPEito1Tm2yOP5Hd0fWcd208bV20/RNM/DOaRWekBU4KCUjWG0LthI3IjZfsRRq09nGpsqj+AnaIRu+f3D25vDDEQ2ujMjHGneoKs77t7ojPeYO6YxrXL0z59LjAta6o6Lzkdh/Me5cEhvaNJFzNQf+Bpt2imHWmNcESJ2wRRUfyoMh29eWFRq9QROobrE80IuV3CDQx6pil40qnkVPAQoh6ExyD87RC6wUt5fSlp6AxPVH7/+NbJg6OA75v3kG8AGvfq+AdtKQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(23010399003)(36860700016)(22082099003)(18002099003)(11063799006)(56012099006)(6133799003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zz6G3Eabiv0cH1hmjoStf0QTTiUEr2gSp/hBo1DhZWoWmEKkU9lhwFUamO1olnpo4atS4YXnwlUb1mSutRAmbpKJojH4YMkV/5h93UR7jWPUsn05Nns86CKx3j6fy15g+Ax2Fn91H2C6WugY3dpQBgaRLbzsUQIg3FhZx5sGqqL9jBPnS97DQpUu6VBUnM+IwHn/43eCIz3fwt1E6UIJGgD1LIzY+Aliabqz2Cl0T3IzZAmTeZoBaQPzSfneKV+A4eIYIT7AD5B6clGqkrzV2E79Xo/PYycketPdtCZhiVjOm/LY3p6doX2toM7kjkPcL9o/4VFH6QlTZ26p+QtKwwJvDkgIvGYQCm/l46MDU9Pc+maP1aamTHvEQlRQdQKpNCo1YAH381ESvxe4e4c0K6PiULynXenMbdtI/soUoqA5W0DBq2kZuoXrjqMoESB8 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2026 14:59:15.7819 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8419eeda-c2de-4939-af6a-08df0514eddf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6953 Content-Type: text/plain; charset="utf-8" rename variables with clear names. %s/rbufs/rx_bufs/ %s/sbufs/tx_bufs/ %s/last_sbuf/last_tx_buf/ Signed-off-by: Tanmay Shah Acked-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_= bus.c index 1b8bb05924af..55cd65b14f80 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -35,13 +35,13 @@ * @vdev: the virtio device * @rvq: rx virtqueue * @svq: tx virtqueue - * @rbufs: kernel address of rx buffers - * @sbufs: kernel address of tx buffers - * @num_bufs: total number of buffers for rx and tx + * @rx_bufs: kernel address of rx buffers + * @tx_bufs: kernel address of tx buffers + * @num_bufs: total number of buffers for rx and tx * @buf_size: size of one rx or tx buffer - * @last_sbuf: index of last tx buffer used + * @last_tx_buf: index of last tx buffer used * @bufs_dma: dma base addr of the buffers - * @tx_lock: protects svq and sbufs, to allow concurrent senders. + * @tx_lock: protects svq and tx_bufs, to allow concurrent senders. * sending a message might require waking up a dozing remote * processor, which involves sleeping, hence the mutex. * @endpoints: idr of local endpoints, allows fast retrieval @@ -55,10 +55,10 @@ struct virtproc_info { struct virtio_device *vdev; struct virtqueue *rvq, *svq; - void *rbufs, *sbufs; + void *rx_bufs, *tx_bufs; unsigned int num_bufs; unsigned int buf_size; - int last_sbuf; + int last_tx_buf; dma_addr_t bufs_dma; struct mutex tx_lock; struct idr endpoints; @@ -443,8 +443,8 @@ static void *get_a_tx_buf(struct virtproc_info *vrp) * either pick the next unused tx buffer * (half of our buffers are used for sending messages) */ - if (vrp->last_sbuf < vrp->num_bufs / 2) - ret =3D vrp->sbufs + vrp->buf_size * vrp->last_sbuf++; + if (vrp->last_tx_buf < vrp->num_bufs / 2) + ret =3D vrp->tx_bufs + vrp->buf_size * vrp->last_tx_buf++; /* or recycle a used one */ else ret =3D virtqueue_get_buf(vrp->svq, &len); @@ -634,7 +634,7 @@ static __poll_t virtio_rpmsg_poll(struct rpmsg_endpoint= *ept, struct file *filp, * allocated buffers are used for transmit, hence num_bufs / 2), or, * - we ask the virtqueue if there's a buffer available */ - if (vrp->last_sbuf < vrp->num_bufs / 2 || + if (vrp->last_tx_buf < vrp->num_bufs / 2 || !virtqueue_enable_cb(vrp->svq)) mask |=3D EPOLLOUT; =20 @@ -872,15 +872,15 @@ static int rpmsg_probe(struct virtio_device *vdev) bufs_va, &vrp->bufs_dma); =20 /* half of the buffers is dedicated for RX */ - vrp->rbufs =3D bufs_va; + vrp->rx_bufs =3D bufs_va; =20 /* and half is dedicated for TX */ - vrp->sbufs =3D bufs_va + total_buf_space / 2; + vrp->tx_bufs =3D bufs_va + total_buf_space / 2; =20 /* set up the receive buffers */ for (i =3D 0; i < vrp->num_bufs / 2; i++) { struct scatterlist sg; - void *cpu_addr =3D vrp->rbufs + i * vrp->buf_size; + void *cpu_addr =3D vrp->rx_bufs + i * vrp->buf_size; =20 rpmsg_sg_init(&sg, cpu_addr, vrp->buf_size); =20 @@ -979,7 +979,7 @@ static void rpmsg_remove(struct virtio_device *vdev) vdev->config->del_vqs(vrp->vdev); =20 dma_free_coherent(vdev->dev.parent, total_buf_space, - vrp->rbufs, vrp->bufs_dma); + vrp->rx_bufs, vrp->bufs_dma); =20 kfree(vrp); } --=20 2.43.0 From nobody Sat Sep 26 22:55:49 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010001.outbound.protection.outlook.com [52.101.46.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 906A947255A; Fri, 28 Aug 2026 14:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929164; cv=fail; b=BGbAygq+jLbBnKz4Kedt56csIFQdEka5a1FLZwCHVOqqOpJQ6UEoD+jLq6epvS9FQ7hKJiUQYCvj3MCPaAQTuAOp0MQwuFwvpzvoB4JuCxgh4dB9TwklhSZgYanTpBO4Ru35gfpo1V2daRrGwlGCg3h/XLoPyiVgoQPHZLEGg0U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929164; c=relaxed/simple; bh=5AwMKzju6PhWHQxfDiLU63hz1jLmQ3aQoKka46mJQ0E=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Rsm25n3878KFHkBH86x4fxBic5pCC0/QZSwFCNqfJEif6/2UyrWWLg94I30YyleOcjjlBlin73QntmVL/mfhsiTe8Az4eBOkq/0byjQlowiBz/M8pXYFhcUvOZmwlJ1JZ1zdm0AyFMHxPF0mi/s8IucfVl85TxOzEdZd3+6ja0w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=aEuLzDat; arc=fail smtp.client-ip=52.101.46.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="aEuLzDat" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YHaKAfgF8Em/6FrK1CtAlt0bHWmBe8lVLEEApAmp1oc3etWEIf5hs56LvZ2488Gyr1Y3Uius1JcM+qleNn9RPkG7KC6Ki19+q6XqRaeHUtbX30GatQ9NLFYVEOwZJyQqMJo1SLduR0BUtIwRyuRy1Tu0bCsPD1Ljo+hvujwLZa2IyM2BUQbGwMDw3fIOh3WNS/3g0haxvKfHXSnxrDJouM1MGJzSeIhDlQHzsFvnwsGZbpoYyJA1Lhw9vUjpRs7knAjJ2Kjav8zeSeldhEPxtpPSRZf9oR41/FVkxXFBpwXQXyyRErtZpUwC29ZE0zCsItNdarRu2rf0quzoFxPWIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mOkpZ/hEZvjsFz/RgHuk3M2JT0CUWeaDXGg9RHQZJKk=; b=CizYi29fYSbLsUxIvoBr95cy8uWce+dSTaJdv1Zekb1Lm77D1saU7KLJ/aylzPd6YKtLzIiYkj0eUATg2f0DiQ7+VG1345V0+NYwViaYRdOjy1ORmVkQvuYURc/TtQYmrJD7tbwREPQ8ofZlSo5Elp7IqxVSbrK537kggDXWNGmgQVMs4KJV2VvAIDjClKGEDJMiyu4clc+bsCWDqVKLtZaQwnT6rkB85amPFaZ1ycmZNNFoPHf96zSC/7n0Jj9coqZZSEDBohYL78yKvq0yQ6FU8WmSJJmVmpnI1maChDg0U8ARUslMWBG8BQXwDYpULYmceoKzOe0eI7GhcLiQyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mOkpZ/hEZvjsFz/RgHuk3M2JT0CUWeaDXGg9RHQZJKk=; b=aEuLzDatkxEPF5rvK2A92QzJTGYV0f5pHFLRXTHtChOkHUiS7O5hLeCWKCJib0B3rPwSF/QNQHZVHwGIrnrbPMTb4+/jqv8r23LmeI6UqygB3MF1kXef9XvOOYHedGse8FTPjVwgXhddZS4FS24KnGHG4z7hRx+4yYb49XCvXcw= Received: from BN9P221CA0016.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::18) by CY8PR12MB7563.namprd12.prod.outlook.com (2603:10b6:930:96::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.10; Fri, 28 Aug 2026 14:59:16 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:408:10a:cafe::aa) by BN9P221CA0016.outlook.office365.com (2603:10b6:408:10a::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.11 via Frontend Transport; Fri, 28 Aug 2026 14:59:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 28 Aug 2026 14:59:16 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 28 Aug 2026 09:59:13 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Fri, 28 Aug 2026 09:59:12 -0500 From: Tanmay Shah To: , , , CC: , , , Tanmay Shah Subject: [PATCH v8 2/5] rpmsg: virtio_rpmsg_bus: allow different size of tx and rx bufs Date: Fri, 28 Aug 2026 07:58:49 -0700 Message-ID: <20260828145853.2843486-3-tanmay.shah@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828145853.2843486-1-tanmay.shah@amd.com> References: <20260828145853.2843486-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|CY8PR12MB7563:EE_ X-MS-Office365-Filtering-Correlation-Id: 87494f79-71a7-4a9e-27a4-08df0514ee24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|1800799024|376014|23010399003|82310400026|10067099003|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: hg0uv9g8nmV30v2+lHlLLIhJ0U3G4AvbZRi5iivNQr/XyFWdgNdHl7qt89C4buN4psEixwAXSSayJyU8kjB3xj7fPTfbdwgyPfd19vB9PexJwyqJ7oj+XkZZuzcr9DBEf97+jrL0+fZ/nymmhIB+Ys3NdcYeP3orvcOF1rVnzS6j0rSgRslasMrryCUfyB/IJkgVhxxRYgeixPsc6doc+3kudzM6pMFmAYbgbfh1ulk+OjH76im5xfN7SSC2EbVq5WaFqufUek3zzen2PYUIL2j4ZHsl4SB+noNqCTgzanrKPOxXsPAYifRizxUeLLRPxjdkpmUPE2sgOxy2Q9/S7IaXDWGs9aoGOCBGYg+8e+eD9B2yCaKXGfnGqA1RlpZWGpcu6VOhhJ2hGgliVAjoX2GxfDhhoDsGdT3keJ3gzdM/PmU/vaV9Oc6ZQxmY860GWacJfvr8GZtfh1M65VNB5abFzVLjpdq4tFjXLavFt8zwV/FtogQRvS5Jb4qJC7b5TAofbhBAFWzzhIUJKz/g2/j8w+3zq6ilQYhOHDYMZfgLU3gCx3uZUfQ9a13eBeBzoGfxxs8KcpRMHRPedHSVfCpBjeWsTZ28tht6yycINeek1ag5y7vsZvWomi9Uu/Xy0d2TwsuV3gR35eIZ5sqX4lMpmE+8kruXLA+7D+uiQHYczqG8TLsUaLTgT14Fci+ZdZM5Ljv0Zy2xVLwyyvmHHw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(1800799024)(376014)(23010399003)(82310400026)(10067099003)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Fvn+nRIKYjbAMjB5EPXwXah3L9CwHh/RKPIlt7SvGYSD22y/SI6FtyOCfQRl0BdJoFnU1M1JQojs0tmG9ubxYlo50F16irIs+65I4Uu4MkzgJ0mgg2lVkuMjFzHU2yIN4iQbGIWiQrxvqrtaFaA0sHClGtUk2rSKvMogfe9So433eNqwcfpPMMI/9bRxBF6TpcgcLbh3EiD59WBnLe8bO3DbUD6KZHqCVY2S4Kjf8QZNpTyKJqlWl5v457ui9u4r/7gKQw5Br2gw1kuCX+zxPmYn72H2qJ/V6n+29AYWCiZua6ok9nPpflmORqPm5k9OldHO4DxxlyZnvTmPXOW22vIRCK6UVDuvZJAv46wOih7T18cwDcqn4HTBobDz+i6Hu/uN77tt76VXt/9+RdEpI7NKUGkcMZS1468cDY/rUCpzlFj54V2EEjZD5Mc9Is4G X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2026 14:59:16.2254 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87494f79-71a7-4a9e-27a4-08df0514ee24 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7563 Content-Type: text/plain; charset="utf-8" Current design allocates memory for tx and rx buffers equally. The throughput can be increased if the user is allowed to configure number of tx and rx buffers as required. Hence, do not split number of tx & rx buffers into half, but decide based on respective vring size. Signed-off-by: Tanmay Shah Acked-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 50 ++++++++++++++++---------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_= bus.c index 55cd65b14f80..c84b6cec9caf 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -37,7 +37,8 @@ * @svq: tx virtqueue * @rx_bufs: kernel address of rx buffers * @tx_bufs: kernel address of tx buffers - * @num_bufs: total number of buffers for rx and tx + * @num_rx_buf: total number of rx buffers + * @num_tx_buf: total number of tx buffers * @buf_size: size of one rx or tx buffer * @last_tx_buf: index of last tx buffer used * @bufs_dma: dma base addr of the buffers @@ -56,7 +57,8 @@ struct virtproc_info { struct virtio_device *vdev; struct virtqueue *rvq, *svq; void *rx_bufs, *tx_bufs; - unsigned int num_bufs; + unsigned int num_rx_buf; + unsigned int num_tx_buf; unsigned int buf_size; int last_tx_buf; dma_addr_t bufs_dma; @@ -110,7 +112,7 @@ struct virtio_rpmsg_channel { /* * We're allocating buffers of 512 bytes each for communications. The * number of buffers will be computed from the number of buffers supported - * by the vring, upto a maximum of 512 buffers (256 in each direction). + * by the vring, up to a maximum of 256 in each direction. * * Each buffer will have 16 bytes for the msg header and 496 bytes for * the payload. @@ -125,7 +127,7 @@ struct virtio_rpmsg_channel { * can change this without changing anything in the firmware of the remote * processor. */ -#define MAX_RPMSG_NUM_BUFS (512) +#define MAX_RPMSG_NUM_BUFS (256) #define MAX_RPMSG_BUF_SIZE (512) =20 /* @@ -439,11 +441,8 @@ static void *get_a_tx_buf(struct virtproc_info *vrp) =20 mutex_lock(&vrp->tx_lock); =20 - /* - * either pick the next unused tx buffer - * (half of our buffers are used for sending messages) - */ - if (vrp->last_tx_buf < vrp->num_bufs / 2) + /* either pick the next unused tx buffer */ + if (vrp->last_tx_buf < vrp->num_tx_buf) ret =3D vrp->tx_bufs + vrp->buf_size * vrp->last_tx_buf++; /* or recycle a used one */ else @@ -630,11 +629,10 @@ static __poll_t virtio_rpmsg_poll(struct rpmsg_endpoi= nt *ept, struct file *filp, =20 /* * check for a free buffer, either: - * - we haven't used all of the available transmit buffers (half of the - * allocated buffers are used for transmit, hence num_bufs / 2), or, + * - we haven't used all of the available transmit buffers or, * - we ask the virtqueue if there's a buffer available */ - if (vrp->last_tx_buf < vrp->num_bufs / 2 || + if (vrp->last_tx_buf < vrp->num_tx_buf || !virtqueue_enable_cb(vrp->svq)) mask |=3D EPOLLOUT; =20 @@ -845,19 +843,20 @@ static int rpmsg_probe(struct virtio_device *vdev) vrp->rvq =3D vqs[0]; vrp->svq =3D vqs[1]; =20 - /* we expect symmetric tx/rx vrings */ - WARN_ON(virtqueue_get_vring_size(vrp->rvq) !=3D - virtqueue_get_vring_size(vrp->svq)); - /* we need less buffers if vrings are small */ - if (virtqueue_get_vring_size(vrp->rvq) < MAX_RPMSG_NUM_BUFS / 2) - vrp->num_bufs =3D virtqueue_get_vring_size(vrp->rvq) * 2; + if (virtqueue_get_vring_size(vrp->rvq) < MAX_RPMSG_NUM_BUFS) + vrp->num_rx_buf =3D virtqueue_get_vring_size(vrp->rvq); + else + vrp->num_rx_buf =3D MAX_RPMSG_NUM_BUFS; + + if (virtqueue_get_vring_size(vrp->svq) < MAX_RPMSG_NUM_BUFS) + vrp->num_tx_buf =3D virtqueue_get_vring_size(vrp->svq); else - vrp->num_bufs =3D MAX_RPMSG_NUM_BUFS; + vrp->num_tx_buf =3D MAX_RPMSG_NUM_BUFS; =20 vrp->buf_size =3D MAX_RPMSG_BUF_SIZE; =20 - total_buf_space =3D vrp->num_bufs * vrp->buf_size; + total_buf_space =3D (vrp->num_rx_buf + vrp->num_tx_buf) * vrp->buf_size; =20 /* allocate coherent memory for the buffers */ bufs_va =3D dma_alloc_coherent(vdev->dev.parent, @@ -871,14 +870,14 @@ static int rpmsg_probe(struct virtio_device *vdev) dev_dbg(&vdev->dev, "buffers: va %p, dma %pad\n", bufs_va, &vrp->bufs_dma); =20 - /* half of the buffers is dedicated for RX */ + /* first part of the buffers is dedicated for RX */ vrp->rx_bufs =3D bufs_va; =20 - /* and half is dedicated for TX */ - vrp->tx_bufs =3D bufs_va + total_buf_space / 2; + /* and second part is dedicated for TX */ + vrp->tx_bufs =3D bufs_va + vrp->num_rx_buf * vrp->buf_size; =20 /* set up the receive buffers */ - for (i =3D 0; i < vrp->num_bufs / 2; i++) { + for (i =3D 0; i < vrp->num_rx_buf; i++) { struct scatterlist sg; void *cpu_addr =3D vrp->rx_bufs + i * vrp->buf_size; =20 @@ -965,7 +964,8 @@ static int rpmsg_remove_device(struct device *dev, void= *data) static void rpmsg_remove(struct virtio_device *vdev) { struct virtproc_info *vrp =3D vdev->priv; - size_t total_buf_space =3D vrp->num_bufs * vrp->buf_size; + unsigned int num_bufs =3D vrp->num_rx_buf + vrp->num_tx_buf; + size_t total_buf_space =3D num_bufs * vrp->buf_size; int ret; =20 virtio_reset_device(vdev); --=20 2.43.0 From nobody Sat Sep 26 22:55:49 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011008.outbound.protection.outlook.com [52.101.52.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC1B747255B; Fri, 28 Aug 2026 14:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929164; cv=fail; b=CaJhaeu9ibZSm0p4EWrfr5JvFVZVatM9FJjQRnwy8ccd9kwk1jnM6LqjgpwSnQV17HAC6hC7EFgtSNwN8COIxYTR1vYmBFlWB46oC7Wvkn34HWyRm2qyd553YV/O9pX3jSadP2hZLcbX4zgwMDhDj/hyJiVj8zuO6AB5DEOjeNM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929164; c=relaxed/simple; bh=8WWd83+V2uGv236U7atTphBHEO+riCez6RiglcITh90=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rgSC+rwZbCpBUujBGhKqIjSSWhFvy2HSaPr4/6VI6oJ59H3V4g0c6zanfZ9ubuqSgqSVWE4yEgaeqZUtUjotTgCfSbzeS+uILeUOiDPF3vZJ6M3j2hPTTJyWIvLXtAX+j/m/zgaKTLeIJEGONor9XJ9FT3KNPKxfSSVZcL0rtM4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=nBxLeFaF; arc=fail smtp.client-ip=52.101.52.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="nBxLeFaF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z4H+QgntPAmaoQBVHu3gQ/IbLx5rJA34sZVSdX2UD9rYgVdx+2kVPJHmEaPGp8A3GIi5CPjFKKnhWb/ZYzTGhHV+mvptX8wXeE8dEVb6S1AbeeVBwE/c/6z5+ZGLaIHAJd58V0OR0/L+Zb3UfvW7oQ6RNmjxIwltMeR9Cryonj+uJK9BCmHIKX4mI4dFJo9wfy4T8vOBpUWy4x9cd0MGShk0AsH9UQQjbfxSHMbyW2e5ifsGIabXzuD03XitjdIS81Z+Y1GkXZKg2R4cKQl9ptkTNoIchFCpDJTx2pCnq2ukdajpBvgTbS8rrN9LHtFeweSNIbWeiOAUkjp1WL48vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lQETnP+cNRuJ8xPsqSCQVLcuWk4JLmqBILinE0lT9xI=; b=kke0htNRcF46t1gqqDWHopN3TMrOINdu8YxT2mBZr/u8T2lNlb4TRc15foXWQh6HaNCZXUfCkJ1QGjr3o78uxxbEjRi5B3TMWBppQrO2/gNqL9L6POgnNaQockLwMWuYr9MbZnL0syKIbqaH8xBkIweIsimdihTqwqlDduubymhvTvSLPvFsXYTgxbVvnEpMVjgCOG/Jp2romJU8UfCvMzdpTLvtHz2RSO2FTYQ6bBoAqB9mA0U7POByonT3eMb6l5FWTc8Dur34Y4kIJdWd1JEoi468Lypqy0qvpAO+1Z3qXv7z9YHZWhWlgFhBsREg0KRp8Gn7dyIE7Dtx/MW0yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lQETnP+cNRuJ8xPsqSCQVLcuWk4JLmqBILinE0lT9xI=; b=nBxLeFaFpT9qNJG1u553stkWOCf6M9vWqquSHXVXXbHiZgNvErpOsluezrT5dT9wwUFXYIlsu3TfHHM4Eki+5EXpM+FF15Rxa5CKTiS8mcGwDToRvBlR5oXsqeF6kzlwMKS+DwPhEWBWJzIPdUzya+s3hDxZNwPE/G40QYIWVaQ= Received: from BN9P221CA0021.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::15) by SA3PR12MB9132.namprd12.prod.outlook.com (2603:10b6:806:394::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.10; Fri, 28 Aug 2026 14:59:17 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:408:10a:cafe::72) by BN9P221CA0021.outlook.office365.com (2603:10b6:408:10a::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.339.12 via Frontend Transport; Fri, 28 Aug 2026 14:59:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 28 Aug 2026 14:59:17 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 28 Aug 2026 09:59:14 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Fri, 28 Aug 2026 09:59:13 -0500 From: Tanmay Shah To: , , , CC: , , , Tanmay Shah Subject: [PATCH v8 3/5] rpmsg: virtio_rpmsg_bus: get buffer size from config space Date: Fri, 28 Aug 2026 07:58:50 -0700 Message-ID: <20260828145853.2843486-4-tanmay.shah@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828145853.2843486-1-tanmay.shah@amd.com> References: <20260828145853.2843486-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|SA3PR12MB9132:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f962384-52c6-44ef-9ccb-08df0514ef03 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|23010399003|36860700016|10067099003|6133799003|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: BceOOsPbMRHbq0ZNHzxJV7pz7nBu1MHEDWTOKOp8YqiD9OwiBdVqGNWKTAh4tYdvr/gFqz4ET9ljGxRVKUhunjHAZDOvKkXqW+cSvOvJbawspsHI4DeDL+AqQ+TS0QoQpfeuv+6TJgsYDF4X6/waKtEoMi0rYA4K3f8GARQDEbCnEXnRefRf4wEfa7AibPbSZqNqP3IVGN0tB8E+BQdh3bz4lWElcrCy4xP+GKBEi/3CKzRj5qv4nbSuGoBjyNWP6C9K4+6OJnsDmoPt40ZJTX33d1cs/PwnSE8J/KKyxGVBJRdKfTB+Ut7zeG9rAYwbBCKfDx7v7t4R7twJtpaClthOw+eNrojt6ljTAVGjQCZY1EnN0VU4JyAg5xugjGYf8K6NpKF2geUoW6nrkW4TzVRhpF51hocBJq+2NK+m7ELP8ttu5R1gSyNvhnRZvQl0qQwsgcUIY4gFUcBv4TlY7qo0KMIUxp3THNsReBJGUgXOXF6iKac6kwekZuCp6gdh6CBQn6xS4kQ5wizM14nIUEam3fxHKHVFl97XC0PZPo/VHtLKQfDZj09a5g9RTh0q0kP2mjEtMKW3AHYfcqoaX3J30J319NVJ2j5SxjlIj1smKE+ogXZ9R5sg8ztb0NWmnvSwCtdIpMfZtX8cPr/RBRWm2bmS3cXZ0n5I96/8rmGxarEQbHZCgKrjSZ89tT2gYZccbFKNYZWVm2DO9Hut3g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(23010399003)(36860700016)(10067099003)(6133799003)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vAxvoFMRT9BcpkkNBK4w9qaYwiNPooKRXjTGBoQAZg/0XGDJOfcTMTUMmn96wUdGtsvr6Ori4BquEpgpbQYQUFDJ3FA9uJB7IKp72wTbeIFnjvt/X+xz3kUNnroh2RXKCv5OIM/sP5Ox5M8hZ7gukJ7gbspureSyjn4RTTO10vrqbQFBrXzMq8J4lEUI+AcP9WtfG2gpKjKOFjOZymJ3BNwWIcB95DjqZVEIkItuMeZBjeMVr5Yki6oBSJTxy95ehcWeAvdmpbZ/rCFaCpyM4eGBdWAsH4QU+EYKd2NBwSQ2aw0zqzUSI+lySLwTdAfzCJzg7QlOQW45HFx2J/+7jmVUdcAQxkma9Egi0aqFM7qSLyJbYk8cRd5uHvufOsSNlD832fnqSeOUFD2DN0IWtsqMM2D2EMHHtjB1St5S6LP2H8TBTNOyDJBuo7WYEZi8 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2026 14:59:17.7026 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f962384-52c6-44ef-9ccb-08df0514ef03 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9132 Content-Type: text/plain; charset="utf-8" 512 bytes isn't always suitable for all the cases, let firmware maker decide the best value from the resource table. Enabled by VIRTIO_RPMSG_F_BUFSZ feature bit. Signed-off-by: Tanmay Shah Acked-by: Arnaud Pouliquen --- Changes in v8: - fix commit message of 3/5, "%s/enable/Enabled" - introduce new function to get buffer size for the vdev device - fix description of VIRTIO_RPMSG_F_BUFSZ define changes in v6: - remove buffer alignment from config space Changes in v5: - fix documentation about alignment of the buffer size - change version field from u16 to u8 - remove buffer alignment check - Separate buffer alignment vs MTU of a single buffer - Use buffer alignment only to get next buffer address at alignment boundary Changes in v4: - Introduce new patch to modify rpmsg.rst documentation - check version is always 1. - check size field is same as size of struct virtio_rpmsg_config - introduce alignment field - check alignment field is power of 2 - check tx and rx buf size is aligned with alignment passed in the structure Changes in v3: - change version field from u16 to u8 - introduce size field in the rpmsg_virtio_config structure - check version field is set to any non-zero value. - check size field is not 0. - Remove field for private config, as not needed for now. - add documentation of rpmsg_virtio_config structure drivers/rpmsg/virtio_rpmsg_bus.c | 100 +++++++++++++++++++++++------ include/linux/rpmsg/virtio_rpmsg.h | 41 ++++++++++++ 2 files changed, 122 insertions(+), 19 deletions(-) create mode 100644 include/linux/rpmsg/virtio_rpmsg.h diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_= bus.c index c84b6cec9caf..40ec93fedde9 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -39,7 +40,8 @@ * @tx_bufs: kernel address of tx buffers * @num_rx_buf: total number of rx buffers * @num_tx_buf: total number of tx buffers - * @buf_size: size of one rx or tx buffer + * @rx_buf_size: size of one rx buffer + * @tx_buf_size: size of one tx buffer * @last_tx_buf: index of last tx buffer used * @bufs_dma: dma base addr of the buffers * @tx_lock: protects svq and tx_bufs, to allow concurrent senders. @@ -59,7 +61,8 @@ struct virtproc_info { void *rx_bufs, *tx_bufs; unsigned int num_rx_buf; unsigned int num_tx_buf; - unsigned int buf_size; + unsigned int rx_buf_size; + unsigned int tx_buf_size; int last_tx_buf; dma_addr_t bufs_dma; struct mutex tx_lock; @@ -68,9 +71,6 @@ struct virtproc_info { wait_queue_head_t sendq; }; =20 -/* The feature bitmap for virtio rpmsg */ -#define VIRTIO_RPMSG_F_NS 0 /* RP supports name service notifications */ - /** * struct rpmsg_hdr - common header for all rpmsg messages * @src: source address @@ -128,7 +128,7 @@ struct virtio_rpmsg_channel { * processor. */ #define MAX_RPMSG_NUM_BUFS (256) -#define MAX_RPMSG_BUF_SIZE (512) +#define DEFAULT_RPMSG_BUF_SIZE (512) =20 /* * Local addresses are dynamically allocated on-demand. @@ -443,7 +443,7 @@ static void *get_a_tx_buf(struct virtproc_info *vrp) =20 /* either pick the next unused tx buffer */ if (vrp->last_tx_buf < vrp->num_tx_buf) - ret =3D vrp->tx_bufs + vrp->buf_size * vrp->last_tx_buf++; + ret =3D vrp->tx_bufs + vrp->tx_buf_size * vrp->last_tx_buf++; /* or recycle a used one */ else ret =3D virtqueue_get_buf(vrp->svq, &len); @@ -513,7 +513,7 @@ static int rpmsg_send_offchannel_raw(struct rpmsg_devic= e *rpdev, * messaging), or to improve the buffer allocator, to support * variable-length buffer sizes. */ - if (len > vrp->buf_size - sizeof(struct rpmsg_hdr)) { + if (len > vrp->tx_buf_size - sizeof(struct rpmsg_hdr)) { dev_err(dev, "message is too big (%d)\n", len); return -EMSGSIZE; } @@ -646,7 +646,7 @@ static ssize_t virtio_rpmsg_get_mtu(struct rpmsg_endpoi= nt *ept) struct rpmsg_device *rpdev =3D ept->rpdev; struct virtio_rpmsg_channel *vch =3D to_virtio_rpmsg_channel(rpdev); =20 - return vch->vrp->buf_size - sizeof(struct rpmsg_hdr); + return vch->vrp->tx_buf_size - sizeof(struct rpmsg_hdr); } =20 static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev, @@ -672,7 +672,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp,= struct device *dev, * We currently use fixed-sized buffers, so trivially sanitize * the reported payload length. */ - if (len > vrp->buf_size || + if (len > vrp->rx_buf_size || msg_len > (len - sizeof(struct rpmsg_hdr))) { dev_warn(dev, "inbound msg too big: (%d, %d)\n", len, msg_len); return -EINVAL; @@ -705,7 +705,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp,= struct device *dev, dev_warn_ratelimited(dev, "msg received with no recipient\n"); =20 /* publish the real size of the buffer */ - rpmsg_sg_init(&sg, msg, vrp->buf_size); + rpmsg_sg_init(&sg, msg, vrp->rx_buf_size); =20 /* add the buffer back to the remote processor's virtqueue */ err =3D virtqueue_add_inbuf(vrp->rvq, &sg, 1, msg, GFP_KERNEL); @@ -809,6 +809,65 @@ static void rpmsg_virtio_del_ctrl_dev(struct rpmsg_dev= ice *rpdev_ctrl) device_unregister(&rpdev_ctrl->dev); } =20 +static int rpmsg_virtio_get_buf_size(struct virtproc_info *vrp) +{ + struct virtio_device *vdev; + u8 version; + u16 size; + + vdev =3D vrp->vdev; + + /* + * If VIRTIO_RPMSG_F_BUFSZ feature is supported, then configure buf + * size from virtio device config space from the resource table. + * If the feature is not supported, then assign default buf size. + */ + if (virtio_has_feature(vdev, VIRTIO_RPMSG_F_BUFSZ)) { + virtio_cread(vdev, struct virtio_rpmsg_config, + version, &version); + + /* for now we support only v1 */ + if (version !=3D RPMSG_VDEV_CONFIG_V1) { + dev_err(&vdev->dev, + "unsupported vdev config version %u\n", version); + return -EINVAL; + } + + /* size of the config space must match */ + virtio_cread(vdev, struct virtio_rpmsg_config, + size, &size); + if (size !=3D sizeof(struct virtio_rpmsg_config)) { + dev_err(&vdev->dev, "invalid size of vdev config %u\n", + size); + return -EINVAL; + } + + /* note: tx and rx are defined from remote view */ + virtio_cread(vdev, struct virtio_rpmsg_config, + txbuf_size, &vrp->rx_buf_size); + virtio_cread(vdev, struct virtio_rpmsg_config, + rxbuf_size, &vrp->tx_buf_size); + + /* The buffers must hold at least the rpmsg header */ + if (vrp->rx_buf_size < sizeof(struct rpmsg_hdr) || + vrp->tx_buf_size < sizeof(struct rpmsg_hdr)) { + dev_err(&vdev->dev, + "bad vdev config: rx buf sz =3D %u, tx buf sz =3D %u\n", + vrp->rx_buf_size, vrp->tx_buf_size); + return -EINVAL; + } + + dev_dbg(&vdev->dev, + "vdev config: ver=3D%u, rx sz =3D 0x%x, tx sz =3D 0x%x\n", + version, vrp->rx_buf_size, vrp->tx_buf_size); + } else { + vrp->rx_buf_size =3D DEFAULT_RPMSG_BUF_SIZE; + vrp->tx_buf_size =3D DEFAULT_RPMSG_BUF_SIZE; + } + + return 0; +} + static int rpmsg_probe(struct virtio_device *vdev) { struct virtqueue_info vqs_info[] =3D { @@ -854,9 +913,12 @@ static int rpmsg_probe(struct virtio_device *vdev) else vrp->num_tx_buf =3D MAX_RPMSG_NUM_BUFS; =20 - vrp->buf_size =3D MAX_RPMSG_BUF_SIZE; + err =3D rpmsg_virtio_get_buf_size(vrp); + if (err) + goto vqs_del; =20 - total_buf_space =3D (vrp->num_rx_buf + vrp->num_tx_buf) * vrp->buf_size; + total_buf_space =3D (vrp->num_rx_buf * vrp->rx_buf_size) + + (vrp->num_tx_buf * vrp->tx_buf_size); =20 /* allocate coherent memory for the buffers */ bufs_va =3D dma_alloc_coherent(vdev->dev.parent, @@ -873,15 +935,14 @@ static int rpmsg_probe(struct virtio_device *vdev) /* first part of the buffers is dedicated for RX */ vrp->rx_bufs =3D bufs_va; =20 - /* and second part is dedicated for TX */ - vrp->tx_bufs =3D bufs_va + vrp->num_rx_buf * vrp->buf_size; + vrp->tx_bufs =3D bufs_va + (vrp->num_rx_buf * vrp->rx_buf_size); =20 /* set up the receive buffers */ for (i =3D 0; i < vrp->num_rx_buf; i++) { struct scatterlist sg; - void *cpu_addr =3D vrp->rx_bufs + i * vrp->buf_size; + void *cpu_addr =3D vrp->rx_bufs + i * vrp->rx_buf_size; =20 - rpmsg_sg_init(&sg, cpu_addr, vrp->buf_size); + rpmsg_sg_init(&sg, cpu_addr, vrp->rx_buf_size); =20 err =3D virtqueue_add_inbuf(vrp->rvq, &sg, 1, cpu_addr, GFP_KERNEL); @@ -964,8 +1025,8 @@ static int rpmsg_remove_device(struct device *dev, voi= d *data) static void rpmsg_remove(struct virtio_device *vdev) { struct virtproc_info *vrp =3D vdev->priv; - unsigned int num_bufs =3D vrp->num_rx_buf + vrp->num_tx_buf; - size_t total_buf_space =3D num_bufs * vrp->buf_size; + size_t total_buf_space =3D (vrp->num_rx_buf * vrp->rx_buf_size) + + (vrp->num_tx_buf * vrp->tx_buf_size); int ret; =20 virtio_reset_device(vdev); @@ -991,6 +1052,7 @@ static struct virtio_device_id id_table[] =3D { =20 static unsigned int features[] =3D { VIRTIO_RPMSG_F_NS, + VIRTIO_RPMSG_F_BUFSZ, }; =20 static struct virtio_driver virtio_ipc_driver =3D { diff --git a/include/linux/rpmsg/virtio_rpmsg.h b/include/linux/rpmsg/virti= o_rpmsg.h new file mode 100644 index 000000000000..0872cbca4593 --- /dev/null +++ b/include/linux/rpmsg/virtio_rpmsg.h @@ -0,0 +1,41 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) Pinecone Inc. 2019 + * Copyright (C) Xiang Xiao + * Copyright (C) Advanced Micro Devices, Inc. 2026 + */ + +#ifndef _LINUX_VIRTIO_RPMSG_H +#define _LINUX_VIRTIO_RPMSG_H + +#include +#include + +/* The feature bitmap for virtio rpmsg */ +#define VIRTIO_RPMSG_F_NS 0 /* RP supports name service notifications */ +#define VIRTIO_RPMSG_F_BUFSZ 1 /* RP advertises RX/TX buffer sizes from co= nfig space */ + +/* Version of struct virtio_rpmsg_config understood by this driver */ +#define RPMSG_VDEV_CONFIG_V1 1 + +/** + * struct virtio_rpmsg_config - config space for rpmsg virtio device + * + * @version: version of this structure, currently %RPMSG_VDEV_CONFIG_V1. + * @size: size of this structure in bytes. + * @txbuf_size: Tx buf size from remote's view. For Linux this is rx buf s= ize. + * @rxbuf_size: Rx buf size from remote's view. For Linux this is tx buf s= ize. + * + * This is the configuration structure shared by the device and the driver, + * read when %VIRTIO_RPMSG_F_BUFSZ is negotiated. The fields are laid out = so + * the structure is naturally 32-bit aligned. + */ +struct virtio_rpmsg_config { + u8 version; + __virtio16 size; + /* The tx/rx individual buffer size (if VIRTIO_RPMSG_F_BUFSZ) */ + __virtio32 txbuf_size; + __virtio32 rxbuf_size; +} __packed; + +#endif /* _LINUX_VIRTIO_RPMSG_H */ --=20 2.43.0 From nobody Sat Sep 26 22:55:49 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011070.outbound.protection.outlook.com [40.93.194.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A8BF47253F; Fri, 28 Aug 2026 14:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929169; cv=fail; b=auFYSDPhUidb7a9d3FHw7/OvSC/wObOtV3URihy1iTxDCXbR5J+BD9uxBV8M253B22LUnLnHncEspjgeuMUid+PLOOPlsjwLKJ0QYyjK3CyhyFRc2d7UvYfjjkdyMcL+0HdLSauyvVZvf/FIRgiqKrAy2vKBxuHlu7+xMeP6aMo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929169; c=relaxed/simple; bh=U1O26ixsqg6TDetP9Hl7DD7ZBLCFDgdcPZ8iFREw464=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Mi4pPk6rACU85hr3UErMP9x6/tRP3pHG2ffeobYeRBPHL67Z3EPUi7RkGJJa+JZfkWPuHXqi6u/4S1wtgVP73vnj5MTcHCxxicU/XEJZQ1qmEd+ny1Y7VdriLNtuYcpHuCPjM8G6uYz0GNqx9BwpD23cjLNTVAxwI/iEzVXtuCo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=FYARygvf; arc=fail smtp.client-ip=40.93.194.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="FYARygvf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=skEZxc1RLRsCeCBEYq9U1PSU/yF7LG8s2Iio4bZcjaHpvjAoRATZwSRrBlEqmw+cixKbQtLES4dPY7ua21DkIEmOnAvMYca/kQ8pV3d0FYAvJ9+rFQR/eS5mGJsVAN3TUAMmzUY4DVUdxzZCOviFTT6ld7OftTb824v9cVCFWlY8uHwqE5BveO5KNqyY52Qm829DMqWubOH7usVg191xZY2d7nU3h3vFFvcgGSFUvs1dqY+JjSGPVPvvg7lTKPVJK195UFz80kHohke4ubKBpovzOCOuHYoyDG08xbR4MAetM/Pkshv+IgtnU/1f3K5ua3SX5SjWZkzVKctIS7rBXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=89+MCQ8UbC+6cm7ZhEfY8zA60AxMBDyWTwdMwYzwipc=; b=tR61jB0LunXdYfGOa23dgBD4WNDKNyugiG7YZMoNCBvIsrOcOnAaKwakFfZPDaWA8UsBF3d+jz5/s1H9MZBF27LgVD9jgGJgeB0XsOi8rgGAxu3/IQkDFqsozZCpoy6GGGTS8jnyJ95zO+T2MqU5uy/t+FdQE1EXA8NXAt7+R8+fNUgoPE2txoSp4di81NhyxDH60onasSJjWoLBvXYNY552pc5vtaSPx8sUtVyKY1nHzwyRIYtdz344rhnAIgJEIapp2vgibhEW0hZU53Wc4shbxU5riRndltpd9bjLpfWubHhyfnInMkyxclu03qy2HNzw8w5mZVUm00VCgCQX7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89+MCQ8UbC+6cm7ZhEfY8zA60AxMBDyWTwdMwYzwipc=; b=FYARygvf36VAPo3dFwfvZs19OfJivrTPF9PO/eydAfcZGYdO3bXhuyc0GZIQmVbFNEvTPAuxAP7v0KvBzNeOuHS9Zb6juwlFSQO2cr4XOxSN3tjWe/DT1jq7WzL0jDFUtCMSE672zNoP7ji68F98jZLapQCWcfebzKwC6oNsLxo= Received: from BN9P221CA0001.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::16) by DS5PPF78FC67EBA.namprd12.prod.outlook.com (2603:10b6:f:fc00::655) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.7; Fri, 28 Aug 2026 14:59:18 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:408:10a:cafe::7e) by BN9P221CA0001.outlook.office365.com (2603:10b6:408:10a::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.11 via Frontend Transport; Fri, 28 Aug 2026 14:59:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 28 Aug 2026 14:59:18 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 28 Aug 2026 09:59:14 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Fri, 28 Aug 2026 09:59:14 -0500 From: Tanmay Shah To: , , , CC: , , , Tanmay Shah Subject: [PATCH v8 4/5] docs: rpmsg: add virtio config space details Date: Fri, 28 Aug 2026 07:58:51 -0700 Message-ID: <20260828145853.2843486-5-tanmay.shah@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828145853.2843486-1-tanmay.shah@amd.com> References: <20260828145853.2843486-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|DS5PPF78FC67EBA:EE_ X-MS-Office365-Filtering-Correlation-Id: b93e83f6-f2e5-4a6f-fefd-08df0514ef47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|82310400026|36860700016|376014|10067099003|11063799006|56012099006|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: wKppawuV04yGF/u/IX6kx4msKdhHHyXRlekFN4fddg5RFnCJSLjySHWr5Ay6k779ZdZr2PDTEg6mqHRxRkL/SxlQiFm6RL83VvqUlIMBmKHOyuUB6lZPU/g4EgjlKI2sAC0E43yb56pVo3CfidW4Toa0jJvM1+Gbn1a5zztq631Os3asKPhgOdbg3pBxkHowPIf+9AK0rUbxBUu6aRacNileCZdN+qiM3jHpnkykpZHoI6ju6DSi7OLCxqCv3o9wCkRCXTQDnEeJ9MPt002wHlF1giJGeQTgDTZFLrS/91jPST1nrycPcKXD5+fE0j4GvAUwAD5ekM0qvUWI+nOxbougCfn2Loj+BSbKbCfzuT0Cs3rz5oT6uHDr35rcvYUknW+Ikg2f9p6CmdQrLDxKuwHA5ikGlq/ZFNCmFmpfan8zpGA+vkw9JOwFWsyPYj0E1dK+8Q7i+ZPMFnfNwDopyRgSp/LNIFP24GKD898zo9Vke5VpVVwHgpD9Zlri81HAfgJzF2qRUx5bjQfQqA4ZXY2zgarB26w68c4cdAX7t1HytpmxCc9WHc/Ot6Cyj0JQo6d/axLZN0jI0hvGPH1HFec0E9Y2YiHaiiqNclF9LAoQigL3lZWsIOXc7Je8hmB1R0EhGNNnzok2tOToSI6lTS08hxrFMq35VOkNU5HntdyaXe3WcTg+qeYd8nC93fylyiVSg92GOAtwCpWzuywA7g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(82310400026)(36860700016)(376014)(10067099003)(11063799006)(56012099006)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3sCqZd1BFIRxeY0eZKRaj8kcxRodFUoAgYfninOKt2tny2/Ajx92lK6JtkzKNxOlpTYJw6Lyg/gR0e2wK0JWlYmXZidWSP79Ac30LAQYAQEYQTv+yhlw3/Sni51NVmfRO0pEroRyN6QyMPbk+QghUvb+TsMcqpnzC+Nijo2bz1duTwyFqk9Ulg1aDqGytoJZY10s4FX4z0nK6cWls+dfEcUvQ1W1jv0MlBgnDACMsqqFHeAjX5siZpzYkDT1ev5x1tJ3t+mSLAUrs39Npp2UvTVG4J2CkQ6AjK0lnswkj3vwS+3opWmuWh7nc+UoHYqUoYT/yVJNH+f18gsk6uHFMsK9zkScwgo3MCUfybHTFydFWtvvYcLr8G+5C6TmWiR00hcsRKc0EJqeBqM7BbHhfddRB//YkzDMJLIqR2WlKTBkGRt+qNFPYGNVY/hOUzHV X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2026 14:59:18.1501 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b93e83f6-f2e5-4a6f-fefd-08df0514ef47 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS5PPF78FC67EBA Content-Type: text/plain; charset="utf-8" The virtio config space can provide single rpmsg buffer size in each direction. Document details of the configurable buffer size via virtio config space. Signed-off-by: Tanmay Shah Acked-by: Arnaud Pouliquen --- Changes in v8: - "%s/or differnt RX and TX sizes)/or different RX and TX queue sizes)/" Changes in v6: - rpmsg.rst: modify alignment related documentation Changes in v5: - fix documentation of buffer alignment Documentation/staging/rpmsg.rst | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/Documentation/staging/rpmsg.rst b/Documentation/staging/rpmsg.= rst index 63612b7ee120..d711d1643bab 100644 --- a/Documentation/staging/rpmsg.rst +++ b/Documentation/staging/rpmsg.rst @@ -299,3 +299,20 @@ by the bus, and can then start sending messages to the= remote service. =20 The plan is also to add static creation of rpmsg channels via the virtio config space, but it's not implemented yet. + +Configurable buffer sizes +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D + +By default each rpmsg buffer is 512 bytes, and the same size is used for b= oth +the receive and transmit directions. Remote processors that need a differe= nt +size (for example a larger MTU, or different RX and TX queue sizes) can +advertise it through the virtio device config space by setting the +VIRTIO_RPMSG_F_BUFSZ feature bit. + +When this feature is negotiated, the driver reads struct virtio_rpmsg_conf= ig +from the config space. This structure provides the size of a single buffer= for +each direction (TX and RX). The device should advertise TX/RX buffer sizes +that already satisfy its own alignment constraints. + +If the feature is not negotiated, the default 512-byte buffers are used for +both directions. --=20 2.43.0 From nobody Sat Sep 26 22:55:49 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010063.outbound.protection.outlook.com [52.101.85.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC89F47254D; Fri, 28 Aug 2026 14:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929170; cv=fail; b=rjfcmGe8/WEM1AkYpSLWV0Ycwr4wK6D6HfAZ765P5iuhfVGlZXjpNpLScmCabEZnllX3qSMRiPTraZhs3S3DGGxDoATFvQ1726dGcJE5yx37lng6ppZlXnnrL+XZZKwRFhemc4bxmNTWAjonHLKQaWyMdhlAu5gKAiLqW1A5Zn4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787929170; c=relaxed/simple; bh=6FSaRj4736or+Zf8/4PcIrsZ2LP6BCg2fP7s+siedfY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d+Eh29xDdnbjp0jwPHmBFmsaeLqbuO0r15Yl/HaRdJCOz2rXj/BbOWboki3REFCYK04nPDFflyogNiTuq+/5FYKVTakRcmHldG0bn5xAAC1DER8FRwLzM6wBbUvrbA4GKZjJew5rCp5CjbVfhBNeH9YZ2ElENuVT6s+qKWTvfW0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=xjCFvRzq; arc=fail smtp.client-ip=52.101.85.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="xjCFvRzq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MTrsI+/uRpMYAs8swx6wNpLmPMiuiqoZU5oV0Jdg+5dwpoylogYx1EW+CWHmxn7Tsj4BB3iXnRDpym0canLqAUJdjQgcNqHOcO3OSXkyLWFRNyaUm/ymyGE+sMUZpW75+MDrYvr4FQStDGzD1O2KBUQvSlc+GaXKV3EHq9oak0zCz6bID1XwTJOF2mEfUimZT9VpNYWTBI5bMaFiXFZK34qp3C3JokWmD7ARbwppgiuDrbn3Tc8H9V6j7iOXCTjViQlteknhAwKcJ66lGr2o8ezkjffxd0nt2GvWVEJA3cJY6wKsz5ja0n4gklP8/z23O2MP0sQ5U0O3QnhRQgmOIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4J769HliW4fxBV194xJirW2tOnrEtylKNpQmkp74aF4=; b=apRABBaDup0Y9GbXCMu6hR6gXVotrqiwmW5yjWNTP+kKcXhdDbBYR572YWcd+hDXZDtRnlD2TltdihSpLSkPeprgk3o9gV3BXWo1acjdM61DG0Zc1CnuE1aDl6vCc1l7jsGzVa7Xxetjdu24VlwYKdncWn/QmhBpsvyjEPfP+D76Q+q/PZYVMgzyFm23OYQmG+aXACq8xgj9z3AcyHKtqIqWVMY4sa1s3bn0JRAOHI9BTrNN2E79JQN1UEU0XjnssL5rzMVpd5FiWuqi23Y7x5SNIBUcg8u85XvYkKmhvbS9dSlmk3HCFLWFAkxaXH/txdUeOyyumzEsrRUws/J0QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4J769HliW4fxBV194xJirW2tOnrEtylKNpQmkp74aF4=; b=xjCFvRzqFJTro0F2pFzBcF4UqwVz+hrFfdu4RkKsnIlcxB5rehvU+iqjm/oRsISKiiJdvboiIx3Rcx+YDMMVcj12mXBMuarkcER/Pqs/xsgDbXQPs/DdsLdg+PomKvYSVumUTG9z6eom8/K/ZVKw7R/hys0lFooKnlpd5x2ifMM= Received: from BN9P221CA0023.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::11) by DS7PR12MB6310.namprd12.prod.outlook.com (2603:10b6:8:95::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.10; Fri, 28 Aug 2026 14:59:20 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:408:10a:cafe::25) by BN9P221CA0023.outlook.office365.com (2603:10b6:408:10a::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.8 via Frontend Transport; Fri, 28 Aug 2026 14:59:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Fri, 28 Aug 2026 14:59:19 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 28 Aug 2026 09:59:15 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Fri, 28 Aug 2026 09:59:15 -0500 From: Tanmay Shah To: , , , CC: , , , Tanmay Shah Subject: [PATCH v8 5/5] samples: rpmsg: add MTU size info Date: Fri, 28 Aug 2026 07:58:52 -0700 Message-ID: <20260828145853.2843486-6-tanmay.shah@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828145853.2843486-1-tanmay.shah@amd.com> References: <20260828145853.2843486-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|DS7PR12MB6310:EE_ X-MS-Office365-Filtering-Correlation-Id: af4d636c-c393-4bf4-30c4-08df0514f058 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|82310400026|36860700016|1800799024|22082099003|56012099006|10067099003|11063799006|18002099003; X-Microsoft-Antispam-Message-Info: YzHWGKvxLLaEKhUJHxHsMIT2O0/sk5fWSm00snKPLzyTIGH9aUgZdimRFfrGgvNkRS+p+AbLNpcS4jpEFWWd7GllYXKJ9f9nz+whBsyH/o96BNnHfcKfW4keCol0MZIWrEKuOWqHwWKl7OKWgZHPukpR5OQCLGuEAlfhAQ/Aw7fszDsq3HPoEszSDo/u58aU00E4LnGVVsmp93ks/G9P7SE4ETxwd0sTmu76xGJ0tOzeirUktf96CQ9b5cCmnUrnJrX9ZWbSafZ6ighNfoknBH02waE2Ujcu5I5/AIPLI27x/gmU4rgzHsZDRD1ExXdLoKaPcw5c+MqWmHciDpal3szJzyzE4JWzXDzmQ2NdHNMg2k+MbNcgeuGFkdQZA3oWJa5/Dk5i3SJPBokg5zSy7gvE99KZer1uak0qJMUrB35XXVjDKD0qrXa7B5gXZcy2CWyUL3H9QweOOT3gE1JhV8se8h1NP/qmhRcd9T+YXkfk1rh80KE6eLeofBUvlg7OC7OfNurzzInZl1DDKLMAfq4tDdqCuQ9h9i7jechXdZW8XP4CQyxsfy0Wa2q1KZmoaH+eS6yDiAOcQBpBHSAqm7QZjulj52g4Nyw5HZFqVPe2+ic2/rmSiVdV9wnuKLbPimFSmPblKQ1dps+33e4BY1ay/B5pIETWEFUrV8+D/unAnvp65rfCwpEyXHbvxs0SEyk0R7Zriz7XXgF4NaMEiA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(82310400026)(36860700016)(1800799024)(22082099003)(56012099006)(10067099003)(11063799006)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: SYEa0z6NLS/XI+q7m70mLAZ9wAMFbJqjSeE31teDAPqZgRdPVi1UUD9katlo7+DtUGXBoj58naeeQ2pc5JA4URE5FGlStgl414tOVOvOfb0D1GO0vzNnq4rDzYChhtjczcYv/JSbUMP491CO3nrAqg4nobiixQbD4/XI7MhUhBQu5nHWgWvy0OC+f+xU1IEjsxqFFE8H3lyaQoj80rGrZPrBasjH4ZS5jjg4U2EXex8AOCKNwnkXpHCTY30CVe+Dl1YC/CCg4JqzR2GCEZHSLoFvUiodRnGTiBgkNGYJphjd2n9glG21gy+JOUpBm9jW8db4vFja5j40h3aSbZoToF1ZWXe3dk0qen58iLe5c3pw7LAX3Q1Gwy93LkWImW/Ie0xHWBdguYjOfUpnPfiR+u8u6Y2f2e+I5siONBkJN0Y+1sxNgcCv8+8c/eLIY82S X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2026 14:59:19.9342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af4d636c-c393-4bf4-30c4-08df0514f058 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6310 Content-Type: text/plain; charset="utf-8" RPMsg MTU size can be variable now and no longer hardcoded to 512 bytes. Add log to the sample driver that prints current MTU size of the rpmsg buffer. Signed-off-by: Tanmay Shah Acked-by: Arnaud Pouliquen --- Changes in v4: - check msg size is < MTU size Changes in v3: - Check for error when retrieving MTU size - %s/mtu/MTU/ samples/rpmsg/rpmsg_client_sample.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/samples/rpmsg/rpmsg_client_sample.c b/samples/rpmsg/rpmsg_clie= nt_sample.c index ae5081662283..4c43436aadb6 100644 --- a/samples/rpmsg/rpmsg_client_sample.c +++ b/samples/rpmsg/rpmsg_client_sample.c @@ -52,6 +52,7 @@ static int rpmsg_sample_probe(struct rpmsg_device *rpdev) { int ret; struct instance_data *idata; + ssize_t mtu, msg_len; =20 dev_info(&rpdev->dev, "new channel: 0x%x -> 0x%x!\n", rpdev->src, rpdev->dst); @@ -62,8 +63,25 @@ static int rpmsg_sample_probe(struct rpmsg_device *rpdev) =20 dev_set_drvdata(&rpdev->dev, idata); =20 + mtu =3D rpmsg_get_mtu(rpdev->ept); + if (mtu < 0) { + dev_warn(&rpdev->dev, "invalid rpmsg MTU size =3D %ld\n", mtu); + return mtu; + } + + dev_info(&rpdev->dev, "rpmsg MTU size =3D %ld\n", mtu); + + msg_len =3D strlen(MSG); + /* make sure our message fits in a single rpmsg buffer */ + if (msg_len > mtu) { + dev_err(&rpdev->dev, + "message size %zu exceeds rpmsg MTU size %ld\n", + strlen(MSG), mtu); + return -EMSGSIZE; + } + /* send a message to our remote processor */ - ret =3D rpmsg_send(rpdev->ept, MSG, strlen(MSG)); + ret =3D rpmsg_send(rpdev->ept, MSG, msg_len); if (ret) { dev_err(&rpdev->dev, "rpmsg_send failed: %d\n", ret); return ret; --=20 2.43.0