From nobody Sat Sep 26 23:53:36 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FCCA3F1048 for ; Fri, 28 Aug 2026 09:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787908046; cv=none; b=OGcAfSoaSd1CUGSqtbInZCJ/4eawviY2c/JcUtOAWIWefxSPyigjBoIUS4mlsts4/fO78tBMcZ4Ja44zAPW/LSYYltetIkbBK8OPXEi5kq2taRbgxpLI4j1yDxFgOxZC2xt/CRCqx3drJo82Pesj1TkE8wxXqD3LTlTrdo7SkmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787908046; c=relaxed/simple; bh=xVxY45sxyo2kZ1v8r74VlABGlXYg2ltKQ96hThjr30U=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=PZmETu1m0WVuyjGBZa+WQYPuiAYeZ4w/r9kx24nGc/G5lPQIu9srKaUQZnt47+nmZEK5Kl/X9eTO3CBZ6vFoHHo9bnjgPih1FI52MsPeHjWjIhBDO1Ri3IT0HPUB1ge3a2SR0cBflLcAnKrhI/XQZXXKKwSHdNjdkWWK2n1bCik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=ep2Ot8PB; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="ep2Ot8PB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=1n fvSbyXaygGDA9i7aXU+p5NHnBngMiGbJBtvILo9no=; b=ep2Ot8PBv4cG1dA+XG EW/ww9dNvYTLLGRNbuayPsG/f2D8i964U7XfOQYx7oNErd8Sgu1hxBmSUkPQxqxL WAPpIEJd3aujYYO+8H1Hs2MldsKJjtA+OcYGB9Xc4TfxvVr8E/cmoTv93yUOuElS uSVUzo9IrUhsFIH5jbS6AanHI= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wDnj3CLT5Fq7b3+SQ--.22427S2; Fri, 28 Aug 2026 17:06:19 +0800 (CST) From: oushixiong1025@163.com To: David Airlie Cc: Gerd Hoffmann , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Shixiong Ou , Ye Liu Subject: [PATCH] drm/qxl: Add pixel blend mode property Date: Fri, 28 Aug 2026 17:06:08 +0800 Message-Id: <20260828090608.792944-1-oushixiong1025@163.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnj3CLT5Fq7b3+SQ--.22427S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WFyUXFWDCF4DJF17tF1UKFg_yoW5Jr1rpa y3CFWYyrW5Ja13Jay7Arya9rsxXan3Ka48Cry3t3s7Zw1jyrykAr10kr1I9rW5AaykGa1f Xas7GFWDCF4UCw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j8pnQUUUUU= X-CM-SenderInfo: xrxvxxx0lr0wirqskqqrwthudrp/xtbC-Qv0BGqRT4vpewAA3r Content-Type: text/plain; charset="utf-8" From: Shixiong Ou The qxl primary and cursor planes expose formats with an alpha channel but do not create the pixel blend mode property. Since commit 860e748bddcc ("drm: ensure blend mode supported if pixel format with alpha exposed") this triggers a warning during drm_mode_config_validate(): [ 4.252654] ------------[ cut here ]------------ [ 4.252676] [PLANE:38:plane-0] pixel format with alpha exposed but blend= mode not setup [ 4.252719] WARNING: drivers/gpu/drm/drm_mode_config.c:872 at drm_mode_c= onfig_validate ...... [ 4.253089] Call trace: [ 4.253091] drm_mode_config_validate+0x398/0x558 [drm] (P) [ 4.253177] drm_dev_register+0x1cc/0x2a0 [drm] [ 4.253262] qxl_pci_probe+0x120/0x1e0 [qxl] [ 4.253277] local_pci_probe+0x48/0xb8 [ 4.253287] pci_call_probe+0x70/0x190 ...... Blending is done by the host with premultiplied alpha, so create the property with DRM_MODE_BLEND_PREMULTI as the only supported mode. Reported-by: Ye Liu Signed-off-by: Shixiong Ou --- drivers/gpu/drm/qxl/qxl_display.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_di= splay.c index 7f4178800afd..8193d08485f2 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -991,13 +992,25 @@ static struct drm_plane *qxl_create_plane(struct qxl_= device *qdev, if (err) goto free_plane; =20 + /* + * Both planes expose formats with an alpha channel. Blending is + * done by the host with premultiplied alpha, which is also the + * property's default value. + */ + err =3D drm_plane_create_blend_mode_property(plane, + BIT(DRM_MODE_BLEND_PREMULTI)); + if (err) { + drm_plane_cleanup(plane); + goto free_plane; + } + drm_plane_helper_add(plane, helper_funcs); =20 return plane; =20 free_plane: kfree(plane); - return ERR_PTR(-EINVAL); + return ERR_PTR(err); } =20 static int qdev_crtc_init(struct drm_device *dev, int crtc_id) --=20 2.25.1 No virus found Checked by Hillstone Network AntiVirus